labofsahil/github-event-dataset-2012 huggingface dataset:
I am not so sure about this commit.  What if you surf into the firewall remotely and it trys to redirect to a hostname that is only available internally?
From a760e1a78cd69ea799943e7a6873c3975c18e2e0, which I believe originated in @Lynx3d's vmap3 dev branch
WTF J-DUBS I LIEK TYPOS!
I would use a different predicate.  Checking that the version is non-null is a very roundabout way of saying "does the status node exist?".  I'd add a predicate to ask "does this node exist" to Util.

also, the version should be an int not an Integer.
do you care about non-firefox browsers? if so, use our `.box-shadow` mixin
> We don't want facter's PATH and RUBYLIB to include puppet right?
>

We do want this otherwise facter --puppet and facter puppetversion
don't work out of the box.  I do this for UX reasons.
Bit of extra space here.
In my opinion the usage of the `required` attribute should be configurable, not forced by the framework. Even when you're using HTML5.

Also, this code implies that if you set the required flag to false after setting it to true, it would leave the `required` attribute in place.
DOPE SHOW
some of the private methods below could be refactored to a general util object so as to avoid duplicates in the future. I believe I have seen some of it before already.
in English if updated the vip user system
To address whirr preference :)
I will fix the gitignore file.

On 17/01/2012 18:16, amarillion wrote:
> I'd like to drop this patch and just pull the other patches, but there doesn't seem to be an easy way to do this? I'll look further, suggestions on how to do this are welcome.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openphacts/BridgeDb/commit/3780e949a4e03d47516f20829004862dde1444a7#commitcomment-875018
>
>
> -----
> No virus found in this message.
> Checked by AVG - www.avg.com
> Version: 2012.0.1901 / Virus Database: 2109/4748 - Release Date: 01/17/12


-- 
Christian Brenninkmeijer
Department of Computer Science
University of Manchester
this is too late, and hence useless
Can you maybe replace this with something that explains why this function exists / what led to it being created?
Ah, forgot to remove it.  I used it to test the updated ObjectStore/FileStore interfaces before implementing the leveldb one.
There is no limit here. The origininal query uses db_query_range on purpose to cater huge taxonomy sets.
Type Belar
There is only one item, but suggestions' box height can feet 4 items.
Also I see scroll disabled. Do we need to show it users?
This seems to be a bug in git. I really did not chang this line and tried in vim, nano and gedit. Then I cherry-picked a commit that only contained the change above to the master branch. It did not work. Sorry. You have to live with this ugly diff.
Thanks for re-testing on latest. I see the issue you're talking about now, that is helpful. This looks like a server-side error so is this an issue on that side?
Not exactly, the goal is to make this variable only mean one thing: the name of the macro. It's just take several steps to go there.
Batch File/ROM dir for Pac-Man (Midway)
subjectId should be removed because it's no longer necessary. facebookId is sufficient.
is the `typeof userExercise` checking for testMode or is this a situation that shouldn't be happening (i.e. somehow userExercise got mangled)
What the heck is going on with this file?
I would not know where ``alpha_c1_1`` would be stored. What ``dual_coef_`` contains is definitely ``alpha_1_vs_2_i``.
They are stored in such a way that it is not trivially possible to compute ``alpha_c1_1``. See my other comment....
Is there a reason to not expose the CookieJar type?
I think d42eec97756 is the commit that caused this. It's @ahocevar's commit but @elemoine did the review and merge :-)
Something we may need to consider here is whether state should be *immediately* pushed through to the server, at least if the state is stored in-session.  A particular use-case would be pressing Command-R after changing pages.
is `gsub` really necessary? a normal `value.replace(...)` and a regexp with a `g` flag will do.
Yes it's terrible and not recommanded, but at the moment it's the only option, until we support external configuration.
Actually, event listeners should not be lost by doing this. The real problem lies in the event delegation inside the tag plugin. I can have a look at this later this month.
That seems nice, it's a good idea to have all ports in the same repository.

About Alien 3, it still works fine on my side so either it's something wrong in the PS3 back-end (ROM loading) or a bad dump. I'd check with verified ROM dump (no-intro) to be sure first.
and arrays
I put it in so that they could be viewed in the browser.  We can remove it if you don't think we will want to see what they look like.
theres anywhere a custom table implementation for that... in our project weve addeed it already
Wait, kandera is a girl?
whats this for ?
The collision for their gameobjects should work @Expecto
what's the relationship between http://www.51qiangda.com and http://www.thundersurvey.com?
I'm not sure why it was here. But it does not work with YouTube.
> I bet @agramfort's brains are very noisy :)

noisy and messy :)
It's 92283.You might want to modify this before testing ingame,92284 is some phasing spell.
http://troll.me/images/futurama-fry/cant-tell-if-trolling-or-completely-lack-sense-of-humor.jpg
Today we do: `input + label` in the boolean input. Maybe we can support a configuration option that wraps the input inside the label instead. People shouldn't need to do f.input :options, :wrapper => :checkbox.
Glad to see you here.
You're right ! after some tests, it seems that "sopa" is not a good value ! I'll revert it now !
I think people can deduce that from the items in parenthesis. I didn't want to include it in the git command so as to avoid confusion. Should I change it to 'git commit -m "This commit closes/fixes/refs #1234" ?

Is xxx confusing?
'Firefox Flicks - ' needs to be outside of the block here. Also, if possible, we should remove the dash and use CSS to reverse the order of the block, dash, and 'Firefox Flicks' depending on if the page is ltr or rtl. Then we won't need an extra string for this and other occurances of Firefox Flicks.
tags.Any() ?

LINQ is in use elsewhere.
A change is occuring to the package after the hash is generated. WebMatrix Client gives the same error that files cannot be verified. I also used a tool to generate sha512 and found a different hash to the one in the feed
I'm not convinced jfile is the correct place for this code - because of the call to getConfigurationDirectory.
I think this should probably move to jutil.  (Or split this in two - with a 

queryTempfilePath(StringBuffer & target, const char * component);

function in jfile (the code inside the if (!dir.length()), which is then called from the function in jtuil.
>target now seems to be required by ndk
WTF? Really? In which universe? Can't build the mixed-java-and-native project because of this commit.

here part of maven log:

--- android-maven-plugin:3.1.1:ndk-build (default-cli) @ myproject ---
[INFO] /home/folk/android-sdks/android-ndk-r7/ndk-build [-C, /home/folk/projects/myproject/, myproject]
[INFO] make: *** No rule to make target `myproject'.  Stop.

I have NDK r7
Насколько старых версиях?
Operation: Shaddup! lol
great now i got rid of my previous error but get

```sh
make install
[sudo] password for cordoval: 
if test -n ""; \
	then install_name_tool -change `otool -L ./phraseanet_indexer |cut -f1 -d" "|grep libmysql` /libmysqlclient.dylib ./phraseanet_indexer; \
	fi;
```
Usually this is bad practice and sign of bad programming choice.
could you switch to use the more common '/' character for the regex pattern?
It's good to validate if it's valid email too.
Android doesn't use cgroups does it ?
This line is throwing an error. 

```javavascript
// knockout-deferred-updates.js:234
// Uncaught TypeError: Object function
dependentObservable() {
        if (arguments.length > 0) {
            set.apply(dependentObservable, arguments);
        } else {
            return get();
        }
    } has no method 'notifySubscribers'
```
I'm having a hard time reproducing it in jsfiddle, but I can't figure out why it would break my app. I'm including deferred-updates after knockout-2.0.0 just as I did before this change. Any ideas what's going on? 

Here's the full stacktrace from Chrome if you're interested:
https://gist.github.com/1927694
`HayakuAddCodeBlockContext` на всякий случай добавь в `__all__`.
Is it possible to add `file` binary to busybox?
Alright. I already do call the gsm.mk ;) (http://review.cyanogenmod.com/#patch,sidebyside,11922,2,products/cyanogen_chacha.mk).
Yeah sure, i can do that this weekend
check the commit done later: I changed it once merged
last.fm always returns two songs by the same artist before returning similar tracks by different artists. So, for this call, I try to get the 3rd-5th entries, and poorly crash out of the loop if last.fm doesn't give me 5 similar songs.
Why did you remove the VDD fix ?
https://github.com/DooMLoRD/Xperia-2011-Kernel-2.6.32.9/commit/cdda2cdf82ce35ccd0432b1a0cbc4a59b821fe3a#kernel/arch/arm/mach-msm/acpuclock-7x30.c
I see tabs and spaces to indentation in this file. It's a bad approach to mix indentation styles.
Redundant comments between function arguments.
Generally, you'll want to list your storage objects or lexical scope globals at the top of said scope. In this context your `parser` and `data` objects should be listed and noted at the top of this function (right below "defineTask"). Otherwise... they get a little hard to find.
No purpose, I just cargoculted these two new test packages with `cp -r tests/packages/FSPkg` -- these `setup.cfg` files can safely be removed I think.
Since this is a `Y.UA` sniff, we should have a code comment for why, ideally linking off to some resource or bug report online.
`@param` tags require a type and a parameter name, not just type and description. Also, do you think you could format your doc comments to match the formatting of the other doc comments in array-extras.js? I worked hard to keep them consistent. :)
Is this to support solves in opencl?  I'm not sure I like it, should it not go in opencl.py instead?
Ok, so ActorSystem has a non-implicit `dispatcher` but an implicit conversion to `MessageDispatcher` while ActorContext has an implicit `dispatcher` but no implicit conversion. Assuming that this was done for a reason and makes sense the way it is, would the best solution for `ActorRefFactory` really be to follow the model of its ActorContext child? I.e. simply have an implicit dispatcher and no implicit conversion?
: Int
making this a `lazy val` would be a bit nicer
didn’t we like `Actor.noSender` better?
`protected[akka]` is weaker than `protected`, so what are you saying? Subclassing applies to ActorSystem or ActorCell, so I don’t see a problem which emerges from this line.
You don’t, would be my suggestion. The name mangling code is currently confined to one single method and it should stay that way.

Wrt. replacing or not I don’t see the issue: the old and new entries will have to be identical anyway.

For your devilish scenario the only solution I see would be manual ref-counting (i.e. keep an Int together with the value and remove the mapping once the last user goes away).
field tested?
According to Git, the minimum abbrev size is 4 (see [environment.c:17](https://github.com/git/git/blob/master/environment.c#L17)).
- boolean operator faster than function call?
None of the other models expose this interface (`peak_values`, `peak_indices`).  I'm not even sure peak indices make any sense, unless the user provides a sphere.
```
method : ('standard', 'deconv')
    Method used to ...
```

or similar
Is this referring to the float64 data-type?  The next line doesn't seem to have anything to do with casting or such.
General style for JS and the rest of this file is to keep the curly brace on the same line as the conditional.

```js
if (true) {
} else {
}
```
This is a good idea. I've added the configuration value and applied it to all consumer content tasks
It's "fum", not "foo".
on 9.8.2012 0:45 Andrew Chen wrote:
>>      <string name="account_setup_incoming_username_label">Käyttäjätunnus</string>
>>      <string name="account_setup_incoming_password_label">Salasana</string>
>>      <string name="account_setup_incoming_pop_server_label">POP3-palvelin</string>
>>      <string name="account_setup_incoming_imap_server_label">IMAP-palvelin</string>
>> -    <string name="account_setup_incoming_webdav_server_label">WebDAV (Exchange) palvelin</string>
>> +    <string name="account_setup_incoming_webdav_server_label">Exchange (Exchange) -palvelin</string>
>
> Er, this now says "Exchange (Exchange)" :)  I'm guessing you either want "WebDAV (Exchange)" or "Exchange (WebDAV)" -- whichever makes more sense in your locale.  Thanks!

Oops... Sorry for that. I must have been thinking something else. But 
anyway, this time it *should* be OK.
Is this allocation accounted for in estimating the size of the workspace? Is the number of these allocations bounded, e.g. by CONFIGURE_POSIX_KEYS? Or does it depend on more complicated factors?
I'd rewrite this as:


    ev.getCause match {
      case null => onException(ctx, new AkkaException("Unknown cause"))
      case _: ClosedChannelException ⇒ // Ignore
      case NonFatal(e)               ⇒ onException(ctx, ev)
      case e: Throwable              ⇒ throw e // Rethrow fatals
    }
Turns out I'm wrong, `&` has less precedence than `+`, so that is fine, although confusing I think.
The bug I thought was `("\xff"*16).unpack("Q*").inject(0) {|hash, n| hash + (n & 0xffffffffffffffff) } # => a number bigger than 2^64`.
Yes, this is a perfectly acceptable way to accomplish what I asked. That's how I would do it. But now that I see the test results, it seems to me the default should be `false` instead of `0`, and we should only apply any padding values if they are passed. So you could still pass `0em` in order to remove padding, but the default should not do anything to the padding.
There's still this statement hanging out on the same line as the brace.
This is probably unnecessary.
Needs to line up with arg 1.
fixed in 65c21e22
How does this change fit in with the rest?
You can remove the imports/globals comments.
pointPort не используется
I think @carlosantoniodasilva is talking about this `:id => false`
suggestion taken verbatim. Didn't notice any further ways to improve.
Yeah, I got it. But I didn't see the controller config `permit_all_parameters` being used anywhere, even though the config will propagate to the config, it is not propagated to the `Parameters` object, which seems to aways do `self.class.permit_all_parameters`. Did I miss anything?
But `recognize_path` now actually supports the Redirection module, so params may be a Rack::Request, in which case it has no method `with_indifferent_access`.
You're right, what do you think we should do in this case?  generate just ```params.require(:user)``` ?
I think you could use the new hash syntax here.
Emacs automatically adds this comment when the buffer contains non-ASCII characters. Since the code ran before the comment I figured the characters must be inside the comments.

I looked for the characters and noticed that the file contained non-breaking spaces. I added a separate commit to replace those with normal spaces. This also makes Emacs happy and  removes the "# -*- coding: utf-8 -*-" comment from the top.
I think it'd be interesting to also test with a custom pk name, wdyt?
Ok, i will revert  this :)
What about a flag with the path to a user-defined scaladoc config file? Say, written in JSON? It'd be straightforward to parse... What do you think?

I totally understand that you had to start somewhere, but I think that it'd be best if we could clean up this hardcoded object before 2.10 so it's easier for users to actually interact with all of Scaladoc's awesome (understatement) new features.

Also, we could possibly use Havoc's new config library since we're going to be including it in the build eventually anyway
Shouldn't isValueClass guard be lifted?
I'd say "isArtifact" is also far too generic; as a compiler hacker maybe it sounds specific, but this isn't even what artifact usually means.  How about isCompilerArtifact.
Isn't this more complicated than it has to be? Alternative would be to use something like

    return_onesided : bool, optional
        If True, return a one-sided spectrum for real data. If False, return a two-sided spectrum.
        Note that for complex data, the two-sided spectrum is always returned.
Use double backticks around conditions.
Space around ','.
You should propbably just use numpy for these?
On 12.06.2012 14:11, Sergiu Ivanov wrote:
>> +            return (self.name == g.name) and \
>> +                   (self.domain == g.domain) and \
>> +                   (self.codomain == g.codomain)
>> +        else:
>> +            # One of the morphisms is composed.  Compare the
>> +            # components.
>> +            for (self_component, g_component) in zip(self.components, g.components):
>> +                if self_component != g_component:
>> +                    return False
>> +            return True
>> +
>> +    def __ne__(self, g):
>> +        return not (self == g)
>> +
>> +    def __hash__(self):
>> +        return hash((self.name, self.domain, self.codomain))
>
> `Basic.hash` doesn't work nicely with anonymous morphisms (note the composite morphism `g * f`):
> ```
> In [20]: f = Morphism(A, B, "f"); g = Morphism(B, C, "g")
>
> In [21]: g * f == g * f
> Out[21]: True
>
> In [22]: hash(g * f) == hash(g * f)
> Out[22]: False
> ```
>
> That's because anonymous morphisms store instances of `Dummy`, just as it (now) happens in `Object`.  I can only use `Symbol`'s in `Morphism` at all times; in this case an explicit `__hash__` will not be necessary.  Do you think I should do that?
>

I suppose that's fine. Are you making it clear somewhere that the name 
of a morphisms has no relevance (other than for printing) for composite 
morphisms?
linelength > 80 ?
Tests for sure, but anyway, this change is misplaced and breaks symmetry of gcd functions in SymPy. At least is hould have been place in the core (the whole point of gcd() methods is to avoid such code in gcd() function). About symmetry:
why is this being deleted?
I'll delete the test, then.
No, actually it can be instructive to know why the special handling is required. Explain in the docstring why n= 1 and n=2 are edge cases.
Asking less generic names is good. I think that subs should be simultaneous by definition so I'd prefer `sim` not to be part of the name (it feels like renaming Elephants to "Big Elephants"). I'll think about this for a bit. Do you have other suggestions?
What is the default coordinate system? Is it taken from vector_field or start_point?
This looks like the culprit:

```
commit ca83169d42a2d4b2954b11caa29a62b4659066dc
Author: Chris Smith <smichr@gmail.com>
Date:   Mon Oct 22 09:11:30 2012 +0545

    test test-suite defs
    
    If a function in the test suite has no argument it is likely a function
    with assertions to be tested. But in order to be tested it has to start
    with the text 'test_'. A check is now made for this as part of code quality
    testing. If one desires to have an arg-less function, they should start
    it with an underscore. This requirement makes testing easier in that
    one does not have to parse the file to see if the function def has
    assertions in it.
```

With this commit, for files matching `test_*.py`, each lines are fgirst tested for the proper `def test_`, and then the file isn't rewinded before each lines are tested again for all the remaining code quality issues. I'll send a PR refactoring this.
You should've removed this, too.
Don't think that error and warning suppression (i.e. `@unlink(...)`) is really necessary here.
need an `@since 1.1.13` annotation here
I think the save() is supposed to persist the effect of the set method before it, which changes the original object, no the newly created association. I'm not sure the meaning of "create" and "build" is super clear though, specially the build method. If you are already persisting the new association model, why wouldn't you want to update the original object to point to it?
関係なかったです、、、
Extraneous parentheses.
Why this change too?  What was it about the old way (prior to the recent "before_validation" switch) that wasn't sufficient?
The multiple function parameter calls are quite hard to follow; but I don't have a good alternate solution at this point. At the very least, can we use named parameter assignment to make it clear which pieces are doing what?
commands like this don't need leading > 

make your collection names consistent and meaningful. 

records
Why this business instead of nil?
I would prefer $expr1 and $expr2.
f.parent_id isn't being used anywhere, so it probably doesn't need to be selected.
Well, PHP docs say that UnexpectedValueException occurs when the path cannot be opened. This should only be the case if the user changes the permissions on files/ or files/plupload.
God I wish I knew about fromMaybe....
Returned status should be `:reserved`
Comment inside the else block.
Formatting still wrong...
Avoid using HTML formatting inline. (as I commented elsewhere: "Please don't use formatting at this stage, unless absolutely necessary. prefer to stick with Sencha defaults when doing development, and to do theming (across all modules in the application) as a consistent effort by using CSS... at a later time.")
My problem with that is, I have no real clue which elements will usefully generalise, as I'm not that much of a GRIB expert.  I constructed these test messages simply by adding a data item every time the current test cases failed.  A much better understanding of the expected usage is needed to improve on that.

Also, a separate 'fake message' class (as suggested by your other comments) is **far** less transparent, because you have to read up on its behaviour to understand how it works.  A simple dictionary has perfectly obvious contents and behaviour.
This is in contrast to the Fake_GribApi class, which I agree is more complex but hopefully contains all the trickier stuff in one place and will be reusable --  whereas testing messages I think can be fairly one-off and disposable. 

I think this is rather like the question over the value of Fakeup_Gribapi_Context (see comment above).
s/start action/startup action/
$(document).ready(main);
Try to send/
Try sending
Can you add a disclaimer that says "DON'T USE ON IT'S OWN."?
Alternatively, add @nested_commit_on_success here as well. This way we'll have units that can be safely reused without depending on the caller.
Maybe just put this in the GiddyUp namespace?
Again it would make more sense for the field in the protobuf to be boolean, so you'll need to pattern-match on the value to coerce to true/false.
What about smart pointers?
Don't think this should be changed to be consistent with the rest of the docs
I have just run your example. I do not see any error. Also the outputs seem correct to me (an individual loss curve only for asset a1 and a3 (a2 is not in region constraint).

Regarding the speed, I don't completely agree with your point. We need to discuss more on this.

However, the goal of this task is not to provide an efficient classical calculator as we do not have enough benchmarks to run against. The only one we have (~43 assets) gave us promising result, so we have considered this solution quite good at this stage.
Mostly I see the aliases as being a way to provide a new command as the de facto without breaking an old command that users might be used to.  An example would be when we introduced `apps:info` and created the `info` alias.  `info` used to be the de facto but we decided `apps:info` was more consistent, so we now recommend that.  As such, my preference would be to not start with an alias here.  I'd rather just start with `auth:whoami` and only add the alias later if it becomes a problem or we change our thinking.  Does that make sense?  Thanks!
I'm pretty sure this has nothing to do with the ticket...
Unassigned variables should precede assignments (i.e., make this the last declaration). Also, why `type = typeof value` instead of `stringValue = typeof value === "string"`?
It looks to me this returns NULL for the first step which leads the entire string to be NULL.  Is it expected?
I understand that this is JSONP and meResult.content sends down `callback(...)` but we can't run eval on the sever -- this will allow for QQ to execute any code they want on our servers. Instead could you just remove `callback()` from meResult.content and then parse the rest with JSON.parse?
Are you crazy? WeaponMeleeInstant can be used by player heroes when they have melee weapons equipped.
Should we do the same for the other listeners to keep the APOs alike?
The few defined error codes are listed in the very short spec.

The error codes from and including -32768 to -32000 are reserved for pre-defined errors.
You can omit the brackets here.
Probably take it in Homebrew-alt.
I'm very sorry, it's my mistake.
I removed this line, could you please review this again?
It doesn't look like this is used?
This can be made shorter with the `odie` method, which prints the error and then exits in one command.
Official mairix website links to it. 

Sent from my phone.

On 04 May 2012, at 8:50 PM, Charlie Sharpsteen<reply@reply.github.com> wrote:

>> @@ -3,6 +3,7 @@
>> class Mairix < Formula
>>   homepage 'http://www.rpcurnow.force9.co.uk/mairix/'
>>   url 'http://downloads.sourceforge.net/project/mairix/mairix/0.23/mairix-0.23.tar.gz'
>> +  head 'git://github.com/rc0/mairix.git', :using => :git
> 
> Given that the downloads are coming from SourceForge, how official is this repository?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/mxcl/homebrew/pull/12064/files#r776131
Fixed in f3b86be
http://datatables.net/ref#sDefaultContent

maybe it is possible to do on the client side.
I don't think `TransportEvent` provides constants, it only has a `DELIVERY_STATUSES` frozenset. The values correspond though.
No need to declare if unused.
Definitely!

As @sf105 has written via email, for `both()` a different solution would have been to replace it with `allOf()` which javac seems to like better. I did it this way to demonstrate the problem. I could replace it with `allOf()` now. What do you think?
It's nice to see Javadoc but let's see the JDK 5 impl. They use synchronized on method. So I do not want any locks!
Also, lots of people use single quotes on HTML attributes instead.  Do you want to try to handle that case as well?
I see false on line 144. I'll remove the check.
I made a pull request with the changes, this was a hack to compensate for the bug in the old CEF3 build with retina gradients
Yes, that file got way out of whack with indentation. Fixed
It seems like `_getAllFunctions()` should be the one to do this, since that's really the function that validates the cache. (In other words, any other caller of `_getAllFunctions()` would want the same behavior, I think.)
I'm still seeing non-normalized input from the user (e.g. "rgb(10,20,30)") getting changed to normalized text (e.g. "rgb(10, 20, 30)") as soon as I type the last char.  Looks like it's because of the "true" here -- the "resetHsv" arg also switches this.color from a string to a tinycolor, so when synchronize() updates the text field it updates it with the normalized string.  Not sure this is worth the effort to fix now, though -- what do you think?
the end of this sentence could be changed from "bloom filter" to any of "the bloom filter" or "bloom filters" or "it"
yeah copying datespan should have come after that. surprised it didn't throw an error
a default value in the middle of the arguments (one c'tor being A, B, C, D, E, the other A, B, D, E) looks strange.
Also, I don't think you'll need to set the collections to null everytime. Since it's a new response object, I think the properties that haven't been initialized are going to be null already
This variable appears to be unused.
The other way with Django fields is that you just add additional [validator](https://docs.djangoproject.com/en/dev/ref/validators/) when creating new field. But it is OK to override also `clean`. Everything depends on the use case. If you have multiple locations when you want to use new field, then it is probably better to define a new field, if you just want to limit value in some way only once, then you could just create a simple method for that.

Leave it as it is here. Just to tell you.
Default should be taken from tuple of possible values (check `choices`, too).
I don't think you need most of this, do you? It should be a part of `default-config.json`.
You could use `deepEqual( res.project, data.data )` here instead
This should be served from the CDN. If it's not available on the CDN, just nuke the ogv; we're covered by webm and mp4. Also, does mp4 need to be listed first? For some reason I remember that as a bug... maybe just in older versions of Safari or Safari Mobile.
don't use a mixin here please. thanks
I don't think we want to introduce the idea of publish vs. save.  When we "save" a project, part of that process is writing out embeds (i.e., publish), but it's a detail.  You can't save to the db separate from writing the embed files, so the distinction is not helpful.  I think just having isSaved is useful and correct.
can't you check for this as a truthy? e.g. if (redirect)
What does the ./ do here if you are not int he local directory?
Because Nexus via dm enforces to 4.8.x and that results in problems
字符串是%V
I'm not following. The point is you shouldn't have to care if the list is empty to add an element to it. And now I just have to keep track of another type. How is this better?
Am i reading this right that we are passing the user's password (hashed or otherwise) to foreman?    This doesn't seem correct.
Yes it should NOT have been reverted back to .all .   Doing that will result in hidden users showing up in the UI.  Probably a result of a bad merge conflict.
Was this intentional to move the client.conf's default to /headpin?
If it IS a valid review then forbidden?
Which error? In my test case I've in all the cases the Twitter, Facebook and Google IDs and Secrets, so everything works :-)
protected methods should be placed after public ones
+1
An ImportError here can be allowed to pass at build time, but any other time it should raise an exception immediately.
And this could be collapsed to a single isinstance statement like you did earlier.
Um... what comma?

> Date: Tue, 24 Jul 2012 02:06:05 -0700
> From: reply@reply.github.com
> To: aconleyjunk314@hotmail.com
> Subject: Re: [astropy] Modified cosmology routines to handle dark energy equation of state (#322)
> 
> >          if isiterable(z):
> >              z = np.asarray(z)
> >          zp1 = 1. + z
> > -        return np.sqrt(self.Om*zp1**3 + self.Ok*zp1**2 + self.Ol)
> > +        if (abs(self.wa) < 1e-5) :
> 
> The outer parentheses are unnecessary here. Also another space before a comma that needs to be removed.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/astropy/astropy/pull/322/files#r1223220
These are just general instructions for creating and managing SSH keys.  We don't have any "institutional" keys in use here.  There's no reason to have access to other peoples' private keys--they're only being used for signing the releases which is something that happens only once anyways.

Perhaps what we *should* do is make sure the public keys of anyone who signs a tag are available somewhere. That's worth thinking about.  Here's mine:

---- BEGIN SSH2 PUBLIC KEY ----
Comment: "2048-bit RSA, converted from OpenSSH by embray@bray.stsci.edu"
AAAAB3NzaC1yc2EAAAABIwAAAQEA0I4YLTcnBU/IKiFd/mTRMZmQr9fZsj9AEql0NGWORN
NZ6Lij4DF2UIMXwx1GdrPXOLdYQ6UwIS673ODhqgSZFEv0IU4uhMhZLowTE/UpygVDcElr
o2aV/Bo1KZGp8todsZ2b+Ck+1aqytSYI3bUwPq6DCCNKATbLOOApfeKeF+jJ7pObXMl+ev
g4Ut9/TTrK2bqcXu7XiMGll+/k7f2mSoZLfQDfeDYwdHYKTpRX6SJE/4rWM74FvpuW34WV
/oY/3EU7uix7KTmxGVIyrnJUfOEj6lcUnx/YfsowicRFtwkiwOGtZmbNoWYrd5o6QJmsvz
K39q0DucFiTyuU6MWsVw==
---- END SSH2 PUBLIC KEY ----
*It would be nice, if we were able to rewrite funtcions to use std::string instead of char * or char arrays*

We certainly agree on that. Apart from places where you really can't get around it such as strprintf, which wraps a legacy C function, there should be as little fixed-size buffers as possible.
I can revert this, but please consider the following:

This patch has the following behaviour:
1.
1.1. enable ``Detach Databases at Shutdown`` in settings -> Apply and close
1.2. click ``Reset`` -> ``Detach Databases at Shutdown`` get's disabled
2.
1.1. enable ``Detach Databases at Shutdown`` in settings -> Apply and close
1.2. disable ``Detach Databases at Shutdown`` in settings -> Apply and close
1.3. click ``Reset`` -> ``Detach Databases at Shutdown`` stays disabled

With current code:
1.
1.1. enable ``Detach Databases at Shutdown`` in settings -> Apply and close
1.2. click ``Reset`` -> ``Detach Databases at Shutdown`` stays enabled
2.
2.
1.1. enable ``Detach Databases at Shutdown`` in settings -> Apply and close
1.2. disable ``Detach Databases at Shutdown`` in settings -> Apply and close
1.3. click ``Reset`` -> ``Detach Databases at Shutdown`` stays disabled

So current code is special and IMHO a user expects it to be the way after this patch, no?
I'm going to revert this, so that in the end the diff is much smaller now (after some reverts and removing silly stuff). I consider your feedback very constructive and I'm glad you took the time to look over the code :).
Ah I missed, that it skips a foreach loop of 0. Seems reasonable then.
Fair enough, so I guess this is ready to merge once the commits are squashed.

1.1 had a `NeatString::randomPassword()` function. We could reinstate that as `String::random()` or have a better random string generator logic.
I dunno about this.  Seems like moar magic which has the potential of going wrong. Like ADmad said in the lighthouse ticket couldn't you just setup the schema or specify the types when using deconstruct.  In the past when we've had code that does guessing it generally ends up being wrong.
yes ... you're right.
Ah - didn't know about that.  I'll look into it.
Just a quick idea for later on: How's about adding a method getEntity($object, [$typename]), to save the user some typing? If it's called with one parameter, you the typename is automatically inferred from the classname, so the functionality would be the same, but it would look a bit cleaner
What happens when there are multiple worksheets?  Triggering `set_dirty.Worksheet` sets the dirty flag for all worksheets?

Same question for `set_next_input.Worksheet`.  What happens if `data.cell` is in another worksheet?
It took me quite some time to figure that out.

I'll change it, this is a documentation issue.  Google "ipython svg" or "ipython
notebook svg" and none of the links I see lead you to do a %config.

Likewise it took me some time to figure out that "%pylab inline" was the right
thing to be doing...

Min RK [notifications@github.com] wrote:
> In IPython/core/pylabtools.py:
> 
> > @@ -88,7 +88,7 @@ def figsize(sizex, sizey):
> >      matplotlib.rcParams['figure.figsize'] = [sizex, sizey]
> >
> >
> > -def print_figure(fig, fmt='png'):
> > +def print_figure(fig, fmt='svg'):
> 
>     how can I inform passers-by of what this branch is supposed to be/do, and
>     that they should run
>     %pylab inline
>     %config InlineBackend.figure_format='svg'
> 
> That's always been how you enable SVG figures, and SVG figures are nothing new.
> So it should be clear simply from the fact that this PR relates to SVG figures
> that this is required, or if you don't think so, then simply mentioning that
> once (as you just did) should be quite sufficient.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> *
--
Cheers, Bob McElrath

"The individual has always had to struggle to keep from being overwhelmed by
the tribe.  If you try it, you will be lonely often, and sometimes frightened.
But no price is too high to pay for the privilege of owning yourself." 
    -- Friedrich Nietzsche
Are they solid enough that the clearly redundant test of `if not startswith(ESC_CELL...) and not startswith(ESC_MAGIC)` should be removed?
+1 on cleaning up unnecessary wildcard extends, esp since buildhive Will
catch anything which might be depending on it
On Nov 4, 2012 7:10 AM, "Matt Stephenson" <notifications@github.com> wrote:

> In blobstore/src/main/java/org/jclouds/blobstore/InputStreamMap.java:
>
> > @@ -53,7 +53,7 @@
> >
> >     void putAllStrings(Map<? extends String, ? extends String> map);
> >
> > -   void putAllBytes(Map<? extends String, ? extends byte[]> map);
>
> To be precise, no we don't need the wildcard, unless someone figgured out
> how to extend byte <http://which%20I've%20never%20seen%20actually%20done>.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/940/files#r2025057>.
>
>
No. But I think I can replace Instant.now() with System. currentTimeMillis and remove it completely.
Using `Fluent` chainable structure should be better in this case. For example <https://github.com/laravie/laravel/blob/nightly/laravel/database/schema/grammars/mysql.php#L376> 

I can simply write `$table->integer('age')->length(10);`
These now live under `libgit2`. This should also give you an excuse to re-push so travis tries again.
Oh sorry, didn't notice the comment on the diff. Can you just kill the code?
Looks like there are a few other fields named 'locale':

* customercare/models.py: Tweet, Reply
* inproduct/models.py: Redirect
* users/models.py: Profile

Do those need to get migrated, too?
Why do we need this test? We should better return false in the first iteration and true in the next one. Otherwise it would be the same test as the first one in this file.
klrmn: except for the need to mock time and the spelling, this looks great!  this will be a very useful way to get coverage on all the APIs we add for CRUD operations.  Thanks for doing this!
access is before apps
A few typos in this line; maybe amend and force-push before I merge it in?
Those variables should be when merging into master (or master into portlet-tests branch) according to the setup changes on master.
I could not see any differences.
"현재 EPUB은 이 컨텐츠를 위한 미디어 오버레이가 포함되어 있지 않습니다." is OK?
as $_FILES might contain something already so in order to do that he have to do $_FILES = array() before the foreach, the outcome is the same.
Then your test is wrong. You should not pass a totally unrelated object. Use mocks or stubs.
Oh, storing an unencrypted password in persistent storage is definitely bad.  Indeed, security issues are lower priority now, but I'd still recommend just removing the storing feature altogether.

How critical is having persisted passwords?  I, for one, always type in my credentials each time I run `sympy-bot`.
It's actually based on Polish. I first thought I would put a function to each key, but in this way it seems to me a bit more compact.
"we shouldn't"? You mean we should?
Also this (and other) lines in this PR run well over 80 chars. Please break for clarity of reading.
This is the `VoteNotificationEmailJob` spec but the describe blocks refer to `VoteConfirmationEmailJob`.
bitbucket and bitbucket/avatars folders must be kept outside of web root
Oh, that's a cool way to do it!


On Dec 10, 2012, at 9:22 AM, Aaron Steele <notifications@github.com> wrote:

> In src/clj/gulo/cdb.clj:
> 
> > @@ -146,7 +145,8 @@
> >          occ-source "/mnt/hgfs/Data/vertnet/gulo/hfs/occ/"
> >          tax-source "/mnt/hgfs/Data/vertnet/gulo/hfs/tax/"
> >          loc-source "/mnt/hgfs/Data/vertnet/gulo/hfs/loc/"
> > -        tax-loc-source "/mnt/hgfs/Data/vertnet/gulo/hfs/taxloc/"]
> > +        tax-loc-source "/mnt/hgfs/Data/vertnet/gulo/hfs/taxloc/"
> > +        occ-columns ["tax-loc-id" "scientificname" "occurrenceid" "laty" "lony" "prec" "year" "month" "season"]]
> Ha yeah. To force cdb to not georef the coordinates. We only want local table to have geom.
> …
> —
> Reply to this email directly or view it on GitHub.
> 
>
- "it's" => "its"
- the link rendering is broken
- the URL should be http://scitools.org.uk/
Нет-нет, вопрос в том, что оно ТУТ делает. Посреди этого кода. Прикинь, сколько у тебя постов на странице - столько раз ты подключаешь все js-ки
why this check?!
This won't change, so it can be computed outside of the loop.
This is pretty inconsistent. You are only reading the url arguments and applying the filters in the "extended" case but not in the normal case. There is no reason for that, we should always filter
Yes; I don't think deep-inspecting things is the right way to go.  We should be converting things to be compatible to JSON where we know what we want (i.e., when the JSON message is made).
Small grammar fix: _change it if it not_ . Should include "is".
Can we check for equality here,  ```id_string=id_string = '_cloned'```?
My offline comment to him is not to use events internally _at all_ ...
please unprefix.
I filed a bug
https://bugzilla.mozilla.org/show_bug.cgi?id=812098
you can add this bug to your comment
use indexOf() here instead of filter(). It terminates the iteration early once it finds what you're looking for.  Filter always has to go to the end of the array.

Also, the argument name video is pretty confusing here, since this is the !isVideo branch
Thanks for the rationale, that’s exactly how it works.

I agree synchronous XHR is bad. The point is, it’s much easier to use `l10n.js` without having to think of this flickering effect — and again, it does make a very significant difference (I’ve been surprised as well): for all apps I’ve tested, it prevents all flickering without having to hide the content until the `localized` event happens.

However, as it’s not directly related to this PR, I probably should update the comment and leave it asynchronous for now. We’ll still be able to make it synchronous afterwards when optimizing apps.
Curiosity: Why do we wait for load event?
I don't think this should be treated. If the user decides to send a sms to string instead of a number, he will be warned anyway when the sms fails.
You got it! ;-) Thanks!
sure, my mistake
we lost the `float:right` in the change, it does not look good :)
we may want to change the explanation comment if we change the value added to bottomToolbarHeight
trailing comma ... not the that Gecko will chock, but it should be avoided.
You may want to use data-field in order to be more html5 compliant. Or it could be an attribute that I don't know?
You don't need !! here.
i'm so not caring about indenting anymore :)
Missing whitespace here and on [188](https://github.com/nickl-/httpful/commit/a23e8c301dbe501ccb934c0ff7e690a334bd81b4#L0R188).
Ah, a try without catch block. It's added now (at least, I think this is what you meant).
On Wed, Dec 19, 2012 at 5:42 PM, Colin Hebert <notifications@github.com>wrote:

> In
> messageforums-app/src/java/org/sakaiproject/tool/messageforums/ui/DiscussionForumBean.java:
>
> > @@ -232,28 +232,19 @@ public void setAutoMarkThreadsRead(String autoMarkThreadsRead)
> >    /**
> >     * Return whether or not the forum is markup free.
> >     */
> > -  public String getMarkupFree()
> > +  public boolean getMarkupFree()
>
> Shouldn't the method be named isMarkupFree()?
>

isMarkupFree() is fine, but to be a JavaBen property it's just an optional
alternative getMarkupFree() works just as well.

The class doesn't have any existing convention for the boolean getters with
some is...() and some get...()

-- 
  Matthew Buckett
No, we only want to release the lock on a direct exception. Otherwise we release it when the async operation completes.
Wouldn't that be InvariantCulture? I don't think cmd line parameters would change based on the culture the user's running. Also, could we have a couple of unit tests for this method?
bad cs, the opening curly bracket should be on its own line
You should probably be using `escape_identifier` on the table / collection name here.
Can this leverage the existing `color` method?  (or maybe that one should be removed entirely?)  There's a good deal of duplication here.
~~~
"Yes" をえらぶと要求されます。
~~~

~~~
"Yes" を選ぶと要求されます。
~~~
Why a second time?
Thanks a lot! I agree with you. I will change it soon. :-)
the same comment here about constructing a RandomState instance at the beginning of this code ...
Add a "Returns" section.
Indicate what exception type is being thrown here, and fix the misspelling.
Added a raise section.
Agreed.  Done.  patch coming soon.
I see.  But when you said 'This probably isn't needed', what were you referring to?
Done, also converted the error responses to a JSON-encoded response.
You can only chat in one channel at a time so I don't understand this.
do you mean:
```
while str(emulate_id) in used_id:
    emulate_id += 1
```
Per djmitche's comment, switched to using os.path.join().
This could probably use a better name, since it is testing more than just *some* output.
Why isn't $resource the full path here (baseUrl + resource + rev)?
This should be removed and below use: `\Exception`.
すべてのViewは、それが既にページに挿入されているかそうでないかに関わらず、常に何らかのDOM要素を所持しています（ **el** プロパティ）。こうすることで、UIの描画を効率良く行うため、できるだけ少ないリフローとリペイントで、Viewはいつでもレンダリングでき、一度にすべてをDOMへ挿入するようになっています。Viewに`tagName`、`className`、`id`そして`attributes`プロパティが指定されていれば、それらから`this.el`が作られます。そうでない場合は、 **el** は空の`div`になります。
correct

On Thu, May 17, 2012 at 2:31 PM, naaman <
reply@reply.github.com
> wrote:

> > @@ -13,11 +17,21 @@
> >   * @author Naaman Newbold
> >   */
> >  public class XmlParser implements Parser {
> > +
> > +    static JAXBContext jaxbContext;
> > +
> > +    static {
> > +        try {
> > +            jaxbContext = JAXBContext.newInstance(App.class,
> Collaborator.class, Domain.class, User.class);
>
> Haven't looked....I'm guessing these are the only model classes that are
> used in XML parsing?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/heroku/heroku.jar/pull/34/files#r841989
>
1000 is the timeout in milliseconds to wait for available packets. In practice this will never be reached unless there is no network traffic.

Matt Keeler

On Nov 2, 2012, at 5:12 AM, Eric Leblond <notifications@github.com> wrote:

> In src/source-napatech-3gd.c:
> 
> > +    ntv3->slot = s->slot_next;
> > +
> > +    while (!(suricata_ctl_flags & (SURICATA_STOP | SURICATA_KILL))) {
> > +        /* make sure we have at least one packet in the packet pool, to prevent
> > +         * us from alloc'ing packets at line rate */
> > +        do {
> > +            packet_q_len = PacketPoolSize();
> > +            if (unlikely(packet_q_len == 0)) {
> > +                PacketPoolWait();
> > +            }
> > +        } while (packet_q_len == 0);
> > +
> > +        /*
> > +         * Napatech 3GD returns packets 1 at a time
> > +         */
> > +        status = NT_NetRxGet(ntv3->rx_stream, &packet_buffer, 1000);
> What is the 1000 here ?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 


--------------------------------------------------------------------
The information contained herein is for the exclusive use of the original recipient.  This information is granted for limited distribution within the recipient's organization for planning purposes only.  Further dissemination, whether private or public, is prohibited and may be covered under a non-disclosure agreement.
maybe call this method flush, instead of sendMessage?
lembrete: aqui é interessante colocar apenas os js mais utilizados e que tenham mais necessidade de otimização, já que os especificados aqui serão carregados em todo o portal. seria o caso deste?
Should handle cleanup on destroy.
You might have to add __exposedProps__ attribute to each argument object.
Ok I think I understand now. What about implementing `isXULBrowser` function, either in `window/utils` or locally ?
This would make code easier to understand.
further down in the file(L205), there is ```verifier_url```, does that serve a different purpose from this?  (as an aside, there is also a browserid_url specified, is that different from public_url?)
Good question... I dunno. Researching...