labofsahil/github-event-dataset-2012 huggingface dataset:
this should be automatically generated based on `CRON_BATCH_NAMES` instead of hardcoding duplication:

```
CRON_BATCH_CHOICES = zip(CRON_BATCH_NAMES, CRON_BATCH_NAMES)
```

Or you could just do that zip where you actually assign the choices to the field, if that's the only place it's needed.
Should it raise an exception instead? Or let the user deal with it?
@nvcVincent push to you repo after you make the commit. I'll pull in the request.
why do you pass `null` as parameter, no parameter has the same behavior ?
I don't know about the message format, but I think that's up to whatever consumes this data (which at the moment is I believe just the puppet cert app).
Should this be `.carousel-vertical` to maintain the naming conventions used elsewhere?
It is called in [inst_autosetup.ycp](https://github.com/yast/yast-autoinstallation/blob/32a6341e372dd7d0992ed5e4e017cc0d44228567/src/clients/inst_autosetup.ycp#L308) in autoyast2.rpm
Our convention is to import the exception namespace, not individual exceptions.
Please move this to [proper file](https://github.com/KnpLabs/KnpBundles/blob/master/src/Knp/Bundle/KnpBundlesBundle/Resources/config/twig.yml).
Oh yeah such a big fail ! Concerning the "return home early" I already tried to flatten the deeply nested structure with no luck, everythings seems to be muddled in a way you need a least 3 nested if. Can't figure a better way.
should we do a `unset()`, or reset it to the value of `$this->_data[$name]` when available?

For NoSQL unset makes sense, for SQL it does not. For other datasources it may vary. (originally the unset is only present in Document)
^ Should be in your own global gitignore. Remove
What's the reasoning behind building the templates list before checking if the post has any categories? For blogs with uncategorized posts, this would result in the template list being built on on every pageload for those posts' permalinks, even though they'll never be used.
had no idea this worked. neat.
"id" vs. "{sectionId}"?
I was thnking about something like this:

```python
SITEMAP = {
    'format': 'xml',
    'changefreqs': {
        'articles' : 'monthly',
        'indexes' : 'daily',
        'pages' : 'monthly' },
    'priorities': {
        'articles' : 0.5,
        'indexes' : 0.7,
        'pages' : 0.5},
}
```
Btw, this converts ""&#216l trinken beim Bes&#228ufnis" back to unicoded "Øl trinken beim Besäufnis"
`$storage->fetch()` already throws an exception.
I guess that's true.  I was thinking that if you're merging the branch you're on, it's because you're working on it, but you're right - we should always make sure it's updated.
No, I meant the lack on 4 space indent on `<packaging>ejb</packaging>`.
I don't think we should hard-remove `-O<4-5>` at this point – we would needlessly break many people's build scripts. Better just hide it, or add a not-implemented note or warning to it.
Great work! Thanks again.
i think you aught to make this an instantiate-able object that creates it's own failure_list on __init__, then all of the methods will have the same footprint as their Assert.method version.
You could save yourself some bytes by doing these at the top of the file, especially since they're used in multiple tasks. I do this pattern a lot.

```python
BASKET_URL = getattr(settings, 'BASKET_URL', False)
BASKET_NEWSLETTER = getattr(settings, 'BASKET_NEWSLETTER', False)
BASKET_ENABLED = all([BASKET_URL, BASKET_NEWSLETTER])
```
Then just use BASKET_ENABLED and your other constants as necessary. Not a requirement, just cleaner.
They were, but not here - good eye!
You don't need this variable
You can put these two directly into the parametrize function. no need to abstract them because they're only used once.
I believe you'd have to use DatabaseUtils.sqlEscapeString(value.toString()) here, in case the URI itself contains quotes. This is used by StringTypeMapping, and will properly quote the string as well as escaping any embedded quotes in the string.

As I understand GitHub you can make further commits on your fork and they'll be included in the pull request?
the RRDTool class was causing exceptions to be thrown in the test suite.
Dmitri can provide more detail, but since we don't test that explicitly,
not having that in the fixture should be fine.

On Fri, Oct 19, 2012 at 3:38 PM, Ohad Levy <notifications@github.com> wrote:

> In test/fixtures/report-errors.yaml:
>
> > @@ -17,9 +17,7 @@ metrics:
> >      basedir: /var/lib/puppet/rrd/my.sol.client.com
> >      label: Time
> >      name: time
> > -    rrd: !ruby/object:RRDtool
> > -      rrdname: /var/lib/puppet/rrd/my.sol.client.com/time.rrd
>
> why remove those? these are genearaed by a puppet client, so we might be
> getting these kind of objects regardless?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/theforeman/foreman/pull/193/files#r1894040>.
>
>
This event is now provided by Backbone.
>`value.replace(/[{}]/g, "\\$1").replace(/[|\<\>\~\^\\]/g, mapEscape)`

Is there a reason we can't just add `[]{}` to the alwaysMap array and make them map to the escaped versions? Then they would be escaped at the same time as the second group and would never be double-escaped. I think even the third replace can safely go into the alwayMap array. But maybe I'm missing something.
Okay. Will add this back to DVDPlayerVideo then. You mean by strange effect that it will take a lot of time until audio gets in sync and until then the pitch will vary constantly? Or something else?
I am not sure how to implement this.
Why the extra spaces here?
From the way things are written here, it sounds like you cannot specify the gain if you're using a NDData object? I haven't followed the development of NDData closely enough to know, is there an official, unambiguous way that gain will be specified for all NDData objects? Otherwise you'll want to still be able to set that parameter here, I think.
That's not my wording , it's from the original patch http://build.meego.com/package/view_file?file=gnome-settings-daemon-2.30.0-902-mount-notifications.patch but it was requested that it opened the file browser instead so s/devices panel/file browser/
Fixed in ad36541
AttValue was computed using ,FEW - does that mean we can use a ,LOOKUP here?
Any suggestions for a good place to put this? I thought of a Middleware base class, but that's kinda silly for one method. Ditto for a "RackUtils" or "MiddlewareHelper" module.
WEEIRTDDDD
bike shed alert: can we stick to `lowercase_underscored_variable_names`?
Why do we need to match this? There are numerous ways in which IP addresses can be encoded, [http://1249765671/](http://1249765671/) is the same as http://74.125.233.39/, both of which point at http://google.com
Can you fix the indentation here and throughout the PR so that all parameters align?
`null` should be returned when there's no error.
I think that's covered by the 'verify making someone an admin'-testcase in test-users
Added the same caching strategy to `OAE.getAvailableModules`.
In the UI, we try to avoid prototype inheritance as much as possible. Can we just have a Telemetry object with the that... structure ?
I think `called` should be set to true here ?
Because classpaths are ordered.
ok, let's drop these then. I think we should build a new API for the table-form if necessary. Currently it adapts closely to a table, which is fine.
i created #39 to address the things we discussed here
毎回 `new` するのはよろしくないので、この辺りを参考に書き換えてもらえると。
https://github.com/thinca/vim-quickrun/blob/master/autoload/quickrun/outputter/browser.vim#L12
You could use `--remote production` instead. You could also use this to use "production" but fall back to "heroku:"

``` bash
git remote | grep -m1 -e "production\|heroku"
```
"запущена на машине" or "проведена на машине". The English copywriting for this message is not particularly good, don't copy it (our French translation also suffered from trying to translate "worker box" word for word).
:+1:  `http://www.geoips.com/developer/`
typo: "a way merge" should be "a 3-way merge"
Take out the comments or write you own.
I guess these two have tabs now and some others have had an extra tab removed, so lets go with that!
Логично, спасибо.
С _dnkArrayLength так и надо поступить, а вот дефайнить массив - гиблое дело.

Вообще есть обходные пути: можете создать метод, который будет возвращать значение статической переменной, или использовать спецификатор extern.
Спасибо, не приходило в голову разобраться c этим.
Согласен, с round будет именно так "как учили в школе". Сейчас запилю.
I guess what I was hinting at was that there are awefully little validations for your (new) models. Keep in mind that this is something which keeps your data sane. Let me know if you want me to merge this even though there are no validations for some models.
This could just use `[lastValues removeAllObjects]`, which would remove any need for the `nextGate` variable used here.
This is definitely the wrong way to add PDF-specific commands. The correct way (see, e.g. picviewer.lua or djvureader.lua) is to define the :init() method which calls self:addAllCommands() followed by self:adjustCommands() and also define PDFReader:adjustCommands() method which does the actual adjustments (deletion and addition).
Remove auto generated comments. Add comments on exceptions and why/why not they'd occur.
3 is a good compromise but you use 2 below
check for error first ```if(error || res.statusCode !==20)`` return and error and close response and don't continue execution.
I don't think we need to explain that the event is attached to the Popcorn instance. We can probably just use the subtitle + footnote explanations to give an accurate description.
+1 I think you have better intutions on how to make a good config file, as you have seen bigger play projects than me
Tests are written using the Jasmine framework. To run from the command line, enter:

jasmine-node ./spec
@WouterJ done thank you ;)
In the Symfony docs, we use semi-colons to end a list item except for the last one.
Yea, it should definitely be merged into 2.1 - Composer was first officially used for 2.1.x. I think we can keep it simple, especially since this article is just meant to gently point of differences between 1.x and 2.x for those curious. So, I think we can just write this as if Composer has always been the way... but then we'll of course only merge it into the 2.1 branch.

Thanks!
the only place where we use extra indentation levels when chaining in Symfony is when using the ``Symfony\Component\Config\Definition\TreeBuilder``, to make the indentation reflect the tree structure (making it far more readable than 100 chained calls indented the same)
I the symfony docs we suffix every list item with `;` and the last one with a `.`:

    * Manually logging some information from your command;
    * Logging not caught Exceptions.
"return a copy of the backing array _if_ ..."
I definitely agree.  I almost took them out, but opted for as close to a "pure port" as possible while I was getting familiar.  I'll start pruning this stuff out.
Given how ct_run works, implementing the check for *_SUITE.erl is a better choice.
Well, I'm usually ok with do...end.compact way, because the block is not that long in this case, and the idea was just to avoid the variable. But I can put it back again, and maybe change [here as well](https://github.com/rails/rails/pull/5255/files#L2R61) to add a variable if you think it makes the methods more readable.
Shouldn't you use Java logger instead?
* Creo que tenemos que tratar de no dejar el trabajo para el final del sprint, de manera de tener tiempo de compartir conocimiento y opiniones.
Estás líneas que estás removiendo tenían una razón de ser. Por un lado, solo permitirán edición de empleados no existentes, pero por otro lado se preservarán datos que el objeto employee tenga en la base de datos y no vengan definidos en el Post. Puede ser que esa característica ya no se está usando, pero me parece deseable conservarla.
if preview doest not exists this will fail
precisely, that generated quite some chaos.
Should we be using `alert()` at all in the documentation examples?
Hey man… I'm just the messenger. @arrbee ^^ ?

Tbh a lot of the documentation was lacking and/or vague in the diff header.
You are correct. There is nothing lm4f specific. I do not know how to hook it up into the buildsystem otherwise.
This variable name made me laugh.
Perhaps a a gui make it clear that the pdf, ps ect backends work. I.e "The other gui backends  do not ..."
```np.prod(expectedImage.shape)``` would do the trick here (obviously your version works, but feels less numpy-y).
Ok, I guess that can be considered as non-public.  The only rule-of-thumb I was aware of for non-public interface was the underscore naming.
Careful, this shouldn't leak into the master branch
We should add <code>_locator</code> after the name.
Ah, yes. That was a bit of an afterthought on my part. I realized that not all of the XPCOM tests were checking for functions. I'll patch this with a docstring.
@zacc yes, it will wait max 10 seconds in this case to find something, or else it will throw an exception (http://seleniumhq.org/docs/04_webdriver_advanced.html#implicit-waits)
Может быть имеет смысл сделать конструктор приватным? Это бы нам дало одну точку доступа.
Wait, so I can't stop a single instance? that seems a little odd
I copied the copy write header - and forgot to change the name. Good catch.
"no-titles"?
I prefer the first one. The condition is there on first plan. Also it is easier to me to distinguish then from else parts, because they are highlighted (? and : are not). I can easily see four short lines without moving my eyes, but to see one wide line I have to move my eyes from right to left, when at the first case I have to only move my eyes from up to down.
At first sight 

    _NO_TRANSLATE_Workingdir.Text = mostRecentRepos.Count > 0 

looks like assignment.
Despite this I don't replace ternary operator with if-else statment in code written by someone else. I know that there are people that prefer ternary operator to if-else. I respect that.
The version number will eventually also need to be bumped here, although that will also be a separate PR with the other version check place.
This is not actually needed for this patch, but because the MySQL patch will join shortly, let's leave it in there.
Does it need to be inline? (if it is then it's ok)
Why did you replace the old test case instead of just adding another one?
Should the type for parameter ``$body`` not be "string|null" instead of "string"?
Are you sure ``$options`` has the correct type as ``array|object<Traversable>`` is not a sub-type of ``array``?
Undo this change. Please update your sdk and run `touch build/blackberry/KitchenSink/main.cpp` in the git bash so it rebuilds main.o and relinks.
Backbone's `navigate` method and `href` attributes need code quotes.
Die Strings sind doch in den NodeProperty.bla klasse
I can't even find that in our docs. That's a way to get a specific account?
The `_configure` overriding is useful though when you want to effectively add to `viewOptions`.
isnt the request instance always available inside templates .. in twig it would be ``app.request`` .. i assume in php templates its ``$app['request']`` ?
could you make the intention of the code consistent with the above example?
I think you can simplify this test as:

```ruby
test "show for tag should be configurable for each iteration" do
  html_options = { :show_for_tag => :li }
  concat(show_for(@user, html_options) do |f| end)
  assert_equal({ :show_for_tag => :li }, html_options)
end
```
просто ждать на кондишнах, не проверяя ничего, нельзя, потому что при шатдауне фантома оно уйдёт в бесконечный цикл.
нужно проверять, что wait завершился успешно, а если нет, то кидать исключение, чтобы текущая корутина завершилась.
пример:
        if(!bq_success(connected_cond_.wait(NULL))) {
            throw exception_sys_t(log::error, errno, "connected_cond.wait: %m");
        }
Not good. It could happen that we are (by error) getting duplicate requests. You should use dictionary and have only once user object stored.

Also define a user object and use that, not just save data.
No need for this comment, because we want to translate everything, of course.
big ole NullReferenceException thrown here.
please fix the CS: ``if`` should always use the curly braces
l'encapsulation de cette classe semble totalement brisé avec les nouvelles modifications.  Est-ce vraiment nécessaire de rendre autant de méthodes protected?  Je ne vois pas de modification dans le framework qui prennent avantage de cette dé-encapsulation.  Peut-être que cette classe devrait déléger une partie de son traitement à une nouvelle classe et qui pourra 'manager' cette ouverture de comportement sans briser l'encapsulation de celle-ci?
I threw in this little optimisation. I hope you don't mind.
I put this with all the other Creature::Select* functions since it technically can be used by any creature, not just pets.
Gotta love 'em low spell ids.
String formatting?
Ist 8 nicht bisschen lang für so ein Low-Security Ding? Und sollte man die PW Länge nicht irgendwo in einer Config ablegen?
Probably just `@promos`
let's do some sanity check on these Strings.. they can not be trusted!
For example running a trim might be useful, but especially check for NumberFormatExceptions so that we can throw an appropriate error message.
Makes sense, I'm totally with you on simplicity.
Would we associate the requests and responses at all, or just have them converted in place from the array we pull from Javascript?
Might be more useful associated but it also adds complexity.
I like this artifact id, though it suggests to me that perhaps I should have named `elephant-bird-mahout` something like `elephant-bird-pig-mahout`.
Since this isn't itself a UDF, may want to place it within package `com.twitter.elephantbird.pig.util`.
positive test is better (isNestedLoadEnabled). I think default should be disabled (for now).
Another alternative is to have 'NestedJsonLoader()' which just extends JsonLoader.
working through pig properties is not very convenient for many users.
I'm not sure but if i do
```python
MyModel.collection(some_filter=some_value)[0]
```
and then later

```python
MyModel.collection(some_filter=some_value)[1]
```

Are all the process of making the collection is done twice ?

Even if i do
```python
my_collection = MyModel.collection(some_filter=some_value)
foo = my_collection[0]
bar = my_collection[1]
```

?
This message could be misleading. I would suggest something like "Unable to locate lib/selenium-server-standalone-${selenium.version}.jar"
That would work as well, the comment stated above is from [MSDN](http://msdn.microsoft.com/en-us/library/windowsazure/ee460808.aspx)
Extra space before the function.
All the jenkins functionality in here should probably be implemented as a cinch plugin that the bot loads
Use `(( $? == 0 ))` or `[[ $? -eq 0 ]]`.
one underline too many
this is not consistent. usually running the console without php works as it has the #!/usr/bin/php line. can you make both lines not have the php please? same for travis_midgard_mysql.sh
Super, bah dès que tout ça est ok, on merge et on déploie !  

--  
Thibaut Assus
Founder & consultant @ http://milesrock.com
Organizer @ http://meetup.rubyparis.org
06 24 57 14 88
Specialized in ROR / Node.js
“Programming at its best is an act of empathy.” - Kent Beck


On Tuesday, March 20, 2012 at 6:24 PM, remink wrote:

> > @@ -0,0 +1,22 @@
> > +%h2 Appel à présentations : proposez un talk !
> > +%p
> > + Faites vos propositions de talks pour le prochain  
> > + %strong
> > + Paris.rb
> > + , qu'on sélectionne et qu'on organise tout ça.
> > +
> > +#{render '/presentations/new'}
> >  
>  
>  
> Effectivement, pas très familier avec HAML ;-)
>  
> ---  
> Reply to this email directly or view it on GitHub:
> https://github.com/tibastral/presentations/pull/1/files#r581146
>  
>
out of curiosity, what is this? might be worth a comment?
>>>>> Konrad Scherer <reply@reply.github.com> writes:

>> @@ -0,0 +1,7 @@ +(:name ledger-mode
>> + :description "A major mode for editing ledger .dat files"
>> + :type http
>> + :url "https://raw.github.com/jwiegley/ledger/next/lisp/ledger.el"

> I think the other lisp files support an "output to elisp" export option. Is
> that correct? @jwiegley

ledger.el from my 'next' branch is the old version -- and the current "stable"
version.  It does not use the other files.

John
this should pull from a configuration file locally. http://api.nhindirect.org/java/site/gateway/2.0/apidocs/index.html
this security constraint needs to be removed
It shouldn't.  The triple / should still mark it as a doxygen comment.  It was just too long for 100 chars when put to the right of the variable, so I moved it above.  I think that's equivalent markup though.
I changed it to a regular expression that checks for a prefix, and then optional '/' and following hash.
I don't mind cleaning it up; it was just 4AM in the morning and I was doing the bare minimum :-p
Why does current_remaining have to be a dollar amount when everything else is in cents?
Why only startable entities? Why not everything concrete that implements Entity?
You won't be able to do with {...} so have to store the JmxObjectNameAdapter (or whatever) as a variable, but that's fairly straitght forward.

If you need a closure (e.g. for a postProcessing), you might need `JavaGroovyEquivalents.closureFromFunction(Function)`. We've changed lots of places that previously only took a closure, but there might be more... Overloading to accept the function as well would be good.
Can you make all of these proper doc blocks?
I'm not quite sure what "window size" here means. Can you explain the methodology a little bit more in the comments?
Is this working on GAE now?
Doesn't the `Thread` have to be `new`ed up? Can't find an example like this but doesn't mean it's not possible!
Use `firstName = contact['firstName'] if contact['firstName'] else ' '` Its much cleaner.

An empty string counts as `False` in Python.
The error message gets added to the topology descovery message so I didn't want to have to long one..
Anyway, fixed.
Done, and also for last_is_master.
IS there any chance for conversation.body to be null here?
The field "module" was just called that when settings were modular, now they are more like "sections" this is just badly named. I'd like to move settings actually into modules, and have a generic "Section" that has settings for that module. But that is another story. 

Just ignore it for now and remove the comments.
Full stop at the end of comment :)
These doc blocks should really have a brief description of the property. Having said that, the property names are pretty self explanatory so I wouldn't block on it.
I'll try that now
Why did this get moved to the .module file from tourney.admin.inc?
Oh what I would give to be able to just edit the file in github :-p
Actually I found that I don't even need to check that.
Мало этого. В extendedMode ещё и дополнительный отступ появляется (см. задание!)
Кажется, это бесполезный комментарий. Если хочется "навести красоты" - пиши хотя бы javadoc правильно.
Why not just:

```
$arr = array_values( $arr );
if( count( $arr ) == ){
  exit;
}
```
So the changes to DPL_onStateChange are broad enough that I can't be certain that there are no regressions, but I'll note that the end result is simpler and easier to understand. My main fear is regressing breakpoint handling on startup in conjunction with the bfcache. All the tests I ran however worked, and we have a few mochitests that cover that area, so I'm reasonably confident that it's OK.

However there is also bug 751949, which seems to occur for me now occasionally, but I haven't really nailed down a reproducible set of STR. I know that adding breakpoints on startup in a page, navigating to another, doing the same and then move back and forward between them, perhaps resuming before that, perhaps not, gets me some of these assertions. I'm not 100% sure that it's this patches fault either, because I haven't tried these tests for a while.

For the benefit of your better understanding of the code though, I'll just note that the point of the patch in that bug was to suspend the navigation until the previous page could resume, disable hooks to avoid any more pauses, resume navigation, and at the right time re-enable the debugger and send the tabNavigated event. The _needsTabNavigated flag was there to guard against sending tabNavigated twice, once from the progress listener and once from the DOMWindowCreated handler. Since that handler no longer sends a tabNavigated event, we have no need for the flag any more.
I like this a lot. <3
We should change the name to <code>are_weekly_downloads_visible</code> or something similar so that the name reflects the action.
to be honest I'm relaying on the assert to fail if something is wrong here.
This is mainly used to match the current class with the correct page
/s/purcasing/purchasing
Should likely be ```core.add(ms)```.
> I would set it to True by default.

+1
when calling sqrt on a number (not an array) math.sqrt is recommended
I'd rather have an instance of Ridge and an argument alpha_ridge=0.0 by default
Not sure but shouldn't it be "boosting" here and in the line below?
shouldn't the comma be before the shape ?
pep8: line to long, multiple spaces after operator
I would also get rid of the `$withBody` parameter:
if I have previously called `setBody()` (so that `NULL !== $this->body`), then automatically parameters (set via `setParameters()`) will be sent in the URL and not via 'application/x-www-form-urlencoded' body
Not yet

Le 10 avr. 2012 à 20:33, Jeremy Mikola<reply@reply.github.com> a écrit :

>> @@ -16,6 +16,11 @@
>>         "symfony/console": "2.1.*",
>>         "ruflin/elastica": ">=0.19.0"
>>     },
>> +    "suggest": {
>> +        "doctrine/orm": "2.2.*",
>> +        "doctrine/mongodb-odm": "dev-master",
>> +        "propel/propel": "dev-master"
> 
> Oh, I was looking at http://packagist.org/packages/propel/propel. Is no one using Propel2 with Symfony2 yet?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/Exercise/FOQElasticaBundle/pull/92/files#r667042
What if they never enqueue it? Can we have them enqueue a request via the filemanager if the filemanager generated that request? Then we could add the request to this array only when then enqueue it.
Do not use byref here
![](http://30.media.tumblr.com/tumblr_m1vknqkfDX1qeyt27o1_500.gif)

^^ Me after seeing Solaris's dirent definition.

Hmm... well this does allocate extra memory on Linux, OS X, and *BSD. Also it does a little extra work, though it's not enough to affect performance.
oops this is missing copyright too! didn't catch it last time :-/
This should probably be cleaned up properly..
it should be ``if (null !== $class && $annot = ...``
Most general models appear to return the whole response like this for example
https://github.com/ossreleasefeed/socorro-crashstats/blob/4fe538e75e0884dcb0aa6fd6818b6a2a6563ed31/crashstats/crashstats/models.py#L352

Can we try to stick to that?
With that in place, it's possible to do things like this:

```python
api=CurrentProducts()
r=api.get()
if r['hits']:
    do_something_expensive(only_relevant, if_there_are, hits)
    do_something_with(r['hits'])
```
I would modify the provider so that it will write out a --no in front of things that are false

something like this:

    if hash[:value] == false
      "--no-#{hash[:name]}"	
    elsif hash[:value] == true
      "--#{hash[:name]}"
    else
      "--#{hash[:name]}=#{hash[:value]}"
    end

we also have to think about the case where the string true of false is supplied and what to do about that case.

I agree that this is pretty ugly, but so is this odd design decision they have made about how to handle booleans

Someone has actually already written a patch for this that needs to be merged. I am just about to cut a diablo release and start working on merging some of the commits out there for essex (the one you mentioned is on the top of my list)

Have a look at this commit:

https://github.com/cblument/puppetlabs-nova/commit/3577d05db0408f2195dda0d6d5db84c47a6a523c
That is about the opposite of sane!  Can't you fix this right, rather than introduce a crazy hack to work around ... something?

If it is really true that this is the only way to achieve the required result, you absolutely need to document why the hell this horror is desired or required.
This (naively) should be 'ad', not 'zone'. But actually, see http://bugs.rmmonline.com/confluence/display/DEV/RealTimeStats, only undeliveries, selections, impressions, redirects, and clicks can be by 'ad'. blocks can also be by 'reason'. requests, unitloads, and defaults should not accept a "by" parameter.
It takes a method and not a DatabaseFactory itself. From the context, it seems clear that this is a transformative method? It is consistent with QueryEvaluator, Query and Database.
Import SoapHeader
After looking through all previous examples, I'd not give environment sections as examples anymore, as we do not encourage this concept anymore. See for instance the application.config.php of the skeleton application:

https://github.com/zendframework/ZendSkeletonApplication/blob/master/config/application.config.php
I'm wondering if we'd want to use the Zend\Soap\Client implementation. Not sure if you need to do that for this refactor, though.
I agree.  Or we could make simple an option.  I think having a single
#generate would be preferable.

On Fri, Mar 30, 2012 at 12:05 PM, Zachary Belzer <
reply@reply.github.com
> wrote:

> >  #
> >  #   MemorablePassword.new.generate_simple
> >  #   # => "sons3pied"
> > +#
> > +# == Advanced password
> > +# Generate a more advanced, random password by calling #generate.
>
> At this point I had to go look to see what 'more advanced' could possibly
> mean. This could possibly be called 'Configurable Password?' In the future,
> we might just consider making simple_password the version of generate
> without any options.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/AutoCash/memorable_password/pull/1/files#r627184
>
please check the entire message starting at 156.
I consolidated everything in this one function
the private method + dup was initially an attempt to try and share an initial base API.client, and then just dup the authentication piece that needs to be recycled per request. Ended up not being as clean as I had hoped, though I'm thinking of leaving it as is, since Chris will probably do some refactoring when he attempts to consolidate the auth controllers
Instead of adding it here add `require "acts_as_indexed"` to https://github.com/parndt/refinerycms-settings/blob/master/lib/refinery/settings.rb#L2
Cross-site scripting (XSS) vulnerability in the BE User Switch... It doesn't look good for me!
Yes would like some feedback as to where this should live, egypt suggested it could be a lib method.
Debugging, should be pulled out or converted to a dlog(..., LEV_3)
I think the filtering should only occur once. `attach` is called when the plugin is attached to the viewer. In contrast, `add_widget` is called each time a widget is added to a plugin.
Wo you have a tool to see unused imports?
We should convert the documentation in this file to the new doc format.
Even though there is a check for `show` in update, `render` will still be called. If `update` returns `undefined` it is still rendered because right now only the bounding volume and model matrix are returned and neither are required for rendering. So I think we still need to check `show` in `render` until we get to a point where nothing returned by `update` means it isn't rendered.
Same comment as the other intersect test.  However, perhaps `intersect` is a better name than `sideOf` (or whatever) since the former is more likely what the user wants to do.
Each description property should have its own @param tag. Then you can place the default values for each inline using [ ]. See Source/Core/Tipsify.js or  Source/Core/ExtentTessellator.js for some examples.
Yeah I wouldn't be surprised if that was at least part of the problem on that Intel GPU machine I mentioned earlier today.  So what would you suggest?  Cap it to 4 or 8 or something?  Turn it off entirely by default?  Leave it as-is but give the user the option to override it?
Why say `Can be called any number of times`?  That should be obvious.  Also, when referring the other functions, see `@see` and `@link` in the jsdoc-toolkit [tag reference](http://code.google.com/p/jsdoc-toolkit/wiki/TagReference).
Hmm.  I'm not that concerned.  Blue was probably random.  Leave it as white.
"A wrapper", not "An wrapper."
In this case you should use a docstring, not a comment.
http://epydoc.sourceforge.net/docstrings.html

Usually pythonistas use the restructured text format in docstring (usefull when the documentation is automatically generated from the code)
We should group all variable declarations with a single var at the top of the function
This is the only thing I don't like in the whole script.  Do we need that?  If you take it out and "outdent" the stuff below it, then the CR is okay AFAIC.
If it makes you feel any better, I originally typed it the way you are suggesting then changed it when I looked at the other constants in the docs. :)
Since running a command, path needs to be normalized using path.join
What does the toggle button/checkbox thing mean? In Mobile Web, the text is always in the button area.
Actually, ti-verify might be ok, but modules for sure.
This should not be a kroll method. This will expose the API to all of our JS objects
Use "/**".
Can you make sure to escape things properly when using writeOutput?
Unless someone made changes outside of the previous manifests, it won't break older installs. The defaults are still kept as RegionOne and the provider works around it. I think?
Another spurios merge sideeffect I think.
Thanks, updated. How should I build phobos docs to enable custom macros then? I was using dmd -D so far.
Wait, I was being stupid. The types returned by the ranges are irrelevant, since this is the pred version. This should do it:

```D
auto commonPrefix(alias pred, R1, R2)(R1 r1, R2 r2)
    if (isForwardRange!R1 && !isNarrowString!R1 &&
        isNarrowString!R2 &&
        is(typeof(binaryFun!pred(r1.front, r2.front)) : bool))
{
    bool pred2(ElementType!R2 b, ElementType!R1 a) { return binaryFun!pred(a, b); }
    commonPrefix!pred2(r2, r1); //Swap and forward to the other implementation
}

auto commonPrefix(alias pred, R1, R2)(R1 r1, R2 r2)
    if (isNarrowString!R1 &&
        isForwardRange!R2 &&
        is(typeof(binaryFun!pred(r1.front, r2.front)) : bool))
{
    //Same implementation as before...
    //This works because r1 is decoded, whereas r2 is popped/
}
```
`Gets the element type of the innermost array in a multidimensional static array type. Considers $(D T) to be an $(D n)-dimensional static array type.`
The line "string s = cast(string)std.file.read("books.xml");" uses it.
No clue. And why did they accept it before and not now??? I don't know
could  be unfutured!
classの中でrequireしているのはなぜ？
Can we lift these strings out?
Yes, this is supposed to be unindented. It was a bug that it wasn't before.
Leaving it as 2*43200 for now, because 12 hours looks better.
Make sense then I understand the flow. I still have a question, we own a Jenkins CI server and when it's making the full build I inject the environment variables in a pre build task, so how Jenkins will get the credentials for tests when it's running unit tests?
Oh yeah forgot to mention, that `.attr('tabindex', 0)` has to be moved inside `NanoScroll.prototype.generate` as we only bind events here and nothing else.
Please remove the closing PHP tag
Can remove the `type` attribute here and below
Great catch, I didn't even think of the need to rollback a case if something is wrong with a step. Perfect.
Don't we need to handle both? What if someone already has a header-enricher with the amqp_ form? What if there's an "old" message in a message store?
Вообще этот абзац какой-то странный, но оно так и в оригинале
Just a little brute-force correction.
Since the Label attributes are fairly straight forward, I think we can skip the placeholder text.
in this case, we are not finding `_id`, but a attribute inside another nested object, that is not mandatory to have `_id`
I wonder about this interface. Having just read this style of usage in `Background.cpp`:

```
VertexArray *va = new VertexArray(...);
// add vertices to array
Surface *s = mesh->AddSurface();
s->SetVertices(va);
```

It seems that having StaticMesh::AddSurface() create these things introduces an unnecessary interdependency. Would this not be better?

```
VertexArray *va = new VertexArray(...);
// add vertices to array
Surface *s = new Surface(va); // surface takes ownership of vertex array
mesh->AddSurface(s); // mesh takes ownership of surface
```

I'd also remove `Surface::SetVertices` entirely. If we want a new surface, make a new surface - there's no logic in this class so really nothing make it worth the effort of preserving.

Yes, this is a personal preference - I like immutable objects wherever possible.

I'll try this change later, see how it falls out.
Why not return a JulianDate instead of a TimeInterval with JulianDate.MaxValue shoved into the Stop property?
you need to keep the check on the ``isCommentable`` flag. Otherwise, this flag is not respected anymore
I would place it after the ``FOS_COMMENT.post`` call, to avoid issues with ``FOS_COMMENT.serializeObject`` if a listener marks a field as disabled.
kick-start below needs the shift; and $@;
Pleaaaaaaaseeeeeeeeee: document. Explain. :-)
Added message = parameter[1] and removed unicode cast.
(well, not get rid of it since it's already working, but we wouldn't actually have to use it for anything)
I don't think it works, the header is already set at that time. Did you test it?
c'est pour mettre en place le mailer
"twitter": "ki_zu"
The mixin definitely *shouldn't* be required, but it is a much shorter way of getting those fields into this model.  A quick test is to verify that `pub_date` and `pub_status` are both fields that are set.  I think `armstrong.dev`'s main test case ships with assertions to verify that, actually.
"the" activity 
"this method" adds
We can make this `final`, mm? Probably `factory`, too.
I think replacing **\\xfc** with **ü** will increase the readability of these tests
Combine back with unsubscribe
Just got capturing calls to addEventListener for the button / dismiss callbacks.
No need for multiple var statements
can we rename this to m_pProvider to show it's a pointer