don't default test environment to build assets

we will have the hudson builds set this

Change-Id: If662a8b950d787d3281d581ba508af55b9b21dac
Reviewed-on: https://gerrit.instructure.com/8567
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
make helpDialog specs more reliable

before it would fail every other page load in
safari and chrome and always in rake js:test

Change-Id: Ib402796a1374d1c3c9465e8a1ff0aa0a5b2e3e75
Reviewed-on: https://gerrit.instructure.com/8455
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
sent filter for conversations, fixes #7012

test plan:
1. click on the sent filter
2. ensure you only see non-archived conversations where you have written
   at least one message
3. ensure that the timestamp and preview on the left reflect your latest
   message (not necessarily the latest in the conversation)
4. ensure the conversations are sorted by the timestamp of your most
   recent message
5. ensure that when you delete the last message by you in a given
   conversation, that conversation is removed from the ui

Change-Id: I85468d19122f1190bd2c53cb640145b7d14e2b42
smarter sorting in recipient finder, fixes #7044

make sorting smarter when searching for users (i.e. not just browsing).
when finding the best matches, order first by the number of common
contexts (descending), then by name, then by id. when we actually
display those 6 best results in the ui though, we still sort according
to the old logic, namely: contexts first, then users alphabetically

test plan:

 * search for some users
 * make sure the ones you see have the most contexts in common with you

Change-Id: I50f7ba5ea4c7021517eda826ae56a52459ef29ac
fix submission comment migration, clean up data. fixes #7203

also make view resilient to bad data in the future

test plan:

confirm that the dummy conversation messages go away and that people stop
getting dashboard errors

Change-Id: I2d59bf400f7b5b92debf4a4e0af2de2204878cf8
fix the weird border fragments on tinymce boxes

there was an unintended consequence that caused
weird border fragments to start floating on the page
as a result of a external tools button commit.

this reverts the unintended change.

Change-Id: Ie1b462afa5acace197b71f3e17fb2eb42854be83
Reviewed-on: https://gerrit.instructure.com/8599
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
add 'Spec' to spec filename

Change-Id: I94d534e4f1d7207c52f54cea47ca539b852ba487
Reviewed-on: https://gerrit.instructure.com/8627
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Ryan Florence <ryanf@instructure.com>
make question data always a HashWithIndifferentAccess

All the code that works with question data is dependant on
the data being a HashWithIndifferentAccess. This commit
makes sure to use that in AQs and QQs, and made the
accessor to question_data set it to the expected hash
type so that old incorrectly serialized data doesn't have
to be updated.

Test Plan:
 * Create some assessment questions that will run through translate_links
 * When accesssing that data id should be an indifferent access hash
 * When viewing those questions in the UI they should display correctly for students and teachers
 * Manually set question data as a hash on a AQ or QQ, when you access it through the AQ/QQ it should be a HWIA

closes #6897

Change-Id: I526ab886aad2f96a3741330059439b100b6a1011
Reviewed-on: https://gerrit.instructure.com/8623
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
fix submission comment migration, clean up data. fixes #7203

also make view resilient to bad data in the future

test plan:

confirm that the dummy conversation messages go away and that people stop
getting dashboard errors

Change-Id: I2d59bf400f7b5b92debf4a4e0af2de2204878cf8
Reviewed-on: https://gerrit.instructure.com/8578
Reviewed-by: Jacob Fugal <jacob@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
handle zero point multiple choice questions in qti

if a multiple choice question is worth zero points, some
qti vendors label increment the score by zero which doesn't
allow us to determine the correct answer. This commit special
cases this problem to grab the answer that was set instead
if added to. (that is the convention used by the vendor)

Test Plan:
 * Import the .zip fixture that was updated
 * The First multiple choice question should have a correct answer

refs #7219

Change-Id: If5b64d21dea509a49d4635b68242b31633b2ac6d
Reviewed-on: https://gerrit.instructure.com/8610
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
fix the weird border fragments on tinymce boxes

there was an unintended consequence that caused
weird border fragments to start floating on the page
as a result of a external tools button commit.

this reverts the unintended change.

Change-Id: Ie1b462afa5acace197b71f3e17fb2eb42854be83
Reviewed-on: https://gerrit.instructure.com/8599
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
make question data always a HashWithIndifferentAccess

All the code that works with question data is dependant on
the data being a HashWithIndifferentAccess. This commit
makes sure to use that in AQs and QQs, and made the
accessor to question_data set it to the expected hash
type so that old incorrectly serialized data doesn't have
to be updated.

Test Plan:
 * Create some assessment questions that will run through translate_links
 * When accesssing that data id should be an indifferent access hash
 * When viewing those questions in the UI they should display correctly for students and teachers
 * Manually set question data as a hash on a AQ or QQ, when you access it through the AQ/QQ it should be a HWIA

closes #6897

Change-Id: I526ab886aad2f96a3741330059439b100b6a1011
Reviewed-on: https://gerrit.instructure.com/8623
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
fix pseudonym password updates in the app.

test plan:
  * on test account, set account setting admins_can_change_passwords
    to true;
  * log in as admin user;
  * go to /accounts/:account_id/users/:id where :id is the
    id of another user in the test account;
  * edit the login information for that user's pseudonym by changing
    the password;
  * verify that a password change is successful;
  * verify that flash message notifys user of successful pseudonym
    update.

Change-Id: If0f175b973b3d641d9185763a55263a44692acf9
Reviewed-on: https://gerrit.instructure.com/8540
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
BUG #6345 - adding selenium test to cover bug in eportfolios spec

Change-Id: Iacbf41db4b198f41f6a5763c2f9f7af64b57d986
Reviewed-on: https://gerrit.instructure.com/8630
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>
handle zero point multiple choice questions in qti

if a multiple choice question is worth zero points, some
qti vendors label increment the score by zero which doesn't
allow us to determine the correct answer. This commit special
cases this problem to grab the answer that was set instead
if added to. (that is the convention used by the vendor)

Test Plan:
 * Import the .zip fixture that was updated
 * The First multiple choice question should have a correct answer

refs #7219

Change-Id: If5b64d21dea509a49d4635b68242b31633b2ac6d
Reviewed-on: https://gerrit.instructure.com/8610
Reviewed-by: Brian Palmer <brianp@instructure.com>
Tested-by: Hudson <hudson@instructure.com>
fix the weird border fragments on tinymce boxes

there was an unintended consequence that caused
weird border fragments to start floating on the page
as a result of a external tools button commit.

this reverts the unintended change.

Change-Id: Ie1b462afa5acace197b71f3e17fb2eb42854be83
Reviewed-on: https://gerrit.instructure.com/8599
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
make question data always a HashWithIndifferentAccess

All the code that works with question data is dependant on
the data being a HashWithIndifferentAccess. This commit
makes sure to use that in AQs and QQs, and made the
accessor to question_data set it to the expected hash
type so that old incorrectly serialized data doesn't have
to be updated.

Test Plan:
 * Create some assessment questions that will run through translate_links
 * When accesssing that data id should be an indifferent access hash
 * When viewing those questions in the UI they should display correctly for students and teachers
 * Manually set question data as a hash on a AQ or QQ, when you access it through the AQ/QQ it should be a HWIA

closes #6897

Change-Id: I526ab886aad2f96a3741330059439b100b6a1011
Reviewed-on: https://gerrit.instructure.com/8623
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
fix pseudonym password updates in the app.

test plan:
  * on test account, set account setting admins_can_change_passwords
    to true;
  * log in as admin user;
  * go to /accounts/:account_id/users/:id where :id is the
    id of another user in the test account;
  * edit the login information for that user's pseudonym by changing
    the password;
  * verify that a password change is successful;
  * verify that flash message notifys user of successful pseudonym
    update.

Change-Id: If0f175b973b3d641d9185763a55263a44692acf9
Reviewed-on: https://gerrit.instructure.com/8540
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
treesame commit of origin/stable/2012-02-04

Treesame-Commit-Id: b34a5858797e9eeb40f7985502d50fae36da4a26
shorten migration names to avoid postgres index max-length.

test plan:
  * on an empty postgres database, run rake db:initial_setup
    and ensure that no errors are thrown.

Change-Id: I2a4b43a7fa60bcb8e81c5c578b9dfccd19b38a28
Reviewed-on: https://gerrit.instructure.com/8625
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>