labofsahil/github-event-dataset-2012 huggingface dataset:
If the idea here is to limit the number of total queries, why not just do a simple django ORM query, order as needed, and then slice/chunk the results to group all of the curves which belong to a given site? For example:

<pre>
num_sites = len(hc.points_to_compute())
imt = <something>
slice_size = 10  # or whatever
# the query below should also filter by results related to the current `hazard_calculation` record
# this is implied for simplicity of the example
all_curves = models.HazardCurveData.objects.filter(hazard_curve__imt=imt).order_by('location')
# now slice and yield
ranges = xrange(0, num_curves, slice_size)
for i in ranges:
  yield all_curves[i : i + slice_size]
</pre>

Something like that. It's basically the same query/slice algorithm you've written, but it's much simpler. I'm afraid this manager just obscures things; it's rather difficult to grok what's going on.

There's some additional logic here to handle `imt`, `sa_period`, `sa_damping` etc.; I would just encapsulate this in a function or two.
I would at least LOG.debug the actual exception here. While I agree with the assessment here that an exception indicates a missing network, I'm afraid it would accidentally mask other exceptions masquerading as this.
what about `trim: String.prototype.trim`?
"madlib." does not seem to be needed.
c.f. #14384
Don't need the whole error dump, just "undefined symbols when linking" is fine.
Scratch that... changing this has a lot of downstream effects! :(

Keep the original - it works!

Unless we're going to start getting the gollum test suite to run on this thing...
Do we want a helper method here for generating application events for the `EventHandler` (not transport events)
Shouldn't this stay? I seem to remember us recently deciding to just have a better comment (i.e. that we need to implement this method as soon as we start issuing submit_multis).
I think this construct is not needed because it doesn't bring any significant benefits but instead makes the code more difficult to understand.
Forgot to add JSDoc.
This should be wrapped in double brackets to indicate the assignment is intentional:

while( ( child = fragment.firstChild ) ){
Removed in the next commit.
Take care of non-hardcoded paths here as well.
The indentation looks off here and on the following lines.
fMatcher can be null (at least as far as the tests are concerned). fValueMatcher means that you've come in via the constructor which takes a value and a matcher. If you have fAssumption, then you can't tell whether fMatcher was null because it was passed in as null, or null because you came through the other constructor. Same for value,

I'm not bothered if we assume that the matcher is not null, but that's the way the tests were written before, and I didn't want to change it, I wanted to keep pretty much the same error messages.
Ok. The reason I added it is that PUT requests were being rejected by nginx even though it didn't have a payload.

Will update the unit tests before merging.
Do these certs belong here or were they just for development?
We have a mixin that does this: `@include pullout`.
Interesting. I assume LESS is ok with hyphens here as arg names. It doesn't match bootstrap's conventions though. May be worth asking XD, but I'm ok with this change.
I though I did the merge but apparently I just closed the issue. I'm asking Randy to resubmit a new pull request.
I think it would be nice to refactor CodeHintManager so it provided the cursor and tag info for the various calls that use them (getQueryString, handlSelect, etc)
Should specify more clearly what this means when multiple bindings are passed.  It seems to mean 'is any _one_ binding valid'... is that actually what we want?
Typo: no "a"
I'll look into it before creating the pull request again.
Same toString() comment as above.
Please don't use this import style. Either import what you need, or import migrate itself (like I do with sqlalchemy).
best to specify what sort of exception you're catching
you can do ListenableFuture<FramedClientChannel> connectFuture = niftyClient.connectAsync(new FramedClientChaannel.Factory(),
I am going to find a better way to write this loop.  I need to read up on async control flow :)
This should probably be a nullable long.
public long? lastViewedCupupId;
Then instead of checking for -1 you check .HasValue
I think that it would be clearer to write the condition when two TocTreeNodeLayer are equal :

this.layer != null && this.layer.equals(other.layer)

I suppose that if this.layer == other.layer, this.layer.equals(other.layer)
Almost there. For the sake of clarity whenever an object is referred to outside it's definition you use the fully qualified name. So in this case you would use "Map.Edge.MapNodeId2Node" instead of "Edge.MapNodeId2Node" Update the file and you'll be good to go.
Hehe, that's right... :) However, it has to be `callback.call(el, idx, el) !== false`, because only a `false` return value, and not a `null` or a `undefined` one, should stop the iteration.

I'll change it.
Well, than I have to delete second default and everything will be ok?
Fixed. But i used mongoengine.EmbeddedDocumentField.
I'm flexible on including the _page suffix, depending on making sure this is consistent.
I'll check that out
This is really long and wordy.  Let's shorten it to indicate that not all web pages can be displayed within another web page (i.e., drop the technical stuff).  At the end you can have a link to read more details on the MDN page.  Make it short, to the point, and actionable vs. teaching them a lesson here.
Just add some spacing before the last bracket here.
Make sure you bump this back to 30
Shouldn't we be able to just include the IOStore.h call here?
duh ;)
scroll ro id kon
Oh thanks, its commented out but still - I will correct this. I am glad you are back :-)
I think you might have to do a to_s  at the end of that.
You probably want to toggle a css class here.
Yes, see here: http://pypi.python.org/pypi/APLpy/0.9.8
Haven't looked carefully at the hooks code, but would the write of the new bucket/key happen after the put request has returned a reply? If so, then we have yet another timing issue and would need a way to handle in the test.
This is part of CreateNewBlock, which always calls ConnectBlock with fJustCheck. A dummy scriptSig is needed to pass the "scriptSig must be between 2 and 100 octets long" rule.
This whitespacing looks a bit inconsistent with CakePHP's style.  There should only be one space around the `=>` and array keys should be indented one tab from the surrounding scope.
Yeah, its a bit of a confusing thing because its a local pid and not a remote {Node, Ref} pair for communication. Rather than be subtle about it I wanted to make sure that things stayed separate.
before_id
Use Nil here (same result, but cleaner)
Why change this? You need at least one character in order to make a valid attribute name.
Ahh, I gotcha... was backwards.
jQuery/jQueryUI have the ability to animate css properties, can we use that instead of this css?  I think it will give us better cross browser coverage.
`cast_bytes_py2` casts to bytes (which is the same as str) on Python 2, and doesn't do anything on Python 3.
Any chance you can add the newline at the end?  Otherwise looks great to me.
This line is commented out because it results in a ValueError:

```python:
ValueError: Sorry, cannot pickle code objects with closures
```
Any ideas?
I prefer to have a separate class for this just to make the intention clear.
https://github.com/kaltura/mwEmbed/commit/df3a0a7886e0ad7617bb5d653085ae79edcf4719#diff-4
I can expose this on the parser
This irks me. Is `indexer_progress` the right name for a callback that will also report network operations?
Instead of an inline span for the arrow, you can add it with CSS: .cta .button:after { content: " »"; }
You should remove whitespace here to make it easier in the Python code.
doc string would be helpful
*Only (sorry for being super nit-ty again)
cleaner... and macros > includes :+1:
sounds good.  but authentication still seems right, doesn't it?  I mean, usernames are pretty harmless anyhow.  But still seems better safe than sorry?
single quotes (nit)
Interesting. I had assumed this would show up on the Pages model, but given that Pages model is getting big, I like this.

Note to self: add code to ignore course pages.
There was one file where the whole thing got accidentally reformatted, this was it. I will fix these along with the other changes you noted.
Is the intent of this config file to only add InterestManagerDialog.js? To avoid code repetition, I recommend only having InterestManagerDialog.js in this file, and then use multiple --config parameters to add the dialog to run. This file to otherwise duplicate all plugin specifications, and would require duplicated maintaining along the side of viewer.xml and plugins.xml.
@jcredding there are some inconsistencies here.  Above you use `self.<reader_name>` to access all the readers.  I would like this changed to either be `self.timeout` to match above, or (even better) don't bother using the dumb readers and just use the instance vars straight up (both here and above).

```ruby
request = Sanford::Protocol::Request.parse(self.read(@timeout))
```
подивись форматування в інших методах і зроби по аналогії
I think you are right.  I'll make sure tonight.. wasn't sure if the Node version was different since I switched to using the "CommonJS" form of the require() syntax.  If so, I'll remove; good question.
Some spaces are missing. Can be fixed with php-cs-fixer.
Well, do we really need to provide BC outside the full-stack framework ? The profiler was not supported outside the framework previously.

thus, if you really want to provide BC, you should provide it for all methods of the GlobalVariables class, not only for the Request getter.
"characters" is not consistent with "element(s)"
but it is a deps of the Form component, not of the twig bridge. So there is no reason to list it here. Composer will install it when installing Form. Listing deps of you deps is not a good idea as it means you are doing part of composer's job by hand
Missing info about new param.
It won't change anything. Since it's not in the official list and I'm quite sure that it wasn't used anywhere I've dropped it. If you feel better with it - go ahead and re-add it... but you should at least change the comment then to say that the table contains the official ones defined by IANA + 418.
Why do you want to remove this part?
Great! It is correct for Chuvash language, it is also according to [a month template in Chuvash Wikipedia with short weekdays names](http://cv.wikipedia.org/wiki/%D0%A8%D0%B0%D0%B1%D0%BB%D0%BE%D0%BD:%D0%9F%D1%83%D1%88_%D1%83%D0%B9%C4%83%D1%85%C4%95)
GJ Roman,

I dont know How is that happened... hnn....

Interesting...
Does the concept of payments thru C&P still exist?  
I am assuming we have removed notifications is you dropped this.
Duplicating constant.
This problem has been resolved, it would be better to delete it.
jedes Fragezeichen wird in ein zufaelliges Zeichen umgewandelt
A simple docstring here would be good.
Статические методы можно передавать 3 параметром в inherit
These numbers come from real-world testing of the Icarus speed as measured by cgminer (which is what matters here)
"there is one is cms" should be "there is one in django CMS", right?
It would probably be more efficient to do:
```python
    if key.endswith("*") and tag.startswith(key[:-1]):
        return TAG_CLASSES[key]
```
Hello,
there was an example included in an older version of the connection handover specs. 
http://www.maintag.fr/fichiers/pdf-fr/nfcforum-ts-connectionhandover-1-1.pdf

But i'm not sure, if this example is consistent with the current version.
Same comment as on line 269.
I tried to not touch the old code as much as possible, so logs are
oldstyle. I was not sure about fixing that, will do today. I guess that
since I've started changing the old code, I should also activate checkstyle
plugin and fix the related issues.

-- Eduardo
No dia 18/07/2012 20:46, "Jason T. Greene" <
reply@reply.github.com>
escreveu:

> > +     * @param name Name specified by the creator of the MBean. Note
> that you can overwrite it when the given ObjectName is null
> > +     *        otherwise the change is discarded (maybe a bug in JMX-RI).
> > +     * @return the ObjectName
> > +     * @throws Exception for any error
> > +     */
> > +    public ObjectName preRegister(MBeanServer server, ObjectName name)
> throws Exception {
> > +        this.server = server;
> > +
> > +        serviceName = getObjectName(server, name);
> > +
> > +        return serviceName;
> > +    }
> > +
> > +    public void postRegister(Boolean registrationDone) {
> > +        if (!registrationDone.booleanValue()) {
> > +            log.info("Registration is not done -> stop");
>
> This violates our logging statements
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/jboss-as/pull/2668/files#r1191177
>
No replacement here? No needed anymore, or just not yet implemented?
Is this include necessary? I'm not familiar with `conio.h`, but I found [this](http://en.wikipedia.org/wiki/Conio.h).
Why do you need to change that?
sure, very true.
You will need to fix unit tests mock as well, in order to be a constructor
No, there are not included in the properties file. Let me update it ;-)
You are tracking the setting value at L555 and below. You should not need to get the setting value here again every time WifiManager API reports status change.
ok

friends-message
num-friends
Does it means the landing-page will always be visible and keep in-memory? Or will it also be display: none when it is not moving?
the date and time will overlap the "Last updated" label otherwise. I hunted around for a classname I could reuse but didn't see any -- feel free to enlighten me :). I also found a bug if no Last Updated date was found, so I will push that fix to my branch soon.

Do we have any automated way to test the settings UI code?
I don't see this as part of the commit? was Gesture Detector added in a different one?
nit: two-space indentation please

+ is there a reason for leaving an empty id attribute?
As we dont know it this 'name' is the definitive one (there was changes in communications/dialer for example) we could keep this way of retrieving the appname until confirm it. I will send an email to UX in order to ensure which is gonna be the definitive name, but I think that could be updated in a next PR ;) Thanks for the tip!
This looks fine I guess.
There is an indentation issue. Also if you want to make the code a bit simpler I would use:

      var header = ConversationListView.createNewHeader(msg) || '';
      fragment += header;
Let's also have this method return the IMetric that was passed in, so that you can do things like:

```java
_metric = context.registerMetric("foo", new CountMetric(), 5);
```

instead of:

```java
_metric = new CountMetric();
context.registerMetric("foo", _metric, 5);
```

When you pass in a reducer or combiner, it will return a ReducedMetric or CombinedMetric appropriately.
yeah... I see. will do.
format expects 2 arguments, but only 1 is given.
закомменченный код нам не нужен. или если нужен - нужно раскомменчивать
Javadocs :P
@Afforess I can return true, but if the final region file doesn't contain data it would invalidly load it.
The 'in progress' is only true while a new SimpleRegionFile is created. This all happens within one function and is almost instant.
This is factored in the triggerable tests.
I think perhaps we should avoid sending `tags` if it is `None`, to maintain compatibility with old servers.
Added LRUCache.keys() method.
you could keep the array inline. It does not make the line too long and is more readable as the main part of the statement is not about defining the array but about doing the condition
wonder why this second call without arguments on validateSchema()
Please only modify the English locale.
`printf` is portable and much more reliable than `echo -e`
Following the convention of `filters.scala.html` - it's actually useful here because it's a bit more straightforward to control output (there are quite a few leagues here we don't want to display, and they're not in the order we want them in, etc).
I think these should be name spaced, other people may be using a similar script from somewhere with tweaks
Fixing this...
valid, by the looks of it
I don't totally understand why you need to make the metadata as strings to re-parse them later. 
It might be due to the current implementation of nbconvert if there are things to change elsewhere to make it easier, than maybe we can do so.
```ruby
def context_needs(*keys)
  missing = keys.reject { |k| context.include? k }

  if missing.any?
    raise ArgumentError, "Missing context keys: #{missing.map(&:inspect).join ', '}"
  end
end
```

I can handle a `.map(&:to_sym)` in there if it's absolutely necessary, but I don't think it is. Symbols and Strings aren't interchangeable, and we shouldn't treat 'em like they are.
We need the login position for so you can put modules on the admin login page if you wish
I can fix this post-merge, but document comments for config attributes are taken as markdown later for the documentation generator, so you'll want a blank line between 'for example' and your indented examples I think
We could use iframe yeah, to this point I don't really see cons and pros between two, but somehow I was considering browsers to be better, but sure I'll change to iframe to keep whatever we used to.
should this be `Module.submit` instead?
heh, that might be more complicated - are you entirely sure it's better to use spaces than tabs?
in the end displaying is user preference with tabs.
I do enjoy 4 spaces indentation, I see you seem to prefer 2 spaces ...
Do capital U, C, and P work, too? I know we use lowercase u, c and p. I ask because this seems to suggest they should be capitalized and if that doesn't work, then that'd be misleading.
It looks like the wrong pattern in this case, how about just adding a fully documented kwarg that change the interpretation of `y_true` and `y_pred` ?
My opinion is that maybe in the makefile , 
we can copy the template and apply a patch on it. What do you think about that ?
Can we default this to `true`?
@cristianoc72 When you will rebase your branch, don't keep this file.
The scope doesn't get called with a method named `notice`. The method is named `function_notice`.
dont' want to do this - we would want to continue to use delegation here. something like `* > li` should work`.
A comment here would be nice. 
...to explain why it defaults back to "upload_file_minidump"
This computes the callback values for the entire row using a callback function assigned to a specific column, every time a new cell is displayed. Obviously we can't have that....
protected visibility, please.
This test should use a dataProvider, instead of having the array of values/assertions and foreach loop.
The same observations than Filter
My bad, please ignore my mistake.
Should be a block `// CraftBukkit start` and `end` as whitespace is being changed in between
Personal preference: I'd rather have more descriptive type names than "Tok". Maybe "TokenType"? I know it's private, and fairly clear, but we have plenty of disk space, so I think we can handle an extra 6 characters per type reference :P
Yes. This is better.
Actually, we need to wrap batch calls in try/catch, just like JSON.parse. However in order to do this I'll need to refactor add/del/destroy emission to not occur until the end of a batch operation. Stay tuned...
change the signature of doneEditing to
void doneEditing(event) {

}
and you can simplify this line to be
editElement.on.blur.add(doneEditing);
Can we just kill this entire method, everywhere it's called and all of the commented lines?  None of it needs to be here any more.
You've got a typo for `element` in the descriptions.
@harjis Pupe-styleguiden mukaan ollaan aina pidetty stringit paksuissa hipsuissa
that's how it was explained: http://benalman.com/code/projects/jquery-message-queuing/examples/ajax/
This class should be simplified as it duplicates some code from its new parent class
Something like below, maybe ?

    SITEMAP_FORMAT = 'xml'

    SITEMAP_CHANGEFREQS = {
        'articles' : 'monthly',
        'indexes' : 'daily',
        'pages' : 'monthly'
    }

    SITEMAP_PRIORITIES = {
        'articles' : 0.5,
        'indexes' : 0.7,
        'pages' : 0.5
    }
So changing to hpcgroup anyways :-p
use self.__class__ here
Idem. Fugly.
Put this in a function `void usage(void)`. Backward gotos are a minor evil.
Perhaps this should be `>= 1.2`, so it doesn't fail when the dev stuff is dropped when making a release?
So yeah, like I was saying before: if you do `filter(id=address_id)` and then run `.update(point='stuff')` on it, you'll avoid save. Just use a `LIMIT 1` and it should be just as fast. Or since it's a PK it might not even need it, but you can add it anyway :-)
Pushing those in now, mea culpa.
Nevermind, @zenspider showed me how I suck. Ugh.
Can this leave some events not belonging to any category?
Can you think of a way of creating a more deterministic test?  As you say, using sleep() isn't something we really want.   I'm not saying you need to provide another test, but if you have any idea on how to do it, we could create a Jira issue on it...
Consider renaming this class JerseyRbacResourceFilterFactory - it is shorter and RBAC is an acronym people using it should know. (If you do, it is best to do in a separate commit, and definitely requires a new release so we don't break existing clients.)
Is there a chance this will try to execute before curl finishes, or does this block only execute after the shell command has finished executing?
беззнаковый тип, и какие-нибудь ассоциации о том, что это вершина в названии переменной
а если Cmp не имеет конструктора по умолчанию?
called on FileReader
it didn't turn fast enough
Again, any reason for the space separating this locator? Also, this looks fragile. I would suggest `(By.CSS_SELECTOR, '.messages .message')`
**reject!** line should not be removed, is needed to build the language list used by filters
We don't depend on nose at the moment; can you use `self.assertEqual` instead?
Can this be

    cache_root.rm_r
A sidenote: we shouldn't be using req.user but rather req.ctx.user()
It doesn't anymore. Fixed.
Not sure if there was a problem with the merge but there is JSDoc in master that reads `Switches the login strategy view when a tab is clicked`. I'll add to that to make it clearer.
We should still return an error when the login has failed.
Please single-quote the err key of this hash.
Extra whitespace!
May I ask why (is it that obvious?)
Heres where i think we should setup the default check

```ruby
@registry ||= {"default" => OKComputer::DefaultCheck.new}
```
Really? Okay ;)
:user is not set
I see that you don't set it in the edit action.
а каким образом вы бы это реальзовали?посмотрел у вас процедуру mutate и не понял)
Есть неточность. Не проверяется, что в этой позиции находится.

Например:
* self.DNA содержит TGAAA...
* [[shuffle objectAtIndex:i] integerValue] = 3
* [self.arrayOfDNAChars objectAtIndex:randNum]= A

Фактически замены не произойдет.
представьте сколько времени будет выполняться этот цикл если X=99 :( как уже писали на форуме, лучше бы массив перемешать. быстрее будет
Как хотите, так и сделайте, просто имейте четкое представление, как у вас делается. Не считаю отсутствие округления поводом снижать оценку. Но вы должны понимать, почему работает так, а не иначе. 
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
Импортировать NSArray не нужно, он включен в Foundation!
При percent == 0 программа падает.
const * char?
На мой взгляд оптимизация проста и добавляет читабельности. Про критичность не буду спорить - между 100 и 500 итерациями, в данном случае, разница действительно незаметная.
However, I was able to squash the requiredFields mapping into the same loop as the input remapping after deduplication. So, good call :)
It means "if the install location does contain spaces."  I can push up a clarification to the wording.
Btw, it seems that `imageinterlace` takes an integer as second argument
I think it would make more sense for this to be named `ShardKeys`, unless there is some alternative use case I'm missing. Additionally, we can consider mapping one or more fields with `@ShardKey` down the line. Specifying an array of MongoDB field names (they're not property names, right?) as a class-level annotation works for now, though.
Those are different, because they do work only if the thing needs that effect (i.e., has been marked for it previously). Check out the methods I linked – they behave very similarly to this one.
I don't recollect doing that code, maybe it's probably a change on master that is not yet in the NPM package.
it's faster and I find it more explicit as it means that it applies to a float and not an array
baseline

this tells me that this line is not tested :(
same for plot
> Is fine with me. Just had this because it runs quicker, was working example if you wish ;-)

no problem. Let's remove it then now.
See a comment above or https://tickets.openmrs.org/browse/TRUNK-2767
Offhand I don't see why you're using a WeakHashMap here. Also, per a comment further down, I think this map needs to move to ModuleFactory.
If we capitalize Development, we should capitalize Operations.
Background these steps :point_up:
So does this actually work? Even if jQuery doesn't find anything, it still returns a non-null/non-undefined thing...
does this need to be exported? if not, export `parseParams` explicitly.
You can read the CS here: http://symfony.com/doc/current/contributing/code/standards.html

And the actual coding standard for this is [PSR-3](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#3-namespace-and-use-declarations):

 > There MUST be one use keyword per declaration.
"with CSS"
This change is IDE-specific so should go in your local .gitignore file, not the project's .gitignore file
I'm also not sure about this one.    A trailing comment can preserve vertical white-space very productively especially in a case like this.   A gratuitous new line just makes it more difficult to put a single idea into the visual field.
Ну вот ты автоматом заливаешь и шаришь.
Why class here over module?
What about Nginx ?
It is always Live Online/Offline. see Else
Also,  most of the comparison functions depend just on computing the amount of pairwise agreements or number of disagreements between all the data groupings, which is what the baseclass does.
There is no code here
What is the effect of this change in old, 5.1.x, clients?
Hmmm, if it's uncontended, why try acquiring the lock?
Yes, very boring to see and hard to maintain it later.
-O3 optimization is generally not recommended for a number of reasons. Use -O2 for the release build instead. See:  http://www.gentoo.org/doc/en/gcc-optimization.xml#doc_chap2_sect3
Although it is just a variable name in this context, the use case from Tony's errorfill is offsetting in the y-axis direction.  Thus naming everything x and xerr might be a little confusing.  Perhaps y and yerr would be better?
Just a thought... just how different are the call signatures for stem() and
plot()?  Perhaps we can utilize the same mechanism for processing arguments?
Yes sir. See #1480.
I don't think that stopping all connections of a specific domaintype is desirable.
I think this method should take a serviceid or instance as an argument.
@drak Except none of those examples include an acronym; so the prescription is ambiguous at best.
Ah soap, where everything is 200 OK. ;D
I will implement more cases. Actually your case - only the types from array
pass, the other fails - is tested by:

> +      pb.validate({h:1},function(err,res){
> +        assert.isNotNull(err)
> +        assert.equal(err.parambulator.code,'type$')
> +      })

In this case we have an error because the value is number and we expect
only:

h: {type$:['date','string','array']}



On Tue, Sep 11, 2012 at 8:05 PM, Richard Rodger <notifications@github.com>wrote:

> In test/type.js:
>
> > @@ -27,6 +28,21 @@ vows.describe('type').addBatch({
> >        }
> >      },
> >
> > +    'multi-types': function( pb ) {
> > +      pb.validate({},function(err,res){
> > +        assert.isNull(err)
> > +      })
> > +
> > +      pb.validate({h:'foo'},function(err,res){
> > +        assert.isNull(err)
> > +      })
> > +
> > +      pb.validate({h:1},function(err,res){
> > +        assert.isNotNull(err)
> > +        assert.equal(err.parambulator.code,'type$')
> > +      })
> > +    },
> > +
> >
>
> this test needs to cover more cases
> in particular it needs to show that only the types in the array will pass,
> and all others fail
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rjrodger/parambulator/pull/13/files#r1577909>.
>
>



-- 

*malex*
"add-new-question" doesn't follow our pattern?
since `user` might not be a User maybe we should change it to `owner`
As a general comment, if we're reconciling a page as part of eviction to increase memory availability, should we think about ways to short-circuit the reconciliation?   For example, if we ever see a skipped UPD element, we could simply return failure and not continue, that is, why write the page if it's not going to allow us to evict it?

Alternatively, is there any information we could store in the page (the most recent txn modification?) that would allow eviction to incorporate the likelihood of hitting skipped UPD elements into the decision on whether or not page eviction should be attempted?   We currently use read-generation to select pages, so this would be in addition to, not a replacement of, the current algorithm.
On Thu, May 17, 2012 at 8:49 AM, Michael Cahill <
reply@reply.github.com
> wrote:

> Well, it means we're explicitly ignoring some pointer that was previously
> in use.  Decrementing this count (by shuffling pointers around) is
> effectively the reason why the check can race with a close at the moment.


Right, but if we don't shuffle pointers, just, if the session we're closing
is the last active entry, we decrement session_cnt back to the new "last
active entry", we're not doing any pointer shuffling at all, and the list
stays relatively compact.

--keith

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Keith Bostic
keith.bostic@wiredtiger.com
I suggest
> As of Python 2.7, unittest supports (recursive) test module discovery.
All test modules should exist somewhere inside `src/freeseer/test/` so that the test suite can find them.
Are you sure you want to override the parameter ``$filter``? This often makes code less readable.
add space before else
removed this is unnecessary
I'm in a organization (LogicalBrikcs) but using github-notifier I can't get all the activities of my organization. I needed because we are a small company.
I just said that because the Amazon made me think of it.
I got a typo, it says JViewLeacy. I'll fix it in a bit.
Should this be inheriting from `Args`? (I don't know offhand the Java SDK's convention for specific arg-classes.)
Do you mean the object in the main file?
Remind me to talk with you about hard-coding URLs. ;-)
This is strange way of splitting. I don't like this automatic splitting without context. This is much more readable:

```
var post_options = $('<ul />').addClass('options').append(
    $('<li/>').append(
        $('<a />').addClass('delete-post').addClass('hand').text(gettext("Delete post"))
    )
);
```
When user selected value with empty id that somehow didn't validate correctly and TemplateResponseMixin raised error for missing template.
This is obvious what you are doing here. Or at least it should be obvious from the code. So `api_models.Notification.objects.create` tells exactly the same as your comment.
Google "Python assertion". ;-)
Not `author`. It is not `author` who has notification.
Done in gh-500
You can remove "At this" here.
Используем обычный массив
I see that you're collecting a rolling window of usage history in a linked list but I don't see where it's being used anywhere, except for the most recent usage.  If this is not being used it should be simplified to store just the most recent usage, or if there are plans to use the rolling history then you might consider using a higher-level data structure that better conceptualizes what you want to do, i.e. Queue<T>.  Even better, create a CircularQueue<T> that encapsulates the logic of throwing out the oldest element when it's full, which keeps that bookkeeping logic out of Instance.
I will update the example, the code works in both cases though.
The (bool) is not needed, NULL is automatically casted to false, and everything other than NULL, is casted to true.
Omit  owner for now. We'll add it back in once user resource has been implemented.
Hmmm, I would actually refactor this more:

$( "#sayHello" ).click( function( event ) {
    event.preventDefault();

    var result = $( "#result" ),
        name = $.trim( $( "#name" ).val() );

    if ( !name || !name.length ) {
        result.addClass( "invalid" ).text( "may not be empty" );
        return;
    }

and then you also no longer need line 54
I believe right now it still works, so we could leave it. Eventually though, it will not so then we'll have to remember to change it. I think I will be taking that functionality out before 1.0.0.Final so that we don't have to deal with deprecating it when SyncManager is added.
The `RaiseActionExceptions ` constant should be defined before `:: ActionController::TestCase::Behavior` is included.
I can remove when I merge down, or just update the pull request.

On Fri, Mar 16, 2012 at 12:01 PM, Chaitanya Kuber <
reply@reply.github.com
> wrote:

> >        */
> >       public function perform(Resque_Job $job)
> >       {
> >               try {
> > +                     $this->log("afterFork being triggered",
> self::LOG_VERBOSE);
>
> yeah, oops
> sorry
>
>
> On 16 March 2012 12:00, Chris Boulton <
> reply@reply.github.com
> > wrote:
>
> > >        */
> > >       public function perform(Resque_Job $job)
> > >       {
> > >               try {
> > > +                     $this->log("afterFork being triggered",
> > self::LOG_VERBOSE);
> >
> > Debug code? :)
> >
> > ---
> > Reply to this email directly or view it on GitHub:
> > https://github.com/chrisboulton/php-resque/pull/49/files#r566325
> >
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/chrisboulton/php-resque/pull/49/files#r566327
>
Semicolon thief!
> but I'm trying to express the "IF you use a Maven like tool"

sure, but it sounds akward imo. Our days a maven dependency example is pretty much understood by any developer worth its money. Chances are if they don't understand it and don't know how to transfer this to their build tool of choice they should not be using OGM in the first place
I guess I anticipated using something with an underscore in it soon enough...

You're right I should use the AS methods though, I guess I was just in the mindset of this being a gem and didn't want to have extra dependencies; but, it's a gem for Rails apps. so :smile:
add "or contains references to the exact same DOM elements."
Я правильно понимаю? Две строки в одном пакете не уживуться?
This kinda config probably belongs in a yaml file in config, that way you can give it environments the same way database.yml has them.   Then you can initialize a constant in config/initializers/neo4j.rb

config/neo4j.yml
```yml
---
development:
  :db_url: http://localhost:7474
```

config/initializers/neo4j.rb
```ruby
NEO4J_CONFIG = YAML::load_file(File.join(Rails.root, "config", "neo4j.yaml"))[Rails.env]
```

Then here you can just say

```ruby
def neo
  Neography::Rest.new(NEO4J_CONFIG[:db_url])
end
```
I doubt it. Fixing.
Why not 0.55 (or 0.5 even)?
What does "test compiling", here and in `ngx_url_async_fetcher.cc`, mean?
I think this should be capitalised (`AtmosphereParameters`). I admit we're not totally consistent about this (or anything else for that matter).
Chris, I have a problem.
I modified the "options.ui" file for moving the random checkbox to connection tab. After I changed, it looked correct when I open the "options.ui" in Qt Creator. Yet, after I compiled, installed, and run it, the interface still showed the old one( which is that the random checkbox is in the behavior tab).
I tried to make clean and compile again, but still no luck...
thank  you Chris.
Yeah, it's supposed to pass the array ivar. I will fix that.
Make the button bigger!! :rage1:
Can you cleanup all the whitespace at the beginning of the docstrings? The docs should start on either the line with """ or the next. I don't know if Sphinx/numpydoc will strip it, but I doubt it.
cool. thanks very much for this!! 

yeh, maybe could be a little cleaner if you do something like this for location? 

```ruby
  [raw_info['city'], raw_info['state'], raw_info['country']].reject(&:blank?).join(', ')
```

or even

```ruby
  raw_info.slice('city', 'state', 'country').values.reject(&:blank?).join(', ')
```
Is it normal to put platform specific attribute settings in a separate recipe file?
Let's leave it in (without the TODO).
The intent is to make it easier to use it in Cluster etc where you need to pass in a factory or closure.
Done. Adding this filter lazily when you call getClient() on a BrooklynCommand implementation.
tricky one ... in some cases it might merit a warning and a trace might be useful ... but sometimes it's benign.  benign when e.g. we are polling for status before status is fully reported.  alternative would be to put a guard in every sensor calculation.

ideal way if this becomes a priority i think is to expose a "strict mode" or other per-adapter configuration.  for now i don't think we need that; we have tests for sensors and it is easy for user to see that they are working at runtime (and in event it isn't working the trace will be marginally useful, likely you'll want breakpoints instead and value of underlying data fields).

so balance for now seems to make sure we don't warn on stuff that is benign and we don't make it too onerous to deal with intermittent or slow-to-start sensors.  open to change if we have user-evidence that we've gotten the balance wrong.
Perhaps use ImmutableSet.copyOf instead of newHashSet?
Well.. it can't happen, but who knows - in the future it may happen, so the error message is in line with how mongo_process_options() defines the return values :)
Did you ever test just `Object` instead of `Object.prototype.constructor`?  I found that it seemed to work the same.

I'm actually not in support of this method landing in underscore.  Unless underscore can use it internally, it feels like a bloat.
I'll get on it, thanks for the help.
Why is this set to "none" ?
Okay, let's do that separately.
I guess this can be removed but I will do that in a followup.
This showNormal will also unmaximize a maximized window-- better to use showNormalIfMinimized from  https://github.com/laanwj/bitcoin/blob/2012_02_altminimizetray/src/qt/bitcoingui.cpp#L792
Do you think it would be better to use an input tag here?  I'm not sure.
autocrlf is an option when installing git, the proper setting changes windows style line ends (which are crlf) to linux style line ends (which are just lf)
I can't tell whether you've messed that setting up, since you committed a different file that didn't have this issue, unless BYOND also does line ends the linux style automatically, or notepad screws something up that git cant handle
Shouldn't this be checking for PATHDESIRED_MODE_RETURNTOHOME?  Looks like copy/paste error with POSITIONHOLD below.
The default is text/plain:

http://www.w3.org/TR/html401/interact/forms.html#h-17.13.4.2

Discovered this when trying to fix it myself, had set the content-type like
you did but it was the HttpRequestWrapper bit that I didn't work out.

Thanks again for sorting this, I spent hours banging my head on the desk


On 7 November 2012 09:26, Sergey Bogdanov <notifications@github.com> wrote:

> In src/ServiceStack.Common/ServiceClient.Web/ServiceClientBase.cs:
>
> > @@ -904,10 +904,8 @@ public virtual TResponse PostFileWithRequest<TResponse>(string relativeOrAbsolut
> >                      {
> >                          outputStream.Write(boundary + newLine);
> >                          outputStream.Write("Content-Disposition: form-data;name=\"{0}\"{1}".FormatWith(key, newLine));
> > -                        outputStream.Write("Content-Type: text/plain;charset=utf-8{0}{1}".FormatWith(newLine, newLine));
> > -
> > -                        var value = Encoding.UTF8.GetBytes(string.Concat(nameValueCollection[key], newLine));
> > -                        outputStream.Write(value, 0, value.Length);
> > +                        outputStream.Write("Content-Type: charset=utf-8{0}{1}".FormatWith(newLine, newLine));
>
> I would live Content-Type: text/plain not sure that we can just put it as
> empty.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ServiceStack/ServiceStack/pull/327/files#r2053074>.
>
>
Maybe s/public/private to the constructor below?
same for this method.  I would like to understand how it works.
Why is it that we need to set the width and height  as an attribute from the computed css values?
We should decide--suite-wise--if  it's "pre_approval" or "preapproval" in method names
well, what's wrong with just using an ID as django.contrib.comments does? (it turns the URL into url + "#c" + id )
please rename the variable to `label_text`
I think this is covered by an "<unknown>" kernel in the test.
using a float formatter for error (i.e. ``"error = %.4f\\nsamples = %d\\nvalue = %s"``) would make the plots more canonical.
The variable names are confusing, in particular since you have both `P` and `p`.
True, it isn't big. Just trying to conserve memory if possible and the check for sample_weight being None didn't add a lot of overhead in the code.
This assumes that only ``fit_intercept`` could touche X in later steps, therefore no copy is needed 
if ``fit_intercept=False``? I like this, but a comment could be useful. For me it's not that obvious what's happening here but if this is common in sklearn it's okay.
2012/9/12 Olivier Grisel <notifications@github.com>

> In sklearn/linear_model/stochastic_gradient.py:
>
> > @@ -571,6 +571,12 @@ def decision_function(self, X):
> >              The signed 'distances' to the hyperplane(s).
> >          """
> >          X = atleast2d_or_csr(X)
> > +        return self._decision_function(X)
> > +
> > +    def _decision_function(self, X):
>
> Do you have a real-life situation where that extra function call overhead
> is significative? I think that people who have that level of latency
> requirement might rewrite the predict proba code in cython or C in their
> wrapping loop instead and short circuit the whole python interpreter
> overhead (+ input checks).
>

Agreed - preliminary optimization - lets forget it for the time being.

> —
> Reply to this email directly or view it on GitHub<https://github.com/scikit-learn/scikit-learn/pull/1141/files#r1589158>.
>
>



-- 
Peter Prettenhofer
I'm not sure we should be caching here, mostly we'll only really query once.
I should also mention that this method will be called once per SessionFactory (of which most apps will only have one) per application.
I'm unaware of any other packaging systems that use it, but my knowledge is limited :)

Thanks for your work on this! :)
Noise. Retira isso por favor.
I'll add a note that it's true for any "basic" data types, even Objects.  Also, that's what underscore uses in its "isFoo" methods, where "Foo" is one of the basic types, like "String", "Boolean", etc.  I've tested this to get the exact "formula".  :)
This seems like odd formatting.
peut-on parler de selection dans une route API ?
the flush() should prevent it...
IMO the real benefits are not in execution performance (any difference in speed will be insignificant compared to the network latency), but rather in the maintainability of the code and to simplify the writing of the code in the first place.
There is a certain irony that as I write this I am having to do something similar in JavaScript as I don’t have the option to generate js stubs from WSDL.  But I am at least able to have a common XML_DOM->JS_OBJECT library, which helps avoid human errors.
All the above aside, you should add a “?ver_=X.YZ” to the URLs so at least you don’t break if the interface changes…
Can't really move it closer (one use is in nested block). But not sure it's worth having at all (should rather put inline on HugeHeaplet::dataOffset() which is a constant...)
Oh nevermind I see the legacy handling here, ok.
This breaks user supplied tuplizers behavior.
就先加空白吧
typo: protoype instead of prototype.
I think this originally meant 'to manually test the extension'. Perhaps to make this even clearer we should say 'to run the tests against the extension'?
Is it necessary to have symlink in vendor/assets/stylesheets/converge-ui? For me it was more intuitive, when symlink for converge-ui asset was directly in **app/assets/stylesheets/converge-ui/**.

This applies for all assets.
I have changed linkTo and onMethod, it now reads linkToMethod(on(MyController.class).showAll()). l have also started Jax Rs support, hoping that Oliver accepts this stuff.
will use getkeys.
turn the double negative into a positive
Consider using for
Is there a good reason to use both @before and @beforeclass. @anshika-qa @aplotitsa
this is a pretty generic word. this will find the first link that reads Delete. so if there's an image there will it still work? would it be more robust to select the delete link that is under the image you added by using the name?
please rename the by veritable to something descriptive.
Just as a reminder, stuff like `and`, `=` and anything ending with a `?` return booleans
Oh, I see now.  You changed what 'admin_limit' means in the tiers code, so it's a limit on *extra* admins, rather than on the total number of admins/superusers. Okay.
Oups done
I'm still not convinced that it is necessary to re-implement this.  Isn't it just because you define certain coefficients to be negative?  This isn't a standard definition, as far as I can tell.
1. My mistake.
2. Because the warp function existed before the transformation classes and we didn't want to break existing code. Nevertheless I think inverse_map is a good parameter name here.
Where exactly
Inputs are selfclosed:
`<input class='edit' value='{0}' type='text'>`
ah, indeed.
is the order now still relevant or not anymore?
what is going on with instance = this?

You can refer to LegendView.this anyone you need to (even from inner classes)
parseInt传统上是全局函数。浏览器也不都支持Integer，都是Number。
Although `scene._animations` will lag a frame number behind, we should move this lower with the rest of the `us.set*` functions.  There's a bit of a chicken-and-the-egg here because we can't set the uniform state until we update the camera but we can't update the camera until we animate so we can't set the uniform state before we animate.  I'd rather keep all the uniform state in-sync  instead of partially initializing it.

Also, can we make this more concise so reading `update()` flows really nicely (sorry, I'm picky about code in `update` and `render`)?  I'm not thrilled with one idea I have, but it could work:
```
// I made this function up, we'd have to add it.
us.setFrameNumber(CesiumMath.incrementWrap(us.getFrameNumber(), 15000000.0));
```
Why not just `distance`?  Same for `angleAndHeight` below.
Not I'm just getting nitpicky, but JavaScript doesn't have a list object, so you should probably say Array instead.
I wonder if these exception checks are going to add any noticeable overhead.  Before, prototype functions would just do the math, now they make this function call (well, I assume the JIT inlines it, but I have no idea), and then does this check.  Think about code that does a lot of dot products or whatever in a tight loop - is this noticeable overhead?  The branch predictor should eat these up.

If it is noticeable - do we make an exception in our API, and just say we don't check for these errors in these types?  Perhaps it is justified since the browser will throw a fairly obvious exception right away anyway.
Its also called in `fromExtent3D` with the last two parameters `undefined`.
If we do keep this file, can it be script?