labofsahil/github-event-dataset-2012 huggingface dataset:
Actually, doesn't this check become redundant since `MODEL` always has a default value?
no, good catch - removed this while I was debugging the new unit test and neglected to put it back
The other issue is that among the Apple HUI guidelines, is, "In general, alerts are unnecessary if they [inform] users of errors or problems about which they can do nothing."
TiUIDialog.show() is only called once to display the dialog. The checking and addDialog is called here is b/c the developer CAN still alter isPersistent value AFTER show() is called. We need to update the dialogs array accordingly.
An occasional comment wouldn't help. For instance, I can't tell these three for loops apart from each other, so I'm not sure which is which.
One blank line or two? (Sorry for being pedantic.) The other ones have one. I'm okay either way, although it'd be great if they were consistent.
Perhaps use em's instead?
Why sys.argv[1]? You already parsed them into the options, args ?
You're not checking if it's a list or a tuple. Or is that taking it too far?
Perhaps "Charset detection is not available, because it would be inaccurate, so you must use this parameter for charsets other than UTF-8"?
pretty sure the parent of all providers is Puppet::Provider by default. I dont think this option is needed.
old_val should be oldVal
Sorry, not sure if I understand... can you show me which note you mean please?
if the loops iterates N (>1) times, you are leaking N-1 string allocations.
Skip db does that
Well I think this existing logic is correct then in that case.
> Where is this code exactly? In one of your other pull requests, I assume?
Yes. Search for *referenced this pull request*. And in *phobos-additions* project.

> This behavior seems fundamentally broken, ...

No, it is intentional. The idea is that we *have* zero-dimentional static array. As a result *every* value is a static array and we don't need any special static array conditions in templated code any more. And I'm not just like this idea, I use it.
I'm unsure which destructor you are talking about? The temporary `t` ? If you know how to avoid its call, I'm all ears, but I don't think I have a choice...

Other than to emplace each argument individually element using `ParameterTypeTuple` I dodn't see how to avoid the call.

I actually did that in one of my versions, but the orverall code was too complicated, IMO.
from a algorithm point of view I am fine with it.
A linebreak here but not elsewhere?! :P
maybe set this variable private (if possible)?
whats special/the problem with those bundles?
+1 Good catch. Did you check the other ctors?
Not exactly sure where these designer changes came from; I didn't modify them myself. Let me know if I need to revert these or something.
By the way, this "&& (!(lastObs.isEmpty()))" isn't helpful here (or in the other places you've used it). It just checks that the entire map is empty (i.e. _nobody_ in the database has that obs.

It makes the code harder to read without adding value, so I'm removing it.
I've encountered this issue on Eden first, so I'm guessing it does, but I'll reinstall Eden and check right now just to be sure.
Missing semicolon (while this isn't strictly necessary on the last element, this is the preferred style of the project).
yep! thanks for catching that.
I will take care of updating the config as @rosstuck is using this bundle with Zend Framework.
yes you are right. Remember that you can have the value unchanged and read==false (I only mark read=true when a get is performed)
removed this method.
I'm going to gently push back on this a tad.  I like handling the list in the SuiteImporter partially because it simplifies the call in the Importer, but also so I don't have to create and merge each ImporResult object.

How about if I call this add_dicts, since it's a SuiteImporter already, I probably don't need the word suite in the method name?

If you feel strongly in making this a single dict import, I'll change it...  :)
Roger, quick question won't this impede future progress? I mean eventually every container is going to NEED the ability to look at np-arrays right?
tiny consistency thing, but everywhere else in the codebase the variable `caseversion` is used, not `case_version`
MINOR: Incorrect comment.
I struggled with this; I think I'll change it to

    "No files found at " + remoteDirectory  + " with pattern " + remoteFilename)
No, Gary, it can be:
Gateway's method and there is no expressions
````java
void twoMapsWithoutAnnotations2(Map<String, Object> m1, Map<Integer, Object> m2);
````
I've just tested it on fetched Oleg's branch
Well, actually we need not keep it TBD and put a description here. Outbound channel adapter has this parameter too and we have given one there. The same description holds good here.
Would be good to also add a non-default value to the test config file, and read it out, to make sure that users can configure it as expected from the config file.
With this, the rakefile is unnecessary to build. Its a nice additional piece, but not everyone has ruby tools installed (including me).
I think I'm getting my head 'round the problem. I had to make some heavy changes but there's still a problem with stof's suggestion: imagine's implementation of Imagick doesn't support the "pdf opening syntax": ``$absolutePath.'[0]'``.
It rises a 500 Server error: "File /home/luca/....../foobar.pdf[0] doesn't exist".
Imagine try to be as agnostic as possible and thus doesn't support Imagick constructor's parameters.
maybe some mistake
`read-only-1` -> `read-annotate-1`
We should probably clean up the order of these params while we're at it. Something like url, verb, params, body, etc.
How about merging these to one line?

`return false unless (typeof identifier == "string") or (identifier.length > 0)`
great patch, but you could also get rid of this kind of lines in the same breath ;)
If there's no value-add, also remove the `NoDataToZero` function below.
Just define these serializers outside the test case, and use `BlogPostSerializer(data=data)` directly in the tests
change !paused2 to !paused && !paused2 in the check if you want to fix an bug . ;)
Yes, `push` is certainly fine to use -- it's `indexOf` that we can't rely on.
here I though I got away with this.

Default location example -

``` /Developer/SDKs/Research\ In\ Motion/BlackBerry\ 10\ WebWorks\ SDK\ 1.0.3.8/```
I'm curious about this check - when will the current track be -1?
html 5 plz
Split in two methods
I think that would work, but would also need to change fromConstInitializer(),  line 183:
                !(v->storage_class & STCtemplateparameter))
            {
                e1->error("variable %s cannot be read at compile time", v->toChars());
+              return new ErrorExp();
            }
and I'm not sure if that function is used elsewhere.
I would actually do this the other way, converting the incoming meta into an integer. Stylistic difference, I guess.
This would kill the possibility to run the script if a proxy is in use. Also see: https://bugzilla.mozilla.org/show_bug.cgi?id=727660
I'd prefer class names to start with an uppercase letter.
What does look better to you? RphUsbWorker, RphUSBWorker or RPHUSBWorker? The last one would be most consistent with existing code, but I'm not sure if that kind of all-uppercase is a good idea generally.
This test model is the lowest common denominator of a model that's supposed to work. Inheriting from `PublicationMixin` is not. This seems clearly superior.
oh, lol. it's optional, why can't we use them!?
Might as well - I think its good practice to generate IR in these easy cases to cut down on the bitcode size LLVM has to deal with each time.
I don't mean a "test failure" as in an expect failing. I mean't an actual runtime exception being thrown (from node etc). Not sure your code would run in this situation. Only other thing i could suggest would be to clone the session object and manipulate that object instead.
why add this outside the create method?
are these methods accessible? I noticed you have a private constructor so unless these methods are static can they be called?
I guess, but then we should just modify our config.xml for that shouldn't we?
(= (mod n divisor) 0) palauttaa jo sellaisenaan booleanin
By accident I modified this, later.