labofsahil/github-event-dataset-2012 huggingface dataset:
In the earlier version of the agent with pulp v1, did it support importing keys?  If so, will that continue to work with the updates to support pulp v2?
Ok, ignore the path, but can you rename the file to foreman.conf.erb?
We try to avoid using the 'and' & 'or'  operators, i think 'not' is on that list too.  I would use '!' here instead of 'not'.  The precedence can be not what you expect (even though it may not matter here).
Where did this code come from? What's the license?
Chinese - Simplified & Traditional - Pinyin
Also remove the comments
That is no quite equivalent:

    >>> [int(sum(col_width[0:i])) for i in range(len(col_width))]
    [0, 9, 19, 29, 41, 55, 70, 80, 103, 115, 121]
    >>> np.cumsum(col_width)[:-1]
    array([  9,  19,  29,  41,  55,  70,  80, 103, 115, 121])

Of course, I might do

    >>>np.hstack(([0], np.cumsum(col_width)[:-1]))
    array([  0,   9,  19,  29,  41,  55,  70,  80, 103, 115, 121])

but I don't think that this is more elegant than the generator.
Thus, I keep the the way my original pull request had it.
Yes -- that's more or less what I had in mind.
Maybe remove this comment, as it pertains more to the template than `tools`.
That was a leftover from earlier commits where I had changed the name from `MAX_WIDTH` to `MAX_COL`.  It's now been fixed so it's consistently always max_width.
Should the ``bounds`` not be in radians, i.e. ``(0, TWOPI)``?
I haven't reviewed this yet, so I'm not sure if this is relevant, but I use this when I want to write decorators that preserve docstrings and call signatures: http://pypi.python.org/pypi/decorator
I wonder how other OSs interpret the Ubuntu font family.
Thin clients can and will know at a higher level whether or not they should issue 'mempool' command in the first place.  Behavior for thin and fat clients and thin and fat servers is adequate without an explicit fClient check.
Good catch, I'll update that.
Can we move this function into the App class?
Why is utf-8 lowercase?  Isn't it normally uppercase?
Oups 'ID` => `IS`
Is this logic redundant if its built into the postgresqldatabase?
This is a validator which provides a standard client-side validator - the way that validators are currently architected even client side validators have to have a server side instance.  Happy to have suggestions for other names, but I can't think of anything off of the top of my head which is reasonable.
Isn't this useless? Just an empty method.
And no return either ;)
why not 2008-... ?
Is there a reason to nix the return value if something was published? That's pretty unexpected from Python, return values are usually independent of side effects.
The plain `{}` in format string are new in 2.7/3.1, so while we're still supporting Python 2.6, we'll need them numbered: `{0}`.

http://docs.python.org/library/string.html#formatstrings
Is this a forgotten debug statement ?
何かのライブラリで依存しているものを暗黙的に利用すると見通しが悪くなる気がするのですが、そうでもないのですかね？
Correct if the value was not a string this did not work, the simple fix would be to just to convert it to a string first but I also wanted to see how easy it would be to optimize the string manipulation here (which can be expensive in terms on GC).
For status, I meant `git status -b`. I run it with `-sb` automatically so I associate it with the default. When you run `git status -b` it will tell you how different (how many commits ahead, beind) your branch is from its upstream (in this case one's master, stored at `refs/remotes/broken/master`). `git checkout master` would do the same, in particular, it will tell you when it can be fast-forwarded.

`git-merge` and `git-rebase` read `merge.defaultToUpstream`. If it's true, running the commands without arguments will do their thing taking the current branch's upstream as an implicit argument. So even if `FETCH_HEAD` manages to mark the right entry as for-merge, doing `git checkout master` will give us a report looking at the remote-tracking branch `refs/remotes/broken/master` which we specified as the upstream branch. For that matter, so should `git log ...@{u}`.

They all look at the ref that's there, so while `git pull two` might behave correctly here by merging the default branch, instead of master, the day-to-day operations are going to happen on the ref with a value determined why which of the fetch commands we ran last.
Silly nit: Two newlines between imports and top level functions
Why 2 lines for this tag?
Sure, I will cover that on a follow-up bug, which should be part of the new version of mozinstall due to API breakage.
Does that even work?! It's supposed to be

```
dsn = dsn_template % (self.database_name,)
```
If there's no classloader change, it should not be added to the changelog.
This will crash if the variable isn't in config. I would prefer we not do that and default to regular authz behavior
Please don't use inline imports.
Why do you set the stream into blocking mode here? This essentially makes it blocking which can block the whole loop.
if you reply another time and this is not a good idea, please just close this. Thanks!
What about determining the prepending extensions in the process method directly? That way, the Kernel won't have to know about them at all and everything would be part of the container.
Indeed, changed.
That's a rather pointless micro optimization.
two of them ^^
well I *said* I copied the code :)
I don't fully understand what you mean by "call the callback outright". The use case for the callback is to prevent unnecessarily executing functions that could end up being quite complex, if we are not in debug mode or such. I was hoping the README example would illustrate it well:

### functions as input

`logly` also accepts functions as input; this is primarily to conditionally produce a debug output of complex something if in `debug` mode, for example:

```javascript
var options = { debug: true, output: "some.file" }
// dump options in debug mode
logly.debug( function() {
  for ( var i = 0; i < options.length; i++ ) {
    logly.debug( '[OPTION] ' + option + ": " + options[ option ] );
  }
});
// stdout: myapp[debug]: [OPTION] debug: true
// stdout: myapp[debug]: [OPTION] output: some.file
```

So, setting this "optimization" of not executing a function unnecessarily aside, I'm still trying to grasp how calling it outright would achieve the same goal. Are you suggesting that in the example above I should just do the for loop, and the logly.debug will end up a no-op if not in DEBUG mode? I guess that would go back to this being an "optimization". 

I'm using "optimization" in quotes here because any sort of magical JavaScript parser could technically remove logly.debug statements if not compiling in DEBUG mode. That seems to be overly complex perhaps, and that's why leaving the functions as input should be retained?(thinking out loud here)
I think the problem is the ```@With(Secure.class)```. You also extend from ```OBController```, which also has the security annotation. I think if you remove the annotation here and extend from ```Controller``` instead, it'll work.
yup it is odd, i'll take another look at it and see if I can find the problem.
don't need the declaration here as well ... storyboard can find it with the method just being in the implementation
datetime.now() will return the local time, which will give you the wrong unix timestamp. You actually want to do datetime.utcnow()
Тут магического числа быть не должно. Вместо десятка должна быть как-раз дельта. Поскольку она приватная - сделай метод getDeltaOffset, который её будет возвращать
This should be an Object, not an Array.
It's basically copied from several other syntax files like c.vim, perl.vim, and xml.vim - with an equal amount, if not more, documentation (try :h xml-folding). For example, when I use syntax folding by defauflt, I don't want function script blocks to be folded. Ideally I'd like to keep them opt-in but maybe I could make them both opt-out. Do you think it requires more documentation, though? Actually, perl.txt doesn't even mention them but does support them.
Можно использовать `.invoke('filter', function(dir) {...})` вместо `.then()` для сокращения кода
Yeah no it's good, I was just teasing. Nobody should ever write `{{}}`.
You're having trailing whitespace here. With the `color.diff` setting enabled, `git diff` should complain about trailing whitespace in garish red. To fix it, you could delete all \s+$
You actually can pass as many contexts as you want. If you're calling a Route transition, we'll fill in the blanks, i.e. if your route is `parents/:parent_id/children/:child_id" you can do `{{action goToChild parent child}}`.
I just merged the AS7-5253 fix, so this no longer needs the @Ignore.
Ick, what happened THERE?  Thanks, I'll open a *new* issue for that one.

On Thu 18 Oct 2012 03:59:21 AM MST, Aslak Knutsen wrote:
> In arquillian/container-embedded/pom.xml:
>
> > -  ~ This is free software; you can redistribute it and/or modify it
> > -  ~ under the terms of the GNU Lesser General Public License as
> > -  ~ published by the Free Software Foundation; either version 2.1 of
> > -  ~ the License, or (at your option) any later version.
> > -  ~
> > -  ~ This software is distributed in the hope that it will be useful,
> > -  ~ but WITHOUT ANY WARRANTY; without even the implied warranty of
> > -  ~ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> > -  ~ Lesser General Public License for more details.
> > -  ~
> > -  ~ You should have received a copy of the GNU Lesser General Public
> > -  ~ License along with this software; if not, write to the Free
> > -  ~ Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
> > -  ~ 02110-1301 USA, or see the FSF site: http://www.fsf.org.
> > -  -->
> > +<!-- ~ JBoss, Home of Professional Open Source. ~ Copyright 2010, Red Hat,
>
> Messy message :)
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jbossas/jboss-as/pull/3271/files#r1877372>.
>
On my browser, the "Powered by Leaflet — Map data © 2012 OpenStreetMap contributors" text wraps onto a second line. If you make the width 360px, this doesn't happen.
If `element` didn't have an id to start with, this will set the for attribute to a non-existing id. It won't be worse, but maybe there's something more useful to do? Not sure.
the whole code was adapted from accordion, because it is the same logic, so why rewrite/rethink into it?
i'll do the heightStyle fill implementation another day and send a new pull request.
All the <head> part needs indentation.
Use camelCase, not a_b
ok, you know what you receives here :) but it is more robust to check the type with function
We should check that we get something back from `Utils.getPhoneNumberAdditionalInfo`, showing `undefined` on the call screen is not a great user experience ;)
Can we move all this parameters to the constants section, just in case we need to tweak them at some point.
with all that we can simplify everything into the following function:

    handleEvent: function pm_handleEvent(evt) {
      switch (evt.type) {
        case 'mozbrowserloadstart':
          // Skip the first load start event because xxxx,
          // https://bugzilla.mozilla.org/show_bug.cgi?id=XXXXXX
          if (!this._loadingEventCount)
            return;
          
          this._loadingIcon.hidden = false;
          break;
        case 'mozbrowserloadend':
          this._loadingEventCount++;
          this._loadingIcon.hidden = true;
          break;
      }
    }
    
and remember to reset `this._loadingEventCount` to 0 every time a new popup came.
don't you want to remove the mozChromeEvent handler at some point?
nit : can you extract `navigator.mozL10n.get` in a `_` variable, we're using it twice here, and soon 4 times when the permissions l10n keys lands.
Message manager will not be call from any other class as Static (we found problems because you can modify cache directly from any part of code...).
s/temporaryly/temporarily/
Yes i agree. That reinforces my previous point. Let's wait for @fabi1cazenave localization code.
About the spaces, it were just missed with the markup changes...
dead code, not used anywhere
What's this? This seems to be independent functionality from the purpose of this pull request, which is to default to ipv4?
i don't know if this is against Zend Coding standard
As you're probably noticing, it's conceivable that this might behave unexpectedly if there's a failing import that has the same last part as the module we're importing. It might be preferable to do a bit more of a rewrite based on how Django's discovery works.
Did you mean "as a result of"? I've never heard it phrased this way, but maybe that's just me.
See above comment about cases being completely unreadable.
Would it be better to have a base? method on the gateway?
~~~
+ジョブライターは、成果物リストをオプションモデルとしてうけとり、結果をジョブユーザにメニューとみせるためにパラメータ化された CGI スクリプトへの URL を指定できます。
~~~

~~~
ジョブライターは、成果物リストをオプションモデルとして受け取り、結果をジョブユーザにメニューと見せるためにパラメータ化された CGI スクリプトへの URL を指定できます。
~~~
Quite at the beginning of the development phase we decided to be more specific with names of dependencies. I would prefer `tracksController` instead of `controller`.
Actually never mind, you don't need this.
Maybe we should raise a ``ValueError`` if times is zero or a negative value.
it leads to 2 minutes with backoff
See above for how to use `unshift` consistently with how other AppScale code does this. Also, separate out the `../..` into `"..", ".."` to match how other AppScale code does this.
Document why you're overriding these functions.
- ByteCodeVisitor cv = null;
+ ByteCodeVisitor cv;
`e` isn't defined here I think
You start from obsolete version of SHKFacebook. Custom values are reserved for subclasses - they are not used anymore. See current SHK.h and DefaultSHKConfigurator.m. What values do you want to add?
JavaDoc needs changing :P
I've just moved it to init, but I'll keep a silly params = self.params in here to avoid doing a wholesale renaming for now.
I've added a test for corrupt JSON and a try block that raises a BadJobfile exception when json.loads raises a ValueError.

Non-dict properties cause an AttributeError to be raised in the jobfile handler. I'll have to think a little about where best to catch and handle that exception. My question is how would non-dict properties get into the job file? tryclinet.Try._createJob_1() ensures that a dict is passed to createJob() (see tryclient.py line 552). The only way I can think of for the for non-dict properties to get into the job file would be for someone to bypass builebot try on the command line and deposit a job file directly into the jobfiledir on the master. Do we really need to guard against them doing that wrong, or am I missing something?
CCAssert会中断执行。从Lua里调用某个cocos2dx方法时如果断言失败，开发者无法得到详细的错误信息。这个补丁让Lua引擎有机会捕获断言失败的情况，从而输出Lua调用栈，方便开发者找出问题是何处的lua代码引起的。

发自我的 iPhone

在 2012-12-24，14:36，minggo <notifications@github.com> 写道：

> In cocos2dx/include/ccMacros.h:
> 
> > @@ -35,7 +35,12 @@ of this software and associated documentation files (the "Software"), to deal
> >  #include "CCStdC.h"
> >  
> >  #ifndef CCAssert
> > +#if CC_LUA_ENGINE_ENABLED > 0
> You can checkout the implementation of CCNode::cleanup().
> Why can not just use CCAssert?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Would be neat to also check if composer.phar or just composer is found in the PATH. Not sure how much complexity that would add to the code though, depends if you just do unixy `which` or really read PATH yourself I guess.
use ``.0``, not ``.000000``
Only downside is that it would lose the case for the error message: I think such messages should ideally contain exactly what you typed, which includes the case used. (Though I'm not that fussed about it!)
It was used by packagist for verbose output, but now it won't be needed anymore I think so that's fine.
@Seldaek I think i agree with you not sure what was the use case of @bzitzow  but back then it sounded reasonable
simply ``if ($pleaseCache) {``
This should be `unless stuff.nil?`.
Also `toc = nil` is unnecessary.
I think not only IPS mode benefit from this. Fore regular live sniffing we get the traffic earlier and this improve the handling of the flow and logging is made earlier. I would then say detect-engine.
Fernando's still on a plane but since we spent a good bit of time yesterday discussing this, I'll take a stab.

> These are good points and I partly agree with your analysis. However, this means that there will be no way to specify a different filename for the output file (since it will always have the same basename as the input file).

That's potentially correct. Essentially, what the filenames we generate for the document will by default be the stemmed filename of the notebook source file, with the same base chunk forming a prefix of any auxillary files such as images.

I guess we could potentially support something like `--output-basename` that takes `nargs='+'` (in argparse parlance) that is then checked to match the number of input notebooks (and then the stemmed .ipynb filename is used if no `--output-basename` is specified), but I would tend to agree that the notions of where to put the output on the filesystem should always be specified by directory, partly for reasons of batch conversion. @fperez, your thoughts on `--output-basename` in light of your previous comment?
add a new DB column (video_duration) and save it with youtube callback
This should have been left in check-input, as it does not apply to all inputs, e.g. input=text The following content attributes must not be specified and do not apply to the element: accept, alt, checked, formaction, formenctype, formmethod, formnovalidate, formtarget, height, max, min, multiple, src, step, and width.
I don't think it's such a good idea, it may cause surprising race conditions. Either don't expose `require` or throw some clear message from it.
`.aud` is a bit of a readability loss by clients of the lib.
And again I wouldn't use the term `lock` here, too likely to be confused with actual SQL locks. I think this one could reasonably be called `get_unprocessed` since that's what it does, it's the other one that has the special behavior (getting only claimed rows)
We've changed this to just be `DEBUG`, there's no need for the extra indirection layer of `DATAZILLA_DEBUG`.
move this ot a createPoint function outside.. same thing
I don't understand. It's twice the same dir : $dyno_dir/rootfs/app $dyno_dir/rootfs/app

Same for $dyno_dir/rootfs/tmp $dyno_dir/rootfs/tm
@pcarlisle I'll fix that
A simple helper method would allow us to factor out this oft-repeated cruft:

```js
function statsSourceUrl(target, opts) {
  from = opts.from || "-1hour";
  "http://stats.oit.uci.edu:8080/render/?from=" + from + "&format=json&_salt=1352477600.709&target=stats_counts.recruit." + target;
}
```

And then calls become simple `sourceStatsUrl("requests", {from: "-1hour"})`

Additionally, we could then make a pretty simple change to switch all graphs to environment-specific stats by just changing the one function.
You should use an early return here instead, ie.

```php
if (!$this->has($name)) {
    continue;
}
```
Sorry the more close alternative is `!array_key_exists(...) || ... !== null`
Add public function name to more accessible api : get/setQuery, get/setlanguage, get/setResultsPerPage.
And keep short name method to keep possibility to use short name properties in array config.
@author and since
StringComparer.OrdinalIgnoreCase
`ID`'s are unique and therefore shouldn't be used twice
should be able to remove the `break` since there is already a return.
Oh forgot about that thing. Thanks :)
Nothing should happen on Esc.
It's `@device`, not `@client `:)
Looks like this is mostly in a seed file. If not I'd move it all there. People have pretty much standardized on using the seed file at this point, so it's good to follow that convention.
do we log only if it fails? not sure to follow here
~~~~
for (key, val):
    if get_software_root(key):
        self.log.error("XYZ")
~~~~

and drop the base, mpilib = None, None?
Weird. Put this in the loop, causing the break?
s/sting/string/
This is necessary because I'm using MSVS 2005 yet in production code. My company don't want move yours production code to MSVS 2010/12 yet but I need this parser to extend old code. And I don't want install other compiler only to build this code. I tested in my home computer using both MSVS 2005 and MSVS 2010 and works fine.
It would also be good to add a small testcase for what this does, we test emcc very thoroughly.
... assuming the other end (which is not necessarily a php app) doesn't send anything else. Imagine a case, where we've sent a request via tcp and haven't got a response in time, so we closed the socket. Now, when we send the next request, we open another connection, and the other end (a non-blocking app... ) recognizes us and send the response corresponding to our last request. This behavior adheres to the spec, but it's impossible to implement sane handling of such in php.
Hmm ... what headers would ever change? Seems like it will always be the same client right?
superfluous parenthesis. also, why not `not request.user.userprofile.is_vouched`?
These just aren't needed anymore?
Wouldn't this be better written as a while loop?
Should it be `static` at all? It's set by init.
Do we need to keep it as an `Integer`, it could introduce problems with possible `NullPointerException`.
This may be useless :-/
I think this should be in the EventPanel, as it should be the only thing that can change the DataStore state (render thread side).
right, I'm aware of that - how much of a problem is that, though? If the
ZU.xpath is null I don't want the translator to detect. Obviously I can
embed this in another test - is that actually better?
Thanks on string.search - that's cool to know.

On Tue, Sep 18, 2012 at 9:45 PM, Aurimas Vinckevicius <
notifications@github.com> wrote:

> In Silverchair.js:
>
> > +	(at your option) any later version.
> > +	
> > +	Zotero is distributed in the hope that it will be useful,
> > +	but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +	MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > +	GNU Affero General Public License for more details.
> > +	
> > +	You should have received a copy of the GNU Affero General Public License
> > +	along with Zotero.  If not, see <http://www.gnu.org/licenses/>.
> > +	
> > +	***** END LICENSE BLOCK *****
> > +*/
> > +
> > +function detectWeb(doc, url) {
> > +	//concerned about false positives - make sure this is actualy Silverchair.
> > +	if (ZU.xpathText(doc, '//body/@class|//script/@src').indexOf("SCM6")!=-1){
>
> ZU.xpathText returns null if xpath is not found. So this may occasionally
> throw exceptions.
>
> Also, a nit regarding url.match (and it's really just something I want to
> point out that I recently found out) if you don't intend on using the
> matches returned by string.match, string.search (but it returns index, i.e.
> -1 for false) is a more efficient function.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/zotero/translators/pull/457/files#r1636373>.
>
>



-- 
------
Sebastian Karcher
Ph.D. Candidate
Department of Political Science
Northwestern University
My bad. Vidar came by and told me the error of my ways. "Follow" is of course the right term, and that's why I merged it :)
Use present tense, not imperative. You're describing what this class does, you're not asking the user to do anything.
same as above: cut the instance variable set
There seems no this file "../VMM.Timeline.Core.less"
Probably either want to bail here by invoking the `save!` method, or report save failures.
Change Colosa S.A. to Colosa, Inc.
Change to:

for (var i = 0; i < newInputs.length; i++) {
This is the wrong parent. The correct parent definition is:

        <parent>
                <artifactId>itests-bundle-settings</artifactId>
                <groupId>net.i2cat.mantychore</groupId>
                <version>1.0.0-SNAPSHOT</version>
        </parent>
This could be written as:

```coffeescript
[id, part] = req.params
api.fetch_language {id, part}, processResponse req, res
```

What's the motivation for changing `responder`? It introduces a lot of repetition. Couldn't `responder` still be a decorator, to avoid having to include `processResponse req, res` in a dozen places?
`/random` isn't sufficiently descriptive, in my opinion. `/card/random` might be better, though this would conflict if Wizards were to release a card named “Random”. I'm not sure where I stand on this one (and if there's one thing that's important to get right it's URLs).
added to my master branch (8eeebc3359d2533f45335517c4657ef092d2541a)
https://github.com/fwenzel/django-sha2/pull/13/files#L16R21 test too!
; не нужна. не на паскале пишем
как это реализовать для vector<int>?
Here you shouldn't say `set`, because it makes no sense to talk about set isomorphisms, sets can have only mere bijections. What you mean is the *structure* (perhaps there is an even better word for this) of deduction trees+`conv` is isomorphic to lambda terms+'beta-reduction'. We can some kind of notation like `(D, conv)` and `(\lambda, \beta)` for them.
when we do the login we expect that the page is loaded and the login is available we only disable the implicit wait only to check if the browser id button is there...
When I read this, it says:

Wait until not is_version_information_expanded.

I'm guessing you're actually wanting syntax whose logic is:

Wait until is_version_information_expanded true.

and I'm unclear about why a lamda is necessary for "not." It might work technically, but it adds to the confusion of this method call. 

Please simplify even if that means more lines of code.
I'm seeing there are actually quite a few cases where the 2nd tenant created are not cases where it's tenant config are altered. I'll change these to just use the GT tenant. Especially in this test, where there are no private tenant use-cases.
This can go if PrincipalsUtil.getPrincipals throws an error for non-existing principals
Not anymore, I removed the function.
As discussed on irc, we should probably have a dedicated field on the user object for these, rather than add it directly onto the user object and blacklist these properties.
`null` instead of `false` here as well.
This should have USING CONSISTENCY QUORUM. Actually, as this function just reads the entire config, it should use readConfig.
Can you add a TODO here to use BBQ once the UI is hooked up ?
You can probably collect the userids in this loop as well.
Feels like it probably is out of scope. Other than the boolean type, there's also not a lot of validation that can really be done.
I'm a bit concerned about the thread-safety of this class. Are you sure you don't need to serialize access to it? 

For instance, with very unlucky timing, is the following possible:

Thread A calls ``dispose()``
Thread A executes ``DebugPlugin.getDefault.getBreakpointManager.removeBreakpointListener(this)``
Thread A is interrupted
Thread B calls ``breapointAdded/waitForAllCurrentEvents`` (i.e., any method that can lead to an incorrect state)
Thread C (the one of the ``eventActor`` process the messages queued by Thread B)

I fear that wouldn't bee good, because I guess you want ``dipose`` to be atomic, no?
Oh, actually, this is not needed, because it's already defined like this in the inherithed, outer property: https://github.com/scala-ide/scala-ide/pull/265/files#L2R61

I'll simply remove it.
Hah, yes, I did a force push with this b/c the code review script complained.
I've found setting default-terminal to `xterm` works better for colors on my machine (e.g. colors under tmux-vim same as normal terminal vim).

Not sure if this is a general phenomenon.
Leaving a blank line sounds reasonable.
Has anything important changed here? Can only see line ending differences at a glance here.
Again, just switch back to the original and add the new stuff in place of GMT.
Got some tab/spaces issues here by the looks of things.
Забавный момент - этой конструкцией вы покрываете возможный момент, когда в передаваемой cell массив будет меньше, чем у self, но наоборот не проверяете. Почему?
runIdentifier gets incremented before coming into this block of code. Check line 73 in ModelRunSelectionPanel.

The 0 here is a failover
The XDR representation of a Diamond object is shown below:
I consider it a programmer error. This is only called by internal subclasses, and a ZincDownloadOp should have exactly 1 HTTPRequestOp (for now at least).
Looks like test-doc is already in the Makefile.
No problem, I'll move it to the handler.
Apparently it turns out this and like 2 other tests didn't depend on test data, so this was an unnecessary call
Use `Guava Objects.toStringHelper`
This should be a `.. code-block::` too?
No, a new 'dl'
mandatory=true
delete commented lines?
>
>
> That's pretty good start. I noticed that something like (n + m)*(n - m)
> doesn't get factored back.
>
>
I don't know a smart way (besides recognizing this particular simple case)
of figuring out what order the factors should go back to after factoring
the expression with commutative dummies replacing the nc symbols. There's
no doubt some principle that is escaping me that would tell what cases will
succeed and which will fail. Is it just that the factorization can only
contain two factors? e.g. for A**4 - B**4 there are 3 terms -- and for
some, isn't the factorization not even unique? From those 3 terms,
expansion leads to 6 unique expressions, none of which are the original
difference of quartic powers. But if two of the three terms are combined,
the original is recovered:

```
(A - B)*(A + B)*(A**2 + B**2) -> A*B*A**2 + A*B**3 + A**2*B**2 + A**4 -
B*A*B**2 - B*A**3 - B**2*A**2 - B**4
(A**2 - B**2)*(A**2 + B**2)  -> A**4 - B**4
```
Do you have any experience with nc-factoring?

/c
Удобство пользователя, все дела.
Because it seemed annoying to build non-branches test at each commits as it is already done for the pull requests.
¿De dónde sale esta matrícula? ¿Es algo que Gabriel tiene? (¿Es el número de legajo?)
Con la ayuda del corrector de Firefox le voy a intentar quitar el título de lince a JD: aprendizaje
:add-subs-to-ak or :add-subscriptions-to-activation-key
Yeah, no worries -- that's what this is all about! Here's how to use ActiveRecord queries:

```
author  = Author.where(last_name: author).all
author.books.each do |b|
  puts "\t#{b}"
end
```
i need to fix this line because no file name is specified for uninstalling an msi. it should just be $msiArgs = "/x"

right now this version requires obtain a guid from a call like:
Get-WmiObject -Class Win32_Product |Where-Object {$_.Name -like "Notepad*"}

i'd like to fix this in a separate release with a helper so that you can either specify a guid if you know it, or have it try to find one based on a wmi call like the one above.
content_length_ is indeed an optional. What am I missing?
Strangely when I took out the single quotes in my RDL the call failed.

Anyway this should probably be driven by a conf file.
$oembed is call only once ;)
Hmm… I've always used the `copy` attribute to suggest that a new instance will be returned each time.
Should I open an issue on libgit2/libgit2 @arrbee
Good catch, I'll fix this
Awesome, I'd been meaning to add this!
Why? When I ran this test on device, the issue I was getting was that "about:blank" window issue. But other than that, I had this test running consistently.
I considered that but then came back to the point that the only real place for this is in the (future) Contacts app object. If I abstracted it out we'd be moving it again later.
Так было и ранее. Оставил как есть. Можно, думаю, ClassNotFoundException так же через require.inc.php подгрузить заранее.
That only happens on the homepage though, and doesn't occour in oneliner.php. Don't even want to know how this looks on the other side, or what causes this ^^
Predicate macro FTW. Suuuper useful.
Suuuper nitty, but missing period, ha.
yeah: so I think all of these distinction can be reduced to a few lines of code.
Thanks! I've deleted these code.
I think that's fine, although I've made the intention of the parameter a bit clearer by renaming it to "forceReload".
The fact that it also replaces the existing state in history is more or less an implementation detail.
Good catch! I prefer to not have any coincidences like that so I think we should go with your approach (which you proposed in the first place.)

I was planning to not have Android Chrome be detected as having the bug since it sort of respects the font stack, but the fact that it uses the last font in the first stack that uses the @font-face breaks that.

I'll start adding and fixing unit tests. I'll also investigate why this didn't show up in my webfontloader-proto tests.
whitespace is all weird here, 2 spaces and no need for the newline after else
Ack, that looks fine.
I'm not following this: if the application doesn't see the error, then they'll call the wrong interface (commit, rather than rollback).  What happens if  you ignore that an update failed, then call commit?

i agree the crashes make the implicit roll-back a bad idea!

IIRC, txn.commit can fail in Berkeley DB, in which case the txn actually aborted.

We could put a flag in the txn structure that we're about to return WT_DEADLOCK, and go ahead and release our locks so other things can proceed.

Then, we return WT_DEADLOCK on every cursor op until rollback is called, and if you call commit, we roll it back anyway.
- Is it possible to add a ``@param`` annotation for parameter ``$querybuilder`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``?
- Is it possible to add a ``@param`` annotation for parameter ``$params`` which defines the array type; using ``array<SomeType>``, or ``SomeType[]``?
Not sure what you mean, the file is still in the joomla suit.
Is this the right documentation (the parameter is named visible)?
Done in 15dec49, but I ended up going back to form.is_valid() and actually using the validity of the form.
Much easier :)
don't you now have to check for null on old?
Indent only once, not to the `(`.
I just put the dict constructor in the `default=`, but wrapping it in a function seems to work, since it probably calls it later. Where have you defined the function, though? If I put it in the class, I get `'default_panels' not defined` no matter the type of method.
Mnja, order is not OK.
So why this one more `<ul>` anyway?
And `user.pk`? :-)
This is not possible. Furthermore, never catch ALL exceptions, only those you expect.
Also, I cannot get past `dependencies = ()`. Should not this be a list?
I don't understand. Currently, we have or Facebook ID (because you have logged in through Facebook) or not (because you logged in with username and password). Why would you in the second case go and ask Facebook for user image? If Facebook ID is not set, you simply do not display an image (or use Gravatar, what we will do later).
This would allow the application developer to have multiple Zend\Session\Managers and point 'ScnSocialAuth_ZendSessionManager' at one besides 'Zend\Session\SessionManager'.
why while or for, not just "if"?
Is this something that could be theoretically autodetected?
You really wnat to write $this->Application\View\Helper\UserIdentity() in the view ? I'm not even sure this can work because of the slash.
Don't think we need this...
The way ZF does it has always been 

1. get the adapter
2. set credentials into adapter
3. set adapter in auth service (if it hasn't been fetched from the auth service itself)
4. authenticate

(see my [example](https://github.com/doctrine/DoctrineModule/blob/master/docs/authentication.md#using-the-authenticationservice) on the auth docs)
Simple usage should probably be direct instantiation first :)
"at the earliest" is actually wrong - we made it happen, and 1.5 will support 3.2 and above. This should reflect that.
Is this safe to use in non-MR context?
This header comment formatting is janky; this is fine for now though, instead of fixing these piecemeal we should simply integrate checkstyle with the build.
This section might be more readable with the option pattern & pattern matching.
maybe we should say somewhere it was taken from werkzeug
These are not the contents that result from running the T4 template.
No, true, I was thinking of warnings in the error console. Might add later then, yup.
tag_manager
This could be
```javascript
var res_id = ctx.allocated_res_ids[data.fromResourceID];
if (res_id)
 ctx.allocated_res_ids[data.toResourceID] = res_id;
```
But there's probably a better way to achieve that than to make a global.
Space before the brace.
Sooo similar to `this.get_resource`
Store the whole file in one chain buffers is too aggressive. It could consume  too much memory in busy servers. You may read the file chunk by chunk and output it by chunk.

This is my thought.
Oh well, it could *theoretically* connect to any other site providing the same API as the AUR. It does not in practice.  Likely the AUR url is hardcoded, because there isn't any other site like this. Apparently none ever needed PKGBUILDs for anything else than Arch. Of course, many of the PKGBUILDs in the Arch might well work on non linux systems, but nonetheless it contains a lot packages that are (Arch-) linux specific.

Moving `yaourt` into a separate module is a good idea, if just for keeping the pacman module clean and simple. But how to deal with the `arch-upgrade` alias that is defined to use `yaourt` if present and `pacman` otherwise?

Btw, you don't really think that there is no better package manager than `pacman`?!.  I mean, it can't even track packages across multiple repositories, let alone pin packages to certain repositories… and using bash as source package description format wasn't the brightest idea ever.
Yeah; the problem is that I don't like it substituting other named directories, only $HOME.  I couldn't find another way to get that behaviour.  Any ideas?
It's nothing more than a regular bubble sort with a small optimization that stops the algorithm if nothing was swapped during the iteration.
What is going on with this change?  It does not seem related to other changes.
I do not know super() in jinja - I assume this calls master.html???
If I run the nosetests with ```nosetests -v```, it prints out the ```@brief```` at the start of the line, so I think those should be removed in all tests in this file.
same issue as above happens here.  I wonder if you are not allowed to put ```@returns``` before the params or something like that?
will update comment here and on api side
To record state for folks that weren't on IRC, @jinpa and I discovered that we were talking about different bullets.  In the attached screenshot, I was talking about the ones circled in green, which go away when this UL is class unstyled. @jinpa, meanwhile, was worrying about the bullets that appear by the child list items (circled in red), which I failed to notice at first because they only seem to appear in Firefox.

![firefox-linux-fullscreen-huge-lipsum-bullets-circled](https://f.cloud.github.com/assets/105487/24721/1ed3fede-4abb-11e2-8059-ae4f14557ce7.png)

Jane, I prefer the look of the unstyled list for Attempt items, but I think a good argument can be made that they're useful for visual tracking and should stay. 

I agree that the bullet for the child item looks bad, but I don't know where it's coming from, and it seems to be Firefox specific, so I'm inclined not to hold up this PR for that. So if you want to leave the bullets on the Attempts, I can merge.
the comment here should have been updated to ``Run the flash policy server``.
But doesn't the validation attribute cause powershell to force the value to not be null?
Good call - I'd like to throw an exception from get/put/delete/search_options
Good catch. I was trying to simplify the logic down below by having a truthy filter if none was specified, but it would be better to raise an error if a non-callable is given.
yeah i suppose
log.info inside a log.isDebugEnabled seems strange...
from line 38 to here (line 57) has a bit of duplication. Investigation also defines teacher_only so you can probably check that in general and then it looks like the only difference is the id and what is passed to expandcollapseoptions.
Je trouve que si dans le contexte. En fait ca m'embete de repeter "music and movies industries", t'en penses quoi ?
"const" keyword is not IE friendly
This file, and many others, has “single key I18n” references
It was originally copy&paste from another code I was writing :]
Really? That was simpler then array_init(return_value) ? :)
Same with setPoolSize & getPoolSize.. heh?
docs docs docs !
Line 46 too sets sessionId. It is being twice
Yes, all the fancy C++ unit test frameworks use templates to get very nice error reporting. I don't think there's a way to accomplish the same in C without a different call for each type.

Regardless, this looks like the kind of thing that should go upstream in Clar. Can you open a pull request?
Agree. Changing to ArrayBuffer
we should set `ignore = dirty` on this too, no?
Hello isn't in footer. The deleted lines show above the added lines.
try : (somename is a name of your choice)
git branch somename
git checkout master 
git pull upstream master
git merge somename


if there are merge conflicts you need to resolve them by calling 
git mergetool
I don't think so. There is probably some other ways of doing that but I can't think of a reliable way except this one. :/

nit: |var input = this.msgText| first and use it
Revert this.  We removed it for a reason.
I don't understand why you added smtp into the adminaddr, that will only go into /etc/nullmailer/adminaddr.
Feedback ob jemand kommt oder nicht? Ich halte das für sehr diskussionswürdig und möchte das nicht zwischen Tür und Angel entscheiden. Bald gibt es digitale Alarmierung, die macht das viel besser und standardisierter, dann ist diese Lösung wieder nicht nötig.

Zudem bedenke bitte ganz im Ernst: Du hast hier in einer APP immer eine gewisse **Laufzeit** und daher wenig hilfreich. Wer ist überhaupt die Zielgruppe für das Feedback? Außerdem richt das nach Zweiklassengesellschaft. Der, der kein Smartphone hat, hat schon mal nix davon.

Ich denke dieses Feature muss im Forum diskutiert werden und dann müssen wir die Architektur vernünftig durchplanen.
Для этого есть метод trim()
Не пойдёт. ChatGui и консольный чат должны переиспользовать код.
Почему Vector?
Because `getAccessToken` method has exception handling explicitly in it's body I'd also add tests to verify that exception handling works as expected.
Also we only import it when we need it. 
It's not needed more than once so no need to import it globally.
why did we changed the app?
two whitespaces :scissors:
only 2 cores left `core8` and `core16`
It contains all the features that have been nonzero at some point during the fitting process. 
I therefore considered it part of the model. The use case is ``enet_path``, this makes it possible 
to some kind of "ever_active_set warm-start".
ya besoin des deux ?
rajoute un test comme pour boost_python pour détecter si la lib est pas là
Roster Class
This is a tiny limit and will probably slow things down a lot. May want to bump it (or leave it off to use the default).
Please amend so this semicolon is not removed.
This should be local
Because it is difficult to implement with a little lines.
Current header generation mechanism doesn't consider `unittest ` block which not shown in header.
And, `AttributeDeclaration` (and it's derived classes) can be nesting.

```d
version(unittest) {
  pure {
    public unittest {}
    pure nothrow unittest {}
    extern(C) unittest {}
  }
}
```

In this case, it is hard to implement that stop displaying of whole `pure { ... }.

Then, this is a *hacky* change as I wrote in comment.
My approach: if the "if" is through to the end of the body of a loop, reverse it with `continue`:

    if (!ttp)
        continue;
    ... rest of the code ...
Also, we should do null checks elsewhere for container_
Good question

It's guaranteed to return Undefined if no object is at that index.  IsString is not defined for undefined so i'll run some extra tests.

I wouldn't expect someone to call format with no argument, but wouldn't put it past them
the `INTERNAL` is for something that shouldn't happen, but this could easily happen. Either create a new string or use `Invalid_arguments`
Your version of the file is missing some lines of code in the current head revision of the master branch. This is one example.
`( called boxes as in bouding box)`
`(called boxes as in bouding box)`
Actually I think it is ok because the base class has a reference preceding this member which will align it on an 8 byte boundary.  (I thought it followed a CInterface which would be aligned on a 4 byte boundary.)

So it will work,, but it would be even better if we revamped the hash tables to make things like this cleaner.
Is the reason for this mutex still there?
Haven't looked in depth, but was it because multiple IDistribute files could call directory function e.g. doRemoveEntry in parallel... (?)
There is a check in CChunkingRowManager::resizeRow that takes a different route when not expanding.

I should perhaps rename this function to expandHeap rather than resizeRow
I think it make sense to return class names as-is because python identifiers are case-sensitive and so casting them to lower case is lossy.
I think this is not necessary, if you test the entity changeset later
Can you just make the library location an environment variable, that can be set externally?
this local variable is useless now that you have it as a property of the object
Maybe the opposite check? :)
see comment in collections/photos
I'm trying to get rid of the ((StatefulKnowledgeSessionImpl)ksession) cast.
This was causing troubles inside drools-grid because we where using commands in a complicated way. The cast was only needed to execute the ExecuteCommand, that no one was using :). I will keep you posted on the changes. I've already improved the test to represent more accurately what we are doing inside drools-grid and right now for the test the cast is not needed. I'm looking forward to improve the test to replicate my failures in grid, but I will be offline until Tuesday, I hope I have 5 minutes to commit what I have.. I will keep you posted
I'll delete this line in a follow-up.
@shacker Please put this on multiple lines
Do we have a defined UX requirement here? I have to admit, normally I'm against adding code that does not meet a known immediate need, and the OAE experience really reinforced my prejudice.
Please remove these comments. If these comments are still valid, create a new ticket against puppet-dashboard and elaborate on the comments there.
This version field isn't needed anymore
This seems overly complex.  Why do you need to bail if line matches this regex?
https://github.com/nmonkee/metasploit-framework/blob/e16a51fcf92c2c513df20e3bac12fa754e7ddf71/modules/auxiliary/scanner/sap/sap_soap_rfc_dbmcli_sxpg_call_system_command_exec.rb

On 20 Nov 2012, at 23:16, Brandon Perry <notifications@github.com> wrote:

> In modules/auxiliary/scanner/sap/sap_soap_rfc_dbmcli_sxpg_command_exec.rb:
> 
> > +					else
> > +						temp = output[i].gsub("&#62",">")
> > +						temp_ = temp.gsub("&#34","\"")
> > +						temp__ = temp_.gsub("&#39","'")
> > +						result << temp__ + "\n"
> > +					end
> > +				end
> > +				saptbl = Msf::Ui::Console::Table.new(
> > +					Msf::Ui::Console::Table::Style::Default,
> > +					'Header'  => "[SAP] SXPG_COMMAND_EXEC dbmcli Command Injection",
> > +					'Prefix'  => "\n",
> > +					'Postfix' => "\n",
> > +					'Indent'  => 1,
> > +					'Columns' =>["Output"]
> > +					)
> > +				for i in 0..result.length/2-1
> 0.upto(result.length/2-1) do |i|
> 
> —
> Reply to this email directly or view it on GitHub.
>
``str(value)`` here doesn't do anything (``"%s" % value`` == ``str(value)``).

If you're worried about non-ASCII characters, ``str()`` will fail on those anyway. You need to ``some_unicode.encode('utf-8')`` if value is a unicode object.

If you're unsure whether value is a str or unicode type, you need to use:

```python
if isinstance(value, unicode):
    value = value.encode('utf-8')
```
The implication here is, of course, that perhaps we should return more than the array.  Perhaps the "command tree" (or currently "command line") has one property for each pass, and each property is an array of commands.