labofsahil/github-event-dataset-2012 huggingface dataset:
I would rename this to something like `kill_ef_add_caps_to_role` so it's more obvious what the filter does. Also a comment why this is needed.

Also, this is one of those cases where the `$killswtich` var isn't needed. Just do something like

<code>if ( apply_filters( 'kill_ef_add_caps_to_role', false, $role, $caps ) )</code>
This bug with invalid html tag escaping is actually fixed in newer google prettyfy but it is considerably slower in my tests.
Good idea. It works on PostgreSQL and there is some indication that firebird also use those strings.
You mean stash the computed value in the caller rather than in this function?
Or stash it somewhere anyway, computing the total size only once at init
time rather than on demand if not yet calculated?
# Homework 3

| **Part**  | **Points** |
|-----------|------------|
| base      |          1 |
| advanced (ascii) |   0.25 |
| **Total** |          1.25 |

Overall, well written program.  The output and your code is clean.  Only a quick note about your code.  In the case of your `m` and `n` variables, you should define them closer to where they are used so it's easier to see what's going on.  In this case they are unnecessary, since you can just use `print p, "3+4 is", (3+4)`.

Also, you can combine some the `raw_input` and `int` functions into one line:

```python
# as one line
d = int(raw_input("Enter the year you were born: "))
```

Last thing, and we will be going over this next week, all these single letter variable names get a bit confusing to keep track of.  In the future, try naming things what they are, even if it is shorthand.  For example `yearborn`, `favnum`, `name`, and `pbot`.  Yes, it takes longer to type but it makes the code much easier to read and maintain.

Again, well done on the program.  Since you seem to have a good grasp on strings, you may want to look at string formatting going forward.  You can find more information on string formating [here](http://docs.python.org/library/string.html#formatstrings).
This is a good start.  Next step is to only pull back the fields specified in the projection.  In this case, only the field named X.
can we add wbaw/burstlam's vocpcm.c and 2 Makefiles to this to enable 2-way call recording?

https://github.com/burstlam/zte-turies-35/commit/bf24862541891a0d2e011a8709a9289195bc90fc
https://github.com/burstlam/zte-turies-35/commit/85d3192edd492a9b4976eac679ad02a03dbf3380

We've been using it successfully on the Blade for weeks on Modaco.
and here too
for p1000 and p1000n devices 

CAMERA_ID_MAX = 2
This isn't a `ContentProvider`; it doesn't extend `ContentProvider`!

Either make it so it does, or pick a more appropriate name.
Please add the description for this pod.
The power of decorators™ 

I'm still not sure if I am "doing it right", but I like the way it looks :smile:
1557910
this seems didn't make any help to graphical performance.
and it make phone unstable when playing heavy games (like Asphalt).
Again, using the built-in cmd_exec should do the trick
Thanks, I had this bug in my kernel too. (ARM: 6482/2: Fix find_next_zero_bit and related assembly)
errors are already available in the FormView. So IMO this is useless. Simply add some logic in your form theme to display them
When developer add new extension should he edit the array to include it?
Done making it service agnostic.
Might want to document this naming convention since it's used for user-facing output.
Since all code is PEP8 we can remove this.

tronweb might not be PEP8, but no one cares.
Yes, that's why I propose to fix the version range to [2.1, 2.2) which means 2.1 to 2.1.x.
result._1 must be(addressA)
    result._2 must not be null
Aren't we just interested in the first match with hash >= the message hash for less than 100 nodes?


`ring.find({case (h, n) => h >= hash }).getOrElse(ring.head)`
ah, sorry for my stupid comment, now I see what you mean.
node is a utility in MultiNodeSpec
hmm I think something need to change name here
if that is named node, we should probably use something else in the tests (I named the cluster node, after your tests)
I can change that to cluster.
To aid in debugging, might be nice to know why the message didn't get through

case ActorPathExtractor(natAddress, elements) => 
  if (allow(natAddress)) system.actorFor(elements).tell(remoteMessage.payload, remoteMessage.sender)
  else log.error("Firewall: dropping message {} for non-local recipient {} at {} local is {}", remoteMessage.payload, r, address, provider.transport.address)
case r => ...
and this would need to effect (possibly) a shortening of the timeout; the easiest solution would probably be to keep a Deadline inside the Data object and calculate a new deadline here and reschedule the StateTimeout in case this client wants to fail earlier.
move down "(if using a"
ah, you removed NodeStartupSpec
If you feel like it we can rename RemoteActorRefPRovider to RemoteActorRefPRoviderImpl and create a pure interface for it.
"fuel/ Directory" is more clear for me.
Yes but now it's deprecated. That's why I changed it to `!=`.
Thanks for that.  Maybe this fixes clang compilation with C++11.
as above, also below
Just wanted to mention that dict.get() returns None by default.  Not a problem to explicitly specify it but not necessary.
Sphinx is complaining that "Bullet list ends without a blank line; unexpected unindent." Easy fix, just tack on a newline at the end.
Because that would involve more code changes.  We wanted code changes kept to a minimum at this point in the cycle.  After Frodo it can be cleaned up, perhaps with the limiter replacing the existing clamping system.

Note that this only applies to video, where only one stream is playing anyway.  Thus, the worst case is where guisounds are mixed in.
The engine is capable of playing and mixing multiple streams and sounds. Why run the limiter for each stream (regardless of the actual value) and not just run it once on the final mix??
...and revert m_bSortAndRenumber to its previous value instead of false...
Would be helpful to put expected output here.
Implemented in the new cherry picked branch.
Missing tab.
Ditto, pass as canary=canary
resetTimer is mainly called from update (i.e very often)
but it used to be simple setTimeout which made only very small waist of cpu

is there a better way of stopping blinking when something changes?
if addressPromise has already been completed then it will throw an exception and context.stop(self) won't be called. is that the intention?
you might use:

if any( r.match(plotName) for r in self.blackListRe) : continue
Find will return only SEARCH_QUERIES_ORDER symbol like :hash, and when you assign value inside find scope it wont be visible outside of it. Thats the reson i used for here, id to set subs variable and use it later. I tried to use SEARCH_QUERIES_ORDER.each and its return value but i didnt like that code so i just stick with for loop.
What, no documentation :penguin: ?
Crap, I was trying to be so careful not to check that in. We're behind a corporate firewall, so we can't use the git protocol :-(
I'll rename the class WSF_FILTER_HANDLER to WSF_URI_TEMPLATE_FILTER_HANDLER and push a new commit on this pull request.
Use `if (cb)` here.
On second thought, what prevents us from implementing this method like this?

[MethodImpl(MethodImplOptions.Synchronized)]
public static int ProcessRaw(float[] inBuffer, float[] outBuffer) {
  return process_raw(ref inBuffer[0], ref outBuffer[0]);
}
Typo: s/varible/variable/
Přidal bych sem na konec, jako prevenci chyb

```php
stream_wrapper_restore('php')
```

Nette totiž v shutdown funkcích ještě něco zpracovává (byť ne zrovna tohle, ale mohlo by)
well, why couldn't you do the check inside the loop?
Also, a space after `//` would be better
Alright then, let me take another look at this then. 

p.s. isn't it past your bedtime?
Also, Is there a difference between two infinities? :)
changed to 

```ruby 
 def test_send_file_headers_with_bad_symbol
    options = {
      :type => :this_type_is_not_registered
    }

    @controller.headers = {}
    assert !@controller.send(:send_file_headers!, options)
  end
```
every thing is green
the first alternative would be to extract_options! and add them back to the args array again afterwards. I think a simple check for a hash doesn't hurt whereas the whole removing and adding things is simply unnecessary. 

the second alternative would be to extract the options in after_rollback and after_commit and add them back to set_callbacks manually. This isn't really dry and frankly speaking, I don't think this is a big deal at all
No need for `()`
That's merely in the sense of "the author of our woe." "For there again, against the glass, as if to blight his confession and stay his answer, was the hideous author of our woe--the white face of damnation."  That's the first thing I've ever felt like "re-tweeting."  Or, if you prefer, "the author of our faith."  It amounts to the same.
Re: filemanager, that's an artifact of not wanting to forward calls to fail silently; I want to know what protocol the tool demands. Footnote, javap has its own FileManager (minor extension).  The unsupported API can change, as well.  At least I removed all my printlns.  I'll test the FwdingJFM.
It was used before Paul's patch.
What I meant by saying "to lift isValueClass guard" is that it was included in every case of this Traverser
def __call__(self, x, *args):
        if not hasattr(self, 'x'):
            self.x = numpy.asarray(x).copy()
            self.f = self.fun(x, *args)
            self.calls = 1
            return self.f
        elif self.first_only and self.calls > 1:
            return self.fun(x, *args)
        elif numpy.any(x != self.x):
            self.x = numpy.asarray(x).copy()
            self.f = self.fun(x, *args)
            self.calls += 1
            return self.f
        else:
            return self.f

Does this look better?
Ok, `_cont` should be perfect for this. I will update this pull request as soon as possible.
Yes, will fix this. Plus, even here I plan to check if both operands meet the conditions to be broken out of the Tr
Well that's the old assumptions, but I guess I'd say it's a bug. 

My point is that removing `is False` here and just doing `if not ...` is wrong because it doesn't account for None.
What's the problem with sympy.abc?
The `-l` switch is specific to GNU Make.  For instance, it (the switch) is not supported in any of the common BSDs' native makes.

On the other hand, that's mostly academic because realistically anyone reviewing th README is likely to be on Linux anyway.  I'll merge.
I think I'm with Sumeet here -- `with assert_raises(type):` seems like it'd be nicer to use than `with assert_raises_context_manager(type):`, and is a lot easier to remember.

Fortunately, the first argument is the exception type, so this is essentially just making the callable and its args optional. If the callable and exception type were reversed, this'd be a lot nastier.
nitpick, add a space after comma, before "rowContainer"
Just a side note: I think the housekeeping branch of brow takes care of adding Sinatra::Reloader to the app in development mode, so we can probably do without this. A coordinated effort to remove this in different pebbles would be great.
Agreed.  In addition we should move on from this single global.css file and change to less/sass while we're at it.
Actually, now that I think about it... `uv__poll_timeout()` returns `(unsigned int) -1` (a.k.a. `UINT_MAX`) when we should block indefinitely. If an int is 32 bits, then the `timeout == -1` check will always be false because timeout won't be -1 but UINT_MAX.
Что это за метод?
1.This structure is not human readable where the condition is found after few libes of code.
2. Also: unless not ==> becomes: if
3. error messages should be printed as errors.
4. change " to '
5. change this to all cases in file
Pls see this example:

if Params['ref_cd'].nil?
  Log.error '--ref_cd is not set'
  reurn
end
well, that can be a different issue, since it's .live is everywhere
they're not just available, but they preform related functionality.
others'
I'm kind of against adding a function for that. This code is specific to the 2 javascript functions for marking forums/topics read.
If you are not fetching too many revisions you can fetch all revisions for all posts in one query and take them apart in php code.
Firstly, follow coding guidelines for SQL statements. Then rewrite the query so it does not require a construct like `OR 1='. (($auth->acl_get('f_read_other', $forum_id))? '1' : '0')`
Why was a new line added here?
Move this before the while loop please.
public/private/protected
L_DISABLE_EXPLAIN
IMO We should also make stickies viewable to anyone. who has normal f_read permissions to the private forum.
oops, duh :)
sparge linia asta, te rog.
QUTTING
Could you add a comment explaining this is a temporary workaround until hub is fixed. Also would be great if you could register issue for hub on reducers so and point out the number here.
That is very weird...doing this for month but not day or year. Javascript standard, you crazy.
Yep, we should copy TensorType or CudaNdarrayType.values_eq_approx
Hmm, how about

"You can run ``nosetests`` in the Theano folder to run all of Theano's tests, including yours if somewhere in the directory structure."
I missed you!
Good point, reworked to calculate the widths once and inject the underlining later.
The predicate is asserted later to be null. Assert that earlier (here), instead, and remove the useless m_needsSubstitutePostExpression member.
if 'xxx' in message:...
Is the space the only disallowed character?
add nolink class
Why not clean them up right away?
DO you need a spiral and a counter? The spiral tracks the total and the minute, with two fields on read (count, one)
sounds like a getter method, I think this one should be called createProxy();
Can you add a versionadded:: 1.5 statement for the new API?

Basically just make your addition a new paragraph and prefix it with:

    .. versionadded:: 1.5
... to modify an objet *definition* ... after it has been *defined*?
I'm familiar with the factory pattern, and I don't see the need for it in this case. The problem is not with the pattern; the problem is that it's just not necessary to solve this problem.

Why not just do this
<pre>
if self.should_compute_mean_curves():
  writer = MeanCurveWriter(job, imt)

if self.should_compute_quantile_curves():
  for quantile in self._calculation.quantile_hazard_curves:
    writer = QuantileCurveWriter(job, imt, quantile)
</pre>

instead? This is equivalent code, without a factory. I don't see what additional "decoupling" is necessary.

- You use an ORM to fetch your data.
- You pass the data to something which does a calculation (a function, for example).
- You get a result back, then you use some writer to write it to the database.

In other words:
- Read data
- Calculate
- Write data

It's really that simple.
I would remove this test (test_do_hazard_map_post_process). If it wants to be a qa_test, it could be addressed in the proper file and in separate branch
Thanks Andreas!
Maybe a note would be suffiecient, which tells the user to checkout the branch in the latest stable version?
This is one of those failures I was talking about... when I checked, `foobar` was already "bar" *before* the `getScript` call, making it impossible to verify that test.js (re)assigned it.
Yes, Xcode has been bugging me a bit with leaving trailing white spaces. It seems http://code.google.com/p/google-toolbox-for-mac/wiki/GTMXcodePlugin provides a solution.

What's yours?
This should be defined in a _sql file specific to the abstraction layer, not part of linear.sql_in
I thought we had improved performance in Assoc rules as well. didn't we?
Thanks. I will use the following SQL statement. 
```javascript
    curstmt = MADLIB_SCHEMA.__format
        (
            'SELECT MADLIB_SCHEMA.__assert_table
                (MADLIB_SCHEMA.__regclass_to_text(table_oid), ''t'') 
             FROM 
                (
                SELECT table_oid
                FROM %
                WHERE table_oid IS NOT NULL
                GROUP BY table_oid
                ) t',
             ARRAY[
                 meta_tbl_name
             ]
        );
    EXECUTE curstmt;

```
Some of your comments end with periods, others don't.  I'd prefer the former but consistency matters most to me.
I'll remove this and think on something else.
log.exception prints out the exception message and the stacktrace. So you should pass in an additional message like "Exception thrown when unindexing".
@jacknagel I respect the tradition. Thank you.
True. The part I most dislike is that there is some duplication of code between the Hash case and the non-Hash case. I've refactored it accordingly.
masks ?i
We can look at this more closely after the branch lands.
Same as above, non-descriptive string constant.
Why is this a runtime class? Isn't _everything_ a runtime class?
Yeah - but it seems to expose the adapter a little.  it feels more like  a result.init() call, which internally would sort this out.  Or just have getModuleAdapter do it before returning, so you always get an initialized adapter.
Use the c++ headers 
```cpp
#include <cstdint>
#include<cassert>
```
好了，我决定接受这一行更改，当然你得帮忙先把标点和括号改过来。
I think this line can be moved to RT block below because it's related to routing table via netlink.
ok, I will have a look.
Thx
Done in 6bea82df32f687d636f1b843a1918a3a1ff22a6e.
oh right. :-)
"if" should be "else if". Same comment on next line.
Yes, this an old and stale comment that I'll remove. 

I have code ready, which I'll submit in a separate pull request, to implement the part of the revised API that allows providers to perform arbitrary matching and highlighting.
done

From: Jason San Jose [mailto:notifications@github.com]
Sent: Tuesday, August 14, 2012 10:34 AM
To: adobe/brackets
Cc: Ty Voliter
Subject: Re: [brackets] Combine jdiel's "language switching" pull request with tvoliter's templatization of index.html using mustache (#1358)


In src/brackets.js:

> @@ -50,6 +57,12 @@ define(function (require, exports, module) {

>      require("thirdparty/path-utils/path-utils.min");

>      require("thirdparty/smart-auto-complete/jquery.smart_autocomplete");

>

> +    // Load HTML Content

> +    // The htmlContentLoad module renders all of html in Bracktes.

> +    // If a module depends on the DOM being fulling formed before it is loaded

> +    // then the module should listen for the event "htmlContentLoadComplete"

> +    require("htmlContent/htmlContentLoad");

If we can make this change, then $(brackets).trigger("htmlContentLoadComplete"); would immediately follow Mustache.render(). I think that would be a cleaner approach.

—
Reply to this email directly or view it on GitHub<https://github.com/adobe/brackets/pull/1358/files#r1374784>.
What do you think about having a naming convention (e.g. "spec/*-test.js") so that new unit test files are detected, so that they do not need to be manually added to a list?
It would be much better if we didn't need to update this rule every time someone adds a new panel. This should only be the "resizing" and "horz-resizing" classes. Maybe we need to adjust where those classes are applied, but I think it's worth the change.

Same comment for next rule with "vert-resizing".
Ahh, cool, I wasn't sure if it was better to group them together in the section they're related to. I'll move them.
Did we want to change this to 23?
that's the couch key.
Shouldn't these have a `test_` prefix?
You could probably use the utils lib here instead
innerhtml is generally discouraged and will cause us problems on the AMO review.  Use .textContent = ''; instead.
Place `PasswordException` code inside the closure
CAP_SYS_TIME could come into play here.  A system using posix file caps could just set the cap bit (+ep) and have the ability to set the time.  The fork for the ssl process (and seccomp) would cover remaining exposure without actively changing uid/gid.  Then an attacker would be able to falsify the returned server time (within the range of your compiled in values) and not much else.
why?  can priority not be negative in the case?  so that the custom xml muck can be -50 and have a higher priority?
since we are checking across the entirety of pulp which  may be hitting different orgs, it seems this check is not accurate in that it often could be returning false positives.

I'd consider dropping the exception here if it can't find the package and just let you add it anyway.  If/when we can do better validation of content we can properly warn users that the package is not available in the env.
Since deletion is working can we remove the commented lines?
Could we move this into the after_suites function since it is only defined in the test runner?
This is already solved in foreman_architectures branch
It can also be called a "factory method". This is a very standard programming practice and and I think perfectly suited for this case.

http://en.wikipedia.org/wiki/Factory_method_pattern

They're sometimes called "factory classes", in fact Wikipedia redirects searches for that to the link above.
I just noticed that these "raw" class attributes get documented using the docstring of the type, in this case string, so it says `str(object) -> string`.  I don't know if there's a way to fix that here or in the autosummary stuff.  Maybe @eteq knows?
If you want to merge that as a feature of riak_test, maybe a different PR, so we can get this test into the test suite ASAP.
More spaces here.
More spaces needed.
Remove the above comment block. It break the doc generation.
⌘ is not defined in all font, any other suggestion ?

also I dont understand what you mean by "This also must be taken into 
account in the control. This doesn't seem to be the case currently."
can you explain ?

> In core/src/script/CGXP/plugins/GetFeature.js:
>
> > +                }, this);
> > +            }
> > +        }, this);
> > +
> > +        return {
> > +            internalLayers: internalLayers,
> > +            externalLayers: externalLayers,
> > +            unqueriedLayers: unqueriedLayers
> > +        };
> > +    },
> > +
> > +    getMessage: function() {
> > +        var tpl = new Ext.Template(this.queryResultMessage);
> > +        var key = 'CTRL';
> > +        if (Ext.isMac) {
> > +            key = 'META';
>
> META is not understandable for many people.
> Please use "⌘" instead.
>
> This also must be taken into account in the control. This doesn't seem 
> to be the case currently.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/camptocamp/cgxp/pull/308/files#r2446004>.
>


-- 
Camptocamp SA
Oliver Christen
PSE A
CH-1015 Lausanne

www.camptocamp.com

+41 21 619 10 23 (direct)
+41 21 619 10 10 (centrale)
+41 21 619 10 00 (fax)
`constants`, please.
Limit instelbaar maken via setting in de backend
8 bytes aligned when they are pushed to the stack. If they are in registers, I don't see the point.
Oups, I wanted to make it optional, forget line 44, I'll remove it tomorrow. It is useless if you don't want continuation prompt. 

My though was to add a dict of option to cell constructor and eventually forward the relevant one to codemirror.

Would this be more acceptable ?
2010 is probably correct - this file didn't exist in 2008, and the copyright was probably just copied from another file.
Travis runs on Ubuntu, so I guess this is not needed. I probably have it because I copied from my `tox.ini` and I probably needed it there because I'm on OS X.
No, this is not new.
I think it is already fixed upstream, maybe we can also update the file with the new version ?
makes sense, then.  still, I'd probably conveniently make it implement map

On Tue, Oct 30, 2012 at 12:02 PM, David Ribeiro Alves <
notifications@github.com> wrote:

> In labs/oauth/src/main/java/org/jclouds/oauth/v2/domain/ClaimSet.java:
>
> > +import com.google.common.collect.ImmutableSet;
> > +import com.google.common.collect.Maps;
> > +import com.google.common.collect.Sets;
> > +
> > +import java.util.Map;
> > +import java.util.Set;
> > +
> > +import static com.google.common.base.Preconditions.checkNotNull;
> > +import static com.google.common.base.Preconditions.checkState;
> > +
> > +/**
> > + * The claimset for the token.
> > + *
> > + * @author David Alves
> > + */
> > +public class ClaimSet {
>
> ClaimSet is the "domain" name for the object as oauth docs refer to it as
> such. I kept emissionTimes and expirationTimes out of the map so that we
> could have typed access to these properties (they are mandatory and we can
> use these values for cacheing).
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/920/files#r1983351>.
>
>
Shouldn't this be `data->found_submodules = is_submodule`? What am I missing?
Even if this is irrelevant, is there a need to #ifdef it out or can we just leave it? I don't think git is going to let you add a file named "." or ".." so having those files show up in `direach()` or `dirload()` call is just going to cause issues.
Sure, it was more of a testing function so I could see issues with the map.
Fix the alignment on these, please.
Thanks Giorgos!
You `'use strict';` in *remote-simulator-client.js*, and it probably wouldn't hurt to do that here too (eventually we should be doing it in all our JavaScript files).
I like those better. Thanks!
Private functions are probably fine here, but as a matter of principle, I tend to avoid them. If this model were ever to be subclassed, this function could not be used by it's descendants.
Good! However, it's not a "BadArgument". It's "Missing". It's never wrong to be explicit.
Why would you get a `OSError` here? `a_crash_store.remove(...)` re-raises any `OSError` as a `NoSuchUuidFound` error.
ImpermanentGraphDb will not use LogBack (or a available logging framework)

the createStringLogger() is overwritten in it (no idea why).
Please use lowerCamelCase for variable names.

I'm curious if we should also allow $script to be an Elastica_Script object (right now under refactoring in other pull requests)
Any reason why this code has been removed? If it's dead code, please remove it. Otherwise, we got a SWAP() function in common that can be used here
нє. це тупий хак. я не збираюсь писати це в кожній сутності. треба фіксити баг бандла значить
вже прийняли, тепер заморожу.
shouldn't you keep it and change the message to makr it as deprecated, like for the session setting ? It would avoid breaking things for users defining the charset
This typehint should be ``KernelInterface``
I don't know if this is a good event name but this could be discussed I think?
looks like you did a mess when rebasing
why not simply

```php
<?php
$bundles = $kernel->getBundles()
$bundle = $bundles[$name]; // checking for invalid names here is let to the reader
$extension = $bundle->getContainerExtension();
```
Some composer bug, cant remember precisely why. But it should be left there.
this is useless as the only way to reach this is to have an empty  ``$extraData`` array to leave the loop
Ok, filterCatalogueForId is fine.
Hmm, this exception throws in test environment for any $client->request
Please do also add the link to the ticket as comment.
Same pattern re: invitation constructor using ivar.
same here... we could have issues with Vector on larger type than int (GMP, int64_t,...). Just simply use the Coordinate type.
Is the assertion required ? I keep getting errors when trying to compute the inverse of a nD matrix. I could specialize my functions for n = 2 but I don't really see the point of forbiding the use of the cofactor ...
Done 42d33ae
use fmath.h instead of stdint.h - Visual Studio before 2010 edition didn't hand this header. Proper types are defined in fmath.
What kind of error message is generated if you ask for a `subimagename` that doesn't exist in the file?
old typo in there, "lenght"
Should be in the constructor I believe.
My bad. I did remove it from our local installation, by for some reason failed to commit it.
awkward trailing blank line
html+django? :)
I guess you're right. If we take all the parameters from the hash we're allowing the action to come from there, so we might as well accept it. Testing the code now with another minor patch.
in this pull request most of the Utils.debug which are errors are turned into alerts so taht we as developers will find out that there are bugs faster before they have side effects. of course this makes the user experience ugly if there are still bugs, but at least the users know there are still bugs...
No, not only would that create a hassle, there is also a real disconnect between reading the statistics and gathering the statistics. While the gathering can be disabled, reading would still be allowed.
More of a question than a problem with the code. Assuming that a deployment has a MANIFEST.MF configured with Logging-Profile: foo *and also* has a log4j.xml (or any of logging.properties, jboss-logging.properties, log4j.properties, log4j.xml) within the deployment. What LogContext will it end up using? Should we just ignore the Logging-Profile: attribute in the MANIFEST.MF, in that case? If yes, then processDeploymentLogging should happen before we do processLoggingProfiles so that the latter can be skipped if necessary.
The default should probably stay 0.
(the documentation/comments mentioned is from line 6 to line 15)
In my opinion this is really against the whole point of this feature to launch the full application. Also if you really want to go this way you likely want to always launch the application with a Web Activity. (And it works now so there is no excuse to not use it :))

In the case where there is a passcode then the system app should prevent the user to go away or to pan the status bar but that's should be the only difference for the system. The rest would be handle by the app itself.
There is no reason to speak loud in the code. If you really want to add this comment (i don't think you want to) just use the regular font size not need to UPPERCASE
Can you hear bot.io cry?
Mmm. Of course. It works. I'm going to commit it and remove the <tt>links4busybox.sh</tt> file.
can this.show() directly in the loop?
Private? _temporaryCurrentFrame ?
Yeah, DEBUG=1 works fine.  The problem was that for Firefox accessing the same file, Firefox would see the appcache and then be annoying, despite the fact that my localhost serves with a validity of 3 seconds.
shame on me. It's updated
What is difference? Why there can't be just one addOsmPoint(OsmPoint info) ?
In general, do not use innerText. The accessor causes reflows. Use textContent throughout instead.
We could simply use something from the ASF by copy/pasting the code, see this #8

If you go that route, leave the copyright headers intact and just update the NOTICE file for attribution purposes
```js
options.variable || 'templates'
```
...and remove from ``HTTP_MOCK_SERVERS``?
Separate out and sort alphabetically.
See https://github.com/DeuceSTM/DeuceSTM/pull/17#discussion_r1479726.
So these codes should be changed too, right?
https://github.com/cocos2d/cocos2d-x/blob/gles20/cocos2dx/include/ccConfig.h#L175
It is not old code. It is intentional skipping of parent's implementation.
Tbh as Downloader has two responsibiliteis - 
 download - get data from remote
 and extract - place data to target dir in valid form.
But current design, where extracting is part of downloading, leaves little choices with overriding Downloader behavior.
`return "" if body.blank?`
Oh, sorry, I'm [on Debian Sid](http://packages.debian.org/sid/bundler) and missed that it isn't on Squeeze. I guess the situation isn't as cut-and-dry then. I don't know much about packaging practices. Is there some clean way of resolving this?
ok. its clear now. Also i'm glad we got rid of `@history_path`. I'll merge it now - hope it works :)
Comments for what these are offset into.  What structure/stack/what?
Spent quite a while trying to add the edition string as an argument to the Tables page and failed -- any tips on doing this correctly? The compiler was complaining that it couldn't find the config object despite me importing it.
=== 
happens multiple times, only saying this as the file currently isn't passing our jshint rules
Ah good catch. Instead of the extra var we could try to use: typeof(field) tvar; in the macro? Or maybe just a void ptr.
4?  What is 4?
so this is going to pull from master every time we build?  is there a way to lock this down to a tag/specific commit/something?  it looks like this gem is released now, too, so maybe we don't need :git?
This link doesn't work, doc parser doesn't recognize it.
Yeah, this needent block merge
should these be class variables?
@daniel-pittman updated.
This may just be my dislike of inheritance, but what do you think about doing this with delegation instead?
Let's link this section to the [settings](http://rapidsms.readthedocs.org/en/feature-new-routing/ref/settings.html) documentation and add a section for INSTALLED_BACKENDS.
we no longer need to precompile?
I think that topic is too complicated to cover in a few bullet points.
You could put this back in `<head/>` if you wrap the contents in a `jQuery(function() {...})`, but it's not necessary.
woah hope i fixed this
There are more occurences of this in the file
Le 19/10/2012 10:11, Varoquaux a écrit :
>
> In tutorial.po:
>
> > @@ -3276,6 +3276,12 @@ msgid ""
> >  "with its interpreted nature, make it an ideal language for scripting and "
> >  "rapid application development in many areas on most platforms."
> >  msgstr ""
> > +"Python est un langage de programmation puissant et facile à apprendre. Il "
> > +"dispose de structures de données et haut niveau et d'une approche de la "
>
> Il me semble qu'il y a une légère erreur de français dans cette phrase:
>
> |Il dispose de structures de données et haut niveau
> |
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/AFPy/python_doc_fr/pull/5/files#r1887503>.
>
Effectivement. Je corrige.
Yep, makes sense. This was just an attempt to see how something using reflection might work. 

The xebug stuff was just a convenience - shouldn't be in a final version.  

-Mike

On Apr 9, 2012, at 12:25 PM, Luke Opperman<reply@reply.github.com> wrote:

>> +        $this->_config = $config;
>> +        
>> +        $ref = new \ReflectionObject(static::instance());
>> +        xdebug_disable();
>> +        
>> +        $keys = array();
>> +        do {
>> +            try {
>> +                $keys = array_merge($keys, $ref->getProperty('requiredConfig')->getValue());
>> +            } catch (\Exception $e) {
>> +                
>> +            } 
>> +            $ref = $ref->getParentClass();
>> +        } while ($ref);
>> +        
>> +        xdebug_enable();
> 
> Got it.  sounds like we could skip the xdebug calls just by checking for the property then?
> 
> However, I'm not a big fan of the approach, sneaking around the inheritance model of php - it simplifies the end-class but at the expense of giving the end-class no ability to control the final situation, and the end-developer the ability to trace using regular knowledge of php. vs using a method rather than a property:
> 
> public function requiredConfig() {
>  return array_merge(parent::requiredConfig(), array("someValue", "anotherValue");
>  // but have the option of doing more.
> }
> 
> (that said, it would be nice if PHP offered the dynamic property / metaclass support of our preferred languages, to avoid having to make this choice. :) )
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/Cumula/cumula-core/pull/43/files#r660772
I cannot find an authoritative source, but it appears other vendors start
with a default of 64k.  Note your comment in MAS-66 suggesting 16k.

I'm expecting an increase use of SAML to deliver other security tokens --
e.g., interop with ADFSv2.  So, I don't think 64k is unreasonable ... but I
do think it could turn out wasteful for the more common cases.

On Thu, May 10, 2012 at 6:24 PM, pames <
reply@reply.github.com
> wrote:

> >
> > -#define CAS_MAX_RESPONSE_SIZE 16384
> > +#define CAS_MAX_RESPONSE_SIZE 65536
>
> Nice thing about keeping it in the stack frame is that it just gets
> allocated inherently.  Simpler code overall, and we don't introduce any
> overhead to reallocate, etc. Plus if someone is shipping you more than,
> e.g. 16k of data then there's probably something very wrong (or you have a
> ridiculous amount of attributes).
>
> I don't think the overhead would be much but I don't think the extra
> complexity really warrants it when we're talking about a fairly well
> defined response with a size limit we can pretty reasonably cap.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Jasig/mod_auth_cas/pull/33/files#r805390
>



-- 
matt@forsetti.com
Key ID:7208B5B4
These seems to be wrong.
yes sorry wrong comment, it should say absolute path
I thought  the feature of UseRedirectParameterIfPresent is taking into account that another module uses it.

ZfcUser's option:
$this->getOptions()->getLoginRedirectRoute()
This is a generic redirect route.

In another module:
give a redirect parameter to the login form.

In case a user has pre-opened form in another window or tab,  possibly a logged-in user can submit loginform,
and the user should be lead to the same page as when the user logged in.
It is another module's after_logged_in_page. it indicated in the parameter "redirect".

This is not critical bug but is an improvement request.
http://sourceforge.net/tracker/?func=detail&aid=3079289&group_id=2435&atid=102435
you can remove the return tag here. It is already documented in the parent
you should change this message to be a bit more friendly, explaining that this test is only for 5.4+. The current message could let think that using 5.3 to run the testsuite is wrong, which is absolutely not the case.
see above notes
@lsmith77 As the PHPCR ODM is not stable yet, would it be fine to drop the class entirely instead of keeping an empty class for BC ?
This is ok, because you're the only one working on this. However, this is generally bad form, because other devs, FEDs may already have run this migration. In the future you should use a new migration to remove columns.
single hash for comments, so use "# need"
Remove space before )
Should this be "logged in"?
Don't use C++/C99 comments.
I'm missing the following code:
................
      selectedRows = [];
      selectedCells = [];
      var hash = {};
................
Now there's no spaces so these'll all bunch up against each other? I think before I meant there was needless double space...

But the bigger issue is that this looks like a listing of skills, so why not use a `<ul>` with each skill in an `<li>`.
see: https://github.com/mozilla/mozillians/pull/217#r708268
works for me, but I am not a Ruby geek
cloud you expand more detail? There are only two break lines in my side for PEP8
- don't pass global $user object
You are right, will fix.
Perhaps it would be clearer to draw the circle unfilled (just `stroke: BLUE`) and then draw just the arc filled in: `stroke: BLUE, fill: BLUE, "fill-opacity": 0.5` or some such.
True. Maybe it's just me that prefer writing my css with only class selectors as far as possible.

I agree on avoiding renaming as far as possible. It would keep the connection with the original Thematic strong and help people who are familiar with it to feel at home. Though I liked the renaming of #header. header#header feels like overkill

To merge only selected commits, I used `git cherry-pick SHA`on the command line. It involved first fetching the wanted repo to your own and making sure you are in the correct branch when you do it. The SHA is the beginning of the commit number, usually 6-10 characters is enough. But it broke the automatic merge button so I undid it with some git magic. That involved rewriting history and I could only do it because nothing had been shared yet.
If you change this to `Celluloid::Notifications.notifier.publish("log.incident", create_incident(event))` to `Celluloid::Notifications.notifier.async.publish("log.incident", create_incident(event))` it resolves the problems stemming from making synchronous calls within actor internals
Oh wait you guys are right

if(!is_object($fak) && !$fak instanceof CollectionAttributeKey){

i thought i had typed is_object not !is_object :)

Sometimes for some classes (thinking of page) you'll still get a Page object, it just isError. I am not sure if this has been fixed in concrete5, but then in that case that is where a is_object($page) would fail, because it is in fact an object, and instead you'd want to go if(is_object($page) && method_exists($page,'isError') && !$page->isError()) { //wewt }  //if you wanted to skip the instanceof check.

 I think it always helps to check for expected classes being returned and I personally like Type Hinting as well for function args but that is just personal preference and some might not like it because it makes your functions a little more rigid.

See ya
Simply changing the comparison from "== 6" to "> 5" seems to do the trick (although there might be a more elegant forward-looking approach to the whole issue).

-Steve



On Aug 6, 2012, at 3:29 PM, Michael Krasnow wrote:

> I'm not sure, I have to look into the problem more.
Yes they are appearing.  ITIN has not yet been included.  Will do that now.
The `_pending_update` and `_completed_update` mechanism seems quite elaborate.  Do I understand correctly that there will only ever be at most one submitted work item running at any one time?  If so, perhaps there's a way to ditch the counters:  in effect, if I'm understanding the application, you have a state machine with three states: Idle, Updating, and UpdatingWithPendingUpdate.
Looks like there are a few more uses of function.bind() in this file.
Sorry, I don't understand your remark here. When we're creating a duplicate of a class, we're sufficing it with "copy_off". My suggestion is that when the result of "copy_off" + originalIdentifier + n has more then 50 chars, the "n" is moved to the beginning of the new identifier (thus reducing the chance of creating a duplication)
Трудное детство.
лучше количествоВершин, иначе не понятно
Was this a conscious change or did you just paste in a different class overtop?  I had added this so I could actually take in some of the formatting like code example blocks and render it in the docs.
Whats with the numbers?
I added an empty text field.
OK, I talked to people from #mozweqa, and it would be nice if you could change the locator like this:
(By.CSS_SELECTOR, "#page > .primary > h1")

Thanks!
oh I see now....
All the other locale files are changed to use to more formal word 'U', except this one.. here there are still traces of 'Je'.
@jipiboily ?
should probably be `aBoundFunction`
Actually not necessary since it will return an empty doc if everything failed.
Please update the comments in this function
I'm wondering if it makes sense to do this in a separate search.js file, just like rest.js.
These methods seem to be missing their jsDoc
Sam here
`to` not `so`
Are you sure it was deleted? I fetched the code from repo today.

-- 
Amir Shaikhha
Ch. 5 iii
Я думал, у нас практика повторяет рассказанный материал в обучении. Например этот http://www.youtube.com/watch?v=6cAO032M6Yk&feature=player_detailpage#t=46s
по уму надо и на отрицательное там проверку поставить было, проглядел
Во внутренних методах класса лучше ничего не выводить. Максимум - выработка исключений.

Кстати, если я передам в этот метод отрицательное число, то на вход будет не пойми что (неизвестно какое число), и метод будет работать совсем не так, как вы от него ждёте.
+1. I think it works  at 5000.
Also, we shouldn't default to JSONP if they specify CORS but it's not supported because we have no idea if their server supports JSONP.

This is how I would imagine it working best but am open to other ideas:

    if(crossDomain)
        if(cors && !hasCORS)
            fail the request
        else
            assume jsonp because they added crossDomain options but not CORS and set dataType and jsonp options
@gtanner is this going to break anything (that we are missing)? If I don't hear back, I'm going to continue merging this in (for now). Thanks!!
Consider `msg.send`ing this instead of using `console.error`. If folks get used to seeing YouTube metadata, they should see any errors that come up too, otherwise it's confusing why the metadata isn't being shown.
please, check not the current branch but $BRANCH_NAME one
my bad HPI coils have specific types see mne.fiff.pick.channel_type

I am find with misc but add the picks param that defautls to None
Please use JSLint from within WebStorm or from http://www.jslint.com/ to fix the style of the code.
u can use Future.success(r) rather
How do you think, what is the best place for this? I can't find any development docs for factory_boy (how to contribute, how to run tests). Travis CI is also undocumented.
`data.objects` will work here.
I decided to stick to libcurl syntax: http://curl.haxx.se/libcurl/c/curl_easy_setopt.html#CURLOPTSSLVERSION. I found it to irritating otherwise.
None of the Pinto API is official (yet), so don't hesitate to break the current interface if it makes sense.  The command line interfaces for pinto-admin, pinto-server, and pinto-remote are the only interfaces that are even remotely stable.
I believe it disables it in development. But I'll have to check when I can
actually see the code (on a bus)
On Oct 31, 2012 1:54 PM, "hhoang" <notifications@github.com> wrote:

> In config/initializers/omniauth.rb:
>
> > @@ -0,0 +1,6 @@
> > +Rails.application.config.middleware.use OmniAuth::Builder do
> > +  provider :developer unless Rails.env.production?
>
> No, sorry. It's just specified inside the Omniauth documentation and I
> just copy and pasted it. (I'm a bad programmer...)
>
> https://github.com/intridea/omniauth
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/urails/urails_rumble/pull/6/files#r1997312>.
>
>
Should this really be code config?
I'd suggest pulling the config from the applicaiton config, falling back to akka-camel's reference.conf
The "Deprecated syntax." part here looks out of place.  I would just remove it entirely.
yes, the deletion was intentional because of two reasons:
- most part of it was not working anyway before my changes
- all of the functionality is duplicated in the (working) files in doc/src/modules/galgebra/GA and sympy/galgebra/tests
Please rename it to activeLinkTemplate and inactiveLinkTemplate to be more accurate.
Es cierto que `.Single()` es más compacto y correcto, pero al final decidí no hacer el cambio porque:
* No tengo ganas de probarlo nuevamente
* No puedo discriminar fácilmente la causa del error
just curious, why the change? We seemed content to use the relative path in the past.
Don't use magic constants. Always declare them as constants.
Can we say `options:` instead of `withOptions:`, since that's closer to Cocoa convention, and we're already saying `withNewTree:` here?
Again, doesn't appear equivalent.
Hi pelson.  I could be wrong but I think I have added these files to. gitignore
My vim's syntaxe hightlight shouted at me :) I don't think this is a big problem, but I would consider fixing that in the long future with a lot of deprecation warnings before.
I saw this behaviour with IPython's custom backend (see: [backend_inline.py](https://github.com/ipython/ipython/blob/master/IPython/zmq/pylab/backend_inline.py)) that doesn't return a `FigureCanvas`.
I'm just concerned about the fact, that this new `_setup_canvas` function might break other applications that don't provide a `FigureCanvas` class as they are used to the old way.
Separate pull request
Вы правы. Поправила.
This is mainly from ActiveMQ. AcitveMQ send for each communication a Wirefromat, which has some diffrent parameters. This parameters are then used, to configurate the own Wireformat so that both have the same configuration. The idea behind this line is that when a wireformat is set, that all the ActiveMQ protocols have the same WoreFormat. "RenegotiateWireFormat" is from ActiveMQ
`manager[s]` should probably be pluralized -- it will flow better with plural `department members`
Ditto platform independent paths