labofsahil/github-event-dataset-2012 huggingface dataset:
Most *nix platforms require special callback memory handling enabled by `FFI_MMAP_EXEC_WRIT`.  Why doesn't this one?  All the callback tests pass?

This one doesn't require an explicit include path to X11?  Note that AWT tests will be skipped if you're running the tests headless, or if you run ant with `-Dheadless`.
Right, I had that happen with this one before.
What's the difference between strArtist and artist? I didn't read through the thread so maybe it's stated there but it looks very confusing to me. Will strArtist always contain a single artist's name?
Yes, a leftover from the previous PR where we had a private property of type CURL. Moved it back from .h to the .cpp
This is going to slow things down somewhat I suspect - any idea how slow it gets?
Ignoring the problem that the function call is per-item (and thus you can't save the db open/close between items) you could:

CVideoThumbLoader loader;
loader.FillLibraryArt(item);

Same for the music art.  It's still got a db open per item, but it's then unified so you make sure you get all the art.

If you can persist your CVideoThumbLoader members across calls (JSON-RPC does it by passing the loader into the function that formats stuff up), then you can save the db open/close by first executing CVideoThumbLoader::OnLoaderStart().
I guess I was thinking of the case where a tap at the extreme top-left of the window would generate an extra tap, since it would get dispatched here and again when the mouseup event went through.  It would take a very exact click to generate that, though, so maybe it's not worth checking into.
Maybe the goal is to differenciate when it is an error because of a bad implementation, but i think it would be good ti have only one interface, and then extends it to keep the explicit name of the interface...
I would remove all the caching done here. That's not the right layer IMO anyway.
Yeah, that was a leftover from when I added in transformers...
Mostly because that'd be the end of using the navigation controller at that point, since you can't push/pop anymore from the scroll view. When your nav bar comes into place, that'd be a great thing to do.
hrm, weird, I wrote the code but must have forgotten that second git add. I will fix.
Changed to `(TypeError, KeyError)`
I would make this change in engine.js directly.  

Currently, tokens are allowed in all strings that go through compiler.introspectString(). Since all required tokens show in up statement.preRequisites, the engine can check skip a statement when preRequites are not found in the context.
Actually, would `sub` be preferred over `gsub` here? I'm sure the difference would be very small but I imagine `sub` is faster.
I'm not sure how it is set up on the docs server. @fxn can tell.
Why is there a `try` on the error_field?
Also, why do we need to use a different default (mm) when debug is true? I think our default would work just fine (if it was url encoded).
This is not going into 2.10.

One place to address such concerns is the relevant discussion on the mailing list. You're welcome to voice your disagreement there and discuss it with those who voiced a different opinion.
I still feel uneasy about changing the types here and I don't feel confident that I understand how the condition in the code (hasPlusMarker) corresponds exactly to the condition that's stated in the comment.
Fix this with css?
indeed. others might even be tempted by goto's :)
It's basically a specialized assert, i.e. with an error message built in. I don't use asserts anywhere in the non-test code, as I do not want the application to terminate or remain in an unknown state in a lowish level library. The caller of this library must decide what to do with error conditions, e.g. attempt recovery, journal and retry later or to a backup queue.
what do the square brackets mean?
or

```
sargs = list(self.args)
for i, term in enumerate(sargs):
    if hasattr(term, attr):
        newterm = getattr(term, attr)(deep=deep, **hints)
        if newterm != term:
            sargs[i] = newterm
            hit = True
if hit:
    return self.func(*terms)
return self
```
I am also of the opinion that we should do away with warnings. 

Another way is to plot real part and imaginary parts separately with different colors(like mathematica  does). This will be valid only for 2D plots as 3D plots will look really ugly with different colors.
Yes, see my implementation of __str__
It has something to do with finiteset. The elements property was the only sensible thing I saw that could help me get the set of partitions. Its str representation returns the frozenset. Should it matter? After all this inherits from FiniteSet. Although I do store partition list form so that the RGS routines do not misbehave. Maybe I should return _that_ instead.
Plus, my method is marginally faster on my machine.
这里的接口做了修改，加入了encoding参数。
No need to use var $joinTableName. Remove 566 and make 577 like:
```
if(($joinTable=$schema->getTable($this->relation->getJunctionTableName()))===null)
```
no need for this empty line, see other doc comments and use same style.
Still need to check fTarget:

```c++
void plLightModifier::RemoveTarget(plSceneObject*) // argument intentionally ignored
{
    if (fTarget)
        fLight = nil;
    plSimpleModifier::RemoveTarget(fTarget)
}
```
I would tend to use double quotes here instead of escaping. Do we have a standard practice?
@royaltm Are you sure you wish to match the beginning of line? I guess you want to match the beginning of the string (```\A```)
This is purely a readability, but I think it's more clear what's going on if you actually include the `else` here and make it a full conditional, so:

```python
if not self.router.retryable:
    raise e
elif retry == self.max_connection_retries - 1:
    raise self.MaxRetriesExceededError(e)
else:
    conn = self._connections_for(attr, retry_for=conn.num, *args, **kwargs)[0]
```

Also, I might move all that logic into its own method called like `attempt_to_retry_connection`, and then the except block only needs to call that.  Right now there is a lot of nesting of for loops, conditionals, try/excepts it's harder to read.
I would recommend using `getUriForPath()` instead of "magically" prepending the base URL.
Will do, and not entirely sure myself, will change to proper notation.
revert, because we don't give a sense of what "too large" is (and can't really.)
though would `url('wiki.document', translation.full_path)` be even better?
Two semicolons? THIS IS MADNESS!!!
Nope. mtime and atime should be modified in line 68, then read on line 72 and 73. Line 76 should update them, so they definitely ought to be greater.
I didn't like it either, I will use that.
Yes, maybe we should change this line completely. Maybe something like "You were signed out of all selected active sessions" ?
$mark_forum_read is not defined if the above if statement is not run. IMO, this would be acceptable instead:
` 'S_UNREAD_TOPICS'    => empty($mark_forum_read),`

Keep in mind that when the item your checking in a ternary conditional is boolean itself, you don't need the `? true : false` because it will already return boolean.
Empty line here please.
Why are these configuration values hard overwritten here? If this is the expected behavior then `$config['fulltext_sphinx_min_word_len']` and `$config['fulltext_sphinx_max_word_len']` should be defined as constants rather then overwriting the configuration values.
tableContains?
this was the code that was there before... This code handles the non-srv record lookup.
Nevermind dat, spun prostii: 0 fiind `int`, primitivă, nu se întâmpla ceea ce am zis mai sus; deci ignoră comentariul.
Nu stiam ca exista:D
Do we require data_ to be a random access fusion sequence?
Would eliminate clutter if we used a single checkbox rather than a radiobutton (default "off")
http://docs.sencha.com/ext-js/4-0/#!/api/Ext.form.field.Checkbox
I think ```read_int16()``` helps readability of the code, similarly above read_uint32() rather than read_dword(), especially since you are reading a hardcoded number of bytes.
What do you mean by "exist" here?
For readability, it would be better to have the keyword names here.
Yes, fix it in this way.
The comments above apply to this method as well.
Why is countable being passed in as a param if it's always set to true?
UNION_TERM is not used, should not be propagated into the EE.
Put commit_on_success on some smaller function inside.
That can be removed.  -webkit-transform:translate3d is generally what causes the blurryness on iOS though.
pf is already unicode here, so we can safely assume `pf + '.mo'` is always unicode. Now `os.environ` does not support setting unicode content with non-ascii. Should we once again retrieve fs_encoding to pass it to force_str (or add a `npath` (native path) utility in `_os`)?
Cue a lot of useless diffs due to bad indentation. :)
Why is it necessary to copy the file?
`for in` is [broken in JavaScript](http://www.jslint.com/lint.html#forin). I think this should be rewritten to use a normal for loop.
I didn't know about `#pragma clang diagnostic`. Thanks!
`"t");` => `"t" );`
This comments should be max_split_point. And its type is integer.
Both the meaning and the content is the same as the fourth element of an float array:  last_values FLOAT[].
IMO ident should be:

```
futures = [b.library.find_exact(**query)
           for b in self.backends.with_library]
```
This should be more specific, and a commit of its own with explanation.
@Sharpie  This is a great tip (and powerful homebrew feature), but unfortunately, I could not make it work for geocouch.rb.  Couchdb runs its tests from the file system in the browser, and I believe couchdb sandboxes the permissible files strictly to those  in the share/couchdb/www folder.  Since the symlink sources reside in share/geocouch/www (i.e., outside share/couchdb/www), I could not get the symlink approach to work (at least with my limited couch-fu).  So I have returned to direct injection of geocouch tests into couchdb test area (i.e., inside the couchdb sandbox)... which works.

Lacking more couchdb configuration knowledge, erlang expertise, or general couch-fu, this recipe still installs geocouch tests directly into share/couchdb.  I did organize the geocouch tests into their own subfolder though, and then symlinked them into place --- adding a little subfolder organization and an obvious "geocouch" in the symlinks for troubleshooting/clarity purposes.

I hope this change is enough to address the symlink issue as much as possible, even though the hybrid nature of the geocouch recipe and strict nature of couchdb sandboxing seems to preclude the symlink approach.
please see the updated commit. I have put a lot of effort in double checking which is the minimal set of needed flags until I can compile most formulae.
Well, since my patches have been merged upstream, the whole devel block can be removed.
Not really. Just pushed the updated formula. Thanks.
You need double quotes for interpolation to work.

also, split this into two arguments: `system "#{bin}/pass", "--version"`
`ENV.j1` is the same as `ENV.ENV.deparallelize`
Overriding Makefile variables can be done by passing values on the commandline, rather than patching, e.g.

```rb
system "make", "MANDIR=#{man}", "BINDIR=#{sbin}"
```

etc.
As we have the minifiers in place we can skip all minified js - don't we?

Thomas Tanghus <notifications@github.com> schrieb:

>> @@ -54,6 +54,9 @@
>>  OCP\Util::addscript('files', 'jquery.fileupload');
>>  OCP\Util::addscript('core', 'jquery.inview');
>>  OCP\Util::addscript('contacts', 'jquery.Jcrop');
>> +OCP\Util::addscript('contacts', 'modernizr');
>
>I don't think you have to add the unminified version here? It is just for license reasons that it has to be distributed in the packages.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/owncloud/apps/pull/1/files#r1499998
Nope 29d04c94060fb74e2a1a5dd5d2a8bb24c84e9ea1
Cut in d21354f9
Do you still need to listen for orientation change?
These styles aren't being applied—they need to be imported into the page_defs base.scss
I wonder if the ideal fix for this might be in CodeMirror -- similar to the isInWidget() checks used for mouse events.  Is there any time we'd want key events to bubble up out of an inline widget and affect the host editor?
The word *inline* is usually just transliterated, and *editor* is *Editor*. Refer to some examples for the translation of *inline editing* over at [Linguee](http://www.linguee.de/englisch-deutsch/uebersetzung/inline+editing.html)…?
Is this rule used anywhere?
Sounds good. Wasn't sure where to put it first. Is the name ok, or would 'project/WorkingSetSort' work better? To make it specific to WorkingSet
Shouldn't the case where `args.length <= 1` throw an error? I mean you need at the very least would expect 3 args right? Old name, new name, callback?
this will throw, because `this` is in a different context now.
Replaced with factory.getUniqueString().
i tend to replace for-loops with list.append() with generators, and thus change ```return values``` to ```return list(gen_values())```
Drop this table for now. We'll bring it back later via flask-lastuser.
The object don't respond to the to_xml method, what you see is the output of to_s. For testing to_xml we need to add active_support and builder(https://github.com/lifo/docrails/blob/master/activesupport/lib/active_support/builder.rb) into dependencies, the question is should we?
Not sure it will always work. I'm afraid you may miss some informations by calling twice "next" in your for loop. It may work now... but what happens, for instance, if you add some comment in the XML that is sent back by the server ?
but `True and x` is always `x`. And `True in ..` is just a very complicated way of implementing [`any`](http://docs.python.org/2/library/functions.html#any), as in:
```
%for facet in pager.facets:
    %if facet.available() and any(getattr(item['raw'] , 'visible', True) for item in facet.current_items)
```
Or is there any reason why we have to evaluate visibility for all items, instead of just looking for at least one visible one?
id != email?
Why name it `UserProfile`?
I removed third file "query.js" and merge it with "search_bar.js". I also removed that duplicated code from "search_bar.js" since it was redundant so there is now almost no duplicated code, but i couldn't merge together  "search_bar.js" and "search_page.js"  I tried 10 different solutions but none of them worked.

Also moved "see on google" link under search bar.
remove this entire block. it is no longer in Butter
It seems the indentation here is wrong.
Put some spacing between these brackets and variables please.
move `"util/shims"` down a line and put the comment above it as it's pretty long
Instead of doing it on an individual basis, why not put this somewhere like here: https://github.com/mozilla/butter/blob/master/src/editor/editor.js#L32
Removing second disabled state, now just have one for all buttons to use.
haha sure, sorry about that
Presentation/UI logic shall be move to different file -- its not a core functionality anyway
You could modify it to have a span with the text in it, and then modify it just call text()  on that span.  I feel that would be more readable.  Only reason it wasn't before was because we had no reason to change the text before.
Should this even happen?
It isn't used in the return statement for `convolve_fft`, only `convolve`.  Shouldn't ``.astype(array_dtype)`` be added to all of the return statements in `convolve_fft`?  (I count 5 of them...)
Customizing this message causes extra work for the translators. I think it's better to keep this message generic, so that we can re-use it for all settings that need restarting.
What's the rationale for changing the name of this link? It's fine as long as it points to the right file isn't it? 

This does complicate matters, and we'll have to handle both possible names forever.
Every simplyfication is a great step, so I agree ... but I don't want to bloat this pull request :). I would like sipas boost pathm rework merged into master before my util updates get in, as he has a better GetDataDir() version.
grrr.. you are right, of course!
Are you sure this isn't needed anymore?
Some alternate names could be `Logger`, `Logging`, `Logged`, `LogLike`
\n is missing here
erm yes, that would be far better :)
it is a type:

```php
var_dump(gettype(new \stdclass));
```
Ah, I misread, my fault. They're are... filtered. :P I'm not sure what I would do... because it's not straightforward to audit, but that's all (like ManageErrors).
Is deze lijn nodig? Zal PCRE_VERSION niet altijd defined zijn als extension_loaded('pcre') true is?
I'd either put this into the companion object, or make some kind of MongoSerialisable trait.
Does this documentation explain anything?  Switch `#'` to `#` ?
Right, but there's no need for the conditional. The expression will return true or false on it's own.
Does our documentation system call this to generate a list of all magic functions?  If so, we should test this to make sure that the formatting is still okay before committing.
In js, you can do a `for..in` it loops through the indexes or keys.
it will allow you to drop the `nsheets = ...`
Does this need a method body :-)
oops!, I was going to add it and use it for validating full document output for correctness but I realized I needed your patch =/ ( believe? )
fix it when its pushed or suggest a different solution :P
I'll just change it to -1 I think.
Why the cleanup here?
old regex /^[^\/]/ meant: string not starting with symbol /. Now regex is: /^[\/:]/, means: string starts with symbol / or :
Please remove this. We do not use java in the build, despite any messages that may complain about it.
> Probably because it doesn't use funfactory's reverse, which handles the locale stuff.

Are you sure? I seem to remember we carefully monkeypatched this stuff.
I'm wondering if the `alt` here should turn into something more usfeul here. Maybe @icaaq could give us a tip?
nit: extra blank line between blocks
This is some weird bug. On the dev site, anything the form generates is not marked as "safe". These errors might be, but the form inputs are definitely not. And it's JUST on the dev site. It works fine locally and on the live site, but it makes it difficult for testing when the raw HTML is dumped on the page.

I've been trying to get this fixed for a while but I had to fall back to `safe` so that we have a chance to test everything tomorrow.

See https://bugzilla.mozilla.org/show_bug.cgi?id=733520
Can you get to this if statement if password is "falsy"? If so, I think maybe adding a:

    if not password:
        msg = _("Can haz password?")
        raise forms.ValidationError(msg)

to the top of ``_check_password`` is a good idea.
ah, i see. If you want to keep results as an array to use for response that is fine.
Yep. Thanks for catching that.
dump those expressions to the console to check:

* if the frame module has been imported correctly
* the persisted property is availalbe
* screenshotPath has been set correctly

You can use JSON.stringify(object) to print the object.
Ha, my bad, this is indeed not being passed to the middleware.
@peterbe probably doesn't mean what you think it means :) the class was folded into socorro-base.pp a while back.

Just to clarify, the vagrant install still sets up the old (current prod-style), this PR is simply about getting things running at all again.
You will also need to keep ``bugs`` in here.
it doesn't. fixed in this commit:  https://github.com/bhouston/three.js/commit/5d70541b3d8b02dfedc911057ae61d22083ea121
All the stuff happening in this file is *awesome* :) Really happy to see this cleared up.
Please always put the __construct on top.
Doesn't not deleting this leak memory?
Please, add a TODO here
is this the same?
Calling explicitly `getNonDelimitedPattern` result in a failure, the pattern exists but cannot be converted, this is an exception.

`getHtmlPattern` will however return `null`, it can’t  find one
yeah already did so locally
Should this be in the if above - ie there is no need to inspect internal classes hierarchy.
Does `[$block]` really make sense for Twig where all the blocks for a `cacheKey` are loaded by a single call. The code might end up scanning the theme hierarchy only to set `$this->resources[$cacheKey][$block]` to false.
or even better `$request-> isMethodSafe()`
`switch` ? For one case ?
I would say someone should check the failingLangcodes().
same here. It looks more like an InvalidArgumentException
The elseif should be changed by else if.
IIUC, that should only be done on Windows ... but not on *nux systems where it will fail. And what when the bug will be fixed?
Honest question: Could this be rewritten as `unless content.empty?`? I feel that this is mainly a style thing, but it may make things a touch more readable.
I think

```javascript
$('#uid-error').hide(); 
```

is more readable.
Line looks over 80 chars. Any way we can break this up?
Yeah this looked funny to me also. Thanks for confirming suspicions.
Dies laedt die services.yml aus unserem UserBundle. Das gleiche passiert auch im SnowboardBundle, das wurde aber damals beim Generieren des Bundles schon automatisch angelegt.
the return is not using anywhere.
paramaters => parameters
before the advanced search was always showing the default fields  of the first corpus it loads (the untitled corpus) so it looked like the users could only serach the pre-programmed fields. thats not true.  I changed the render function of Advanced search to pull in the current corpus' datum fields so that the users will know they can search any of their fields. This was important for the verb lexicon import since it has (appears to have) over 400 fields per datum!
Dropping this causes tests to fail that expect an empty string as the default for the title option - without the typeof check here, the option ends up being reset to `null` instead. Arguably the right default value though.
As I said, accordion has different concerns.
why so many comments? if the file is unused just delete it
Stupid thing but if you want to change you save code :)

var aquery1 = [].concat(FRIENDS_QUERY);
For simple key/value object stores, you can also omit the keypath, and just pass both the key and the value separately to put().  I don't know that it really makes any difference, but it might be slightly simpler to do it that way.

Its too bad we don't have a utility for trivial DB uses like this.  I just wrote shared/js/asyncStorage.js which is an async string->value map. There's a pull request for it now, but it won't work here, at least not in its current form because it does not have error callbacks.  If you want to use it, though, I could add them.  You wouldn't get such specific informative messages, though.
what’s this `buttons.css` stylesheet? It isn’t in the `shared/style/` directory yet.
I ask him to just handle one modal a time for now.
Saw that further down :)
Thanks I didn't know that. Seems like Opera support it and we don't!  Can you add this https://bugzilla.mozilla.org/show_bug.cgi?id=570326 next to the declaration. Thanks!
Absolutely right. Thanks!
Could you ( @etiennesegonzac , @basiclines ) tell us something about @jmcanterafonseca 's comment, please? :-)
I meant to make a note to not do that once https://bugzilla.mozilla.org/show_bug.cgi?id=769182 is fixed, cheers
:smile_cat: I won
Even if the three timer triggers at different time, you can use `setInterval(fn, 1000)` and decide if you need to wrap the date/day/minute/hour every time.
typo: 
s/explicitely/explicitly/
Is filetype typo? looks like fileType, not filetype
`type` attribute isn't required in HTML5.
no, Q_DECLARE_PRIVATE will set up d_func and stuff, but you stiill need to define your dpointer yourself
When the connection is on when the bug layer is created, and than, it will went off, the user will not be able to add osm bug.
What I want to say, that depend on such dynamic setting at time of construction is not a good idea, I think. This also applies
for the POIs
Maybe `BitConverter.GetBytes` can help here.
Why would the response fail to be parsed? Do you have a case where this happens?

No interest in defensive programming for the future. If you have IE10 available, let's test and find out if it's a problem. But no preemptive programming otherwise.
This code doesn't make sense here. Seems like it better belongs in built_request_uri? Also consider putting this into its own method with some sort of descriptive name because it's not clear at a glance what's happening here.
Change to Moments Group laws?
I'm wondering, would it be simpler to do such things for `mousedown`, and for `touchend` if `L.Browser.touch` in all places, removing `START`/`END` arrays and loops all together?
Indentation seems wrong on these continued lines - you need a 4-space hanging indent in these cases (here and elsewhere):
http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Indentation
I'm not so sure this will work as you expect. What if my starting position is (0, 0, 0) and my end position is (-5, 0, 0). Then hasNext() will always be false.
More explanation of the "gyp" file format or a link to where I can read more about it would be nice.
Yes, but you see, if a Bukkit plugin relies on this function, then it will get an unexpected result and could end up breaking something. We want to emulate Bukkit as close as possible.
This isn't your fault, but after internal discussion, we decided to not implement EntityMoveEvent (performance reasons). Rather, if you need to check the movement of entities, you can attach a component to them and check in the onTick method.

I planned on writing up a small component to attach to players when they join so that onPlayerMove is fired. You can attempt this yourself, or just remove this method.
`if params.get("force_cleanup") == "yes":`
Yes, the first disk in /boot/grub/device.map could be other disk which virt-v2v convert to virtio disk vdx, the x remains what it is. So  Amos is right.
I've added now condition to set PlatformToolSet to v110_xp for Visual Studio 2012 only.

Should work on vs2010 (not tested).
This looks a lot like delete-file-recursively from clojure.contrib.io, it can't be included wholesale like this
In theory yes. In practice though I saw python or ruby webdriver do implement slightly different behaviours and formats in their commands.
It's not a complex check and make us a bit more solid.
Don't you agree?
I would like to discuss with you the need to validate the names of the repository (the project), but decided to do so after giving the code. In fact - we use the name of the project in the future for the name of the directory that will host the repository itself on the disk. In this case, this test is not very different from the way. It is difficult to say how high should be the degree of freedom of project names, but the choice of white path with an extended range of valid characters is not a bad thing. As a starting point, I think, quite a test. If necessary, it can be expanded.

I usually prefer not to trust users :)
What's the point of creating additional controller for this?
As I said before:  since no measurement is being done here, what do you think you're actually measuring?
A lot of these selectors don't need to be inside the .football-stats block at the top, this makes them too specific and cannot be re-used elsewhere
Cool. Didn't know, thanks!

On Tue, Sep 4, 2012 at 10:05 AM, Nicolas Morel <notifications@github.com>wrote:

> In package.json:
>
> >    "repository": {
> >      "type": "git",
> >      "url": "git://github.com/idottv/node-xml-events.git"
> >    },
> >    "main": "index.js",
> > -  "scripts":{
> > -    "test":"node_modules/.bin/mocha test.js"
> > +  "scripts": {
> > +    "test": "mocha"
>
> npm adds node_modules/.bin to the PATH when running scripts, npm test
> should work just fine this way.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/idottv/xml-events/pull/1/files#r1524289>.
>
>
Does this open the device for reading pkts? If so you may want to move this to the *Loop function. We're going to do that for other pkt acq's as well to not get pkt loss reports due to the timing between open and first read.
Fixes a bug where @import statements were not parsing the less files. Basically lessc returned null on these files since it couldn't find them.
In this specific case, the fact that `dataURL.base64` is `true` and `dataURL.parameters.length` is `1` means that the parameters value has to be "base64", so it will be redundant.

But if you think it should be present, I can easily add that test.
URL to a file is incorrect here.
Unless info.complete handles it, if this XHR request fails, no error message will ever be displayed to the user. One of the bad things about putting user.* calls inside of state.js.
Good catch; appreciate the comment here
I added the closing tag to conform to the parser's spec: https://developer.mozilla.org/en/HTML/Element/span . I'm sure the program will run without it, but it feels a bit more satisfying knowing it's valid :p.
I've looked at that module but I would not recommend it as it requires OS X to have Growl installed or else it will log the error silently to console.
It is microseconds.  It comes directly out of PR_Now..  Surprised me too.
can't we use a specialized exception here?
# @param bit [Boolean]
So, we're explicitly testing when the kernel is `FreeBSD`, but according to the confine from earlier in the list, we could also run on `GNU/kFreeBSD`.  These tests should be expanded to include the other kernel value as well.
D'oh.  Totally forgot that test.  Thanks, that's why we review...  Will add it when I add `@name` to error message and acceptance test.
I don't think there is any reason for the `unless` on this line. The `join` will just return an empty string if `verify_errors` are empty. The only thing this saves is that we won't end up with an extra space character.  I think this could be dealt with by just formatting the error message a little differently.

Maybe change the list of stringified `verify_errors` to be displayed as a list in square brackets. So that it appears as '... [verify error 1; verify error 2]' Then in the case were there are no errors it would be '.... []'.
OK, leaving that one alone for now.
For some reason, I thought the snapshot branch was separate and could be used to the asynchronous saving to the server. Sorry about that.
Is there a `break;` missing here @mtibben ?
change this to
2.0.1-SNAPSHOT

change
project/release.properties
2.0.0
looks good, I suppose we'll need `xtest()` and friends for the TDD one as well but we can wait on that
@Ocramius don't skip Zend\Cache -- this one has a maintainer, has already been refactored, and is generally passing. (BTW, I can't recreate that test failure locally, either... which makes me wonder if it's a timing issue.)
We can't move them during the 2.X cycle at this point. If we'd done this prior to the stable release, sure -- but following stable, no. We should do this for v3, however. Reminder to myself: start a v3 TODO. :)
yes.
At least on MySql
This feels a little iffy to me... if no email or name was provided, how about just don't continue with the rest of the script? Also, my GitHub email is not the same as my Kiln/mercurial email, since most of us have personal GitHub accounts using our personal emails. Could probably separately ask for GitHub email and username (if the user doesn't already have this setup).
Sorry about the diff spew. This is the only actual change.
Need a header here :p
It just prints it in red. Personally I hate the convention of printing the plugins prefix on all the messages, it seems tacky and undesirable for users. Think about it, players don't give a shit what plugin is printing what message. If I'm the player I just want the information.
original version caused errors in the test suite, but i fixed this in another way
It does, you're not seeing the latest because of the way this thing does reviews.
This is done by default. Can be dropped.
It is probably worth writing a context manager to allow `with shared_lock.shared: ...` which whould remove a large number of `try...finally` in the code.  Basically something like (again, untested code)
```
class SharedDescr(object):
    def __get__(self, instance, owner):
        class Manager(object):
            def __enter__(self): instance.acquire_shared()
            def __exit__(self, ...): instance.release_shared()
```
and add a `shared=SharedDescr()` field to `SharedLock`.
Remove or use fancylogger and log.debug.
Allright, I'll fix this.
ping @maxdec
That might be a nicer general solution, since this whole "symbol gets loaded as string" weirdness is confusing,
I still want to get this in for now as backwards-compatible fix
`api` should probably be added to `settings.default.SUPPORTED_NONLOCALES`.
no need for blank line here
Yeah, maybe. The problem is that I don't know why this is there in the
first place. The unittests pass fine without it FWIW. I suppose if you
artificially set you algo_start before the first event.

On Tue, Oct 23, 2012 at 4:45 PM, Eddie Hebert <notifications@github.com>wrote:

> In zipline/gens/tradesimulation.py:
>
> > @@ -214,10 +214,10 @@ def transform(self, stream_in):
> >                  # We're still in the warmup period.  Use the event to
> >                  # update our universe, but don't yield any perf messages,
> >                  # and don't send a snapshot to handle_data.
> > -                elif date < self.algo_start:
> > -                    for event in snapshot:
> > -                        del event['perf_message']
> > -                        self.update_universe(event)
> > +                # elif date < self.algo_start:
>
> Should we just remove this completely?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/quantopian/zipline/pull/5/files#r1921300>.
>
>
Can you please revert this? We prefer to bump the version ourselves.
Added label for value to make it more readable.
See comment below about blank lines and package changes.
Could we add a disabled class to this set of definitions as well?
Nice use of `true` to close the path! You've obviously picked up a lot of the little details of our framework!
wrong complement!
That's right, it would create a new `Quantity` object. I guess we could do something like "take the units from the object on the left" but that seemed kind of arbitrary to me.
Should these asserts be changed into 'self.assert*' method calls?
I suggest adding a short time.sleep (0.1 seconds?) before each of these assertions, just to give the code a better chance to do the wrong thing.  (Motivation: I made a typo earlier when I was working on the state machine, and noticed that this tests only failed occasionally;  with a time.sleep, it would have failed every time.)
Fixed header row to correctly reference "headerRowHeight" config property.
These changes should be reverted.
тут не очень понятно, что владение отбирается, лучше передавать unique_ptr
Hello David,
Yes LOOKUP will make it faster, I'll do the change.

Regards
Victor

On Fri, Jun 1, 2012 at 6:15 PM, David Bayliss <
reply@reply.github.com
> wrote:

> > +     END;
> > +     SHARED class_cnt := TABLE(Dep,{classifier:= number, c_actual:=
> value, Cnt:= COUNT(GROUP)},number, value); // Looking for class values
> > +     ConfMatrix_Rec form_cfmx(class_cnt le, class_cnt ri) := TRANSFORM
> > +       SELF.classifier := le.classifier;
> > +             SELF.c_actual:= le.c_actual;
> > +             SELF.c_modeled:= ri.c_actual;
> > +     END;
> > +     SHARED cfmx := JOIN(class_cnt, class_cnt, LEFT.classifier =
> RIGHT.classifier, form_cfmx(LEFT, RIGHT)); // Initialzing the Confusion
> Matrix with 0 counts
> > +     SHARED cross_raw := TABLE(J,{classifier,c_actual,c_modeled,Cnt :=
> COUNT(GROUP)},classifier,c_actual,c_modeled,FEW); // Counting ocurrences
> > +     ConfMatrix_Rec form_confmatrix(ConfMatrix_Rec le, cross_raw ri) :=
> TRANSFORM
> > +             SELF.Cnt        := ri.Cnt;
> > +             SELF                    := le;
> > +     END;
> > +//CrossAssignments, it returns information about actual and predicted
> classifications done by a classifier
> > +//                  also known as Confusion Matrix
> > +     EXPORT CrossAssignments := JOIN(cfmx, cross_raw,
>
> Given cross_raw is a ,FEW - can we not use a ,LOOKUP here - if we can it
> would be substantively faster
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hpcc-systems/ecl-ml/pull/120/files#r918011
>
:-) we have a test the asserts "Hotness"
Yeah +1 perrito's idea! Looks like the code does not belong there.... Should be some kind of editor helper!!!
Thinking I realize that we could improve all that kind of features like editors behaviors using some kind of helpers and going forward add more of that using plugins too... That should be done in fileOpened signal... :) 
what do you think guys?
I will keep thinking and analizing how to improve it.
test comment on someones diff
Right.  I think we're just talking about the possibility of a clojure wrapper for ehcache... ideally one using the core.cache API.
This is useless IMO. Translate method will never return nil or false.
Looks like `if mail.to` check will be enough. And maybe move this check to the top of `To` section because it doesn't make sense to me to show blank `To` section. What do you think?
needs encodeUriComponent on the tenantId
As discussed I'll add back in the `getContent` function.
I don't know Symfony etiquette here, but shouldn't the authorship creds be on the class?  They seem to be elsehwere.
we should make this the regular `(err, path)` signature and delegate the error handling in
case someone is doing a database lookup etc and that fails
Usually in these situations I try to avoid introducing code unless it's completely necessary. We may never need a handler and are making assumptions about how we might implement such a thing.
this context is not working currently as it tries to access Doctrine from the wrong container
This is the magic toggle
So, why is there a need of a constructor if the class won't ever be instantiated via `new CodeIgniter()` from outside of itself?
Имя можно задать и такое же, опять же. И что значит "неявная переменная"?
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
Добро, поправлю.
@mvmn вас не устраивает слово ТЗ, или что? Или ТЗ для вас - это "Точка Зрения", и их может быть несколько? Программисту дают чёткие указания: вот это - процент, этот метод - возвращает число, этот метод - инициализирует объект. На усмотрение программиста даётся право выбора алгоритма, по которому он будет это делать, право выбора любого количества переменных, если ему это захочется, и так далее. Но пренебрегать входными данными, прописанными в задании - не стоит. Вы можете сколько угодно говорить мне, что "в задании указано 100 символов", я же вам точно так же говорю - в задании указано, что х - процент.
спасибо за разъяснения
Great code review prior to merging by @guille too
Same thing here (80 chars)
@jerboaa do you mean we should have both non-null checking AND validation, or we should get rid of the non-null checking and use validates_presence_of? 
For some of our text attributes, we want to allow empty string but not nil. validates_presence_of does not allow empty string. For other attributes, either way is fine.
I'd just call it "herder" and leave the zoo off of it. Also add a dot at the end of the sentence.
Maybe @mperham can give us a tip.
I'll add the two tests, and I'll change this one to make it clearer.
This one tests that errors that occur at a later position of a complete, but at an earlier time, get forwarded.
This list is hardcoded :( You'll want a way dynamically add/remove people from this, storing that knowledge in the robot brain.
It's common to have extend/include calls as the very first statements in the class body. So these should be moved up. The friendly_id call is fine where it is. 

Ditto for the other models.
This redundancy seems bad.
mats : list of matrices
idx=13 do not mache the 24 above
Yes. Like you suggested, I could update the functions to make `exclude` be `None` by default, but then what's the point of invoking the function rather than just accessing `INSTALLED_APPS` directly? Maybe it should be clear that the `get_` functions should only be used when you actually want to exclude things. I'll change that.
It's Guava. It can't be changed ;)
The (Available Phone Numbers resource)[https://www.twilio.com/docs/api/rest/available-phone-numbers#local-get] expects the `InPostalCode` and `InRegion` list filters, so this is necessary
Could we try to address the code duplication here?
function --> C function
I knew it! There was something which successfully hid amidst the shadows.
8 lines up lands on 'memberMembershipChangeListeners'. WDYM?
Never mind; I can't send you a personal message - no email address with Github?  Anyway, the whole purpose of the 'honorCipherOrder' option is to set the SSL_OP_CIPHER_SERVER_PREFERENCE flag on the TLS server. This allows you to specify the RC4 cipher as a preferred cipher to mitigate BEAST attacks.  IMHO, this is much better than forcing the developer to `require('constants')` and make this change themselves.  I'd like to propose a few solutions:

1.) We stick with the solution above.  We document that setting the `honorCipherOrder` option is identical to setting the SSL_OP_CIPHER_SERVER_PREFERENCE on `secureOptions`.
2.) We change the default cipher list and set SSL_OP_CIPHER_SERVER_PREFERENCE by default.  I don't like this option because `secureOptions` cannot be cleared once they are set.
3.) ... whatever else you can think up.
Звездочка с пробелом.
Creo que el objetivo es eliminar basura, no me parece mal.


2012/11/6 Alpha <notifications@github.com>

> In entregables/site/Docs/Proyecto/Retrospectiva-Proyecto.markdown:
>
> > +
> > +Documentaremos los cambios sobre la propuesta original en un documento que presentaremos a la cátedra un documento, con un resumen de la funcionalidad implementada hasta ahora y el Product Backlog que incluya los aspectos considerados en este documento.
> > +
> > +Debemos resolver varios aspectos de terminación que el director funcional no considera importantes, pero hacen a la calidad del producto (ej. Crear un empleado y no guardarlo genera un empleado vacío). Para esto, prefijaremos tareas técnicas o terminaciones de UI con un espacio importante en los sprints.
> > +
> > +Creemos que puede haber funcionalidad que el director funcional no considera importante para el día a día pero que puede ser valiosa para la cátedra y útil para la empresa (ej. Flujo de postulantes). Con asesoramiento de la cátedra y del director funcional seleccionaremos esa funcionalidad y la definiremos con ayuda de algún interesado que esté involucrado en cuanto a las funciones que son útiles para la empresa.
> > +
> > +## Tareas pendientes
> > +
> > +### Postulantes
> > +
> > +Se investigará si es importante para la empresa perfeccionar el flujo de postulantes, en caso contrario convenimos con la cátedra que se harán los siguientes cambios para darle un pequeño cierre:
> > +
> > +* Convertir postulante en empleado.
> > +* Asociar postulante a búsqueda.
> > +* Permitir marcar postulante como descartado.
>
> No estoy de acuerdo en este punto. Si bien un postulante puede quedar o no
> seleccionado para una búsqueda en particular, no por eso se descarta
> completamente, sino que debería quedar en la bar de datos para futura
> búsquedas en las que se le podría ofrecer un puesto. ¿Está considerado esto
> en esta funcionalidad?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/CommonJobs/CommonJobs/pull/216/files#r2042259>.
>
>
No me desagradaba este disclaimer. ;)
On 18 December 2012 04:31, jerro <notifications@github.com> wrote:

> If I remove it, GCC uses ebx as %1 in some cases. With this code that
> isn't a problem, because xchg %%ebx, %%ebx simply does nothing (and I
> assume that GCC knows it shouldn't put %1 in ebx when compiling with -fPIC).
> I do remember having bugs because GCC used ebx as input or output register,
> though (and that's why I put it in the clobber list) - I must have modified
> the code since. I guess things like that are the reason to have a separate
> non-PIC code path.
>
> Anyway, ebx doesn't need to be in the clobber list here, so I'm removing
> it . Maybe it would be better to have a separate code path for non-PIC
> after all? Should I add it?
>

That's what I suggested originally.


-- 
Iain Buclaw

*(p < e ? p++ : p) = (c & 0x0f) + '0';
please rename this to `doDeleteRecord`
My columns! All that alignment, gone in an instant!
I agree with that point. I changed this part to look over the DBInstance list instead now and find the compute instance info and create the Instance now.
so its based on the name of the Q from the binscript, and in the case of reddwarf-taskmanager, it gets pruned down to just "taskmanager"
Yes, this would create a very small patch. But without a single try{}finally block for the connection handling the chances for creating a new connection leak, a another simple patch are just too huge from my point of view.
As above, this shouldn't be `const`.
@chdemars, no, please do not put all that in examples.
Good catch!

I fixed it in my last push.
PrestaId again???
So the off-screen map will be used to pre-load tiles, but, for the on-screen map to actually benefit from the pre-loading, it won't actually "use" those tiles. In fact, I'm not sure I understand what "map uses a cached tile" means.
you are right.  but this is in the comment.  it will be taken out.
I needed because in previous implemenation we have:

['prop$',{name:'type$', rules:{type$:'string'}}]

Now we need to have something like

['prop$',{name:'type$', rules:{type$:['string','array']}}] to allow
defining an array of possible types.

Bellow we have this:

['prop$',{name:'type$',
rules:{enum$:['string','number','integer','boolean','date','array','object',]}}],

that will check if the string value that defines the expected type is one
of the enum values. But now, in the case when user defines an array with
expected types the enum rule is no longer valid. It expects to match a
string to one of its values. I needed to change this to match each value
from an array to the values from enum.


So if all values defined in the type array are matching the enum thet it
passed.




On Tue, Sep 18, 2012 at 4:00 PM, Richard Rodger <notifications@github.com>wrote:

> In lib/parambulator.js:
>
> >          }
> > -      }
> > +      )
> > +    }
> > +    if ( iserror ){
> > +      return ctxt.util.fail(ctxt,cb)
> >      }
>
> i'm not sure I understand the changes to enum$ - why are they needed?
> also I don't see nay updated tests for these changes
>
> we have to be careful with the semantics here - enum specifies a list of
> valid values, and the point must match one of them
> this seems to be allowing the point to be an array, such that it passes so
> long as all elements are from the enum list?
>
> so maybe foo: {type$:'array',enum$:['a','b']} allows
> ['a'],['a','a'],['a','b'],etc but not, say, ['a','c']
> is this the intention? and where is it needed?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/rjrodger/parambulator/pull/13/files#r1628488>.
>
>



-- 

*malex*
@nicolaasmatthijs We don't support iframe widgets anymore?
trailing comma.
Please drop Q parameter I don't think it is useful
My thoughts on the code are:

 * I wonder which cert should I use to verify users settings.
 * Also I dont know: "Should I reject self signed cert as notification setting?"

If the answer to above is 'Use default cert and reject self-signed one.', then line:21 should be removed.

How do you think of it?
This would need to return the first commit even if skipped in order to keep the return value more consistent.
kittens? wat?
Michael should decide this, but my suggestion would be to use "cache=(size=XXX, name=YYY,  chunk=ZZZ)" and get rid of the existing "cache_size" value.  This means if you want to just set the cache size, you have to do "cache=(size=XXX)", and the more complicated forms are for shared caches.

My reasoning is it avoids programmatic mistakes, simplifies interactions and results in fewer configuration strings.

We already have the notion of configuration strings that take multiple values.  For example, "drop=(June,July)", or even something like "key_format=r,value_format=S" is a group of multiple values.

@michaelcahill