NRWT is not printing out the builder it's uploading JSON files for
https://bugs.webkit.org/show_bug.cgi?id=82834

Reviewed by Ojan Vafai.

Handle log messages of the form log.info("%s", arg) properly ...
I didn't even know you could do that :).

* Scripts/webkitpy/layout_tests/views/metered_stream.py:
(_LogHandler.emit):
* Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
(RegularTest.test_log_args):
(VerboseTest.test_log_args):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Rebaseline more tests from 79568
https://bugs.webkit.org/show_bug.cgi?id=79568

Unreviewed test expectations udpate.

Patch by Philip Rogers <pdr@google.com> on 2012-04-02

* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
* platform/chromium-win/svg/clip-path/clip-path-text-and-shape-expected.txt:
* platform/chromium-win/svg/clip-path/clip-path-with-text-clipped-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Expectations updated needed after 75091
https://bugs.webkit.org/show_bug.cgi?id=81217

Unreviewed Chromium test_expectations update.

Leaving tests as flaky because some builders seem to be flaky,
although it's not clear why.

* platform/chromium-linux-x86/svg/carto.net: Added.
* platform/chromium-linux-x86/svg/carto.net/tabgroup-expected.txt: Added.
* platform/chromium-linux-x86/svg/custom/text-ctm-expected.png: Added.
* platform/chromium-linux-x86/svg/hixie/perf/003-expected.png: Added.
* platform/chromium-linux/svg/carto.net/tabgroup-expected.png:
* platform/chromium-linux/svg/carto.net/tabgroup-expected.txt: Added.
* platform/chromium-linux/svg/carto.net/window-expected.png:
* platform/chromium-linux/svg/custom/js-late-clipPath-and-object-creation-expected.png:
* platform/chromium-linux/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/chromium-linux/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/chromium-linux/svg/custom/use-detach-expected.png:
* platform/chromium-linux/svg/hixie/perf/003-expected.png:
* platform/chromium-linux/svg/hixie/perf/003-expected.txt: Removed.
* platform/chromium-mac-leopard/svg/carto.net/tabgroup-expected.png:
* platform/chromium-mac-leopard/svg/carto.net/window-expected.png:
* platform/chromium-mac-leopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
* platform/chromium-mac-leopard/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/chromium-mac-leopard/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/chromium-mac-leopard/svg/custom/use-detach-expected.png:
* platform/chromium-mac-leopard/svg/hixie/perf/003-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/tabgroup-expected.png:
* platform/chromium-mac-snowleopard/svg/carto.net/window-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/custom/js-late-gradient-and-object-creation-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/custom/js-late-pattern-and-object-creation-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/custom/use-detach-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/hixie/perf/003-expected.png: Removed.
* platform/chromium-mac/svg/carto.net/tabgroup-expected.png: Added.
* platform/chromium-mac/svg/carto.net/window-expected.png: Added.
* platform/chromium-mac/svg/custom/js-late-clipPath-and-object-creation-expected.png: Added.
* platform/chromium-mac/svg/custom/js-late-gradient-and-object-creation-expected.png: Added.
* platform/chromium-mac/svg/custom/js-late-pattern-and-object-creation-expected.png: Added.
* platform/chromium-mac/svg/custom/use-detach-expected.png: Added.
* platform/chromium-mac/svg/hixie/perf/003-expected.png: Added.
* platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/chromium-win-vista/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/chromium-win-xp/svg/carto.net: Removed.
* platform/chromium-win/svg/carto.net/tabgroup-expected.png:
* platform/chromium-win/svg/carto.net/tabgroup-expected.txt:
* platform/chromium-win/svg/carto.net/window-expected.png:
* platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.png:
* platform/chromium-win/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
* platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/chromium-win/svg/custom/js-late-gradient-and-object-creation-expected.txt:
* platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt:
* platform/chromium-win/svg/custom/text-ctm-expected.png:
* platform/chromium-win/svg/custom/text-ctm-expected.txt:
* platform/chromium-win/svg/custom/use-detach-expected.png:
* platform/chromium-win/svg/custom/use-detach-expected.txt:
* platform/chromium-win/svg/hixie/perf/003-expected.png:
* platform/chromium-win/svg/hixie/perf/003-expected.txt:
* platform/chromium/test_expectations.txt:
* platform/mac-snowleopard/svg/custom/js-late-clipPath-and-object-creation-expected.png: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Activation tear-off neglects to copy the callee and scope chain, leading to crashes if we
try to create an arguments object from the activation
https://bugs.webkit.org/show_bug.cgi?id=82947
<rdar://problem/11058598>

Reviewed by Gavin Barraclough.
        
We now copy the entire call frame header just to be sure. This is mostly perf-netural,
except for a 3.7% slow-down in V8/earley.

* runtime/JSActivation.cpp:
(JSC::JSActivation::visitChildren):
* runtime/JSActivation.h:
(JSC::JSActivation::tearOff):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-04-02  Stephanie Lewis  <slewis@apple.com>

        run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
        https://bugs.webkit.org/show_bug.cgi?id=82552

        Reviewed by Dirk Pranke.

        Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.

        * Scripts/webkitpy/layout_tests/port/webkit.py:
        (WebKitDriver._start):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Simplify main resource load start/end in FrameLoader
and DocumentLoader.
https://bugs.webkit.org/show_bug.cgi?id=82935

1. Have FrameLoader call prepareForLoadStart() on itself directly, rather
    than through DocumentLoader.
2. Remove DocumentLoader::m_primaryLoadComplete, since this is basically equivalent
    to m_mainResourceLoader.
3. Rename setPrimaryLoadComplete() to clearMainResourceLoader(), and only call it at
    the end of the main resource load.
4. Move clearing DocumentLoader::m_mainResourceError into startLoadingMainResource(),
    which leaves DocumentLoader::prepareForLoadStart() empty.

Reviewed by Adam Barth.

No new tests, refactor only.

* WebCore.exp.in:
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore):
(WebCore::DocumentLoader::mainReceivedError):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::startLoadingMainResource):
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::continueLoadAfterWillSubmitForm):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
* loader/FrameLoader.h: prepareForLoadStart() is now called directly,
    so make it private.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Call NPP_SetValue with WKNVCALayerRenderServerPort when a WKView is moved from a buffered to an unbuffered window, or vice versa
https://bugs.webkit.org/show_bug.cgi?id=82951
<rdar://problem/10589308>

Reviewed by Sam Weinig.

* PluginProcess/mac/PluginControllerProxyMac.mm:
(WebKit::PluginControllerProxy::setLayerHostingMode):
Call Plugin::setLayerHostingMode).

* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:
Move WKNVCALayerRenderServerPort to the header file.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::NetscapePlugin):
Initialize m_layerHostingMode.

(WebKit::NetscapePlugin::initialize):
Set m_layerHostingMode from the parameters struct.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::compositingRenderServerPort):
Return MACH_PORT_NULL when hosted in the window server.

(WebKit::NetscapePlugin::platformPostInitialize):
Move the code that gets the layer out into a separate function, updatePluginLayer.

(WebKit::NetscapePlugin::setLayerHostingMode):
Let the plug-in know that the layer hosting mode changed and update the plug-in layer if
setting the new compositing port was successful.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
garden-o-matic should let you listen to audio failures
https://bugs.webkit.org/show_bug.cgi?id=82953

Reviewed by Chris Rogers.

Now that we've actually got an audio failure on the bots, we can clean
up the last stray bugs.  This patch doesn't have any tests because I'm
lame.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
(.):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
We should use CSSPropertyID rather than integers when manipulating CSS property ids.
https://bugs.webkit.org/show_bug.cgi?id=82941

Reviewed by Andreas Kling.

CSSPropertyID enum holds all the CSS property ids but many parts of WebKit treat the ids
as integers. While it's not incorrect it is nicer to use the enum as a parameter of
functions manipulating property ids, as we ensure that the value passed will be an
existing value. It will also feel more correct after this patch that CSSProperty::id()
return a value of the enum rather than an integer. As this modification is quite big this
is the first part only so it will be easier to review.

Source/WebCore:

No new tests : There should be no behavior change in this patch.

* css/CSSParser.cpp:
(WebCore::cssPropertyID):
* css/CSSParser.h:
(WebCore):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::cssText):
* css/CSSProperty.h:
(WebCore::CSSProperty::id):
(WebCore::CSSProperty::shorthandID):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::item):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyValue):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):
(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):
(WebCore::PropertySetCSSStyleDeclaration::isPropertyImplicit):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getPropertyValue):
(WebCore::StylePropertySet::appendFontLonghandValueIfExplicit):
(WebCore::StylePropertySet::propertyIsImportant):
(WebCore::StylePropertySet::getPropertyShorthand):
(WebCore::StylePropertySet::isPropertyImplicit):
(WebCore::StylePropertySet::asText):
* css/StylePropertySet.h:
(StylePropertySet):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement):
(WebCore::removePropertiesInStyle):
(WebCore::setTextDecorationProperty):
(WebCore::diffTextDecorations):
* editing/Editor.cpp:
(WebCore::Editor::selectionStartCSSPropertyValue):
* editing/Editor.h:
(Editor):
* editing/EditorCommand.cpp:
(WebCore::valueStyle):

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::styleProperty): Adapt to the API change and also remove an unecessary name->id
conversion.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Flaky SVG tests on MacOS 10.6
https://bugs.webkit.org/show_bug.cgi?id=82954

Unreviewed Chromium test_expectations update

Removign one empty expectations file that somehow made it in
previously. And marking several tests as flaky on Snow Leopard.

* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Removed.
* platform/chromium/test_expectations.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Having a drop handler prevents navigation on drop even if event is not cancelled
https://bugs.webkit.org/show_bug.cgi?id=79172

Reviewed by Ryosuke Niwa.

Source/WebCore:

Only early return if the drop handler prevents the default action.

Test: fast/events/drop-handler-should-not-stop-navigate.html

* page/DragController.cpp:
(WebCore::DragController::performDrag):

LayoutTests:

* fast/events/drag-dataTransferItemList.html: Fix drop handler to prevent default.
* fast/events/drop-handler-should-not-stop-navigate-expected.txt: Added.
* fast/events/drop-handler-should-not-stop-navigate.html: Added.
* http/tests/security/clipboard/clipboard-file-access.html: Change dragover to drop handler
    to prevent bubbled events from causing navigation.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
garden-o-matic isn't able to rebaseline audio failures
https://bugs.webkit.org/show_bug.cgi?id=82957

Reviewed by Chris Rogers.

This patch just adds "wav" to the list of test suffixes and updates the
unit tests to show that we're rebaselining audio tests results now too.

* Scripts/webkitpy/tool/commands/rebaseline.py:
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_updates_expectations_file):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Removing ahem.ttf that was checked in with wrong-case name.

Reviewed by Adam Barth.

This file is not referenced yet.  The correctly named one will be added with
the next ietestcenter css test import.

* ietestcenter/css3/support/ahem.ttf: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry] Adapt WebPagePrivate::webContext to the API change of r109570
https://bugs.webkit.org/show_bug.cgi?id=82945

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-04-02
Reviewed by Rob Buis.

RIM PR: 147163
Adapt WebPagePrivate::webContext to the API change of the security
cherry-pick of r109570 and r112023.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r112948.
http://trac.webkit.org/changeset/112948
https://bugs.webkit.org/show_bug.cgi?id=82961

Someone else already checked in a similar change (Requested by
sundiamonde on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-04-02

* Scripts/webkitpy/layout_tests/port/webkit.py:
(WebKitDriver._start):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Skip new test webarchive/css-page-rule-crash.html for WK2.
WK2 tests can't dump as WebArchives yet.

No review.

* platform/wk2/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix layout test failure with window-properties-expected.txt
https://bugs.webkit.org/show_bug.cgi?id=82969

Unreviewed build fix.

* platform/mac/fast/dom/Window/window-properties-expected.txt:

Fix expectations caused by addition of Oscillator and WaveTable:
http://trac.webkit.org/changeset/112938

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Skipping a bunch of flakey tests on Lion.

* platform/mac/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
check-webkit-style errors when removing .png files
https://bugs.webkit.org/show_bug.cgi?id=82933

Reviewed by David Levin.

* Scripts/webkitpy/style/patchreader.py:
(PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).
* Scripts/webkitpy/style/patchreader_unittest.py:
(test_check_patch_with_png_deletion):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
fast/events/drop-handler-should-not-stop-navigate.html fails on Lion
after http://trac.webkit.org/changeset/112954

* platform/mac/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112964 268f45cc-cd09-0410-ab3c-d52691b4dbfc