labofsahil/github-event-dataset-2012 huggingface dataset:
Shouldn't there be a check for wizard first?

`elif "wizard" in context and "form" in context["wizard"]`
maybe just combine the if to be one check?

```javascript
function isGitHubSpecialCase(anchor) {
  location.href.indexOf("github.com") >= 0 && //inside github
    anchor.classList.contains("minibutton") || //ignoring buttong
    anchor.href.indexOf("#readme") > 0 || //??
    anchor.hasAttribute("highlight") || // ??
   position == "absolute"  //ignoring absolute placed elements since it will probably look bad
}
if (!isGitHubSpecialCase(anchor)) {
 //add to anchor list
}
```
Looking at the commits tab, it seems that everything is already here.  What's up with that "\ No newline at end of file" in the diffs?  Is that something i need to fix?
Ты не должен коммитить настройки ide

Добавь папку nbproject в gitignore
Im not a fan of adding implementation code targeting build scripts im afraid :/
This is same as:
~~~clojure
(empty? (filter (complement pred) awards))
~~~
This looks like garbage.
no need to create ``$image``
why not auto property ? {get;set;}
"Autores anteriores" by itself seems the most appropriate.
Can we make this method private?
Tuple!
`user_channel`
We are not having spaces around `=` elsewhere, do we?
why did you remove these lines ^ ? anything to do with keystoning?
It *could* safely be used outside the class, so I think it may be better to change it to be more friendly (i.e. rename it, as I believe we discussed in the API Proposal wiki), rather than making it private. ?
Entire Factory should be moved to DoctrineORMModule
Simplify:

You may also need to know if there is an authenticated user within your other controllers or in views. Here's examples of a controller plugin and a view helper you may use.
I will get that updated right now
Where'd this attribute go? We relied on it in the default recipe...
agreed, changed all of these to just check nil explicitly
Break the new folder name generation into a separate function. Then whenever we run into a book with etext in the title we can rerun that function to know where it now lives. We could modify the rdf or the pickle but those aren't long term solutions. Once I setup the local db we can store the original filepath and the generated one if we want.
Spelling ^_^
Format like:

```
new_user = auth_models.User(
    username=self.cleaned_data['username'],
    first_name=self.cleaned_data['first_name'],
    last_name=self.cleaned_data['last_name'],
    email=self.cleaned_data['email'],
)
```
More and more of a reason to hustle on #67, amirite
And that makes me think whether atmospheric_mtf() shouldn't just be mtf() for consistency.
There is an HTML element called `iframe`, this made me think you were using it, but you aren't. Probably best to choose a different name. Maybe `content`?
I don't understand the need for this if ... else statement.
Other than the line that sets `group_id`, don't the statements in the if clause do the same thing as the statements in the else clause?  What would be lost by merging the two clauses?
django template filters -- now I know about these.  Fancy.
I think we have a 1-1 correlation between user stories and features, where each feature has multiple scenarios which tests one detail each.
I like ImmutableSet.copyOf(excludes), rather that these two lines.
But no strong feelings :-)
Alright, that's fine. I prefer to use `unless` over `if not` because it reads better. It's just that little bit more intuitive for me.
native for in without hasOwnProperty is antipattern
Shouldn't it return the ProfilePage() object here?
há um `x` perdido
options['success'] = ...
what OS's have you tested this on? I'm pretty sure I tried to do this on Debian and it blew up - because we're not also specifying the version of puppet-common, which leads to a conflict...
We make special layers for frames that only have a background image.  Those get scaled on the GPU.  In this case it doesn't really matter, since we should only draw the screen once.  It might even be more power efficient to not scale on the GPU every time we recomposite.
Put this in style/homescreen.css.

\o/
I guess this is right... I prefer to push the bounds when appending strings.

> There MUST NOT be a hard limit on line length; the soft limit MUST be 120 characters; lines SHOULD be 80 characters or less.

https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#23-lines
Check again, asshat.  If(ishuman(occupant)) is a complete statement.  The rest of that line does nothing.
If we decided to keep this code, it should probably be
```ruby
on :message, "hello #{c.nick}" do |m|
  m.reply "Hello, #{m.user.nick}"
end
```
Just to keep the channel a little less flooded.
Actually it doesnt appear this method is used, so I would suggest deleting it.
Let's get alarms into a library.
added two new tests and renamed sequence-create to sequence-both since it happens to be the combination of seq-create and seq-resolve
Можно было бы просто StringFormatterDoubleExtension.class.getName()
Stack в однопоточном приложении не используем.
It would be easy to test this: install OLSRMeshTether, and click the Start button.  I have it working on a few HTC devices, doesn't seem to work on Samsung yet. I haven't tested too many others yet.
Sorry, fixed on master.
Imports should usually be on separate lines http://www.python.org/dev/peps/pep-0008/#imports
self = <tests.mobile.test_home_page.TestHomepage instance at 0x0258A508>
mozwebqa = <pytest_mozwebqa.pytest_mozwebqa.TestSetup instance at 0x0366C170>

    @pytest.mark.nondestructive
    def test_that_verifies_categories_section(self, mozwebqa):
    
        home_page = Home(mozwebqa)
        home_page.go_to_homepage()
    
        #Assert.true(home_page.is_the_current_page)
    
        Assert.true(home_page.is_category_section_visible)
>       Assert.equal(len(home_page.categories.items), 6)
E       AttributeError: 'list' object has no attribute 'items'

File "F:\workspace\Marketplace\marketplace-tests\tests\mobile\test_home_page.py", line 36
AttributeError
------------------------------- pytest-mozwebqa --------------------------------
Failing URL: https://marketplace-dev.allizom.org/
Yep. I'll remove some.
Could you write this simpler by using `List.groupBy`?
This `note` needs a `:` 
```
.. note::

The higher...
```
la pureté de code, ce n'est pas rien !
I considered that, but to avoid setters in the public API you'd need to move all of Config into somewhere internal, and reexport it from here. I thought that was a bit of a big hammer to take to someone elses code :)
nit: 2 char indentation please.
This is incorrect, content type is not "application/x-www-form-urlencoded", maybe setContent() should require a second parameter that will indicate what type of content is being set.
This is only ever used in test code, why is this method in a class in src/main/java?
Wow. That's a valuable lesson for me. Thanks!
Also a dead line of code.. but really, since it's all #if 0'ed out, just yank it all.  (the amount of #if 0'ed code in this file is getting kinda silly.
Add comment saying that v8 is used in BlackBerry
fix order. I hope this is just jetlag :)
This file is no longer needed once you merge :) Please remove it.
what benefits do we gain by making this static? It's private, so it wouldn't run outside of the class anyway, unless there an inheritance gain??
Hm, why should it? It just returns the client object, developer have to decide what to check.
Like: 
if (! empty(OneAuth\Auth\Core::client()->user_id)) ...
Why is this under "Port" ?
That is exactly what was happening (the last digit was being rounded, and the test was failing). So I guess it makes sense to leave it rounded on the last. I'll change.
clearer might be to set prev to right as soon as the match condition has been tested.  (Same for roxie code)
Most architectures are 64bit now, with the exception of ARM. But by the time we manage to make it run on ARM, it'll probably be 64-bit anyway... ;)
Agreed.  This is "can't happen" code (given that the sscanfs will ensure we're less than PATH_MAX), so I think bailing is acceptable.
Добавление OPENSTACK_HOST в конец файла приведет к тому, что строка 60 OPENSTACK_KEYSTONE_URL = "http://%s:5000/v2.0" % OPENSTACK_HOST будет содержать не верное значение.
Ok pour moi tant qu'on le change partout.

Greg
Le 2012 8 29 08:21, "Thomas Botton" <notifications@github.com> a écrit :

> In book/controller.rst:
>
> > @@ -400,7 +400,7 @@ elle-même.
> >
> >  .. tip::
> >
> > -    Etendre la classe de base est *optionnel* dans Symfony; elle contient
> > +    Étendre la classe de base est *optionnel* dans Symfony; elle contient
>
> La consistance est en effet de mise.
> Si ça ne dérange personne, on va avec les conseils de l'académie (cf.
> http://fr.wikipedia.org/wiki/Usage_des_majuscules_en_fran%C3%A7ais#Accentuation_des_majuscules_et_des_capitales
> ).
>
> OK ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/symfony-fr/symfony-docs-fr/pull/130/files#r1482604>.
>
>
Ок тэгвэл удирдлагын урсгал гэдгийг нөхцөл гэж явъя.
Places I use asserts in, really are not supposed to ever fail. If they do, then something really really went wrong, so displaying a regular error to users in these cases sends the right message "this thing just broke entirely". And the bug report with the assertion info will also be most useful.
Since you have renamed apache_modules_ok to apache_modules_toUpdate, this should be changed too.
I thought about that too, but decided for myself that it would be better to have one entry in the services file for each command. I like this more, because I can now see for each process one status line in the overview and don't just get a "at least one process is down".
What's the reason for doing this with addEventListener rather than .delegate() ?
QByteArray has a toString method, so either should be fine
It's actually stored as inverse, so it's really confusing:

    [{"@name":"compute","@is_template":false,"@uuid":"WAEGogiMQ3bry52sXQhmJ","@tag_matchers":[{"@is_template":false,"@uuid":"WMTBMMTrUO1tVbFPM8reR","@value":"00:25:B5:00:05:2F","@uri":"http://192.168.25.254:8026/razor/api/tag/WAEGogiMQ3bry52sXQhmJ/matcher/WMTBMMTrUO1tVbFPM8reR","@noun":"tag/WAEGogiMQ3bry52sXQhmJ/matcher","@inverse":"false","@version":0,"@compare":"equal","@key":"macaddress_eth0","@classname":"ProjectRazor::Tagging::TagMatcher"}]

In this case I can change it to:

    :inverse       => m['inverse'] || m['invert'],
Well I am a liar and a scoundrel
Does it have to be 192.0.2.12??
In that case, you could add a regression test using one of the images in `skimage.data` (i.e. run the filter on the image, copy the points, and then use those points to test). It's not the ideal test, but at least we'll know if the behavior changes.
Do you have any sense how long this takes with our current data volume? I'm wondering if re-building the index during peak traffic will cause any issues?
I believe for that one there is a race condition. It fails sometimes if you
keep rerunning the test.

On Wed, Feb 29, 2012 at 01:06, Simon Kornblith <
reply@reply.github.com
> wrote:

> > @@ -125,6 +126,7 @@ var testCases = [
> >       {
> >               "type": "web",
> >               "url": "
> http://www.washingtonmonthly.com/magazine/mayjune_2011/features/the_information_sage029137.php?page=1
> ",
> > +             "defer": true,
>
> Are you sure this needs to be deferred? It seems to be working fine
> according to the translator tester.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/zotero/translators/pull/137/files#r500232
>
@kring perhaps your fragment shader is more optimized now?  So it could be a win on systems with weak GPUs.  Leave it if you want or remove it.  Either way, @bagnell and I will look at sorting (by shader, by depth, etc.) in the DDR in the future, and can revisit it then.
This should compare to an epsilon value like `CesiumMath.EPSILON20`. I was able to get `NaN`s with

`Ellipsoid.WGS84.cartesianToCartographic(new Cartesian3(1.0, 1.0, 1.0).multiplyByScalar(1e-150))`
This really isn't that important, but I agree that style choices at the function level should be left to the coder for the most part, so shouldn't someone modifying an existing function respect the style choice that was already made in that function?  This change wasn't even related to the color changes.

Consider the readability of this code:
<pre>
var p0 = new Point({
   show : true,
   width : 5,
   color : RED
});

var p1 = new Point({
   color : RED,
   width : 5,
   show : true
});

var p2 = new Point({
   width : 5,
   show : true,
   color : RED
});
</pre>

with the readability of this:

<pre>
var p0 = new Point({
   show : true,
   width : 5,
   color : RED
});

var p1 = new Point({
   show : true,
   width : 5,
   color : RED
});

var p2 = new Point({
   show : true,
   width : 5,
   color : RED
});
</pre>

We must agree that the later is more readable.  More generally, if we strive to keep properties for a given type ordered in a similar fashion all over the code, it is more readable.  This is the style choice I made throughout (well for the most part I hope) the primitives.  I have no interest in imposing it across Cesium as a whole.  I hate rules, and want everyone else to hate them too.  But in this case since I already had it like that, why not keep it?

Either way, let me know when to merge this request; we have bigger things to do than belabor this.

P.S. A style guidelines as part of the coding standards would be OK.  I actually want to rename the coding standards to "best practices" so they don't sound like rules.  Everyone wants to follow best practices anyway, right?
Should be yyyy-MM-ddT**HH**:mm:ss... (capital HH for 0-23 style hours)
This code must be outside the check for validating. With KeyManager null you are essentially creating a non Validating client with custom trust managers.

Also on exception in creating the client, must terminate connection.
One small issue left: the i declaration should be moved out of the for loop (declaring vars inside for loops can be dangerous since they aren't actually scoped to the for loop like you would expect).

Once this is fixed. I'll be ready to sign off on the CR (sorry I missed this earlier).
Documentation changes will be required but the exact changes will depend on what changes come from the above comments.
Removed them, I should have realised this. :)

Tested the use of a dummy toolchain by installing CPLEX (binary installer), worked fine:

```
== Results of the build can be found in the log file /user/scratch/gent/vsc400/vsc40023/easybuild_REGTEST/software/CPLEX/12.4/easybuild/easybuild-CPLEX-12.4-20121104.161113.log
== 2012-11-04 16:14:19,879 main.main INFO Build succeeded for 1 out of 1
```

So, you can push the magic green button to merge this pull request into your branch, so all this stuff ends up in the pull request for develop.
не очень приятный/понятный API. три придирки, которые все пересекаются на 90%:

* глобальный стейт
* симметричные операции с нессиметричными аргументами
* почему-то закрытие диалога связано с загрузкой файла, хотя второе не следует из первого, а первое не будет следовать из второго, когда у нас будет мультиаплод
безусловно
Well I was thinking if there was ever an ambiguous case like this

```D
enum E
{
    x = 1,
    y = 2,
    z = 1
}

void main()
{
    E e = to!E(1);
}
```

Is `e` E.x or E.z?

I guess the problem is that an enum in D isn't necessarily used to keep a set of *unique* values, but sometimes also used to keep a set of related values that may be duplicate. If the latter should never be used then maybe such an enum definition shouldn't even compile?
s/RPackage/RExtension/
This should be WFK, and it needs submitting to aerogears quickstarts...
Doc, please. Does this return the same value if called multiple times within the same thread? Do we need to clean up in some way?
You should do this before you do all of the post-insert work.
This is one of the few times I'll suggest using an `else`. A mess of `continue` and `break` and `return` is worse than a little structured programming.
any objection to using include apache instead of this statement?
This will break puppet 2.6 and some early puppet 2.7 versions. Please remove the trailing comma on the last entry.
You accidentally added `test/backbone-relational.js`, it was supposed to be a symlink to the actual file one level up.
having two different checks in one assert is not good practice, the assert should check for one condition only. Although there could be some scenarios where it's must to do that, so make sure from this.
In general, we should not track fixed errors in source code.
Your code does not merge mirrors retrieved by the metalink
Could you move this to the ``serialize`` method? Then, we avoid instantiating visitors that are not needed.
The problem in mopa's code is that they suppose the form_div_layout. element is the first one (which is in reality terms_form_type from the cmf), so the logic is broken and mopa's template is not applied as expected.

Thanks for the merge, anyway I've made a pull request here to fix the issue : https://github.com/phiamo/MopaBootstrapBundle/pull/356
Horde, PEAR, Solar, Symfony, Zend, Lithium, et al. *all* note 80 characters as the expected line length (in some cases it's a soft limit, but it's still mentioned).  Per comments elsewhere, screen size and resolution are not the driving factor; human cognitive limitations are.
Tabs are only useful in (office-)documents, where the character width is not equal. For code set your IDE to use a monowidth-font. When you set your IDE to use spaces _as_ tabs, there is even no difference while coding (note, that most IDEs support `[shift]-[tab]` for a kind of "tab-backspace"). Additional mixing both in one file is horrible. Have a look at my comment above about "`\r\n` versus `\n`".
blank line before the final """" on a multiline docstring. Also, the docstring should begin with a single-line self-contained summary. An exercise in conciseness!
I am not even looking at it that way. All I care is to have a single place to maintain a constant value instead of spelling it out literally  so I that's fine
Thanks Artem, We can actually remove this element as the transactions will be handled by the poller in case of an inbound adapter
Then it needs to be added to the Wiki (breaking changes)
Is there any reason to 'lock' and 'unlock' here?
Because it does in the invoked `this.add(object);`

However I don't like this implementation: just look into `CopyOnWriteArrayList#add` & `CopyOnWriteArrayList#addAll`
The last one doesn't invoke the first.
I was satisfied by the uncommented tests that the assertions were added and behaving correctly. This test file was taken from the Shoulda source and the commented out tests depend on Capybara, which isn't a dependency here. The tests could either be rewritten to use the standard Rails testing infrastructure or this project could add the Capybara dependency.

If you choose to add a dependency on [minitest-rails-capybara](https://github.com/blowmage/minitest-rails-capybara), this test file will have to be rewritten as a `ActionDispatch::IntegrationTest` test instead of a controller test.
hmm
just do not think that we should remove this raise for now 
we can remove it when we will "upgrade" sys_firewall LWRP to use more complicated rules
because for now it put "all" directly in ipatables rule
-A FWR <% if @ip_addr -%>--source <%= @ip_addr %> <% end -%>
--protocol <%= @protocol %> --dport <%= @port %> -j ACCEPT
if we change "all" to "both" we will have to create two rules
I take your point, but I think we're starting to add complexity that isn't of value to the goal of getting a basic install of Foreman up and running. Once a new user has done his evaluation/testing and wants to put Foreman into production, they'll have a better idea of what they want from the modules that installed it.

I think I'd be happy with this so long as we add a comment to params.pp that makes the array requirement clear. @skottler what do you think?
Use jQuery to construct tags, don't construct HTML by adding strings together (hint: do you escape strings?). jQuery does. See [examples](https://github.com/wlanslovenija/PiplMesh/blob/master/piplmesh/frontend/static/piplmesh/js/home.js) here.
It's not about errors, it's optimization. Suppose, I plot two graphs on the website at the same time (well not actually at the same time but close). The first starts this function, finds that there is no local data and requests it from the server. Before the JSON request fires, the second graph starts this function and finds there is no local data, so he also fires a JSON. The first request starts, the second waits for it to finish. But the first request polls the data that the second request could use. So, if I wouldn't do it like this, two same sets of data would be transferred from the server...


On 29. 09. 12, at 12:44, Mitar <notifications@github.com> wrote:

> In tests/test_project/test_app/static/test_app/js/datastream.js:
> 
> > +            'lines': {
> > +                'lineWidth': 1
> > +            }
> > +        }
> > +    };
> > +
> > +    var flot_defaults = {
> > +        'url': datastream_location,
> > +        'datastream': null,
> > +        'from': null,
> > +        'to': null
> > +    };
> > +
> > +    function getMetricData(metric_id, granularity, from, to, callback) {
> > +        if (query_in_progress) {
> > +            setTimeout(function () { getMetricData(metric_id, granularity, from, to, callback); }, 40);
> This ... is very error prone. :-)
> 
> Maybe use jQuery queues?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
я его перенес еще дальше, так, мне кажется, звучит лучше
According to: http://api.drupal.org/api/drupal/includes!database.inc/function/update_sql/6 -  %-substitution parameters are not supported.
@marystufflebeam pointed out that these are mixes of tabs/spaces even within the same line. Bleh.

Let's leave this as-is and do whitespace changes later.  I was hoping to not do the tabs/4spaces discussion, but looks like we'll have some whitespace pulls soon.
Используем везде (единообразие; consistency) виртуальные свойства, а не геттеры и сеттеры.
does this really have to be static?
Thank you, I am still not used to committing with web interface
I dig that it is much better name. I will change that immediately.
Why this empty class? It is not even used... as far as I can see...
It's probably missing logic after this for loop for when the last line is incomplete, the td should be colspan="2" and the tr should be closed
You can drop this, since it's already in `install_requires` in setup.py
fixed documentation.  I just used the regular subscription verification email on the api side, but I'll create a new non-implemented email method and use that instead.
The default getMessage already exhibits a blocking behaviour, if you want to define a separate blocking call, please modify the getMessage() method so that it does not block.
Shouldn't this field be defined in the class? With type casting etc.
Makes sens
This is a good point but that break the simplicity of constructor parameter == potential direct assignment for grid search. I think this is a case of practicality beats purity. WDYT?
Same, not necessarily album.
This should be a relative import, as should the one above it.
as far as I remember, your pull request was pretty complete.:
https://github.com/anthonydahanne/maven-android-plugin/commits/master/
now, I just configured my projects a bit differently than yours, but not that much... 
I' m gonna blog about it very soon + the mailing list android maven plugin to give some insight.
you pull request rocks man ! thanks again for bringing it in !
Spoke with Zac.  Right now, this test will fail even with the lengthier timeout.  We suspect an indexing issue and are chasing that up.
Whoops, copy paste error. Fixed.
As a `@require`d protocol, there is no such thing as a "default behavior".
Sorry, the comment was more like "you need to add some short notice on why we don't need any code there"
Using Delegate would cause a confusion since it's not a delegate. Maybe TiUIScrollViewProtocol ?
Might be worth adding a comment to this method too explaining why we back things up.

It can be the case that the user-pref is set to backup to iCloud, but iCloud is turned off for the device. Not sure if the backups are then necessary in this case. It's worth documenting though.
Please fix indentation (in other test cases too).
{  needs to go on new line
Fix applied.
Maybe put these inside `$(D ...)` too.