labofsahil/github-event-dataset-2012 huggingface dataset:
This worries me, since it loses anything else that might have been on _popcornOptions.  Why not just explicitly set rAF on that options object to false?
Drop this (see below)
any reason why you chose not to use a class for this one?
Unless @ednapiranha and the rest on the project are adamant about 80 character line lengths, I'd say this is more readable as one big string on a longer line.
modified increment of iterator
not as ugly as your sister
I can't find a way how. probably searching for the wrong thing....
I made an attempt, but it was a lot of work and didn't really simplify _dumptype. The main problem is that it's not just a tree of types. You also need type names and type constructor info. You could return a tree of string representations, but I'm not sure of the purpose. It doesn't simplify _dumptype, and increases the complexity of idump.
Do we have "Red Hat trademarks" somewhere in this code? If not, then you can remove it.
Is that '+' a typo or some sort of special Ruby way of combining two do-end blocks?
I actually first began to build the query as suggested to let RAILS do the work; however, it was not generating the query that I needed.  Since I saw that we've specified inner join elsewhere in the code, I used the same approach.
Since, given the previous language, subscriptions are attached to systems, should this read more like `There are no subscriptions currently attached to the system?`
There are 2 accepted formats for MULTIPOINT:

```
MULTIPOINT ((10 40), (40 30), (20 20), (30 10))	
MULTIPOINT (10 40, 40 30, 20 20, 30 10)
```
Let's go with the second format since it requires fewer parenthesis characters. It's a minor efficiency gain, but for 450 million points it saves about 430 MB.
I'd actually assume this would destroy the other streams
While testing this in an app that uses MessagePack, I noticed that body in this line is always nil. The conversion in `bodyAsString` from NSData to NSString does not work for binary data because the encoding used during conversion is the hardcoded `NSUTF8StringEncoding` because the HTTP response does not contain character encoding information since it's binary. Now I thought of a couple of workarounds:

- When body is less than 1-3 bytes or chars long, it is most probably an empty response. With this assumption, no string conversion is needed.
- Have the parser define a default encoding that is used for the conversion to string. This approach feels kind of backwards to me.
- Tell the user that he has to explicitly `setDefaultHTTPEncoding` on the client. Again, this doesn't feel right.

What do you think?
https://bugzilla.mozilla.org/show_bug.cgi?id=757496 will introduce a mozKeyboard.onfocuschange handler, has proposed in the virtual keyboard proposal on dev-webapi. This will make it possible for a keyboard to listen more than showime/hideime. Bug 757496 is specific for <select> elements, and I will use bug 754083 for regular inputs.
Consider making local var for kwargs['request'], it gets used a bunch
Maybe a nice big comment at the top of this explaining why this do-nothing file exists?  Something like:

/*
This is a placholder file that should be replaced by the output of bitcoind -saveblockcheckpointfileto
It will be filled iwth the least-significant 32 bits of block hashes in the best block chain. By checkpointing
the early, difficulty-1 blocks several potential denial-of-service attacks are prevented.
*/
Well, the other alternative is to always pass in a valid unit value. 

You may like it, but there is no real need to special-case 0, no need to use ?:. You only need one function signature for this, without special magic values which are bound to bite you some day.

If you look at how I've done it in the other files it's like this:

    void MyClass::setModel(model) 
    {
        if(model)
        {
            /* Set initial value */
            fooChanged(model->getFoo()); 
            /* Track changes */
            connect(model, SIGNAL(fooChanged(int)), self, SLOT(fooChanged(int)))
        }
    }
    
    void MyClass::fooChanged(value)
    {
        // Do something with value
    }

So everywhere you call updateDisplayUnit() use updateDisplayUnit(model->getOptionsModel->getDisplayUnit()). Either that or the previous suggestion,

    void MyClass::setModel(model) 
    {
        if(model)
        {
            /* Set initial value */
            blaChanged(); 
            /* Track changes */
            connect(model, SIGNAL(fooChanged(int)), self, SLOT(fooChanged()))
        }
    }
    
    void MyClass::fooChanged()
    {
        value = model->getFoo();
        // Do something with value
    }

which IMO in this particular case is most sensible as we're always taking the value from the options model anyway. Both are valid solutions, but don't try to do it both at once.
why print the time?
IMHO this could be an InitWarning() and the message should be a little more user friendly and translatable.
URL should not be uppercased but lowercased, see the codingstandards (abbreviations).
Yes, you can check it by the following snippets.

```python
In [1]:
import pylab
from io import BytesIO
from IPython.core.display import display_png

fig = pylab.figure()
pylab.plot([1,2,3])


In [2]:
fig.set_facecolor("gray")
bytes_io = BytesIO()
fig.canvas.print_figure(bytes_io, format='png', bbox_inches='tight')
data = bytes_io.getvalue()
display_png(data, raw=True)


In [3]:
fig.set_facecolor("gray")
fc = fig.get_facecolor()
ec = fig.get_edgecolor()
bytes_io = BytesIO()
fig.canvas.print_figure(bytes_io, format='png', bbox_inches='tight',
                        facecolor=fc, edgecolor=ec)
data = bytes_io.getvalue()
display_png(data, raw=True)
```

In the output of the cell 2, figure face is white.  In the cell 3, it's gray because it is explicitly set to it.
VI Java API library has BSD license.

VI Java API is built on top of vSphere Web Services SDK 5.0: for java they provide java stubs (jax-ws or axis2) starting from the wsdl.
FYI it's more consistent with the rest of the Laravel code to use "or" instead of "||"
In the spirit of testing all the guarantees in the documentation, there should probably be tests for these cases:

* `repository` is NULL (thought I'm not sure how this would be tested)
* Asking to hash as `GIT_OBJ_ANY` should give an error. Or should it? I don't see anything in `git_odb__hashfd` and friends that would do this either.
* `as_path` is an empty string
Love the tests:)
Probably easier to do a:

```
if not translation:
    continue
```

then go on with these two cases without testing translation multiple times.
I think these need to have `required=False`. I can't add a leader to a locale without also filling in reviewers and editors.
Definitely icky! It is totally a hack and abusing the KB to be more like a localizable CMS. I am hoping it is simple enough to just work, but if there are issues with the document getting screwed up I was thinking of adding some UI sugar to enforce the structure.
nitpick, but this is something carl always reminded me of: 2 lines between functions, 3 between classes.
this is one of the cases where I really dislike web.py.  Not only does it fail to use new style classes, but it dares to take over interpretion of the commandline to get host and port information.  My subclass is to prevent that.  I'm going to rewrite this code to make this clearer.
indentation womp womp
ROBERTOOOOOOO
So this looks like it needs some attention
Okay. I'd advise against changes like this is you can avoid it, simply because it creates another merge point with new releases that needs to be maintained.
You could change name to a Common::String. That way, you could change all occurrences of these:
if (strcmp(name, "Foo") == 0) {
to:
if (name == "Foo")
Some levers are just in that block space though and not attached to the face.
For testing, just use the `setAccessible()` method on the reflected method like we do at other places already.
You are right, I've added a commit to fix it. I decided to actually check the old array of children to the new one, because it could also be that a field was added and another removed, leaving the count unchanged
:P  Corrected
Yes, the plain-text password is store in the session.
What do you recommend ?
確かにそうですね。ACIDではふんだんに使ってるようなので。
Please follow standard convention for naming methods - no space between `(void)` and `pulseImages`:
https://developer.apple.com/library/ios/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingMethods.html

Should be: `- (void)pulseImages`
Fair question. I created the facade because I wanted to give all three "communication" modules (user private messenger, group private messenger and user mailer) a uniform API so they can be viewed as strategies. I take advantage of this in the user model. See the `get_messenger` method. I think as we move forward there will be other situations where we can take advantage of this design. Thoughts?

The spec... Shame on me. Will fix first thing tomorrow.
Would it be possible to get this OS detection into a function so we don't have it repeated 3 times?
Fixed a6254be
Ah, thank you! I'd forgotten you could add messages to asserts.
I thought so to, since we rebind and end class `this.flush` bad things happen. 

https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/run_loop.js#L61
We shouldn't need this require since we've already required the whole `ember-states`.
I think that's something of a religious topic.  Personally, I prefer the implicit version (else what's the point of being able to use collections in a boolean context?).  Is there an overall style-guide for pyface or ETS that makes a recommendation one way or the other?

See the long thread starting at http://mail.python.org/pipermail/python-list/2012-July/626697.html for the latest related python-list flamefest. :-)
I was getting a crucial jquery error when the html editable table is too big (400 columns, 300 rows) http://stackoverflow.com/questions/6095530/maximum-call-stack-size-exceeded-error so I surrounded the code with a try catch, if we cannot successfully read the data from the editable table we will resort to reading it from the asCSV object. What this means is that the user cant really change their data in the table before importing, they have to change it either in the text box, or in the source file.  Most users probably dont even know that they can change their data in the table anyway...
Same comment as above - please use SIMPLE_LOAD_FACTOR_PROVIDER instead.
Yes, any exception message or log message at INFO or above needs i18n.
This needs to be internationalized.
I guess you were wondering why I moved from the intialization as a variable to its initialization in the init function. The reason was mainly for the testing. I wanted to know when the UssdManager was "really" initialized, including its properties.
remove input area and test because I am not sure if it is needed
It's my bad. I find `statusbar` is using `SoundManager.currentVolume` just now.
Could you please modify this for the scenario?
1. Modify `statusbar` or instead
2. Modify `soundManager` again for not to modify `statusbar`.
@timdream, please check if this is a good scenario in statusbar now, thanks.
Out of interest, why is !important needed?
Sounds good. In the meantime there is no need for this big switch. Once you will have timezone.json you will likely access the value directly from the object like return timezones[gmtInt]; Use an object or remove this big useless switch.
Why does `passcodeDigits` need to be an array?
yup, it might get added back but for now replaced by swipe, swipe + buttons is a bit annoying
You read a char at a time?
同意把 该函数从 rs 模块移出来，可以再单独建立个 img 的模块；
改函数名ok

按照下面说的，如果硬要和  rs 撇上关系，也可以用 func(key, opts) 形式表达，函数内部调用 rs.get 取 url
Did you mean to use a single pipe here?  I use `|` to get set union for arrays/sets but I'm not sure what it does here...

In addition, I'm not sure on the order of operations: is this `exit(status | run(ARGV, $stderr, $stdout).to_i)` or `exit(status) | (run(ARGV, $stderr, $stdout).to_i)`.

It'd be nice to make this code not rely so much on detailed understanding of ruby's precedence rules to parse.
As this is a multiline block I think the ````do ... end``` form would be nicer here.
Ок, если Вы говорите, что так оно и будет работать, мне несложно поправить текст. Просто, в геме 'russian' там отдельно задается правило локализации (see https://github.com/yaroslav/russian/blob/master/lib/russian/locale/pluralization.rb#L21-L25).
perfect for case
I do not understand this reset preset/history split. Is this only because SMTP does not have presets?
This isn't true. Each component isn't in charge of creating their own config files. The AppController is in charge of this for everything except for App Engine apps, which are the responsibility of the AppManager.
these TODOs are done, aren't they?
To have the documentation from which the client was generated, available in the client. It also used to retrive validation hash for the params validation. Before it was generated directly into method, there was no way how to retrieve the hash without parsing the Ruby code. see `Apipie::Client::Base.validation_hash`
Developer would expect setter to return either nothing or fluent interface ...
in this case please remove return statement.
If you push new commits to this branch, github will automatically update this pull request.
extra braces here
In next commit ^_^
That is a great idea. However, I would like to keep that separate from this MR and make it a separate feature. Would that be an option?
There must be a cleaner way to handle this.
no need to do this, I wouldn't say your work is a derivative since you're creating a completely new file
'<a href="' + **prefix** + ':' +
@ochameau Also remember what we agreed new manifest format should look like ?
https://github.com/mozilla/addon-sdk/wiki/JEP-Linker (See example in 7. Normalization section)

**local** modules have relative identifiers (relative to add-on root) while absolute identifiers are for **external** or **system** dependencies. Which maps very nicely to how this works in nodejs, in-package modules are required via relative identifier and system / dependency modules are required with absolute identifier. This also maps well how the web works were scripts are usually referenced via relative paths.

Now suggesting special `addon/` prefix is not very portable, in that case node probably would have defined other prefix like `package/` maybe so you would write `package/module` instead of `./module`. I don't even know what would have being analog to that on web.

Now that all being said I would have bought `/` as prefix, as it would make sense to refer to add-on root as `/`, but still that would made compatibility only harder for no real value.
I think either API or documentation is over complicated. Namely by intuition I expect `isFoo` named functions to return booleans.
I also find cofusing that no values `results.length === 0` returns `true`. I think it would be a lot simpler to have `getCurrentContexts`
that return array of matching contexts or `null` if there are no matches.

Maybe I'm missing something.
57ca1e5b2c496834fd7fe3058cda43cf215dce12 puts the above comment into the CSS for clarity for maintainers.
ok.  this argument is compelling and the jury is split.  going with `"disabled": true`.
I agree. This made me twitch while I was pasting it.
Can you add a comment about using functionality provided by the normal backend unit tests here? I was confused how these pieces went together.
Are there any tests that get here?
I often make numdays optional.  If you pass a ``days_ago`` and no ``numdays`` to ``get_day_range``, it will just get all the days from ``days_ago`` to the present.
nit: 'nsILocalFile'
__whimboo__ commented:
> why don't we use this in defaultTitle() and tabTitle()?

To use what? 
You would like to use the inaccessible `tabbrowser` variable in `nightlyApp.init`?
Or You would like to define a new `tabBrowser` property to `nightlyApp`?
Or? 

Instead that line above, I used `gBrowser` not just in `defaultTitle()` and `tabTitle()` but in `init()` too.
This shouldn't be a public method of this class. It looks like there is a config file class here.
we should make this a != then
As mentioned in the comments, you're polling here.  That's "bad".  The tornado gen module certainly looks interesting for this sort of thing.  Examining messages should happen in a callback (i.e., when a message comes through, calling a function), rather than in a polling loop, if at all possible.
Updated; better?
The problem with vars like `@whiteSmoke` is that it does mean this should only be `#f5f5f5`, not a light gray of some sort. I'd love us to abstract all our grayscale vars a bit more to something like `@black`, `@black90`, `@black80`, etc where each number represents an opacity (against white) of a black fill. This could be done in increments of 10% down to around 20%, then in increments of 5% for granularity.

Thoughts?
The `err.stack` typically contains the message as well so we should be fine with just the one line
Can we perhaps split this method up? It's currently 70 lines long, making it hard to extend and comprehend.
This class looks problematic, as it can easily go out-of-date with the base ServiceListenerFactory.
This exception is actually used in Connection and Statement, what are you suggesting we do in there?
FYI, this is not an exception to throw, it is utilized as a nested exception to carry errors inside the actual exception.
I think that there is not specific rules about this but I think as @mwillbanks, its more readable if both sides of && share the same line and || in a different one.
Just for consistency add the type for the parameter (int)
The code is not so clear here, you are right. I reused the $output as a new variable. I will change this.
This won't work as-is. If you look at Simba master you'll see that each wrapper has a lape_extdecl at the end of the line. If you don't do this; it won't work in Lape.
I suggest syncing your branch against latest Simba master. (We can look at this over IRC)
JPEG_FOUND is only set when the findJpeg script is run. That script will not run if USE_SYSTEM_HEADERS=NO.
done.

This file usually exists just because it’s needed for simple `npm install` of brunch plugins.
Not a jquery expert, that's the same thing as the following, right?

$(this.domElement).html( this.template( data ) );

I used that for now.
Cache the `$(this).val()` since it's used twice.

```js
var val = $(this).val();
```
shouldn't this be moved to a method called "toggleVisible()" on TodoWidget?
@harjis Don't repeat yourself. Nämä voisi yhdistää yhdeksi funkkariksi sen verran samat on.
Ahh, we don't do that anymore, indeed :)
Codesniffer on commit hooks locally in git would be a boost :)
Since class names are here suffixed by their functionality, we should stick to that (=> PrefixedUrlHandler), but that's just cosmetics.
`script` があるのが微妙...
gem を入れたらすっきりするかと思いますがそこまですることもないかなと
This isn't needed if you use insinto later.
:cake: good catch
can we also look up the project group in the groups tree?
Please add a proper sanitycheckpath.
Should probably add 'image' to select_related and test that this is still only one query.
It was a DOS to Linux line ending conversion.
your comment is obviously perfectly valid, it's just the likelihood of race condition is greater than the likelihood of that particular bug =).
This is fine as long as UNS remains a singleton.  For the future, if we want to expand the number of UNS instances, having a named queue here is fine, but the callback method will should extract the process_batch_key out of the headers (or make it a lambda call, passing in the current value of it), that way round-robin delivery to all UNS instances would be safer.

There would need to be an additional step where the binding is removed from the queue when we want to tear down this batch processing.

Again, for the future.  Comments for posterity.
If you restrict it explicitly in the type, that's very fine with me.
どう使うかによるけど， ENV って要はグローバル変数ですからね.

- iniitalize などで渡す
- 適宜アクセッサを定義する

などして，実際に使う場面でENVから（それらを使って）設定してあげるのがいいんじゃないかなー．

もちろん用途によって例外もあるんですがー
I agree though that this is pretty gross, I'll try to figure out why this is actually happening.
I just checked the code and I'm not sure if this code does even affect DVDs because there is some code in DVDInputStreamNavigator.cpp which tries to set the audio stream using DllDvdNav::dvdnav_audio_language_select() (where we probably should replace the usage of CLangInfo::GetDVDAudioLanguage() by the new CLangInfo::GetAudioLanguage()).
We should perhaps look into running the unit-tests with the memory backed simple direct bypass server, rather than the full container. It will be much faster.
Thanks for writing documentation!
there's a `hint_purple` class and as @xymostech mentioned a `\purple` macro, but no `PURPLE` constant, probably because you can just say `"purple"` and get the same thing. But yeah, we should probably add one to be consistent.
nit: `skiis` -> `skis`
4 spaces indent please :dancer:
Why hardcoded port `8070`? Should provide an ability to specify port number as an optional argument. The default one should match the default of `bem server` itself: `8080`
It's probably worth looking this up and passing it into the rules. (just to keep the curator out, it's not foolproof but I still view rules as a potential attack vector so the less they have the better)
レンダリング用に評価するためJavaScriptテンプレートをコンパイルして関数化を行います。JSONデータソースから複雑なHTMLの断片をレンダリングするために便利です。template関数では<%= … %>と、任意のJavaScriptコードを実行することができる<%- … %>とで変数を補間することができます。変数の補間と同時にHTMLエンコードを行う場合には<%- … %>を利用してください。
template関数を評価する際はテンプレート側の変数に合致するプロパティを持つdataオブジェクトを渡してください。1度しか利用しないテンプレートを書く場合に、dataオブジェクトを第二引数として渡すことで、templateを返す代わりにレンダリングをすぐに実行できます。settings引数は_.templateSettingsでオーバーライドされたハッシュを含んでいる必要があります。
I think `self._state` should still be updated in this case.
Function.bind() replaced by enyo.bind() in new commit added to this pull request
Once again. This is not use-case for Filter, please create Logout Servlet
Yes - good plan. Will change and merge.
да?
super.doParse would parse attributes for you.
I wasn't sure whether the hack this comment is referring to was about, so wasn't able to test whether removing it breaks something. Do you know what bug this was fixing?
```c++
#include <iostream>
using namespace std;
cout << "Hello world"
cs
```
Of course, however the context of the page loading depends on the action that caused the page load rather than the page that's loading.
should also be added in %files
Is there anything sensitive in the logs? Having the log dir readable without executable seems an odd choice.
All principal / content searchschema stuff has been centralized in the `oae-search/lib/init` file. This stuff has been removed.
I don't think -enabled should be used to identify boolean configurations. Every element should have a type value that defines its config type (boolean, string, select, etc.)
I think this can result in multiple invalidations for the same group and subsequently multiple member expansions. In short, you need to check `!_.contains(...)` on both `invalidatedGroups` **and** `groupsToInvalidate`. Explanation:

Say Group A, Group B, and Group C are all in `groupsToInvalidate`, and Group C is a child of Group A. If Group A is expanded first, Group C is found, and Group C doesn't belong to `invalidatedGroups` yet. Therefore it gets pushed back into `groupsToInvalidate` and is in there twice.
This documentation isn't accurate, it can also return what the passed in value is. Also, please align so that the 'types" are aligned vertically (i.e., {String} {Boolean}) and the descriptions are aligned vertically as well, between return and param. This is the convention we are trying to maintain.
this happens only for POMs, right? If that's the case, maybe ``**/pom.xml.versionsBackup`` is better?
Any reason why `ask` and not `askOption`? If not, I'd suggest to use `askOption` instead.
You may want to make this ``private`` and ``@volatile`` to avoid visibility issues (which could potentially lead ``ScalaJdiEventDispatcher.run`` to never stop)
Nope, my fault.  renamed the method at the last minute.  Thanks for catching it.  Eventually I will get better at this! :)
Five lines of comments for one line of code?  That ratio just seems absolutely silly, even adding actual bloat to the file size and download.
It's really hard to read each example on its own. Can you separate them by a new line each?
Вот от этого не забудьте избавиться.
согласен, спасибо.
а он и вызавает, посредством вызова initWithMoleculeLength
(symbolIndex + random()%(dnaSymbolsCount-1) + 1)%dnaSymbolsCount

с чего бы А стало снова А ?
А если короче?
Мне так удобно
It doesn't make sense to add #each without also adding the rest of Enumerable. I'll look into that.

Also, this would be better written as

    def each &block
      value.each(&block)
    end
Since we've removed the ability to create custom schedulers through the API, I'd rather have private subclasses that implement `-schedule:` to do what they want.
Your intention is correct, but are they equal? 
You're doing this because "extension_id" is incremented inside JTable::store, is it right?

Eng. Gabriele Pongelli
Your call. `0.10.0` is probably better
apparently there is a bug if you don't give color then only one evoked is plotted.
... corresponding to Freesurfer environment variable SUBJECT
same here check for error first.
Should this configuration be per-user, so that multiple people per-Splunk install can use it?
this is really a crappy title as you could use it for anything, thus making the TOC useless for this title.
it already works in 2.0
this does not follow the Symfony2 CS. We use a use statement per class.
较大的缓存将变的必要
可能必需较大的缓存
Comma needed after this line.
For when we have tests. This script will run only our tests with an in-memory database.
>
> > +    assert separatevars(x + x*n) == x*(1 + n)
>
>
Yes, because without it the factors could not be separated.
Оно же со свичем не работает.
А, нет, не ок. Имеет смысл строчкой ниже `break` делать же, а то добавится несколько разных эдиторов.
Yo no pondría nos números de los sprints, es algo que solo nos sirve de referencia a nosotros y probablemente fluctue mucho.
Perdón que pregunte esto ahora pero... esto significa que lo que viene abajo no está dentro del criterio de fin de proyecto? Por alguna razón me confunde la forma en la que está redactado.
As this file is only loading the composer autoloader, you may even simplify things by removing it and making phpunit use the vendor/autoload.php directly. this is what symfony bundles do
I'd prefer something like:

```
options[:method] ||= []
options[:method]  << :amount
```
I guess this is ok since it's only 552kb, but ideally I'd want to use something programmatically generated like my [sine wave generator](https://github.com/TooTallNate/node-speaker/blob/master/examples/sine.js).
We can always add that later. In most cases, any given machine won't be part of two separate clusters with different keyFiles, in my experience.
Why was this file added?
Ed and I were just talking about how passing req to view actually violates the C to V encapsulation of MVC... but I can't say I really mind. To me as long as M is chilling off by itself away from C and V I don't care if those other two cats occasionally mingle.
we mustve made this at the same time :P
can we switch to using the annotations aka decorators
God bless code review!!! Thanks
Sorry for being pedantic, but can we pull these out into a separate pull request, as it isn't related to NBST and this patch is complex enough as it is without added noise.
I think the key should only be marked as read if the returned value is used, i.e. the Flag.SKIP_REMOTE_LOOKUP is missing or unreliableReturnValues is set to true.
A bit out of context, but I think it's worth adding an bolded note on the put/remove javadoc stating the important performance benefits of Flag.SKIP_REMOTE_LOOKUP. Something like:
   /**
    * {@inheritDoc}
    * <p/>
    * <b>N.B.</b> if the return value is ignored by the application, then the user is strongly encouraged to use the
    * {@link org.infinispan.context.Flag#SKIP_REMOTE_LOOKUP} flag when invoking this method as this might in one less
    * remote/network call.
    */
   @Override
   V put(K key, V value);
Wdyt?
of course, thanks :)
I am crying at the conventions in this file. What _is_ all this.
I could, thanks for pointing out. The y property was changed like a day later and changing width and height using the same way slipped through my mind
Логично )))
This was split off to another class because some log libraries already have those constants defined, which prevents them from implementing the interface. As for why they are not integers, it's again because integers can conflict with existing level constants of log libraries. Strings can't conflict since they map to their own meaning.
All-caps variable names are reserved for constants.  Switch to all lowercase.
Could you give this a more generic name so that we can easily expand on it if necessary?
@bp323 Can we use 4 spaces here?
#ifdef at beginning of line please
Done! (I've also removed some old Debug code that was lying around for a long time... heh)
ordering based on `id` is probably not correct, it should be order by `sequence`
I feel like we shouldn't insert this until right before we're going to make the relevant measure (after we set the font for the second time). I'm not sure how all of the timing works out, but it seems like if the browser paused JS execution at the first width measurement, it could already be done trying to load the null font before the second measurement is made, leading to a false negative for the bug detection.
Are you sure that the property "hashAlgo" exists? Did you maybe forget to declare it?
It could appear if no other error messages were set in the flow translation
file, I've updated this to a meaningful message.

On 6 November 2012 09:00, Alex Tomlins <notifications@github.com> wrote:

> In lib/smart_answer/question/date.rb:
>
> > @@ -45,6 +45,9 @@ def parse_input(input)
> >          date = case input
> >          when Hash, ActiveSupport::HashWithIndifferentAccess
> >            input = input.symbolize_keys
> > +          [:year, :month, :day].each do |k|
> > +            raise InvalidResponse, "Bad date", caller unless input[k].present?
>
> Is this error string exposed to the user at all? If so, it should be
> worded differently.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alphagov/smart-answers/pull/95/files#r2040056>.
>
>
I don't get why we can't have a shortcut form `link(model)` that calls `linkRenderer().to(model).write()`?
Please can you re-instate this? I'm not sure why you've deleted it.
Compile warning:  warning: conversion to 'int' from 'long int' may alter its value
nm I was confused, `#attributes` is still around.
Looks like it works fine without it (automatic escaping and all). Removed!
If ``popular_videos`` is a NormalizedVideoList with a queryset that is correctly ordered, it is an iterable that yields popular videos in the correct order for the front page. It doesn't matter whether the output exactly matches ``Video.objects.get_popular_videos()`` because we don't have an explicit sort order for items that have the same popularity (for example, 0). IIRC that's why I changed this test - the order for items with no watches was indeterminate.

I'll add assertions that we're dealing with a NormalizedVideoList instance and that it includes all videos.
ok so the bundle is added automatically by composer ?
The @return clause is still incorrect.
the idea was afair that we re-read the config file, so we can track changes, otherwise, you need to restart the proxy each time you add an environment.
Could add parentheses here? This confused me for a sec. :)
Typo in *exsits*.
I think that `.is(':checked')` is the proposed way to see if checkbox is checked?
*ravnokar*?
Why no spaces around `=`?
```
v1_api = api.Api(api_name='v1')
```
**Returns provider's source name.**
No i can't. In settings.py there is a regex  code "url': r'/updates/([^/]+)/", where "/" is excluded. I tried using / but this was the reason for error 500 that i mentioned some time ago. Then I changed regex code so that "/" is allowed but this opens whole new list of errors. I think there is a reason for  excluded "/" in push server url.
for example from this 
http://shrani.si/f/2A/6a/2HnLPAZv/capture.png
to
http://shrani.si/f/3a/su/2XJ3ChsO/capture1.png
And why span around input? Why would not input has that id itself?
Look you know it is not hard to make another commit to fix it. But I just copied the current version in my file, and github sees no changes. Why would I lie to you? I will do somethin else then, make a stupid commit and then another commit with current code.
My previous documentation of defs in ruby was "Args" and also for Python. Lets change this for consistency.
$this->plugins === null
Namespace is shit
I think you wanted `options[:credential4].present? ? options[:credential4] : account`
Aha, I need to break.
ich glaub der istso nicht mehr nötig. Geschieht implizit.
Das müsste noch in strings... oder sonst wo...
No, you should assume that you get objects here, while the `AuthenticationAdapter` should retrieve entire instances.
Is this accurate? Seems the jqf content has been largely replaced.
I'm pretty sure we don't need gevent-socketio in here. However, it's listed in the web-requirements.txt.

I may be mistaken. Why do you want to have it here?
Yes, .match returns the whole match as [0], will actually slice it off and work only with the parts.
This doesn't really matter, we're just painting an "×".
Should not there be an --all without --contains?
Does this URL need to be here?
Group imports. Put one empty line between built-in Python modules and Django modules.
My questions about why import whole modules wnet away and I can't read your comments on them.
Also, why should we import like 
>from piplmesh.account.models
instead just models?
One empty line before. Group imports.
Please name the class with some prefix from the base class. Like `CaseInsensitveUserCreationForm`.
What is this?  I cannot find any other references to kxml in the diff.
Same comment re:correct type.
Oh my.  Yes, that came from draw(), not drawShoot().  Fixed.
True, this will be good to add when I make sure surveys appear correctly in videos, but I'd prefer to handle that as part of a separate pull request.
Get rid of this doc
very lightweight, rather not have extra fields
We had that in there before, but thought end users wouldn't want it. But I'm guessing that we're nascent enough that should be in there to help people develop it.
If you are going to keep using MySQL remove this file, or adjust it to MySQL.
This pattern is not the easiest to grok.

Perhaps:
```` ruby
/_COMPLETE$/ === current
````

http://www.ruby-doc.org/core-1.9.3/Regexp.html#method-i-3D-3D-3D
Did you mean to leave this line in?
Acho que para ficar explícito que a ação será tomada sobre os ítens selecionados, o label poderia ser: Enable Selection/Disable Selection
In theory, there should be no need for to_f, but the assertion library was complaining than an Alchemist::UnitConversion couldn't be coerced into float. I struggled with this when working on the alchemist library and think I may have a fix there but hadn't translated into the alchemist used for testing DM
I don't understand the name. Why is this called _run_method?
Hi David - yeah I agree. We were just following our designers guidelines. I will talk to him and come up with a solution. We were thinking of highlighting the area you are in via the main navigation, but we will work it out.
Should we add keystore, it is not integrated in pzp. It was integrated previously but removed as support is missing in Windows and Android.
instead of a comment what about:

        var ok = buttons[0];
        ok.onclick = function onClickOK(evt) {
          ...
        }
newline at end of every docstring.
there is a missing call ``->fixXmlConfig('directory')`` to support XML configs as well
@with is basically kluged together multiple inheritance.  Since OBController has @With(OBSecure.class), everything that extends it does too.  That's the only place we should need it.
Is this left-over debug code?
`each` / `forEach` just return undefined! What do you want to do here? `any` or `all`?
JavaDoc missing for the public interface, what it is / why it is needed
Hey, this is awesome! After this line, could you please use [something like this](http://stackoverflow.com/a/1675345/304706) to set the cursor at the end of the text? (It's not happening for me in Chrome, otherwise.)
It's also possible to do the sorting in Galaxy.  Check out lib/responder.rb for examples about how to do that.
А почему здесь нет сообщения?
Я тоже не очень понял, но вроде все файлы остались прежними.
Not anymore, I'll remove it.
which rather than what?
Я, здесь, планирую всё про-рефакторить. В конечно версии укажу о this.
Example and test scripts may either live in the docs directory or in the test suite, but we should try not to have them loose-standing like these.  Data-files may be added to skimage.data (although my image viewer just shows black when trying to open iko_pan).
'original' -> 'noisy'?

Also, it's a bit confusing that the original image is on the the same row as the `tv_denoise` calls and the noisy image is on the same row as the `denoise_bilateral` calls. (I originally assumed that the two filters were operating on different images.) Maybe you can write the titles as 'TV(noisy)' and 'Bilateral(noisy)'?
Should this be ``y_size // 2``?
This is not going to be readable from the Python/IPython shell. Can you rewrite the formulas in plain text? Unicode is allowed if you put an encoding declaration at the top of the file.
Is this kind of local scope optim required in cython code?
same here - better to call ``__dealloc__``? (see [1])?


[1] http://docs.cython.org/src/userguide/special_methods.html
Sure - just to make sure: deviance (=logistic loss) is the most commonly used classification loss function for GBRT - I've seen exponential loss functions (e.g. R's gbm supports exponential loss) but they are usually dealt with using AdaBoost. Actually, I think I should have hard wired ``GradientBoostingClassifier`` to deviance in the first place.
I assume that the `q` in `qid` stands for "query" but this is just an informed guess. I am not very familiar with learning to rank stuff my self.
No. ##then()## call returns _new_ promise.
Remove the TODO above
Met à jour le nom du panier sélectionné
Can you add spaces around the equal sign
Return type should be `id<RACSignal>`
@fuceta - adding for comment..
I face a similar problem in that I generate a cobertura file via js-test-driver and as such do not run the maven plugin.
I'm not sure this is robust enough. Especially if the slug uniqueness is false. I'll investigate with some more unit tests at some point.
res.expose
I really think all this examples should be in [our examples folder](https://github.com/mozilla/addon-sdk/tree/master/examples) and this
tutorials should have links to them.
Ah, okay, makes sense then.
I think this should be fine. Php can even handle casting stdClass objects to arrays. ArrayAccess simply adds a different way of addressing indexes (eg $myObj['index'] rather than just $myObj->{'index'})

The problem is that even if an object implements ArrayAccess, is_array still returns false. So if we try to call array_replace_recursive on such an object, it won't work. (we need an actual array here)
FUNCS array was added by Federico ( another contributor ) to link each "gimme_time"s function to its language so if 
italian language is represented by the index 0 then FUNCS[0] should be "gimme_time_it", english has index 1 so FUNCS[1] should be "gimme_time_en" and so on.
Name: _prime_perm_caches
`storageservicesettings` should ne `servicebussettings`
Yes. Abhishek asked to include it.
@shacker can we just use `background` shorthand?
is there any reason to prefer "namespace { /* stuff i don't want visible */ } over using file statics?

(btw: this shouldn't in theory be a problem, since CONFIG += hide_symbols is enabled for all plugins, but still a good idea to follow good practice I suppose)
Could you explicitly name the parameters. I had trouble matching these descriptions to the parameters.
Maybe `downscale` instead of `factor`?
How can there be any nans?
I changed a lot around - actually we only react to `FBSessionStateClosedLoginFailed` the case when you cancel the authentication process. So it would not be bad if we just ignore this `transitionToState` originated in the `init`...
Ok, that sounds fine. I'm still a little unclear on some of the intent behind your organization, but i'm sure i'll get it in time.
This method always returns a falsy value (`nil` or `false`). If it succeeds, shouldn't it return `true`? Otherwise lines 25 and 29 will always fall back on checking `parameters_difference`, as I think it does now.
`(10 seconds) * (number of file to download)` for mozilla to wait before removing iframe? I think it is too long. Have you test it?
that's a relic i need to get rid of. i didn't know when i started whether it was ID or NAME
Let's make them consistent with the Cesium API defaults even if that means changing some of Cesiums.  Some defaults, like color, are pretty random.
If it's really a `TODO`, let's do it; otherwise, just call it `PERFORMANCE_IDEA` like we do elsewhere.
I would say, 

    Setting this property to true disables display of the network activity indicator when network activity is in progress.
Why only if enableHorizontalWrap is true. Don't you need the maxHeight even if you are not wrapping?
40 is an int. I want to be explicit that I want nums (i.e. floating point). Does that make sense, or should I still switch to var?
Good point, I'll make some changes. I don't know myself about faces-config, just trying to replicate the WAR structure in the test.
Let's change to the array format.
On 10/15/2012 9:54 AM, Greg Thornton wrote:
>
> In lib/cached_shell_redirector.rb:
>
> > @@ -104,7 +104,7 @@ def close_write
> >      # Ruby 1.8 define_method doesn't work with blocks.
> >      def method_missing(my_method, *args, &block)
> >  	# Only handle IO methods!
> > -	if IO.instance_methods.index(my_method.to_s).nil?
> > +	if IO.instance_methods.index(my_method.to_sym).nil?
>
> I'm using 1.9.3 so that's definitely the problem. Maybe |if 
> IO.instance_methods.map { |m| m.to_s }.include? my_method.to_s| ?
>
>
I suggested a simpler version:

IO.instance_methods.map(&:to_sym).include?(my_method.to_sym),

since might as well keep it as a symbol if it is already.

--KUBI--

-- 
Professor John Kubiatowicz
673 Soda Hall
Berkeley, CA 94720
E mais interessante voce testar somente o resultado porque nao seria inerente ao teste saber como esse resultado acontece, mas sim testar se o resultado e o esperado.
thinks its ok like this for now. we should run all test suites against 2.1 and 2.2-dev but thats out of scope here
Sorry, I meant to say you want to change it to mantychore-tests, not base-mantychore.
Could you add a new test case instead of modifying this one.

Maybe call it `"preserves query string on GET request"`. See this as an example test case.

https://github.com/defunkt/jquery-pjax/blob/master/test/unit/pjax.js#L128
возвращать константный bool --- это сильно. лучше метод сделай константным
array $options
Two weeks ago, the implementation of `std.string.format` is changed to `xformat`'s. (by merging #939). So currently, you can just use `format` in here.
In current, most better workaround I can suggest is:
https://github.com/D-Programming-Language/phobos/pull/842/files#L1R143
You horribly mangled the HTML here for no good reason. HTML is built like a hierarchy, you should always indent after any reasonable addition to the hierarchy, makes the layout much clearer.
The related part of the HTTP spec is here http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.1

I understand it that the media type with the highest quality value as associated from the server that is higher than the quality as requested from the client wins, e.g:

````
client                              server                             win
text/html;q=0.9, text/plain;q=0.5   text/html;q=0.9, text/plain;q=0.3  text/html
text/plain;q=0.5, text/html;q=0.2   text/html;q=0.9, text/plain;q=0.3  text/html
text/plain;q=0.5, text/html;q=0.9   text/html;q=0.1, text/plain;q=0.6  text/html
````

It was not clear to me, how your current implementation works in detail. :-)
What do we use this i-var for?
So new commit is here : https://github.com/symfony/symfony-docs/pull/1124
Indention is using tabs/spaces differently here
Sounds good, I understand what you mean now.
This is the only way I have found to match the generic type of the page object I would like to implement with the actual type retrieved from super class declaration.
Ha.  It was tabbed, I replaced it with spaces in the new commit.
1<<20 seems to be over-sized, thinking about it. Make this 1<<17, with 160 max segments. This is still 20mb max
`,` on end of line, just everywhere actually.
:'(
I so much like methods camelCased, but variables underscored. But, fixing...
$isExclude and $isExpose only apply to the real properties, we should probably move them into the loop above.
тоже самое, и внизу
Why are you including this, if you define it as helper in the next line?
That is fine too :)  Good improvement!

On Tue, Feb 28, 2012 at 3:01 PM, Benjamin Root
<reply@reply.github.com>
wrote:
>> @@ -13,6 +13,10 @@ for all these packages are available here:
>>
>>    <http://pythonmac.org/packages/py25-fat/index.html>.
>>
>> +*** Setup from source using Pip ***
>> +
>> +   pip install -e git://github.com/matplotlib/matplotlib.git#egg=Package
>
> Shouldn't this use "https://" instead of "git://" in case the user does not have git installed?  I don't know if it makes a difference.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/matplotlib/matplotlib/pull/646/files#r498427
Can we change this (and on all the lines beneath) from `docData["rows"]` to `docData.rows`
Anything specific you would suggest? I looked through Chrome's and Firefox's language lists and es-419 is the only 3-character country code and only in Chrome. I still can't replicate the bug.
Why is b the case? It seems like it would happen for any bad locale, not just that locale.
did you read my response to pervious same comments ?

we call print_sprint_header two times, one for request and one for response, and if I open the file in 'w' mode the user only sees one of headers
Okay. String alone is fine. The runtime exception will happen soon enough.
The valueOf(..) call here can obviously lead to errors anytime the expression evaluation result is not a valid HttpMethod enum value. The default error message is probably too-level, meaning we should catch this and provide a more useful error message.
Javadoc lines are too long to read easily on GitHub. Spring guidelines suggest wrapping at 90 chars.

https://github.com/SpringSource/spring-framework/wiki/Contributor-guidelines
?? If we want to stay compatible with JDK 5, we can't have @ overrrides except on superclass methods. Did you make any changes to STS save file rules recently? Should turn off the option for interface methods (unless we're declaring 2.2. needs JDK 6 - which is probably not bad since 5 went End of Life in 2009 and JDK 6 goes EOL in November :-)
Could have done assigning of the name in `_compile_integral` but it doesn't really matter.
That refers only to the case where instances of factories or closures are used. It may be worth telling that it is PHP itself not allowing serialization of closures.
@apex13 That should now be reverted.
please add spaces according to the Twig coding standards
`ZendDeveloperToolsTime`, `zendDeveloperToolsTime` and `zenddevelopertoolstime` is the same
Ok, I will wait for https://github.com/FriendsOfSymfony/FOSCommentBundle/pull/274
Why is there a file addition?
I'm totally against this, just for the record
https://github.com/vinodkiran/droolsjbpm-integration/commit/586b82708d21a22aff04469b4873d500db18b80d

all the modifications suggested by your review have been done and committed...I am not sure how to add the second commit to this pull request.
It's not exactly `if TEST_MGMT`, but it's still a gate.
StackMob.java is now just a bunch of cleanup changes
Can you please put a space after the comma because I'm super pedantic? :-)