labofsahil/github-event-dataset-2012 huggingface dataset:
I really need to pay more attention when I switch branches, sorry about that, originally I had changed 

    function metaDataParser(videofile, callback) {

to

    function metaDataParser(videofile, callback, error) {

following the comments from mediadb

 *     your metadata parser function. This function should expect three
 *     arguments. It will be called with a file to parse and two callback
 *     functions. It should read metadata from the file and then pass an object
 *     of metadata to the first callback. If parsing fails it should pass an
 *     Error object or error message to the second callback. 

I will do as you said and mark it as bad, but it seems like mediadb should do the same whenever the metadata parser throws / calls the error callback, right?
What happen if there is already a modal dialog out there and another iframe called |alert|?

(let's address this question in a follow up)
no sysout please.
I (broadly) agree; the problem that I was seeing seemed to be that one of the `puppet agent` runs was returning a non-zero exit code, simply to indicate that resources had changed (as the help says it does if `--detailed-exitcodes` is provided).
Let me guess. Without this the car wouldn't show up in the beginning right?
I know about your intention :wink: Actually this `highscores` method just does one thing: fetching the highscores (sadly, I couldn´t n achieve to cast the rank to an integer by modifying the select-query - so i wrote this little helper).
I basically agree with 'each method should only do one thing' but this is connected so close, it belongs together for me. I hope you can get along with it.
You only get to this if-form if file is non-nil. Therefore if *edts-debug-last-visited-file* is nil it will never be equal to file, so you don't need the first condition here
There is a new cascading (val pipe) that has run all the map/flatMaps/filter.  Since we have to run those to write out the result, let's capture the result so we don't recompute it.  We do this by taking the result pipe and returning the new TypedPipe wrapping this pipe.
Can't be right... where's the {param}?
Why is there a TODO here?
Turned it into a TODO in the code.

On Fri, Nov 16, 2012 at 9:20 AM, Chris Bunch <notifications@github.com>wrote:

> In AppController/lib/app_manager_client.rb:
>
> > +  def initialize()
> > +    @conn = SOAP::RPC::Driver.new("http://
> #{SERVER_IP}:#{SERVER_PORT}")
> > +    @conn.add_method("start_app", "config")
> > +    @conn.add_method("stop_app", "app_name")
> > +    @conn.add_method("stop_app_instance", "app_name", "port")
> > +  end
> > +
> > +  # Make a SOAP call out to a the AppManager.
> > +  #
> > +  # Args:
> > +  #   timeout: The maximum time to wait on a remote call
> > +  #   retry_on_except: Boolean if we should keep retrying the
> > +  #     the call
> > +  # Returns:
> > +  #   The result of the remote call.
> > +  # Note:
>
> Saying "you won't forget" is not acceptable. Just make this a TODO and
> open an issue for this, so that Jovan or Tyler or I can potentially look
> this over in case you get busy.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/AppScale/appscale/pull/99/files#r2154161>.
>
>



-- 
Navraj Chohan (Raj)
PhD Candidate @ UC Santa Barbara
http://cs.ucsb.edu/~nchohan
http://appscale.cs.ucsb.edu
http://nlake44.posterous.com
You're right. I switched to an IDE which messed up all my spacing and didn't realize this had happened. I'll fix this.. Thanks!
You don't need these `"`s.
I'm leaning towards 1) for now, as its a very quick fix.  I'd like to do 3) down the road, but i think that's going to require some serious work to do right :)
`typeof` is unreliable across browsers, but mostly when applied to host objects. For our tests, `.to.be.an('object')` should suffice, right. Expect.js seems to test for `!= null`. Will change that (there are several occurrences).
yep, didn't actually notice it swaps it, so to do it the rails way use `post.photos.empty?` ;)
Why are these sections commented out?  Do they not work?  What are you using to configure for ARM NaCl?
Hm, seems i have not really understood how all this .m4 stuff works together. If i put this in my local user_myHardware.m4, how would someone else know what he must add into his pinning configuration for the module to work ? Is there no global file or something fo this?
@SaitoWu  great. I'll merge this one. Thank you
I think it's quite safe to remove `GL_BYPASS_UPDATE_HOOK` as I didn't saw any reference for it in gitolite nor anywhere else...
Do you mean that we should use a classname of `color`...? Not keen on tying a design detail to the markup, `selected` is abstract enough that it's clear what it means but doesn't mean that its implementation includes a colour change.
Yes the data-upgrade attribute only gets set on the first trail in trail blocks, and therefor the test below on line 27 will always pass. But for all other images the will only get upgraded if the layoutMode is extended.
agreed, will do.
Maybe we can allow "group" as well, or make the perms configurable.
indentation here is off
That password needs to be changed now.
@daniel-pittman in the form it has become the constant doesn't have as much value as when I commented. When I suggested the change the special hyphen was in two places with no clear indication that they were the same concept. I actually still like the constant in this case since the code clearly states the intent of the value.
It seems like it was already doing that, so I don't think this change makes us any worse off--unless I'm not reading this correctly.

That's not to say that I disagree with your statement about failing if the method can't achieve it's goal.
Maybe break this on to different lines?
The dateutil dependency is called 'python-dateutil' on pypi, I think this might be required instead here.
This can be string too
This blank line must be removed.
@Maks3w The $assertion usage is something I started with the other form helpers -- it simplified the ability to test behavior across many types at once. I think it's valid -- you're simply saying, "hey, here's some common setup for a given value, let's run an assertion against it." Having the assertion provided via the dataProvider keeps the value and expectation close to each other.
this method refactors one line, hmm why not refactor 232 too, so then just leave it bare not refactored
Agree, just a brainfart moment ;)
should this say `request`?
Haha yeah probably :D wtf..
what is this!
Ah yes the old ashtray on a motorbike test, I've updated this and pushed.

On 21 September 2012 11:54, Alex Tomlins <notifications@github.com> wrote:

> In test/unit/business_support_business_type_test.rb:
>
> > @@ -0,0 +1,7 @@
> > +require 'test_helper'
> > +
> > +class BusinessSupportBusinessTypeTest < ActiveSupport::TestCase
> > +  # test "the truth" do
> > +  #   assert true
> > +  # end
> > +end
>
> Should there be anything in here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alphagov/imminence/pull/5/files#r1660140>.
>
>
If the line does not surpass 120, we can put everything into the same line
Indeed:

```iex
iex(1)> kw1 = [b: 1, c: 3, a: 2]
[b: 1, c: 3, a: 2]
iex(2)> kw2 = [a: 1, b: 2, c: 3]
[a: 1, b: 2, c: 3]
iex(3)> Keyword.merge kw1, kw2
[a: 1, b: 2, c: 3, a: 2]
```
`dict.setdefault` is handy: `self._commutes.setdefault(ref, []).append([fn, args])`
sanity check paths need to be fixed
@JensTimmerman said it was OK to merge.
well, huh. Good catch. Crazy! I suppose that returning None fixed the tracebacks I was seeing in postgres. Now when I return the reversed tables I get another integrity error. I'll have to revisit this...
LOL... This seems so minute to bring up (and cause a rebase..)... but, perhaps `extension` should be pluralized?
Well yeah, it's only for tests.
That's not quite the same thing... You'll need to dispatch a click event to the video element.
Correct. The baseplayer already sets up basic things like this. So media.paused is the exact same thing.
What you've done here is technically correct and will work great, but since it's something we use frequently, we have a shortcut in the form of span_if_current. :) With span_if_current, all you need to do is change link_to from the original version to span_if_current, and it will turn the link into a span with the class 'current.'

Also, there are a few extra spaces after the translation string for Flat View that should be removed before this can be merged.
isnt it domain_ids ?
I think you might have explain this before but why using `is_active`? How can a user even be authenticated at all if they're not `is_active`?
Doesn't something like `request.user.is_authenticated()` a more natural way to ask the question?
I'll make the change. In terms of the later I couldn't find another way to do it. What would be really nice is putting the start and end into a single template, but I didn't see an easy way of doing it.
I've corrected my mistake in the latest commit.
Committed fix for this documentation error should now state "ISLANDORA_POST_PURGE_OBJECT_HOOK"
value引数で指定した値のある配列のインデックスを返します。配列に存在しない場合は-1を返します。ネイティブの *indexOf* 関数がある場合はそれを使用します。大きな配列を扱い場合、かつ配列がソートされている場合には、*isSorted* に `true`を与えることでより高速なバイナリサーチを行います。あるいは、第三引数に数字を渡すことでそのインデックス移行から探索を行います。
Qt documentation practices do document even the obvious to keep consistency. I would also consider it strange to have documentation on some functions but not on some, no matter how obvious they are. The comments don't make the header harder to read and don't require maintenance, so I don't see any problem here.
Should mention the `logging-config` configuration variable here. Dynamic changes to log4j only happen if they have that variable defined (which it is by default in our packages).
I don't disagree with that.  This could be an intermediate step, though, because it still helps to mitigate the risk of typos in having the literal string everywhere.
From my pov we're just fixing a bug + this change shouldn't break any existing apps but please do correct me if I'm wrong. That's why this is a pr and not a direct commit :)
settings.py file is created by django admin tool, which used it's default code indentation. I don't think it is required to use 2-space indentation here, let me know if you want, I will do the changes in settings.py.
This is a bit confusing to me. We do almost the same query twice, we could merge this into a batch query.
Default getters are getters for *default parameters*. Good point, I'll update the description accordingly.
I'm getting ReferenceError: Can't find variable: ClusterMarker_ in my console (leafclusterer.js:544ReferenceError: Can't find variable: ClusterMarker_) :-(

Possibly due to the if statement on L222
Remove this file is a avoidable BC break. 
You can simply include the composer autoload file.
We can keep `!==` for the second expression - that shouldn't be an issue. Parentheses (again on the second one) could be removed though - counts for the next two instances as well.
Can you put spaces around any `!`'s and this should return NULL Instead of FALSE now (we changed stuff). I'll get this off to EllisLab to see what they say.

Do you have any unit tests for this btw?
Попробовал для 1000 и 10000 элементов и мутцацией 100%, сложность стремится к n^2 при увеличенни числа элементов, но для 100 элементов и 10% мутации итераций будет всего 10. Подумаю на досуге, как улучшить алгоритм, но для меня этот вариант самый очевидный. После сдачи проекта, посмотрю решения сокурсников.
после else не нужна точка с запятой, и лучше выводы обрамить в {}
UTF-8 is needed because sometimes socket.io is embedded in websites not served with utf8, so it defaults to the wrong thing
Использование будет выглядеть так:

    user.role?(:user)
    user.role?(:admin)

а давайте сделаем чтоб можно было пользоваться так ;)

    user.admin?
    user.user?

то есть в здесь будет что-то типа
    
    [:user, :admin].each do |r|
        define_method "#{r}?" ............

ну идею вы поняли :)
The client is free to send expired cookies, and the server is free to reject them.  You meant to say that the server MUST NOT accept an expired cookie.
strictly speaking, no. It'll just mess up the cursor styling if it can't be found. I'll change that from a throw to a check later on where we set the html cursor style.
fixed it, sorry bout that.
Not a big deal, but these are initialized to `NO` in the `beforeEach` anyways, so it doesn't need to be done here.
Because that allows use to use `+deferredScheduler`.
@dahlbyk are you against the `BareRepositoryException` in general or just in this case? IMO, throwing a `BareRepositoryException` here fits in with other cases where this exception is currently thrown...
here and in other places:  instead of the hard-coded `/site_media/` please rather use `{{ MEDIA_URL }}`
+1 that would be handy
put the statement on a separate line.
OK .. I will remove it
Yes, this one has little to no impact on the theme, it's mostly performances and the decision should be made by the end user
1. 地址和路径统一，都用路径或者目录
2. 既然翻译出了具体关系，相对路径对应的应该是基准路径，而不是父路径
Is this what it's referred to internally?
ok. that was up for discussion.. but nobody replied in the irc so i comment it

On Feb 22, 2012, at 21:33, Ryan Phillips<reply@reply.github.com> wrote:

>> @@ -222,6 +225,11 @@ assert(xpcall(function ()
>>   process.argv = args
>> 
>>   local repl = require('repl')
>> +  utils.useColors = usecolors
>> +
>> +  -- if not (native.handleType(1) == "TTY") then
> 
> I think it should work like this... piping colors to a file doesn't make sense.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/luvit/luvit/pull/133/files#r477482
Shouldn't need to new up a whole `BozoConfiguration` just to get the version. Perhaps put the version reading into a module that both can include.
“… other TYPES of messages, e.g. when interfacing with untyped actors.”
Тело функции поразительно напоминает предыдущую. Вынеси в одно в локальном неймспейсе, в которую уже будешь передавть хедер диалога, указатель на лейбл и не-конст-ссылку на цвет.
Hi Andy,

can you remove the whitespaces around the = sign?
http://www.python.org/dev/peps/pep-0008/#whitespace-in-expressions-and-statements
If you run this a second time it will fail because environment "dev3k" will already exist.  you can either not care if the env exists (see ensure-env-exists which will create one only if it doesn't exist), or use a unique name (see with-unique).
In general, use the `print()` function rather than the `print` statement.
-1 is only needed here as only mf 0.3 allows zooming in this far.
I like it. Let me rework the pull
Please add tests for testing whether moving back and forth betweend org.infinispan.configuration and org.infinispan.config using read() and adapt() works
No, it's not going to work. A recursive search should fix that, I'll implement that in a bit.
i18n対応を行いたいです。
This is not a docstring. Use `"""` instead.
Yeah, indeed I have a real passion, only limited time. Is there any time after which it would become too late? Is it ok if it takes me around a month?
What is the `None` argument?
The extra parenthesis here shouldn't be necessary.
At some point we will need something similar to the page object model. Perhaps an 'app object model'? This could include the necessary helper functions to launch the app, etc. If we implemented one here, we could include a launch and search_for method that would considerably reduce duplication.

    def test_search_foo(self):
        marketplace = MarketPlace()
        marketplace.launch()
        marketplace.search_for('Lanyrd Mobile')
        ...

We can then also use this to separate the tests from the locators. For more complex applications, we could even provide more familiar page objects as properties of the application object: `marketplace.home.click_login()`

With all that said, this would be a fair change, and in the interests of adding coverage I would be okay (if somewhat uncomfortable) with a certain amount of duplication for now.
As above regarding the return/assert.
I like naming event handler functions with an 'on' prefix and the event
name with only the first letter uppercased.
Yeah to switch between the views.
Should we skip the qsort and bsearch calls if there aren't other transactions in the system (or fast-path them if there are only a few)?
Do most applications run in snapshot or read-uncommitted mode?
So - uv_cpu_info is doing it wrong. The problem is that RegQueryValueEx maps to either RegQueryValueExA or RegQueryValueExW, depending on the setting of the _UNICODE directive. If you want to use RegQueryValueEx you should also encapsulate string constants in _TEXT. But don't. Just use the wide-character variant (RegQueryValueExW).
once we get a cross platform buffer in luvit then we can.
Please use dirname(__FILE__) here as well.
We have looked with David L on this - not merged yet (just started merging Appcelerator's changes with our Macadamian Branch) but actually they didn't touched this urls. So they are just broken urls.
I reverted back my changes - so If something is broken for other platforms it will be broken also for BB.

About writing an email to them - I just don't aware exactly to whom I should write it. Maybe I will wait to find and collect all the issues and will write a general email after the whole code will be changed once.
isBlackberry is not used anywhere
Should :class_name be a String or Symbol? 

If both work, I'd vote to change all to Symbol. But if I remember correctly I've changed to String because Symbol didn't work. 

I can be wrong though.
I'm guessing pubsite maintains its own concept of the "owner" of a package independent of any owner metadata in the package's pubspecs, right?
The require_once call, which is the line on which I commented
you can actually just set it as `npm install` and it will install all the packages (don't need to break it up)
@"_def_ns" should be at least kGDataXMLXPathDefaultNamespacePrefix
Jepp! Done! :)

On Sat, Sep 22, 2012 at 4:57 PM, Jari Bakken <notifications@github.com>wrote:

> In puppet/modules/munin/manifests/master.pp:
>
> > @@ -0,0 +1,49 @@
> > +class munin::master(
> > +    $package_name = $munin::params::server_package_name,
> > +    $common_package = $munin::params::common_package_name,
> > +    $package_ensure = "present") inherits munin::params {
> > +
> > +    require hdo::backend::apache
>
> Kan vi bruke require apache i stedet? Så slipper vi å dra inn hele
> HDO-backenden.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/holderdeord/hdo-puppet/pull/1/files#r1667707>.
>
>
Oh noes !
I don't think this is necessary? The adaptation to IPrimaryFieldInfo will return None if there's no primary field, rather than raising TypeError.
Couldn't this just be `tracker.models[model[:parent]]` ?
please add a docstring here explaining what this examples does and how it is different from ldc_2d.
An error, not a warning, right?
Does this actually work? Typically options (`--foo`) are passed before arguments (`bar`).
@michaelklishin, no worries. I was curious whether I'm missing something or it's you trying to make things super explicit. I got my answer :) Great PR anyway!
That wont solve my problem.
Again my problem is that I have 2 classes for password form (UserPasswordForm and UserNewPasswordForm), and they are almost identical (only labels and requier field are not the same). But I want to have only 1 class (UserPasswordForm) and that AccountForm would inherit from it and just change labels and requier field (UserNewPasswordForm would then be unnecessary). I tried overriding AccountForm's __init__, but with no luck.
I guess I moved too much. Do I leave `updates_url` here? Otherwise there is trouble.
`channel` -> `Channel`, start with capital letter.
`full_location_uri` -> `full_post_uri`.
This is why you put required to false and should take care of this. No?
No, we said that we will regenerate it on user disconnecting from the website.
Ok, no problem. Given that will be just a simple list, where and how to display additional information of the venue?
Sounds like we have the same data (the asset id) represented in two different ways depending on the type of computation (asset["assetID"] if scenario, asset.asset_ref otherwise). Wouldn't be better to have the asset id represented in the same way across the calculators?
Add:

#include "SpellScript.h"
#include "SpellAuraEffects.h"
On a side-note, it could be nice to have a demo using the infinispan dataprovider, using clustered indexes too, and configured to offload to Cassandra via CacheLoaders.
LzoBaseLoadFunc used it so I assumed it was okay.
In fact change there was intended to highlight difference between promise resolution and fulfillment.
Looks like github uses a smaller tabstop.  The file is laden with tabs and I wasn't going to fix that with this request because it would make the diff harder to read.
Have you notice any impact of using `rgba()` vs `rgb()` or `HEX` colors ?
The timelines can have LOOOOOOOTS of these elements.
As serveCache and cachePage have to be "in sync", I *think* I would rather have them in a single object (something like cacheHandler or similar, as opposed to two functions). That might make reusing the code in _defaultServeCache and _defaultCachePage awkward or impossible, so I'm not sure.

Also, from the implementation it seems you're only caching the response body? We should definitely cache the headers, too. They might be crucial for some testing (but then again, if we cache headers, we can't uncompress the response bodies... or we have to kill the Accept header from the request before proxying it).
The main reason for dividing this into two functions is the simplicity with which these functions can be rewritten because as they are as short as possible it is much easier for a user to change them and thanks to urlToPath() they are almost independent (in the sense of being "in sync"). This allows tricks such as when the user rewrites the writeToCache function with 'function() {}' and gets a cache that serves only already saved files, which I found also quite useful.

You are right that caching headers is important too, I just didn't realize that. I would like to see them in a dedicated file with the same name as the main (body) file but with a suffix ".headers" (or maybe ".headers.json").
Inconsistent style.
That's right, here's a good fix : https://github.com/rstacruz/jquery.transit/pull/77
standard notation for variables is k_xxx, k_vars or k_exogs   or maybe explicit k_exog_all
Are there any tests that make sure yozioProperties and externalProperties are sent out correctly?
gotcha. done.
I will try to switch dynamically on what event kernel support and file a follow up issue.
These changes are confusing.  You've got commented-out direct setting, then moved the @Resource from the field to the setter.  What's going on here?
So i never actually manually removed this.  I'm not sure how it got removed.  The funny thing is that when i tried to add it back, it wasn't in the list of .net assemblies and realized because the project type was "client framework".  It compiles just fine without it.
[True](https://github.com/MagLev/maglev/blob/master/etc/maglev.demo.key-Linux-x86_64#L24)
Not a fan of Thread.sleep(). I have a very similar situation in ImapIdleChannelAdapter where instead blocking the thread I use scheduler. You submit the task to a scheduler and than the task itself has a reference to a scheduler so its is able to schedule itself, etc.  . anyway look at org.springframework.integration.mail.ImapIdleChannelAdapter.ReceivingTask
le 2eme commentaire n'est vraiment pas clair. j'ai pas compris ce que tu voulais dire
This seems a little OTT. I don't think we should stop someone's application from starting because they haven't configured Evenitron correctly.

I'd flip my shit if a third party library stopped my site from working because I hadn't configured it properly.
When do you use metadata vs include_reciep?
So you don't get an exception if you try to use it in the month or year template - but I guess that's what `page_type` is for so I could remove it.
On Sat, 18 Aug 2012, Hannes Magnusson wrote:

> > @@ -20,7 +20,21 @@ static mongo_connection *mongo_get_connection_single(mongo_con_manager *manager,
> >  	hash = mongo_server_create_hash(server);
> >  	con = mongo_manager_connection_find_by_hash(manager, hash);
> >  	if (!con) {
> > +		struct timeval now;
> > +
> > +		gettimeofday(&now, NULL);
> > +		/* Check when we last tried, if it's not more than ping_interval secs
> > +		 * ago, then we simply don't bother. */
> > +		if (server->last_try + manager->ping_interval > now.tv_sec) {
> > +			mongo_manager_log(manager, MLOG_CON, MLOG_INFO, "get_connection_single: skipping connect as we last tried at %ld, now: %ld, time left: %ld", server->last_try, now.tv_sec, server->last_try + manager->ping_interval - now.tv_sec);
> > +			return NULL;
> 
> Don't you need to free hash?

Good catch - fixed.

cheers,
Derick

-- 
{
  website: [ "http://mongodb.org", "http://derickrethans.nl" ],
  twitter: [ "@derickr", "@mongodb" ]
}
I mean, the way it's coded _every_ possible URL will cause disk IO, since every URL is checked. But then you merged the PR so I guess it's fine :p
Please spell repr the way that most people will recognize. :)
I had to convert it to an integer for the CLE file (seems to work for OAE/nakamura) as well
Should be "gone too far"---missing an o. [/nit]
I assumed that all developers added themselves to this list in order to be able to test their changes. I heard on mumble later on that you actually use this config on your live server. In such case you are most welcome to remove this change.
I think that would be good to do honestly and can build upon this.  Here is an issue 

https://github.com/PhoenixPilot/PhoenixPilot/issues/86 :)

do you see anything about this consolidation that would prevent this, other than the openpilot plugin becoming deprecated?  A plugin right now can support a QList of IBoards, right?
This is a function, should be ```assert.equal(stack.size(), 2)```
Remove this extra line break between comment and function.
Лишний  StringBuilder.
Лучше выбирать степень двойки.
String.CASE_INSENSITIVE_ORDER
We could, I guess it would just involve getting the most recent window with Services.wm, maybe that's fine though, it just seemed sketchier.
I don't really care… but you removed a `;`
oh :-o true, just saw it... that what's mean to copy paste :) should be fixed at AMO as well
We don't need that now, the pass is enough
I wonder if we should report an error to the completion handler in this case?
not sure if this will work. Try again
Do you think the benchmark is wrong? This benchmark and the small speedup when using the solution as warm start
https://github.com/scikit-learn/scikit-learn/pull/992#issuecomment-7669632
paint a similar picture. I suspect that this is due to lines like ``R = y - np.dot(X, w)``.  I'll look into it but I want to finish other stuff first.
Please add assertions on content of the other fields too.
I'm seeing a lot of this troika: semantic, resolveProperties, ctfeInterpret. I think it deserves its own abstraction.
gem versions should be fixed going forward.
> I don't want to block the pull because of that; having sync Tika is better than not having it. You think a subsequent improvement could be possible?

+1 

Otherwise it is probably a good idea to think about an async approach. IMO we can cover this in another issue.
Can I have a version that takes an ITypeInfo too?
No clang ?
eek, that sounds like something that should go in 3.8.x if possible..
What is 5? Are we removing lemur/ prefix? Maybe it could be more explicit
@shacker Can we just do `var $campusNewsContainer = $('#' + tuid)` here?
@yuhunglin is there a reason for this change? I can only see a whitespace change in the `loadDummyCourses` function
goober.
must have copied it from somewhere.... :)
Yes, I intend to submit a rewrite of the example as a new PR after this is merged. On that note, would you mind adding plot_otsu.py back? (I think they deserve separate examples). If you're in the parent directory of `skimage`, you can run:

    git checkout abca94e16fb018033f9e2343d16e463c6cc5311e doc/examples/plot_otsu.py

This uses the hash for the commit just before your PR.
ps: sorry for making you look at loads of whitespace changes.
We should use CDI to inject a CDI bean, not this hacky lookup from the session which relies on JSF implementation details.
please remove the trailing whitespaces. Empty lines should be really empty
Maybe a little nitpicky (as if the rest of my comments are nitpicky enough already!) but rather than saying "This flag is only valid in 2D and Columbus view modes" we should say "This flag only applies to 2D and Columbus view modes".  It's valid in either state regardless of the mode, it just doesn't do anything in 3D.
Same comment as above.

Also, the comment is wrong.  This is not expected constant time.  It is o(n) where n is the number of unique width / outline width pairs.
I was happy, but since this is going away, I don't care either.
In my opinion, lookAt in 2D would take the eye and rotate it about the target so it's directly overhead, using the same up vector.  This is what I do in DynamicObjectView.js and it works quite well.  I'd rather see that than having the exception, it's extremely reasonable behavior in my opinion and we can document it to make it more clear.
Any reference to it?
Why are we deleting tests?
We actually do need this. onTabChanged is called when first tab is added, but at that point, only the first tab exists in tabhost. We need this to set background color for subsequent tabs.
I was told that text was implemented on Android (as well as iOS), and that was why we had to implement it on mobile web as well even though I was against it. Maybe we should double check with the Android guys.
The colors are slightly different but, yes, it works. I've corrected the next PR. Thanks Bill.
Лучше так и назвать `importance` imp === http://img361.imageshack.us/img361/996/heroesvidcardsinferno01imp4lf.jpg
And ... break. You will be doing it three times otherwise. Or does it return cleanly on a stale handle?
We're starting having too many template files spread in root. Shall we group them in a `./template/` dir?
You just need to add the hook so it can see the pushes to GitHub http://about.travis-ci.org/docs/user/getting-started/
Ugh, this change is still unclear. Reading the next two bullet points my question becomes "What if `promise` is pending?"

Maybe leave fixing this for a later pull request.
That returns a JsonProcessingException
I was surprised when I discovered it worked.
I was wrong. I assumed `is(ElementType!string == immutable(dchar))` but in reality `is(ElementType!string == dchar)`.
Yves, those lines are in your master in this repo: 

https://github.com/y-trudeau/resource-agents-prm/blob/master/heartbeat/mysql#L58
While this SHOULD be protected, it's currently used by DB forge and utility classes and they don't extend the CI_DB_driver class. See [line 1181 of my version](https://github.com/narfbg/CodeIgniter/blob/4c598360d646f734d254d45b397bc26984999f0a/system/database/DB_driver.php#L1181) - it's also good for comparison. ;)
You missed a typo here!

Should be `Requirements`
its the new mysql adapter class in rails >= 3.1.
Yep Ben, we were supposed to. Any chance of editing these to use Mocks ? :)
I guess that's true - if anyone is using a dedicated T.S. today this will break; but they can then set the option on the T.S. So, definitely needs to be in the migration guide.
?? Confused - if they don't use a CCF, the temporary queue that was just created will immediately disappear when the connection is closed.
Thanks for your addition!

I think we should also pass along the $view instance when we call the parent::render().

If you could add that I will merge your pull request.
Planned for the next iteration. This one :)

On 29. 09. 12, at 12:34, Mitar <notifications@github.com> wrote:

> In tests/test_project/test_app/static/test_app/js/datastream.js:
> 
> > @@ -0,0 +1,700 @@
> > +(function($, undefined) {
> > +
> > +    var debug,
> > +        plots = {},
> > +        cached_data = {},
> > +        current_plot_id = 0,
> > +        datastream_location = '',
> > +        restful_api_location = 'api/v1/metric/',
> GHMMMAMMAMFDMS.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Use phpunit.xml.dst instead
title underline must match with title length
this is gross, let's throw out all 'no event' users, and note it once somewhere.
Is this image intended to be linked twice?
I think the translation is ok (but it's hard to see the difference with the used font)
hmm ok sorry if i'm not understanding very well. 

What about having this before the original code, this seems more clear?

```actionscript
if(count != array.array.length / stride) {
	count = int(array.array.length / stride);
}
```

Its checking if the xml parameter count matches the computed count if it doesn't then sets the count to computed count as its more acurate then continues as it did before

so it becomes

```actionscript
if(count != array.array.length / stride) {
	count = int(array.array.length / stride);
}
if (array.array.length < (offset + (count*stride))) {
	document.logger.logNotEnoughDataError(accessor);
	return false;
}
```
Ahh that was my confusion. It looks like the `responseInts` function writes out the prefix number in `libril/ril.cpp`. Thanks for the clarification!
I don't understand the intention of adding a `get_all_fields` what am I missing?
Well, that would require going through every single one of these again, which is something I had hoped not to have to do. I will if you really want it changed, though. Otherwise, maybe you could open a new ticket for it.
This is not used. instead I get an error because shootDelay is not defined. Why not leave this ``shootDelay``
Do not use yoda conditions.

```php
if (($locale = array_shift($localeList)) === null) {
```
This line should be:
<pre>
charset_error: {'strict', 'ignore', 'replace'}
</pre>
Also, I suggest to replace 'strict' by 'raise', to match numpy.seterr.
this class is huge. over 1000 lines. can it be broken down?

method signatures have different formatting throughout the file.
formatting is inconsistent in general and needs a thorough scrubbing.

it is really hard to follow the logic of what happens in here.

i think we need to do some documentation.
^^ pretty sure you don't want the tokens in here
You've convinced me.

Would it make sense to open a new ticket to test that case of 2,000 patients and, er, however many procedures you'd expect for 2,000 patients, with an eye towards reducing that runtime?
Sure. Thanks :-)
I really need help here. Please, tell me description of the function, `$with_me` parametre and return array.
Не, переменную удаляй полностью. `fnWrk` будет биндиться как `this`. А в самой функции `_findSync` надо поменять аргументы местами, чтобы они совпадали с `_findWrk`.
I guess leave it in, you'll only see it when debugging any way
This is a good catch.  Using `fudge` here instead of `Fake` directly makes it more clear what's being used.
**Cupones
This is a lot more friendly than the function above, and already contains the necessary parameters for logging in. Some developers may be confused as to what should be passed into the function above.
Your added lines will not worksin 2.0 the prototype works only with :

prototype = prototype.replace(/\$\$name\$\$/g, type_collection_{{ field }}_nextId);