labofsahil/github-event-dataset-2012 huggingface dataset:
Yes, it's ok as long as the values from D do not end up in places where A is supposed to be used. C++ cannot guarantee this, and it wasn't clear to me on first reading the code that the extended values were local to one function.

Anyway, it seems that you have a good reason, and the extended values are local to that function, please add this in the comment. Just "c++ does not allow this" looks like you're hacking around something :)
It was in from the very beginning, didn't ever touch it.

See: https://github.com/bitcoin/bitcoin/commit/7d145a0f591dab109eae9adcfaf59303cce0431a#L10R63 which is commit from @TheBlueMatt
But you allow signing of non receiving addresses here, no?
as @ADmad and I pointed out, you need to respect the coding conventions. too many whitespaces here inside () for example.
Should be `if (` and `) {` Also no spaces around function arguments.
I found out on my end that this is way too low, 16k ish is about how big the routing table dump is so 20k should be ok, I'm using >65535 now but python has some weird problems with long strings so I had to decrease the dumpTable output length
Can you also document or explain this as well? This code is awfully complex and I had expected task dependencies to be a fairly simple task, so I'd be great if you could detail your approach and how it works for us.
Duplication in specs doesn't need to be removed as mercilessly as in the main codebase, however these three all being exactly the same is possibly grounds for removing it. Consider using a shared example: https://www.relishapp.com/rspec/rspec-core/v/2-1/docs/example-groups/shared-example-group
account for never receiving first ping, in which case last_pinged is None
Thanks, that should be fixed in the next commit.
That's fair, but I just don't like the idea of creating objects for which str(foo) will fail, which would be true without this code.

For instance:

```python
lz = LazyEvaluate(lambda : u'é')

print lz # gives UnicodeEncodeError
```
Charsets.US_ASCII
nope! no starting in constructors!
First, **choose which** connection
This whole idea of a modal should be pulled out into another function that could insert the modal HTML.
should be `{{ _('Showing') }}`
Two minor things. Remove the spaces around the `=` (python coding style convention) and add the `-` back before the `%}` (used to collapse the whitespace.

Other than that this should work! Fix those two minor things and we'll land it. Thanks!
Out of curiosity, why'd this go from 22 to 3?
it's to be consistent with the line about @fligtar's mom
This is awesome - I gotta be "that guy" though and say it should be str_to_bool() to fit in with the rest of the helper functions. Same with no_parse.

Consider this merged though once the names change.
Isn't it used to be 'if (false)'? o_O
the formatting is confusing here as the argument of strtoupper is on 2 lines. I first thought that strtoupper was only applied on the condition of the inner ternary operator when looking at it
The naming is wrong. This method does not parse a template (which would imply returning the parsed template). It validates a template.

And you should typehint the arguments
no need for extra spaces here
well, keeping them in the builder is good indeed. But for the node, I don't think it is needed as they are never called (the builder already handles putting the info and the example in the attributes).
Yes, but is that preferred? and do you want them on one line or wrapped for each variable.

```php
<?php
unset($var1, $var2);
unset(
  $var1,
  $var2
);
``

Or some variation.
Isn't array_map more appropriate here ?
I knew I forgot something. Thanks. :P
Whooops. Saw right now that locale can be different than `en`. Only the error seems not adequate.
@fabpot what do you think ? Should we use Reflection to avoid false positives with ``method_exists`` ?
I used type-of to get when value is `default`, do you think is better use `$value == 'default'` instead?
This definitely needs a reference to the charset encoding.
Thoughts on deleting the `begin` and `end`, then indenting the method's contents two spaces to the left?
to stylus ke nemikhad quote bezaram khodesh to khoroji css mizare
use world.getMaxHeight() for y axis :)
why ``lambda: SortedDict()`` instead of just ``SortedDict``?
We're using camel case throughout Flame, so this should be `propertyName`
These lines happen if the datalist and session save successfully, they dont wait for all datum to get imported before adding the data list to the user and corpus. this make sense to me,
argh problème d'encoding...
This is correct. Options represent the current state of the widget.
I just changed this in master, so you'll want to make sure you get the changes from master when rebasing again.
Uncommenting that line removes all the gradients from the css, so it makes the keyboard work better. I would suggest use that CSS while the "Gecko drawing bug" is not solved.

Anyway, totally agree that this line needs some comments :)
no special reason, it was just difficult for me to see it on the screen. I can change it back if is better the UTF-8 char
Yeah, this should just include the files in the root directory. I used some logging to verify this.
Does this mean notification....?
you should create an l10n entity for the `.textContent` value — define 'any' in settings.en-US.properties and do:
```javascript
option.textContent = _('any');
```
Will we need a translator to add these the other locales as well?
facepalm saw it down a few lines...
I don't know why the grid should define this listener. IMHO when an icon calls to renderDownloading, it should listen to 'downloadfinished' event and then it updates the icon or whatever and remove the listener. So we avoid several loops and exposing more methods in Icon class. What do you think? Icon knows how to update its icon in my opinion.
Ismael told me to put strong ....
`compatibleAPN` is undeclared here. Moreover, please address the parseInt issue for the mnc code otherwise It couldn't work even having the data we're fetching in the apn object.
Same comment as above about exposing init.
It's actually fine to use. It will break on non-UNIX with no arguments passed, but that's A-OK since I don't imagine this will ever run on Windows :)

Perhaps that might be an option for patching applicationFilePath too.
Perhaps this should take `link.target == 'inline'` into account as well.
I don't think this is needed since I'm using blocks
I plan to rewrite this section of code in a future ticket because it does not function the way I want it to, so I made a TODO comment there for now.
Wow, that's a bit embarrassing. I'll try to do more proofreading of the README after adding things from now on.
Looks like some whitespace got inadvertently introduced here.
An absolute sourcestamp is one that does not specify a revision of `None`.  It has nothing to do with whether it's in the database or not - in fact, that distinction isn't very well handled anyway.

I don't mind having an explicit "write this sourcestamp to the database" method, which does nothing if the sourcestamp is already in the database.  I *do* mind having a method that looks like it serves that function, but actually writes a *different* sourcestamp (with the same values except for sourcestampsetid) to the database, and/or modifies the in-memory sourcestamp in place.
On Mon, Mar 26, 2012 at 12:44 PM, Tom Prince
<reply@reply.github.com>
wrote:

>> +    def __init__(self, miss_fn, max_size=50):
>> +        super(AsyncLRUCache, self).__init__(miss_fn, max_size=max_size)
>
> We don't use super in buildbot, so this would be `LRUCache.__init__(...)`

Fixed.
This list of changes can sometimes get quite large -- it might be better to give Python the opportunity to sort in place with `changes.sort`.  Really minor, I know!
I wonder if it is worth abstracting this logic?
does it really need to be public ?
making private code public/protected
Write: protocol = QLatin1String("icq"); as it's faster, then just using constructor of QString
Was an override that was no longer needed in this controller as we are getting all tags in the ContentApiClient class
I've added read and exucute/search by group
Why does unchecking stop event propagation but rechecking allow event propagation?
casper wraps the phantom api, so I assume that it just uses whatever page is associated with it. 

Like i said, a Hack. That's partly why I closed the pull request, I'm concerned with the direction/quality here.
childs should be children
I think this belongs in "window/utils" instead
Opened a new issue to explore this: GH-1421
we left in an unnec pass arg to complete_user_creation lower down in this file...  let's fix it...
It seems like these three lines duplicate the above `headers` variable, and only the latter is actually used?
wah camelCase is so ugly ;)
I would remove the extra `currChangeset` variable and pass in the current changeset directly. Have you thought to make that method a property instead? Would be nice to get access to it via `nightly.changeset`.
Should be ``AMQPExchange::bind($exchange_name, $routing_key = null, $flags = AMQP_NOPARAM)``
Better to say "This method" instead of "Factor.json?". And it either is, or is not a lightweight way to check. Suggest changing to

"This method is a lightweight way to check if the JSON feature is available". Or simply "Checks if the JSON "feature" is available". (What is the alternative?)
This name isn't great - it doesn't silence a backtrace, it expunges some Puppet related content from it.  You should make sure the name clearly reflects the behaviour.
I'm trying to parse this logic, but having trouble. Is the `!expectation.called_max_times?` part still required?
Thanks, I just pushed a slightly different version of what you suggested.
Can we add one more example here? "Rails" is obviously a framework gem - what's another one? Sprockets?
No. I added the merge function to allow to override/add some filters/validators, for instance for all HTML5 elements that had pre-defined filters/validators. This is called only when the input filters are created, so this occurs before any filtering.
This should be `[0-9][a-f]`
call to isValidPort should be enough here if not maybe we are having a bug.
Perhaps we could move the part inside the if, as well as the code in the else-part to two separate methods. This would allow someone  to override specific behavior more easily.
On the name itself; I believe this should be DbTableGateway rather than TableGateway.
Is correct
The problem is parts like ogre take the finished path and just stick a filename on the end, regardless of ending slash or not.
Converting a str to a unicode is what can raise UnicodeEncodeError...  If the message parameter contains bytes > chr(127), you need to specify an encoding, or UnicodeEncodeError will be raised (before PtDebugPrint, which I'm assuming takes a unicode parameter, gets the string)
Although valid python we always put a newline after ```else:``` blocks
On Tuesday, April 17, 2012, RonnyPfannschmidt wrote:

> > @@ -5,32 +5,29 @@
> >
> >  from .version import version_info, __version__
> >
> > -try:
>
> that catchall import error broke debugging on a regular basis
>
>
ok. rest of the patch sound good but need to test it. will do that later in
the day.



> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/benoitc/couchdbkit/pull/128/files#r695478
>
this is wrong. The first argument is a Package entity, not a composer package. This will simply break all updates with a Fatal Error
Small note

The comment in the tests should be the success condition, not a failure message, they show up with passing tests as well
@vesak Tässä on nyt virheellinen teksi. Pitäisi lukea ehkä näin: Tuoteperheiden lapsituotteille ei lasketa asiakashintoja eikä -alennuksia.
@vesak Ai saakeli. Nyt tarttis ky kommennteja kehiin koko tähän iffihässäkään.
``.keys()`` is useless here.
Also, missing space between `!`. It should be ` ! `.
Why did you change to `STDOUT`? Also this should be in an environment file, like `development.rb`
Injecting the container is generally a bad idea... If you need it for getting the legacy kernel, just inject the legacy kernel instead :wink:
Spacs everywhere.
Finds.
Two spaces before inline comment hash
This file should also get `_` out of the deps Object.  It's not technically needed, but Underscore is used here and we might as well keep the files consistent.  It's also a tiny bit faster to have `_` local and not have to look it up in a closure.

I'll add this after merging.
I don't understand this one: -g creates a directory for a new module from a template
Because it's not an OK status. This is a little bit pedantic, but we should get used to not sending `200 OK` if things went wrong. `400 Bad Request` is really a better response for form validation errors, and we can file bugs do do this more consistently.
Please use (4) spaces, not tabs.
Also, PEP8 is complaining about the extra whitespace at the end of this line.
No problem... should be quirb@hotmail.com
I wonder if it would be worthwhile moving a lot of frame and UI lookup logic out of the actual test case into separate Python classes that could be reused. We could take care of this refactoring in a followup though, since it looks like a lot of the test framework code already written follows the practice of intermingling the UI logic with the actual test.
added
```
super.preStart(reason,message)
```
Shame on me for this :-)
Readability. I dislike function calls in conditionals especially since it's returning the session id and token from it.
Curious why the change in convention?  I had previously tried to use dashes vs. underscores to denote different aspects of the name.  Where underscores connected an entire conceptual entity and dashes denoted a different property of the entity that could vary (as the grey and black did).
This will fail unless you have pro, right?

I'd add
```
Background:
  Given I am using Nexus Pro
```

And then in the implementation of that step, stub out the calls that get the version to make them pretend to be pro.
Looks like this used to be part of the variable declaration? The comma should be a semi-colon, and the variable below needs declaring.
Change "$accion" to "$action", don't use spanish!
It actually takes less space then before as it is on the same line as the logo.
As for hiding it.. I guess it is soon time to spend time on making it what it was intended to be, an informative block that would tell you about new versions or patches being available, and that is something we have to solve across all editions.
According to PSR1 it is.. https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-1-basic-coding-standard.md
We do not currently use it and there is definitely a case for deleting it. Doing so now.
You _probably_ want to use delegate instead of $.bind() (which is what click and hover shortcuts really are). Also, I think the each on _everything_ is pretty expensive too.
As per [ID and class name delimiters](https://google-styleguide.googlecode.com/svn/trunk/htmlcssguide.xml?showone=ID_and_class_name_style#ID_and_class_name_delimiters) referenced in style.css please use `-` as the delimiter **except** in cases where you are using the twig template page class names as they require by default `_` as a delimiter. *See line 625 of style.css for example*
Cool, not a problem.  It's a great, useful, and much needed set of changes.  The new options object is especially great.  

After just a couple of cleanups, I'll merge it right in.
I know, but i like to think that the html can be parsed as xml. Why drop that rule, but still quote attributes and such?
Hardcoded python env can be replaced with:

    #!/usr/bin/env python

To use python from the activated enviroment
met une majuscule
@cprice-puppet  leftover debugging?
These all need docstrings that at least mention the behavior when the verification fails (what gets returned to the client). Could also use a precondition on `content-type`.
This one already seems to use CONFIG.keyspace, so name can probably go
As a side note, we probably want to find a way in which we can add nodes without having to restart all app nodes. Not sure if this is a big issue though, and we'd have to do the same for cassandra.
This should use the default set in the config files.
I was actually thinking about a ``EclipseGlobalIndex`` that should be used in place of the ``GlobalIndex`` (hopefully, you can enforce this at compile time), and the assertion could be part of its constructor. I believe this way you could defend yourself against improper usage.
Admittedly, the comment is incorrect. Will fix it.
Better to use the logger.
Same thing here [namespace, ...,] key, value
the code from 522 - 540 makes sure that there is at least on argument. The while loops the checks for any additional arguments. Perhaps I could have used a do while loop...
Accidental apostrophe added here ;) Am testing it locally now just to be 100% sure and will merge it then.
`elseif`.
Could you just remove this comment? The rest looks good. :)
I'm with @derekjones on this one, even though I'm not that concerned with how it affects parsing. It really makes it harder to read and a 4+ line comment block for 1 line of code just sounds like a waste to me.
попробовал if (length<=0) [NSException raise:@"Неверная длина ДНК" format:@"Длина ДНК должна быть положительным не нулевым числом"]; и все равно получаю результат http://d.pr/i/AzSt а хочется пользователю показывать только сообщение об ошибке и ничего больше.
Почему Вы не создали данную переменную как @property, мне кажется это упростило бы код? У Вас бы были сеттеры и гетеры, а также доступ к переменной. Вместо описания доп. методов в классе в тексте было бы [[self DNA] метод_массива].
Он заменяет строго X процентов, но заменять на тот же елемент или на другой не сказано.
What you've removed is the data folder in the Rails app root, not the db/data folder. I don't think anything db:populate related was ever Git ignored, so you should be fine by keeping the file as it was.
For Bridge to support SpoutPlugin, there needs to be no nms code in org/getspout/spoutapi, move that to getspout/spout :P
Slight concern over use of empty() again. It's such a blunt instrument.
What about some naive caching? `@links ||= discover_resources_from(@response['_links'])`
i would say: yes! @agramfort : dya?

On 07.12.2012, at 19:02, Eric89GXL <notifications@github.com> wrote:

> In mne/proj.py:
> 
> > @@ -121,14 +121,11 @@ def compute_proj_epochs(epochs, n_grad=2, n_mag=2, n_eeg=2, n_jobs=1,
> >      else:
> >          data = sum(np.dot(e, e.T) for e in epochs)  # compute data covariance
> >      event_id = epochs.event_id
> > -    if event_id is None:
> > -        event_id = 0
> > +    if event_id is None or len(event_id.keys()) == 0:
> So it should be safe to delete this check, right?
> 
> —
> Reply to this email directly or view it on GitHub.
>
yes it was misplace :( let me recomment
There are three empty lines here, but should be 2.
Hmm it doesn't return a token, it just passes it to the requested module activator, but ok I'll hide it in the ModuleFactory.
This must have been rolled back! We don't want ANY changes to be persisted if one of the methods inside a transaction fails.
are these required or optional?
Yes. you're right. For some reason I thought I had pushed a version 0.3 to hackage. Will change...
In fact, `2.0.4` was the first Symfony2 version which uses Composer.
What do you think of :
"When Symfony use the Composer autoloader instead of UniversalClassLoader, you should use the ``add()``"
This is just from converting this file to a directory, and then back to a file. We can convert it to a directory if we have a lot of pipelines in the future.
This is very wrong. Query languages and scope and two totally different things.
hmm, not sure: this will have to be turned into a system property somehow, to enable Jenkins to use it, right?
I would put this in `reader.rb` rather than create a new file, as the directory is already pretty full, and this follows the pattern in other files where models sharing the same table name are in the same file.
On Feb 20, 2012, at 2:19 PM, Sergiu Ivanov
<reply@reply.github.com>
wrote:

>> @@ -4,11 +4,82 @@
>> """
>>
>> class SymPyDeprecationWarning(DeprecationWarning):
>> -    def __init__(self, value):
>> -        self.parameter = value
>> +    """A deprecation warning which can also hold the information about
>> +    the feature to be removed, when it will be removed, and what the
>> +    developers recommend to use instead.
>> +
>> +    This class is expected to be used with the warnings.warn function
>> +    (note that one has to explicitly turn on deprecation warnings):
>> +
>> +    >>> from warnings import warn
>> +    >>> from sympy.core.compatibility import SymPyDeprecationWarning
>> +    >>> warnings.warn(\"Don't do this, it's deprecated\", SymPyDeprecationWarning)
>> +    __main__:1: SymPyDeprecationWarning: \"Don't do this, it's deprecated\"
>
> Thank you for your advise!  I took the way of skipping the doctest altogether, instead of trying to get it pass.  The reason is that, according to what is written [here](http://stackoverflow.com/questions/2418570/testing-warnings-with-doctest), one should either turn warnings on explicitly with `simplefilter`, which I did and it didn't work for me, or one should write a decorator.  I chose to consider that writing so much code just to get some warnings actually caught is not worth it.
>
> By the way, the warnings do show in the output of `./doctest`, but, apparently, doctest misses them.

That might be because they are printed to stderr instead of stdout.

>
> Thank you for telling me about gist :-) I'll use try it out next time.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sympy/sympy/pull/1065/files#r468703
so if it fails to unlink a single file, it returns false? Should we short circuit this and just return false right there? or maybe break out of the foreach?
I've set up a remote of John's master branch on his fork, and then set up a
local branch to track that branch. Seems to work fine. I use Tower as my
git client...


On Mon, Nov 26, 2012 at 11:34 PM, Chris DuBois <notifications@github.com>wrote:

> In src/read.jl:
>
> > +  end
> > +
> > +  # Count the number of lines we've read
> > +  i = nrows
> > +
> > +  # Iterate over lines
> > +  # If any entries violate type expectations, loosen them
> > +  # Don't change type inference for missing fields
> > +  for line in each_line(f)
> > +    i += 1
> > +    if i >= Inf # Used to be 100. Changed to insure that all files are correctly
> > +      break
> > +    end
> > +    fields = split_delimited_line(chomp(line), delimiter, quotation_symbol)
> > +    for j in 1:ncols
> > +      if !contains(missingness_indicators, fields[j])
>
> What's the best way to try out the latest in this branch using Pkg? I have
> been using `curl [url of patch]; git am`, but I am curious how others are
> doing it.
> … <#13b4024bf3bf4d47_>
> On Mon, Nov 26, 2012 at 8:28 PM, John Myles White <
> notifications@github.com>wrote: In src/read.jl: > + end > + > + # Count
> the number of lines we've read > + i = nrows > + > + # Iterate over lines >
> + # If any entries violate type expectations, loosen them > + # Don't
> change type inference for missing fields > + for line in each_line(f) > + i
> += 1 > + if i >= Inf # Used to be 100. Changed to insure that all files are
> correctly > + break > + end > + fields = split_delimited_line(chomp(line),
> delimiter, quotation_symbol) > + for j in 1:ncols > + if
> !contains(missingness_indicators, fields[j]) Good idea. Changed. — Reply to
> this email directly or view it on GitHub<
> https://github.com/HarlanH/DataFrames.jl/pull/73/files#r2231136>.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/HarlanH/DataFrames.jl/pull/73/files#r2231168>.
>
>
same for array_keys http://twig.sensiolabs.org/doc/filters/keys.html
Please hold while we transfer your comment to an associate. Your comment is important to us.
We should avoid using singletons
Vladimir, could you make one more tiny change here? :)
I think this check is too broad, you could write instead assertTrue(e.getCause() instanceof IllegalStateException).

BTW, I didn't notice this before, but why do we use AssertJUnit?
I agree. Change the log's method interface to take a plain Exception
Yes, that's the current behaviour here. Only the guessers which are in the guessing order getting injected into the manager (via compilerpass)
Blocks here.
I agree with this change. Just want to point it out to others.
I think this phrasing is a bit confusing.  Is it XeTex, LuaTex, or LaTeX or just the first two?  It might be clearer if it were spelled out as a list.
A suggestion - since you're using this snippet of code in <code>test_that_only_browser_reports_have_browser_icon</code> and <code>test_that_only_plugin_reports_have_plugin_icon</code> create a private helper method that both of these tests can use to generate the list of random numbers.

example:
<code>def _random_range(list_length, begin, end)</code> which returns a list of integers (or in this case indices to iterate over).
Two spaces before the start of an EOL comment.
Same as above - I'd do a wait for condition here until you see the number requested appear in the phone number view you have typed.
Use the standard numpy reference format.
missing break?
Same here use uppercase WPS
Yes it does. @eightysteele this seems to be good to go aside from my one other comment. Should we be concerned about silently coercing everything to 32-bit integers? Can we deprecate other integer types?
James, instead of changing this file, can we overwrite it when we need it?
@nicolaasmatthijs +1
When replacing calls that pass SlingHttpServletRequest I've had to include Authorizable as a new argument. The request object is often used to obtain the remote user String and a Sparse session in order to look up the Authorizable for the current user. This addition to the POM allows the user of Authorizable in those calls.
These were opportunistic fixes to javadoc that is mismatched with the methods it decorates.
清楚掉测试代码。
Well, for ``file_put_contents``, the comparison is strict because it returns ``false`` on failure and an interger on success. And ``0`` would be wrongly detected otherwise.
But for cases where it is not needed, Symfony does not use such checks against booleans. See line 239 of the file for instance: ``if ($this->verbose) {``
Same reasoning behind having category translation element tag as "translation_title" as opposed to title :).
We already have an element with the tag name "categories".
Spacing before 0x04
updated .less file with comment for better documentation


On Wed, Dec 5, 2012 at 4:12 PM, Philip Schatz <notifications@github.com>wrote:

> In css/ccap-biology.less:
>
> >    > .title {
> >      display: inline;
> >      color: @tuscany;
> >      font-weight: bold;
> >      text-align:center;
> >    }
> > +
> > +  & img {
> > +    margin: 1em 0; //override auto  left/right margins from base
> > +    max-width: @page-width !important;
>
> Can you comment why this needs to be !important?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Connexions/oer.exports/pull/33/files#r2328076>.
>
>
The comment indentation is wrong (I believe plain spaces should be used instead of tabs).
This line is very oddly aligned. will both ``__module__`` and ``__name__`` possibly contain ``gearman_jobs.``? If not, why not just apply the replace to that part.

Either way, please don't indent four spaces in from the hypothetical equals sign position :)
`count` is costly, better to check `(not (empty? ...))`.
What is this supposed to do?  It doesn't look like anything happens if you click on this button.  Did I miss something?
Maybe change it to camelCase now we're here.
It's still weird though.. because all other methods are added with `Object.append` as well, which boils down to simply `element.set = function...`. So why do you have to delete `_fireEvent` manually, but not any other method..
I think removing this check will cause issues with the importer wicket ui as i remember putting it in explicitly. It really needs a test case but basically there are points in the workflow in which the importer blindly assumes a geometry exists. Be nice to have a test case for this.
\z over $?  shouldn't ever matter, but...
Which code exactly have you used?
`panels` module is on the same level as `frontend`. So better name could be `piplmesh_panels`.
The second one is already solved. But the first one I don't understand. How would request fail afterwards? Aren't clients updated when the request is successful (when the post is in the database)? And what is this post_list exactly?
There is a more suitable class-based view for forms.
Well, both the official `` and our `` contain `get_user`, so `super()`, I think, would call only the official implementation because of the Method Resolution Order (MRO) of Python's multiple inheritance. I've actually searched for it, but couldn't find a way to call a specific method from the second parent.

I found only people saying the way I did it to be the only way:
http://stackoverflow.com/questions/7415974/better-way-to-access-super-class-method-in-multiple-inheritance
Name it `browserid_profile_data`.
Yes, but we will deal with this in some other ticket. (You should leave something also for others.) Use `:contains` for now.
`h_language`? What is `h`? Write verbose/full name variables. Or don't. Here it would be much easier to read if you would have:

```
for horoscope in HOROSCOPES:
    if language == horoscope.get_langage():
        ...
```
Then remove this class if we cannot set size.
Move this import to the top. It is system one.
On the other hand, [Random.Next](http://msdn.microsoft.com/en-us/library/2dx6wyd4.aspx) seems to accept only Int32. A solution would be to use the [Random.NextBytes](http://msdn.microsoft.com/en-us/library/system.random.nextbytes.aspx) for that..
This span tag is missing an end bracket.
executables already knows about the bin dir so you don't need to git ls-files. Especially since there's only one binary file.
Like with my note from line 15 above, I think treating this as a dictionary is a leaky abstraction. Perhaps instead of calling it a key, we can call it a type? So a method sig of something more like
```objc
- (NSDictionary *)metadataForObject:(CMObject *)object ofType:(NSString *)type;
```
or
```objc
- (NSDictionary *)metadataOfType:(NSString *)type forObject:(CMObject *)object;
```
Reference `Doctrine\Common`, not `Doctrine\ORM`.
Accepting **kwargs here makes it harder to reason about calls to this factory without adding much. Can the verify_ssl_cert passthrough be explicit?
Any particular reason for this plugin to be defined in both the pluginManagement section & the normal plugins section? I feel like this is unnecessary unless you plan on having other subprojects inherit from this pom.
Done in e67bea5
> it was suggested that we break hard

I hope that wasn't me on a bad day :( Anyway, its out of scope for this PR. I will open a todo issue for it shortly.
What about these comments?
why did you shift this? it looks nicer if brakets are aligned
Sure, we can, but `ruby-cldr` [uses](https://github.com/svenfuchs/ruby-cldr/blob/master/lib/cldr/download.rb#L15) exactly the same command to download CLDR, so we're already bound to using `curl`. The reason why I decided to use it as well is that it prints nice progress while downloading. Only developers will use this code, so I don't think there's much to worry about, unless you're going to update resources files on Windows.
@stof, I was not wondering about the ORM but which version included the Selected interface. I know the implementation in the ORM has been done in the 2.3 version of the ORM.
Empty line between doctring and code.
Move to docstring?
I love that you left the notice intact while trying to deface a website... that is classy
I don´t understand. How are tables and type ahead related? Can you give an example?
On Oct 3, 2012, at 12:05 PM, Mike Jarvis wrote:

> In galsim/lensing.py:
> 
> >  
> > -        # store some more information
> > -        self.interpolantxy = interpolantxy
> > +        # Set default interpolant if none given
> > +        if interpolant is None:
> > +            interpolantxy = galsim.InterpolantXY(galsim.Linear())
> > +        elif isinstance(interpolant, galsim.Interpolant):
> OK. Feel free to edit the doc string as you think appropriate. I don't think I know the thrust of the concern here, so I'm not sure what to write.
> 

Please check the edits that I just pushed.
用 npm init生成的。。。。
I see, the "efficiency" comes in the form of not calling 't = t.getCause();' after 'break' ;) Well, I tried ;) but in all seriousness I am just not a big fan of 'breaks', they have to much of a 'go to' smell ;)
Anyway, i'll merge
If you are going to use 3 a lot, it would be better to put it into a variable.
One can safely call /etc/init.d/apache2 stop when apache is already stopped.

So it should not lead to failures within the script.

Setting up apache2 (2.2.16-6+squeeze8) ...
root@debianpeter:~# /etc/init.d/apache2 stop
Stopping web server: apache2apache2: Could not reliably determine the server's fully qualified domain name, using 10.176.198.11 for ServerName
 ... waiting ec.
root@debianpeter:~# echo $?
0
root@debianpeter:~# /etc/init.d/apache2 stop
Stopping web server: apache2apache2: Could not reliably determine the server's fully qualified domain name, using 10.176.198.11 for ServerName
.
root@debianpeter:~# echo $?
0
root@debianpeter:~#
not sure spec buys us much, there is some duplication.
the larger issue is that jclouds "Template" is really a "ResolvedTemplate" -- and this "PortableTemplateBuilder" is technically a template.  i'd rather move the "build" out and have another class responsible for resolving templates, but that is a jclouds change.
This should really be `cocoa.id` since that what `objectForInfoDictionaryKey` is supposed to return.
Please stop using the terms "callable methods" or "callable functions". We need to agree on a vocabulary before we proceed. We'll use the terms defined in ES5:

* a "function" is an object with a `[[Class]]` of "Function"
* a "method" is a function, when referenced in relation to an object that has the function as one of its properties
* an object is "callable" if it has `[[Call]]` defined

And it's worth noting that

* all functions have `[[Call]]` defined
* non-functions may also have `[[Call]]` defined

Now that that's out of the way, the problem is: "which test do we use in `_.functions`/`_.methods`?"

Filtering the properties by `function(x){ return typeof x == "function"; }` will produce a list of callable objects, while filtering by `_.Function` (the `[[Class]]` test) will produce a list of functions. Refer back to my drawing above to see that the set of all callable objects are a superset of all function objects. 

Now which test do we use? Well, we have to determine what `_.methods` is supposed to produce. According to the ES5 definition of method, the `[[Class]]` test. According to the documentation ("every function property of the object"), the `[[Class]]` test. Either way, this line should remain how it is on `master`, which means you should revert your change to this line.

Is it clear now?
Inspect module is python's inbuilt module therefore not an external dependency.
No `>=` dependencies, please. We would rather this extension not be installable if we upgrade Spree and it includes breaking changes. `~> 1.1.0` would be best for now I reckon.
I think it's a miserable hack, but there it is.
Shouldn't grunt be called here?
please fix the CS. The curly brace should be on its own line
remove line as function has a returntype of void
Das GoogleMapsWidget liefert in BuildHTML(), Zeile 200 öfters ein "null" zurück, was die UI abstürzen lässt (NullReferenceException). Bitte beheben.

Generell: Bitte defensiver programmieren!
В каждом тесте ты считаешь создание HashMap
Docstring should be wrapped to 72 columns.
do this by parametrizing?
Hmm.. this shouldn't be here anymore I think (not related to your pull request, don't worry, just something that came to my mind).
Rename to ``equalize_adapthist``?
> Is it possible to use the weights w if the object is inside a Pipeline or a GridSearchCV?

yes with the fit_params
2012/11/15 Andreas Mueller <notifications@github.com>

> In sklearn/feature_extraction/hashing.py:
>
> > +    non_negative : boolean, optional
> > +        Whether output matrices should contain non-negative values only;
> > +        effectively calls abs on the matrix prior to returning it.
> > +        When True, output values will be multinomially distributed.
> > +        When False, output values will be normally distributed (Gaussian) with
> > +        mean 0, assuming a good hash function.
> > +
> > +    """
> > +
> > +    def __init__(self, n_features, hashfn="murmurhash3", dtype=np.float64,
> > +                 input_type="pairs", non_negative=False):
> > +        if hashfn != "murmurhash3":
> > +            raise ValueError('"murmurhash3" is the only hash function'
> > +                             ' currently supported, got %r' % hashfn)
> > +
> > +        if not isinstance(n_features, (int, np.integer)):
>
> All input validation should go into fit, I think.
> Which is some what weird, as this doesn't need to be called. So put it in
> fit and in __init__?
> The problem with having it just in __init__ is that GridSearch uses
> set_params and therefore would circumvent the check.
>

Alright.
thanks for reviewing!
Same comment s as `X_norm_precomputed`.
btw there is a doctest in the user guide :)
recommended way to do this is `#! /usr/bin/env php`. Reason being that you can not be sure at all that php is available under /usr/bin. It is quiet likely /usr/local/bin or /opt/bin.
C'est plus largement : "Retourne les objets associés au document"
ces objets sont des paniers ou des reportages les contenant

Cette route est un "point de vue" du document
Sentences must finish with a dot and begin uppercase
I did think about that. But I want `:unspecified` to mean "not specified" rather than treating it as a certain version. When you specify a version, it behaves differently, it looks for that version - if there're no versions specified, then it uses unspecified.
Alternately to "make these changes" is we either:

* say "run this cherry pick command", or
* we manage a fork of bosh that contains all the patches we need to make bosh work

Thoughts?
either is ok for me : as you wish
I will just assume that this will work. No chance to test this on windows :-)
The other case where dynamic lookup / late filename resolution should be used is for queries received via the workunit queue.
Is there a reason we should not eliminate fields from dictionaries if they are never referenced? (I think that is what this code is all about...)
I doubt there would be too many.  Simplest thing may be to try it and take a careful look at the warnings generated.
It may increase the size of some serialized data (e.g., maybe sort, although it may already be sending 64bit for that).

It should be a separate commit though.
Around the keyword ``key`` I mean.
Hmm, I didn't see any useful method in the dialect that gets passed the dbcommand? Do you mean a custom driver? I contemplated that and it should be possible. One drawback is that it would only work when the tests are run for a particular RDMBS.
Could include apt prior to erlang, but not necessary.
Check your indentation, please. Two spaces.
If new configs are added, doc/Configure.help should explain them.
Please use the verbatim string below.
The re-allocation is a miss retained from my debug process.
I've fixed it in the newer version.
In newer version, there are two variable related to the probability function:
isProb is used as a switch for the function
prob_estimates keeps the estimated value from svm_predict_probability().
In the title of the Diff Tab I wrote something like "A: ... --> B: ..." to say which revisions are diffed (difference from A to B). Thus, "Save B as" means that revision B will be saved. I am not completly happy with this solution. It is not meant to be final. Any idea how to make it more intuitive?
Kinda means something to the user, in case they go "I wonder what binary planting is" (since the module is designed to leverage that)
Yes, I think you're right and that it's probably fine the way it is.  What would be useful is to show somewhere (in a docstring) how we derive these linear systems. [I wrote it up in Section 5.3, p. 61 of http://mentat.za.net/phd_dissertation.html , but I'm sure you have a better reference somewhere].
@stefanv I used np.asarray, what's the purpose of your change here?
Is this really just for unsigned integers? it seems to be called on signed integers below.
Is this code block the same as above ?
Couldn't you write :

    if (JSON.stringify(doc.sess) !== JSON.stringify(sess)
        || accessGap > this.setThrottle) {
        sess.lastAccess = _lastAccess;
        if (_expires) sess.cookie._expires = _expires;
        sess.cookie.originalMaxAge = _originalMaxAge;
        doc.expires = expires;
        doc.sess = sess;
        this.db.put(doc, fn);
    } 
    else {
        return fn();
    }

I hate code duplication :)
This is all whitespace?
We use shadows elsewhere, but we can't use them here because they would force us to loop over every polyline to check them, when perhaps only a few or no polylines were updated.  I've toyed with the idea of requiring the user to tell us when they update, but it isn't a coarse-grain dirty, we need to know what exact properties changed.  Users will have a fit calling one update, let alone several.

I am in agreement with using `Color`.  There are several places, not just here, that need it.  It's up to you guys if you want to update the Polyline here or wait for a system-wide sweep.
Well, my understanding is that this would be the case for an exception route, for example this [route](https://github.com/danbev/aerogear-controller/blob/AEROGEAR-426/src/test/java/org/jboss/aerogear/controller/router/DefaultRouterTest.java#L127) does not have a path.
We may wish to include a check that `headerViewProxy` is not `nil` here. If it is there may be a crash due to the read/write of `bounds`.
`count` is used in the for loop. Didn't want to calculate it everytime the loop was executed. `i` is reused in the horizonatal layout adjustment below.
Haven't examined `finishTestPass` yet but does it have a way to determine the difference between test success, test failure, and inability to run a test? This might be useful information, especially for debugging.
iOS has the stack of windows for each tab, but I don't think Android nor mobile web has.
Josh, I did not add this! I dunno why I am seeing this here. I dont have this block in my local repo!.
I shall update it with the latest one.
getProperty methods need to start with get. so getIsChecked()
I think it should be @param array|ArrayCollection $participants
what do you mean there was no way to ensure that both the keystone and glance service were running? (b/c they may be on different nodes?)
I wanna refactor this out into its own concern.
I think that we can do some code combination here. For example, something like:

_log = console.log ? log_as("log") : function() {};
A minor point, but perhaps we could use `graph.movablePoint.coord[ 0 ]` here instead so we just store the x-coordinate. No need to store `[ answer, 0 ]` all the time. Plus it will make it backward compatible with previously answered questions!

(and obviously update other references to guess appropriately)
Ah, no, I was referring to the contract of random number generator ranges in general, whether obtained through `rndGen` or not. In my opinion, it would be the norm to call `popFront` after using `front` as part of »consuming« a random value, so that the same value is never used again by any other caller. I don't really know why, but this intuitively makes sense to me, and it also seems to be what `std.random` does.
Hmm. If we went with that proposal, then there would be no point to either `isTrusted` or `isSafelyCallable`, and `isSafe` would continue to do pretty much what it does now (only correctly).

Since this affects a regression for the current beta, we either need to do these changes in away that doesn't change much (e.g. just fix `isSafe` without changing what it does regardless of what the decision with `@trusted` is in the long run, possibly breaking code later if we have to change `isSafe` to just mean `@safe` like this pull request currently does), or we need a firm decision on the @trusted issue ASAP.
Then you have to write`if(config.getBoolean(ConfigKeys.OPTS_DURGM_KICKONDISC.key(), false))`.
Not sure if "style-map" is the most appropriate name for the attribute.
<b>ブラウザの全ての非同期API：</b>ブラウザAPIの呼び出しをDeferredでラップするのは、APIの均一化という意味で、多くの場合良いアイデアと言えます。
You like the arrow anti pattern don't you ;-) 

Pls try to flatten this out if possible.
Because loci.common.DataTools exists in the bio-formats-legacy component, and this class will be in the scifio component, we have to use the refactored scifio common imports to avoid a circular dependency.
`request.xhr?`
To accomodate future members that may be added.
Whoops, stupid mistake. Fixed.
Why is it only possible to supply x and y evenly spaced 1d arrays for the grid? Is this a limitation of the algorithm? It would be very nice, if arbitrary 2d arrays for non evenly spaced grids could be supported like for quiver plots. (nice work btw.)
There is some code duplication between the `switchToOneColumnLayout` and the `switchToTwoColumnLayout` functions.

Can we merge those together and pass in an argument?
Or at least put the same code in a separate function.
Originally I decided to export timing and category information with each line (for debugging and as personal preference)

Whilst this is fully functional, some people do not like the "additional clutter" so decided not to include this in release. I have not removed the code as it could be useful in the future.

If this is something that is wanted it can be re-added reasonably quickly. Most implementation time would be spent refactoring tests.
removed replaceSlashes, so we don't have to restore them.
We should be using mocks and asserting the URL rather than going out over the real internet - won't build without an internet connection that can get to google.
Rebased and pushed
That's just the default - if they want anything other than this, they simply provide their own implementation.

(That's why it's DefaultTcpSSLContextSupport)
like 'singleValue', will change
should this be nullable too?
the wording seems weird here.
Why is it an error? There is an `author_name` method on the `note` model which does exactly what you are doing here and returns the name from the first comment...
опечатка "ля"
I am not sure this class is needed. We can do all the job inside the main ``Admin`` class.
that does make sense, but I guess he is not happy with that particular "if", which is (if you ignore int(...) part) equivalent to if (0 < offset).
Use a method decorated with the [SetUp] attribute instead of a constructor.
Can this go somewhere else?  It's only used in Point, so maybe it could go there.
This pattern is too useful to be stuck in widget specific code.  Can we make it a display util?  Or otherwise generify it?
```
@Produces
public CorsConfiguration demoConfig() {....}
``
We've been adding values to the test conf for each feature we want to flip on or off, so this could be:
<pre><code>
if test_conf.values['test_hostname']:
    raise SkipTest("....")
</code></pre>
I guess we need to decide on how we decide what encoding to use here.
@tomchristie:

1. Should this test using a ModelSerializer instead?
2. Should these tests be put in a different/new class instead?
Yes. I don't know how i missed this
`div.slideshow`
Add `@return array` for teh php docs here
These are external docs please don't add references like "iF"
They don't mean anything to our external customer. You can call it Invocation Framework if you must reference it.
Yes, this is also done in the following.
I think assert is too harsh here. Either don't check it, or use NSLog to warn about it being an invalid value.
May want to stick a Process.waitall at the end of these tests so that the job doesn't keep running past the end of the test.  Not sure if Process.waitall will wait on the grandchild (run_resque_queue ends up forking for the job), so double check that