labofsahil/github-event-dataset-2012 huggingface dataset:
おぉ、大作だ！
質問！なんでnmakeをコマンドラインから使わせるんでしょうか？
sln開いてxyzzy_makを右クリックからビルドする方が楽じゃないですか？
初回ってこれじゃビルド出来ないんでしたっけ？（結局allが呼ばれるのでどっちでもいい気が…）

masterブランチの作業についての是非は何も言わなくていいと思います。
ちょっとこの時点でも初心者を威圧してしまう分量なので（ただこのPRを寄越すのはドキュメントと違いプログラマのはずなので乗り越えてくれるとは思いますが）

Pullリクエストした後も何も書かなくていいんじゃないですかね。
これだけあれば十分以上なんじゃないかなぁ、というか私知らんのもありそうだ(^^;

ちなみにここまでやるならこの一個上のフォルダのREADME.mdも書いてくださいよ、と御坂は御坂は都合のいい事をお願いしてみる。(誰？)
このレポジトリ全体の説明とsrcの中のREADME.md見ろ、って感じでいいので。
ちなみにその時変な位置にあるgen_symsフォルダを移したくなったら移してもらって構いません:-) (調子乗りすぎ？）
This is a nice thought. I might add this functionnality to one of my plugins.
Removing text-shadows on selection improves typography.
Currently Chrome / Safari only.
Thanks eugeneius, This took me sometime to figure out... I did not see anything wrong with the code, especially that it is working for other forms of PUTting..

Once again thanks for sharing 
Cheers
Has
What would happen if you added this style?

.leftPanel ul {
  list-style: none;
}
It would be nice to figure out a more general solution for refinery engine dependencies and migrations.
WebKit*
Rec changing this to 'No Reminders' to avoid confusion with the Messages section below.
any way to contact you off gh?  shoot me an email sometime.
oooo whats this even horde support for horde and alliance in heroic
OnGroupSelected in tree is most likely same as the method for tab. 3 params
That's Infinispan we are using for local cache which make jgroups useless.
It is painful to send FAN_LO or FAN_HI followed by OFF to disable the fan, why not add FAN_DISABLED as well? Maybe it would make more sense to use FAN followed by a mode (DISABLED='a', LOW='b', HIGH='c')
View this commit without whitespace diffs: https://github.com/paulirish/css3please/commit/c45fc97e6ac08ea409e196e7348f3ab6842d7c7e?w=1
I went through all the mantis code, in all the other places it's used in conjunction with date() where a hardcoded format is given. Only in these places strtotime is used to convert *user input* to a date.
I'll go over it again to be extra sure :)
When checking for an empty string, the fastest way is to check just the first character. If it is a null character (zero), the string is empty; otherwise the string is not empty.  Also, I presume you meant to check szUrl rather than szID.

    if (*item.szUrl)  // URL is not empty.

 What should happen if the URL cannot be executed?  Currently I think nothing happens.  Perhaps the g-label should be called so that fallback code can be written.  For instance,

    if (!*item.szUrl ||
        !g_script.ActionExec((LPTSTR)CStringTCharFromWCharIfNeeded(item.szUrl).GetString(), NULL, NULL, false))
        pgui->Event(control_index, nmhdr.code, GUI_EVENT_NORMAL, item.iLink + 1);

Checking `control.jump_to_label` is one of the first things GuiType::Event does, so there isn't much need to check it here.
Жесть недетская. :)
блин. это нужно, имхо, хотфиксом в 1.3.5 включать пока не опубликовали, либо 1.3.6 выпускать скорее.
Yes, I guess it will. Perhaps this should be a string instead. Thoughts?
I've applied all your changes and added an Exception class.

However, I've reviewed your suggestion on using DOM instead but I'm not convinced.

The reason I chose regex is because it's so reliable in circumstances like this.

To achieve what I can do in one line of regex takes about 5+ lines of dom calls and results in something that is completely unmaintainable.

I've looked at DOMXPath and simple_xml xpath, but I don't think it was designed to work with this legacy HTML that Mailman outputs.

If Mailman gave me more of an XML style output, I'd be more inclined to go down that route, but alas, it doesn't, which is why there's a need for this package.
From quick googling it seems that ISE 12.1 should support Spartan 6. Is there any issues with that?

Also, As I understand it, version of the project file can be older then the version of your tool. So even if there were issues with Spartan 6 in ISE 12.1, you still should be able to use ISE 12.1 project file. Is it correct?

See my other comment below as well.
@bhitov Under what conditions does this log message get triggered? Is this for any email or just specific emails (e.g., only for password recovery)?
please required Linux installation steps
Yes it's already added, but not wasted for Linux. In fact I made the new exe for a Linux guy. It's the same binary for all OS.
Stuff like summoning through doors used to be awesome for exploring the world in places never officially intended... still, the fix is true to retail so great job :)
As I said I can confirm it :D all right
Error in comment yes.
Yes it does, assuming git didn't strip it out.
nah, no worries at all. thanks for the opportunity to test it somewhere else :)
Rails 2.3 does not have this...

I'm getting the following error:
```
activesupport-2.3.2/lib/active_support/dependencies.rb:158:in `require': no such file to load -- active_support/core_ext/class/attribute (MissingSourceFile)
```
True for verbose console output, true for silent?
esto es lo unico relacionado con ese bug que he encontrado en 2 dias, y ami en mi server no se me mueren del susto xD. Lo unico podría ser que el DATA empezara en 0 y por eso tuvieran tan poca vida.
My only concern here is that in browsers that do support localStorage, it will never read the volume from the tech. I think the only time that might happen is if native controls were used to set the volume (iOS?). I think what needs to happen is for the defaultVolume to actually be set when the player loads (not being used yet). defaultVolume will read from localStorage. Something like defaultVolume: window.localStorage['volume'] || 1;
https://github.com/aspee/lge-kernel-msm7x27/blob/63b96aa4928af39ed35deb233ae49b55e5a02572/cp.sh
The commit message is a lie. I didn't hide forks in the end :)
this function is already defined on [line 159](#L12R159)
Ach, für das Einbinden der Pluginseiten sind ja die Addons selbst verantwortlich. Daher, damit das so funktioniert, muss das Addon die Pluginseiten über das Plugin-Objekt einbinde, Beispiel siehe [hier](https://github.com/redaxo/redaxo/blob/master/redaxo/src/addons/install/pages/index.inc.php#L64).

Man kann es aber natürlich auch so machen, wie es jetzt ist. Ist nur als Hinweis gemeint.
this should probably be removed. I added it as quickfix for myself because I had signature key check errors
The edit and new partials could be the same one. You can add a bit of conditional logic using `@location.new_record?` for the parts that are different.
Y U NO cache engine.boardWidth and engine.boardCellSize
let me reword that cause that sounded terrable instead of saving in inside of the apk could you save it to say a txt out side of it.
line 918 should be 

ptrEq _ _ = False
Powinienes ustawic metode wybor na booleana, jesli bylo wyjscie z gry dajesz return 1;
W mainie ustawiasz, while(true) if(!menu.wybor()) break;
Tada :P
Looking good!! Worked for me!
You did not actually add the new created typeprompt to the lang.
Sorry for my poor English. But I haven't understood the idea of your post.

Here are my reasons for objc_msgSend usage :
1. I don't know your codebase good enough to re-implement this piece in block style or any other fashion.
2. Hovever,  "objc_msgSend" legally removes annoying warnings and does not significantly change your logic.
and if i remove that part from the Makefile then I get:

```sh
~ sudo make install
make[1]: Entering directory `/home/cordoval/sites-2/phrasea/Phraseanet-Indexer'
test -z "/usr/local/bin" || /bin/mkdir -p "/usr/local/bin"
  /usr/bin/install -c phraseanet_indexer '/usr/local/bin'
make[1]: Nothing to be done for `install-data-am'.
make[1]: Leaving directory `/home/cordoval/sites-2/phrasea/Phraseanet-Indexer'
```
I guess we should have a separate post about the Matlab and R critiques, and not link them here.

-viral



On 09-Mar-2012, at 1:04 PM, Stefan Karpinski wrote:

> I think the second Russian one and the French one aren't straight-up translations but rather actual posts about the language and should probably be in the other section. Thanks for updating this.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/JuliaLang/julialang.github.com/commit/2e396bdf8229b1a01d61b413f117a9de2cbe4519#commitcomment-1064316
"Invalid consumer key" is what I have in my notes. I can test it out again if you need more details.
Ok. It is static because it screws up otherwise.
What error are you catching here?  I would imagine a Key Error on the .get() method.  Could you use a default value?
cast shouldn't be needed here
One return statement per method
I think your version binds the pouting to use exactly as-core 1.2.7.1, and
not 1.2.7.1 and later.  That's why I suggested it. My comment reflects
1.2.7.1 or newer.

If you want older versions, just find out which version you want to
support, and set it to something like...

"1.1 > *"

...hope that helps me clarify.

--
Aaron
On Jan 28, 2012 10:20 AM, "Marco Vermeulen" <
reply@reply.github.com>
wrote:

> Not sure if I agree with this one. By upping the required version of
> springSecurityCore to 1.2.7.1, we are forcing *everyone* who wants to use
> the SAML extension to upgrade to this version. What about others who are
> still using older versions of spring security core?
>
> I would suggest leaving it as it was.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/marcoVermeulen/grails-spring-security-saml/commit/b5b753e0ceca07a6ba12ed719ada6df3bd9904aa#commitcomment-910942
>
Will you add support for Linux 3.2 in Debian wheezy?

I’ve managed to make a stand-alone version of the Console “plugin” as *.deb file, based on instructions from the Heise c’t/iX magazine. I think I’ll write that down and send to you.
Well, creating windows on-demand for iOS is just totally unnecessary when the windows are managed by the ios navigation controller. Each platform has its own way of skinning this cat. In this case, we leverage the most appropriate one for each platform.
Is this the only remaining use of `nuke_memoization`? If so I think we may as well just roll it inline.
This needs a `#` I think. Appears to be causing a syntax error in CI.
Can this binding be done in event handler's _create method?
Remove this line instead of commenting it out.
This needs to be `$extender->getEntity()` methinks.
ah.  useful to keep them in sync? (obviously this wouldn't stop this commit which you've already committed :-))
Okido - I'll make the necessary changes and add them to the pull request then.  Thanks for the feedback!
perhaps do: val channel = connection.getChannel at the top here and use that throughout?
we will do protobuf when everything has stabilized, avoid dev overhead
True  (though I made sure it can never be called). Done.
but that's something the IDE should help you with (mark occurrences), all this just reminds me of a naming scheme using prefixes of different types of variables in java (m = member, p = parameter, s = static), so bad, wrong, those memories hurt -- anyway, as said earlier, I will adopt to whatever we decide perhaps easiest to discuss it in the same physical room, whole team, some day
mistake, I think I removed it downstream already
Yeah - I am starting to think that using the Rice distribution from
scipy.stats will be the most satisfying solution. Will keep working on
this.

On Mon, Jun 25, 2012 at 3:37 PM, MrBago
<reply@reply.github.com>
wrote:
>>
>> +    # SNR = var(signal)/var(noise) => var(noise) = var(signal)/SNR:
>> +    p_noise = np.mean(p_signal/snr)
>> +
>> +    if noise_type == 'gaussian':
>> +        # Generate the noise with the correct standard deviation, averaged over
>> +        # all the voxels and with the right shape:
>> +        noise = np.random.randn(*vol.shape) * (np.sqrt(p_noise))
>> +    elif noise_type == 'rician':
>> +        # To generate rician noise, we add two IID Gaussian noise sources in
>> +        # the complex domain and combine them together:
>> +        noise1 = np.random.randn(*vol.shape)
>
> I think we need to distinguish between var(noise-sample) and var(noise-distribution). These two will be very close for a large noise-sample, but at the end of the day, var(noise-sample) is only an estimate of var(noise-distribution) and when noise-sample is small, it's a pretty bad estimate. I believe is usually defined as `SNR = mean(signal) / sqrt(var(noise-distribution))`. We can either hard code the analytical form for var(rice-distribution) for use scipy.stats either should work.
>
> Bago
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/nipy/dipy/pull/26/files#r1046764
_add_whether_on_same_domain(data_dict) is a private function by convention so you should not be using it outside of the module (file) it is defined in
It should also be possible to set float timeouts:

http://docs.python.org/library/socket.html?highlight=settimeout#socket.socket.settimeout
you should only call `start()` once in a test.  the idea is that if you are performing a test that runs asynchronously (and [the `collection.load()` call](https://github.com/siq/gloss/pull/1/files#L1R255) is asynchronous), then you start the test by calling [QUnit's `stop()` function](http://docs.jquery.com/QUnit/stop).  the tricky thing is that `asyncTest()` is just a call to `test()` that starts by calling `stop()`.  so the typical async test case looks something like:


    asyncTest('something async', function() {
        doSomethingAsyncLikeCollectionLoad(funtion() {
            ok(/* some assertion */);
            start();
        });
    });

i don't remember why exactly i was doing `setTimeout(start, 15)`, presumably i wanted to wait for some pending events to occur before moving on to the next test (`start()` tells QUnit that this test is fully complete and it can proceed to the next one).

all this to say this line should just be removed :smiley:
The binding of the session.  This is the main use of the +*account card, that's what is bound here.
What if I want self.parent.parent.iso_path?
You have to check all the parents in a loop until you find a non-empty iso-path
Генерирует `<html>` через элемент `root`, решает #110.
If type == null, this else will never be reached
Por que adicionar o .gitignore no .gitignore? A idéia é que ele seja trackeado pelo git exatamente para definir quais arquivos que não devem ser.
I've fixed this styling issue in the latest commit.
The original libemu installation instructions are missing the --enable-python-bindings flag which makes pylibemu unable to interface libemu.
This documentation could use some improvement. As it stands, it is meaningless, and one place where some of my questions could be answered if it were a little more verbose. It should detail purpose, structure, and use of the class. 

I recognize it's a simple class, but this string should at least hint at the purpose of the class (especially for such a simple class, why bother with a class so simple?). If this info were in the documentation, I might have fewer questions as a reviewer.
I pushed a change here. I moved the top __call block to be the last elseif block.
I suppose you mean disabled ? And what about overall speed on this case ?
Operator precedence bug: `!handle instanceof net.Socket` is always false.
i like the safe_init method... thats a god idea! and i like the implicit call to init, makes life easier. and as the scenario that someone wants to unload the library is very rare, i think is ok to just explain that in the comment and leave the rest as is.
ok, one came to another and i had quite some fun reading pages about marshalling. frankly, there is no good way to provide a method signature which allows to use pointer and array in the same time, because you want to provide the marshaller enough information that it does not copy the data. in the array case, the CLR will pin the arrays and lets the unmanaged code read/write the provided memory only if one uses the [In]/[Out] attributes. if one wants to use pointers, then in C# the type should also be pointer, because this forces the programmer to pin the memory himself with a fixed code block as shown above. so it needs two implementations for optimal performance in both cases. will do a new update soon.
Thanks Patrick but try not to use this if possible, because the rest of our code doesn't; the break stuff in Scala is confusing and not very efficient
It can't throw exception because this method is called from Caching\Cache regularly.
I put here the dependance of lm-sensor.
@rafaelfranca to be sure we cast `nil` properly.

```ruby
if name.nil?
  nil
elsif name.is_a?(Module)	
  name
else
```

Would be more readable here, wdyt?

Or `Thread.current[:xml_mini_backend] = name && cast_backend_name_to_module(name)` is better?
@rafaelfranca done. Thanks for all the tips!
Thanks, I missed it. Let me update it.
Why do we need to take owner explicitly instead of using `this` as in old version? It seems like you are passing `this` every time you call any of those methods.
duplicate See Also sections
Needs extern "C" { } around the npy_math.h include (it unfortunately doesn't include its own)
Sure, no problem. I certainly want "non-experts" to be able to understand our code to some extent, but in this case I think just sticking to standard terminology is best.
They are not typos and should not be changed.
Don't use tabs for indenting.
// Whoops
YAML is not as popular as XML and JSON for webservices.
Remove the "is" here I think.
Style: wrap at 80 columns. Probably applies to other lines too.
See section 13 in style guid: https://sites.google.com/site/rndbbnorth/cheat-sheet/code-styling?pli=1
pls change " to '
OK, I know I said to do this, but this is too unencapsulated for me :-).  Question shouldn't know about params and shouldn't know about the guts of the answer_choice params in particular.  How about instead of this, you just put a hidden_field in the answer choice view that sets :updated_at to Time.now.  Put the comment there about why we need this.  Then you can take out this code and the Question.force_update(params) call in the controller.  Should work right?
will rename the existing logfile.
"option none" implies there's an option type. `fail "error result"` might be better, maybe even with the error attached.
I'm not entirely clear on this: Will this warning be printed even on systems without grsec if `/proc/sys/kernel` is unreadable?
It was generated by develop/create_schema_files.php. Most likely previous version was edited manually by someone.
If `class $acm_sql_type` implements `interface phpbb_cache_driver_interface` it should be wrapped via `class phpbb_cache_driver_sql_generic`. Otherwise you can assume it's a `phpbb_cache_driver_sql_interface` (which will end up in a type hinting error if it is not).
L_COLON should be reinstated.
whoops >_<
Oops, was supposed to be ===
FIxed.
Also fixed the missing space between the ".'"
The following deps are not used at all: phpbb_root_path, phpEx, request, cache.
quoteAbyssPager и quoteApprovedPager не нужны
Just a note that this is the "static" app config:  the app config that is contextualized by the startup context (if any).  (It might be better to call this 'static-app-config' just to avoid confusion later.)
You mean `cloneObj()`?  No, it's generic.  In fact, we might want to move to `Y.clone(obj, true)` instead.

Historically, the resource store wasn't a YUI module, so pulling in other YUI modules (such as the utils.js) was tricky.  We should definitely take the opportunity to clean up though.
As long as they're consistent, I don't see an issue with lots of bindings. There is an argument for each variant to exist (though I only use 2 regularly, a third sparingly, and the fourth almost never).
Kinda forgot the docblocks - its public because google told me so :P
Semicolon, added. Here and elsewhere.
please don't commit commented code. this applies throughout, so be sure to search through your code and remove other instances of commented code.
5 is a "magic number". http://en.wikipedia.org/wiki/Magic_number_(programming)#Unnamed_numerical_constants 
You should replace 5 with a named variable, describing what it does
remove commented code, ln 11 ,13
There's no explanation of what this is for. Why should we need this when we can get it from the cube?
wrong comment. we register the sparse type.
Why remove the link to learn more about ``scan``?
I've added tags 'async' and 'gpu_async'
Why not TextField?
Why nullable?
Maybe it would be good to have <code>datetime.datetime.strptime(x, '%d-%m-%Y %H:%M')</code> as a function?
Well yeah, that's really hacky, I had an idea to try to override value with SpellProcMgr but I don't feel like it's gonna work, considering I've to look in so many places and with my bad behaviour of jumping from one part code to another I will simply miss something important and fail in the end. Well, I will ask SpellProcMgr tonight to be so nice to me and let me edit him a little bit ^^.
I would prefer the freeing happen in the modifier_linkable_list().
Should be 1.5
God yes. It hurts my eyeses.
Oh, sorry, my mistake - they are covered, I see.
`keys` is already declared, but not assigned, please remove the `var`
AFAIK, the policy of the jQuery project is not to put this kind of info in the source files. We have a commit history for this.
Hm, why do we need another argument here?
The file was removed.
The real reason it fails with GCC is because of the options that you pass along.

I get errors like this:
```
nearest.c:1: error: bad value (native) for -march= switch
nearest.c:1: error: bad value (native) for -mtune= switch
```
Added the option, thanks.
That doesn't make sens: md5sums is None, and you cannot test 'in' for None. As a result the tests do not pass in your branch.
> You'd need to make sure that {DAV:}write is not returned for the principal that's not allowed to change the vcard :)

Right :-) And since there's only read-write and read-only to choose from (?) we should in principle only allow updates if the user also has permission to delete. In that case I think it's better to throw an exception because the alternative would be too restrictive. One can always blame the CardDAV clients if they barf on it ;)

> only the plugins are aware of the user context and make decisions based on that.

So we should do permission checks in a subclass of Sabre_DAVACL_Plugin (still at 1.7.x) instead?
This part is introducing some possibly unfamiliar terminology i.e. octaves and harmonic relationships.  The reader might not have a clue what these two things are and thus it is hard to judge why not strictly adhering to these is a good idea.
Wow. It is legal PEP8. :) I indent these case to immediately after the bracket.  I'm a bit surprised that PEP8 is ambiguous about this. Happy with either indent, I guess.
I see what you are saying, however, PRAW for testing reddit's code as well. A failure in these tests can represent either an issue on PRAW's end or on reddit's end. It simply means there is an inconsistency between the two. This is something that I am currently involved in fixing and I prefer to leave it this way.
Silne typy ti ne vzdy pomuzou, tohle je dost patologicky pripad, v podstate
je zbytecne testovat, ze tam vsechno je. Ale kdyz vezmu test updatu, tak
tam uz si chci zkontrolovat, ze jsem opravdu ten objekt zmenil. I kdybys
mel libovolne silne typovani, tak stejne potrebujes otestovat, ze jsi nekde
neudelal chybu a v te databazi se objekt opravdu zmenil.

2012/8/26 Lukáš Lánský <notifications@github.com>

> In test/users_test.coffee:
>
> > +
> > +    it 'should create new user', (done) ->
> > +      users.createUser 'doe@example.com',
> > +        'John Doe',
> > +        'hunter2',
> > +        'john@example.com',
> > +        (err, user) ->
> > +          should.exist(user)
> > +          user.should.have.property('id', 'doe@example.com')
> > +          user.should.have.property('displayName', 'John Doe')
> > +          user.should.have.property('email', 'john@example.com')
> > +          user.should.have.property('courses').with.lengthOf(0)
> > +          user.should.have.property('achievements').with.lengthOf(0)
> > +          user.should.have.property('salt')
> > +          user.should.have.property('password')
> > +          users.hashPassword(user.salt, 'hunter2').should.eql(user.password)
>
> Tak trochu to vypadá, jako by to nahrazovalo silné typy: JS je strašně
> free jazyk, kde se nemusíš starat o to, co s čím děláš, ale, ach né, pak
> ztratíš kontrakt "tahle funkce vrací takovéhle objekty"! V takovém
> prostředí jsou asi unit testy nutné všude, ale je to IMHO větší otrava, než
> unit testování netriviálních funkcí a silné typování ve většině programu.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/progma/progma/pull/7/files#r1460998>.
>
>
Same comment as above. Why not just do it for all of the classes?
Interesting. Did you find that you had to cast this to a String? Is there an underlying PreferenceStorage bug here?
Need a description for this parameter.
This switch statement seems redundant with the line above it
No longer initialize to WAVELOC_PATH as default behavior
keeping it as get_labels. I'd like to have the docstring in there and raise a not implemented error if it's not implemented. sure, I could check it in __init__, but this seems cleaner. also I don't want to confuse labels with the label property.
ah my b, I forgot to actually make the partial once I worked how I wanted this to work.
dropBomb
No, after our little chat I see that the case of an empty curve is still tested whereas the other tests were testing implementation details (now changed). So it LGTM.
Add `if parent.user.email` since they may not have an email address.
maybe something like: "precomfigured_desura_launch_script_cmake.sh"?
Probably this is meant for projects where developers are in teams like GUI team, Localization team etc. Will remove that.
You can simply use `settings.LANGUAGES`, no?
Hahahaha ...fun.
no `px` on 0 values
don't change this alignment
I had the same dilemma. Some of the localizations translate it, some not. It doesn't look like a product name to me though.
yeah just remove it, as it will be replaced when importing the new data anyway
Guess we should add the _helpers.scss to the CUI login composite in the future.
Why 600px?
When you run ./config.sh you can specify what to build.

In our case we would specify ./config.sh emulator-x86.

That information is then used when you run ./build.sh. Take a look at the .config file in your B2G dir
Ok, I will look into this.   I have a vague memory of encountering a way to do this while writing automodsumm, but I'll have to investigate it further. (It doesn't necessarily block this PR given that it works right now as-is, though, so if I don't get to this soon enough, I can do it as a separate PR of astropy.)
@andycasey  and @wkerzendorf  - Actually, now that  I've thought more about it, I think you're right that for masks it does make more sense to just throw and Exception if their types don't match (although not necessarily for errors, as discussed below).  I also missed the ``if not isinstance(operand, BoolMask)`` part when I first read over this, so now some of what you're saying here makes much more sense.

I am, however, still concerned about the confusion that may result from this being a subclass of `ndarray` - normal `ndarray` objects are perfectly happy to combine with other types of `ndarray` objects, so that's what users will be expecting.  I also have some of the same reservations as I mentioned below for errors, where in some cases one might imagine the mask being dependent on the values of the array (or perhaps the errors - one could easily imagine a mask where the point is masked if the error is >= the data value).  So perhaps we can get around these problems by subclassing a base mask class, and storing the boolean mask itself as an *attribute* on the BoolMask object?  What do you think about that?
The majority of the code in this function `handle_check_return({up, Check}, ...)` was copy/pasted from `handle_call({service_up, Id, Pid}, ...)`. Would be better to refactor out the common logic in both functions into a new internal function and reuse in both places. Easier to maintain long-term.
Ditto with this form, reducing duplication would help.
You can probably use a zero_after_free_allocator here as well.
If USE_IPV6 is not defined, then there's no support compiled in to disable.
Im a Linux noob, sorry ... but your statement is false for the Windows binary, as we statically link to OpenSSL there ;).
Ok, although i think that would not happen when baking models
Wouldn't keeping prefix "Trait" for all traits be better for consistency and easier to identify a triat file?
I had done that because the length part appears as a part of the name, even though it is outside of the quotes. i.e. `text_field1`(20), `text_field2`(20). By overriding name() on Mysql, I could also attempt to keep this processing out of DboSource.  I guess that failed, somewhat.
I'll override buildIndex in Mysql instead, and change Mysql::_alterIndexes, so that adding that sub part is not done as a part of the name() function.  This should also mean that DboSource will be oblivious to the functionality.
I have to say I'm a bit uncomfortable about putting workarounds for specific implementations into the generic parts of the code. Could this maybe be solved in some other way? For example, could we move that to rdfMapper? If necessary, we could add another method there (althoiugh I'm not to sure about how it should be called). Or we could have something like DoctrineRdfTypeFactory, but that probably wouldn't work too well
Dat object wordt gemaakt vanuit backend pages add/edit. Dat kan dus ook zonder dat profiles geïnstalleerd is, maar dan moet het gewoon niks doen.
On Android, where we can't really trust the state from frame-to-frame due to drawing overlays and stuff like that, we want to be able to call Initialize (or maybe it then should be called Flush) every frame, and this seems to prevent that.
Hm. Don't you think that `~0` is better style than a cast in an enum?
How does [this](https://github.com/benstraub/libgit2/blob/8651c10f1ed5d42ef0ad6e9e9f654799b4ffb39c/src/checkout.c#L99) look?
You don't need to wildcard `regex.c`
A break there would break the inner loop (`while (1)`),  `goto done;` jumps to outside of the outer while loop.
The payment modules actually receive the shop as an argument; because of that you might want to use `self.shop.redirect` instead.
I think we actually want a flash fallback, see https://github.com/mozilla/bedrock/blob/dev/apps/firefox/templates/firefox/features.html#L363
If we did, I can't find where: https://github.com/mozilla/funfactory/blob/master/funfactory/monkeypatches.py
This `select` could use `size="7"` to avoid scrolling.
See my comment from above.
Nit: We don't actually use a weak ref, so lets modify this comment.
Heh, that was just a debugging log, it shouldn't be there anymore...
try - except - else - finally should only be used when the finally clause needs to execute after the else statement. This can be made simpler be removing the else statement, moving the finally statement closer to the context, and removing line 47 and the test for connection in the finally block.
document what this actually converts.  It converts a `frequency` in the form of what into what?  String of the form "HH:MM:SS" into integer seconds?
isn't that just a test-dependency?
Yeah is there a different way to work with core_ rather than using straight query strings? I have run into this before. Some sort of utility or something might be nice.
This actually breaks the case where a block is given; however, we didn't have a good spec that actually covered it. Doh! I'll fix.
This is only when you don't use the CacheProxy, which I think should be named CacheDriverProxy.
That will take care of doing the instance if you don't provide one already. I'll update the bundle to reflect that soon.
Does this apply to all predefined PHP classes/interfaces? Or only the ones extended/implemented.

The Symfony coding standards don't mention this, or are these based on the https://github.com/pmjones/fig-standards?

Just asking as it will prevent these type CS errors in the future, the documentation of 2.x only mentions a small part of the conventions. If this is really something that must be fixed I will open an issue in the docs section.
It could only be duplicated partly because it also covers something that is not fixed in 2.0.
So I think it would be enough to rebase your PR on master. It's not really needed in 2.0/2.1
extra spaces in this file
Move this check to the beginning of the normalizer
This is likely to be an infinite loop when a form is submitted with extra data
This is original code https://github.com/symfony/symfony/blob/master/src/Symfony/Component/DependencyInjection/Loader/XmlFileLoader.php#L490
コメントありがとうございます。
意味なかったです。。。
修正します。
you could use self.context.id
see context.identify: https://github.com/twitter/commons/blob/master/src/python/twitter/pants/goal/context.py#L32
If you wan't to change that to use sha1 instead of md5 - sgtm
If I know, I would fix that already... I am still investigating it.
This has nothing to do with the bug. Please, open a new bug targeting 2.4.0, label "Remove js log info", and create a separate pull request for it.
nit: just do:

return d.promise.then(...
it should not clash, since you run the test in subprocesses. but yea, it would require the full configure to run.
"role" is the list of roles declared in the "run_list" as opposed to the expanded "run_list". The same applies to "recipe" and "recipes". You took the plural form, which is not what we want.
Use camel case for variable names
I added the default className, so in the below line - `if (!$('#miniTip.'+ o.className +'')[0])` it would match both the default or the user entered option
According to Tom this would need a length validator.
Messy message :)
This patch accidentally drops this newly added functionality, which is required. This is why the testsuite fails.
@mikesherov It seems to work the same (`mouseenter` is fired before the click) but I can see the wisdom in making the fewest required changes.  Will change.
yep, gonna pass the linter
I think the whole point of this module is to not have getElementById inside functions. You should find a different way.
Are you sure we should remove the animation completely? Isn't there a UX spec that says it needs to fade in and out?
what is _class? thanks Ran
`if (!('error' in this._currentPopup[this._currentOrigin].dataset)) {`
Dani, yo no puedo chequearlo. El "poder" para poder decidir esto se le dió a Patryk, por lo que debe ser él la persona que lo defina.

De todos modos contactaré con él para que se defina.

Sorry

//Sergi

El 04/09/2012, a las 19:28, "dcoloma" <notifications@github.com<mailto:notifications@github.com>> escribió:


In apps/homescreen/style/dock.css:

>    pointer-events: none;
>  }
>
> -/* icon */


@sergivila<https://github.com/sergivila> @patrykdesign<https://github.com/patrykdesign> @authoritaire<https://github.com/authoritaire> could you please check if the icons are OK with current size. Do we really need to generate the shadow via software when it could be part of the image itself?

—
Reply to this email directly or view it on GitHub<https://github.com/mozilla-b2g/gaia/pull/4283/files#r1525267>.



________________________________
Este mensaje se dirige exclusivamente a su destinatario. Puede consultar nuestra política de envío y recepción de correo electrónico en el enlace situado más abajo.
This message is intended exclusively for its addressee. We only send and receive email on the basis of the terms set out at:
http://www.tid.es/ES/PAGINAS/disclaimer.aspx
force of habit, will switch
err no I refactored it and left this as an array it should really just be a string...
Need a better naming, rename `getNumber()` to `getAlarmCount()`.
I'm implanting the pending message deletion in messageManager.deletemessage api and it should be landed in this week. Although you execute deletion will not delete the pending message now, it should work correctly when the pending message deletion landed and you won't need to change in view page code. So you can still add the deletion ability first to test if it works for normal messages.
What does this variable means? 是一條線?
Looks oversimply good!
that's very hard to read. Do you want to use a method of arrays instead? https://developer.mozilla.org/en-US/docs/JavaScript/Guide/Predefined_Core_Objects#Array_comprehensions
For single line blocks, { should be removed.
You should check the type of inputs. I'd like to see the following tests pass:

    #> BaseForm[x]
     : BaseForm called with 1 argument; 2 arguments are expected.
     = BaseForm[x]
    #> BaseForm[x, 2]   (* Should this raise an error? *)
     = x
    #> BaseForm[3, -2]
     : Positive machine-sized integer expected at position 2 in BaseForm[3, -2].
     = BaseForm[3, -2]
    #> BaseForm[3, x]
     : Positive machine-sized integer expected at position 2 in BaseForm[3, x].
     = BaseForm[3, x]
    #> BaseForm[3, 0]
     : Positive machine-sized integer expected at position 2 in BaseForm[3, 0].
     = BaseForm[3, 0]

You'll need to define the messages and use evaluation.message to print them. (let me know if you need help with this)
If you want to refactor another way be my guess. I have no loyalty to this method.

Just know that DB backend means if you want long term int typing you need to handle the in and our for this instance var.

I was just dropping the quick fix. 

-- 
Nicholas Weaver
EMC Corporation


On Wednesday, June 20, 2012 at 10:45 AM, Nicholas Weaver wrote:

> It is stored as string from the CLI/API input and in the DB. I should have never compared to the int in the first place.
> 
> Only reason I did was because the new method was setting an int. But that is always overridden by the Slice.
> 
> Since the vast majority of the time this will be a string in the key/val to_s is only needed should it somehow get set to int before object persistence. I could have set just @maximum_count == "0" but the to_s is a safety net.
> 
> 
> 
> -- 
> Nicholas Weaver
> EMC Corporation
> 
> 
> On Wednesday, June 20, 2012 at 10:38 AM, Nan Liu wrote:
> 
> > > @@ -56,7 +56,7 @@ def current_count
> > > end
> > > 
> > > def is_under_maximum?
> > > - return true if @maximum_count == 0
> > > 
> > 
> > 
> > Should we compare .to_i or is there some reason for compare .to_s ?
> > 
> > ---
> > Reply to this email directly or view it on GitHub:
> > https://github.com/puppetlabs/Razor/pull/81/files#r1018668
> > 
> > 
> > 
> 
>
Collections, not objects, are mapped to tables. No O/R mapping. A table 
has a uuid, an int (for the verison) and a bytearray for the bson.

On 2012-10-24 23:42, tjmcs wrote:
>
> In lib/project_razor/persist/postgresplugin.rb:
>
> > +        if @statements.add?(statement_name)
> > +          prepare_on_collection(statement_name, collection_name, 'SELECT value::bytea FROM ' + table_for_collection(collection_name))
> > +        end
> > +        exec_select_on_collection(statement_name, [])
> > +      end
> > +
> > +      # Returns the entry keyed by the uuid of the given object_doc from the specified collection
> > +      #
> > +      # @param object_doc [Hash]
> > +      # @param collection_name [Symbol]
> > +      # @return [Hash] or nil if the object cannot be found
> > +      #
> > +      def object_doc_get_by_uuid(object_doc, collection_name)
> > +        statement_name = "one:#{collection_name}"
> > +        if @statements.add?(statement_name)
> > +          prepare_on_collection(statement_name, collection_name, 'SELECT value::bytea FROM ' + table_for_collection(collection_name) + ' WHERE id = $1::uuid')
>
> So are you mapping objects to tables in PostgreSQL here (using some 
> sort of object-relational mapping) or are you using PostgreSQL as a 
> key-value store (I know it supports this as an option)? I guess I 
> should have asked this earlier, but hadn't had time to pick my way 
> through the new code in the level of detail that @daniel-pittman 
> <https://github.com/daniel-pittman> has...
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/puppetlabs/Razor/pull/224/files#r1934706>.
>
Would be good for this not to say `10
OK then, I'll change it to 42.  That turns _on_ the hilarity, right?  Or did you mean the Hillary filter?  The scaladoc is out of date.
直す
s/追加され後に/追加された後に/

`uptime`  2回目はダブルバッククォートになってる
Yeah, `cx` and `cy` is from Raphael. `c` stands for `center` ...
I didn't know about it. I'll set it up the global .gitignore then as in https://help.github.com/articles/ignoring-files
Then ignore the modification to .gitignore, which was a side effect of the motivation of the pull request (the docstring of errorfill)
I think the best way to fix this then would be to have the page load at the top of the page, or make the alert stick to the top.
ouais bon là j'aurai dû relire, ça devrait être 0.8…
These all apply to any strategy, not just the default one.
Should this logger be initialized with the name of the class? (appscale_datastore_batch)?
@cordoval checked all the adapters and noone fit with CF .. so i guessed it was intended ..
Ah, yes; I see why a separate variable is needed. I'm fine with 'lineNum', but how about using 'childIndex' instead of 'childI'. (something about the trailing 'I' just bugs me, I guess...)
Ah... good catch! I think my alternative method doesn't have this problem. There, I simply calculate the distance to the center of the pixel and see if it is within a "pixel radius" ( e.g., `0.5 * (dx ** 2 + dy ** 2)`) of the circle radius:

    pixelrad = 0.5 * (dx ** 2 + dy ** 2)  # dx, dy = pixel spacing in x and y (probably both 1)
    ...
    if d < R - pixelrad:
        frac[j, i] = 1.
    elif d < R + pixelrad:
        # subsample the pixel ...

I prefer this method anyway because then you're only calculating one distance per pixel instead of four.
This is also a dependency of twisted, and that dependency is part of the interface, so we probably don't also need to depend on it.
yep, why not.

```coffeescript
callback ?= (view, model) =>
  display = if included then '' else 'none'
  view.$el.stop(true, true).css('display', display)
  # Update visibleItems list, but do not trigger
  # a `visibilityChange` event immediately
  @updateVisibleItems model, included, false
```
Turning it off there is not necessary. But we'll have to update the state of the app after launch with the current state of the proxy.

On Aug 14, 2012, at 5:45 PM, Justin Ridgewell <notifications@github.com> wrote:

> In AppController.m:
> 
> > @@ -121,10 +125,8 @@ - (void)applicationDidFinishLaunching:(NSNotification *)aNotification {
> >  	if (previousPID != 0) {
> >  		XLog(self, @"Turning proxy off");
> >  		
> > -		[NSThread detachNewThreadSelector:@selector(turnWirelessProxyOffThread)
> > -								 toTarget:self
> > -							   withObject:nil];
> > -		
> > +		[self turnWirelessProxyOffThread];
> Is turning the proxy off here necessary? Imagine
> 
> I launch the app
> I connect to my proxy
> I quit the app, clicking 'no' that I don't want to stop the proxy
> I resume the app at some later time
> I kind of expect the proxy to persist after I relaunch...
> 
> —
> Reply to this email directly or view it on GitHub.
>
this is wrong. ``execute`` returns the status of the process, not the output (and you simply need to compare it to 0)
I honestly have no clue what's going on in there, but it explodes when generating autoloads for packagist: `Undefined offset: 27` when reading `$groups[$packageKey]` at line 462. If you can either fix it or add comments so that it's understandable I might be able to merge.
ahhh, and post.haml is in fact included on most pages... never mind, I will indeed remove this line.
made it eager
I guess you forgot to update the LED names here.
All account has a token.
why do we need this? an exception should not appear and if it appears we should care about it and not just pass.
Shouldn't this still concatenate onto `$list`? This is occurring in a few places below this line as well.
If you plan to work on new manifest on the same SDK release, we can delay this. [so you may wait for the 1.8 merge to stab before landing this 05/15]
But ensure that you can address this without having to modify loader.js.
By that, I mean that we have to ensure that loader.js fits SDK needs before asking it to land in mozilla-central.
I think we should add another test of this `format` function, something more concrete than https://github.com/ZER0/addon-sdk/blob/0a0dc9faa62964ca9088ff02f7e99e34c4cb816c/packages/api-utils/tests/test-traceback.js#L96
aha.  a one char bug.  This makes sense - javascript calculations included the boundary condition while CSS did not.
@shane-tomlinson do you think this should be done? or is it something to look into in the future?
yeah, I think we can just say if `req.session.userid` is truey (an integer), then there must exist in the sesssion a lastPasswordReset token that matches the current one in the database.  if `req.session.userid` is falsey, the session is not yet authenticated and we can skip the db hit.
Why?
If I got an `ImportError` it would suspect I mispelled the module path because it couldn't find the file. When in fact it found the file perfectly fine but couldn't import it. 

If anything, I would create a new exception class to dedicate to this. 

Either way, we need logging there if we decide to swallow the ImportError.
We probably don't need jQuery and can just use built-in stuff, so I may remove this later.
same for pointCount and points - using points to check length
Oups I don't remember this
Why should this raise a `NoMethodError`? It seems like this should be something like a `InvalidTypeError`.

Also, resource is misspelled.
It seems like changing the function signature (expanded args vs array of args) between the DSL and the proxy class is vaguely confusing - would it make more sense to move the arrayification into this method instead?
can this individual change be made in master?
elements, completions (on the next line)
@Maks3w clarification: array definitions should include a comma on the last element.

@bakura10  This is a best-practice, as it eliminates errors on copy-and-paste, and also ensures that the diffs are smaller (one less line change, basically).
Align param tags, add type to $verb method (string), remove internal tags.
This check is unnecesary, the next if (Traversable) is enough.
It's precisely the call to ErrorHandler::start / ErrorHandler::stop which makes it impossible to use the StreamWriter inside an error_handler... I have no clue about avoiding "@" here and at the same time solving the bug...
variables and method parameters should be named with lower_case_and_underscores style. since self.listOfWords is an internal variable that is never exposed outside the class, it should be named with _one_leading_underscore_style. [reference](http://www.python.org/dev/peps/pep-0008/#method-names-and-instance-variables).
How about make this optional for those Mac users who already have it set up?
Can you use a built-in pi constant instead?
I could be useful to keep a documentation about the information associated to each file (field 11 is post URL, etc) and delete them
Superfluous new line :-)
xsvfbnhjmk,l.ö-ä'
this is wrong. The timeout is set by a setter, so *after* the constructor
Good point! I'll give my changes a quick test before pushing a new commit (more BID problemos). Cheers Owen.
Spaces around moustaches. A comment somewhere in all the form magic saying where these fields come from might help too; it confused me when I first went through all the code.
Ah, so doing it this way lets Django automatically rehash the password with a newer HMAC_KEY?
Not sure this should throw. That means nothing would get returned to the callback, right? I feel like with callback-style functions, there's an implied contract with the consumer that the callback should always be called, and that errors will be sent to the callback instead of being thrown. This is definitely true in node (because an error thrown after the current tick crashes the whole process), but I feel like it should also be true in client js.
No idea what I saw when I wrote that comment, but definitely doesn't look like while loop material to me either.
The base_url you should check is https://support.mozilla.org , and not http: ...
Due to this, the if does nothing because of the term of comparison.
thanks GICodeWarrior. No need to change anything here jerry.