labofsahil/github-event-dataset-2012 huggingface dataset:
Is there any specific reason that this is separated into two halves, one to do the mapping and the other one to dispatch it?
No. it could break to the outer loop, but I'm not 100% sure how BOOST_FOREACH works, and I figured keeping it simple made sense. Maybe I'll take another look.
two blanks
No problem here with the current implementation, but I'll note that we can probably better handle resource acquisition is initialization (http://en.wikipedia.org/wiki/Resource_Acquisition_Is_Initialization) using factory methods in the future. Ideally, this will be part of the Milestone "Inf: Finalize Material/IsoVector/CompMap API/Interaction"
I don't understand. I must be missing something. They look fine to me.
I'm pretty sure these TODOs are TO-DONE; but I'll check to be sure.
I would notice the user about the installation of a package in the application python path.
E.g.  echo "Installing httplib2 from local bundle"
`setTimeout( function() {` => `setTimeout(function() {`
Should be able to just do `system "make", "CC=#{ENV.cc}"` to override that.
This should either be replaced with something that tests the software's functionality, or removed.
Hum, a supprimé...
Would it perhaps be wise to provide a default value here? To prevent Redis from storing stuff forever?
I'd be less strict with this first check - there might be situations where you want to pass a generator rather than a list. I'd do `self.colspecs = list(colspecs)`, and let it handle anything that can be turned into a list.
No as some of the more global checks are overridden by some of the more local checks, this is on purpose.
Nit: Line wrapping here looks off.
包的名字用**粗体**，俩星号围起来，另外可以给一个简单的`system.time()`实例，因为我们用knitr动态编译，所以能写例子的时候就多写点例子，不要让读者去想象去猜去查。
Yeah, I came to that conclusion today as well, the issue is getting the pipe in right state to terminate I think.
Maybe I'm being dense, but what does fValueMatcher indicate that can't be surmised by seeing whether fMatcher is null?
Through github, the indentation still appears not to match the surrounding file.
I changed this because the logs are almost unusable when it logs all of that.

(Did you know: you can set logging output levels now! In `config.json` set `logging.level`, weeeeee!)
yeah noticed so i guess i have to tweak all the other throws :)
What the comment says and what the condition is checking are different.

To check for an "empty selection" as stated in the comment, use:
```
if (sel.start.line === sel.end.line && sel.start.ch === sel.end.ch) { 
```
Should be this.editor.document.getText()
Nit: capitalize start of sentence.
This is a flawed way of doing things. Try tabEditors.$buttons instead.
i will remove them now
doing `$ lsof -i :8080` on the gear gives if an app is using that port and its pid
Maybe try like 5 times at times: [500, 1000, 2000, 4000, 8000] - and if found, send a message to the previewer to open it in a new tab
How does that sound ?
This requires a docstring.

Docstring policy is not enforced for now, but it is recommended to add a description.

The name of the method is wrong. It does not returns a temporary file name, but just a unique filename.

Please merge this code into makeFilename(self, length=32) or just use makeFilename.
This method is good - isolating parts of your system into compact functions is a good habit to get into. Nice handling of the NumberFormatException, too.
其他相關的亦同
I used four spaces as tab, but rest of style.css is made with tabs. Should I replace all tabs with 4 spaces (to be consistent with py files) or replace my spaces with tabs?
Is this XHTML valid? `button` standalone as it is as a child of `form`?
So this view is useless. We can just remove it. Also remove the setting.
I'm curious why lint thinks . is better than array-like access. Just for readability, I'm assuming.
oh, awesome!
https://github.com/cadecairos/butter/blob/e608af21ee77e9a07968dcb1e34c10d7c4fdaf65/src/core/media.js#L80
https://github.com/cadecairos/butter/blob/e608af21ee77e9a07968dcb1e34c10d7c4fdaf65/src/core/media.js#L119
https://github.com/cadecairos/butter/blob/e608af21ee77e9a07968dcb1e34c10d7c4fdaf65/src/core/media.js#L141
https://github.com/cadecairos/butter/blob/e608af21ee77e9a07968dcb1e34c10d7c4fdaf65/src/core/media.js#L151
https://github.com/cadecairos/butter/blob/e608af21ee77e9a07968dcb1e34c10d7c4fdaf65/src/core/media.js#L177
https://github.com/cadecairos/butter/blob/e608af21ee77e9a07968dcb1e34c10d7c4fdaf65/src/core/media.js#L186
https://github.com/cadecairos/butter/blob/e608af21ee77e9a07968dcb1e34c10d7c4fdaf65/src/core/media.js#L214
https://github.com/cadecairos/butter/blob/e608af21ee77e9a07968dcb1e34c10d7c4fdaf65/src/core/media.js#L223
https://github.com/cadecairos/butter/blob/e608af21ee77e9a07968dcb1e34c10d7c4fdaf65/src/core/media.js#L251

Just saying.
The mozprintcallback patch you've linked doesn't have the `abort()` functionality and therefore there is no `.abort()` property.
Extra 'F' at the end of line
I could also move the crlf check after gjslint, is that ok? Is there some integration issues for the bot?
Please use PrivateBrowsingUtils.isWindowPrivate instead of using the usePrivateBrowsing attribute directly.  See http://mxr.mozilla.org/mozilla-central/source/toolkit/content/PrivateBrowsingUtils.jsm.  Basically this needs to look like:

let docIsPrivate = PrivateBrowsingUtils.isWindowPrivate(this.domWindow);

Also, no need for the try/catch block as nothing here can throw as long as this.domWindow is really a DOM window object.
unless/else/end is generally a pattern that's avoided; if/else/end is preferred.
is there a reason not to use the same dynamic detection as in the step-definition above? This would eliminate the if condition and make further refactorings less error-prone.
Is it not possible to have a `default` implementation as you have below and this implementation at the same time?
Have an empty stream for which no data is created in merge and mirror.
Can you rename nothing to consistentData or something else which conveys what you are testing in that stream?
What does they mean? Can you translate??
it's wrapped on line 192 https://github.com/Katello/katello/pull/222/files#L1R192. But now when I am looking at it again, this is probably not correct either. There is a parser in gettext which wont be able to parse these strings, right?
Are we missing a change to assets.yml for repository_edit and possibly js files?
yea, I've not seen `assert a, b` before.
#1. removed.
#2. no good way to do this with jquery - only the text of the parent needs to be updated, not the children elements, or their values.
Please use 4 spaces per level of indentation, not 6
To allow implementations of this method to discern between when this method gets called for the purpose of loading an entity during the resolution of a connection or for the purpose of looking for an existing entity for one that was requested of RestKit by the application.  More about this in a generic comment.
I guess my general attitude is why not duck-typing?  @adrn, do you have an opinion here?
Taking this out breaks the functionality where the version is updated between Python runs even without re-running setup.py.
`<continued from above>` ...here we throw an exception on error. Why is one error conditional crash worthy and not the other? Or should they be the same? It seems to me that if this `vnode_manager` and the relevant `handoff_manager` ever become out of sync (ie. either one of them crashes and loses state), that either one of these two error conditions is equally likely.
But future readers of the code won't see your commit message. They need comments to understand what's going on.
Im with @dereuromark
more extra newlines
no extra spaces. When reviewing Doctrine PRs, use the Doctrine coding standards, not the Symfony ones. there is a few differences (this one for instance ^^)
TODO: move the bodies of `cmdname()`, `firstarg()`, and `lastarg()` to `parser.y`
TODO: remove `command.h` and `argv.c` files
I would say 'includes' and not 'receives' here.
Probably because it doesn't use funfactory's reverse, which handles the locale stuff.

Admittedly I could've then used redirect for the external url redirect, but I figured making this method more flexible would be better.

Although it might be useful to see just how the built in redirect handles an absolute URL that doesn't use the kwarg like I did.
Got it. I just looked at the individual commits and see what you did. That's the big problem with the "Diff" view which shows you the diff of the tip vs. what you pull requested from.
I don't really understand this. Is this fix here in case mode is 0 or some non-None falsey?

Also, this line is over 80 characters long and for readability (it's a nested ternary), it might be better to break it up:

    self.mode = mode if mode != None else (
        self.modes[0][1] if self.modes else None)
Emails are django templates, not jinja2. That said, I am not sure if this is valid or not in django templates.
Ah, I missed the `=` part in `>=` :)
It seems dangerous to bind `onKill` in `kill()`, since `onKill` gets passed into `kill()`, which doesn't know what it does.  If `onKill` needs to be bound, it would be better to do it wherever `kill()` gets called, even if that means doing it at multiple call sites, to avoid a situation where `kill()` gets called in the future by a caller that isn't aware of the binding and passes an `onKill` function that misbehaves when bound.
I believe you forgot to change that doc string. It looks like the one for a ``PostgreSQLCrashStorage`` class.
Nice. This will have to be updated when we allow spreading the store over multiple locations, but this is nice enough for now.
I don't think so.. it should only require an object if you are using a URL in the form 'id@users.user_update'

You should be able to set the success URL to @users.user_login as it is in the view above.. if not then we should fix that in Smartmin.
Do your mean there won't be error if there are no arguments ?
Can you make sure this matches other files EXACTLY please? Otherwise it will screw with our docblock system.
логику расчета скидки и создания платежа лучше вынести в сервисный слой
нє. неймер нам не потрібен. імена файлів лишаєм такі як є
якщо юзати ParamConv то тобі не потрібен буде цей метод
i don't see any test in here, what are you testing ?
Heh, Symfony coding standards. Thanks for reviewing. Should I amend my previous commit or push the fix in a seperate one?
we are not using multiline signatures in the codebase
I would call it ``isLocked``
@stof right. I'll move this in the matcher / generator.
I extended `All` to prevent copy-pasting
Please use yoda style here (0 ===)
you should use ``&&`` instead of nesting 2 conditions here
what about adding some `->info()` ?
Twig uses it in its CoreExtension for some tests: https://github.com/fabpot/Twig/blob/master/lib/Twig/Extension/Core.php#L197 (which are similar except it is Twig_Test_Node)
Something is missing?
indentation for the previous 2 functions
This is basically copying the pattern in the airbrake spec. I think the reason it is done like this is because it is testing for `Exceptional` to receive the method not Failsafe::Backends::Exceptional.
这里是否可以做一下drag实例的缓存判断？避免多次实例化操作
Can we remove some of the superfluous comments? :wink:
I'm not sure to understand why you want to replace that value. 
I'm not a DB expert, but that seems quite uncommon. I think that either having two columns (property name, value) and replacing or only one column, but always inserting are more common way of doing that. Nicolas C, could you give some more feedback on that ?
A few of the parameters can be modified based on various other parameters -- interdependencies. Instantiate these mutable values on the stack and use them instead of the const values in the passed in MaketxParams.
I've built Cartopy OK with 0.15.1.
Oops! I completely missed that.
Where does that Utils class come from?
ok i took them out. (and moved my searchable up iwth the others)
When I first started my comment above, I disliked the change very much. But then I thought hard and maybe the explanation in my second paragraph was correct. In which case I don't mind so much. If that theory is correct, your change doesn't change the basic semantic of SVH.settleTime, it just accounts for a different situation where a larger timeout is needed. 

But I'd like to confirm that theory is correct, since SVH is really critical code.

See my final comment on https://issues.jboss.org/browse/AS7-4603 for what led to my theory. Apparently OSGi is installing some COMPLETE service in a ServiceListener. If something like that was going on with a service that Services.FRAMEWORK_ACTIVE depends on, that would explain why your change helps.

/me goes to look a bit
I'll cleanup that part before merging :)
again, I don't think this should be required.  Thoughts?
It was right before :-)
It's a little bit tricky because scrollHeight is a little bit smaller than original height. If the input height is equal to scroll height, the scroll bar will show up.  So I add a small space to prevent the scroll bar before textarea match the max rows. I will commit some solution for keeping the height single line and add the margin only for multi-line.
If we want to increase with line-height, it still need to compute how many row need to increase decrease every time, and the increased height of scroll height is actually the line-height. So I think think both method would be nearly the some in result and performance. But still thanks for you advice ;)
I followed the same pattern as test_apps/uitest/tests/setcapture.html
:)
I have now change it
Or this is intentional?
This excess the 80 chars limit, you can pass the linter with 

make lint

(and be aware of your changes)
Probably, as you have computed styles in 'inputCss', why dont we use line-height for increasing the size of input?
Always wanted to include a finalize() function... So, if you do not tell me otherwise, I'll call it finalize() for the old times... :-p
I have explained why I changed "hidden" to "invisible" in the previous comment.
If this is still an issue to you, I can change back to "hidden";
You may want to update this with the new python magic that lands in the last day.
Why do we create both variables before knowing if the activity is 'save-bookmark' ?
My opinion is it should be flexible enough that it shouldn't matter if it is first or not. Right now I'm not actually parsing out the individual elements between the brackets, but the regex should at least allow matching in case of additional elements besides just 'READ-ONLY' (even if we don't necessarily care about those other potential elements for the time being) in case the response text is added to by additional RFCs that extend IMAP or some server decides to against the spec for some silly reason (this can happen).
We want this to match the "vfs" format which uses mtime.
Please document the inner workings of `accessibleStates` and how they work together with the view
You're welcome.  It seemed like the next logical step.
Call this module ``spawn`` or ``launch``
I would change the view_type context variable to be `is_zendesk_user` and do `class="tab-pane{% if is_zendesk_user %} active{% endif %}"`
I will add templates directory at this level as well.
├── templates

also at the app level I would add a shared directory where each app can share base view for example or collections or models.
I think we should add some more instrutions for how to install (i.e. check out from github, etc).
This should be in a separate patch.
"Debian Build Steps" maybe?
You should use 'delete[]' or 'CC_SAFE_DELETE_ARRAY' to destroy array.
Why not puts pszMsg directly?
`An error occured while removing the vcs directory` would be better.
class constant should be uppercased, using underscores to separate words
Coz we won't compile *.mm files for example on linux ;)
Done. Adding only an error message as code already handle the NULL case.
Taken care of :-)
I think you might mean to change this to `not args.no_highlighting`, as `args.plain_output` will raise an AttributeError now.
my tendency is to prefer 'base' units for all values (ie; bytes, not megabytes, and seconds, not minutes). On the other hand, it seems OK to have this as minutes since you probably don't want to have a fast interval, right?
As described in latest commit message, now cloudwatch can be configured solely in the output plugin by providing "default" parameters.  These can still be overridden by the presence of valid event fields, as i think that is the most likely way this output will be used in practice, but it is no longer a requirement.

I started updating the documentation but still need to do more.  This comment at the top is no longer correct and I will commit an update to this & other documentation comments tomorrow.
Please use require with relative paths when possible, that makes code more portable.
Use the generalized helpers.getDomainFromEmail here. This was added in this PR and is found in resources/static/common/js/helpers.js
Could we run all of our commands by simply putting those into a single command separated by semicolons? Or is that not possible with Ant?
Can you please clarify that piece?
I really wrote it in 2010 and I've made pull request in 2011 :)
@pcarlisle moved it up
`touch` is implemented so that it non-destructively creates the file if it doesn't exist, and does no harm if it does.  We are paying an extra open (with O_CREAT down at the system level) in return for getting good behaviour out of 1.8.7 systems.  This should be completely race-free and safe.
Same here, if Rational is already rounded (@denominator == 1), we can return immediately, just like the 0 case. Also probably checking @numerator for 0 is faster than self == 0.
fair enough `span#` is noisy.
s/numEdges/numIntsToRead/ or something like that...
I was burned recently by not unit testing the Date Element values (the regex pattern was bad). You might consider doing something similar instead of this pattern equals test: https://github.com/zendframework/zf2/blob/master/tests/ZendTest/Form/Element/MonthTest.php#L61
most component in zf2 using ternary for simple if else.
@spako These functions were there already, just tabbed incorrectly, so I fixed that. @Rynoh pointed out that they are missing param tags so I'm going to add those, but I didn't actually write any functions except the last 2.
I'm assuming you edited this comment, as it's different from the email notification I received...

Yes: choose `master` for production releases, `develop` for continuing development, and use the defaults for the various prefixes for features, hotfixes, etc.
I like the addition of this augeas, but the problem is that silly mysql allows for _ and - to be used both for defining variables. Have you tested wether this works? Also, I don't see the proper subheaders in use here, or does the mysql lens take care of that? ie. [clien] and [mysqld] entries in my.cnf.
Lastly, we'd need to make the binlog destination variable.
This will break hard if eventemitter2 does not exist. I was thinking you could perhaps export a method that allows one to feed in an EventEmitter compatible class, and fallback to require('events').EventEmitter?
Removing couchdbkit debug toolbar panel - this is installable via requirements now - no need to have a debug tool be part of the submodules for no reason.
Would be good to mention it is WIP and only in qt and api may change without any warning.
This one should be removed
is this valid for 2.x and 3.x ?
These instructions could be easily generalised to be for any datasource.

Though, I am wondering if we wouldn't be better off using a deployable datasource.
Yeah, modifying standalone.xml is going to be a bad route, and not even the recommended approach.  Do you know if the CLI would allow me to make those changes - modifying log settings?  If so, I could write a script to do it, but then we are expecting the user to be able to execute the CLI script.  Is that any better?
Capitalize and punctuate.
This is in case the baseplayer's time is changed before youtube is loaded, I had to make a decision on which one takes priority. I decided on user interaction > fragment start.

I'll play around with removing it.
DM is an asynchronous framework and you cannot rely on retriever to give you an entire dataset before ingestion has ingested the dataset.
These lines are commented out because ingestion does not actually ingest the mpl dataset.  http://cl.ly/image/1q0q1d282f2b

Also, the MPL param dict def reads as follows:
```
mpl_graph: ['mpl_graph'] # will never go into a coverage, do not try to ingest, it will die, painfully.
```
If this data needs to be ingested, the parameter dictionary definition will need to be altered.
This means the status options only show after you save the work and go back to edit it. In terms of workflow, it might be preferable to remove this logic and always present the options -- there are definitely cases where someone would want to select the Abandoned option when first posting a work.
це все не дефолтні параметри?
On line 47, you check if title exists and only create an item if that is true. If there is a page that contains `<input id="__ZoteroType" value="book" ...` but does not contain a title, it will pass detectWeb and Zotero will display an icon in the URL bar, but once clicked it will not create an item. You should include a check for title (like on line 47) in detectWeb so that Zotero does not display icon for pages with no titles.
不会啊，再不行把
$("input.select")缓存起来，我看效率比你给的代码高啊
"To learn how to install a custom theme and modify it yourself, see", or something like that
IIRC, there's no official way for phpDoc to specify the type of array items in `@param` and `@return`, anyway the most used notation I've seen around would imply to use
```php
/** ...
* @return Block[]
*/
```
Tu sa to meno nezhoduje.
The perprocessor conditional in the middle of a function arglist is quite ugly, yeah ;)
всегда ли тут правильно отработает?
does this syntax auto save `repo` ? If I used this in production would it work? I normally manually call `repo.save` after, i've never checked if this would work...interesting if it does.
response_content_type to avoid naming collisions maybe?
guys don't want to be mean but I made this change yesterday :D  https://github.com/mozilla/Addon-Tests/pull/527/files#L0R225

So the implicitly_wait(0) was removed :smiley:
I am not sure that this will be a very reliable representation of the page being loaded.
Testing adding comment
fair enough we are restricting in the RequestBuilder, so changed as per ur recommendation
If we're going to mount it at '/', then we need a deprecation warning, right?  Obviously it wouldn't go right here, but we should probably go ahead and put one in?
No, the uniqueness is handled by the timestamp, pid, thread-id, and counter.  This is just for usability.
Good point. I guess it's a foible of my jumping between branches.?
That's what all the other ones do and I wanted to do it the same way. Other than that, there's no reason. Should I compare directly?
Can you explain what the recent metadata is ?
It feels like there is quite a bit of overlap here with setRole
We should also check some additional properties on the first comment, like body, etc.
We'll have that anyways when creating a new comment object instead of deleting the properties.
The comment can be changed. It is a private method, so it shouldn't be used ;)
whitespace and use single quotes instead of double :)
Order your includes carefully as they are in other cyphesis files. Local includes should be at the top, then others from this package, the libraries we use, and finally the standard library and system headers.

In fact you don't need to include <string> is it is already included in Shaker.h
This looks like something that should be I18n'd. Do you need a timestamp helper? Lotus provides all the I18n data we need to translate dates.
`else if` -> `elseif`
`AND` -> `&&`
это сравнение указателей, более правильно использвать [myString1 isEqualToString:myString2], пруф: http://stackoverflow.com/questions/3703554/understanding-nsstring-comparison-in-objective-c
Необязательно. Можно даже в этот метод внести изменения, чтобы он в любом случае менял значения массива, но в пределах положенных 100 объектов. Здесь, на гитхабе, полно способов разбиралось, еще один был а обсуждениях к проекту на hexlet. Можете посмотреть, как сделал я. 

P.S. В указанном вами примере действительно Fail, программа по идее скомпилироваться не должна.
Быстрее не будет + не будет работать. )
Массив можно объявить внутри метода +(NSArray*)nucleotides без инициализации nil'ом тогда случайный доступ к массиву из вне метода будет невозможен. В данной программе не критично, но в большом проекте могут возникнуть сложности с поиском ошибки т.к. метод и переменная имеют одно имя.
Вам нужно добавить проверку на исключение случая, когда объекты идентичны
Я внимательно посмотрел ваш метод. ТЗ, которое говорит, что метод должен заменить x процентов, говорит вам, что передавать нужно процент, а в методе считать, какое количество элементов поменять исходя из этого процента. Вы считаете количество, но не ограничиваете процент. До сих пор не понимаете, в чём ошибка?
Sure but the transports don't really need to know about sequence ids.
Are you sure this doesn't break the role switch UI? Same with about. IIRC these use different layouts. Just making sure.
Should these files have the Obvious copyright notice?
I'm not sure if we can access CefSettings in the render process. I'll check. For now I just set CefSettings.locale in init for mac and win, but they don't actually work due to the CEF bug with navigator.language.
Sorry, just caught this: these are still MD5s.
This syntax looks iffy... does it really run?
This gets used in the following way

```
function openFile() {
  chrome.fileSystem.chooseEntry(function (entry) {
    if (chrome.runtime.lastError) {
      showError(chrome.runtime.lastError.message);
      return;
    }
    clearError(); // used for UI not actually clearing chrome.runtime.lastError
    setEntry(entry, false);
    replaceDocContentsFromFileEntry();
  });
}
```
I think using `Completer.completeException()` will be better and using `Completer.complete()` for non errors. So a call might  look something like this

```
  Future getBackgroundPage() { 
    Completer completer = new Completer();
    js.scoped(() {
      
      void callback(object) {
        // TODO(adam): log this value and figure out its proper runtime mapping. 
        
        lastError
        ..handleException((error) {
          throw "getBackgroundPage $error";
        })
        ..then((success) {
          completer.complete(object);
        });
        
      };
      
      js.context.getBackgroundPageCallback = new js.Callback.once(callback);
      var chrome = js.context.chrome;
      chrome.runtime.getBackgroundPage(js.context.getBackgroundPageCallback);
    });
    
    return completer.future;
  }
```

Honestly this type of error checking seems funky but should not be a problem using the pattern above.
I'm not sure how to take that comment.
Oh, I was commenting on the console.log out. Let us know if you get it sorted.
Curious why an exception for this. This is an expected scenario; right?
Thanks! Was unsure about that. I'll change it today evening, if you don't mind.
hemisphere

Also, could we display both easily as an option, or would this be a pain?
It's Lucene's job, which can be tweaked however you like starting from query parameters to modifying the scoring algorithm used while indexing. http://lucene.apache.org/core/3_6_0/scoring.html#Introduction gives some basics.

Currently we rely on defaults. However, in addition to a simple keyword search I use boosting for names matching the whole phrase as given.
"reminds of in" => "is similar to"
What @parndt said, but it's also worth noting that you're not changing the contents of `@page.content_for(:blah)` with this, so using `html_safe` is semantically incorrect. It's far better to use `raw`.
If the only thing you need to escape inside a string is double quotes why not just use a single quoted string?
I like this abstraction, but it is quite unreadable for classic JSF developer.
My concern is that it's not immediately visible what is the actual XHTML source.

I'm not strongly advocating nor discouraging you from this principle,
but we need to come with unified approach across whole test suite.

I would like to discuss this on tomorrow's team meeting.
Ok then :). We can worry about fixing it later, and then we'll fix it in both places. I've never loved the upload document either (for the same reason - I don't like having the paths inside my model).
Minor typo "to specific" should be "to specify".
Also "LocalDiskDataSink" is a strange name for something that keeps its data in memory, right?
Why this Exception?
Чо ж ты так const не любишь. На следующей строчке тоже пригодится.
`x-leechcraft/` лучше использовать для такой внутренней фигни.
Няргх, переносы строк же!
no default value here ?
`setVisibleColumns(array $visibleColumns = array())`
it looks like a mistake, i'll take it off, although it could be a nice new feature idea.
Ruby Gems are not all modules. You could potentially turn a module into a gem, but it doesn't have to be that way.
The data needed to be slightly randomized or the threshold in the function would delete it. This is why that looks odd.
"in" the end ? or "at" the end ?
Having two sections for two basically similar options is a bit to much for my taste.
It will return a 400.:

``(HTTP 400) Unable to migrate instance 3633 because it is already migrating.``
Thanks for catching this... the delete was actually failing because the status was not BUILDING and I should've caught this.
I also fixed a bug where I put the logic for "status" into "is_building".
Pointless javadocs here?
This isn't strictly a mock, because it does wrap an actual cache. Maybe ControlledCache would be better (see ControlledRpcManager, ControlledCommandfactory etc.)
Hahaha, we are supposed to be serious for these code reviews!
Seems like useless empty line :)
@arrbee should I be pointed at development?
This is why we put ourselves through this torture
Could we just use the builtin datetime for this? (showing my naivety here). If a user specifies a string format as a kwarg, use that with [strftime](http://docs.python.org/library/datetime.html#datetime.date.strftime). If not, let ```dateparser``` do its (frightening) magic.
Nit: Looks like prevailing style for comments is a space after the # character
Could you please try again? you should see the list scrolling at something like 10fps until you exit the app.

Consider it also outputs "QGLWindowSurface: Flushing to native child widget, may lead to significant performance loss" when I don't use a QGLWidget as viewport...
again, what does the messge want to say to me?
+1.  Schema supports it now
I'd like to see the method signature become:

``public function request($method, $url, array $headers = array(), $content = null, array $options = array());``

I find that I almost always have to set headers (e.g. Accept, Content-Type) when sending requests to REST APIs.  I think that moving $headers before $content would help to make it easier to send GET/HEAD/DELETE requests.  Doing it this way, Guzzle could just add a new ``request`` method to its client and implement the HttpClient interface.
Adicionar Href nesse e em todos outros membros.
@christianv Indenting for the above 3 lines
If it gets here this means that the page can be viewed. We can just do `return true;` instead of `return canView`.
This is not really what the PR tries to do as the aim is to make conversion from non-option APIs to option APIs fairly easy. Something like this:

```php
class ExistingRepository
{
   public function findSomething()
   {
       return something;
   }

  public function findSomethingOption()
  {
      return \PhpOption\LazyOption::create(array($this, 'findSomething'));
  }
}
```

We could additionally support returning explicit option objects by introducing a type check there. Would that be alright?
Is there a reason why we are not using the entwine event handler here, so we could get the benefit of the entwine taking care of the mem-leaks?

```js
'ontabsbeforeactivate': function(event, ui) {
  this.riseUp();
}
```
Making "added" unsigned will make lint happier, it's mostly used in an unsigned manner.
why is this in #if 0? If we're not using it let's actually get rid of it.
Are you sure ``false`` has the correct type as "Boolean" is not a sub-type of "string"?
Ha ha ha ha. Again. what's the way of modifying a pull request? I think such scenario is common, how shall we deal with it?
"relevan" => "relevant"
ah yes!
Este método se va a ejecutar varias veces por tick. Lo suyo sería que se utilizase aritmética en potencia de 2 para que los cálculos sean más rápidos. Aun así, es más rápido un acceso indirecto a memoria que todos estos cálculos que propones.
The `_.clone` is useless here as `options` won't be altered.
@technoweenie see github/github-services#402
Ok, thanks. I have fixed this in my gsoc-fixes branch, also pull request #102.
Should we do the same strategy as we did for ruby (unused options dictionary, for future use)?
Hm, I would use prop also here? No?
The format he was using before was not standardized JavaScript format which JavaScript could parse.

In RL you would already know how to do all that 15 minutes and this would be it. :-) Once you get used to it, it is fast. Fork, branch, fix, commit, pull. 5 minutes.
Add TODO about displaying error message.
The docstring is a bit confusing with respect to the code. An example in the docstring doesn't mention attribute "description" which appears to be required, but does mention "time" attribute which is not used in the code.
1. usually the convention is to always use parenthesis when calling methods (e.g. include? here)

2. Use `Hash#slice` from ActiveSupport to simply this line.

3. I would assign the array of symbols to a variable, e.g. `customer_options`
You should add new values to the AnnotatorType enum, and bracket the adding of these annotators to the pipeline with an appropriate check like the ```if (this.annotatorFlags.contains(AnnotatorType.PART_OF_SPEECH_TAGS))``` check above. That way, only the annotators that actually need these things in the pipeline will have to run them.
ist super async! coole sache :)
PHP has curl functionality
http://php.ca/manual/en/book.curl.php
It looks like the newick.py file is missing
Yeah, confirmed, this makes no difference either.
the ranking concept makes a lot of sense. nice one.
wtf are we writing C-code for?  just glanced, but are we trying to capture everything after the last slash?  if so usually a regex would work, but in the special case of post-last-slash we can just abuse path manipulation functions, if not tell me what your going for cause this can't be the right way


if its just finding post-trailing-slash this could replace this whole loop nonsense
```ruby
  File.dirname(self_url_string)
```
no because select() is triggered on socket events
you should check this in the message method, rather than here, and make an error out of it.
after waiting is complete (no more spinner), perhaps we could include a check that verifies the user was successfully logged in.  Would that happen in higher level code?
why we base64 encode the name?
I'm trimming the right (i.e. the end) because that what you did in your original implementation

   value = _value.Substring(firstPos, _pos - firstPos).TrimEnd();

For skipping white-space characters I don't see that you escape them in you original implementation, so I've did same.
Why inherit from RoboHydraHeadMounted instead of RoboHydraHeadProxy? Don't you need all the functionality in it, and then just add the caching bit?
no, I use it because the maven command-line utility uses camel-case throughout. I thought this would make it more familiar to java-heads. I am happy to hcange it to snake-case if u feel strongly about it
I think this line is the problem. `writeArray` is an autoreleased object, so it shouldn't be explicitly released, right? Looks like you removed this line over on the original pull request.
It computes the Jacobian rows for discrete changes (ie., not continuous derivatives) that go into the variance-covariance estimate below. It's the outer terms in the delta method.
When I started working on the project I suggested @camertron to use methods defined with `rspec`'s `let` instead of regular instance variables. I think he liked the idea. You can read about `let` and `let!` [here](https://www.relishapp.com/rspec/rspec-core/v/2-4/docs/helper-methods/let-and-let) and [here](http://stackoverflow.com/a/5359979/357743) you can find reasons why in most cases it's better than using instance variables in specs.
Use HTTPS always when referencing external services so that code can be used also on HTTPS webpages (otherwise you will get mixed content warnings).
Unnecessary newline?
Oh, i'm sure there is (or at least I hope there is). Was just hacking it in quick.
Sure. I can look at doing it now as well. Not a huge deal.
Again, used existing code for consistency's sake. I'm not tied to this nor the previous implementation. If you would prefer I will defer.
il y a un pb avec le _however_. Je te laisse reformuler comme tu le sens
I began this work now.
because b3 doesn't exist; and this was failing locally: dev is the one in master currently, the one we need and b3 isn't released.

Or I missed something?
Is least available on RHEL or will we have to roll our own?
On Thu, Feb 23, 2012 at 2:46 PM, Dan Yamins
<reply@reply.github.com>
wrote:
>> +                    orig_result = result[0]
>> +                    assert hasattr(orig_result, 'keys')
>> +                    assert all([isinstance(x, tuple) and len(x) == 2 for x in result[1:]])
>> +                    assert ([hasattr(x[0], 'keys') and hasattr(x[1], 'keys') for x in result[1:]])
>> +
>> +                    return_val = []
>> +                    orig_result_return = handle.update(self.current_job,
>> +                                           dict(result=orig_result))
>> +                    return_val.append(orig_result_return)
>> +
>> +                    num_new = len(result) - 1
>> +                    new_ids = self.trials.new_trial_ids(num_new)
>> +
>> +                    for new_tid, r in zip(new_ids, result[1:]):
>> +                        spec, res = r
>> +                        new_rec = copy.deepcopy(self.current_job)
>
> SOunds good .. the only I think I want to understand from you before being ready to test is what you want me to instead of checkpoint ....
>
I was imagining the bandit could call ctrl.trials.insert_trial_docs directly
On Wed, Oct 3, 2012 at 2:16 PM, Ayose Cazorla <notifications@github.com>wrote:

> In Rakefile:
>
> > +  desc "Update chef-solo.tar.gz"
> > +  task :tarball => :clone do
> > +    puts "Updating chef-solo.tar.gz file..."
> > +    run_quiet "tar --exclude-vcs -zvcf chef-solo.tar.gz cookbooks"
> > +    puts "Done."
> > +  end
> > +end
> > +
> > +desc "Obtain cookbooks and update the chef-solo.tar.gz file"
> > +task :update => 'update:tarball'
> > +
> > +namespace :install do
> > +  desc "Do I have enough permissions?"
> > +  task :root do
> > +    user = `whoami`.chomp
> > +    if user != 'root'
>
> You can use Process.uid == 0.
>
>
>
I was figuring out it should be a better way, but I forgot to check it.
Thanks! :-)
What do you think about the change? Shall I merge it? (with that change
you've just suggested?)
Точка, запятая, другие знаки препинания.
Сначала фильтрация, потом сортировка
Total (nanos): 6024410520
Total (msecs): 6024410
Total (millis): 6024
Total (seconds): 6
Single (nanos): 60244105
Single (msecs): 60244
Single (millis): 60
Single (seconds): 0
Сначала сортировка, потом филтрация
Total (nanos): 7690280817
Total (msecs): 7690280
Total (millis): 7690
Total (seconds): 7
Single (nanos): 76902808
Single (msecs): 76902
Single (millis): 76
Single (seconds): 0
Also you are using an assignment operator and not a comparison one.
「の」がいらん？
Yup. Cliff requested that only he has the ability to add codes.
Maybe I missed something here, but why has this been removed?
The idea is that mask is either indices or bool. If it is indices, we return it, otherwise we might create indices.
``np.issubdtype(np.bool, np.int) == False`` is true and the exact intention.
I could have also said ``if not mask.dype == np.bool``
I could also check both and throw an error if the array is neither bool nor int.
Cool, I didn't know this function. Why don't we use it more often?
@vene @GaelVaroquaux I am a little confused as well for "Seeding RNG ...". 

Another thing is have I done it right here?
Ahhhh. I can certainly change the arpack calls to use scipy utils :)
FWIW I wouldn't have added a toggleSection class here as we don't seem to be using this and it could just cause us pain in future (for instance mobile site might introduce a class toggleSection and add some css rules for it)
I can change these 3 properties but this means that old data is invalid (unless we decide to look for both).
It is a test for aliasing template itself.
This is fine, it does the right thing even if `*this == eventPtr`
Agree, but since the log is more optional than the arch we building for I've added the parameter before. All corresponding changes made.
Macros and file stat-ing moved to utility functions, let me know what you think.
Yes, Hibernate search doesn't have a dependency on lucene regexp. but the lucene module could be considered a generic one, so it could make sense to add it anyway.

Any thought about it, @Sanne?

How hard would it be for a project  to use a custom lucene slot instead of the one that we are creating? Is it possible to specify it in the manifest or in the custom jboss XML file?

I haven't tried yet.
uh, yes
yes, not a pressing issue
Interesting.  I don't have any issues with this on my end, in fact, my LDFLAGS contain only `-L<lib path>` portions, because `-I<include path>` commands should be put into `CPPFLAGS` as they are a C preprocessor directive, not a linker directive.  Do you know what is putting the include path into your environment?
I already bring these example to UX – I used all the examples provided by @ochameau in this mopad: https://jetpack.etherpad.mozilla.org/widget-in-navigation-bar
identation is wrong
You should keep this default at 1024 I think.
remove any code that isn't relevant to your test. You mentioned this is not your code.
@shacker the whole site, Allison told me to change it to this value
please don't commit this stuff
Agreed, will revert this part.
That is where things are today, all other UDP recvfrom modules do the same, we should tackle UDP scanning through another PR and fix all of the affected modules
Quite frankly I wasn't sure if it was necessary so I opted for less changes to the higher-level code and I wasn't sure if that was what u guys would prefer, altho I did end up making all those other changes in the end, so WTF, but originally I was trying to minimize

-Josh

On Aug 6, 2012, at 12:59, jlee-r7 <reply@reply.github.com> wrote:

>> @@ -43,6 +43,16 @@ def commands
>>        end
>> 
>>        #
>> +        # Returns an empty hash for an empty set of aliases.
>> +        #
>> +        # This method should be overridden to return a Hash with alias
>> +        # names for keys and alias values as the hash values.
>> +        #
>> +        #def aliases
> 
> Why is this commented out?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rapid7/metasploit-framework/pull/637/files#r1314000
I think this trailing comma breaks on 1.8.7.
Why did this change to context?  Shouldn't it be describe since its a method?
We should probably jump on a call with matt about this. It would be easier to talk about than through text!
Right. I tested the one from your DropBox, and it works perfectly. I wanted to show you the stack and my Gemfile to see if anything stuck out to you about how my app is configured.
Perhaps give this an explicit `@private` so people don't wonder if it belongs in the doc.
why? because in the Raphael.sketchabot.js (the file that got deleted) I was directly passing an array to this function and not an elem object. So I refactored it an made the fromArc function to take an array and not an element.
Can we make these script names constants so there is one place to change them?  Might consider adding them as string resources
We could use LINQ for this ?
Ah good catch with the final. About this no-args constructor, it is required by CDI as it needs to be able to create a proxy to it. But I'll a javadoc with a comment about this. 

Just for your information. Some of this has been refactored while adding the consumes support. For example, I've removed the formParam, headerParam, etc methods and there will only be a single param method. I should have a PR for this tomorrow, I just need to rebase on this work as it's based upon it.
Ah good call on the casting! And I'll move the warning to the top of the method. Thx
Need to add a YML file for the new name. (`apidoc/Titanium/UI/iOS/DocumentViewer.yml`)
Yes, it makes sure the view is not changed in the method.
`This is an intentional behavioral...`. Also what events fire on returning to active state?
put the `not` before `in`  easier to read.
well the line is too long now.
If something was wrong about the original version, couldn't this just be:
`connection.on('log', self.emit.bind(self, 'log'));` ?
Maybe "replaced by the value of the **named** environment variable"?
Just kill these comments altogether.
If an extra parameter is added to std.algorithm:sort to allow such a thing, and as long as benchmarks are unaffected. An alternative is to return temp, since this function currently doesn't return a value.
If the range is infinite, Range.emtpy is always false, no?
Can't people just write `takeNone(R.init)` themselves?
In fact, it's definitely the plan to add more, because things that aren't currently templated are supposed to be (e.g. the AA implementation). druntime is like any other library with regards to templates. If templatizing something is the best way to do something that it needs to do, then it's going to be templatized. If it's not, then it's not. There's nothing special about druntime that means that it will or won't contain templates, and it already _does_ contain templates in some places.
nit: use /** */ comments for all dartdocs (consistency)
Where do you end the conversation?
I believe we can count on a `wipe` being followed by a `finish`. So this is just for cleanup.
yep, I think that would be a good idea
If they set the Xcode SDK to 10.6 compile they get the legacy player, it was designed as a transparent way to switch to the new version going forward

but 'm happy to do it with OF_ENABLE_LEGACY_QUICKTIME - except that if you are compiling against 10.7 or 10.8 that flag won't work
Is it really a different format? imho the URL ought to look like `/registration/registrars/1/full`
sounds better indeed
Why removing comments ?
Ah, and then you can replace the addJeader validation that was removed in above in HttpCallContent (because right now your are passing ints and floats)
leading tabs vs. spaces. Please correct this and any other instances to use tabs
Oh, wow. Lots of little distros based around arch. https://wiki.archlinux.org/index.php/Arch_Based_Distributions_(Active)
> pause
> IsPlaying_ = true;

Наркоман шоле? Переобзови переменную.
Do we need to `return true` here?
Are you sure, that param serialization would work after this? (I'm not. Had problems with serializing arrays to yandex-request)
Maybe "special" serialization (with array-escaping) is not needed anymore. 
But we should be careful.
If destroy is deprecated then this needs to be updated. Also it needs to be rewritten to ddoc-style syntax, e.g.:

`/// $(RED Scheduled for deprecation. Please use $(LREF destruct) instead.)`
Oh, we commented at the same time. I was convinced.

But it is hard to understand. I want to propose writing a small utility function in `object.d`:

`@property T staticCast(T)(TypeInfo obj) { return cast(T)cast(void*)obj; }`

And use:

`rhs = base.staticCast!TypeInfo_Const;`
I think we need to explain what each of these is for - or at least refer them to the javadocs for RedisTemplate.
Apparently you haven't replaced these rules with anything.
This should still be overridden, not overwritten.
What about using the PHP escaping function here instead?