Scripts fail to detect when a tool crashes
https://bugs.webkit.org/show_bug.cgi?id=82659

Reviewed by Mark Rowe.

Have exitStatus() detect when the process fail to exit cleanly
(possibly because of a crash), and return a non-zero exit code
in that case.

* Scripts/VCSUtils.pm:
(exitStatus):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
REGRESSION (r110065-r110080): Content drawing outside overflow: hidden at ynet.co.il
https://bugs.webkit.org/show_bug.cgi?id=82129

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html
       fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html
       fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html
       fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html
       fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html
       fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html
       fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html
       fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html

This is a regression from r110072. I wrongly thought we should call ensureLayer if we create our RenderOverflow.
However the current overflow code removes the before and start overflows (like in horizontal writing mode with ltr direction,
we never have a top or a left overflow). Because of that we would not get a RenderLayer as expected and the overflow clip rects
would be wrong on our RenderLayer children.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::addLayoutOverflow):
Moved the ensureLayer() call after the check that we do have some overflow but before we remove the overflow in some directions.

LayoutTests:

* fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
* fast/overflow/before-after-overflow-hidden-horizontal-writing-mode-tb.html: Added.
* fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
* fast/overflow/before-after-overflow-hidden-vertical-writing-mode-rl.html: Added.
* fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb-expected.html: Added.
* fast/overflow/start-end-overflow-hidden-horizontal-writing-mode-tb.html: Added.
* fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl-expected.html: Added.
* fast/overflow/start-end-overflow-hidden-vertical-writing-mode-rl.html: Added.
Added 4 ref tests that should cover the 4 different values of (hasTopOverflow, hasLeftOverflow)
in RenderBox::addLayoutOverflow.

* platform/chromium-linux/fast/box-shadow/shadow-buffer-partial-expected.txt:
* platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt:
* platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt:
* platform/chromium-win/fast/block/lineboxcontain/font-expected.txt:
Rebaselined those tests on Chromium linux (new layers).

* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wk2/Skipped:
Skipped the previous tests on the other platforms.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Skipping crashing workers tests.
Filed https://bugs.webkit.org/show_bug.cgi?id=82660 to track the issue.

* platform/mac/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Source/WebCore: rollout r112484, r112545, r112574
https://bugs.webkit.org/show_bug.cgi?id=82662

Unreviewed, build fix.

this appears to be producing some questionable differences on
the apple mac bots, and possibly one test on chromium linux.

* css/mediaControls.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
* css/mediaControlsChromium.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
* html/shadow/MediaControlElements.cpp:
(RenderMediaVolumeSliderContainer):
(WebCore):
(WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer):
(WebCore::RenderMediaVolumeSliderContainer::layout):
(WebCore::MediaControlVolumeSliderContainerElement::createRenderer):
* html/shadow/MediaControlElements.h:
(MediaControlVolumeSliderContainerElement):
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::create):

LayoutTests: rollout r112484, r112545, r112574, r112575
https://bugs.webkit.org/show_bug.cgi?id=82662

Unreviewed, build fix.

* media/video-controls-rendering-toggle-display-none-expected.txt: Removed.
* media/video-controls-rendering-toggle-display-none.html: Removed.
* platform/chromium/test_expectations.txt:
* platform/mac/Skipped.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Skipping 5 failing webarchive tests.
I filed https://bugs.webkit.org/show_bug.cgi?id=82665

* platform/mac/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Skipping plugin mouse events tests failing on Mac platforms.
The issue is tracked by https://bugs.webkit.org/show_bug.cgi?id=82668

* platform/mac/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Update CSS Exclusion wrap-flow values left & right to start & end
https://bugs.webkit.org/show_bug.cgi?id=82366

Source/WebCore:

http://dev.w3.org/csswg/css3-exclusions/
-webkit-wrap-flow now takes the values start and end rather than
left and right. Updating the code to reflect this. Functionality
is covered by existing tests.

Patch by Bear Travis <betravis@adobe.com> on 2012-03-29
Reviewed by Andreas Kling.

* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator WrapFlow):
* rendering/style/RenderStyleConstants.h:

LayoutTests:

Updating test values for the wrap-flow and wrap shorthand property

Patch by Bear Travis <betravis@adobe.com> on 2012-03-29
Reviewed by Andreas Kling.

* fast/exclusions/script-tests/wrap-flow-parsing.js:
* fast/exclusions/script-tests/wrap-parsing.js:
* fast/exclusions/wrap-flow-parsing-expected.txt:
* fast/exclusions/wrap-parsing-expected.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Update expectations w/ crash information after r129689 has landed.

Unreviewed, expectations change.

Also delete what appears to be a bad baseline for the fast/text test.

* platform/chromium/fast/text/international/spaces-combined-in-vertical-text-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
InputType attribute changed functions should happen after the attribute change
https://bugs.webkit.org/show_bug.cgi?id=82644

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2012-03-29
Reviewed by Benjamin Poulain.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Skipping 3 inspector tests on Mac.
I filed https://bugs.webkit.org/show_bug.cgi?id=82671

* platform/mac/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Rebaseline fast/js tests for Chromium where the new results are
clearly more correct or the differences are just the error messages
V8 uses that are different from JSCs.

* platform/chromium-linux-x86/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-linux/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-mac-leopard/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-mac-snowleopard/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-mac/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-win-vista/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-win-xp/fast/js/large-expressions-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/js/large-expressions-expected.txt.
* platform/chromium-win/fast/js/large-expressions-expected.txt:
* platform/chromium/fast/js/JSON-parse-expected.txt:
* platform/chromium/fast/js/JSON-stringify-replacer-expected.txt: Added.
* platform/chromium/fast/js/Object-create-expected.txt: Added.
* platform/chromium/fast/js/Object-defineProperties-expected.txt: Added.
* platform/chromium/fast/js/exception-codegen-crash-expected.txt: Removed.
* platform/chromium/fast/js/function-apply-aliased-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/js/function-apply-aliased-expected.txt.
* platform/chromium/fast/js/function-bind-expected.txt: Added.
* platform/chromium/fast/js/kde/parse-expected.txt:
* platform/chromium/fast/js/object-literal-syntax-expected.txt: Added.
* platform/chromium/fast/js/object-prototype-properties-expected.txt: Added.
* platform/chromium/fast/js/regexp-caching-expected.txt: Removed.
* platform/chromium/fast/js/regexp-test-null-string-expected.txt: Removed.
* platform/chromium/fast/js/reserved-words-as-property-expected.txt: Added.
* platform/chromium/fast/js/reserved-words-strict-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Get rid of Geolocation::positionChangedInternal(), use positionChanged() directly
https://bugs.webkit.org/show_bug.cgi?id=82543

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-03-29
Reviewed by Andreas Kling.

After the change to client based geolocation, the method positionChangedInternal()
is called only by positionChanged(). This patch remove this extra indirection.

* Modules/geolocation/Geolocation.cpp:
(WebCore::Geolocation::positionChanged):
* Modules/geolocation/Geolocation.h:
(Geolocation):
* WebCore.order:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Skipping http/tests/xmlhttprequest/range-test.html for Mac platforms.
I filed https://bugs.webkit.org/show_bug.cgi?id=82672

* platform/mac/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
new-run-webkit-tests: crashes when it fails to decode a stack trace
https://bugs.webkit.org/show_bug.cgi?id=82673

Unreviewed, build fix.

We are assuming the stdout/stderr output from the driver is utf-8
encoded when we get stack traces; this may not be a valid
assumption generally, but if we do get strings that aren't valid
utf-8, we would crash. Now we will ignore any decoding errors.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port._get_crash_log):
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase.test_get_crash_log):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed build fix for non-x86 platforms.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitSlow_op_mod):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Heap-use-after-free in WebCore::InlineFlowBox::deleteLine due to fullscreen issues.
https://bugs.webkit.org/show_bug.cgi?id=82055

Reviewed by David Hyatt.

No new tests; fixes fuzz test crasher which is not reproducible in DRT or WKTR.

When a RenderFullScreen object is inserted between a child and parent renderer, make sure the
parent renderer deletes its line boxes by calling setNeedsLayoutAndPrefWidthsRecalc().  This
forces its InlineBox renderers to be removed from the line boxes and their parents in the correct
order, fixing a double-delete crash.

The same is true when unwrapping the RenderFullScreen object, and when creating and inserting
the full screen placeholder.

* rendering/RenderFullScreen.cpp:
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
(RenderFullScreen::createPlaceholder):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
remove support for junit-style xml output from test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=82279

Reviewed by Eric Seidel.

This was added when we were looking into integrating w/ Jenkins
rather than buildbot, but I believe that project got shelved, so
this is unused. We can always add it back in later as necessary.

* Scripts/webkitpy/test/main.py:
(Tester._parse_args):
(Tester._run_tests):
* Scritps/webkitpy/thirdparty/__init__.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Simplify reporting a main resource error to DocumentLoader and
FrameLoader.
https://bugs.webkit.org/show_bug.cgi?id=82649

Reviewed by Adam Barth.

No new tests, no functionality change intended.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::mainReceivedError): Remove isComplete parameter,
    since it was always true. Call FrameLoader::receivedMainResourceError,
    instead of the other way around.
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedMainResourceError): Remove isComplete parameter,
    since it was always true. Merge in most of mainReceivedCompleteError().
* loader/FrameLoader.h:
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::receivedError):
(WebCore::MainResourceLoader::didCancel):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Restored change log entries that were accidentally deleted in r104276

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, expectations and baselines updates.

* platform/chromium-mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@112604 268f45cc-cd09-0410-ab3c-d52691b4dbfc