labofsahil/github-event-dataset-2012 huggingface dataset:
according to the spec, the redirect_uri in this request must match the parameter passed during the start of the authorization flow which may differ from the client redirect uri.  I believe it is acceptable for the redirect_uri during authorization to differ from the redirect_uri set on the client if it is a subpath of the original.

ex: 
client.redirect_uri = http://localhost
authorization_code redirect_uri = http://localhost/my/callback

http://tools.ietf.org/html/draft-ietf-oauth-v2-23#section-4.1.3
"ensure that the "redirect_uri" parameter is present if the "redirect_uri" parameter was included in the initial authorization request as described in Section 4.1.1, and if included ensure their values are identical."

I think the only way to solve this issue is to store the initial redirect uri on the authorization code database record and then compare it to the request param.
New drivers work fine for me and my layout is different than yours.
Isn't _dim a constant? It is not used in the class and is private, so I guess we can remove it, isn't it?
Same thing here. Please consider the style suggested by Sphinx: http://sphinx-doc.org/rest.html#lists-and-quote-like-blocks
The style of this select is quite different with that of the "Recently Used" select. I suggest we make them the same style, preferably use original style, or change to the new style in another commit
Why not just call it what it is, "selector"?
Ok let me try the direct injection method.
Alright, it should probably be encoded then.
Please add comment `If optional is True, None values will be returned without validating.` This function and its converter twin have a relatively high amount of conditional logic and abstraction for their innocent-sounding names. (That's not a complaint, in fact I think I wrote them this way...)
In IntelliJ you can configure inspections to warn against this.
document the busy waiting
Listen does not extend RemotingCommand (which I assume it should?)

Also, I prefer to pass the transport in the constructor instead of in a message (in Props).
will do, thanks for pointing it out
Shouldn't this throw an NotYetImplementedException?
just do: message.asInstanceOf[AnyRef]?
I second this concern. Why do we need a cache? Is the performance of node lookups critical?
Don't use symbols, they are registered in a global object
On `ActorSystem` it's not implicit right now, which is why I haven't marked it implicit in `ActorRefFactory`.
Should it be implicit in `ActorSystem` as well?
for(m <- msg if m == "DIE") context stop self
I haven't played much but I think ids get stripped; and I've seen others use `name`, it's pretty safe and works; even works nicely on the new npm site: https://npmjs.org/package/traversty#first
The group with the '|' in it isn't captured, so we just get the for words from the RE.  Maybe we should define the number of groups as a constant here?
Looks complete? Is not called anywhere, can we delete it?
I would say go for lower than that :)
Did you forget to push modification to MRY that doesn't use this deprecated class?
Oh, whoa, didn't catch that patching `runner._steps` happens outside of tests. Don't do that!

The whole point of the roundabout way of fetching step definitions by running the script with `--steps` is to make it simple to write mrjob scripts in other languages. In theory, all we have to do is give `mrjob` a way to infer the interpreter to run from the script's file extension, and it'll be possible to write a `mrjob` script in whatever language, and launch it from Python. The performance hit of starting a subprocess is small compared to the overhead of starting up Hadoop (not to mention running the MapReduce job), and if you just want to test quickly, that's what inline mode is for.

It sucks that this slows down tests, but really, that's the tests' problem. If all the tests that run jobs need to inherit from a common base class to patch `runner._steps` so that they can run faster, they should do that, or they should use `inline` mode.
OK corrected
wow, that's weird ... github attached this comment to the wrong line.  I reloaded the page and the comment had moved!
I'm not familiar with writing JSON/REST APIs, but I would expect that the status code and message would just be read from the HTTP response headers, rather than also needing to appear as a JSON element.  Or have I missed a subtlety?
I'd prefer something like this so you don't have to define all your events at once.

```javascript
if (!this["on_" + name]) {
    this["on_" + name] = [];
}
this["on_" + name].push(fn);
```

That way, you can do stuff like `on("change:name", this.renderName)` or `on("change:address", this.renderAddress)`.
Idiomatic Objective-C code (such as that provided by Apple) should not use `is` getters with dot syntax. This should check `self.editable` instead.
Or you could use a value transformer, but even I forgot how to do that, so I'll make the change later in life...
Hi,


   Great, I rewrite and send.



Em 13-06-2012 20:01, Dickson S. Guedes escreveu:
>> @@ -16,6 +16,13 @@ Then open a new terminal or type:
>>
>>   and voila!
>>
>> +
>> +Depends
>> +-------
>> +
>> +If to get PostgreSQL trunk version, you need git to pgvm take of repository git.
>
> I got what you mean, what about something like:
>
>
> `pgvm` has the following dependencies:
> * `git` in order to get PostgreSQL trunk version
> * `bash`
> * ...
> * ...
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/guedes/pgvm/pull/1/files#r981143

-- 
Fernando Ike
http://midstorm.org/~fike/weblog
copy paste mistake?
If it's not a problem I'd be inclined to keep your version. It adds a small bit of overhead but is clearer code.
хочется doxygen-комментариев
This call will try to cast nil: `self.current_thread_backend = nil`, but it's not a public API, so it should be ok to use `name && cast_backend_name_to_module(name)`.
The current implementation prepends both prefixes "a" and "t" to the index.
Purpose of reverse_sql_order is to reverse current order directions
So if we have :asc we need to change to :desc, etc
Yes. Please remove all the tests to `split_paragraphs`
@pixeltrix clean enough

Than maybe we should support `:if` and `:unless` there. wdyt?
Yup, exactly :). Thanks.
We will need to add backward compatibility to `page_cache_extension ` and deprecate it
no, Undefined != Undefined (because it is supposed to behave like Double.NaN)
On 09.04.2012 19:59, Christopher Smith wrote:
>> +from sympy.polys.monomialtools import (
>> +    monomial_mul, monomial_lcm, monomial_div, monomial_deg, monomial_divides
>> +)
>> +
>> +from sympy.polys.distributedpolys import (
>> +    sdp_LC, sdp_from_dict, sdp_to_dict, sdp_add, sdp_strip
>> +)
>> +
>> +# Additional monomial tools.
>> +
>> +def sdm_monomial_mul(M, X):
>> +    """
>> +    Multiply tuple ``X`` representing a monomial of `K[X]` into the tuple
>> +    ``M`` representing a monomial of `F`.
>> +
>> +    Multiplying `xy^3` into `x f_1` yields `x^2 y^3 f_1`:
>
> It would be nice to use consistent notation; in `xy` there is not space but it means multiply whereas in `x f_1` the space means multiply.
>

I generally use spaces only to increase clarity (note that they 
disappear in latex...). For example I think `x^2y^2` looks hideous, 
whereas `xy` or `xy^2` does not.

Do you feel this is important?
These are from here:

        # Fresnel S
        # http://functions.wolfram.com/06.32.19.0003.01
        # http://functions.wolfram.com/06.32.19.0006.01
        # Fresnel C
        # http://functions.wolfram.com/06.33.19.0003.01
        # http://functions.wolfram.com/06.33.19.0006.01 

Should I put this into the code?
Do we want links like these inside the code?
``args[0]`` (unless I'm missing something)
You may wonder, but spaces in this fragment have been appended bwfore me, I have replaced them by tabs in this commit.
Compare code with yii/master:

https://github.com/yiisoft/yii/blob/master/framework/web/CClientScript.php
I do not see a release for the ivar correlating to this property in the dealloc of this class. In fact, this class is a leaky mess. Every retain property needs a release in the dealloc. 

Please also run analyzer and find the other leaks.
This is only applicable to you and Oliver. ;)
Yeah this is a bad function name because it's actually writing out tab delineated lines (not comma separated). Maybe a better name here is `url->file`.
this is wrong. should be `self.cache`
Good idea. I'll add a TODO in the pebblestack.org repo.
I agree with @fabpot.
There is 3 "`" a the end of the line
What happens if the fd is closed, then reopened and added with the same watcher?

Also, this effectively turns the NULL check below into dead code. Probably not what you want.
This the the sitra arha or Klipot.
I deleted this file.
Testing cruft to be removed?
This would be clearer as `core.index_page_title`. Currently, `core.index` doesn't tell me what this does.
I commented the lines out that are deleted by the function and do not appear in the result, so you can see easily which elements should be deleted and which are still there
No there was empty line before. Btw, this means I should remove the empty lines of all the files?
http://area51.phpbb.com/phpBB/viewtopic.php?f=119&t=42809
No assertions at all?
Indeed, should be up to the admin, no reason to limit this unecessarily.
Move this onto the WHERE line
With delegating ctors this could be initializer.
Logger does not _have_ to be tied to the back end.  If we want a logger to
be pluggable at all, it should provide the same mechanism though, and it
doesn't need the delegator pattern, we know from the get-go what methods
are available.


Peter Fitzgibbons
(847) 859-9550
Email: peter.fitzgibbons@gmail.com
IM GTalk: peter.fitzgibbons
IM AOL: peter.fitzgibbons@gmail.com


On Tue, May 29, 2012 at 4:17 PM, Andy Lindeman <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,17 @@
> > +require 'delegate'
> > +
> > +module Shoes
> > +  module Logger
> > +    class Log4j < SimpleDelegator
>
> I was also thinking about ease of adding a logger outside of the `shoes`
> gem. It seems like it should be possible to register your own logger
> without monkey patching our stuff.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/shoes/shoes4/pull/26/files#r895847
>
Strange.  Even though it's not used, Eclipse keeps auto-adding it. :(
```js
….map(Number)
```
Does the trick as well
While we are at it, let’s fix class names. This one should be ApcCache instead of Apc.
agreed - you can remove all of this from here. Simply call ```printPrescribedDrugs()```
review -- which of these ```requires``` are actually needed?
Ref [1]: http://docs.python.org/distutils/setupscript.html#installing-additional-files

[1] states that the installation directory is relative to the installation prefix.

Just want to confirm that this will place the files in the <i>.../site-packages/iris</i> directory ... I assume it will.
Don't think these are coordinates. Consider which should go in attributes.
I added an assertion explaining that you shouldn't try to assign anything to it. This is only ever intended to be a placeholder symbol that gets optimized out or ignored.
Is this line a no-op?
Intentionally checked in initial version of test with cluster and iv2 configs subtly commented out? When will these be enabled?
Actually, due to how differently devices behave this has been changed. (sometimes resize has to be ignored onfucos otherwise the UI would permentely jump (Experia Arc, SII)). 

So now the touchLayer only fires a 'reshape' event whenever it resizes/scrolls and ignores shaking internally.

$.bind($.touchLayer, 'reshape', function(){
if(document.body.clientWidth>=700)
$.ui.toggleSideMenu(false);
});
Thanks! New I had missed something! Added back in!
This is a hint to JSHint that the assignment is intentional, rather than a mistake.  I've surrounded this form on lots of other lines in our code.
Actually I'd expect the use of \xA0\uFEFF a third time would actually gain size, but I'll defer to @gibson042 on this one.
Oh, ha. @gnarf37 was just talking about spacing.
No need abs here, since function rand return an integer value between 0 and RAND_MAX.
For t_test_two_pooled_final, t_test_two_unpooled_final, and t_test_final, is there no need to check to return NULL as in t_test_one_final?
Lots of changes here seem to be due to rewrapping text. It would be good to keep such cosmetic changes separate from content changes.

BTW, I personally do not like manually wrapping LaTeX code. I instead prefer keeping paragraphs on a single line, even if GitHub does not wrap long lines and is therefore rather unusable as a diff tool. Rationale: With manual wrapping there is no usable diff tool (unless you accept that editing produces very ragged lines in the LaTeX source code). Without manual wrapping, there are at least external diff tools that do a good job.
You should be able to use the DX path here...  just assign the texture to the GraphicsDevice.  No GL code needed.
PEP8 allows both, and I can't bring myself to indent with anything else than multiples of four spaces.
I get `354fecde094f72523f26f7032b65f3aae7013eba` as a sha1.
I am not using enthought but traits and traitsui and believe surfer/viz.py  should read

try:
     from traitsui.api import View, Item, VSplit, HSplit, Group
 except ImportError:
     from enthought.traits.ui.api import View, Item, VSplit, HSplit, Group
This file is for testing the database schema changes, no need to add anything for other tests.
It's much easier to read output when the browser knows it's text. Also, it'll respect line-breaks
I corrected the my comment:
"#acknoledge one" => "#acknowledge one message"

Is it what u mean?
Apparently

>>> "1.0.10">="1.0.6"
False

Is there a better way of comparing version numbers like this?
Ja, find ich gut.
wg ignore, muss man prüfen
Sure - using the ternary operator would be cleaner. I was being explicit after I realized that ||= is not a good idea for boolean values ;-)
Why not? Follows the order of the initializer.
State building simplified in a614635c
Explicity undefs for radmon from 53862ff6c7 and 8c63a915e
No, exception - it is a error in process. But null is a "normal" state of process. I check null in the SMPPSession.java
It looks like this actually uses the first 80 characters, not the first 80 lines. You probably want
```javascript
var m = Zotero.Utilities.cleanDOI(lines.slice(0,80).join("\n"));
```
Colin and I had a quick chat about it and I don't thing there's a simple way of doing it without abolishing the semver representation of the version compatibility in solution data (if we want to do this comparison in couch). So I think for now it makes sense to at least have the os filtering and do the version filtering within the node app responsible. Hope that's ok?
No no, that's ok.  Go ahead and update your version and after it gets merged I can rebase my other changes on top of it, and then David can decide if he wants any of the other refactorings on my branch.
it's really `(/?v[0-9][0-9]?)?/?multi`, but that's gross (I'd rather over reject, than allow anything by).
Hmm, although for that last example it's a little tough because of the ```<strong>``` tag getting injected... if you escape it late you'll break the angle brackts.  So maybe in defaultResultsFormatter() it's best to make sure item and query are _both_ escaped first, then do the RegExp substitution.
Looks like you missed this one in your latest changes.
This line seems too far indented... tabs vs. spaces issue?
Should this handler only listen when the commands are active?
Changed name of _loadedAgents to _loadedAgentNames to make this more clear. Also added a comment.
This is in MurmurHash code, so if you think this is worth the loss in readability, you might want to open an issue at http://code.google.com/p/smhasher/issues/list. But then again, don't underestimate an optimizing compiler – in my experience, most backends perform simple peephole optimizations like this just fine.
this looks like a switch(config.transport) { ... } 

or config.getTransport() ?
why? This is an internal class and it is never called with null values. I can add checks, but they feel redundant.
changed to *message* , and i also changed constant name to *MESSAGE_MAX_LENGTH* to be consistent.
Again, great comment to have inline.
That is setting a default callback to do what the old code used to do.

If you notice on line 362, I removed the old update call, and can now call callback in all cases. I remove a bunch of checks with this.
space before inset please
what do you mean there's too much going on? looks like we do the same thing as we did with the other loops like I linked you before. For defaulting just  something like:

```javascript
for ( var item in elements ) {
 elements[ item ].value = trackevent[ item ] || _manifest.options[ item ][ "default" ] || "";
}
```

That should work.
I'm using stylus, so the real stylesheet is main.styl; it gets compiled to main.css, and there's no point in having both tracked by git. In fact, this just causes unnecessary merge conflicts later on.
理由は非対応だと言わなくていいですか
dafuq with that RE? `[\d\-]+`

    r'^\-?\d$'
the location -> a 'location'
这里也是，对齐太多。
What you want is an instance of SPARQLEngine in the case of a Sesame graph.
Same as for ActionSheetPicker2 I've added a 0.1 tag
Normally, if you sample at uniform spaced points, there are chances that the plot gets aliased. For example, if the sampling width matches with the periodicity of the function, then we will end up with a flat line. If we do it at random, then we will end up with a different angle and hence will sample further and end up with a better plot.
I'll leave this as is - it'll be taken care of in my next pull request
nope good catch.
cool down, man
Remove the pinCode there then you will be able to use `this.pinCode.length` to replace `this.hasPincode`.
This is not fixed yet.
Really pleased to see this, don't know why it was done this way in the first place.
With the added options (especially `transparent`) we should add-in a standard doc-string.
typo: docuemntation
And I agree with what @taldcroft is saying here - a factory class is useful when you need the factory to remember something about its state, but that's not the case here - every time you ask the factory for a coordinate, it gives you an object that stores all its state in the resulting object itself, and doesn't have any side effects on the next coordinate you ask for.
Ok that's fine, we can refine it as we build out more views and actions.
this sorts of confuses me , i see public function but then @private, someone is playing me mind tricks :)
As per market order parsing, this should be `"buy"` or `"sell"`, not a boolean.
Do we want this to do a save first or at least ask the user.  Seems a bit to easy to loose changes this way.
This is what's causing the test failure on 2.6 - the field needs to be `{0!r}` there.
I think these numbers are required to build it with old gcc. See c13542673ff5954caafc0002
Is the normal `readdir` threadsafe in AmigaOS?
This depends on the execution order guarantees provided by the framework.
If the next task cannot execute before the call back on onResolved has returned on the earlier task, then there is no concurrency problem. I think this is a reasonable guarantee since the next task may depend on the side effects from of onResolved.
Ditto, keep this comment.
Is there a way to style this without splitting into two lists? This content is actually going to come from a wiki document so a plain list would be easier for the editors.
Oh, whoops--you're right. It's new in 2.7. Nevermind!
Umm... this is a tangled mess. We should split this into a few different functions:

1. register a model as being searchable
2. register signals for a non-m2m model
3. register signals for an m2m model
I don't really understand this. In the ``key=None`` case, this only truncates one value? Why not truncate values until the json is less than the max_length?
There is a type in 'aReasult'. Also shouldn't we check the result of asyncFetch before writing out the data via NetUtil.asyncCopy?
If you use `self.assertEqual(len(fts_app.the_list), 5)` you will get an output like::

```
4 != 5
```
if the test fails. 
Your optional comment to asertTrue doesn't actually add much :)
Why not just `return 1`. That'll exit the `main()`
I don't get why all these whitespace changes the only thing that matters is onhttps://github.com/pyrocms/pyrocms/pull/1223/files#L2L25
Crap! My eyes are not in front of my head :p
You can close this PR.
Thanks, will patch in future commit.
Generating an invalid URL means it potentially would lead to another route, or to a 404. At least the empty link will just reload the page, and it's weird but not broken. It logs the error so you can look at it, but it doesn't create blank pages for your users. As for catch, yeah, I really want to wrap all my twig calls into try/catch just in case. Truth is this has happened to me because I didn't realize the data could contain some special characters, since it was inserted in the DB by another script not under my control, and it blew up half the page of the site, which I think is way more of a disaster than a broken link, or "bad API design".
you can simplify your regexes by using ``\s+``
It can make sense to have it. It asserts that a second call of the method returns the same result as before. But then it should be asserted in a dedicated test method. Either remove it or factor it out.
wrong phpdoc. There is not depth
oh, we just fixed a bug in this, so we DO use it!
Please a 'e' to variable - currentVenu**e**
Maybe rename to `email_to_find`.
I like the `Test` and `Class` parts of this name to distinguish its concrete-ness and existence only in the test suite but it feels a little too generic.

If this module were to be renamed `PerformEmailJob`, thoughts on naming the class to `TestPerformEmailJobClass`?
This is an interesting one. Not all the views this controller renders use require the guest, so I would prefer to pass the variable in because the guest isn't really part of the controllers state in my opinion. We can rename the method to `log_in` and then pass it the guest to increase readability.
Where we find these, we should change them to:
```ruby
flash[:error] = invitation.errors.full_messages.join(', ')
```
As here https://github.com/yammer/sched.do/blob/master/app/controllers/invitations_controller.rb#L26
действительно странно
This is the line we would change if we didn't want it to fail miserably *by default* for many users.
it looks like we're generating a new notification each week, and the notification only goes away once the offending condition has been resolved. right?

in the (relatively common) case where a single facility continues to have stockouts for 3, 4, 5 weeks in a row, it looks like this code will generate 1 stockout sms on week 3, 2 stockout sms on week 4, 3 on week 5, etc. Let's keep it at 1 sms, by changing the uid to just include {pk} and {year}.
this blank try-except that only defines a certain field in one case screams "should be a separate app and not be in core" to me.
A validation of this would be nice as well.
The proposed version
> $ python -m timeit -s 'import os' 'os.stat("/home/dario/dario.txt").st_mtime'
> 1000000 loops, best of 3: 1.52 usec per loop

And with the old one
> $ python -m timeit -s 'import os' 'os.path.getmtime("/home/dario/dario.txt")'
> 1000000 loops, best of 3: 1.88 usec per loop

The new version is slightly faster, so I will change it.
加载更多的功能我先尝试一个“点击加载更多”的形式。然后再试试“上拉松手后加载更多”。
It seems that the controller state monitor can only be used to report problems when a service is expected to come UP. In this case, I'm expecting the deferred phase service to come DOWN before a restart is attempted.

I changed the code such that I wait for the deferred phase service to come DOWN as part of the failed start attempt instead of before a restart attempt. I now also wait for 30sec.
So the spacing is to be:

```javascript
if (this.open) {
```

* nospace around if conditions
* space between if-defining `()`
* space after if-defining `)`
Shouldn't this also call `event.preventDefault()`? Otherwise the browser still scrolls the page, if there's content to scroll (probably wasn't the case on your test page).
Agreed. Or even better: reorganize so that choosing the underlying library isn't done at import time, so that one can have mocked and real tests as part of the same test run.
here

(I mark all the line with comment so Github will remove them when the line changes)
nit: sometimes you use setTimeout(..., 0), sometimes setTimeout(...). Both sounds good to me as long as you keep the same.
yep, I could have done that differently (maybe reusing the icons property) but I felt this was better this way. And I usually like having such arbitrary constants at the beginning of the file.
We are only testing that dataset['search'] is filed with the correct order, but are we testing that the order in the list is right (and that the field ordered by is *bold* in the list)?
extract messages[i] to a variable and use that var:

var message = messages[i]
Dough!

Will update this with the Makefile changes as well.

Thanks!
`alert` is too generic
Shouldn't this be part of the `KeypadManager.render('oncall')` ?
this is what really fixes bug 800267
Does this means that we can receive a ussd message, but there is no message?

Is that a common state? Should we be aware of that state and give some feedback to the user?
I _think_ it makes sense to use l10n keys for the units.

For example for us frenchies it's Ko Mo Go To Po.

PS: I like how you're planning for my future 16PB FirefoxOS phone ;)
This is not very robust. (can be addressed in a followup)
In the situation `app crashed`.
By @jcarpenter , the bottom banner is app by app.
But homescreen app doesn't know which app crashed. It couldn't receive the `mozbrowsererror` event.

This is a workaround for that spec.
@fabi1cazenave You might want to see comment here and see what magic you can bring in mozL10n for this crap in `bootstrap.js`.
You can apply the string localization first.
This will not work if the frame is out-of-process.  Instead, you should listen to mozbrowserloadend.
`frame` is already used down there at Line 103, and `frames[origin]` is not a frame but `frameFromOrigin`. I don't think we need that but if we do I can submit another pull request. Merging.
If you do replace the compressed tz_world.json file and it ends up changing the format of the deserialized json object in memory, make sure you regenerate the pickle file since the pickle file is just a dumb binary serialization of the python object I got from parsing your tz_world_compact.json file.

Glad to help.
I agree, proper use of matches is key to expressiveness and when you see people not exploiting the full vocabulary of your test framework it only indicates one thing; lack of insight :)

My reasoning for not checking for double quotes was that I was thinking a bit non-TDD, namely "what if he decided in the future to no longer need quoting, then the test would break at that point", instead of the proper notion: "how is the code supposed to work NOW".  I'll remedy it as suggested.
~~~
1つ以上のオプションが依存関係を持つ時は、ある変更によって、他のオプション値がリモート URL からリロードされる可能性があります。
~~~

~~~
1 つ以上のオプションが依存関係を持つ時は、ある変更によって、他のオプション値がリモート URL からリロードされる可能性があります。
~~~
Does it makes sense to use `Process::WNOHANG` here as well? To avoid any blocking in case the process has already been reaped.

Also might be worth using `Process.waitpid(@pid)` instead, but I'm not convinced.
yep.
here is: void zmq::session_base_t::monitor_event (int event_, ...)
On Fri, Mar 9, 2012 at 6:16 PM, Dan Peterson <
reply@reply.github.com
> wrote:

> > -
>  Fog::Logger.deprecation("Fog::AWS::Compute#authorize_security_group_ingress
> now requires the 'group_name' parameter. Only specifying an options hash is
> now deprecated [light_black](#{caller.first})[/]")
>
> Was this deprecation message lost in the move to
> `parse_security_group_options`?
>

Yes, we can not specify groups through either name or group id. And since I
wanted to make as few changes as possible to the interface (for backwards
compatibility) I wnet with this change instead. The group name can be
specified either through the first argument or in the options. An id can
only specified through the options hash, in which cane the name bust be nil
or not present.

    /MaF
Indentation under `if-user` is wrong here. Should line up like an `if`.
Since you're using unittest, you should be doing `self.assertEquals(expected, actual)`.
s/app_manager/AppManager
@xGen create a http://jsfiddle.net/ test case that reproduces the problem and create a new GitHub issue with the description and a link to it
I guess you can remove it if it died.
Dunno what happened to it.
dungeon?
I don't get this. You have no dynamic properties here. When I see `__get` i think that there are some dynamic properties like in the case with `Resource`. Please use getters here.
I'd personally avoid adding specific query strings into these tests, as they make it slightly harder to see what's important. In this instance, it only matters that `@secondary_solr` returns an empty array, and not what was passed in as the `q` parameter.
is this really worth to  test applicability at two places (in __init__ .py and in patch())?
The logic (and in particular the data) seems to overlap with the `create-master` logic. It would be good if we didn't have to specify it twice.
@paulmillr docs!
These activations are not going to be executed until the current activation's execution ends
コレクションに実装したいUnderscoreのメソッド集。
You once asked how to replace such #ifdefs with preprocessor or m4 macros. I suggest to move these lines to pinning/internals/header.m4 and declare the e.g. RS485_USART_INIT() there depending on the settings made. m4 is mor epowerful them cpp.
This comment should be written above, with an explanation of what Boxcar is and how one can register to get notifications
This relative (to the domain) URL will not work on CODE or PROD

would need to use the form url(../../images/guardian-logo.5f7d1bda6dfb728f0fa2d56c18c339a5.png) if we go down this route. This is due to AWS buckets
True.

I've left quite a lot of 404s in - approx. ~2% of the tests I was running were 404s, but there so much junk in these raw access logs that I'd rather not have it interfere with the test.

We should chat about how we are handling 404s in the application offline.
They were working - at least the DB hit counter was. Why would they stop? They stopped after I changed the DB password, but started again when I changed it back. ??
Looks like it was not such a good idea after all, as `prefs` are defined later. I had to revert change as it was broken.
Oh what's going on there. I'm trying to help you looking for information and give additional material to document your code.
Don't be too picky about review comments. I want to improve comments about this method, not just one sentence in this comment. The C++ code does exactly what you describe in your second sentence `Therefore, a `nsISupportsInterfacePointer` object that reference an `imgIContainer` with the image is needed.`, and what you code does.
Magic number! We should make that configurable.
+1 on a single entry point
Everywhere we're deploying to for now (Sync, Monash and UoM) should run on this fine. We can deal with the particular cases of new deployments case by case. Again, I'll ticket this up so we can have a discussion, but again, I don't think this is a show stopper for the pull request.

In terms of using a username/password pair instead of the IP/key pair... I'll just line up my thoughts here to start a discussion (I'm not lecturing anyone on security 101)

With a key and a password being the same thing (I guess keys aren't usually '1234' or 'password' though), it's just a choice between using a username or an IP address to  identify people. If we're simply looking at a problem where anybody from anywhere is allowed to talk to the provider and ask it for experiments, and we simply need some way to tell who is asking, then a username will suffice (i.e. the username is being provided to use by the consumer as a convenience so we know which key to check against - provision of the correct key is enough for us to trust someone). 

In our case though we have a very small set of users (institutions), who don't move around very much and who we care very much about identifying correctly (given that this is the interface to download potentially very private experiments). Given that consumer IP addresses wont change that often, and that it won't be too difficult to maintain a list of allowed addresses, I think it's a good trade off. This way we can confirm that users 1. know a secret (the key) and 2. are talking to us from a location that we are familiar with. It is a trade off between security (+1 bit of information) and convenience (maintaining the list + dealing with the problems you mentioned), , but given the nature of the consumer I think it's an easy choice.

TL;DR My opinion: A username is just a convenience and in terms of security, is effectively a very guessable extension to a key. Checking the IP address provides an extra level of identification. In a situation where you have a small number of users who don't move around too much (deployments of tardis) then it's nearly a freebie in terms of making things more secure (short of the problems you mentioned that we'll look into).
Hey, you misspelled 'with'. I'll merge after you fix that.
Nice! I learned something here, I missed `unravel_index` from numpy >= 1.6.0 !
@vrthra please add the case where instances returns an empty array?
OK, I can see why consistency is the best plan here.
Oops, yes, agreed (about side-effect free). Should use a different way.
Thanks for the pointing out.
I have used the before-after blocks in new commits.
just move it into a little `function trim(str) {`
This indent must go below `'INSERT ...`
This one can still live in `ControllerManager`
Not sure it matters overall. I just lowercase it for comparisons throughout anyway.
@jone better german translation "Zweispaltiges Layout"
I was referring to where you say "This will push the feature up to your 'origin' repository...". Do you really mean that `git flow [feature] publish` will push changes to Github? Totally cool if that's what happens, but is it repeatable? I mean, what if I want to push to Github several times before the feature is technically worth "publishing"? Sorry for being such a n00b. :S
upper sensei forced my hand here
This is useless file, just add note in `README` file how to update all bundles.
Is all these overrides really necessary?
could even be shorter

```clojure
(swap! behavior (constantly 3))
```
We clearly have 2 logical groups of assignment here. Please consider a line break between them (variables creation and array indexes definition).
oops .. didnt mean to commit that change
Done, can you check this again?
use a regular expression for this, see re.compile
any other naming?
Spaces before and after the '>'
No need to have a return statement if we don't return anything. Kill this and the comment above.
could be done as:

```python
with browserid_mock.mock_browserid(email):
    self.client.post(reverse('browserid_verify'), d, follow=True)
    self.client.post(reverse('register'), register, follow=True)
```
it's going to something long the lines of, though. Templates, fragment, partials, etc... templates would be closest to what the rest of the world calls it?
Let's get a ticket on file for this them
Okay.

Maybe we need to use this syntax instead:

```ruby
found = where(@klass.friendly_id_config.query_field => id).first
found = includes(:translations).
        where(translation_class.arel_table[:locale] => [I18n.locale, I18n.default_locale]).
        where(translation_class.arel_table[@klass.friendly_id_config.query_field].eq(id)).first if found.nil?
```
I think adding a TODO might be the best approach. I think a large number of hosts are still on PHP 5.2, and some are even on PHP 5.1 (some versions of CentOS come with PHP 5.1.6 as standard, and you need to add a custom repository to upgrade)
I think that in this context you could use the snappiest form of the simplified render syntax, which would be

<%= render @chapter %>

Being in the chapters folder, this will look for a partial named _chapter, and assume a variable @chapter will be used for a local named chapter :D
Is this unfinished?
not sure if it make sense, (e.g. for CI)
Yup, that's the issue.

On Fri, Oct 19, 2012 at 8:47 PM, Sam Kottler <notifications@github.com>wrote:

> In test/fixtures/report-errors.yaml:
>
> > @@ -17,9 +17,7 @@ metrics:
> >      basedir: /var/lib/puppet/rrd/my.sol.client.com
> >      label: Time
> >      name: time
> > -    rrd: !ruby/object:RRDtool
> > -      rrdname: /var/lib/puppet/rrd/my.sol.client.com/time.rrd
>
> the RRDTool class was causing exceptions to be thrown in the test suite.
> Dmitri can provide more detail, but since we don't test that explicitly,
> not having that in the fixture should be fine.
> … <#13a7a90901db0412_>
> On Fri, Oct 19, 2012 at 3:38 PM, Ohad Levy <notifications@github.com>
> wrote: In test/fixtures/report-errors.yaml: > @@ -17,9 +17,7 @@ metrics: >
> basedir: /var/lib/puppet/rrd/my.sol.client.com > label: Time > name: time
> > - rrd: !ruby/object:RRDtool > - rrdname: /var/lib/puppet/rrd/
> my.sol.client.com/time.rrd why remove those? these are genearaed by a
> puppet client, so we might be getting these kind of objects regardless? —
> Reply to this email directly or view it on GitHub<
> https://github.com/theforeman/foreman/pull/193/files#r1894040>.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/theforeman/foreman/pull/193/files#r1894112>.
>
>
Looking at the comment above changing this behavior looks like it will break the backbone implementation. This test is there to ensure that we don't break under backbone implementations that call the route event before the execution of the route callback.
A request I've gotten from metalab (and agree with) is to propagate the ready event to all children, even if they weren't passed to `setView`. In which case there won't be an options object passed. I'm ok doing a conditional of `options && options.scroll` but since I want to make our `ready` event more like the jQuery / zepto `$.ready` event, seems like a bad idea to tie it to `setView`.
Unnecessary reorg
And please make sure that you use ```image-url``` compass helper, which makes sure that the url's will be correct after compilation and in rpms.

Example: 

don't use:
```background: url("/images/flash_warning_icon.png") no-repeat 0 0;```

use this instead:
```background: image-url("flash_warning_icon.png") no-repeat 0 0;```
Oops! Though, disconnecting the dac is probably doing people a favor
There is code further down in this file which is checking for the same thing:

    if tp.startswith('MachO-') and rest.startswith('/'):
        # deprecated: because we now use rpath on OSX as well
        r = find_lib(rest[1:])
    else:
        ...

Presumably this code path is not completely redundant and should be removed.
honestly can't see big difference: explicit cast when calling scintilla_send_message shows that widget is actually a scintilla widget and casting to a local variable seems to illustrate the same, maybe having an odd local variable is not a good idea, np, want me to correct it?
Пока придумал  только это для передачи всего пути пользвателю в CalcLength, который захочет использовать весь путь так, чтобы это было не накладно. Как можно сделать лучше?
nice method name! <3
Yes, it works with double home tap... the only problem is the one i mention and get fix with the proper if.... i'll take a look at the remaining problem after work
Yes, related to the previous comment, This test should work, but the reject! was broken for the get_languages method on Repo class, If you can fix that, then the test can check for nils and ""s once again.
How about using [CountDownLatch#await](http://docs.oracle.com/javase/6/docs/api/java/util/concurrent/CountDownLatch.html#await(long, java.util.concurrent.TimeUnit\)) instead of the flag + loop? It already supports timeout, is synchronized and everything.
It is. If I missed something, please let me know and I'll open a ticket (as it has to be thread-safe)
https://github.com/teeworlds/teeworlds/blob/master/src/game/editor/editor.cpp#L187 
used this value for opque, could set both higher dunno
Express is also not at fault though when it comes to clients sending `*/*`, if they say they accept anything, then they better accept anything
Ah yes, now I understand.

So it's up to you as a client of the API to choose the granularity that you want from the diff by splitting your input the way you want, as long as you provide it as a List of components.

The API's code does not go into the details of your component, it just does an equals check and tells you that your input differs at component number X. I was under the impression that if you provide a list of Strings, you will see what differs inside those Strings as well, but now I understand that it is not the case and you will only see that (for example) String 1 in A differs from String 2 in B, just that.

Also, you don`t care about types since Object#equals(...) handles that well.

Thanks.
With multiple files open, after exhibiting the black buffer bug, then closing MP, this line throws a RemotingException:

    Object '/0a012ca5_ea94_4a0b_941b_76ab3ef4ea53/mzncn1u8eb0jv6okm3coaa7c_3.rem' has been disconnected or does not exist at the server.
Sorry, I don' understand what you mean, could you please give more details ?
componentsJoinedByString хорошая вещь, возьму на вооружение
а у переменной x и нет такого ограничения в диапазоне. Если DNA будет больше 100, то и x теоретически может быть больше. Для того и вычисляется percent.
This looks odd. All of this seems to be done in Javascript only. I.e. all columns are first returned to the user and then after the fact hidden via a client-side hide() call. I'm not sure if that's the best approach to go about this. A better way would be to not render the columns on the server side in the first place. It should also give us some performance boost.
... or time
Må fikse conflict-markerne ;)
what abound 'kind' ?
say that's in seconds
typo, already corrected 

On 26.12.2012, at 14:47, Alexandre Gramfort <notifications@github.com> wrote:

> In examples/preprocessing/plot_ica_from_raw.py:
> 
> > @@ -46,7 +46,7 @@
> >  # between 0 and 1 to select n_components by a percentage of
> >  # explained variance.
> >  
> > -ica = ICA(n_components=0.90, max_n_components=100, noise_cov=None,
> > +ica = ICA(n_components=0.90, n_pca_components=100, noise_cov=None,
> why not 64 here?
> 
> —
> Reply to this email directly or view it on GitHub.
>
a test I would do is load fif_fname
then save on disk the same data in chunks
then load each chunk, concat and check that I get the same results / data / times etc.
at least in this case you concatenate data that actually follow each other.
I'm fine with removing isDeathdateEstimated. We have the correct getDeathEstimated a few lines below.
why this is needed now?
Use `SecureRandom` instead. I can't find it in the rails docs, but it's there somewhere (might even be a ruby 1.9 thing...) but check it out.
This class provides a simple interface that caches the last fetched stanzas, which is what the existing code expects.

The Conf class does not cache stanzas so there would be more round trips if I naively accessed stanzas in it directly.
there should be a way maybe to isolate this

also on the tests we should put comments via the assert arguments as to give an idea of what went wrong
图像的相关信息
图像信息
包括nginx允许使用的连接处理方式

包括允许nginx使用的连接处理方式
to support poor java user. Scala users get implicit conversion for free.
А оно на прыщах-то после этого работает?
< br />
This shouldn't be here. : )
Good examples!
Excellent reuse of multiply!
should extends PhraseanetPHPUnitAbstract
Ca sa pot sa pun data-placeholder

On Fri, Mar 30, 2012 at 5:48 PM, Alex Morega <
reply@reply.github.com
> wrote:

> > @@ -15,10 +15,17 @@
> >
> >  {% macro select(form, field) %}
> >    {{ _label(form, field) }}
> > -  {{ form.select.open(field, class="field-%s" % field.name) }}
>
> de ce nu mai folosim `form.select.open`?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/eaudeweb/natura2000db/pull/1/files#r626303
>
There is no validation in the present stuff.

https://github.com/rackspace/reddwarf/blob/reddwarf/master/reddwarf/api/root.py
This would be easier to read if two variables were used for next_url, i.e.:
<pre><code>
app_url = pagination.AppUrl(request.url)
next_url = str(app_url.change_query_params(marker=marker))
</code></pre>
And again, same story about Callable vs Runnable...
If it's an internal cache, for the moment I would not allow configuration. 

See Hot Rod's topology cache where we only allow specific parameters to be configured, and we use an internal cache name.
Why factor this block out of the method it's used with? It just makes it harder to see the real type, IMO.
I'll open a separate issue for this once this is merged. Thanks.
It's not used anywhere in the file. Does the import have a side effect?
Looks like the trailing commas are just a distraction; you might as well go ahead and remove them.
"The name 'committees' does not exist in the current context."
ABICT, mozinfo.bits is the integer 64, not the string
"all the image" -> "the entire image"
Меня смущает момент array(array($id), $workerUncacher);
Мож отдельный класс сделать к примеру CacherMedium::create()->setIds(array $ids)->setWorker($workerUncache)
ммм ?
try to avoid accents, just in case
Clarified the docs here.
Sure, I see what you're saying. Things would be different in a typed language, where the user could just look at the type signature and see that you're supposed to pass in. You're really telling someone how to use the function; "vector" has a very specific meaning outside of Clojure, but also INSIDE of Clojure.

The test should be, if I were looking at this for the first time as a programmer, are any of these statements really ambiguous? I agree that "timeseries" has a meaning, but "frequency" here really doesn't. I really think you should spell out what frequency means.
The goal is to be able to reuse these outside of lists as well. For that reason I did not prefix them with oae-list.
`renderCantShare`
Can we provide the user with a notification message saying that you can't add a collection to itself?
Compile failure. The logger in this class is called `logger` not `LOGGER`.
I'm wondering if the ```<=``` should be replaced by ```<```.

Should the MaxDepth annotation mean "include only if current class is at maximum depth X", or "include only if the property will be at maximum depth X" ? (Currently its the second one)
This is the key part of the change -- just parse the application's config string because we know that the default is zero.
Since it is an unrelated change, yes I would prefer as for dev I prefer to
start in the same state over and over (not have remainders from previous
runs)

Thanks
Yan

On Fri, Mar 9, 2012 at 10:27 AM, Zoran Simic <
reply@reply.github.com
> wrote:

> > @@ -73,6 +73,7 @@ class BootStrap {
> >      // setting up data when development...
> >      if(Environment.current == Environment.DEVELOPMENT)
> >      {
> > +      if (ConfigurationHolder.config.dataSource.dbCreate != 'update') {
>
> This one is unrelated to JSON, it's because without it I had to keep
> re-selecting the big JSON as the model to use each time I restarted the
> console. I checked it in because I thought it would be useful for everyone.
> Perhaps I should have checked it in separately. the default DB is hsqldb in
> 'create-drop' mode, I thought it was OK to avoid doing that when 'update'
> was specified.
>
> Should I take this one out?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/linkedin/glu/pull/130/files#r538225
>
This cleanup code should all go into a out: block and the boolean should be controlled via a variable to remove duplication.
Ok, forget to try it that way round.
Still, once you agree on a codestyle, it does highlight what functions do have side-effects and what don't.

I read about it somewhere in this book: http://ofps.oreilly.com/titles/9780596155957/index.html
But I'm sure I have read that before, when trying to get some insight into Scala.
Why take `package_id` here?