spec: add selenium spec to conversations finder file refs #7583

Change-Id: I5c30a545ba192c0230faaee5356ee78d984c1acf
Reviewed-on: https://gerrit.instructure.com/9376
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>
spec: add selenium spec to gradebook2 file refs #7375

Change-Id: I6a943aa3273e8a97919b63648cc63ee2ea13b899
Reviewed-on: https://gerrit.instructure.com/9396
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>
show multiple sections on course users page; fixes #7510

similar to the course settings users tab, we want the course users page to list
all sections a user is enrolled in.

test-plan:
- in a course with a user with > 1 enrollment
- go to courses/X/users and make sure all appropriate sections are listed
- make sure accounts/X/users still works normally, without sections

Change-Id: Ic5e5da7c5c25200cdec99c3657f4dbb6c0b87cb7
Reviewed-on: https://gerrit.instructure.com/9159
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
spec: add selenium spec to speed grader file refs #7646

Change-Id: Ie2dbafb84297842296084c303b1265c0a7245cb2
Reviewed-on: https://gerrit.instructure.com/9308
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>
modified parallel selenium rake task to include plugins specs

Change-Id: I451194a1b5e95c0606e9f4a47276b73abffeb86e
Reviewed-on: https://gerrit.instructure.com/9341
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>
clean up and stop creating duplication notification policies

fixes #5196

test plan:
 * perform an action that causes lots more than
   User.max_messages_per_day notifications to be sent out
 * in the db, there should only be one entry with notification_id
   is null for that communication channel

Change-Id: Ibd1c5f5273b171bd4ebb6252e942e23dac4aa7e3
Reviewed-on: https://gerrit.instructure.com/9260
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
fix todo bug introduced in 17494bce1a745af20c8ec20

Test plan:
  - go to a course page without logging in

Change-Id: I185f74f41cbe547efdba41064f650b5fe7ed2e5a
Reviewed-on: https://gerrit.instructure.com/9080
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
spec: fix intermittently failing gradebook2 selenium spec

Change-Id: Idfb56005437a13386865203d9c03337ba3bc1b89
Reviewed-on: https://gerrit.instructure.com/9413
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>
spec: add selenium spec to dashboard file refs #7536

Change-Id: I7d8b8b0653a90dbcdf44f037b1a95d4854b822a7
Reviewed-on: https://gerrit.instructure.com/9375
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>
add heading to account permissions pages fixes #5343

test plan:

  1. go to account level view
  2. click permissions on left nav bar
  3. notice heading that was added

Change-Id: I24fc6bc257d10bd8a073a2a5aff59627166fc8e6
Reviewed-on: https://gerrit.instructure.com/9325
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Rob Orton <rob@instructure.com>
send announcement notifications to observers; fixes #7424

test-plan:
- in an available course with an active observer, with a communication channel
- have an admin create an announcment
- the observer should receive a notification about it

Change-Id: I94cd7eadead3bd079d820c0ea4595f203c4458bc
Reviewed-on: https://gerrit.instructure.com/9303
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
refactor top nav links to have id's

test plan:

 -fixed multiple selenium specs to work
  with these new id's

Change-Id: I57ece6761636ea6c40f4e87d60aafb9c870754b4
Reviewed-on: https://gerrit.instructure.com/9402
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Bryan Madsen <bryan@instructure.com>
prevent group discussion assignments from spawning jobs recursively

discussion topics touch their root topics when they are saved so that post
counts get updated correctly. However, when the discussion is part of a group
assignment, part of the post save logic is to update the child topics to keep
the topics for each group in sync with the root topic. This was done in
a delayed job, and was kicking off a recursive job.

test-plan:
- with delayed jobs running
- create a group discussion assignment
- make sure delayed jobs for #refresh_subtopics don't start growing out of
  control

Change-Id: I592275db18239ba49eaed766dfab5ff1439e3024
Reviewed-on: https://gerrit.instructure.com/9431
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
don't cache tinychat settings on the Tinychat class

This was preventing us from changing the Tinychat settings for different
accounts. I also removed the tinychat.yml.example file, as people should be
using the /plugins interface now.

Change-Id: I5fe6bbf72563f75e9cbfadf1f661715b40a5fc33
Reviewed-on: https://gerrit.instructure.com/9427
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Zach Wily <zach@instructure.com>
remove dead code around page views

Removes unused methods and associations from models, and removes the
PageViewRange model completely, which is no longer used.

test plan:
  * run the specs
  * verify that no active page-view-related functionality was inadvertently removed

Change-Id: I8522d151555db64a0ad2548334ae642f9fefd54e
Reviewed-on: https://gerrit.instructure.com/9324
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Cody Cutrer <cody@instructure.com>
remove dead code

test plan: n/a

Change-Id: Idf3a5b2caaca0cd232c6bad7a282b8e85f846d46
Reviewed-on: https://gerrit.instructure.com/9313
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
allow disabling mail from outgoing_mail.yml

test plan:
 * set perform_deliveries: false in outgoing_mail.yml
 * verify outgoing mail no longer happens, but you don't get a ton
   of error_reports for failed deliveries

Change-Id: I18b6cacc8fc7e79c60969728d5caf0a06caaf91a
Reviewed-on: https://gerrit.instructure.com/9338
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
don't cache discussion topic html to work with marking as read

Change-Id: I116059708a3271c6dce786d7286b85bc24cc536f
fixes: #7724
Reviewed-on: https://gerrit.instructure.com/9430
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Jon Jensen <jon@instructure.com>
move ungraded count migration to dj

Change-Id: I8f901d1618686ec98341a594cabf6b71183a89fb
test-plan: n/a
Reviewed-on: https://gerrit.instructure.com/9372
Tested-by: Hudson <hudson@instructure.com>
Reviewed-by: Brian Palmer <brianp@instructure.com>
discussions: only notify people in course or group

fixes #7490, refs #7483

Test plan:
- make a disussion topic
- make a discussion entry with a student, and then end that student's
  enrollment in the class
- make a discussion entry with a different student; the original student
  should not receive a notification

Change-Id: I6465363bc8e99ebe431c9483c9a569a68d3f852e
Reviewed-on: https://gerrit.instructure.com/9161
Reviewed-by: Cody Cutrer <cody@instructure.com>
Tested-by: Hudson <hudson@instructure.com>