labofsahil/github-event-dataset-2012 huggingface dataset:
Do you mean to cast the ints to floats here, or to pack them (as in reinterpret cast) into so-called float pointers?

Doing it the way you do here means you are giving up several bits of precision, but actually working with real floats ... but if you are working with real floats, then why not make the input to this Op a CudaNdarray so that the copy to GPU isn't necessary at all?
Yes. But the -2x offset here can yield separate non-overlapping contours. Same list of contours before and after union, because they're non-overlapping.

Then each of those contours gets the +1x offset one-at-a-time, so the unions involved there apply to each in isolation, so they can end up overlapping. Adding the union_ex() cleans that up, at the cost of one more call to Clipper.

But there's a better way to fix this that results in fewer calls to Clipper.

Instead of saying 
foreach of the results of the -2x offset, offset +1x
we should say
for all of the results at once of the -2x offset, offset +1x.

To do that, you've got to unroll the offset_ex() calls, which exposes an extraneous union_ex() that we can get rid of.

```perl
$_->offset_ex(+$distance) == @{ union_ex([Slic3r::Geometry::Clipper::offset($_, +$distance)]) }
```

Clipper::offset() can take all the polys from the first offset - and it's better if they're not $expolys. So we get the "forall" instead of "foreach" effect by nesting the first offset results into where $_ is above. Here's the initial replacement for the map/foreach to make it forall:

```perl
@{union_ex([Slic3r::Geometry::Clipper::offset(

	@{ union_ex([Slic3r::Geometry::Clipper::offset( $surface->expolygon, -2*$distance)]) }

	, +$distance)]) }
```

But the inner section needs to  return just the array ref of the results of the first offset - no premature union, no expolygons. So it should be like this:

```perl
@{union_ex([Slic3r::Geometry::Clipper::offset(
	[Slic3r::Geometry::Clipper::offset($surface->expolygon, -2*$distance)],
       +$distance)]) }
```
Probably to much empy lines here
Don't use "is" with '', it's not guaranteed to be a singleton. Use ==
I think my goal was to remove all application env entries for the app, and then load them fresh on the next run from the .app file. If unload doesn't do that, then it can easily be removed.
Ты про obsolete? Никуда :) Вернуть?
Does this behave correctly if I drop a unique constraint and add an index instead?
you should have an abstract synchronizer as you are duplicating some methods in the different implementations
We recently fixed cabal-install to work with GHC 6.12.3 on requests by users, so we don't try to break old versions when the benefit is very small, as in this case.
A good thing to do here, is not die if on_error isn't supplied, but instead provide a default error handler of some kind.
Good question. (1) because I had a bad call to `next.parentNode.insertBefore( elem, this );` (should have been `insertBefore( elem, next )`) which has been fixed in the latest commit. Also because of the `nodeType === 1` check, it seemed appropriate to remove regardless of whether the insertion happened or not so doing it below was easiest. Anyway, the `nodeType` issue is for you guys to sort out so I'll leave that one with you. In the meantime I've fixed the `insertBefore()` and moved the `remove()` up in the latest commit: f698ccbb9a.
From a maintenance point of view, it doesn't make sense to change a whole bunch of code unrelated to the ticket the commit/PR is supposed to fix. It makes it very hard when looking at things months later to pinpoint where the fix actually is.

I'm not being hard, I see and appreciate you're trying very hard to contribute, I'm just trying to make sure you actually CAN contribute. There's nothing I'd like more than merging a PR of yourse. All I'm doing is letting you now how you can make it happen.

So:
* make focussed PRs (fixing a bug OR gaining size),
* lint and unit test your code (if your change in the callbacks signature doesn't make a test fail, then we probably need to create one),
* check your spaces/tabs and code style in general like a zealot (even I fear the wrath of @rwldrn sometimes),
* create your PR on a branch, not your master (makes things much easier for us).
Nested? https://github.com/gibson042/jquery/blob/f7067566d1bda266e8bc9bc7c51d8755d068fbd4/src/data.js#L230
Yeah, I noticed that too when @dmethvin commented on it and I had to scroll horizontally. FIxed.
"classifySource" and "classifyAttrColumn" should be always present. But I agree it is fine to add more checking here.
It seems the svec module doesn't provide such operators.
```sql
testdb=# select '{2, 1}:{0, 1}'::madlib.svec - '{1,1,1}:{1, 0, 1}'::madlib.svec;
ERROR:  operator does not exist: madlib.svec - madlib.svec
LINE 1: select '{2, 1}:{0, 1}'::madlib.svec - '{1,1,1}:{1, 0, 1}'::m...
                                            ^
HINT:  No operator matches the given name and argument type(s). You may need to add explicit type casts.
testdb=# select '{2, 1}:{0, 1}'::madlib.svec + '{1,1,1}:{1, 0, 1}'::madlib.svec;
ERROR:  operator does not exist: madlib.svec + madlib.svec
LINE 1: select '{2, 1}:{0, 1}'::madlib.svec + '{1,1,1}:{1, 0, 1}'::m...
```

According to the source code, it defines a lot of operators. However, they all starts with MADLIB_SCHEMA as schema name. I don't know the reason why we do that. If we want to make "+", "-", etc. work, we need to add the schema "MADLIB_SCHEMA" to the search path or remove the schema from those operator. I think we can't force the users to set the MADLIB_SCHEMA to the search path, so i prefer the latter one. What do you think.

```sql
CREATE OPERATOR MADLIB_SCHEMA.- (
	LEFTARG = MADLIB_SCHEMA.svec,
	RIGHTARG = MADLIB_SCHEMA.svec,
	PROCEDURE = MADLIB_SCHEMA.svec_minus
);
CREATE OPERATOR MADLIB_SCHEMA.+ (
	LEFTARG = MADLIB_SCHEMA.svec,
	RIGHTARG = MADLIB_SCHEMA.svec,
	PROCEDURE = MADLIB_SCHEMA.svec_plus
);
```
According to the book "Data mining concepts and techniques, 3rd Edition", "suppose we are given a data set of D tuples. Each tuple has a probability 1/d of being selected, so the probability of not being chosen is 1 − 1/d. We have to select D times, so the probability that a tuple will not be chosen during this whole time is (1−1/d)^d. If D is large, the probability approaches e−1. Thus, 36.8% of tuples will not be selected for training and thereby end up in the test set, and the remaining 63.2% will form the training set.”
I feel like this needs to be a lot more robust, but I don't know what sort of errors I need to watch out for.
Note: Should check if the new cmake 2.8.8 does still need this. They did a lot of improvements to handle Xcode without CLT!
Remove these if they are not used.
Since we're re-rendering the element just do `data.contact.getListItemElement().remove();`
Non-descriptive string constant again
I do this so that you can grab the .jar from the `target/` folder and then upload it to the GitHub downloads page. This way the .jars that non-Maven users download from GitHub are prefixed with 'square' to provide more insight into their origins.
The property is not really unknown, but more unsupported on fbsd - maybe align the error message with the one above (unsupported on fbsd)
How does the effect #72 or #73?
Will fix both.
layoutClass = if typeof layout = @get('layout') is 'string' then @["#{helpers.camelize(layout)}View"] else Batman.View
layout = @set('layout', new layoutClass(context: @, node: document)) if layoutClass
PerfUtils needs currentDoc to get the file path, so that's why its the 2nd line
Looks like there's still a diff showing with the SHA here...
Do you think it's possible to change the shadow and triangle handlers to also use requestAnimationFrame?
Can we clean this up to a single var decl?
i tried both and there are no serious impact reported by perftools.rb
Use `first_or_404` and ditch the next two lines. Do this everywhere that we've used the older first() followed by abort(404) pattern.
I will move the class definition in the CoerseTest module I added, I planned to do that but got distracted.
The way I usually prefer to fo this is what I did in my first version (create a class and bind it to an instance variable) but when I moved the Boolean class declaration I had to change the code otherwise Boolean was not in scope and so would raise a justified error :/
The Man with The Powerful Mane is right: both the object and the ODB need to be explicitly `free`'d. They are refcounted and managed by libgit2, but you need to decrease their refcount.

Also, the first call to `git_odb_read_header` is redundant and inefficient. Lookup the object directly and check its type with `git_object_type`. :sparkles:
Those are two different thins, mongoengine fields and Django fields.
Yes, Must be added a crrent directory(./) in Ruby 1.9.3.
I wanted to coexist 1.8 and 1.9.
Remove this if you're not doing all cross-browser gradients
Same as https://github.com/mozilla/butter/pull/1396/files#L1R140
This is a bad idea, why leave commented code in?  File a new bug to add it later.
missed a space of padding
@DragonDM the `time_delta.total_seconds()` is only available in python 2.7 that would break backward compatibility. Something like this might be a better alternative.

```python
def get_total_seconds(td): 
    return (td.microseconds + (td.seconds + td.days * 24 * 3600) * 1e6) / 1e6
```
```state.highstate``` with ```salt-call```. This displays far more information

Or perhaps make ```salt-call``` a link to the page about salt-call?
Right, I wanted to split out the management of num_connections. I am fine with moving that and overriding _new_conn. I try to avoid overriding methods starting with underscore though, better make it explicit that this belong to public API.
Ja.

Deze wijziging is er tussendoorgeslipt, wordt in een latere commit ook hersteld.
Whoops! Nice catch!
Ha good catch, I have been playing with this and you actually discovered two bugs :-) This if clause, and when I was testing it, CLI was incorrectly setting -1 value :-) Fixing now.
Should ldap be enabled by default?  If so, what does <role-id> represent? (e.g. Will the installer create a default role?)

(Just curious how this will work)
I'd like to reserve glue module for its original purpose - the
orchestration code, which this is not.

On Fri, Oct 12, 2012 at 2:18 PM, Lukáš Zapletal <notifications@github.com>wrote:

> In src/app/models/candlepin/content.rb:
>
> > +  end
> > +
> > +  def update(params = {})
> > +    return self if params.empty?
> > +
> > +    updated = Resources::Candlepin::Content.update(params.merge(:id => @id))
> > +    load_attributes(updated)
> > +
> > +    self
> > +  end
> > +
> > +  def load_attributes(params)
> > +    params.each_pair {|k,v| instance_variable_set("@#{k}", v) unless v.nil? }
> > +  end
> > +end
> > +
>
> Msuchy had a comment today - should not this go ti models/glue/candlepin
> directory rather than this one? If I look on the candlepin glue RPM it
> looks like this currently:
>
> # rpm -ql katello-glue-candlepin
> /usr/share/katello/app/models/glue/candlepin
> /usr/share/katello/app/models/glue/candlepin/consumer.rb
> /usr/share/katello/app/models/glue/candlepin/content.rb
> /usr/share/katello/app/models/glue/candlepin/environment.rb
> /usr/share/katello/app/models/glue/candlepin/owner.rb
> /usr/share/katello/app/models/glue/candlepin/owner_info.rb
> /usr/share/katello/app/models/glue/candlepin/pool.rb
> /usr/share/katello/app/models/glue/candlepin/product.rb
> /usr/share/katello/app/models/glue/provider.rb
> /usr/share/katello/lib/resources/candlepin.rb
>
> I have already fixed the spec, but let's discuss this and move it there
> after Katello 1.1.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/Katello/katello/pull/836/files#r1829257>.
>
>
I was imprecise. I meant that you are checking each point every time, including these that were already checked. A better resolution will be necessary for only a handful of points, and always in the same place, this is what I meant when I said that you do all this in order to add one single point.

You do not need to reevaluate the array, and you still can use vectorized_lambdify. Here is more detailed version of the previous snippet that I posted:

```
def get_segments_addaptive(array):
    segments=get_segments(array)
    for index, point in enumerate(segments[:-2])
        if not flat(point, segments[i], segments[i+1])
            new_sampling = np.linspace(array[i], array[i+1].param, num=10)
            new_segments = get_segments(new_sampling)
            add this to the temp array
        add this to the temp array
    return the temp array
```
I _think_ it happens if one doesn't do `git submodule update`, and make sure the submodule is in the correct branch/commit. At some point we need to figure out how to use submodules properly, they seem very convenient to split up projects, but the amount of hassle increases drastically.
Yeah :smile: I was just thinking about the scenarios in which by design the hub gets frequently called (like the Mouse Tracking sample). It might make a big difference, though...
Changed it to `FetchMethodsFor` - ok?
This is a bug we had way back where we did it on the wrong event.
Maybe only update the state if it's non null.
no typo
Yes, I've already fixed that in #364 :x
Unnecessary line break
@mdboom , actually the plot was made by `predict_search`. To turn off the plot, set `verbose` to `False`. This is noted in `predict_search` function docstring.
@iguananaut - could you explain what

```
self.set_undefined_options('bdist', ('dist_dir', 'dist_dir'))
```

does? I'm confused by the ``dist_dir`` tuple. Thanks!
On that note, do you really need to io_lib:format/2 that? Couldn't you use the string directly since the command doesn't need any interpolation?
i think you should also handle the case where the cookie is passed as a string there.
Why socket_base instead of boost::asio::ip::tcp::acceptor?
That's a gross misuse of the Configure class. A proper way to achieve this for eg. would be setting a special view variable named `_rootElement` to specify alternate root element name.
Yes or no ...

JSLint discourage to create to create a function in a loop, it can make memory leaks ...
Is *digitize* the correct word? Tom told me once that digitizing means something like converting an item from a material form to a digital one.
What about *Draw*?
这里最好处理下路径
Don't replace it if theres's stuff there. If I click on a user by mistake I shouldn't lose my message
@guilhermeblanco s/PSR-0/PSR1.5 (PSR-2 for the new code but there is a garbage of legacy which cannot be fully converted to PSR-2 without breaking BC for child classes)
I thought since `_selected_renderers` was private it would be ok to change this. I was getting a bug where some items would not be deselected, and I think it was because the code was removing elements from the same list it was iterating over.
OK, I now realize you meant the default parameter and not "async". Thanks for applying the change.
Test temporary variable anchor to see if the pointer moved over a different anchor.
this should be the link to any smartos over ssh docs, where present
should still plan on breaking up this client a bit
To be more complete on testing, consider using a three-value REQUEST-STATUS.
Yes, a submodule will appear as a `GIT_OBJ_COMMIT` in the tree. The behavior of core git when doing a clone of a submodule is just to create an empty directory at that path. The user is then required to do a `git submodule init` and `git submodule update` to correctly populate the empty directory with the submodule content. (There is a `--recurse-submodules` option to clone, but that will be supported in libgit2 by secondary calls to the submodules, fetch, and clone APIs, I think.)
why not Task<T>?
this avoids the cast required in line 108.

is this because there is the untyped case where each Task has different "T"?
may define two methods, a strongly typed T version and untyped version.
This text needs to change now, it doesn't make much sense in this case. We are shooting for a goal of replies and not counting unanswered tweets.
not quite,  this is a PolyStorageError and I'm interested in logging the contents of x.exceptions.  i'll make it clearer
No citext is still an extension, it's just installed differently (CREATE EXTENSION versus "psql -f citext.sql")
single quotes or `'%s.%s' % (item['name'], locale)`
On Fri, Dec 21, 2012 at 04:42:06PM -0800, Rob Hudson wrote:
>403 seems like an odd thing to return on ValueError? When would this happen?

When someone tries to use a path outside of base URL (`../foo`). 
I could just display an error in the page, but given that for 
the foreseeable Jorge and I are the only people likely to be 
running this, it didn't seem worth the trouble.

-- 
Kris Maglione

On two occasions I have been asked, "Pray, Mr. Babbage, if you put
into the machine wrong figures, will the right answers come out?" I am
not able rightly to apprehend the kind of confusion of ideas that
could provoke such a question.
	--Charles Babbage
I'd rather repeat what's in the asDouble function, once for precision errors, once for performance
为啥不写成`images = [];`
I tend to keep `REQUEST` in capitals for when accessing the object directly.
In the case of a parameter, the method may be receiving a dictionary or a fake request object, so let's not imply it's the same as the browser session REQUEST object.
Just checking the obvious here - there is no equivalent of "User" in Italian?
`unset($this->lazy[$option])`; missing ? - even if it should not have side effects for now
The 2nd assertion has been present since Feb 2011. I did not add it. See https://github.com/symfony/symfony/commit/41bf849a637d9434f859eeafd816fec4a0ab51be
the logic is not the same anymore for the saving
api gets marked later.
This does not need the getter as the form is already initialized.
no really, use `i`. if a worker died really quickly, there might be a gap, meaning this will duplicate an id.

example: workers 0,1,2 are forked, then worker 1 dies, then we go to fork the fourth-and-final worker, but re-use id 2 because that's the length of the still-active ids [0,2].

I *think* that particular race isn't actually possible with this code, but I'm not willing to bet on it. the ids in the `xrange` are *exactly* what we want.

EDIT: actually this needs more thought. `len(self.workers)` is what we want for the case of `fork_workers` being called after a `SIGTTIN`, for example.
why not add a parameter to the 3 exceptions, and have it add position at the time the exception is thrown?
li > a > img
Parenthesis around the parameter por favor.
Really doesn't matter for me, both ways are okay. :)
space before 4
Could you clarify please? This copies and pastes fine on the command line....
That check is saying "is bits_needed greater than both zero and 128," which is redundant. Should it be bits_needed < 0?
Would you mind inverting this logic to make it look simpler? Eg.:

```ruby
it.instance_eval(&block) if block_given? or !it.instance_of?(Property)
```
logging -> logger
I see what you mean. I'll make the change and resubmit it
Private variables have to start with $_ according to code sniff. 

In practice I've found private variables typically indicate the original developer figures that they cannot think of any possible way that someone who can come along after them might be able to do something better than how the code was originally created. Protected leaves the possibility that someone can make something better later.

But for right now it was just for the codesniff.
Escape the text!
missing title?
OK, GitHub shortens the URL, let me add a + in the middle: https://github.com/mozilla-b2g/gaia/pull/4877 + /files#r1640928 ;-)
updateHeader function seems update whole timeHeaders innerHTML, but it will be triggered every time when new header created. Why not update only the new created element?
Actually, I'm already calling blur here:
https://github.com/ochameau/gaia/blob/e49e456d856e85c229efbd146ee2139d4c715da0/apps/system/js/simcard_dialog.js#L255

The keyboard ends up disappearing, right?
Because I'm not able to reproduce a case where the keyboard is kept visible.

I think that we are just hitting a general issue with the keyboard that doesn't disappear fast enough when calling blur.
vivien has some ideas to optimize it, like ignore focus/blur from setVisible(false) frame and eventually hide the keyboard quicker when a frame having the focus receive a setVisible(false).
We need to store it, but here we are updating the ID of `ts_` prefix, and we dont need this prefix anymore.
@AntonioMA is aware of this.
This part of logic got some error because dbData does not exist... You can assign dbData to result[0] and try again.
Sounds an hipster way to say:

if (!this.rotation)
  this.rotation = {};
sorry i was talking about the wrong function , (that function was added by SChih , i am not sure if i should remove this , thought he might have used it some other place  ) let me check if i can remove this 



On Dec 21, 2012, at 12:11 AM, Sriram Krishnan <sriramkrish85@gmail.com> wrote:

> its below on the evenlistener L53
> 
> 
> 
> 
> 
> On Dec 21, 2012, at 12:10 AM, evelynhung <notifications@github.com> wrote:
> 
>> In apps/system/js/captive_portal.js:
>> 
>> > +    } else {
>> > +      new MozActivity({
>> > +        name: "view",
>> > +        data: { type: "url", url: url}
>> > +      });
>> > +    }
>> > +    settings.createLock().set({'wifi.connect_via_settings': false});
>> > +  }
>> > +
>> > +  function handleLoginAbort(id) {
>> > +    if (id === eventId) {
>> > +			//TODO Close notification
>> > +    }
>> > +  }
>> > +
>> > +  function sendUserCancel() {
>> But I didn't find anyone calls the function? did I miss it?
>> 
>> —
>> Reply to this email directly or view it on GitHub.
>> 
>> 
>
If you intend to keep the workaround, please file a Bugzilla bug and paste the url in the comment, so people will know when the bug is fixed
Move everything except L390-L391 to `onring.html` to simply the code here, or move the `am_gotAlarm` function out.
What do you mean?  I don't see why it shouldn't work. This is for ID3 metadata tags which have a weird spec and sometimes actually encode text using UTF16.  If MP3 files ever actually use this feature, they will have to use 16-bit surrogate pairs for anything outside the BMP because that's how UTF16 works. Its a silly spec feature, but easy to handle in javascript!
Finally we rollback to this state until the new system is working properly
} should be removed from the else.
okay, looks good!
`index' is already used as a loop counter in the outer loop. Probably a bad idea.
Clarified why its not used.
A minor issue: jetty.start() needs to be called later, i.e., directly before new StopServer(...). Otherwise, flags such as "stop" will not work.
1. Add space after each `if`
2. I think it would make more sense to call it just `bounds`.
* Rename to "production_delivery"
* Add a bit more info:
``
Allow user to mark all the items that were received from production.
``
Remove the extra parentheses.
In theory, you should round (i * MathHelper.TWO_PI) / SCALE.SIZE here.
Two-space indentation and closing brace on a new line please!
Params is a dict subclass, params is a dict, so any reason not to just do this in __init__?
Let's not be ambivalent in the comment -- the SUCCESS in this case only indicates that the trigger was successful.  That's worth re-iterating in the docs, but I don't think we'll find ourselves in a place where we're waiting for the nightly build to finish.
No, and really, both are potentially asynchronous operations (in the sense that message brokers doesn't guarantee instantaneous delivery, and databases don't guarantee instant replication of commits)  so it actually doesn't matter which order they happen.

We're going to have to solve this with some kind of per-master "clock", and I'm not planning to get that done until 9.0.1 at least.
Hey I actually removed all the ``white-space`` calls from the other themes cause I realized they are not needed since it is already a ``pre`` tag.  Can you remove here as well?
Ubuntu 12.04, gcc 4.6.3. I can test it again later today and report any problems.
I would add ``g`` as shortcut for the option
done with --level=all
we can nix these view and request specs
Here, we just need to make sure that when `ncaps` is set, it is less than `MAX_STATIC_CAP`.  thus, we only need the second check (i.e. we don't need the check vs. `MAX_STATIC_CAP`).
This was for two reasons:
- vanity urls of articles wouldn't match in a simple route regex
- we already have this data on the page so lookup is quicker than a regex match

@mattandrews has also done the same with gallery routing as per the reasons above
good point, adding commit with this change.
also, add a length field that contains the size of "dstbuf"
please merge to ipa320 first, some things have changed regarding arg and env handling
Don't think we need def failure
ここは。。。
Where is context?
I find it little strange to do this branching here, I think it would be better to always pass event to the panel.show and do this decision making there.
nit: blank line please
Only the window has an onload event; I could use that but it serves no purpose other than style.
search_results.py:13:1: W293 blank line contains whitespace
@TrevorPH I started to look at writing tests for this, but I'm a bit confused.  Does this patch make the assumption that the value of the `gid` parameter is always numeric?  If so, we need to verify if this assumption is correct.  The `Puppet::Provider::Ldap` class is the base class for both of the `ldap` User and Group providers.  I notice that the [user provider makes sure the value is always numeric][1], but the [group provider does not appear to make this assumption][2].

Are you trying to fix this problem only for the group?  If so, perhaps this isn't the best place to make this change and instead we should make the change [in the group provider][2].

[1]: https://github.com/puppetlabs/puppet/blob/3.0.1/lib/puppet/provider/user/ldap.rb#L50
[2]: https://github.com/puppetlabs/puppet/blob/3.0.1/lib/puppet/provider/group/ldap.rb#L38-L44
Checking the furthest point against the last point in the buffe already covers the row check for the last row.
pfff micro-opt much :p
foreach ($annotations as $annotation)
I used the Zend\Db\Adapter\Adapter for a performance reason. Zend\Log is a core component and we want to have the minimum memory usage and the maxim speed for this component.
Done in 46ee695ee7332d8ec77762e07413647ae55b5117
Maybe instead of putting those translator methods into AbstractHelper and HelperInterface, we move them to a Zend\I18n\View\Helper\TranslatorAbstractHelper which the handful of helpers can extend from. That way the concerns are a little more separated and the Zend\I18n\Translator\TranslatorAwareInterface would have purpose for these view helpers (and elsewhere). Thoughts?
Ok, for me.

For the record, personally I understand timestamp as integer value not as object.
Same comment as for filters: need to retain the "validators specification" language, in addition to the ValidatorChain change.
Use only 5.4 to cover more versions like the PHP 5.4 shipped with Zend Studio
For CSS style names follow the convention implemented in the dynamic form:
1. Prefix all styles with "ssGWT-"
* Store the style names on class constants.
I'd just add it.
Any ETA on this?
I can't believe it's the recommended way. The purpose of it is to prevent searchbots to follow links, nothing else. For anything else, you can use data attributes. Example: `<p>Part of <a href="http://todomvc.com" data-external>TodoMVC</a></p>`
I'd rather encapsulate this block in a separate function.

```php
protected function getEntityIdentifierValueList($entity)
{
    $unitOfWork = $this->_em->getUnitOfWork();

    if ($unitOfWork->getEntityState($entity) === UnitOfWork::STATE_MANAGED) {
        return $unitOfWork->getEntityIdentifier($entity);
    }

    $classMetadata = $this->_em->getClassMetadata(get_class($entity));

    return $classMetadata->getIdentifierValues($entity);
}
```

Then just reuse it here.
Quickly reading the code I'm unsure if we already support the aliased class names. Do we support this here?
Also, why reassigning the from class name is necessary? It doesn't make any sense to me.
This is a clear situation where we lack of a comment here.
It seen more explicit for me, also similar with hibernate implementation..
This file is correct utf-8 encoded, the issue is with the diff generator of github.
Pekny priklad je napr. https://github.com/mitsuhiko/werkzeug/blob/master/werkzeug/exceptions.py - je v nom tisic tried, ale je to podstatne krajsie, ako dat kazdu do vlastneho suboru.
Kod ma byt strukturovany tak, aby sa dobre cital cloveku, nie podla toho, ako to urcia implementacne detaily. To, ake triedy spravime, je v podstate "implementacny detail". "V subore len 1 trieda" je podobne umele obmedzenie, ako napr "v subore len 1 funkcia" - dalo by sa to (zvlast s IDE), ale holt niektore funkcie patria spolu. S triedami je to rovnako. V subore ma byt to, co spolu tvori jeden logicky celok z pohladu cloveka, co to cita.
That returns `None`
Surely you mean:
```python
tables.reverse()
return tables
```
Or perhaps: `return reversed(tables)` but, mind you, that returns an iterator and not a list.
According http://www.libsdl.org/docs/html/sdlvideodrivername.html and http://sdl.beuc.net/sdl.wiki/SDL_VideoDriverName the return of this function must be null if SDL not initalized.
<pre>
Returns NULL if video has not been initialised with SDL_Init or a pointer to namebuf otherwise.
</pre>

So i add this condition to implement this behavior.
We should add the '_locator' suffix after all the names, according to our style guide https://wiki.mozilla.org/QA/Execution/Web_Testing/Docs/Automation/StyleGuide#Locators
In the future, I find alphabetical attributes easier to look through, but nothing worth r-ing about.
What tear down is appropriate here?
If you have the time and inclination, would you change the translation function to the one we're currently using? :)

Instead of
t('bla', :default => "Bla %{var} bla", :var => value)

we now use
ts("Bla %{var} bla", :var => value)

Also, the h function has been deprecated, so you can just remove it.
can be simplified to:

  org_ids.map!(&:id)
you are destroying the instance? I have no idea why we would update the ip here?
it seems weird to include a CLI module into an OSS Remote. I know it's just a name, but this is a code smell for poor encapsulation (or just poor naming)
We do. If you don't, then you get a 400 error
hm is keys sorted or not?
а поэффективней слабо написать? чтоб за количество ребер было?
It would be nice to stick with one style for CSS, either 2 or 4 spaces.
I am more than happy to help convince your boss to do this right. ;)  Seriously, though, doing this right is going to cost less time in the big picture than doing it wrong but fast will.
We should file a ticket against puppet proper for this, because that seems not-so-great.
> You can still keep using whatever you’re using locally, but when your app is running on Heroku, it needs to be able to connect to PostgreSQL.  So in your Gemfile, change:

Minor edit for clarification:

``` textile
You don't have to change your local database settings to use PostgreSQL, but Heroku depends on the presence of the @pg@ gem. So, in your Gemfile, change:

<shell>
+gem 'sqlite3' # or whatever the database driver for your local database is
</shell>

to:

<shell>
group :development, :test do
  gem 'sqlite3'
end

group :production do
  gem 'pg'
end
</shell>

WARNING. Using differing databases for development and production is not recommended. Occasionally, specific Rails idioms may have different effects on different databases. We encourage you to set up and develop on PostgreSQL if you intend to deploy your application to Heroku.
```
Now that `filterLibs` is gone, this now tries to generate docs for folders, and results in an error message during startup. We should filter out files that we know are going to fail, like folders. Maybe we can limit to just `.js` files?
What is `subjectPrincipal` ? Is that the pairing of ObjectType:ObjectId ?
I'd rather have 2 separate endpoints. I think it's more readable.
I think this method needs a little rethinking. The `row_spec` (fields to select the row) can only be determined on a per row basis. So this method should clearly take a row as argument. This eliminates the need to use `first`. I totally agree to use `headers` instead of `row.keys`.
Again. Take old code out and write your own comments.
I don't think that the second value is a valid one.
Неверный оператор сравнения http://stackoverflow.com/questions/3703554/understanding-nsstring-comparison-in-objective-c
Это я еще про воздух и травку смолчал, ага. :)
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
хотя, сделал чтобы при 0 просто выходила
Элемент должен в любом случае измениться, как уже сказали, "А" на "А" - элемент не изменился по сути.
точно, в пятничной суете забыл имя поменять )
Эм. Я имел ввиду, что корректней сдесь поставить вываливание с ошибкой если на вход пошли неверные данные. Врядли вас ктото попросит перемешать 110 или -33 процента :)
I think you still want to pass `db=db` in this call, allowing the caller to explicitly specify a database value.
I'm find with the exception name, but I think a test or two expecting DocumentNotFoundException would be helpful. I can add that later after merging, though. @asm89 will be adding the query filter stuff into Doctrine Common soon, so I'll revisit the tests then.
Shouldn't this be `and msec == DINFO_TIMEOUT_FAST`?
You always have a reference name. If you somehow manage not to have it, then it's likely that both the server and libgit2 are buggy.
I'd rather have a function for this. I hate objects as you know :)
can you clarify your use case? I am sure why you want a feature like this.
import in every call. Might be better to import only ones
very well. approval seal approved.
You should probably should add your name to this. Remove Jeff's and Matt's.
only the ContainerBuilder, not the Container
So, $attributes contains each tag's attributes ? 
That's why I have start this documentation, because I don't really understand why there is an an array of attributes like that.

On the first time that I have used the additional information on tag, I have directly do a $attributes["alias"] without success..


To sum up, If there is many tags , each index of $attributes referes to a different tag ?
So, in the documentation, I have to do 

```php
foreach ($container->findTaggedServiceIds('acme_mailer.transport') as $id => $attributes) {
    $definition->addMethodCall('addTransport', array(new Reference($id), $attributes[$id]["alias"]));
}
```

In this case, what about : https://github.com/sensio/SensioFrameworkExtraBundle/blob/master/DependencyInjection/Compiler/AddParamConverterPass.php ?
I guess this would be for the case: 
from(actor)...to(somewhere else)

but I think it is covered by the Producer

Ray, comments?
I agree that it's best to allow only one way of using the `Stash`. Having only the self type looks nice indeed.

However, there are two things that this requires: first, I had to duplicate the implementation of `Actor.preRestart`. The reason is that calling `self.preRestart` leads to an infinite loop when `preRestart` is overridden in a user class that extends `Actor with Stash` (like in the test in `ActorWithStashSpec`). The other thing that has to be kept in mind is that the `Stash` trait has to be mixed in right after the `Actor` trait. It's not possible to write `Actor with MyActor with Stash` if `MyActor` overrides `preRestart`.

Removing the self type and only extending `Actor` would remove these two issues, but it would have the problem that Roland mentions, namely that users could write `class MyActor extends Stash {}` in which case we should probably rename to `StashingActor`.

The current solution uses only the self type, adding a note saying that `Stash` has to be mixed in before any trait/class that overrides `preRestart`.
BIG NO!!!
It is not mutable. At least it was not intended to be so if I miss something tell me, otherwise this class is immutable.
That should have been `return ThrowException(exception)`. No worries, I patched it before pushing out 59c3923.

On a side note, can `get_uv_dlerror_message()` fail? If the answer is 'no', then we're looking at dead code here.
Э, щито. Почему бы не инициализировать сразу по объявлению?
Мало ли что там запостилось или выдалось. Представь себе, что я одному
чуваку отправил заливаться через /sharesong один файл, а другому — другой.
Как менеджер заливки узнает, какую ссылку кому отправить?
layout related should put in `_layout.css.scss`
首頁 put here
Esto se ve algo incómodo. Me pregunto qué tan difícil será hacer una extensión que funcione de la misma forma que

    @using (Html.BeginForm)) { 
        // magia por acá
    }

De todos modos imagino que debe ser complicado, no lo hagamos ahora, pero estaría bueno.
Pero no entendí, estás borrando por días o por cantidad?
No, attrs isn't available earlier up in the execution chain, but the events array never changes and doesn't need to be created on every linking pass.
or **null**
Please fix it, we are being a little stricter about formatting now.
not a super important improvement.. but I think you could avoid the _volatile_ in the cache wrapper since you're already checking for the latch.
Worthy of a comment.
Yeah, I see your point.
Just tested it myself and it looks good to me.
*existed function backquote
Don't rack your brain, just try it:

(fact [1.0000001 2.00001 3.000001] => (map roughly [1 2 3]))

On Wed, May 9, 2012 at 5:07 PM, robinkraft <
reply@reply.github.com
> wrote:

> > \ No newline at end of file
> > +  (deseasonalize 3 [1 2 3 4 3 2 1 2 3 4 3 2 1]) => [1.1846153846153844
> 1.8846153846153846 2.8846153846153846 4.184615384615384 2.8846153846153846
> 1.8846153846153846 1.1846153846153844 1.8846153846153846 2.8846153846153846
> 4.184615384615384 2.8846153846153846 1.8846153846153846 1.1846153846153844])
>
> I couldn't figure out how to do roughly on a collection. That is, (map
> roughly coll) produced a bunch of functions, not their result. We've been
> down this path before, and I'm racking my brain, but it's not working!
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/reddmetrics/forma-clj/pull/18/files#r799087
>



-- 
Sam Ritchie, Twitter Inc
703.662.1337
@sritchie09

(Too brief? Here's why! http://emailcharter.org)
> I think this radius is defined somewhere else in the code.

Yeah, the radius in `forma.reproject` is for a different projection. Added comments to the `radius` definition in 8e3e7c9 to explain. 

> Also, can you add some comments here to explain what this whole namespace is and what these numbers mean? 

Done in f15f723.
@bp323 same as `403.js`
I love seeing parameters expressed as enums. More of this pattern, please!
`.south` is not really a good root selector - its adding dependencies about the used layout algorithm which mandates these classes, and also hardcodes the position of the toolbar, which to me is the same as hardcoding classes like `.red-button`. Can we use `.cms-preview`, `.cms-preview-toolbar` or something?
pls remove this it's not used
parameter should be set on querybuilder.
A Lookup is more an action than a thing. Since this class holds a table of lookup data I think we should rename it to something more expressive:

* LookupTable
* IdDictionary
* MappingTable
* you get the idea ;)
can you remove all the commented out code?
I think I like your idea best -- but if it's the default, we could drop the flag, and add it back in if there's a reason to turn it off, that it, at some future date we might decide to add WT_CONN_NOT_TRANSACTIONAL?

Does that give us the best of both?
Are you sure you want to override the parameter ``$max``? This often makes code less readable.
Siehe beerlistressource arrays
w0rd
Perhaps this return type should be called "image_paths" instead of "images"?
can you break this up into multiple lines? with the curly braces, etc.
previous code already converts rgb to hex: https://github.com/mootools/mootools-core/blob/master/Source/Element/Element.Style.js#L121
also, the border* styles always return 3 components (unset values just return the browser defaults).
This variable is written to but never read.
Do we do verification or validation?
Style CSS similar to the rest of the file (empty lines around style blocks, spaces before `{`).
So please test everything and make it work. :-) Or ask if you are unable to make it work.
```
if user.birthdate == None:
    context.update({
        'error_birthdate': True,
    })
    return context

if user.language not in horoscope.get_supported_languages(): # BTW, it would be better to use translation.get_language() here
    context.update({
        'error_language': True,
    })
    return context

...
```
`<span></span></span>`???
No need for `.each`. Just:

```
$('input[type="checkbox"][disabled]', this).prop('disabled', false);
```

You think too much in a procedural way. :-) jQuery is quite functional. You can chain, do things over many thing at the same time, and so on.
Groan. Should I really point everything out. You do not notice that also in just few tags above also things are not ordered in the same way.
If you make these docstrings then you can have the examples actually run as tests. A docstring would look like this:
```python
def get_release_apps(stack):
    """
    arguments ...
    
    example of runnable doctest:
    >>>get_release_apps('qa')
    ('qa_fullhouse/', 'qa_fullhouse_static')
    """
```
Now that we have changed the selectedElements to only contain an array of elements (instead of objects) this should now work directly. As noted in the above comment we can now pass the selectedElement array directly to drawUtils.
No need for the array. A single store can be created with just the name string.
This is necessary when using multi_host and getting VM to VM (on same host) traffic working...
These spurious changes are showing up because of Windows newlines. Can you try setting core.autocrlf? https://help.github.com/articles/dealing-with-line-endings
Typo, should be ```add_metadata.py```.
I'm wondering what the purpose of this line (#143) is? It appears that it iterates over a list of two tuples, and returns a list of two tuples to the same variable name?

utils.project_totals may be a generator and this line is just iterating through to create this as a list? If so, I think a list() around the function call in line 1541 would suffice?

I might be being dense and missing something, so just lmk thoughts.
right, fixed. Thanks.
fyi: if we counting everything, fs.getContentSummary(path) would be the most efficient.
s/abstract/overridable/g
Create a test that tests this extra argument.
I don't know automated way to do that, let me know if you find any.
It's a bit difficult and actually unnecessary to keep more than one context of a type. So I think remove_request_context should still only take `type`. I can change it so there are separate add and remove methods per type, so the type is in the name. They will still need to take a `force` flag though, as the createView methods use them to check if there's a context or not, without requiring one.
We need to compute the effects, so I went ahead and attached them during fit as R does. If I check for exog_Q, we still need the effects.
You can combine those two lines into one. And please sort them alphabetically.
This is a personal account and should not be checked in.
Since we are wrapping and re-throwing, I think it is misplaced responsibility to log here.  At the very least, it's redundant.
>Hmm...all that said, if Interpolants are in fact always immutable, there's actually no reason to copy them - there's nothing wrong with sharing them if you know neither owner can modify them.

Hmmmm, I guess that's right: I was more worried that someone might later swap out the interpolant for another one, but that would be silly anyway since it wouldn't actually change the interpolant being used in the SBCorrFunc...  I just have a test I want to run (I'm still not 100% about how Python assignment in every possible case) but I think you're right, I can just share...
Personally, I find a full paragraph of italics hard to read, so I'd rather remove the `\emph` here (and many other places).
I see, you just pulled this directly into our repo.

Perhaps we should give credit in the source comments?
we should not remove the JSB only code since it is much faster than the HTML5 code.
Instead the solution is to do something like:
```js
this.create_parallax_layer();

function:create_parallax_layer() {
  if( platform == 'browser" ) {
     // code for html5
  } else {
     // use code for JSB (which is way faster than the HTML5 code).
  }
}

```
Don't delete old ones, just add new ones... It seems, we'll have to review it at all
Modify also sample.properties.erb, please. This file is used to generate sample.properties for jenkins run
On Tue, Feb 28, 2012 at 8:20 AM, vingtetun <
reply@reply.github.com
> wrote:

>
> nit: The convenstion is to to use '-' as a separator instead of '_'
>

Done.


>
> Also do you really want to replace the full application with the gallery
> app? Sounds to me that you want to open a the gallery as a new application?
> (window.parent.WindowManager('../gallery/gallery.html)). And can you add a
> comment next to this code to remember to replace it once we have intents
> (good use case for it!)
>

Actually I'm not sure this is a good use case for intents because no
information is being exchanged, it's just a simple hyperlink from one web
resource (app) to another. What kind of intent would it be?

The window manager should detect that the hyperlink goes somewhere outside
of the app, that the URL corresponds to the origin of another installed app
and open a new app window with the gallery app inside. Unfortunately this
won't work yet because all apps are served from the same origin.

-- 
Ben Francis
http://tola.me.uk
The more I look at this, I think we should just put the time zone in the session. I think it simplifies this a little.

`request.session['timezone'] = timezone`
But here in refreshUser it will do an extra query to the database.
I'm not sure what's a good pattern to follow here...  The iframe script also gets included here ->  https://github.com/arturo-c/USARugby-Stats/blob/e12d032622c412fcf112940a9c7d2a62afaa312f/app/include.php#L45  but the standings page callback doesn't include include.php.  However, i'm wondering what the pattern will look when / if we need jquery in there... 

Just pondering.. Definitely don't think this is a blocker.
Have you tested if `system "make", "--prefix=#{prefix}" would work? Then the `system "make install"` should know where to put the binary and man page itself.
Adauga te rog si comentarii inainte de fiecare configurare si lasa o linie libera inainte fiecare optiune.
you can shortcut this with if @config[:conductor], has_key is not used very often typically
Should we ask for "friends" instead of "followers"?
Mmh, I'd leave it as is as long as no one comes and has a reason to request the change, I don't want to add any "unnecessary" interface that we'd have to support later.
Не по code conventions. И вообще лучше на switch переписать.
Poke. I'd like to get this closed - can you respond to my comments? I might be wrong and thats fine, I just need to know.
I believe test -h should actually be test -L ? Also why use ${BASH_SOURCE[0]} when $0 gives same result and the intent is clearer.
match the )
It might be possible to wrap the python function call in a cdef function with the right prototype, itself being passed as a function pointer to the C code:

http://stackoverflow.com/questions/8353076/how-do-i-pass-a-pointer-to-a-c-function-in-cython
One quick question, is SLA.eigsh just using arpack by default?
we use singular for ``class_weight_`` and ``sample_weight`` in sklearn, however, ``pls``, ``neighbors``, ``gmm`` etc use plural (e.g. ``self.weights_``) - if we want to be consistent it may be easier to rename ``class_weight`` and ``sample_weight`` to plural. Lets discuss that elsewhere. I'm fine with ``boost_weights_`` (its consistent with ``pls``, ``neighbors``, ``gmm`` etc.)  .
a different a
different
just pushed
I don't like the explicit check for `bool`. What's wrong with adding an extra argument `out`?