merged branch Seldaek/autoload (PR #3515)

Commits
-------

d2f8aa3 Allow autoload to run without vendors being cloned

Discussion
----------

[Tests] Allow autoload to run without vendors being cloned

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixed misleading help for "name" argument as search for services with wildcards is not implemented
use SecurityContextInterface instead of SecurityContext
fixed docblock
[HttpFoundation] Removes use of  parameter in Request::getClientIp function.
merged branch marcw/request-proxy-ip (PR #3527)

Commits
-------

f718859 [HttpFoundation] Removes use of  parameter in Request::getClientIp function.

Discussion
----------

[HttpFoundation] Removes use of  parameter in Request::getClientIp function

made in reference to this : https://groups.google.com/forum/#!topic/symfony-devs/cnSLwdAQiSk
merged branch sbusch/patch-1 (PR #3526)

Commits
-------

afbb8f2 Fixed misleading help for "name" argument as search for services with wildcards is not implemented

Discussion
----------

[FrameworkBundle, Console] Changed help text for container:debug command

Fixed help for "name" argument as search for services with wildcards is not implemented in ContainerDebugCommand
Allow people to set the error level, this is especially important when dealing with misbehaving libraries as part of legacy integrations.

Usage would be to extend the Kernel, and set the errorReportingLevel prior to calling parent::__construct(). Not ideal, but this doesn't break BC and allows the user to defer the decision as late as possible. This can/should be handled better in 2.1.x
Add PHPUnit annotation.

This test performs an action which affects the global space of the test process, therefor, these
tests must run in separate PHP processes.
[ClassLoader] Fixed ClassMapGenerator and added suport for traits
[DoctrineBridge] Add minimal tests for DBAL session storage driver
merged branch drak/patch-1 (PR #3530)

Commits
-------

dd192a1 Add PHPUnit annotation.

Discussion
----------

Add PHPUnit annotation

Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -

This test performs an action which affects the global space of the test process, therefor, these
tests must run in separate PHP processes.
merged branch pminnieur/patch-1 (PR #3522)

Commits
-------

bfb5547 fixed docblock
bf75212 use SecurityContextInterface instead of SecurityContext
498b4b6 use SecurityContextInterface instead of SecurityContext

Discussion
----------

use SecurityContextInterface instead of SecurityContext

Bug fix: no
Feature addition: no
Backwards compatibility break: yes
Symfony2 tests pass: yes
Fixes the following tickets: /
Todo: /

Abstract: it's not possible to exchange the `security.context` with another implementation without this change. You may not be able to extend the `SecurityContext` because `isGranted` is final, so you may implement your own context.

---------------------------------------------------------------------------

by pminnieur at 2012-03-06T17:37:27Z

PS: could you merge this back to 2.0 branch, too?

---------------------------------------------------------------------------

by stof at 2012-03-06T17:42:03Z

@pminnieur send a pull request to the 2.0 branch then

---------------------------------------------------------------------------

by lsmith77 at 2012-03-06T18:42:41Z

i guess this doesn't break BC as SecurityContext always implemented the SecurityContextInterface .. no?

---------------------------------------------------------------------------

by pminnieur at 2012-03-06T19:11:00Z

this would not break BC, correct. I may identify additonal places where its not typed against the Interface but the implementation, which is really annoying. I will update the PR tomorrow morning and also do a PR for the 2.0 branch.

---------------------------------------------------------------------------

by stof at 2012-03-06T22:04:09Z

As it is in the constructor, it is not a BC break indeed as overwritten constructors can have a different signature anyway. For other places, take care that it could be a BC issue for people extending the class

---------------------------------------------------------------------------

by pminnieur at 2012-03-06T22:11:28Z

as the `isGranted ` method in the `SecurityContext ` implementation provided by Symfony is declared `final`, it's not really extendable at all - which ultimately leads to the problem: its indirectly hard coupled ;-)

---------------------------------------------------------------------------

by stof at 2012-03-06T22:38:08Z

@pminnieur the BC break is not for people extending the SecurityContext but for people extending classes that typehint it

---------------------------------------------------------------------------

by pminnieur at 2012-03-07T10:45:55Z

JFYI: the `RememberMeListener ` also does not type hint the interface but the implementation itself (it's always a constructor argument). All the other `Security\Http\Firewall` listeners type hint against the interface. I will update the PR accordingly today and also create a second PR against the 2.0 branch.

---------------------------------------------------------------------------

by pminnieur at 2012-03-07T11:55:52Z

JFYI: same issue w/ JMSSecurityExtraBundle https://github.com/schmittjoh/JMSSecurityExtraBundle/pull/44
merged 2.0
[HttpFoundation] Refactor tests for master branch.
merged branch drak/pdo_tests (PR #3534)

Commits
-------

9b3b936 [HttpFoundation] Refactor tests for master branch.

Discussion
----------

[HttpFoundation] Refactor tests for master branch.

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
[DoctrineBridge] Rewind MongoCursor before use in unique validator

Fixes a regression I introduced in: 265360d1426676cf9b0ff7a01e631546e22e3b63
merged branch jmikola/patch-2 (PR #3535)

Commits
-------

a5ed6ab [DoctrineBridge] Rewind MongoCursor before use in unique validator

Discussion
----------

[DoctrineBridge] Rewind MongoCursor before use in unique validator

Fixes a regression I introduced in: 265360d1426676cf9b0ff7a01e631546e22e3b63

---------------------------------------------------------------------------

by jmikola at 2012-03-08T22:11:32Z

This was also reported in doctrine/DoctrineMongoDBBundle#84.

Let it be stated that we should create some functional tests for this validator :)
merged branch drak/doctrinetest (PR #3531)

Commits
-------

dee47b1 [DoctrineBridge] Add minimal tests for DBAL session storage driver

Discussion
----------

[2.1][DoctrineBridge] Add minimal tests for DBAL session storage driver

Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -

This is intentionally only for the `master` branch because the class is different between 2.0 and master.  This test is the minimal but at least will mean any refactoring changes in dependencies get caught.
[ClassLoader] Fixed version compare