labofsahil/github-event-dataset-2012 huggingface dataset:
Indeed, which is why it's a separate thing right now as I can enable/disable it directly. If SQL generation is built in directly, there's no need for any nicely-done logging of SQL.
The tests run fine without this line so I can remove it.
What's this function do?
All this boilerplate code will eventually be generated by the Greenplum-specific part of the SQL abstraction/specification layer, and I think it is appropriate there.
I see your point and tend to agree. Names are but sound and smoke. I'll change it!
I'm surprised that this change would make a large difference in performance.
Not so sure, does it really override the definition from the included Metadata file?
What about putting this in a dedicated `http` module?
I agree but I though you wanted to be able to forget/delete them. I am not sure I fully understand the problem that's why I suggested the PR since at least you know my use case.
После "по крайней мере" запятая, мне кажется, не нужна. Цитирую: "когда слова «по крайней мере» расположены перед соотносящимися с ними по смыслу словами, обособление, как правило, не требуется" (http://www.gramota.ru/spravka/punctum/58_556).
Ещё я бы заменил "у вас более старая версия" на "у вас версия старее".
И ещё в предложении "Давайте сделаем, то что написано" запятая явно стоит не там.
После "Другой пример", кажется, должно быть двоеточие, а не запятая.
I personally find great value in having parameters individually documented, even if they seem obvious. For example, a "config" can be lots of things.
ich finde die rekursive denkweise ist an dieser Stelle nicht sinnvoll. genau diese dinge sollen ja einfach werden durch die finder API.

ich möchte ja auch nach "hallo/du/ordner" filtern können, wobei dann immer egal ist, ob "hallo/du/ordner" als struktur im basedir beginnt oder erst in einem der teilbäume.

nur bei "/hallo/du/ordner" würde ich die prüfung ab basedir erwarten.
What is the `true` doing here? https://github.com/andre-d/reddit/commit/ff4e74a919e0b55ef8b30f62a15e159d6cc902fd#r2-r2-public-static-js-wiki-js-P26
rather than saying "a given class", just refer to the parameter by name.

    "Returns the static injection for {@code injectedClass}."
dagger-codegen --> dagger-compiler
should be:

my.interval = spec.interval || my.cfg['CACHE_TIMEOUT_INTERVAL']
This is scary, in that it generates a number of temp files proportionate to the I/O speed of the testing system.  Could we just throw ClosedByInterruptException ourselves?  (Like run6?)
Use each instead of f.
nvm actually im on crack, this should be fine
I assume you mean _lose_, not _loose_.
I assume this line will crash when run in brackets-app.  Maybe that's ok -- by the time anyone could possibly see a real update notification (and hence the UI that calls into this API), we'll all have cut over to brackets-shell anyway.  But it seems worth sending the team a heads-up about this, at least.
Suggest including link to http://dygraphs.com/per-axis.html here (and maybe update that page to describe the new way of doing things).
Shouldn't this pass in `server`?
Ok, changing  back.
Did you leave these in for a reason?
Same issues here as above.
Ahhhh I see now! Good eye!

However, it's probably more correct to check for the existence of `fieldset` before attempting to make its display none instead of removing this line. Notice that the `else` block here tries to use `fieldset` as well, which should also be guarded.

The point is: we should only try to manipulate aspects of the element that this code has tried to automatically grab if it actually found something :P.
have_content is a really broad matcher.  It would be much better to pick out the particular element on the page that should contain the text 'creating' using a css or xpath selector.
Probably more Scala-like to do a match here
So according to [this](http://www.w3.org/TR/html5/dimension-attributes.html#attr-dim-width), the width attribute only accepts pixels, not percentages. I didn't test the code in different browsers, so if it does the job, we're probably fine. Maybe we could move that into CSS though.
The tag version should be the same as the pod version. There is no `1.0.4` tag, though, so either the file should be renamed, or the tag.
Has this gem been officially added in?  (i.e. rpm will be available for production install)
Is it really part of the "Pulp API bindings"? (i'm assuming it is the hooks gem from rubygems.org)
This would also work but there's already another mechanism to distinguish between deployments. The value in header #apply is actually parsed and tells the upgrade script when it should be executed. Example:
#apply katello -> used only for katello/cfse installations
#apply headpin -> used only for headpin/sam installations
#apply katello headpin -> used for both installations
Ah, good point. I have reverted that commit in my fork, now just need to figure out how to sync it with this pull request
Can the above be changed to the following?

    return Regex.Replace(input, "</(?i:script)", match =>
    {
        return "</\"+\"" + match.Groups[0].Value;

I think that would be a little more clear.
I would write something like this, avoiding to rise unnecessary exceptions:
```perl
my $zUser = new EBox::UsersAndGroups::User(uid => $group);
if (zUser->exists()) {
    throw ....
}
```
On 02/04/2012 06:00, Ben Francis wrote:
>> @@ -192,6 +194,9 @@ update-offline-manifests:
>>   			find * -type f | grep -v tools | sort >> manifest.appcache ;\
>>   			$(SED_INPLACE_NO_SUFFIX) -e 's|manifest.appcache||g' manifest.appcache ;\
>>   			echo "http://$(GAIA_DOMAIN)/webapi.js" >> manifest.appcache ;\
>> +			echo "NETWORK:" >> manifest.appcache ;\
>> +			echo "http://*" >> manifest.appcache ;\
> Will this prevent webapi.js from being used offline?

Nope. This has been added to let newly installed application display 
their own icons.
I wonder whether this is safe - after all, if I have two angle objects an initialize a new one with (for some reason) ``a1.hour + a2.hour``, maybe I would expect it to still be a valid hour if larger than 24, and to wrap around. Just a thought, I think the above is fine for most cases.
Too many tildes, should be `--tag ~nodegen`.
A recent fix (by somebody else) was made to this module to not use lager: see note above.  Apparently remote invocation with possibly different versions of the lager transform did not play well.  Besides that, actually I never saw those lines come up in the logs, so I wouldn't mind removing them. Adding the return code was a better validation anyway.
If it's not supposed to be true by default, why set proxydns to true here?
No. Look again. OptionsModel::Init does not change the QSettings. It sets command-line options (using SoftSetArg) *based on* the QSettings, not the other way around.
This should indeed be moved to SendCoinsDialog::SendCoinsDialog() via as it's considered standard to currently not use the placeholderText property in ui-files.

<pre>
#if (QT_VERSION >= 0x040700)
    /* Do not move this to the XML file, Qt before 4.7 will choke on it */
    ui->sendFrom->setPlaceholderText(tr("Restrict the client to only send from these Bitcoin addresses."));
#endif
</pre>
Braces are required around all control structures.
Nice to see this one here, no more ```http_build_str()``` problems :)
Introduce typedefs to make code self-documented
Do we need to make "emf" a private field? It looks like the emf is only used in the constructor.
The reason is that if the -t option is 'default' and ETS_TOOLKIT is defined then Enaml will select the corresponding toolkit in that case there is no compatibility issue. I used the OPTIONS_TO_ETS because I did not want to  create another dictionary.

I am open to suggestions here
As I've expressed elsewhere, I really don't care about formatting in the XML files.
Geen idee hoe het in de stijlregels staat, maar is `($this->record['is_featured] === 'Y')` niet logischer en leesbaarder?
I tried to put at the very top indeed... but keep getting following error during compile ...


1>GLES\TextureCache.cpp(27): error C4430: missing type specifier - int assumed. Note: C++ does not support default-int
1>GLES\TextureCache.cpp(27): error C2365: 'glGetFloatv' : redefinition; previous definition was 'function'
1>          E:\ppsspp-master\native\ext\glew\GL/glew.h(921) : see declaration of 'glGetFloatv'
1>GLES\TextureCache.cpp(27): error C2078: too many initializers
1>GLES\TextureCache.cpp(27): error C2440: 'initializing' : cannot convert from 'GLfloat *' to 'int'
can you add another assertion of the value emitted?
`expect(helper.markdown(markdown_text)).to be == html_text.chomp` にしてください。
It's no problem, I guess I should just be more conservative with my wrapping. :smiley:
@tanoku introduced a "bool" type internal to the library - let's use it for this and the true/false constants instead of an unsigned int.
@rragan as Veena said, t

he tests that use helpers have to be in the helpersTests located on /dustjs-helpers/test/jasmine-test/spec.
As a note on this class I'd like to mention that I intend on tracking scope information and storing it on nodes to make it easier to hoist declarations out of sub scopes created by rewrites. In the current version of Six for(var x of []){ var x = 0; } is effectively achieving block scoping.
Total nit... But think we could change the id on this to `submit-l1on`. Maybe that's more trouble than it's worth.
The reason I didn't merge `Sidekiq::Worker::ClassMethods.DEFAULT_OPTIONS` was that `normalized_item['retry']` wasn't. Could do if you like.
Sorry this should be removed.
+1. Maybe just not all upper case, but "Changes"
If the CLI was already given a configuration object, it no longer makes sense to provide this option; so this is a flag to not include it.
This should not be a float, but a char
ти впевнений? здається з цим може бути проблема. навіщо міняв?
You're right though, this should return early.
Why is there an empty private final __construct() for a class that has only one static method?
While your would suggestion would be proper dutch, it is also 24 characters longer than the english version. I tried to keep it brief, to prevent breaking HTML layouts. 
At the same time, I tried to keep the same tone of voice. The english version does not contain a verb, nor does it address anyhting literally (no 'this' or 'that'), so I think the translation should match that.
Sorry, already merged this PR. It probably makes sense to move the check, but the tests must be fixed as well then as they won't pass anymore.
I think stof would say that this line should be reverted as it's not according to the CS.
There's two periods at the end of the line
->setDefault()
I would sort by `int(x['n'])` instead of by date.
Remove angle brackets for readability.

Also, the 'when' use here leads me to want a context block, like
```ruby
   context 'when the recipient is not the owner` do
     it 'returns the owner name` do
      ##
```
貌似bat文件这里没添加
Правильнее будет сразу расставить им верные позиции и не иметь not null позиций
Yes I totally agree with you. I'll bring that up tomorrow in our weekly meeting. Thanks for the suggestion!
Actually...ignore that comment. I see you just moved it down.
Oh, just noticed the comments surrounding a lot of these tests - I say just delete the tests that are not relevant are being used right now.
I opt for ```Cartopy``` as we appear to have adopted capitalisation for **I**ris in its' documentation.
Sass is so cool!
what is this folder for?
Any calculation (including below) that uses a time value outside of ICARUS_READ_FAULT_COUNT is including hashes that either did not happen or were not checked
Thus including them is incorrect ... again ... unless EPOLL resolves that in all cases (I've no idea if it does - and it certainly wont in the 0xffffffff case)
However, EPOLL is not always compiled in
You're right. In the meantime I better understand how the test infrastructure is set up. I've switched to `messages.clear()`, see commit below.
good pt.. fixed
`searchHistory` `matchedHistory` 我没声明property，是不是也应该把`.h`里的都声明下property？
We need a different name. See org.jboss.as.controller.transform.OperationTransformer.
sure no problem, I correct this
Yeah, why not? We use tabs for HTML and CSS files, too.
lets just have name be undefined here
you can just use "latest"
`render_item(element)` -> `render_item(item)`

The name `element` is exclusively reserved for DOMElement object.
This is an interesting way of setting a CSS global variable :P I don't know how efficient it is, but I'll go with it for now.
This won't work, remove `solid` please!
I gave it a second review and decided the toggle method is not really needed. We are gonna do more things apart from toggle edit mode, and for that I would have to include more logic, so to keep it more simple I won't include it.
you are not handling volumechange. why listen to it?
you are totally right. fixed!
// XXX: May need to handle unknown progress
Use real error object here
You can probably fit more than one attribute on a line here.
Nemuzeme se zbavit `newX` a `newY`?
leftover personal reminder. ill remove it.
Updated commit changes to function
nginx by default if you dont specify will listen on all interfaces, so yeah 127.0.0.1 and any other interfaces on the machine.
原文では tail -f を実行しているかのような、とある
This kind of except is very dangerous, it's nicer to catch Exception subclasses only and to log all the exceptions like this:
```
except Exception as e:
  log.exception("Error fetching woeid", exc_info=e)
  sleep(60)
```
are you doing joins for speed here? Should we be doing joins everywhere? Or do you just think it's cleaner instead of having `var partials = ''` and `partials +=`
Add in an `__email__` tag please.
Should it be that we check for one arg, no args, and print an error for anything else?
Code inside if doesn't work. Users total thankyou count can never be calculated from one message. Users end up having always 1 thankyou with the code below.
This will fail for users that have the config file in the same folder SAB is running from (myself included).
Are you sure they they don't provide a different HTTP status code for requests that are unsuccessful? You would be better off checking that you got a non-200 status code for your error case, as that's the way HTTP works. Also, in the hypothetical case that they didn't (pretty sure they do), I would expect several lines of comments explaining strange code like that to handle the case.
头像为空时，我会去取默认头像
the "floppy_readonly" is a Boolean string, isn't it?
so I prefer "ast.literal_eval" instead of 'eval', to avoid possible security problem.

FYI:
Help on function literal_eval in module ast:

literal_eval(node_or_string)
    Safely evaluate an expression node or a string containing a Python
    expression.  The string or node provided may only consist of the following
    Python literal structures: strings, numbers, tuples, lists, dicts, booleans,
    and None.
The other patch scripts don't seem to do this in both places, although some do it in one place, and some in the other.  There is actually some method to the madness: all of the production monkey patches avoid importing the extra module if it doesn't apply (to cut down on the in-memory code).  The two monkeypatches that are only used during test runs are checked for in the patch script itself.
Actually due design nature of HttpClient we should always call getInstance and it will create instance in case it was NULL, so my CC_ASSERT doesn't require too, sorry, and in destructor static var will be nulled, so it is np and can be done both ways. I just put NULL to destructor to make it look more logically.
Note - if we will keep HttpClient instance somewhere else except scheduler (which keeps it while we unschedule handler) this method either will work not as expected (don't destroy instance), or will make static var NULL.
I not sure what can be best suggestion for this case.
right, you are correct.  We should actually just delete it. Thats what version control is for! :)
more refactorings to allow overloaded methods
This doesn't seem specific to Serenade at all. IE < 9 never does this for any text element, so why document it for Serenade?
http://docs.stackato.com/deploy/buildpack.html
Would it help if we said specifically DefaultGeographicCRS.WGS84 (it would be more explicit and remove any ambiguity)
It makes the function an expression, so it is callable. More info on this see: http://stackoverflow.com/a/5654929/189431
Agreed that this is tightly coupled to the global. Although, as gu.prefs is currently set in commonJavaScriptSetup.scala.html before EventEmitter has been loaded there is currently no way to pub/sub to the prefs object without accessing directly or passing in as argument. 

So we could refactor the gu.prefs object and move to its own module, but even the article bootstrap js heavily relies on it. So we have a slight chicken and egg race condition. Had a similar disscusiion with @ahume about this last week.

Is this even what you meant?
In fact, we have to use the two. Fixed.
I probably won't use this one now that I am forced to use iframe to pull in the section onto a Sierra Club page
Maybe I'm wrong, but I thought that one reason because we mark a module as deprecated, is to be sure that even if they're still present the devs are not going to use them – or at least they are perfectly aware they're deprecated.

They can be still present not only because we want to give to the devs the time to migrate the code, but also because internally we could still have some dependencies that wasn't so immediate get rid of.

I believe that we should choose a policy based on what's best for our users, and at the same time based on what's possible for us to achieve in reasonable time and resources: we can focus to refactor the entire code base and modules that uses deprecated APIs, but it's not realistic. We should doing a progressive enhancement, and replace what we can when we work on them, until we wipe them out. In the meantime, we can mark those modules "deprecated" for the users.

I agree with you, we shouldn't signal deprecation by modules' position, I was just point it out that currently the deprecated modules are under this folder, so it's easy spot them out for both devs and reviewers. My point was that we can't really write that sentence, because at the moment CFX is not raise warnings for deprecated module, and it's less trivial than I thought on JS side. I'm trying a couple of approach in  [bug 725409](https://bugzilla.mozilla.org/show_bug.cgi?id=725409) but I will probably to end up to land it as is and open another bug for this.
If the "future" tense used in the sentence is clear enough, we can leave it ("CFX will generate warnings" = "CFX currently doesn't generate warnings, but it will in the future"); otherwise I will keep this pull in stand by until we implemented the behavior described.
why 'frame'? also i'd prefer that the name explicitly indicated it's a namespace.
@ozten - here is the new and improved catch all.
Are you sure this is a safe test? You're expecting the `json.dumps` function to write the keys in alphabetical order. 
I would just skip this assertion and just do the round trip one
rats... fixed.
there is an assert in is_the_current_page, so the test will fail if you're not on the right page.
Please put a period after `serial.Serial()`.
Right. We expect knife-windows and winrm(dependency of knife-windows) is installed as well.
OHGODSELF. Good eye.
curly is off .. and public is missing
remove this change please
missing `@group Zend_Crypt` here
I think that in logging any component can be changed without change any line of your own application.

The docs must advise the limitations of this formatter and relay to developer if he wants use this formatter or not.
Could you merge those two changelog entries?
It's not even in master yet ;)
Change the function name to setActionBarVisible
remove all spaces in the brackets
This is the only line that might seem out-of-place. Because .dropNaturally() is fired **before** .wasExploded() in Explosion.java, there is no good way to inform .dropNaturally() to drop a block of TNT, so I am causing a block to drop here in BlockTNT.wasExploded().
you also need to add this column to the migration command
Ive deleted the 404 page and CSS so this isn't needed anymore.
OK, then the problem is most likely somewhere else. What do your routes look like?
Couldn't think of a better way to test this…
In the context of this method (parsing types file), optimizing this loop is premature - I don't expect anyone to ever care about shaving a couple uSecs off this method. And forEach() is, imho, more compact/readable.
Limits can be merged as segments. But i think this logic will be too complex for such simple method.
So I agree.
Also (not very important right now) PSR-1 says one `use` statement per row.
FYI: It's 
Time::DATE_FORMATS[:custom_name_here] = "%b %d, %Y", not
Date::DATE_FORMATS[:custom_name_here] = "%b %d, %Y"
I would replace the whole block above with the following:
```
if not hasattr(self, 'author'):
    self.author = Author(settings['AUTHOR'], settings) if 'AUTHOR' in settings else None
```
There are solid use cases for serving feeds from a different domain/sub-domain than the site itself. For example:

1. Enabling support for external feed management services (e.g., FeedBurner)
1. Easier to migrate feed handling to another server, virtual machine, or external service
1. Distributes load for sites with high traffic/subscribers
1. Potentially easier to analyze site logs
Something like this is already implemented in build.py (see robotFindEasyconfig).

Find a way to unify both of these, e.g. put the creating of the list of options in robotFindEasyconfig into a seperate function, and call that function here.

You can add an extra wildcard to allow you to both specify the version, as needed in robotFindEasyconfig, or a '*' to obtain a glob pattern.
On Mon, Sep 17, 2012 at 6:19 PM, Jens Timmerman
<notifications@github.com> wrote:
> Please add a proper sanitycheckpath

Fixed, please review.

Fotis
This should be ok now
Note this change, related to your comment on the call to Kernel.raise in APIDriver.  Here I had to pass an instance of the exception, rather than the class - otherwise, the new exception would have the message set as the status_code (as well as the return from #message, even though they're completely unrelated), because the message is sent in as the first argument to initialize, when raise is given a class.
You should use `django.shortcuts.render`. `jingo.render` is deprecated in new versions of jingo.
Yeah, about 170 additional files to add `connect` as a `node_modules` dependency. [I'd included it in this branch, at one point](https://github.com/lmorchard/kumascript/commit/0230f6d3217788402350aa6d27749cbb316b2480), but it seemed like overkill for this one small method. So, I rebased that commit out of the branch and just transplanted this method.

The `express` module includes `connect` as one of its own dependencies. But, that's within it's own private `node_modules`, which makes it awkward to get at.
This line will need to change to "and not is_valid_path(request.path_info)" and the corresponding import to from django.core.urlresolvers import is_valid_path for Django 1.4 compatibility.
Thinking about this, do we even need it to be this complex? I've tested the following regex successfully:

    pattern = re.compile(r'(?P<version>[^#\s]+)(#(?P<build>.+))?')

This should match everything that's not whitespace or a # as the version, and if a # is found should match everything that follows it as the build number. Thoughts?
Oops, I forgot to push :blush:
This is actually based on advice from the backbone guys - if you don't want to use events: {"event selector" : "function name" } (which I really don't, that's so much indirection it's insane), the idea is to add in all your UX by directly working with this.$el -- I just have it in its own function for (re)factoring purposes. In fact, the setupUX function can probably be refactored into smaller bits, too, for legibility.
if is not used we should remove it
Nop we didn't :)
This didn't work before because export_options is an [HTMLSelectElement](https://developer.mozilla.org/en/DOM/HTMLSelectElement). It has a length property and numeric indices like an array, but it's not an array. If you iterate over its indices you'll get all of its properties and not just the numeric indices.
this is the same mods2html used in another module - i believe i pulled this one from the book solution pack.  my initial tests were failing because of my data, after fixing my objects the fields were populating
Then something seems backwards about this logic...
Вот об этом я что-то и не подумал. Такая реализация can_turn? наверное даже более правильная.
Karang, it is still custom armor in the same way you have custom skins. They do not have values as that would affect gameplay. We'd rather it be done right from the start instead of having to fix things that others break. Likely it will be added by a team member though since Wolftein gave up on it, but unsure as to when as it depends on their time.
What does that do, with the value set to nil?
This argument didn't seem to be used--found this as I was renaming the "code" div.
Esta regla no debería hacer referencia, tenemos un reset que debería encargarse de esto.
use comments only in case if it contains 'TODO'
We could I'll switch back.
this comment doesn't seem to match up: you don't check that notification is null or not
Could you please move the description to a doxygen comment after the license?
Also see http://paparazzi.github.com/docs/latest/styledoxygen.html
the stabilization_attitude_int.h (and airframe.h) includes should be sufficient for the header file. 
If Other includes are really necessary in the c file, include them there....
I suppose if somebody were using USE_TZ=True before 1.4, then the above would be better.
Should check for err here as well.
This should just be the commentId, not the contentId - timestamp combo.
I believe here you wanted to check for object identity equality. If that is the case, it may be better to use ``eq`` (``==`` redirects to ``equal``, which could be overridden by the user, of course).
Remove useless ``super`` call
sorry for the late reply. could you make change this to `public $consumed = 0;`
oooohh
Is this method needed? A `array_filter` should be enough.

```php
<?php

$data = array_filter($json);
return array_merge($this->getDefaults(), array(
   // ...
   'city' => isset($data['geoplugin_city']) ? $data['geoplugin_city'] : null
   // ...
));
```
the filename  attribute is the file base name only, I agree to use it totally if u do not wanna keep the back  backward compatibility. I need get get the relative path info from file.
If its a single return value, don't return a slice. If it has multiple, just make a slice of interface values and return that.
Weer niet nodig deze regel
Deze functie namen zijn echt vreemd ten opzichte van de rest van de code. Ik zou er  dit van maken:

```
this.detectPlayer();
this.moveGeneral();
this.updateHealthBar();

...

this.moveForAttack();


...

this.movePassive();
```
`main-character` (2 woorden)
В вашей реализации в DNA измениться percent элементов, а не percent процентов элементов. и нет проверки на высов с -1 процентом или 123424324 процентами.
вы "собираете" массив индексов, подлежащих замене.

Схема работоспособна, но если у нас будет не 100 элементов, а 100 000 и нужно заменить 99%, представьте, сколько раз будут выполнены циклы по условию в строке 29 в холостую на последних шагах интерации.
Не понимаю, зачем тут городить ссылку на объект типа int, когда можно тупо объявить массив?

`int indexesToChange[dnaSize];`
Тоесть каждый раз когда нужно заполнять рандомальное значение в клеточку вызывать функцию? Если честно то я не подумал об этом, но с другой стороны когда я писал класс Cell я еще не знал, что будет в мутаторе и поэтому не мог предвидеть, что в нём будет похожий кусок кода. Кроме того может мутатор (метод в категориях) обращаться к функциям в основном классе? Правильный ли это подход?
...я так и думал, что использую простую переменную с двумя значениями "YES" и "NO", которая занимает один бит в памяти. не знал, что есть еще и BOOL. Так это разные вещи?
Почему все еще используется || (или) ?
ситуация такая:  элемент старого массива НЕ равен новому, а вновь полученный элемент не равен старому. Т.к стоит условие ИЛИ, то в  итоге проверка вернет YES и мы  еще раз сделаем реплейс объекта, и увеличим счетчик мутаций.
Probably we should remove this library from here, because by now we should use it only in 'attention-screen' right?
removed. I'll like to have a 2 version cycle for removal. 1 version with deprecation warning and the next one that removes the old way
yes, but I would prefer if you create and error object then to use JSON.stringify
```
var error = {statusCode: 500, message: "Something went wrong"};
res.end(JSON.stringify(error));
```
Also, don't keep the message as it is here. "Something went wrong" is not a helpful message.

The same applies to all responses that should return an error.
This isn't particularly (DRY)[http://en.wikipedia.org/wiki/Don%27t_repeat_yourself] but that's partially my fault – I didn't realize that multiple validators in mongoose don't follow the same pattern as a single validator (it'd be nice it you could just do `validate: [maxLength('image', 256 * 1024), isPng('image')]`. I'm not enamored with the way mongoose does validation overall).

Given that multiples work differently than singular, I'd change the `maxLength` and `isPng` functions so they just return the new function instead of an array and a message:

```js
validate: [{
  validator: maxLength('image', 256 * 1024),
  msg: 'maxLength'
}, {
  validator: isPng('image'),
  msg: 'isPng'
}]
```

Note that this will require changing some of the `maxLength` validator declarations later in the code.
Same for these, just deprecate it instead of deleting
Always :D, thanks!
Ok I will enable it back then.
This functionality has moved to a new feature: https://www.pivotaltracker.com/story/show/27515811
@nomack84 : looks like you were right :) !
@weaverryan : I trust I don't have anything do to, it looks like you managed apply the PR without this commit...
但是，当服务器被认为不可用的时候，这些客户端的请求会被分发给其他服务器，而且很有可能也是同一台服务器。
Add line change before `),`.
This shouldn't go in here, use your ~/.sbt/plugins/build.sbt for that
As a sidenote, why the System.exit(0)?
Я бы написал

    const auto& accs = Core::Instance ().GetAccounts ();
    const auto& name = Ui_.NameEdit_->text ();
    return std::find_if (accs.begin (), accs.end (),
            [&name] (decltype (accs.front ()) acc)
                { return acc->GetAccountName () == name; }) == accs.end ();
блин, но создание класса через new Class (this,this) выглядит плохо
Предпочитай `value`.
Sí, deberíamos disparar un FileNotFound o algo de eso. Luego atraparlo y si queremos en el UI podríamos generar un 404 o algo así.
Why change this to CPLogConsole?
GitHub FTW!
I assume this is a place holder for now until all of the novaclient support work comes though. I am wondering if we should pull up that novaclient work into a top level directory similar to horizon.
Ugh wonderful :)

Sent from my digital shackles. 

On Apr 26, 2012, at 1:51 PM, Craig<reply@reply.github.com> wrote:

>> @@ -56,7 +56,10 @@ class BaseController(wsgi.Controller):
>>         }
>> 
>>     def __init__(self):
>> -        self.add_addresses = config.Config.get('add_addresses', False)
>> +        self.add_addresses = utils.bool_from_string(
>> +                        config.Config.get('add_addresses', 'False'))
> 
> great question! well because they are all strings in the configuration file and no types are associated with them from the config class. 
> 
> I realized this when i attempted to turn off volume support with False. It was still turned on. because the string existed. I figured out this is what melange was doing to convert the values. Integers should be casted as well when pulling a config value.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/hub-cap/reddwarf_lite/pull/65/files#r740775
Ups. I miss that mistake. Will be fixed in the next commit
This has been changed… although I'm not sure why this is not collapsing.
If I understand this correctly, you are building and caching all the `git_diff_patch` objects into a list for easy access. One concern with this approach is that each `git_diff_patch` object must keep the entire before and after file content in memory (provided the file is not binary). So if you build and cache all of the `git_diff_patch` objects, this will attempt to keep in memory the full file content of both revisions of every file in memory all at the same time. The working directory versions will probably be mmap'ed and the reference versions will be kept in malloc'ed chunks of memory.

Unfortunately, I'm definitely not qualified to say what does and does not feel like a "natural" interface to an Objective C program. Is there an approach to generating the patch objects as needed that would still feel natural? If the typical use case is displaying a cumulative diff, you generally just need the patches in sequence instead of having to load all that data all at once...
Presumably this is currently always true as I can't see any code further on to handle image diffs vs actual images? Is that correct?
@WeatherGod Same here: The way it is now looks to me like the right way to break it.  Think of how you would read it out loud; what are the natural chunks?  Would you pause after the "if"?  I don't mind letting the binary arithmetic operator stay on the first line (though I don't see any good reason for that rule), but I think "if" is different, and "for" is even more different.
As opposed to a comment, or in addition to it?
good point, updated
Apparently unused?
https://groups.google.com/a/cloudera.org/forum/?fromgroups#!topic/cdh-user/1QtL9bBwL0c
also wasn't this supposed to be called repo-freezedate or something? timestamp is a confusing name since the build-date is actually the timestamp
Can't we use the same syntax as we're currently doing in `default.properties`:

```
MY_PROFILE_OTHER = ${user}'s profile
```
Had to move this comment to make it easier to debug the hashfiles step
what do you need the kernel factories for? they really seem to be not necessary...
We are doing different things on before activate depending on which tabset we are calling and where. We can change this to the tabsbeforeactivate, but we'd still need to use it in each specific context, so couldn't have it as a global thing within this context.
hai no, e fun :smile:, știi cât mi-o luat să găsesc datele alea...
This is a bit needlessly verbose.
```
$c = isset($this->request['c']) ? $this->request['c'] : 0;
$this->response_data = $this->_get_incidents_by_bounds($this->request['sw'],$this->request['ne'],$c);
```
Should we check this every time a hazard reference is released?  Doesn't that penalize read-only applications?

Why not test in an update function, maybe __wt_cache_page_inmem_incr, and then there's no need to test if the page is modified.

Also, if we're not interested in internal pages for this test, we don't need to test the root page, it's always an internal page.

Also... I'm curious why you added the test for internal pages: what was the error you're saw?
Optimizing bsearch is not in scope for the transaction work -- this issue would apply any time we call it.  I've opened #220 for this.
indent within conditional
I just added the instructions to the readme file! Thank you!
On 2012-08-19, at 10:21 PM, Dennis Ideler wrote:

> In source/install.rst:
> 
> > @@ -59,3 +59,13 @@ and Freeseer should detect them.
> >  
> >  .. note:: On both platforms the `.freeseer` directory is in the user's HOME
> >            folder. On Windows this is `C:\\Users\\username\\.freeseer\\`.
> > +
> > +Installation of passlib for Freeseer Server          
> > +*******************************************
> > +
> > +Passlib needs to be installed to run the Freeseer Server.
> > +It can be easily installed using this command:
> > +
> > +::
> > +
> > +    $ sudo easy_install passlib
> Don't forget to add this instruction to Freeseer's README as well.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 

Bora Sabuncu
The assignment to ``$options`` seems to be dead. Are you sure it is necessary, or maybe you have a typo somewhere? Please also check line 132.
Can't rename them with the same name we had in symfony 1.x: `format_currency`, `format_date`...?
This is completely unrelated, but it's interesting that this needs to be listed once for *nix and once for Windows...
%1 should be %1$s as well as 2 ;)
according to the Sf2 CS, the return tag should be removed here
This patch should be in here as it's not needed.
Yes. UnsupportedOperationException is the one to use here.
So what? You are mapping above from string to string in `provider_month_names`. Why not map from string to number instead?
Move this to the end of previous line.
No need for `\`?
<form method="post">	required attribute "action" not specified   <- w3c validator complain... but we don't have any action in html... It's all done via js...
Why fromstring? Why not `objectify.parse`?
Good point. I'll modify the pull request accordingly.
Is this the only way to get the headers? What tool does it use to download them? Seems weird.

Also this URL 404s for me.
Done. the changes are in. Thanks for reviewing. This issue was something that bugged me often earlier. Grateful that ppl at reddit keep their source open for us to tweak a bit.
OK. Well, we're not quite as strict in the games repo, but I'd definitely like this to pull a particular revision and not just let it pull whatever's currently the latest. If there's a revision you can pick out as a known good one, update it like this: 
```ruby
url 'https://github.com/Quuxplusone/Homeworlds.git'
  :revision => revision_goes_here
```
What does setting this to 9 mean? This is untested.
Guild achievements also require the ACHIEVEMENT_FLAG_SHOW_IN_GUILD_NEWS flag check
Do you know whether this is pubchemcompound: or pubchemsubstance:. The pubchem: namespace is being phased out in favour of either of those two.
findBy instead of findby.
1. I suggest we split that functionality to a separate PR _if it turns out we want it_
  2. the problem is not about how to use it, but about educating user to use it. We shouldn't provide every functionality "just because we can". For instance, fluid interface was never implemented in the `ObjectManager` implementations. That is because of how responsibility should always be limited. In this case, you're suggesting an usage of the DIC that is quite different from what it is meant to be (please ask on #zftalk.2 for that). While it turns out to allow `$dic->get('My\Object', array('id' => 123));`, that is the same thing achieved by `$dic->get('My\ObjectRepository')->find(123);`. The responsibility of retrieving instances from some probably persistent container goes to the `ObjectRepository` and `ObjectManager` :)
I think I'd rather stick with `~> 2.0` here, wdyt?
Yeah, RAII handles that.
useShards and useChunks can be set through config options.  By default if your collection is sharded useChunks will be true and useShards will be false. 

This code is inside of the function fetchSplitsViaChunks - and if you have chunks it means you have to be on a sharded cluster (and so you'll have a shardName).
Should we shut down the fetcher here? Otherwise the fetches will be still there.
The `setObject:forCache:` method will check this. Is it necessary to check here, too?
MacPorts, much like Homebrew, can be installed in many different places. It's probably better to set the path manually in *zshenv*.
is there any reason you wouldn't want to set this to true? My general inclination is to have fewer options and better default behavior.
But when you open not `/search` then this is probably not a valid HTML page?
Recommend enclosing this entire method in if (LOG.isDebugEnabled())
This is cool, I didn't realize you could use 'do clean, jar' to do multiple lein actions. Very handy to know about.
... maybe something about using GalSim classes directly as library functions? (i.e. explain a key difference between this and the current form of MOD1?
nice, i think named functions here make sense.
Finding all td elements in the table makes it more difficult to support nested tables. I know that currently nested table support is not possible, but we shouldn't make it worse than it already is.
Should it not load a template if one exists for this campaign?
These lines could use a bit of linting (granted, the whole module could)
"people to make" ?? "people would make" non ?
Why is this changed? `Character`is what's used in the original Java code. We want to stay as close to the original code as possible.
data.paintRectStruct = cellRect;
    data.paintRect = &data.paintRectStruct;
Ok, I'll have to take a look at the "os_custom.c" file. It might be that I just skipped that file completely.
Is Option useful here? Could just Seq[String] be used?
I've changed a few mintues ago
Don't turn it into a list.
self.widget.setCheckable(True) should be performed in the initialize() method instead of the create() method.


def initialize(self):
    super(...).initialize()
    self.widget.setCheckable(True)
@var!
Cred ca in constructorul de la LayouParser ar trebui facuta citirea fisierului primita ca parametru (ce e acum pe L270), apoi apelate functiile interne care construiesc arborele.
When I wrote it, I thought it didn't matter, but it appears that this no longer deletes the directory. so it is necessary.  I'll add it back
This file needs to be added to the package if it is to be used (dbMigration-2.4-2.5-last-error-report-id.sql).

Change debian/rules and SPECS/* to add it.
Then a jira ticket should be created, to postpone the removal of this limitation.

(and in the jira ticket, with comments, it's possible to share ideas about possible solutions)
Oh, I see.
This file implements submitting AJAX requests when user clilcks a link with `data-method` attribute which is generated only in Rails 3.
In Rails 2 `link_to` with method generates `onclick` attribute which is (should be) handled by prototype.
Why wasn't it broken on Redmine 1 in such case if we don't include prototype?
Склеивать строки надо через StringBuilder.
á ×ÏÔ É ÎÅÔ, calendar ÍÅÎÑÅÔÓÑ ÐÒÉ ÒÁÓÐÅÞÁÔËÅ, Ô Å ÓÄ×ÉÇÁÅÔÓÑ ÓÎÁÞÁÌÁ ÎÁ
ÐÅÒ×ÏÅ ÞÉÓÌÏ ÍÅÓÑÃÁ/ÇÏÄÁ, ÚÁÔÅÍ ÐÒÏÈÏÄÉÔ ÞÅÒÅÚ ÍÅÓÑÃ, É ÔÕÔ ÍÙ ÅÇÏ
ÏÂÎÏ×ÌÑÅÍ ÔË ÎÁÓ ×ÏÌÎÕÅÔ ÔÅËÕÝÅÅ ×ÒÅÍÑ

2012/10/31 Dmitriy Komanov <notifications@github.com>

> In src/ru/fizteh/fivt/students/fedyuninV/calendar/CalendarMain.java:
>
> > @@ -176,9 +176,7 @@ private static void printCurrentTime() {
> >              calendar.setTimeInMillis(new Date().getTime());
>
> á ÜÔÏÔ ËÏÄ, ÐÏÈÏÖÅ, ÌÉÛÎÉÊ.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/dkomanov/fizteh-java-task/pull/76/files#r1996723>.
>
>



-- 
ó õ×ÁÖÅÎÉÅÍ
æÅÄÀÎÉÎ ÷ÁÌÅÒÉÊ
íæôé æé÷ô ÇÒ. 195
Переменные без _
А хотя, если в каждом запуске создается свой buffer то лажи может и не возникнуть... Или все же может...
Если используется default Locale, то надо вызывать метод без параметров.
this function seems to be testing the valid case again?
There, change 4 for 9, but for php44, let’s not be _past-proof_. If you want to support php44, we’ll have to test it and modify the class accordingly
The preceding three lines can be a single line ;)
This is not doing anything really, it is returning the same text that it is finding on.
Change this to `is_success_message_visible` which represents what the property is checking. Available sounds valid but it's not consistent with what we do on the rest of the projects.
これかな http://jira.grails.org/browse/GRAILS-6462

意味的は

    Grails 1.2.2 からは@Test@のサフィックスもサポートしています。

ですかね。今2.1.2でためしたらちゃんとTestで動きました。
Please add a one sentence comment to each class in this change that mentions the purpose of the class.
sorry, I accidentally replaced consts with lets
should we have a failure message here?
if (property_exists($this->build, 'estimatedDuration) would be better  ?
I wonder if we couldn't somehow write a generic peak finder (or use the existing ones) for this purpose.
Should be passed to 'scatter', rather than completely removed.
I don't understand this line. Could you add a comment saying what it does?
I'm not sure to understand your question, but yes, it's overrwritten by the "locale" form field. But isn't it was we want, as this is a "default" value ?
this is weird :p
Using dataFilter means we can return the original jqXHR object itself, which has useful methods (such as for cancellation) that converting them to a 'normal' deferred won't give us.
It looks like here fits better find
If this method should work the way it currently does I'd like the method name to state the fact that it should be a non-blocking method, and that it should return null if the condition cannot be fulfilled yet.
The current name makes it seem like the implementation would do the waiting.

If this is truly a condition, it shouldn't return a type, it should instead just return boolean, true if fulfilled, false if not (yet) fulfilled. Perhaps even define an enum with a third IMPOSSIBLE_TO_FULFILL state.

Also the spelling is "Fulfill" (or "Fulfil" in British English).
Shouldn't this be && !_disableExplicitSelectors?
the test does not what this description says
This data type's definition is not complete.  It's a stub.
The set of supported colors will need to be updated in the UI.yml file unless all listed forms in the doc are supported
Likewise, can this block of code be removed, since it's commented?
Shouldn't it be `isWin = process.platform === 'win32'` then?
your clock needs new batteries since a while ;)
I don't pretend to understand this part. It was ipsis literis copy of the function in CDistributedDirectory.
not used as far as I can see.
hardly worth it, but yes.
Should this be uncommented and used instead of the line above?
What does this comment mean ?
Looks like a file named `237823.1212.msgpackaizenauoizenucaozen.tmp` would match. Probably not what we want.
That's Peter's experience for you! Thanks, I didn't know that. :)
Instead of doing a case statement, how about commands `JavascriptAlertMessages`, `JavascriptConfirmMessages`, etc.
same for this example btw
Substitute try catch for @WarnOnly  if you like it better.
remove smoke from group
make method names more descriptive and bundle specific verifications together. For instance: 

The three assertions here logo, top and reginfo are verifying the header. In your page object you can define a method verifyHeader() {
-- do all your verification here ---
} 

in your test class call the verify method. When doing a code review and when it fails the code and error is more readable and easily identified.
@yuhunglin  Do you want to specify a full or calculated path to the .rspec file, or will this script always be run from the same directory? Also, >> will cause the .rspec file to grow infinitely. If you don't want that, you can blank it at the start of the script with just 

> .rspec
As with the above, `do` is unnecessary here (though removing it means it'll have to be changed to `let … in …`).
You could combine these on to a single line to tidy this up.
Because that would be obvious and make total sense.  :-) I guess I just needed a second pair of eyes.  I was staring at the code last night thinking that something was not quite right....
I would like to check res.code before res.body. I can add it by myself when merging. No prob :)
I tested it. It doesn't make a difference performance-wise. The C code is a bit longer but the Cython code is a bit more readable, I feel.
If you prefer I can do two loops.
If you convert the uints ``[0 100 200 255]`` to bool, I think you want ``[False False True True]``.
Which example do you mean? Because I do not know of a example for the old fast_homography transformation?
fair point. I'll change it.
Do we even need to specify anything?
You could remove this file as you aren't using JSF.
After looking over czm_lightValuePhong it appears that czm_material.specular IS being used as a specular exponent.  Actually 1/specular, but still it's used as the exponent.  What might be missing is the ability to control the color/intensity of the the specular light.  ie now you can set specular to be be a narrow bright reflection, or a broad bright reflection. You have no way to create a broad, low-level reflection though.