labofsahil/github-event-dataset-2012 huggingface dataset:
@felipesilverstripe @normann I think this title should be empty by default, the name "data models" doesn't really mean anything to the end user, and we don't mention this term anywhere else in the UI. 

Either we always show the tab bar, even with one tab - then we have a natural header with the actual model name.
Or we detect if only one model is managed, and set the <h2> title to the model title, without tabs.
No you're right. Thats a mistake. I'll fix that.
if ('' !== trim($value))
causes errors on multioptions form elements
should be
if (is_string($value) && ('' !== trim($value)))
Interesting! Very short. Just at a superficial first glance there's quite a lot of duplication. For instance, ````@players[player.to_i - 1]```` appears a lot, as does the magic number 100. Any way of DRYing this up?
Nope 49 is unbootable so revert again
maybe make "Skitch" and "Cloudapp" links?
Do you plan on using this?
What needs to happen in order to finish this function?
Ah, I see.

Can you provide me a full dmesg log from your stock ROM (if you have one handy), please?
Your comments suck :D
@GaryJones As written above: 90% of your comments are your personal style. If I'd refactor/rework it to _my_ personal style, it would look completely different. You can take a look at my repos, then you'll know more. And I'm not reworking it for personal preference, but for github code parser and readability. 

If you have stuff to add to the codes phpDocBlocks or find failures, like the time (6hours), please make a pull request. Thanks.
../a4process/src/driver.cpp: In member function ‘int a4::process::SimpleCommandLineDriver::main(int, const char**)’:
    ../a4process/src/driver.cpp:488:38: error: could not convert ‘errors.std::vector<_Tp, _Alloc>::operator[] [with _Tp = std::__exception_ptr::exception_ptr, _Alloc = std::allocator<std::__exception_ptr::exception_ptr>, std::vector<_Tp, _Alloc>::reference = std::__exception_ptr::exception_ptr&, std::vector::size_type = long unsigned int](((long unsigned int)i))’ to ‘bool’
    ../a4process/src/driver.cpp:499:18: error: could not convert ‘error’ to ‘bool’
@geemus: Line 58's comment implies that the other ones are also EBS:
    
    case attributes[:connection].instance_variable_get(:@region) # Ubuntu 10.04 LTS 64bit (EBS)
joins on A2_Assay and A2_Sample are redundant, there are FK constraint on ASSAYID and SampleID.
That makes sense. I suppose the reason I did it this way is that with the previous behavior a `pip install --upgrade` never presented this message, whereas now it can and it struck me as confusing that the user would be directed to perform a `--upgrade` during a `--upgrade` (the source of the confusion here being the ambiguity of the argument to `pip install`)
I had to switch this from `"MSTransition"` to `"msTransition"` so it would pass the feature detection test.
divider_theme is better than "divider". Also you can extend it from BCommonProperties.theme like the following:
divider_theme: $.extend(true, {}, BCommonProperties.theme, {
    displayName: "divider theme",
    htmlAttribute: "data-divider-theme"
})
Would you mind deleting this line?
there's a theme for cas management?
I meant that number "12" in the key is different than number "9" in the value ;-)
and then it shouldn't be lazy either right?
yes, I guess it should. but it is in the standard library now meaning that it would take a bit longer to do, and it would not show up in M7 since that is fixed already.
why INSTANCE.generateSeed(Seed256.size) instead of engineGenerateSeed(SeedSize(256))
SeedSize could be:

object SeedSize {
  def apply(bits: Int): Int = if (bits % 8 != 0) throw new IllegalArgumentException("bits need to be a multiple of 8") else bits / 8
}
No need for a 2-pass:

nodes foreach {
  case (`myself`, t) => thunk(t)
  case _ =>
}
... and I just wanted it be in symmetry with the other probability we have, gossipToDeputyProbablity
This is also local.
ok, removed LongRunning from this test
Shouldn't examples be moved to the examples dir?
collections.Counter may be better here (for float division cast one of operands to float).
Ah, is that so?
Thought, in case of GET, no show is necessary.
"get logger" -> "get logged"
I also prefer the full stack trace when debugging, which why I default to providing it when I mask exceptions.
Ditto, for this whole file, it would be nice to use the recommended sphinx syntax.  http://sphinx.pocoo.org/markup/desc.html#info-field-lists
should mark before reply I think
No problem.  I'll add them to `Gemfile` instead.  I was following the lead from d8a950668878de619aebb30e7897a03d5c12716b.
The input protocol already does this for you. I'd just rename the `key` argument to `coordinates`.
Agreed.

"log10Scaled" is an attribute of a product  and "log10ScaledDisplay" is an attribute of an image at the time of display. I agree that ImageInfo is the right place to keep track of the display option for both image and histogram.

Aynur Abdurazik, SAIC
Ocean Biology Processing Group
NASA/GSFC Code 616  (Mail Stop 616.2)
Greenbelt, MD 20771
Phone: (301) 286-4072







On Mar 12, 2012, at 11:08 AM, Norman Fomferra wrote:

@@ -34,6 +34,14 @@ public double scale(final double value) {
        public double scaleInverse(final double value) {
            return value;
        }
+
+        public boolean isLog10Scaled() {
+            return false;
+        }
+
+        public boolean isLog10ScaledDisplay() {

This method is about _display_. Scaling is a part of the _data model_. Display and model shall be decoupled, simply because there may exist multiple ways to display data.

---
Reply to this email directly or view it on GitHub:
https://github.com/bcdev/beam/pull/2/files#r546178

--
To UNSUBSCRIBE: Send an e-mail to
seadas_dev-request@seawifs.gsfc.nasa.gov
with the subject, "unsubscribe"
Do you really need to test for `has_capability`?  It's a class-defined method (meaning, we don't patch it on), it should always exist.
```python
raise NotImplementedError('"{0:s}" method not implemented yet.'.format(method))
```
What is ClientListener?  It's not used anywhere AFAICT - best remove it and the m_listeners member because it's causing compile warnings.
Is this worth noting?
why store in a val here?
... please do explain? This is the first time I'm hearing this.
I actually like the ability to specify the default options at one place, and overwrite them as needed. In some cases, this can greatly reduce the amount of duplicated code. (Maybe I'm doomed, but at least I have readable programs ^^.)

Without looking at the source code, you'll never guess that it won't work.
Maybe this instead?

```javascript
} else if (handle instanceof dgram.Socket) {
  message.type = 'dgram.Socket';
} else {
  assert(0);
}
```
Yeah, I am similarly confused. I've been poking and prodding at the code today to try to really get what's going on. Still not there…
Hi igorw,
 did you try 10.8 is that still broken in 10.8?
Why lowercase ``q``?
лишние пустые строки убрать
I used "update_attribute(s)" for the commit message but figured I should avoid the possible confusion with method invocation, in the CHANGELOG. I'd be fine with either though!
Do we need the line [699](https://github.com/nateberkopec/rails/blob/fd9b9039c1848ad56cefe9f0a09c5ebd586af9f1/actionmailer/lib/action_mailer/base.rb#L669)? If we don't you can remove this `||=`
I think we need to ensure that the `connection_handler` inside the thread is new_handler
@josevalim thoughts about this?
If you need to test something using `Rails.env` then you should test the behavior in railties. The tests in the frameworks should not know about the `Rails`
It has to stop - it isn't recursing.  It's folding across the filters.
Sounds good to me to have only one version of the extractor which catches neither fatal or internal throwables.

Naming-wise, I'm still unsure if it's the best solution (notice the description of the `NonFatal` case in the comment in:

    catch {
      case NonFatal(e) => // will not catch __fatal__ or internal Throwables
    }

 the match), but we can think about that later.
append ``instance``. same for other plot docstrings.
This should be `"(\\d+(?::\\d+)?)\\s*"` in case there are any number of spaces, not only 0 or 1.
Would it be more useful to have an optional argument in potential energy or some other way to pass in the potential energy definitions? Seems like if you have to call .set_potential_energy for everything seperately anyways, what is the point of this function? It only takes a short one liner to sum up the potential energies if you've already defined them. Maybe something like:

```python
potential_energy(Pa, A, expressions=(m * g * h, M * g * h))
```

Then you at least don't have to type .set_potential_energy so many times.
so your categories are locally small?
The surd function is confusing me (the docstring is not very clear, aside from the fact that I did not know what a "surd" is until I looked it up), but based on what I saw, I suspect the new result is wrong.
Shouldn't it also return NotImplemented if this raises NotImplementedError (as above)?
`See Also` is meant for other objects defined in the code (I did not see anything called `unimodular`). You could add a `References` section with links to appropriate resources if that is what you want.
is there a missing indentation here (between the last two lines)?
Should be Pow (with capital P).
To keep it from getting too long (past 80 chars) and to make it more legible, perhaps write it as```
assert (
M.det() ==
M.det_bareis() ==
M.berkowitz_det() ==
M.det_LU_decomposition() ==
1)
```

or 

```

assert M.det() == M.det_bareis() == M.berkowitz_det() == \
       M.det_LU_decomposition() == 1
```
Hm. I don't know. https://github.com/sympy/sympy/wiki/Writing-documentation and http://sphinx.pocoo.org/ and http://docutils.sourceforge.net/rst.html might be a good start. Basically single backticks are for latex and double backticks are for code. Run make -C doc html [in the main sympy directory] to build the docs, then view them with a browser.
But according to the PDO manual (http://www.php.net/manual/en/pdo.rollback.php) and Yii API (http://www.yiiframework.com/doc/api/1.1/CDbConnection) correct spelling is `rollBack()` not `rollback()`.
and this
```php
return t('yii','ImageMagick or GD not installed');
```
If arguments accepted are important for this interface, you could also check function arity too :)
you should add a warning as calling isGranted if there is no token will throw an exception
Ok no reason to use an eval, I've replaced is with json.loads()
Since it is not realy a bug but only a bad definition of a requirement that a file name should be a ruby file.
what I am realy worried is why the typo  in the lib/params.rb did not break the tests.. My tests were broken.. so why the tests in the BBFS master did not break ?
In linux this will not work since the entire process is reexecuted. We need to change ARVG param 
from --bg_command=true 
to --bg_command=false
This will ensure the setting of this param to false for backround execution
Added  'lib' to all paths. Done
only thing that's needed here is passthrough(x) on the child process object returned from `.exec()` - if you do not do this then the user sees no output during the long pause.
The shell iterates the cursor 20 times to print the selected documents; not necessarily that MongoDB returns the first 20 documents
- this

- "for `$box`?"
period at end of sentence?
This looks sqlite-specific, yet the function otherwise has no db-specific code. What should probably happen is $db->sql_error_triggered should check if the error is "not an error" and report this condition as not an error.
There is phpbb_pcre_utf8_support function that should probably be used instead.
In [discussion](http://area51.phpbb.com/phpBB/viewtopic.php?p=240791#p240791) you said trigger_error removes query from input box, but you still use it. Will it keep query in input box now?
You should probably assign the function to a local variable if you intend to scope it locally.
If this query is meant to run on phpbb database I don't think you can get away with specifying it inline like this as the syntax has to be different across dbmses we support.
I don't see how this will harm anything.
should propably be PHPBB3-10601 as that is what our tracker creates...
shouldn't callback be the last parameter?
Would you want that added to luvit/lib/luvit/path.lua ?  Something like win_path_has_drive ?
c8eca7c
BTW there maybe a bug if infoLogLength <= 2
Should include this API change in the compatibility and change docs.
Instrumenting each request does look a lot nicer than instrumenting the whole server.  By doing this, we can be sure that performance metrics for each request are kept separate from other requests.
This test should be for the base zmq.Socket, not restricted to the green subclass
I checked the database from implementation site and they are entering 10 digit mobile no. for almost all contact numbers.
Please remove unnecessary comments
Subtle one this ...

It's related to an issue way downstream, hence why this seems like a random patch.

For ```test_nimrod.py``` the underlying dataset appears to be in column-major format. As a result, when NumPy loads the data payload (which is not currently deferred) it is not contiguous within memory. This causes ```iris.cube.Cube._xml_element()``` to blow when it is calculating the data checksum with ```hex(zlib.crc32(self.data))``` resulting in the exception ```TypeError: must be string or single-segment read-only buffer, not numpy.ndarray```.

This fix resolves this issue.

At the very least, I'd agree to adding a fuller comment.
This is the actual code change.
a little weird
why is this condition now continue instead of return?
What does renaming the parameter accomplish?
This looks serious:
repeated "resetPlanNodeIds(rootPlanGraph, nextId)" seems like intended as  "resetPlanNodeIds(subPlanGraph, nextId)" ?
Do we support this query today? I didn't think we did self joins?
What's bad is that you are modifying a row of dbcSpell. This change will affect all Spells with that SpellEntry, causing unknown behaviour. The only place where SpellEntry objects can be modified is ApplyNormalFixes() in HackFixes.cpp .
@stephenh also proposed we use something other than checkboxes here for domain management (I followed up with a "Domain Widget" from the "Data Filters" component) but this change was out of the scope of what I was trying to do here.
Check for doc == NULL right away on top of the function (input validation) and safe yourself the double check in line 1097.
Is this something we should be tackling now? All my tests will fail valgrind right now. It was my understanding that we were going to write tests to pass the spec and then worry about valgrind later. 

A lot needs to be changed here before we can start getting rid of those memory leaks. Either the NodeFixture needs to keep track of all the nodes being created, or we need to restructure how the Nodes function.
The original is wrong too then ;)
Why do you think creating a hash table is expensive? I haven't looked at the PG implementation too much, but in general this is a simple data structure. Also, for each function the hash table is created only once per query, so not a big deal I think. When would the execution time of a code path that is run only once per query, and that is probably in the order of nanoseconds, be relevant?
We can not refer to the column name here, since the column is an expression ```MADLIB_SCHEMA.svec_minus(MADLIB_SCHEMA.svec_plus(a.set_list, b.set_list), MADLIB_SCHEMA.svec_mult(a.set_list, b.set_list))```.
One solution is, that we use a subquery to get a column, and we refer the column in the top query.  Please refer to the following code. But i don't know if it will bring to additional performance penalty. I will do a test for that. 
```sql
    EXECUTE 'CREATE TEMPORARY TABLE list_b AS
    SELECT text_svec, set_list, tot_products
    FROM (
        SELECT MADLIB_SCHEMA.svec_to_string(set_list),
               set_list,
               tot_products
        FROM (
            SELECT
                MADLIB_SCHEMA.svec_minus(MADLIB_SCHEMA.svec_plus(a.set_list, b.set_list), MADLIB_SCHEMA.svec_mult(a.set_list, b.set_list)) as set_list,
                MADLIB_SCHEMA.svec_l1norm(MADLIB_SCHEMA.svec_minus(MADLIB_SCHEMA.svec_plus(a.set_list, b.set_list), MADLIB_SCHEMA.svec_mult(a.set_list, b.set_list))) as tot_products, 
            FROM
                assoc_rule_sets a 
           CROSS JOIN
                assoc_rule_sets b
           WHERE
              a.text_svec <> b.text_svec
              AND a.iteration = ' || n || ' 
              AND b.iteration = ' || n || '
        ) t
        WHERE MADLIB_SCHEMA.svec_l1norm(set_list)= ' || n+1 || '  
    ) t
    GROUP BY 1, 2, 3
    m4_ifdef(`GREENPLUM',`DISTRIBUTED BY (text_svec)') 
    '; 
```
Also, wouldn't it be more appropriate to put in `<>`? After all, it's not a relative path to the current file.
`.replace(/\\/g, '/')` could possible be used here instead.
Thanks for pinging.  Will look again.
`depends_on MPIDependency.new` should set these for you.  https://github.com/mxcl/homebrew/blob/master/Library/Homebrew/requirements.rb#L99
I have seen people having problems getting it to build with the bundled OpenSSL in the past so probably not.
Buuuut... If you are scared omit it.

On Nov 12, 2012, at 4:24 PM, Brenton Leanhardt <notifications@github.com> wrote:

> In lib/rhc/rest/client.rb:
> 
> > @@ -14,7 +14,7 @@ class Client < Base
> >        # The list may not necessarily be sorted; we will select the last
> >        # matching one supported by the server.
> >        # See #api_version_negotiated
> > -      CLIENT_API_VERSIONS = [1.0, 1.1, 1.2]
> > +      CLIENT_API_VERSIONS = [1.0, 1.1, 1.2, 1.3]
> >        
> Just checking, was this change expected?
> 
> —
> Reply to this email directly or view it on GitHub.
>
This can error out and there are a couple of ways to get the fingerprint based on support on each platform.  When you get the keys from the server don't they already have a fingerprint?  If not all of this functionality should be moved to a helper.  If all key fingerprint code fails then a message should be placed in the fingerprint area such as "Invalid Key".  Take a look at what the legacy code does here.
I know it isn't introduced in this PR but I had a small WAT?! here. Would `value = json.loads(value) if value else None` perhaps be clearer?
If I choose to continue support for Python 2.5 will need to work around next being >= 2.6
stimmt.. hatte das initial mal in der debug class selbst gehabt, und da gings nur so.. danach nur c&p.. ;)
yeash. i stucked at holy bug when string received from last signal with garbage at the end ant can't solve in other way.
i have some ideas how to rewrite some things before that, will try tomorrow
标点一律用中文的，包括（）：等

啥是AUR？
Sorry for misleading you on this, Colin! 
It shouldn't be in the else as I suggested, since the it wouldn't be able to handle a setting object like:
setting = { applications: { ... }, foo: { applications: {...} }
As mentioned, those should be private and have a getter.
I think you can call "unfiltered2" "attributes" instead. Also, you can combine these two lines like this:
var attributes = this.tags[tagName].attributes.concat(this.globalAttributes);
If selectionStart != selectionEnd, hitting an arrow key clears the selection without moving the cursor, so we could allow default in that case.  Otherwise, if you select-all in the text field (or if we in the future automatically do so upon focus) you can't clear the selection without making an edit.
I suppose we could address this later by refactoring the statusbar updating code out of ``EditorManager``.
Also, the core commands in Commands.js don't follow this format.  We should probably mention that (it's implied by "Plugins should..." but easy to miss).
(I know this is pre-existing code, but this seems like a good opportunity to do small cleanups).

Could we add an "_" prefix?  All the other private methods in this module have one.  (Or we could make this an inner method within MultiRangeInlineEditor.load()... it's only called from there). If it stays here, we should add a blank line below it.
Yes - JSLint did complain. - I put it back in
Done (I added a map from mode names to buttons--seems useful to have one level of indirection in case something changes in the implementation later).
What is missing here is loading this.offlineQueue from localStorage. Now the offlineQueue gets reset when the application starts in offline mode (can happen in the local version as well as when we use html5 manifest).
I agree, I considered that exact implementation, but I didn't want to change the break the existing API without feedback.
Paranamer now has it's own unit tests that got committed alongside the fixes.
Hm, I wonder if we can avoid hitting the DB twice for this?
some thoughts about these two lines :
- The two if blocks whould be merged
- What if the currentFilter is null ?
I'm not entirely sure this makes sense as a singleton for `Remote`. We might as well declare it as a method on `Repository` directly.
One line too many. Please - I am not writing to you all problems of the same nature over and over again. For each problem I write, please go around and see if there is something like this also elsewhere.
fix the space after {
Don't need these two lines at all now!
Looks like it shall be `!/Safari\/5/.test(navigator.userAgent)`
Please cache the `queue.fnArray` and `queue.argsArray` in a local variable.
Rather than `:body`, I would make this be `[[post_body_keys.first, doc_body]]` or maybe `post_body_keys.map {|key| [key, doc_body]}` -- not all post types w/ one body_key are `:body` (see the [Quote](https://github.com/mwunsch/tumblr/blob/master/lib/tumblr/post/quote.rb) post type)
Why are there 2 files to configure the mime times?  I'm confused...
Huh, I see your doing "next id = max(id) + 1" down below...why did this change to 0, 1 instead of being 1, 2?
这个跟IPSTAT无关。你把它想象成独立的机制好了。
please no commented code if it is not properly commented as example
Please, add a css content in separate files.
> 4 can be a property of the object, so it will live next to the other customization bits.

Can you elaborate?

> I think this.currentCode should not be updated if there is already |n| characters.

Update is prevented by status set by `this.checkCode()`. Checking it here again is duplication.
why 100?

not: add names to your anonymous functions
Do you really want the source code dir or do you want the objdir? In This case there is already MOZ_OBJDIR
Maybe also mention here that the hub (https://github.com/defunkt/hub) command line tools now support doing this from the command line?
...but?

I'm not clear what this function is for.
can here use "user" upstart stanza?
Here we print an error and then happily continue running, but ... `<continued below>`
Use the public URL here: `git://github.com/basho/riak_search`
Odd, looks fine now... May have been a github glitch.
I wonder if we couldn't have the size be the sum of the size returned by each lines. So we could eventually have streamed contened in the multipart like files or any othe stream function that is able to return the size of the streamed content. Thoughts?
This opens up a potential DoS, I can send you a gazillion tiny transactions to try to get you to spawn gazillions of threads.

I'd suggest not notifying transactions that are less than MIN_TX_FEE/-mintxfee (see code after // Fee-per-kilobyte amount considered the same as "free" in main.cpp)
Good catch, as such a thing did cause a crash a few versions ago.
I think you want to put the net-specific path in pathDataDir - that's the one used almost everywhere but in GetConfigFile.
This and the line below contain parse errors.

`Parse error: syntax error, unexpected '=' in lib/Cake/Console/Command/Task/ModelTask.php on line 415`
Gotcha now.. fixed it up.
missing type (``object``)
Suggest to comment out one of the flash defines and maybe add a comment to explain.
This is already in there at line 53 of the file (with a slightly different name), I think this part is cruft from a previous pending test stub.
Maybe all control chars including esc should be disallowed. If you're pasting into an editor, it would make a mess of things.
@takluyver @fperez and @minrk how should I handle the fact that `distutils.Extension` cannot handle unicode paths?  Right now to get it to work I am just calling `str` on this path.
How about calling `X.encode(encoding)`, with `encoding='utf-16'` on windows and `utf-8` elsewhere?  If we can believe [this post](http://www.conifersystems.com/2008/10/21/windows-vs-unix-file-system-semantics), Windows uses utf-16 uniformly for filesystem encoding, so that should work.
expense isn't an issue at the moment, as we are not pooling 1 trillion nodes :P

main thing is to break up things so that they are testable :) A function is very easy to test.

Maps2.transformKeys is what I meant
I assume these changes were unintentional?
@arrbee Of course, you're right! Otherwise no header is being generated for binary files.
I really like that `@see` can URL reference here as well for the specs
fixed absolute path to account for '/' at the front allows for relative pathing
We should briefly review the class hierarchy.
This would probably be faster if you built the whole string first and then wrote it out. Although, I'm not really sure of the overhead difference and this is just a test so maybe not worth it.
have you forgot escape character in group#12 (checks for query)?
example:
url is http://example.com/?query=2
detected query is "query=2", but should be "?query=2"
here I would indent an extra 4 spaces :)
__whimboo__ wrote:
> ... behaves correctly in such a case.

What are You expecting? What would You like to trigger?
`aResult` with bad code in the callback? Or an exception while calling `NetUtils.asyncFetch()`?

I have no clue how to get an `aResult` with bad result code.
And making `NetUtil.asyncFetch()` to throw an exception isn't that what we would like to do here, IMHO.
This entire else block could be replaced with something much more readable:

```    
    seconds = convert_frequency(self.config.frequency)
    interval = datetime.timedelta(seconds=seconds)
    missed_execution_time = last_success + interval
    while missed_execution_time < now:
        function(each)
        missed_execution_time += interval
```
Oh now I see what you're doing, sorry. Still not sure about the syntax but I understand the ``SELECT``.
oh!   Thank you.  That's code which was supposed to be deleted in this checkin!  

FYI, beta_number=999 was for the "final betas", something we don't do anymore.
Would this file need to be modified to allow hbase? I was expecting there'd be an include file for this ala primary-crash-storage.ini
This is a nice cleanup. :)
`api_info`
roster_changes is a Hash where the key is the course, and the value is a hash of added, dropped, and not_in_system arrays of students. While bullet proofing is nice, I don't see how this particular error condition would occur. 

If it did occur, this is not how I would wanted it handled. An email should go to me, not to the professor. Thus detection of the error would need to happen up the callstack, potentially in send_emails.
hi phil,

if you are talking of &nbsp; the unbreakable spaces are needed in french before ! ? : " etc.
This cannot work. You need to access `$constraint->ignoreNull` instead.

Please add a test that proves the implemented functionality.
@fabpot It was requested by @bschussek in comments above.

@egeloen Maybe just remove `@link` annotation from this comment and leave only link it self.
Depends a bit on how #6129 turns out. If we depend only on the Translator's API, we need this class in the Validator in order to function also without the Translator implementation.
it does not say anything about line length because there is no length limit. And as there is no limit, there is no reason to put the description of the param on another line
Fixed, thanks. The old code was also wrong.
@lsmith77 where do you see that `\Closure` type hinting is not recommended ?  I think it was the case in an earlier version of the php doc and asked Dmitry Stogov (back in october last year). His reply was that is it safe to use "\Closure" as a type hinting.
missing space after the type cast
I don't think it's odd. It makes senes this way.
That's just how it was.
maybe `color = 'r'` so it shows up clearly on gradient background.
Why is it so important to make private members private to the instance?

Also, my reasoning for the lazy val here was allowing the creating of a client without doing the connection leg work until the user actually used the client. A replacement for having an explicit 'connect()' method.
Again using Calendar here?
missing `break;`
Can also be `null: false`?
A+. We don't have a repo-specific style guide but should probably add one.
关于2.3（当然2.3只是个例子）的问题，如果2.3版本中修正了或增加了一些内容，并在各个平台及编译环境中测试通过可以公开发行的话，正式版本号应该就是3.0。关于目前的版本号，完全是内测，按照完成度来看的话，我觉得应该是0.8版本了。
Надо делать тест и по тесту смотреть где проблему с НЕ уменьшением каунтеров
trebuie de făcut un parțial și de transmis task ca parametru, să putem refolosi la alte obiecte.
you can use:

    import tempfile
    tempfile.mkdtemp()

to not have to managed that directory: http://docs.python.org/library/tempfile.html
NIT: extra blank lines?
Ok, I just wanted to be sure this is expected;)

The code compiles and works on Windows, so it LGTM
So defining `{string, stdin}` as the default for terms results in that by default being passed. By putting an `io:format` under `process_opts(Opts)`, we can see what is being passed:

```
∴ ./dev1/bin/riak-admin diag 
Options: [{user,"mirell"},
          {etc,"/Users/mirell/src/basho/riak/dev/dev1/etc"},
          {base,"/Users/mirell/src/basho/riak/dev/dev1"},
          {level,notice},
          {terms,stdin}]
```

What this means is that there will always be a `terms` option, and so we will always get machine-readable output. 

Instead, you should change `{string, stdin}` to just `string`. This will coerce the given value to a string, and will not have any defaults assigned. When you attempt to call it without an argument after changing that, it will result in this:

```
∴ ./dev1/bin/riak-admin diag --mr_out 
Invalid option sequence given: {missing_option_arg,terms}
```

Which seems perfectly reasonable.
@cedriclombardot thanks, i got it to work! :)

@willdurand, @cedriclombardot i changed the command a bit, shouldn't it only check to delete app_* files? Do you ever want to remove your app.php? In our projects we have checks in our app.php which change the environment based on the server it's deployed to.
Wouldn't this require a protocol version bump, as older servers will not understand this new message?
No, its a job for whoever subits the pull request. Have a look at org.jboss.as.web.WebMessages, it takes all of about 10 seconds.
What's the rationale for all this flexibility? Why not just require that the property be set or the ManagementClient be provided?

This is minor in the big picture, but in the first 1 1/2 years of the AS7 project a lot of "convenience defaults" like this crept into the testsuite. And then at critical times when there were much more important things to do, we had to divert major resources to hunting through the testsuite to go eliminate them. That's not going to happen again.
Looking at the Jira and the imports further down you are still importing the following from the server side controller module:

import org.jboss.as.controller.PathAddress;
import org.jboss.as.controller.operations.common.Util;

They seem to be used by
https://github.com/baranowb/jboss-as/blob/d8e32f4cd7e17afad67c80eec9a4af1ce182e62a/arquillian/common-domain/src/main/java/org/jboss/as/arquillian/container/domain/ManagementClient.java#L231
ModelNode op = Util.getEmptyOperation(READ_CHILDREN_NAMES_OPERATION, PathAddress.EMPTY_ADDRESS.toModelNode());

The imports should be removed and the above should be something like:
ModelNode op = new ModelNode();
op.get(OP).set(READ_CHILDREN_NAMES_OPERATION);
op.get(OP_ADDR).setEmptyList();
Unfortunately, this need to be smashed together with the previous line for the variable replacement to work.
yep, it has slightly changes, but I will try to make them to converge.
Right now we only change the tag to enable/disable edit mode, but in near future PR we should also show an image to the user if there's no messages. 
Anyway, the toggle method with argument seems ok, and we can finally call that from a showNoMessages function if we finally implement it.
Same here ;-) Are asses are safe now :-O Anyhow, I will include it in my next PR once this one is closed :-) Hopefully, no more inter-PR resolution like these ones for a long time ;-)
Right. Fixed. :-)
@steveck-chung Does this change impact your change from yesterday?
Same comment as above for dead code.
Do you really need a 1 between support.mozilla.org and firefox-os ?
What's the z-index of this div? I couldn't find it in CSS.
Hopefully I have not reviewed this code because I have always hate this kind of declaration for vars instead of having a var per variable. (i have not always hate it but i'm not ready to admit it)
These two lines are out of date since we don't have a Back button anymore.
var overlayStyle = this.overlay;
var firstShownStyle = this.firstShowStyle;

and use them.
ok but it is out of this pr
Yeah RAD does set them and http_spec doesn't. My thinking is that `request_content_type` is redundant and neither RAD nor http_spec should need to set them for Raddocs.
I think in all of these "return False" cases it's better to return None (or raise an exception), because as you noted before, if now we're expecting a return code, False and 0 evaluate to the same thing, but 0 in the context of a return code means it didn't have any errors.
We need to flow it as part of the Environment and make sure it gets here (maybe as a ctor parameter). It does require plumbing though. We'd add the path here https://github.com/projectkudu/kudu/blob/master/Kudu.Core/Environment.cs and fill it in  here https://github.com/projectkudu/kudu/blob/master/Kudu.Console/Program.cs. Once it's populate in the env, you can pass it to the ctor of BasicBuildrer:
https://github.com/projectkudu/kudu/blob/master/Kudu.Core/Deployment/SiteBuilderFactory.cs#L78
https://github.com/projectkudu/kudu/blob/master/Kudu.Core/Deployment/SiteBuilderFactory.cs#L158

Basically following the same pattern as the TempPath.
Good idea. That would probably make a good recipe as well!
Seems like Eclipse is being a bit wonky about my formatting.  I'll have to double check it with NotePad++ for the time being.
直したサンクス :exclamation:
You never know, how long it will take until the "real" starting lights are there. It's probably not highest priority, so better move it in place right away ;-)
The color should probably be ``@highlightPrimary`` from the color.less mixin, to prevent introducing another red color.
Please in the future avoid making the same change to 2 branches.
I changed the variable name to `context`.
This is unlikely to be general enough to go here.  I'd deal with it at the place that calls this, if possible.
Wouldn't it prevent to continue executing the next if? Maybe first check for unauthenticated, and put a return there. If there is another error, show the alert (continue to sendDidFailWithError) But this is only a thought, it should be tested to be sure it actually works
what kind of events do you look for? Join / Leave events? shouldn't the plugin creating the channels manage this?

atm there is no way to get a certain channel if you don't know about it.
If free choice is mine, 3) by all means.
Else 1).
almost - but not always, I guess. there are times when it is useful to debug the site in debug=0 mode (especially with ajax etc).
indeed you are right, I always take setUp like a preExecute by error
i would write it 
```
$dir = $workDir . ($sourceRef[0] === '/') ?: '/' . $sourceRef;
```
or even 
```
$dir = $workDir . '/' . ltrim($sourceRef, '/');
Generally, if you are posting stuff out, you know you need to base64 encode/decode things before you post it... not having the actual value come out of the database seems like something you have to remember before using it, which seems like it could lead to more mistakes.
I guess you wanted to use `other` here, not ruby.
"How would a third-party service know if an incoming POST concerns a ping event or a CheckEvent event?"

In my case I was planning to write a Backstop (obfuscurity/backstop) consumer that handled both types. I think it's a valid argument to be able to configure this plugin to support _either_ type independently, but I think coupling it to the remote endpoint is the wrong way to do it. I believe that __invocation__ (i.e. calling the same plugin multiple times with different options) is the right way to handle this. AFAIK uptime doesn't handle this yet.

"Also, it's only a matter of chance that both models have almost the same property names. These propserties don't means exactly the same thing on each size, so I'd prefer if you adapted the message for each event type."

Again, without being able to invoke this plugin differently, we might need to create two completely different plugins (e.g. `PingWebhook` and `CheckWebhook`). Perhaps we could do something like the following (untested). 

```
$ pwd
/Users/jdixon/Projects/uptime/plugins/webhook

$ ls -l *
-rw-r--r--  1 jdixon  jdixon  1700 Oct 28 15:14 index.js

check:
total 8
lrwxr-xr-x  1 jdixon  jdixon  11 Oct 28 17:52 index.js -> ../index.js

ping:
total 8
lrwxr-xr-x  1 jdixon  jdixon  11 Oct 28 17:52 index.js -> ../index.js
```

```
# config/default.yaml

webhook.ping:
  host: 127.0.0.1
  port: 5001
  path: '/custom/ping'

webhook.check:
  host: 127.0.0.1
  port: 5001
  path: '/custom/check'
```
Имхо это не относится к апи, потому что здесь идет _только_ парсинг текста и выдача в html. Апи - это если идет взаимодействие с какими-то ресурсами GF
with adding something like:

```haml
:javascript
  $(function(){
    $('.save-btn').click(function() { ... });
  });
```
OK I'll change that.
yes, i used the environment plugin as a template....
It seems strange to provide custom functionality like this in a standard component. By the same reasoning, you would want to provide a filter function for preprocessing the label of the TextArea component, along with the properties of other GUI elements. (I'm not actually recommending that you do this.)
Hi @chrisdl — is this change needed? The current ordering matches the ordering below, and the clockwise ordering that is commonly used in CSS, but I'm happy to hear your thoughts on why it should be changed. :)
This is no longer "exemplar object" it's "class" now, so we should rephrase either to "class".
agreed, I'll fix this.
This also has to be a paragraph. Sorry that I missed it last time.
why do you need it here?
This should be on the same line than `foreach`
If we don't want to spam the logs, then I would suggest using something to only log once per x amount of time or some such thing. Encoding this special knowledge just seems like a bad idea.
rm_r works like below
```
% ln -s foobar
% ls -l foobar
lrwxr-xr-x  1     naruse  staff  6  7  6 10:02 foobar -> foobar
% ruby -rfileutils -e'p FileUtils.rm_r("foo")'
["foo"]
% ls -l foobar                                                   
ls: foobar: No such file or directory
```
I'll do that monday. The readme is still read by github so I thought the comedy value was high enough to include. I'll remove it
I blame @robashton for not slapping me on the face for that one. :) Lesson learnt.
var type goes before var name, also var name is optional in this cases.

Check this along your PR.
I concur with @jmikola -- if the `modified + lifetime` is _less_ than the current timestamp, we want to delete.
Accentata
Remove all empty lines in try / catch.
Not sure if this is desired, but it no longer references non-existent classes
There is not need to remove the type hint for pass a null value just make it optional

`setError(Error $error = null)`
Instead of using the same logic in multiple places, make a function that checks if a user is moderator or not
At my last job we had a kind of ersatz attribute management that hit the 16k limit with some users so I bumped it to 64k on-stack with no ill effect.

I suggest raising the limit and keeping it on-stack for simplicity's sake. A 64k stack frame is not a problem on modern systems (the ones people actually use) so I don't see a downside.
Wouldn't it be better to use this loop statement instead?

```js
for ( var i = tasks.length; i >= 0; i-- ) {
```

Or even better a while loop:

```js
var i = tasks.length;
while ( i-- ) {
```
no idea how that crawled in there!
are importing from pelican? if yes then that's weird.
If config is an array, we need to swap arguments. Arrays are an 'object' according to typeof, so that check you're proposing would not do swapping for an array as the first argument.
Is there any reason for this to be results.length - 1? I would probably prefer resultsIndeces[changeId] = true
Align both "=" signs
I'm going through the docs looking for what would need update
I know we are getting more and more OT :)

@stof Editing is not necessary. It could be done dynamically in the proxy itself.

@guilhermeblanco I'm not sure we need this, support for better accessors is indeed quite an interesting patch, nevertheless we don’t need it for this issue. What’s not very well known is that unset() works on object properties and after unset() is called magic methods are called again. This is something Doctrine could use. See this gist for illustration: https://gist.github.com/2662665
I need to check this but I think the method is defined in the common interface
I think that `filename` is a better name for the argument
OK, we can merge these in as is, until we get our policy for contributed easyconfig files straightened out. I feel your pain. :P
Let me document that policy on contributed easyconfigs somewhere, before we try to enforce something that's not clear.

Just to clarify: I never said you should create a separate pull request for each and every easyconfig file you contribute (in fact, it's kind of annoying ;-)).

What I did say is that you should try to keep pull requests manageable in size to review, i.e. a maximum of, let's say, 10 easyconfig files at a time in this context. Combining easyconfigs that belong together in some way (e.g. form a dependency tree/graph together, or are the same type of tools), makes sense and makes it easier to review things.

Just so we're clear: we appreciate you're actively contributing your work, we just want to avoid ending up with a huge mess. ;-)
cleanup:

			libprefix = "libhmsbeagle"

			sanityCheckPaths = {'files':["include/%(pre)s-1/%(pre)s/%(fn)s" % {'pre':libprefix,
																    'fn':incfile} for incfile in ["beagle.h", "platform.h"]] +
                                                                   ["lib/%s%s.so" % (libprefix, lib) for lib in ["-cpu", "-cpu-sse", "-jni" ,""]],
							   'dirs' :[]
							}
there is no jinja2-ictce easyconfig.
you should check ``if (null !== $resourceOwner) {`` instead. Symfony2 does not use ``isset`` to check for null values.
I used 32 because that's the number of elements in an byte32 and ubyte32 that are already defined in core.simd in the latest release of DMD. Is there a good reason to use 4 instead?
I'm surprised - does express not have caching support built-in?
Yipe, copy-pasta fail. Good catch, and lodged a note with the SUMO folks from whence it came.
Remove the Phpstorm header :)
It looks like the indents get a little out of whack from here on.

The mark-up of the form itself needs some changes in order to meet W3C standards and our own front end standards -- I'd suggest modeling this on the challenge signup form, which is exactly the same design pattern, right down to the ability to add/remove questions (or requests/offers, in the case of the signup form). It even has a way for users without javascript to add items to the form. views/challenge_signups/new.html.erb and views/challenge_signups/_signup_form.html.erb correspond to this, and you'll also want to look at views/prompts/prompt_form.html.erb which corresponds to the question_answer_fields partial this is rendering. Looking at a signup form will actually give you a pretty good visual indication of what goes where because of the way it's colored, but here is what the markup will basically look like, with bonus explanatory comments:

```html
<form>

  <!-- containing fieldset that surrounds all questions -->
  <fieldset>
    <legend>Questions</legend>
    <h3 class="heading">Questions</h3>

    <!-- div and fieldset group for each individual question; there may be many of these -->
    <div class="removeme">
      <fieldset>
        <legend>Question 1</legend>
        <h4 class="heading">Question 1</h4>

        <!-- dl pairing labels and inputs; only dt and dd should be direct children of a dl; direct children of dt and dd are not restricted -->
        <dl>
         <dt><label></dt>
         <dd><input></dd>
        </dl>
        <!-- end dl pairing labels and inputs -->
        
        <!-- p containing our remove button must be outside dl since it is neither a dt or dd -->
        <p class="actions" role="button"><a>Remove</a></p>
        <!-- p containing remove button -->

      </fieldset>
    </div>
    <!-- end div and fieldset group for individual question -->

    <!-- button for adding questions; it should be inside the containing fieldset and after all individual questions are done -->
    <p class="actions" role="button"><a>Add another question?</a></p>
    <!-- end button for adding questions -->

  </fieldset>
  <!-- end containing fieldset that surrounds all questions -->
  
  <!-- fieldset containing actions for form -->
  <fieldset>
    <legend>Actions</legend>
    <p class="actions"><input type="submit"></p>
  </fieldset>
  <!-- end fieldset containing actions for form -->

</form>
```
Kill: `util`, `__`, `es6`, `WeakMap`
I'm not a fan of this. Are you expecting `BadRequests` in the tests?
Definitely worth thinking about, but I think this is perfectly fine for a first cut. We could almost certainly get a better value for ``encyclopediaTitle``, either by getting something from the page source or by including a lookup table in the translator.
well, fair enough. most clear way is params.hasOwnProperty('appendFormat'),
i suppose.


On Wed, Oct 31, 2012 at 9:26 AM, Olivier Lalonde
<notifications@github.com>wrote:

> In lib/railway_routes.js:
>
> > @@ -227,6 +227,8 @@ Map.prototype.resources = function (name, params, actions) {
> >      var self = this;
> >      // params are optional
> >      params = params || {};
> > +    params.appendFormat = (params.appendFormat == null) ? true : params.appendFormat;
>
> Haha, I did exactly that first then someone on IRC complained I should do
> it the other way because it is more clear (to him I guess). Anyways, I
> agree with you.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/1602/railway-routes/pull/9/files#r1988388>.
>
>



-- 
Thanks,
Anatoliy Chakkaev
I'm good with using cron. Do you want to mention it maybe in the readme? And wire up the cron, so we don't end up with a bunch of dead entries in the database? It would be good to raise in committers as well, but we should get something in this commit to deal with dead tokens.
Actually, you might have to just leave off the last `[x,y]` here and `v.push(true)` after you recenter below.
nit: maybe we should start adding something like `id="parallel-lines"` to problem types since they show up in debug mode (and you'll soon be able to specify them when building custom stacks)
Weird indentation, use vertical space instead to group logic.
This check is redundant
Change the condition to:

if ($aRow['DOC_UID'] == $this->input) {
These are default value (more or less). No need to repeat them (and you certainly don't want to include the test resources in the main artifact).
Ok, I will implement it as a state machine. I agree that it will improve the code clarity greatly.
There is a minor bug, it should be logger.cpp
Вы сами говорили на последнем семинаре, что тест должен осуществляться ПРОСТЫМ алгоритмом, и это самый простой и наивный алго...
Собсвенно я думал об этом, но класс, казалоь бы для внутреннего использования, а количество мы по дороге посчитали. Жалко еще N действий тратить