REGRESSION (r125912): Crashes in worker tests
        https://bugs.webkit.org/show_bug.cgi?id=94390

        Reviewed by Brady Eidson and Sam Weinig.

        * bindings/js/JSDOMBinding.cpp: (WebCore::reportException): It's always fine
        to report an exception on a worker context, but it's not fine to treat those as windows.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8] use checkInboundData in setWebGLArrayHelper
https://bugs.webkit.org/show_bug.cgi?id=93051

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-08-17
Reviewed by Kenneth Russell.

Use TypedArray method checkInboundData in setWebGLArrayHelper instead
of performing the computation manually.

No new tests. This patch doesn't change behavior.

* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore::setWebGLArrayHelper):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[BlackBerry][EFL] Remove compile warning in WebCore
https://bugs.webkit.org/show_bug.cgi?id=94328

Patch by Kangil Han <kangil.han@samsung.com> on 2012-08-17
Reviewed by Rob Buis.

Fixed compile time warning in WebCore.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::createEdje): unused variable ‘errmsg’ [-Wunused-variable]
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::selectionRect): ‘toX’ may be used uninitialized in this function [-Wuninitialized], ‘fromX’ may be used uniniti

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix XCode project file.

* WebCore.xcodeproj/project.pbxproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fixed incorrect references to JSVoidCallback.{cpp,h} in the project file.

* WebCore.xcodeproj/project.pbxproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Disconnect UndoManager when its undo scope host is destroyed
https://bugs.webkit.org/show_bug.cgi?id=94388

Patch by Sukolsak Sakshuwong <sukolsak@google.com> on 2012-08-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

Disconnect UndoManager in Element's destructor to prevent
use-after-free vulnerabilities.

Test: editing/undomanager/undoscopehost-use-after-free.html

* dom/Element.cpp:
(WebCore::Element::~Element):

LayoutTests:

* editing/undomanager/undoscopehost-use-after-free-expected.txt: Added.
* editing/undomanager/undoscopehost-use-after-free.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Add a style check for #include "cc/..." in chromium files
https://bugs.webkit.org/show_bug.cgi?id=94382

Patch by James Robinson <jamesr@chromium.org> on 2012-08-17
Reviewed by Adam Barth.

Adds a style check to make sure new chromium code follows the correct convention for including cc files.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_include_line):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(OrderOfIncludesTest.test_check_cc_includes):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r125940.
http://trac.webkit.org/changeset/125940
https://bugs.webkit.org/show_bug.cgi?id=94398

"Causes crashes on the bots
http://build.webkit.org/results/Apple%20Lion%20Debug%20WK2%20(Tests)/r125944%20(2626)/fast/css
/first-letter-removed-added-crash-log.txt" (Requested by
bradee-oh on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-08-17

* rendering/RenderListItem.cpp:
* rendering/RenderListItem.h:
(RenderListItem):
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
(RenderObject):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
* rendering/RenderObjectChildList.h:
(RenderObjectChildList):
* rendering/RenderQuote.cpp:
* rendering/RenderQuote.h:
* rendering/RenderRegion.cpp:
* rendering/RenderRegion.h:
(RenderRegion):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
nrwt: don't fail tests if ImageDiff fails on the wk2 ports
https://bugs.webkit.org/show_bug.cgi?id=94396

Reviewed by Ryosuke Niwa.

It appears that WTR is generating PNGs that ImageDiff doesn't
like, and so we're getting lots of "can not get ImageDiff"
errors (see bug 81962). The change in r124581 made this a test
failure, and this is causing the WK2 bots to frequently abort
with 500+ failures.

This change makes ImageDiff errors not be test failures just for
WK2 for now until we can better triage what's going on.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._compare_image):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Preserve styling elements in DeleteSelectionCommand
<rdar://problem/12040676>
https://bugs.webkit.org/show_bug.cgi?id=93643

Patch by Alice Cheng <alice_cheng@apple.com> on 2012-08-17
Reviewed by Ryosuke Niwa.

Source/WebCore:

Styling elements (<link> and <style>) can appear inside editable content. To
prevent accidental deletion, we move styling elements to rootEditableElement in
DeleteSelectionCommand undoably.

Test: editing/execCommand/delete-selection-has-style.html

* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss): Added to preserve styling elements during the command
(WebCore::DeleteSelectionCommand::handleGeneralDelete):  Modified to preserve styling elements during the command
* editing/DeleteSelectionCommand.h:
(DeleteSelectionCommand):

LayoutTests:

Test if delete selection command does move styling elements to
rootEditableElement, when the selection contains some. Also test command's
undoness.

* editing/execCommand/delete-selection-has-style-expected.txt: Added.
* editing/execCommand/delete-selection-has-style.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Perfalizer should differentiate results with and without the patch
https://bugs.webkit.org/show_bug.cgi?id=94399

Reviewed by Dirk Pranke.

Add "with 12345" and "without 12345" descriptions in results JSON so that graphs in
the results page are labled accordingly.

Also use _build_without_patch when building without a patch so that we get the right error message.

* Scripts/webkitpy/tool/commands/perfalizer.py:
(PerfalizerTask.run):
(PerfalizerTask._run_perf_test):
* Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
(PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
AudioParam must support k-rate processing with audio-rate connections
https://bugs.webkit.org/show_bug.cgi?id=94385

Reviewed by Kenneth Russell.

Fully implement AudioParam *final* value calculation according to spec:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioParam

In particular, this covers the case where the parameter is k-rate, and we also
have audio-rate connections to the AudioParam.

* Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::finalValue):
(WebCore):
(WebCore::AudioParam::calculateSampleAccurateValues):
(WebCore::AudioParam::calculateFinalValues):
* Modules/webaudio/AudioParam.h:
(AudioParam):
* Modules/webaudio/DelayDSPKernel.cpp:
(WebCore::DelayDSPKernel::process):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add ability to create AtomicString using LChar* buffer and length
https://bugs.webkit.org/show_bug.cgi?id=94381

Reviewed by Geoffrey Garen.

Allows the use of 8 bit string data directly without converting to 16 bits first.

* wtf/text/AtomicString.cpp:
(WTF::LCharBufferTranslator::hash):
(LCharBufferTranslator):
(WTF::LCharBufferTranslator::equal):
(WTF::LCharBufferTranslator::translate):
(WTF::AtomicString::add):
* wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
(AtomicString):
* wtf/text/StringImpl.h:
(StringImpl):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
DFG is still too pessimistic about what constitutes a side-effect on array accesses
https://bugs.webkit.org/show_bug.cgi?id=94309

Reviewed by Geoffrey Garen.

This change means that even if structure transition watchpoints are not used for
hoisting of clobbered structure checks, we still retain good performance on the
benchmarks we care about. That's important, since butterflies will likely make
most array structures not watchpointable.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed, rolling out r125897.
http://trac.webkit.org/changeset/125897
https://bugs.webkit.org/show_bug.cgi?id=94326

Source/WebCore:

This patch seems to have broken the inspector on the apple mac bots.

* WebCore.gypi:
* inspector/compile-front-end.py:
* inspector/front-end/AuditsPanel.js:
* inspector/front-end/CodeMirrorTextEditor.js:
(WebInspector.CodeMirrorTextEditor):
(WebInspector.CodeMirrorTextEditor.prototype._toRange):
(WebInspector.CodeMirrorTextEditor.prototype._loadLibraries.loadLibrary):
(WebInspector.CodeMirrorTextEditor.prototype._loadLibraries):
* inspector/front-end/Color.js:
* inspector/front-end/ElementsPanel.js:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreatePanel):
* inspector/front-end/Panel.js:
(WebInspector.Panel):
(WebInspector.PanelDescriptor):
(WebInspector.PanelDescriptor.prototype.panel):
* inspector/front-end/ResourcesPanel.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
* inspector/front-end/Spectrum.js:
(WebInspector.Spectrum.prototype.get outputColorFormat):
* inspector/front-end/StylesSidebarPane.js:
* inspector/front-end/TimelinePanel.js:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
(WebInspector.doLoadedDone):
* inspector/front-end/utilities.js:

Source/WebKit/chromium:

this patch seems to have broken the inspector on the apple mac bots.

* WebKit.gyp:
* scripts/concatenate_js_files.py:
(OrderedJSFilesExtractor.handle_starttag):
* scripts/inline_js_imports.py:
(main):

LayoutTests:

This patch seems to have broken the inspector on the apple mac bots.

* http/tests/inspector/resource-tree/resource-tree-non-unique-url.html:
* inspector/database-table-name-excaping.html:
* inspector/styles/styles-invalid-color-values.html:
* inspector/timeline-dfs.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Fix random noise around text in FPS HUD.
https://bugs.webkit.org/show_bug.cgi?id=94400

Reviewed by James Robinson.

This was the result of an incorrect clear operation on the canvas
that stores the font atlas used by the HUD.

* platform/graphics/chromium/CompositorHUDFontAtlas.cpp:
(WebCore::CompositorHUDFontAtlas::generateFontAtlas):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Calendar picker shows wrong date when input element has year earlier than 100
https://bugs.webkit.org/show_bug.cgi?id=94100

Reviewed by Kent Tamura.

Source/WebCore:

Date.UTC can't set an year earlier than 100. So when the input has a value earlier than 100, calendar picker shows the wrong date.

Test: fast/forms/date/calendar-picker-appearance-pre-100.html

* Resources/pagepopups/calendarPicker.js:
(createUTCDate): Uses setUTCFullYear when the year is pre 100.
(parseDateString):
(DaysTable.prototype._renderMonth):
(DaysTable.prototype._maybeSetPreviousMonth):
(DaysTable.prototype._maybeSetNextMonth):

LayoutTests:

* fast/forms/date/calendar-picker-appearance-pre-100-expected.txt: Added.
* fast/forms/date/calendar-picker-appearance-pre-100.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Add self to webkit contributors list
https://bugs.webkit.org/show_bug.cgi?id=94409

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-08-17
Reviewed by Dirk Pranke.

Add name, email and irc handle to webkit contributors list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
DFG CSE should be more honest about when it changed the IR
https://bugs.webkit.org/show_bug.cgi?id=94408

Reviewed by Geoffrey Garen.

The CSE phase now always returns true if it changed the IR.

* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setReplacement):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
2012-08-18  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: load panels code on demand
        https://bugs.webkit.org/show_bug.cgi?id=94326

        Reviewed by Vsevolod Vlasov.

        - Introduces importScript that evals in debug mode and inlines for release
        - Loads Element, Resources, Timeline, Audits panels lazily.

        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/compile-front-end.py:
        * inspector/front-end/AuditsPanel.js:
        * inspector/front-end/CodeMirrorTextEditor.js:
        (WebInspector.CodeMirrorTextEditor):
        (WebInspector.CodeMirrorTextEditor.prototype._toRange):
        * inspector/front-end/Color.js:
        * inspector/front-end/ElementsPanel.js:
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onCreatePanel):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel):
        (WebInspector.PanelDescriptor):
        (WebInspector.PanelDescriptor.prototype.panel):
        * inspector/front-end/ResourcesPanel.js:
        * inspector/front-end/SettingsScreen.js:
        (WebInspector.GenericSettingsTab):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame):
        * inspector/front-end/Spectrum.js:
        (WebInspector.Spectrum.prototype.get outputColorFormat):
        * inspector/front-end/StylesSidebarPane.js:
        * inspector/front-end/TimelinePanel.js:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector._panelDescriptors):
        (WebInspector.doLoadedDone):
        * inspector/front-end/utilities.js:
        * inspector/inline-javascript-imports.py:
        (main):

2012-08-18  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: load panels code on demand
        https://bugs.webkit.org/show_bug.cgi?id=94326

        Reviewed by Vsevolod Vlasov.

        * WebKit.gyp:
        * scripts/concatenate_js_files.py:
        (OrderedJSFilesExtractor.handle_starttag):
        * scripts/inline_js_imports.py:
        (main):

2012-08-18  Pavel Feldman  <pfeldman@chromium.org>

        Web Inspector: load panels code on demand
        https://bugs.webkit.org/show_bug.cgi?id=94326

        Reviewed by Vsevolod Vlasov.

        Showing panels prior to running tests in order to load the code for them.

        * http/tests/inspector/resource-tree/resource-tree-non-unique-url.html:
        * inspector/database-table-name-excaping.html:
        * inspector/styles/styles-invalid-color-values.html:
        * inspector/timeline-dfs.html:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@125965 268f45cc-cd09-0410-ab3c-d52691b4dbfc