Whitespace only cleanup
(Maint) Stop watchr from reading non-existent spec.opts

Without this patch the watchr auto-testing script attempts to read the
spec.opts file.  This is a problem because the file no longer exists in
the repository which causes watchr to fatally error out.

This patch fixes the problem by simply removing the code replacing it
with a comment to use a personal ~/.rspec file instead of the project
rspec options file.
(#15193) Document how to use the static compiler

Without this patch the magic nature of the `Filebucket[puppet]` resource
and the expected behavior of the puppet agent obtaining file content
from the server is not documented anywhere.  This is a problem because
it is not clear how to configure the agent in a manner that does not
produce errors when using the static compiler.

This patch fixes the problem by providing a more in-depth description of
the high-level approach the static compiler takes.  In addition, the
specific configuration of `fileserver { puppet: server => $server, path
=> false }` is documented in the README_DEVELOPER.
Document the different forms of catalogs to help test writers

Without this patch it was not clear to me that the static compiler
operates primarily on a resource catalog.

This was a problem because I spent considerable amounts of time trying
to figure out the difference between `resource[:source]` returning
`"puppet:///..."` inside of
`Puppet::Resource::Catalog::StaticCompiler#find` when running `puppet
apply` and `resource[:source]` returning `["puppet:///..."]` (an array)
when inside of `#find` from the spec test.

When testing catalog terminii the resource form of the catalog should be
created instead of the RAL form.

This patch addresses the problem by providing a description of the
difference between a resource catalog and a RAL catalog and when it is
appropriate to use each.
(#15193) Add spec test coverage for static compiler

Without this patch there is no test coverage for the static compiler
terminus.  This is a problem because internal changes to the indirector
break the expected behavior of the static compiler and we have no
automated way to discover the broken behavior.

This patch adds spec test coverage for the static compiler's find
method.  This covers the most common use case of the static compiler
where by file resources with source parameters are modified in the
resource catalog.

The patch does not include test coverage for recursive file resources.

The approach taken stubs the underlying compiler terminus and produces a
fake resource catalog for the static compiler to operate on.  The
fileserver metadata API is also mocked to break the dependency on a real
fileserver.
(#15193) Fix StaticCompiler#store_content

Without this patch the static compiler's store_content method improperly
calls the indirector in a way that produces fatal exceptions preventing
catalog compilation.

These errors take the form of:

    NoMethodError: undefined method `find' for
    Puppet::FileServing::Content:Class

This patch fixes the problem by sending the messages to the right
places for Puppet 2.7.x and Puppet 3.x
Merge branch 'bug/2.7.x/15193_fix_static_compiler' into 2.7.x

* bug/2.7.x/15193_fix_static_compiler:
  (#15193) Fix StaticCompiler#store_content
  (#15193) Add spec test coverage for static compiler
  Document the different forms of catalogs to help test writers
  (#15193) Document how to use the static compiler
  (Maint) Stop watchr from reading non-existent spec.opts
  Whitespace only cleanup