labofsahil/github-event-dataset-2012 huggingface dataset:
@DouweM I've done my fair share of nefarious deeds, and was not punished solely for the fact hat I overall increased the security. I'm a white hat. He's... grey, since it's kind of undetermined, but he's not fucking anyone over.
Any particular reason you don't just write `connection_pools[spec] = pool` since you already have the helper method to get the one for this PID?
Agree, sorry about that.
Sweet baby Jesus! You've brought in all this useless JNI crap without even using it yet?
thanks, I will follow the theory!
I've just realized that I'm doing something very wrong with the evaluation order, and am revising the code to generate the code for destructuring binds. Besides, the tests for the compiler already test destructuring binds more extensively.
We should provide API documentation so that caller know that they are expected to send "plain-text" password and API will encrypt it.
I would also point to ``bessely``, it is used for the definition of the Hankel functions.
What did I say above about fixing the size? This is incorrect with the way messages are written above. If you fix above as suggested this should work. If you don't want to fix above, you want to subtract sizeof(int) from msgSize before using it.
hmm, I think I'd actually prefer writing a general unit-to-piece linking system to either of those special-case solutions.

I'll see how far I get, but no real promises.
Well actually it does.

Let's look the other way around: Plaguelands have WIN event in order to handle a specific action for each tower. Venture Bay has win event because it spawns the soldiers only when the capture is at 100%. But for Zanga and Terokkar nothing happens when you capture 100% or just 80% - note that Zanga and Terokkar have a big grey area, so in order to capture a tower you have to wait a long time.

PS. I'll get a sniff in the following weeks and we can check which is the best way to do it.
\t必须放在\n的后面
Anything that's not a number >> 0 results in 0. This avoids 2 tests over collection length.
yeah, it solves the hang up problem, more importantly, does writing that way plays the click audio for you as well?
Nice! What are your tricks? 

I found that a longer second beat is traditionally more waltzy, but isn't always effective on pop music. Also, I added an option to accelerate the tempo. That is quite effective. For the sake of simplicity, I didn't add volume control, but it could help to turn the 3rd beat down a notch. Either way, I like the effect when the beat tracker doesn't fuck up.

You can easily mix audio and overlay sounds with Remix. Check in other examples. There's more design work necessary to make it truly convenient in the pure scripting sense, but you can get it done.
I never set an input range for the Jaguars, so I'm not sure if it matters.
Agreed, very good suggestion. Implemented in 6bb7bc6
Here you can only return NULL.  But setting default_signal = NULL should cause that to happen anyways if krb5_config_get_string_default() has to use the default -- I think.  So the code you have looks right and you should remove the XXXrcd comment.
The return value of this function is size_t, which is usually unsigned.
And then use config.getMilliseconds
didn't like the name anyway
Ah, yes. I did that some time ago. I totally forgot!

On 25 January 2012 12:05, Leo Franchi <
reply@reply.github.com
> wrote:

> You can actually build QtWebkit (since it is a part of Webkit) completely
> separately from Qt. Here's how:
>
> http://trac.webkit.org/wiki/BuildingQtOnLinux
>
> Once you have it built, you can copy the libQtWebkit.so* into your
> QTDIR/lib, or you can do
>
>    chrpath -d bin/phantomjs
>
>  LD_LIBRARY_PATH=/path/to/qtwebkit/Build/WebKitBuild/Debug/lib/:$LD_LIBRARY_PATH
> bin/phantomjs
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/ariya/phantomjs/commit/1531595d2e2a44c3b9ef425d78fa38614e3ab493#commitcomment-901695
>



-- 
*Ivan De Marino*
Coder, Technologist, Cook, Italian

blog.ivandemarino.me | www.linkedin.com/in/ivandemarino |
twitter.com/detronizator
the old code is better. revert this.

you replace a short and simple condition with:
 * two lines of code
 * one extra variable
 * a complex condition involving both && and || instead of a simple one.
immutable c
We might json compilation here too?

./compile-json.sh .

Note: It depends on Perl and a couple perl libraries.
This might be a bit grim-specific for a generic renderer to handle? (Grim could always invert the indexes on load to follow the standard gl-approach?)
This bug was introduced when default value of $arguments becoming array() instead of null.
So the fix is to replace line 55 with "if (sizeof($arguments) <= 0)" instead of catching the exception.
Just wanted to say thanks! Love this!

*pulling in the new stuff*
:) i'm on smartphone. only tomorrow (on phone very uncomfortable to work in ssh :)
the point is removing script from vehicle now. Already done a SetBGFaction function, like http://pastebin.com/hrsnDPa6 . I see no problem with it for now
MSVC 2010 includes stdint.h
Another failsafe of repeating alarm is to Cancel the current alarm when setting the new one.
@stof this is not equivalent
Не надо это выкидывать в интерфейс, пусть классы внутри себя поглощают данную ошибку
每天中午都诡异的刷出一张票，却从来没有订票成功过。伟大的天朝。
Yes, and also to ensure each quickstart uses it's own database - avoid completely the table name crossover...
If I remember correctly the JIT will assume final until a subclass is loaded, so you don't really need to write it.
forces an explicit dependency on **jruby-openssl** `LoadError: OpenSSL::Random requires the jruby-openssl gem`
is this desired or should there be a fallback if it's not available ?
True. But in any event, I checked the codebase, and it doesn't look like we're really using `modifyRef'` anywhere else. Maybe the best move is to not provide the `modifyRef` wrapper so that no one can accidently use it.
How about a seperate column for each phone number?  The label could then be in the table header instead of on each row.  That way the "compactness issue doesn't come into play.
@davidhicks could you please comment on the rationale behind this change, and what behavior you intended to correct ?

I implemented a fix for #13937 to properly pre-select multiple values in filter selection lists for versions and categories, and this commit actually introduces a regression:

* option "[any]" ($p_val=0) is *always* selected when one of values to pre-select ($t_this_var) is a string

This is due to the condition you modified evaluating to *false* in this case, so the code goes to the else if which is *true* since the string value is converted to int(0) == 0

I believe the purpose of the type-safe comparison you labeled as "incorrect logic", was actually to cover this special case, as mentioned in the comment. If this assumption is correct, then I think your commit should be reverted.

Let me know your thoughts.
The upgrade of rack to v1.3.6 in this commit is causing us a problem, because we're restricting the whitehall app to v1.3.5 to match the [version provided by puppet](https://github.com/alphagov/alphagov-deployment/blob/master/alphagov-puppet/puppet/manifests/classes.pp#L106). Since whitehall and whitehall-rummager run on the same box, we get a clash of versions i.e. passenger error: "You have already activated rack 1.3.5, but your Gemfile requires rack 1.3.6". Is the plan to upgrade the version puppet is providing? In the meantime, I'm going to investigate upgrading the version in the whitehall app.
would you recommend a better way?
I merged in all your code, and it seems to have fixed whatever the issue was.
Dieses Update fixed den Bug in ICC bei Lord Marrowgar mit den Stacheln sowie alle anderen Vehicles!
No, they used to be 60s.
But since monitor is also 20s, I guess it should be enough.

I'll pull this into my tree and push to master shortly
Nice feature!
I think it will look better inside grey rectangle, just as in Github
@create_group was read from the wrong attribute
Same as above, this should have been getResourceModuleName();
is it guaranteed that `pk in category_names`?
I'm afraid that moving this in a common class will be as a wildcard for doing this kind of trickery all over the place. Anyway, having to do the wait()'s here looks like an issue in itself.

I've done quite some work on the fronted code. It's not bad. However, it would be great if I can factor out the thread that's launched in the ChunkedResponder. Solving it via callbacks would pose an even more reliable solution.
maybe if we can do that as a keyframe animation, having it disappear for 1 out of 10 seconds
createFirewallRuleForIpAndProtocol
quoted... uh... espaced instead ??
This is the start of a BASIC access control system. Once I hit the limits of it, I'll change how it works.
hey sogar mit exception handling!
After that commit iteration over list of objects in select tag cause "UnknownFormatConversionException if result of i.labelProperty contains '%' or some other special symbols.
Can we not just specify *.scr instead of each individual file?
Tout est dans prototypes.h
You know what, just let leave it for now, unless you can find it in a spit second.
Since I'm not sure if dataDomCache=true will preserve the casing in Railo and "dataDomCache"=true will give a syntax error on CF 8 I made the tests more generic.
That explains why it didn't look fixed to me - there's no visual feedback yet,
Even if vi is just a symlink to vim?
Just a heads up; the debug task looks like a duplicate of lein-pprint: https://github.com/technomancy/leiningen/blob/master/lein-pprint/src/leiningen/pprint.clj

Also you should remove the :aot from project.clj.

Looks handy apart from that.
Well, yes, I agree the views are not very readable at the moment because they are defined in one .m file.

However, there is a reason for that. The views declared inside the .m file are those which are not meant as a general (reusable) views for the users of the API. The "public" views are MADayView and MAWeekView and the other are internal. Why I see problematic of exposing the internal views, is that changing the implementation is difficult afterwards. Moreover, there are internal dependencies in the internal views, which make them kind of tricky to use in other contexts than inside MAWeekView for example.

In this form, I don't want to merge this patch but if you have further ideas how to make the view code more readable (while keeping the internal views private), I would love to hear your ideas!
hmmm... test av merknad?
@tecbot for this bundle, 2.0 is merged into master regularly, like for Symfony. Simply wait the next merge
The newline is not really relevant to the charset, but I was playing with Iconv in this file earlier.
Terminado no esta, la verdad es que lo tengo algo abandonado por falta de tiempo, ando de examenes y poco puedo hacer.

Por otro lado toda esta rama esta basada en todo nuestro core, puede que necesites aplicar la primera version del Torneo que metio Karlos. De todos modos tengo en mente intentar hacer esto en condiciones (osea sobre una rama de trinity limpia) y mandar un Pull request, con lo que sea ya lo irás viendo por aqui.

Si me dices más exactamente quien no te da misiones y bajo que circunstancias te puedo intentar decir que puede fallar.
I'm curious as well. One day,  being logged out should not be possible because the data is then unreliable, the other day this possibility is added.
I suspect that this code has broken the no-JS operation of GridField.  There's a bad code-smell here: I think that gridFieldAlterAction() and index() need to have their code separated more aggressively, and both rely on a 3rd method that contains the common code.  Suffice it to say that the route back into the gridfield will be quite different for no-JS than for Ajax.
Oh... seems like I've been too tired theese days... sry %)
Can you add a sentence and an example showing the more common use case of not mixing depth and includePath? before diving into the combination.
I’m thinking that the file mode changes `644 → 755`  are unintentional?
Those queries are now part of the giant query above.
If you want to make `/contact` resolve this page you can write `match 'contact' => 'pages#contact'`.
Ok thanks for clearing that up, we've added a FAQ entry to help people that use Stargate. :)
Madhu,

I just reverted back to the original code and it worked fine. The server is responding 'Y' now. Thanks for your suggestion.

Regards,
Deepak
We already have a headers file. I'll move it there

Sent from my iPhone

On 7 jan 2012, at 19:44, Shlomi Izikovich
<reply@reply.github.com>
wrote:

> Should we consider taking all the constants (such as "NServiceBus.OriginatingAddress") from a single constants file?
> I think that one (small benefit) that I can think of, is a common, general place that shows the headers types we have.
> Just an idea...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/NServiceBus/NServiceBus/commit/71f63528778bc682dc248574dfbf81940ccd61d5#commitcomment-846478
NB: This would have worked before.
It's not clear how this should be implemented, possibly it should call out to swaponenode script, since it needs to do the steps contained therein, i.e. including pushing out new environment to cluster.
Which version of mongoengine are you using? I can't seem to find any version that has a DynamicDocument class.
listo cuando puedas metelo. core + sd2
jajaja gracias :D
please change to an if statement with curly braces
> As a side node, this requires to use a shadow attribute C_ that gets set
> at train time, and we should not override the attribute C (which is what
> gets currently done with Gamma, AFAIK).

I completely agree that transformed parameters should be local
variables in fit. This includes, e.g., C (after scaling), gamma and
random_state (after check_random_state).
Location?
Oh Yes!
it is a part of assistant.

In the Image, the Location is Null, because i deactivate my GPS.
Location-Services.
Well spotted. And I think this may be slightly faster.
How can this work? If we get a rectangle we can't get the two different sizes of the sides.
Excerpts from ZyX-I's message of Sun Feb 26 09:59:04 +0100 2012:
> This modifies passed dictionary which may be unexpected. My version does not.
If anybody hits this case and complains about it I'll pay you $100 :)

Moreover its the simple style I use in all of my plugins - and it gets
the job done reasonably.

I see that there is a difference. But I don't think it matters.
ამ ობიექტის ინსტანსი არ გჭირდებათ. სტატიკურია ყველა მეთოდი და პირდაპირ შეგიძლიათ სარგებლობა. აზრი არ აქვს ობიექტის შექმნას.
The db.pp tries to import the sql before granting the user privilege to do so. 
http://pastie.org/3221593
Guessing this solves the warnings about the browser closing too fast?
Yeah, I only added it that way because it was a `Content-Type` is required, and I had a pull request that was easy to merge. See [my comments here](https://github.com/tylerhunt/rack-canonical-host/pull/4#issuecomment-4220672), and take a look at de31b5ecd96ee87f8fafd65652744082d29de6bb and let me know what you think.
I think this was correct before. The "UpdateStart" routine begins copying data to other computational nodes after values have been set, and "UpdateFinish" just waits for it the update to be completed and then for geometric fields it also calculates geometric parameters.
I agree, I was just thinking that it looked a little busier than I would wanted to see. may be push it to a private method with descriptive name?

I also agree with keeping the start especially after i just did this: https://github.com/SpringSource/spring-integration/pull/298
I wasn't paying as close attention as I should have, and github is kinda confusing me since I'm trying to make these changes individually... but the description here should be changed to match what is in actionmanager.py, so:

                r.description = u"This content rule was automatically created by " + \
                                u"the workflow manager to support actions on workflow transitions. If you want the " + \
                                u"behavior to work as expected, do not modify this outside of the workflow manager."
Should we be defaulting to a string here?  is this needed for the view or similar ot the 'n/a' issue earlier?
Depends on IDE and project settings.
It would be very helpful if the `options` were passed to `getURL()`, it would aid usages like:

```javascript
Y.UsersList = Y.Base.create('usersList', Y.ModelList, [Y.ModelSync.REST], {
    url: '/users/?num={10}',
    
    getURL: function (action, options) {
        return Y.Lang.sub(this.url, options);
    }
});

var users = new Y.UsersList();

// GETs "/users/?num=10"
users.load({num: 10});
```

Passing the options to `getURL()` seems obvious. I'm questioning the usefulness of passing the `action` along too… although it's probably not much harm there. The other question is if `_substituteURL()` should also have a `_substituteURL(url, options)` signature too, it probably should.
I think we can have a more straightforward interface for findSandboxHeader. From  end user's point of view, I thin hasSandboxHeader is enough, which returns only true or false.
I'm sorry, but I don't understand from the snippet. Which nine functions are you referring to?
missing colon?
I’d prefer `transport.listen map (transport -> _)`
Messing up ordering is the worst of them since it breaks the contract of the message sends.
The aforementioned function is more important IMO – that there's a JulLoggingAdapter that ships LogRecords to the JulEventHandler that logs them.
OK! I'll neaten it up as much as possible (I think a lazy val might read nicer) and then comment whatever I can't neaten.
I do not like this one. It's better if it was a Zipper or something, you risk having millions and millions of actors being put into this string, creating a huge blob that OOMEs
message is already a string
testConduction.getNodes.await.filterNot(myself ==).isEmpty ?
These substitute for having a minimal file in lib/wagn/renderer/  I think we should move these there too.
On Mon, Jun 25, 2012 at 4:04 PM, MrBago
<reply@reply.github.com>
wrote:
>>
>> +    # SNR = var(signal)/var(noise) => var(noise) = var(signal)/SNR:
>> +    p_noise = np.mean(p_signal/snr)
>> +
>> +    if noise_type == 'gaussian':
>> +        # Generate the noise with the correct standard deviation, averaged over
>> +        # all the voxels and with the right shape:
>> +        noise = np.random.randn(*vol.shape) * (np.sqrt(p_noise))
>> +    elif noise_type == 'rician':
>> +        # To generate rician noise, we add two IID Gaussian noise sources in
>> +        # the complex domain and combine them together:
>> +        noise1 = np.random.randn(*vol.shape)
>
> We should set up a skype or something to talk about this,

Sure - we can do that. Maybe we can make that the topic of our hangout
with all the others, when we get around to doing that. In a sense, it
might be worth discussing over email, if you don't mind it, so that we
can refer back here, when we want to remember what we said about this.
We'll avoid repeating ourselves and others can chime in this way.

> It's not clear to me why you're using var(signal) / var(noise).

That's just derived from the definition of SNR as it appears in that
wikipedia article. It's also approximately the ratio of the sum of
their PSDs, which is another definition of SNR.

>Also it looks like you're implementation of the Gaussian noise scales the noise differently for each voxel. Even though there might be applications where this is useful, it's not physical for MRI. MRI noise generally has the >same power over the whole volume.
>

The scaling factor is actually uniform across the volume. I estimate
the variance in each voxel, across different directions, but then
scale them all by a scalar (on line 193).

> Also, in the MRI literature there are two ways that noise is usually measured, either the mean signal to noise of diffusion weighted images or the mean signal to noise of b0(no diffusion weighting) images. I believe that the first is a more useful number, but because the SNR of dwi images depends on b-value some people report the second. I believe we should keep that in mind.
>
Yeah - here I want to add noise to simulations of diffusion weighted
images, but I don't see a problem with adding noise to no diffusion
weighting images as well, in the same manner.

> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/nipy/dipy/pull/26/files#r1046937
Nit-picky, but I think a hyphen would help the readability. It took me a few readings to understand it meant "in-progress"
This should probably be a bit more detailed. Explain how if specified, only errata whose issued date is on or after the given value will be included. Also include the format for the date, I don't believe it's an ISO8601 formatted date, so it's especially important we mention it's different from the rest of the app.
Spell it out as "For example", it looks awkward dangling in the generated docs since there's no other text around it.
Code looks good, but I might need some explanations about what is happening here.
You could replace it with a function that returns another map, then you wouln't need to get a mutable map as a parameter
you're right, I didn't notice that addition.
Thats vetter.
Please fix the CS. Mink is using spaces for the indentation, not tabs
Actually, yeah, now that I think of it, you are right. It is pretty specific, so no reason not to bring it in.
Eu editei e mantive os diretórios da tua IDE. Tá beleza agora.

Abraços.
Em 29/03/2012 13:33, "barongello" <
reply@reply.github.com>
escreveu:

> > @@ -1 +1,4 @@
> > -pev
> > +.gitignore
>
> Era pra ele se auto ignorar, subiu nem sei porque
>
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/merces/pev/pull/8/files#r621868
>
Content-ID is optional. No need to limit it to inline attachments.
You don't need those `+ \`s in parentheses.

    ("some "
    "text")

is quivalant to `("some text")`
Ça répond pas à ma question.
This makes me a little sad -- if you have an easy way to generate certificates/authorities for testing please let me know!
You may want to wrap this in a try catch instead. If the table died for whatever reason (some person closed it by hand), it might be desirable to catch it and return the default value, or maybe just log.

A dead table, for whatever reason, that is getting read a lot by who knows what can usually take down a node through error messages, which I guess would be made worse when the logger is the one to choke on it.

Note that I'd let the no-default stuff crash in that case, too, or try to make it replicate the lager_mochiglobal behaviour if it's not what you're doing right now.
@BeanProperty on all of the members?
“rarrp!” – I like that!
just fixed a bug here in master, but wanted to point it out to you -- this doesn't declare a local variable named top, but instead uses a global named top.
shoudln't you set ``runtimeInitialized`` to ``true`` here ?
Xcode 4.4 tells me it's all tabs and it's all well spaced.... Not sure what to do D:
`-copy` should be called rather than `copyWithZone:`
This should use the `<TUIBridgedScrollView>` interface. It's unsafe to assume that the `ancestorScrollView` is actually a `TUIScrollView` (as opposed to, e.g., an `NSClipView`).
We need this check here because the paging mode viewport should not animate upon the selected event.
This is a common enough pattern to warrant its own class. Can you pull this out and make it a class, e.g. JavaMapIteratorWrapper?
rend cette méthode et `findPollAndUser` private
first_part.reverse.first(radius).reverse.join(separation)

Can probably be rewritten to the faster:

    first_part.drop(first_part.length - radius).join(separation)
Ah nevermind, setting :min zeroes :sec.
I don't think we need this version. Nobody is going to be upgrading directly from 3.0 to 4.0.
I think we should avoid method missing if possible, but I don't have an idea off the top of my head, I'll try to think about something.
s/valus/values
Dict comprehension does not exist in python 2.6 so you should change the second line with 
```
t = dict((k, v) for (k, v) in TAGS.iteritems())
```
Just a few lines above there's another loop that checks the correspondence paramlist-wise
Don't put the same boolean expression in successive else clauses.  The above can be written, and with fewer negations to boot, as:
```
if (sym == NoSymbol) <1>
else if (sym.isLocalToReifee) <4>
else if (sym.isClass && !sym.isModuleClass) <2>
else <3>
```
Where hopefully the meaning of <1..4> is apparent.
Instead of `assert False` can you add the assertion that we expect to see when the code works? Ideally some future user should make changes to ode_system.py , see that "XFAILed tests are now passing" and simply remove the XFAIL property.
I still think that the most constructive solution in this case is for me to make this class as agnostic as possible with respect to storage and then merge.  It should then be a simple thing for someone to integrate a PermutationSymbol class if it is ever written in the future.
These should be triple quotes.
fine I'll do it.
A newline is needed here at the end of the file (or else you have to push your most recent commits with 'git push -f comer test1').
It may be useful to check the `NumericConstant` class.
``state1.rows != state2.cols``
Though you could also use ``Matrix.is_square``
as seen below?
needs to be !this.isPortrait()
That is just the standard convention
> This would be more consitent with other property documentation that are passed to createComponent.

Right! Fixed.
can be done with dql. 

pseudo-code

    $dql = 'DELETE from Workflow\Entity\Workflow WHERE module=:module';
    ->setParameter('workflow', $workflow);
This should be `(sa_family != AF_INET && sa_family != AF_INET6)`. I realize that you're not the one introducing this, though. :-)
Use Consumer @cunsumer_queue, remove @logQueue
Yeah, I wondered about that. I'll play around with it in repl to see if any difference. If none, would it be better to go with simpler option, or maybe I missed something in the other use?

On 20 Oct 2012, at 05:31, Ben Hood <notifications@github.com> wrote:

> In kernel/src/main/java/net/lshift/diffa/kernel/config/WindowRefiner.java:
> 
> > +  public boolean isRefinementOf(String start, String end) {
> > +    return intervalFromRange(start, end).overlaps(windowInterval);
> > +  }
> > +
> > +  private Interval intervalFromRange(String start, String end) {
> > +    String iStart = start != null ? start : "1900-01-01T00:00:00Z";
> > +    String iEnd = end != null ? end : "3000-01-01T00:00:00Z";
> > +
> > +    return new Interval(parseDateTime(iStart), parseDateTime(iEnd));
> > +  }
> > +
> > +  private DateTime parseDateTime(String expression) {
> > +    try {
> > +      return dateTimeFormatter.parseDateTime(expression);
> > +    } catch (IllegalArgumentException ex) {
> > +      return dateFormatter.parseDateTime(expression);
> In other instances we have used the DateTimeFormatterBuilder to pass in an array of parsers that are used to construct a single multi-format parser - it might be worth just checking whether it is worth maintaining consistency here.
> 
> —
> Reply to this email directly or view it on GitHub.
>
There is one?
Please add a newline between this and the if() below.
Copy pasted from old code in functions_user.php file. Removed it now
Do you think the name `toUnique` describes what the function does? It sounds it actually returns sth that could be also returned by `attr`. Would it make sense to rename it to `toAttr`? Maybe I missed something.
Cool. Again, just a little comment about what this i doing would be great.
The only code change is here.
Is this needed? If so a comment explaining why would be useful.
Using ```#!/usr/bin/env``` you're at the mercy of the users ```${PATH}``` ... but I guess in this case it really doesn't matter.
This function needs to support passing in `numpy.ndarray` inputs, in fact I need to use it this way for another modification I am working on (adding weighting to `iris.cube.Cube.rolling_window`), which is why I moved it to `iris.util` in the first place. In order to support cubes as well it would be necessary to use some kind of type checking, which I am not really in favour of.

I'm still not convinced that `broadcast_weights` should have to accept cubes as well as arrays anyway. Other functions in `iris.util` don't accept cubes (e.g., `rolling_window`) and it is very easy to use `cube.data` when calling `broadcast_weights`.
The inter-relationships between `_time_unit_as_string`, `_time_unit_as_seconds`, and `_time_unit_stringandsecs` are overly complex. Wouldn't it'd be simpler and more transparent just to have:
 - `_time_unit_as_string`: the code from the first half of `_time_unit_stringandsecs`
 - `_time_unit_as_seconds`: calls `_time_unit_as_string` to get the string, then decodes it using the code from the second half of `_time_unit_stringandsecs`

Having done that, it seems pretty odd to convert the GRIB values into a string just to decode the string into numbers again. How about something *vaguely* (please don't take it too literally) like:
```python
class GribWrapper:
    edition_1 = {13: ('15 minutes', 15 * 60), 14: ('30 minutes', 30 * 60)}
    edition_2 = {13: ...}
    edition_any = {0: ('minutes', 60), ...}

    def _time_unit(self):
        if edition == 1:
            answer = self.edition_1.get(timeunit_num) or self.edition_any(timeunit_num)
        return answer

    def _time_unit_as_string(self):
        return self._time_unit()[0]

    def _time_unit_as_seconds(self):
        return self._time_unit()[1]
```

Oddly, the three-part solution is back again!
There are undefined references with exception classes, like PyExc_TypeError (I have no clue why).
I found the above trick while googling for similar errors.
_abort() does add the output_path to the message already.
This line can be erased
Use the grid instead of hardcoding sizes.
are you missing a pair of { } for the "else" block? otherwise Menu->SendTo(plr); will be called twice.
Good point. I don't see a *good* way to do this...
The file name is a little surprising. To parallel "creation.py" I would expect something like "alteration.py". "schema_change.py" or "schema_editing.py" also work. "schema.py", to me, hints mostly at a generic, python-level representation of the schema.
Nitpick: you can use 

```python
complain_and_exit('Job %s failed' % completed_job.id, 1)
```
Hey Michael, I've switched the exceptions to be guzzle exceptions.
I know we brought this up in class about not putting any asserts. Is this something we really want to do? If no spaces will be parsed we should check that the times are correct. If it should ignore it then check for the error code returned. We need to specify the exact state we expect it to be in at the end of the test.
Let's change the help description text to something like "Letting users know they need to provide html"
I'm a bit confused by the "we have to start a new group" comment in combination with throwing a runtime_error.
Out-of-bounds access possible here. Needs fix.
Yes. If we can determine automatically inside the function, it is perfect.

But for different hardware configurations and different data sets, the results differ greatly based on my experiments. It is hard to work out a formula for that.
just for clearing up: why is it not possible to make it static? it only uses static variables right?
Go ahead and change the #elif DIRECTX to #elif WINRT to remove that nesting of #ifs.
Hehe, that's what comes of assuming the variable was a Rectangle just because it had the word Rectangle in the name :)
This seems like a really useful test, but I'm having trouble reasoning about how it plays with the expectations we've set up.

Then again, if `{{.}}` from inside a lambda *isn't* useful, that seems like an oversight.  Any idea what kind of implementation "tricks" are required to make this work?
Sollbruchstelle? (This is a German word) :-D
On 8/19/12 5:22, Jack Nagel wrote:
> In Library/Formula/monetdb.rb:
> 
>> @@ -18,6 +18,7 @@ def install
>>                            "--enable-assert=no",
>>                            "--enable-optimize=yes",
>>                            "--enable-testing=no",
>> +                          "--disable-jaql",
> 
> Reason for this?

The option disables support for the Jaql query language, a query
language designed for Javascript Object Notation.

http://www.monetdb.org/Documentation/Extensions/JAQL

The feature is currently marked as beta and fails to build, so I
disabled it to get a working formula for the latest MonetDB release.

Best regards,
Steffen
Pointless message, the `fails_with :clang` ensures it won't use clang.
is sudo really necessary here? it works fine for me without.
Yes. And it's "moved" code. I'd love to have @github show "moved" code in the one or the other way. Some kind of superdiff :-)
collapse niimg
Tu as besoin de ce code plu tard?
Actually scratch that using rolling_kurt means only a single window size so won't work for dataframe. for sake of consistency i just ported the math to nanops. We will just have to do a C/Cython implementation of nanops overall.
As I have discussed with Alex, there are some problems when removing multiple rules. Please recheck the algorithm and make sure that the remaining rules keep their order.
coding standards.. keine Unterstriche in Methodennamen ;)
Yeah I couldn't find a definition of link that fit (neither could pylint, btw) which is why I added the note.
Good point - it should be get!
Agreed.  No big stake in that.
I don't think these should be installed.
line 43: [: missing `]' for `if [ !isMac && !isLinux ]; then` and unknow OS for  `[[ ...]]``
I don't remember anything about this, but you can probably reproduce the original broken behavior by making repairRelativeLinks a no-op.
Sorry if I'm being dense, but I don't see the leak. Won't each worker be GC'd when Queue is destroyed? Each Worker sets `this.job` to null as soon as the job is done (whether failed or complete), so those should get GC'd right away.

I'm probably just missing it. I don't have as strong an intuition about Node/JS memory management as I'd like (and I couldn't get v8-profiler to work on my machine :-/)
Instead: "Sharing not supported for " + service + ". Try using /proxy."
It's a little sketchy that hsv.s and hsv.v are getting overwritten with strings here (especially since hsv.h and hsv.a appear to be staying as numbers).  Might be better to move these expressions down to the left/bottom lines below and leave the hsv object itself unchanged.
Weird--I meant to wrap the render in `$()`. I actually have no idea why this code works without it!
I tried to implement what you described, but it's too hard to get filtering correct. Part of the reason is that it implies you can, for example, filter by typing a space char when %20 will get inserted in page, which is a conflict . I think it's best to show user encoded url and they learn how they should really look, so I think this is the best solution.
This can never work. The insertBefore method inserts an AML element as a child to the model AML element.

What you want is this:

    apf.xmldb.appendChild(model.data, apf.getXml(revisionString), model.data.firstChild);
It will fail for those using `AppController::redirectToAction()`. The phpDoc block in `Lvc_PageController::loadView()` also needs an update. Everywhere else looks okay.
Yes it was a constant, I forget to refactor the name.
My mistake, Done:-)
Yep, I re-checked the signature and you're absolutely right, they are necessary


On Dec 27, 2012, at 2:37 PM, Nikolai Vladimirov <notifications@github.com> wrote:

> In ext/rugged/rugged_note.c:
> 
> > +			notes_ref,
> > +			git_object_id(target),
> > +			StringValueCStr(rb_message));
> > +
> > +
> > +	git_signature_free(author);
> > +	git_signature_free(committer);
> > +
> > +	rugged_exception_check(error);
> > +
> > +	return rugged_create_oid(&note_oid);
> > +}
> > +
> > +/*
> > + *	call-seq:
> > + *		obj.remove_notes(data = {}) -> boolean
> @tnm, the problem is that when removing a note a commit obj is created and it needs an author and a committer. A hash seems like a reasonable way to pass them.
> 
> I don't see how the note removal can work only with note's oid . Maybe I didn't understand what you meant?
> 
> —
> Reply to this email directly or view it on GitHub.
>
Write *MongoDB*, not *mongodb*.

Maybe a better would be: *More info about MongoDB installation can be found here.* and you put here into link.
Please give better feedback to the user than "Submit". "Login" is a good candidate. ;-)
For relational database it is: lazyuser app does this. But it does not do this as middleware, but as a decorator (so it comes after all middleware peprocessing).

I recommend that for your middleware you extend official language selection middleware (based on browser settings) and then you first check if the user exists and then set according to that, otherwise you call parent implementation (the browser-dependent one).

Also add the language field if it does not yet exist. I will probably move those fields to a separate app.
Page objects should not contain logic. We should know what we're expecting based on the scenario. If password and login_password are different then we should have different properties too.
This should be `@returns: boolean value representing blah blah blah...`.
Is there a reason the constituents of this branch block can't just be placed into the try/catch block above?
This doesn't look entirely necessary. Is it? I tried removing it and it was fine.
Thanks a lot for explanation. I agree this loop needs to be fixed.
But I do not understand your last version. I think it might be something like that:
```
while True:
    sockets = poller.poll(timeout*1000)
    if sockets:
        break  # we have got result
    if tried >= tries:
        raise SaltReqTimeoutError('Waited {0} seconds'.format(timeout * tried))  # but still have no results, so it's enough
    tried += 1
```

With your version we do not care about poll() results, we will just wait up to tries*timeout and raise exception.
Do we need the println here?
You mean
```csharp
        public System.Guid Id { get; set; }
```
With the comment on line 905. There is now one lookup(QType::ANY, rLabel); and a if for the types.
I put include("dlload.jl") here, so that it will be available for loading PCRE, but is after the very useful, basic string manipulation functions
duplicate with foreman_architectures
Actually  I think @next_environment && @next_environment.blank?   is sufficient.  We don't want to allow them to create a changset if there is no next environment.
Will this prevent webapi.js from being used offline?
Could you please move the variable declaration at the top of the function?
Variable hoisting is there to do it for you anyway, but it's better to make sure it behaves as expected.
Okay, right.  I added a download_url to setup.py in the pull request.  Thoughts?
It was so spammy. It's checking every three seconds
If all who contribute translatable strings to the source would be a little more straight there would be no need.
It really annoys me, that we habe strings that have incorrect grammar or punctuation.

At least for the string "Error: Transaction creation failed." we currently already have 2 strings in the translations, this pull makes one out of them.

You are free to close such pulls you consider not valuable, even if I don't agree here, as a good overall string handling was needed badly and this covers the last things I could find!
Or... We already have a GetProxy function to encapsulate getting values from proxyInfo, why not use it here?
These two need to be changed to URI to compile.
hahaha, you win code review
Does this need to be public? I don't know if we really need to make Model's public API even larger.
Actually domain 'cake_dev' should be replaced by variable `$validationDomain` available in that funciton. This message isn't just for developer but instead the validation error is seen by end user.
autsch. no. you usually use strpos with !== false
When I build the grids I add it to the tab and  keep a reference in  gridByType object with the feature type as key.
Than we have something like: 
```
{
  'addresses': <grid object>,
  'parcels': <grid object> 
}
```

`firstType` is the first type we receive in this results file.

`previouslyNoFeature` no previously receive feature, in an other word the tab is empty before we revise this results file.

Than ` if (previouslyNoFeature && firstType)` mean we have added the first tab in the grid => we want to display it.

Is it clearer ?
it exists for a reason, no string feelings about it. IDE auto-suggests it so I did not give it a second thought.

Does everyone agree on keeping/removing this?
why commenting a placeholder?
Can't we have with normal flow as primary one? We use an alternative flow for entire code execution.
All you need to do is `return;` and negate this condition.
Ah sweet. I'll take a look.
These should probably be in a sub-dict.

    'attributes': {
        'primary': ...,
        'secondary': ...,
    }
I am also more of a fan of building the query once, instead of having a duplicate query. Example: https://github.com/forkcms/forkcms/blob/master/backend/modules/form_builder/actions/data.php#L42-67
Why? Is this used? Can't we replace all occurrences of `::getDB()`?
If not the PHPDoc should be fixed so there is decent autocompletion.
Our puppet scripts are uploaded to S3.
jgroupsRef doesnt seem to be used any where
This can be safely used if workon_home is undefined, because it is normal to specify the absolute path of an env.

Something like:

```python
def get_workon_home():
    if 'WORKON_HOME' in os.environ:
        return os.environ['WORKON_HOME']
    default = os.path.join(os.environ['HOME'], '.virtualenvs')
    if os.path.exists(default):
        return default
    # fallback on empty, absolute or cwd-relative paths must be used:
    return ''
```
How about `The OID of the git object which should see its note removed`?
And to be picky about the message, they're not remote branches, but remote-tracking. A remote branch would be one that exists in another repo, and we don't care bout them.
OK that's fine.
This should be an acronyme with a title value (both for l10n an a11y)
this quick way is go turn off the karma switch and flag. Then run `./manage.py cron cache_top_contributors`. But that depends on a recent database because it only looks at data in the last 7 days. So what I do is a go into `apps/questions/cron.py` and tweak the SQL to be more days.
Yeah, it sucks. It's unfortunately the way the implementations work and I can't think of a better way to solve it.
isn't this the filesystem impl not postgres?
"Maybe expose"
不要引入全局变量和全局函数，所以这个文件最好整个包裹在一个function里，比如：

```javascript
$(function(){
  var PHOTO_DIR = ...;
  var images = [];
  function discover() ...
  function ...

  discover();
});
```
i think it is better to add these tests path for Molino and Model on the bootstrap.php as that way the test classes will not interfere with the prod like loading
why did we loose the .swp file ignore? :)
Modifica*
A safer way to do thins could be something like.
<pre>
std::vector<u8> data;
QByteArray qtData;
...
qtData = QByteArray::fromRawData((const char *)&data[0], data.size());
if (qtData.isEmpty() || qtData.isNull())
{
    LogError("AvatarDescAssett::AddAttachment: Failed to serialize attachement data from " + assetPtr->Name());
    return;
}
...
attachDoc.setContent(qtData);
</pre>

http://doc.trolltech.com/4.7/qbytearray.html#fromRawData

I'm not sure if you need the `data.push_back('\0');` or the (const char *) cast, but see how it goes.

Here is example how to get QByteArray from std::vector<u8> https://github.com/realXtend/naali/blob/tundra2/src/Core/Asset/IAsset.h#L118 and yeah it uses the same cast you have, so its fine.
equals / hashCode / toString
він в .gitignore має бути
і ліва і права частини вертають емейл, але перероблю через @secure
With the current implementation, the ``matchRequest`` method will always be called. Thus, HttpFoundation will always be required.
It is done for all classes of the global namespace (be it core classes or no. See the references to Twig classes in TwigBundle)
This comment should be rewritten as ``Dumps a reference configuration for the given configuration/node instance as YAML.``
Yes, I think it is.  Going to track down the type of a variable is a distraction from whatever it was I was doing before, and now I'm reading unrelated assignment code.  I've not seen my IDE figure it out from the constructor yet, so I don't know how common that is.  Every issue that causes me to think about something other than the problem I'm trying to solve is one more distraction that interrupts my flow.  Plus, it's easier to make a blanket statement of "document everything" than to sort out "do we really need it this time?"
`assertCount()` should be used here, and below.
It's a private method that is not used with these params. So no need to handle that.
Ah, I see how it works now. I find the implementation pretty strange. Why not simply create only one DumperCollection and then add each route to it. No nead to create itermediate dumpercollection that are then not used at all. This way, `addAllRoutes` is not even needed.
no need for these local variables
Best I can do is throw an exception like "Collection root's prefix must be an empty string" when parent is null when this line is reached. What do you think ?

Do you have any last remarks, so that I could do one final fix ?

Thanks
should be ``static private`` according to the CS
btw-- if you want to retain the debugging information here -- it's often useful -- you should probably either (1) use logging at a debug level, or (2) pass a debug flag into the codec constructor.
"""
To create a Finagle Thrift service, you must implement the `ServiceIface` Interface that <a href="https://github.com/twitter/scrooge">Scrooge</a> (a custom Thrift compiler) generates for your service. Scrooge wraps your service method return values with asynchronous `Future` objects to be compatible with Finagle.

* If you are using <a href="https://github.com/harrah/xsbt">sbt</a> to build your project, the <a href="https://github.com/twitter/sbt-scrooge">sbt-scrooge</a> plugin automatically compiles your Thrift IDL. **Note:** The latest release version of this plugin is only compatible with sbt 0.11.2
* If you are using <a href="http://maven.apache.org/">maven</a> to manage your project, <a href="http://maven.twttr.com/com/twitter/maven-finagle-thrift-plugin/">maven-finagle-thrift-plugin</a> can also compile Thrift IDL for Finagle.
"""

@stevegury Steve, do you have an official link for the maven plugin? I could only find it under Twitter's maven repos. Sorry, I'm not familiar with maven plugins. Let me know if the revision is OK. I think it's important to specify that the developer must implement `ServiceIface` and not `Iface` to make the example clearer.
@isnotinvain that is a good idea.
This is wrong! We don't want to put these in Bootstrap. It is wrong.
add_index :dashboards, :user_id, :unique => true
Why are you deleting the rus translations?
Oh, this is left over from testing. I tried to see if reducing function calls would help.
Something like this:

`const int &x = iter.x();
const int &y = iter.y();

for (iter, begin, end)
    //use refs instead of x(), y()`

But the compiler was already inlining and optimizing x() and y() such that it made no real difference.
By default exit returns success to the OS. It should be 1 here.
Seems strange that I should set the ellipse keyword, but it only kicks in if I provide proj params.
Worse, I don't think we should be exposing the user to the ```proj4_params``` - it is an implementation detail that we are using proj.4 under the hood.
I think this was accidentally left here
OK, all my attempts to make this break fail - it seems OK to me. 

*However*, I would like to test moving plugins around as well, but as far as I can tell the CMS doesn't use `CMSPlugin.move_to()` at all, and I haven't been able to use it successfully to move a plugin. How does the CMS move plugins, if not using that? Surely it has to at some level, if it's using the MPTT base class for them?
Or should ```Ember.State.detectInstance(target)``` be used here?
We should be using your new legal_file function here, right?