labofsahil/github-event-dataset-2012 huggingface dataset:
This class should be removed and this work can be done by the subsystem add handler.
Yaaaay, zero sanitization. Now I can unlink **whatever file I want on the host system**.
We don't delete the results, we reset the run in this job. The results have permalinks and will stay available by direct link.
I'm pretty sure we're missing a:
```
.touched .swiper-rail {
  opacity: 1;
}
```

Otherwise we don't see the trial at all on the direction we're going.
I think any modifications related to z-index should goes to `apps/system/style/zindex.css`.
call the z-index police, @alivedise.  :)
You need to escape things before putting user input into `RegExp` unless you want to enable user to search SMS with regular expression (geeky search!)
do you really only use console.log and no .warn or .error?  If not maybe use bind() to parameterize the type?
Does 'disabled' works for links? I know it does for buttons, but not for <a> tags. You sure of that?
Ya, I really use the photo as a temporal mock. But we can remove it now and add it back when the contact photo is ready.
This seems slightly different than the other crash, file a bug please?
I would personally add some line breaks after the break instruction but i can live with that for landing.
The UA checking is removed and I commented on that problem and paste a related bug in the code.
Yap, parseInt() is what I wanted here, I will change this.
Maybe it happen before ftu is launched? I have no idea, but every time I flash I'm already connected to the wifi so this is the first possible workaround in my mind.
oh ok then :) it might be, but after I first set this up, the rest of the development of the entire code was way easier, so I think it's worth it.
better rename to out
ThreadUI.renderMessages(num) ?
Remove this unused function.

(are you intend to use it somewhere?)
Hm, where is the script?
how about `build_spec_command`?
I see what you did there :eyes:
k

On Fri, Nov 16, 2012 at 9:32 AM, Chris Bunch <notifications@github.com>wrote:

> In lib/misc.py:
>
> > @@ -0,0 +1,18 @@
> > +# Programmer: Navraj Chohan <nlake44@gmail.com>
> > +
> > +# These are invalid characters for an application name
> > +BAD_APP_NAME_CHARS = '/\\!~?<>:{}@#$%^|&*()+=;'
> > +
> > +def is_app_name_valid(app_name):
> > +  """ Validates an application by checking if it contains certain
> > +      characters.
> > +  Args:
> > +    app_name: The name of the application
> > +  Returns:
> > +    True if valid, false if invalid
> > +  """
> > +
> > +  for ii in BAD_APP_NAME_CHARS:
>
> This is exactly the thing that regexes are designed for. They're extremely
> common, so just learn how to do it - it's not that complicated.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/AppScale/appscale/pull/99/files#r2154310>.
>
>



-- 
Navraj Chohan (Raj)
PhD Candidate @ UC Santa Barbara
http://cs.ucsb.edu/~nchohan
http://appscale.cs.ucsb.edu
http://nlake44.posterous.com
Explain this more clearly.
Space these properly.
&view=karma is deprecated...
What was the reason to rename the function? To me it looks like the new function is backwards compatible and displaying "access denied" message.
Oh, yes.
Sorry, it's commented when debugging and I forgot to remove it.
I think we should refactor CCEGLView for win32 port.
When we first invoke 'CCEGLView::sharedEGLView()' , we should create the window and initialize GL environment. If it fails when initializing GL, it just return NULL.

setFrameSize just resize the window size, so it needn't to have a return value.
What about your opinion?
I've added an error, and a return statement now. Callers can decide how to procede when errors are present then.
The method name (doAuthDance and __construct above) doesn't belong in the docblock, if you have nothing special to say about the method it's fine, but don't write anything then.

We don't really have rules beyond [symfony cs](http://symfony.com/doc/current/contributing/code/standards.html). Just look around and follow what's already there :)
Shouldn't there be a case for `2.10*`?
原文: Creating and destroying models is now optimistic. Pass {wait: true} if you need the previous behavior of waiting for the server to acknowledge success. You can now also pass {wait: true} to save calls.

監訳案: Modelの作成、削除は楽観的です。もしサーバーから成功の応答があるまで待機するという以前の振る舞いを利用したい場合は`{wait:true}`と設定してください。また`[save](#Model-save)`メソッドをコールする場合にも同様に` {wait: true}`を利用できます。
whats a magic number?
shirley, enhanceGallery() ?
Move this into ````Row```` and use by ````#exists?```` as mentioned above.
I'm not quite sure this is the right solution.
The property alpha is already defined in DisplayObject, but it's overriden in Quad.as.
Please, use concatenation like this: `"attachment; filename='#{filename}'"`
Don't mix the single quotes and double quotes. It seems this file uses double quotes so write `"use strict"` instead.
Also, put a new line between the license and the `use strict` to separate them (are conceptually two different things, totally unrelated) and make them more readable.
why the default for an empty object here, but not above at L190?
done, see 1ff57d1
Would a `curl -O` be simpler here?
I find this comment hard to interpret - really this is just getting the full URI to pass to OAuth, right? I think this whole section could be removed and a call to `request.build_absolute_uri()` could just be inserted inline into the call to the `oauth.Request` constructor.
nit: 'directory'
But this dependency should be handled by the `composer.file` of the
component, not in Propel2. We just need to add the component name AFAIK.

ping @Seldaek

2012/3/26 Cristiano Cinotti <
reply@reply.github.com
>

> >      "packages": [
> >          {
> > -            "package": "monolog/monolog",
> > +            "package": "doctrine/common",
>
> Sf2 Validator depends on doctrine/common. ValidatorFactory class uses
> doctrine code to read configuration via annotations (
> https://github.com/symfony/Validator/blob/master/ValidatorFactory.php).
> It's a feature that we don't use but I have not found a way around the
> problem.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/propelorm/Propel2/pull/156/files#r605913
>
CriterionCuston or CustomCriterion?
Oh, so it is.  My mistake - I misread the next line.  Too much code. :)
This should probably return an actual string, not just something that stringifies, which I think it does, right?
Will this define the CFPropertyList constant at the top level?  If so, this is a problem.  When we vendor ruby code we need to make sure there is no possibility that we're monkey patching the upstream libraries.  One possibility, which I recommend, is to make sure these constants are rooted somewhere inside of the Puppet namespace.
can we have it expression style:

```coffeescript
@prompt_label_main = if typeof prompt_label == 'string'
  prompt_label 
else 
  DEFAULT_PROMPT_LABEL
```
Looks like `UndefinedConstantSetter` and `DefinedConstantReplacer` share some functionality. Here is a parent class they could share:

```ruby
class StubbableConstant
  attr_reader :original_value, :full_constant_name

  def initialize(full_constant_name, stubbed_value)
    @full_constant_name = full_constant_name
    @stubbed_value = stubbed_value
  end

  # methods that #stub can use
  private

  def context_parts
    @full_constant_name.split('::')
  end

  def const_name
    @const_name ||= context_parts.pop
  end
end
```

Which would allow:

```ruby
class DefinedConstantReplacer < StubbableConstant
  def initialize(full_constant_name, stubbed_value, transfer_nested_constants)
    super(full_constant_name, stubbed_value)
    @transfer_nested_constants = transfer_nested_constants
  end
end
```
If the user does not provide a query type to sequelize.query, check if the query is a select query. All other types of queries are still identified in abstract query
Ah, I see the problem now - the existing implementation would short circuit, so there would only be 1 extra request when the limit exceeded the number of entries.  Sending concurrent requests would always do the work for the missing entries.

Tough call, and adding an extra round trip in this primitive call seems to indicate that concurrency, when your search space isn't known isn't best here.  Or at least smarter concurrency like pages of requests so there can be a limit to the requests to missing entries.
Why are you removing this check? What happens if the class does not exist, in terms of user error messages?
It's the first time that i see double ! in PHP. Yeah, cast is better IMHO.
WOAAAAH WHA'S GOIN' ON HERE SON?!
That works, but I still find it clunky if you need to use a lot of different libs.

Wish there was something like a HTML comment directive or data attribute:

```html
<!-- meteor:client -->
<script src="jquery.js">
```

```html
<script src="jquery.js" data-meteor="client">
```
The 13 is isolated to one place which I thought was the main requirement. Do you want the following and if so to what benefit?

```
checkit.enterKeyCode = 13;
checkit.isEnterKeyCode = function(keyCode) {
    return keyCode === checkit.enterKeyCode;
};
```
If the input is very big we have two options:
 * instruct Erlang.re (PCRE) to convert matches for us
 * do it ourself
Converting input if it's big is not an option (converting just matches way more efficient)
ok, it just implies that any derived classes will act funny if they also redefine  __getattr__ 
maybe add it in the docstring thatderived classes should not touch __getattr__
...and is it "tile" or "title"?
Your idea is good @m8ttyB.
Glad to help @Sakshiarora !
Same here re: turning them off for admins too.
Long term we might want to have a constant instead of a magic number, even for the highly subjective "normally" ;-) but for now this is good.
yikes I think you are right! have fixed
Oops, you're right. In that case, LGTM.
shouldnt we check for the puppet version instead? (e.g. you might be missing the adapter gem?)
Comments as above.
Oh, I think I see the confusion. `new` is actually read-only, wherein it just renders new.html.erb when the app's visited. It is RESTful in that sense. But, it contains `authenticate if params[:shop].present?` (which has a redirect implementation) in case the shop logs into the app through the 'Login' button for the app inside 'Manage Apps' of shop admin. This link will be something like `shopifyapp.com/login?shop=someshop.myshopify.com.....`

Hence that condition inside `new`. Makes sense?
I would rather say : "Iterate the new placeholders array to rewrite each one."
Well, this was a bit Q&D, I can perhaps rewrite it to improve performance.
unique_ptr\<T\> x;
T* y = x.get()
I think you can make your life easier here (and more efficient) doing:

tCCount := TABLE(pDis2,CCountRec,value,MERGE);

but I may be missing something - so check my suggestion - but if it works - it will be faster ...
same as above: if originalNodesOrder was not yet init, why do we have to init here? i think you could just if (null !==...)
There shouldn't be a space here between the method name and the parameters (See https://github.com/bbatsov/ruby-style-guide)
`return unless path.exists?`
No, this is not a priority for me at the moment.
I considered this approach the first time, but the issue I saw is that while ClojureCascadingBase#prepare has a FlowProcess instance, which I can pass to KryoService#deserialize.  The ClojureCascadingBase#initialize method has no FlowProcess for passing to KryoService#serialize.

Also, I didn't look too closely, because of the issue above, but can we be confident that the FlowProcess being passed in is actually an instance of cascading.flow.hadoop.HadoopFlowProcess?  That way I can cast to that, and use .getJobConf().
This change seems unneeded?
Write a small comment of what this does (particularly, why ``isDefinedAt`` is defined this way``)
I guess we have it to avoid that ``super.codeComplete`` gets called. I'll add a comment explaining why it is there.
"Interrupteurs" ? "Crochet" ? This is not usual french either.
`Callbocks` :)
Huh? Maak dan ff een beter plaatje ipv paddle-red te gebruiken
`&&` instead of `AND` (other occurences as well) :)
не совсем понял что Вы предлагаете исключать.
Строки здесь лишнее. Можно сравнивать обе днк поячеечно.
А оно разве не уйдет в отрицательные значения? Это же int.
As I said, I do like the idea. But I also have timing constraints and priorities.

We need to have a new beta released pretty soon, to check if database problems reported by some users are solved or not. So I prefer to keep it this way for now, and improve later.

If you have time to implement this user interface, feel free to do it. I'll be more than happy to pull it whenever it is available.
`// s`
No need to copy this file (and create `config` directory) on this spec.
It looks like you're just trying to find your tag obj.  You can also use something like this.

```
if (xtag.tags['x-dropdown'].methods['actionType']){
  xtag.tags['x-dropdown'].methods['actionType'](this);
}

```
i would suggest dependent destroy on commentables too.
Each time one forgets to add a trailing newline to a text file, two things happen:
 - A fairy dies
 - Linus bursts into tears

I know, that there's a huge debate regarding whether Linus actually exists or not and I don't want to turn this thread in a religious flame war... So, please, at least, do it for the fairies.
The TestHiddenWidget is needed.

Marc Schröder wrote:

> > @@ -306,3 +309,62 @@ def _has_changed(self, initial, data):
> >              pass
> >
> >          return initial != _data
> > +
> > +class TestHiddenWidget(TextInput, SelectableMediaMixin):
>
> Is `TestHiddenWidget` used, or is it a leftover of the development phase which can be deleted?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/metashare/META-SHARE/pull/188/files#r794978
you sure? tests would fail?
I think here you could just use:

```ruby
delegate :show_welcome_page?, :to => Refinery::Core, :prefix => nil
```

Or

```ruby
delegate :show_welcome_page, :to => Refinery::Core, :prefix => nil
alias_method :show_welcome_page?, :show_welcome_page
```

Or no?
This needs `{% trans "Search..." %}`
Would you be willing to move `dotproduct` into this class too? That'd be awesome, just so we're not mixing calls, as I think we eventually decided that all of `numbers.matrix` would be in this file/class eventually.
Do not surround links with `<` and `>`. It can cause problems.
默认是不安装的
Not sure if I feel strongly either way. Nice to have for cuc users, but seems like we're going in the direction of rspec only so I doubt we'd use them anymore.
But they don't hurt either...
This name is a bit misleading, it should be test-durable-mailboxes, I'll fix it.
I haven't thought about that, thanks. I choosen the Boolean option and set the default value of `jac` to `False`. 4ed75ba
No. Please see my change in getModelName().
use copyfile=False unless these are overwritten.
Назначь ему какую-нибудь няшненькую иконочку.
¿Esto sería temporal?
Si, la linea de fin de proyecto esta mas abajo.
moved.  I don't think it hurts to always set the default language.
May seem unorthodox but since the <li> contains plain text and not an element, it's neccessary to wrap the contents first so the ajax notification can be applied.
I'd like to change the constructor of the rowAction.

For a route with parameters, we can use this constructor :

$myRowAction = new RowAction('title', array('route' => 'books_more', 'parameters => array('id', 'author_id', 'other_parameter' => $my_param), 'absolute' => false) false, 'target');

If a parameter of the route is a string, we use the data of the grid else we use the given data.
99 should be a string here, no?
Please fix CS : `return get_class($this);`
yes, the dictionary I created has linefeed characters in the base64-encoded data (I always understood they were appropriate, but I'll take them out now, as per your quote from WIkipedia -- thanks!).  However, when I compiled GoldenDict from my fork, and fed it that dictionary, it worked just fine (i.e. -- at no stage were the linefeeds converted to tags).  Strange.
Since this branch is primarily here to ensure compatibility with vms2.3, do we need this check? Does vms 2.3 have the setup_for_library() method? If so then we don't support any older versions of vms, so we can just default to it. The stable/Diablo is currently tracking vms2.4, and it already has imcompatibilities with vms2.3 (guest parameters during launch). Perhaps this fix should be slated for stable/Diablo and just change to logger.setup_for_library()?
but i did miss deleted_at here
give me a moment
Is this if statement (and the others) merely for logging purposes, or should we "return;" here as well ?
Configuration objects must be read-only, please use the Collections.unmodifiableXYZ() method to make this and all other collections unmodifiable after building
Should I remove the MongoDBCacheStoreTest class from the functionnal group ?
This can be `@(URLString)`.
There doesn't seem to be an implementation of this. :trollface:?
i guess you did not really intend to break this url, right?
These two are already handled by the superclass.
This break is a little untidy. Perhaps a temporary variable to store the output of `self.canvas.figure.get_axes()`?
probably best to wrap this in a:

```
try:
   # do animation
   ...
except:
   os.remove(fname)
   raise
```

So the temp file *always* gets nuked.
You removed (probably accidentally) the new line at the end of this file. Could you add it back in?
Note I have changed this function's docstring to a comment as I don't want the function appearing in the sphinx documentation.  The function should really be private with a leading underscore, but as this is a documentation PR I didn't want to change any code that would require new testing.  I have made a note to address this when I am next altering the class.
The difference would be on how gaia-ui-tests was installed:

Installing via easy_install vs. pulling the code directly
@m8ttyB, @klrmn: why not use py.test's teardown instead of a simulated teardown?
the backgound image would of course only be relevant when using a <button> or <input>  instead of an anchor.
I think you could also add a wai-aria role to the image eg. <img role="button" src=...
I'll fix the typo. 

My thinking was - it's in the context of dept. A department can only have one manager - managers will imply that you can have more than one manager.
Good point. Just switched to _.isNumber.
And why do you have to create a kernel? Couldn't the user just supply you a kernel object? At least this is what we do for any SVM...
Tak po troše špikování kódu pomocí printk se mi zdá, že ta chyba bude u tebe. Zacyklí se mi totiž přesně tenhle while cyklus. Ten mi ale připadá v pořádku, takže se asi nějak naruší integrita toho listu. Proč se tak děje, jsem ale nevypátral.
i've changed the code to use the parameter set in the Extension class and removed this Compiler Pass. This does mean that only something evaluating to == true will pass
> which can only be set once before their setting methods are re-defined to accessor methods

This is true but `save` is coded (somewhat precariously) to only set those fields if not already set (i.e. with the setter methods unchanged). That being said, I do agree that save doesn't need to be (and probably shouldn't be) called more than once per lifetime of the Vanity object.
Sounds like the best solution to me. I agree that route specific ones should be called after the global ones. So the implementation needs to be changed.
I would suggest that revive only resurrects objects that are not alive.

```as3
if ((basic != null) && !basic.alive)
```

It's fairly common to override `kill` to set an objects `alive` to false but to keep `exists` true, so that you can leave dead bodies on the screen for example. Having `FlxGroup::revive` like this would make it easier to revive such objects.
Are you sure that the property "storage" exists? Did you maybe forget to declare it?
else nicht nötig
Can we log if an exception is caught here? Dropping it completely is nasty.
Okay i checked this and you are right. 
It's better to remove $bucketName from the constructor and use $storageName, because `riak` 
can better scale more small buckets as than one big bucket.
I wasn't sure which event is triggered when a pull request is merged.
I want the deploy request to be made when ever repo code changes.
Or `(every? (set->predicate (:awards book)) awards)`.
Do we actually need subclasses of this? All the concrete implementations are empty, the database specific work seems to be abstracted into the Iterator.

To get the correct iterator we could pass the iterator object to JDatabasePages in JDatabaseDriver::getPages().

Of course if there's database specific stuff that will be added later to JDatabasePages than this approach makes more sense.
This seems like a change in functionality; in previous versions, site & widget settings had a logo/icon as well as a thumbnail. In the case of the sitesettings, at least, I'm pretty sure that the logo is meant to be much larger than a thumbnail. It might be easier for now to just add the thumbnail field, then in later releases remove the logo and icon fields if we determine that they're redundant.

Also, perhaps ``thumbnail`` as the field name rather than ``thumbnail_file``?
Set to private.
I'm confused. What is the inconsistency?
this would make a good `component/*`, so we can eventually move this sort of x-browser junk out of superagent
You can move this immediately after `mail_managers` above. If `mail_managers` will raise exception, it will not be run. So you can simplify code here and simply call `super(ContactView, self).form_valid(form)` at the end.
NO! Don't fetch anything during user request processing. This should be done in the background. What if this takes minutes because third-party server is slow? What if it fails?
I have no idea. This commit was already in our (team 1) repository. I can delete this.
And also what if tasks interval changes? Isn't 10 seconds pretty intensive?
Check existing Django source code for examples of validation error codes. (Here `password_incorrect` would be better.)

Use past tense. And maybe be more polite, Django has for example: *Your old password was entered incorrectly.* – they do not tell so directly who is guilty. :-)

Anyway, try to reuse strings from Django, if possible (not in this case, but maybe somewhere else, for example for field labels), because then we are getting translations for free. :-)
Ehm. OK, to ask differently: where it is imported?
Is `:build` actually accurate here? It sounds like pkg-config isn't required to build imagemagick, but to run its Magick-config script. `:build` in a dependency is meant to indicate that it's only required while building the package, and isn't required once the package is built.
Read this; if this is just straight libs then you can omit the test.
If we pass a string request [Convert.ChangeType](http://msdn.microsoft.com/en-us/library/ttf5d382.aspx) will return the string's `int IConvertible.ToInt32(IFormatProvider provider)` value. To avoid this, we still need a `switch` or `if` statement in order to exclude the types that we don't want (e.g. `string`, `object`).

I was thinking something completely different.. Since this code is exactly the same with the one in the `NumericSequenceGenerator` class perhaps we could extract it so it can be used by both places.
yes. I use it in https://github.com/nzzdev/www-sql/pull/412/files#L1R3

> formatDisqusDate is defined inside of $(document).ready but not in global scope
- I didn't use "var", so formatDisqusDate in global scope.
We have a helper in gateways to take care of this, `requires!(options, :login, :password)`, not sure if it can be used in integrations but maybe check it out.
try / finally around the set / restore ForegroundColor - any exceptions here will not reset the color back to its original value
Wäre schöner das ganze try catch/JSON Object erstellung auszulagern. Code wird sonst in jeder Activity so mindestens einmal stehen.
Linkie to ZF2 docs here
Don't pay attention to what I said: I made a fresh install of the bundle and everything went fine.
Also this bracket level is not needed AFAICS.
it has to be deleted
OK, I take the point: I didn't look into this code as carefully as I could have.  I was scratching my own itch and thought that coming to you with some code that fixes my problem would be better than opening an issue with no code in sight; I wasn't expecting you to merge it blindly.

As I see it, this was a success: in my haste I had misunderstood the intention of the original code and fixed the problem in the wrong way.  However, the issue has been identified and will be resolved in a more efficient way.  That sounds like a win :)
The doc has been converted to rST a while ago so this one should be converted too (and moved to the appropriate location)
All strings displayed to user should be [translatable](https://docs.djangoproject.com/en/dev/topics/i18n/).
I wouldn't really name this a hack, but simply a normal way to do it. Please keep comment aligned with the rest of the code. And move it inside the method.
Ah, I need to actually make a comment for that block. Thanks.

As far as checkstyle being turned off, the class created within this class was causing some errors. Checkstyle was insisting that the class created there needed it's own javadoc, which is fine. But it also wanted the fields to be private and to have public getter and setter methods for each field. It seemed excessive for a test class.
ahahah i'm losing it
OK.  It's not actually hard to implement that, so I went ahead and did it.
You scared me for a second until I realized that you meant that those invalid initializations DO raise the appropriate error and therefore those tests would pass.  Yes, I will add this unit test.
same issue here, "psf_image" seems too general a term
OK, fine to go w/ that.
just wonder why we need to special case instructors out. i guess it's cleaner data, and it's okay for now, but what if instructors want to test that the report worked?

transparency vs. neatness.
Should uploading photos be done in the dashboard or in users/edit?
This is not right, we need to fix this to say...
I'm curious.  Why the '#' before comments when you have one at the beginning of the line?  Are you emphasizing that the 'comments' column isn't otherwise used by the test?
Nope; I'll remove both it and the unnecessary uses of `ScopedTypeVariables` below.
Oh, sorry, I thought that said 'timecop'.
Please move this array into Class variable (not local variable)
I wanted to make sure my intuition that this was necessary for `String` on 1.8.7 was correct...so I developed this on 1.8.7, and changed the operator registration from `Array` to `Enumerable` as the first step.  It broke a bunch of tests, and demonstrated this was necessary.  For example, this spec failed:

https://github.com/rspec/rspec-expectations/blob/v2.12.0/spec/rspec/matchers/operator_matcher_spec.rb#L107-L111
@procoderX  there is nothing at this place is re-verfiy and fix it... the document must be published on web as public.. grab the public link, and set the link here..
AFAIK NFS won't work on windows, although I know that it's way better with it.
Maybe there should be a note somewhere, to tell windows people to set this to false ?
This doesn't make much sense. Note that this is dealing with data over the network: invalid values on that data make no sense, so treat them as such. "Corrupted packet line" or the likes. It's not like somebody forgot to write a space.
Если использовать ArrayDequeu.descendingIterator() - reverse() у StringBuilder будет не нужен.
В идеале - надо сделать ```private static final int[] dayIndexes = new int[] { Calendar.MONDAY, Calendar.  }``` и итерироваться по нему - код намного нагляднее будет.
Там daysOfWeek - неиспользуемая переменная.
Typo s/maifest/manifest
i think this is the test performed by is_the_current_page()
Yep I totally agree with @klrmn , this property needs to return just the date and obtain it as safely as possible. Then you can use `assert.equal` in the test to compare whether the start date is valid.
Sure, should I switch over to using the uiAddContent branch now from uiIndex2?
Deprecated, not used = DELETE
maybe we just should return from `wrap` https://github.com/plataformatec/simple_form/blob/master/lib/simple_form/wrappers/many.rb#L53 when namespace equals to `label` or `input`?
We can't use 1.9 style here ;)
could we use `sparse_format` as a property of the class? so that it can also be used to generate the docs to indicate which estimators/transformers supports sparse and which don't?
Cosmetic comment: we rather like to respect PEP257 for docstrings:

First line should a short descriptive one liner and more description in a paragraph after a blank line:

```python
        """Fit all transformers and transform the data and concatenate results

         Valid only if all transformers implement fit_transform.

         ...
         """"

```
the name of this variable is not very clear to me.
@ndawe do we need both ``n_samples`` and ``weighted_n_samples``? - for unweighted samples ``weighted_n_samples`` equals ``n_samples`` and in the case of weighted samples we should use ``weighted_n_samples`` anyways....
On Aug 10, 2012, at 10:14 , Andreas Mueller <notifications@github.com> wrote:

> In sklearn/metrics/euclidean_fast.pyx:
> 
> > +
> > +cdef extern from "cblas.h":
> > +    double gemm "cblas_dgemm"(char STORAGE, char TRANSA, char TRANSB, int M,
> > +                              int N, int K, double ALPHA, double *A, int LDA,
> > +                              double *B, int LDB, double BETA, double *C,
> > +                              int LDC)
> > +
> > +
> > +@cython.boundscheck(False)
> > +@cython.wraparound(False)
> > +def dense_euclidean_distances(np.ndarray[DOUBLE, ndim=2, mode="c"] X,
> > +                              np.ndarray[DOUBLE, ndim=2, mode="c"] Y,
> > +                              np.ndarray[DOUBLE, ndim=2, mode="c"] out,
> > +                              bool squared=False):
> > +    cdef np.ndarray[DOUBLE, ndim=1] XX = np.empty(X.shape[0], dtype=np.float64)
> > +    cdef np.ndarray[DOUBLE, ndim=1] YY = np.empty(Y.shape[0], dtype=np.float64)
> 
> @vene could you compare if indexing via .data is faster?

I tried it in every way that I can think of but I can't get the casts right. How should I do this?

> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 

------------------
Vlad N.
http://vene.ro
Also you're adding the documentation to a base class, add it to `RidgeCV` instead.
This is the first mention of `top-down`: it should be defined here or somewhere previously.
That sounds great.  I like that plan.
Therefor you shouldn't be calling sync directly here.
The header classes all inherit from peer.Header, which implements ```equals()```and ```toString()``` methods.
The latter is used in equals to determine if headers are the same.

I didn't change that behavior.

I agree, that using
```$this->assertTrue($requestHeaderExpected->equals($requestHeader));```

looks better than
```$this->assertEquals($requestHeaderExpected->toString(), $requestHeader->toString());```

but I wanted to test the factory, not the ```equals()``` method of the headers.
if (standalone && (!serverConfigurationDir.exists() || !serverConfigurationDir.isDirectory()))
Add test `0.α8503();`.
Do we really need this init() method? 
The _LoaderHelper_ class itself is in the hibernate-search-orm module, which depends on both JPA and Hibernate ORM, so it's module should be configured to be able to load the ObjectNotFoundException/EntityNotFoundException.

I think this should work fine using

    ClassLoaderHelper.classForName( "org.hibernate.ObjectNotFoundException", LoaderHelper.class )

hence not needing the init nor the volatiles.
no time like the present.
Good point, changed to std::max(INDEX_BLOCKSIZE, maxRows*2*sizeof(void**)
I'm not concerned with the memory leak, we can live with that.
But leaking a lock is serious.
this now needs to be version**s** and the regex should contain the `;`
Are you sure it's a good thing to install less as a general module and not a local one? Everything in Playdoh is done to work in a virtualenv so why not keep consistent and use local node modules as well? In which case you can just add a line to .gitignore so the node_modules folder doesn't get added into commits.
coincidentally, that error type was already declared :)
$this->fs because i use Filesystem instance in tests.
I'll fix declaration. 1 minute :)
Ah got it, thanks, sorry for that.
On 20 Feb 2012, at 07:27, Marc Bennewitz wrote:

>> @@ -73,7 +75,12 @@
>>     public static function factory($options = null)
>>     {
>>         if (null === $options) {
>> -            $options = array('Zend\Loader\StandardAutoloader' => array());
>> +            if (!isset(static::$loaders[static::STANDARD_AUTOLOADER])) {
>> +                static::$loaders[STANDARD_AUTOLOADER] = static::getStandardAutoloader();
> 
> should be static::STANDARD_AUTOLOADER
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/zendframework/zf2/pull/802/files#r466144
`url` should be capitals.
@shacker Where do we get this completed variable from?
Can we also remove the comment above this line?
These three `_link` methods look like prime candidates for some refactoring. Why don't we create a generic `discussion_link` method which handles the parameter checks and link generation. You can even use the `humanize` method on the category name so you don't have to have lines 35, 44, and 53.
Yes, that is exactly correct.  `1.2.4-dirty` is "greater than" `1.2.3`, but "less than" `1.2.4`, and `1.3.0`, and `2.0.0`.

If Puppet supported SemVer 2.0.0 build versions that would be `1.2.3+dirty`, which also orders the same way, but that isn't supported, and can't be for literally years, so this ... works around it for the moment.
all of these need to go.  ```load``` should only be used for debugging.
content->status !== version->status
See constants on SPI\Persistence\Content and SPI\Persistence\Content\Version.
ya header ro hazf kon ya bara bahgiye ham bezar
be in mani ke hame dar yek level tarif beshan
Right, if there is no central body, then there is no occluder.
Just to close the loop, this has been fixed in master.
Be explicit; return `undefined`.
Done.  I've been meaning to write a general regex to find these, did you have one, or did you just do a simple search and happen to find it?
Actually, a child can be declared this way:

top = 10
center.y = 20

This will cause the top to be at 10, the center to be at 20, and the height to be 20 (i.e. height is inferred from these two pins). Of course this assumes that height is not defined, otherwise center is ignored.

Here are the combinations used for calculating height and top, in precedence order:

height+top
height+center
height+bottom
top+center (height inferred)
top+bottom (height inferred)
top+default height
center+bottom (height inferred)
center+default height
bottom+default height
default top+default height

default height is the classic "auto" height (mobile web supports default height properly, just not the "auto" value to set the default height)
default top is center in composite layouts

Width/left is calculated the same way in composite layouts

If anything else is defined in a pair, it is ignored. Each pair assumes that the previous pair isn't valid (i.e. one of the two is undefined).
I'm afraid this will lead to a regression with current behavior for views with no children that draw outside of their bounds.
Probably could just make this static.
Need a sanity check here in case the platform isn't provided, (is `undefined`) so that `usage` can be displayed.
Could be structured around a `switch(platform)` or check for the existence of `driverGlobal.driverDir+"/platforms/"+platform`, and then fail if the platform can't be loaded. This will allow us to much more easily add platforms (bb, etc.)
Data still needs to default to an empty object
Yes, the names are lowercase to match the typenames in GLSL. This may change in the future.
Start with a capital letter and use a period.
Hmm - pointing to the commit provides  the delta - ie 'this is what you add - in various different locations- to get this working properly'.

It also shows you the (hopefully somewhat helpful) commit message I made when making that change :)
you should add it as a command line option then...
On 10/15/2012 9:41 AM, Greg Thornton wrote:
>
> In lib/cached_shell_redirector.rb:
>
> > @@ -104,7 +104,7 @@ def close_write
> >      # Ruby 1.8 define_method doesn't work with blocks.
> >      def method_missing(my_method, *args, &block)
> >  	# Only handle IO methods!
> > -	if IO.instance_methods.index(my_method.to_s).nil?
> > +	if IO.instance_methods.index(my_method.to_sym).nil?
>
> Ah, Ruby 1.8 uses an array of strings 
> (http://www.ruby-doc.org/core-1.8.7/Module.html). I'll update this to 
> do the right thing in either case.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/kubitron/redmine_git_hosting/pull/80/files#r1844078>.
>
Yes, just do:

if IO.instance_methods.map(&:to_sym).index(my_method.to_sym).nil?

--KUBI--

-- 
Professor John Kubiatowicz
673 Soda Hall
Berkeley, CA 94720
This had a valid html5 doctype. Why should we change this? I see no reason. Both html and xhtml are valid under html5.
r1 is not a very expressive name. Better call it "repositories" or something like that.
I have changed the implementation. Now, I dont delete the widgets, and rather show/hide them. I have done the implementation using QHash
Ну как же, я там внизу видел строгую проверку на null.
давай сделаем функцию debug для этого лучше
https://github.com/uploadcare/uploadcare-widget/commit/5df8d9af891e939e6f2cb8b8386f67d62d7a69c5
ну и потестировать чуть лучше. и с разными реализациями. А лучше всего сделать специальную тестовую реализацю и убедиться, что все было вызвано в том числе и деструктор!
Например можешь убедиться, что деструктор итератора вызван не будет. (до исправления бага)
Probably should fix this up.
All three changes in this file should be changed from `button` to `btn`.
PLZ 4 pointingto generic bootstrap -- BTW Porter told me to tell Porter he is a douche
Instead, I might use something like:
<pre>search_wiki( $search, $args = null ) {</pre>
i would rather not have this supported in the ``__construct()`` method
i wonder if we should do an empty check on the current configured groups just like we do for the status code .. this way it would still be possible to override the value in the annotation ..
I removed trailing whitespaces from this file.
`reason` is not needed
you missed the copyright header
ясно.
I'm not so sure this is good for code.  This particular limit was popular when screen sizes were smaller, but now screens and resolutions are much bigger and 100 quite acceptable.  This is something that is more appropriate for text files (like markdown or rst).
Fixed per Nico's suggestion.
Can combine this and the next two lines.
This needs to also make sure its getting a version of the right product; there could be versions with the same `version` for different products. (And should be moved out to the management command, as above).
Hahahaha. I forgot the liquibase changeset. :)
should this be remoteDIrectory+"/"+remoteFileName?
Yes, but if there __is__ a payloadExpression, you are just eating the argument...

````java

void sendAMap(Map<String, Object> map);

	@Test
	public void testSingleMapParameterWithExpression() throws Exception {
		Method method = TestService.class.getMethod("sendAMap", Map.class);
		GatewayMethodInboundMessageMapper mapper = new GatewayMethodInboundMessageMapper(method);
		mapper.setPayloadExpression("'foo'");
		Map<String, Object> headers = new HashMap<String, Object>();
		headers.put("abc", 123);
		Message<?> message = mapper.toMessage(new Object[] {headers});
		assertNotNull(message.getHeaders().get("abc"));
		assertEquals(123, message.getHeaders().get("abc"));
	}
````

I think you need...

````java
            ...

			else if (messageOrPayload == null && !Map.class.isAssignableFrom(methodParameter.getParameterType())) {
				messageOrPayload = argumentValue;
			}
			else if (Map.class.isAssignableFrom(methodParameter.getParameterType())) {
				if (arguments.length == 1){
					if (this.payloadExpression == null){
						messageOrPayload = argumentValue;
					}
					messageOrPayload = checkForMapWithStringKey(messageOrPayload, foundPayloadAnnotation, headers,
							argumentValue, methodParameter);
				}
				else {
					messageOrPayload = checkForMapWithStringKey(messageOrPayload, foundPayloadAnnotation, headers,
							argumentValue, methodParameter);
				}
			}
			else if (this.payloadExpression == null) {
				this.throwExceptionForMultipleMessageOrPayloadParameters(methodParameter);
			}
````

where checkForMapWithStringKey() is the code in the next else.
One comment on "result-type", in XML that is used to indicate the particular implementation type of javax.xml.transform.Result

If it had simply been the target type of a transformer, we might have named it "target-type" instead. There might be something else in a transformer elsewhere to base this decision off of (for consistency), but nothing is coming to mind immediately. We really do use the "x-to-y" naming most often.

The Tuple type itself will need some polishing (probably a 3.0 addition). We could possibly stick with Map only as a target type for now?
Maybe should we provide some **MockTwitter**?
IMHO
I basically agree on the patch. But the ssl-checks are not related to the auth-keys. The UrlConnection is verifying SSL certificates by default. The flag was meant to provide the ability to turn those checks off
`o.url + metric + '/` this part is too hardcoded. Django might be configured to not have `/` at the end.

You should accept as input URI template and then find/replace it. For example, URI template in this case could be `/api/v1/{mtaric_id}/`.

See: https://code.djangoproject.com/ticket/16391#comment:6

For now you don't need to play with Django part. You can hard-code in demo.html the values you are passing to datastream.js, but in the plugin itself you should use URI templates. Code to find and replace can be very simple. For example:

```
        function urlTemplate(url, params) {
            $.each(params, function (param, value) {
                url = url.replace('{' + param + '}', value);
            });
            return url;
        }
```
I designed datastream.js to be independent of Django and used on other platforms also. I know thet we are not planning this now but in the future we might want other web sites to plot out time series.

On 11. 09. 12, at 11:31, Mitar <notifications@github.com> wrote:

> In tests/test_project/test_app/static/test_app/datastream.js:
> 
> > @@ -0,0 +1,295 @@
> > +(function($) {
> > +
> > +    var current_plot_id = 0;
> > +
> > +    var datastream = {
> > +        "url": "http://127.0.0.1:8000/api/v1/metric/",
> What general JS library? We are doing django-datastream. It is Django based. This is what we are doing?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
The original was more specific and less ambiguous.
Please fix header's underline with the correct length (This occurs in the rest of the PR too)
It's so ugly it's almost pretty again. Also, spacing around the =. (I was probably the one making that mistake)
いんでんとずれてますよー
withName で該当するものが無い場合に発生する NoSuchElementException を BadQueryParameterException で
ラップするべきじゃないでしょうか。メソッドの責任的に。
一見例外処理をし忘れているように見えます。
the idea here was to be able to disable it again once it has been enabled...
This is an O(n) test - sounds slow.  Is this what the paper suggests?  This is only done once, right?  Not in a loop?  So it's probably OK.
I was bewildered by that too. We can look into changing it later, but I want to keep it the same for this PR. I mostly moved all this stuff up so when QE makes their own config files these first properties (before the blank line), which contain endpoints and will be different, will stand out.
I think it's sufficient to set the bootstrap value ``bootstrap="./Tests/autoload.php.dist"``, and remove the bootstrap file, or rename autoload.php.dist to bootstrap.php. 

After all, what is the use case for changing the autoload function? I think that should never happen.
how about this form:
```
case x
when Hash ...
when String ...
end # else nil then nil implied 
```
A little lower you call it Bag of words and not Bags. Also I think the expression "vector space model" should appear in this page, maybe even in a heading. Many NLP guys might google for it.
Good point :)

-W

On Nov 6, 2012, at 18:36, Naveed Massjouni <notifications@github.com> wrote:

> In dist.ini:
> 
> > @@ -5,7 +5,7 @@ license = Perl_5
> >  copyright_holder = Crowdtilt, Inc.
> >  copyright_year   = 2012
> >  
> > -version = 0.0300
> > +version = 0.0301
> This is a non breaking change. This is also adding a new feature. Given a Major.Minor.bug_fix version format, the minor number increments for new features. You incremented the bug_fix part. The perl convention is that 0.0123 corresponds to 0.1.23
> 
> —
> Reply to this email directly or view it on GitHub.
>
Should be QueryParam as this is a GET method
Is there actually a benefit to checking that it has changed rather than just updating it? Does it stop rails bothering to update that field or something?
Well ideally I would like to be pointing at a released version, and in a way that means update only gets released versions but I'm not sure that `vendorer` is actually able to that? At least not without help from upstream in the form of a fixed tag that points at the latest release?
отстпупы
The whole point is that the file might be in a subfolder, if I understand your question corectly. Say, you transform lib/bootstrap.less, then CurrentFolder becomes "lib", and all @imports in the file are resolved relative to that folder. BTW "first" in that context means "one and only".
Oops, I ended up confusing myself when I was messing around with constants.
New processor that registered insted of default inherited from default. I've just add new directive "require_closure".
remove the PatentDataSetDefinition from the session before the redirect
I added  Process.waitall to the end of test.
Can you please remove this pull request? All changes in the new pull request!
ALL_UPPER_CASE names are usually just for constants
I'm tending towards the same approach for native as well.
It is hack for `SonataDoctrineMongoDBAdminBundle` and `SonataDoctrinePhpcrAdminBundle`
I use only `SonataDoctrineORMAdminBundle`, and I can not say what effect the addition to return of `Admin::getExportField()` simple fields + association mappings.
put a space between the () and {
test delete activity, keeping node and setting id to null
Is here some kind of state tracking necessary? When the user pans the left view controller far to the left and continues panning, the value of isfirstViewControllerViewOverdraggedToLeft does not change at all but kvo notifications are send.