labofsahil/github-event-dataset-2012 huggingface dataset:
Ok. I will change.

Em 03-07-2012 14:30, Dickson S. Guedes escreveu:
>> +		elif [ $TARGET == "--all" ]
>> +		then
>> +			echo -e "Removing all Postgres installed by PGVM!\n"
>> +			echo -e "$VERSIONS"
>> +			rm -rf $pgvm_home/environments/*
>> +			exit 0
>> +		elif [ $TARGET == "--purge" ]
>> +		then
>> +			echo -e "Removing all Postgres installed and source by PGVM!\n"
>> +			echo -e "$VERSIONS"
>> +			rm -rf $pgvm_home/environments/*
>> +			rm -rf $pgvm_home/src/*
>> +			exit 0
>> +		elif [ -z $TARGET ]
>> +			 then
>> +				echo -n -e "Choice Postgres version to remove or the options.\n"
>
> May be "Choose a Postgres version to remove or check the options." ?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/guedes/pgvm/pull/11/files#r1094542

-- 
Fernando Ike
http://midstorm.org/~fike/weblog
Should be the first require() statement. This file needs the copyright boilerplate as well (copy it from one of the other tests).
It's quite surprising that this even compiled on newer versions of OS X. Compilers and linkers are way too lenient these days. :-)
Still working on them - the implicit conversions all use the default JavaHashMap right now.
`if` statements should always be split across two lines. I'd also make this `if len(shape) == 1` for clarity. And the comment really should explain what exactly this is accomplishing -- I think this is for handling both `ndindex(2, 3)` and `ndindex((2, 3))` syntax?

And if that's correct, then we need a test that both syntaxes are handled so this doesn't break again.
is this stuff still supposed to be here?
Is this a part of the standard?  Didn't notice that, do you mean all declarations at top of function?
You want this:

    .Op Fl r Ar reponame
на 2 строки
This shouldn't be present..  :-)
Wow, this is pure brain failure on my part.
I think you could just use `value.map!` instead?
@pixeltrix right. You can do this inside a view/helper because [`ControllerHelper` defines this](https://github.com/rails/rails/blob/master/actionpack/lib/action_view/helpers/controller_helper.rb#L8). We can make `AssetUrlHelper` depend of `ControllerHelper` but I don't think is a good idea since we want to include this helper inside AC
Ah ok. Thanks for the explanation Steve! That helps as I try to get back in the swing of submitting patches to rails.
The symbol is just fine, there is no reason to change symbols to strings here. The fact that is internal does not justify a change. The change should have a justification by itself.

Josh, it is OK that you prefer strings, but this is a subjective change unrelated to the feature proposal in this PR. And it is a cosmetic change we do not agree with because symbols are idiomatic and strings are not, regardless of your personal preferences which I respect.

On the other hand the feature itself looks good to me.
You should remove this author tag, or add your name :)
I think this should also be ``self.dtype.type(data[pos])`` to prevent similar unexpected behavior.
While I like the idea of the MaxAge arg being in minutes it makes this hard to test. I'd like to write a test and set the MaxAge small to trigger the cull and not have to wait in test code.

One thing I've done in the past to help clarify time units is to take an arg like `{2, min}` or `{30, sec}' so that the arg keeps the units very readable and clear, but can be expressed with different granularity.
just a random thought. should we put the map defs for the instruments inside the instr directories so that it is all in one place?
Does this happen regularly?  What exceptions are thrown? I don't like this bare except, because it will mask any problems with the code in the try block, potentially skipping modules or classes with some other problems without any warning.
This should be fine if it works.
Why only functions?  Shouldn't something like `2**(2*sin(x)*cos(x))` also work?
If it is more readable I will consider changing it to one_form.
Camelcase for is only for Class names, use "bodylist", "bodyList", or "body_list". Checkout out PEP 8: http://www.python.org/dev/peps/pep-0008/ there are tools to check for PEP8 compliance like: https://github.com/nvie/vim-flake8
Yes, I understand you, of course the next time I'll know.
Line delete.
Two git: prefixes? Bad copy-paste?
Does this satisfy the equals/hashCode contract? I have no clue how equals() is implemented so this is a real question :-)
I will also accept 'Ruinstorms', for those of us who've read Transmetropolitan.
Is it possible to detect that one is using musl, and adjust the CFLAGS dynamically?
Why don't you append path to event? That is:

```c
typedef struct {
  /* ... */
  char path[1];
} uv__fsevents_event_t;

s = paths[i];
len = strlen(s);
event = malloc(sizeof(*event) + len);
memcpy(event->path, s, len + 1);
```
What's the advantage of doing all this as opposed to just making `setPlaceholderText(WString)` a convenience method for `setAttribute("placeholder", "xxx")`?
DOCS-673
i may have when i was trying to figure out how to make this pull request happen, is that going to be a problem?
This was when controllers were accessed via extension name. When an extension name was given and that extension did not have a controller, this error would be displayed. However, now controllers are accessed via a path in routing.yml. This test is replaced by test_error_ext_disabled_or_404().
Can we use the `skip` key here?
I've found the current default to be good for working on the docs.  sphinx doesn't detect changes to static files, but you add a line to layout.html or whatever and it rebuilds everything.  I agree -aE should be the default for correctness, but it should be easy to switch to dev mode.  As for -N, I don't think I've seen sphinx use colored output, but you could enable it based on `log.isAnsiSupported`.
Re-calculation of `.width` and `.height` is needed here
I'm not against moving `index.js` to `mojito.js`, just curious, why is that valuable?
Given ```source``` is now an attribute, is it worth taking the metadata (excluding cell methods?) from the ```src``` cube and adding it to ```new_coord```?
Just so it can share a resource file with other functions, some of which need the orography.
Can you add in the docsting what edges should be?
I've added this code.
Thanks, I didn't realize this pull request was not based on the other one.
NB: just below this code there is a test if ``idx.stop`` is an int. Would this test need to be extended to include long as well?
(I suspect there are probably more places in the code that wrongly assume integer indices have to be int... which may be a pain to fix)
Should we tell that the user can set "pycuda.init" flag to True, to force the import of pycuda?
My typo, thanks paul.
Use ==
Почему и копирование свойств, и присвоение `this.opts = opts`?
Docstring is a bit confusing.
As I noted below, the performance bottleneck is likely due to the fact that we're performing the same filter query _in every task_, then slicing at a given offset to only consider the assets relevant for a task. So that would explain why a lower number of total tasks is faster (because you don't have to do as many redundant queries).
@interface, @implementation など、クラス定義に関わるブロック記述は以下のように改行してください。

@interface クラス名
{
    # メソッド記述
}
Turns out I don't need the `.get()` at all, since the methods accept a jQuery object and `.apply()` sees the jQuery object as array-like. That brings it down to -34.
`window.attachEvent` will ignore a browser other than IE, but I think this code is should be improved.
Please follow the style put forward by my existing C++ code. E.g., indent with 4 spaces, place functions opening { on previous line, etc. Thanks.
I didn't even think about that will fix this
Doh, sorry, forgot that again. I've set it to run on write in vim now.
I kept meaning to do this, then kept forgetting. Glad you did it!
Are the warning flags (`-W...`) actually necessary?
Don't need a separate config_args array
this is just the way coffeescript convert js to be sure that type is string, of course I can remove first quote if you want
what you think about adding another separate if statement after this line to check if CEDAR_REPORT_FAILURES_IMMEDIATELY is set and print out failure if there is one (instead of `else if {`)? that way stateToken will be printed in one place and nested format will also get fail fast output.
I've reverted this for now.
"в своей локальнокй ветке"
"separators" has 2 A's and 1 E, please
sold.
extractQualifier?
Yes, I think so - something needs to tell that same manage.py what settings to load.
How you feel returning a Hash with this variables? At least for me, an Array doesn't explains much about its values.
The above two lines should be indented by one additional tab.
Similar to above, AFAICT this should also be a prototype method on `AbstractBinding` (though in another PR if you want). If the first argument to a function must be an instance of a particular Batman class, then I'd say it belongs on the prototype.
Yeah, add it back in.
ha and actually that shouldn't be commented out. Even though clearly it does nothing at all.
What? No! That's _perfectly_ clear, don't you think?

…yeah, I probably should figure out what it resolves with.  


On Monday, September 24, 2012 at 9:58 AM, Dan Imal wrote:

> In app/mulberry/_Adapter.js:
> > @@ -24,12 +42,25 @@ dojo.declare('mulberry._Adapter', null, { > > /** > * @public > + * > + * gets data for a particular resource > + * > + * @returns {Promise} A promise that resolves with WHAT DOES IT RESOLVE WITH.  
> Did you forget something in the comment?
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/Toura/mulberry/pull/572/files#r1673173).  
>  
>  
>
I see, you're right -- it affects the number of change records you get during undo, but not the number of change records you get during the actual original edits (so the two can actually be asymmetrical).  Looks good then.
This TODO comment can be removed.
Good call - renamed to _getUpdateInformation()
I don't think you have utf-8 here. Even if you have utf-8, I'm afraid that it still won't work in Brackets. I remembered that we intentionally removed high-ASCII characters from French url path. Anyway, can you replace (or save) it utf-8? We'll try to fix it in Brackets later on if utf-8 path is still not working.
Ditto -- do we want something akin to verifyAttrHints() here?
I'll add a todo for this so we can fix this next week after the pull request lands

-----Original Message-----
From: Peter Flynn [mailto:reply@reply.github.com] 
Sent: Thursday, May 24, 2012 3:02 PM
To: Ty Voliter
Subject: Re: [brackets] Menu and Command and Shortcut Extensibility implementation (#936)

>  
> -                    var $menu = $("#" + menuID);
> -                    // Some commands have multiple key commands. Only add the first one.
> -                    if ($menu.find(".menu-shortcut").length === 0) {
> -                        $menu.append("<span class='menu-shortcut'>" + shortcut + "</span>");
> +                var key, i, platform;
> +                for (i = 0; i < keyBindings.length; i++) {
> +                    key = keyBindings[i].key;
> +                    platform = keyBindings[i].platform;
> +
> +                    // TODO: handle insertion position as specified by relativeID, position
> +                    // also support inserting into Menu Sections
> +
> +                    if ($menuItem.find(".menu-shortcut").length === 0) {
> +                        $menuItem.find("a").append("<span class='menu-shortcut'>" + formatKeyCommand(key) + "</span>");

I'm a little worried about how this works.  If anyone else has registered a keybinding for this command, it won't show up -- only ones passed here during menu item creation show up.  Similarly, if someone adds/removed a binding later on, the menu item doesn't get updated.

To solve the first problem, it seems like maybe KeyBindingManager should maintain a second map, from command id to list of shortcuts, so Menus can quickly find all registered shortcuts for the menu item's command.  For the second problem, KeyBindingManager should probably dispatch add/remove events.

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/936/files#r878489
why? 
i am adding exists to both path and fs in the very start of server.js
because there are some more modules which need it (e.g. architect)
should the first occurrence of "table" be "process"?
detailed_description is marked_safe in template_context of the super class
This is marked safe in InterfaceEditableItemMixin
maybe make a util function for this?
I think we should be raising the exceptions in both of these blocks (especially where we make the call to handler() ) so that we get the email for the exception.  Catching and continuing also doesn't preserve the handler order in the way that may have been intended.
Equivalent to `license = (facet == 'licence')`, right?
This should check for Sabre_CardDAV_IAddressBook
ok great

- CalculationValueUnitSpec checks that the getValue of ModeValue returns the right thing.
- ValueServiceSpec checks that ModeValue contains the correct ModePartialValue list
- ExpressionServiceSpec checks that the ModeMap contains the right stuff

all good!
Old proposals will not have an email, so check if it's not null/blank.
Or you could do 
`string <varname> 
{
     get{
          return Clips.Count + (Clips.Count == 1) ? " Clip" : "Clips";
     }
}`
Yes you are right. I will change this
Ah! I didn't realize they're refcounted.  Thanks! :-D
OK, because `fields` are not `mongoengine.fields`. :-) Yes, for mongoengine fields use `mongoengine`.

Have you checked if all this really works? `Comment` being referenced before the definition?
Why have require here if you aren't loading anything?

I'm really curious. Trying to figure out if similar issues in the other tests I wrote are what's causing some problems on test swarm
I really do not like this.

Let's explore ways to remove it?
So two things.

First, I changed this because if you use margin, you'll end up ++ing the height on a revert (invalid drop) because mergin in not included in ofsetHeight/Eidth. By using padding, we can get the value.

The other is I felt having the 1 px padding only on top made no sense. t is hard to notice, but it looked weird and inconsistent. By making the padding 1px all around, it overlaps the same. Much more consistent. The other option would be to not have any padding at all.
Can't this just be the generic border-radius?

Then again, I think we have a minor ticket sitting around to handle any of these that are sitting around.
As far as I know, nothing does now since I removed the one spot that used it previously in editors/editor.js
I think you missed this value -- should be -5% or something.
Very much a nit, but I don't think "Routes" needs a capital here ^_^
Thanks for reviewing. I agree that this is a big ugly. But currently I don't see how this could be handled correctly:

- CGUIListItem usues the enum GUIIconOverlay when you set the overlay. But there's no public function to get the overlay as enum.
- I could change it to use the play count values of the VideoInfoTag (like it is done in GUIWindowMusicNav). But I'm already working on the watched overlay for the recording subfolders. As soon as that is finished I'd like to remove the 'if (pItem->m_bIsFolder)' and only use the '.Equls("OverlayWatched")'. Because we don't have VideoInfoTags for folders.
- GUIWindowVideoNav btw uses also the '.Equls("OverlayWatched")' code so we're not using it more ugly that they do ;)
the problem here it that we have to know whether the timer supports directories or not.
an empty "m_strDirectory" isn't an indicator that the timer may be placed in a directory later on.
without this boolean we always have to find out the backend the timer was created on and then check if that backend supports timers in directories, ...
i think it's easier to add a boolean ;-)

nevertheless, i vote for renaming this to "m_bSupportsFolders", just to be consistent.
Did add a helper method. now page value is defined dynamically for every controller.

paginate_search can not be used due to a bug in acts_as_indexed

When using paginate_search you will get an variable undefined error . They are reporting it here https://github.com/dougal/acts_as_indexed/issues/23. A fix should be out soon we hope.
I don't think this line is necessary in a Given step.
if (clcf->ignore_file_error
                && (rc == NGX_HTTP_NOT_FOUND || rc == NGX_HTTP_FORBIDDEN))
            {
                continue;
            }

            return rc;
static -> statically
下一行对齐
good spot boss :)
I guess you have a point that there are too many people who would prefer to write AST:s Lisp style, and what is more, even more people who would have a hard time read and maintain their code. I'm fine with keeping `@sexpr` out of `Base.Meta`.
Could also do this as a higher-order function. We don't *have* to use metaprogramming all the time.
This is the same code as in function above. Can you put in in common function?
This whole file shouldn't have been committed. It isn't included in SignalR.csproj. This attribute was just an idea I was playing around with but nixed because it would likely cause too much confusion.
This check must be done in the preGroupAdd method of SambaLdapUser.pm. There check and throw an exception if the group name is not allowed.
This cannot be done. If ``value`` has been malloc'd  to have exactly ``len`` bytes, we're writing memory that we're not allowed to write.

The correct way is to make users pass NUL terminated strings for stealing (by documenting the behavior).
Same as below: use "changeCurrentFrame".
Just for clarity's sake, this is the input format, or the output format?

(Also, FYI, this is exactly the sort of place you'd use an `astropy.config.ConfigurationItem` instead of a class function)
@andycasey It's 160 mb not for caching the transformation but for caching the actual new coordinates. Erik Bray (et al. ) have written a little decorator called `@lazyproperty` that will cache output of the property after it has been computed once. 

@astrofrog: Anything is computationally expensive when enough data is used (I'm thinking here of `time` where the implementation currently is the other way around, as it was said to not be expensive enough to warrant a method). What is a sensible, but defining rule we could apply in general?
I assume these arrays can have any number of dimensions as long as val1.shape is broadcastable to val2.shape.  Is that the case?  Should that be made explicit here?
`riak_core_handoff_manager` ends up setting `#handoff_status.type` using a variable that is of type `ho_type()`, so should change this to be `ho_type()`. This would also fix the issue that `ownership_handoff` is what is actually set, not `ownership`.
It's pure pedantry - but this is a nicely sorted list at the moment, why not add after riak_core_handoff_sup?
Oh nice. I like that better.
No need to over complicate it. It was just an idea, but your way works just fine, especially considering that you're trying to preserve the config.
So everything fine here :)?
Do not make this check in the setModel function but in setNumBlocks. 

Background: in Qt, a model is assigned to a widget at most once (there are exceptions, for example when reading a new file and everything should be reset), so it must not make judgements based on temporary state.
What happens, if someone tries to feed a >2GB file to this :)?
This one broke MAX_PATH limits, which seems bad.
You don't need the else here.  You can just return when the if closes.
I've also created some tests in #127 which should help with that but I couldn't test all the cache drivers. Memcache(d), APC, Array pass this condition, Zend should too since it's based on APC and I'm clueless about the rest.
Curly brace should be on a new line.
not sure if github ate some char, but you should use 4 spaces indentation
Is it necessary to add mysql2?
yes, could be confusing. one is the type of the attribute, the other the allowed child types. i don't like widget though, its just the type structure, not any visual thing. what about ``childtypes``?
Which? I don't see, for me, all parameters is used. 
The wave and the detection radius are used in the files "teleportation" (in the client and in the server).
There are some trailing spaces here.
all the console.logging of errors should probably be returned to the client instead (or potentially both).  Some failures of ldap should be logged, such as we can't connect to the server.  Some failures, like an invalid password, probably shouldn't be logged.
can you move this to a method marked \@PostConstruct?  This will make a network call (pattern is that Suppliers shouldn't be called in ctor, as they imply i/o in injector wiring)
Should this be `> 0` rather than `> 1`?
ShareJS uses 2 spaces, not tabs.
```python
output = dict([line.split(': '), 1) for line in message.split('\n')[:2]])
try:
    output.update(('Message', ' '.join(message.split('\n')[3:]))
except IndexError:
    output.update(('Message', ''))
return output
```
Got rid of redundancy.
The margin makes a little bit of space if/when the buttons wrap to more than one line, which they'll likely do once it's localized.
Browsing through the file, I see that there are a bunch of other methods with `default='all'`. I think I'd rather leave that consistent and change the `update_top_contributors()` cron job. Although, I could be sold on changing all the defaults to '3m' since that seems to be what we are using as the true default. Thoughts?
FYI, those prefixes don't matter actually. You can use `foo` and `bar`. The only place where these prefixes are used is in `service_overrides`. Just fyi.
Not a great name of a class.
These variables don't appear to be used anywhere. Are they necessary?
what is ```{out:{inline:1}}```?

Is there something special happening with mongo here? I don't have any experience using it. For example, does it serialize the function to execute in mongo?
Error does not correspond to when it would be raised
That's because you [originally named it `$spec`](https://github.com/duckson/sphenic/blob/d31b6867dc6b2a87f06bd2ae0a88c2a4388a0150/application/libraries/Sphenic/Application.php#L45).
nice defensive coding
Off topic: one pattern I've had a lot of success with is temporarily changing thread names depending on what work they're doing. Very handy if you ever do a thread dump . . . thread names could be like "Retrofit: http://api.squareup.com/foo"
The method should be ``countDeprecations`` to be consistent with ``countErrors``
This is wrong. ``IN('foo,bar')`` is not the same than ``IN('foo','bar')``
This is wrong . For other errors, they are let to the PHP default handler instead of using the error handler configured outside the factory
I don't care for it either, but since matchCollection now has 2 arrays that it merges in I wasn't sure if I wanted to lock it down to just a single array.  That would essentially require forcing matchCollection() to merge its arrays and pass them in, and then the the new method merges that with the defaults.  Would splitting it up like that be better?
Was not a typo
it is really needed to add them here ? The gitignore file in the component should already ignore them, no ?
I would postulate they should not be using a shared folder for this. The code only scans for `sess_*` and the other alternative is to change the session file prefix.  I wouldn't silence here.
missing empty line (same below)
I think the check should be consistent with the condition set by the CollectionType. the form component does not consider Countable in a special way.. A better solution would be

```php
$this->modelData instanceof \Serializable && $this->modelData instanceof \ArrayAccess && iterator_count($this->modelData) === 0
```
Easier to catch because it would actually throw an exception as opposed to require an acking.
"render" implied (I believe)
写论文不是写博客，想要强调就给个粗体斜体啥的，代码段如果需要等宽字体，模板中也已经支持，其他的英文都应该使用Times New Roman，中文都是宋体，没有其他，更没有粗体斜体，我无法理解为什么你一定要强调这种需求，还放在了最开始
second "in order to " -> " and to "
I think we're going to have to be careful with this. Will every single new query parameter create a new metric? Do people want this? We need something like this, but we need to figure out the right way to opt-in to things/patterns that users care about.
There's a problem with removing PSI element this way. It looks like IDEA can't handle the region for update correctly. I'm going to debug and fix it. It can be reproduced with this chunk of code. After applying the fix idea shows errors in internal mode (with -Didea.is.internal=true in javac string).
fun test(value : String) : String {
  return value!!
}
Da warst du grundsaetzlich zu umstaendlich. Du hast hier und noch an 2(?) anderen Stellen extra eine Repository-Methode gebaut, die ein Update macht. Das ist gar nicht noetig. Einfach das Competition-Objekt, das du ja eh schon hast, aendern, fertig. Du wirst nur sehr sehr selten ein Update in einem Repository machen muessen.
Can't we just get the exact pixel dimensions from the figure?
I like the chain of `then()` calls more that `qq.step()`, because `qq.step()` is a single function call with a lot of arguments and I can't add `fin()` or `fail()` when I need to.
`no_method = op_params.except(:method)`
pull these few lines out into a common method?
moved to str_list_set.{c,h}
I thought of i_mimedata.py but then PyMimeData does not inherit from HasTraits so it cannot "implement" an interface, so ideas welcome.
I think you can simply do `obj.set(member.attributes)`.
Is this necessary?  Will it be redundant with what is done in kmain already?  I have no idea.
what's the difference between flake8 and pep8? does flake8 contain pep8 linting?
Curses. Yes, that's an accident. They're completely unused. Didn't have the IDE properly configured to remove them.

I'll close an resubmit.
So Robert added the for-attribute-update, the click handler was already there?

If so: I think he added it to fix screenreaders reading the button label, I guess the for-attribute is more reliable then aria-labelledby. With that in place, the manual click binding can likely be removed. Can you give that a try?
It was in iceaxe. Will make things more reusable in the near future. Would like to get this to master for now since cascades is now blocking builds as the companion iceaxe change has been merged. Thanks.
On 04/07/2012 17:45, Cristian Rodriguez wrote:
>>      */
>> -  drop: function(origin, target, dir) {
>> -    var icons = this.icons;
>> -    var onode = icons[origin].container;
>> -    var tnode = icons[target].container;
>> -    if (dir > 0) {
>> -      // upwards
>> -      tnode = tnode.nextSibling;
>> +  drop: function(origin, target) {
>> +    if (origin !== target) {
> ok, although I prefer having only one return per function instead of multiples return statements. But in any way I change it too without problem you know more than me I'm sure
I really don't! But I have found than avoid nesting helps to read the 
code (and since i'm doing reviews that's helpful ;))
we have no `.end` class yet in the `shared/` directory, do we really have to add one now?
I know that is a stupid comment :) but just for code beautify, can we add the indentation?
If we are not using 'ts_' anymore, why do we create inputs with this prefix?
Could we remove these 2 variables?
leftover from when I had code in there that *did* use it. I will clean up!
yay, this removes the old version's confusion about `publicKey` (which starts out being the previous-cert key, used to verify the signature on this one, then got shadowed to mean the next-cert key).
A matter of style - shouldn't there be spaces surrounding the predicates in this and the following if? At least in this source file the existing style should be observed.
pretty sure this breaks
See https://github.com/fnichol/Razor/commit/beab733eb855449f8c9d9f2da601bcc32e904715
You can tho this with plurilization. http://guides.rubyonrails.org/i18n.html#pluralization
Not to mention the memory... good catch
Added, two for one deal.
Replace this with `limit = query.limit() or _MAXIMUM_RESULTS`.
All inner methods were taken from the SDK.
In general, "from X import *" is bad practice as it pollutes the global namespace (ie, if two modules have functions with the same name, and you import them both like this, there is no way to tell those functions apart).

 It's usually better to import the module (like "import  JSONMaker") and reference things in it like "builder = JSONMaker.JSONMaker(makefile)".

If you are going to bring something into the global namespace, you should at least explicitly import it by name (ie, "from X import foo") so you don't import everything in the module.
Giving fuuka slashes for instance will fuck things up. I did go around that with simply replacing it with a _ but this is much more fail-safe in case I forget about a character.
nice line
The sentence continues on the 
next line.
For backwards compatibility, it might make sense to have `self.rotation` be a property that sets the `self.labelProperties["rotation"]`
`@regions.push {name, instance, selector}`
I think it was one of these: 3a895991c29b037f5dc8ae7f400f2aa2ced7f180 f07785503477e3837df9e74ea447de228978a05b

When git did the auto-merge there were a lot of conflicts, where the gles20 branch had a bunch of     ^M   added which is a carriage return.

I can go over my branch and batch convert all cocos2d-x files (and hopefully it will only be the ones "I" touched ;) ).
Allows pane switching via mouse, scrolling via mouse, copying via mouse.  Nice option to have
In order for these commits to work in languages other than english, these changes need to be replicated to those locales, there's no new translation, just a move / copy from config/locales/javascript/javascript.lang.yml to config/locales/diaspora/lang.yml , how should I handle that?
解释了~~
Where is linux-only condition?
NB that is quite silly from ipfw... heh heh... are you sure there is no way to make 'ipfw delete' more "specific"?

now I remembered that there was discussion on mailing list (look for " Fail2ban on FreeBSD") suggesting specification of a rule number...

my guess that ideally f2b should provide some <random_int> in a range set in some options of the action... or may be someone could figure out for a more specific delete ;)... let's boil it a bit
I think that if enableNewChecks is true and http_options.check is undefined, you should raise an error. Same for pings
What's with the `!`?
this should go into a configuration file in cob_hardware_config. Is there no way to set a parameter for that instead of args?
El 19/12/12 06:45, Bussonnier Matthias escribió:
>
> In converters/reveal.py:
>
> > +from markdown import markdown
> > +
> > +import os
> > +import io
> > +import itertools
> > +
> > +
> > +class ConverterReveal(ConverterHTML):
> > +    #"""
> > +    #Convert a notebook to a html slideshow.
> > +
> > +    #It generates a static html slideshow based reveal.js.
> > +    #The delimiters for each "Header slide", "Slide"", and "Fragment"
> > +    #are retrieved from the 'slideshow' metadata.
> > +    #"""
> > +
>
> Are the comment usefull here ?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/ipython/nbconvert/pull/69/files#r2461163>.
>

Maybe not, moreover it is imcomplete... maybe I have to reformulate it 
or delete it? What do you think?
I guess you use Windows. Fix your Git client to use NL not CRNL for all text files in the repository. The pull request cannot be evaluated until line endings are reverted.
esses unbinds tb ficariam melhor fora do if else né?
Again I wonder if Loader should just use this configuration as default making the common case to create a loader just `let loader = Loader()`.
This is not good enough as it breaks `browserWindows[index]` that works on desktop.
Also name of this function is very confusing. It does not removes anything it just checks if `value` is empty. I'd suggest to rename it to `isEmpty` instead.
Lets re-use one from [tab/utils](https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/tabs/utils.js#L50)
If that is on both lines, the first one should be able to be removed.
I'm not sure that in production it is safe to return an arbitrary exception message to the client; it's possible that could expose sensitive data (and impossible to verify that it won't without seeking out every possible exception that could possibly be instantiated in any of the above code). This is especially true for the `except Exception` below.
Yeah I am reluctant to build a whole toolchain around this.
probably past 80 chars? nicer to break it up into separate lines?
Oops. Yes, of course.  =)
@hkenney it might, I'm not a FreeBSD guy. If I understand correctly, different versions of FreeBSD will return different things for their kernels, (an older one might have been `FreeBSD` and now it's `GNU/kFreeBSD` or vice versa). So since they might be different versions, I think it's safe to assume that they might return different values for `zpool upgrade -v`. I think the two fixtures we have should suffice...
Why not validate here? Since here we already walk through the list of strings, now we walk it twice and that's probably more confusing.
Good question.  On the Drupal website, there is theming that looks like this: `#main td {}` which is affecting the sagecell td elements because an id selector is more specific than a class selector.  I figure that similar things might happen on other pages too.  That's why.
You only use the length var once in this function... why not remove the var declaration and do if (index == colors.length - 1)?

BTW, from a style perspective, I've never seen the double-surrounding space. I think the commonly accepted style is a space after controls statements and no space before function argument definitions.

Control statement style:

    if (myCondition)
    for (i = 0; i < something.length; i++)
    while (thisIsTrue)

Function definition style:

    function(arg1, arg2)
Why not first call is_subclass_of and return result if true or php >= 5.3.7 - It saves a version_compare if is_subclass_of returns true
Throughout the file, on conditional statements or loop operators:

- Remove spaces after the opening paren of a conditional
- Remove spaces before the closing paren of a conditional
- Add spaces around operators (including `=>`)
var name should not start with underscores
There is a old typo around here respository
You could probably use isEmpty() here
This probably should handle duplicated params? parse_url -> parse_str to get an array of query params already in the url, merge with the passed params, and http_build_query ->http_build_url to put it all back together.
Long term would we have this method be somewhere else and wired up by some sort of config or something. So there's not a "direct" dependency on GAE in the file.
Yeah, to me it looks like RUN_TEST is just doing display stuff similar to what you are already doing with Travis.
oh, looks like it does the same thing as ` `
`(1..31).to_a`
If we don't, we can have false positives. :(
Seems like this is not used anywhere?
remove if not defined
* Indenting is off starting here.
* "render" is unnecessary here
* Use new hash syntax
Enable it only if yasnippet is already activated:

    (when (and (boundp yas/minor-mode) yas/minor-mode)
Super unimportant nitpick: Single quotes.
s/fredom/freedom
> Are we sure commentable can't be a Chapter or something other than a Work or a Comment, at that point? Would being a Chapter cause any trouble?

That bit of code is only checking to make sure that <code>commentable</code> <b>isn't a comment</b>. It being anything else (Work, Chapter) is fine. Unless I'm reading the code wrong (strong possibility).
Yes was thinking of making the code clean with spaces, will add the test case as well.
Refer to http://www.w3schools.com/html5/tag_meta.asp.
so this only works with :has_many?
Yeah, um, too much python :p I'll fix it in a sec

On Thu, Nov 8, 2012 at 2:30 PM, brunoais <notifications@github.com> wrote:

> In jquery.sceditor.js:
>
> > @@ -320,7 +320,12 @@
> >  				.bind("beforedeactivate keyup", saveRange)
> >  				.focus(function() {
> >  					lastRange = null;
> > -				});
> > +				})
> > +				
> > +			// auto-update original textbox on blur if option set to true
> > +			if(base.opts.autoUpdate)
> > +				$body.bind("blur", base.updateOriginal);
> > +				$doc.bind("blur", base.updateOriginal);
>
> I don't think this does what you think it does.
> Try using brackets.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/samclarke/SCEditor/pull/34/files#r2069148>.
>
>
If any of the gems have changed (e.g 1.0 to HEAD upgrades Rails to 3.0.17) then you need:

    echo "Bundlizing..."
    bundle update

here
so you want to force powerdown when editing? isnt it better to allow editing only if its off?
.all is not required, just Location.count
Mind creating a pull request?
Yes, but that is specific to Zookeeper and should not be mentioned here.
Method looks like it's missing a bang `!` since it calls bang methods (`run!`)
input will default to type text if no type is specified. Remove that line.
It needs to be // Spout ;)
Coding-standards (CS) : 
  * please add spaces after the opening ``(`` and before the closing one.
  * please have the opening ``{`` on a new line.
Shouldn't you include the concatenated file?
Again - I think table,merge can be used
Instead of checking the url here, you should change it to check the page title.
can you capitalise gemfile as Gemfile?
capitalized.
I don't fully agree actually. This is about not having access to the content at all, not just not being able to manage it. I think we should return a 401 error when you have no permission to see the file, as we do when getting a piece of content, etc. We shouldn't be doing canManage checks on content that you're not allowed to even see, if only to avoid the potential security bus that could be caused by not returning an err.
And actually, here you need to be careful that the outer instance (i.e., ``ScalaJdiEventDispatcher.this``) also doesn't escape. The actor should really be started only *after* the ``ScalaJdiEventDispatcher`` was properly contructed.
I just reverted template:default and added template:dokuwiki and changed the info.txt accordingly.
When actually running inside TorqueBox, the fetch type does matter. While the Ruby side of injection / fetching will return whatever's in the TorqueBox::Registry, if you try to fetch a service by calling fetch_queue things may not get wired up appropriately on the Java side.
Extract the body param string building logic out to separate method and keep the post method logic the same.
Do not cuddle braces! See https://github.com/topaxi/nib/blob/master/coding-style.md :)
Because I'm always the one who forgets to add that comma later when adding another item to an array. I can remove it if need be.
Круто. Спасибо, не знал. Но по комментариям на стековерфлоу вижу, что компилятор все равно оптимизирует код и результат будет тот же, что с isEqualToString. Но на будущее учту.
Согласен, скорее косяк прочтения ТЗ. Делить 100/100 и умножать на процент посчитал лишним.
А зачем "заворачивать" в NSString? Лучше сразу добавляйте определённый объект массива arr.
А кто ж вам такое сказал? Вроде бы в задании сказано, что мы передаём процент, который нужно изменить. Следовательно, мы должны вычислить, сколько элементов мы должны изменить, исходя из процентного показателя.
I would not say this has a default of false since you're actually just checking if it is undefined, which is falsey. I would have no default.
My counter argument would be that a `BOOL` can have only one of two values, so the implicit comparison is clear, while a `uint32_t` can have any number of values.

I don't feel terribly strongly though.
Collapsed comment thread:

> Will this ever be nil? Should it be allowed to be nil?

It can be `nil` for synchronous or uncancelable schedulers, like `+immediateScheduler`.
`.toggleClass()` is shorter
Ah, now I get it! 
Fixed.
No need for `P` as a type argument ... just use `HNil` on the RHS. Also this one comes first, so call it `hnilPrepend1` and the other `hnilPrepend2`.
I think you have an indentation problem on this line (increase it) otherwise if you import from joblib you'll never fix the job=-1
also since you're at it, can you add a docstring to read_surface ? I did a sloppy job there...
```
gem.add_development_dependency("rspec-rails")
```

This should take care of the 'action_view' dependency.
This line won't be included in the QM file because it's not finished. Please fix it and push the changes, it'll be added to the pull request automatically. And while you're at it, could you please revert the changes to src/dvbcut_en.ts? Just checkout the old version before you commit.
I have just seen them now after making this commit. :)
I put this eviction in the if statement where a person record exists in the database but no patient.
So in other wards, for existing patients, this section of code will never execute.
Again, the leading $ might be misleading as this isn't a prompt.
Ah, that's correct.  This is the most pressing change.
maybe precise that the second argument is the class name of the service
如果想编译支持SSL的<registered>OpenSSL</registered>模块
=》
如果想编译<registered>OpenSSL</registered>，以及为nginx添加SSL支持
space after comma, none around equals
Síp, los ejemplos son para el pasado, no sé si aplica para el futuro: http://momentjs.com/docs/#/displaying/from/
You miss the point, it's all about entities and report
`login` parameter is missing
I think it was Bananeweizen or samueltardieu who mentioned before that the `.toString()` was unneeded and should be removed when encountered when changing code.
"should" in the example description is [no longer a good practice](https://www.relishapp.com/rspec/rspec-core/v/2-10/docs/example-groups/basic-structure-describe-it) I would reword it as 

    it "works with missing images"
It translates to a BadRequest 400 in the service exception map. I just wanted to make it less confusing
That was just a shortcut to aid while testing. The actual ispn-cli.sh script doesn't require this. Removing in the next refresh
+1, I've changed it to return an unmodifiable
I agree.  I wasn't sure how to do this. I was trying to register a component but I can't seem to get a working reference from Cache object.   Any advise on how to do this properly?  Thanks!
But its not so easy here - the reader is a spy (not a mock) and therefore your proposal calls real Reader.read(...) method and it throws NPE.
Are these need to be 32 bit integers and not uint8?
Shouldn't this be defaulting to False, rather than None?  Booleans are much more clear in their intent than Nones.
Looks like you missed something while resolving conflicts.  This means you didn't run the tests after rebasing.  Please run the tests to make sure everything looks good.  This may also impact the resulting test images because changes may have occurred to the rendering algorithms (line snapping, text anti-aliasing, etc.).
It now uses Committee.NumberOfVacancies
You probably want to remove the triggers and ContentTemplate as well.
+1 :-)

On Tue, Aug 7, 2012 at 11:10 AM, François Thillen
<notifications@github.com>wrote:

> In bridge/pom.xml:
>
> > @@ -34,10 +34,9 @@
> >
> >    <modules>
> >      <module>Interface</module>
> > -    <module>WsdlToDll/Domain</module>
> > +    <module>WsdlToDll/domain</module>
>
> Normally, I try to stay in the .Net convention but sometimes a small
> letter happens :-). I will try to get all to upcase
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/loom-csharp/pull/23/files#r1319225>.
>
>
But this change also means that if someone forgets to include v1_1.js of some OGC format in his build, he might get a fall back to a base class e.g. v1.js which does not make sense likely.
Should we not at least limit this fallback to the third digit in an OGC version?
Looks like maybe this file shouldn't be here?
It's there so you can unsubscribe when it's yanked! This looks good to merge.
@bp323 using `jQuery` would make sense if we were using `jQuery.fn.pager...` below.

Right now something like this will happen:

1. Look for the `$` in the local function scope
2. It won't find it so it bubbles up to the window object.

Instead, when we would use `$`, instead of `jQuery`, it would just be defined locally.

Most places that use `jQuery`, have the following syntax:

```javascript
require(['jquery'], function (jQuery) {
  (function ($) {
    ...
  }(jQuery));
});
```

[1] e.g.
* jquery.fileupload.js
* jquery.autoSuggest.js
* jquery.equalheights.js

or use `jQuery` directly:
`jQuery.fn.contentChange`
Rewrote the algorithm and added comments. Now there is less options, and they have been pulled out into LeftAndMain.js entwine field `LayoutOptions`. There is also API calls available:

jQuery('.cms-container').entwine('ss').resizeLayout({minContentWidth: X, minPreviewWidth: Y})
jQuery('.cms-container').entwine('ss').showContent()
jQuery('.cms-container').entwine('ss').hideContent()

When/if this API proves useful (we'll be using this for the preview options) we'll document it also.
Is this specific to one distribution? As a nginx noob, I wonder why that setting wasn't necessary before? Could you link to setup docs for PHP5-FPM?
"magic numbers" like this need documentation - why is it 10px and not 11px, for example?
Why are we passing values here at all? you're just matching the defaults, could use this instead:
```
customforms::get_custom_form_fields();
```

If you need to pass values it be better to match default values types anyway
```
customforms::get_custom_form_fields(FALSE, NULL, FALSE);
```
Great thanks. Yea figured this was written before some modifications to get_node_text()
Evtl. statt MVC-Prinzip, MVC-Patter.... Patterns, you know?
I'm guessing these are from dartlang.org? Maybe add a comment to that effect so we don't inadvertently diverge.
seems unnecessary...
CodeStyle
имена переменных с маленькой буквы в CamelCase стиле
Tässä voisit `count` välttämiseksi käyttää `my-some` funktiota:
~~~clojure
(not (my-some (complement pred) a-seq))
~~~
what is depending on yaml ?
I think that you always want to add the map guard and only return if !mapMethodsAccessible. This will ensure that if you later add the key that the guard will break and the wrapper will be reevaluated.
You can also just do `with open(...) as f:`.
Because, I was young and stupid :) Fixed.
Hmm yes, this is bigger I think. I only _know_ that user.connections _was_ `[]` somewhere in the near past and hope and assume it still is. This is not ideal and yes I agree, it is even less ideal if I am unsetting `connections`.
Yes, `id` field is special. Maybe name it then `stand_id` (or `station_id`), I am not sure what you decided to use.
We don't want to depend on browser features. If we want user to be redirected back where she came from, we should make sure we always have this data. And then it is not necessary to check browser headers for this.
I would not encode user feedback in the code. This is designers job to decide how to tell this to the user. You just set some constant and then check for it in the template. For example, here it would be much more user friendly to also provide a link to the page where user can set birthdate.
Aha, you added it to subject, not to content. ;-)
OK. You are right. In this context it does not matter if we override the previous value, because we will override with same content. So yes, we can check if value exists and if not, we store it.

Please rename `number` to `id`. And don't have number of stations hard-coded.
Not really sure what the intent here was. Is it just to inherit data form parent scope if set? Or to ensure new frame was created? Either way it never actually gets executed if you run this simple example and hence no data is passed.

The note below indicates that the correct usage is to create a new frame every time data is passed (i.e. every iteration of this loop) so I change it to do that.