labofsahil/github-event-dataset-2012 huggingface dataset:
In general I'm not sure EPSG codes can all map to unique Cartopy CRSs (at least, with the current definition). And an extensive translation could be so large as to make the use of Cartopy CRS instances prohibitive. But rather than try to engineer a complete solution to a problem we don't yet fully understand, we should keep it focused on the WMS specifics. NB. That could be as subtle as putting "wms" somewhere in the name of the translation dictionary.
about the declarations at top, there are some things that make sense in order to be consistent with the project style and "bitly style", even if I might not do that on a new, personal project
add a space please. Sorry about all the nit-picking but when we write in the docs we'll only accept PEP8 style code, we should only write PEP8 style code ourselves whenever possible.
test name can be simpler: "test_get_role_relations_roles_given"
Ooh, I hadn't read through the docs on that. That helps me in a few other places, too.
I'm sorry, I meant more the "type" property inside the WellKnownRecord. As far as I can see all WKR have a type and we could use it to automatically encode it.
My intention is generally to reduce the amount of duplicated code.
C'est une valeur non standard Safari/Chrome. (cf http://css-tricks.com/snippets/css/prevent-long-urls-from-breaking-out-of-container/ )
j'avais pas retesté sous firefox et je vois que ça ne fait rien car ça n'est pas reconnu par firefox.

je te referai une pull request pour firefox du coup.

pour tester il faut avoir un bloc de code markdown (1 tab ou 4 espaces)
Je me demande si c'est une bonne idée, ça va rentrer en conflit avec les gens qui utilisent le hashtag #search
This can be replaced by .addClasses()
I think this should be:

if (context.isNormalServer() && !context.isBooting()) {
Why are you changing the active tab?
@mikesherov Good catch, it's vestigial.  Will rm.
frameworks that does the filtering
                              ^-- typo: do
This change is actually unrelated to the merge request, but I think it's a small security improvement. 

No one really has any business looking at user passwords, hashed or otherwise. Feel free to undo this change if you disagree, though.
The content of the landing page is a part that the UX teams are thinking on. I'm going to enjoy my vacations this Friday during two weeks so I've decided to implement this basic landing page with the controller of gestures  to navigate among different pages: icongrid, landing page, etc.. So, another colleague, when the decision will be taken, could implement the content of this landing page. The idea could be to have the icon + a text field, but as far as i know we haven't web activities for launching the browser with the url  http://www.google.com/search?q=blabla or could we do this? thanks for your help
Anyway, even you make a mistake, you could easily adjust it later up or down. Not too far to the correct position I think, since we have already lots of dialogs working and they seems never get lost, living peacefully in the dialog layer(z-index=1024).
I would guess this runs the .load method on Event? If so we really don't want to do that anywhere.
Renamed to be more clear 'StoreLoad', will load a store.
Gives faulty values. Not connected to mobile data nor wifi, it gives back true, which is not acceptable.

From documentation of the function "So while you can assume that the browser is offline when it returns a false value, you cannot assume that a true value necessarily means that the browser can access the internet."
I wrote a minimalistic version of this code but I prefer to do like this in order to clarify what we are doing. Ok, I'll try to meet a compromise between code economy and legibility.
Just now, I have updated my B2G desktop and device, and try to remove +13px, but the scrollbar still occupys content-flow space.
Is the fix of https://bugzilla.mozilla.org/show_bug.cgi?id=770453 landed?

About the transition hack, I need to re-layout the <code>index.html</code> and modify the <code>music.js</code> to get rid of this hack. it will be better to apply these changes in another pull request.
un-prefix this
you can kill the starting ;
Nit: missing space, please make sure your patch passes `make lint`.
Fixed. Even though geeky search sound a great function :p
if (this_startTimes <= 1)
      return;
What about:

querySelector += (current == '#') ? 'und' : current

?
I'm not sure about the second one, it was there already when I started, so I thought that we need it somehow.
I'm kind of sad of having to expose those internal methods. What about removing those 2 methods and instead expose a |startSecureTransaction| and |stopSecureTransaction| that replace all you calls to WindowManager in TrustedDialog.js?
Shouldn't these be in the text too? What about RTL translations or something? Iunno.
Need to type-hint the receive-queue
If unset by a boot call #dhcp_mac remains nil. ERB templates validate whether to use the #dhcp_mac value.
Good question; I made my code look like the surrounding code; this use of one-off variables was an already established pattern by the time i came to work on the code.
JS does not need setters.
And this is where I really miss CL's keyword arguments... :)
I think you should change the `str(...)` to `true` as you did in line 209
Streams are awesome!
And on top of these,   3. We might want to clean up so that the codes are less fragmented.  Now, the "standard" consistency support is scattered across neural_datasets and v4toit..
This just seemed like a waste of a class.  Either make it static, or make it a private method in the JSON area (this is what i did).
Yes, I can. This change target was to make several projects from pear.php.net be available.
監訳ありがとうございました。
ご指摘の通りです。少し読み間違えました。
Well if you're on /from/zurich/to/chur this will point to a non-existing location otherwise
I'll look into it. :)
I think `<div class="citation">` should be sufficient.
Look like using `split` will work just as fine:

```python
>>> "\t\t\t foo    bar  \t   baz   ".split()
['foo', 'bar', 'baz']
```
This should probably default to '@fields'
In a8f9d2059538928badcd7d3b1f074c9a65dc1ec2 it's renamed to _compute_prices. As method not meant for calling from outside of class it gets underscore.
rename to save_watche_percentage_cookies
Not sure I understand. I don't plan to modify manifest format until cfx.js but again this `let path = requirer.uri.split(prefixURI).pop();` loader in a current state does the same. I don't think putting `module.path` is reasonable solution as it's sdk specific. Which means that we either do runtime path resolution or include uri to path mapping in manifest to
do a lookups as you have suggested. At the moment it's runtime. I suggested we could figure out what makes more sense while working on new manifest. Either way resolution function is defined in cuddlefish which we'll able to modify as we pleased.
I think this form is more correct, as it's descriptor of properties and not an array of property descriptors. Also we use this name in other code for such functionality so I'd rather stay consistent.
ah don't worry about it actually, I can manage.
Why do we drop local? (Not that I know what env did)
Will this pass back null or undefined here? Is it clearer to use null?
Is this already taken care of by user.checkEmailIssuer? If not, should it be taken care of using that instead of having two places that delete record.cert?
Hm, that's bad. I wonder why the SDK doesn't make use of the popup notifications you are using. Would you mind asking?
For comparisons please always make use of triple-operators.
This change make the tests fail. I'll try to see why and fix it when I have more time.
That rm_rf should probably be "secure"
Previously, the "download_plugins" was being called from within the "prepare" method, which seems more generic than the "get_facts" method.  Without understanding the life cycle of this class a little better, my immediate question is "Are the facts the only part of this object that rely on the plugins having been downloaded?  If not, it seems weird for this call to happen inside of this method.
Again, I think you can get by here with `@klass.send(:alias_method, stashed_method_name, @method)`--no string eval needed (unless I'm missing something).
@dchelimsky I don't really know the answer to your question. I'll try to do some experimentation, and if doing `Rails.application = xxx` works and doesn't have unintended side effects, then I think that may be the way to go.
Good point about adjusting multiple times, didn't think about that. But yeah, I think a light adjustment to the horizontal and vertical granularity (maybe 2.0 and 30.0?) along with a capping of the number of decimal places (5?) should be good.
Wann wird die Methode aufgerufen? Gibt es eine route?!?
This is how PureMVC apps define notification names which can be sent and received in various places throughout the app. Pardon me but the alternative - massive use of string literals are the anti-pattern. If you misspell one, your tools have no way of telling you about it and it is hard to debug.

-=Cliff>

On Sep 20, 2012, at 6:56 AM, Sindre Sorhus <notifications@github.com> wrote:

> In labs/architecture-examples/puremvc/js/src/AppConstants.js:
> 
> > +        APP_NAME :                 'TodoMVC',
> > +        
> > +        // Notifications 
> > +        STARTUP :                  'startup',
> > +        ADD_TODO :                 'add_todo',
> > +        DELETE_TODO :              'delete_todo',
> > +        UPDATE_TODO :              'update_todo',
> > +        TOGGLE_TODO_STATUS :       'toggle_todo_status',
> > +        REMOVE_TODOS_COMPLETED :   'remove_todos_completed',
> > +        FILTER_TODOS:              'filter_todos',
> > +        TODOS_FILTERED:            'todos_filtered',
> > +
> > +        // Filter routes
> > +        FILTER_ALL:                 'all',
> > +        FILTER_ACTIVE:              'active',
> > +        FILTER_COMPLETED:           'completed'
> Why all these constants? Massive use of constants is an anti-pattern.
> 
> —
> Reply to this email directly or view it on GitHub.
>
Consider moving this line below the actual writing of the headers so that the flag is not set until the work is done.
This is a fabulous approach. Just one thing to make it more elegant: take a look at this block of code: https://github.com/collectionspace/ui/blob/master/src/main/webapp/defaults/js/SearchTools.js#L204-215
Every renderer component has "prepareModelForRender". I believe this is the place where you would want to do your modifications to the model.
You can find the list of default formats here: http://api.rubyonrails.org/classes/Time.html under the constant `DATE_FORMATS`.

You can also add your own usually inside an initializer file:

```ruby
Date::DATE_FORMATS[:custom_name_here] = "%b %d, %Y"
```
You can probably use `URI.regexp(['http', 'https'])` here too.
Errr, why did we actually use "Mail" instead of Email ? I mean, it really is an Email, as in electronic mail... Should we change that ?
Then rewrite it as SRC_URI="http://psychopy.googlecode.com/files/${MY_P}.zip"
Here is how I would have written the whole thing.  Basically two changes: catch `AttributeError` instead of looking for `__dict__` (some day someone will have the weird idea of writing a subclass of `_thread._local` that will add the `data` attribute dynamically and that won't work anymore), and rename the attributes (that part is less necessary but to me `cls._transactions` holds all thread local transactions and `cls._transactions.local` holds one of these, that is, the thread local one).  If that is not how you see the whole thing then just keep your naming, I was just trying to wrap my head around it.
```
class LockingTransaction(object):
    _transactions = threading.local()

    @classmethod
    def get(cls):
        try:
            return cls.ensureGet()
        except IllegalStateException:
            return None

    @classmethod
    def ensureGet(cls):
        try:
            transaction = cls._transactions.local
            if not transaction._info:
                raise AttributeError
        except AttributeError:
            raise IllegalStateException("No transaction running.")
        return transaction

    @classmethod
    def runInTransaction(cls, fn):
        try:
            transaction = cls.ensureGet()
        except IllegalStateException:
            transaction = cls._transactions.local = LockingTransaction()
        if transaction._info:
            # ...
            return fn()
        else:
            transaction.run(fn)
```
Again, untested code but you get the idea.
@boegel  This is one of the fastest ways to implement this. see the link
I'd drop this
You shouldn't update classes inside a different function (even if it's an inner function)

Either supply it as an argument, or make a new dict for every call to add_class and update classes with the returned dict.
Unfortunately, I have no idea what this means, maybe @boegel knows?
why not set self.bindir here already?
The build section conventionally goes underneath the dependencies section and above the profile section.
You can delete this part of code (and above), no ?
using this method this way we have some false positives
we should use:
return self.is_element_present(*self._test_features_locator)
Isn't this in the main template? Why is it here now?
Remember that these will be displayed in this order. Do you really want `is_vouched` as the first column?
Okay, that makes sense. I think we should stick to expecting at least one digit at the start of a key to indicate a version number. We can always revise if needed. So how about:

    pattern = re.compile(r'(?P<version>\d+[^#\s]+)(#(?P<build>\d+))?')
Uhm, why this indentation?
Thank you for this information.
Will send a new pull request now.
Might want to also check for `null` because `typeof(null) === 'object'` - same with the others below
If self.from_email and not self.from_email_name from_ will still be '' and EmailMultiAlternatives(..., from_, ...) will fail

How about:

```
from_ = ''
if not self.from_email:
    from_ = getattr(settings, 'DRIP_FROM_EMAIL', settings.DEFAULT_FROM_EMAIL)
elif self.from_email_name:
    from_ = "%s <%s>" % (self.from_email_name, self.from_email)
else:
    from_ = self.from_email
```
Could you make a comment in the code about the 32768 part for future reference? (and also because I'm not sure why this is the limit, so I'm curious)
We probably could, but we may have to apply the cleanup to more than just title. I looked into switching back to RIS, but it also contains escaped special characters. I think I'll make an unescapeDocBook function for this translator, and if you want to, it can be included in Zotero.Utilities as well.
Please remove the extraneous newlines around this new method
Just recall firewall_list() which will display the list, instead of those four loops
How about prefixing this with "tasks" like the other logging routines here?
Please delete this line
The idea is that users should not be using `_wait()` to ensure that an assignment has propagated. Instead they should be listening to the `items_modified` event. Another reason not to make it public is that it would add another method difference between `AsyncExecutingContext` and `ExecutingContext`.

However if it turns out we need to use this method often outside the class we should make it public.
No direction info for en?
Not tempted to rewrite the entire test suite in unittest? Are you sure? Honestly?
Do even use this stuff? Is there a case for deleting it?
My strong personal preference is not to use web.config variables for this. 

Web.config is good for when the end-user of an application is configuring things, but not a development user who is consuming a library. I'd rather have config via the WebActivator App_Start\SwaggerNet.cs file, and if the developer implementing the library wants to use web.config values, it's up to them to wire that up (and more importantly, make sure that their web application uses it throughout).
unfortunately `_` is a super useful library, making it a bad throwaway variable. In this case you can just drop the second parameter
Code formatting [alphabetizing of CSS property names]
Sorry I have run this again and it looks like it was a focus issue causing the test to click on the wrong element and end up at the wrong page.
(was going through it with stephend on IRC) There was a test failing due to stale reference exception. The original locator found the frame with the paypal "loading ..." page, but the subsequent is_displayed was failing with the stale reference since the frame reloaded with the final contents.

Then final contents have an image (in all the cases logged in / out), thus the new selector.
no spaces around params
no closing / needed for tags
does connecting have a real cost? delaying it might be worth considering if so
It is normally nicer to use #if !(foo) instead of #ifndef foo, since you can explicitly enable/disable it.
See http://paparazzi.github.com/docs/latest/stylec.html
That is a good plan: you should at least handle the various file-system exceptions in `dequeue` differently from exceptions during submission.  Otherwise a single faulty message (eg: `chmod -r`, or `chattr +i`, or `chown root`) will not only block the queue forever, but will be potentially unremovable, and multiply delivered.
See https://github.com/resolve/refinerycms/pull/1649
/sContribuite/Contribute
The same logic applies here.  `rspec-puppet` should not reach deep into Puppet to build a compiler instance.  Instead, it should use `puppetlabs_spec_helper` to obtain a compiler instance in a Puppet version agnostic way.
If the first one evaluates to false, the second will be used. I just confirmed this in the Chrome JS console.
This is probably not necessary as it should be server by the tenant config service
Using `comm` now.
It looks like there is already a createUser function that is publicly exposed. Would this ever be used, as it doesn't associate a login id to the userid.
If tenant admins are allowed to do this, they should have controls to do it.
Editors can hang around to old instances of the compiler, and won't be cleaned up unless the user types. In an "exploratory" phase, you can easily have tens of editors open. I had a heap dump last Friday with almost a Gig of RAM in SourceFileEditors.

As a rule of thumb, I think any cache should use weak references.
You can simply delete this line, no need to keep commented-out code. We can always look in the revision history and recover it if we need it.
string should be lowercase
should be `providers` with a `s`
I think this check is wrong. 
It's a unexpected behaviour in the `GuzzleHttpAdapter` that's needs to be fixed.
Is this stripping the line feeds from GlobalAssemblyInfo.cs somehow?
Не обязательно, да. Он уже объявлен у NSObject. нам нужно было бы самим писать свой метод init, если бы у родителя его не было, или если у нас самостоятельный класс, который ничего ни от кого не наследует.
мне в условии привычно хотя б один знак сравнения писать(такое соглашение на работе, например)
phpdoc would be nice :)
Please use boolean values.
It looks like that the count of the Iterator is not the real query cursor. But if I count the result its ok.
Missing whitespace between `if(` and `){`, as well as a few other places in the tests.
Want to get rid of the commented code?
Guess you're right. Somehow we need to express, what the method really does on the user side. Any idea?
files under the ".idea" folder are specific for WebStorm and should not be included in commits. Also, those files should not be tracked, so you need to stop tracking those files.
no need for any of these lines.
As in the purpose for the commits? Or why I created a rails4 branch?

If its the purpose of this push, I was getting StrongParameter errors and was unable to create/update registrations on a Rails 4 project as of now. If its why I created the branch, its purely for my local dev purposes, this was meant to go in master for compatibility with 4.0.0.beta
The Scala doc is missing.
Added JavaDoc fb4b5d8462ca6b39593af28aaa482f541396ea96
For an example of usage look at its UT, TestIndexRuleTest
typo here `May`
typo here: ``get``
Replace "entity" with "model".
hello @stof , @weaverryan ,

I'm always happy to give some time, but I'm quite busy lately. 
Let's refactor into some new sections :+1:  !
如下指令配置
=>
如下配置
对象
状态记录
Why is this necessary? The cert is properly signed by a root authority.
also it looks like this is duplicated?
No, sorry. It's just specified inside the Omniauth documentation and I just copy and pasted it. (I'm a bad programmer...)

https://github.com/intridea/omniauth
Although coverage is transmitted in the result event now, it changes so that it may transmit in a complete event. 
i think it's better.
You can use `symbols(cls=Wild)`.
Seems that an `assert` is missing here.
Please could you add docblocks here too?
It is needed. To let the system gossip enough. Could perhaps be cut with 10 sec, I don't know.
But I have tagged all these long running tests with a tag 'long running' so they are excluded by default you have to run: 

    sbt -Dakka.test.tags.include=long-running

to run them
à quoi sert cette propriété ?? Les données d'un record sont directement mises dans des propriétés de l'objet (et ces propriétés sont déclarées dans la classe générée par jDao, héritant de jDaoRecordBase. Le setter et getter sont également inutiles
Good point. I've never really thought of it that way; this is a mistake that I make a lot. Anyway, good tip! I'll fix this.
OutputMultiPath for the outputs
Ты уверен, что const T*& - это нормально будет?
should load partial

```haml
= render :partial => 'pic', :locals => { :size => :large}
```

```haml
.pic
  %div{:class => size}
    = image_tag ....
```
You can 'set' the theme, using the ThemeManager, but not 'get' it. I added the property ThemeIsDark on line 47, and set it on line 41, as I needed a way to check (in my own code) whether the theme was dark or light. That feature was missing, and I figured this was a simple and clean way to do it.
Yes, I forgot to remove manage-orgs
Nice use of a hash here! I think that's exactly the way to go. Here you are really retrieving the key from a value (Monday being the key, 1 being the value).

Instead, maybe try:

```
  days_of_week = {1=>"Monday", 2=>"Tuesday"}
  puts "Pick a day of week: Use 1 for Monday ... 7 for Sunday"
  user_pick = days_of_week.fetch( gets.to_i ) { puts "sorry, not found"}
```
@matzew You need api Level >= 16 (Android 4.1, 4.1.1) to compile and api level >= 10 (Android 2.3.3, 2.3.4, ...) to run device/emulator
No, because the compiler will in any case raise the "out of memory" exception of line 255, without even trying to use this address.
can you do a second var declare here. we recently switched away from multiple assignments to a single var statement. due to @cowboy 's concerns.
rather than slowing down the process for such a minimal change, I've merged it as it's correct and solves the issue.

If you think you agree that we should removed the log or move this logic into the _logAsError_ variable, that can be a different push.
Shouldn't this be at least debug, like the other log you added?
I'm wondering if suspend is the right thing to do here...

You seem to suspend the transaction if an implicit, per-op, transaction is used. The problem with suspend is what happens with transaction eventually. IOW, what happens with a transaction that's suspended and never resumed? You would not want any exceptions to suddenly appear in the log...etc.

A rather optimistic commit if the submit call works fine might be better?

If the intention is different, the suspend has to be followed by a resume at some point.
it relies on both serverList and connectionPool to update the transport count, so a lock on the invariant is needed (see my comment on the invariant below).
How do I retrieve the list of available sites ?
Wouldn't moving it in 5.2 cause problems ? I'm thinking about a JDBC cachestore containing serialized InternalCacheEntries containing serialized CacheValues that need deserializing.
The factory closure get the app as parameter: 
`function () use ($app)` -> `function ($app)`
Derp herp, welcome to my morning comments.

Ignore me!
Making `colormaps()` return a list of colormaps seems pretty logical to me.
Shouldn't this be `log_base ** -1`?  (i.e. 0.1 only makes sense when the log base is 10).
Please indent the continuation line(s), preferably by lining up the LH quote marks.
I would change the comma in the second line to a semicolon, and end with a period.

Rather than cycle through self.axes twice, why not move your axes calculation below up to above
the "no_go" line, then change that line to "dangerous = len(axes) < len(self.axes)" or something like that.

Maybe also change "axes" to "subplot_axes", to make it clear we are not operating on all axes.
I noticed this and nabbed it in a later commit, but didn't have time to perform git surgery.
This close button works for desktop, but might be cumbersome on mobile.  Ideally we would want to show or hide it via platform sniffing, but for now lets make it optional using an attribute setting.
these 3 if's can be reduced to 1 using &&
`if-not` in [updated commit](https://github.com/reddmetrics/forma-clj/pull/193/files#L0R82)
This should call oae.api.group.getGroupMembers ?
@arnodeclercq I would go ahead and use @media on the bottom of `sakai.base.css` so we can avoid the extra request.
We deprecated the use of .live and .die. Instead we use .on. Can you take another look and see what was wrong with it?
@dooremont These properties are probably the same in the English version, so they should be removed.
Please use latex notation there
please use SG_ADD instead
Please note that `encodedKey` also should have spaces replaced with `+`.
I agree on the doc block for available, but then there really is no need to do that here, since the first call is to available anyway.
Are you sure ``$requiredLocales`` has the correct type as ``*`` is not a sub-type of ``string``?
Are you sure the class "Zend\Mvc\InjectApplicationEventInterface" actually exists, or did you maybe forget to add a USE statement?
Would be good to clean up these commented out lines.
Do you mean getDefault?
you don't seem to use the environment there
We definitely should be doing this stuff.
it's now on the link to allow to show it on mouseover on the progress bar... I'll check this tomorrow.
I mean if it is an ascii character, then how are we mixing it with utf-8?
Isn't it strange that you would be checking for validity of field in a method called `form_valid`? Obviously you are doing something wrong. :-)

Checking for valid password should be done in the form. You should pass `request` to the form so that in `current_password` clean method it can be checked.

http://stackoverflow.com/questions/1057252/how-do-i-access-the-request-object-or-any-other-variable-in-a-forms-clean-met
i create mongoengine.DateTimeField and  mongoengine.DictField and insert into DictField an object like
weather:{
    'forecast1': {
       'from': xxx, 
       'to':  xx,
       'temperature': xxx,
       'wind': xxx,  
       ...
    }
    'forecast2': {
       'from': xxx, 
       'to':  xx,
       'temperature': xxx,
       'wind': xxx,  
       ...
    }
    ...
}
???

for symbol there's timespan for 3 and 6 hour. should be both saved or just one?
i meant  that where is weathericon data there is no wind, temperature and other data. i would simply merge all data and take    one with shortest timespan.
You should move this to JavaScript, some global variable. And initialize from there.
Forgot to remove :S Removed.
Added todoTODO.
How should it be done if this is not ok?
Furthermore, have the order of args in the script tag the same as in base.html file (first src, then type).
OK, it doesn't complain :-) In what format field open has to be stored, since it's boolean? If I use int, I get validation error.
I'm sure it would work perfectly if you provided a template. Not sure what's the difference between '' and 'some_text'.  I think there would be much debugging needed to find out what happens in background.
Unnecessary space after comma.
Bounds are in both directions of the same size?
I have just noticed that and have already change it.
The prototype changed. The pointer is missing in the new version and the compilation fails.
pkcs11-display.c:738:1: error: conflicting types for 'lookup_enum_spec'
pkcs11-display.h:64:13: note: previous declaration of 'lookup_enum_spec' was here

Have you tried to compile the code before committing it?
Now fixed in c20cd128097953550ac1ef762b0988735c657d6c
If you're using PHP 5.3, it _should_ be installed by default...
`$this->shouldBeEmpty()` will work too! It's one of cool *phpspec2* features. ;)
I think we should use it here, I'll merge it after that change. Thanks!
I think this is a more complicated issue than we're ready to deal with here.  I'll add it to the issue tracker, but ignore this local instance for now.
These days when we are using bundler I am thinking as an another option should we just remove the rescue fully?
No és una doble negació això?
I tried removing this definition section, but it doesn't work without it. It needs the type of `identityClassName` defined as `false`, but once I put that line in, the DI seems to ignore the type hinting for `objectManager`.
could be rewritten as

    return isSameTable && Arrays.equals( keyColumnNames, reverseCollectionPersister.getKeyColumnNames();

getting rid of the _if_ and the _matching_ variable
If you both agree, that's fine. To me, it looks more like a trick to beat the competition is naive tests :)
lets try to not change whitespace only.. makes reviewing and merging more complex. (next if line and the foreach line)
capitals will not pass... but as far as i remember, every mac in PF is lowered... or is it?
I don't have any objection to that. I think that's an AP style rule.
`s/ARGV\[1\]/.`

(regex pun, remove ARGV[1] and just add the dot)
Please bare with me, it's little hard to aggregate comments from multiple different sources (threads you commented in).
`window.messages`.
Yeah. Last minute untested changes always catch me out ;)
How about some curly braces around the if-block? :-)
Thanks. I'll fix this and the paths. You don't need to open another pull request.
Add a sentence to what multicollinearity is
You're right.  Change made.
Forgotten debug statement?
After talking to @KL-7 about this, I'd be fine with removing `KeyPath` and just passing around arrays - it makes sense because the names of the variables with key paths are clearly named in most cases, eg. `@base_path`.
Indeed, unfortunately, because the count() method of the PersistentCollection now needs to actually fetch all the matched results to return the actual count of the Collection.
Looks like git has trouble with changing filenames where the change is case only.  Had to use a workaround as stated here:

http://code.google.com/p/msysgit/issues/detail?id=228

which is to rename it twice with the first being a temp name that is not just a case change.
Maybe it is better to reuse bho and call ```.reset()``` here. This way, we don't reallocate a new byte-array at each serialization.
Who's PUT'ing?
Great! Thanks for renaming key to keydown! Makes it much more clear.
Hello Rene,
please remove this :-)
If you are using a constant such as 3, it would be good to know why exactly 3 and not 2 or 4.
It used it as an example because I converted the signature of method to 

 public ScriptHelper prepend(String... lines){
   
Will delete the method.
Could we use a file-based URL, so can run the test on the plane/train without internet?
I think the javadoc needs to be made clearer, particularly around what "brooklyn will take control" means.

If destinations are not set, then brooklyn will auto-generate a path to use for the certificate/key.

If sourceCertificateUrl/sourceKeyUrl is set, then brooklyn will copy that to the path specified by certificateDestination/keyGeneration.
One can set the field order in xstream:
http://xstream.codehaus.org/faq.html#Serialization_sort_fields

But it doesn't look like particularly pleasant code ("This will not affect any of the type's super or sub classes. If you skip a field which will be serialized, XStream will thrown an StreamException during the serialization process.")
Is that readable as in "you can say the exact words out loud and it passes as english" or "easy to comprehend."? I don't particularly value the first, and don't know that either is much easier to comprehend than the other. 

`is` is still harder for me to read than `==`, but I suspect I would quickly get used to it. There's a decent chance we'll be switching to `is`.
CS dictates that the { should go onto the next line).
Those are only evaluated once, when the module loads, right?

The issue is that most of the tests assume the normal django user model, but the custom user model tests use mock to temporarily change `AUTH_USER_MODEL` to point to `django_browserid.tests.models.CustomUser` to test if the authentication still works with a custom user model correctly.

By the time those tests run, `auth.py` has already been loaded and would have set `BrowserIDBackend.User` to the default User model. Changing the setting would do nothing, and the test fails. This way, the new backends created for the test pick up the setting change and use the correct model.

In production, it never changes and this code is superfluous, but at least it lets us test if it works! :P
-1 this, let's leave the whole stack trace intact.
A wrt folder is still needed at the .webinos level as this is where the
webinos_runtime.json file is stored. This file tells the renderer where the
PZP is running (i.e. the ports and the folder location).


On 13 November 2012 10:42, Habib Virji <notifications@github.com> wrote:

> In webinos/core/pzp/lib/session_configuration.js:
>
> > @@ -322,7 +322,7 @@ Config.prototype.createDirectories = function (callback) {
> >          if (!fs.existsSync(self.metaData.webinosRoot))//If the folder doesn't exist
> >              fs.mkdirSync(self.metaData.webinosRoot, permission);
> >          // webinos root was created, we need the following 1st level dirs
> > -        var list = [ path.join(wPath.webinosPath(), "logs"), path.join(self.metaData.webinosRoot, "wrt"), path.join(self.metaData.webinosRoot, "policies"),
> > +        var list = [ path.join(wPath.webinosPath(), "logs"), path.join(self.metaData.webinosRoot, "wrt"), path.join(wPath.webinosPath(), "wrt"), path.join(self.metaData.webinosRoot, "policies"),
>
> bit not sure about this - > path.join(wPath.webinosPath(), "wrt"). This
> will create folder in .webinos. Is that needed. As you are trying to read
> getWebinosPath() it returns .webinos/pzp/wrt.. Probably this is not needed.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/webinos/Webinos-Platform/pull/292/files#r2108246>.
>
>
Yes, but check it. Is is there? Because if it is, then we cannot change to `10s`.
This will break in the near future (with mozbrowser windows seeing themselves as toplevel windows) so we need to figure out a better way of notifying the parent than the window is ready. That's fine for now.
I think you replaced the space indentation for tabs here.
We should probably keep the space indentation (as discussed in class and [here](https://github.com/w7cook/OpenBook/wiki/Coding-Convention)).
You need the "2".
Зачем переопределяется метод, если он возвращает то же, что и родительский метод?
I'm not clear why surefire is being told to skipTests in this POM. There are no tests in the quickstart so they won't run anyway.
You need to add a `ok(false, "This should not get executed")` if you want to correctly cover your code path (as it is, if there's no exception, the test won't fail).
Different function name to property name
missing whitespace after ,
It's more visible this way
A space between these computed properties would make it easier to read.
Use .. note:: ?
Reference a paper, if possible
variabel -> variable
whitespace before ``:``
cool - I didn't know ``choice`` - one still needs to do a fancy indexing later to create the sample mask but it should be preferred over ``random_sample_mask`` because the latter needs creates a random array of size ``n_total_samples``. There's just one downside - it has been added in version 1.7.0 - I still have 1.6.1... what is our min requirement?
Je te laisse libre de décider.

----- Mail original -----
De: "pbrunet" <notifications@github.com>
À: "serge-sans-paille/pythran" <pythran@noreply.github.com>
Cc: "serge-sans-paille" <serge.guelton@telecom-bretagne.eu>
Envoyé: Samedi 3 Novembre 2012 13:18:19
Objet: Re: [pythran] [gmp] Add mpz support for long usage in python (#21)



In pythran/interface.py: > @@ -44,13 +43,15 @@ def extract_constructed_types(t):
>          return [ pytype_to_ctype(t) ] + extract_constructed_types(tkey) + extract_constructed_types(tvalue)
>      elif isinstance(t,tuple):
>          return [ pytype_to_ctype(t) ] + reduce(lambda x,y:x+y, (extract_constructed_types(e) for e in t))
> +    elif t==long:
> +        return ["pythran_long_def"]
>      else: 

J'y ai pensé mais ça ajoute un python_to_pythran pour chaque type dans ce cas alors qu'ils ne sont pas utile pour les float ou int par exemple. Après, le python_to_pythran ne fait rien du tout donc on peut en effet les appellé, c'est juste qu'ils ne servent à rien et le code est un peu plus beau. 

— 
Reply to this email directly or view it on GitHub .
it seems that this method doesn't actually settle the bills, but returns the transactions needed to settle the bills, which is different, I would rename this to something different.
this is not the right thing. It will not work properly (add some unit tests loading a file with a whitelist containing 1 element and with a whitelist with several elements and you will see it fail).
This is an prototyped array node, so it should simply be a direct child of the config appearing many times (to be consistent with the other places using it and avoiding a hack to remove the extra level when coming from XML), and then using ``->fixXmlConfig`` in the Configuration class (which is needed as XML would give us a different result for a single element or a collection of elements so we need tell the processor to take care of it)
You are faster than fast :), I pushed a new commit
This will be done in a later PR.
Add ipad as well, same for the 2 other ones above
We could do get rid of the ubuntu user a little earlier in the process.
But what we get might be a little too magical to be comfortable with it.
- ubuntu vanilla cloud VMs boot with a user that name is ubuntu. if you download the tar.gz of the cloud image, you will see it there.
- we can run a custom script when the VM is booted by EC2.
It is run by root and it could transform the ubuntu:ubuntu user into a vcap:vcap user

```
usermod -m -l vcap -d /home/vcap ubuntu
```
Same as above for scripts. In the head, it's `head_js`, at the bottom of the body, it's `body_js`.
That is the idea - I will clarify with a comment.
Yes, it was changed a couple of commits ago (see CHashTableRowTable::init)
It will shrink back to requested size if difference above threshold.
Indeed, not sure what I did wrong. I probably compiled the wrong tree...
It would be worth having a type.elapsedSecs() to avoid a double divide as well (although not so significant as above).
>Don't you need to call init on hashtables 0..numHashTables-1?

with a max overall size of ~6MB, I think it's best to initialize them all upfront. 6MB is a low enough threshold.
It lessens odd effects (early spills) when memory is tight (on 2nd+ phases) and it's starting off.
Now that the HT's are reused, HT low memory threshold is more stable and more functional I think.
Can you break this up onto multiple lines too please. 

(I know it was crazy long lines before but it's time to upgrade from that past)
This method appears to differ from the core implementation simply in which URL it fetches.

Is there a reason why that functionality can't occur in `process_enclosure`? eg.
```python

def _get_enclosure_url(enclosure)
    if IngestOptions.USE_LOCAL_TRANSFERS:
        enclosure.href.replace(IngestOptions.URL_BASE_TO_REPLACE, \
                               IngestOptions.LOCAL_SOURCE_PATH)
    else:
        enclosure.href

def process_enclosure:
    ...
    datafile = Dataset_File(url=self._get_enclosure_url(enclosure), \
                            filename=filename, \
                            dataset=dataset)
    ...
```
you will need to install the redhat-lsb package earlier in the build process for this executable to be present on Fedora 17. It may be installed by default on Fedeora 18, but on Fedora 17 it will need to be installed.
This should read common_package_name, not just common_package.
You could add a 

```ruby
devel do
  url 'http://downloads.sourceforge.net/project/pmw/Pmw2/Pmw.2.0.0-alpha/Pmw.2.0.0.tar.gz'
  sha1 '88cd160c32617a2da1b06d567710336156ac0a71'
end
```

I have not tested this url and install. But perhaps worth a try. `brew install pmw --devel` would use that then.
We could use plain structs in the internal implementation. But, it's nice to use typedefs in the external interface.
That is very true and a much better fix.  I think I must have just followed the .removeClass just before it...but your way is a better approach
Yeah, you can call `artwork.render_artists_inline`. More generally, padrino has a core extensions `Array#to_sentence` that joins strings with commas and a final 'and'. Still think that the popover would look nicer with the artists as inline tags, but up to you
Yes the image size will remain the same.
You probably wanted `map` instead of `apply`.
yep, as many instances of the class as you like; they'll all run as long as they use different ports

i have added this to the start method to explicitly
See PEP8.
Where is parent_conn defined?
I think you should test for validity of the returned folderId before appending to the list.
Also the version does not need to be here because it's specified in the gemspec.
I don't believe the site owner is part of `.admins` on most sites.
We should be able to do this instead if the config is correct:

    $rzr = "${directory}/bin/razor"

    exec { "gen_ipxe":
      command => "${rzr} config ipxe > ${tftp::directory}/razor.ipxe",
      creates => "${tftp::directory}/razor.ipxe",
    }

Not sure the best way to keep this up to date if razor config ipxe changes but this should be ok for initial config.
when is this required? Isn't this always run on the same node as the keystone server which includes this as a dependency?
In case of exception maybe you could raise it, so you don't need to use return codes anymore :)
From my testing, I can say that the wab.exe + mailto:// or ldap:// trick works fine on WinXP, as long as outlook express is there and registered to handle such URIs. On Windows 7, JRE, then the j2plauncher.exe is one way to avoid the user prompt warning and achieve code execution. I am unsure if there are other ways to avoid such warning in Win7.
I can definitely add an extra routine to check if WinXP, then do the wab.exe trick or go for the Java one.
Regarding WBEM, the trick didn't come to my mind, cool stuff, thanks for that. In order to work, my understanding is that the browser would need to write in: %SystemRoot%\system32\WBEM\mof but that's a priv operation so I will prob opt for the double check between WinXP and Windows7.
What is all this about?
Just returning if somehting fails while getting output? It will make the exception handling on run_host method to fail
Well, for this use case yes: I find that the small feature given to the user (like writing ALL instead of all) is not worth additional boilerplate code. Did you get a different opinion from other people?
`if`-block unnecessary? By default, the seed to `RandomState` is ``None``, so the `else`-block should cover all cases.
I'm not normally a fan of having code across two lines but for these matchers I really prefer it for readability.  Maybe we can use that syntax in the controller specs as well?
You know, I thought that you had to have two spaces between everything after imports, but PEP8 itself doesn't necessarily say this, only that it should exist between top-level classes and functions. Carry on!

/me changes his habits accordingly.
nit: pep8 wants two lines before this
I usually put all tests that throw exceptions at the bottom of the file, but I'm not sure that needs to be standard.  Having them all at the top is OK I suppose, or even interleaved throughout the file so all tests for a given function - including those that test for thrown exceptions - are together.
I don't know, will try and if worked fine will remove it.
Good point, let me take a stab at this. The order is not important in this case but this can certainly be improved. I'll push a suggestion. Thx!
そうなんですね。`bubble-wrap/all`で全部読み込まれると思っていました。

https://github.com/rubymotion/BubbleWrap/blob/master/lib/bubble-wrap/all.rb

coreとhttpもallで読み込んでいるのでcoreとhttpを読むだけのbubble-wrapはrequireしなくてもいい、
という理解でいたのですが、何かまずいですかね。。
Need to list Mobile Web alongside iOS
Is there a reason why we are using the Boolean class instead of the primitive boolean type?
This removal worries me, because it changes the behavior in an unexpected way: it means for a 90 pixel tall area, it no longer falls down to 2 rows of 33 pixels, but insists on keeping 3 rows of 33 pixels. There must be a more elegant solution.
Leading spaces on this line and the next.
I forgot the default width is FILL, which is a problem. This means that if you set the width to SIZE, it will actually be set to FILL. Either you need to change the default width to a pixel-based unit (most likely breaking parity in the process), or you need to return a different, hard-coded value here.
Actually, currentSuite and currentTest are defined as part of the startTestPass() function which is why an error does not occur in that use case.  Regarding a no test dummy response - I don't think I would want to return an error just cause a test isn't found since that technically isn't an error.  Thoughts?
why is this rule 7? This is a for statement, not if :)
pitch() and yaw() look very similar. Does it make sense to refactor to use a helper function?
do we need to add this to our repository? can't we download it as external dependency?

this would solve licensing issues.
space before your brace
El None en realidad no agrega nada nuevo, pero lo agregue para claridad de la API nomas
Artifact from when it had more than one argument. I usually try to remove them, but I guess I missed them.
nitpick: the sentence should end 'etc.' with one full stop, even though 'etc' is an abbreviation. ('etc..' is also repeated below once).
"R" is the unqualified range type.

The current type is Cycle!Range. Cycle!R while probably assignable to and from Cycle!Range, may not match in terms of type.
I think we should define this dep in the parents section
Why don't we want to wait anymore until the encounters are also queued?
Yep it would be nice to have this file as Intellij allows you to export the code style scheme settings
IMO, it's better to use the variable `num_today` than relying on the parent view to have a `@num_today` available.
Can you please not use `from X import *`?
It makes it hard to know which symbols come `X` and to learn a new package.
Und mit dem setzen einer Bewertung $this->auto = false setzen....
I wasn't anticipating putting the avatars in the database. Just wanted to indicate that they needed to be cached.

But, yes, makes more sense to move this out of the model and take advantage of UIImageView+AFNetworking
Стали появляться магические числа (здесь и в строке 110). ПОЧИНИ.
ah I see, well spotted.
No, that was just an artifact of copying from Caret's postgres wrapper bundle. Fixed.
dismax isn't set as '-' anymore
ditto these two
nit-picky but I would prefer the adjective before the noun, e.g:  receiveCorrelatedReplyMessage(..)

even more nit-picky, I would swap the last 2 args since they basically represent 'key' (correlationKey) and 'value' (messageCorrelationIdtoMatch)

final nit-pick, is it necessary to include "message" in that arg name?... or even in the method name?