labofsahil/github-event-dataset-2012 huggingface dataset:
Henrique, obrigado pelas traduções, mas você precisa muito ter mais cuidado com a acentuação.
Levei um bom tempo para revisar suas adições porque tive que corrigir problemas de acentuação em todos os parágrafos.

De qualquer forma, obrigado por contribuir.
I should really remove `Category` from `Category.table_exists?`. I'll do this to the next commit. Thanks.
Could you please add there some comments to this import why it is there and what issues it could cause not being there?
make sure to keep your indentation consistent. It's a minor point, but still important
Vérification dans le dispatcheur pour aller dans les actions "admin_" des controlleurs;
Redirection si nécessaire + flash
Can anybody tell me how can I connect to @Venugh ? Thank you :)
Just a quick refactor. I'm going to work with Dipesh for an hour or so now, but I'll keep looking tomorrow.
We should cache this selector and some others as well.

e.g.
`$browse_overlay = $('#browse_overlay');`
building a string via joining an array is a bit hard to read, IMO. i'd just use `%{whatever}` or a heredoc

(i still don't understand what's going on with `MAXIMUM_N_ENV_VAR`)
+ Parler du pourquoi des fichiers plats et de PostGIS et expliquer pourquoi on ne fait pas que du postGIS
Ah, ok you removed here. Good lad :)
Is ScriptlerBuilder is completed?

I'm translating into Japanese, and almost have translated including ScriptlerBuilder config.jelly.
But, ServletException caused NPE occurs when ScriptlerBuilder is set and submitted.

If Scriptler is not completed, I'll push after completed.
Ok, fixing it then
Step attribute can also have a valid value of "any" per http://dev.w3.org/html5/markup/input.number.html
Hi,

thanks for the PR!
Please:
- only include changes that are associated with the commit comment (in this case: "Automatically show input controls for properties" does not require the removal of the presets ("Kühlschrank"...); if you feel this is an important change, too: include it in the comment or put it into a separate commit
- don't send one PR with several commits that have changes in one commit and a correction to that change in another one

I've tested your change and I like it!

Can you please send another PR? I'll be glad to include your commits then. I'm not going to include this one as it's pretty hard to figure out, what's happening and I don't agree with the removal of the presets.


Regards, J.
te falta activar el uid_stats en el PW28_defconfig ;)
Whitespace-only change. *wags finger*
yep, when upstream and local branch diverge, ```git pull``` does ```git-fetch``` and ```git-merge``` automatically unless you specify ```--rebase``` option not to merge but rebase instead for pulling.

or use ```git fetch``` and then ```git rebase <branch>```

It will get rather cleaner history.
Maybe we could put this in the config.yml aswell.
Cool, thanks for pointing me to that. I changed the code to use that instead.
![](http://f.cl.ly/items/063A2X3q0D3G1e38172k/Screen%20Shot%202012-01-18%20at%201.52.00%20AM.png)
Also added an error if the project doesn't appear to have been set up properly for release notes.
Thanks. 

At first glance, fix is useful. I'll run the regression tests at the weekend to check for possible bottlenecks.
According to the datasheet (p14), `27,32,n` is "Set and cancle [sic] bold font", but that's immediately below another definition for setting bold using `27,69,n`. So yeah - fun.
monkeypatched manually, thanks!
url en dur
Actually I am not sure this is particularly useful. I guess it is if the metadata is not present.
This is based on ASIHttpRequest
Cool... no worries... halfway through is a pretty good start for Monday at 10AM... (well, okay, I know it is six hours later out there...)

A couple points to think about... make sure you take a look at the attached Word document that Lara wrote up, particularly the fifth row-- "Patient has a workflow state of X starting in Jan 2012 (still current)"  Note that in this use case, a patient ends up being in the same state back-to-back, ie. They end up with two back-to-back PatientState records with the same state.  My original behavior for this state would be to keep a single PatientState record, and roll that "start date" back.  Neither solution is really "right"... we came up with use cases that justified each behavior... but behavior that Lara came up with is what we decided to go with.

Also, we still have to resolve exactly how we want to handle the case I described in the ticket "QUESTION: if a user changes the encounter date, this information could potentially no longer be accurate... do we think this is a problem? is it better not to set the default?"   We were discussing this last week... I will see if I can find the email chain and forward it along to you...

Mark

-----Original Message-----
From: rkorytkowski [mailto:reply@reply.github.com] 
Sent: Monday, February 06, 2012 10:21 AM
To: Mark Goodrich
Subject: Re: [openmrs-module-htmlformentry] HTML-64: Additions to htmlforms for workflow and states (b8adf46)

No, it's not yet ready. I'm only halfway through.

-Rafal


On 6 February 2012 16:17, mogoodrich <
reply@reply.github.com
> wrote:

> @rkorytkowski: that was fast... there were some edge cases we hadn't 
> 100% decided on the functionality for, and I wanted get you up to 
> speed on the debate.
>
> Do you want me to code review this, or is this still a work in progress?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/OpenMRS/openmrs-module-htmlformentry/commit/b8adf46
> e98e9cdff7d40dc07bfa6d03a2a938dd3#commitcomment-936831
>

---
Reply to this email directly or view it on GitHub:
https://github.com/OpenMRS/openmrs-module-htmlformentry/commit/b8adf46e98e9cdff7d40dc07bfa6d03a2a938dd3#commitcomment-936849
I see now, thanks. I have synced few hours before (android revision
nadlabak-picked), probably I am on 7.2 (have bt GPS and t9 dialer)
will dig that deeper, at least now i know when to start

so after reverting the commit usb.apk is crashing, but not offending
systemui?
On Jan 8, 2012 10:31 PM, "Pavel Chernyak" <
reply@reply.github.com>
wrote:

> Well, are you using cm 7.2 or still on 7.1 build? Try to update all and
> get more info about it.
>
> On last 7.2 build i get usb.apk crashed... and after that crashed systemui.
> That was on problem.
> Also, i explored about uevent and kernel.
> Quarx recomended to write module for usbnet_enable(defy has that in
> kernel... but how to build module i don't know, i have love experience at
> c/c++ lang. .
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/CyanogenModXT720/android_packages_apps_Usb/commit/057a6f094de833e35f06261e4aa6de0b0bb0d19e#commitcomment-847966
>
I think this should maybe just be `File.exists?` instead of `FileTest.exists?`?
This is in .gitignore.  I'd remove it from the commit.  If you want to keep it, I'd rename connect to connect_openstack so that other providers can make use of this file as well.
Ruby will complain about the use of `attr_reader`. The problem with your solution is that Ruby will complain about `@client` being uninitialized. Here are some examples from IRB:

```
irb(main):001:0> class Foo
irb(main):002:1>   private
irb(main):003:1>   attr_reader :client
irb(main):004:1>   end
(irb):3: warning: private attribute?
```

And...

```
irb(main):001:0> class Foo
irb(main):002:1>   private
irb(main):003:1>   def client
irb(main):004:2>     @client
irb(main):005:2>     end
irb(main):006:1>   end
=> nil
irb(main):007:0> f = Foo.new
=> #<Foo:0x007fbaa988b970>
irb(main):008:0> f.send :client
(irb):4: warning: instance variable @client not initialized
```

Proof of my solution...

```
irb(main):001:0> class Foo
irb(main):002:1>   private
irb(main):003:1>   def client 
irb(main):004:2>     return @client if defined?(@client)
irb(main):005:2>     end
irb(main):006:1>   end
=> nil
irb(main):007:0> f = Foo.new
=> #<Foo:0x007f99fb851000>
irb(main):008:0> f.send :client
=> nil
```
Missing acp_
justremove these @inheritedDoc things
we should make this post
This was deliberate, after looking at the specification for node and ssh_options in mcp.py.

Both of these can be reworked (by simply checking the MASTER namespace for these configuration options), then ignoring or raising an error if these sections are present in other areas of the configuration object. 

I'm curious what substantive reasons there are for not allowing the specification of nodes in non-MASTER namespaces, though (ssh_options is simply a runner for node configuration). If the case is simply that the master should maintain strict control of the allocation pool, that's perfectly reasonable and easily workable.
There are actually exceptionCaught invocations where the cause is null?
You commented on `MixMetricsSlector()` not being `MixMetricsSlector`.

The way I have implemented it now (not pushed) is as follows. The purpose is to have the object MixMetricsSelector for the default instance, and the case class for custom instance, e.g. MixMetricsSlector(Vector(HeapMetricsSelector, MyOwnSelector))

        /**
	 * Singleton instance of the default MixMetricsSelector, which uses [akka.cluster.routing.HeapMetricsSelector],
	 * [akka.cluster.routing.CpuMetricsSelector], and [akka.cluster.routing.SystemLoadAverageMetricsSelector]
	 */
	@SerialVersionUID(1L)
	object MixMetricsSelector extends MixMetricsSelectorBase(
	  Vector(HeapMetricsSelector, CpuMetricsSelector, SystemLoadAverageMetricsSelector)) {

	  /**
	   * Java API: get the default singleton instance
	   */
	  def getInstance = MixMetricsSelector
	}

	/**
	 * MetricsSelector that combines other selectors and aggregates their capacity
	 * values. By default it uses [akka.cluster.routing.HeapMetricsSelector],
	 * [akka.cluster.routing.CpuMetricsSelector], and [akka.cluster.routing.SystemLoadAverageMetricsSelector]
	 */
	@SerialVersionUID(1L)
	case class MixMetricsSelector(
	  selectors: immutable.IndexedSeq[CapacityMetricsSelector])
	  extends MixMetricsSelectorBase(selectors)

	/**
	 * Base class for MetricsSelector that combines other selectors and aggregates their capacity.
	 */
	@SerialVersionUID(1L)
	abstract class MixMetricsSelectorBase(selectors: immutable.IndexedSeq[CapacityMetricsSelector])
	  extends CapacityMetricsSelector {
killing the child with stopping strategy and I dont want a
deathpactexception. (Let me know if I'm mistaken there)


On Sat, Dec 8, 2012 at 12:14 AM, Viktor Klang (√)
<notifications@github.com>wrote:

> In akka-camel/src/test/scala/akka/camel/ProducerFeatureTest.scala:
>
> > @@ -254,6 +267,47 @@ class ProducerFeatureTest extends TestKit(ActorSystem("test", AkkaSpec.testConf)
> >  }
> >
> >  object ProducerFeatureTest {
> > +  class ProducerSupervisor(childProps: Props) extends Actor {
> > +    override def supervisorStrategy = SupervisorStrategy.stoppingStrategy
> > +    val child = context.actorOf(childProps, "producer-supervisor-child")
> > +    val duration = 10 seconds
> > +    implicit val timeout = Timeout(duration)
> > +    implicit val ec = context.system.dispatcher
> > +    Await.ready(CamelExtension(context.system).activationFutureFor(child), timeout.duration)
> > +    context.watch(child)
>
> Why the watch?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/akka/akka/pull/933/files#r2354974>.
>
>



-- 
Raymond Roestenburg

code: http://github.com/RayRoestenburg
blog: http://roestenburg.agilesquad.com
twtr: @RayRoestenburg
book: http://manning.com/roestenburg
How many times is the standard import statement repeat factor?
is this still correct?
executorService is  now a ExecutorService, but LoadMetrics is not implemented by that?
Also, why do you use (new SecureRandom).generateSeed(numBytes) instead of SecureRandomSeedGenerator?
It's a bit inconsistent and undercommented to be able to figure these things out if you're not the author of it ;-)
Add a FIXME here, it's a bit wasteful to create Futures for one-offs, just use EC.execute instead
Perhaps also mention that wildcard can not be used to match part of the name, or can it?
`/foo/bar*`
Either we explain that you have to pass `-Dakka.test.tags.include=long-running` to sbt when you start it up, or we change the sbt run command to `akka-sample-multi-node-experimental/multi-jvm:test-only sample.multinode.MultiNodeSampleSpec`.
that's a nasty trick :-)
So a consumer cannot also be a producer? (values get overwritten in the map)
because you need to store the sender of each message in any case (for resending); another benefit is to enable “normal” communication between the two end-points, which otherwise would have to be a bit non-obvious
Shared lookup of the renderer from a format string/symbol.
This sentence doesn't really make sense:
`Numpy array of values to calculate the survival function for this given distribution for.`

I would replace it with something like this:
`Numpy array of values to calculate a survival function for the given distribution.`
Nope; it appends (like logs should do)

But the `cook` script controls the world—it can blank out the log file before a run? Not sure if that would be civil.
@arokem Sorry, I mean to run the examples. And/or generate the html? Did it work for you?
Should there also be an upgrade option?
Oh, is this a gofer-specific conduit? And the agent.lib one is in case we ever add another comm layer? Might be unncessary for now since that one isn't adding anything, but not a huge deal.
No it still changes queued calls (tasks that are persisted across server bounces) and scheduled calls (scheduled syncs, publishes, etc)
For consistency, I'd like to rename referenced_name to ref_key, and referenced_card_id to ref_id

Ok with you?
Using Option (with None) is a better idea in Scala than simply returning null...
Also, please parse `~` and environment variables in `include`. :)
safer to use Ext.Array.indexOf
The IterativeSuspendable does quite a bit of work to be able to suspend the computation. I was worried that this does not carry over to this class, but it seems that you use RestartableIterativeTask for the actual iterative computation instead. Does that handle suspend correctly?
This __init__() can just go away.
Hmm, you imported a bug here from `tmxviewer`. This will crash when you are evil and launch the application like this: `tmxrasterizer ""`.
Since value holds the final answer i think you can just return the value without the extra variable in the if/else
oh, hm. yeah, I guess that could be the case. I'm about to drive into the office, I'll munge the patch once I get in
Can it be <= 0?
This whole file looks so similar to rest.c it may be worth merging them.  Also, should be proposed to upstream CTags.
Or you could use a struct, which might be easier at this point, since these are just primitive values.
Superfluous `== true`
Good idea -- will fix this.
this is neither possible not necessary since traits is set to accept lists of only three elements
PyErr_WarnEx isn't available in 2.4 (the Travis failure on this PR is real). Also technically this should be a DeprecationWarning, since it's only introducing stricter checking, not actually causing code to return a different result. Use the DEPRECATE macro from numpy/ndarrayobject.h to fix both of these.
OK. Could we consider an optional approach based on dlsym?
тут динамик_каст второй раз делать не нужно, можно просто edge проверить на NULL
parent не булевского типа. Может быть, лучше явно спросить, не NULL ли он
I left it there because I was not sure what should happen if there is no tracker for a handler. I guess the proper thing to do is to just return an empty array. However, that will mean that any template types for which the digestor accidentally works right now will stop having version tracking. Would that be okay? I feel that perhaps the handlers should register themselves. I could add support for Builder if necessary.
Exactly. I don 't think it makes sense to send a value that potentially does not exist.
Let's get more ambitious about not polluting all our methods with unused identifiers.  It is not edifying to have mods0, name0, tpt0, rhs0 in there, never to be used.

    case vdef: ValDef if vdef.symbol.isLazy
Modifier patrol: You could make a few defs in here final.
I'm not sure if logical equivalence is a lattice.
No. But perhaps you could replace the 'and' with 'divides' in all headers and then write for the first example something like:

```
In the following examples, the monomial is given in terms of x, y and the generator, f_1 and the tuple form of that monomial is used in the call to sdm_monomial_divides. Note: the generator appears last in the expression but first in the tuple and other factors appear in the same order that they appear in the monomial expression.

`A = f_1` and `B = f_1`
```

If it's customary to put the generator last, though, why not follow the same convention in the tuple: so (0, 0, 1) for f_1 rather than (1, 0, 0)? I understand if it's a convention that's already been established...I just don't know this stuff enough to know what those conventions are.
The docstring says:
```
This is necesssary because MatMul may contain both MatrixExprs and Exprs as args.
```
In this case, I'd recommend against formally stating that this function is a special case of `rm_id`, but rather saying that this function is _analogous_ to `rm_id`.  I may be overly exigent over minor details, though, so feel free to disregard this comment.
never compare to True or False if you know the result already *is* True or False. I.e. make this `if not ...:`
There a reason for this odd spacing?
defined about the hinge, not about the mass center of the pendulum.
The same sort of fix is needed in order for an inverted wild to match an expression:

```

>>> x.match(1/w)
>>> (1/x).match(1/w)
{w_: x}
>>> x.match(w)
{w_: x}
>>> (1/x).match(w)
{w_: 1/x}

```
Ok. I'm about to add this tests
I've refactored `groupby` and `sift` in a recent commit. Let me know if you're alright with it.
@creocoder please tell me more about "good refactoring".
Like @rawtaz said i have my points on this refactroings, which im explaining to @qiangxue. Youre just acting like smug. If your have nothing better to say, better stay silent.
please make your file access thread safe. synchronization should help.
Don't we still want to capture the comment, even if the content is nil?
Same here. But again, this is a personal opinion. We'll talk about it face to face :)
Bad sizeof(). That's what was making it crash on my 64 bits Linux install: `sizeof(char*) == 8`
We need to change ARVG param 
from --bg_command=true 
to --bg_command=false
 This will ensure the setting of this param to false for backround execution
also, this parameter is no excpetion with respect to quoting: --bg_command=\"false\"
If we decide that, for now, we only use node for testing, we won't even need `process.env.L20N_TEST` in there.  I prefer to leave it though -- it will make it easier to fully port l20n.js to node.  (At which point, we'll be using `fs.readFile` and `fs.readFileSync` instead of the fake XHR wrapper.)
So, I originally added image_answer as a string variable, and later on decided it should be Boolean instead.  I had made enough changes to lose a few commits if I rolled back the database, so I just decided to remove the column by creating a new migration.
Since we are deprecating our usage of the Hibernate 2L cache, I don't want to introduce any more dependencies on it.
Add a "BUG: overwrites any passed values with the values from config, thus we have to copy the original values" comment
this paragraph is a bit dense.
I think I changed this on purpose. I did some logic at https://github.com/mozilla/kuma/blob/master/apps/wiki/templates/wiki/document.html#L6 to make translate_url point at the parent document which should always have `is_localizable = True`.

If we want to improve it, let's add `is_localizable` check up there so we can keep an "Add translation" link on non-English pages; it will still work by going to translating the English page.
Nice idea but unfortunately this won't work with Foundation framework. We have to explicitly define the classes for each field.
Document layout of array values.
CamelCaps or CamelCase?
Why are you using a multi-line comment here?
That was requested by Nick (https://github.com/phpbb/phpbb3/pull/610#r542459). If we're going to move that function to a front facing file than get rid of the function completely because than it really doesn't have an advantage to keep it in a function.
I'll move the language string - but wouldn't `!empty` return true when the value is false?
Remove added white space on this line.
path.size() + infix.size() + 9
Nope, but it looks better with alignment
Этому коду не место в этом методе
recommend for less redundancy: view.dispenseview -> view.dispense
It's already apparent it's a view from the path filepath and includepath
Just a note to keep in mind for the futur. It is probably not worth an issue.

This can probably be optimized by reusing the old output if possible.
sys.maxsize would work to get the size of pointers on all architectures, I think.
Add "TODO" or somehting?
always put a space between ) and {
В общем, в `getFirst` будет что-то странное
Ditto for ornament
I get that it will be another *Model* that would be getting passed in here but it is still a parameter and by convention parameters are lower case.
I can't say I'm thrilled with the way these required fields are handled in this command - something here isn't passing the smell test. I understand why it's needed -- otherwise the createsuperuser command fails hard on custom user models -- and I can't put my finger on exactly what feels wrong. Nor can I suggest a better approach, so in all likelihood this should go in as-is. However, I'm flagging my discomfort so that we can think about it just a little bit and see if there's not something a little less... smelly.
please remove these commented use statements
While you're making the other change... can you remove this line break too? :)
maybe it would be more appropriate to see if '-pthread' occurs anywhere in $PTHREAD_CFLAGS, rather than just checking for an exact match
Please put your name here for all files you contributed.
What about making the git hash available within our build? A shortened version could be used here and might also be a useful meta information in the build results.

http://mojo.codehaus.org/buildnumber-maven-plugin/
Still need the unary `+` before `ret[1]`, there is even an open ticket about it.
Typo iff
hmm, actually if this is only meant to remove leading and trailing whitespace, we can do this without a capture.

```js
selector.replace( /^[\x20\t\n\r\f]+|[\x20\t\n\r\f]+$/g, "" );
```

Or something similar.
This is line is somewhat confusing. Since we don't have another option that has to be converted into an integer I'd just drop the `optsToInt` array and check `if (o[0] === 'indent') { ... }`. This way it is much easier to skim the code.
But this is not the case if there is a scalar variable at the very end of the components. So, do you think suggesting one more zero (in this case 9) in the aggregate initial string is what we want to do in all modules? You could ignore this if this is no longer important with the new modular transition states.
Boost will throw a exception if x is not an integer.
Don't include your environment path.
Small grammar/spelling mistake in this comment. Up to you if you think it's worth fixing.
Use the full path: `"#{bin}/regex-opt"`
I use XCode 3.2.6 on OSX 10.6.8 and I need those because of the outdated autotools. They may not be needed on Lion, I'm not sure.
コメントアウトsないと何か問題が??
I just want to throw in that the web interface offers to set four individual types of permissions: create, update, delete, share. You can also set an expire date. Don't know if this also concerns the ACL implementation...
We need to process the PDUs one after the other (since that's how things worked before txredis). There's a queue (`self._pdu_queue`) that PDUs get put onto and pulled off of. But there needs to be something that interates through the queue and processes them. This something is `self._process_pdu_queue`. We could keep the deferred and block on it in some sort of tear down method, but I'm not sure which one. We would also have to push `None` onto the PDU queue to end `self._process_pdu_queue()`.
Не могу согласиться со второй добавленной запятой: «могущие быть полезными (параметры)» – это причастный оборот, расположенный перед определяемым словом, в этом случае запятая не ставится.
Запятая здесь могла бы быть, если бы «могущие быть полезными» являлось уточнением прилагательного «другие» (какие именно «другие»), но это не так.

Поправлю на предложенный вариант, только без запятой между словами «параметры» и «вместе». Нет возражений?
prinzipiell würd ich hier noch bissl kosmetische Änderungen machen

```
if ($columnName == $sortColumn) {
  $columnSortType = $sortType == 'desc' ? 'asc' : 'desc';
}
else {
  $columnSortType = $this->getColumnOption($columnName, REX_LIST_OPT_SORT_DIRECTION, 'asc');
}
Best is the simplest solution that requires the least contextual knowledge of starcheck code to interpret and produce the fewest surprises for reviewers.  Holding all ERs' to the 3 bright stars rule would make me or Eric surprised for a non-perigee ER (after I've forgotten this discussion) in this case.  Just saying that there is a problem with inputs and the check cannot be done reliably is straightforward.  In all cases the products would need fixing anyway.
Oddly, I think checkstyle can get these without, if the outer pom checks src/it in its scans.
Reading the line `@ottawaWeather.once 'snow', 'sleet', 'hail', doSomething` out loud, it seems to me that it should just `doSomething` literally once, regardless of what the event is. But I haven't even really convinced myself of that.

Is there actual use case for passing multiple keys to `once` or was it just for parallelism with `on`?
Just so you know, I see a little tiny chance this could cause problems.  This accessor used to be calculated the first time the property was `get`ted, which means you could have messed with the accessor the property will look up after the property has been instantiated, and it will still find the right one. Here, it memoizes the value upon construction, which means if you mess with it after construction but before the first `get`, it won't pick up the new accessor. All this I am pretty sure is moot because I can't think of any time that properties will be created without being gotten immediately after, but I wanted to point out the subtlety in case this introduces bugs along these lines when it gets merged.
Please give a name to the function.
These tests are dependent on the HTML menu implementation. Eventually we'll have the native implementation instead. Should we separate these tests from the API testing?

If we do that, it seems like either some internals like ``menuMap`` and ``menuItemMap`` need to be exposed in order to validate the current API without inspecting the DOM.
brackets-concat is just a test file for perf tests and should be ignored.
This is a slightly misleading comment. At first I thought the username was included, but it isn't. I think it would be clearer to just say "refs/heads/branchname"
Would it be better to use “функциональность” ? (Google translation for functionality)
/extend/extent/
If the URL is already https, won't this give us 'httpss'?

```
1.9.3p194 :001 > "https://".sub(/^http/, "https")
 => "httpss://" 
```
OK. Then good.
Right... :) that's better.
The function name `parse` is pretty ambiguous here. Mind changing it to something clever like you did with `toSeconds`? Perhaps `toTimecode`?
By path above, I mean the popcorn-js path
No, I suppose not. Consider it removed.
I assume this is intentional, but want to confirm.
`options.innerContainerClasses.split(" ")` needs some extra spacing
nvm we only need updateOptions
Nit: no comma needed there; I'd say omit ", then" and just use a colon, even.
Nit: Put view.el.clientHeight in a variable since you use it twice.
Perhaps ```lowstate``` should be defined and this should be made back into a term?
If you use an error payload, this locale string should appear in the errors.irc.ALIAS_EXISTS constant
Tässä myös merkkijonot käyttöön
Tähän voisi laittaa suoraan returnin.
we only ever care about the 1st value from the package checksums?
We haven't been as consistent with method names, I think more so use of underscores methods/variables and CamelCase for Global namespace definitions.
I've removed this options completely, set up foreman and foreman-postgresql as  katello-all dependencies and turned on configuring Foreman by default
So this only gets called from one place right?
`onInitialized` was getting called twice, meaning that the `onError` handler got connected twice. So I removed this line. Was there a reason for it being here though?
Underscore variables are sort of misleading here.
Well, I'm not really qualified to say... I'm happy to update (or remove) the value to whatever is preferred. `:)`
Uri!
No, not a TODO, more of a note-to-myself: "figure this out, fool!" :)

I'll snip it out of my next commit. Working on CTxDestination instead of CBitcoinAddress now.
Instead of this, always pass an array.
@stof  that's the goal. It already creates 4 sub directories. 
Lots of files in the same directory might be a problem depending on the OS

I just changed the hash algorithm to avoid collision.
.
Hi Marco, 
For keeping conventions same, also should add this check to ```MemcachedDriver```. 

I think we can solve this problem in another discussion/pr :)
Module docstrings should come before imports, or it's not a docstring.
Sounds like I solved the issue by executing all of the deffered calls (only used by the relayout stuff) in a separate thread. How does that sound?
`corp_id`
On 17/10/12 2:54 PM, Jesse Reynolds wrote:
> In lib/flapjack/data/global.rb:
>
>> @@ -0,0 +1,27 @@
>> +#!/usr/bin/env ruby
>> +
>> +# Used for data that is 'global' to an instance of Flapjack's Executive component
>> +
>> +require 'flapjack/data/entity_check'
>> +
>> +module Flapjack
>> +
>> +  module Data
>> +
>> +    class Global
>> +
>> +      def self.unacknowledged_failing_checks(options = {})
>
> how is this specific to a particular flapjack executive instance? It
> seems global across all executives, no?
>

Yeah, I think I managed to express exactly the opposite of what I meant 
with that comment... maybe we should remove it.
I think you should just use a bitwise operator to clear the read only flag - but preserve anything else. Then again - we are about to blow it off the face of the earth - so I'm just being pedantic at this point. 

Just put a comment above the line and I'll be happy - sometimes I forget that TFS sets stuff as read only. :)
Do you still have to get/set the face/edge color if they aren't being overridden anymore?
I didn't know that enumerate can take "start" argument!
I agree.  I've made the changes and pushed a new commit.
I think inputsplitter, if nothing else because that code is a bit more cleanly organized and designed, where as prefilter is more of an attempt to clean up old hacks from the very early days of IPython (and it does partly succeed, but it's still pretty messy).
so are you saying there is only this file and no identity?  If that's the
case better to have identity and no cred than the other way.

For file make sure classpath can be an option for GAE.

Maybe you can show me the complete input params, or in the javadoc :)
On Oct 31, 2012 7:01 AM, "David Ribeiro Alves" <notifications@github.com>
wrote:

> In
> labs/oauth/src/main/java/org/jclouds/oauth/v2/functions/OAuthCredentialsFromPKCS12File.java:
>
> > +   private final String identity;
> > +
> > +   @Inject
> > +   public OAuthCredentialsFromPKCS12File(@Identity String identity, @Credential String keystorePath,
> > +                                         @Named(PKCS_CERTIFICATE_KEY_NAME)
> > +                                         String keyName, @Named(PKCS_CERITIFICATE_KEY_PASSWORD) String keyPassword) {
> > +      this.identity = identity;
> > +      this.keystorePath = keystorePath;
> > +      this.keyName = keyName;
> > +      this.keyPassword = keyPassword;
> > +   }
> > +
> > +
> > +   @Override
> > +   public OAuthCredentials get() {
> > +      File file = new File(keystorePath);
>
> This makes sense. I've created an additional module to read the file.
> Question though: right now I'm setting the path to the keystore file as
> the @Credential property (e.g, oauth.credential) since there is really no
> generic "password" (PKCS12 stores need a pass but others don't). Is this
> aligned with the common practice?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/920/files#r1992246>.
>
>
Good eye. Will fix.
I agree! I was wondering what to do about this, as the swf file we link to there has the video CDN hardcoded inside of it. So if you link to a video file that's not on the CDN we can't use that fallback. I guess I could throw it in by default and allow a kwarg of ``flash=False`` for the rare case when we don't point to the CDN?
if you wanted, you could make this whole thing a single lambda and drop it straight into ``page()`` below.
Is there a way to get the name of the passed in function from within the decorator? That way I could do `<func.name>:<md5>` and not do the parameterized decorator.
The exclude clause here was the key one to fix the ConcurrencyError you were hitting in that test. What was happening was that `self` here (the result instance that `set_latest()` is called on was being included in this update call (because it had `is_latest=True`). Thus it was being updated in the database, causing the concurrency-control counter in the database to be incremented, but the concurrency-control counter (`cc_version` field) on the actual Python instance was never incremented. This caused a `ConcurrencyError` the next time that instance was saved, in the test.

There would have been two possible fixes, either to explicitly increment `self.cc_version` here (if and only if `self.is_latest = True`, because otherwise it wouldn't be included in the update call), or to add the exclude so `self` is never part of the update call. Since the very next line reverses the effect of this update call for `self` anyway, doing the exclude seemed like the more sensible option.
``raises`` instead of ``rasises``.
The 'FennecAndroid' and 'Thunderbird' products are useless in this test, but it doesn't really matter (just make the test smaller and easier to read).
Why is the nullcheck removed?
yea, but what does it _mean_ ? that'st he question
A protocol or scheme parameter would fix the issue too:

    $manager->getConnection($callback, $scheme, $host, $port)

or 

    $manager->getConnection($callback, "http://host:port")
Copied this from internal tree. Wondered about that myself but figured I'd just copy and see if it stuck. Updated.
What alternatives exist to use defined? everywhere? It seems that it is polluting much of the code....
Would you mind telling what's wrong ? I've copied this from the parameters check a few lines above and removed the `!$optional` as all variables are required in the hostname.
could you please test both inserting and updating ?
and you would then want to move that logic into ``Symfony\Component\DependencyInjection\Compiler\MergeExtensionConfigurationPass``?
I would guess on medium confidence only as a collection type could require more options (the internal type for instance) and we are not able to guess it
So how would I pass the error to the error handler configured outside the factory? Something like this?

    $this->prevErrorHandler = set_error_handler(array($this, 'handleBC');
    [...]
    public function handleBC($errorNumber, $message, $file, $line, $context)
    {
        if ($errorNumber & E_USER_DEPRECATED) {
            return true;
        }
        return $this->prevErrorHandler($errorNumber, $message, $file, $line, $context);
    }
is_safe is about disabling the auto-escaping on the output of a filter (if it is used to be displayed), which does not make sense here. So it would be better to remove it (someone looking at an existing twig extension should not see something marked as safe if there is not a good reason to do so as they could start marking unsafe things as safe).
It does not really matters for the form theme itself as it does not display the result but uses it as a test.
`else` statement is not needed here
Registering half of the locale stub only looks like a bad idea
ok, changed all those to 0.0f-comparisons.
I meant that this check could also be performed when the name of the file is only extension. Currently if filename is "exr" but contains a tiff this check won't work (cause filename('exr') == format('exr') ) ? It seems like very rare case but in theory could happen.
OK by me. 



Chris Foster <reply@reply.github.com> wrote:

>> +    
>> +	ImageBuf::ConstIterator<Atype, float> a (A);
>> +	ImageBuf::ConstIterator<Btype, float> b (B);    
>> +    ImageBuf::Iterator<Rtype, float> r (R, roi);               
>> +    for ( ; ! r.done(); r++) {
>> +        a.pos (r.x(), r.y(), r.z());
>> +        b.pos (r.x(), r.y(), r.z());
>> +
>> +        if (! a.valid()) {
>> +            if (! b.valid()) {
>> +                // a and b invalid.
>> +                for (int c = 0; c < channels_R; c++) { r[c] = 0.0f;
>}
>> +            } else {
>> +                // a invalid, b valid.
>> +                for (int c = 0; c < channels_B; c++) { r[c] = b[c];
>}
>> +                if (! has_alpha_B) { r[3] = 1.0f; }
>
>Much appreciated Larry :)
>
>Ok, let's do this: To avoid changing the specifications out from under
>Stefan (yet again!), we'll go with the current method for this review
>which I think is perfect for the common cases.
>
>After it's committed, I'll have a look in more detail to see whether
>the
>"no alpha is opaque" rule can generalise to nchans!=3 without a
>maintenance or performance burden.  (I'm pretty confident it can be.)
>
>"Fixing" this would only generalise what we already have in this pull
>request, it doesn't change the behaviour in the common case.
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/OpenImageIO/oiio/pull/381/files#r1037749

-- 
Larry Gritz 
lg@larrygritz.com
it's the srs
I'm starting to wonder whether there needs to be a RectangularGeoAxes subclass... not for here though.
Use wiki markup here, so it can point to the correct version over time

`[[[Commands documentation|Command-Line-Tools---riak-admin#wait-for-service]]`
@skipIfDBFeature('supports_transactions') does not work as it will skip for sqlite as well.
shouldnt we keep some instructions in the datalist? that way they can see the use cases for them... i guess we could do it in a placeholder :)
The ServiceTracker now supports failure in untracked dependencies (i.e. START_REQUESTED_to_PROBLEM)
Untested $_POST value being used
This whole line should've been deleted.
почему Not authorized? Напиши что offset слишком большой, а то путаница будет
OK I think I understand wat you mean now,
Done, since it was aligned with @etiennesegonzac 's comment ;) Thanks!
What about extensions.gaia.*
`Authentication needed!`
"msec" -> 'msec'
I think we need a check like:

     if (!oldObj.hasOwnProperty(k))

no?
We can remove this part and the `head` method now, right?
Это был ответ, на предыдущий комментарий. Я имел ввиду few, many, one... Это не относиться к джему russian - это часть библиотеки локализации Rails.
not sure how much you care about min with compiler.js - but it would be probably better to do something like `var tagTypes = Hogan.tags = ...` so that everywhere below where you ref `Hogan.tags` it can be minified
Kind of like the auto mimetype icons, but probably not completely necessary.
I like the new node, we could remove some of the redundancy and have `attrs.set(...)`, `attrs.remove(` etc
Use multi-line comments when documenting. I don't understand the sentence either. Just write "We intentionally use converting equality comparison (==) here."
Keep in mind, thisRule['depends'] can be an array of arbitrary size, it doesn't have to always be of size 1 like it is in the simple example input file.
можно просто `render :show`
Nah there was nothing, this is just a stub.
thanks, should have thought of using a new branch myself, wasn't sure if it was possible if it isn't branched from my own master, but apparently not. Yeah, that would be kinda stupid...
I'm still yet to look at the form stuff you sent me @timpaul, but either way we really shouldn't be checking generated code in - just add the mixin to this project and use it like regular Sass.

If it passes muster (and people want to use it globally) we can look at getting it integrated with the govuk_frontend_toolkit.
Needs class docstring
I've just commited a fix to show this info in Debug mode.
@schmittjoh Can you fix this for non-default vendor dirs then please?
tab vs spaces ?
generally, it is consider kinda gross to make a div JUST to store data.  Might be better to attach a JSON object to window, but that could just be personal preference.
use_cache should default to False, not a string.
@robbytaylor True. Fixed.
A comment on the udp_client1w binary above:  You should **not** commit binaries.  Please remove that from the pull request.  They encourage people to try and execute them, but they probably won't work on their setup.
Да пошёл ты!
The highlight flag should be added second, to preserve backwards compatibility for anyone who might have been calling this with positional arguments only.
let's create a helper method for this that adds .active based on a condition. Probably good to use @anchor here.
if you `require("time")` instead of "date" at the top of the file, you can avoid the 'to_datetime' call and just do `Time.at(...).iso8601`:

```
>> require "time"
=> true
>> Time.at(3).iso8601
=> "1969-12-31T16:00:03-08:00"
```
this could just be
event.tags += @tags
Added a note again.
What is the ; at the start of the line here about?
argn, the test takes wayyy too long with 512x512...
`dprime_from_samp` will not be visible when doing `from bangmetric import *`
@hkenney `Kernel` misspelled here too... :)
It looks like this doesn't actually *evaluate* the code, it captures it for later evaluation, right?

Probably best to name it to match the behaviour.
Same with all of these.
Hmm, well, in 1.9 $LOADED_FEATURES has full paths, but in 1.8 mode it doesn't. I wonder if that would break stuff
That's because in mochijson2 a list is considered an array and in erlang a string is just a list of integers.  If you want a string the value must be a binary.
Indentation should be only 2 spaces here. :)
I just used the template render function on the Generator that is already
there.
On Nov 26, 2012 4:44 PM, "Sindre Sorhus" <notifications@github.com> wrote:

> In test/test-api-v2.js:
>
> > +  before(generators.test.before(path.join(__dirname, 'temp')));
> > +
> > +  // generators is an instance of event emitter.
> > +  it('generators is an instance of EventEmitter', function() {
> > +    assert.ok(generators instanceof events.EventEmitter, 'Not an instance of EventEmitter');
> > +  });
> > +
> > +  it('generators.Base is the Base generator class', function() {
> > +    assert.equal(generators.Base.prototype.__proto__.constructor, events.EventEmitter, 'Not an EventEmitter');
> > +  });
> > +
> > +  it('generators.NamedBase is inheriting from Base generator class', function() {
> > +    assert.equal(generators.NamedBase.prototype.__proto__.constructor, generators.Base, 'Not a Base class');
> > +  });
> > +
> > +  it('can be hooked using a grunt instance, from which we read cli tasks and options', function() {
>
> Oh, ok, any reason you can't just use Lodash templating directly?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/yeoman/generators/pull/141/files#r2224202>.
>
>
Leave this import unchanged. All dependencies, even if are PHP's classes, should be declared here.
I'm not sure but seems that this list should end with 255
This file has tabs?
Ralph,

Can you perhaps be a little more descriptive in the accompanying docblocks here? One would have to what this property represents (at least that's what I'm doing...)
Is there a better icon in the old implementation? It would be nice to have a separate one for remarks...
Yeah, not sure about the half compatibility thing. It would be better to do it now entirely, instead of doing it partially, forgetting about it, and then finally fixing it later...
Why all these constants? Massive use of constants is an anti-pattern.
@jfox015 

I haven't had a chance to review the code yet, but try taking your check point out when loading the role_model and make sure the role_model is extending BF_Model those are just some thoughts of top of my head, I'll try and take a look at the code itself and see if I can find any issues
helper script on making sure all workers are working correctly - will remove
I'll fix, it this everything? :)
test user? :)
Hodim to do infoboardu. Plus pridam filtrovanie podla datumu, ktore tam momentalne chyba. Asi iny sposob vyrabania playlistov ani nebude existovat.
Preferably use `(void) arg;` if you want to squelch unused argument warnings. `__attribute__((unused))` is a gcc extension.
Nope, addHeader() takes a full header string, so you can't really give it a key and a value.
The general preference is to use events: { ... : ..., ... : ... , etc}, but it's a step back in software engineering. Writing what should be a triplet { eventName: "...", selector: "...", callbackFunction: fName} as a tuple of strings, you undo whatever semantics there was to the strings, and you make it impossible to trace cleanly. So the official alternative is "use jquery event binding on the this.el/this.$el peroperties, which we give you mostly for that purpose".
Removing this is might cause trouble for visited links in the drop down menu -- when I try it with my developer tools, visited links turn white and become invisible. Can you double check on your webdev and either update the pull request or comment to say it's okay, depending on what you find?
Will this be enough info?

````
child :domains do
  attributes :id, :name, :fullname
end
````
why even load this if we are not in testing?
This makes me uncomfortable. This is digging pretty deep into an undocumented portion of the handlebars framework. If there anyway around this?
Nit - Change this naming to TestInstallApp to word it in alignment that you are testing installation of a single app.
Could we make sure that we wrap all method arguments in parentheses? i.e. url('/articles.xml')
We directly get a token here from the URL arguments and then pass it into a database statement. Its probably not vulnerable to SQL injection because the database layer is smart, but it might be good to sanitize it here using something like this:
http://www.phparch.com/2010/07/never-use-_get-again/
The original motivation for using grey in the four hint was so that when I highlighted the last two digits in blue, the whole number was still the same brightness.. It looked too jarring when part of the number was dark black and the other part was the lighter blue. The gray made it look more like it was all one number, but that the last digits were highlighted.

That said, perhaps using gray here for the reason you suggest would work too. I'll try it out and see.
I think we're just sticking with X.Y, no need for a Z.
what a long variable name, `classSelect` would perfectly fits!
5.4 :D
This was covered by readme2
The reason I didn't went for the clone module is that doing a `JSON.parse(JSON.stringify(..))` is not only faster, it also gets rid of the non JSON values. (in this case: functions like `isAdmin`)
I'm happy to change it to clone though
Usually we do

```
if (err) {
 	 return callback(err);
} 

log(ctx).info('Password successfully changed for user %s by %s.', userId, ctx.user().id);
callback();
```
I think this method got removed in one of the earlier PR's
You might want to make the command name an attribute of the module. So after you do the import, you can say mod.cmd_name to get the cmd_name, rather than making it something that depends on the directory name.
Here, Range is not de-allocated if parsing fails. You should allocate all objects in the AST context, by using "new (Actions.Context) HicudaRange()".