labofsahil/github-event-dataset-2012 huggingface dataset:
How's this:  I will add protection so that str(self()) works if we gave it a unicode object, but allow DecodeErrors to raise if you give non-ascii bytes.

Sound good?
for convenience extend ForwardingSet<String> which means I can see the keys deleted and do Set comparisons easily
Would this be easier to read using `+` to concatenate the strings, rather than append?
The Java compiler will automatically use StringBuilder append for the byte-code anyway, so no less efficient.
showing off name uniqueness, eh? :)
See below; @arrbee's function is more generally correct, so I'll replace this with something that (a) doesn't look like it should be in `tree.h`, and (b) that doesn't leak objects or dereference invalid memory.
print debugging ftw. also #facepalm
again, can't make the assumption that the cause of any possible `Exception` is always going to be "bad object data missing key"
this section of code ought to change to use .../socorro/external/postgresql/connection_context.py   If not now, then mark it with a TODO or file a bug for the change.
You have twice the same id in the same page (unless I'm missing something in the diff), that's invalid HTML.
Variable should be tight with its usage. so this line should be moved to line #4814.
And I think that it doesn't need lazy evaluation, so it can be written like this
```c++
bool showAll = copts.count("all") > 0;
```
You did, sorry about that.
Oh and this also should log that the file is actually being downloaded and validated with md5.
Fixed.
And all of the `NULL` was replaced with `null`.
через ці зайві пробіли перед strip_tags вилізуть помилки в check code style
@bschussek I came to about the same conclusion: `!$view->hasParent() && $form->hasChildren() && $form->hasAttribute('csrf_field_name')`. I thought the children of the view might not be there yet ?
@beberlei is a Doctrine core developer, so it's normal he miss that.
@stof so, we should keep it as it is now (`self.version`), you think?
@cordoval Making it public to test it does not make sense IMO. As it is meant to be called from inside a command, you should call it from inside a command in the tests IMO.

And it is not at the same level as run. ``run`` is meant to be called by the Application whereas ``runCommand`` is just an helper for the code inside the command.
@TerjeBr You can see all services defined in the container using the command: `app/console container:debug`
The dbal service id is: `doctrine.dbal.default_connection`
what if the modelData is not countable ?
I'm in favor of adding the typehint and not support ArrayAccess everywhere where it could potentially be used. Let's go with the more restrictive behavior first and soften it when required. Same reason as using private visibility over protected.
btw, the best solution IMO would be to go the same way than @fabpot used in Twig a few days ago: ``if (!is_string() && is_callable())``. It would still allow all other callables (forcing to use a closure is too restrictive)
I did another attempt using a special message ID. Thought that was not nice. I agree on the statelessness.

Can we agree on adding ie __HEADER__ as a message ID? Then I can add the header to the messages. We can then prevent the Translator to translate that particular ID.
コメントありがとうございます。
確かに1行に条件が複数あると可読性が落ちますね。。。
以後、注意します
This might be short enough to go back to a single line (which would be The Best)
Yea right, its not used anywhere else in wagon. I updated my branch.
Would need to hit the pkg manager of choice to determine the version installed. I can test this cookbook on a variety of Ubuntu releases to see if there are any other configuration issues. We can then collect these attributes at the bottom of the default attributes file w/ a little documentation.
!this.dirs is gratuitous, and should actually probably NPE because you'd be masking an assert-worthy error.
I close this pull requests. 

You make a new pull request only with the fix on the regex.
It's okay with me, just wanted to make us think about other solutions :-)
Is this needed? 
The `Mongo` class inherits from the `MongoClient` class, or i am wrong?
Would importing System.FilePath.Posix to always use Posix style on all systems work, as well?
http://hackage.haskell.org/packages/archive/filepath/1.3.0.1/doc/html/System-FilePath-Posix.html
Anywho, squashed.
You're right, on second look it doesn't make much sense, although it did solve the problem. Please have a look at Issure #53 , which explains in details what the problem is.
How about FRAMEWORK_SYSTEMPACKAGES and FRAMEWORK_BOOTDELEGATION ?
OK, added i18n, but it was a bit more then 10sec. ;-)
Please change this variable name to `module` here and below.
I copied this from the above method which you wrote; what would `enumerate(book.chapter_lengths, 1)` do differently?
Should there be a `free(tracks)` inside this if block?
nit: please remove this obsolete comment
Ok i got it, i thought that you were talking about the titles.
We need the clasname because we are applying some specific styles for increasing the touch area for that elements, and if we apply them for the whole labels, some application could be very ugly.

`  display: inline-block;
  vertical-align: middle;
  width: 5rem;
  height: 5rem;
  position: relative;`
this is not bad, but just curious that you are not using the variable daySelector anywhere else than in the below line, and don't think is for making the length of the below line smaller, 'daySelector'.length > '.log-group'

hehehe, just curious :P
I think in order to use CSS, we need to change how the transition animations work, which is fine.  The DOM Tree is basically:

  + Clipping viewport (viewport sized)
   \--+ Card holder (N cards wide, so N * viewport width)
       \---+ N cards (Each viewport sized)

In order to use 100% for the width/height, the cards will need to be at the top-level.  Otherwise, I think some kind of manual propagation of the values like this is required.
hmm does this add extra args you don't want or something to imageDeleted?

Seems like you could pass it directly and avoid the extra anon functions for each onchange?
Just to avoid 4 lines, 

current =  (current == '#') ? 'und' : current

but is just an opinion. Up to you :)
this reminds me of something.. :)
Same that above ;)
Seems like you can be sure of the value of undefined in your context. No need for that :)
This is valid for all occurences of
(function(undefined) {
})();
I learned something new in clojure core.  that hasn't happened for a while :)
Oh, this is indeed an error. It looks like there are problems with parsing spaces. I didn't notice in my tests as in Dutch, we like to combine everything in one word.

This should be solved when fixing the script, and not too hard to do (I think)
I don't see this phase in the state machine; is this actually valid and functional?  @lynxbat, @tjmcs, perhaps you can confirm?
See https://github.com/fnichol/Razor/commit/d918df2394f76583c39907a3f9c2d20bb2898a54
This seems like a wrong / miss-leading error message. We should validate that the provided value is a string and the error should say something like "Value needs to be a string".
‘白衣女青年’这个称呼是不是应该修改一下？
另外‘撤退’被修改了，也就是大boss的职业设定变了？
Moved this into the class of the monoid, which already had a function to create a sketch out of a single item.

Should these be in the companion object instead? I put them in the class instead of the object since the monoid takes parameters, which are required for creating the sketches, and I'm not sure if there's an object-y way of doing this.
Categories with the access type "joomla.group" are automatically asigned the access level 0 (See line 505 ff). Now that I know that other plugins can handle the access level as well, maybe the getAccessLevel should be rewritten, so that only joomla.level access types return an access level.
New code doesn't work in all cases.

I would restore the old code and do this instead:

    // Combine 572+573 into this:
    if ($target instanceof KunenaForumMessage && $target->getTopic()->authorise('read')) {
Typo in $isNew
use `$.formData`
`data` -> `form`
Your docstring says that zen_tickets is already a list, why call list on it?
I'm not actually sure if we want to document all these attributes.
Shouldn't `Endpoint` have enough information to generate this?
The factored asserts are usually present when some aspect of the results does *not* need to be part of the assert, either because it's irrelevant or dynamically generated.  In `assertBuildset`, in particular, the boring value is the sourcestampsetid, and the much more interesting value is the sourcestamps *in* that set.

For cases where the entire value is fixed by the test, I think this form - an explicit assert of everything - is clearer than a factored form where "boring" expected results are set by default.

I'll take another look and see if I can at least make things consistent.
Why delete this line?
Why should use *va_copy*? If not using it, it's also compiled ok.
What's more, it seems that **CCMenu::alignItemInColumns** cannot works correctly,
When app run into **tolua_Cocos2d_CCMenu_alignItemsInColumns00*, an error occurs.
Any ideas?
Please rename this "pruneRemoteAliases"
{github,GitHub}
The problem is that I missed a paren. The fact that using let* like that worries me about Chicken scheme (I usually use Chez). Here is the correct code:

```scheme

 (define-monad
    <writer>
    (lambda (a) `(,a . ()))
    (lambda (a f)
      (let (b (f (car a)))
        `(,(car b) . ,(append (cdr a) (cdr b))))))
```
you should not be using strings for the descriptors as that is not type safe and a pain to maintain. Take a look at the Type class in ASM as it has helper methods for descriptors and etc, so that you can make your code type safe.
Use # instead of =begin
dunno what the Scala conventions are for `if` statements without braces... @daithiocrualaoich?
hum...strange about the import .
No, if returnEvent is set, the text area is implicitly single lined and we don't want to add a newline. return false is necessary to short circuit any further handling of the event.
As we discussed in IRC, we agreed on:

1. Remove `atob` and `btoa` from `chrome` module
2. Create a new `api-utils/base64` module that exposes the base64 encode/decode functions
3. Update the old `api-utils/utils/data` to notify to the developers they should use the new module instead
Is there a test that makes sure this works correctly if the issuer stays the same?
Correct me if I'm wrong but the credential caching only applies to HTTPS. Since we're using ssh for the clone, maybe this optional step is unnecessary?
@ozten That's the error that was hiding the first error of posting to /verify without certificates, since that throw was unreachable. 

BTW, the crypto.js change looks good to you too?
this can be `if source is configobj.ConfigObj:`
Is this actually necessary? It shouldn't be, as long as you set DJANGO_SETTINGS_MODULE before importing settings, which it seems like you do.
Nit: I know this is just fake data, but a newline after the comma would be better in general for style.
Nit: I think we want comments about the route above the function declaration, not like Python in a docstring.
Makes sense. In any way I have filed is as [Bug 765717](https://bugzilla.mozilla.org/show_bug.cgi?id=765717).
change messageboxes to be the parameter that is passed to findBff
I don't even know if it is correct to have all this default users in the repository! Maybe just the main roles for test purposes...
Thanks!
Stefano

-----Original Message-----
From: Eko Suprapto Wibowo [mailto:reply@reply.github.com] 
Sent: 31 May 2012 11:27
To: Ricci, Stefano (FOM)
Subject: Re: [collect] Reengineering (#2)

> @@ -0,0 +1,93 @@
> +INSERT INTO collect.ofc_user(id, username, password, enabled) 
> +	VALUES(1,'eko',md5('eko'),'Y')

ok. understood!

---
Reply to this email directly or view it on GitHub:
https://github.com/openforis/collect/pull/2/files#r906313
this may not be the perfect example because swapfree and sawpsize are identical. If the line is parsed in the wrong order your test will not fail.
:last-child doesn't work cross browser. If you need to select it this way, you'll need to add a class with a jQuery selector, e.g. `$('ul>li:last-child").addClass("last-child").

Then in sass: `&.last-child`
Need a comment in the code explaining what is happening with that last argument -- what it's creating, and why -- so that others coming in later know why it's there.
Please put a space between else and { 

else_{

else {

(And rebase so as not to make two commits, please. :) )
This should be end, probably just a typo
Note that to run tests you'll have to do `foreman run bundle exec rspec spec`
should be split over two lines i guess
Btw, I'm not sure all internal changes (i.e. not affecting people installing the app directly, like DB migrations do) should be added here. It adds more work and you can already look at the git history if you want a full history.
(and otherwise, you should build all the missing parts of the changelog)
This is what triggers the bug, because the getter clones the collection before returning it (and we do this quite often, to avoid indirect changes to internal data (by accident) through references).
makes sense .. i simplified the code accordingly. dont think its the responsibility of this code to ensure that there is still a persisted translation left.
To me it's about how it reads, but yes it's just personal preference.
I was thinking about this. I'll change it so.
Hi,

most of requested interventions have been done;
I'd rather postpone further beatification for next sw release, if needed.

cheers,
Fotis
Fix the TODO's first please.
Should be: `check()` (no space before first paren)
This really needs a comment to explain your general flow.  It's only obvious to me because we've discussed.  If I came to this code cold, I'd be hard pressed to understand what problem you're trying to solve.
The <%= ts part of the translation string is missing here.
config/initializers/constants.rb
に書くのが宜しいでしょうか？
移動させます。
should we allow to destroy a location that has hosts?
I guess that  this's not answer for thinca's question.
Why you change `=file` to fnamemodify? `=file` seems to be working good to me.

```vim
:so `="foo!bar.vim"`
```
ok. thank you sir!
You could have just used string concatenation here ;)
Which changes? I'm not seeing them... It's probably me not being able to find them.
nah not really - just being explicit
s/severs/servers
Sorry about the delay to answer. I am using Ubuntu 12.04 LTS. x86 with
EXT4. I am guessing is an issue with UTF8 normalization.
Some charactares are encoded slightly different.

On Mon, Jul 9, 2012 at 9:14 PM, Nick Novitski
<reply@reply.github.com>
wrote:
>> @@ -17,6 +17,8 @@ responder = (fn) ->
>>  app = express.createServer()
>>  app.get /// ^/card/(\d+)(?:/(\w+))?/?$ ///, responder api.fetch_card
>>  app.get '/card/:name',                      responder api.fetch_card
>> +app.get /// ^/lang/(\d+)(?:/(\w+))?/?$ ///, responder api.fetch_lang
>> +app.get '/lang/:name',                      responder api.fetch_lang
>
> What OS/filesystem do you have?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/davidchambers/tutor/pull/17/files#r1127512



-- 
The lights then came up and the crowd erupted in applause, because
that's what the crowd does after it watches destruction on a large
screen. -- Ben Kuchera, Modern Warfare 3 review.
:0 Will fix that.
Do you remember what have I told you about feature branches? 
This should go to separate branch, not this one. Please revert this changes in "Feature" branch and create new one.
autoloading all these won't get you much, because you're going to reference them all right away, though it does give a nice map of the namespace...
Is this syntax actually correct?  I think it might need to be:

((some-fn nil? sequential?) query)
I should probably also mention that this is not actually executing the test.  This is executing a script that returns a list of command-line invocations, each corresponding to a test.  These are later passed to other nodes, which will actually run the tests.  This was true before my changes, as well, which is why I renamed the functions from `do_test` to `generate_test`.
Yea that would avoid validating the user parameters in the request "chain". I'll make that change.
`JSON.parse` will throw an exception if there is bad data. Should we try and catch that and handle it through the callback instead?
These should be single quotes as well. I'll fix.
Wait a minute, I'm an idiot. I have uncommited code that does just this.
Ok so in that example for 3x you gave it will only return true if html or
json are listed explicitly?

On 2012-04-15 12:07 PM, "TJ Holowaychuk" <
reply@reply.github.com>
wrote:

> @@ -135,8 +135,8 @@ req.accepts = function(type){
> // normalize extensions ".json" -> "json"
>...
in 3x you can also now do `req.accepts(['json', 'html'])` which returns the
acceptable type (if any) which is probably more what you're looking for,
this variant will not return a random value even with */*, that's up to the
user to default


---
Reply to this email directly or view it on GitHub:
https://github.com/visionmedia/express/pull/1020/files#r686089
The headings have a search bar in them for most- hence I didn't put anything there. Current headings are merely placeholders. Don't think this should be generalized. showPage should just do the page showing :)
Dispatch AsyncModule should be explicity install in clientmodule instead
óÐÁÓÉÂÏ, ÄÏÂÁ×ÌÀ ÐÒÏ×ÅÒËÕ


On 12 November 2012 13:35, S. Lebedev <notifications@github.com> wrote:

> In DNAProject/Cell+Mutator.m:
>
> > +//  Created by Olga Andreyeva on 11/4/12.
> > +//  Copyright (c) 2012 Olga Andreyeva. All rights reserved.
> > +//
> > +
> > +#import "Cell+Mutator.h"
> > +
> > +@implementation Cell (Mutator)
> > +
> > +- (void) mutate:(int)x {
> > +    NSMutableArray* indexes = [NSMutableArray arrayWithCapacity:self.DNALength];
> > +
> > +    for (NSInteger i = 0; i<self.DNALength; i++) {
> > +        [indexes addObject:[NSNumber numberWithInteger:i]];
> > +    }
> > +
> > +    for (int i = 0; i<x; i++) {
>
> ðÒÏ×ÅÒËÁ ×Ó£ ÖÅ ÏÂÑÚÁÔÅÌØÎÁ, ×ÁÍ ÍÏÇÕÔ × ËÁÞÅÓÔ×Å ÐÅÒÅÄÁ×ÁÅÍÏÇÏ ÐÁÒÁÍÅÔÒÁ
> × ÜÔÏÔ ÍÅÔÏÄ ÐÅÒÅÄÁÔØ ËÁË ÏÔÒÉÃÁÔÅÌØÎÏÅ ÚÎÁÞÅÎÉÅ, ÔÁË É ÚÎÁÞÅÎÉÅ Ó×ÙÛÅ 100.
>
> --
> Reply to this email directly or view it on GitHub<https://github.com/Hexlet/osx-project-1/pull/338/files#r2095342>.
>
>



-- 
÷ÙÂÏÒÙ × ëÏÏÒÄÉÎÁÃÉÏÎÎÙÊ óÏ×ÅÔ ÒÏÓÓÉÊÓËÏÊ ÏÐÐÏÚÉÃÉÉ http://cvk2012.org/
Ниже используется массив, что правильно. А не такое развесистое дерево if-ов (а тем более есть оператор switch, который тут уместней)
also why the stringify here? and not just regular concatenation like below
Shouldn't the second argument be `array('_id' => 1)`? I realize that's not your fault, but this would be a good place to correct it.
It's also a little fuzzy if we should be removing licensing stuff that people add to their scripts. Or, we have to assume they are being made under hubot-script's license, and remove it from all the scripts that have it.
Could you format the description like the following https://github.com/github/hubot-scripts/blob/master/src/scripts/commitmessage.coffee
but fair enough if you want them in the same figure. Maybe plot_evoked could take a pylab axes instance to be able to do this...
Nit: I try to keep line lengths below 72 characters. I would put `return true;` on a new line.
See the comment on line 84, on line 86 after calling spy, i call Context.clearSession(); which results in the call to Context.clearSession() to be ignored since there is no hibernate session to clear other we will get a NPE. Actually this is one example that shows a problem in our api where we are letting hibernate logic bubble out of the dao layer, so in my tests i try to suppress that
One last thing. Shouldn't this be `from` instead of `_from`?
I don't think that this is going to work the way that you intend it to work.  Maybe someone else can chime in on the jenkins environment and vlan tagging on eth0 - will it pass between vms?
Can probably just use `should validate_presence_of :secret_key`, two birds one stone.
Completely agree. Don't know how I missed that. It's even nicely written up in the 2.0 docs Pi example.
why not toSet?
I think since we use scrollX and scrollY above, we should use those here too, since they are equivalent to pageXOffset and pageYOffset. <http://www.w3.org/TR/cssom-view/#extensions-to-the-window-interface>
BillingStateProv ... and this is what codegen (or DSL?) is for...
Debería decir `Git Hub` en lugar de `HitHub`.
Pensé que agregaba validación del lado del servidor. Si no lo hace, entonces no tengo ningún problema.
The last regexp should include a '-' in order to catch MiSeq flowcells
I'm guessing this fix is as simple as deleting row 73?
Hah! You are too fast for me lol, lines changed
```php
echo ' Path: \'', $context['available_themes'][(int)$_POST['delete_theme']]['theme_dir'], '/images/membergroup_icons/', $_POST['delete_img'], '\'';
```
Something went wrong, please contact an administrator.
Correct. I will make this fix, as per @primalmotion's request, reopen this PR in a moment.
Use remote filename as part of the temp filename to prevent collisions between different versions. For example, if the remote path for package `foo` is `http://getfoo.com/download/foo-1.0.4.msi`, the local temp filename will be `$chocTempDir/foo/Install-foo-1.0.4.msi`
Can this be done portably?
This syntax won't work on python2.5 IIRC.

You could use the following instead:

import sys 
...

except Exception:
    e = sys.exc_info()[1]
    logging.error(e)
From what I could see we were handing the ModelNotFound up higher than we should have because we weren't catching it here.
This gets triggered when the baseline images don't yet exist. It might be better moving this to above the convert & adding a check on the actual image existing too.
You might replace the parenthetical explanation by saying, "...meant to be used for cyclic variables such wind direction or time of day",
In all the examples like this, I would favor using more indentation for the second line, perhaps aligning it with the start of the RHS of the line above.  This would make it more visually obvious that it is a continuation of the line above, not an independent line in a block.
I've got a pyflakes warning on this line. ``x``, ``y`` and ``xi`` are undefined. I'm guessing this function doesn't work.
I think it would be better to just kill the launched app by name here.
![](http://3.bp.blogspot.com/_H6F_zPmpCxE/SK24fKXD7xI/AAAAAAAAArU/p3mQlRmsT_U/s400/intense_porpoise.jpg])
The whole point of having this callback is that multiple loaded tiles can be combined to be rendered in a single reflow, instead of one reflow per loaded tile. The way it works is that when a tile is loaded, it will not be made visible (reflow!) immediately, but when the browser decides it is a good time to do a reflow. In the meantime other tiles may also have finished loading, and will be made visible in the same reflow.

If you want to see the image placeholders without requestAnimationFrame, you need to remove the fade animation css, close the page, clear the cache, and open the page again in a new tab.

Setting visibility needs a reflow in all browsers (see https://developers.google.com/speed/articles/reflow), and we also need to set the opacity to start the fade animation properly. This is why both is done in the callback.

The execution flow is like this: setting the img src means we start loading. Then some time later, the image fires the onload event. Now we schedule the reflow that will make the tile visible. With the callback, the whole process finishes, so I decided to trigger loadend here. It may also allow us to remove the backbuffer immediately when the last tile has finished loading instead of using a delay, but I haven't investigated that yet.
My bad. Sorry, dude.
Try to avoid long lines here. The PEAR coding standard we use dictates a 85 character limit.

Never mind about the descriptions, wrapping them will make it more confusing.
Using `<button>` rather than `<input type="...">` is more semantic.  Also, consider using `class="btn"`
@arnodeclercq Can we use the `sakai.api.Util.include.css` function for this?
It should also check whether that stylesheet is already loaded.
@nicolaasmatthijs Can you explain the `a, b, c, d, e, f, g, h, i, j` in the code? I think this might be confusing for some people.
This allows the the variantKeySpec to be an empty array and not force a regeneration. This is an edge case where there currently are no specs for environmen (live, dev, test), env variables or constants in a yaml config file.
I think you want to use "noble", not nobel here.
The conversion rates that shows up on vanity dashboard originally is actually #converted/#participants, not what the 'conversions' variable in the code tracks (I'm actually pretty sure they don't use/display that variable anywhere, don't know why).
The metric counts I'm tracking is different from the conversion rate in that it can count one participant multiple times.

Allowing multiple saves won't work because there's no way to regulate the hooks being set up (unless we define a whole new data structure to give each hook some id and whatnot, but that is 1) extremely not worth the effort, 2) still not guaranteed to work. Also from what I can tell, save is not intended to be called multiple times, as it checks for instance variables such as ```@alternatives``, ```@metrics```, which can only be set once before their setting methods are re-defined to accessor methods (you should remember this from working on default).
I'm not sure if it's smart/necessary to wait for the thread to finish while holding the process lock.

We could possibly set the cache_pool_tid to NULL while holding the lock, and wait for the worker to stop once we've released the lock. Would need to be more careful in the worker to ensure that multiple workers could be alive at the same time.
I had this explicitly because it was the only case where we might or might not be holding the schema lock.  Now I'm concerned that I have to look at every `WT_WITH_SCHEMA_LOCK` and try to work out whether it could be leaving the schema locked.
原則上 application.css 不要有 css
都用 import
上面這些, 和整體版型有關的用 layout.scss
和共用有關的可以用 shared.scss
Calls the restore_world function
Since you are not defaulting the params to anything, this will break backwards compatibility, and since this gem is in active use other places, this is not an option at the moment.
Are you sure the method ``setTitle`` can be called on ``$translatedContentPage`` (of type ``string``)?
The idea is the following:
In their code there is  the following statement
if (e.rowData.test) - this is like checking e.rowData.test to be defined (not null or not 'undefined')
I need to have the corresponding statement for BB and other platforms.
The proper way in JS to check if some object property or variable is defined is (typeof object !== 'undefined')
http://stackoverflow.com/questions/27509/detecting-an-undefined-object-property-in-javascript

In their code they just used (e.rowData.test) but as I understand the proper check should be (typeof e.rowData.test !=='undefined') as long as I am familiar with JS.

So this check is only verifies that 'test' property of an object is defined
Achso, stimmt :) Hat man ohne den Parameter zugriff auf den Request?
Maybe this section chould have a page of its own
I guess test_rsync_exclude_sources_chefignore should not have been removed. It just happened to use the erroneous file to save duplicated code.
why not keep `left: '@px'` by default, only for special cases use an object. Is smaller and probably better for backward compat.
Maybe @adriaanm could verify?
Any reason not 755? Since this will currently be written as root in most cases I suppose it doesn't matter much.
What's the deal with all this whitespace?
Where project-specific configuration of IDE plugin should go then?
Don't *hardcode* the links.
This is not needed. If you don't define a method, then first one found in parent classes will be used. Exactly the same as you are doing here.
Keep the style consistent.
And then all this is unnecessary. :-)
A comment discussing what we are doing here could be useful, above this line. For example:

```
# Fetching data only once per possible duplicate locations
```
```
{% if user.facebook_id %}
```
`user/email_confirmation_send_token.html`
We use `" ... "` for user-displayed (translatable) strings. (This way it is easy to search for them.)
This empty line is not needed here?
No, in the current implementation either description="COMMENT" or description="" are parsed as comment. Similar applies for LYRICS and URL (see the documentation of properties() in id3v2tag.h).
Is this the only thing we care about? That the method doesn't throw?

Shouldn't we at least test that the value returned isn't null?

Can we do more? Can we verify that the generated Resemblance is equal to the original value?
Push to parse()
swap these 2 checks to avoid unneccessary guild lookup
If the test is invalid, you should remove it, commenting doesn't help.
I'm wondering if it wouldn't be worthwhile to make a second method for the duplicating functionality?

IMO, this method is well written, especially after the else clause, but it is a bit lengthy and handles two related, but different things.

How would you feel about:

def post():
    return self.duplicate_post() if request.POST.get('duplicate') else self.update_week()

or something similar, perhaps using auxiliary variables and more lines. Then defining a method for duplicating and updating the week separately?
This should probably be `if [ -d "$HOME/.rbenv" ]; then` to support people with spaces in their `$HOME`.
authenticateResultInfo feels like it should be used for a authentication failures, ie an identity/cedential pair that doesn't validate. This error is only going to happen if something is seriously wrong with the code - ie ->getRepository($class) doesn't return a $class instance.
Удобней делать функцию, возвращающую сконфигурированный парсер
you can use in any([value in self.commands for value in sys.argv])  here
Looks fine, although checking for visibility might be a little more robust (against string changes).
Yes it's tricky situation. I am starting to use the bidpom a little bit beyond what it is aimed for because I am directly testing BrowserID rather than just logging in with it in order to perform the test on the main site.

To access properties like the `email` I need to get the page objects directly.

It is not pretty, I apologise.
Again, can this be a separate pull? It will also require the latest ChromeDriver to be present.
How can you have children on a tree view ?
I think it would be better to call node_access() and have a hook_node_access() that will return DENY as needed.
And on accessing element without check?
I have seen this throwing SECURITY_ERR, I guess that depends on the "Let Site Access Clipboard" setting. Will that stay this way? We should probably have feature detection that sets a flag to offer clipboard dependent features. This might also be different when Dragonfly is used from file://?
We don't really have a standard for it, but this is not how we usually write templates. I'd do
```javascript
["span",
  (entry.current_request && entry.current_request.method + " ") || ""
]
```
How does catalog get to here?  Does optparse do some magic? Or do we need to load and sort it?
You can do it :)
Small typo here.  s/to/from/
Line 12.
Why div and not span? `img` is inline element, so use span to keep everything inline.

BTW, why one more element around? Why not just class attribute to the img element itself?
Can you just add some whitepsace between the LOG macros and the code.
Good job he bolded that space too...
Needs to be spaces not tabs.
The same here, please no spaces between jQuery( ... )
Can you make sure you look at this in a subsequent pull request please? I won't let it block merging now though.
synch looks good.  neat pattern for batching blocked requests.
I'd remove the commented out line, and expand the comment above if it's not clear that it refers to behaviour if one changed it to `return false`.
This code is also mostly duplicated from the activity_controller code. I'd suggest moving some of the code into the model and then adding a helper which computes these properties for the material and generates the block of html.

So I'd add a method on Activity and Investigation called full_title. For investigation it would just return the title, for Activities it would append the parent.title like the code in the activity controller is doing.
These two controllers could just set one instance variable `@material` , the layout code can check for that and call the helper to generate the meta tags. It is possible that `@material` is used in other controllers so then perhaps you could call it `@sharable_material`
The description string can be generated using the `@material.model_name.human`
The image url should probably just use `@material.model_name`

One thing I'm not sure about is whether the helper will have access to the request.url, but I think so.  It might be better anyway to use a url helper to generate the appropriate url from the `@material` object instead of using the request.url.
This should not be casted to `int` and it should be `null` instead of `0`.
> That very unambiguously says it's meant to produce the names of function properties.

Well I think equating methods with the specific class of function, is muddling up our argument here.  If we are looking for methods, then what we care about is whether it is callable.  If we are looking for specifically classed functions, then everything you have said is 100% correct and I understand your argument completely.  I assumed that by aliasing _.methods with _.functions, we were looking for just that methods, not specifically classed functions.

If you really want me to change this one line that results in a 6x performance boost on some browsers, I will.  But I think then there is an argument for a separate more loosely defined _.methods that returns callable object properties.
same thing ! :) . Line above use tabs and line below too. but old line between {} use space. No problem i replaced them by spaces. But Christian in cmyth there is no rules for indentation. Probably we need to reformat all in one time.
Maybe import com.griddynamics.genesis.api._ ?
FWIW, these JSHint warnings can be disabled by setting `eqnull: true`.
You should use `get` instead of `match`. See https://github.com/rails/rails/pull/5960
Should we deprecate the `add_cc` method in this case?  Was it ever an option?  Are there plans to bring it back?
Looking up by PK can be problematic as it's a detail of the DB implementation.  Ie, running these tests on Postgres will generate different primary keys.  It's always better to use some ID that you set explicitly.
In general, it's nice for end users to know which classes represent entry points to the API, and which are generally for internal use.  I'm guessing this is a class for internal use, but that's not immediately obvious.  Documentation helps in this regard.
In Ext JS 4 it's not complete different, it just an other method :
http://blog.coldfusiondeveloper.net/index.php/2011/extjs-4-0-overview-guide/
myFunction.createDelegate(this)
=>
Ext.bind(myFunction, this)
Why that? Is there a bug somewhere?
Ref: https://github.com/AllPlayers/allplayers.php/pull/4
why ternary operator ? 

prefer early return, far more readable.

Also Are you sure about Datetime objects comparison using `<=`
I like the rake approach. You can merge it, if you want.
I think it's just ugly to have a class in "pipeline" package, that deals
with lot's of concerns (e.g. datamanger)



On Wed, Oct 31, 2012 at 3:18 PM, Daniel Passos <notifications@github.com>wrote:

> In src/org/aerogear/android/impl/pipeline/AdapterFactory.java:
>
> >  import org.aerogear.android.impl.core.HttpRestProvider;
> >  import org.aerogear.android.pipeline.Pipe;
> >
> >  import java.net.URL;
> >
> > -import static org.aerogear.android.impl.datamanager.StoreType.MEMORY;
> > +import static org.aerogear.android.datamanager.impl.StoreType.MEMORY;
> >
> >  public final class AdapterFactory {
>
> The RestAdapter used in AdapterFactory is default visibility. If I move it
> from out of pipeline folder I'll have change RestAdapter visibility
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/aerogear/aerogear-android/pull/22/files#r1992485>.
>
>



-- 
Matthias Wessendorf

blog: http://matthiaswessendorf.wordpress.com/
sessions: http://www.slideshare.net/mwessendorf
twitter: http://twitter.com/mwessendorf
This could use some links to functions or somewhere to read more about the ini setting and function.
Правильнее String.CASE_INSENSITIVE_ORDER
BufferedReader тоже имеет метод close. И его тоже надо в finally закрывать.
{ должна быть на предыдущей строке
На то синхронизация и придумана как бы.
My knowledge of SSL is limited, but would it be possible ([as described in the docs](http://docs.python-requests.org/en/latest/user/advanced/#ssl-cert-verification)) to use /etc/ssl/certs/transmission-cert.pem and/or /etc/ssl/private/transmission-key.pem in the `REQUESTS_CA_BUNDLE` environment variable to get these requests "verified"?

Or am I totally off in left field?
Yep, I actually saw this code failing - had to fix it.
But on XBMC, you may select one of the two flags, that will be unsupported by teh addon configure, leading to compile the internal version of the file and it will break
Yay for declaring dependencies!
Not necessarily for dev_4_1, but perhaps something that would be good to put in the BaseHandler class a la ```getFloat(Attributes attrs, String name)```
"and are" should be "and you are"
Build [OMERO-merge-develop#55](http://hudson.openmicroscopy.org.uk/job/OMERO-merge-develop/55) failed here
I usually also follow that convention. Just did it like that because `Pipeline.fit_transform` has a similar docstring and I took inspiration from there. Since the second sentence is no longer needed (requirement dropped), I'll just delete it.
Same here for the variables names.
I've added plot titles that should clarify things a bit - unfortunately, I'd to drop ``pl.tight_layout()`` because that didn't play nicely with the plot title...
зайве. юзера можна спокійно в вюшці витягнути
if the multilang admin is activated, this one must be set or we would have to throw an error. otherwise the error happens on undefined `symfony_cmf_content.multilang.locales` at runtime, which will be harder to debug.
I think this should be:

```
if ($canonical) {
  sscanf($this->_info['scheme'], '%[^+]', $scheme);
  $url= $scheme;
} else {
  $url= $this->_info['scheme'];
}
$url.= '://';
```

This way, `sscanf` is only necessary if `$canonical` is *true*.
Hmm... I know I did this deliberately, but now I have no idea why.
Si un utilisateur accepte, il est alors redirigé sur l'URL de redirection
If you want I can change it back to setting each property individually but I've avoided this as each setting parses the JSON string into an object, sets the property on that object and then stringifies it again. This probably isn't really a performance issue but doing it this way only parses and rewrites the string once.
I'd prefer it if we kept the existing coding style.
There could be, but in practice I never saw this logic retry more than once.
I think mods is short for modules.
I thought we never had any static objects because of problems initialising them.  There should really be pointers to critical sections initialised in MODULE_INIT
In practice, I think dali would need to be failing for that to happen. But I'll clean up and repush anyway
All of the above can probably be said about lots of these other variables.
homebrew provided `-mmacosx-version-min=<current-os>` already. I don't really think 10.5 is needed. But lets see if all the tests pass.
This will need to be localized. Otherwise it looks good though, but we should talk it over at our next meeting if this is how we want to address this issue.
You should really go to Tools | Templates to get rid of it :P
So you can pass ImmutableMap.of(...) without an explicit downcast to Map<String, String>
Hmm. The title is important, and the choice of "toolbar" was intentional.

The idea of this restructure, mostly, is to present tutorials by task rather than by technology. So, for example, one tutorial is called "display a popup" rather than "using panel". Because people coming into the SDK don't know or care about panel, they just want a popup. Similarly, I don't think people come in asking "I want to display an HTML document in the toolbar", they come in wanting to create a somewhat complex UI in the toolbar - or more likely, wanting to create a toolbar. That's why I chose this name.

It's true that what you can do using widget isn't quite the same as creating a toolbar, but (it seems to me) this is the best option for someone wanting to use the supported APIs. In this example you create an array of buttons, and - I'd say - that's pretty close to being a toolbar for most people.

Having said that - it is important that the tutorial explains the limitations of this approach, compared with a full-blown toolbar. If you think the differences between a "real" toolbar and an HTML widget are too great, and it will totally confuse people by referring to an HTML widget as a kind of limited toolbar, then I should rename this tutorial. But otherwise, I think we should keep the name the same, and in the tutorial describe the limitations (and maybe point to low-level APIs you could use to get around them).

Does that sound reasonable? If so, what would you say are the limitations, compared to a real toolbar?
I don't see the point of this class expression: apache_modules_toUpdate and apache_modules_ignore are two classes defines by exactly the same condition, one with a negation in front. So this is like saying "true or false", is it not? So this could just be "any::". Or am I missing something?
It's actually a template filter, not a tag.
same as above. create method in the page object to do this.
@shacker Do we really need the `if` here? What will happen when we have an `#each item` when that array is empty?
This Map (and the others in this class) looks like a constant and should be an Enum. Use valueOf() for the dictionary lookup. If I'm wrong and the contents of the map will be dynamic, then they should move into instance variables.
oops.. now i fixed it for all checks.
I think print_status has more sense here
Nope.

````ruby
@configdir = File.join(File.dirname(msfbase), "data", "svn")
````

If you pass `--config-dir=foo/bar`, it doesn't matter, it's always going to be set to `./data/svn`

Threw me too.
My fault! Really thanks for looking!
This is almost confusing, can you rewrite this on two lines?
It might make sense to allow this to be configurable — either the actual key name, or at least a prefix...
Well, I didn't say that it "makes absolutely no sense". And just to be clear, these are just my first impressions: they could prove to be very wrong after actually using it in real code. That being said...

My preference is to import modules instead of functions, in which case it wouldn't really be a burden to have many different transform functions. But I guess, this isn't always the case.

In my head, the *functions* (not classes as I accidentally wrote in my earlier comment) `transformation_similarity`, `transformation_similarity_inv` would create the transform matrix internally (i.e. `make_tform` would go away). So the function *might* look something like
```python
def transformation_similarity(src, dst):
    matrix = _make_similarity(src, dst)
    def warp_map(coords):
        return _transform(coords, matrix)
    return warp_map
```
Since most of the transforms would have similar signatures (excluding `polynomial` and `rotation`), you just write the bulk of this as a reusable factory function and have those transforms call the factory. One disadvantage is that you would need to recalculate the matrix if you wanted to call both the transform and it's inverse, but as I mentioned in my earlier comment, that overhead *seems* relatively small (that's just a gut feeling---i.e. untested). (By the way, would calling `_make_similarity(dst, src)` be the same as `inv(_make_similarity(src, dst)` and would one be faster than the other?)

Just to reiterate, this is my viewpoint without having used it in real code. It could turn out to be unwieldy in actual use. Also, I haven't actually tested any of this so there could be serious conceptual errors in my approach.
Same here. Committed the new version.
Can you please add an example in the docstring? The example of your test would be perfect.
Right you are, sir.  :-)
You could have a token implementation of this in 2D if you wanted to.  Use the target as the target and the eye to control the distance from the map.  Ignore the up.  I'm not sure if there's any benefit to that.
That's good enough of an answer for me.  At some point in the future we can clean up its usage to make sure the only code that really needs it is used.
Very cool.  Thanks.
There are several TODOs in this file, perhaps add them to the roadmap or - if they are relatively pressing - create issues for them.  Although I'm sure I'm guilty of having some `TODO` comments in the code, I want to minimize them so folks don't lose confidence when browsing the code and see TODOs that are really feature ideas, not pressing issues.

This applies to all the TODOs in this pull request, but I might have more specific comments when I get to them.
This should have doc, right?

Actually, these two properties are kind of strange because they will never get executed.  I guess it is OK since we are not documenting default values.  As we discussed, we may be able to write doc without any code.
I know it would be ideal if not specifying `MODEL` at all just built code for the native target, but I vote in favor of consistency with the other DPL repos' posix.mak files here. If you want to alter it in all the makefiles later, feel free to send pull requests for that, but let's just be consistent for now.
correcting issue I had with nextFloat returning in range 0,2 rather than 0,1.
Why not call it min python version or something like that instead ?
Nit: new files should have 2012
Could we do a len variable set to fns.length? I could see us adding/removing one of these in the future and forgetting to update this hard-coded value.
var dec at top
_capitalize() should not be passed the value. _setInternalText() should not return a value. You should only set the field value if it changes to prevent the caret from moving to the beginning of the field due to unnecessary clearing and re-defining the value:

    this._field.value !== value && (this._field.value = value);
We should add in a link to [iOS Human Interface Guidelines|https://developer.apple.com/library/ios/#documentation/UserExperience/Conceptual/MobileHIG/UIElementGuidelines/UIElementGuidelines.html#//apple_ref/doc/uid/TP40006556-CH13-SW1] on Tab Bar; "Don’t remove a tab when its function is unavailable." That is, just because someone can remove a tab, it's typically not good UI design.
where are createPerson and removePerson?
If that's the case, this is a bug where the FB module is being triggered by 'resume' and not 'resumed'.
Seth will want you to add a comment that says, "Don't use window.alert in real life ;)".
The featured extensions page title is the same as the home page title: "MOBILE ADD-ONS"
Ok, I fixed this and added a couple more tests.
Having one string would mean having in the string newlines which would screw up the line numbers in the file when the string is mixed in.

I couldn't use a templated function to solve the problem, because the function arguments change (e.g. the random-access version takes a length; the other doesn't). Otherwise, I would have just put this inside of `decodeImpl` directly rather than mixing it in as a string.

And a template mixin wouldn't work, because you can't mixin statements like this, only declarations.
This is in lockstep, specifically, for supporting lockstepping on a `immutable(T[])`:

`immutable(T[])` is not an actual range (no `popFront`), but lockstep seems to accept anything provided its unqual'ed type is a range.

TBO, this may work for immutable arrays, but I question the design for any complex range.