labofsahil/github-event-dataset-2012 huggingface dataset:
this was copied from the original ClientHandler exceptionCaught code, so I fix it there as well.
ok, changed to ignore ClusterDomainEvents (that was the intention) and rest are unhandled
sorry, one last thing, "utils" should be "util" here and in the following few lines
This may have been an accidental change during a manual merge from mainline. I'll revert it as I don't remember a reason for this change.
I think it is working in this branch now, I intended to test manually.  Well maybe I need to push that fix here.  Later code needs api work to get each message right, but that should be pushed down the road a little
the property itself has an underscore as the first charachter (convetion
for private variable)...so then: "on_" + "_offset" gives the double _

On Fri, Aug 10, 2012 at 2:09 PM, Michele Lacchia
<notifications@github.com>wrote:

> In kivy/uix/carousel.py:
>
> > +        self._offset = 0
> > +
> > +    def on_slides(self, *args):
> > +        self.index = self.index % len(self.slides)
> > +        self._insert_visible_slides()
> > +        self._position_visible_slides()
> > +
> > +    def on__offset(self, *args):
> > +        self._position_visible_slides(
> )
> > +        #if reached full offset, switche index to next or prev
> > +        if self._offset <= self._extent * -1:
> > +            self.index = self.index+1
> > +        if self._offset >= self._extent:
> > +            self.index = self.index - 1
> > +
> > +    def on__drag_touches(self, *args):
>
> Why double underscore? Is there some Kivy convention I am missing?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/kivy/kivy/pull/626/files#r1354555>.
>
>
I don't think that this value is correct based on the existing values it is looking for below.
You pretty much have the logic down. sphere_eval takes a sphere with N points and returns an array of length N. In this case we create a sphere with one point. The main peak finding function we have in dipy is called `local_maxima`. It is a discrete peak finding, we use it on line 140 to find the seeds for the non-linear search.

Boundary conditions are not an issue, I believe, because we eventually convert back to Cartesian coordinates and return unit vectors. ie theta=pi, phi={pi, 3pi] will both result in the same unit vector so I don't think we should should have any issues.
JavaScript has [hellish type coercion](http://bonsaiden.github.com/JavaScript-Garden/#types.equality) which comes into effect when using `==` so it's considered best practice to always use `===` which is an explicit comparison.
Right it's the equivalent of going through the action functions via `get_action("...")(context, {})`, too sleepy today
I'd rather this be `now_playing` rather than `current`. (Also can you add periods to your TomDoc.)
Typo in "usednby".
Looks great. Apart from minor suggestion above, it's ready to be merged.
looks like you broke something,  type_id should never be less than one.  if it is, something is wrong and should be fixed at the source
Let's close this here and move to the later branch.  If it isn't changed yet there, I will fix.
actor.start() should come after putIfAbsent otherwise the actor migth be started but never used.
Если обращения нет к этой переменной помимо этого класса, сделай ее private
Are you using shoulda? I don't see it used in your test.
Seems unnecessarily complex. Why not just have `-M`, `-R`, `-C`?
why is there so much new code here?  it seems like console should not be changed.
Returns a {@link List} of additional {@link Resource}. These resources do not require user confirmation before deletion.
This line looks like it needs a comments about this `read(None)` trick.
I don't think this is necessary.  The test system is for internal use.  If we guard against this particular mistake / malicous action, why not against many others?
``context.watch`` returns the actorref that is passed into it, so I'd watch it immediately:

    reader = context.watch(
       context.actorOf(Props(new EndpointReader(codec, handle.localAddress, msgDispatch)), "endpointReader-" + URLEncoder.encode(remoteAddress.toString, "utf-8"))
    )
not sure whether 'susyTree' should be in defaults ('/' might be preferable)
It should be ``Twig_SimpleFunction``
Can you please pull out this cast and assign it into a properly typed temporary?
This condition should be inverted to avoid an empty body.
`performs` doesn't make sense in this sentence, it would make more sense to use `provides`. My other issue with this is that we aren't linking to the PHP extension. What was your reasoning for that?
Oh, it’s because of the omission of `require`…
`null`s don't come out well when drawing individual SVG elements, so I filtered them out.
Retour au groupe
my mistake  ,you are right,many  php version on my PC,i confuse the version,sorry.
C89 says in §3.6.2 

          compound-statement:
                  {  declaration-list<opt> statement-list<opt> }

Or in other words: In a code block enclosed by { } variable declarations go first, then statments. So this is valid:

          { int a; foo(); }

whereas

         { foo(); int a; }

is invalid. This is different in C++ and C99.
Just cleaning up line length (79 char max)
Should this be `OneTwoThreeSave`?
Should not we doing an assertion here?
We will need to document this method.
Could you take the opportunity and remove `/tree/master` from the url? This will trigger a redirect that we can avoid :).
the test name is misleading, because the cost is not set in the `User` model - it's global
> This is not thread safe, because Set is not thread-safe. You can't access a Set while some other thread might be adding/removing elements.

In general I agree with you - there's no dispute that Set is not in general threadsafe.

But in this specific use case I *think* it may be fine. We are never removing elements from this set, only adding them. So the question is reduced to the following:

If I call `@@compiled_delegators.include?(method)` while another thread is in the process of adding an element to the set (remember, this is the only mutation that will happen), could the call ever return false, when it should actually return true?

(We don't care about the element that is being added by the other thread, because for that element, `super` cannot be true, because the method hasn't been defined yet.)

I think the answer to the question is no, once the element is in the set, it will not be falsely reported that it is not in the set. However, this is a rather implementation-specific question; the answer may actually vary among ruby implementations. (I wish such things were better documented...)

Anyway, on reflection I take back what I said. We should put a mutex around it because it's less hassle than being almost-sure about what happens if we don't have a mutex. By using a mutex the code is more obviously correct, even if it would do no harm to leave the mutex out.
No final?
It would be great to have a dedicated `preSuper` field in `Template` and to synthesize the primary ctor on the fly in `typedTemplate`, but I'm not sure how this would work with namer. 

I suggest I explore this in 2.10.2. That'll be the time for macro annotations, and then I'm planning to dig into symbol tables and synthesis of methods and companions. Currently I'm under a mild pressure of delivering type macros soon, so I wouldn't go into this right now.

P.S. Can we freely change the signature of `Template`? Reflection is officially in flux, but by doing so we're going to screw up all the plugin writers, probably, the IDE and, most likely, SBT. What do you think?
Before applying your fix this line would fail with an error?
Magic number is magical. Pull out to a named constant and comment what it is for
where's the like button :)
scala> val t = u.newTermName("???")
t: u.TermName = ???

scala> t.encoded
encoded       encodedName   

scala> t.encodedName == t.decoded
decoded       decodedName   

scala> t.encodedName == t.decodedName
res0: Boolean = false
This is important and it would be great to see it promoted from "TODO" to "DO".

I suggested years ago that we should have dedicated classes for the major List[List[T]] players (argss, paramss at least) rather than blurring the lines by shoehorning everything into a shared and lossy structure - lossy at least in the sense that Nil willingly hops between levels, and also because at the type level every List[List[Tree]] looks the same. The passage of time has only made some structure seem like a better idea.
This is again a change in formalism.

Are all these actually errors in the previous code (which is quite possible!) or just another formalism? If it is the latter I do not think that it is justified to change it without explaining the benefits. If it is the former, it should be clearly stated in the commit message that there were extensive errors in the older code.
I would like to have the permute method and it should return a new instance.
I wonder if we should try to coerce in `__eq__`.  I noticed that other ring classes don't do this either, like

```py
In [15]: QQ[x](1) == 1
Out[15]: False
```
Leftover from  debugging?
I think there is a way to get all of the operators ne, gt, ge, ... for free once you have compare. Basic might do this for you. If not you could look up on google. There might be something like __cmp__.
`is_builtin_sequence`? The function is rather hard to name as its implementation is the only good way of describing it (this is often a sign that it would be better to inline it).
On Wed, Apr 25, 2012 at 9:01 PM, Tom Bachmann
<reply@reply.github.com>
wrote:
>>      from sympy.polys.polytools import Poly, factor
>>
>>      if a != 0:
>>          return _eval_sum_hyper(f.subs(i, i + a), i, 0)
>>
>>      if f.subs(i, 0) == 0:
>> +        if simplify(f.subs(i, Dummy('i', integer=True, positive=True))) == 0:
>
> I agree but … why? [It's 77 characters ^^]
>

(But the leading 8 spaces brings the line to 85.)
да, ты прав. избыток кода
By the way, you'll need to create the CoGroupedRDD directly with new CoGroupedRDD(parents, new HashPartitioner(parallelism)). There's no API for it on the RDD or PairRDD classes yet.
If it doesn't have a schedule, you can remove this line.
I mean that it's an "inner" script, that shouldn't be run directly
I just noticed that this method is called `getProcessedResource`, and not `getPreprocessecedResource`.  Do we want to change it and make it even longer?

Also, I can move the creation logic out of the cache and into resources.
What's the difference before and after?
What came of the deliberation to tighten up the FK constraints between views and parent categories that is currently only enforced in the application?
needs colon.
I run these again.

Real Time Without Patch: 01:06
Real Time WIth Patch: 01:14
Real Time WIth Patch and Single Transaction: 01:07
Why is this now here?
$db->sql_freeresult($result); missing
This doesn't seem acceptable. Shouldn't there be a way to figure out the style based on old template path, style and theme data? At the very least this means we need to have very very good documentation on how to convert 3.0 styles into 3.1 styles.
This should not be in colours.css. Only color values and image urls should be in this file. 

Please move this and other border-radius entries to correct files where those selectors are defined, for this particular selector correct file is common.css.
Cut this line at 79 chars please.
"specificed" => "specified"
This description of parameters should be merged with the `@param`s below.
fixed in 7d7b9db
These hardcoded namespace references caused this test to fail after my patch. tns and ins0 actually refer to the same namespace. After my patch, ItemID will be namespaced by ins0 rather than tns. This change occurs because previously this item was just using the operation namespace name. Note that the correctness of using tns or ins0 is the same, so I just generalized the test by referring to the actual namespace URI, rather than its name.
I like 3. Too.   Possible enablePdf and enableHtml.   For now, PDF is the
real goal....

You also forgot, 6. Profit!
On Sep 26, 2012 5:16 PM, "Peter Vlugter" <notifications@github.com> wrote:

> In src/main/scala/com/typesafe/sbt/site/SphinxSupport.scala:
>
> > +  val generateHtml = TaskKey[Option[File]]("generate-html", "Run Sphinx generation for HTML output.")
> > +  val generatePdf = TaskKey[Option[File]]("generate-pdf", "Run Sphinx generation for PDF output.")
> > +  val generate = TaskKey[File]("generate", "Run all enabled Sphinx generation and combine output.")
> > +
> > +  val settings: Seq[Setting[_]] = inConfig(Sphinx)(Seq(
> > +    sourceDirectory <<= sourceDirectory / "sphinx",
> > +    target <<= target / "sphinx",
> > +    sphinxPackages := Seq.empty,
> > +    sphinxTags := Seq.empty,
> > +    sphinxProperties := Map.empty,
> > +    includeFilter in generate := AllPassFilter,
> > +    excludeFilter in generate := HiddenFileFilter,
> > +    sphinxInputs <<= combineSphinxInputs,
> > +    sphinxRunner := SphinxRunner(),
> > +    installPackages <<= installPackagesTask,
> > +    enable in generateHtml := true,
>
> Okay. Some options:
>
>    1. use skip
>    2. use enable as it is now (the inverse of skip)
>    3. use enable like publishArtifact where generatePdf called directly
>    would still run (and rename to generateOutput?)
>    4. make enable more specific to this case (so just use an enablePdfsetting and have html always on)
>    5. ...
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/sbt/sbt-site/pull/19/files#r1700786>.
>
>
Ok, confused. We say earlier if length of the split !== 1 return. Then we join what can only have 1 part. Am I reading that right?
az ali.md/b64 estefade karadm khodesh injori dade
man bi takhhhsiram :D
Thanks for the hints. Unfortunately I have to use Eigen, since the code requires a complex eigenvector calculation. I have added precompile surrounding, so that the code will be only compile with HAVE_EIGEN defined. Please let me know if it is fine.
please don't add extra blank lines
all lines should end with semi-colon
Do people ever put the +91 in front? Will it always be 10 digits even for land line/cell phone?
The error should just be `Invalid API endpoint: $method`

---

I think we should have general Reflection functions in `functions.inc` that we can use in a trait once we upgrade to `PHP 5.4`

Example:

```php
<?php

/**
 * @param mixed $class (object or class name)
 * @param int $flag (same params/style as ReflectionAPI... IS_PUBLIC, IS_PROTECTED, IS_PRIVATE)
 * @return array
 */
getClassPropertis($class, $flag);
getClassMethods($class, $flag);

/**
 * @param mixed $class (object or string)
 * @param string $method
 * @param int $flag
 */
function methodExists($class, $method, $flag) {
    return in_array($method, getClassMethods($class, $flag));
}

// propertyExists would be similar as well.
```
Remove ``s`` from ``bits``.
Took me a while to understand this sentence. It could just be me, but I would replace ``as`` by ``with`` (I understood ``as`` as ``because`` and it confused me).
Why? I think it is easier to put that enforcement here than in the grad method of every possible Op.
That loop should get the test_values if needed
because "\a" or "\b" is not a valid java strings while "\\a" and "\\b" are, thus java.lang.String parlance we need to escape the double quote, and the escape character itself "\\" remember please though that "\0\1\2\3\4\5\6\7\t\r\n" is a valid string ("\8\9" is not)
Don't leave random prints in your code.
Well thanks, I really appreciate your time on reviewing my patches and giving me some tip but I still didn't hear a single thing about how it should be handled, as in this pull request or as in http://git.io/mMA_Vg ?
Is there any way we could do this in the ```DS.Model.extend``` call?
> Ok, so, if the current code fits you, I can make a new pull request to clean up the commits.
> If I do it. Do I have to erase this fork and make a new one?

Please do not erase the current branch because it would delete the comments
that lead to your changes. Just create a new branch and a new pull request
for it.
It's a context thing. You need to call it when you're adding a column to an existing, non-empty table, but in most other cases the proper thing is just to not set a default.

I've had a DBA look at the database in a project, and raise an eyebrow at the arbitrary default for a datetime column with default=now; and he was right. That default was set by the equivalent code in South, of course.
Nitpick: Technically this is sitting under the `Output/post-processing params:` section. It should have its own section, like this: https://github.com/gem/oq-engine/blob/ede24737858a419f973c2a072cdaad85d942f04d/openquake/db/models.py#L738
The contact should be devops@openquake.org, not `info`.
It uses the same mechanism as `cabal test` (i.e., reconfigure and build).
are u sure we want to keep closeAction hide
snafu!

(copy, paste, revert, move back, forgot a line).

Thanks.
This is a great attempt, and thanks for contributing. But yeah, the truth here is what was discussed in the ticket: That a stacking doll approach is slow, error prone, and heavy handed. Really, the mistake we made was ever having hidden elements return >0 whether hidden directly or via a parent. The ticket remains open because it suggests what to do for the other dimension functions.

@PaulBRamos, I think we should close this pull, but I welcome further contribution. There are plenty of other open bugs to tackle if you're interested!
Yes, this paragraph gives an intuitive explanation of the formal definition. This statement ("the 0-quantile will be ...") actually applies to all quantile functions in MADlib, not just for special cases.
Where in PL/Python for example?
Yeah, there is a lot which is not reformat.
Where did this come from? Also, why the ugly one line with `&&`?
Agreed about cleaning up the duplicate lines.

Requiring `ARGV.debug?` is reasonable, although sometimes failures don't reproduce when run again -- for instance, see #13226. Another downside is cases like #13244; reading that, I wondered where in that code the error was originating, and with a stacktrace it would have likely been included in the issue report. Stacktraces are ugly, but so are failures.
Maybe we should auto-scan for bash/zsh completion scripts in the cellar after install instead of adding these caveats manuall.
Could you link to a specific location for the patch?
Should use `build.head?` and `build.devel?`.
If this is running autogen.sh, probably needs to depend on automake/autoconf when building head in Xcode 4.3, since it no longer includes those tools.
I'd prefer not to change the option name. This will break upgrade option retention for users who installed with the original name.
For block comments in JS files, I'm rather preferring this form:

```javascript
/**
 * Comment contents.
 *
 */
```

Especially when it's the form already used in all casperjs modules :)
This is the *main* change - this overrides the settings for the Wiki class based on our position within the directory tree.
I renamed the hash key but not the method because of the above mentioned self.options method which returns the options that were parsed from the command line.
Should we be emitting the duration if it's <= 0?
The errors thrown by this method should be documented
rockt.. find ich auch..
"We"?  Can you rephrase to avoid personal pronouns, plural or singular?
You probably mean to be checking translate._currentState here, but you're right that this really needs to move to Zotero.Translate, since other files shouldn't be touching properties beginning with underscores unless it's not a problem if they get broken.
JUnit style is to either call static methods directly, or to import them by name.  Can you change that?
This namespace prefix declaration does not match current http://ogp.me/ specifications and as such prevented the script from working on Open Graph valid pages. I removed this requirement all together as I know of at least three different implementations the Open Graph protocol has declared.
I think it's better if a change on a chunk call the render to refresh the chunk, it's heavy to check each dirty state on all rendered chunk. So snapshot for render only maybe useless.
I'm surprised Apple doesn't!
Ok, we decided on a compromise: I've added a public `setColorFromString()` that is just a thin wrapper around `_commitColor()` but without the sketchy 2nd arg (and with a TODO referencing #2204).
Yeah, let's leave it out for now. I'm not worried about error messages when running in a browser, as long as the user sees a reasonable message.
We only need to update paths of the sub-tree of the renamed folder. And if it's a file, then only the single node. Always updating the entire tree could have a noticable performance impact.
Nice, this is much cleaner than before!
Check out the latest changes.
??? Why did you change this? The commands plugin will find the active editor itself.
I moved the "this.eventListeners_ = {}" line before "this.createInterface_()" in the __init__ method instead.

You (or I) really should move the range selector into a plugin. It's where it belongs now, and it will prevent odd interactions like this one. It will also be a good test of how well the plugin system works: if the range selector can't be implemented as a plugin, then we need to expand the capabilities of plugins.
Or maybe the right question is - why are both in the repo?
Is there a purpose to this class? It looks like it is a stub, but il will be useless, @nicolas-f is currently working on integrating the console.

I think this should go too.
This is useless. `#` signals page-unique ID of the element. There is completely no need to tell that it is a child of some other element.
Shall I add language field in models.py? MongoDB field type should be StringField, no?
Simply nothing? Why there should be span, when you already have `button` around? Just put all wanted style on `button`. No?
I would change the structure of this part of the documentation so that there are some paragraphs without numbering.
Spacing after `if`.
Below you always require pid.  Is there some way we can explicitly return pid here, since it's an auto-incremented field, and we'll always need that value after adding a row?  Maybe it's baked into project.data.id?
I'm assuming you put this here on purpose to load it last, yes?
Wait, this actually works? Wouldn't this overwrite Butter.init completely?
in html5 '/>' is not a proper tag ending; for xhtml5 is

I'm just curious, why does the utf-8 case matter?
Now why didn't I think of that! :+1:
Der neue Eintrag in der Sprachdatei wurde noch nicht commitet, oder? Am besten auch gleich in deutsch und englisch..
Also it gets set below too.
Not sure why this wasn't static to start with, changed it to static since that allows me to include an extension for string that splits paths safely.
If you want to change this back, then just change the function definition (remove the "this" in it) and change how the function is called in XMLUtils.
server block ?
yes, in https://github.com/GeoNode/geonode/pull/248/files#L19L159 as part of the ISO output.
i would not put ttl or prio in the WHERE
love the compression here :)
You could `dump(io::IOStream, x, n::Int, indent) = idump(io, x, n, indent)` to catch all the simple cases in one shot, leaving the original `idump` dispatches, then HOF the recursive ones. I can see that.
should be written to stderr:
print >> sys.stderr, "Supported protocols are https or http"
or
sys.stderr.write("Supported protocols are https or http")
the warning should be updated as well (if it's true that 5 needs this monkey as well)
Well, if you check the web.py, line 67, I've the following code:

```python
# Enable Google if available¬                                               
try:¬                                                                       
     if (app.config['GOOGLE_CLIENT_ID'] and app.config['GOOGLE_CLIENT_SECRET'    ]):¬     
         from pybossa.view.google import blueprint as google ¬               
         app.register_blueprint(google, url_prefix='/google')¬ 
 except Exception as inst:¬ 
     print type(inst)¬ 
     print inst.args¬ 
     print inst¬ 
     print "Google singin disabled"¬
```

Thus, the blueprint will be only registered if the settings file has that GOOGLE_CLIENT_ID items. This is how it works not only for Google, but for Twitter and Facebook, because the goal is to completely disable/enable the blueprints based on the configuration. In any case, what do you think about this approach?
Is to ahve standard. Think that package declaration is not in all perl files but strict and warnigs yes. 

Moreover if we put them afterpackage declaration  the 'use base' is separated from the package declaration. Check any oop language and you see that the superclasses are next to the class name. And for good reason
Note to self: Move the variable declaration to the beginning of the block.
Maybe avoid calling these "deltas" to avoid confusion with the "Time Deltas" section title? Instead perhaps "Time scale transformation offsets"?
Yeah, I like it better this way, too.
Should use pWalletMap->GetWallet(strWalletMap);
Here's still a CBitcoinAddress left.
Yeah many versions of IE and other older browsers don't support anything but get/post for forms.  Even in the [current editors draft of the HTML5 specs](http://dev.w3.org/html5/spec/single-page.html#attr-fs-method) they only mention get and post.  We have to use simulated method until it reaches wide adoption and implementation in specs/browsers.
I don't like the typedef of the anonymous struct, is it ok to just call it a struct everywhere?
Also since it's apparently used in the test too, IMO it should be in a header file.
:( I wish we could have at least talked about getting rid of the converter market. Maybe I missed that meeting last week?
Ah, I see. Yes, that's tricky. I'd say you want to either put the transaction on a stack to fulfill later (like, you may want to work on the order for a few months before your inventory is big enough to comply) or else, throw the exception. That decision can probably wait, but a good near term solution might be to uncomment the lines so that at least you know when it's happening?
Rename `@previous_motion` back to `@selected_motion` for now.
I don't think it's a good idea to introduce a symfony dependency in the generic xml driver. Is there any special reason to use this particular exception class or is it just copy n paste?
will do it...
The 'raise on third call' behaviour here is unnecessary, because `detect_encoding` should only refer to the first two lines anyway. Also, I think it's simpler to use an iterator:

```
iterx = iter(x)
return lambda : next(iterx)
Sure, that's better, though the two are perfectly identical, since `unicode(self)` is really `unicode(unicode(self())`.
hmm.. Maps.transformKeys?
That wiki is incorrect, but also specs out how the client JS will talk to the mozilla/browserid service.

You're free to build KPIggybank in any way you see fit. I'll update the wiki... I don't think we needed to spec it out there.
Oops, ignore my comment, which I am about to delete...it is already order-independent, I misread the code.
@carlosmn @scunz I'm on it.
Can this become `git_buf_unescape` which operates in-place on a `git_buf` instead? I think `attr_file.c` already contains the code to do the in-place unescaping at the bottom of the `git_attr_fnmatch__parse` function. You might have to do some trickery to replace the existing `attr_file.c` usage with a new `git_buf` utility function, but it would be nice to have just one (reusable) version of unescaping code.
semi-semi-semi colons.
It does, but this came straight from the grid plugin and I didn't refactor it.
oh nice. i/we should probably start using this more
This should be if (timeIsUp() && self.result !== true) {

That way if the result became true in the last iteration before the timeout, or you crossed timeout right after breaking for a true result, it will still pass.
yeah, it can go away.
you feel strongly about it as you have mentioned it before.  In more recent code, I've lapsed into the full `self.config.logger` and find it ugly.  However, now that I tried it both ways, I find I just don't care that much.
ok, I like this.  thanks.
Is there some important reason why this file is added to the repository? Was it accidental? Or used for something?
If it shouldn't be in cyl, it shouldn't be in sphere. Whatever you'd rather do, I'd just like consistency in the generation commands.
Depending on the container makes it impossible to use this extension in a project using Twig and Routing without using the DI component (Silex projects for instance)
`new RouteCollection` not used
does it really make sense to make this method public ? It should be a protected one IMO
"and possibly more" deserves some more explanation.
I think for right now it makes sense to have this hard-coded as that formatting comes from Grayson's UI design. 

We'll have to cross the localization bridge at some point but it's not a priority for now.
We'd be introducing variable formats that we need to handle differently in terms of the space the the label occupies.
The goal here is to rescue from an `Unauthorized` exception.

Is that still possible without the `begin`..`end` block delimiters?
I think this block should return the same type as we have in [`BTRView`](https://github.com/ButterKit/Butter/blob/master/Butter/Extensions/BTRView.h#L52), with it returning the view in question, along with a context. These additional parameters can then be added onto that.
Acesta pentru ce ne trebuie?
nitpick: should there really be a default oper_logins? I know this whole thing for now is just for DB and not really all that reusable yet (we bundle DB configs and bidserv and everything), but still...
Chris can you please explain the usage of capture? I want to go through
its execution to figure out how to do optional arguments, but I don't know how to use
it and there is nothing on it in the documentation.
Der Translator ist das Uebersetzungssystem von Symfony. In der naechsten Zeile habe ich es aktivert, "~" steht in yml fuer null und damit in diesem Fall fuer "Standardeinstellungen". Es macht vielleicht Sinn, das ganze Projekt spaeter mit diesem System zu uebersetzen, in jedem Fall nutzt das FOSUserBundle es und solange du die Standardtexte nutzen willst, sollte das aktiviert sein.
Ummm... I'm struggling with this one, to me the comment is fairly clear (admittedly I did write it). @rhattersley would you be able to expand? If not, I propose we defer this one until @esc24 is back online (and not postpone this PR).
r->modBase =  info->base???
Sweet change!
Why did you remove the possibility to get the non-extended nodes?
It might be more accurate to say that it clears the cache which will cause it to be computed on the next get call. Though this is still an improvement.
```js
value  = Ember.create(value);
value.func = Ember.wrap(value.func, ovalue.func);
```
Please extend \Faker\Provider\Company rather than Base
don't explicitly include version of plugin in your pom.
versions are defined in jboss parent pom but can be updated via standard mechanism 
https://github.com/jboss/jboss-parent-pom
aka in root pom add 
<version.dependency.plugin>2.5.1</version.dependency.plugin>
Hi Jonas,

It should not be difficolt to extend the GraphViewDemos to show the new style capability, regarding the setViewportSizeLimit I think I can add it too. Since I'm a bit busy now I'll need a bit of time to do it, I guess I can allocate the time for this task in the next weekend. Is it ok for you?

Marco
appenders , root 这个是哪样？
я не проверял, но помоему тут будет NPE если пользователь не авторизован
// XXX Break down obj keys in a for each loop because mozSettings does not
// currently supports multiple keys in one set()
// https://bugzilla.mozilla.org/show_bug.cgi?id=779381
If we don't truncate this element maybe it's a good idea to increase the line-height.
`settings` is always the `mozSettings` API interface. You don't need to pass this in as a parameter.
Two-space indentation please.
Woah! That's bleeding edge. Is this function syntax in ES6 or is it spidermonkey-specific?  In any case, I don't think we're using it anywhere else in Gaia, so you should probably put the braces in.
width.
So that when focusing on the searchbar we widen it, exposing an X button and onblur - we shrink it back and expose the back button.
gSectionVisible -> gWifiSectionVisible
yes, you are right. That needs to be checked throughout the files
At second glance - it seems like I should be waiting on the bluetooth.onenabled event instead. Would that be correct?
Fixed it in master and rebased PR branch
Where ```set_local_from_url``` is used?
I understand what you want to test, but I don't understand what this line does. Could you please explain? :)
This parameter list should all fit on one line (it's less than 80 characters). If not, `default_name` should be aligned with `directory`. Also, there shouldn't be spaces surrounding `=` for keyword arguments (PEP8).
This should probably default to

```python
ls = plt.rcParams['lines.linestyle']
```
Monoid.plus(maxRhow, oMaxRhow) would work here.

I think there is no need to capture the implicit monoid in HyperLogLog
s/mock_type/protocol/ ?
This is weird, git thinks that I renamed this file but this was really a distinct deletion, and a distinct new file.
I don't understand this, and this seems to be at odds with the name of the function.
Remove this part.
Yeah, I saw the default settings later in the diff, so the original comment isn't relevant.
shouldn't this line be removed ?
Besser einfach rtrim(-)?
wonder whether this is neater as a data structure that's looped over.
six characters for colour codes!
Your line should be:

```python
comment.message_html = bleach.linkify(markdown(comment.message))
```
npm adds node_modules/.bin to the PATH when running scripts, npm test should work just fine this way.
Didn't know that existed! Pull request updated.
I think this wasn't working because `module.exports = tabs` at some point, so `tabs` gets frozen.  If this works on master then I'm not sure why, I will need to look at this some more tomorrow.
Let's discuss optimizations at a later stage, shall we?
This is the most important part. Hm, in fact, the ```setAttr``` might be completely sufficient, no other sanitization necessary.
If data['max_pause'] is a string then it should just be +data['max_pause'] if you are trying to return an integer. The ''+ actually will return a string.
__xabolcs__ wrote
> >Is it set automatically based on the number of maximum visible rows of the tree?
> 
> Yes, it is set automatically.

Hmm. A height is set by `#variableTree`, so no `height` styling is needed in it's container `#NightlyTesterOptions`. It would be automatic.

__whimboo__ wrote:
> ... which height of the window do we get? ...

`42.75em` is `684px` (at `16px` default font size). See [EMCalc][1]!


[1]: http://riddle.pl/emcalc/
Last time you put this at template header, that is correct. Why do you choose to put this in template footer?
Why don't you use templates for this method just like for the others?
Hmmm...

When I use python setup.py install it copy over root_numpy.tests so what's is it exactly for?
:thumbsup: I like it. I'll change, squash and merge.
This should probably be https://
this is a "safe" random walk i think. please do note in the doc that this will be considerably slower than the regular random walk.
Yeah, figured I should do that...
Maybe implement this, or throw an exception here (and add appropriate unit test)?
Simply doing the instanceof check would suffice here:
```php
if ($this->validator instanceof ExplodeValidator) {
```
see above re parenthesis
This should be // CraftBukkit start - use the right yaw and pitch value
Ah, right. Maybe a cast to the enum or uintptr_t is a better choice in that case? size_t is not necessarily large enough to hold a pointer (though I guess in this case it doesn't matter because the enum isn't big. Still, for clarity's sake.)
Alright, fair enough. Document that in there, then, or everyone who looks at it is likely to have the same question and have to go hunting around in other code to find the answer.
Just to clarify, the change here points out a BC break in `first()`?
Jeah I didn't run qa because I fear nate comments too much that I need to change ;) but i really need to get the space after the if in my fingertips...
You can assume that "drush" is in the path for a cloud hook script.
Ah, right, I was just confused by the `onkeyup` name.
Can you add the parameter to Doctrine\ORM\Tools\Setup class as well? 

Also we have to default this parameter to true everywhere i think, because otherwise we have to update the documentation as well.
i think this is intentionally made private .. to get the content there are other methods available
ah okay


On Thu, Nov 8, 2012 at 3:19 AM, José Valim <notifications@github.com> wrote:

> In lib/mix/test/mix/cli_test.exs:
>
> >        assert output =~ %r(\* creating lib/new_with_tests.ex)
> >
> > -      output = mix "test"
> > +      output = mix "test", [{"EXUNIT_CONFIG","none"}]
>
> Simply add System.set_env("EXUNIT_CONFIG", "none") at the top of
> lib/mix/test/test_helper.exs.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/elixir-lang/elixir/pull/636/files#r2067941>.
>
>
I prefer Email as well.
This method needs some fixing to make it work with OAuth1.0a. This is still a WIP
due to perfomance issues this value is reduces for all cobs now, see https://github.com/ipa320/cob_robots/blob/master/cob_hardware_config/cob3-3/config/cameras/parameters_left.yaml
Ditto here--need two empty lines before this.
Remove those spaces after the `!`s!!111

(this is an nit, but also an excuse to get travis to retest it)
We're going to keep the name of the site. In general, it's not a good idea to replace a generalized solution with a specific one, as this would break the other sites that use this code.
okay, if you want to leave these in, they need comments and 
documentation so someone understands exactly what they are.

I worry about the possibilty for some kind of disaster where someone 
accidentally runs them against their real SFX and overwrites their real 
SFX db, horrible disaster! If these need to stay in, can you think of 
any way to make it less likely for this to happen? Maybe build into the 
migration that it only runs at all if ENV["SETUP_MOCK_SFX"] is set or 
something?

On 10/10/2012 11:22 AM, Scot Dalton wrote:
> In test/dummy/db/migrate/20120927163304_sfx4_global.rb:
>
>> @@ -0,0 +1,15 @@
>> +# Create a test SFX Global DB.
>> +class Sfx4Global < ActiveRecord::Migration
>> +  def connection
>> +    ActiveRecord::Base.establish_connection(:sfx4_global)
>> +    ActiveRecord::Base.connection.initialize_schema_migrations_table
>> +    ActiveRecord::Base.connection
>> +  end
>> +
>> +  def change
>> +    create_table "KB_OBJECTS", {:id => false} do |t|
>> +      t.integer "OBJECT_ID", :default => 0, :null => false, :limit => 8
>> +    end
>> +    execute "ALTER TABLE KB_OBJECTS ADD PRIMARY KEY (OBJECT_ID);"
>> +  end
>> +end
>
> I added these for the sunspot piece because I was using a local Solr
> index (provided by sunspot_solr). I ended up just using VCR for that
> Solr bit and didn't run a local instance, but I still use these
> migrations as a quick test of the Sfx4 search module. I db:migrate them
> in travis and add some SFX fixtures and can do some sanity testing on
> the Sfx4 searching.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/team-umlaut/umlaut/pull/2/files#r1807795>.
>
Please re-write as one expression and without `return`.
you should be able to just:

```python
    slug = slug_base
    while model.objects.filter(slug__iexact=slug):
        counter += 1
        slug = "%s-%i" % (slug_base, counter)
    return slug
```
ToolRunner() sets the conf. We should just remove it here. It will give you the same effect anyway.
I hate ToolRunner.
There should be a space between the "if" and the opening paren in all cases.
I can't remember -- is the JavaScript that tells this anchor what the inboxUrl is?  The href attribute is blank... how does it know what to do?
Is this just to clear the file?
Oh I think maybe the `return bot.concat(top)` is reversed and `bot` is `top` and `top` is `bot`
Am I misreading? It seems this is the only output to the terminal.
You seem to never use `hypothesis: 1, conclusion: 3` but if you made choices into an object you wouldn't have to deal with numbers.
first of all +1. I think we should also have 11.42 / u.meter as this is mathematical and logical
When called from fElement_mapAttribute (line 273) after an id attribute has been added, this id has not been propagated to the view document before, so we need to search for the uniqueID once more.
I removed some unused assignments of the results of $db->query or $db->execute to simplify my life while I was looking for unclosed recordsets...
Well, I'm not married to the function name, but I generally like using $ in a function that returns a jQuery object - it helps me keep track of whether I need to call jQuery again to use the jQuery functions or not.
ah, good to know - then it needs to be done in the controller action directly
Yes, I am just carefull about changing things without testing them. I think it is better to have no doc than bad doc.
I imagine that someone else who can actually test this can add it back.
details_page.license_faq_text can change to license_faq.text
what does this default to if there are no opengraph tags?
Because if the pitch is larger then 90 degrees, the body yaw will be switched. If you use the reference model, this will result in an unwanted yaw-and-back. Alternatively, you could use the yaw calculation I use in the setpoint, but you might not always want to use this calculation, as it switches on roll angles larger than 90 degrees.

As the different cases are already being handled in the setpoint, I thought it would be the simplest to just take the yaw form there.
On 18:05 Mon 10 Dec     , Paul Tagliamonte wrote:
> > @@ -3,6 +3,13 @@
> >  PACKAGE=$2
> >  SUITE=$1
> >  
> > +if [ $# -le 1 ]; then
> > +   echo Usage: $0 suite package
> > +   echo suite: can be binary\|source
> > +   echo package: .deb if suite is binary  tarball if source.
> 
> actually, this is the chatham JobID that gets passed to atlantic -- mind updating that?
>

I'm not sure If I got you right.. did you mean pointdexter is called by chatham?

-- 
Vasudev Kamath
http://copyninja.info
Connect on ~friendica: copyninja@{frndk.de | vasudev.homelinux.net}
IRC nick: copyninja | vasudev {irc.oftc.net | irc.freenode.net}
GPG Key: C517 C25D E408 759D 98A4  C96B 6C8F 74AE 8770 0B7E
Dude, where's the i18n string?
Please document this function
Can't this just use the .isAdmin function ?
This is within the if, should be indented.
optional parameters should be written as: `@param {Function}    [callback]     ...`
Can you add a line of documentation specifying why there are 2 loops ?
This has changed for 6.1. As I understand it, we won't release SP versions anymore. Instead, we'll do GA1 and GA2 and service packs.
match wildP (normalB [| err (show d) $(varE v) |]) []
という感じでいけませんでしょうか
This endif should go at the end of the file, or else it is not guarding the full file correctly.

It should also be annotated with a comment showing which #if it corresponds to. See the other files as an example.
The current arguments are something like '--dotComplete foo.d 150'

If we don't have have a source file specified, the next argument will be the file position.  It's slightly more robust to test for a valid number as the next argument.  If it's not a number, then we can treat it as a file name.  I could have just looked at args.length instead, but this seemed slightly better.
Согласен, не досмотрел.
"исходя из того, что этой гибкостью могут воспользоваться"
Это первое тестовое задание, суть которого - проверить усвоение вполне конкретного материала. Всё остальное - дополнительные вещи.
Можно добавить рассчёт процентов с прицелом "на будущее", можно добавить метод clone и сделать на основе него тест программы чтоб убедится что mutate меняет ровно x символов (создать Cell, склонировать, смутировать с x процентами, проверить distance относительно клона на равност x) - как сделал я, например, можно еще много чего добавить дополнительного.
Но эти вещи не основные, и за ошибку считаться не должны однозначно + упоминать их особо тоже не стоит (если у вас есть вагон времени чтоб всё это писать - не факт что у автора решения есть время чтоб всё это читать). Нужно выполнить поставленную задачу: проверить решение на соответствие критериям правильности (тем 5-и что перечислены на сайте).
Остальное - лишняя трата времени.
х - процентный, а не количественный показатель по условию задачи.
Непонятно, к какому методу это относится, если к print: , то его и вправду можно было реализовать лучше, а что касается init и hammingDistance: , то мне не попадалось лучшей реализации. Может поделитесь ссылкой?
Лучше реализовать с округлением. В этом варианте changeCount возьмёт целую часть от числа, т.е. если будет 35.89, changeCount будет равен 35, хотя по правилам округления надо бы взять 36.
Could we consolidate this block with the previous (non-silent) block? The logic is virtually identical.
Also it's not belong xbmc. I guess /var/log better place for sabnzbd-suite.log
create уже делает внутри себя save. Так что или 
    
    @role = FactoryGirl.create(:role)

или

    @role = FactoryGirl.new(:role)
    @role.save
How would I do this? With or without the CefRefPtr? And how would I initialize the ExtensionString?
I think all the cleanup the disposable does is done automatically in that case.
Could you please add an isValid function that proxies to this function, allowing this validator to be used for Symfony2.0 as well as 2.1?
check_raw_compatibility should be in raw.py

isn't it redundant with the handle of concat raws?
I think having word "label" in the name is important, users wouldn't know what ltc stands for, and since we don't have a LabelTimeCourse type it's not obvious.  mne.extract_label_time_courses would maybe be good
@agramfort this fixed the nasty little bug I was talking about. When epochs are written to disk as `epochs.save()`, the data `epochs._data` get modified in-place by the `data *= decal[None, :, None]` line above. Thus we have to un-do this calibration. Otherwise, the next access to `epochs._data` will yield incorrect values.
Ohhh, putting yours at the top, I see? :)

Kidding, I know it makes sense since it fits with the other changes directly following it...
This may show my python ignorance, but why couldn't you set `methods=['POST', 'GET']` in the signature and just have

```python
throttled_methods = methods
```
(or just directly use `methods`)
Am I blind or it's not included in this pull request? ;-)
You should link to the packagist page (#1877)
yes, it is part of the Camel trait.
maybe an "else if" is clearer to read, communicating that it's part of the same thought.
Needs an extra indent.
Let's move the discussion to [issue 3025](http://code.google.com/p/sympy/issues/detail?id=3025), so that it doesn't disappear when this review is done, OK?
хорошая идея
to calculate the size you are replacing the -7 by +1 to the strlen. The - account for the chars in the template that will not be part of the final string. There are 4 %s and %d, which take 2 chars that will not be on the final string, therefore, -(2*4)+1 => -7. By replacing it by +1 the srequest is allocating a bit more space than required. It's safe because you are allocating more than needed. Will commit a the fix with a comment to avoid other guessing where the -7 comes from :-)
Beginning with 3 points ? O RLY ? :D
I'd probably want 1 migration per table, but that's a bit nit-picky.
```
...
use Sorien\DataGridBundle\Grid\Column\TextColumn;
...
$columns->addColumn(new TextColumn(array(
...
```
Where are we here ?
The double `#` also works BTW...
Ok, I agree that this is a more simple/sensible API for now. In future, we could imagine having sub-classes of ``PSF`` and ``Aperture`` that are ``DynamicPSF`` and ``DynamicAperture`` which then return different results based on the position and source index. But I agree that this is sufficiently complicated that we can probably defer this for now. Whatever we do, I agree the above (simpler) API should work in any csae.
Looks good here too.