labofsahil/github-event-dataset-2012 huggingface dataset:
When using WWW form encoded data, the DNSimple API respond with a 302 status code. The 201 is certainly used with JSON/XML request.
Is this passing? I feel like it shouldn't be since I intentionally mocked out the parsing process. I was just trying to test that it was correctly pulling the right part of the email to pass along, not anything about the muddling process. This is supposed to be a unit test, rather than an integration test.
It does, block overrides options (probably should note this in comment). Defaults work the same way.
Why not do something like this?

<pre>
mode = File::CREAT | File::RDWR
mode |= File::TRUNC unless offset
File.open(file, mode, :encoding => "ASCII-8BIT")
...
</pre>

Haven't tested this exact code, but the approach is more clear and better shows the intend imho.
No, the getData() method constructs a new ArrayList if one doesn't already exist: https://repository.sonatype.org/content/sites/maven-sites/nexus-oss/nexus/nexus-rest-api/xref/org/sonatype/nexus/rest/model/PlexusComponentListResourceResponse.html#55
can you pls add a note on how to use this in <toplevel>/examples/ExamplesREADME.md? It would be be even nicer to give an example of doing parallel pagerank on a huge graph generated using this (but that can wait when you have the parallel pagerank)
a fuller explanation here might be helpful.
None of the JavaScript uses ISO 639-2
eaa19f9abe5833c80218282a0b142cbcf466d7a2
I fixed in all the files of Zend\Crypt.
Please remove this kind of comments
Ok but i run tests before commit, must i undo the change ?
Next line actually.
Bad indentation on 346, and line 347 looks like an error (not sure what that brace is closing).
Woah. I have never seen that before! Okay, I'll add that too.
this is for place all tabs in one line w/o hidinig under the dropdown or rollover 
![](http://i.imgur.com/EFi8P.png)
We do classes like HTML, e.g `connected-sortable`. Not a deal breaker though.
All this paramater parsing should be broken out into a search class it shouldn't be in the controller.
CS: whitespace within [ and ] ?
I think that this is unrelated to the issue but stephane pointed this out in the issue thread. I also think  that it is probably a bug not to use the DEFAULT_CATEGORY setting here...
Consider aliasing `collection` to `results` to mirror the `Twitter::Cursor` class, which server a similar function as an envelope/wrapper class.
Yeah, but FF11 didn't like it.  I searched around and there was a bug about it already.  I got "not enough args" with a null.
This actually won't work. `STATIC_URL` should be something like `/static/` and django will append `admin` to it for the files. See:

https://docs.djangoproject.com/en/dev/releases/1.4/#django-contrib-admin
Comment ping.
typo? `||=`, also does this mean there's a hidden failure?
Remove hardcodeing and replace with config.get_install_server_ip() (or what it's called)
Should be chemical/x-daylight-smiles
This regex is more simple : 
detect           : FW.Url().match(/http:\/\/bofip\.impots\.gouv\.fr\/bofip\/ext|simple\/.+/),

The search engines are : 
// source du droit : http://bofip.impots.gouv.fr/bofip/ext/codename/source/recherche-codesource-facet
// recherche avancée : http://bofip.impots.gouv.fr/bofip/ext/recherche/avancee/recherche-avancee-facet?expert=false
// recherche par date : http://bofip.impots.gouv.fr/bofip/ext/recherche/date/recherche-date-facet
// recherche simple : http://bofip.impots.gouv.fr/bofip/simple/recherche-simple-facet
@jnormore The user is going to be running this generator on a brand new, greenfield app.

Will the generator create the file for them? If not, add it to the generator or rewrite in the imperative tense.
Screenshot kinda implies that the default username and password is "administrator", which it is not. You should change the board title, and preferably your username to something like "dida" so that the reader knows that you chose it.
I'll talk with Alex we did have a good reason :)
а что такое цвет?
Whoa, I just learned something new.
Oh, of course. Maybe we could keep some pointer to "the current application" though, to make it easier to find, and only cycle in a new application when reloading.
Could be useful to point out what are the changes required somewhere.
When we are moving the dict up here I would say we call it `DEFAULT_FILE_EXTENSIONS`.
Won't all of these crash on the null QSharedPointer until setPath is called?
This function doesn't actually do anything. Probably best to either push some stuff into it from `render()` or remove it and call `getPage()` directly.
incidentally this can be `.sort_by(&:updated_at)`
I wouldn't do this in 2 separate for loops. I would just loop over the rows once and do an if/else check there.
Right, but what if you update cassandra and the cache invalidation errors out?
Wouldn't you be serving up stale data from Redis?
Given that the UI doesn't support this yet, I think this function can be removed for now.
Ok, I will add a line about that.
more indentation inconsistencies, 4 spaces this time.
It looks like you accidentally added a space to the end of this line. Please remove it.
Production centre should not be selectable - it is the logged in user's production centre, so just display it but don't allow it to be selectable (yes, this is a bug in the MiAttempt form, it should do the same thing)
Создать массивы можно более компактным способом используя методы класса: 
_DNA = [NSMutableArray arrayWithCapacity:100];
atcgArray = [NSArray arrayWithObjects:@"A",@"T",@"G",@"C", nil];

Так же размер массива _DNA можно вынести в константы, тогда при необходимости поменять размер массива, не придется редактировать кучу строк, где используется это значение.
не оч важно, но все таки :) разные отступы
Don't have first hand knowledge on the tools but I think Sun Studio
was free but only on Solaris which maybe was free.. you'll need to
look around.  Intel vTune is out of the question unless something
changes.

Good introductory article :
https://www.ibm.com/developerworks/java/library/j-benchmark1/index.html
(several parts)

JVM internals:
https://wikis.oracle.com/display/HotSpotInternals/LogCompilation+overview

If you do not understand how something works, ask yourself how you
would solve it and the answer will materialize... if you give it a
chance.


On Wed, Jun 27, 2012 at 6:21 PM, Steve Dougherty
<reply@reply.github.com>
wrote:
>> +                             }
>> +                     }
>> +             }
>> +             return false;
>> +     }
>> +
>> +     /**
>> +      * @param type probe result type requested.
>> +      * @param candidate node to filter for response from.
>> +      * @param uid probe request uid, also to be used in any result.
>> +      * @param htl current probe HTL; used to calculate timeout.
>> +      * @return filter for the requested result type, probe error, and probe refusal.
>> +      */
>> +     private MessageFilter createResponseFilter(Type type, PeerNode candidate, long uid, byte htl) {
>> +             final int timeout = (htl - 1) * TIMEOUT_PER_HTL + TIMEOUT_HTL1;
>> +             final MessageFilter filter = MessageFilter.create().setSource(candidate).setField(DMT.UID, uid).setTimeout(timeout);
>
> Okay, merged. Are there tools I can use to check such low-level performance things, and if so are they ridiculously expensive? Will I just have to develop an understanding of such things? Are there any books or articles you can recommend?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/freenet/fred-staging/pull/94/files#r1064249
Before doing this, we should send completed on the `subscribablesSubject` and verify that the subscriptions haven't changed.
This check only works when the callback is defined using the widget factory method

```javascript
$( "#mylist" ).listview( 'option', 'filterCallback', yourFilterFunction );
```

If the user sets the value via the prototype options value eg,

```javascript
$( document ).bind( "mobileinit", function(){
  $.mobile.listview.prototype.options.filterCallback = function(){
    console.log( "foo" );
  }
});
```

This check will always return true though it's clearly a custom callback.
I am still not convinced about RawFromMerge as I would think you can do the
same with assignment

raw[picks, :] = data

don't you think?
It doesn't look like it should go after < /select>?
Dumb users are dumb anyway, this is not what will stop them ;)
Yes we can add the sealed :)
Don't think I really like this logic. Really, it should be an action on the question and item, not a separate controller, which leads to this stuff.
This will panic on non-utf8 encoding of unicode codepoints.  Better would be to try to unmarshal a string first, and if that succeeds and the NewString succeeds, copy the results of NewString.
``===`` would be better :)
日志别翻译
Avoid capturing self here.
add 
val replyTo = self

and then close over replyTo instead.
Right, we will need to check for something like (any letter):\ or \\ but I want to get this merged and working MVP first.
these attributes are not necessary as they come from the input spec and will be automatically generated.
what if there is no controller? You should use `Yii::app()->createUrl()` and `Yii::app()->createAbsoluteUrl()` when you are not inside of a controller.
Выводи отдельно дату, чо, и формируй строку руками.


2012/12/12 Maledictus <notifications@github.com>

> In src/plugins/blogique/blogiquewidget.cpp:
>
> >  	{
> > -		S_ParentMultiTabs_ = tab;
> > +		QStandardItem *dateItem = new QStandardItem (entry.Date_
> > +				.toString ("dd-MM-yyyy hh:mm"));
>
> Ок. Расскажи мне как в short версии сделать hh
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/0xd34df00d/leechcraft/pull/153/files#r2390434>.
>
>



-- 
  Georg Rudoy
  LeechCraft — http://leechcraft.org
Debería decir `lleguemos` en lugar de `llegemos `.
can you align here with spaces instead of tabs?
Ruby methods usually don't need an explicit return statement, it returns the value of the last statement executed by the method.  So you could just say "word" here and you would get the same result.
Loks like $timeout gets declared as a global variable here?
This can be read easier by others by splitting the check using "guards style": http://www.refactoring.com/catalog/replaceNestedConditionalWithGuardClauses.html

if (getMapGenerator.requiresInternetConnection()) {
  return false;
}
if (Settings.getMapFile() == null) {
  return false;
}
return true;
Where is the Content-Type?

    headers['Content-Type']   = mime.contentTypes[fileExtension] || 'application/octet-stream';
The lines in this method are too long and make it really hard to read.
Also, perhaps document what each of the arguments to this method mean and how they're used. Its not clear what conditions and comparison_options are.
Can you please document this?

It should also be declared `strong`, or else things will get screwy with a conforming class that wants to use it as a settable property.
That I forgot to uncomment it. It passes because it creates the droplist with 2 elements like that.
Spaaaaaaace. Wanna go. Wanna go to space.
In this first issue I wanted to avoid creating a dependency between `infinispan-query` and `infinispan-lucene-directory`, as in long term that's going to be tricky as it creates a circularity via Hibernate Search.

Still in the subsequent patches for the Infinispan based new IndexManager, I had to introduce this circularity anyway, BUT that's going away with further work. That further work however will depend on a new release of Search, which is not going to happen for the moment.. 

So in long term we need the new module, as I'll need more significant tests than this silly one, but for now you could avoid it if you like moving the test into Query.
Another thing to take in account is that if isWlocal is false, then computing isRlocal is waste of time...
consistentHash() is only used in our unit tests. Could we just remove it instead of deprecating it?
'plot3D' is an old name that I intend to eventually discourage (when I can get the pyplot mode to be more adaptive).
It's not really a magic number -- all of this code is predicated on the images being RGB, and there's not much point in being more general.
Yes, GtkAgg backend currently does not work, which I believe is due to this.
Seems like this variable should be within the xtag.  Lines 115 and 128 are using it and if we had multiple x-toast messages going off simultaneously, there could be some strange behavior.
Inside the factory, all the instances are maped to the domainType. So this is the same as using the serviceId or the instance.

This closes all the open connections of a domain. The eventhandler is closed automaticly excepted a exception happens. In that case the method could go into a endless loop (exceptionhandler). The StopConnection method stops all the exceptionhandler from the domainType and so all the connections will be closed.
@arnodeclercq Not really sure whether I understand this completely.
Can you show me where they say that in the documentation?
Each infinite scroll li element will need a data-id attribute with the item's id property and a data-key attribute containing the start value to use for paging.
Oops I think that should be features->get_num_vectors() to make sure there are as many training labels as there are
training examples.
c=0?
Just contain rather than contains.
That change makes sense to me.
Mention that it is passed as an argument to the middleware?
Potential Rewording?

> Deleting an extension removes all of its files and settings. Log entries will remain, although any language variables added by the extension will not be available.
I think `Array.isArray` is better for this.
So I suggest adding polyfill like this
```javascript
var isArray; 
// ...

isArray = Array.isArray;
if (!isArray) {
    isArray = function isArray(ary) {
        return Object.prototype.toString.call(ary) === '[object Array]';
    };
}
```

and use it
```javascript

if (isArray(options.tags)) {
...
```
Shouldn't this be fullpaths => 0 for it to be off by default?
I think the idiomatic way to do this is `isinstance(x, basestring)`.
I'd also prefer opt-out. If you've got a specific use case that requires bypassing validation, you should be required to explicitly say so.
А почему getCost может вернуть не integer?
Это преобразование (если нужно) его забота.
Denne fila blander tab og space for indentering. Erstatt tabs med space.
Yeah, I added it later. I *think* it's not necessary, but since it doesn't hurt to resolve an already normalized path, I thought I'd be safe and ensure it was resolved. If someone used findAllWatchFiles() in the future, this makes it so that they wouldn't necessarily have to ensure a resolved path themselves. No problem with you not including it though.
Could we have a B/C issue by removing these constants?
But if $key would not exist you would then get a **Notice: Undefined variable: key**
That's why $key is tested first and cannot be left.
cd test && ruby to_test.rb ?
That would be good.  And also to integrate references to [REP 105](http://ros.org/reps/rep-0105.html) where appropriate
As discussed in person, I think this variable should override the production/sandbox field in the evaluation (so that we can easily run integration tests offline). However, this param is a task-level param, whereas the evaluation holds an evaluation-level param, so maybe some refactoring is needed to allow production/sandbox judgments at the individual task level. (and some tests to make sure that evaluations still work with both production and sandbox tasks)
`feed_itemss` -> `feed_items`
No, don't do this. If data was not given, don't construct data at some random point in time. What if Facebook will change their URLs? Then you will go through all database and change URLs?

But I agree that this is good to have on user object. So you can define such property:

```
@property
def twitter_link(self):
    return 'http://twitter.com/#!/%s' % user.twitter_screen_name
```

Maybe it would be useful to store all usernames given from third-party authentication mechanisms (and even display them).

BTW, user can change their username on Twitter, so one more reason not to hard-code twitter_link (and you should also make it so that `twitter_screen_name` is saved every time user logs in through Twitter. Probably this goes for all fields from the third-party authentication provider.
Why only if authenticated? All users can get notifications, no? We are using lazy users now, remember. authenticated means that user is registered. But all users can post content.
(String.)
And then:

```
    'id': 'submit_comment'
}).click(...
```
`<em>` could be outside of block trans.
a bunch of pep8 changes follow
Link to the issue instead: `https://trac.macports.org/ticket/29635`
JavaDoc wär ev. nett. Bei der Klasse fehlt er wohl auch noch, gemäss unseren Rules.
this is the lost line that caused the index overflow when the initial uTotalParticles is over 100.
Why is your name in the title of the plugin?
OK. I have removed that class and added another constructor to the WithMagnitudeScales to handle the case of instantiating WithMagnitudeScales with a single scale.
"following," not "followin" :)
should add @addyosmani here, he and @jaubourg did the original content, @peolanha helped with converting it to markdown!
I just added a null check here and pushed the rest of these changes.
в случае проблем сокет выбрасывает OSError, по которому нужно как минимум корретно завершаться
we don't want to print here, probably.
Wouldn't a check for "ReadableIndex" be better?
I'm not claiming this is a good solution for older versions, but i think it's better workaround than to show always exactly the same name. Then the user has at least a chance to differentiate them.
I've been picky about this for other people, so I suppose I should point it out here too. The surrounding lines all use tabs, this line (the `if`) uses spaces.
fixed in 357a3d7
This API forces the client to envy MessageProcessResult.  Why not force clients to call DirectClientUtils and pass just the MDNs?
Is there no better way to do this?  I've got this in code too, but it really feels a little silly.
This looks like a class variable too.  But given that you have a bunch of tests that pass with this as is, is it even doing anything?  Is `self._SBProfile` something different from this?  If so, I don't think you even use a bare `_SBProfile`, so you can probably get rid of this line.  Likewise for the `transformations` class variable below.  I think you only ever use `self.transformations`.
Maybe this is a result of my not knowing something important about C++, but if I try to move the 3 lines starting at Solve... into the case HALF_LIGHT_RADIUS, then the compiler complains:
```

src/SBProfile.cpp: In constructor ‘galsim::SBMoffat::SBMoffat(double, double, double, double, galsim::SBMoffat::RadiusType)’:
src/SBProfile.cpp:1477: error: jump to case label
src/SBProfile.cpp:1474: error:   crosses initialization of ‘double rerD’
src/SBProfile.cpp:1472: error:   crosses initialization of ‘galsim::Solve<galsim::MoffatFlux, double> s’
src/SBProfile.cpp:1480: error: jump to case label
src/SBProfile.cpp:1474: error:   crosses initialization of ‘double rerD’
src/SBProfile.cpp:1472: error:   crosses initialization of ‘galsim::Solve<galsim::MoffatFlux, double> s’
```

What am I missing here?
Seems weird to me too, but that's what the documentation wanted. And it works.  I guess it acts as two different requests or something.
je vais reflechir
_than_ au lieu de _then_ pour comparer
It's to avoid the tax of the added function call. I would jsPerf it to see cost and then think about adding those truthy checks directly to the `isXYZ` methods and compare it to them as well.
This test doesn't really test much except if the test mocking is working correctly. We should modify `mock_browserid` to add a "add_mock_argument" parameter that will pass the mock object to the test that it's decorating as an argument. Then, we can use that mock to assert that `issuer` and `allow_unverified` were passed correctly to `_verify_http_request`.
Hmm .. why the special treatment for FilterLogger#warn but not for other methods e.g. #error #info etc?
I've moved it to ```teardown```. Thanks, for your note.
>I will use MACOS_VERSION == 10.6

Yes, this (or `MacOS.version`) is the correct thing to do if you want to apply something \_only_ on Snow Leopard.

`MacOS.snow_leopard?` is actually "Snow Leopard or greater", and `snow_leopard_64?` is just a wrapper around `MacOS.prefer_64_bit?`, so your results are correct. These are defined in Library/Homebrew/utils.rb and Library/Homebrew/compat/compatiblity.rb, for reference.
I see. You should take a look at the existing code for handing the drag and drop behavior: https://github.com/danielbachhuber/Edit-Flow/blob/ea87a6ace9d6b421489ea027c0353150e968b560/modules/calendar/calendar.php#L265

By default, it won't actually set the publish date — it will only change post_date so the post gets the proper slot on the calendar. We should respect that filter when creating new posts too.
А вообще надо два append() делать
1. GUI - не по Code Conventions.
2. У тебя интерфейс - это textarea да кнопка, т.е. та же консоль. Все команды чата должны иметь свои элементы управления. /list - список серверов, /connect - форма для подключения и т.п.
Нет. Ты не удостоверился, что это то самое исключение (тот же тип, то же сообщение).
Это некорректное создание FileReader. Если исключение произойдёт в конструкторе BufferedReader, то ресурс не освобоится в finally.
Can we make this private then?
これも

    全てのテストを実行します。

とかでは？
A definition list rather than a bulleted list would be more appropriate here
you should also be able to avoid the alloc of the diagonal matrix
Since the URI is so clean I would add it here. WDYT?

http://www.cs.toronto.edu/~hinton/absps/fastnc.pdf
Hrm, should not code coverage kick off just when a test starts (eg. in `testStarted()`)?
(Finally looking at this again!) What should it be? Most the other code uses this same member. (I started this by copying the "    else if (ident == Id::identifier)" branch)
is the default usage string not adequate?  isn't it simpler to just let optionParser generate the usage string?  Make for one less thing to update everytime there's a slight change in the options.
That depends if you are just passing existing variables or if you need to
compute something like a toString. Also there is a cost in checking the
logger level so if you have multiple statements it's a good idea do make
the debug level a local variable. If none of these apply I prefer to make
it more readable by going for the plain option.
On Oct 22, 2012 9:21 AM, "Hardy Ferentschik" <notifications@github.com>
wrote:

> In
> hibernate-search-engine/src/main/java/org/hibernate/search/indexes/impl/SharingBufferReaderProvider.java:
>
> > @@ -58,6 +58,18 @@
> >  	 */
> >  	protected final Map<Directory, PerDirectoryLatestReader> currentReaders = new ConcurrentHashMap<Directory, PerDirectoryLatestReader>();
> >
> > +	/**
> > +	 * Each actual IndexReader refresh will change this value. To what value exactly doesn't matter,
> > +	 * as long as it's not a value recently used, so we don't care for overflow conditions.
> > +	 * When a client needs to check for index freshness a lock is acquired to protect from
> > +	 * too many checks (which result in IO operations); when it is actually able to acquire
> > +	 * this lock it should check if the refreshOperationId changed: if so, a refresh can
> > +	 * be skipped and we release the lock quickly as the IndexReader was then for
> > +	 * sure updated in the time interval between this client arriving to request a reader
> > +	 * and actually being able to get one.
> > +	 */
> > +	private volatile int refreshOperationId = 0;
> > +
> >  	private DirectoryProvider directoryProvider;
> >  	private String indexName;
> >  	
>
> public IndexReader openIndexReader() {
>     log.debugf( "Opening IndexReader for directoryProvider %s", indexName );
>             ...
>     }
>
> Not changed by this code, but should there be an if statement around the
> logging or is this not required w/ *debugf*? Or is there no benefit in
> general anymore?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/hibernate/hibernate-search/pull/347/files#r1900986>.
>
>
Yes I suppose it should, I'll add
No, a workunit may have run on, one, some or all thor processes within the cluster.
All thor processes listen to same queue, eclagent fires outer graphs to the queue and a free thor process runs the graph.
In which case there will be multiple log entries provided by the different Thor's.
In fact even if there's 1 graph, a restarted workunit, may run on different thor processes.
or reinstate it....
It was needed the way I coded it but I think this is better...

    capacity = rowsToSort.capacity() + 1;//add one for the row we are about to add
    if (capacity >= indexCapacity)
    {
The old code (yuck!), had a section equivalent to above, that looped and paused if couldn't gain locks on all.
Presumably to avoid deadlock, where multiple clients were trying to promote a series of supers, with each holding some or something..

I think that pausing mechanism has gone? but still an issue
This is for the IFBLOCK(condition) within a record - there is no else block.  
- child(0) is the condition, child(1) is the record containing the conditional fields.
more pythonic:

```
if not versions:
```
can you make this <=80 chars?
All good feedback. Done.  

--  
Phil Sturgeon


On Wednesday, 27 June 2012 at 15:13, Drak wrote:

> > +can apply for membership and if they get enough votes they’ll be a member of the
> > +group.
> > +
> > +
> > +## Do voting members have to comply to the standards?
> > +
> > +No. Becoming a voting member on the PHP-FIG in no way forces a member or project
> > +to implement every - or any - accepted PSR’s. It is assumed that some will be
> > +picked up, but in no way required.
> > +
> > +## Can I get involved?
> > +
> > +Absolutely. Anybody who subscribes to the Google Group is part of the PHP-FIG,
> > +but only voting members get a to vote — simple right? If you or your project
> > +want to become a voting member simply send an email to the [mailing list][mailing]  
> > +requesting membership (see [homepage](/) for more details).
> >  
>  
>  
> I would rather not place the onus here on becoming a voting member or somehow imply, as this text does, that being a voting member is the only way to influence PSRs - as we have shown over and over again, PSR are often greatly influenced by non-voting participants (let's just call them FIG community members). Active participation is far more important than voting rights.
>  
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/php-fig/php-fig.github.com/pull/23/files#r1060258
>  
>
Disons que j'en ai corrigé pas mal, je referai un tour de correction ce soir, au bout de 2h de review hier j'avais les yeux qui piquaient un peu, j'ai pu en oublier :)
Can we make this more readable? Maybe moving the `result = ` line at the end, and instead using a _to_index and _to_deindex variables in the function?
`this` sounds very magical. `window` looks more common.
As I will mention later we should rename it to 'tabTitle'
Why do we need exactly 31px?
Further information can be found at the very bottom of the page.

http://wiki.opscode.com/display/chef/Search
How is `Table.Meta.sequence` honoured here?
@shacker yeah, we should create a jira to follow up on this.
@shacker Can you double check this ;). There were spaces before but it should have been replaced by one tab.

The best way to verify is to actually check out my branch or click on "View file"
Returning the sequence returned by `map` would be just fine.
The installed pom is identical to the pom in the repo.  I wouldn't be surprised if there's a plugin or property to flatten it, but I don't know it off the top of my head.
a little more nitpickery (but fixing this isn't mandatory, it's just for future use) - 'return NULL' on its own line
okay, sure.
The reason I added it was that so if you configure it to something else as your default the old option (20/50) would still be present. And the old options where both 20 & 50.

I think it makes more sense to keep the 20 option in there even if you configure your default to say 200. But that's a matter of taste I guess, maybe all options should be configurable.
Hi, 
In the API, this "invert"  and not "inverse" when you set the value 
Cheers
You can actually do just "if not smtp_auth_method". A nil object will evaluate to false.
Now we have a reference implementation :)  That's the whole plan behind world domination with skimage!
Might be worth mentioning that you do include this as a library in the war.
We don't need need the enablement for Mylar - as it just applies to the current map. Perhaps fix this for Layers View as well :-)
(3) is a good idea, but I'd make it less redudent, i.e., ` Material.ColorId` instead of ` Material.ColorMaterialId`.  @IanLilleyT, please update the [wiki](https://github.com/AnalyticalGraphicsInc/cesium/wiki/Fabric) as well as the code.

(2) is the hot topic that @IanLilleyT and I predicted.  Even though we've made it look like JSON - as I also did on the wiki - it is a PIA, so since @mramato and @shunter think it is overkill, let's trim it down to normal JavaScript.  It will be cleaner.  Also, update the examples on the wiki, but be careful because many of them are actual JSON, not JavaScript.
I'm going to clean up the names and also add a comment to the top of the page static that numerical validation was done agianst STK Components with a link back to the product page.
Yea this probably shouldn't be there. It was a quick fix to let me use a default animation speed of 1.0 instead of some ridiculously small number. Any suggestions on something that won't be machine dependent?
This bug (or maybe I just don't know what I'm doing) now exists in Chrome stable as well.
I am more concerned about the assumption that children array has >0 elements.  If headerView is null then an exception will be thrown before we get to this point.  headerView.getChildren().get(0) assumes there are children and checking for getChildren() != null just makes sure that the array itself is not null, not that it actually contains anything.
the split that is happening on new_key could be much cleaner.
You're right about the bit-width. Research the storage limit of JS numbers (if any) and use that as the "out of range". 

    redis 127.0.0.1:6379> set "foo" 1
    OK
    redis 127.0.0.1:6379> incrby "foo" 12358014081327480173408
    (error) ERR value is not an integer or out of range

I'm all for mirroring Redis' error messages so long as we can justify it in the context of JS.
The scp methods, per the comment in the ssh_connection class, only return 0. This was dead code.
I don't think issues are enabled in this repo, so I raised the question here.

IMO, this is pretty ugly. It's only enabled for two distributions and the default action is to not do anything.
why does it always create a bitmap drawable here?
It's true, I led him astray.. guess that means another commit for you
Right thanks- I've actually started doing this in more places (read in
style guide) but old habits die hard, must've missed that one. Thanks
for reminding me :)

Andre.

On Fri, Mar 2, 2012 at 8:16 AM, Felix Ruess
<reply@reply.github.com>
wrote:
>>  #define Spi2Slave0Unselect() GPIOB->BSRR = GPIO_Pin_12
>>  #define Spi2Slave0Select()   GPIOB->BRR = GPIO_Pin_12
>>
>> +struct spi_periph spi2;
>> +
>> +static inline void Spi2SlaveUnselect(uint8_t slave)
>> +{
>> +  switch(slave) {
>> +    case 0:
>> +      SPI2_SLAVE0_PORT->BSRR = SPI2_SLAVE0_PIN;
>> +      break;
>> +#ifdef USE_SPI2_SLAVE1
>
> Just a quick note, I think in general it is nicer to use #if instead of #ifdef for cases like this, you can then also explicitly disable it by defining it to zero.
> I already added that to the last paragraph in http://paparazzi.github.com/docs/master/stylec.html
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/paparazzi/paparazzi/pull/148/files#r511384
Sorry about that. Ping me when done. Thanks!
Ah, I see here that the separator is copied. Hmmm... what @monarchdodra said then.
Generally, I think adding more extensive helper code such as this to the `std.internal` package might be a good idea, as done in other similar cases – particularly, if the code is going to be used from multiple Phobos modules.
Double :-) for @Sanne



On 27 Nov 2012, at 18:15, Sanne Grinovero <notifications@github.com> wrote:

> In engine/src/main/java/org/hibernate/validator/internal/metadata/aggregated/ParametersMetaData.java:
> 
> > +* distributed under the License is distributed on an "AS IS" BASIS,
> > +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> > +* See the License for the specific language governing permissions and
> > +* limitations under the License.
> > +*/
> > +package org.hibernate.validator.internal.metadata.aggregated;
> > +
> > +import static org.hibernate.validator.internal.util.CollectionHelper.newHashSet;
> > +
> > +/**
> > + * Represents the constraint related meta data of the arguments of a method or
> > + * constructor.
> > + *
> > + * @author Gunnar Morling
> > + */
> > +public class ParametersMetaData implements Validatable {
> I hope you guys solve this quickly, as I'm receiving a notification for each comment now since weeks .. ;)
> …
> —
> Reply to this email directly or view it on GitHub.
>
What's wrong with "sync" and "skip"?
why ups? the formatter has removed some blanks : )
Right. It's only "undef" because I was not sure what the path/file is under RedHat. Just laziness on my part -- I can fix this.
Você só criou um período.
O segundo save() gera um update.
Was this supposed to be moved outside of the initializer block? Does it have any implications surrounding loading etc.?
Can you please adjust this line to remove the parenthesized portion? The name is used for the package installation folder, and those parentheses may cause problems on some systems. Better just to set the name to `"Git Gutter"` and have your Github repo’s description provide the explanation of what your package does.
I remember FxCop used to complain about this. FxCop recommends to create the dictionary by default, each time we need to renew the dictionary, we just call Headers.Clear(). What does FxCop say this time?
If the serialization format is JSON, could use this instead:

        if (!empty($customProperties)) {
            foreach ($customProperties as $key => $value) {
                if ($value instanceof \DateTime) {
                    $value = gmdate(Resources::AZURE_DATE_FORMAT, $value->getTimestamp());
                }
                $value = json_encode($value);
                $httpCallContext->addHeader($key, $value);
            }
        }
This is pre-optimizing assuming both the essentials and electives sections can use the same partial, which I doubt.
This class def is not correct - it should be CmdbEventChef < CmdbEvent
I don't know, but I guess it doesn't hurt :)
>If the segfault is triggered by an mprotect you can get back in the program just like if nothing happened. 

Right, but what's the use case for accessing protected pages?
Are you thinking of GC read/write-barriers?

If you want to support callbacks you need to go the full way, e.g. saving and defaulting the FPU state.
I understand, but dereferencing a value like `0x10` would yield a `NullPointerError` too, which would be very confusing. Perhaps `InvalidPointerError` would be more accurate.
ok; so I am going to revert back to my original implementation that only supported Map and use

````
    <syslog-to-map-transformer />
````
Hey I know this comment should have been posted on he original issue, but do you think the other two methods would have been called onRollback and onCommit since it really is not 'after', but 'during'?
it should be ``update``, or ``update "doctrine/doctrine-fixtures-bundle"`` if you don't want to update your other deps
(At least the style I use has it, and it is elsewhere in the code like that. But you do not have to change this. I am just writing comments I have.)
So which are those function and why would not we want them in the plugin?
args[0] is the argument object in something like createView().  We want to loop through all the properties here and fire off a referenced event so we can count them in the ti-usage-finder plugin.
This class does not respect any symfony CS ...
make this an abstract method
oh ok, well it would only be 0 if the array contains no data and an array shouldn't be empty in the collada file as far as i can tell. There is no src attribute or anything like that.

Just add in a check to see if array is zero? Would that work?

```actionscript
//if array has some data continue
if (array.array.length > 0)
{
	//if array length less than expected data
	if (array.array.length < (offset + (count*stride))) {
		//if array length less than actual data throw error
		if (array.array.length < (offset + (int (array.array.length / stride) * stride))) {
			document.logger.logNotEnoughDataError(accessor);
			return false;
		} else {
			count = actualcount;
		}
	}
} else {
	document.logger.logNotEnoughDataError(accessor);
	return false;
}
```
The indentation looks wrong. Are you using tabs ?
Why not chcon the logfiles to httpd_log_t instead ?
You could rewrite the function body as:

```javascript
return ++count > times ? memo : memo = func.apply(this, arguments);
```

I'm not sure to what extent file size is important to this project relative to other considerations (such as readability).
Should be `assert_equal` instead of `assert_equals` :)
unnecessary semicolon here, like a lot of places in this file... ;-)
As fair as I can tell there is no 'Login' page. The preview uses BrowserID, so BIDPOM takes care of this. You can safely move this login method to base.py.
the concurrent splicing and iteration raises a flag.  This needs a comment about iterator semantics making this safe (if it's safe).

Also, there's a red flag about this being O(n^2), but since the current persistence setup is temporary, I'll hold off on this.  But please add an "XXX O(n^2) but persistence will be rewritten soon" comment so no one else freaks out.  (The IMAP approach has better bounds for various reasons, but it's no wunderkind.  I'm sensitive to this because Thunderbird had/has some pathological behaviour here...)
Is this supposed to be a property for the callback event? Currently, it's overriding all of the properties for Ti.Push.
I think we should leave it as Titanium.Push for now. There is a case to be made for providing an equivalent implementation on iOS in the future.
changes to isEqualToString
Logger throughout.
This singleton is responsible for the coordination of all builds around an event.
So this is where strange things can happen if you are not careful. The key value to a memory imprint is based on the change and patchset number; so what happens when you first upload a change that triggers some builds and then merge it before the builds are completed and that triggers some other builds?
I think it could be messy.

One idea could be to generify this class and have one BuildMemory per event type. But some thought needs to be put on how to handle future events like ChangeAbandoned that should probably cancel all ongoing builds for a particular change.
Declare the following repos:

	<repositories>
		<repository>
			<id>repo.springsource.org.milestone</id>
			<name>Spring Framework Maven Milestone Repository</name>
			<url>https://repo.springsource.org/libs-milestone</url>
		</repository>
		<repository>
			<id>xqj</id>
			<name>XQJ Maven Repository</name>
			<url>http://xqj.net/maven</url>
		</repository>
	</repositories>