Always unpack the source tarball, not the bottle
Set DEVELOPER_DIR; Fixes bad xcode-select path

In cases where the xcode-select -print-path is '/' xcrun still hangs indefinitely, setting DEVELOPER_DIR to something (preferably the Xcode path) fixes that. So let's.
superenv: Remove HOMEBREW_PREFIX/bin from PATH

We add the bins from all deps instead. Rationale: formula find and use eg. GNU-coreutils versions of things and then break. Only allow formula to use tools that they depend on and expect.

I want to go further and only add include paths etc. for dependencies, I have done some work on this, but I fear it may be impossible. If an include path is eg. /usr/local/lib/foo/include, is it possible to know if this path is bad? Not always AFAICT.
pass 1.4

Closes #15072.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
e2fsprogs 1.42.6

- Upgrade to 1.42.6
- Works well with superenv
- Needed for ext2fuse

Closes #15069.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
ext2fuse: fix build error by using a CFLAG

ext2fuse has been broken for a while because it's an old piece
of code that needs a few cflags for clang.  Macports also defines
a different precompiler variable, `-D__FreeBSD__=10` which it
turns out fixes all our build errors and aslo fixes the need we
had for defining `SSIZE_T`

- Add to CFLAGS `-D__FreeBSD__=10 -DENABLE_SWAPFS` like MP.
- Add a `--std=gnu89` flag if compiler is clang
- Remove the unneeded CFLAG.
- Works great with superenv.

Fixes #12207

Closes #15070.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Fix doctor hanging if xcode-select is bad

Also fix typo in the superenv DEVELOPER_DIR set detection code.
Abort if `xcrun -find foo` returns superbin/foo

Fixes #14691.

Rewrite in Ruby to facilitate checking PATHs properly.
Assign DEVELOPER_DIR before it is needed

On a broken set up, setting DEVELOPER_DIR can fix builds, provided it is set early enough to impact them.
Work even when RUBYLIB='-'

Apparently setting RUBYLIB to '-' causes the library path to be unset. So we need to set our own library path in our scripts.

Fixes Homebrew/homebrew-versions/#47.
libnids: build the shared library

libnids is used by dsniff, but libnids only builds a static library
due to being coded in 2005 before much use of `.dylib` etc.  By
patching libnids to build a shared library, we can get dsniff to
link against it and against glib and gthread correctly without
`LDFLAGS` hacking.

- Add deps on automake anb libtool to run `autoreconf`
- Run autoreconf to fix any issues in 2005 era configure.
- Add configure flag to `--enable-shared`
- Add patch to fix errors building shared with `-soname` and `.so`
- Works well with superenv and dnsiff

Fixes #14363

Closes #15011.

Signed-off-by: Max Howell <mxcl@me.com>
Attempt to fix opt-paths for all deps

Since we changed superenv to set a PATH without /usr/local, all deps need to have opt paths.

Fixes #15077.
libvirt 0.10.2

Closes #15075.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
opam 0.7.1

Closes #15076.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
PostgreSQL 9.2.1

Closes #15079.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
phantomjs 1.7.0

Closes #15080.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
optipng 1.7.3

Closes #15082.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
FFmpeg 0.11.2

Closes #15056.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>
Fix fixopt and fixopt error handling

The Keg constructor was throwing because we were returning a relative path, and the error-handler was just returning a string rather than raising a string.

Worrying because a lot of opts have not been fixed and I thought this was essential for depending on keg-only formula nowadays.

Refs #15077.
iftop 1.0pre2

Closes #15062.

Signed-off-by: Adam Vandenberg <flangy@gmail.com>