labofsahil/github-event-dataset-2012 huggingface dataset:
Seems like an outdated link. We should be pointing to http://docs.nuget.org/docs/creating-packages/creating-and-publishing-a-package#Creating_a_Package
Nope =/ vb fails
Agree. Wrote that in haste to get it working and didn't think to extract. Done, new PR incoming.
Possibly, I'm not sure of the 'correct' way of commenting code. I'm not sure we need comments for each update, maybe just one to point out it has been modified by GDS.

On 4 Sep 2012, at 13:57, Kushal Pisavadia <notifications@github.com> wrote:

> In app/assets/javascripts/jquery.tabs.js:
> 
> > @@ -10,6 +10,10 @@
> >   * Frances Berriman
> >   * Minor changes to support GovUK specific markup
> >  */
> > +/* July 2012
> It's a small style thing, but should we have this as a single comment block instead of being separated in this way?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
I don't know. I just guess that there are several levels, and size optimization level cannot be the same as speed optimization. Disclaimer: I haven't used MonoDevelop ever.
Please avoid indent fixes unrelated to your significant changes. They 1) add line noise in blame; 2) increase probability of rebase conflicts
When I was playing with this, I also ended up adding `astropy/setup*` and `astropy/version*`.  I don't think there's much anything in those modules that are likely to be run through the tests anyways (unless we do add tests for some of the setup hooks...now that would be interesting).
this is not correct - the project name should be "Astropy", not "AstroPy".  Also, for consistency with the PyPI entry and other places, can you change this to "The Astropy Developers" while you're at it?
I see that this is done here, but then the final cast in the return statement is never done (although it *is* in `convolve`) - is this intentional? Right now nothing seems to use `array_dtype`...
I find it useful to have a format string that is easily parseable by humans and machines.  This one could be tricky if the message itself contains a hyphen.  What about something like:

```
%(asctime)r, %(origin)r, %(levelname)r, %(message)r
```

which should parse as a Python tuple -- or almost JSON-ish?
不过大家需要figure out出来一个可行的，用方法名来代替配置的约定。
It'd be nice to at least mention the Makefile in the README, perhaps with quick overview of available targets.  Alternatively, we could have a HACKING.rst file with such things.  I'm OK if you prefer to defer that to a future PR.
Can't be implemented in this way, `urlparse(...)` returns a valid `path` even for strings like `"thisisnotanurl"`
I don't really like transaction code to look at (potentially unrelated) blockchain data, but it's probably by far easier this way.
I guess in this case it is ok since it is the index file in the root folder, so it is safe to assume that it is the normal cakephp distribution
Actually I don't like this logic spilling out of UDPInterface, it is harder but better IMO to do a lookup table in UDPInterface rather than using the IP address as the key directly. Alternatively we could lower our requirements and just do the lookup once and assume that the router will be reset often enough that not all links will change their addresses.
Please add comments describing these constants.
Should we not rely on `codeop._features` and instead produce this as:

```
PyCF_MASK = functools.reduce(operator.or_,
                             (getattr(__future__, fname).compiler_flag
                              for fname in __future__.all_feature_names))
```

For reference, `codeop._features` is implemented as
```
# codeop.py:

import __future__

_features = [getattr(__future__, fname)
             for fname in __future__.all_feature_names]
```
Change these back please.
is it possible to switch to sshj?
Shouldn't this be `Role::where_name('group')->users` instead?
I'm not too fond of this. The index is a binary format; in the case of corruption, it doesn't make much sense to report the details on "*more or less the part of the binary protocol that got corrupted*". It's not like it can be recovered by the user at all.
please use ===. 
This does seem a little too magic -- let me take  a look.
I personally haven't used length on a function before (http://bclary.com/2004/11/07/#a-15.3.5.1)
you can use Enum#flat_map here.
port can be string, so don't check for type. 
added query string
Yeah, I'm not sure, base.py is quite large and it might make more sure to leave this close to the view since that's where devs will be looking. I can move them into settings though if you think that'd be good, I don't really mind.
* NO - the tweet locale comes from twitter and we just blindly stick it in there
* NO - the inproduct locale is set by admins to whatever and there is nothing for sv* anyway
* YES! - the user profile locale is their preferred locale which they select from our supported locales. 

I'll add user profiles.
So these three cases above get nuked and we keep the since below.
I'd probably test the "malformed wiki text" cases, too. What happens if there's no h1? What happens if there's an h2 before the first h1? ...

Given that this is user-driven content, it'd be nice to know that the parser "does a good enough job" parsing rather than "throw an error".
I think we can just have the second condition? If it isn't in the text we don't want it.
well, when i originally wrote this code, ProductVersionResource wasn't CRUD enabled, so it wouldn't have likely helped =)

I was unable to find any examples of code where item A could not be created without creating item B, and item B could not be created without a reference to item A. 

i tried sending the bundle without replacing productversions with an empty array, but it would fail without telling me why (at least without put logging into tastypie code...this would be when i complained on #moztrap about exceptions that have no __str__, __repr__, or message)...my guess is because the items in productversiosn didn't have product fields, because it hadn't been created yet.

i'm open to suggestions, but i was delighted to find something that actually worked.
sorry. this was off-topic. It was hurting my eyes.
This ends up doing 2 queries... one for the `exists()` which looks like a "SELECT 1 FROM ..." in SQL, and then one to get the obj. It'd be more efficient (and to me, clearer) to do the following. It is more lines but 1 less query.

    try:
        addon = Addon.objects.get(guid=guid)
    except Addon.DoesNotExist:
        addon = None
I dislike this change, although it gets more compact it also gets less understandable :)
Here is a good use case for `endforeach;`
In response to my previous comment. Like this but in reverse?
First it's two spaces.  Then global variables.  Then It's a slippery slope ;)
I take that back. Since it now checks for endOfVideo(), I reversed the if/else check and therefore "if (true)" will make it automatically skip all robot videos.
Я виходив з того, що фікстури для сутностей повинні лежати в тому самому бандлі, що і сутність. Іншого варіанта поки що не  бачу
Well spotted. Fixed. Thanks!
maybe $configs as $name =>$config ? dunno, but $cfg is not correct.
Why not `$baseDir = trim(strrchr($baseDir, ';'), ';');` ?
you should be using camel cased names for variables
This is wrong. It will try to read the property when it is not set, thus throwing a notice
yes, it's odd to load other ViewController just for a cell, but there is no other way to do it, that I'm aware of now. Copying cell to storryboard will work too, but then there will be two places to keep cell look in sync - which is not good. Most users will see tutorial only once - so less effective code, that is easier to maintain was my choice.

I'll try to fix that statusbar.
@huxuan 保留这上面四行，可以算是我的最后让步了。
ЗАчем двойное хранение одного значения и в set и в @?
Ah I see, ok.
whoops, java habits. fixed
GREAT SCOT!! The flux capacitor has no concept of a now!
Comment klopt niet.
I'm not sure about this checking :around_scenario here, it seems like a single reponsibility principle violation.

I think this logic could be handled in the "around_scenario" method. Maybe we should be "accumulating" callbacks (so each around_callback executes inside another around callback until the last one).

The other option could be to get rid of "around_scenario" at all. Is there any case that specifically needs around_scenario instead of before or after?
flake8 has a bug with pypy, it's already reported and when it's fixed, we can again test pypy :)
Use a guard clause:

`if ( this.options.disabled ) {
    return;
}
...
`
More as a reminder to revisit once we have some jobs running through cascades. Thanks.
This case never happened but we will change it for a raise instead of a warning.
Instead of raising an error, could we just have it default to False?
а чем не нравится? можно конечно неправильно написать, но тогда все равно не будет видно никому
nit: add a name to the anonymous function
no need to add {} for single line.
is emt an abreviation for element?
You can use `body: document.body` just thinking out loud
For the video view activity I've just implemented, I just call postResult() when the video ends so the inline activity ends and we return to the calling application. Would that be better here?  If the user wants to listen again, they can always launch the music app.
@vingtetun I feel hard to use content: attr(data-text) instead.
Because I use innerHtml to construct alarmList in line 280 ~ 284.
It should be assign two data-text dynamically.
obviously!
+1  Fixed
ha~ I found and filed a issue to myself for this before (#3632). Thanks for fixing it.
What's the change exactly? We can probably remove the code altogether.
Let's put everything in this function into `handleEvent` itself - this can be done in a follow up.
and back to `null`
Yes, you're right. The first value found shouldn't be overridden.
So, Composer wouldn't run on 5.3.3 for you, only on 5.3.2?
It'd be good to have full yard docs for this....care to take a stab at that?
Would that look like this?

    # @deprecated
    # use failure_color(text)
    def red(text)
      color(text, :red)
    end
not sure about this myself...
Also, it seems that headings were being exported as <h4>Heading</h2>.
Makes sense to extend Function2. Where can I use that though?
I agree with Edwin.
This would probably be separate settings for host and port.
Maybe better as {0: [v, t, p],...}[i] though I guess without tuple unpack it's kind of a wash.
The loading method can be changed if needed. If this old method is not sufficient we can create a new issue to do loading of the interface as suggested and do so for the older versions as well.
```coffeescript
return
  if type is 'image'
    something
  else
    something else
```
The other one in Redirect.image too I suppose?
No, I'm just using the normal bootstrap.css, so I can delete those extra files.
For convenience, I used a script called [autoenv] (https://github.com/kennethreitz/autoenv) that automatically executes files with the .env extension in a directory when you `cd` into it. This allowed me to put all of my `export` commands for exporting the various private constants needed for GitZen into an .env file that would be automatically executed when I entered the project directory for GitZen. I want to ignore that file because it contains private constants that should not be publicly available on GitHub.
See comment above about use of exceptions.
Couldn't that just be self.master.name?

Also, I'm not sure that it makes sense for this to be formulaic. If
people start using this to do analytics, then trivial things like moving
the buildmaster directory will cause renumbering.

Certainly, having a formulaic determination is a sensible default.
I think it was because Chaplin's View constructor had to wrap initialize and render **before** calling constructor (which then calls initialize...)
[Do](http://do.com/)はタスクの消化やプロジェクトの管理を簡単にする、ソーシャルなプロダクティビティアプリです。[Do.com](http://do.com/)のウェブアプリはスマートフォン、タブレット、PCでシームレスに動作するようにゼロから構築されました。製作チームはBackboneと[CoffeeScript](http://coffeescript.org/)や[Handlebars](http://handlebarsjs.com/)を記録的な短時間で構築し、複雑なナビゲーションとモデルの同期を行うための独自拡張を実現するために利用しました。
teams find { case (k, v) => v.url.endsWith(team) } map { _._2 }
The omniture module is using some of this data:
author,
tones,
web-publication-date
Why `nargs='?'`? If `--output-dest` is provided at all it should have exactly one argument.
This is actually a programming habit that I generally prefer, because it avoids catching implementation errors along with expected errors.

Although this is not the primary concern, there is also a performance reason: there are plans to implement tail calls, and this `try{}` would kill this optimization.
Good point, although version is supposed to be used.
what does `aVarNames` mean? :p
Change the variable name if you can :)
@zaphod42 I copied this test from the command_line_specs. It's asserting that core_apps are a subset of the values returned by names. Alternatively, I could set an expectation on `:files_to_load` so it only returns the core_apps
Btw, Have I already said that mocha rocks? Because it dose!
Appreciate the link - I checked and it's the crueler JSLint I was thinking of for the var declarations at the top.
For changelog, 80 characters per line is usually the maximum, please.
note to myself: update website!
What style sheet is this? Where would it be located in the code base.
corrected back to negative z and commented
Yeah, the problem is that when you're trying to adjust a number (let's say '0') that's in the top left to begin with you can only get to about -100, at the very least, whereas you'd be able to get to a number like 1e-12 very easily (which is likely only going to be needed very rarely) since the screen is typically longer than it it is wider.

Oh, which brings up a second bug: Since it's possibly to generate numbers with such high precision the 'e' ends up breaking the number selection (since it isn't detected as a number). I think it might be good to just limit the precision to not go below the range at which 'e' starts to appear (after some light testing, that appears to be e6).
This was causing an issue for me. I don't have MVC3 or Razor1 installed in the GAC and as a result things failed. Maybe version 407 was removed from the gallery? Anyway, this shouldn't have functional impact, just a dev environment fix.
happend -> happen

or

happend -> have happened

depending on what you want to say.
I think we should also be checking whether the canvas has focus. Otherwise, if I'm typing with the text tool and accidentally move my mouse outside the canvas, I won't be able to type anymore.
Zidane asked some commits ago to have it for Entities.
According to wikipedia, capitalization should convert the first to upcase and the remaining to downcase.

I believe we don't need to change the `unicode.ex` file for this change. We could simply ask for the first codepoint, upcase it and then downcase the rest.
To get this correctly, you are working on this in develop, and this is the reason why there's a separate reg test branch right?
Not yet, I don't think.

The nodeunit tests work with EJSTemplate, but KumaEJSTemplate is collecting all the surprises I'm finding as I integrate kumascript with kuma (eg. Bleach messes with <% %>, some characters in template source get encoded, etc).

I expect to find some more integration surprises, and didn't want to rewrite all the tests yet.
Yeah I think this one you can assign right here without globals(), while below you need globals() because the name is programmatically generated.
How about:
```python
{{ personal_message|replace('&#39', "'")|replace('&#34', '"') }}
```
Should use `urlencode` like L125.
I'm actually ditching ```class="location"``` entirely. Pull request coming up.
And yes, branch is necessary. Will add it too.
use the same style of declaration above, so it all looks consistent. i.e `var addScript = function( url ) {`
That's what git did. I don't know anymore about git than what I pieced
together from the wiki page on building murmur and searches for how to
check out a specific tag.

On Friday, December 14, 2012, Jan Klass wrote:

> In opus-src:
>
> > @@ -0,0 +1 @@
> > +Subproject commit d060dd7cbd6405c8a31510ca17adb1e051934f49
>
> Your changes to pid handling should not linked to opus changes, right?
> Could you update this PR to not include submodule changes?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mumble-voip/mumble/pull/139/files#r2425954>.
>
>


-- 
James Sumners
http://james.roomfullofmirrors.com/

"All governments suffer a recurring problem: Power attracts pathological
personalities. It is not that power corrupts but that it is magnetic to the
corruptible. Such people have a tendency to become drunk on violence, a
condition to which they are quickly addicted."

Missionaria Protectiva, Text QIV (decto)
CH:D 59
If you end up editing this pull request for something else, I think the Default link and the confirm message should be translation strings. If you don't, np, I'll get it when I do the deactivated styling.
@kellyredding - Why did this move from the data class to here? Guess it doesn't really matter, just curious.
maybe I'm missing something, but we already define a constrain for the host_id above, why do we need to define it again?
That `st.blank` refers to the `blank` keys in `statusIcons`, which are booleans, not functions.
Continuing the thread above, it seems like this is a change in behavior that is incorrect. We want this to call the failback to occur.
I would only clone the repository if no artifact is available. Otherwise we should really do: 'hg pull -uC'
again this looks like job for merge method.
Why "follow" and not the more known "tail"?
This is a preliminary version in reworking the architecture while maintaining the compatibility with the existing behavior. I've focused in working out the logic and more commits are coming soon.
How is the `repository` field set?
Guessing this should be %3f
By "enchant", did you mean "enhance"?
This conditions always return false, this make sense?
The issue I just opened on Paul's original repo (https://github.com/ericmbarnard/KoGrid/issues/63) bites your changes here, and anywhere else you're using KO's "css" data-bind.

For your fork, changes to fix are:
ln 2714: element.className += " kgCell " + "col" + cell.column.index + " ";
ln 2814: element.className += " kgHeaderCell col" + cell.colIndex + " ";
I refactored and put an 'option by option' handler in a separated method :ok:
generally I've found that modeling data as close as possible to its actual form is a good starting point. Here this strategy happened to work well
Probably need to add a "type" field so we can distinguish easily between the different card types
You're not actually using this width for anything, so I think you can delete this.
I'm surprised this works. So you install `generate_test` as a builtin when executing that test but it still has access to `tests_as_list` through a closure? I didn't know python supported such.
Oh, right, thanks Eugene! Looks good then.
And writing unit tests now for this class now... ;-)
This method call, and all the infrastructure to support it, are not needed anymore, as the attribute in the marker is used instead.
Please revert this change.  `req.accepts` was functional the way it was before and was an easy way to determine if a content type was explicitly passed.  Now it's just useless as it always returns true regardless of whether I pass in a single value or an array.
Your formatting here does not match the rest of Cyphesis at all. On any codebase you work on, it is important to match the indenting, and other style elements to the existing codebase. You may come across programmers who make strong arguments for particular ways to style code, including the indenting, and the placement of parentheses and brackets, but the truth is they are all wrong in a way. The only thing that really matters is that a codebase must be consistent.

Look carefully at the other source files. See how much the code is indented, and where the parentheses and brackets are placed, and make sure yours are the same.

For clarity, each block should be indented with 4 spaces. You have a mixture of 2 and 4, inconsistently applied. Your { symbols are also in the wrong place at the start of the functions.
Cookies seem like a tricky area. Many of the real browser drivers don't support them, no? For example, my scenarios don't work at all under Sahi:

```
    Then the browser should receive an "exp" cookie         # FeatureContext::assertBrowserReceivesCookie()
      Response headers manipulation is not supported by Behat\Mink\Driver\SahiDriver
```

This makes me think I'm going down the wrong path by having scenarios check for cookies (which seems pretty uncommon and possibly unBDDish). This is tricky, because I'm not testing something observable like signing in. This for an A/B test system, which is supposed to be sort of invisible except that it might show different experiences, but I haven't defined those yet. I wonder if it makes sense to emit the bucket assignments in an HTML comment so that the tests can do assertions on that rather than cookies. Not sure how others will feel about that though. Suggestions for a BDD n00b...? :-)
Пофиксил https://github.com/volt0/osx-project-1/commit/f2c7924b091ba80fb40a7fde1595999ef79b922b , теперь действительно рандомное число, отличное от предыдущего, генерится в 1 итерацию
Нет проверки на количество процентов.
У вас возможна ситуация когда  в массиве **IndexSet** найдутся повторяюшиеся символы, тогда мутация произойдет не правильно, одна и та же ячейка мутирует 2 раза, а следовательно мутирует не 
````
...СТРОГО X процентов
````
absolutely, I missed that on my merge sorry. Ill push up the change now to take it out
That should be id 79.
Should the attribute be data-fixer as fixer isn't a valid attribute?
spaces -> space
I cloned because I was not thinking about your idea you just proposed and encountered an issue : 

if you write, it will echo "0" : 
```php
echo count($imagine->open('image.gif')->layers());
```
Because, as soon as the `Layers` object is returned, the `Image` object is destructed. The destruct method of Gmagick\Image calls `\Gmagick::clear` and `\Gmagick::destroy`, so the `Layers` object contains an empty `\Gmagick` instance and return 0 layers.
I didn't like this hard coded ajax call. You should abstract this into a model in my opinion.
This doesn't look like it's necessary?
Yeah, @Coneko nailed it. This was added before the protocol (just to demonstrate to myself that the primitives I had were good enough). It's going to go into `<RACStream>` later.
*concatenating
It seems the overrides defined in default.less aren't being applied (changes the background colour of the navbar)
Avoid function invocations for really simple operations.
Done! Is the documentation for this parameter okay? The git documentation doesn't say anything about rev-parse when it mentions "treeish"es or "commitish"es, but it seems to be the right thing.
compliments the removal in app/application/config/database.php
Let me add a unit test for this.
I think I would check for valid top-level keys *before* doing the recursive `ej:valid` call. Probably not a big deal, but checking the top-level keys feels like the light weight step so I'd expect it to happen first.
towns vs town's - posessive
Thank you for review, I agree with all comments.
I implemented "function creator" here, so that's why I used closure.
But If you have got other better technique, please send reference for it to me.
jQuery always returns something so you don't need to check anything here. If there is nothing to attach a click handler to, it won't do anything.
There is another case: if you return ``null`` (most of the time because you forgot the return statement), an exception will be thrown by the kernel
This is a tough one, it's technically still `%kernel.debug%` - but the Configuration parser could never know that, since the "debug" value is just passed in as a boolean value and then used.
it is. See the link above
意译：
与以下指令共同确定指令开启。
Please place after Adam Lundrigan's blog, because of alphabetical sorting.
Twas overkill.  Stripped out all the unnecessary info.  message was a string representation of all the other params.  I left message and removed everything else.  It might have been structured that way to allow the sender to reconstruct and resubmit the message, but I suspect there's a better way to do that than pulling it all out of an exception.  Will wait to see if anyone screams...
How about rename `list_hints` to `valid_hints` and write it alphabetically as

```
valid_hints = [
    'base',
    'comnutator',
    ...
    ]
```

And then keep your checking loop clean:

```
for i in hints:
    if i not in valid_hints:
        raise ValueError(...) # ValueError, not TypeError, isn't it?
```
pep8 here and below
Y esta 1/8.
"Send an email to the user with his credentials"

The checkbox is checked by default
I know this has been merged already, but we might want to make this function more readable. All the one letter variable names are very hard to translate to a meaning and this function will be very hard to maintain for everybody that hasn't written it and even for the original author 3 months from now.
Hello,
you are right; I initially added it for the btMatrix3x3 dependency, but then dropped it to use tf::Matrix3x3 .
I thought I had already updated it in Github ...
Regards
Comment out the printf or covert to logging
I like it! Could you put `config.controller.... & ACTIVE_ADM...` in a method?
I'd imagine per command to keep options available for a command limited.
We've missed the ```.lower``` part here. Other than that, I'm more than happy to press the big green button :smile:
Ah, if colour names are case insensitive then it's unneeded. Thanks for pointing that out.
var child is redefined here
Good feedback, otherwise everything would start with "it returns...".
Just wondering why you chose to remove the declaration of the options array out of the initial declaration of the $plugin_list['csv'] array.
I think that it should stay where it was as that's more readable...
These can remain untranslated, could you remove them from this file to avoid duplicates?
Can you remove the whitespace?
This is only nitpicking but I think there needs to be a space between the `;` and the `URL`
When this block of code is entered (i.e., we're using a QueryHandler), we no longer have support for the "sakai:query-template-defaults" parameter in the search templates, which is causing kern-1045.rb integration test to fail. That functionality should still be supported.
Can anybody think of a way to trick sprintf() or preg_match() with unicode chars or buffer overruns to accept different DB names? `</paranoid>`
I don't see why you would use the id in such case. Either they configure the hostname and they don't bother about how we do things internally, or they want to use the service themselves and they define it and give the id (which is probably not the common use case anyway).
Also : "escaping as late as possible" usually means either using the ORM or parameterized queries to do the work for you. You should almost never need to call $db->escape() or escape_str() manually
Eventually we could do that in 2 passes
first check if we can find any handler for request path and method ..
if not, and if request is HEAD, we could look at handler for request path and method GET

This is not yet perfect, because we have to be sure the handler will process HEAD .. at least like a GET .. but also being sure no content is sent ...

I will try to think more about it.
I will try to review the other points, but right now I am very busy with other urgent tasks, but I will try to review and work on this patch each day.
Is it possible to add a @param annotation for parameter ``$bundles`` which defines the array type; using "array<SomeType>", or "SomeType[]"? This would help me, and IDEs to better understand your code.
How about making the return type a bit more specific; maybe use ``RedirectResponse|array``? Please also check line 134.
indentation, also consider using `{}`
I'm guessing we'll want to support multiple owners for a package at some point. Will it hurt us if we don't plan for that now?
Apologies, I've been writing too much CoffeeScript lately :)
The `@throws` tag should come after the `@since` tag.  That last grouping is in alpha order.
Doh, sorry you are right, since the target feature type is already there it already has ordering.
This method use's Yesmail's SubscribeAndSendComposite API. It looks like you just want to use their Subscriber API. I would create a new method for that.
Check here that notification points to comment/post, or whatever the content it has.
Dot is missing at the end of the sentence?
Good idea. We probably really need current user in JavaScript too. But make it an object. So `user` JavaScript object, which has for now `username` attribute only.
Hard-coded URL. Spaces.
Yes, convert. ;-) You should always try to normalize data before storing. And then you output in the way you want it.
Через интерфейс
why is the function not used?
Change to void, is always true and not used
See comments about factories.
Agree with that. I remove them.
There are two reasons that I store `entityName`.

1.  I need the correct mapping between tables and entities and fields and properties especially when annotations such as `@Table`,`@Column` and other annotations that change the corresponding tables and properties' names on the datastore exist. Without following the mapping, the datastore can't determine which goes to which since the table name and field name are not the same as their entity and property name anymore with those annotations. To get the mapping, I need to access the annotations that `entityName` class has, so that I can correctly map for the datastore.
2. It's necessary to get the correct type of properties whose keys in the tuple are different from their properties' names annotated by annotations such as `@Column` or `@JoinColumn` when deserializing them to objects from JSON. Without getting the correct types, an `IllegalArgumentException` is thrown because it tries to assign a variable with an incorrect type.

Yes, I agree with you on 
> It would be great if you could figure out the entity from the used table and field names, as Hibernate always does from other databases.

However, I have a question about the quote. I'm less familiar to Hibernate internal than you are, so if I'm wrong, please correct me. Hibernate figures out the entity from the used table and field names because it processes annotations on an entity in advance and understands the relationship that the entity has. But could Hibernate know the entity from the used table and field names without getting the relationship from the annotations ? That's the situation where I got stuck because I got used table and field names but neither entity nor property names.

That's what I wanted to achieve before getting the current solution using reflection through `entityName`. However, I could not make it right based solely on the used table and field names.

> If you really need it, I'd prefer to see some consistency rather than have it occasionally set to "" as in the current code, or we should at least commend this carefully.

If it's possible, I would like to remove `entityName` from `EntityKey` class because that's one of the core classes and other datastore provider might not need it.
these two fields could be declared `final`
This backend's been deprecated in favor of the psycopg2 one; we shouldn't mention it.
we get this for free from `BaseStoreFunc`.. or we will when [this ships](https://github.com/kevinweil/elephant-bird/pull/256).
Do you mean for me to copy that code example or can I access that like a property? I can't see it exposed to a project using bidpom (as it's only in BaseTest), although that could be a useful change, in line with the bidpom's purpose of saving code duplication.
That's nice, making the tpl and stringifying it is probably really quick? Maybe you can even `return` in else?
this line is in here twice now
the app.settings.py is the production settings always, is't it?
http://hackage.haskell.org/packages/archive/xmonad/0.10/doc/html/XMonad-Core.html#t:WindowSpace
yes, to make clear this is using a different controller
Okay, I just merged the nodes into SpoutConfiguration for static access.
Dict keys put convert into strings:

```
google.load('search', '1', {`language`: lang_code});
```
yes it should.
Could you do a git mv to preserve file history???
I'll be honest... I have no idea why I used both POST and PUT. Let's kill the PUT for now.
Agree!  A demo script should offer almost instant gratification in my opinion - the use of the code is not demonstrated any more effectively by simply performing the same tasks 99 more times, after all.
The host field should contain only the requested internet host (not the rest of the URL).
Perhaps have an AfterTest(alwaysRun=true) that shuts down the executor (and store the executor as a field)? Otherwise thread will stick around for a while...

I'd have probably made the method non-static, but not sure about that...
Running the suite of integration tests for a customer was hanging for me 
(indefinitely? for hours at least, until I killed it), with the thread 
stuck at something like the stacktrace below:

    java.lang.IllegalStateException: Connect to URL not complete within
    60 seconds, for url http://localhost:18004/helloworld/; stacktrace
    [java.net.SocketInputStream.socketRead0(Native Method),
    java.net.SocketInputStream.read(SocketInputStream.java:129),
    java.io.BufferedInputStream.fill(BufferedInputStream.java:218),
    java.io.BufferedInputStream.read1(BufferedInputStream.java:258),
    java.io.BufferedInputStream.read(BufferedInputStream.java:317),
    sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:690),
    sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:633),
    sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1195),
    sun.net.www.protocol.http.HttpURLConnection.getHeaderField(HttpURLConnection.java:2300),

    java.net.URLConnection.getHeaderFieldInt(URLConnection.java:579),
    java.net.URLConnection.getContentLength(URLConnection.java:474),
    brooklyn.test.HttpTestUtils$1.run(HttpTestUtils.java:66)]

Not sure what the exact situation was, but probably involved https.
updateTaskAndFail...  (or make that behavior the default and have a failOnNonZeroWithoutUpdatingTask, which might be better)
Is `!important` really necessary?
It was removed from dart sdk/pub, not sure exactly why. @efortuna might be able to expand on it
Why did we remove this method?
This might break if the page_url starts with a slash, no?
Fred said no quotes, to put in: {'body':  ... a response reader object... , 
I tried that and Sphinx choked. I think Sphinx gets confused by pseudo code--it won't format it as an example because the code is "wrong". 

One way or the other, this will need to be a manual fix for me after compiling the HTML docs.  I'll follow up in email to show you the two versions that Sphinx creates depending on with or without quotes.
лінк перегляду чіпляй одразу на назву категорії.
Also, can you redirect back to ``/accounts/?tab=notifcations`` so that the correct tab is open after the form submission?
No need to pass a QPainter here. You can just do:

QPixmap p(30, 30);
QPainter painter(&p);
painter.drawRect();

in the collaborativeIcon() method. It should return a QPixmap, like typeIcon()
nope. if you happen to log in with your username instead of your email then secure.security.connected().first() returns your username not you email so you should do a find by username in that case or when you comment you will get an error
Does paginator.count return the total number of things or the number of pages that would show the number of things?
Why not use datasource here?
remove it yourself. developers are given admin rights on our server, and have to go through a vetting process like any other admin.
This tries to add the feature to heat/cool energy particles by checking the photons map as well.
this isn't necessary, since it is explicitly populated immediately prior to this call.
Just the same as above, you should use `${::operatingsystem}` and `${::lsbdistcodename}`.
Не будет работать в случае наследования.
space too many
it's -> it is
*scientific
revert this. You should use relative imports
@ogrisel I've thought of two options: either remember the sample_weight after the last boost so it can be reused to continue boosting, or we could iterate through the already existing trees and recalculate the final state of sample_weight before continuing to boost to a higher `n_estimators`. The fit could accept an additional `append` argument defaulting to False. @glouppe @pprett any other ideas?
link broken, as this is the current module, I think. Use sklearn.gradient_boosting?
Since it is embarrassingly parallel and each transformer can take time to fit, I think supporting `n_jobs` would make sense.

> Are there any transformers that use n_jobs?

Not that I know of but I hope that users have enough common sense to not enable `n_jobs` at two different levels :)
I feel this does also rather belong to ``test_common``.
I would use `neural_network` without an s to be consistent with `linear_model`.
This commit is no longer here. I rebased, doctored the commits and force pushed. I assumed GitHub will be able to handle it, but apparently not.
Changed to your suggestion, thanks!
bracket before $
Hi Benjamin, and thanks for the contribution,

This check  (l.110 in former version) seems to have disappeared in the new version of the code, am I mistaken ?
The second nitpick : visually, the ``<div class="source">...</div>`` would benefit from a larger padding/margin at top and bottom : do you think you could quickly hack this in too ?

Other than that : *all good and pretty useful !*
As I already mentioned in my blog: it's not just about the scroll buttons. I do have reasons for choosing the wording! ;)
These are usually allocated on the stack, not the heap.
We should be passing `self` instead of `nil` for the `object:` parameter when we post the notification.  Notification Center uses this object to allow observers to subscribe to specific notifications from a specific object.
Beat me to it by a pageload.
This line triggers a warning in NetBeans because it looks like an accidental assignment. Not sure if anything can be done about that.
I could make these the same test.
I think the proper way to do this is using `to_python`.  This way the value the user entered is preserved across submissions, but the value that comes out of `cleaned_data` is the coerced value.

<https://docs.djangoproject.com/en/dev/ref/forms/validation/>
Actually, the whole switch is odd. I'd think that it was a decision to early abort expected to be long (thus the switch), but in the end became irrelevant, and instead of removing the whole shebang, a short-circuit (of the short-circuit) was created... 

Maybe we can remove the whole thing... not sure about the semantics of that, but today, that's totally bypassed.
A memmove of 0 isn't a problem, I wouldn't special case.

The cur++ which occurs if this is the last element of the sting is strictly speaking undefined behaviour since it no longer points at an object.  (I can't imagine it will cause any grief.)  A break would be more correct.
If you are going to leave MORE comments in you should at least be consistent about how they are cased.
Could this create problems with unreceived messages?
now it is simplified it could just say return.... and avoid the temporary variable etc.
Better name would be nextCapacity - it was confusing when capacity is used on line 3832 for the size to create.
I would just let it bubble up with what the error was on the middleware then. If the middleware says it was 503, we should bubble it up as such. 

Using 500 is otherwise good because it's basically a catch-all for all things unknown. Which is what happens with an else statement.
Double-quotes should ALWAYS be used for this project except when the string contains double-quotes. Otherwise, this patch looks good. Thanks!
I understand, i have to think about this
While I understand the arguments regarding YAGNI and having context-specific tests, the reason I added IsAssocArray::test() was because I've run across the need to check for an assoc array several times, and didn't want to duplicate code.

I've used code such as included in that method, as well as Thinkscape's suggestion, as well as one that looks like this:
```php
$keys = array_keys($array);
if ($keys != range(0, count($keys)) { return false; }
```

The main point is having a way to detect if an array is behaving like a _list_, vs. a _hash_. The particular method I used was largely because it was more performant than the array_keys + range solution, but if Artur's is even faster, I'm game. 

As far as what constitutes a list vs a hash in PHP, I have to concur with Artur -- the moment our array keys are no longer in strict sequence, I'd consider it a hash.
`collectTemplateData` is better as it group parameters by template.
Here you should call gimme_minute() directly
Would there be a difference between saying  `if t:` and `if t is not None:`?
Will take care of these after today's work on retrieving class names in separate API call.
`(not (empty? ...))` would be a better test
no () around the boolean clauses
Maybe add a comment (I don't feel strongly about this):
```python
# params = [a0, a1, a2, b0, b1, b2]
```
Oh, I didn't even realize that this was strictly for binary images. Matlab's equivalent function has the option to use a grayscale image, but that can wait for a later PR :)
Because changing the order showed the presence of the issue before the mapping code was changed ...
Should be able to remove the import of power_state, shouldn't we?
This file, and the `DistanceIntervalMaterial` argument below are not used and should be removed.
If you're only concerned with documenting the name, type, and a description for each field, you can use the `@property` tag. 

Also, I noticed that the changes in this branch to build.xml, perhaps from commit da9a0e9f5702c00ea7c468152a582256ba815be3, broke generating documentation for the .glsl files. I was able to work around this by generating a `filenameComments.js` file for each GLSL file. Is this overkill? Would it be better to concatenate all the GLSL comments into a single file (or at least a single comments file for each directory)? CC: @shunter
The Eclipse XML editor settings default to tabs, not spaces, and of course there's no relationship between the settings for text editor tab/spaces and XML tab/spaces, and no way (currently) to set this per-project.  The rest of this file uses tabs, so for a cleaner diff stick with tabs here in the build file, and later we can switch it, find the Eclipse setting, put it in the Eclipse setup guide, etc.
The pattern is different in the public repo (for example, we have a conditional inclusion)
Hi @danbev wdyt about refactor the method above to:

    @SuppressWarnings("resource")
    @Override
    public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {
        final HttpServletRequest httpServletRequest = (HttpServletRequest) request;
        final Throwable throwable = (Throwable) httpServletRequest.getAttribute(DefaultRouter.EXCEPTION_ATTRIBUTE_NAME);
        final PrintWriter writer = response.getWriter();
        final String html = ErrorFilter.readTemplate(TEMPLATE, throwable);
        writer.write(html);
    }
The casting to ((HttpServletResponse)response) is redundant and  @SuppressWarnings("resource") on top of the method makes our code more readable. Wdyt?
we can just use one of javadoc `@deprecated` or the annotation `@Deprecated`, they should be functionally equivalent IIRC
Ok, makes sense.  Then we should probably merge the kroll.DBG condition with the previous if statement.
I don't think this is necessary b/c we don't know if future versions will have this bug.
We need a `callback.passed()` here as well, to indicate that the test passed. I'm unsure why Android passes the test without it.
So there's two conditions that you must meet when calling this method.

1. This is the first time you have called on this instance, so you can pass in a valid Java object reference.
2. You have called this method again after the first call. You can no longer pass in a Java object reference.
    It is only valid to call this again with NULL to force a re-attachment with the Java object.

The correct assertion expression for this would be: `ASSERT((javaObject && javaObject_ == NULL) || javaObject == NULL)`
... you can only add and remove sections by setting the data property:
table.data = [ sectionFish, sectionFruit, sectionVeg ];
Print a more helpful error. Also, is it okay to continue after this error occurs?
Agree with this in principle, but not stylistically I would put my vote in for the one liner option in this simple case...

 ```bash
[[ -e ~/.bash_profile ]] && source ~/.bash_profile
```

or at a stretch

 ```bash
if [[ -e ~/.bash_profile ]]; then
  source ~/.bash_profile
fi
```
Okay, so you've said "lint doesn't like functions inside loops— which lint is that?
Раз это теперь аплодеры, то почему они называются файлами?
Sure — we already specify that it's 2.0.0, so why duplicate it?
Why modernizr can't be loaded into proper asset pipeline? Why it must be separate? This is problem for whole project. Bad usage of asset pipeline.
As I already wrote, no changes in this code. Is is practically needed.
alert alert alert - mixed style in the same module and by same author "if(" and "if (". Please use "if (" throughout, as is the case everywhere else in std.algorithm.
I see that indention is indeed screwed up across the whole diff.
I did extract part of the condition, because it may make sense in other places. But this date assignment at the moment is only happening in this file, so not sure if it's worth putting it on Measure.
bzzt
> What do you mean? Those are just a comment explaining what happens to get to this point in the code. Maybe the comment isn't so clear? I can remove it.

Ah, then perhaps:

```
Preconditions:
...
```

It looked just like commented-out code.
where did we decide that? (not that I'm opposed)
local constant?
Also sucks that the spacing got messed up here.
Is GWT able to know that options.getResources() will return always null or never null ? In others words, does gwt will prune the if or else branch at compile time ? 
I don't want to include default resources if it is not used !
Can you add this same test to EssentialsSectionPresenter?
Yeah, gotcha.
Need the openrasta one there
You probably need to call this function somewhere.
Should be `views/app`.
Нахрена тут QPointer?
Now that I've recommended removing this anyway, I guess this comment is irrelevant :-)
one more blank line here
use ingest_ instead of archive_
What you suggest is what PEAR recommends, but ZF recommends aligning on the equals.  After having used both, and after talking with others about it, we have found it easier when *reading* code to look down a single "column" of concatenation (i.e., when aligned on the equals). Does it cause *editing* troubles?  Yes, but only when you change the length of the variable name.  I think the tradeoff for aligning on equals is reasonable here.
Actually, this is fine. This is what's shown in the invitation message template
Just added to allow actually testing the code.
First reference of ROS - need to expand and define the TLA
To my students I would say to import only modules. This makes things in general more structured.
`además del deber` > `más que deben`
Alright then!
This needs a double slash.
This probably shouldn't be case-insensitive.

Also, do we want to match `@inheritdoc` in the middle of a comment, or do we want to only match docs which start with `@inheritdoc`?
kinda weird indentation.
we could make it a configuration option that can be true, false or auto, default it to auto and only do the class check when set to auto. its what we did in quite a few places in cmf bundles. shall i change it that way?
yes, looks like I missed the constructor too as it needs to accept 2 fields to specify "key", "value"
anotherdb?
I imagine this should be `!Functions.isWindows()`, rather than being hardcoded to `true`.