labofsahil/github-event-dataset-2012 huggingface dataset:
#  MetronomeBar::setCurrentBeat slot

No need range check ? (any case when setCurrentBeat get invalid value ?)
If no need or don't want the check every times, but assert macro still helps code readability.

 Q_ASSERT(bpi >= currentBeat && currentBeat >= 0)


> This could be optimized to repaint only changed regions but it just makes the code trickier.

I see that can not take a straight approach for NJClient.
update signal by passing the range (prevBeat, currentBeat) may helps though,
but no need that optimization yet. leaving that comment is enough ok for now.

Current patch code has call update() twice at BPI change, that in reset() and setBeatPerInterval(bpi)
but the area of MetronomeBar update is not so wide and BPI change is rare event, I think performance won't be problem.
this can leave until when need optimize or cleanup code.
@vicb When I said ``null`` was never used, I meant explictly. It is called relying on the default value. But this would work if it is set as an empty array directly
Ok...

Couple of things...

This is clearly labelled as a work-round and should be treated exactly as that.  It is not perfect, but solves a problem... The define that inverts the signal can be re-named to make things easier, but that assumes that a more elegant software solution cant be found.

As for the pin numbers you refer to. those pins don't perhaps match your hardware, but they do match mine.  Unless a standard is set by someone, there will always be inconsistency between hardware setups so users will all have to tweak the pins.h file to their needs.  My setup is currently hacked together on stripboard and already I have ideas to make it more practical  (I am using two aux ports at the moment, I can do it all on one)

Thanks for the heads up on the wire bridge, This would be the most convenient approach.
ça me va
I will look into it.  For now you can use the -t flag to build.bash to use the tip and ignore the checksums.

This might not be related to the patch.
Wieso redoStack.Clear();? Dann brauchen wir doch keinen Stack...
redoStack.Clear() wollen wir soweit ich weiß *nur* bei SaveSnapshot aufrufen
why do we need a new method? can't we use toggle_check? Where does using toggle_check break?
yes, got a compile-error on that.
The killer bits do nothing if the process terminates normally. They just also allow a kill -9 to be sent to the process without requiring any special features in the SSH client (the ssh spec allows sending signals to remote clients, but no one's implemented it so it's an unused portion.
Estou Conectado......
I'll see if I can make this part of the query url.
Wouldn't __traits( compiles, { *here = writeThis" ; }) be nicer?
I'll give it a shot over the next day or two ha but might need a
walk-through.

Anyway will see you Friday at 630! I'll pick up Murrays again

On Wed, Mar 7, 2012 at 8:14 AM, Cameron Westland <
reply@reply.github.com
> wrote:

> Think about this: Try doing fizz buzz without any if statements at all. If
> statements are a symptom of procedural logic and you want to start thinking
> in terms of polymorphism. If it's too tricky we can do that as an exercise
> together on Friday!
>
> - Yes I will be your JS mentor no problem.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/mcranston18/katas/commit/c664d4c594660719cb80d5cc57d824b594daee64#commitcomment-1053123
>
we have this in https://github.com/mozilla/zamboni/blob/master/mkt/developers/templates/developers/base_impala.html#L7 - does that not work?
内存泄露，这个你delete了么？
heres the thing... pretty useless
The option should be `--with-apr-util` and **NOT** `--with-apu`. Please update this line to help others not getting crazy. ;-)
Thanks for the notice! Fixed in b9d4b67
Basically cancels all the unloads from DC chunks.
Great stuff - many thanks!
i wanted to let you know that i applied this and it causes a small problem when you go to edit a users permission it adds this to the top
https://www.jaysonberger.com/image1.JPG

and if i undo the fix the issue goes away.
@Venugh MAKE A PULL NAW BEFORE HE TAKES IT BACK! :<
I'm getting a crash with this test on 32bit.

```
Program received signal SIGSEGV, Segmentation fault.
0x0807d584 in clever::Array::push (args=0x80b9488, retval=0x80b7438, value=0x80b88c0) at types/array.cc:43
43		ValueVector* vec = CLEVER_GET_ARRAY(CLEVER_THIS());
(gdb) p value->getDataValue()
$1 = (class clever::DataValue *) 0x3
```
The problem comes after https://github.com/TrinityCore/TrinityCore/commit/2293d2d7dfab3470c6d1fbdb84d7df691ac93240
After that rev the eye "falls", but doesn't really falls, it move like a pet to the player's position, then you can control it without problems
Yeah, it apparently affects more than syntax so Bram was kind enough to point this out.
I think the previous label is more accurate than this. Shouldn't the label element reflect the expected value to be entered in the associated input? This text seems more like a legend.
If anyone knows a better way to do this in order to identify videos let me know. For now we do it the hard way.
not sure how does it work without this commit, so test it if you think you have some problems with range :)
Do you have any other options enabled? I can't reproduce this.
I was wondering the same thing... :)
Hi Dan,

Any luck with why these tests would be failing on my machine?

Cheers,
Byron
This worked when I wrote it...
Also, the old way changed it while typing in chat too, which is what made me change it.
Test = True
A followup comment on the first defending the text I wrote from the harsh review.
On Sat, 25 Feb 2012 02:45:54 -0800, Kirill Bychkov wrote:
> BTW, my version is SHARED_ONLY=Yes. OK?

It provides static libs in any case, so even if you want to enable
shared libs (additionally), SHARED_ONLY would be wrong.

Where's your version of the port?  I didn't find it ...

> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/jasperla/openbsd-wip/commit/63adfa0e081d59c6e5eaa833635b3b
> 8d48ee83d0#commitcomment-1010609
> 
>
true !
It occurs to me that this probably breaks gcov... and/or whatever else we wanted to call exit() for, that probably has an onexit callback we care about.

Probably we need to fix the daemon to do an actual shutdown here?
So you'll pull it ? :)
I would expect so and regardless it will be notably cleaner code.
*cough* OCD *cough*

(inb4 Look who’s talking.)
This expects the following DB update:

delete from creature_linking_template where entry in (15514);
insert into creature_linking_template values
(15514, 509, 15370, 1030);    -- buru egg - aggro on aggro / respawn on evade / don't respawn when boss dead
This will be always `null`. To make this working we need changing from `private` to `protected` in [parent](https://github.com/symfony/symfony/blob/master/src/Symfony/Bridge/Doctrine/Security/User/EntityUserProvider.php) class.

Also entity manager is no longer available.
wir brauchn lediglich nurnoch jmd, der ulduar fertig bauen kann, den rest kriegen locknes und ich selber gebacken
Oh haha duplicates. Got it. Fixing it now. :)
I moved the call to dialect.buildSQLExceptionConversionDelegate() before adding SQLStateConversionDelegate in case the same code is interpreted in different ways. That way the dialect-specific delegate will have precedence.
Right enough, you can change Scribite to a tag.  Can you edit this file accordingly please?
warning: suggest parentheses around assignment used as truth value
After changes, main page wouldn't show, and gave error that this didn't exist.
Could you provide a reference to that ?
Utilise plutot les references pour ces fonctions au lieu des pointeurs, non?
Je pensais que pour les collisions on peu utiliser lintersection de lignes (ou droites) qui nous permet d'obtenir le point d'intersection et donc de faire une simulation parfaite de façon rapide (sans faire une boucle a petits pas de mouvements)
lol eai is old. smartai is what we use these days.
Let's change this to "Create Invoice"
The size of the buffer would need changing too, it's now length 14.
Central is supposed to be self-contained, so artifacts on central shall not refer to any external repositories, except when masked by profiles. In particular, there should be no references to snapshot repositories. Don't know if the Maven Release plugin or OSS  Nexus has some sanity check for that.

If you don't want to build the snapshot dependencies of Pax URL locally, then why not simply add a profile with the OPS4J snapshots repository to your settings.xml. That's easy to turn on and off, and there's no risk of forgetting to remove temporary stuff from the project POMs before the next release.
Use isEmpty(); size() may be expensive depending on the type of list.
So, is id 0 special in OpenGL?  If yes, you would want to change the default counter value to 1, and also add the check for id 0 to remove() as well.
Får du någon respons då?
Hi,

I created an application one year ago using jstree and the html_data pluggin. The html_dat ais build dynamically with a recurring php routine. Works fine if the number of child is limited, but it become too slow and even hangs if the number of branches/child get too high.

So I'm trying to use now the model_back pluggin (found it by pure chance). Looks great, but I really do not understand of to use it in conjonction with the html_data pluggin.

In the provided example, the root node is created in advanced, statically. While I need to create the nodes by reading data in a database (nested structure).

Can anyoen help me by pointing me to an example of previous discussion on how to use model_back together with html_data ?
Or is there another way to buils the nodes dynamically for model_back, without html_data ?

Thanks in advance for your help.

Rgds
Franck
Well I spoke to soon it seems :) 

> phpunit-dev/bankaccount$ ~/phpunit.phar  --process-isolation
> PHPUnit 3.6.10 by Sebastian Bergmann.
>
> Configuration read from /home/edo/Desktop/PHP/phpunit-dev/bankaccount/phpunit.xml.dist
> Fatal error: Call to undefined function phpunit_mockobject_autoload() in phar:///home/edo/phpunit.phar/PHPUnit/Util/GlobalState.php on line 378
We should consider a version of lerp/slerp/squad that takes directly qx1, qy1, qz1, qw1 and qx2, qy2, qz2 and qw2 so we dont have to create a Quaternion each time just to perform the interpolations every frame.
I take a paypal folder and modified the files for PagSeguro Config
Shouldn't you use tgkill, if only for sanity's sake?
The crasses can be caused by the buffer that allocated by fast slob is not well aligned. I implementing your fast slob in the old binder and get BUS_ADRALN, which mean Invalid address alignment.
Fix it with this:
#define MAX_ALLOC_SIZE		98304
#define ALLOC_SIZE_SHIFT	3
#define NUM_BUCKETS		4

The NUM_BUCKETS must not be odd number. Hope it helps.
Like Jacob said, I think libs from different adreno versions are compatible, so the adreno 205 ics libs that have been released should work on the qsd8k with adreno 200, but they will not work on blade because it is armv6. I don't think we can do much until an msm7x27 rom is leaked/released, which may never happen (msm7x27 is the only qcom armv6 soc with an adreno2xx).
Pull request will not me merged until I checked the licenses.
Shouldn't think be `process.env.HOST` so that you can specify a specific port to bind to?
fwiw i don't think the A versions of the functions are needed either (i just suggested the Win64 change as a less controversial start).
So, while using straight objc_msgsend is technically legal, and does remove compiler warnings, it eventually becomes a headache. You're mentally converting from the ObjC message sending model to the procedural C model of function calling. It's a subtle difference, but I truly do not like mixing 2 programming paradigms in the same method. Hiding them behind other methods let's the code read easier. It may seem like a minor difference, but it's one of those things that I've just come prefer...

BTW, thanks for your pull request. I have't had time to review it all yet, but most of it looks good. The only thing I'm unable to pull completely just yet is converting to ARC. Don't get me wrong, I love ARC, and use it a lot. And, actually, switching to only ARC and the newest version of Core Data makes the MagicalRecord codebase easier to write. But I will keep some minimum level of support for the "old way" until I release 1.9, which will be ARC only.

Thanks again!
--
Saul Mora
Founding Panda
saul@magicalpanda.com



On Jan 3, 2012, at 12:56 PM, Oleksandr Dodatko wrote:

> Sorry for my poor English. But I haven't understood the idea of your post.
> 
> Here are my reasons for objc_msgSend usage :
> 1. I don't know your codebase good enough to re-implement this piece in block style or any other fashion.
> 2. Hovever,  "objc_msgSend" legally removes annoying warnings and does not significantly change your logic.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/EmbeddedSources/MagicalRecord/commit/49ea2ba1e963050e24ef431ff1bcd640e829ea10#commitcomment-834649
Looks good. Two improvements.
I see. If you have a basic testing setup, I'm happy to contribute tests as well. Cheers!
OH omg, I was reading the diff incorrectly. I'm sorry, you're right, there is definitely no problem with this!

And you are definitely not being a pain! This is all fantastic feedback that's only making the theme even better. I somehow wasn't even aware of Customizr until very recently. Thanks for all your help!
this was a correction; if you read the license notice on GnomeKeyring.cpp (which is the standard tri-license header) it states MPL-1.1 only. most mozilla tri-licenses are like this, MPL-1.1 or GPL 2+ or LGPL 2.1+.
checked in editor backup file again
eek. severely broken. i'm thinking we might want to completely rebuild this one from scratch.
tu je prilis vela volnych riadkov, potom ten return nevyzera, ze patri k tomu
Nice :)
Thank you!

În data de Tue, 24 Jan 2012 02:20:39 +0200, aveangelus  
<reply@reply.github.com>  
a scris:

> OK i will do!
>
> I want say that im translating to Portuguese (Brazil).
>
> This is a really good plugin, simply wonderfull!!
>
> Congratulations!!!
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/scholarpress/buddypress-courseware/commit/c4fe685633ccc565f10bc2eac8efd6c35293abbb#commitcomment-894393
Для использования в качестве модуля через API
I guess I'm kind of confused about this being in bin/fog.  If you are writing other stuff I'd think you would be using fog code directly instead of delegating to bin/fog, am I missing something?
could we shorten 'non-significantly differentially expressed' to 'non-differentially expressed' ?
OK, added as git+file , and tested installation. Test file added to packages.
I left the `Y.UA.ie` check in here to minimize the amount of refactoring I had to do to IO. IE can use a proprietary `XDomainRequest` object, and when IO is setup to use the `xdr` transport, it will create one of these objects.

Since `XDomainRequest` is only in IE, I needed to make sure the `XDomainRequest` transport is only used when there's native support + IE + an IE without CORS in XHR.
Yes, it's a good idea : "management" may be confusing.
I still don't like that this context and commandqueue are created on module import, rather than at op2.init time.  Can this be fixed somehow?
It's possible we lose some early validation here.  Ideally we wouldn't need this.  If you feel comfortable removing it, we should remove the skip_env_dependent kwarg from the function, since this is the only place it's used.
If our update is a named config, this won't properly validate it.  We could have nodes, etc in the config.
Ah, ok, I see: the default netty pool-size-max is 8.
Yes, very true.
May i ask why this is not an ordinary actor?

25 sep 2012 kl. 16:28 skrev Roland Kuhn <notifications@github.com>:

> In akka-remote/src/main/scala/akka/remote/RemoteDaemon.scala:
> 
> >  
> >      case t: Terminated ⇒
> >  
> > -    case unknown       ⇒ log.warning("Unknown message {} received by {}", unknown, this)
> > +    case TerminationHook ⇒
> > +      terminating = true
> this is racy: child creation could check flag before this and create child after line 90 is finished; I think this is one of the few places where I’d use a conventional Lock
> 
> —
> Reply to this email directly or view it on GitHub.
>
we conventionally call those “…Settings”
use a ..warning:: block
what purpose does this UUID serve nowadays? I hope lazy vals are not secretly `@transient` …
I would think preferred API would be Card.new :typecode=>:invitation_request, no?
this should be done in a rule set, right?
Looks like the $target_area should also have a default of `null`.
Both get_dip() and get_strike() will be covered by tests in fault source branch.
what do you mean in the `kw` ? 
should i specify the `background` as a property in the Popup class ?
I wonder if we should just have dashboard_show() and dashboard_update(), keep it to just two logic functions
This should probably be a dict. The idea was that in the future we would add an extension point where plugins could register their own functions as renderers for activities of a given type (which might include new types of activity that don't exist in CKAN core). That's why there was a dict mapping activity types to renderer functions, although the extension point itself was not implemented yet
Will do. As a strong believer in the power of sudo, I am morally opposed to using #. ;)
Nice. I love that you updated the docs too
I think i'd rather see this in the DllAvFilter.h file directly.
more descriptive name?
No need to store shell in an attribute. You can use getShell() directly in your tests
This localized string comment is not descriptive. It should describe exactly what the string represents and how it's used; for example, "Google Search contextual menu item for TwUI text renderers."
The github coding conventions are the law of the land here! :D
You are right. I was focused on print having become a functionin 3.x and did not think of meaningless parenthesis.
Well, this looks really weird. `null` is not `Error` instance, you should change this strange *exception*.
On Fri, Nov 9, 2012 at 9:56 AM, Ralf Gommers <notifications@github.com>wrote:

> In setup.py:
>
> >  LICENSE             = 'BSD'
> >  CLASSIFIERS         = filter(None, CLASSIFIERS.split('\n'))
> >  AUTHOR              = "Travis E. Oliphant, et.al."
> >  AUTHOR_EMAIL        = "oliphant@enthought.com"
> >  PLATFORMS           = ["Windows", "Linux", "Solaris", "Mac OS-X", "Unix"]
> > -MAJOR               = 1
> > -MINOR               = 8
> > +MAJOR               = 1
> > +MINOR               = 8
>
> Eh, sorry, replied too fast. Your question doesn't parse. PyPi doesn't
> figure out versions. Do you mean pip?
>

Actually, I don't know what I'm talking about ;) I just used your PR
comment.
This is a TypeError
Perhaps the correct way to do this is to subclass SearchResponse into a SolrSearchResponse and add the above classmethod? I'm just cautious about having what's essentially a constructor/initialiser in a function floating in the ether.
Declarations have to go first in the block to be compliant with ANSI C. Either move the declarations up or put this in a block.
This function should not `print` unless it is called by the argument parser. See https://github.com/prody/ProDy/issues/151 for how to get around it.
Why is the length 4 and not 5?
Not sure there's much point in passing `ENV['CONTROLLER']` here - it's used in the rake task to focus on a particular controller, e.g: `rake routes CONTROLLER=products`. Perhaps we could pass a url parameter instead, e.g:

``` ruby
# can't  use :controller here obviously
get '/rails/info/routes(/:filter)' => 'rails/info#routes'

class Rails::InfoController < ActionController::Base
  def routes
    @inspector = Rails::Application::RouteInspector.new
    @info = @inspector.format(_routes.routes, params[:filter]).join("\n")
  end
end
```

That way you don't need the `RoutePresenter` class.

A couple more points:

1. Do you need the explicit `render` calls - does the default render not select the right templates?
2. Do we need the explicit `layout 'application'` - does the layout not get selected correctly?

Not really bothered whether the explicit calls are there or not - I'm just wondering why you put them there.
@rafaelfranca `input[type="time"]` doesn't have `size` attribute.
The test description doesn't match with the content.
What about testing that this should return `1`, meaning it's the number of records?
I believe that if you're touching a file and some whitespace is cleaned up (mostly because your editor is configured to remove extra spaces on save), it should be fine, I'd not bother.
These previous methods are protected already, so the `private` needs to be un-indented?
Please change to

```ruby
{ :env => Rails.env }.merge! options
```
fix capitalization and translation "Fechas legibles"
This would seem to merit an explanatory warning right here, rather than waiting for less specific errors to trickle up.
Btw, there seems to be a typo in the file name ("Intrumentation.scala").
I'm afraid you should call them "value members".
So these methods are completely compatible with the IDE? https://github.com/scala/scala/blob/0acb8a30c379f268e8a3e1340504530493a1a1dc/src/compiler/scala/reflect/macros/runtime/FrontEnds.scala#L1
It's the only text shown in the page there, if we are consistent and start every page with a heading, we should have a heading here.
Has it now bro.
Yes sorry I spoke too soon on fixing the spec..  I fixed the initial error I was receiving, and pushed up my initial change.
I think it would be better if you rephrased this as "The result appears in stderr.  The form of the result is similar to the output of test_xperm.  See for example...".  If you are not actually talking about the output of `test_xperm`, feel free to choose a different term.
(H-1/2)/(hbar*omega)
Make sure `**kwargs` is handled properly everywhere.
Yes, I meant "this PR", sorry
Well, there are two #instructor? methods: one on course and and one course_membership.

I'm fine moving these test to course_membership tests, but if we do then we aren't testing all the behavior. Specifically, the behavior around finding the right membership for the github_nickname would be untested.

What do you think is best?
is it `setted` or `set`?
Invoke `rmdir` **ONLY** in case directory is empty.
I really want to get rid of this :D
The fix is correct. I just wonder if we shouldn't define a macro for this kind of stuff, something like DIVISOR(value) or WRAP_ZERO(value), so that we use the same checking everywhere. what do you guys think?
This is rather restrictive. I like that the method is able to send any email (with more than one recipient, emails with attachements, ...).
no.. TestClass or FalseClass
Эта фигня будет нормально работать если я в urlmanager-е красивые ссылки про пишу?
This appears to be copy and pasted from the PairActorSupervisor - should this potentially get refactored?
Maybe just the conflict marker chunk needs to be removed?
You're welcome to make your own permissions here, but django automatically adds create, edit, and delete permissions for every model.
Мне кажется, это уже избыточно.
Кажется более-менее достаточно вот такого: `/&(?![A-Za-z#]\w+);/g`.
Да, там какие-то псевдо-энтити появятся типа `&#asd;` -- ну и фиг с ними.
Please do make sure it is possible to update from 3.0 to 3.1 via database updater, as QI cannot install 3.1.
No need to call it $phpbb_notifications if it's a local variable, just go with $notifications?
For this to run on Windows, the paths would need to be `'nul'`.
Please don't refer to the table directly, use the `TOPICS_TABLE` constant.
Well I hope that someone will create a "calender extension" which overwrites the template file and will be even more user friendly ;)
I don't really want to spam the poll area with more explanations and having it as a hidden feature is kind of bad aswell
Please also prepend "Search failed:" text here. For someone not expecting failure it may be unclear what the error is related to.
I'd suggest something more descriptive, like 'User cannot delete own account. If you want it to be deleted, please contact board administrator.'.
Actually,  internally, for (for each one php does:):
==: Check types, convert types (if not the same type), compare value.
===: Compare types, compare values.

Don't forget that: 123 == "123fs JUST SOME TRASH"  is true. Why? Well... That is equivalent to: 123 === (int) "123fs JUST SOME TRASH"

I'll change to == anyway.
And if you move this under `defined('PHPBB_ADMIN_PATH')` conditional you would avoid creating this unnamespaced variable in global scope.
select lang_id from lang_table limit 1;

then check if any rows were found/retrieved.
Will unlink spam if it fails?
fixed in 9fd37fb
it's a double print
I had started using haml, but I was getting frustrated with it, so I switched to ERB and forgot to remove this dependency. I'll probably be asking for some help at some point to help clean up my gemspec :-/
Since the homepage loads the stylesheet and it's 'permacached' on first load, there's no reason not to put all styles in the css file (even styles that are for a single page).
Any reason you're not using ArrayAssert here?
Do you think it would make sense to move the newline into uzbl_control ?
we seem to always append it
place in controller?
I agree inline formatting damages overall uniformity. But, I had kept these borders and padding attributes in the BMICalc to keep it in the same style format as the rest of the registrationextjs4 pages.
Removing this would make it inconsistent with the previous 3 pages.

Either we rid the styling of those pages as well, or we undo it together later when we add the main CSS and styling.
this name (```diagnosisFilterByOnSearchClearIconTap```) is pretty convoluted :) possibly to simplify?

Comment could explain specifically which searchfield, too
Be more specific -- what's the problem?
Also --> file a bug to track this todo, and link to the bug in the cod.e
I don't like this. It'll blow up if the points are incompatible with the bounds of the source coord. I know you could add a further bounds arg and implement the same logic of wiping bounds if only points are provided, but I'm not keen on adding arguments (or this logic) as it'll encourage use of this somewhat questionable method (I know I created it the first place!). If you just want the coord's metadata (which is the case if you are providing alternative points and bounds) then I'd prefer something like:
```python
new_coord = AuxCoord(new_points)
new_coord.metadata = old_coord.metadata
```
Added in my PR.
remove those 2 lines
As discussed, I think that the temporarily allocated was a problem that we fixed. So we should test it. The choise is this brittle test that cover more case or test less case. I prefer a brittle test if it don't break too often. We could see how often it break.

Also, what about conting the number of contant on the gpu in the compiled function and computing the extra_alloc from that? I can try it this week.
Also, you put in a lot of error checking code, including allowing CudNdarray as pass-through, and ndarray only if dtype was int32. It would be good to test those checks.
вообще-то здесь никаких исключений не возникнет.  И зачем Вы ловите исключение и добавляете к нему слово, написанное как малолетний хакер? )
Use dictionary.iteritems() rather than [ ] lookup to iterate over key/value pairs:

    for (e, path)  in testSuiteList.iteritems():
        os.chdir(path)

Actually, "e" is not a very descriptive variable name.
More of a future thought than something to act on. These regexes could be built up from building blocks, which would also reduce the need for elaborate comments. E.g.

String reStart = "(?i)\\A";
String reWhitespace = "\\s+";
String reNameGroup = "([\\w$]+)";

static final Pattern partitionProcedurePattern = Pattern.compile(
        reStart + "PARTITION" + reWhitespace + "PROCEDURE" + reWhitespace + reNameGroup + ...

To me that's fairly self-documenting and I find it much easier to read then the detailed comments. I don't think the slight inefficiency of using string concatenation would do any harm. The pattern only needs to be compiled once.
Two lines are identical.
spelling: clm_varbinary as clm_varinary could confuse.
It was automatically generated by South.
Good use of specific exceptions.
Ok, so, if the current code fits you, I can make a new pull request to clean up the commits.

If I do it. Do I have to erase this fork and make a new one?
I think this class may be redundant since it's already defined above
We follow the PSR-2 standard: https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md
wrong phpdoc. This is not a resource
Turn this method into a ternary return.

```php
return ($len === null)
    ? sprintf('SUBSTRING(%s FROM %s)', $value, $from)
    : sprintf('SUBSTRING(%s FROM %s FOR %s)', $value, $from, $len);
```

Unfortunately, we cannot break BC and turn $len into $length variable.
@lest, right, the `redirect_to` will stop the destroy action from happening
Why is this not retained?
I guess I wasn't clear here:

> each time we create the package index

By "create" I meant "load", as in "create a value of type `PackageIndex`". So yes, `configure` will pick up your changes.
Almost fixed. Except the first one. 

How about "internal used transition state is not the format that we expect" ?
I'm not sure if this is for only internal (inside C/C++) invocation, but if it's for SQL invoked functions, too, 9 is too few.
Also, I think there are important changes that were done to in PowerContext.cs to support minions. Might want to look at pulling that from willy's branch as well, but don't copy PowerManager even though I know it got changed a bunch too.
`depends_on 'cmake' => :build`
Calling `ENV.O2` is the preferred way of doing this as it also clears any other optimization flags that have been set.
Use the full path to the executable: `system "#{bin}/xorriso", "--help"`
Hardware on which I tested:
* MBP 13" Mid-2009 (NVIDIA GeForce 9400M 256 MB graphics).
* iMac. I sadly don't currently have access to it, I cannot have more details. In particular I don't know if the graphic card is Radeon or NVIDIA.
This path to the python includes should not be added **if** Homebrew's Python is installed.
it's elegant and succinct ... but hell to read if you didn't write it (isn't that considered anti-pythonic)
We don't practice using module-level variables because they aren't testable. I think it would be better here to use a property on the ``Logger`` function object (a class static property as it would be called in OOP terminology). The name should begin would the underscore character to adhere to our coding guidelines. What do you think ?
> What timezone is getting subtracted here?

The same one as [here](https://github.com/DEADB33F/reddit/blob/7997035be34429e4f072dae4061c7570eb066448/r2/r2/lib/jsontemplates.py#L182).  
For consistency I just directly copied the line used to generate the created_utc timestamp.
Actually, having a class named `Error` in each module, which other exceptions in that module subclass, is a convention (see the [Google python style guide](http://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Exceptions), which is generally a good read) but I'm not actually sufficiently expert to defend it. I'm willing to just delete this class, especially since `LockError` is going to subclass `UserError` now.
I agree.

@addyosmani @paulirish I think we should bring in ShellJS as a dep. It let's us do this kind of stuff in a cross OS compatible way and in JS. ?
@dsaff pls see my latest update.
How we would proceed next?
We cannot use `fListeners` directly in the stack, because we need to have two constructors because of `fireTestFailures()`.
In previous code it was worth to use final because of `synchronized (fListeners)` likes constants.

I use to have final in this case, not because of concurrency, but because I want other developers remind if they really want to rewrite the reference maybe by mistake.

Or you mean something else?
Can we `forin` this bad boy? Also we totally don't need to `slice` since this is an internal array.
Don't commit your own credentials! Thought this was a placeholder but it worked when I tried.
The editor in MAP doesn't allow arbitrary classnames, so we'd have to add that. I think the original idea was to display links in a list like child nodes, and leave other links unchanged. That would mean the client would have to know to put their links in a list, so maybe it's best to check with PM whether they think that'll work with the client.
`tmplist` -> `tmpList`
There isn't a lot of power to move the banner in Android out of the box. We can change it's "gravity" which controls like top, bottom, center, left, right but we can't actually put in pixel values like in IOS.   I can fix the parameter list to match the ios version.
fixed. re-formatted that block as well.
Thanks for moving this function here!
Is there a reason why you are doing this in JS instead of in CSS?
Brackets currently doesn't support Firefox, so is this necessary? Maybe the comment is incorrect.
I disagree with this suggestion. We are supposed to use Array.foreach instead of $.each for better performance, so I suspect the same problem with $.map, which seems to be supported by the data here: http://jsperf.com/javascript-map-vs-jquery-map-vs-jquery-each

I think we may want to convert calls from $.map to Array.map in the places where the operation is on an Array (not a jQuery result set). If so, then it might make sense to convert my code to Array.map.
After discussing this with you offline, I understand better how the code works. I think the comments need to be improved so anyone looking at the code can understand this better.
Ack, good idea, haven't though about this. Easly done though. Will convert.
My bad, my laptop's hard disk died a couple of days ago - I didn't lose anything important but it will be a week before I can code again. I should have just waited and done tests myself before merging.
I would appreciate if someone could make a pull request to fix this (@Nami-Doc) as I can't really do anything atm (my friend's netbook I'm borrowing is basically only for internet surfing).
I've generally tried to avoid collapsing all the data into a single data frame because it's rather an expensive operation.  One way to make it a little more efficient here would be to do `data[c(x_vars, y_vars)]`.
It may be nicer to have an actual sentence here.
These changes adds support for binding to the root element, before it was only children or the root.
I would name this file *account*, because *user* is already in the template often user object. So you have some naming confusion.
Probably should use the domready test from the mootools-core tests (and use node.js or something instead of php): https://github.com/mootools/mootools-core/blob/master/Specs/1.3client/Utilities/DOMReady.php
Remove the commented code if it's not needed.
Suggestion: just hash date+report? Too much processing power?
`path` was not `require()`d above and hence does not exist here. you can avoid requiring it by simply doing instead:

```javascript
  executable = executable + '/Contents/MacOS/Google Chrome';
```

this worked on my Mac.
If there is not any 'if' directive ?
最新版的Nginx把这行移到tag的判断下面去了，以便可以更准确的打印错误。
That's a good thing to look at. That's why I'm using the more descriptive urls (i.e. the ones with slugs) across the site.

There are two use cases here I was thinking about:

1. I want the ability to do short urls. The long urls with the slugs are descriptive and therefore better, but sometimes you really want a short url. Sure, people can use url-shorteners, but that brings me to my second use case....

2. I want things to keep working even if the title/slug for a video/speaker/tag get changed. I think changing titles/slugs happens often enough I don't want to deal with site redirects.

I figured it's easiest to meet both of these needs if the url included the pk and a slug, but essentially ignored the slug. Given that, might as well make the slug optional, but use the slug one across the site.

I'm not hung up on this, though. I'm game for other options, but really want to meet these two needs somehow.
As a side effect, this ManifestReader class is able to parse manifest contents, so we can leverage this in the Katello codebase. Maybe previewing manifests before import or something like that.
Need to remove the debugger.  Also, should 'add_pulp_consumer_group' remain in system_group.rb?
[i for i in custom_info[k]]
this is just obfuscate version of
custom_info[k]

I would simplify 
  "[ " + ", ".join(["%s: %s" % (k, "[ " + ", ".join([i for i in custom_info[k]]) + " ]")
to:
  "[ %s ]"  % ", ".join(["%s: [%s]" % (k, ", ".join(custom_info[k])))
from python documentation - http://docs.python.org/2/library/os.html#os.popen
```
Deprecated since version 2.6:
This function is obsolete. Use the subprocess module.
Check especially the Replacing Older Functions with the subprocess Module section.
```
Should it be "file:///locahost" ? (three slashes)
Could we have a function which wraps the callback and checks for uncaught exceptions, and logs them appropriately.  Given that all expected exceptions should be passed to the callback.

This can be a future change though.
Orchard is FAR from a common scenario. Why not have an orchard specific assembly resolver. App_Data/Dependencies is an orchard specific convention.
Tim has added a |locked| property on the LockScreen object. Sounds safer to use.
It's a pain to tap these, I think we would benefit from a touch of css :)
Ok, I'll clarify this. I think that functions/methods explicitly for printing information can also use ``print()``.
To ensure we use the first available Icon from the executable you could use ``$INSTDIR\bitcoin-qt.exe,0``.
AFAICS that way it would affect the following "else" branches.
This is problem that i described. Should we overwrite or just add in such "mergings". For now orderins and where expression are added and limits are overwritten.
could you use ``assertCount`` here ?
and a space is missing after the comma
Please provide a clear and concise description in prose explaining this line.
Let's get rid of the Plugin usage in this module.
If you've re-forked the IPython repository, you can do

```
git remote add takluyver https://takluyver@github.com/takluyver/ipython.git
git fetch takluyver
git checkout drtimcouper_all_
```

Then either make a PR against my copy, or make a new PR against master (in which case I'll close this one).
So would `'/'.join([self._directory_prefix,self.path])` be better here?
Why not use here `setattr(self.config, lhs, value)`?
note that ${user.name} should work here due to rocoto
rename to findOrCreateKeyPairContainerInVDCNamed
Ooooh shinneh. I forgot we wrote that API for the repository helpers.
if we are just resetting these. 
```
context.stack.head['$idx']  = undefined;
context.stack.head['$len'] = undefined;
```
should be good enough and a little more performant.
I'm thinking the correct route is to go back and get a proper ORM in the system before moving further in this branch.
I used them as much as I could find pages in the bedrock code base like for example {{ url('firefox.geolocation') }}. I do not think all of these have been moved to bedrock yet.
I'm not sure where that is executed, but I do know that this needs to be in the &lt;head&gt; or else there will be flickering on pageload.
This is something that was added for backward compatibility and that ought to be removed. The ``search`` service accepts ``from`` and ``to`` as parameters where others services use ``from_date`` and ``to_date``. There should be no fatal error if a parameter is missing here as first those are not mandatory parameters and second if it were it would be handled somewhere else (after parameters are filtered).
everything is commented out so that the hardcoded defaults are taken.  If a default should be overridden, just  uncomment and change the value
I'd prefer to see this as `class.tabs` in case `Sidekiq::Web` ever changes names. Otherwise this is a bitchin' commit :wink:
not sure if this is right, imo powinno byc:

`initializer "netguru.bullet" do |app|
  app.config.after_initialize do
    (...)
  end
end`

ale moge sie mylic - sprawdzales, czy tak jak napisales dziala?
reference to logic missing
I'll give this factory a much more meaningful name, don't worry about it. Note to self.
True. In that case I would make it a proper message though. "DNS query for igor.io timed out" would be more useful.
Document where this class came from so we can keep it up-to-date if ever necessary?
why should we also count internal interfaces?
After session_start you can change session id. PHP allows for this type of behaviour and not throwing any error. I think the better solution will be inform user that he do something wrong trying to change session id.
Shouldn't it be ` $ex->setPath($this->getPath());` only ?
I think this should be
```php
if (null === $this->translator) {
```
typo: `testDontPass` I guess
btw, why not using the core ``iterable`` test available as of Twig 1.7 ? http://twig.sensiolabs.org/doc/tests/iterable.html
I don't think a choice can be iterable without being a choice group. Am I right ?
In this case it's true. But I do not see anything wrong with that.
Also not sure you should add `@api` here as this is quite new...
I would just remove the constant altogether.
missing phpdoc for it
Fixed thanks, I was not sure about int vs integer.
missing empty line above return (same in line 57)
I wanted to know what I'll need in profiler before making it. If my time will allow it, I'll do it tomorrow or during the next weekend.
I had to go lookup NSOrderedAscending to verify.  I see others have done this way so no error.  But, there is an earlierDate and laterData method in NSDate.  I leave it up to you to decide.

see http://stackoverflow.com/questions/5429280/how-to-compare-two-dates-in-iphone
I saw this also. Seems like a ton of overhead to do essentially the same thing.

What's the specific objection to randomizing when GC runs?
It's not only legal, but the original is actually *illegal*.
We don't have access to the old envlatlmode global here, and I don't really understand this ASSERT, so I removed it.
That was my lack of concentration. The autopep8 tool does this... I will fix.
As I see it `$res` should either be `FALSE` or `NULL` here which makes it irrelevant in the log message.

Also there is a spelling error :).
This validation and cleaning code for public and private stuff looks the same except for the names of some of the variables or keys. We should be able to turn it into a function.
Why does this link to mustache? :wink:
Looks like this functions is not used. Is this correct?
there is typo here
This handler is not needed as it's not something a user would ever do.
This is *completely* unreliable with a dependency. You can't depend on a service being in the installed state.
Completely removing this will break the management API with no prior deprecation. I'll push up a commit in a bit showing how I'd prefer this be done.
Hmm, got a JPA test failure:
Tests in error: 
  testSubsystem(org.jboss.as.jpa.subsystem.JPASubsystemTestCase): Can't find resource for bundle java.util.PropertyResourceBundle, key default.datasource
or Namespace.WEB_1_0
why did this get moved up to before the internal propagate? I'm just trying to understand how that effects the internal state...
wouldn't `if (/^[\s\t\r\n]+$/.test(line))` be more accurate as to catching all types of empty lines?
I think you can call back() directly. There is no need to wait ThreadListUI rendering complete.
nit: the indentation was “better” before (= it passed gjslint in 'strict' mode)
I’m soooooo glad this rule went away with the flush. ;-)
I think that we don't need this method anymore.
nit:
```
  if (evt.type === 'mozbrowsererror' &&
      (evt.detail.type === 'fatal' || 'wrapper' in evt.target.dataset))
```
Does this seem more clear?
why not initialized it to `null`
I don't think you need to re-slice it here.  Can't you just use imageblob from above?
That's legacy code to clean the mark from selected element in the list of tags.
You don't need `function() { }` as third parameter.
yeah we did the same in flicks. i think rtl just reverses it?
This may be a non-issue depending on the eventual platform support intended, but on Solaris this will set the client hostname to "-f" and leave the answer blank.
Fixed in 21df078c.
Did you simulate it? :snowman:
Yeah, I opened a [bug](https://github.com/redu/help-center/issues/14) related with it
...Maybe
A lot of scanners don't keep their state around yet. Most don't even use the state protocol. It's a TODO, related but not essential for this feature.
i like the check scanCount > 0 better.  But the check above also work.
Why would they be in the ClockView. Those images are are the little streets from the home screen. the only reasone why they are in this commit, is because the folder structure was renames and therefore I had to rename it. I believe they are where they should be.
Never, EVER, do this. The $LOAD_PATH should not be altered by libraries, only by library managers (like RubyGems). If you want to locally have `./lib` in your load path, run ruby like this:

    $ ruby -Ilib …

or

    $ RUBYLIB=lib ruby …

If you don't want to type that every time, just `export RUBYLIB=lib` in your .bashrc or similar, and then ./lib will always be in your $LOAD_PATH.
Add your email here :)
already done - in constants.py
Why not use regex for methods as well? This way you could use things like ``(POST|PUT)``
we could just match on `\w+` instead
¿Provocará un conflicto con alguna otra rama?
I'm pretty sure you have to append the password to the form, not the XMLHttpRequest object.
это обчно делают скоупом, вот так

модель Attachment

    scope :public, where(public: true)

и потом 
  
    event.attachments.public
I had @Raphfrk push a fix for this a few days ago.
Actually, ChatChannels don't even really need a format, I would do them all in events. Like ChannelBroadcastEvent
* On 2012-08-08 19:39:12 -0700, Yiqiao Pu (notifications@github.com) wrote:
> 
> Well it is depends on the hardware designs and you never know there are some architecture will shows up. 
We could know, from the kernel code.

> Now we already see some numanode assign cpu like node 1 has 1, 3, ... and node 0 has 0, 2, ... in the desktop.
Well, so I finally know why you call a 're.sub' func in the for-loop.
Could you add some comments here to mark which kinds of node info we
would get from the `/sys` filesystem?

> And we don't test in something like server or blade which may include tens and hundreds of cpus.
> So it is probably one day the autotest is running in a system with more than one \d+-\d+. 
> So I'd like to cover more possibles. 
Agree.

>
I would prefer:

name -> description (long description, displayed in UI)

name_hash -> nameid, enforced by config system to be unique and lowercase, used for scripting, and json API
AFAIR you are right, but not sure about classes bundled with PHP (i.e. exceptions).
Please revert this change. You should not add trailing whitespaces in empty lines
you should clean it after use when copying it to the temp folder IMO
don't define the version, it's already inherited from droolsjbpm-parent pom
Opps, yes. fixed.
Have now fixed this with https://github.com/guardian/frontend/commit/8b80d67828f7602cba7f6435e5f6b074c650b293
Unfortunatley there isn't much other than this line: 

> If you're building a Webkit (iPhone / Android / Chrome OS) application, you may be interested in qwery-mobile! Include this > > (instead of qwery) in your Ender build and get a full qwery interface for just 600 bytes :)

But @commuterjoy and I read through the source code, and from what we can see it just assumes that the user agent supports getElementsByClassName or querySelectorAll and defaults all looks to them. I.e. it doesn't actually do any UA string detection which is a *good* thing. 

https://github.com/ded/qwery/blob/master/mobile/qwery-mobile.js

We made the decision that as we are only serving our JS to devices that support those native methods anyway this should be ok?
zone is "uk" or "news"?
exceeds 80 characters