[FEATURE] Make UTF-8-Sniff-Error-Message configurable

The message from the UTF8-File-Sniff is not configurable.
Further more there is one obsolete variable.

Change-Id: Ibd465573fe77f32648fdee3a3ded4101f27995fa
Fixes: #9544
Release: 0.0.4
[FEATURE] Allow more than one whitespace in Assignment...SpaceSniff

We have to allow more then one whitepspace on both sides of string,
arithmetic, assignment and other similar operators
(for example, ., =, +, -, ?, :, *, etc)

The sniff support this already, but this functionality has been
covered by an unit test.

Change-Id: I3d29b499f14412f4a80cc202620f8b84e94c57aa
Fixes: #12240
Reases: 0.0.4
[FEATURE] Improve error messages of ValidVariableName-Sniff

The error messages from
TYPO3.NamingConventions.ValidVariableName are not configurable.
Further more this patch adds an suggestion to a variable
name with underscore.

Change-Id: Ifd2e70dfb7a15cf82ed7a0d9078710ded455f7f5
Fixes: #37452
Releases: 0.0.4
[FEATURE] Support relative sniff inclusion for standards

Since the newest PHP_CodeSniffer-Version (v.1.3.4), sniff inclusion
via relative path usage is supported.
With this, it is possible to use our sniffs / standards with and without
symlinking into the PHP_CodeSniffer installation.

Change-Id: Ib0452458956e4f6d08e96179d629b5e98f794360
Fixes: #38297
Releases: 0.0.4
[BUGFIX] AlwaysReturnSniff complains about empty return for @return void

If a function/method got a @return void in doc block comment
and the function/method contains a "return;" statement,
the mentioned sniff will raise an error.

The expected behaviour should be, that no error will be raised,
because a "return;" is equal "void". Now, the sniff will
raise an error if there is something like "return null;",
"return $foo;", "return true;", and so on.

Change-Id: Iac4a55564e1eac4180c36b3af69e089984fc4d03
Fixes: #37336
Releases: 0.0.4
[BUGFIX] Extend TYPO3.Debug.DebugCode-Sniff for more cases

In current TYPO3v4 master branch, the debug-method was
moved from t3lib_div::debug to t3lib_utility_Debug::debug.
The current implementation of this sniff does not cover
this method call.

Further more, the error message was improved to be
more flexible.

Change-Id: I8017b32d73ec0d4bdb6c1ccc73d61890e9ce586f
Fixes: #12203
Releases: 0.0.4
[FEATURE] Exclude class.doublemetaphone.php from checking

The file /typo3/sysext/indexed_search/class.doublemetaphone.php
contains third-party code. This code do not fit to the TYPO3
Coding Guidelines.

So lets exclude this third party stuff.

Change-Id: Ia9e18110e782655b4b8ed65831fadf9ae23b42ca
Fixes: #36870
Releases: 0.0.4
[TASK] Exclude third party code from checking

TYPO3 ships 3rd party code with it.
This code does not formatted with the TYPO3 CGL.

Change-Id: I3c8fdc7bfa55dfbc83bbf8dfa645f8d4ad67c733
Resolves: #37505, #38360
Releases: 0.0.4
[TASK] Add exclude pattern from ci.typo3.org to ruleset.xml

Our Jenkins Server at ci.typo3.org excludes the
following folder / files:

* .git
* typo3/sysext/dbal
* typo3/sysext/openid/lib
* typo3/contrib
* typo3/sysext/adodb
* typo3/sysext/em/mod1/class.nusoap.php
* typo3/sysext/fluid
* typo3/sysext/extbase
* typo3/sysext/indexed_search/class.doublemetaphone.php

With this exclude stuff in the ruleset, it is much easier
to check the core against violations for other users,
because you don`t have to point this
files / folders via exclude argument.

Change-Id: Id81eac8cd3ecf0a863a55e042c43a35573824500
Fixes: #38529
Releases: 0.0.4
[TASK] Exclude files for system extension "em"

TYPO3 system extension "em" constains some files which
does not been checked, because this are 3rd party software.
This files are mixed up in one folder with self written
files for the TYPO3 project.

Change-Id: I04ea214b47922f6e9b754190f22c1897e9e356f1
Fixes: #38751
Releases: 0.0.4
[TASK] Activate Generic.CodeAnalysis.UnnecessaryFinalModifier for FLOW3 / TYPO3v4

The sniff Generic.CodeAnalysis.UnnecessaryFinalModifier
could be useful for both standards (TYPO3v4 / FLOW3).
This sniff detects final modifier which are not needed.

Change-Id: Ibd66e566b5d9f8fbab59dcf8f8622eb31d074aff
Fixes: #38337
Releases: 0.0.4
[TASK] Update package files

Update the package files and and one to new FLOW3 standard.

Change-Id: Ia98d0cb0a7e4adc98fbd4ea9be7ee0b80d42418e
Fixes: #37300
Releases: 0.0.4
[FEATURE] Activate Generic.CodeAnalysis.ForLoopWithTestFunctionCall for FLOW3 / TYPO3v4

The sniff Generic.CodeAnalysis.ForLoopWithTestFunctionCallcould
be useful for both standards (TYPO3v4 / FLOW3).

This sniff detects function calls in loops.
This kind of coding could be decrease the performance,
because the function is called every duration of the loop.

Change-Id: Iac6c7ae52069c9b163ebd120885841115073d3e9
Fixes: #38339
Releases: 0.0.4
[BUGFIX] Break statement in else construct is not checked correctly

If there is a while loop and in this loop an if / else construct
is used, the break statement in this if / else construct
won`t be checked correctly.

Change-Id: I5c784d3cdadb4127a61c713a1635d115331afdb7
Fixes: #38822
Releases: 0.0.4
[BUGFIX] Remove non valid code from test case

Remove the non valid test case code snippet, which include an break statement in an if structure.

Change-Id: Ia5e78eeced5e9eeefa8d39d1019fbda84e4b7394
Resolves: #38945
[FEATURE] Activate Generic.CodeAnalysis.EmptyStatement for FLOW3/TYPO3v4

The sniff Generic.CodeAnalysis.EmptyStatement could be useful for
both standards (TYPO3v4 / FLOW3).
This sniff detects empty statements like empty try / catch blocks.

Change-Id: I03bfc9f98dbbdf4a6215cefb703cde4f5ee11bf7
Fixes: #38310
Releases: 0.0.4
[BUGFIX] Wrong message in TYPO3.NamingConventions.ValidVariableName

This sniff returns a wrong expected variable name.
This patch will return the correct expected name.

Change-Id: I9fcd3111bc06ee67e0475b3739229c07e18ba4f9
Fixes: #37454
Releases: 0.0.4
[FEATURE] Activate Generic.Classes.DuplicateClassName for FLOW3 / TYPO3

The Sniff Generic.Classes.DuplicateClassName could be useful
for both standards (TYPO3v4 / FLOW3).
It detects multiple occurrence of the same class / interface
name in different files of the same namespace.

Change-Id: Ia57103951b15b8055352fcbd28982348b8b12059
Fixes: #38308
Releases: 0.0.4
[Feature] New sniff to check spaces around concat op

The new sniff checks if the concat operator is surrounded by spaces.

The sniff is taken from CodeSniffer project and modified a little bit to fit our needs.

Change-Id: I50a36e980b58b8fa0393fd7cfab122428ba89440
Fixes: 37940
Release: 0.0.4
[Feature] Add ConcatenationSpacingSniff to both standards

In TYPO3v4 and FLOW3 coding guidelines the concat must surrounded by spaces. Add the sniff to the standards.

Fixes: #39017
Release: 0.0.4

Change-Id: I02792599d3d97f69e1107738c8e078b8216cf47d