labofsahil/github-event-dataset-2012 huggingface dataset:
Both of this and line 73 in the other middleware object should be behind `if not 'x-xss-protection' in response:`. That way the middleware can be overridden with different values (either set in the view or with decorators).
You might consider just using '-' to represent separator. OS X does this. Not sure about Windows.
I personally don't see much value in building such class like a construct and would prefer more node fs-ish API:

```js
exports.open = function(path, mode) {}
exports.mkdir = function(zd, path) {}
exports.addFile = function(zd, to, from) {}
exports.write = function(zd, path, content) {}
exports.close = function(zd) {}
```

That being said if we do it, it definitely would make more sense as an incremental step after.
> Does that mean that relative path in another package than addon package would be broken?

This `paths` mapping is only used for URL resolution, which happens only post id resolution. In other words all relative requires from other packages are already normalized to `package/path/to/module` before URL resolution will happen using this map. I have replied to a related question you had in documentation https://github.com/mozilla/addon-sdk/pull/449#r874072

Short answer is not it won't be broken.

> BTW, are will still using this metadata object somewhere in code?

self module uses some fields from it.
That's a good point, the reverse is true right now. On the main site all of the dialog templates are included, which bloats the main site slightly. I opened a new issue (#2481) for this.

We should figure out a good strategy to only serve up the needed templates for the context.
Good cleanup. [primary_offline.js](https://github.com/mozilla/browserid/blob/primary-transition-ux/resources/static/dialog/js/modules/primary_offline.js#L23) could use that too.

No worries about adding that to this patch.
@seanmonstar - the rebase seems to have blown away our conversaion that was here.

General flow was:
* I asked if @ozten wanted to log the user out. 
* @ozten stated that a more desirable experience would be to re-provision the user.
* I suggested using 'self.close("primary_user")'
* @seanmonstar responded with - `@shane-tomlinson do you think this should be done? or is it something to look into in the future?`

self.close("primary_user", infoFromAddressInfo) *should* cause the address to be re-provisioned if needed. Since checkEmailUser will remove the address' cert, the address will need to be re-provisioned. After the re-provisioning happens, "email_chosen" will be called again.

The hardest part is going to be making sure cancelling auth from the IdP still works correctly.
Please get rid of the inner anonymous function. I don't see a reason why we would need it.
`recur` would be more robust here (for large `things` stack might overflow.)
I think the PR message covers this? I can gist up a sample module but I think it's in the main message
Yes, I think that would be an improvement.
Would be a little bit easier to read of you refactor this in functions
Yup, everything in `src/Knp` should be 5.3+. Everything in `src/App` could be 5.4+ (as it's just an example).
clean this up and use the "real" one if we're ready to only have one.
I always struggle when rebasing... You can't merge directly ?
I don't think it's a necessity. The developer will get back a type that conforms to the Dict protocol anyway. What if they pass a non-empty dict? Being able to do that feels strange.
Anything involving bitwise operators upcasts bytes to ints. Since bytes are signed, the sign bits get extended, and then then bleed into the next chunk of the hash.
shouldn't packed-groups be true in ictce?
we still want toString()
Makes sense, good idea.

Ok, I'll write a testcase for this. Please take a look at my commit later though to see how to write testcases in the future.
I've changed ngxDate.check argument order to year, month, day. Original order by PHP checkdate was weird :-) Please fix this.
wicked - nice
I totally get that but your comment doesnt say that :P
Interesting, we should probably just set the `ANON_ALWAYS` setting to `True`. Out of scope here. Filing.
I don't think this is a valid test; even if you don't have _update defined, this won't ever change anyways, right?
I'm not sure if this is the best item type to default to. We probably want the most permissive item type here as far as fields go, so that we can store as much information as possible. Which one is the best choice?
Nice touches here with the animation!
In PHP 5.5, The /e modifier is deprecated. Use preg_replace_callback() instead.
http://php.net/manual/en/function.preg-replace.php
`getStringPrefixFromLength` seems ok
Can you add a blank line before the case?
I dont think this accurate (from my experiences in the past)
а потом копируешь... std::move
we could, but it would be an nth-child locator, and no less flakey.
Seems like this will fail if the resource contains non-UTF-8 data in a field, which happens with, eg, content.  If you care; I assume you would have failed earlier anyway.
All, the curly braces. Sure thing.

There are some locations in unit tests for brevity where I do:

`if (err) throw err`

Should this be exploded as well?
I think the code that appends ${module_index}/${option_index}/${element_index} can probably be stored in a variable, which should save a lot of noise in this code.
We should really use setInterval instead of setTimeout. setTimeout is prone to memory leaks anyway.
Is this reference not needed anymore?
A comment here would be good.
Why are you removing the Makefile? How will this help the module build on platforms other than Windows?
Out of curiosity, why do you add `@throws` here?
Would something like this be better?

```ruby
def initialize(app, *taggers)
  @app = app
  @taggers = taggers
  opts = @taggers.extract_options!
  @silence = Array.wrap(opts[:silence])
end
```

That way it preserves backwards compatibility.
コメントしてみる
The entire action was copied from mi_attempts_controller - the flash notice probably won't be needed when the show form is in place (think it's down for the next sprint?)
Довольно замороченно!) Хоть коммень добавьте - что тут происходит ))
В x1 должно быть случайное число в диапазоне от 0 до 99, поэтому нужно брать остаток от деления на 100, а не на x. (Обнаружил, когда мутировал клетку: при мутации на 1% всегда меняется первый элемент.)
99 - та же беда
например так: 
NSString * arr[] = {@"A", @"T", @"G", @"C"};
int index = random() % 3;
index = [DNA objectAtIndex:index] == arr[index] ? (index+1) % 4 : index;
Можно реверснуть if
Тогда будет меньшая вложенность кода
"А когда в твоем коде может возникнуть ситуация, что ДНК будут иметь разную длинну" - такая ситуация не наступит, но жизненный опыт подсказывает что проверка здесь не помешает =)  А смысл переменной - наглядно показать "воображаемым" колегам необходимую длину масива, плюс в будущем если понадобиться поменять его длину, никому не прийдётся судорожно выискивать все цыферки по проекту и менять их на что то другое.
This change was needed when we upgraded `node-xmlhttprequest` to `1.5.0`
Maybe this whoel block would be nicer as a switch ? Or maybe a helper function outside of `.attach`? `.attach` is looking unwieldy
Feel free to refactor as long as you don't break the tests ;)
If the node doesn't actually exist in the graph (like "req" or "res"), in which case we hash the name instead.
Wouldn't this test for the correctness of eigenvalues *and* eigenvectors?
We probably shouldn't drop the option of using `th` here.
Hey Cindy,

Right here it is possible if the getLiferayRuntime() fails (sometimes if the user's project is not properly configured this will fail), then the initParameterName variable will be empty.  We need to revise this logic to use this logic:

by default use "template", then check if portal version is less than 6.1.0 (means its 6.0.x), then if so set the init parameter name to "jsp".
Any reason why `super.onSaveInstanceState()` isn't called?
why?! it's an rspec test. not a condition.
Please rename to `LowPriorityPrepend`.
we should have a "pca" mode to have a rank 1 approach. Also expose such a functionality as a method of SourceEstimates object
I think raw_in should be an instance of mne.fiff.Raw and the function should return a list of Projection

the save would be done here with mne.write_proj
I agree for a copy. But then we should not call it crop as Epochs.crop() works inplace... Or just a param to crop.

crop(self, tmin=0.0, tmax=None, copy=True)

and add the copy arg to Epochs.crop(copy=False) (False to avoid breaking the API)
Why is this needed? Site bar?
We also need the corresponding "maps" entry - in `cookbook/maps.rst.inc`
此版
此版本
What exactly is this useful for?
This is actually a constant `OPT` (which is not well-understandable)
I think you intended diff_size here
Sorry for the confusion and thanks for spotting. It does not work of course, its a left over from some testing.
If I change the paren to protected should I consider remove the _ from the name?
Buh, es cierto, voy a tener que iniciar un servicio de windows (o aplicación de consola), aunque por ahora yo programaría un request diario. Que opinás?
Good idea. Changed.
maybe ```if (cache.isOffline())``` instead?
OK, it's been converted in a previous commit.
I thought the InboundInvocationHandler is the 'standard' way of executing remote commands. Yes, I can short-circuit it to a simple initializeReplicableCommand + perform and avoid the InboundInvocationHandler if you say it's preferable.
This is already handled by the testing fwk in AbstractInfinispanTest.fork
We don't like Bela's code style here ;-)
How'd my name end up here?  ;)
that's what i get for not testing
Ah, OK, then this patch is fine for me.
So this is how you thank people working on your code? This is open source, we have the right to open meaningful discussions about any project. I can see that you are trying to create a culture of exclusion here. I do hope that you will properly apologize for this atrocious behavior.
Don't need to add strings.
This is not a PEP 8 question, but this line looks like a debugging statement that got left in by mistake.  I'm pretty sure it should be commented out.
Instead of the empty dictionary, shouldn't it return patch_cattr?
ProcessDefinition is its own first class resource, not a contained object. Use an association to it
Hi Glenn,

to be honest - I'm no Ruby developer either :-)
I spotted this fix in another cookbook related to handling Mixlib::ShellOut::ShellCommandFailed and copied it to fix the issue I was having: https://github.com/opscode-cookbooks/python/pull/9/files

Hope this helps!

Kind regards,
David
I agree - I plan on reworking UI a little down the road.... That said, I doubt anyone will have more than a dozen groups and in addition it's a page you deal with it only once.
This checkbox should visually remove or disable the group selection since it disables the feature. *Unless I just totally don't get it*
huh, is this really the most efficient way?
Do we not want `?prob-series` here? If not maybe delete the comment and bring up the trailing `]`.
They are from the disassembly of EMI. Would just adding a comment saying that suffice? The numbers seem to pretty much be magic to me.
@bp323 Can you remove all the `_bg.png` files in this CSS file and use CSS gradients instead?
Maybe they are already replaced in the current master branch but I'm not sure.
Nit: should be a space after `,`

```js
element.css("top",topval + "px");
```
Not even sure why you check the existance of the file? Just check the class.
Are you sure ``null`` has the correct type as ``null`` is not a sub-type of ``string``? Please also check line 35.
Please remove one tab from lines 32-33, 35-36, and 52
That would be pretty cool, but I don't think it's necessary.

I haven't added client/server specific plugins. I don't think we need to, either. Plugins can check to see whether the game is in hosting mode or not.

Perhaps the best way to deal with plugins is to define new objects for them, and put the script on the create event, then create that object.
what's up with this line?
Good call. Added commit to remove extra options check.
I think you mean an not and and also no period please
I don't know about this, we already have some code just like this
I'm going to use this on my geocities site.
Sorry, you mean that we don't need the last test, or both of them ?
The proc module is missing?
what if klist is not in path? I guess we need to do which(klist..).

also, if we move this code into its own line, we could parse it without reverting to grep :)
Don't concatenate strings, but use jQuery to build it (use `'`, not `"`):

```
var image = $('<img/>').attrs({'src': user.image_url, 'alt': _("User image")});
$('<li/>').append(image);
```

and so on ...
You could just do:

```
provider = providers.get_provider(translation.get_language())
```

and catch the exception. Or if found, use `provider` later on in context update. Instead of multiple calls.
??? `self` passed to `%s`? We depend on how object is stringified? Ugly!
This variable is not needed anymore! Why are you putting it back?
You need to change "Edystuj..." to "Edytuj..."
I can't put this together right now, but would greatly appreciate someone else doing so.
I've been working on overhauling the JS code organization, and the mishmash of initialization code in `reddit.js` is best considered legacy. Could you please move this initialization code to its own file/object like `r.timeago` (see `r.analytics` as an example) and init it at the bottom of `base.js`?
Все равно лучше писать как они пишутся по стандарту: Authorization
Similar to previous suggestion, I believe this has a place in PetAI
So should I move this to `dbal.xml` then?
Use the context object to retrieve dynamically the path:

`c.uri_for(c.controller('DB').action_for('start'))`
Nowadays we usually wrap this in a dispatch_once, yes?
I would rather have a list of commands that should be handled by the master itself (register_node, nodelist) and relay these commands without modifications.
The style guide is exactly that, a guide. As long as new code is along the right lines it is a waste of time to spend too much time over nit-picking it. The important things are that the code is consistent with the module it lives in and that it is readable. This particular style (not cuddling else and catch) is used quite a bit in Mozilla code anyway and is just fine.
That seems appropriate.  I was about to say to call it ExpireReservation command, but it appears as though the current event is called that.  Event names should be past tense: ReservationExpired. So perhaps there is a little refactoring to do.
#include <something> goes into the stdafx.h file only #include "local.h" in the CPP files
That dot matches all chatacters, no? Doesn't it need to be excaped?  Or, because it is in a [] character class it has literal meaning?
This is just to test the overlay, Daniel will have to finish it.
For the headers_in header, it's real.
Add a brief namespace comment that describes what this namespace does.
Thanks. I didn't read the Wand paper, just the summary of it in the booked I linked, so I may have misunderstood the reference case.
Why is removed /etc/sysconfig/foreman-proxy? This is regression to me. And it can be preserved by:
```
EnvironmentFile=/etc/sysconfig/foreman-prioxy
```
in foreman-proxy.service
Ah, @camertron, do you mean a document explaining NFD & NFKD algorithms themselves?
I *think* this could be triggered by an 'update' event, since that would mean it passed validation.
I confirm that this is correct.  I thought there should be an analytic form for this, but I hadn't gotten around to trying it yet.
Guys , I remember you asked for somelike simmilar like this ... even if it IS useless ;)
You might want to guard for older browser and also add:

```css
-webkit-border-radius: 50%;
-moz-border-radius: 50%;
```

Alos not sure if % works in every browser. Better of giving it actual pixels.
yes on both.  the lte thing is a freudian slip. :)
> But isn't that okay? 

Yap, I use `typeof` for function checks simply callable and `[[Class]]` checks when I want to ensure something is really a Function.
Does 100ms always work on the device? Sounds like this can be broken easily :/ Can't we listen an event instead?
Hi Mani, can you edit the text so that you refer to $SOURCE_CODE/jdk8_tl and state that if the user is using the http://java.net/projects/adoptopenjdk/pages/AdoptOpenJDKVMBuild *then* $SOURCE_CODE/jdk8_tl == /home/openjdk/sources/jdk8_tl

Also, I'm concerned about having anything wrapped up in a ZIP file.  We shouldn't be storing binarty artifacts in source control
@christianchristensen no problem! will add tomorrow.
Ok ja mach ich ...
debug-комментарии надо убирать перед commit
@shacker is the zurb gem not automatically going to include the compass rails version?
No, no reason, I'm not sure why that's like that. I didn't notice it - I could certainly have cleaned it up while I was in there. I'll make that change now.
Remove this bit because `get_link_text` is flawed as mentioned above.
small typo: `sset` -> `set`
Ok. I've set this now.
Duplicated in other places.
Yeah, it still looks far too large to be useful.  And why on earth is the minimum value zero rather than negative?  I thought it would end up being Long.MIN_VALUE.  Maybe default both float and double to the same set of defaults as for int32?  Again, still to large to be generally useful, but a bit of an improvement compared with the long range.
But I can create an additional PR for RC2 and make that field public. WDYT?
On Tue, May 29, 2012 at 04:51:23AM -0700, Varoquaux wrote:
> > +noise = np.random.rand(n_samples, n_samples)
> > +noise += noise.T

> Yes, that's the same thing.

Did you actually check it.

> What would be dangerous in doing that ? Having a non symmetric matrix at the end ?

You are modifying inplace the matrix that you arer using to do the
modification: the RHS and the LHS both get modified during the operation.
It's highly likely that you won't get the result that you are expecting,
and if you do, its just a matter of luck.

G
you are correct - I used to use ``np.mean(y)`` but I changed to the same init as ``gbm`` - I forgot to update the docstring
again, no camel case please ;)
Nope, don't worry with kwargs ordering.
It prints exactly like that in the command line.. still readable though..
Only part that's a bit ugly on the command line is the equation and the topic.. but it makes up for it
by being pretty in the example :smile:
Good, thanks for checking!  So no need to unroll those tests. I would have thought that we could have gotten so speed ups though. Maybe a C/C++ expert such as @larsmans could give use a clue why this is not the case.
so abs, warn, np, sp?
Oh, and the song is still playing even after the Jukebox goes off. I need to make sure that the song is forced to it´s initialized state ("unplayed") whenever the jukebox is off.
Same here, `<button>`
this. isn't in the coding style. Remove that.
This will work for container but there as other template classes that cause problems during compile.
```diff
- // Something Here
```

Maybe just leaving it empty is good enough ;)
Added synchronization using m_muted member variable from CWsDeployFileInfo.
I think you actually want a getExpectedFootprint() function instead.  That wouldn't subtract off the header size before returning.
Would be good to leave some idea that we're trying to rename a file... I can change it to "rename", if you prefer.
You also need to make ```id``` an ```integer4```.
Would crash two lines further down if it was.... removed the check.
Have you tried this under windows/osx yet?
Would also be good to join IN_* flags into one define, since they seem all the same.
This will always be non-null for a no_constant
Ah, yes, I always get confused...
If both key and out are missing, we're all good.
perhaps rename the old executor to something more meaningful, like uploadExecutor?
You check for %nick% only in simpleregexp case.
I'm not sure this is Rally Red.
Nitpick - casing, should be linkedRevisionControl
Absolutely not. This is details of the implementation, not the public interface or user visible semantics.
We don't have a UX need for this endpoint & so my guess is that it will go away soon. Shouldn't block the merge, though.
@ctweney This shouldn't be necessary anymore (it's not in master anymore)
Please see 931a60fdaf6c711e853a015a6281b0058dd8ee9c for the commit by @raydavis 

I've already removed it in my follow up PR at #11
Not thrilled about it either, but doing so to prevent CLC-89 errors (https://jira.media.berkeley.edu/jira/browse/CLC-89) and the like from showing up to the front-end. Rethrowing at this point generates the 500 error page (also non-json output), without the default exception mapper in place.
`/tasks/posts/firebase_push`? It would make it clear it submits data, and "do" is what I've been using for "just does math" tasks.
why is this commented out? If it isn't needed then please remove it.
This needs to be addressed for sure. Windows platforms, IIRC, have readline problems.
Maybe, in case of exception you want just return so you wouldn't need to keep the "connected" variable and stuff.
K-kmeans -> K-means?
np.ascontiguousarray and img_as_float calls should be flipped around, otherwise a copy may be made to make data contiguous, and another to transform to float.
This description isn't entirely clear.  99% of the Gaussian distribution of what?
I think a better test would be to call `.matches?` and then check the failure message, like this: https://github.com/thoughtbot/shoulda-matchers/blob/master/spec/shoulda/active_model/allow_value_matcher_spec.rb#L123
Nope, not handled in the terrain branch.  Needs to be.
so it's copied only when updated
Yeah. Talking with Sabil and Vishal pointed that out. The deeper issue then, is to move the annotationProxy delegate from pointing from a view to pointing to the proxy. That would remove the need of having a view when calling annotationsFromArgs, and annotationsFromArgs can be moved to the proxy.
Typo? I think this is supposed to be 36.
Nope, because windows are sometimes contained in other objects (think tabs and navigation groups).
Can't we just call setEnabled() here?
It looks like we should always be using getDisplayMetrics(parent).densityDpi for getAsInches() getAsCentimeters() etc.  When we initially convert to inches, cm, etc, we either use ydpi, xdpi, or densityDpi depending on whether it's width/height etc (take a look at the getSizePixels method).  We should probably do the same inside getAsInches() and other related methods.

Right now, specifying '1in' height on a view, and then using view.rect.height will return something like .908, when it should be something closer to .99 (rounding error due to pixel conversion)
update docs on this
Becuase `Connection` object keeps both references to cdn connection and storage area connection. Need to use different connection for within different request methods.

As an alternative, I can something similar to:
```python
self._log_request(self.connection.host, self.connection.port, method, path, headers)
```
Took me a bit to figure out what was going on here. The comment should be `"Return the negation of odd-index elements on the list since we're using mincrby"`
Instead of storing this in a member variable, it could also be stored in the backend object. This would remove one indirection and make the backend more self-contained.
i don't say anymore that the code did not get there :-) but the situation that getValue would return null is impossible. 

but whatever, things are gone now in #97 - can you maybe check that against your situation just to be sure? i tested with all phpcr tests as well as the phpcr-odm and found no issue. and i read the code and think the problem should not happen.
you should use Assert.is_sorted_ascending or Assert.is_sorted_descending here
*Phobos*' programmers must be advanced.
If you want to use can't, then use can't. Multiple sources have been given which indicate that cannot is more correct than can not, and the person who corrected you first isn't even American (Alex is from Denmark according to his github profile).  And if you actually use quotes in that google fight bit, the results are in favor of cannot: http://www.googlefight.com/index.php?lang=en_GB&word1=cannot&word2=%22can+not%22

But arguing over it doesn't get us anywhere. We have better things to be doing. If you don't want to use cannot, then just use can't and be done with it.

Thanks for the cool link by the way. I didn't know about google fight.
spacing around operators (throughout)
That's almost definitely not the email address you want either. Wrong proposition.
No big deal (either way). More of a personal thought- just did not feel right (i.e. I've used the method myself in [io.FileTransfer](https://github.com/tinyhippos/Ripple-UI/blob/a6bb9c62f0ce29306d01b1f2c47a9ba0eb6aaae3/lib/ripple/platform/webworks.bb10/1.0.0/io/filetransfer.js#L204-207), FWIW).
I'm wondering whether we could find another name. Users might get confused about this type vs. `org.hibernate.validator.HibernateValidator`. I don't have a good idea, though :)
I disagree, because numpy also uses `os.environ['HOME']` (so we should too), see https://github.com/numpy/numpy/blob/master/numpy/distutils/system_info.py (`get_standard_file` function).

I moved the check higher up to `DefaultPythonPackage`, because it not only applies to scipy.
Why do this as a static?
This comment doesn't look right.
why not 
ModelDescription source = new ModelDescription(model); 
or
ModelDescription source = loadDescriptionFromOpenEngSBModel(model);  // as static method from modelDescription
This should be a pretty straightforward fix. I'll see if I can push out an
update to this around lunchtime PST today :-)
On Jun 29, 2012 10:11 AM, "Ben Hughes" <
reply@reply.github.com>
wrote:

> > @@ -291,6 +293,8 @@ def git_with_identity(*args)
> >
> >          return ret
> >        end
> > +    elsif @resource.value(:user)
> > +      su(@resource.value(:user), '-c', "git #{args.join(' ')}" )
>
> FreeBSD:
>
> <pre>
> [hal:~]% su -h
> su: illegal option -- h
> usage: su [-] [-flms] [-c class] [login [args]]
> </pre>
>
> yeah, that will break horribly....
>
> Yes, it needs a patch for sure.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/puppetlabs/puppetlabs-vcsrepo/pull/25/files#r1077212
>
Finally, please also put these two lines in the opposite order, to preserve the alphabetical order of the list.
This plugin upload the jar file on googlecode in the gwtquery-plugins project. Is it something we want to keep ? The problem is that only me have the permission to upload the file I think
And "Patient B" should have status "new"
is a good practice to keep all events related to the plugin with a namespace, in this case <code>crc</code>, please keep it
I agree with @JensTimmerman, it this really needed? I don't see why it would fail.

Maybe because there's no `.so` provided by SamTools? If so, then that should be fixed instead, I think.
That's a LOT more complicated, no longer an easy search and replace on 'llvm::'.
Assuming you can get away with an int above, you can also pack `valuesource` into 2 bits and `connected_down` into 1 bit, and hide them in the upper bits of the `dataoffset`. This would cut memory usage by more than half.
That was exactly what you wanted me to modify. Have I missed something?
It was the ManagerInterface and you requested to be the ManagerRegistry, so I modified it.
Which one do you prefer? Interface of this one?
please add a test for not found
Personally I would consider using full weekday name since with a bit smaller font it won't increase column width (at least for English and Polish ;-)).
Multiple filters aren't set in one string anymore, so removed helper function for that.
I'll check it, ti satisfy our curiosity, but i'll probably keep it to maintain bean convention
Well, not exactly Thread.sleep() but, yes, the thread is paused in an ObjectWaitSleeper if you use a backoff policy. This is part of spring-retry.

How else would you implement stateless retry mid-flow?

I agree pausing threads is not scalable but stateless retry (or at least a backoff policy) should not be used in cases where it would cause pain. The default backoff policy is NoBackoffPolicy (which has no pause), so folks shouldn't get tripped up by this by mistake.
I'm not sure how I feel about comments about the details of the service "5000 items". Those facts can change from service version to version, so by including them we make our docs implicitly tied to a version. In addition, the REST docs can have bugs of their own (perhaps they are in error and it is really 1000?), which makes comments like these even more fragile.
I see. Wouldn't it still be safer anyways ? Example: in case someone adds a async call in the future and happens to forget to add the done ?
no, it is $$key :)
or "directory" resource
I agree, we should keep the offset info.
Minor thing, but space after the comma, please :)
Use HashMap(int) to preallocate capacity, default is only 16 items, be sure to be slightly more generous with the initial cap since hash maps will need to expand and copy all elements when the load reachs around 70%. We might be better off using something like a TreeMap which has better support for dynamic expansion.
it's overwritten method from it's parent which doesn't change it's prototype.
Not directly related to the renderer, but it would be nice to not allocate this array every frame. This code needs more general cleaning though so I wouldn't bother with it right now.
What if the fields have custom values to start with? A form.reset() will modify anything the user has changed back to their defaults?
Present tense is better than future (avoid rspec-like text)

something like: "entry point for configuring the routes mapping http requests to the pojo controllers" would be better
I dont think there is a query builder for insert. Or does anyone know better?

Couldnt find one in the docs and also found this: 
http://www.doctrine-project.org/jira/browse/DBAL-182

As far as I can see Doctrine\DBAL\Connection::insert is quite simple and wont accept a subquery either. 

If I am wrong on the above, great. If I am correct, do we leave this as is, or resort to sql in this method? I see there are other places in the class where SQL is used directly but I would have thought we want to get away from that where possible.

Would be good to have a steer on this point.
the license header should be before the namespace
I believe the cache no longer works if it depends on the `attribute_name`.  In production it would cache the first attribute name and use that for the remaining accesses. On the other hand, I am skeptical about adding a two i18n lookups for each time we are rendering the boolean collection. So we have two options:

1) Drop this feature and the developer manually pass this as :collection

2) Continue with this feature but do one lookup at "simple_form.collection.#{attirbute_name}". We would pass this hash straight to `builder.collection` which means its usage would no longer be limited to booleans. This means a developer could do:

    simple_form:
      collection:
        user:
          gender:
            male: "Male"
            female: "Female"
            other: "Other"

And he would get the expected results back (unfortunately the results would be out of order on 1.8 but we can tag as 1.9 only feature).
I think that I am only toggling if it is wrong state?
Fixed in bf6a4e25fa7c95fd61b13a2541697eaead9eb225.
The default should be True for the next release.
Most of the deletes and new files are moves from `management` to `management-servlet-api`. This class gets a good working over on the way though.
You can switch the flag to YES when we want to enforce the batch layout behavior.
Please add spaces after colons in the array.
Well, I've reviewed the tests in the remote container, and the 
application.xml file embedded in the EAR by the test is useful in a way. 
It serves as a regression test for ARQ-658, but there is another test - 
GlassFishDeployWithoutAppXmlTest related to this issue, where the file 
is not added to the SW archive. I'll add this second test to the managed 
container, and provide comments in these classes on how  the two tests 
are used to serve as regression tests.
added the filter in the interface.
for DoctrineORMAdminBundle implementation, see PR https://github.com/sonata-project/SonataDoctrineORMAdminBundle/pull/47
Need test cases for invalid orientation and background color values?
Not a huge thing, but you could probably find a way to get rid of `toBeIgnored` and just use `matchedFiles`. Would require a bit of tweaking to your code below though.

`return matchedFiles.indexOf(from+ "/" + file) === -1
If it makes your life easier just a create parallel ext folder called "ext-internal" and put your new extensions in there.
This file has been removed ;) 

https://github.com/sonata-project/SonataDoctrineORMAdminBundle/commit/8bb63d433b16e41fa50780a38db1985a6fe685e9
This stuff is kind of redundant because it appears later in the file, but there are a ton of duplicates in here.

I'll merge it and then clean the file at some point. There's a ton of stuff that doesn't need to be here.
Just removing the comment about only when utf8.