labofsahil/github-event-dataset-2012 huggingface dataset:
No, and there's already a use of changed serverside fragments in there somewhere. The basic idea is that you override the HTTP header on the current request as required. It'll be cleaner to allow setting an override on PjaxResponseNegotiator though (like you had originally implemented). Wanna have a stab at it?
Is this only needed in `development`, `assets`, and maybe `test` environments? Would be nice to avoid putting it in `staging` and `production` environments if possible.

Alternatively, if this is a development-machine-specific library that doesn't require Gemfile changes, can Debian users just install a Javascript runtime as part of getting their machines ready for Rails? It seems like we don't necessarily need to make this an application-level concern if it works for some operating systems with libraries installed external to the Gemfile.
interesting solution.  you could also just have a boolean var or attribute called `is_default_set`
remove space after opening parenthesis
this is the safest option
Why not just using an anonymous function here? You are declaring the function inside of the function anyway and not inside of a loop
what do u mean by "causing a lot of nodejs restarts" ? we have an haproxy in front of our instances and are queueing requests if too many are approaching.
remove this method entirely. It is not needed as the parent class defines it
Duh, thanks! That’s what I get for writing a patch at 1 AM.
Have to correct type to string:

 $this->rows = (int) $this->element['rows'];  to   $this->rows = (string) $this->element['rows'];
Instead of `getUrl` it should be `getURL` since it's *U*niform *R*esource *L*ocator 

...

Then again I haven't checked other methods with acronyms for usage. @arian do you recall?
```
container = document.id(container);
this.container = container || document.id(this.container.getDocument().body);
```
For what it's worth, you can do `'padding-top' which feels less magic to me, but I'm fine with this. Just an FYI
No, int is not good ID. But OK, use this for now, but add TODO for later, maybe somebody else can improve this later.
What if I put additional conditions here. I had `logged` variable here that cleared when task cleared user `connections`. This way there are no sequential subscriptions here. Putting this in tasks.py will cause delay. Is that really the best choice here?
I think it is quite good.

*Returns horoscope sign, description, date and a source depending on user information.*

So *s* at the end of the verb. ;-)
Somethin liek that: Ensure this value has at least 4 characters (it has 1). It is also transleted to slovene: Poskrbite, da bo ta vrednost vsaj 4 znakov. Trenutno jih ima 1.
Good. Because you see, if you just leave things in, then somebody else will think that there is a reason for it. :-)
If you login "the normal way" with username and password, you do not have facebook_id (it is set as "None"). 
Then this function tries to get facebook image with some strange id, and you end up with default facebook image and not with avatar you had.
(String.) ??
this is obviously ugly but the benefit is that it's called only once rather than every time we call #evaluate
@irium Just push new commits to the *same branch* where you originally sent the [pull request](https://help.github.com/articles/using-pull-requests) from. They'll automatically show up on this page.
Все равно в Zend\Http\Headers ключ будет приведен к нижнему регистру
It probably just wasn't being used in the purchase method.
Wouldn't a repait/invalidate do the job (faster)?
I don't think I meant to do that, I may go through and just add them
should be written as "plural_name"? (but practically no problem)
@Ocramius Should I/you raise an issue in the zf2 issue tracker?
that's right, my ext4 /home partition doesn't support SQL.
surpressing anything interesting?
Is the PigLuceneIndexOutputFormat a good idea? If this class hierarchy and the requirement to subclass PigLuceneIndexOutputFormat is just to get  rid of an unsafe case, I'd say we don't need it. Without it could we just catch the class cast exception when casting to LuceneIndexOutputFormat and output a meaningful message in the constructor? I think I might be missing something here...
Instead of passing builders around, what do you think of refactoring so the code looks something like:

``` java
Map<String, TableBackup> metaTableBackup = kiji.getMetaTable().toAvro();
List<SchemaTableEntry> schemaTableBackup = kiji.getSchemaTable.toAvro();
final MetadataBackup =  MetadataBackup.newBuilder()
    .setLayoutVersion(kiji.getSystemTable().getDataVersion())
    .setMetaTable(metaTableBackup)
    .setSchemaTable(schemaTableBackup)
    .build()
```
I like because I think this decouples getting a serialization of the meta / schema table from constructing a backup record that's convenient for storage. Another advantage is that other code can get serializations of the meta or schema table without knowledge of the builders.
My conception of the restore-from-backup functionality is that it's something a user will employ when either their meta or schema tables have been irreparably lost or corrupted. If we work under this assumption, then this tool could wipe the meta table / schema table if they already exist (with the user's consent) before performing the restore. This would avoid the delete masking problem you encountered earlier as well, and allow us to write the layouts and key/value meta data at their original timestamps.  Also, appending backup values to an existing meta table may result in confusing column histories containing many duplicate layouts or key/value pairs, and wiping meta data first avoids this.  

In this world, an option allowing the user to select specific tables to restore makes less sense (which is my excuse for putting this long comment on this line).

If we decide to go with this option, we'll have to ensure (at least down the road):
1. The user can roll back a table's layout to a previous layout in the history. This is so they can easily roll back layout updates that proved erroneous. 
2. The user can roll back the value associated with a meta data key easily. Again, roll back erroneous settings.  
3. The user can "undelete" a table in the sense that the table's meta data can be restored. The delete-table operation would delete the hbase table corresponding to the kiji table, but only write a marker in the meta table (a "deleted" column) instead of deleting the kiji table's row. The meta table implementation would have to be modified to respect this.  

I'm in favor of this redesign because it scopes down the features implemented by this tool (backup in case of disaster, restore in the aftermath) and separates the concerns of recovering from more minor disasters (bad table layout changes, bad table deletes, bad meta data settings). Thoughts?
It's understandable to me but sadly we can't add your copyright to the header. I checked various other open-source projects for best practices but I couldn't find a definite answer. Is it OK if I add/change the header after the pull request is merged in? As said, I will make sure you get proper attribution for your contribution.
document_id
The number of colours should be detected automatically.
I added l1 logit and MNLogit to examples/example_discrete.py.  Should I add Probit?
Only wrap lines if > 100 characters. I think this parameters will fit into the line above.
If you added these comments on purpose, just delete them instead.
Depending on the note above, the ```//round``` comment should match the function name
3.1 is not correct. The AdapterCommonDataLayer code (and all of the other projects in Adapter\Framework directory) is being updated for use with CONNECT v3.3.1.  I will make sure to incorporate this change and the other suggested changes into the updated version.
@zoltax, do we really need this var_dump here?
Lol. Great catch!
I change the field name to verify things would work when the key doesn't exist - forgot to change it back!
port_end is still declared and assigned, but never used...
This should have an `e.preventDefault();` before it's called to avoid following the logout link.
On 23/02/2012 09:41, Timothy Guan-tin Chien wrote:
>> @@ -476,7 +476,7 @@ iframe.landscape-secondary {
>>     bottom: 0;
>>     overflow: visible;
>>     background-color: #f0f1f2;
>> -  width: -moz-calc(100%);
>> +  width: -moz-calc(100% + 2px);
> WIth width = 802px, 11 key-row keyboards add up to 802px or 801px in a row, which breaks the layout.
>
> Instead of update the calculation of key width, I thought this is faster hack to do.

I don't really like it, but let's go for now.562/files#r479479
Since I'm not familiar with this code, please revert it for now. I assume it's just a warning and not a crashing bug, right?
Let's get the actual mathematics into a library, instead of in this file. It'll make it a lot easier to understand what this module does, and how and when it does it.
Сколько раз мне надо сказать исправить название по code conventions, чтобы ты исправил?
\n должен быть после )
We have changed this if statement, because we discovered a bug with this, and this refactor extends the original logic, and solves the regression bug we have discovered with Zsolt.
This shouldn't return True or False as it is only a passive Wait.
Source extlink can point to openmicroscopy/bioformats
Author information should all go into ``CONTRIBUTORS.txt`` -- this makes it a lot easier to manage the licensing for our Debian packaging.
Please keep the line width at max 80 chars. This is hard to read in the GitHub interface.
I think this code building `affinity_matrix` from a data matrix should be factorized out in a public utility function, maybe in the pairwise module to make it more reusable. It should further be completed with `dot_product` (e.g. for positive data), `cosine_similarity` (same as previously).

We should also implement a truncated connectivity matrix for k-nearest neighbors using a sparse datastructure to be able to scale spectral to large n_samples documents corpus for instance without exhausting the memory but this will be dealt with outside of this PR.
Why do you need this option? I would just use `_sparse_fit` when the data is sparse and `_dense_fit` when the data is dense.
этот тест проверяет доступ или удаление? лучше сделать два простых теста в два действия, чем один большой, который проверяет все на свете.

в тесте на удаление логично проверить или обоя в базе осталась или нет.
This could be in a `private static` or at least initialized *before* the loop
Shouldn't this be false. Once the export is finished, it is no longer ongoing.
This member has been added for condition checks but doesn't seem to get modified anywhere. What's the plan here?
Couldn't we also just do the following? Or would it mess with things expecting more functions/properties than just show?
```
Ti.UI.createAlertDialog = function(parameters) 
{
    return {
        show:  function() {
            Ti.API.info(parameters.message);
        }
    };
}
```
Should all these use the following?
```
platforms: [android,iphone,ipad,mobileweb]
```
shouldn't we make the default the amazon endpoint?
Minor nitpick: this change isn't necessary.
This shouldn't be the syntax for a grouped hash aggregate any more.  Have you retested?
oops, I tested under eclipse/vista.
please re-add the empty line after the use statements
I mean you only test false to be true, nothing else. Try adding an assertion that compare two different strings. What happens?
this is not php :)
```
ok_("We couldn't find" in response.content)
```
It should, yes. Changing it now.
``are supported``
This should be using formatteddelimiter to prevent extra spaces:
```, input = this.mode === 'multiple' ? this.$element.val().split(this.formatteddelimiter()) : [this.$element.val()]```
The functional and integration tests are testing subtly different behaviors. 

The integration tests only cover that a link called "Add task" appears or doesn't appear in the view based on the user's role in the course. The functional tests, however, enforce the permissions on the server side. Whether we call it an integration, unit, or functional test, I'd like to make sure that each of these behaviors has tests around it.

Thoughts?
indentation is off in here (4 space indent)
nit: 3D
changed to driver.allow_aliases actually
Removed filename
Remove if you don't need it
To keep the line short?  I do that sometimes.
I guess this is one loop where the functions above may significantly slow things down if they were in pure Python.  Did you perhaps do a benchmark?  It'd be good to know what the slowdown would be if this entire module were to be done in Python.
For an RGB(A) image, I imagine this would make the most sense.  However, for my use case (separately acquired, registered, multispectral volumes) I definitely need the option of separate scalings.  One could range from -2000 to 4000, another from 0 to 600, which is why I warn about pre-processing.  This could be addressed with a `scaling=` kwarg defaulting to `all`, with an alternate option `separate`.
Fixed. I agree with tonysyu that it makes no difference. Now you have the full flexibility.
Add:

### Constants in global namespace should always start with a lowercase k
If our usernames are a `UNIQUE` in the database, wouldn't the database throw an exception that we could catch instead of this hack-y, race-condition-prone way?
Same question throughout, of course.
After seeing the bulk of your code, I agree.  Keep `isReady`.
You should never use `||` anywhere except for Math.  Use the `Core/defaultValue` function instead.
Why less than 1.0?  Doc says 1.0 means spin forever and 0.0 means don't spin, so I would think you'd want to maintain inertia anytime it's greater than 0.0, not less than 1.0.  But I'm might be missing something.
Could we enforce the user to follow the chain or the order doesn't matter?

For example, currently this builder allows me to do something like this and do not enforce me to follow the chain of methods:

    @Produces
    public CorsConfiguration demoConfig() {
        return CorsConfig.create()
                .allowCookies(false)
                .allowCookies(false)
                .maxAge(10)
                .maxAge(20)
                .enableCorsSupport(true)
                .enableCorsSupport(false)
                .allowCookies(false)
                .allowCookies(true)
                .anyOrigin(true)
                .validRequestMethods(RequestMethod.GET, RequestMethod.PUT, RequestMethod.POST, RequestMethod.DELETE)
                .build();
    }

Would be nice to follow the footsteps from: https://github.com/aerogear/aerogear-controller/blob/master/src/main/java/org/jboss/aerogear/controller/router/RouteBuilder.java
Probably should add a comment stating the reason for this workaround of the Android bug.
- nothing seems to close this PrintWriter
- print writer uses default system encoding
Это выпилишь потом?
Hi Scott,

> My only question is that this line appears like it will blow up if the private path already exists.

According to `man 1 mkdir`

> -p ... On the other hand, with this option specified, no error will be reported if a directory given as an operand already exists. ...

I think it won't blow up.

> I'm not sure what the rest of the behavior in deploy:setup is like; we probably want to be consistent with that.

the rest `chmod o-rwx` does not behavior like what in deploy:setup because I think the `private` directory should not be accessed by others.
Rats.  Let me find the right one.  Glad you caught that.
do we have RTL styles?
quotation !
Yeah, I know it exists in the 2.1-stable branch, but it doesn't exist in CodeIgniter 2.1.0, which is the latest version released.
It was introduced [just a few weeks ago](https://github.com/EllisLab/CodeIgniter/commit/db6066511bfc1a728049fdadaad14f1d10cd9796).
Noted and removed. 08ec53e
Use `reduce(0, :+)` instead for initial value
It would be better to track this somewhere else, such as issues. It is very easy to get lost on requests like this.
The primary goal of this format is to allow for a simple XML format
Just that you could just change the module it's being imported from without having to update the code and specify it as modulename.Class.
If you remove the ### line, then the title in the index will be messed up.  You need to have a title that the index can use.
Just a stylistic choice. I'll change it.
Is there a reason you are not using the ``setListeners`` call anymore? I added it to avoid a single method call per listener.
Well that's a conundrum. Is there a bug open at twitter/bootstrap? Is there a particular reason you know of that bootstrap chooses that range?

That would cause upgrade compatibility issues if people used the mixin elsewhere, how likely is that?

What are the specific conflicts with Compass here?
sorry, nevermind
I think I fixed these everywhere now...  :)
If you wrote the code, it's most probably not »Copyright Digital Mars 2000 - 2012.«.
~~We will now see~~ The following is a sample
Oh; I see Amol is saying the same thing.
"use verbose logging" or "log verbosely", perhaps?
esté configurado (con tilde)
`o` va sin tilde
This function does not seem to be used anywhere in the theme. Also, it is better to use `${PWD/#${HOME}/\~}`.
missing space .. also i wonder if the DBAL doesn't have a helper method for us to fetch this with a single function call
No need for trailing comma.
Should this not be COST_REMOVE_RAIL ?
Код должен быть максимально самодокументированным. Используй тогда модуль заодно и от _ избавишься
```javascript
var mySpecialFunction = (function () {

    function myPrivate() {

    }

    return function () {
        var  stuff = _myPrivate();

        return stuff * 42;
    };

}());

mySpecialFunction(100500);
```
`<call method="setEventDispatcher">`
The same as above :D
Why are you committing the changelog as a comment to the file? Make a separate file for it, it does not belong in the language file.
Please also pull 9f59a0b7fd0eaff72b80e9741337d596bb885a4c to remove the now redundant check
no need for ``else``
"whether to recursively delete any parent directories in the path."
I just renamed `addHandles` and `removeHandles` to `showHandles` and `hideHandles` respectively. A misnomer perhaps but I think it's more obvious and would like to stick to it.
The only real files of interest in this review are  CloudTunes-metadata/make_package.sh and CloudTunes-metadata/readme.md.
These were copied from a java file. I'll check with Ted tomorrow if he has C#-specific headers.
there is no language just sign. ok i will change it to trippledot
I see that you are resetting the value for archivePath back to it's original value at the end of your test. What happens if this test fails part way through (runtime exception)? Will this code not be executed? If not, then the session.archivePath value will never be reset and could affect other tests.
we can use nvl() to do that
shouldn't this be true by default
Participants are listed, but other than that, nope.
don't think you need the baton here as well
uusi tehtävänanto pyysi kertomaan kahdella listan/vektorin pituuden, siis jotain (* 2 (count x))
The condition for `if` can be any value, not just a boolean. So this is sufficient `(if x true false)`.
You probably meant `(not (teen? age))` without the `if`. Try to be sure that the code runs even if some tests fail, for example by running `lein midje` from the command line.
s/similar to functions/similar to values/
Agreed. `armstrong.db` makes sense. That would be a new package right? What else would go in it? (Different thread of discussion I realize...)
If you look down towards the errors on the form document; the bootstrap library by default shows them as help-inline; whereas help-block is more or less utilized for the description ( the help text that generally speaks to how they should implement the value).
The last line about object/array could get more importance if separated as a NOTE like

NOTE: If CActiveDataProvider is used like in the above example $data is an object (usage in the view file: $data->name), but if  CArrayDataProvider or CSqlDataProvider are used $data is an array (usage in the view file:$data['name'])