labofsahil/github-event-dataset-2012 huggingface dataset:
yes. It was one of the only points where the Symfony CS were incompatible with PSR-2 (symfony was saying "visibility everywhere except interfaces" and PSR-2 says "visibility everywhere") so @fabpot changed the rule for Symfony to follow PSR-2 (another point was the order of ``static`` and the visibility and it was also changed to follow PSR-2)
ah i added line as a note to me when i thought i would have to change something but its fine as is ignore or i can re open pull request with this line deleted
quote gozashtam dggggg :trollface:
De pus urlul complet cu titlu Referință.
It would be better to use values defined in object FrequencyBuilder for that, but I'm not sure it is possible: I believe annotation only takes static modifier, so perhaps a "final" will be needed for vals.
Do you ever get the large values here now that the division is gone?
Why not name these "union" and "intersection"?  Generally we tend to use nouns for "functions" (return a value based on non-mutable inputs) and verbs for "procedures" (do something to the objects referred to, have some kind of side effect, or perform a task).
hier wird nach dem erfolgreichen deploy der apc cache geleert.
Would be nice to have a docstring here to describe the purpose of this file.
Not sure exactly what you mean by "well ordered", but it'll be consistent from run to run.
Don't think we want this on a separate line?
You've already captured `numpy.array(img)` as `img`... did you mean to do it again?
Ah, no, it's much more straighforward that that. Brief testing shows that `AfterStep`s are only called after top-level steps (as in, ones in Feature Scenarios). Steps called by `step` or `steps` don't trip `AfterStep`
Alphabetical sorting is done on imports in the same package; as such, from akanda import should be above from akanda.routerapi import ...
Same here:

```python
littlechef.lib.get_recipes_in_node({'run_list': run_list})
```
Well I'm glad you're diving right in despite being a beginner. Thanks for your hard work.
I would love to adapt the ecf settings.

However, since ecf file format still lacks a decent documentation, I use 
copy-paste or snippet programming to assemble ecf files.

Le 21/11/2012 16:38, Jocelyn Fiat a écrit :
>
> In library/gobo-core-confident.ecf:
>
> > +		<root all_classes="true"/>
> > +		<option warning="true" full_class_checking="true" is_attached_by_default="true" syntax="transitional">
> > +			<assertions precondition="true" postcondition="true" check="true" invariant="true" loop="true" supplier_precondition="true"/>
> > +		</option>
> > +		<setting name="console_application" value="true"/>
> > +		<library name="base-safe" location="$ISE_LIBRARY\library\base\base-safe.ecf"/>
> > +		<library name="gobo-kernel-safe" location="$GOBO\library\kernel\gobo-kernel-safe.ecf"/>
> > +		<library name="gobo-pattern-safe" location="$GOBO\library\pattern\gobo-pattern-safe.ecf"/>
> > +		<library name="gobo-structure-confident" location="$GOBO\library\structure\gobo-structure-confident.ecf"/>
> > +		<library name="gobo-time-confident" location="$GOBO\library\time\gobo-time-confident.ecf"/>
> > +		<library name="gobo-math-safe" location="$GOBO\library\math\gobo-math-safe.ecf"/>
> > +		<cluster name="gobo-core" location=".\" recursive="false">
> > +			<file_rule>
> > +				<exclude>/EIFGENs$</exclude>
> > +				<exclude>/CVS$</exclude>
> > +				<exclude>/.svn$</exclude>
>
> probably it would make sense to exclude any file or dir starting by /.
> this would include /.svn /.git /.hg ...
>
> And it would be nicer to have this just before the <option line
> this way, it is global for any cluster
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/gobo-eiffel/gobo/pull/3/files#r2195233>.
>
Where-ever you got all of this code from, you should probably put a link to the webpage at least in a header somewhere.
These 1 sec sleeps are just killing testsuite execution time. How about 100 ms? And if the first request can execute before the first sleep, all the better.
I agree that they could be and the getters/setters would also need to change before we start running multiple AS instances per jvm.  I'll make a note of that and catch it in a future change.
I changed this attribute name to more accurately represent what data it holds, it used to be a object with attribute factor, as this was confusing and did not serve any other need i have simplified the usage and rename the parameter as now parameter acualy holds load balance factor and nothing else.
But if there is/will be need to add any other attribute to load balance provider than this should be changed significantly (submodel & friends)
Looks like a copy/paster error (javax.ws.rs.ext)
Jan, this system property shouldn't play a role in the EJBCLIENT-34 feature. The EJB client context created via the JNDI context should be isolated and should work irrespective of what value this property is set to. If it doesn't then we might have an issue somewhere. Can you please explain what problem you were running into?
abstract public class
Demo added. It's demos/dialog/complex-dialogs.html.
is it possible to not upload a file and submit a form? make sure it is not.
BTW, I don't think this will pass `gjslint`
I think this select widget makes more sense below the name/email/password fields, but I don't feel strongly about it.
You did it in the `isConnectedTo` function, right?
There is a '+' before... 
return '<div class="groupHeader">' +
    Utils.getHeaderDate(conversation.timestamp) + '</div>';
We should keep looking for an image if the contact has a photo (to change it), not only when the contact doesn't have any
2-space indentation everywhere, please
Use a data-disabled attribute and pointer-events: none in the css so you will never receive click events.
It's the color matching the calculator's background image. The calculator uses a full-screen background image. With the current white/transparent background there is often white flashing when opening the calculator because the bg image doesn't load/decode fast enough.
The Task.Finally helper is no longer needed with await. It will either throw and get caught by the outer try/catch or continue without exception.
What is the intended purpose of either of them? CommandExecutor appears to be doing exactly what I need (and so does Executor)?
________________________________________
From: David Fowler [reply@reply.github.com]
Sent: Tuesday, July 10, 2012 9:47 AM
To: Tomasz Janczuk
Subject: Re: [kudu] Support for multiple node.js versions (#120)

> @@ -74,5 +91,40 @@ public void CreateConfigFile(string nodeStartFile)
>                  Path.Combine(_siteFolder, WebConfigFile),
>                  String.Format(Resources.IisNodeWebConfig, nodeStartFile));
>          }
> +
> +        public void SelectNodeVersion(ILogger logger)
> +        {
> +            // The node.js version selection logic is implemented in selectNodeVersion.js.
> +
> +            // run with default node.js version which is on the path
> +            string command = string.Format(
> +                CultureInfo.InvariantCulture,
> +                "node.exe \"{0}\\selectNodeVersion.js\" \"{1}\" \"{2}\"",
> +                _scriptPath,
> +                _repoFolder,
> +                _siteFolder);
> +
> +            CommandExecutor executor = new CommandExecutor(string.Empty);

This isn't the class I meant. (I know it's confusing). It's this one https://github.com/projectkudu/kudu/blob/master/Kudu.Core/Infrastructure/Executable.cs.

---
Reply to this email directly or view it on GitHub:
https://github.com/projectkudu/kudu/pull/120/files#r1132796
I can't fit this in one refactor, one of the ideas is if the slices returned the results as an object and we can determine how to handle it on a global level, otherwise every additional slice we implement needs to carry the burden of understanding how to provide proper response. 

<pre>
slice = ProjectRazor::Slice::SomeSlice.new(args)
...
results =  slice.slice_call
</pre>

This way we can easily add additional formats in one line, and we can implement pretty_print per slice for CLI output:
puts results.to_xml
puts results.to_json
puts results.pretty_print

This is just a suggestion and I'm open to other ideas that isolates responsibility and ease our implementation so we can add functionality such as xml in future.
It kind of makes you wonder, when they retrieve their phasers from the armaments locker, what are they set to by default?  I suspect there is a setting that is never mentioned: "Uncomfortable tingly sensation."

Probably that setting was also deprecated in season two as not very useful.

This here was for educational purposes -- since old actors is deprecated anyway.  Maybe old actors will live on as actors lite for classroom use.  But I can zap it, of course.  Set to "make it glow and pulsate until it fades into nothingness."
Makes sense, will change.

The regexps reflect the rules for the allowed file names in doozerd ([Naming files](https://github.com/ha/doozerd/blob/master/doc/data-model.md#naming-files)), i.e. unless we want to check this explicitly in our code again, there is a check in place via doozerd which forbids file names not matching that regexp
Sorry ... that was one of your test that was already commented out. But you are right - I need to remove it. My bad!
Added it. Note that I copy pasted the approximate map equality code. I added an issue that we should fix this at some point.
Also, since I guess it only can happen on mobile webkit, I would add the timeout inside an if block (`if (L.Browser.mobileWebkit) { ... }`)
I would say the "same name as the enum" is preferred, so it's clearer when reading the PRC that it's not just a string value.  Also, you use the 'k' in the default value below ;)
Measurements should be treated separately from ops as mentioned by @rzezeski  otherwise summary stats get inflated by them.  Fine for now as just an evolution of the stats.
minor nit: we usually spell this `[]`
simply initialize ``lowMatches`` to an empty array instead of ``null`` and this will not be necessary
quentin, can we go from an api point of view? what do we want to expose? :install, :update, :uninstall... can we make those the only tasks available?
Agreed, eager static + setters, getters and default method will be enough for now
this is NOT obsolete, instead
This define should be set by UreenPlugin.qbs for all plugins, look at cmake scripts for convience
did you check your request at all?
I'd prefer previous option.
not writing, just reading, making sure I hadn't broken the configurability

but yes, accidental check in
Nope. NSS code has been added after you add this lib in Suricata deps.
ROS node names are under_scored, see http://www.ros.org/wiki/CppStyleGuide
Bad stuff :laughing:  I didn't look at what the other `EnumerableCollection` classes were doing.  `raise` that it was not found?
'file' and 'paste' can probably be named better. maybe that they have to do with images or text input
Somewhat moot for English, but could res.setEncoding('utf8') here.
@seanmonstar - a slight typo here, this should be resources instead of resoueces
Cool, the semantics of returning undefined look the same, assuming the old code it was possible to ask for a key that didn't exist in allInfo.
Business logic goes to Manager class
Oh. And I ushed up a reversion commit.
@hkenney We should add an empty line between the two sections.
Please use other wording than it "works", since that doesn't really convey any meaning. Probably something like it "returns public methods for immediates", since that describes what it does.
This condition exists for formtastic in order to support both 1.x and 2.x versions. I don't think the same is required for the `formtastic-bootstrap`. Could you please simplify it to just:


```ruby
class FormtasticBootstrapBuilder < ::FormtasticBootstrap::FormBuilder
```

Thanks!
This import is also used in docblocks. Can you revert this and use Object\ObjectInterface where is needed?
Move the "implements" keyword up to the previous line; "ExceptionInterface" can stay on the new line. (PSR-1 recommendations)
Caution with this.
Yes we should, because functionally those two they are opposite. 

Expecting (typehinting) a `Request` must disallow passing a `Response` and vice versa..
Lines should be wrapped to 80 cols please.
Yeah, just prompt for a yes/no from them I guess.
It seems weird to put the manager in the ``Entity`` folder. It is not an entity.
and btw, this will cause Doctrine to check these classes when searching all metadata.
It's `\DateTime` not `date`, also this method don't return anything.
"isStillUnit" ?
also I was thinking , the whole formatVideo method, you dont really need to check for patterns in the test data; I would rather just keep one case there, perhaps changing the regex to not end on eol ?
can you add some spaces around ``?`` and ``:``?
not sure either .. ``validateRuntimeMetadata()`` is probably also not the right place ..
Typo, looks like this should have been #cf-public
these are default values for the ``MARKUP`` setting, so you should not add ``'markdown', 'mkd'``, see:
https://github.com/getpelican/pelican/blob/master/pelican/settings.py#L24
You're right, cleaned up.
Please use `null` instead of `''`. Why in next comment.
`#{}` should be returned if the square is already filled.
I see this syntax mentioned in the [relish docs](https://www.relishapp.com/rspec/rspec-core/v/2-11/docs/command-line/format-option), but it doesn't actually seem to be supported:

```
$ rspec spec --format documentation:rspec.output.txt
/Users/john/.rvm/gems/ruby-1.9.3-p194/gems/rspec-core-2.11.1/lib/rspec/core/configuration.rb:482:in `add_formatter': Formatter 'documentation:rspec.output.txt' unknown - maybe you meant 'documentation' or 'progress'?. (ArgumentError)
	from /Users/john/.rvm/gems/ruby-1.9.3-p194/gems/rspec-core-2.11.1/lib/rspec/core/configuration_options.rb:23:in `block in configure'
	from /Users/john/.rvm/gems/ruby-1.9.3-p194/gems/rspec-core-2.11.1/lib/rspec/core/configuration_options.rb:23:in `each'
	from /Users/john/.rvm/gems/ruby-1.9.3-p194/gems/rspec-core-2.11.1/lib/rspec/core/configuration_options.rb:23:in `configure'
	from /Users/john/.rvm/gems/ruby-1.9.3-p194/gems/rspec-core-2.11.1/lib/rspec/core/command_line.rb:21:in `run'
	from /Users/john/.rvm/gems/ruby-1.9.3-p194/gems/rspec-core-2.11.1/lib/rspec/core/runner.rb:69:in `run'
	from /Users/john/.rvm/gems/ruby-1.9.3-p194/gems/rspec-core-2.11.1/lib/rspec/core/runner.rb:8:in `block in autorun'
```
Thanks. I get this.
same here...  and for every similar case below plz :)
You're right. I hadn't thought about that case. Let's just disregard my comment, I guess.
This assert needs to go in the try section or pyflakes complains. I would also leave the pyflakes comment since it's not super obvious why the assert is there
Why? It seems like a pretty convenient function?
Oops, it was screwed accidentialy by ide when I was building project first
time. Just missed this mistake.

On Aug 2, 2012 10:19 PM, "Randall Hauch" <
reply@reply.github.com>
wrote:

> @@ -20,6 +20,19 @@
>           Define the dependencies. Note that all version and scopes
default to
>           those defined in the dependencyManagement section of the parent
pom.
>       -->
> +    <build>
> +        <plugins>
> +            <plugin>
> +                <groupId>org.apache.maven.plugins</groupId>
> +                <artifactId>maven-compiler-plugin</artifactId>
> +                <version>2.3.2</version>
> +                <configuration>
> +                    <source>1.6</source>
> +                    <target>1.6</target>
> +                </configuration>
> +            </plugin>
> +        </plugins>
> +    </build>

Our parent POM uses the JBoss parent POM, and should already be at 1.6
compatibility. Why was this needed? Was a different version needed? If so,
do you recall why?


---
Reply to this email directly or view it on GitHub:
https://github.com/ModeShape/modeshape/pull/465/files#r1296110
I can't imagine there was a use for that
The change in debugstyles? It's just a matter of preference, avoid a couple of useless cpu cycles spent in assigning 2 values one after another to a variable when initializing it.
What's a freaking litteral section, literally ? ^^
опять три буквы Vec
Check this. + add WIKI for Serializer coniguration
Neither Apache neither Nginx configurations have this problem: if you request `foo.1.png` you get that file.

https://github.com/h5bp/html5-boilerplate/blob/master/.htaccess#L395
`RewriteCond %{REQUEST_FILENAME} !-f`

https://github.com/h5bp/server-configs/blob/master/nginx/conf/cache-busting.conf#L9
`try_files $uri $1.$3;`

Means that they check the file requested before trying to rewrite the URL.

But, in order to check if the file exists or not we have the paths of the public resources.
This really seems unnecessary. Not bad, I guess, but totally unnecessary.
Oops. I'll just revert the comment.
Note that you can no longer access the registers of the AppleToo directly, you need to go through the CPU object
Do we need a test for this?
I'll change it back.
Should mix-case this: `principalIds`
should 'be equal to the associated mi_plan production centre name if it has not yet been set' do
Ew...please no. @narfgb clarity is better than byte size, please.
Да, это имеет смысл, спасибо. Поправил.
Это должен быть массив заменяемых индексов массива днк, чтобы метод next выдавал рандомный, но не повторяющийся новый индекс на замену. Где-то надо хранить эти значения.  

Я понимаю, что наверное можно определить эту переменную в классе cell и использовать в категории, но как то не верно когда переменные используемые только в категории объявляются в самом классе.
percentToMutate - это процент, поэтому надо посчитать количество ячеек, которые нужно заменить. А сейчас значение этой переменной используется как количество ячеек.
Полагаясь на случай, трудно предугадать, сколько раз будет выпадать одно и то же число. Ясно дело, что при небольшой мутации это будет незаметно, но при большом массиве и мутации в 100% будет не очень комфортно.
Здесь програма будет вываливаться с ошибкой, так как, если случайное число numCell уже есть в масиве, то програма ничего не делает и переходит к следующей ячейке.
Don't leave these in here.
Put this condition together with the other condition with AND
This should be ```$this->assertEquals(2, $offer->links[0]->referencedDocuments->count());```, right?
This seems incorrect. I would've expected `@[ @2, @3, @3 ]`, though I understand the rationale behind this implementation.

I think we should document it better either way.
@Coneko Good find! `CurrentThreadScheduler` does seem to have that behavior: https://rx.codeplex.com/SourceControl/changeset/view/ef6a42709f49#Rx.NET%2fSystem.Reactive.Core%2fReactive%2fConcurrency%2fCurrentThreadScheduler.cs
This test is not actually testing anything? Can you add a check to see if the songs we get back are actually songs with a 'christmas' type?
Does this work? How can you make a branch from master if you don't have a master branch locally?
See comment for line 21 of test_browser_blocking.py
I wouldn't use special characters like "/" here. Stay on the safe side and don't risk it being misinterpreted. Say Concept.error.notAtLeastOneNonBlankDescription
Why do we need to change these to `def`-s?
We don't currently have any support for Python 3, so we probably shouldn't list it in the tox file. If you could fix that up, I'd be happy to merge this. Thanks for the patches!
s/  This/ This/
Oh d'oh, I thought you meant it should list the defaults :)
you can use the "#expects" method, to check for given parameters as well.
Here's the [doc](http://gofreerange.com/mocha/docs/Mocha/Expectation.html#with-instance_method)

not 100% sure if this will work, but worth a try:

    FileUtils.expects(:chmod).with() { |permission, path| permission == (perms&~01111) }
Фонон говно и я блевал его юзая
Э, щито, какой shared_ptr, зачем его убирать?

Пусть PlayerTab обладает иконкой так же, как обладает Player'ом. Такая
архитектура гораздо более скалабельна и ужата — обладание не
размазывается по всем личкрафтам.
Me causó algunas molestias que la página se termine justo al final de los elementos. Claro que hay formas más elegantes de arreglarlo, como un padding o algo así, no?
The original check compared ```declsize < initsize``` your code ```typesize < initsize``` is that intentional?

And getTargetSizeConst seems to be in bits, so it has to be divided by ```BITS_PER_UNIT```.
And the whole code needs to be moved down below ```relayout_decl```.
Readability nit: comments should be full sentences with periods at the end.

     # Ensure they are in proper format. (Recovers from old settings.)
Only changed strings must be included. I'll remove it later.

Btw: Why do you have "st" for "ft" Slovak language?
Why do you need synchronized here? After doing the get, you could call putIfAbsent instead of put to guarantee that there's still no adapter. If you found there's an adapter, it would do nothing.
I can't tell from the innerGet method, could you post an example stack trace with the current code?
Galder, as requested, here is the clarification about the use of Self
You're right, I just pulled the patch - as it is it's too much of a hack. We'll use this locally for the time being, and come up with a more comprehensive solution. 

Thanks for the input.
As above, this should be `STAssertEqualObjects`.
Typo. Therefor -> Therefore. (if your interested, therefor is a proper word, but would not be correct in this case: http://walkinthewords.blogspot.co.uk/2009/04/therefor-vs-therefore.html)
you need to use [@functools.wraps](http://docs.python.org/library/functools.html#functools.wraps) here. It does more than just name, things you might need for nose's test discovery, etc.
@mgutz Yeah, it would be great if you could look / address this issues asap :)
I understand where you're coming from with this change, but am curious: with sap-ui-core.js in the same directory, does that imply that all the rest of the sapui5-static/resources files are in that same root-level directory alongside this HTML file? I want to get to a situation where we can have the resources held in a single (abstract) place. Or am I missing the point? 

(Hmm, perhaps we can get SAP to host...?)
The rest of the file doesn't put spaces between the letters either.
Better to remain consistent on a file level, no?
If there is no good reason for that pattern it should be changed throughout the widget.
I think it would be best to just leave this line for groupId out. I don't see this done anywhere else in JSDocs and it makes things less flexible.
something is wrong with indention here...
This was on your pull request, so I didn't touch it, but you're right. Would you like me to change this?
Yes, should have clarified that it was my personal preference on this one. Not everyone use IDEs that do type inference for you so having explicit checks like this can help a little when browsing code.
Is `674` a fixed number associated with uptime?
typo: permanently
should not use $_POST here?
oh totally, didn't see this, thanks
Warum gibst du eine `List<BeerModel>` zurück wenn eh immer nur ein element drin ist?
Pätterns!
wouldn't that be overcomplicating things, only thing is add/remove opacity. Parsing/building all other properties with all kinds of other types of filter properties sounds hard.
This should be <!DOCTYPE dialog
Okay, then I understand your change. Thanks.
I would add here a test if notification is not already marked as read. So that we do not do unnecessary calls to the server.
Please check if form is XHTML valid.
I would do:

```
{% load i18n %}{{ EMAIL_SUBJECT_PREFIX }}{% blocktrans %}Confirm your e-mail address{% endblocktrans %}
```

Pass to the context:
 * SITE_NAME (somebody could like to write that in the subject)
 * EMAIL_SUBJECT_PREFIX
 * user object (somebody could like to address the user in the subject)
 * request object (to be able to maybe display the IP of the request)
 * CONFIRMATION_TOKEN_VALIDITY (to tell how long you have to respond, in the subject)
Move this to the module, make it a module-level function!
(Use only `'`.)
I would simply not have two forms for *info*. *UserPersonalForm* and this is it?
Do you really need to use acronym? `OpenStreetMap` would be much easier to understand.
`request`??? What is this?
I think it (maybe) doest not worth the effort
Changes are very localized and the cost of performing some sparse extra ifs
are pretty much the same of calling virtual methods.
Maybe in terms of organization it worths ? Need to discuss more.

But what about the features, will us just follow the xna reach
funcionalities ?

Thiago Dias Pastor


On Wed, Feb 29, 2012 at 4:06 PM, Christopher Chambers <
reply@reply.github.com
> wrote:

> > @@ -65,21 +65,49 @@ internal void Apply()
> >               {
> >                       GL.BindBuffer(BufferTarget.ElementArrayBuffer,
> ibo);
> >               }
> > -
> > -             public void GetData<T>(int offsetInBytes, T[] data, int
> startIndex, int elementCount) where T : struct
> > +
> > +        public unsafe void GetData<T>(int offsetInBytes, T[] data, int
> startIndex, int elementCount) where T : struct
>
> I can't say for sure without knowing more about the code, but it might be
> possible to eliminate most of the 'ifs' by using a variation of the
> [Strategy Pattern](http://en.wikipedia.org/wiki/Strategy_pattern).
>
> For example, we could have an internal abstract class,
> GraphicsProfileBehavior.  And then HidefProfileBehavior and
> ReachProfileBehavior implementations that actually do the work.  That way
> you create the right kind of behavior object when the user chooses the
> profile they want, and eliminate the need for if statements to be
> throughout the code.  All the differences would be isolated into the
> behavior of those two classes.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mono/MonoGame/pull/324/files#r502927
>
A better way would be if the existing algorithm is improved so it may never return consecutive numbers (the same way it doesn't return duplicates).
DoCast(embraceTarget, DUNGEON_MODE(SPELL_EMBRACE_OF_THE_VAMPYR, H_SPELL_EMBRACE_OF_THE_VAMPYR);
damn those parenthesis.
+delete targets;
Good call, I'll have it fall back safely if we can't build the lock.
On Nov 10, 2012 2:33 PM, "Moxie Marlinspike" <notifications@github.com>
wrote:

> In src/org/thoughtcrime/redphone/call/LockManager.java:
>
> > @@ -42,6 +55,9 @@ public LockManager(Context context) {
> >      PowerManager pm = (PowerManager) context.getSystemService(Context.POWER_SERVICE);
> >      fullLock = pm.newWakeLock(PowerManager.SCREEN_BRIGHT_WAKE_LOCK | PowerManager.ACQUIRE_CAUSES_WAKEUP, "RedPhone Full");
> >      partialLock = pm.newWakeLock(PowerManager.PARTIAL_WAKE_LOCK, "RedPhone Partial");
> > +    proximityLock = pm.newWakeLock(PROXIMITY_SCREEN_OFF_WAKE_LOCK, "RedPhone Incall");
>
> I'm just worried about it changing.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WhisperSystems/RedPhone/pull/60/files#r2091608>.
>
>
this line will break the function for non-queryset iterables, so it needs to go back in the ordering code below
scheme/schema
The cgi script name is actually in lower case.
unnecessary spacing:

    editor = child_process.spawn (process.env.EDITOR || "vi"), [filePath]
Ah, right.  I can change it to support the nulls.  I may just pull the whole map copy all together and just return the map.  As it stands, the parser.isNestedJson will always be false (b/c the parser is always the DEFAULT), so the map is being returned at line 66.  This is an artifact of my not being able to get the nested support to work from here (the JsonStringToMap eval func).  So, I can pull it until I figure out how to get nesting to work correctly.
The cost of a single len is huge as we have to retrieve all. But i think it's ok as no other redis call may be done after this, the results being stored in _collection. 
But if we only need the count, it's huge (with stored temporary results set, a call to scard would be a very light and quick call)
was duplicated for some reason...
nitpick, if we want to go all the way to PEP8, we need to start with an uppercase and remove spaces:

"""Manage processes."""
That sentence doesn't mean anything.
Nope. It was used before, and then the callers have changed to not require it. This is to complete that change.
validate whether parsed is empty or null?
probable should not be blank
```javascript
var expires_parts = expires.split(".");
if (expires_parts[1] && expires_parts[1].length < 3)
```
versus e.g.
```javascript
if (!/\..{3}/.test(expires))
```
I think I prefer the shorter one, but do what you want.
`ngx_http_pagespeed_determine_request_options` is called by `ngx_http_pagespeed_determine_options` is called by `ngx_http_pagespeed_create_request_context` is called by `ngx_http_pagespeed_header_filter` which short circuits if `server_context` is null.  There are only three points where nginx calls into us once we're configured and handling requests, and in each of them we short circuit if server_context is null: `ngx_http_pagespeed_header_filter`, `ngx_http_pagespeed_content_handler`, `ngx_http_pagespeed_body_filter`.

Added comment: 4511106
Doesn't this have an implicit acquire barrier?  It always calls ngc_atomic_cmp_set, but the docs on that in ngx_atomic.h are rather dicey.
I see what you mean. Unfortunately it's the same error whether you decode it or not because the json library calls the same decode method.
I think I prefer if we can avoid lowercase L in class names.
I think checking the rank does not help for this. For dummies users could leave out one category for a no constant regression, or keep all dummies and don't include a constant, even in the pure ANOVA case. 
If users use formula and have a more standard/predefined encoding for dummies/categoricals, then we have the information anyway from the formula, (unless users create it themselves as a basic exog variable.)
If you can post to the ML (or here) a full working example that hangs I'll have a look.
Thanks for catching that. I've fixed it.
No -- take a look at the `_setMediaIdAttr` method on `toura.components._MediaPlayer` -- this method gets called when, for example, you do:

```
videoPlayerInstance.set('mediaId', 123);
```

We should likewise create a `_setMediaAttr` method, which will be run whenever you do:

```
videoPlayerInstance.set('media', mediaObject);
```

You can read more about working with attributes in classes that inherit from `dijit._Widget` in [Lessons in Widgetry](http://www.enterprisedojo.com/2010/10/02/lessons-in-widgetry-binding-property-values-to-dom-nodes-in-templates/).
This should instead be 
```item.action.visible = visible```
should be `var c`.
> How is this copyright to 2 sets of people?  I assume we can't GPL this?  Can we even use it?

This code was originally written by someone at Transmeta, and then
modified by John for our purpose.  The Transmeta guys GPL'd it to
begin with - so it is GPL'd.  You can copyright to multiple people,
what it means here is that the changes that John has made are his
copyright and the remaining original code from Transmeta is theirs.
Git logs provide provenance on who wrote what.

We can definitely use it as part of Adopt OpenJDK.  if we want to put
it into the main source repository we'd need to get Transmeta to sign
off whatever the corporate equivalent to an OCA is.  This is probably
more effort than just rewriting the script itself, but IMO we have
more important things to worry about at this moment in time.

regards,

  Richard
And again, this should go to TNLibvirtEntity
I have been preferring assertTrue(CollectionUtils.isEmpty(...)); because logically (IMO) empty list and null are the same, and I don't care whether the implementation leaves it null or fills an empty list.
I thought that for the demos, we were going to use keywords everywhere.  I can see an argument against this for Pixel, but I do think that it would be worth having a comment that general usage for rectangular case is ```xw=, yw=``` but to get a square pixel you need only indicate one number, and it isn't necessary to explicitly name the argument in that case.
Thanks! Pushed...
I agree.  I was mostly just preserving previous behavior in allowing a default.

Unless someone else expresses a preference for defaults, I'll remove them shortly.
nevermind, ignore
`set_default(p1, p2)` is a no-op if p1 is already in the dict, correct?
I don't think this is doing what you expect, if the comment here is correct. This looking for any flags by any user, of this app OR of any of this app's comments. I think the query you want is just like the one at line 2722, above, but with the addition of ensuring that treeId is non-empty.
if (@user.photo) "Change Profile Picture" else "Upload Profile Picture" end
personally i agree with both -- i'm just preserving existing behaviour here.  removing aws-ec2 as default for certain well known regions is fine as a separate issue.
On Wed, Dec 05, 2012 at 02:28:02AM -0800, Raphaël Pinson wrote:
> > @@ -25,7 +27,9 @@
> >  
> >                default: {
> >                  augeas { "setup rsyncd munge symlinks $name":
> > -                  changes => "set '$ctx/$name/munge\\ symlinks' $mungesymlinks",
> > +                  incl    => $file,
> > +                  lens    => 'Rsyncd.lns',
> > +                  changes => "set '$name/munge\\ symlinks' $mungesymlinks",
> 
> Same here (for braces). Is space escaping still required in Augeas 0.10.0?

Not sure, but as it doesn't harm, I'd prefer to keep it
backwards-compatible for those still running older augeas versions.
If I had my way, we'd use a patch for this :-)
Nope. In the migration you can put `:default => false`

Right now, you can create a new migration an use the [change_column_default](http://api.rubyonrails.org/classes/ActiveRecord/ConnectionAdapters/SchemaStatements.html#method-i-change_column_default) method. Maybe, something like

```ruby
def self.change
  change_column_default :users, :approved, false
end
```

will work. With the `default` in the database, you don't need to initialize the value in a `before_create`
I thought I did!
I blame git add -p with to many unrelated changes :D

Fixed now
Change this property to return the text of the html element that will contain this no_results message. Then from within the test we will assert that this text is the expected text or not.
Hmm .. another idea, maybe dumb ... this class's responsibilities are so minor, I find myself wondering: does it even need to exist at all? For instance, what if FeatureConfig had this loop in its self.read method?

KNOWN_FORMATS = [YAML]

if File.exists?(something)
  raw_data = File.read(something)
else
  raw_data = something
end

parsed_data = nil

KNOWN_FORMATS.each do |serializer|
  begin
    parsed_data = serializer.load(raw_data)
  rescue Exception => e
    #not supported by this serializer, apparently
  end
end

unless parsed_data
  raise ArgumentError, "Cannot parse configuration data; it must be in one of the following formats: #{KNOWN_FORMATS.join(', ')}"
end

parsed_data
Good point.  That will have to be a follow-up.  I don't run Cygwin or MSYS on my windows box.  Think you could take that one for a stroll?
nice - crazy europeans
Yeah forgot I was in AS world
тут би щось мало падати? змінна вже не так називається
/[0-9.,]/ или /[\d.,]/ - достаточно
Don't get obsessed w/ purity. At some point your program is about side effects and this is it. You're just making your program less efficient by piling up a giant string in memory to print all at once.
Let's hide these kind of things. Users don't need to know what's `getaddrinfo`. `"Failed to resolve address %s:%d", host, port`.

Also, note that @arrbee changed the giterr API. If you set a `GITERR_OS`, the strerror will be appended automatically.
Readd this line.
But `gfortran` is not a MPI compiler. If you need this, then make `open-mpi` a dependency and set the compiler to `mpif77`.
Yes, in the commit I mentioned above.
Makes sense to me. It's actually not the proper way to read a quadtile when the quadtile is presented as just a binary value with a zoom level. In this case, the bits are interleaved between what is referred to as x and y.
WebSockets only work in modern browsers, so I guess we can use normal API here.

```javascript
var links = [].slice.call(document.querySelectorAll('link[rel="stylesheet"]'));
links
  .filter(function(link) {
    return link != null;
  })
  .forEach(function(link) {
    link.href = cacheBuster(link.href);
  });
```
This should be done inside `lib/better_errors/error_page.rb` where the CGI constant is actually used
Крайне не желательно объявлять обработчики в HTML `onclick="CreateCalendar()"` see `addEventListener`
Это не читается :)

```javascript

var items = this.items.sort(function (Event1, Event2) {
    return Event1.rating - Event2.rating; 

}).reverse();


return new Collection(items);
```
Не пойдёт. Должно отображаться в разных локалях по-разному.
У метода с ```@Collect``` не должно быть int/long параметров.
The name here isn't very revealing - what's the purpose of this? Just to check if something succeeds? What is succeeded? Why should it succeed?
If you think of wkhtmltopdf.subprocess as a compatibility module for Python 2.7's check_output, then it makes sense to load everything from the standard library into this module.

This way, when django-wkhtmltopdf requires Python 2.7, the code cleanup involves: removing this file, and changing the import statements trivially.
Same superfluous code in this change, too.
You may ignore it. Only for better performance.
上記の例では@SimpleController@のテストとモックとして振る舞う@Simple@ドメインクラスになっています

↓

上記の例は@SimpleController@のテストとモックとして振る舞う@Simple@ドメインクラスをテストしています。

日本語の係り結びがこちらの方がよいかもしれません。
all over it.  spanks. :)
Let's add comments to the docstrings to reflect the default value.
Just leave the `inline` directive in the pyx files.
this 0.09 raises a red flag but maybe in practice it's good enough.
BSD like scikit-learn would be the best.

By the way, since the data is artificially generated, you could alternatively recode the function and put it in the sample_generator module.
The prototype is available here:
https://gist.github.com/3188143
We agreed to take it as gold standard for now.
On Fri, Nov 09, 2012 at 08:49:08AM -0800, Olivier Grisel wrote:
> Could you please include both test cases? I think the old test with the tie
> should still pass

It should fail: it was a mistake on my side.
The indentation for i_size seems to be a bit misleading here.
You're using the 1.9 hash syntax here, but VCR still supports 1.8.7...
I copied the TkCheck (instead of importing the python formula).
Just had a thought: what if we add an array here as a list of properties whose defaults we don't want to see?
I'll try to do that as part of TIMOB-10713
Throw an exception. Same for the others
`iscus` ?
It can be.  At one point I though I could use buildStmt(assign), but I can't because the self selector doesn't match.

I'll change.
cur would never be == end, since it's the condition of the loop.
This is to silence the compiler warning emitted about the lower variable 'x' and 'set' shadowing these bindings. One of the modifications I made was to turn on -Wall
Are you ok with not handling case of operational_timeout_in_seconds = 0?
I mean, that would fall through and raise here.
I copied my test from the `VcsTest` – it's where the namespace is from. Should I address this only in my testcase?
Yes just one or none.
I found this slightly hard to understand. It may be clearer to split across keys and strings, vs red and blue.
funktion on tarkoitus palauttaa aina yksi kirjailija, joten tätä viimeistä elseä ei tarvita. Lisäksi `first` palauttaa `nil` tyhjille sekvesseille.
What's the purpose of this? PuppetX::Puppetlabs::Razor is a stub, by the looks of things
Suggestion:


    Spatial moments up to 3rd order.
        m_ji = sum{ array(x,y) x^j y^i }
    where the sum is over the `x`, `y` coordinates of the region.
I think `img_as_float` should be applied on the whole multichannel image, otherwise the scaling might be different for different channels
@thewtex I wonder whether this test was safe to begin with.  Should we add a margin for error to be sure?  Especially if we convert from float, I guess those values could end up going up or down one?
Roger. I didnt like this hack, told that to Sande just before commit :)
Sorry, haven't had enough caffeine yet. :)
Should this be Cartesian3 instead of 4?
How often does `transformChanged` being true?  Could we save 3 branches by having this and the next 2 `if` checks wrapped in a single `if(transformChanged)` check.  If it's usually false, that causes this code to be 1 `if` most of the time instead of always 3.
lol.  Yes, it is.  Don't know why I thought we were doing `1.0 + 1.0` here.
Not a nit - Equals shouldn't throw. Check types explicitly and return false if they don't match before casting.
use kLauncherViewDefaultColumnCount
Failed on validate.py. Here should be type: Titanium.Blob
oh k now that make sense. i got  confused there.....
Needs to be more precise, please.  "...modification of existing contacts is currently not supported, whereas the creation of new contacts and the removal of contacts are supported."
Here's a ```new```. Don't we need a destructor with ```delete```?
spelling... must *have* a static
the core bug issue is that winows to a linux server did not work properly and had the wrong direction separators. I would argue that hostIsWindows should remain for now in case it turns out the dstore behavior is different. I'm not willing at this time to guarantee that this is unncessary.
Обычно что-то такое генерируют `uploadcare-dialog-open`, или такое `uploadcare:dialog:open`. 

Меня смутило что мы добавляем теги при генерации события. А их по задумке нужно добавлять только при подписывании/отписывании. Я даже и не знаю что будет если добавлять при генерации. Видимо ничего страшного.

Но при подпиывании будет не однозначно:

```javascript
$(...).on 'uploadcare.dialog.open', handler
```

Толи подписались на `uploadcare.dialog.open`, толи подписались на `uploadcare` и добавили два тега `dialog` и `open`.
давай подумаем: вот эти адаптеры (я бы их переименовал в "табы"), они вообще нужны как классы? выглядят они абсолютно как "инстансы". я думаю что табы стоит добавлять с таким уровнем сложности

    tabs.addTab ('facebook')

тем более у яваскрипта куда меньше разница между классом и инстансом )
Стоп. Если ты подпишешься как `click.myTag`, то ты не получишь все клики. Только те, которые будут с этим же неймспейсом.
Oh, and yes, I find `setInitialState` to be less than ideal as well – make it `setToInitialState` at least…
This is called with a Collection or an array *everywhere*. Let's avoid variadics and the redundant allocation of arrays.

It's also only ever called with a comma for `delimiter`, so I suggest instead:

```
public static String toDelimitedString(String delimiter, Collection<String> items) {
  if (items == null || items.size() == 0) {
    return "";
  }

  StringBuilder sb = new StringBuilder();
  int i = 0;
  int c = items.size();
  for (String string : items) {
    sb.append(string);
    if (++i < c) {
      sb.append(delimiter);
    }
  }
  return sb.toString();
}

public static String toCommaSeparatedString(Collection<String> items) {
  return toDelimitedString(", ", items);
}
```

and then using `toCommaSeparatedString(coll)`.
is this really an append and no replace operation?
Why an option? Before my work, you only got a log statement that you had to do it manually. It's not an option on any of the Linux flavors either, so why should it be on Mac?
@andrewdavey said this shouldn't be called anyway on `IsolatedStorageFile`.
i didnt know what was in buttonElements.bcls so i was hesitant to move it in case it has ui-link in  it
Well, does phing itself relies on the include path, or is it only Propel assuming that Phing is in the include path ? In the first case, it should be done by phing in its composer.json
Do not even attempt to parse the xml encoding
Yeah, it seems to me too that this would be an item to tune in the framework. Not a big priority though at this moment.

Please review once more.
Maybe just use ``if (!$groups)`` here to also reset the strategy when an empty array is passed.
ups. well, i said its work in progress...

the changes to the router should come later once the route is sorted out.
Le constructeur spécifie la capacité de la liste, mais pas sa taille. La différence est que tu peux avoir une capacité de 8, si tu fais un get(4) tu auras une indexoutofbounds exception, alors que le setSize(8) initialise bien une liste avec 8 objets placés à null.
Can you change `click` to `on` throughout the widget?
"Overriding strategy to be ... "?  The log message you're printing out reads like an instruction that the user needs to override the strategy, not that it is being overridden.
Here is the reasoning :

As Andrei said, accessing a field of a null reference will trigger a page fault at address 0 + offset of the field. This is why linux kernel specifically reserve memory at 0 to detect null dereferences.

I see a point in discriminating null dereferences and other pointer errors. In the current state of D, you can dereference null really easily almost anywhere. Other memory errors are result of memory corruption.

The *(cast(ubyte*)0x100) = 1 is not a good example IMO because it is artificial. Pointer come from allocated memory, not constant that you cast. And no memory is ever allocated at 0 by the linux kernel.

As a result, you only trigger the NullPointerError on dereferencing null, or by building thing specifically to trigger that behavior, like @klickverbot did.

A NullPointerError is something you should expect to see on a regular basis, considering how D is done. Other memory error is something that must scare you very much because it means somewhere you have corrupted memory.
s/`DEFERENCE`/`DEREFERENCE`/g
Maybe ```union siginfo_data_t``` ? :-)
Were you not able to move this receive inside the while() ??
s/~~its~~/it has/
It is very important to adheir to the Java nameing guidelines, and make this a lower-case "queryString".
Our coding style says that we prefer to always use var {variableName} = {value} versus multiline declarations.
опечатка "содерживмое"
s/hosts/sites/ (I'll make this change on merge)
I'm not sure I follow this, what's super calling here?
Thanks.  It's definitely doing too much with the Dealer's Hand.  After I submitted this I started the same exercise from scratch to try and BDD it with cucumber.  This was fun.  Enjoying the course so far!
if you do 
ini_setting {'puppetagentruninterval':
    ensure  => present,
    section => 'agent',
    setting => 'splay',
    path    => '/etc/puppet/puppet.conf',
    value   =>  true,
  }
 for example
I discussed with Raul this morning since our first idea (use the NAT IP address) is not the best one as Vivo folks told us.

I think we should add the IMSI number into the registration process. Since de IMSI includes the MCC and MNC (country code and network code respectively) we can map which OB is the owner of the line.

It has no incompatibilities with the desktop since the don't have SIM card so the can not be connected to the 3G network directly.

see: http://es.wikipedia.org/wiki/IMSI
see: http://es.wikipedia.org/wiki/Mobile_country_code
see: http://es.wikipedia.org/wiki/Mobile_network_code

Of course this mapping table should be on a MongoDB collection

WDYT?
similar to a comment in #30 ... instead of comparing strings, compare actual Result objects, e.g. `new Result("not found")`
Should be `TryIntersectRayPlane`.  I understand you're trying to avoid the redundancy with the class name, but as it is now you're missing a verb and it leaves me wondering what it means to ray a plane.
add ``js`` to have the syntax highlighting
Thanks :laughing"
You should document the expected config
"===" unless you are depending on coercion
OCD, fix the indentation below. Also, I'm a much bigger fan of two spaces rather than four, but I'll try not to get too crazy about that. :-)
Beginning with...

...intent (not intend).
При конкатенации огг с изображением в поле файла, автоматически добавлять тег в текестовое поле.
I think these should be static public functions within FileTransferCurl.
Why is this a class variable?
same again here