labofsahil/github-event-dataset-2012 huggingface dataset:
Okay, ternary condition changed.
Needs a global.
I was joking :-)

On 14 Nov 2012, at 11:25, Erik Frèrejean <notifications@github.com> wrote:

> In phpBB/includes/api/api.php:
> 
> > +		$result = call_user_func_array(array($this, $func_name), $this->args);
> > +		$this->handleOutputData($result, $format);
> > +
> > +		return true;
> > +	}
> > +
> > +	/**
> > +	 * Handle output data - turn array into string of something like JSON or
> > +	 * XML and then output it.
> > +	 *
> > +	 * @todo: Hook for adding other output formats.
> > +	 *
> > +	 * @param array $data Array of data to handle.
> > +	 * @param string $format Format to turn the data into.
> > +	 */
> > +	protected function handleOutputData($data, $format)
> http://area51.phpbb.com/docs/31x/coding-guidelines.html#namingvars
> 
> —
> Reply to this email directly or view it on GitHub.
>
I've rewritten everything to use dependency injection instead of the container.
Why the change in indenting?
Since you handle errors in a non-silent manner immediately below, I would say errors here should also be handled in a similar manner.
Same as with previous function, what is "avatar"? This description should explain to someone reading the documentation what the function returns.
Self-note: this line is likely left over from some previous code, but because I don't see it being used, it should probably be removed.
I find this name kinda confusing. Talked with @rphillips on the IRC, apparently initial connection delay is still 0 and this value actually specifies a first re-connect delay.
Is this the only requirement?
Might be able to squeeze a bit more out of this by not checking medium and lowest repeatedly. I think these checks are going to do implicit Boolean conversions with each iteration.
@jgoz If it is a long running task, then it is generally recommended to use `TaskCraetionOptions.LongRunning` as it will allow the ThreadPool to continue to process other tasks without considering a worker 'slot' to be in use (as the long running task may be on a separate dedicated thread). That being said, you want to use `TaskCraetionOptions.LongRunning` with caution as you don't want hundreds of long running tasks.
what is this space?
>>      ./configure --with-qt4-dir=${qt4} \
>>        ${optionalString (!javaBindings) "--disable-java"} \
>>        ${optionalString (!pythonBindings) "--disable-python"} \
>> -      --disable-pulse --disable-hardening \
>> +      --disable-pulse --disable-hardening --disable-kmods \
>
>Well, I guess that commit is somewhat unrelated to this pull request, so I'm going to rebase/remove the commit and maybe bring it up as a separate pull request. And it's kinda useless anyway, as we might be better of to build a derivation depending on the kernel to provide a more real, out-of-tree scenario.

Personally I think that given VirtualBox size, building one main binary
and one set of modules per kernel may make sense anyway.
The admin username, password cannot be in code.
I do realize that we need some kind of daemon user to kickstart the app and the initial POST, but definitely not the admin
Probably don't want too many console.logs
Will eventually want to abstract these out to constants in resources/scripts/page_enum.js -- however, since these views are a bit temporary, okay for now.
I suggest you use line continuation here rather than ```+=```. If you use field names in the format expression i.e:
 ```
msg = 'Failed to create {cf_name!r} dimension coordinate: {e_msg}\n' \
      'Gracefully creating {cf_name!r} auxiliary coordinate instead.'
msg.format(cf_name=str(cf_coord_var.cf_name), e_msg=e_msg)
```
you don't need to provide the name variable twice.
I went with issue not bug partly for that reason.
Does this work? My previous comment was more wishful thinking (I should have made this clear) as I didn't think we had implemented the coord metadata property yet. I know cube was done, but I thought coord still used ```_as_coord_defn()```.
"Has PyCUDA already initialized the GPU context"?
Use sizeof(msg) rather than 1024 om this line so we can change our minds in one place.

Put single quotes (the SQL standard quote) around the %s content part of the message, for readability. 
(What if docChars contained "This perfectly valid JSON"?)
Don't forget to patch expected output in unit tests.
But **because of changes in that pull request** it has to be removed because it is now useless.
correct order, as pep described or use my sublime text plugin for it 

https://github.com/vi4m/sublime_python_imports
In the future we may want to merge these with `Opts` in case we want to tweak the level options used for AAE.
The stars here aren't needed
noAnnouncedJobsAreMadeByTheCompany() ? I can understand nothing from the test name.
Err we don't do this? Both give [<<"page">>].
This function, that is a nice abstraction, implements a quite complex visiting logic.
A proper testcase containing unit tests for the two different cases (with and without a complete_logic_tree_gmf) should be added to this change.
Is this separate overload for static operands actually necessary? It should be covered by the following overload.
We should not accept double arguments but then bail if a value is not integer. The argument should simply be changed to integer.
We just use PG_TRY for the two functions, what do you think?
```
UDF::SRF_invoke(FunctionCallInfo fcinfo) {
    FuncCallContext *funcctx = NULL;
    MemoryContext oldcontext;
    bool is_last_call = false;
    bool is_first_call = true;
    AnyType result;

    MADLIB_PG_TRY{
        is_first_call = SRF_IS_FIRSTCALL();
    } MADLIB_PG_DEFAULT_CATCH_AND_END_TRY;
    
    if (SRF_IS_FIRSTCALL()) {
        /* create a function context for cross-call persistence */
        funcctx = SRF_FIRSTCALL_INIT();
        oldcontext = MemoryContextSwitchTo(funcctx->multi_call_memory_ctx);

        // we must construct the argument here, since it needs SRF_FIRSTCALL_INIT
        // to init the pointer: fn_extra
        AnyType args(fcinfo);
        args.mSysInfo->user_fctx = Function(fcinfo).SRF_init(args);
        MemoryContextSwitchTo(oldcontext);
	}
        
    MADLIB_PG_TRY{
        funcctx = SRF_PERCALL_SETUP();
    } MADLIB_PG_DEFAULT_CATCH_AND_END_TRY;

        // the invoker function will handle the exceptions from this function
    result = Function(fcinfo).SRF_next(
        static_cast<SystemInformation*>(funcctx->user_fctx)->user_fctx,
        &is_last_call);

    if (is_last_call)
        SRF_RETURN_DONE(funcctx);

    SRF_RETURN_NEXT(funcctx, result.getAsDatum(fcinfo));
}
```
Since finding mongo is written the Linux way, we simply ignore the error for now.
This has now been changed. Only methods directly on the exported objects are exposed, and not methods on attributes on exported objects. Thus, lookup of methods is now done using the objects map directly.
This line causes the tests to fail, because there is no common.py in [this branch](https://github.com/sergiocharpineljr/ispdb/tree/bug_526469/ispdb/tests).
Why the extra <p> here?
Use `models.CSSRule.objects.create(...)` and then you don't need a separate save
Tiny a compile time as normalize has, we prefer to let build systems run parallelized if they're able to. We only use `ENV.j1`/`ENV.deparallelize` when we've actually run into problems.
Can you force it to put its dotfiles somewhere else?
*smacks forehead* D'oh! I was in "package developer" mode and completely forgot what I was writing.

I have lots of experience writing RPMs (I was the Sr. Build Engineer for TurboLinux (RIP)) and I've packaged for Debian and things like the Zaurus project, etc.  My "package" habits just took over.

I'll fix it now.
code de debug ...
This comment states the obvious so from now on it shall be known as: **Captain Obvious**
Added [comment](https://github.com/site5/moo_moo/commit/442b1089386ca6e6a68459031119544e52e3da5a#L4R3)
Maybe not, but should the enter state event fire after the actual event fires?
I made those classes nested because they really aren't intended to be used for any other purpose. They collectively define the internal data structure that MemoryTableContext relies upon. I could've written the entire thing in terms of dictionaries and lists, but that would've sprinkled duplication throughout the code.

Would it reduce confusion if I added some kind of explanatory note?
I look for "overviews" like this at the top of files, so I think it should be moved to the top. I guess some people may go straight to the bottom to see the public API, so maybe a snmall comment that says "see comment at top"?
And also we may still need it for unit testing. Otherwise, it is hard to verify the key binding APIs.
Um, so I just tried the feature and I can't do CMD+A to select all. I have to drag a selection and CMD+C to copy out of the textarea. Is there anything better we can do?
I added it to the Missing features list.
There's a lot of duplicated code here that needs to be refactored into a single resizer class. There are several other extensions (and I expect more to come) that also use the bottom panel adn would like to have this same functionality:
- https://github.com/cfjedimaster/brackets-csslint
- https://github.com/cfjedimaster/brackets-jshint
- https://github.com/cfjedimaster/brackets-w3cvalidation
Ok, I'll bite :) Actually, it turns out it's used in the XQuery extension. And it may be used in other places. but a deprecated message could work, sure. I wouldn't recommend that in all cases, but this particular method has been annoying me forever.
Roger. Seems okay. Can you rebase this change, please?
ajouter un groupe supérieur dans la config propre à chaque provider

```dcc_tracker:
  google:
    account_id: ...```
it is under appstore/partials. Doesn't seem like you need to use the full path
Not a workaround. Should I have surrounded it with try, except ZeroDivisionError ?
yeah, actually, both cases are returning a sumvalue, so i think i can combine, i updated it to almost exactly that, verifying now that it works, and will update.

SumValue calculationValue = (SumValue) valueService.getCalculationValue(calculation, location, period, types);
		if(calculationValue != null){
			if(target.getAverage()) value = calculationValue.getAverage();
			else value = calculationValue.getValue();
		}
Please put such brackets on the line of their if. :-)
Ok, no. Sry. Forget that.
Of course also for other values we are passing to JavaScript.
(We do not have to remove it, you just have to fix it.)
Continue to use double-quotes if you can, please.
I like the idea of calling `spawn()` and it opening the dialog for us, I think that's awesome. I think the setTimeout bothers me because 10 milliseconds just seems like an arbitrary number and gives us no guarantee that everything will be ready in time.
I liked the "Edit source" better in the UI concept, personally
Why not use VAR_REGEX?
Do you mind fixing up this vertical spacing?
i'll add to the 'it' description
Since `MultiJson ` does note escape user generated content, is there a clean way to escape `content` in `json.(@message, :content, :created_at, :updated_at)`?
```
When /^I refresh the Agi Database$/ do
  refresh_awesome_db_database_path = "database/start_stop/refresh_awesome-db_database_page"
  full_path = File.join(VCR.configuration.cassette_library_dir,refresh_awesome_db_database_path) + ".yml"
  sleep 400 unless File.exists?(full_path) # it's what it takes to instanciate a RDS instance. This is only necessary when recording it with VCR
  VCR.use_cassette(refresh_awesome_db_database_path) { visit database_path(@awesome_db) }
end
```
what does ```s3.get_bucket``` do?  Does it load the bucket into a cache or something?  I would usually expect a method like that to fetch data and return it as a return value, which is then used later.  I expect this works fine but I'd be interested to know why the ```get_bucket``` call is necessary.
is this new param used anywhere?
Could just use the CoreClient in constants instead?
А! Я решил, что ты про абзацы. Теперь понятно. Сделал.
> neodpovídá aktuální funkčnosti,

???

> navíc jde o popis tlačítka.

???
There should be space before the brace
I see this a little confusing:

katello system add_system_groups
katello system remove_system_groups

maybe this looks nicer:

katello system add_to_group
katello system remove_from_group

It could still accept a list of groups, but I expect users to assign one group more often. Just an idea.
I would break these operations into functions so that you can look like you're not an amateur
huh, I thought I fixed this.
Yeah, makeRecord is never supposed to be called directly.
Perhaps this should be something like `format_equivalent_units` and have it *return* a string rather than printing one?  Then the examples can just be changed to ``print(format_equivalent_units(...))`` and it then becomes possible to programatically use the string this produces...
No, I've removed it in #1112. It does require re-adding that include in other files, though.
The idea was that if it throws an exception it was blackholed (which it shouldn't be since its disabled for the current) action and that would cause the test to fail otherwise it passes. Is a try/catch block preferred with an assertion at the end to test that exception wasn't thrown, a comment, or `$this->fail('Action was blackholed when it should not have been');` inside of the catch block?
Why is `noLayerSelectedMessage` missing?
I don't think a template is the place for all this ruby code. I know that it's mainly setting up strings. This giant switch statement (well, lots of elsifs) tends to indicate that polymorphism is needed here. You shouldn't be checking event_kind, you should have a polymorphic event.
Ah, didn't realize it would do that.  Thanks for the tip.  Should have this committed soon.
we do have a `display_json` in `IPython.display` do we want to write a warning that not many frontend support it ?
ahh ok.  I got it now.  disregard, then.

On Sat, Sep 15, 2012 at 11:11 AM, Ignasi Barrera
<notifications@github.com>wrote:

> In labs/abiquo/src/main/java/org/jclouds/abiquo/AbiquoContext.java:
>
> > +@ImplementedBy(AbiquoContextImpl.class)
> > +public interface AbiquoContext extends ComputeServiceContext
> > +{
> > +    /**
> > +     * Returns the Abiquo API context, providing direct access to the Abiquo Rest API.
> > +     *
> > +     * @return The Abiquo API context.
> > +     */
> > +    RestContext<AbiquoApi, AbiquoAsyncApi> getApiContext();
> > +
> > +    /**
> > +     * Returns the administration service.
> > +     * <p>
> > +     * This service provides an entry point to infrastructure administration tasks.
> > +     */
> > +    AdministrationService getAdministrationService();
>
> No problem, but that AdministrationService is not a direct Api connector
> such as CloudApi or InfrastructureApi. It delegates in strategies to
> perform more complex operations, so I decided to use this named convention.
>
> I took the example from clouds-chef context:
> https://github.com/jclouds/jclouds-chef/blob/master/core/src/main/java/org/jclouds/chef/ChefContext.java
> Maybe it was not the right decision, but I think this *Service classes
> that are more similar to the ChefService than to the *Api ones.
>
> It is ok for me to do the change, but it may be a bit confusing to have,
> at context level, a "getAdministrationApi() (providing strategy based
> functionality), getApi(), getAsyncApi() (providing access to direct api
> calls)". I followed the example from chef context because to me it seemed
> more clear.
> If you confirm these kind of services should be refactored to *Api I'll do
> the changes!
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/811/files#r1613865>.
>
>
It actually converts the template name into the view name, so in this case it's `url('privacy.firefox')`
Huh, why are you moving these around? the "from" imports should come after the straight imports. Check out PEP8 :)
Nit: This is two too many empty lines.
ahh, nope.  you're right.  that was a mistake.  added ALL to it.
As it is passed in the HTTP content (it's a POST here, not a GET), we don't need to urlencode that data.
No, stats.schedule_size and stats.retry_size

On 29 Dec 2012, at 04:31, Brandon Hilkert <notifications@github.com> wrote:

> In lib/sidekiq/web.rb:
> 
> > @@ -214,7 +214,13 @@ def number_with_delimiter(number)
> >      get '/dashboard/stats' do
> >        stats = Sidekiq::Stats.new
> >        content_type :json
> > -      Sidekiq.dump_json({ processed: stats.processed, failed: stats.failed })
> > +      Sidekiq.dump_json({
> > +        processed: stats.processed,
> > +        failed: stats.failed,
> > +        enqueued: stats.enqueued,
> > +        scheduled: Sidekiq::ScheduledSet.new.size,
> Are you suggesting something like?
> 
> stats.processed.size
> instead/in addition to:
> 
> stats.processed
> —
> Reply to this email directly or view it on GitHub.
>
s/may/are/
use ``!``. Symfony uses ``false ===`` only when dealing with some crappy PHP methods returning a falsy value with a different meaning (strpos returning 0 when finding things at the beginning and false when not finding things for instance)
This is wrong. The class-loader is not a hard dependency of the HttpKernel component. Bundles are not the main feature of the component (see Silex for instance). Using the Kernel and bundles requires most of the optional dependencies.
you should do the check against ``'none'`` instead, so that the case where ``getPreference`` returns ``false`` (old IE) or ``undefined`` (no value yet) defaults to showing the toolbar (which is a more sensible default behavior IMO)
`for ($i = $allowableSessions - 1, $countSessions = count($sessions); $i < $countSessions; $i++) {`
Probably want to remove this line, because we don't want to be able to search unverified users.
glad I didn't merge it then.
naming standard as mentioned above
恩，我觉得原则应该是够用就行，不必全，不用细，只要对于写论文过程中可能需要的情况提供解决方案即可
That was the approach I was taking originally, but I don't think it's worth the extra complexity of having multiple config files (and not just a regular config and a logging config, but a separate logging config for each process), especially since many of our users won't be familiar with python logging anyway.

If we start getting a lot of requests for a separate log file for the redis library, we can consider it, but for now I think it makes sense to optimize for "where are my log files?" and "how do I move my log files?", which we currently get a ton of requests about.
Silly question, but why does a dummy artefact need a section tag? I thought this method would be used for e.g. the help page, which isn't in a section?
Check what happens with uncaught errors.
Bonne idée! Je m'en occupe.
Old, and maybe should be inherited anyway?
Do folks have .NET repo's at the root of a drive and not in at least one folder (even on a thumb drive)?  I'd have thought that was an uncommon enough scenario not to bother with an entry for the recycle bin in the general VisualStudio ignore file.
Okay!  Thank you.  

Two things:

1. Is there a way to protect against this in PyVows own test suite?
1. I believe the following rewrite would fix the behavior:

```python
raise VowsAssertionError('Expected topic({0!r}) to be truthy', topic)
```

Which is most certainly doable.

However, if `VowsAssertionError` made use of `**kwargs`, then we could use `key = val` arguments.  This would make code easier to understand (both for the `VowsAssertionError` class itself, as well as `raise` statements everywhere else.)  

Would that be okay with you?
We could do that. I'm sure JDR id's are far less important, at least at this point.
So far we've put this 'global' stuff in the main server/host/domain descriptions
Yeah, this is old and nonfunctional thing.
the proper solution is done as separate pull request: https://github.com/jbossas/jboss-as/pull/2348
Ales, you should remove this infinispan changes from your branch and use that commit.
schema version is 1.4 now not 1.2...
Visibility works fine, but looks a little odd because the text isn't centered anymore and the icons are hidden too.

It also doesn't work well for discoverability (better than double click, which nobody would guess, but hovering to discover isn't ideal either). Lets try opacity.
I think you're missing a `/` here
I thought we were moving Momentum back into the SGD algorithm.
sorry for this mistake
Didn't we already check if 'callback' is provided inside '_transactionCallback' method?
The height and width of msg-list-empty-container are both 100%, this will let that div covers msg-list-action-toolbar.
So users can not click on refresh, edit and search.
Maybe we can put the msg-list-empty-container in just middle of the screen, not the whole screen.
I don’t see the point:
* it would get in the way of developers that want to use `data-*` attributes exactly as a `theme-*` class name would do — there’s no benefit at all here;
* that information is not a *data*, it’s a presentation thing. It should be a class.
is iccInfo.mcc an integer or a string?
Yes, since UX defined this STK message as an alert
Here you can use bind(this) and replace |SimManager.unlocked = true;| by |this.unlocked = true;|
Sorry, disregard the previous comment.

Let's do 

    (summaryRepeat == 'Never') ? 'singleLine' : ''

to prevent misunderstanding like this.
changed to be more readable
delete ConversationListView._lastHeader;
if (!to || !subject)
  return;

And then avoid one nesting level.
this part should be in `quick_settings.js` :P

and the function should remove it self as the listener, so 

    var self = this;
    window.addEventListener('appopen', function hideTray(evt) {
      window.removeEventListener('appopen', hideTray);
      self.hide();
    });
gniiiii
@steveck-chung , if the database is order by timestamp is this sorting needed?
Placeholder is different than a `<label>`. Arguably, it should be, in terms of UX:

    <label for="searchbox">{{ _('Search field') }}</label> <!-- Hide with CSS. -->
    <input type="text" id="searchbox" name="q"
           placeholder="{{ _('Project name, person, etc.') }}">

    <button>{{ _('Search') }}</button>
"." would be sufficient.
I don't like this design. You're mixing the storage implementation with where things are stored on the storage implementation (by auto-rooting every path). It's better if the "where" part is done by Nimbus (as it is now), and the storage interface is just a dumb Filesystem interface. That way another implementation, like an HDFS implementation, doesn't need to know about the "where" and Nimbus can continue supplying that.

This should also make the pull request simpler by moving that logic back to where it currently is in Nimbus. Additionally, I think there are problems below with regards to separators between the storm root and the path, but those will go away after making the above changes.
Der Ordner heißt aber `de_x_sie`.
I used to do this while (null != (line = reader.ReadLine()).   but fowler thought I was some sort of yoda.
this curly bracket should be on the same line than the `if`
I edited that line.  Let me know if that's still a problem.


On Thu, Nov 29, 2012 at 11:29 PM, Dave Moore <notifications@github.com>wrote:

> In src/speclj_www/view/docs/tags.hiccup.clj:
>
> > \ No newline at end of file
> > +  [:code "(describe \"I/O Tests\"<br />
> > +    &nbsp;&nbsp;(tags :unit)
> > +    &nbsp;&nbsp;&nbsp;&nbsp; ;tests with the unit tag will be contained here
>
> This line overflows to the next line and doesn't look good in its
> container box. Can you change that and improve the look?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/slagyr/specljweb/pull/1/files#r2274944>.
>
>
1つ → 1 つ
Should be called apply?
Same as above, and throughout this file.
Looks like you can factor the ul tags outside of the if check since both include them.
This was never used in this build script.
You could do this faster with set arithmetic: `if set(listA) & set(listB)`
Won't this still cause issues when there are multiple versions of jQuery on the page?  I think the only change that needs to be done here is to remove the `true`.  Even then the jQuery library loaded by DebugKit will still overwrite window.jQuery which still feels wrong.
@stloyd could you please give an hint on Composer conventions? I haven't had the time to read thoroughly the docs and the code since I knew about this project two days ago (:

If you have to suggest a message that adheres to Composer conventions I'd very much like to add it ASAP.
please don't add trailing whitespaces (be it here or in the empty lines)
this will need lots and lots of JS tests.  Backbone and jasmine are your friend :)
I mean in theory we coul (or should) also sort Likes and Mentions like this, then we'd have `likes.id` and `mentions.id` there, too.
current_user.projects.find_by_code
If this is used in asm, then it shoudl probably be in asm_defs...
`if` should be outside the `<ul>` as empty `ul` tags are invalid HTML.
Repeated in line 189+?
You're obviously right, thanks.
I'm assuming this was originally just a copy / paste error, but let me know if there was a reason for it.
Looks like q is actually in packages, so nope. FIXME :ambulance:
After reading code of other modules, I'm convinced that you don't even need this module. Just set `error.cfxError = true` on throw or define helper error functions in the appropriate modules.
I still don't get the difference between these both setPBMode methods?
How different is:
`docShell.QueryInterface(Ci.nsILoadContext).usePrivateBrowsing = mode;`
vs
`chromeWin.gPrivateBrowsingUI.privateWindow = value;`
Why are we using different way of toggling private browsing per window in test vs modules?
wasn't immediately apparent that checkSupport itself handles delegation chains.  but it does.  great.
What's the value in separating summary metric calculation into a separate thing, rather than just doing it in the main `run_metrics` function after all the page metrics have been computed for a given revision?
debug.launch is not needed any more. You can delete this file.

Now configuration is done is dynohost/conf and the rest in dynohost/bin/dynohost.
Backslashes for line continuation are ugly. Maybe write it like this:
```python
        return ["%s, %s says you butchered the language with: %s" % (
                    nickname, violation_sender, violation_text)
                for violation_sender, violation_text in violations]
```
@joshcooper updated.
@vrthra can you add a link to where this magic constant comes from?
This should just be changed to a `deprecation_warning` and documented with `@deprecated`.
oops, missed your comment elsewhere which indicated you were already aware of this
@dchelimsky Side note: the implementation of this feature on master is drastically simpler. 

@danrasband Can you please confirm @dchelimsky's question? Thanks.
This seems like it should initially be False, since it's not actually executing until we get an ``execute_request`` message?
Gotcha, my bad
I think "Set up" is two words.
I'll check - it's likely just a fragment from a prior version of the test. I decided testing the escaped value further wasn't worth the trouble so that part was removed.
It's a preference, not a rule. We don't enforce it at all.
Please comment here as to why an empty string is returned (see e.g. assemble method of scheme route).
Why has this been renamed?
This is a Cyan class, and it seemed too complicated to tamper with it. However, the reason they're using __dict__ is because of the __setattr__ function afterwards.
WidgetChild = InterfaceChild
A bit more documentation is needed throughout this file.
change random to the private
_random
Explanation? 

{{todo.content}} is a two-way binding, which says: if the value of the input changes,  change the content. And also the other way around.
Aaaaah, yes
@vesak Tää feilaa jos stringin eka merkki on viiva. Silloin strpos-funkkari palauttaa nollan, joka on false. Tässä voisi olla if ($dash_pos !== FALSE)
should it really be a public method ? I would have made it private
This entire method is useless. Method `loadAll` does exactly the same thing as you're doing here.
should be `false`
Most probably you need to use QA_PREBUILT. Please check man 5 ebuild for that.
Pete can you arbitrate on this one and let me know if you want me to change it or just merge it in its current form.
These messages are quite annoying. I propose to add newline here, just as in other files, for consistency.
got it, my text editor was using 2 space so i did not see the above... will fix.
Just fixed it and squashed it back into the same commit.
true. change it to "the user did not succesfully log in"?
Nit: Prefix this with 'is_'
I can add it later/soon, was aiming here to add the minimum to get the exisiting zipline tests to pass when using the Event in the mock trades.
User  ⬅  Talk
   　↖　　⬇
　　　　Room
こんな感じでした。
可読性重要ですね・・・
Yes I thought about it too. Because final gemspec  is static, so it will depend on what platform you build gem.
Setting[:foreman_url] || request_url  (assuming the foreman_url can be nil (which I dont think it can)
I guess it makes no sense to add json views here, rather add it directly to the /api namespace
I'd rename this method - it's no longer creating a `lib` directory. What about `make_install_directory`?
Maybe we should first try to make it `some-slug-base-20120628' first before we start doing the `"-%d" % i' thing. 
That would make it much nicer URLs for the, specifically, Monday meeting events.
no - that must have been added to the test w/o an timestamp update so it didn't update in my local version of the translator, I'll fix that with the other two.
shouldn't this be logged?
Everyone's editor does their automagic differently. Either, they have to comply with a single coding style that we have agreed on, or the auto-feature must be turned off. Otherwise, we'll end up with lots of ping-pong diffs unrelated to the change (I've seen it happen). Such diffs block merging.
This should be in the Trade class since it only modifies the trade.
sorry, that's just a tabs/spaces thing. fixed.
Interesting. JSHint didn't complain about this one. I think it's because `/` isn't at the start of a statement. But I didn't change it simply because the linter didn't complain.
Change the path to use a php file inside the plugin pmReports
looks like we have to support decrease of samples count. Which we don't have here...
Can't we move sync_project on level higher, so we only call it once for every log instead of every new release…
That's a trailing bucketname which should be retrieved via _getBucketName and is fixed locally.

FYI, I'm not yet looking for a full blown code-review.
I wanted feedback on the model and api approaches.
Then this line can be removed.
+1. I think this is how I formatted it in the ID management PR as well.
By adding the logger, we pull in the oae-logger, bunyan and underscore modules, which is something we might not want to do if we ever release this module as a stand alone type of thing.
(This also reminded me that we need to add the request module as a dependency for the oae-rest module.)
I know the above was already existing code, but I am wodnering why do you need to set this specific policy. And why on Thread start/death. Would you add a comment for the JDI newbies like myself :)
Ah, didn't read your note on this above.
replace with range(52) to make more readable, compact, and less error prone? i.e.

return range(52)
This sort of stuff concerns me a bit, we have lots of hardcoded references to file locations. This won't work in any of my applications for example.

I don't have a suggestion for an improvement right now other than we list stuff like this in accompanying documentation. Is there anything else we can do?
Я так и отношусь. И очень благодарен за ценные комментарии. У меня уже готова совсем другая версия программы основанная на всех замечаниях и комментариях от других студентов, но я ее не выкладывал еще, так как хотел, чтобы оценку мне поставили за то, что я написал сам без помощи других.
Вам этот метод совсем не нужен, при наличии метода hammingDistance, который возвращает int
Возможно вам пригодиться такой конструктор NSString:
```objective-c
[NSString stringWithFormat: @"ДНК = %@", [self.DNA componentsJoinedByString: @", "]];
```
`i<(!!head.length) ?1:0` is madness haha. what about `i < head.length`
Why is this part of the patch? Could you revert changes to this file? Thanks!
Hey kira, if you're interested there might be a way to salvage the work you have done so far.

in the terminal run:

git checkout master -- path/to/INSTALL -p

the -p is "patch mode" which enables you to revert some changes to the file and keep others. after running the command you should see an interactive command line interface that will show you all the changes to the file and ask you whick ones you want to keep and which ones you want to revert.

I hope all is well with you!
`(` before `data` seems superflous here
Hoepfully this was tested :)
@coderanger It seems to be the convention in this project to use `Error.new` so as not to create an infinite loop of exceptions being raised and caught (so Raven doesn't catch its own exceptions).
Heh, it won't be me. My first question then becomes really important, because I think we should eliminate one or the other (or at least focus the class more specifically on one use case). This feels a lot like two interfaces smushed together.
For the command help, I think it'd be worth while listing out the particular options. For example:

   hubot nick pirate <name> - Provide the user with a pirate nickname

This would alos someone to say `hubot help pirate`, and get this back.
I bet Rails has some nicer way of checking this than using Nokogiri. If not, we should move it to a helper method.
absolutely right. 
I hope to dedicate some time to kpdfview this week-end, and I will fix this; or, of course, feel free to do it by yourself, no problem for me.
And I also should absolutely take the time to study all the new implementation / refactoring you guys made last 2 weeks: you work really hard to this project, and it's not easy to keep your pace! :-)
I'd combine this with the README.md (markdown/github will format it nicely and show it in the directory listing online)
The name of the XML file inside the resource should be constant, and not include the revision. I suggest to stick to the name in the synchronization protocol spec, "resource.xml". But I can live with other names too, in that case please update the sync protocol spec accordingly.
show case this function in the example
that's not an attribute but a method
can you use bandwidth rather than bw?
Cool FBI work!
On Fri, 3 Aug 2012, Philippe DENIEL wrote:

> > @@ -124,6 +124,70 @@ void DispatchWork9P( request_data_t *preq, unsigned int worker_index)
> >    V(workers_data[worker_index].wcb.tcb_mutex);
> >  }
> >  
> > +void AddFlushHook(_9p_request_data_t *req, int tag, unsigned long sequence)
> 
> Very basic remark : can you prefix non-private functions (used in other .c files than this one) with a "_9p_" string. For example this function will become "_9p_AddFlushHook". This "layered naming" policy usually helps debugging a lot. 
> 

Of course, I can do that. But at this point I was only expecting feedback 
on the general idea of the patch.

BTW most of the code should probably moved to another file than 
9p_dispatcher.c. My code is also not compliant with your formatting 
standards (which are ? 2-space indents ?).
@benmccann: I was just talking about not using the "new" keyword since it
will make the whole thing confusing. This was fixed bu Guillaume by
replacing it with the "@" character.

On Mon, Sep 10, 2012 at 6:21 PM, Ben McCann <notifications@github.com>wrote:

> In framework/test/integrationtest/conf/routes:
>
> > @@ -14,6 +14,9 @@ GET     /cookie                 controllers.JavaApi.setCookie()
> >  GET     /read/:name             controllers.JavaApi.readCookie(name)
> >  GET     /clear/:name            controllers.JavaApi.clearCookie(name)
> >
> > +GET     /json_java_instance     new controllers.JavaControllerInstance.index()
> > +GET     /json_scala_instance    new controllers.ScalaControllerInstance.index()
>
> Hey @sadache <https://github.com/sadache> . I still can't figure out what
> you were trying to say. I think perhaps you don't understand what's
> happening in this example. I made a Java controller and named its class
> JavaControllerInstance. Then when a request hits /json_java_instance, the
> JavaControllerInstance class is instantiated and its index() method is
> called. I also created a separate controller with a separate class named
> ScalaControllerInstance just to prove that there would be no problem
> instantiating either a Java or Scala controller and calling a method on it.
>
> Please get back to me so that this pull request can be either committed or
> updated as necessary.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/playframework/Play20/pull/365/files#r1567596>.
>
>



-- 
www.sadekdrobi.com
ʎdoɹʇuǝ
This first `put` should probably be removed
Did you want me to make this change prior to merging?
protected, because you might want to access it from the Producer Actor. yes it is idempotent.
Note that

```
>>> factor_nc(A*B + A**2 - B*A - B**2)
(A - B)*(A + B)
```
change version comment according to upgrade versions.
NewPuc2/NewPuc2b
As we discussed on wednesday a couple of weeks ago, we should probably try to stick with the convention of keeping tests in a separate file.
The logic here wasn't fully completed, but we need a way to remove breadcrumbs, for instance the homepage doesn't have any breadcrumbs, and if you enter from a page that did, you could potentially leave the old breadcrumbs there.
Personally I'm an RSpec guy, having never really used test/unit in anger before, so it's making it feel more like home :wink:
Please make this an optional<size_t> -- last thing we want to do is to have too short a body (it's completely imaginable to have >65k bodies, and even >2GB bodies).
May I suggest instead of catting right to a pipe

    while read line; do
    . . .
    done < ../etc/my.cnf.base
will removing this cause the create call to _not_ return the hostname? it should be in there
Probably best to stick with the use of :symbols since that is already in use in the cookbook...
use `bin/list_command_ids.py` to check for command id conflicts and to generate the next avbl command id...
the year should probably be ``2010-2012`` now :)
is "origin" even needed here?
That was more of a stylistic swagger than functional (*may be a hold over from my Java trainings*) but I think removing the parenthesis is good advice given we're already following this convention on our projects.
Changing it to "Espacement et retrait" seeing as it's both, and "indentation" doesn't exist.
Confirmed this problem. We'll keep QGLWidget for now, and I'll file a bug on it.
Why didn't you add the braces here?
Great catch! Totally my bad. Fixed in 0d5f6cb
There are some inconsistencies between Firefox and Chrome when it comes to rendering line-height in buttons.
Please use CopyOnWriteArrayList or a similar concurrency minded collection. `bind` & `unbind` can be called at the same time.
should we maybe try to read this from Travis.config ?
Could we add a couple of specs for e.g. ```when_present``` as well? Add something to the page that calls alert() using window.setTimeout. Both the success case and the timeout case should be tested (i.e. to make sure selector_string is invoked correctly).
Fixed - bring to the same pattern scale * value.
Also some values are now just set because width/height = 'auto' are not supported for BB yet. Also layout right and bottom properties are not supported.
If they will be implemented than these lines of codes should be removed. Added //TODO comment to review that part in the future
Good to know! Anyway, my point was that the arguments passed for event callbacks are not at all documented. How do we fix this? Should I open an 'issue'?
As python's doc state:

>  (An Adler-32 checksum is almost as reliable as a CRC32 but can be computed much more quickly.)

as for string concatenation.. ''.join() for two strings ? Apart from the fact, that it doesn't produce readable code, it seems like an overkill ;). Also, my naive thinking tells me that using string interpolation ( formatting ?) requires more CPU cycles than simple addition. 

Why isn't ``+`` good? (i'm not trying to argue here, just trying to know python better).
Definitely need to make it clear what we _officially_ support, yes.  I think when it's just little differences (e.g. moving the `appendChild` in that other issue), then we should try to make it work appropriately.  However, for something like this particular line, shimming `querySelectorAll` is no easy task. Perhaps the right approach is to state a support model like: "Works in IE8+. Works in IE7 but requires Sizzle/jQuery. (And of course works in all of the other browsers.)"
private properties are easier to change as they are not accessible from 3rd party classes
Sort_links was added in 1.8 (specifically 1137f8037da76d9a9b38f71778849e915766ae91), but we never added general support for it to the templates or publicized its availability (though we may have used it in stanford's custom templates) so it's safe to remove. I forgot to take out the docstring, though.
That's not a good idea, if the 1.1 branch work with sf 2.2 it need to allow both 2.1 and 2.2 but not force 2.2
If there is incompatibilities, we shoud create a 1.2 branch that require sf 2.2
It's all called argument in the REST API. I think I'm going to leave it that way.
submit in Python only allows single events to be submitted. You have to attach to a socket to do multiple.

Good call on eschewing PrintStream. Changed it back to a raw OutputStream.

We don't specify encodings in the other SDKs that I'm aware of, since Splunk usually figures it out just fine.
There are many other minor things that have been deprecated. Therefore this should not be taken as a complete list.
Much less intensive then doing that on every request (if we will have many requests). :-)

The main thing is that it is much more predictable. And not tied to request processing. (Request processing means that Django process cannot handle others at the same time, this is why you have other processes doing that, even on other servers.)
What we will have? *User picture*? Or *User image*?
Fixed. Everything.
So, the question is: do access tokens change everytime user authenticates or not? But maybe it is better to leave it like this, to be on the safe side.
We have users, and each user has account page which contains AccountForm. I admit, this class names are a bit confusing, should I change it to UserAccountChangeForm ?
So you can populate context in one way if horoscope is available, and in another if not.
*hour* -> *time* probably?

Also we have comments in different syntax. No dot at the end (you have one in comment above). Space after `#`. Starts with upper case letter.

```
# If one object doesn't contain time (is date type), convert the other one to date object
```
Are you sure that `.layout` is always defined?
`if c is None`. `None` is always tested with `is`.
Under Windows, calling theano_nose directly doesn't work (says it isn't a valid win32 application).
That's why I had been using 'python' as the main command to launch.

Using ['python', theano_nose, ...] seems to work. I guess you could either use that one for all systems, or put an "if sys.platform == 'win32'...". Could there be a problem by calling "python" on Linux? (like, is there a risk it might not be using the same Python version for some reason?)
thanks.

Someone can pls point me the problem in the functions (DrawUserPrimitive).
Cause i dont have the environment to compile for IOS or Android.

WHen i try to open the solution i get:
The project type is not supported by this installation.
iam using visual studio 2010 ultimate

Att,
Thiago Dias Pastor


On Wed, Feb 29, 2012 at 7:54 PM, Christopher Chambers <
reply@reply.github.com
> wrote:

> > @@ -192,11 +191,6 @@ public static void FillMode (RasterizerState state)
> >                               GL.PolygonMode(MaterialFace.FrontAndBack,
> PolygonMode.Line);
> >                               break;
> >                       }
> > -#else
> > -                     if (state.FillMode !=
> Microsoft.Xna.Framework.Graphics.FillMode.Solid) {
> > -                             throw new NotImplementedException();
> > -                     }
> > -#endif
>
> Right now the only way is to test against Android or iOS manually,
> unfortunately.  I'm working on adding automatic testing for Android and iOS
> to the bot.  And also working on fixing the bug that prevents it from
> building this pull request.
>
> Hopefully things will be better soon!
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mono/MonoGame/pull/324/files#r504386
>
Here you should check that `new_dir != None` in the case that there was an error in creating the new directory i.e. the directory already exists: http://root.cern.ch/root/html/TDirectoryFile.html#TDirectoryFile:mkdir
Hi

In order to delete the test database and remote access, cdist needs root access to the database. There is no other secure way to specify a password for a MySQL process than the my.cnf file:
http://dev.mysql.com/doc/refman/5.0/en/password-security-user.html

Hence, the --password parameter is requried for the __mysql_server type, and I have no other possibility than writing the password into /root/.my.cnf. As alternative, I could move an existing my.cnf to a backup first, and then move it back after cdist has run.

As a side note, I'm planning to enhance the __key_value type so that it could properly handle .ini files such as the MySQL my.cnf. There are a few good Perl libraries around for that, and I hope that I could then make the changes to the my.cnf file in a more generic way.

Benedikt


Am 20.02.2012 um 11:12 schrieb Nico Schottelius:

>> +
>> +# to the database without requiring a passwort input
>> +rootpassword="$(cat "$__object/parameter/password")"
>> +
>> +# set root password
>> +echo "mysqladmin -u root password $rootpassword"
>> +
>> +# store the root password in /root/.my.cnf so that processes can connect
>> +cat <<-EOFF
>> +cat <<-EOF > /root/.my.cnf
>> +	[client]
>> +	password=$rootpassword
>> +EOF
>> +EOFF
>> +
>> +# remove anonymous users
> 
> should this always be done? i.e. isn't this breaking stuff for people how would use __mysql_server in a generic situation?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/telmich/cdist/pull/38/files#r466719
Here occurs an error saying: 
function ChatHandler::HandleCharacterLevel is inaccessible!

maybe due to it being protected for class ChatHandler, how to override this?
this change breaks existing scripts
please use the short class name as there is a use statement
Not your fault... can you strip the exit and remove `Error: ` from the exception message?
(yes, I'm spoiling you :P )
That's a PHAT Controller...  We'll put 'er on diet soon!
(Do that.)
Same as the issue above, once resolved we should also reduce duplication.
Because other are obviuous and they don't require documentation. Something like `$_subscriptionId` is nothing more than SubscriptionID
If a dll is loaded by ctypes from a specific location then the location could be based on __file__.  Let's keep them in the data files directory module.
yeah, either one will work.
My reasoning was that the progression should be: 

Newbies (getting started, intro, basic doc) -> Regulars (statististical functions and tools) -> Ninjas (understanding the structure of the statsmodels software itself)
add kertype as attribute to instance.   in __init__ ?
Why use the Buddhist calendar here?
Check out EntityUtils.toString(httpEntity);
What column limit are you formatting with?  Some of these lines seem to be wrapped pretty early
Then, can I change email to request.user.email ??
ni: else if location
Yes, I'd change it in both.

I agree about consistency in lam/D vs. D/lam for optics module vs. SBProfile Airy as being part of the work on radii-specifications.
OK.  Done.
If the pull request  for #195 gets given the go ahead, I'd be happy to convert this to be a new descriptor-style GSObject.  It looks very good, and great to have the new improved factors for HLR and FWHM.