labofsahil/github-event-dataset-2012 huggingface dataset:
Excellent, thanks.
I suppose since they're just variables, not static class members, that you are allowed to initialize them in the .h declaration.

On May 22, 2012, at 10:58 AM, Mike Jarvis wrote:

>> +         * @brief Report interval bounds
>> +         * @param[out] xLower Interval lower bound
>> +         * @param[out] xUpper Interval upper bound
>> +         */
>> +        void getRange(double& xLower, double& xUpper) const {
>> +            xLower = _xLower;
>> +            xUpper = _xUpper;
>> +        }
>> +
>> +        /**
>> +         * @brief Return a list of intervals that divide this one into acceptably small ones.
>> +         *
>> +         * This routine works by recursive bisection.  Intervals that are returned have all had their
>> +         * fluxes integrated.  Intervals are split until the FluxDensity does not vary too much within 
>> +         * an interval, or when their flux is below `smallFlux`.
>> +         * @param[in] smallFlux Flux below which a sub-interval is not further split.
> 
> I guess you are worried about name clashes with other things in the galsim namespace?  The usual thing for that is to put them in their own namespace.  e.g. odd in this case.
> 
> I went ahead and did this, so you can see what I mean.  Feel free to revert if you don't like the change.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GalSim-developers/GalSim/pull/156/files#r860594
>
Isn't this else statement redundant with line 37?
consider writing something interesting here to the log file.  don't want to log a bunch of extra junk tho...
ok. this is good
pthread_mutex_trylock() will return non-zero immediately if it cannot acquire the lock (ie, another thread is already holding it).  This could occur if the thread was deadlocked due to lock order violations, or just because another thread was busy using it.  Either way, if it can't acquire the lock immediately, it drops the lock it already has.  It then acquires them in "correct" order.

The IFNDEF simulates pthread_mutex_trylock() returning non-zero (ie, pretend it couldn't acquire the lock and always enter the conditional) so it forces it to use correct order.

Using the pthread_mutex_trylock() is an "optimization" for the usual case.  There's no need to drop a lock and reacquire it unless it would otherwise deadlock.  I'm fine if we want the policy to be you ALWAYS have to lock in the correct order, but I think it's fine as-is.
no clue, maybe it was deleted during a reset and untracked afterwards.

will correct during merge
could do `def (List allconf, List unusedConf) = prepareConfig(flags)`
But don't care one way or the other.
Also who at Opscode ever said this wasn't important so I can go smack them?
It was there to give the right path to the virtualenv binary when python was being installed from source.
I mean, that /kind/ of makes sense, no?
Was this a deliberate change in Ace? or an inadvertent breaking change?
Why the `this.resource` stuff? Can you not use a local variable in the containing describe block?
20px seems a long run, maybe 10? On iPhone seems somewhere between 5 and 10.
``->fixXmlConfig`` should be called outside the ``->children()`` node
This is copy/paste from the other documentation. Although i agree, i'd like to keep this table-formatting the same as the others :)
Just wanted to also highlight this TODO comment, which one may want to resolve... One way would be to just ignore this: EOF (and not EOS, sorry, a typo), equals -1, so it is cast to 255, which I believe will lead to isFOO() returning false in any case. So just having the plain cast might be enough.

Of course, a more aggressive variant would be to add a check that asserts if c is not in the range -127..255  or so... But thinking about it, this actually seems pretty useless: It's unlikely to happen, and if it *does* happen, the result of just casting the value to a byte should be harmless; while the crash caused by an assert would be mighty annoying! So, perhaps the above TODO should be removed, and replaced by an explanatory text.
This seems to remove some of my requirements in the requirements.txt.  let check and make sure it doesn't
check out the other for method in java: for (Object object :objects) you can have a template via typeing foreach into eclipse and then press ctrl+space
```if (selLength > 0) {```

Spaces after if, closing parens, variables (selLength), operators (>). No space after opening parens or final "thing" inside a paren.
а как пользователю пометить, что он хочет прeкратить ввод, если тот через System.in?
Конечно. Это синхронизация на пустом месте. В другом случае тоже надо проанализировать, есть ли конкурентный доступ.
Не только пробел является разделителем. Надо использовать Character.isWhitespace
Тогда я не понимаю, почему мой класс непотокобезопасный. По идее, несколько потоков могут дергать addToExtensions, который затрагивает extensions.
I don't think so, because that would cause the imports to fail when in production mode. The canvas.rb proxy actually uses VCR classes.
@ctweney The separate still enabled test that hits fake.
awsbox question: Is it correct that I would use the `-u` option to set the `public_url` in `config.json` so that the `PUBLIC_URL` here would be my proper domain name, and not the IP address of my server?
This class will also need the POSTFIX String variable
Please don't use the same name than KnpMarkdownBundle to avoid replacing the filter
pep8 : no " " around = in function args
you should check that coef_init has proper type and dimension
There seems to be some redundency between _check_fit_data and the above line.
不需要注释的吧？？？
The first field has `offset==0`. so this is not good.
`if (storage_class & STCfield)` is better.
please check the pointer for null-ness
let's use std::string so we don't have to do this low level stuff :)
Ligne incomplète ?
holdS
You're making an assumption.  You don't know why you're going to be dumping out a tree.  If you're dumping it out because the types are inconsistent then the type is very important (I have had several bugs like that).  
The more information you include the more problems you'll find it useful in.  The more consistent (and concise) the information, the easier it will be to scan the output.  You're right that it isn't really needed for attributes, but there are other expressions that is also true for, so that should be generalised to a function.
If files come in a text form, escape as the last byte would be a syntax error, I think. In binary format, everything is possible. I probably should add some protection, just in case.
No point, see my comment above, you need to be in block and you check numCommitted() already on 1st line of sortAndSpillRows()
No, because if there's no compiler, it won't run the test, just compare the directory.

This is good if you're using different tools to compare, or finding the best ignore flags (and need to keep restarting the diff tool), etc.

Because the test shouldn't normally be against the installed compiler (ie. you don't need to re-install the package every time to test it, just compile), so hopefully that won't get in the way of not being the default.
> This is still confusing c versus c++ compiler.

Not sure about this. We're using only that test everywhere (well, and clang).

> Checking the version of the c++ compiler before deciding what options to pass to the C compiler seems wrong.

I don't like it either, but it's bound to happen if we want to disable warnings that are only present in a new version, and still support old versions of the compiler.
Looks like that `Fiddler` works fine with HTTP only then the common parts for any filter that changes HTTP ports would be centralized in a base filter that serves all things like Fiddler, MockServer, MyServer....
It's also good to have `isLocalProxyPortAvailable` in that as well.
Doing ``valid = bool(value)`` would mean that a ``0`` will be considered ``False`` and we don't want that. We really want to filter out only empty strings and lists.
Needs review. Is this depended upon anywhere?
these should use the path utilities at the top of lib/consolidate.js
Using a unique dict for all the commands doesn't make it harder to override it just partially?
@christianv Is it intentional to have no action= attribute on this form?
Scared of numbers larger than 4 :-)
sorry to annoy, but wasnt this www/composer.json before? :), since you invoke composer from www also.
is this x-ms-copy action or just ms
Use a context manager.
The method there represents the addons count from several pages(The number of the pages does not count, because it will always take the sum of the number of addons from all the public addons pages).
Well although this method or property does not represent the page, it points to the addons section of the page and provides the number of addons required for the test.
If the testcase is the problem maybe it should be revised, also I don't see any flakiness in the test or in what it tests.
Please remove this and other cases of more than one blank line.
There are other cost overrides, for special deals we made with individual groups.  Maybe after creating `available_tiers`, you can check whether the costs match what's in LOCALTV_COST_OVERRIDE and change the Tier objects accordingly?
node.attributes["changed"] could be interesting, for the date of the gpp...
I think this needs to be corrected.  You have code that supports OSX, but your Platform option only wants 'windows'.  Also, why is 'shell' support stripped from SessionTypes?
should be "inverse" -- sorry, thought I had fixed this with the refactor
I was switching between double and single quotes so much that I wanted to use `%q()` so that `sed` wouldn't change it no matter what I did.
Any reason we can't use:
    unless @options[:now]
I really disagree with this. Having the assets change out from under you with no changelog is bad.
%s for a numeric code? Should that be %d/integer or %s/GuestStatus?
you should add a use statement for this
How are we interpolating quaternions (CC @kring)?  Linearly interpolating Euler angles is bad - the interpolated rotation matrices are not orthonormal.  Do we plan to support spherical-linear interpolation (slerp)?
Use `computeArea2D` here and below.
There should be "since" here as well I think.
Given that isFiredOnce is set true always on line 640, why do we check?
Good suggestion - thanks. Updated in next push.
Here, if console is not defined, you'd get a ReferenceError.  The way to do it is to use typeof, I'm sure it was just a slip up:

```javascript
if (typeof console === "undefined") { ... }
```
`it('sets the value of a non-existent key to 1'` is a bit more accurate.
I am using showEvent so that the installation screen can be shown before the password dialog box
What are we protecting against?
и название эвента наверное тоже?
Та ну не, просто странная фича. Но если ты хочешь, чтобы люди литералом могли вписать табы (опуская проверки содержимого литерала и так далее), то может лучше на массив проверять, а всё остальное делить как строку (больше кейсов, имхо). Но хотя и так, и так странно.
Indent seems off here
copy-paste spotted :smile:
`ConcurrentHashMap`.
Pokemon Exception-handling?
this doesn't look safe, or rather looks ripe for bugs in the future. does Poco::Path not have a built-in == operator, or an equivalence function? the string "/usr/local/bin" != the string "/usr/local/../local/../local/bin", but the paths represent the same thing.
Right now we only support standalone, but will keep that in mind if things change.
Doesn't need to be ternary - the expression itself will return TRUE or FALSE.
It doesn't on my instance. That's the whole reason why I wrote this patch.
I think that the design would be much cleaner if these process nodes were refactored into a separate static AtomSerializer class, into which you feed XML and get back objects.

Then, you also put in the serialization logic too, one central location for mapping Types to XML info. That would be a great place to encapsulate the `Attributes` info too; for example, that is where you specify that a `SqlAction` node should define `xmlns:sql="blahblahblah"`.

That makes it more maintainable in the future, and gives a central location to make changes (instead of peppering changes across all files, like had to be done in this changeset for `parseXml`, `writeXml`, and `writeInnerXml`).
context "given a root node"
nice idiomatic use of `setdefault`
The style guide does not cover this, but I'm fairly sure the convention is having no space between the *private* and the *:* tokens.
True, except we'd still need to cast in doStop(), the general contract for 'task-executor' is Executor elsewhere. If we make it a TaskExecutor, that would not be consistent with other uses.

Also, TPTE does a shutDownNow() by default.

With a mail adapter, we should probably allow sender threads to quiesce (although, even then, there's a race condition in IdleTask.run() in that we could be in the middle of executing sends on a bunch of messages). This is especially a problem if shouldDeleteMessages is true.
~~review~~ refer to
I think one 'will' is enough ;)
wondering if this is valid by adding 2 supports line with the same OS.  Opscode example shows only one limit input, but not 2.  emailed mailing list to see if there's a way to both an upper and lower limit.
If you want concrete versions for testing or demonstration project, you can define those with `tests_require` or special `requirements.txt` for test projects.

(Sometimes it is normal to have `requirements.txt` for tests, for example, for different Django versions, if you want to support multiple Django versions. And you can use the same `requirements.txt` for documentation at readthedocs.)
Since JDatabaseFactory is  completely new class do we actually need legacy error handling?
Not sure about arrays, know its the case for ints and booleans.
Should be --session-dir not sessions-dir
k. I'll do that to make something more reasonable
I'm not quite sure what you mean. This block conditionally injects a locator statically into a base test class so it can be used by any test class that extends it.
Not sure about convention, but this ways it's easier to append new configuration options.
Do you delete the temporary file later?  I don't see it?
please put default values in the Configuration class instead, according to the Symfony convention
You might be ok with the logic structured like it is (I haven't analyzed it all yet) but double check that you only invoke the callback once.
baraye to are
har kas dar levele khodesh ;)
Why have you removed the close button !? I am in the favor of having the possibility to not show the close button, but that should be configuration with an option.
http://i.imgur.com/aDnxG.png
ascend does have an upper boundary, it's '/'
By using @callback tags you can document the parameters this function expects.
If there's only 1 event, you do not need meta tags
You want "X" here.
replace the last two lines by "return false;" ;)
Would like to consult with Ted here on the headers, for C# I almost always prefer proper two-slash comments including for license headers.

But if there's team precedence here, I'm OK with this.
You have right
please log exception or use it as a cause
This comment lies
I don't necessarily think the way `X86` and `X86_64` work is flawed, but I do think our `version` system is flawed in any case. The fact that we don't support logical and/or in them is very silly and many people have complained about this, but Walter in particular calls it "too complex" even though there are real use cases... /rant

(I'm not against the changes to the FP ABI identifiers in any way, by the way.)