labofsahil/github-event-dataset-2012 huggingface dataset:
This proc changed.  Change the line to:
user.visible_message("\blue \The [src] morphs and changes [user.get_gender_form() == MALE ? "his" : user.get_gender_form() == FEMALE ? "her" : "their"] appearance!", "\blue You change your appearance!", "\red Oh, god!  What the hell was that?  It sounded like flesh getting squished and bone ground into a different shape!")
Does that hash cause the rest of the line to be a comment? I guess it must not, ruby is so clever.
using multiple `&&` and `||` in one expression without parenthesis is pretty bold.
split declarations onto separate lines.
Вынеси каждый конструктор в отдельный файл
Лучше сделать вот так: 
```javascript
var Collection = function (items) {

};

// на то, что имя повторяется - пофиг
exports.Collection = Collection;

// и дальше уже работать с локальной переменной...
Collection.prototype.constructor = exports.Collection;
```

Дело в том, что Collection на строке 16 и дальше будет получен из глобальнй области видимости (`exports===window`), а обернув в IEFE мы максимально хотим тем самым использовать локальные переменные. Но все это работать будет.
the scope of the bug is to support root container, container name escape is beyond the original description of the bug. I will keep the fix/issue tracked separated.
If they are invalid, the request will fail. Conversely, it is not possible to be 100% sure about the correctness of the URI here.
Why `installed_prefix` and not `prefix` from the `AbstractPhpExtension` extension?
Awesome work with gettext. See earlier comment, we don't escape provider here. 

Where does the `escape` function come from? It does html escaping? Very cool.
if you are catching the exception with the try-except block, and returning False rather than the exception, then you need to check for false every time you use the method. it would be a little bit better if you returned an empty string instead...it would at least be the same data type as the string you return otherwise. unless there are cases where the location should *legitimately* have no text, then i agree with @bebef1987 that you should remove the method.
We could change the `validate_manifest` to perform this and return the result. We should also assert this rather than ignore if the manifest is invalid
true, renaming this now
this is set as a default in bidpom but to make the difference between the 2 types of login we specify it
nice catch moved
テストフェーズ、テスト種別

でも違和感な内容気もしますが。。。
どうだろ。他にも誰か意見を。。
Missing section underline?
Ok, that was the subtlety I knew I overlooked, thanks :)
Also, this code doesn't seem to preserve sparsity. My intuition is that it may be necessary to treat positive sparse data  as a special case (if the user-specified range doesn't require a translation of the data).
wouldn't this be replaced by the PEAR installer too ?
Shouldn't we pin common.css as well to the Revision?
Might want to keep this line, otherwise program will only use a single thread.
I originally added ``tmp`` because when I just had ``chosen = constructor``, it was complaining about ``chosen`` not getting initialized sometimes.

Do I really need to make another commit over such a minor detail though? :P
Btw why would (int, int, int) vs (int, int) be ambiguous? We could error with "Missing one parameter ('int')"
yes, really. see iphone.js
This should be > instead of <.
What happens if I pass in `nil` for cacheSchema?  Will our calls to `[self.cacheSchema cacheURLFromRemoteURL:url]` be handled correctly?

We may want to either not allow `nil` to be passed in, or override the `cacheSchema` getter to create a new default cache schema if it's `_cacheSchema` is `nil`.
Indentation? It looks weird on GH, maybe it's okay where you are...
This function or relevant portions of it need to be synchronized using m_mutex member of CWsDeployFileInfo
Ah, good question. The interface has the default parameter, but the class doesn't. So, when dealing with the interface, I was using the default parameter, but when I casted to the class, it failed. Nothing major, but curious.
It doesn't need to - left will only be set if it has an input dataset (or if there is some weird other meaning for left)
I could release it as two commits, but I'm not sure I have the energy to discuss it.  Richard, do you want me to split or not?
Do we need some copyright notices?
In case you want to use coco's `class`, you have to super in constructor

```
class User extends Backbone.Model
  -> super ...
```
Ah, you need a username, this guys won't work.
Can you please use some less common port name for this ? There is pretty high probability to have something conflicting running on the developers machine.
I believe all of the above should be attributes that are modifiable with node attributes. Ush, are you familiar with adding new stuff to attributes/default.rb and then inserting these values into the erb template?
Overall put message in asserts
Why this function should return IList?
I understand that function argument should be declared as the lowest possible type, but when function actually returns List, why it shuold declare to return IList?
nitpick: please don't leave blank lines and huge comments between 'if' and 'else'; it's difficult to read.

if you fix that, remove the double blank line added above too.
NP :)
I don't fully understand the parse_reply function, why don't just search if it's a setup_record (seems it is when setup_record[3] == 0xf9), and if it is a setup record, return the password?
causes exception, should read:

localuser.name = p.attributes["userName"] if localuser.name.to_s.empty?
Use ``skimage.data.lena`` and ``skimage.color.rgb2grey`` (or ``skimage.data.camera()``.
I think that typically we test the matcher almost at an integration level rather than a unit test level.  This is directly testing the method so it seems to make sense to me to nest it.

You're call.
I heard you mention `multiplyByScalar`.  That name is OK with me too.
I admire the noble intentions, but this branch has been open for many months, and the plan was to merge it in tonight so that (among many other things) pinch-zoom will start working on cesium.agi.com (Paul asked me about it again today).  We can hold it up for the `.clone` problem, but docs must go on their own branch, not this one.
This has nothing to do with scoping.  Before the error check or after the error check the scope is the same.
"describes [a]"
Aside from the name of the parameter, copyViewMatrix and copyNormalMatrix are exactly the same. Perhaps you can refactor.
I'm using 1.9.3 so that's definitely the problem. Maybe `if IO.instance_methods.map { |m| m.to_s }.include? my_method.to_s` ?
No worries!

Also, if you want to get your function added, you have to add tests. I guarantee that Puppet Labs will ask about them.
Emitting `disconnected` here is kinda confusing. Error here could mean that connection was not even successfully established so emitting disconnected is not right thing to do.
If the route is before the one with the id, it's not a problem.
Good point. Don't forget `is(T == enum)`.
Inserting webcomponents.dart directly into this file (inside a triple
quoted string) would mean that any changes to it would require a dart2js
compile which is a bit annoying.  Would also mess up dart editor support
for it. I think the right solution is to handle converting relative paths
to global paths so that this doesn't have to be hard coded.

On Tue, Aug 21, 2012 at 2:35 PM, John Messerly <notifications@github.com>wrote:

> In components_polyfill_boostrap.dart:
>
> > + * scripts into a page after dart code has already run (b/4636).
> > + *
> > + * The script does an XMLHTTP request, so
> > + * to test using locally defined custom elements you must run chrome with the
> > + * flag -allow-file-access-from-files.
> > + */
> > +
> > +#library('webcomponents_bootstrap');
> > +
> > +#import('dart:html');
> > +
> > +// TODO(jacobr): this is a complete hack.  Figure out the correct relative URL or
> > +// embed the polyfill script directly in this script.
> > +//String polyfilLibraryLocation = "../../../../dart-web-components/webcomponents.dart";
> > +
> > +String polyfilLibraryLocation = "http://127.0.0.1:3030/Users/jacobr/src/dart-web-components/webcomponents.dart";
>
> fwiw, I think it would be fine to merge in webcomponents.dart here.
> it would actually help with merging mdv-poly branch back into master.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/dart-lang/dart-web-components/pull/16/files#r1429804>.
>
>
add `,` at end of last item in the list anyway when doing multiple line lists.
Essaye de garder la même façon d'écrire des tests que dans le reste de la doc, s'il te plait :)

En l'occurence:
```php
    $this
        ->string($car->getName())
            ->isEqualTo('batmobile')
        ->string($car->getName())
            ->isNotEqualTo('batmobile')
    ;
```

Au passage, le 2ème ->string() est totalement inutile, tu peux très bien écrire:
```php
    $this
        ->string($car->getName())
            ->isEqualTo('batmobile')
            ->isNotEqualTo('batmobile')
    ;
```
Yeah, I agree that flattening it to one level doesn't make a whole lot of sense. We're working on those "single node actions" in the next two weeks BTW, particularly "sort children" and "duplicate page"
the integration point would be ``$request->getRequestFormat()`` .. so if its not enabled .. there would just not be any "smarter" logic to determine the format.
hehe that's the end of the week :) done
Have u seen this one? Why could we just use it or inherit from HttpContent?
http://msdn.microsoft.com/en-us/library/system.net.http.bytearraycontent(v=vs.110).aspx
You should probably log + return here
Same as above, drop prefix, use better name.
Не делай так. Грузи из темы.
it still feels weird to me that this comment says "map of suites to cases" when the object is a `SuiteImporter` and there's no indication of "mapping" in its external API. When I see a comment that says "map of suites to cases" I expect to see a dict below that comment, because a dict is how you implement mapping in Python. (And there is a dict, of course, but its inside `SuiteImporter` and therefore no concern of this code, which makes the comment out of place)
Parameters and types are backwards here
Is it on purpose that you don't inherit from the nakamura base pom? If you do, you won't have to add the maven-sling-plugin here.
"function is"
There's a static assert being thrown here - see above for why (no 'else version').  By the way, why so many "Unsupported platform" asserts? I'd have thought they'd just cause more ill than good, especially when dealing with only C bindings.  The *use of* C bindings I can understand though - eg: in a function that depends on sigwaitinfo being implemented by the platform  ```static if (!__traits(compiles, sigwaitinfo) static assert (false, "Unsupported platform");```
> Such a warning applies to all Windows C file functions that take a char*, not just these 5.

No, this is file names issue only. All other functions from this module works good because they operate only with some ASCII symbols and UTF-8 is backward compatible with ASCII.
To clarify: This is safe because any object reachable through roots (in this case the stack/registers) should be treated as NO_MOVE by a moving GC.
The JPA Inbound adapter lets you poll and retrieve (select) data  from the database ~~via~~ using JPA <b>,</b> ~~while~~ <b>where as, </b> ~~by using the~~ JPA Outbound Channel Adapter lets us create, update and delete entities.
Can you add a little comment just to re-emphasize the fact that this strategy is not to be implemented and its EOL is imminent (not even a deprecation)
And with that do we have a JIRA for 2.2 to refactor it?

After this its LGTM to me
IdleSize/Count is the number of allocated items that are immediately available for use. This could be less than the availablePermits if the pool isn't fully allocated. 

InUseSize/Count  is the number of allocated items that are not available (they are in use).

Maybe we need a 'getAllocatedCount()' or 'getUnallocatedCount()'.

These methods were what I anticipated might be useful for monitoring.
May be *BeanFactory* as class name? (up to you)
Forgot that we have changed the name, path should actually be `ubuntu-10.04-x86_64`
You really wouldn't want a library which overrides your global error handling settings. Actually, you also wouldn't want a library which fires alerts. I will remove the error handling here and leave it for the API user to do it.
By default, filters registered with ``Zend\Filter\FilterPluginManager`` are available, IIRC.
Remove the comma after the component name
Richtig. Danke!
I actually removed the name option from logging, so you can remove the third argument here.
%s の中は空なので、 format する必要はないのでは。
Should this start with "There" and not "here" ?
Apart from the Copyright. Should we change the version in every file? Or keep in the Readme.md the actual version. I don't think that the version number should be in every file, just in a README or even in a branch ;)
Where? 
Sorry i don't see it :(
Should be ConvertToCzml to ConvertToCesiumLanguage.
`eventName` is only valid if used with `eventSource` correct?  Should that not be part of some sort of EventSource schema object rather than just listed as individual properties?  I'm asking because I honestly don't know, @kring ?
I'm not happy with the filter_var() function call here. Validation of input is not the responsibility of the controller in this case. 

The bundle already configures a Url constraint for the permalink, if there is a missing case where the validation component is not run, please add a failing test case.
You've left some debugging code in here.

I would also like to see the fos_comment_deleted function remain, which can proxy to the isCommentInState function. Marked with @deprecated
check for widget update event fire
I just thought I would let you know the latest build works fine on linux with the webworks sdk.  I would say 0.6.10 minimum for linux
-----Original Message-----
From: Eric Pearson <notifications@github.com>
Date: Wed, 05 Dec 2012 12:25:39 
To: blackberry/BB10-Webworks-Packager<BB10-Webworks-Packager@noreply.github.com>
Reply-To: blackberry/BB10-Webworks-Packager <reply@reply.github.com>
Cc: Mike Robinson<badtoyz@gmail.com>
Subject: Re: [BB10-Webworks-Packager] Updating README.md - Adding info for
 prereq step to build node on Linux (#229)

> @@ -7,6 +7,7 @@ This repo contains the code for the BlackBerry 10 WebWorks Packager and submodul
>  2. Install [BlackBerry Native SDK](https://bdsc.webapps.blackberry.com/native/).
>  3. Install [BlackBerry 10 WebWorks SDK](https://developer.blackberry.com/html5/download/sdk).
>  4. [*Windows*] Add Git bin to PATH. i.e. `*Installation Directory*\bin`
> +5. [*Linux*] Build node[v0.6.10], ensure it works on your distro and copy the binary into `third_party\node\linux\` folder

sure but 0.6.10 has security issues, 0.6.10 is needed on windows because of wrench but it doesn't care on non windows platforms, shouldn't limit everyone else because of windows

---
Reply to this email directly or view it on GitHub:
https://github.com/blackberry/BB10-Webworks-Packager/pull/229/files#r2326342
oh yeah! 11
# YOU WA SHIFT!
ok - I just did the change. But ther is one problem:

https://github.com/django/django/blob/master/django/http/response.py#L104
```
    def __setitem__(self, header, value):
        header = self._convert_to_charset(header, 'ascii')
        value = self._convert_to_charset(value, 'latin1', mime_encode=True)
        self._headers[header.lower()] = (header, value)

[...]

    def __getitem__(self, header):
        return self._headers[header.lower()][1]
```
the setting and getting is done non-trivial. i mean .. its no rocket science. but at this point i have to say i'm really not ok working around this - at all. Because then its just now simpler and nicer anymore, but redundant.

I hope you think so as well right now.

And at least - its more or less as fast as it would be when every header would be set normally via Response[{header}] without using the RestResponse(headers={headers}).
What's this blank line for?
you should remove lines that you have commented out once you are sure that they aren't going to be needed again (and even then you can drag them out of src control if nesc)
it's awful for large apps and apps this small only need one conf file so it's overly complex.

the structure of medley conf is going away because it's unmanageable and has resulted in numerous pmrs.
It's not needed because ```retry()``` will unlock all locked files and put them into NONE position (not even read lock), so that line is redundant, and dangerous.
http://img6.imagebanana.com/img/mv5yj2f9/Selection_210.png
Double spaces between items at the top-level in the module please.
Probably can call the selector directly with the draggable variable.
The association is based on where the Proxy was actually created, can you add to the description a bit?
Currently up in the air whether we need to remove obsolete stuff, or leave it in so we can generate the appropriate docs on removed methods. Will take this up separately.
I'd say yes - already when you define the requirement you should know what is the priority of the user for it.

Example how I understand it from my work:
Requirement to implement the new taxes in a banking software which you need have from next year on - very urgent
Requirement to exchange a current feature with something which is easier to use or enables more configuration possibilities can be somewhere between normal to nice to have.

I'd say that most of the ideas for improvments which take some days to be implemented are requirements by the client - or am I wrong?
You'll want to write this using the PyCogent/QIIME script interface. You can create a template script with ``make_qiime_py_file.py -s``. For example, I would run:

``make_qiime_py_file.py -s -a "Greg Caporaso" -e gregcaporaso@gmail.com -o my_script.py``

Then edit this file to define the interface for your script. 

You can find guidelines on using the script interface [here](http://pycogent.sourceforge.net/scripting_guidelines.html)
Again, const.
This is the only reference to the folder image I could find - I hope that's the only one.
Let the application override this to decide if it wants to load IP bypass flow, or regular flow.
@nukulb @kwallis Do we want to implement similar validation for the new design?
Also missing copyright header
Sorry, I was not clear what I mean with merge. I was thinking of calling waitUntilConnected() as a part of waitUntilBootCompleted...because you need to wait until boot is done for all cases anyway.
Why not doing ? :

In services :

``` xml
<service id="admingeneretor.menu_builder" class="%admingeneretor.menu_builder.class%">
             <tag name="knp_menu.menu" alias="admin" />
             <argument type="service" id="knp_menu.factory" />
             <call method="setContainer">
                    <argument type="service" id="service_container" />
             </call>
</service>
``` 

And in php 

``` 
public function __construct(FactoryInterface $factory)
```
These should either be in `$(D ...)` or be consistent with `$(I ! )` below.