labofsahil/github-event-dataset-2012 huggingface dataset:
Would it not be more future proof to have the FK set to get_user_model() ?

The disadvantage is it is somewhat less direct - but would allow more flexibility in future refactors of how the swapped model might be specified (hint hint, wink wink app-loading ;-)
Thanks for this pull!

You can save six bytes by moving the new block to be the first test after defining `div` and using `isSupported` instead of `focusinBubbles` (since they're identical at that point). If you do so, though, please include a comment to that effect.
I commented already elsewhere: Don't use a catch all. Don't capitalize BernoulliPDF.
Wouldn't a column of type SERIAL be easier than creating a sequence?
Again, I do ask why you need srand(), as you want just random numbers.  Calling random() without srand() gives you just random numbers.  srand(volative_value) also gives you random numbers.
Hai, I really like the comments explaining the logic. It would, however, be great to have the user/dev doc updated with the equations that you showed me (instead of here in the code). That way we don't need to add a big explanation about the logic here.
Need to turn ENV.fortran into a special requirement.
This is a bit tricky -- a delete where some tags are inuse and others are not deletes some keys and then fails half way which might be difficult to recover from.
Also, the `FailureMessage` goes to the `FailureWorker` which isn't hooked up to anything at the moment and stores failures in Redis -- completely out of reach of any of the applications.
what about just ignoring those who don't?
what is going on here. I don't see the point I'm pretty sure I have spaces here which is the right thing to have (tabs are definitely forbidden) but I might be wrong?
Yeah - I think it shouldn't be in linker.
Awsome.

the method signature:
String connectAndBind(String host, int port,  BindParameter bindParam, long timeout)

at fist I was thinking about this question: "what is the timeout of method connectAndBind?" or "maximum time taken to connectAndBind?"

if you see, there is two things happen on connectAndBind
1. connect (establish connection) -> this has timeout should has timeout
2. bind, this happen after socket connection established -> this has timeout also

OR 

so what you say is that we have different thing here.
1. connect timeout (the timeout)
2. bind timeout (soTimeout or enquireLinkTimer)

it means the total time taken for connectAndBind is connectTimeout + bindTimeout
so, let's put something to make it clean such as documentation that describe about this thing and maybe change the variable name of "timeout" to "connectTimeout". what do you think? after that I'll merge the code.

btw setEnquireLinkTimer use by user to change the timeout, in order to send the enquire link command
Haven't used ShellJS before but agree we should do this in a more cross-OS friendly way. @mklabs thoughts on us using it?
dont you like elvis? i prefer:

      return testclass == null ? null : Description.createSuiteDescription(testClass);
This comment probably want's to disappear so we're not confused by it in the future.
Ha, ok! Thought I had noticed us settle on ', but maybe not.
move this method out, add file param
well it's `if ($this->locked) {`
Nevermind. I updated the unit test to report the sum of elapsed time spent in getDocumentForPath() in addition to the existing 2 measurements. That should give us a better indication of the bottleneck of I/O vs. regexp.
For simple init like this, I don't see any advantage to wrapping in a function. If there were a number of init-specific local vars, I could see wrapping them.
fixed and fixed
I don't think these links are required since Github now has section anchor. See https://github.com/defunkt/resque#jobs
private final boolean invokeAsynchronously;
Does that need to be wrapped in `grobTree`?
What's the reasoning for only pinging hubs in production?
nesting is off here.  This block should be the same level as line 23.
Move declaration and initialisation to the same line.
Facebook has all of the above sizes.
I stuck with STAMEN-TERRAIN here because of how the project is set up (shows three different stamen examples in a row). It seems to work well in this location. How's that sound?
This was also a testing API call that can be safely removed
Is there a reason these are all split up?
Not that it's a *huge* deal, but I've generally been putting truly external code in the `external` directory so that we know where it all is and it's not surprising. You don't need to alter any of the code or wrap it in a `define`, since it's really a library we're including. Then, if it needs replacing, we can just replace the whole file, etc. etc. It might be worth keeping the original code in-tact so we don't have to worry that we've changed something by accident.
space after for and before the {
I see now. Why not set a flag instead of repeating the switch (even less copy paste). e.g. 
var clip = false;
...
case TextRenderingMode.FILL_ADD_TO_PATH:
  clip = true;
case TextRenderingMode.FILL:
....
if (clip) {
...
Why can't we use `typeof console !== 'undefined' && 'log' in console` here?
like above
It seems that the `Digest::SHA1` object is available once `require 'openssl'` is run. I've tested this in irb on 1.9.3 and 1.8.7, and it seems to be the same in both. That would explain why the spec testing the old-style hash isn't failing.
You should not check against `React\Promise\FulfilledPromise` as it's considered internal api
把函数指针typedef一下？
Should this be fenced to only be included when in development mode?
My intention was to document the N+1 requirement, but I can work with the must-be-terminated requirement.
Hack of Slide Horizontal Transition mentioned above.
4 chars? really ;)
nit : i would use globalHistory -> gh if I was you in case the prototype of your function is long
86c5ef7a9b5948862d40e195d8f306f442a74930
Actually, looking at the code, it appears that the dimensions must be equal.  It might be helpful to document that explicitly.
as far as I could tell, `fromlist` does nothing at all, but I didn't look too closely.  Do you have an example to help me understand?
That would be something like that loop typedef, which we considered "bad", right?
It would be simpler to move this block above the if "version" block, that way you wouldnt have to add another if statement.  Also, correct me if I'm wrong, but the way its written here, instead of waiting for a new block to come in after being disconnected from the first node, you are now just waiting for any message.  Though tx inv messages come in quite often, it may make more sense to move this block to the disconnect handler, where it would be called much quicker after a node disconnects (though I havent looked at locking implications of that).
I will ensure the docs are properly updated :)
`NULL` should be `null`.
You can break this description to 2 lines, its a bit too long
`LOG_ERROR` isn't part of the syslog constants, so we'll probably need to keep that one.  But the others should be removable.  It looks like they were defined even in PHP4.
We'll have to document these methods being moved in the migration guide.
Ahh, they are trying to confuse me.
This should be in the "As a... I want... so that..." format

As a user
I want to be able to vote on motions
So that the group can decide on shit
Does unviewed notifications return a scope (it should ideally) or an array. If it returns a scope, don't call size on it, call `count`, so that it performs a simple count query. Also, you have the constant "10" in two places in this code, move it into a constant or variable. Finally, this whole if statement  seems a bit fishy here in the controller, move it into a scope. current_user.unviewed_notifications.limit_read(10)
Is there any chance that `base_project_url` is a full URL (i.e., `http://.../`) instead of just a relative URL?  It seems that it might be easier to just do something like:
```
self.redirect(self.application.ipython_app/base_project_url.rstrip('/') + '/' + notebook_id)
```
I had the same reflex, about IPython.utils.js , i think we should merged it to have feedback as fast as possible.
Well then it's fine with me... :)
Added a new pull request to the develop branch , the old one was to the master branch , i had closed it :
the new pull request
https://github.com/laravel/laravel/pull/1274
@scunz Does this section say what you'd like it to say?
You're right, I'm on it!
Oh, sorry guys. Got distracted by other things. I'll split my submodule branch and push up some options today.
Jimmy your comments are very helpful to me.

Yes it is really verbose to maintain. 

thanks Again. 

I will accept your suggestion and move the comments to its own file too.
Please make use of Cc and Ci in all the cases.
Can you please keep the result consistent with the other services? I.e. return something like:

<pre>
{
  "hits": [
    { ... }
  ],
  "total": 3
}
</pre>
os_name_matches may contain a regex in the 'match_string', so ILIKE here is correct and '=' would not work properly.
这个文件在.gitignore里去掉吧
I won't belabor it. I think `statements/2` makes more ceremony than clarity, but not a big deal.
The same way you edited it before?
'$mixed' can either be a path to a template file as a View object. Considering this I am not sure what to call it. '$path' would be insufficient. Therefore I called it '$mixed'.
This is a very weak content-type. Almost better to forbid this if you could get away with it.
Ok, I wasn't sure the JSDoc stuff would output the function comments if they were private (not exposed).
Seems I've pushed an older version of this :)
private classes must appear after public ones
Ah, ok, seems like I'm missing some knowledge about string handling within Rails, good to know :)
I know this isn't yours but for sanity please switch this to !chatView
it's read-only ... can't access it that way.
This `EMAIL_SEARCH_URL` constant is now probably unused, I'm guessing.
没有黑体，这里没必要强调，要的效果是少而精，不是一大堆话，再加各种强调
into scalar values (instead of into a)
pvUnknown is the default here -- you probably don't need to set that unless you explicitly want to call out that it needs to be pvUnknown.
Internal build will only use whatever available in artifactory.
It doesn't seem like the module uses std.date, so the import could probably be deleted.
how can a plugin not have a placeholder?
You *do* need to be familiar with Ember.StateManager/Ember.State to understand the router.
I think you should keep a list of created views since they will stick around even if you do not use them.
@trisapeace i had to add Activity nearly everywhere, do you think we could just make it globaly availible like you did with Utils? how did  you do that?
Same comment as in HostControllerEnvironment.
Not required to get this PR merged, but I'd also like to see these tested:

1) Some host=master/child-type=y resource that isn't on a server (i.e. verify that reading master works)
2) Some host=master/server=x/child-type=y resource (verify that master can access it's servers)
3) The host=slave root resource
4) The host=master root resource
5) The host=master/server=x root resource
6) The host=slave/server=x root resource
Perhaps this makes sense?
```
if (selected == 0 || priority == 0)
    switch_pools(pools[0]);
```
Now I understand your proposal, updating the code ;)
manifestURL can be declare closer to this function call (where it is used)
nit: `e.g.` instead of `e.x.`

r=me as well
@alivedise Done, thanks for reminding.
Here I used function call because changing sourceType will change the behaviours of the PlayerView.
I wanted to let reviewers and me to know this is an action, not just changing a value.
But maybe I can integrate this function with <code>setDataSource()</code> which above mentioned,
of course it's better to refine this in the following up.
well done! removing those ugly conditions!
This is a nice utility function!
NIT: There are extra whitespaces
er, and note that POP3 is not currently supported at all.  It might be okay to just display the implementation value verbatim, possibly after calling toUpperCase on it or by styling it with the equivalent CSS transform.
ocd nit: there is a trailing space here
what if you don't set `allowPkInsert` to `true`?
You probably need some error handling here, if neither of those commands was found.  (This can happen with minimal Debian installs, at least, as can various "cloud" things.)  There isn't much recovery unless you want to use `/dev/tcp` directly, but at least you can give a clear error report.
This paragraph is a nice sentiment but it's too first-person. The author's voice should be more impersonal since this comes from the organization not from an individual. Maybe just say "we" (and take out the "sick of me talking" part), e.g. 

    We apologize for how long this document is! Hopefully it addressed
    most of your concerns about git, contributing, and github. Feel free
    to ask more questions on the 
    [railsbridge-workshops](http://groups.google.com/group/railsbridge-workshops)
    mailing list.
Also, could you add documentation for pivot/unpivot to Codesnippets.md?
Can you remove the case class and instead add an object with an apply?  Case classes can't be subclassed so we have tried to deprecate their usage as sources that we intend to subclass (also we don't use the pattern matching aspect).
Maybe add a test that exercises the weird behavior of mapStream (with the misaligned fields, etc)?
Actually I thought about it some more. This is more general than files so this is good as is.
Add ``@see theme_...``
what is e? needs a better name
I just tested and you're right, although the man page states

>      -f file       True if file exists and is a regular file.
9.0.0 is the minimum version, so you're fine :)
bzr doesn't (or didn't; see below) really have a sense of the "default branch name", because of the whole directory <-> branch thing.  Imagine, in git, if all branch operations didn't exist, so you had to use "clone" to create branches; that's how bzr works.  (It's a little more complicated, in that you can share the repo metadata between branches, but that's largely an implementation detail and not relevant to what buildbot needs.)

The 2.5 release of bzr introduced support for what bzr calls "colocated branches", which work like branches in git.  It's still very new; there's no default branch name yet, for example, and no tools really understand colocated branches yet.  So I'd assume that "traditional" bzr branching will be the norm for some time.

There's also no convention for branch naming as there is in svn, so it's hard to say what the default should be.  I'd probably just say that using "baseURL" requires using "defaultBranch" as well, and rely on that.  For the "repourl" case, I think we can ignore the "branch" parameter entirely.
and btw, the fact that you changed the lock file instead of having the lock file available in the master branch currently is the reason why tests are failing on travis
Yeah you were right. Anyway fix is here: https://github.com/composer/composer/pull/740
在服务器抽出一个config.java文件吧。
right - I circumvent bundle exec by setting the bundler option to false in my guard configuration block for rspec.
Yes, one of the timestamp types that the Napatech card can produce has a base of 1/1/1601 instead of 1/1/1970. Therefore I do the conversion.

Matt Keeler


On Oct 10, 2012, at 10:11 AM, Victor Julien <notifications@github.com> wrote:

> In src/source-napatech-3gd.c:
> 
> > +		
> > +		Packet *p = PacketGetFromQueueOrAlloc();
> > +		if (unlikely(p == NULL)) {
> > +			NT_NetRxRelease(ntv3->rx_stream, packet_buffer);
> > +			SCReturnInt(TM_ECODE_FAILED);
> > +		}
> > +
> > +		pkt_ts = NT_NET_GET_PKT_TIMESTAMP(packet_buffer);
> > +		
> > +		/* 
> > +		 * Handle the different timestamp forms that the napatech cards could use 
> > +		 *   - NT_TIMESTAMP_TYPE_NATIVE is not supported due to having an base of 0 as opposed to NATIVE_UNIX which has a base of 1/1/1970
> > +		 */
> > +		switch(NT_NET_GET_PKT_TIMESTAMP_TYPE(packet_buffer)) {
> > +			case NT_TIMESTAMP_TYPE_NATIVE_NDIS:
> > +				/* number of seconds between 1/1/1601 and 1/1/1970 */
> 1601?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
I checked the repository. First, it is not subdomains/prepage. It is subdomains/www/prepage. Sorry about the confusion. subdomains/www/prepage is in the repository and there are html files in there. Some of them are hard-coded for the present. Like quotes, calendar, and pop_ads. Others, like videos are generated.
Ahha, good point.

In this case, put your Org::Zenoss stuff in a separate library file, such as lib/logstash/utils/zenoss.rb and require 'beefcake' there, then from your new plugin, in the 'register' method, do require "logstash/utils/zenoss" maybe?
Though, I wondered: what about international emails? Or emails with other strange characters in them? We'll still have an illegal id.
I would leave this as 'Changeset' as it is one word and seems to be used everywhere.
Move to `examples`?
yo/you
if you expect an array, then add the type in the signature, but don't use this kind of Hungarian notation.
<pre>
unless type = R_E_N_T_K[kind]
    raise
end
</pre>
It's an instance of `RSpec::Mocks::StashedMethod` which conditionally stashes a method only if its needed.

I think that you're right that the class and variable are a bit misnamed--the name implies it is always stashed when that is not the case (which is why we check `method_is_stashed?` here).

@alindeman -- you came up with the `RSpec::Mocks::StashedMethod` abstraction originally...what do you think about renaming it to `MethodStasher`?  That makes it clear that it's role is to stash methods without implying that it always does so.
`Ska.DBI` is not used.
1.3.2. Spoutplugin doesn't have the Axis portions, so this would break JukeIt for SpoutPlugin 1.3.2 (which is current stable). Also I fixed spoutplugin to use default Axis.Y for reverse compatability and to keep plugins from breaking: https://github.com/SpoutDev/SpoutPlugin/commit/1f53621694a17f877e5a0cef487faa28aa00d005
not work ( equals ) for me. wait, where is the TestClass ? i can't found at the asset folder
I know this is not where this should be defined -- it will be defined in a more appropriate location.
Asterisk is any version, symbol, e.t.c...
So, there is no way to remove the 404 when reading the README.md on github project page ? cf : https://github.com/zendframework/zf2
$numEntriesPerPriority means number of entries per priority level, it sounds good for me.
Putting this check first avoid to do the same checks that there are above
c'e' un po' di confusione tra "noi" e "tu" nel testo. Non e' molto rilevante, ma consiglio di fare piu' attenzione :)
Should be this Exception\InvalidArgumentException?
This should be surrounded by // CraftBukkit start and // Craftbukkit end, correct?
will remove one
should be 1 space-line before ``return``
This should be just `Repo`.
Allright, will do, thanks for the feedback.
I think quite different :P. I like to know what plugin is printing out what information.
We use the todomvc.meteor.com url.
Or we can do here nothing (i. e. using only `''` for disabling file writes)
Forward declare this.
fixed all occurrences
Why is this in the `Persisters` namespace?
we had those arguments on purpose because we thought there might be a use case when you need the document or metadata to decide
I think it should be possible to completely get rid of the states for MOVED
or REORDERED. This is the same as MANAGED. I changed that yesterday and all
but one MoveTest still pass (the test not passing assumed that a persist
after a move results in the move not being executed).

2012/9/4 David Buchmann <notifications@github.com>

> In lib/Doctrine/ODM/PHPCR/UnitOfWork.php:
>
> > @@ -631,6 +644,29 @@ public function scheduleMove($document, $targetPath)
> >          $this->setDocumentState($oid, self::STATE_MOVED);
> >      }
> >
> > +    public function scheduleReorder($document, $srcName, $targetName, $before)
> > +    {
> > +        $oid = spl_object_hash($document);
> > +
> > +        $state = $this->getDocumentState($document);
> > +        switch ($state) {
>
> can you do those tests with combined operations to see if things break? i
> am a bit afraid of merging without knowing what happens. if we hit problems
> that are hard to solve, i would prefer to throw some exception rather than
> create a hard to debug invalid state with hidden data loss.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/doctrine/phpcr-odm/pull/171/files#r1521516>.
>
>
The fact that @inheritdoc reduces readability is an argument. But honestly,
I'd rather have to jump to ther parent method, rather than having outdated
documentation due to copy/paste + entropy.

I think that we can require that our users, at least those who have
interest in reading our code will rely either on the generated
documentation OR on a feature-rich IDE rather than on reading code only.
This assumption makes it really easier to provide, accurate, up-to-date
documentation.

In any case, I think we at least all agree that if we choose not to
copy/paste parent documentation when it is identical, it is useless to add
@inheritdoc. This should be automatically handled by IDEs and doc
generators. And actually, it is.

I have checked support on *sami* (http://ezsystems.github.com/ezp-next/sami),
and it indeed isn't *perfect*. I have also checked PhpStorm 5. There are
the results with a validate function, in the Image\Type class, inheriting
from FieldType.

*No phpdoc at all:*
- sami: documentation from parent is re-used
- phpstorm: documentation from parent is re-used

*Inline {@inheritdoc} with extra documentation*
    /**
     * Overridden documentation.
     * {@inheritdoc}
     */
- sami: Prints out {@inheritdoc}
- phpstorm: Doesn't take the local changes into account

*Override short description in the child method*
- sami: replaces the parent's short description with the child's. Parameter
& return & @throws docs are maintained.
- phpdoc: replaces the parent's short description with the child's.
Parameter & return & @throws docs are maintained.
This change is needed for providing a negative margin if the image is higher than the image container.
Can this just return the string? The API I expected is `decrypt(encrypt('string')) == 'string'`.
I can certainly copy and paste the instructions back into the individual 
quickstart README files. I'm with you; there's a balance between 
navigating and maintaining the same text in multiple files.

On 03/29/2012 07:17 AM, Pete Muir wrote:
>>   ----------------------------
>>
>> -This quickstart provides Arquillian tests. See [Run the Arquillian Tests](../README.html/#arquilliantests) for more information on how to set up and run the tests. When asked to start the JBoss Server, this quickstart requires that you start it with the _web_ profile.
>> +This quickstart provides Arquillian tests. See [Run the Arquillian Tests](../README.html/#arquilliantests) for information on how to set up and run the tests. When asked to start the JBoss Server, this quickstart requires that you start it with the _web_ profile.
> I'm not sure, let's chat on IRC.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/pull/167/files#r620498
Could you comment on that? If the PT gem needs those but actually doesn't pull them in, I'm happy to work around it this way.
There should be a space between the `if` and the first paren for style consistency, and you should use a strict equals comparison (`===` instead of `==`).
Actually, this isn't even being used anywhere. Remove it completely an disregard the comment for line 1220. Again, confused how linting isn't picking up on this.
Some wild whitspace above!
Shouldn't this be logged?
Checking one client is a good start, but maybe you have the time to modify the health check to receive an array of all clients?
我搞错了:)
Since you're using the ZU shortcut below, this should technically be 2.1.9 (http://www.zotero.org/support/2.1_changelog#changes_in_219_september_3_2011). It's not really that important in this case, because translator updates are not pushed to clients that are older than 2.1.9 (IIRC) anyway. Other than that, this looks ready to be merged.
Why tilt?  This is all in the plane, right?
This is pretty cool! It would be nice if it did this for all three hints, instead of just this one
Why can't these methods just use the supplied Set objects (rather than making copies). This method is called with Set objects obtained from the SessionNode.getChanges() object, which itself makes a copy of the sets. Therefore, this method is technically making a copy of the copy of the actual changes.

I think having the DocumentChanges be an interface without these mutator methods would help, because the DocumentChanges could be constructed with the actual objects it should use directly. This more closely fits our use case. Alternatively, having these mutator methods means that the class should perhaps handle this method being called any time after construction; this appears to not only be unnecessary, but it adds complexity and exposes functionality where it's not needed.

Thoughts?
while this will almost always work, it's potentially dangerous writing to the current working directory. You don't know if the user has write permissions to the directory he is currently in.

Often it's nice to write to a tmpfile or the users directory in a hidden folder for the application
Might be worth emphasising that (maybe italicising "nightmare" or putting some kind of wink face).

On 5 Aug 2012, at 18:20, MSuhajda wrote:

>> +
>> +### Installing Node Package Manager (NPM)
>> +
>> +The latest version of Node includes NPM with it, however if you are using an older version of Node, you can still install it!
>> +
>> +- On UNIX systems:
>> +
>> +		curl http://npmjs.org/install.sh | sh
>> +		
>> +- On Windows:
>> +		
>> +You can download a zip file from <http://npmjs.org/dist/>, and unpack it in the same folder where node.exe lives.
>> +
>> +### Installing Socket.io
>> +
>> +Installing Socket.io is a nightmare:
> 
> Yup
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/callumacrae/lynx.io/pull/5/files#r1308339
The MetadataCache is by design meant to be agnostic to whatever it is used for. So this method should be part of the OaiPmhService, not the record itself.
(もしくは有効なキーの配列)
I have to check but I think this is the default behavior by using Ares to develop.
`getStringLengthPrefixFromLength` maybe. But I stick with `getStringPrefixFromLength`, that should be enough.
`infact` => `in fact`
cvan just added a .login class to it for logged-out users and changed .logout so that it's shown for logged-in users only.
Hey Marc,

Thanks for the pull req! The problem with doing it this way is that we're not going to pick up cluster-wide configuration settings, or settings that are supplied dynamically using `with-job-conf`.

The right way to do this is to modify KryoService to accept a JobConf, and use this to build a `SerializationFactory` in the same way that the MemorySourceTap does it: 

https://github.com/nathanmarz/cascalog/blob/master/src/jvm/cascalog/TupleMemoryInputFormat.java#L133

This is almost exactly what we need to do. I think you can downcast the `FlowProcess` that comes in through a BaseOperation's prepare method to a JobConf and pass this through. What do you think?
I'm fine with using the space check as a workaround, but I'd also like to see this reported somewhere, as I really don't think this should be happening
The sample fluorescence slide that I have has *three* images: a brightfield thumbnail, a fluorescence thumbnail, and the main image.  In anticipation of that, it might be better to get rid of the hardcoded image1/image2 stuff and use a proper loop.
For the Quadshot, I need different command laws for the elevons depending on the RC mode. Since the RC mode is not accessible in the command laws, I added it to the commands using SetCommandsFromRC (see the command laws in gain_scheduling_example.xml).

Alternatively it can be done by making the command laws macro accept the mode as well.
i didn't do this...sorry
If this will be checked very frequently, it may be better to store this in a hash instead of an array, looks like for "is in" will be quicker.
Can you elaborate on this a bit?
You specify an empty string, yet you pass in null in the example.

What about only accepting 2 *things* 
* String: Set a (new) role for a principal.
* false: Remove a role for a principal.

All other things (null, undefined, true, ...) are explicitly denied before the _updateContentLastModified by some sort of validation.
logging -> login ?
I think the `fs.unlink` returns an error in the callback that we should probably log with a warn if deleting is not successful.
It is used by the authentication API to delegate creation of a user. I think it's necessary because a lot of other high-level stuff will come out of this method, such as firing events. I could rename the other to indicate it's creating a user with a login id.
These should be moved up to the next line according to our style guide `} else {`
I think you will need a Expr* list in your implementation of Shape. and HicudaExprList is already defined.
Sure! Just double-checking before doing it. You only need the ClientRequestExecutor.java and ClientRequestExecutorFactory.java changes, right?
msg attribute
`array_merge` useless.
Same here, we should filter on IPs.
Is it still classed as a hook?
That's not caused by putting the player argument, which is required and therefore should stay there. That's caused by not returning true in the CommandListener.java.
Just thinking whether the slider can go in a more relevant location. Not a blocking issue for me currently.
"Версия компилятора тут только при том, что она определяет, поддерживает ли он определенный стандарт языка" - это и есть ключевой момент. Вместо того чтобы задумываться какой стандарт поддерживает тот или иной компилятор, я просто написал код так чтобы он собрался везде.  На момент написания кода это было вполне оправдано.
Благодаря вам я узнал какой компилятор используется в XCode. Есть ли смысл переписывать код с использованием расширенного функционала? Сомневаюсь.
Но даже если и переписывать, то скорее в сторону
    int index=0, distance=0;
    for (; index < [dna count]; index ++ ) {
    ...
    }
ИМХО так читабельнее.
Генерацию значения лучше бы вынести в отдельный метод, чтоб не повторять  его несколько раз.
спасибо, проглядел
Uhm, some comment that "this selects the last HTTP/1.0 ... " line that shows up in the curl output. There can be multiple because curl follows redirects?" :-)
It's probably not too big of a deal, but perhaps we should prefix these 2 variables with an underscore ("_nodedir" and "_copy_dev_lib"). I mean I doubt anyone would use those variable names, but we might as well hint that you shouldn't use them in your own gyp files.
I thought about this one after the "0" issue. So - "array func_get_args ( void )" - this will always return an array. In this case, empty() is safe enough, as it'll either be array() or array(0=> ...)
Can you add a space after `if` and then rebase all of these commits down to one?
Array.isArray() is ES5 only, not supported in earlier browsers & not suitable for mobile.
Shouldn't this schedule on `+currentScheduler` instead? Calling the block synchronously triggers #94 right?
Skal jeg endre det i pluginen? Litt usikker på hva som er OK å gjøre når man låner andres arbeid :-P
Ok - then I shall add a default val for these records and re-request
Should the `lastevent` variable be declared inside the `vmousedown` callback? Otherwise it seems like it would prevent and follow up `vclick` event's triggered after a `mousedown` for a given element.
I think this test may not pass on all platforms. Unless I'm wrong, this number takes into account **your** global and system configuration stores as well.

Moreover, git may even *not* been deployed on some computers (which would make `repo.Config.HasGlobalConfig` and `repo.Config.HasSystemConfig` return false). Interestingly, our own CI server (Codebetter TeamCity) falls into such category :)
Good catch - see aec0563dd13a73a2e2bacb4abddb4670e6e1d705
This is not a heading, it's the module's docstring
yep, I'll keep you posted
+1 for this, I think this should be sufficient for most people.
Why do you hate the periods
I don't like the "eog" default as it's often the case that there is 2 EOGs (one vertical and one horizontal)
I'd rather let the user pass the proper channel name and do a pickt types before
I was referring to all the stats logic, not the environment mismatch check. The check is fine.
Probably want to remove this, I can do it during the merge as well.
@cordoval maybe it's because I'm not a native English speaker, but I've never heard of this rule. Could you provide any grammar resource that discusses it? If it's right, we should also correct the rest of the documentation, there are many entries where it is not respected.
`Composer` - capital `C`
Just the same style comment: `===`, and maybe a comment on what this comparison is doing then it looks good
No. Fixed
awesome, I updated the tests and fixed some of your lint errors: 75db26fbfab23c5cb9db48b4fe2d632c3ef0a9d9
It's true that calling this variant of `unstashAll` twice in a row is problematic, since it calls `become`. So, I think the simplest solution is to remove this version of `unstashAll`. It doesn't add much anyway. If someone likes it, they can write it themselves, and then they are aware of what's going on.

In contrast, the semantics of the parameter-less version of `unstashAll` should be completely clear (calling it twice in a row is the same as calling it once).
well if you want to keep the default value, it is not possible,
you just made me realize that I forgot to set default_value=True for all these traits.
Testing against the internal `@reserved_connections` hash is not a good idea.  We use thread object ids to differentiate connections, but that could change in the future.  This is a brittle way to check out expectations.

I suspect you were required to write this code because the test is using the global connection pool.  Using the local connection pool should help clean this code up.
@qiangxue proposed a good change. I'm talking about another thing at the same line: `&& $default!==null`.
С чего бы это нельзя?
Можно и `auto& map = ...`
Ok, me confunde que tengas un objeto exception separado dentro de MigrationMessage si al fin y al cabo sólo usás Message. Pero tenés razón, de la Exception se genera Message así que mi corrección estaba mal.
What's the point of this `_clean()` method?
Please see how the Auth module is doing the internal add/creation:
https://github.com/aerogear/aerogear-ios/blob/master/AeroGear-iOS/AeroGear-iOS/security/AGAuthenticator.m#L39

I hope to get rid of the internal add; since more and more options blow up internal add - using the config object instead
you should probably better wrap it like this : 

`' ('` . implode(' OR ', array_unique($coll_filter)) . ') '
Why using container here (and below)? Service / Service instance are what we use everywhere else for user facing stuff, do we want to change that?
Can this be done better than "wait some time". Perhaps repeatedly wait_for_status until an exception arises?
so if mysql failed to restart we generate the instance status from the states of the system not the tasks?
what is here? am i here? who's there?
so we are just removing the raise here? This is fine, we'll just have to follow thru and make sure there's no dangling instances.
Ok, I didn't realize it was still used.
`$this->session->remove('isAuthenticated')`
It should be `[matrixId.tileWidth, matrixId.tileHeight]` for matrixId in `layer.matrixIds` it you haven't that consider using simple WMTS: https://github.com/mapfish/mapfish-print/blob/master/samples/specWMTSsimple.json
see also: https://github.com/geoext/geoext/blob/master/lib/GeoExt/data/PrintProvider.js#L687
and finaly can be somthing like:
```
[
(maxExtent[2] - maxExtent[0]) / (resolution * tileSize.width),
(maxExtent[3] - maxExtent[1]) / (resolution * tileSize.height)
]
```
Could you make these blocks?

```
if left is None:
    left = old_left
```
Nicely done with the custom error message!
The locators are named a bit differently. this is not a <select> element at all. It's just an input checkbox. So line 64 needs to be changed to just find the element and click it. Line 65 is not required.
Please expand on that? I did not use one, so if you could tell me _what's_ wrong and _what_ I can change it to then I might find your comment useful.
This will not work on any other machine than yours
Why don't we allow any "System.ServiceModel.Dispatcher.ExceptionHandler" here?
should we add a small utility function to get the rowSign, since this is used more than once?
BTW I also removed length on float fields.
Same, regarding attr_accessor.
why are you calling int? this looks duplicated, too...
@arnodeclercq We should use `on` instead of `bind`.

Thinking about this a bit more, can't we just add the `jqmClose` class to the buttons instead? (in the html -> this will need some testing)
problem is though that #classes that can be found in label (subset)
might differ from #classes of the problem...
Same here, why changes for GridField in this PR? Please try to isolate into separate commit (same pull request is fine, but intention should be clearer than "somehow part of preview feature")
Do you think this could fit under user settings?
There's a problem with this approach where the font attempts to load in a browser with the WebKit fallback bug and then fails to render. The width will change from the initial fallback size to the size of the last resort fallback, and then back to the size of the initial fallback. This is two changes in size, but it doesn't mean that the font has successfully rendered. (In fact, it's *not* rendering.)

Instead of just waiting for two changes in size, we actually need to remember what the initial fallback size was. If the WebKit fallback bug is present, we also need to remember the last resort fallback size. Then, as we're watching the font, we need to ignore both of these sizes. Only a change to a third, new size would be considered active.

In the timeout case, we should only return active if the last observed size matches the last resort fallback size, and not in any other case.
This javadoc doesn't convey any information not already in the names, it can be removed.
Please fix capitalisation.
The Xerces parser complains about it with tons of exceptions:

org.xwiki.rendering.parser.ParseException: Failed to parse input source[...]
Caused by: org.xwiki.rendering.wikimodel.WikiParserException: org.xml.sax.SAXParseException; lineNumber: 3; columnNumber: 26; The entity "nbsp" was referenced, but not declared.[...]
Caused by: org.xml.sax.SAXParseException; lineNumber: 3; columnNumber: 26; The entity "nbsp" was referenced, but not declared[...]

Tried with legacy mode (http://www.whatwg.org/specs/web-apps/current-work/multipage/syntax.html#obsolete-permitted-doctype-string) but sometimes work, sometimes not:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
<html>
<p>This is <strong>&nbsp;bold&nbsp;</strong></p>
</html>
Fixed and added comment.
//TODO review this part of code if layout height/widht - 'auto' and right/bottom properties will be implemented for BB
"Give first-time users early wins by avoiding signups. Save pain for experienced developers by avoiding weird object instantiations."
really it's YARDoc that provides `@params`, etc... RDoc sux
Yeah, couldn't think of a useful name. :-|
Should it throw an exception? Or return `null`?
So, I think that for your usecase,  stopping at top isn't good enough

It is quite possible to write a test that has to be run in a top level browsing context. Although it is possible to place the burden on authors and say that if they do that they have to open a tlbc themselves (and indeed for some tests that is a rather sensible thing to do e.g. where precise control over the history is needed), it is a lot of overhead for many tests. So a test runner should always window.open a new browsing context for the tests to run in, rather than using an iframe or similar. Hence if you want to report back to the harness you also need to ascend into opener windows.
I added a couple lines to the main project README, and stuck a README in `css/notify/` with some more info. Let me know if they make sense.
You are right. It would be better. I'm checkin the API and PR the changes!
From chat with Ryan: Nope, dependencies require slash whereas everything else requires dash. This is due to architectural issues with the Forge and they're working on it.
So instead of using the `doSubmitToProduction` field when we want to do testing, we'll simply create evaluations specifically as Sandbox jobs? (Makes sense to me, just confirming.)
Don't we have `buttons` class for those buttons?
I didn't. Don't know where this came from
Where do you define `error_data`? You might above if `state` is empty and `state[0]` does not exist. But you currently don't do it.
?????????????????????????????????????

Why not simply pass a JavaScript object and all this will be done automatically by jQuery. ;-)

```
'data': {
    'message': $('#post_text').val(),
}
```
Simply wrap in `<p>` instead of `<div>`, or unify somehow. So maybe move one `<div>` up?
Text mybe?
No, I meant it was better fixed :/

Sorry for the confusion.
(T* unit) was ok, why this was changed?
aha,understood now.if your PR gets in,i'll remove the 

```
case 49882: // Leviroth Self-Impale
```
from this PR and let the rest of the things,as those are needed also.
What is this comment telling me?
Tracing into the cascading code, this is how the ```getRecordReader()``` is invoked:

```
private RecordReader makeReader( int currentSplit ) throws IOException {
    LOG.debug( "reading split: {}", currentSplit );
    return inputFormat.getRecordReader( splits[ currentSplit ], conf, Reporter.NULL );
}
```
renamed kiji.test.standalone

I don't know what it.test is for, can you give some more context?
BuildMI implicitly marks its last argument as being defined, so that's why I moved DestReg into BuildMI.  This is a super-confusing API.
I am not sure yet what value we want to expose here. I think time will tell
On 2012-10-31 22:41, Jeff Kaufman wrote:
>
> In src/ngx_pagespeed.cc:
>
> > @@ -569,6 +569,9 @@
> >      return ngx_http_next_body_filter(r, in);
> >    }
> >
> > +  ngx_log_debug1(NGX_LOG_DEBUG_HTTP, r->connection->log, 0,
>
> |s/ngx_log_debug1/ngx_log_debug/| ?
>
> |(%V, str)| exists? I'd been using |(%*s, str.len, str.data)|
>
%V is against ngx_str_t *. It's better than the %*s while this is the 
Nginx way:-) .
>
> Would unparsed_uri be better?
>
That's fine. I just want to log the current request and show it enters 
the body filer. The whole request uri are logged in the debug log in 
other place.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/pagespeed/ngx_pagespeed/pull/13/files#r1992832>.
>


-- 
Thanks,
-Weibin Yao
I think you're right: merging the global options into the directory specific options as part of our configuration process would be more efficient.  I'll look at that.
I thought that a partially working OMZ is probably better than no OMZ. Being pestered with errors is not good though. I'll take another look.
https://groups.google.com/d/topic/pystatsmodels/4O-C5-nY0Dc/discussion

I think it's incomplete refactoring that we have both in the ``__init__`` or exog is for the strata, stratification (I need to check again)  
``surv`` is ``endog`` IIRC

I'm not sure where we go with this. 
I like Survival as a class to hold the data descriptive information, instead of attaching everything to the model classes. Also a Survival data instance needs to be created only once, and then can be used with all the related functions and models.
I kind of got to like this idea, but it's a bit of a break with the current signatures.

(I worked a bit similar to this with repeated measures/panel data where I keep internally a Groups instance.)

Preliminary opinion: I would keep Survival as a class for internal use even if we move to a more "standard" signature.
Unnecessary curlies. NOOOOOOOOOOOOOO!
I agree, removed the flag and setting highlightSeriesBackgroundFade to 0.5 by default.

I was paranoid about it being too slow on some browsers, and I wouldn't want to make the interactive highlighting unusable due to the repeated animation-related updates where the unanimated version may work acceptably well. But users can set highlightSeriesBackgroundFade to 0 which disables both the fading and animation, I'll that to the docs for that option.

Going forward, what would you think about a global animation preference that would also cover the zoom animation? Maybe two levels, one to turn on comparatively-cheap animations that just redraw the overlay, and a different one for animations that require full re-rendering?
It is square.  Seems like the better thing to do, since this isn't a radial profile, so the square region is I think the more relevant thing to do.  But you're right that the debugging statement (which I probably just copied from other profiles' corresponding debug statement) is confusing.  I'll change it.
A minor point -- you don't need the dereference (*), since you aren't using this value.  So just `imageptr++` would suffice.  

(Or even `++imageptr` would be slightly more idiomatic.  It's considered better form to use the prefix increment operator, since for non-simple pointers it is more efficient.  But for pointers to POD, the compiler will optimize them both to the same machine code, so it doesn't really matter here.)
It's in the dox as galsim::hsm::HSMShapeData.  Would it be sufficient for me to directly link to that instead of just writing "HSMShapeData"?
Thanks Mike!  Yes, that was a missed relic from my first attempt at ASCII I/O.  Things are clearer now we adopted Mike's scheme.
So the idea here is that you want to allow more input formats without making the ```getShear``` functions themselves longer and more complicated?  Makes sense.  The only possible confusion I see is that we also use ```pos``` for the position of the NFWHalo lens.  We should clarify that this is for parsing the input position arguments for sources that are passed to the ```getShear``` and ```getConvergence``` methods.
Debugger code is still present
It wasn't displaying the help message that I wanted. Namely the message did not include a "type brooklyn help <command> for more info" statement.
I will refactor and add a LocationSummary class both for list() and get().
please use `camelBacked` notation: `hasErrors`
??? wtf
The removed methods in this module, it it duplicated or old code?
If that works then we can have an additional test that overwrites this profile preference using --firefoxprefs
use empty world from cob_gazebo_objects (we have our own lightning settings and camera views
This is not correct, you forget to free the result of mongo_server_hash_to_server().
dict.setdefault() retorna uma referência ao ítem recém criado em dict. então, este código ficaria mais correto assim:

  numbers = volume_node.setdefault('numbers', [])
  numbers.append(issue)
Again, it's an artifact of jobs not being refreshable instantly. They may take a moment to be available. I took the sleep out of read (which was called by refresh), and switched to isReady and isDone methods as Wim as in the Java SDK.
If a `sleep` is needed, then this test is brittle. Consider rewriting.
@fabpot Should I squash my commits with every push or should I wait with squashing until the end of our discussion?
Only in declaration or also at method calls?
What happened to our coding conventions?
Just a quick idea. What about adding something like "status code extension objects" that can be added to the Response via a method like addStatusCodeExtension()?

This way you can add status codes without handling the array itself.
sure
-Geoffrey Parker


On Sat, Mar 3, 2012 at 11:18 PM, amshali <
reply@reply.github.com
> wrote:

> > @@ -9,131 +9,124 @@
>
> Please revert this  change. Let Lauren fix the indentation.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/w7cook/OpenBook/pull/22/files#r515420
>
It is preferable to remove lines of code instead of commenting them out.
There is a 'children' list for every organ, can just iterate over it, no need ot go theough all organs.