labofsahil/github-event-dataset-2012 huggingface dataset:
Don't need to do this check. We have a try catch around all setup, start, end and teardown that does what is specified given Popcorn.plugin.debug.

https://github.com/mozilla/popcorn-js/blob/master/popcorn.js#L1511
I already test for autoplay and loop working, so this just tests that they are set when they would be read.  This is fine.
Transforms will have output_bindings as a [class variable](http://www.python.org/doc/essays/ppt/acm-ws/sld051.htm).
Do we need / want a generate_countdown_html for feedback_comment, too? (I don't know what are the upper limits, but presumably there are some.)
The tests aren't done yet, I forgot there is an open pull request on this.   We can cancel it whilst I get the kinks ironed out of these tests.

On Mar 27, 2012, at 10:33 AM, Tim Simpson wrote:

>> @@ -101,3 +105,15 @@ def test_root_restricted(self):
>> 
>>     def test_instances_index_restricted(self):
>>         self._test_path_restricted('instances')
>> +
>> +    def test_get_guest_info_success(self):
>> +        controller = reddwarf.api.management.Controller()
>> +        status = mox.MockAnything()
>> +        status.is_sql_running().AndReturn(True)
>> +        self.mox.StubOutWithMock(controller.guest_api, 'list_databases')
>> +        controller.guest_api.list_databases(FAKE_CONTEXT,
>> +                                            FAKE_INSTANCE['id']).AndReturn([])
>> +        self.mox.StubOutWithMock(controller.guest_api, 'list_users')
>> +        controller.guest_api.list_users(FAKE_CONTEXT,
>> +                                        FAKE_INSTANCE['id']).AndReturn([])
> 
> I might be missing something but where is Controller._get_guest_info called?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/rackspace/reddwarf/pull/424/files#r609566
Any reason you didn't just use display: none?
options should propagate for ready and we should have some other more obvious distinction for top level and not.
We don't need to say "in the problem above" since it should be obvious. I think this is probably worded this way as a result of the somewhat confusing order of hints where the first hint asks a rhetorical question that isn't answered until the fourth hint.

Perhaps we could use definition popups (from utils/subhints.js, like we do for the term "noncollinear" in points_lines_and_planes) so that the terms "converse", "inverse", and "contrapositive" in the first hint can be clicked on to get a definition of each instead of defining them in hints #2 and #3. Then the rhetorical question asked in the first hint can be answered in the next hint. (maybe with a little more explanatory text in case people don't click on the definitions? i dunno)
stupid lousy floating point :(

![Imgur](http://i.imgur.com/653su.png)
Templates, sample files, or generators should always be provided.

A sample knife config should be provided in a test directory much like this yaml was.
django_sha2 currently includes: SHA256, SHA512 and base64-encoded SHA512 (see readme, towards the bottom). The latter is more of a gimmick because the default PW field in Django < 1.3 (or <= 1.3? I don't know) is too small for a SHA512 hash. You should be able to subclass those fairly well.

PS: I can't believe Django hardcodes the algorithm name in there, they could make our lives so much easier by using the "algorithm" attribute to determine which method in hashlib to use :-/
Bugger. Forgot to remove the rescue. Sorry 

On 16/03/2012, at 4:10 PM, Joshua McArthur<reply@reply.github.com> wrote:

>> -      :html_body => erb(:"mail/#{options[:template]}", :locals => options[:locals], :layout => false),
>> -      :via => PONY_OPTIONS[:method],
>> -      :via_options => PONY_OPTIONS
>> -    )
>> +    begin
>> +      Pony.mail(
>> +        :to => options[:to],
>> +        :from => options[:from],
>> +        :subject => options[:subject],
>> +        :html_body => erb(:"mail/#{options[:template]}", :locals => options[:locals], :layout => false),
>> +        :via => PONY_OPTIONS[:method],
>> +        :via_options => PONY_OPTIONS
>> +      )
>> +    rescue
>> +    
>> +    end
> 
> I'm not a big fan of this - I get that this was probably rescued because there was no SMTP server in development (Mailcatcher, btw)[http://mailcatcher.me], but if mail doesn't send, I'd like to know about it with a big nasty 500.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/joshmcarthur/Latter/pull/12/files#r566553
Ik heb een paar namen verzonnen die iets meer sense maken. Bedankt voor de
suggestie. Als het geen (syntax) error gooit is het nu ok geloof ik.

--

Daan Sprenkels <dsprenkels@gmail.com>



On 18 July 2012 21:11, Jille Timmermans <
reply@reply.github.com
> wrote:

> > +    A JSON string will be returned containing the information.
> > +    '''
> > +    if (request.REQUEST.get('fetch') is not None and
> > +            request.REQUEST.get('user') is not None):
> > +        token = sha256('%s|%s|%s|%s' % (
> > +            request.REQUEST['user'],
> > +            date.today(),
> > +            request.REQUEST['url'],
> > +            settings.SECRET_KEY)).hexdigest()
> > +        if request.REQUEST['token'] == token:
> > +            properties = {
> > +                'username': request.user.name,
> > +                'humanNames': list(request.user.humanNames),
> > +                'humanName': request.user.humanName,
> > +                'cached_groups': request.user.cached_groups,
> > +                'cached_groups_names': request.user.cached_groups_names
>
> Kunnen we dit niet mooier `groups` en `group_names` noemen? Het `cached_`
> deel geeft alleen aan dat het binnen deze request gecached is.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/karpenoktem/kninfra/pull/83/files#r1190866
>
Can we not add this to the JAVA_ARGS?  Is that the problem you were having with bash sourcing or something?  If we could add it there, then it would prevent the duplication and it would also work for puppetdb-foreground (which isn't incredibly important, but, for consistency it wouldn't suck)
Small change suggested here :

"Sorry, '%{email}' is niet gekoppeld aan een account. <br/>Weet u zeker dat u het juiste e-mailadres heeft ingevuld?"
Ah, yea that would be useful. Would probably need to take both a tenantId string and principalId string.
The docs for a module can probably be cached on first read to avoid going back to the disk on each request.
We need to be able to return an error when no `tenantId` has been supplied.
And another one ;-)
why the <R>?
Я так понимаю это перменная используется только в -(int)getHummingDistance:(Cell *)anCell, или нет? Просто зачем объявлять ее тут, если фактически она локальна и достаточно было написать int counter = 0; ...; return counter;
Заполнение пустого массива лучше делать через addObject
рус буквы
Where is the return value set if the user cancels the dialog?
You forgot to change for '.twoStepConfirmation'.
Extracted this into the MANIFEST file as a step toward automating the check to see if everything's there.
spaces are missing here and on line 37.
I think bubbling up would be ok. In which case, seeing the following would probably be common:

    for result in qs:
        try:
            obj = result.object
        except ObjectDoesNotExist:
            pass  # User defined something or other.
Oh you mean put the function tupled into trait Variant[M] ?
Because it passes in the page as an argument to the selected_page? method.  Equivalent to this: 

page.descendants.any? { |p| selected_page?(p) }

http://andrewjgrimm.wordpress.com/2011/10/03/in-ruby-method-passes-you/

Do you think it's worth it?
Bad i18n again. Whole sentence is needed for a proper translation.
Yeah, that's more concise. Seems less obvious what's happening though.  Unless there is a performance difference (which I don't think there is), I prefer clarity and readability over brevity.
Oh yes, thanks for catching this one!
You should only need one Hyperedge as a backpointer.
I don't understand the problem ?
I prefer to create a code block here or, even better, a configuration block with all formats:

    you can do this:

    .. configuration-block::

        .. code-block:: yaml

            requirements:
               _locale: %locale%

        .. code-block:: xml

            <!-- ... -->

        .. code-block:: php

            // ...
This is evil. Text should just *work*.
operator[], плюсовее будет.
И я бы не сюда добавил, а более глубоко. Возможно, в трей. Но не в контекстное меню вкладки, нет.
these constants looks really weird. You are making the pattern configurable, but you are making assumptions about the order of the placeholders in the configured pattern
nitpick: use real URLs here, and example.com. e.g. myorg.example.com
XSS filtering is part of the LanguageSettings model and obsolete here
For me it was a better understanding of the code.
I think jinja2 has autoescape default of False, this will create backwards incompatibility. I'd like to keep ti default to True, since this provides better security.
use {{ module|title }} instead of declare 'module_name'
Agreed. Python 3.1 support isn't really necessary.


On Tue, Nov 20, 2012 at 10:53 AM, Jesús Leganés Combarro <
notifications@github.com> wrote:

> In setup.py:
>
> > @@ -99,6 +102,7 @@ def find_packages(base):
> >          'Programming Language :: Python :: 2.4',
> >          'Programming Language :: Python :: 2.5',
> >          'Programming Language :: Python :: 2.6',
> > +        'Programming Language :: Python :: 3.3',
>
> Really? I have heard that the one widely adopted and with a good
> compatibility backward status is 3.2 / 2.7... The more the better, but I
> wouldn't put 3.1 a priority, and in fact I would focus on 3.3.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/andialbrecht/sqlparse/pull/81/files#r2178495>.
>
>
this has nothing to do w/ this PR, but we need fix this empty list db shenanigans that i added ;) Just a mental note
I don't understand some of this pagination stuff, but shouldn't next_marker refer to the name of the db that is one past the list? I.e. if the list is "A", "B", "C", "D" and "E" and the limit is three then shouldn't the list returned be "A", "B", and "C" with next_marker == "D"?
s/rout/route/
Ha! Yeah I guessed that it was bytes :p.
This is issue #881, for others' reference.  Maybe we should "soft deprecate" them by saying they don't really belong here and shouldn't be used?   Like gist_gray is identical to gray and should never have existed, so I just list it as "identical to gray".  should I go a step further and say "deprecated, use gray instead"?
Done! I usually use triple quotes too, but I wanted to follow some convention so I had just looked at a function a few lines above... which has single quotes ;-)
I didn't see any new tests to handle these cases. Are they there and not in this change set?
The point of doing this is to validate the initial attributes users directly set on elements; i.e. if the HTML page contains:

```html
<x-toggle-switch data-on-text="">
    <label>Example label:</label>
</x-toggle-switch>
```

I want the `data-on-text` attribute to be immediately validated and replaced with "on", since "" is not valid. It doesn't make sense to me to do this in a getter because they should never modify values, as you allude to yourself.

It's also intuitive that as soon as the x-toggle-switch is created, each attribute it has should go through the setter. When I was first creating x-tags, I expected this to happen automatically, but it doesn't. In fact, I recently spoke to Dan about making this the default functionality and he is currently considering it.
OK, my mistake then. Thx and I'll merge
Not really sure! I've been away from the code for a while...
@jsloane Can we put this method before the `getRedirectURL` so they are in order?
Never mind, I'm an idiot
Can we standardize the use of separators?
We have tags for
* personal-info
* customfields
* customforms
Either all with - or none. My preference is to use _ as we have with attributes
Is this OK? Should we try harder to choose a reasonable higher?
This class is not autoloadable using a PSR-0 autoloader. If you would like it to be loadable, it should be in the sub-path "Symfony/Component/Security/Tests/Ldap/LdapTest.php".
Are you sure the class "Zend\Navigation\Page\Mvc" actually exists, or did you maybe forget to add a USE statement?
Well, the server accepts the 'cloak' attribute purely as it is from the client.
Totally see this now -.- -- Getting late. Sounds fine.
right. will fix
Now I remember.

The Dart example uses the .forEach iterator function.  Since the .forEach() isn't available for IEnumerable<T>, I reasoned that casting to List first would give more visual parity with the Dart example.   I can just iterate over it directly if you think that would be better.
yeah sounds good
Actually the inverse is true. We short circuit 'on' if name isn't defined because it's mandatory. `!nameOk` will `===` false for falsey `name`s. This check could be taken out if we trust people not to do silly things like `on('',...)` or `on(falseyValueHere, ...)`. I think we can expect people to respect the event map or string requirement yes? I'll remove it.
The default being a wildcard implies that (a) wildcards can be used and (b) multiple tables can be extracted at the same time. If this is the case, `table(s)` would probably be more appropriate, and a mention of what wildcards are allowed.
I think it should be:

```css
.moor-box label { font-family: mono; }
```

rather than taking it off entirely. The reason I had that as mono is to ensure the labels such as HEX, RGB, etc, won't inherit any of the admin templates font families and sizes.
May be better to say "Automatically turn on the speakerphone during a call"
why allowing making it null ? It does not make sense IMO. If there is no transformers, it should simply be an empty array
No, that wasn't intentional - good catch, I'll switch it back. As for not hard-coding the size - I agree. This is here for backwards-compatibility only. This tag is going to be dropped in favor of daguerre's native tag, which will have an {% empty %} clause to handle the default case without hard-coding it.

See also: oberlin/django-daguerre#8
This is a text that is shown only once in a small bubble to help the user the first time they view a friend view (when you go to an event, then the friend list, then tap on a friend)
Sorry somehow I missed that. 
Thanks
Curiosity again, but is there any reason why this is preferred to `contents.on('click', 'button.confirm', function() {`?

I would of thought the latter is more performat, since it only binds the event when a click occurs?
Yes, put after that line an assert, similar to how we have it in RegistrationView.
Start TODO comments with upper-case letter.
Add its script tag separately to the "js" block. Sekizai makes sure that block are not duplicated and it can do that only if there are of small chunks.
I did nothing here? It is the same as it is now?
We already have jQuery?
If it is not a class-based view, name it as a function, now class (don't use camel case).
We will have to discuss this hard-coded URLs.
Why once `stations` and then `stands`?
It might be better to use the constructor-initializer here.
i.e.

    pack(...)
      : parent(make<data_type>(...))
    {
    }
Yes, you are right.
We took the code directly from wetwlly branch and inserted it in it.
We are not so deep in the messages and all attributes, but we saw that like this it worked, at least as far as we know...
If you prefere we can remove all DeathPayload.
Made the change. There is only one iteration in this case, and the second time the generator.next() is run, it raises a stop iteration. So now I have put in a self.assertRaises to check for that.
Doesn't matter.
It should be readable ;)
Previous naming convention did not use the "-" before the parameter name. Ruby code that is documented from previous commits and Python code do not have this. Let's change this for consistency, or agree to use this as our default documentation style.
prevent modify of original meta['indexes'] in QuerySet._build_index_spec
We don't match empty/null paths anyway
Fifth bit: RatedArenasEnabled
I Agree that `i` is against our standard, but `key` is not a key and `value` is not a value, so our default `x` is best here.
I think we should either port PyCogent's optparse additions over to this project, or use standard optparse, but not provide support for both. This makes it difficult for us to maintain and test, and changes made to one option have to be copied over to the other, which is error-prone.
I've always been confused about why the example project doesn't require South and think it should be added, but why is it added here? Does something with the upgrade break otherwise?

Also, why do we not require psycopg2, since postgres is requred?
Implement the appropriate interface too :)
Another approach would be to not set the value at all unless the user sets this property.
Se let the driver decide (meaning if the driver changes it's value it will apply + we're really not messing with it)
I would inject the Detector. If the view helper has a factory, you could inject it there and you are not dependant on "the service locator of the service locator" later on.

Copy paste: 

```php
/**
 * Set locale detector
 *
 * @param Detector $detector
 */
public function setDetector(Detector $detector)
{
    $this->detector = $detector;
    return $this;
}

/**
 * Get locale detector
 *
 * @return Detector
 */
public function getDetector()
{
    return $this->detector;
}
```
Let's call this "fatjar" instead of "nodep"
to prevent input_box to become just 30px
but it can get wider if needed...
Ok, ok, I give up on trying to make you write this `for` loop with a `for` :)
"so that new handlers _are_ forwarded"
We should use t() here as-well.

```
t('Last updated: @time', array('@time' => ...)
```
it looks like Ohai only returns i386 or x86_64 because we're parsing weird strings to produce these values. An else statement instead of this would probably be cleanest.
I guess this comment can go now?
`m_numLights` should be removed, since `m_lights.size()` can be used instead.
This creates some problems. From issue #258 http://qbforums.shiki.hu/index.php?topic=997.0
I dont know if we may add all the third party dependencies to our repository... i think this should go in the fitignore and should be installed on a bootstrap.sh script for set the development enviroment or the staging or production one.

For example all the python dependencies ar seted up like this using pip.

This way we have less garbage in our commits :) just imagine what if we put all python libraries over here!! :S
Prefer to not name hog here and call this M2RepositoryTest, which should be held for basic unit test class. Since the setup is more involved, suggest name the test class around what is being tested.

and add the issue number in the test javadoc.

M2RepositoryMetadataJavaUserAgentMTTest

'MT' for multithreaded?
This is a good point, but I'm not 100% sure about merely adopting the smallest for the reasons you describe.  Would it be a real timing drag to adopt a little Gaussian logic here and add the `stepK` values in inverse quadrature? (similar to adding the sizes in quadrature).  Or at least make this an option?

To be clear, this would mean in pseudo-code, for a hypothetical three component object, that
```
stepK_convolve = (1. / stepK1**2 + 1. / stepK2**2 + 1. / stepK2**3)**(-0.5)
```

I think that for many of the objects we're simulating the PSF, galaxy and possible pixel response (including charge diffusion) are not so different, and so this typical factor of sqrt(3) is sufficiently different from unity to make me think it's worth trying to take it into account.


One other final, minor comment:

>Thus, taking the minimum stepK will not be small enough to adequately sample the final image.

I would add: "... in k space, which will lead to periodic folding across image boundaries in real space."  This seems clearer to me.
They were for debugging.  I can remove them.
Were you able to reproduce the error that jQuery.browser was undefined?
This predicate shouldn't be here in this case. If a different user updated the motd since we were last here, we should see it. Allow the transition every time.
is this confusing -- until we fix the @SetFromFlag during construction (it's safe here, but i had to think about it for a minute) ?  (disregard if you think not worth attention.)
btw, fudge is more of a compliment to mock rather than a replacement.
should we not use an empty whitelist to allow no tags whatsoever?
It's the Super Controller for OpenBook. Your controller must extend that.
put this outside
This works, on the same line?
Likewise, some comments on what you're actually doing here would be good.
А что это за push?
Он один и тот же, или в том смысле что взять его из той папки?
; ...!!
It's ok to abstract this if you think it will reduce a lot of duplication but we should put it into the page object and perhaps reduce it to just filling in the fields and clicking submit.
JsHint ругается на такие конструкции. Знаю, что моя конструкция выглядит ужасно, но пока не придумаю, что делать с JsHint – останется так.
`this._inputId` стоит делать внутри `apply()` — чтобы после обработки контекста всего блока, значение `this._inputId` вернулось в `undefined`. В противном случае, ты можешь зааффектить соседние блоки, если у которых тоже будет гард на `!this._inputId`. 
Для проверки: постать на страницу несколько экземпляров блока.
add some demos, the rest is more local debug stuff, I will remove it from the branch
Might be cleaner to make these functions local to ``tree_.prune``, sort of similar to how ``build`` has a ``recursive_partition``.
A good test and proof-of-concept would be to reweight the samples of some unbalanced problem such that the class distribution would become balanced. 

(Actually, that would be very nice to have such a  utility function to generate those weights.)
What do you mean exactly? ``SGDClassifier`` should have a ``multi_class`` too... or do you mean ``multi_class='multi'``?

BTW: The current API is certainly subject to debate - any thoughts welcome :-)
I'd prefer this function to be kept as a function and not a method, as in the original code. The corresponding function can be used in the object.
Is `tree.predict` still faster? If so, we couldn't we remove altogether the storage of predictions at leaves? (and hence simplify the code).
maybe say "tuple of length arr.ndim" or something.
This item is there twice.
On 10/09/2012 07:18, serge-sans-paille wrote:
>
> In pythran/pythonic++/core/set.h:
>
> > +			//
> > +			//Should accept any iterable object but due to use of find, can't be done yet
> > +			//
> > +			set<T> tmp = intersection(others...);
> > +			for(iterator it=tmp.begin(); it!=tmp.end();++it){
> > +				if(not in(other, *it))
> > +					tmp.discard(*it); //faster than remove() but not direct interaction with data
> > +			}
> > +			return tmp;
> > +		}
> > +		
> > +
> > +		template<typename... Types> 
> > +		void intersection_update(Types const&... others) {
> > +			*this=intersection(others...);
> > +		}
>
> This looks correct, but it seems to me that would be faster if
> everything would be done in place instead of allocating extra sets...
> Not critical as of now.
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/serge-sans-paille/pythran/pull/12/files#r1563239>.
>
This is the only way to use the 'recursive ellipse expand'. However i
wanted to return a ref to the initial set everytime, but you told me I
couldn't (don't understand why...)
Please use `assertInstanceOf()` here, `assertClass()` [is deprecated](https://github.com/xp-framework/xp-framework/blob/master/core/src/main/php/unittest/TestCase.class.php#L116)
Actually with the $bodySet flag I have a tri-state.
Whenever I call setBody(), I ensure, that all the parameters will be sent within the URL. regardless if a body was actually set. Calling setBody(NULL) will also move the parameters to the URL, whilst it won't do that if no flag is used and only the body is checked for NULL.
I'm adding it to the time command, too. :)
> At some point we can work out a proper policy for this and make it consistent throughout dmd.

Consistency a.k.a. code duplication. :)
Is it possible to set the loc correctly when the expression is created?
Where does this get deleted? Also, what if initialize() is called multiple times?
Keep these in order
before_filterとhelper_methodをapplication_controllerに定義しましょう
How would a different caching mechanism be treated in here? I think we're missing the other cache types in DoctrineModule. Also, I would use an alias only if strictly required.
With the current wording I would expect that the class being mentioned at end of sentence would be an example of one such interface type.

I'd use something like
`@ClassBridge implementation '%1$a' should implement either org.hibernate.search.bridge.FieldBridge, org.hibernate.search.bridge.TwoWayStringBridge or org.hibernate.search.bridge.StringBridge `
No check for hash table filling up in this loop. Can it?
Yes, and there are a few other similar cases
Seeing that the only files that was using the catch all has been changed in this PR, we can certainly get rid of this one to discourage it's use.
@peterbe So, I removed the * in front and behind CACHE, strange thing, git starts to show static/ as untracked. Changing it to what it is now i.e. */CACHE/ fixes that and still leaves @rhelmer fix to ./static/ in tact.
Yep done by URL, so we might as well cache the full set every hour than do a bunch of different product/version-specific URLs that will have a relatively low cache hit rate.
Is this the right package?
Yikes!  My filesystem is case-sensitive!
Yes I've added it this morning along with the new tests, but the leak error still remains.
`if (names.length)`
My proposal for today:

````php
<?php
namespace Zend\Stdlib;

class ArrayTest
{
    public static function isList(array $array){ // ... }
    public static function isHash(array $array){ // ... }  
    public static function hasNonNumericKeys(array $array){ // ... }
    public static function hasNumericKeys(array $array){ // ... }
}
````

We can extend it with additional test in the future, if needed.
I think we should use url_for to get the static directory.
Imagine a case where you have:

``` php
<?php
$foo = array('foo', 'bar', 'baz');
unset($foo[1]);
var_dump(\Zend\Stdlib\IsAssocArray::test($foo));
```
The old way would correctly return false, however using `array_values()` like this returns true because the [1] key is missing.
Why the initial _? I haven't seen this pattern elsewhere in the code - but I may just have missed it.
Its because mac os x is stupid and ignores file capitalization, and
originally it was called LogInResponse and I refactored it to LoginResponse

On Tue, Aug 7, 2012 at 4:59 PM, dmansen <notifications@github.com> wrote:

> In src/main/java/com/cloudmine/api/rest/response/LogInResponse.java:
>
> > @@ -37,7 +37,16 @@ public LoginResponse(HttpResponse response) {
> >      }
> >
> >      public LoginResponse(String json) {
> > -        super(json, 200);
>
> I just noticed this file is called LogInResponse.java ?? Is that a mistake
> / will it cause problems
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/cloudmine/cloudmine-javasdk/pull/10/files#r1326384>.
>
>
@christianv Redoing without, but I have a question about this (for later).
agree with that. and make sure not to overwrite an error return value with a non-error one. i suggest you get the return code into a temp value and append a string to $errorMessage for each backend that fails. then throw after the loop if the error message is not empty.
@bootstraps I can just run it later I guess. If it works, it works.
0.upto(23) do |i|
I would expect setting DOMAINS would implicitly disable the ALL check..?
I find that virtualenv often fails to install PIL properly, which results in PIL failing to decode images such as PNG and JPEG data, which results in an object array of size `()`, which results in this test failing through no fault of its own.
No, it's definitely not that important. Don't get me wrong but I think any further discussion would be a waste of time here ;-)
Would be nicer to use the if template tag than executing arbitrary code in the template.
`<tpl if="checked">checked</tpl>`
the VcsRepository is not used anymore
Hm...this one was giving me problems. I'll take another look.
For now, yes.  No new code should use a || b style due to easy potential for bugs like this.  In the imagery branch I made a helper function defaultValue which brings some of the convenience.  At some point I can merge that in earlier.
Does assignment have any subclasses? If not, then the type column isn't needed.

You have `belongs_to :assignment_types` in your Assignment model, I think that needs to be `belongs_to :assignment_type` and then you need an integer `assignment_type_id` column since it's a belong_to.

Then, on this line, you should be able to do `current_course.assignments.group_by(&:assignment_type)` and your block will be passed an AssignmentType object.
Where do u think the best place then? `Constants.cs`?
These javadoc comments are pretty sparse, can we remove them and just use the `@Deprecated` annotation instead of javadoc? (there are a few places you'll need to change)
The padding should be set to (8,0,8,0) to ensure that it causes no regressions.
Is there a unit here? Seconds? MS?
Why are we removing the duration property support?
I'm not 100% sure if this works as expected, have you tested it?
Imho the commandtranslator would try to escape the string which would break the command
Wouldn't it be better to expect a responseobject or its items as a argument?
This will not work, as the import path will now change. I suggest a relative import (from .pt_regions import REGION_CHOICES)
Hard to see in the diff.

`count` was a convenience method only. The `getCount` came out in the JSON in the `value` attribute anyway. Count is also wrong language for a gauge. So it has all disappeared in favour of a `getValue: () => T` that gets passed into the constructor.

The sourcefile in full: https://github.com/guardian/guardian-management/blob/174f4332766cde372d361a80891ab7a359f86050/management/src/main/scala/com/gu/management/metrics.scala

The previous sourcefile: https://github.com/guardian/guardian-management/blob/0517d9bdf9b1799a0fb0dec370bc3eff6e7c8947/management/src/main/scala/com/gu/management/metrics.scala
The YMP parsing doesn't belong into this class. The class should just encapsulate the actual package installation. YMP parsing and handling the data is needed in the UI, and it's a separate task, so this should also be separate classes.
Let's put `4.x`
This line increases run time by ~10% in Chrome.
Good point, I'll change that
ditto for a more thorough unittest:

```D
unittest
{
    alias TypeTuple!(short, ushort, int, uint, long, ulong, double, real) Src;
    alias TypeTuple!(byte, ubyte, short, ushort, int, uint, float, double) Tgt;

    foreach (idx, T; Src)
    {
        static assert(is(Demote!T == Tgt[idx]));
    }
}
```
Quick comment: I think the constraint can be relaxed to:

```D
        is(Unqual!(ElementType!R)) : Unqual!(ElementType!(ElementType!RoR)))
```
which would allow:

```D
join([0.8, 0.9], [1.1, 1.2], [1]); //RoRoDoubles joined by an int range.
```
If this requires extra code, then forget about it, but it seems like it is a pure constraint issue.

Also, there is an open request for `join(RoR, E)` I believe. (gotta search the issue number). Whilst you are on the issue of refactoring join, it seems like a good idea to add it no?
To add to that, I removed to avoid un-necessary proliferation of entries in the lead section.
IMHO it will just force generic code writers to add more branches in their (already complicated and full of templates) code for essentially same cases: `int[1]` and `int`.

Consider e.g. this function and its examples: [unstd.multidimensionalarray.asFlatStaticArray](http://denis-sh.github.com/phobos-additions/unstd.multidimensionalarray.html#asFlatStaticArray).

And its implementation is this:
```D
return *(cast(MultidimensionalStaticArrayElementType!(T, n)
	[multidimensionalStaticArrayElementsCount!(T, n)]*) &t);
```
b/4636 -> [bug 4636](http://dartbug.com/4636)
sure - probably just the emitter_test is enough in this case.

Even though they might be redundant, sometimes I like having both - the emitter_test style so we can directly visualize what the generated code looks like, and the other style of test to check that it actually works.
これはさすがに改行しましょう。
why renaming this file to testDescription.transformation.txt? The TransformationDeployerService is aware of files with a ".transformation" ending.
I actually can't.  Without specifying that part links in the email won't know where to go...
we could also turn it into a blacklist of for what formats it should be disabled and default it to ``html`` .. not sure ..
They are all update actions and that implies PUT in REST.
Sure, I'll move it out to the document manager and look into moving it to the connection level. If multiple clusters are used within an infrastructure then having different definitions may be wanted/needed.
ahhh, never thought of that, and if the explicit encoding is given in the xml header, should I convert it then or just parse complete chunk in ascii?
На строчку вверх.
What is the point of creating the vtx0, vtx1, etc. arrays?  As far as I can tell, the arrays are filled with the current x and y, and the previous iteration's x and y.  When testing, my memory usage is significantly higher.
This `</div`> should be on the next line
@croby Strictly speaking not

We have an if/else in `init.versions.sakai` so it will always be set.
Could you make the mu == const part optional such that the second line in

http://en.wikipedia.org/wiki/Mahalanobis_distance

can be used ( this (x-y) S^-1 (x-y) one? Then distance(i,j) can become meaningful again...
Rather than using variable substitutions in the first place, concatenation should be enforced.
I think that got in there by accident.  But it does no harm (alloca is actually recognised by the compiler as a built-in function that is expanded at compile-time).
The change is implemented and the test is added although the test passed without modification although as you said it could be vendor specific improvement
Which cookbook? Maybe this cookbook?
Please make sure the whole example is indented at least 4 spaces so that Markdown renders it correctly.
This gets the job done, --- I was originally thinking you'd do this in the to_s method itself
It's true!! Both spellings are correct. I was just trying to make the spell more american friendly (http://www.reference.com/motif/language/cancelled-vs-canceled). I don't know why I did that, I saw the Cancelled button and near by in my screen I saw a Canceled button and I went to google to find out which one was the correct one and... I fliped a coin and the coin said “Canceled”!!

About break the code... Despite the previous existence of this state, there were no ways for an object to arrive in this state since there were no methods to cancel (Void) a shipment. It is as if we were creating this state right now. Am I wrong?
True story, missed that. Sorry.
These method names are kind of misleading since they only return text they should be named more obvious in my eyes.
This generates a race condition. The search strings for this app are removed here, outside of the later transaction that is updating everything to do with the app. Instead of calling removeAppFromSearch() here, set a flag to indicate that it needs to be done. Then, at the beginning of the transaction, if that flag is set, call removeAppFromSearch() before doing the other stuff that the transaction already does.
i'd probably stick it in the api itself but i'm happy either way.  your call.
I think "return value" would be better than "return type". It's the value that is validated, not the type.
assert "foo"[%r(o)]

it asserts the regexp can access/match the string.
shouldn't this class level fiield be defined with others.

it is really hidden down here.
no, technically lazy_build => 1 means:

    lazy => 1,
    build => '_build_author',
    clearer => 'clear_author',
    predicate => 'has_author',

...which adds methods to your public API that you probably didn't want.  It's fallen out of favour in the Moose community because of this, and is now being actively discouraged.
Don't use `preg_match` as you are not using any regex, you are just checking if it includes that string. Either just do `$singel_active === $plugin_name`.
лучше const node_base*
I think we can avoid doing all of this now that we have real active record objects. For example, `Procedure` has a method `full_description` which does the same thing as `p["code"] + ": " + p["description"].titleize`, except it doesn't `titleize` but it probably should. Time to DRY this code up :smile: Makes me happy
Ah, so it does. Lovely!
Yeah, reading wikipedia definition, scalar isn't what I meant.  I meant "this unit can be scaled to other units"  So maybe isScalableTimeUnit?
Umm, that's the original formatting :) Shall we apply the formatter for 
the GlassFish modules now, instead of applying them before the 
1.0.0.Final release? Trying to match the style in each file for this 
Maven project, is a pain anyway.
Personally, I am against using Faker in test contexts. This makes the test non-repeatable. This introduces unnecessary randomness.
Thanks for reminder. I also update the reference document.
'ponychan.net', 'mlpg.co', 'mlpchan.net'

Hmm. Too much attention to ponyfags.
please add an upper bound. Otherwise, the release would be broken. Same for all other deps
This was copied from the different timezone test, which is not required for this test. So please remove it.
What if someone was using file:// to load the URL?
Or even platform://
Doesn't it make sense to keep the web view logic in the chromeWebview module?
change to just "BLOB" for 65k of storage
Yes. I'm still using it on 3.4. Should work on 3.3 also
1. use snapshot-version here
2. try to stick to osgi-spec for bundle-versions