labofsahil/github-event-dataset-2012 huggingface dataset:
thanks, google table for easy display: https://docs.google.com/spreadsheet/ccc?key=0AtP7KyCg177NdDFfb1JuSkZCS0k2cW5SbGJXUkhxSlE
I don't understand how it could work as currently implemented. For instance, will it handle a command like "CCACHE_SOURCEDIR=/src gcc -I/src/lib/includes -Ilocal/includes -c /src/lib/hello_world.c" (that is, with -I options for both directories under CCACHE_SOURCEDIR and under current working directory)?

Also, the CCACHE_SOURCEDIR addition feels like a quite complex solution to me. I suggest to instead extend CCACHE_BASEDIR so that you can specify several paths: CCACHE_BASEDIR=/path1/dir:/path2/dir (Windows version with semicolon instead of colon. That is, if any of the directories in CCACHE_BASEDIR is a prefix of the path, the base directory mechanism kicks in.
Lastly, i think if you're going to use the recursion method, it should be a general solution.  I feel like you kind of cheated using the 34.times do block?
Also, the recursion method should call itself way more times than just the 34 times mine does because only the last iteration it calls itself 33 and 32 times right?
Great. At some point I'm thinking we may as well build both models.
If you bump the gem version, I will be your best friend. Whacky adventures, crazy hijinks, hiding bodies – the works.

Please, restore our sanity and save us from noisy logs.

:bear:
Presumably `CALayer` retains the values you pass to it. I figured you were trying to mirror `UIColor`'s `CGColor` accessor here, which returns a non-owned object.
It works, but now we don't check call count of loadController. I've sent a pull request 6 with a fix.
Well I didn't feel the need for it ;)
потому что симптомы данные в теме неверны. я еще раз повторяю - на чистом ядре можно увидеть только по .gps, больше никак - LOS у них просто не используется если вмапсы битые.
I don't know for sure but i don't believe it.
I use SDK 23 to upload the ArduinoISP sketch and then switch to SDK 1.0 and use it at 19200 Baud.
Also read in the Forums that the problem is a buffer overflow in SoftwareSerial but didn't find a (working) fix for it.
But... any hint on that would be highly appreciated :)
Can we say its Docs ? Its API ?
> Nobody has complained about this before.
So I complain about it now (but my complaint's don't count, right?).

And back to my first comment. Did anybody test this with Windows? As I read the code it compares now extension without ignoring the case. So `.C` file is checked as C++ in Windows? Am I right?
@tibbi change this `spawndist` float NOT NULL DEFAULT '5',  to default 0     any npc added by temp summon or npc summon or an .npc add coomand will get a error on next start up  i had commit this sql change to R2 before the name change bumped my R2 pushing powers
xDDD Use russian for this! Latest version without https://github.com/mangosR2/mangos/commit/3178cc8d18941522fe97f7dfe3c159fd4632b6a2 + [mr1631] stable for now... so some crashfixes works fine ;-)
found out that reseting talents for everyone wont guaranteedly fix them :/ If for example someone once had Blood Gorged, but someday he made 2 specs, in which none contained Blood Gorged, at talent reseting he will not lose it. Need to find some other way to delete all spells, that the player shouldnt have.
Thanks for noticing this! Fixed by 1ec6af6501 . Note that bbplaybook.svg isn't used right now. As I remember, the SVG file had a problem(mis-oriented?) so it's not included at this point.
Rails.application.class.parent_name maybe?
Why do you use the *constant* "1" here???
You are right.
Thanks.
Addressing here to have a record of the conversation: discussed this with David, he's OK with the fallback that's currently implemented in RBM.
Latest Nox+script not really working for me. Don't know if it's the script or skin

I get no posters and no movie list on a smartplaylist menu (playlist does work when entering).
All empty however it does show a tvshow episode thumb on the movie list. When entering the list is empty
a test [here](https://github.com/mozilla/zamboni/blob/master/apps/versions/tests.py#L329) would be nice
Shouldn't we be using require.js instead of doing it this way?
Have a look at how we use `jquery.autoSuggest` in widgets.
вместо filter обычно используется list_comprehensions (погугли)
а вообще непонятно откуда тут могут быть "пустые услуги". это реально? может на уровне фильтра sql-запроса их отрезать?
instead of checking the length and doing five comparisons, you could just do this (and order doesn't matter):

    eq_(data, {'status': 1, 'message': '', 'id': 9945, ...}')
Why are getDisplay and applyDisplay still static?
You can roll this back with this:

git reset --hard HEAD^1
git push origin develop -f

That will roll it back 1 commit then force the push, so that you can pretend it never happened.
Sabía que se iba a hacer vicio el sleep... ya no hay test sin sleep =)
cb6b786202b8dea938fbf5ebdfc22dbe6c59bbd6
This is meant to confuse the optimizer :)
https://github.com/mozilla/zamboni/blob/master/lib/settings_base.py#L419 does this matter for `mkt` yet?
This let could be replaced with a doto, and be one line shorter!

    (doto (.getCache clustered-mananger name)
      .start)
- The signal/slot connection still uses done()
- When reimplenting QDialog::done(int) we probably should call QDialog::done(int) in the end?
if this is about done() hiding done(int), maybe just renaming done() to somethingElse() is less intrusive?
solves #24 because it doesn't fire up the default web browser. Doing the math take an [average user](http://www.w3counter.com/globalstats.php) times the system Visual Studio works on plus [default Windows 7](http://en.wikipedia.org/wiki/Browser_wars) factor. I'd say 70% of users won't appreciate the `start localhost` behavior.
That's not the rotation property from the OpenLayers symbolizer object literal. It's the rotation of the label text. My suggestion for a mapping: ```symbolizer.labelRotation```.
aw… more work on the compiler side ;)
Alliance Mounts dont move nor Have Spells
I suppose it should, although its less certain what exactly you should visit to check that. IP address? Localhost? It depends on how you've set things up. Feel free to add something generic to the effect that the site should be serving on port 80.
ok, thanks, will change it then
Isn't that what ```dom.hasCustomAttr``` and ```dom.getCustomAttr``` do?
haha good idea.  I will commit this later, and rebase.

emesene/gui/gtkui/Conversation.py:333:  I think that if/else statement is also a mistake, can be directly erased.
а ещё лучше считывать файл отдельно, потом хранить их в структуре данных (например, хэшмап) и возвращать оттуда. а релод делать независимо
Perhaps not. But assigning to `clock` rather than `var clock` was also causing problems since IE helpfully creates a global object named `clock` because there's a div with that id.

So maybe that was the only reason it was failing in production and the comma/semicolon stuff just popped up when I was debugging.
We can pull this out at build time if that seems desirable.
oooo... korean, fancy
Seems like a lot of work to control access in a fashion that will not allow easy use of script in other places (Seems like could be treated like a widget) Why not control access with an acl control?
Recommend placing something like this here (I'm just guessing with the br tag; can experiment with what looks right):
```<span class="title"><?php echo htmlspecialchars( xl('Message and Reminder Center'), ENT_NOQUOTES); ?></span>```
```<br>```
This commit needs an inline comment, too.
PARENT_SCOPE - это анонс переменной на уровень видимости выше, на уровне, где она задана, такой переменной нет.
Should this be in here? I guess it was added for testing purposes and then forgotten?
should be `array('name' =>` instead of `array( 'name' => `
They are generally used as regression models. As they need to be wrapped to handle multiclass classification I would rather not introduce them here but keep them for the "which regression algorithm" section.
ROLF fix it yourself i don't go to do another pull request for this xD
Can you explain me what it means refactor?
Maybe you fixed bug when in traderNPC item dissapears?
You never pushed this version to Rubygems? http://rubygems.org/gems/css_parser
@jbergantine

Basically what the code is trying to say is that if the following constraints were satisfied:

- Touch event ended before the durationThreshod expired.
- The x-direction (horizontal) exceeded the horizontalDistanceThreshold
- The y-direction did *NOT* stray more than verticalDistanceThreshold from the original y value saved during the touchstartt event

then a left/right swipe event is triggered.

In my opinion the scrollSupressionThreshold is un-necessary, and should be removed such that we always prevent the scroll. The reason I say this is because the threshold is 10px which is the same magic number that iOS and Android use to trigger/initiate scrolling. If we don't want scrolling, then we should just preventDefault on every touchmove event.
Is this liable to cause issues on systems where libusb-0.1 is installed?  The usual pattern I see for having both installed is that libusb-0.1 is called "libusb.so", whereas libusb-1.0 is called "libusb-1.0.so"; will this line wind up finding and using libusb-0.1 if libusb-1.0 is not installed?  What about when both are present?  (Is libusb-1.0 called libusb.so on Debian kfreebsd?) 

We might also have to figure something out for the Windows side, where we do ugly things to emulate libusb-1's API using libusb-win32 (which is a fork of libusb-0.1).
I am almost to a point where I'm am getting something out of setting up arrays and understanding how arguments work with them.  I'm not like ready to take a test or anything like that.  But I can say the heavy fog is lifting.
Works like a charm :-)
Thanks
I've created a pull request to fix it.
https://github.com/spdr870/gitextensions/pull/814
Is there a special meaning for `/*\` and `\*/`?
immer noch typos :D
center date
It does, but only because it's using our own URLs (see line 28).  It's easier to do this than to generate all the request &c objects we'd need to run the VideoFeedView directly.
I'm demoting your team status to Lieutenant for your actions.
Why was I removed from contributors list?
/tar nays troll doll .cast fireball

lol <3
UPDATE gameobject_template SET scriptname = '' WHERE scriptname = "go_black_cage"
DS-RV Arenas work?
"POINT_FROSTWYRM_LAND" only goes as "EFFECT_MOTION_TYPE", and MovementInform only wait for "POINT_FROSTWYRM_LAND"
Very true. Going to improve that today and add more hints into the UI today.
Both are valid. I'll update the commit if you have a strong preference but it doesn't really matter from a forward compatibility perspective.
A comment here might be useful
Por un lado, se te ha colado una coma final. Por otro... ¿por qué el location?
I was just thinking, we may need to document the case where people are trying to "update" a template that no longer exists (popup, document, secure, etc). We'll need to tell people how to switch to another template and how to specify the body class param.
actually, fixes #627
Maybe I shouldn't do such huge commits
@FernFerret That's right
So? What should i do? :)
Il giorno 16/feb/2012 18:24, "Andrew Dodd" <
reply@reply.github.com>
ha scritto:

> Oh yeah, another thing - I see that you reverted this, but in the event
> that the power mode gets set to PM_MAX, this seems to trigger the infamous
> BT-AMP bug even on firmwares normally not susceptible to it (like XWKL1).
>  As far as I can tell, you do NOT want to mess with enabling PM_MAX!  (In
> Samsung kernels it's disabled by these #ifndefs)
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/simone201/neak-kernel-sgs2/commit/8ce5232a9469c4a29ea0702318ae8050d586476d#commitcomment-974461
>
Part | Points
------------- | -------------
base | 1
adv | 0
*Total* | 1

Passes tests. :sparkles:
nada, no va, mejor dejarlo así que funciona perfect
I will also update the Readme file in that directory with a note about the latest build..  Colin

On Jan 31, 2012, at 11:28 AM, Colin Worth wrote:

> Hi Janet and Paul,
> 
>   These docs were accurate when I wrote them and the overall build structure is correct.  Every time I do a build, i.e. update ffmpeg, and run the build script, though, something comes up, which usually leads me to think - well, I guess it's not going to work this time, and then three hours later discover some way around or through the problem - most recently had to switch C compilers due to some kind of stand-off between the gcc developers and the ffmpeg developers.  If you look in the build scripts in each directory you will see some instructions, if necessary about things I had to do for that library.  In some cases it is editing Makefiles and extreme cases (maybe not necessary any more) editing source code.
> Obviously whenever anyone updates ffmpeg or a 3rd party library there is the potential for something to change, and since ffmpeg developers are usually not thinking about compiling on i386, x86_64, and ppc on a Mac, that adds further complications.  Unfortuntately, I just don't have time to keep the build docs up to date right now as I have another full time job.  Even so, the process of doing an up-to-date build is slow and painstaking - just trust me on this.  If you want to do it yourself, or maintain a set of docs yourself, I recommend going through the process - there are online guides out there, reading the old docs, and I'd be happy to answer questions if you run into obstacles.  One thing I am doing, as you'll see in the docs is compiling a version for each mac architecture separately and then combining them at the end, in order for the machine language bits to run as fast as possible.  It is easier to compile for the native architecture of your machine only.  In fact, I would say the only exceptional thing about the way I'm doing it is the fact that I keep the architectures separate.
> 
> -Colin
> 
> 
> On Jan 31, 2012, at 4:01 AM, jed jed wrote:
> 
>> Hi Colin -
>> 
>> Can you please be sure to respond to Paul's questions regarding the
>> ffmpeg build docs, he wants to pull your stuff into Miro.
>> 
>> 
>> Thanks,
>> 
>> Janet
>> 
>> 
>> ---------- Forwarded message ----------
>> From: Paul Swartz
>> <reply@reply.github.com>
>> Date: Mon, Jan 30, 2012 at 5:48 PM
>> Subject: Re: [mirovideoconverter] Add new commands for xoom, fire, and
>> galaxy. Bring in new ffmpeg build 1/26/2012 (f50392a)
>> To: Janet Dragojevic <jed@pculture.org>
>> 
>> 
>> Are the FFmpeg builds made from the same code/scripts that are in
>> https://github.com/pculture/mirovideoconverter/tree/master/Mac/FfmpegCompile?
>> If not (and it doesn't appear that they are) can you update those
>> instructions to reflect the build you made?
>> 
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/pculture/mirovideoconverter/commit/f50392aec44ab3dceaed7ebfb9e024fd0da69e80#commitcomment-914771
>> 
>
No, this is Larsson Sadakane Method and its complexity is O(n(log n)^2).
Probably, but what I'd like to argue for is getting rid of `useWfuncs` entirely. There's a thread about pre-Win2K support in the main D newsgroup at the moment, and Walter doesn't seem to be entirely against dropping pre-Wink2K support, so may finally be able to do it. But having to worry about A vs W functions like we have been is a big problem IMHO, and I'd like to see it dropped entirely.
message type might be wrong... I wil fix it.
Removed images from 45 to 92 since we're pulling info from the sd now
I see your point. Maybe it does make sense to have the leaf node both host the access and the constraint like property. I think my main ocncern was to deal with all those optionally null values to detect what the node is actually about.

That being said, if I had to do it again, I'd change that to create intermediary nodes in BV 1.0. But we can't change history.
MethodDescriptor => ConstructorDescriptor
вместо переоткройте (кто вообще придумал такое слово?) - повторно откройте
Removed in latest release.
By removing this method, you can also remove `require 'oauth'` from the top of this file. That line should be moved into `cli.rb`.
Was curious about as well (which is the "todo").  I just did a test...

`e.wheeldelta` values:
Natural mousewheel down = `1`
Natural up = `-1`
Normal down = `-1`
Normal up = `1`

So OSX tells the browsers the correct thing and the paginator behaves as expected. Code comment will be revised.
Per MS docs, the prefix is already deprecated for native Win8 apps and should become deprecated when IE10 on Win8 reaches GA.

But, both clients should continue to respect the prefix for quite a while.

All of the compatibility tests should be updated to check against non-prefixed values as well.
lets use ".ui-navbar" instead... I find it more readable with looking through the css
We will turn all these into proto once the protocol have stabilized. Not now.
because of the bounded waiting time for `tryLock` which has not yet been implemented here ;-)
Just remove all the numerous imports of this and place it at top level, DRY
OK. So @patriknw, if you agree, will you change the code to reflect this?
Hmm, I know first-hand what the location transparency thing is all about, but would it not make sense for user code to ask a ref whether it is local or not in order to determine proper timeouts etc.? I’m on the fence, really.
yes, since we know that it was convergence when we receive the member events it should be enough to check those, which is done in awaitUpConvergence
I'll rename `isRunning` to `isTerminated` in the cluster extension, and remove this attribute from jmx, because it doesn't make sense there, the MBean is deregistered when the cluster extension is shutdown :-)
changed my mind, it doesn't touch much more lines than I have already changed, so I'll change it right away
Technicalities :D
FYI, this was removed/cleaned up because I realized that this wasn't correctly accounting for situations where there could have been a partial write that timed out where you can't actually retry...

Not sure why I wrote it like this at all in the first place... if we wanted a 3 second timeout we should just specify that :)
maybe you can add: ...output in m/s2 from cm/s2, in this way the factor -2.0 in the equation can be better understood. At a first glance I could not understand the meaning of: imean - 2.0
Same as above, just return the result directly.
Sorry if my comments were somewhat cryptic. I simply meant that we should
test to ensure that all models comply with the multi-voxel api.
On Oct 25, 2012 8:12 PM, "Ariel Rokem" <notifications@github.com> wrote:

> In dipy/reconst/tests/test_dti.py:
>
> > -from dipy.data import get_data
> > +from dipy.data import get_data, dsi_voxels
> > +from dipy.core.subdivide_octahedron import create_unit_sphere
> > +from dipy.reconst.odf import gfa
> > +import dipy.core.gradients as grad
> > +
> > +def test_TensorModel():
> > +    data, gtab = dsi_voxels()
> > +    dm = dti.TensorModel(gtab, 'LS')
> > +    dtifit = dm.fit(data[0, 0, 0])
> > +    assert_equal(dtifit.fa < 0.5, True)
> > +    dm = dti.TensorModel(gtab, 'WLS')
> > +    dtifit = dm.fit(data[0, 0, 0])
> > +    assert_equal(dtifit.fa < 0.5, True)
> > +    sphere = create_unit_sphere(4)
> > +    assert_equal(len(dtifit.odf(sphere)), len(sphere.vertices))
>
> Well - in this case, fa.shape == (), because there's only data from one
> voxel => 1 FA value.
>
> Should we test that's true, or do you mean we should look at some
> multi-voxel data here?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/nipy/dipy/pull/82/files#r1948457>.
>
>
I'm fine with clarifying with better use of the names.

We don't use the funky cache keys for the ids, because the core of this change is that we only store the id-keys in the local hash, and never write them externally.
Haha, was late last night. That should clearly be 720p50hz
Yeah, probably should check for non-empty.  We can't really use the first one though, as that could be fanart, which is probably not desired (only reason I didn't just use the first one to begin with).
Use a for loop, looks a bit nicer.
Might make sense to add a testcase for this, with a sample pool, so that people can look at what the pools look like.
The constructor function is as simple as it can be, no iterations, it just instances a already-processed Interface (OwnInterface) and returns it.
change isolation level thorough the patch.

This function should be  private boolean hasConflicts(...) and modify the reply at the call site.
I can't trigger this to happen because a click event comes with the first `guttermousedown` is in control of folding/unfolding https://github.com/ajaxorg/ace/blob/e220a11f34dd7e2fd69d7aee7c955a3df8a645c3/lib/ace/mouse/fold_handler.js#L52
Ah, you default it to 1 here.
as this is an optimizer, it should simply return the unoptimized code instead of failing IMO
`TUITableView` **shouldn't** initialize it, because `TUIScrollView` already does. It's a static variable – exactly one copy of it exists in the compiled binary.
pourquoi ne plus utiliser javascript_include_tag?
Maybe this should be generalized by doing `if (axis > ndim-1)` --> warning message, because this issue probably exists at higher dimensions as well.
почему весь файл заменился? надо бы вернуть, как было
Whoa, that's way better. Thank you, updated and credited.
See my explaination above. https://github.com/rails/rails/pull/5807#r795804
Agree also with your comment, we need to find a better name for find_in_sprockets method
Man, I just got rid of coreClassesFirst.  It would be much better if there was an absolute prohibition on embedding the names of classes or files as strings in source like this.  It makes things so hard to debug later.  Can't we at least have some kind of configuration file which is consulted on these questions.
This refactoring is not obvious to me. Could you elucidate, por favor?
Why don't you return HashSet.empty here and above instead of null?
This needs to be checked/fixed for all 4 methods.
I needed a way to communicate the Spree.user_class to core/app/models/spree/user.rb to make subclassing of Spree::User to the custom auth model work...

I first tried this line 3 for core/app/models/spree/user.rb:
User < Spree.user_class

which would've been much cleaner if it would work, but that wound up producing errors during app initialization. 

So, I wound up setting a constant in initializers/spree.rb so that I could use it in core/app/models/spree/user.rb ...  IMO, this is definitely the hokiest part of this pull request...   can you think of a better way to let the Spree::User model know which class it's supposed to be a subclass of?
We usually make our docstrings NumPy-esque, compare http://sunpy.readthedocs.org/en/latest/dev.html#functions
Oh yes, sure.  Added.
No it's 77 without the spaces.
Ok great, we should change the name of the Kane Class too then.
This should say "DOCTEST COVERAGE for "
pep8: space around `-` and `+` and space after commas below.
Is the only point of have the @property decorator so that you can write a doc string for the .potential_energy attribute? I'm not sure what the reason for it is? What happens when you try to set the .potential_energy directly?

You could get rid of the set_method and the decorated function. What if it just went like this:

```python
>>> P.potential_energy = m * g * h
>>> P.potential_energy
m*g*h
```

You can make use of the @property to at least error check whatever folks assign to .potential_energy but you aren't doing that here. I'm curious why you have the extra overhead of the set method and @property decorator?
I'm confused -- how does this differ from ```conjugate```? Could one just call the other?
This should have ```\left\{``` and ```\right\}```.
I think there's no need to list 1.1.10 and 1.1.9 at all since there's no content.
Would change that to:
`Your anonymous function should receive one argument, which is the model, the current <option> tag is generated from.`
This option is not critical, so there is no short answer to that question. See http://www.unixguide.net/network/socketfaq/2.16.shtml
Maybe we should include it as future option. I left it commented just to remember in the future.
Du wirst zwei Actinos brauchen.
1. Action: requestgroupAction: Stellt die Form nur dar, ohne den Service aufzurufen
2. Action: savegrouprequestAction: Speichert den GroupRequest
I think this should be
d_quantiles[1] - (d_quantiles[2] - d_quantiles[1]);
Fixed in 71c746e.
for all of these examples I think it's important to provide links to the database command names (in case people want to use the drivers.) 

also to note might be good to what the output is in the shell.
log rotation is a common enough term. 

if I were going to change one thing to this is I'd invert it so that it spends less time talking about the mechanics of the procedure and a little bit more time talking about why you'd want to do this. Which is basically to be able to archive and compress log data...
each of these use the word specify or specifies three times.

I think we can say these things less tautologically, and more clearly. Give a revision stab, and ask me if you have questions.
this is not something that happens or that will seem reasonable to users. 

The reverse may happen, where you might seed development servers using a portion of production data. You may also migrate data into production from a staging environment  which isn't the same. and also is much more likely to pass through your application rather than go directly using these commands.
you should probably cache this element so subsequent references aren't re-instantiating it.

e.g. var flickrMashup = $('#flickr-mashup');

...

flickrMashup.flickrfeed(...

flickrMashup.show();
The optimization should be in the cuda/opt.py file.
From what my tests shown, if that condition isn't there, there's a way to hammer a certain set of GET variables (an f and a p, IRRC) that, without a protection, will allow the a moderation to view a topic he is not supposed to be able to view.
This is that needed protection. If you spot a better place to write the code for that protection, please do say so(!) I'm still learning about how phpBB3.1 is working internally.
So shall I just remove all such lines?
As per IRC, changed to core.modify_posting_parameters.
Random extra spaces after `=`
no need for the space before the )
Old syntax is meant for old and not updated programs. New programs are supposed to be made as updated as it is possible.

---
DOM operations are slow. That's a fact. By working this way you are not only using the DOM repeatedly (even though it's not multiple times per second) and also the trash collector which is also not something that is that cheap. The real problem does not lye in this happening 1ce. Lies in this happening many times, in many places, in the code. All those together it becomes significant (specially in slower systems)
Note to self: Just use static functions, no need for an object.
și dacă a făcut draw nu ne interesează? Doar întreb.
Space after commas, please.
semicolon and brackets are missing
What does `\=` match?  I didn't think that `=` was a special token in regex, and thus doesn't need escaping.  Ditto with `\%2F`, I didn't think that `%` was special.
`u == Use.NDT ||` needs to be removed (otherwise, all math functions will be treated as non-deterministic)
Hard to tell... did the query change here or no?
array_buffer can't be of size 0 then?
For all "incomplete" work, in the code note it with both a TODO and a link to the JIRA ticket that tracks that completion of the work. This helps further tie together the code with the JIRA system. (Still, minimize TODOs going into the code. TODOs must all be reviewed and purged before we do a release.)
remove link to MOTECH, since unused
can someone verify we don't need this anymore
These two ``if``s should be switched around, since calling ``cost.ndim`` will crash if ``cost`` is of type ``NullType``.
This last sentence doesn't parse, and I'm genuinely not sure what you mean.
どもども、こんどからブランチ作成 -> コード編集 -> CorePackを最新にする -> branchでrebase -> pull request ですね。覚えておきます。
<pre>
for cpu in dev.processor_set.exclude(index__in=detected_processors_keys):
    cpu.delete()
</pre>
https://docs.djangoproject.com/en/dev/topics/forms/modelforms/#overriding-the-default-field-types-or-widgets
Fix the comment description
Missing line break between the two logical blocks
Yes, I was a little unsure of what to return here. 

The different driver implementations seem to be inconsistent here. The MySQL and SQL Server drivers returns the list of indexes on a table while the Oracle driver returns all constraints on the table including check and foreign key constraints. The PostgreSQL driver seems to only return unique and primary key indexes on the table
Would `shutil.rmtree` work better? http://docs.python.org/library/shutil.html#shutil.rmtree
<blockquote>Because of IE, we also have to check the presence of the constructor property.</blockquote>
I'm not sure which line this corresponded to, the closest line I could fine is "`if ( obj.constructor &&`" but that line was not removed.
if we're going to go this far, should we also do:

```
return jQuery[value === undefined ? "css" : "style"]( elem, type, value, extra );
```
I believe nodeName may not be defined in certain edge cases.
Yes, that would be good. It would be good to clean this up - why another deferred object, can't you do:

   ajax.complete(next)
For RF, as we do sampling for each tree, some IDs in the table _t1_ will not be included in tr_association. At this point, left join will introduce garbage data. However, the garbage data will not be used to calculate the split criterion value, since we will ignore them (have no meaning).
Not anything I remember. The WSR epsilon test might have been motivated by me testing some sample data. I wrote all this in one week, so there was not much time, and this just seems inconsistent. I'll check again before merging.
There should be no checks after printing a result.  If there is an error condition an error should be thrown beforehand or the rest api should have thrown an error.

A user can have no ssh keys uploaded.  We try to get them to create one and upload it early but if the user just created the account and ran this command they would have no keys.  They can also delete their last key.  This really shouldn't fail except when there is a connection or authorization error. You should handle the empty key list case and make sure the output is clean as well as directs the user to use rhc sshkey upload to upload their key.
We shouldn't use fixed px font-sizes. I have added a base font-size of 10 px. Not ideal, but at least there is less difference between the browsers now.
@tfiwm no code should get executed at require time. You should create an initialization function and call it at serve startup
"with using" seems tautological. Can't we attach "__enter__" and "__exit__" methods to TStyle?
Chex is no more.  If there are no other dependencies on `source` then take this out.
Two spaces after a period, and I would say "UUID might be included"...  Some distros include uuid-ossp as a separate package (or a user repository), so it would be good to make a note of that too.
You should get rid of these two lines!
Now i see. thx for clarifying. Maybe now it's the time to re-think of the method name which would tell me as a user of what "missing" means.
What about "NotThrown" instead of "Missing". It would state for specific operation that you expect when something is going to happen when a test is doing wrong; means not throwing an exception results in an error message.
Then you should also have an option to write the message to:
+ System.out
+ System.err
+ Logger (level)
Sometime the people do not use the console at all, because JUnit is part of test system with own logger system, and the application has other logs.
Here it is necessary as the tests shall be ran if

 a) no included category is specified
 b) the actual category in included
There's no actual test in here?
Why apply this to the menu/toolbar vs. ``#editor-holder``?
Remove the second part of this comment since you moved it to next runs.
Ugh. Yeah. What do you think we should do here? It seems like div, form, ul, ol, table, and tbody are the most likely elements to scroll. Should we add listeners to those? Or go ahead and add to all block elements?
I think it'd be helpful to have a comment here saying what the type of ```itemInfo``` is.  It took me a while skipping around the file to figure it out.
To pass JSLint, you need a space after `if` and you need to use `===` instead of `==`
Minor nit: we generally put one space after "//" and capitalize comments.
Thanks, overlooked that one
why not add the class in the new apf.bar("class":"element")
moreover a more descriptive class name would be handy and avoids overlapping
Did you notice, by the way, that I introduced a new type, 'Series'? It's a bad idea. I'd really like something better.

PS I think searching for options is tough in options.html. Rewriting it with, at least, a full index would be good. We should discuss that separately.
Map element is not a service. You must create another instance to use it.
Rename to `LimitedDateTimeField`.
`list-style-type` is used by `ul`, not `li`, no?
do we need to leave this in?
fail case?
I don't think it is worth adding a function call to the stack for this. It is fairly straight forward and I don't see it growing any time soon.
why the mixed case on the word 'log'
在解析 dso_path 命令的时候没有要求必须是绝对路径, 这里缺少提示信息, -t fail 后用户不知道什么情况
Can just do 
```javascript
} else {
  parent.removeClass("active");
}
Removed, this will come in the uploader-dev branch
It is a convenience - a reminder that this line is necessary in the geoserver data directory's global.xml file for the editing tools to work correctly when running GeoNode locally via 'paver host' .  So the global xml file in the zipped gs-data download (http://dev.geonode.org/dev-data/synth/geonode-geoserver-data.zip) should actually be changed to include this line.
Yep, will add it.
Mirek please make sure this directory (lib/util) is accessible from BOTH katello and headpin. Installer uses it! You want to have this one in the katello-common.
Interesting method name considering it takes no params.. I realize you moved it from SystemTasks where it used to accept tasks.. Do you wanna try to change this to something like pending_message or something :) .. I know a bit nit picky but will be nice )
That…
Fine, same is true for me thinking about Linux ;). End of OT then ^^.
This could be written as

```php
$exists = class_exists($taskClass);
if (!$exists) {
  throw new MissingTaskException(array(
    'class' => $taskClass
  ));
}
```
Can't you simply use `driver.current_window_handle` before the loop? http://selenium.googlecode.com/svn/trunk/docs/api/py/webdriver_remote/selenium.webdriver.remote.webdriver.html#selenium.webdriver.remote.webdriver.WebDriver.current_window_handle
BTW, do you know that you can handle null (mostly coming from java APIs) with the Option companion? Option(somethingPotentiallyNull)
Tento vznikol z lessonSearch/currentSuccess a zobrazuje zaznamy v dvoch stlpcoch podobne ako aktualne prebiehajuca vyucba
I don't think so, because you still create a new instance (line 36) of the module class (or does it output html)?
this looks up from simpledb which stores the value true / false as a string.
This really shouldn't be a conditional statement.  There should be a solution that adds a conditional lower down in the logic (if one must be present at all).  Perhaps around fs.writeFileSync, a conditional that either writes the data to a file, or the specified stream.  

That is to say, this whole function should should look mostly like it did before, with only minor modifications to account for stream inputs/outputs.
Set $origin once up here and use it throughout the function.
Ok. I'd tweak the comment so it says:

```
       """Test that logging in as a user with PASSWORD_DISABLED doesn't kick up a 500."""
```
You can use the ``in`` operator. It's better:

    if 'firefox' in item['from_user'].lower() and 'firefox' not in item['text'].lower():
I disagree--they're getting used by code that's outside of this module, so they shouldn't be "private".
Total nit... and sorry I should have done this earlier. But everywhere else I use an rgba color I use `0.x` not `.x` for the opacity, so I think we should probably keep doing that for consistency.
Either way, it would be nice to remove all odd constants and replace them with something like `LENGTH_OF_CRASHID_PLUS_ONE`. 

Or is this old code that will soon die? If so, why am I reviewing it?
This can go too. We use nosetests now through out.
Method too long. Needs to be splitted into submethods
Not sure I'm reading closely enough, but why do we need special code here since the invalid message looks standard? Oh, because it is a fun_match, yes?
Happens with the subtree splits every now and then unfortunately. But luckily composer can handle it.
This method is unnecessary, please remove.
These tables seem to be used locally only, so they should at least be static and properly constified.
`src/Symfony/Bundle/TwigBundle/CHANGELOG.md`
How about changing the PHP doc, so that people can rely on the fact that ArrayAccess is also supported?
Ok, I'll remember about that when I get back to creating tests for this class.
No! `get_class($this) === get_class($child)`. So it can be any FormBuilderInterface, not just FormBuilder.
You should not remove `@` here.
@ return should be FilesystemIterator[] as its an array of FilesystemIterator objects.
Well, you may need to refactor some stuff. But the way you do it currently is broken as soon as you have several classes using bcrypt (they would all use the config of the last one, thus not respecting the cost)
Thanks man ;)
You can use the same email I put in #2606 if needed.
Missing a space after `if`.
This is wrong. First of all it must be Photo.type.USER. Second, why do you need this type at all?
What? Married? Why?
Yeah, it's nil.
I guess.  It just feels weird to have a file that's under rubber's management but isn't a template so it can't be customized by a user.  But, it's no worse than what I'm doing currently.
Seems there exist many redundant spaces
you can just use Z2i::DigitalSet instead of using the selector (more pedagolocial if included in the doc)
This is a no-op test basically. I was trying to avoid creating the colorprocessor at all if I know the incolorspace is already linear. I'm getting a little confused with scene_linear, linear, linear_alias, etc. Without OCIO support, "linear" will always be present. With OCIO support, there are a few checks in place in the event that "linear" is passed in... which swaps it out for "scene_linear". I'm thinking mainly of the colorconfig.getColorSpaceNamesByRole("linear") function. Should I just use that when creating the color processor, and leave the hard-coded checks for "linear" in place?
What happens if its removed? We can always add things later on if there is no immediate benefit.
No - it doesn't transform anything... it is the projection manifestation (i.e. the map).
Not sure what 'bad' topology is. Not really in scope for this PR though.
emoveService? :p
Засунуть все в один div?
again, just delete, don't comment out. we still have the git history if we need to go back
why is this needed in addition to the willAppear/didAppear events?
I noticed that myself ... and now there is no evidence of it. ;-)
@kabir as far as I have looked all attributes defined in CommonAttributes have AttributeAccess.Flag.RESTART_ALL_SERVICES

but I should have removed flags variable as it is not used anymore...
I think this check is needed as well. At least judging from the method name, it does a different check from checkModelAgainstDefinition()
Ah, I see. The values will be 0 rather than 'undefined' if gathering the stats is disabled. The text descriptions should say that.
Maybe these two methods should be static methods?
Yeah, maybe until we use a common prefix in the whole BB we should only use the `icon`!
needs a test ( should have asked before yes )
elementID -> elementsID

But what should it be a property of the object instead of a local variable?
Let's isolate the flight mode logic into another module and map it to `ril.radio.disabled` so both sleep menu and settings app can use it.
On Fri, Sep 28, 2012 at 9:49 AM, Josh Carpenter <notifications@github.com>wrote:

> I made a judgement call on "top sites - you don't have top site yet". It
> told the user they didn't have any of a thing they didn't know about.
> Ridiculous.
>
Yep makes sense, no need to bombard the user with useless information.

however, that what's left is a bit silly in context, given it's repeated
> directly above.
>

One other thing to bear in mind is that this message is displayed under a
title saying "Top Sites", which is confusing. Maybe we should either change
this message or remove the Top Sites title if there are no top sites?
`document.getElementById('battery-level').firstElementChild`
i -> icon please. i is ugli.
What happen when the image has predefined the shadow? The result could be ugly
Hi @riadhchtara !

Maybe I missed the definition of the l10n.get function, but cannot see it in the PR or in the file previously initialised. 

Something like:

var l = navigator.mozL10n.get;

Also in the rest of the applications, we are using the abbreviation '_' :

var _ = navigator.mozL10n.get;

Can you verify this, also rebase since the latest changes for web activities already landed in contacts and we cannot merge this PR.

Great work, thanks!
I’ll have a look.
Same as before regarding deprecated functions. Also likely to be a serious problem for porting commhistory-daemon, it makes use of MNotificationGroup.
ya, i've seen that and hate it.  but i'll try it on for consistency.
lowercase :)
Actually I was planning to add `RelationRegistry#fetch_edge`  and `RelationRegistry#fetch_node` that would work like `Hash#fetch`. WDYT?
Please add some unit tests to this module
ah right I forgot we wrap in a closure
I agree its long but it'll have to be pushed to another sprint as me breaking it up requires unit test on the new smaller chunks.
Why do we care if user can upload a new attachment? Even if the setting has changed, user should still be able to remove his existing attachments.

So how about making a query on how many attachments user has and if he has any, enable tab if current user is the same as profile or if user is a moderator.  Also: not all attachments can be removed, so we should do individual authorization for every attachment.

BTW: It looks like this function allows anyone to delete attachments from other users.
The virt-v2v command enables virtio drivers in the converted guest if possible, as usual, we will find /dev/vda, but I'm not sure about this.

Alex->Wayne, please help confirm it, thanks.
By the way this is similar with Monitor classes, and just think maybe we need change that too.
Oh, CC_SYNTHESIZE already declares set function.
ok my bad, removing the others keeping this one for memory
``new VersionConstraint('<', '1.2.4.0-dev'))``
Yeah, thanks! Updated :-)
When writing new tests, try to use `assertThat(x, is(t))`, instead of `assertEquals`. [It has much better readable error messages, and some other benefits.](http://junit.sourceforge.net/doc/ReleaseNotes4.4.html)
This line shouldn't be included. It completely escaped my notice.
I've implemented the sd_journal_wait method, which blocks indefinitely or for a number of microseconds: d6b4c4c2efd573f99cdfccf00d3be7cb8b174089

 Not sure if its a bug, but currently journald ignores any match filters, and sd_journal_wait returns on any journal write.
should be proxyUrl.hostname, proxyUrl.port and proxyUrl.protocol
Make sure we write a listener for this next week
good - if it can  easily be handled, please do, and add it to the description of changes. Thanks Also that takes care of my concern above about DBsettings.pl and settings.pl  - they can go along with the sseccurrittyy folder.
@wiibaa Time parsing in ruby (Time and DateTime both), as a general rule of thumb, is tragically slow. We can address the 'slowness' of LogStash::Event#ruby_timestamp later and independently.
I just can't understand why we are ending up with such compicated code:

    var unbind = Function.call.bind(Function.bind, Function.call);
    var apply = unbind(Function.prototype.apply);
    // Good luck to guess what apply does!
    function mix() { ... }
    
    apply(mix, mix, concat(sources, options, { ... } ))

First why aren't we using `mix.apply` instead of `apply(mix, mix, ...)`?
Then, I remenber that we already used `concat` somewhere like this, but why aren't we using `sources.concat`?

    mix.apply(null, sources.concat(options, {...}));

Or if we do not trust `sources.concat`:

    let implementation = mix.apply(null, sources);
    implementation = mix(implementation, options, { ... });

Or anything similar?
Nit: I think it would be better off assertinng against `main.id` instead!! (Assuming value there is `'test-harness/run-tests')
this `stack` isn't used.
I think we should add "Fennec" instead of removing the whole block; unless we are sure that the module doesn't have any particular issue with `Sunbird`, `Seamonkey` and `Mozilla` (see [system/xul-app](https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/system/xul-app.js#L33-38) module).

Or, we could agreed that we don't care about module's platform compatibility as soon as the module supports `Fennec`, `Firefox` and `Thunderbird` (and so it's fine remove the block).

@Gozala @Mossop what do you think about it?
Finally, the KPI backend will have to be updated to handle these new states.
I switched both the key and secret to be generated from uuid4.
It seemed too complicated. I was wrong.
Done
Unfortunately it can't be removed because the deprecation warning never occurred for the `:inf` value.
If a file is modified and one switches to another file's tab, what happens? Seems to me that this will not work, but I have not checked ;).
This should be wrapped in a local private method to align with the other branches that raise.
I hate to nit pick, but this is just a style change. Please split it from the actual change.
Don't worry about JRuby and Rubinius. Each project tags its set of known failures in its own repository.
Again, a doc would be good.
inconsistent spacing (e.g., need extra space after the final ',')
No, because the wrapping FuturePool catches all exceptions and converts to Future.exception (i.e. Throws). That's why I thought the TODO should be okay for now.
`if (stats.pending) {`
All this for each should go to own method. like
```
ImportLanItems(NetworkInterfaces::List(""));
```
similar like it is done with network interfaces import.
How?

The point is that the response composed in the **event** is what should be sent, not the one in the application object.
IMO write "implements ObjectInterface" is more readable.
Please fix the syntax of variable reDiabled
Yes, it is created as soon as something is installed. It's referenced in this bug: https://github.com/mxcl/homebrew/issues/12870 which says that you should just install something...
Instead of echoing this out, why don't we put this file in the dotfiles repo here, clone this repo, and symlink it?
`@Then /^the json response should contain following items:$/` ?
Did you remove "meta" specially or by mistake?
Is there a framework-specific reason to use the language attribute?
I don't think it needs a pragma - but I think to be polite we should state that the module now requires Perl 5.10 or better, using the appropriate backward-compatible syntax.
Store the current PID in the lock file to be able to check the process status later on.
Two empty lines before ...
info on all arguments whilest you're at it?
Change to new style copyright lines
Why do you extend `PathUserResponse`? I think it would be better to extends the `AbstractUserResponse` and implement the few methods from the interface in the class itself?
Is this the recommended range (-359 to 360) for defining meridian ranges?
Ah yes. Good point about the "maybe not a tuple" thing. And yes, `list + list` makes a new list, doesn't modify either of the operands, though I'm w/ you about avoiding it at all costs.
Any way to do this relatively, given this should get served up from the same place as other `ADMIN_MEDIA` stuff?
Yeah, this should be in part of an `else:` block, in case it's a `GET`.