labofsahil/github-event-dataset-2012 huggingface dataset:
I had just about finished switching all rviz files to the opposite order, general to specific.  I didn't know there was any recommendation one way or the other, it just sort of seemed more proper to me.

I would say generally it is better to avoid changing the order of that stuff in a pull request unless it is required to make it work.  It just distracts from the real work at hand.
Fixed it in last commit.
I prefer *, and I am not sure if `-` work in ReST. Do they?
Import only modules! ;-)
So their timestamps is nice to have for statistics purposes, but for us, we would like to know if our data is stale and which data is the most recent.
No, we should not hardcode this like this. No language should be special. If we do not have language, then we don't display anything. (Or display request for help, that somebody gives us source in that language.)
Ok, I will look into it tomorrow. 

I tried to add dependency but do not know how :). I overloaded get_dependencies event and tried to add MapPanel there but to no avail. A little hint please.
No it didn't, but it might be useful for somebody else.
Надо просто добавлять еще одно событие которые будет проверять на формат и если что выкидывать исключение. Просто делать это перед диспатчем
Nope, that's it...
i don't said you should do this
`custom_texts` and `script_texts` are handled in the same way, these texts are added to m_mTextDataMap, the other DoScriptText function is the only one that access to m_mTextDataMap
removing the other DoScriptText function will break `custom_texts` too
either both table will drop or don't remove any DoScriptText function
(btw. `custom_texts` is empty for me)
Auth.getUsername() oder so
the caller might not read the counters, but the underlying record reader does not know that. Presumably you would want this to work with any inputformats and recordreadears...
I would actually prefer to just do obj.respond_to?(:to_guid), but I stuck with the current conventions.
I cannot click on the namespace part, but this should be in the Common namespace (and folder), not in Internal.
The date looks wrong, it is now 201*2*.
``# the node ID of the group``
It still supports old clients. Just that it changes how info is displayed for them. I thought that there is no purpose in showing extension id here, whether it be old or new client.
If what you want is the font used for menus, this is not valid. I guess you want:
```css
font: menu;
font-size: 11px;
```
Done: cf405b2
right; converted this and the ones below to asserts
Method _resolveCtypesImports was not able to resolve these libraries?
Do you have an idea how it could be fixed?
I'd suggest renaming remove_extension to remove_file_extension. Would you like me to do this then submit a new pull request?
ravel('F')

>>> np.__version__
'1.5.1'
>>> np.arange(5).ravel(order='F')
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
TypeError: ravel() takes no keyword arguments
>>> np.arange(5).ravel('F')
array([0, 1, 2, 3, 4])
add 7th edition, since I didn't find it in the 5th
Thanks @xsuchy, will submit an updated PR.
If no one else is going to call position_assets, then this is OK. Otherwise, this method will explode horribly if there's no assets dir...
... but can be easily installed per the instructions in section BLAH above?
Why snapshot here?  You're depending only on released versions of plugins.
Oops, missed that.

I realized this morning that for UWA and other members of the open source community, this should also accept the site.name on the command-line.  Should I revise my commit or make another commit on this branch?
Feels confusing having different return types for the two very-similar-sounding public method, claim(ReusableMachineTemplate) and claim(int, ReusableMachineTemplate).
il faut que tu precises au debut. Tu ne peux pas dire movies and music industries, c'est beaucoup trop large ca englobe tout (artistes, spotify, writers, studios et labels)
Have to hard code a value here, as OpenCover does not expose this value yet,  sawilde/opencover#111
why ignore the trace?
nit: I rather prefer to write it like: 

        var events = ['mousedown', 'mouseover', 'mouseup',
                               'mouseleave'];
I bet there is a way to render a twig template without access to the `$app` variable. I dont necessarily view this as a blocker, but def. my biggest comment on this PR: there's a lot of theme level duplication trapped in the PHP source...
you could shorten it with ``window($name ?: '')``
If this is commented out there should probably be an obvious reason if were bringing it main line. This does not seem obvious.
And in the
```ruby
mock_galaxy(:put, "/api/v2/users/.........", post_headers, nil, 200)   
```
instead of nil in the return spot, we just return the <http success thing>
Можно использовать BufferedReader.readLine().
Выводить на экран.
else не переносится.
That is strange.  This documentation

http://www.sqlite.org/capi3ref.html#sqlite3_bind_blob
http://sqlite.org/c3ref/bind_blob.html

says that it returns an int. What does the compiler say it returns?
I am curious why you chose to use a different approach than was used in PHP. It would make maintanience easier if we used the same accroach across languages, unless there is a compelling reason not to.
Should that change take place in SoOSiM or SoOSiM-ui? (I understand it's the latter iff they talk about different things)

Would it make more sense to use the 'small step' by default? Would it help us avoid this 'issue', so that running means running and idle means idle and there's never any discrepancy between the simulator and the ui?
I think this locator will catch even failed uploads by the ambiguity of the locator
Although this is a bit ugly it is an exmaple of catching only a successfully uploaded screenshot div.preview div.preview-thumb[style^='background-image:url(https']
Forgot to say ... So the main reason for doing the owner this is that the permissions will probably be the same cut and pasted code. But since that's just a guess, it good to keep things modeled as accurately as possible.
I'd suggest removing the last part. If this block is only for API compatibility, then this whole labels block can be moved into `is_local_max`.
Thanks for the comments but this indeed very experimental. 
I'm still trying to figure out a sensible way to restructure the tests.

By the way, the imports are just copied from ''test_common''.
Is this a convention that absolute imports are acceptable in tests but not in other places?
``may`` > ``many``?
Yep, otherwise a config exception is thrown.
Should default value be localized or not?

I'm split here as (most of) Ding defaults are in English but as a default value content makes little sense to our local/Danish userbase.
pronto. ver aí se fiz certo a atualização do pull request. Primeira vez que fiz isso :P
include v8.h (with the warning guards)
need to add  "--blackberry=bbndk_path"
Too far above. Should be exactly above the line with `New(2.0)`
this fixed in #10
Après téléchargement des sources et installation des :doc:`prérequis <Prerequis>`, vérifier la configuration à la racine de l'installation :
Ok, I will use that.
should it be doing this/short circuiting this if stopping is true?
seems my test is insufficient. wait a min i will add more tests
In reading further, this block could be combined with the block below to create:

```
if user.email.nil?
    user.email = "#{username}@sakai.invalid"
end
```

WDYT?
Yeah, I can just remove this try then, because run should catch any exceptions thrown in run_tests.
typo: `taks` instead of `task`
This stuff really has to go.

If you run the phpunit stuff with our default phpunit.xml.dist, it will [tell you to setup the deps](https://github.com/composer/composer/blob/master/tests/bootstrap.php#L14-16), which is graceful enough IMO.
я на самом деле его добавляю в функции addListener ) здесь, наверное, просто убрать забыла
what is the purpose of these variables?
This one will be an API break. You might need to look at qmlcontacts at least to make sure it'll keep working.
Yes, it should. You'll have to do the format conversion to phs-net, but ```payload.encoded``` is the encoded shellcode, just like in remote exploits.
check -uplay_steam_mode is intact?
It looks like `_repr_jpeg_` and `_repr_png_` are pretty similar. Maybe you could create an additional method that gets called by these functions; e.g., `_repr_image(self, image_format)`, which would contain most of the logic?
Pretty much.

What other commands could benefit from patched state?
I think this needs to be a LayerItem!
Who gives a shit.

but the quotes around default are unbalanced.
Let's not hard code `12` (and `4` below).  Use `Float32Array.BYTES_PER_ELEMENT` and `Uint8Array.BYTES_PER_ELEMENT`, and suddenly the comment can go away - win.
Hmm... yeah, makes sense.
ok my mistake. I meant tabsBackgroundColor property applies to all tabs/all states
In fact all these login/logout* vars are not used.
You mention in the comment for `getWrappedView` below that caller is responsible for null-checking the return value, but it's not done here.
check out fs.fstatSync. It takes a file descriptor and throws an exception if the fd isn't valid, so you could write a helper function with a try/catch to get what you want.
Default behavior here is complicated. If the user specifies top and left, for example, the view is *not* centered.

I think we should just say "undefined" like we do for top, left, etc. We can refer people to the 'layout' property for the full rundown on positioning.
I have done some research in this regard, and have put up some cards on the board. We can discuss this in the next meeting. I will do some more research on it in the meanwhile.
Maybe we already discussed this, but why move this sentence to a sibling bullet instead of leaving it as a parent-paragraph?
newlines are cheap
Ah, yes!. You're absolutely right.
I'd recommend using curly braces for all your `if` statements.
I would have a separate section on syncing the release with jboss-as/quickstarts.  Just to keep these two steps separate.
![](http://i215.photobucket.com/albums/cc153/MistressOfSpices/Pokemon/slowpoke.gif)
Is this a good name? Maybe "isSeeded" instead?

Property?
Porter, 

additionally on this issue - I find this a code stylistic issue - and not one of best practice ... neither Matt or Adam felt this was a necessary change in all the code that they have reviewed in the past. 

Betsy 

----- Original Message -----

From: "nrporter" <notifications@github.com> 
To: "plymouthstate/plymouth-webapp" <plymouth-webapp@noreply.github.com> 
Cc: "bscoleman-psu" <bscoleman@plymouth.edu> 
Sent: Wednesday, October 3, 2012 10:56:04 AM 
Subject: Re: [plymouth-webapp] changes for adding new BM Report App (#425) 


In legacy/hub/HUBSQL.class.php: > +    {
> +		  $sql = "SELECT * FROM `bm_rounds` rounds WHERE rounds.bmr_id=? ORDER BY time ASC";
> +      $rs = PSU::db('hub')->Execute($sql, array($data['id']));
> +			$rounds = $rs->GetRows();
> +			$data['rounds'] = $rounds;
> +      return $data;
> +    }
> +
> +	return $null;
> +	}
> +
> +/**
> + * add a Round Entry for Building Manager Report to the MySQL hub database
> + * 
> + */ 
> +	function addBMRRound($now, $data) 
If you are adding something to the database, it is best practice to return some sort of success indicator. It costs nothing in processing terms, and adds the ability to grow functionality later on. Please return the result. 
— 
Reply to this email directly or view it on GitHub .
Is there a reason why this has to be exclusive? As in, currently if you include this middleware then you can't use any other type of route.
Hi Peter,

We're not ready to update our API maven version yet. Everything else in the pull request looks fine, but if you can roll back this change we will be able to merge it.

We plan on putting the client up onto a public Maven repository in the future, but are not ready to do that as yet.

Thanks,
George
version is 1.4 now... no?
please wrap the line
`ajax = response.xhr?`
Is there any follow-up required here, creating issues or filing a bug on the server, or can the code just be removed? OK to stay if it needs to be there for consistency.
What do you think about running the yum provider instead of package?
OK.  I will revert that.
you're requiring 'ci/reporter/minitest' three times, given that this file is always loaded I guess you only need the one here. Could you please remove the other two?
let's keep the lang consistent with the applet - "Add Earlier Activity"
http://www.flickr.com/photos/toms/4332774392/sizes/o/
you need to inherit from the params class if you intend to use variables from its scope as class param defaults
argh. 1 second.
"Temporary" doesn't need to be capitalized, right?
ok, I think I fixed this right.  Instead of "created_by=user" in the kwargs, I did "user=user" where user is the obj I created in the lookup
Combine into one `padding` declaration
Why enforce Double? Surely any number can be converted into a Double.
You shouldn't need the &lt;code> here.. markdown supports code block by indenting four spaces, which makes the content much more readable when viewed as plain text. See http://daringfireball.net/projects/markdown/syntax#precode
I guess one could rescue only ArgumentError exceptions in this case.
Why does it need OpenJSK @badtoyz? What exactly requires java?
Should be able to build without it?
Can you explain me what is the function of the ownerId, I'm checking it, but to understand why you add it here. 
I've also notice that most of the changes are formatting changes which complicates a lot the revision. Instead of looking at 3 classes I need to check 50 
:(
is it because we are changing the line ending that this file appear to be deleted and re-added?
As noted above, `ApiClient` (or something similar) would be a more appropriate name here.
Принято писать теги с маленькой буквы и не забывать закрывать их
```htm
<p>
    <input id="input" size="20" value="3,2,1"> input array, for example 1,2,3</input>
</p>
```
@wireframe so I thought about doing this, but honestly I don't know if this is possible with mocha. I'll give it a shot though.
"keywords": ["symfony2", "form"],
{ ro biyar balaaaaaaaaa
Same with this print here
I'll wait Ayoola to change this as this is his part
This could be a static const, since it's not exposed outside of the class.
Obviously needs someone to add their appname in - maybe a config file for this?
"note" should be a constant
There are some corner cases for which SKIP should be valid on a delete event.

About UPDATE onDelete .. I don't think we can implement it, we don't have the values to be written ? Might throw an exception.

I wonder if one wants to support a use case for which projection still needs to match the document but having no fields and return an entry like "this entry matches your query but was removed". Doesn't sound like useful.
Cool, but the rest of the project has 4 space tabs.
The use of query interface is a bit ugly.  That can wait for another day though.
I just made the loading of the TextHolder mapping conditional on the dialect, combined with Assert.Ignore in the only two tests that use TextHolder. Didn't seem to bad.

'``csharp
                protected override IList Mappings
		{
			get
			{
				var mappings = new List<string> { "ReadOnly.DataPoint.hbm.xml" };

				// Firebird doesn't have the text type.
				if (!(Dialect is FirebirdDialect))
					mappings.Add("ReadOnly.TextHolder.hbm.xml");

				return mappings;
			}
		}

Should I ignore it for Oracle too?
Need to update the comment.
type should be Number
Should we document the event passed in?
FILL behavior actually means that the current view will fill _available_ parent width (or height), not be exactly the same as it's parent necessarily. Update this, and the autoFillsHeight description below..
Should be rewritten using the new PseudoType nomenclature established for Docs.

See the setContentOffset method of Titanium.UI.ScrollView for an example.
I reversed the sense of the query here because the original code started with Procedures, outer joined PatientProcedures, and then removed Procedures with no PatientProcedures via a HAVING clause, essentially asking for rows we'd immediately throw away.

The result is classed as an array of PatientProcedures instead of Procedures, but it *is* a summary on a join...honestly not sure what the best practice is here.
``=5`` seems weird to me. It looks hacky.

And btw, annotations tend to use camelCased named, not dashed names.
This won't work!
Please add a test that it doesn't cross the bridge twice
This needs to be targetted to the browser - "sys.browser"
Ok, I will.
This get_text is fine I'll go ahead and add it to the base, I'm not sure about the iFrame stuff though.  Ed / Ryan any thought on the iFrame stuff?
Do you consider that line to be human readable?