labofsahil/github-event-dataset-2012 huggingface dataset:
This was there for a reason. Please test this PR really well. It might have to do with resizing a panel to 0.
These should be properties instead of ivars.
I think it was cleaner to leave this without the returns.  they are implicit
Consistency: use byte shifting.
uh-oh.
Better Error msg ?
Should be `gxp_feedsource`
I dont like it too. The original current() and etc behave so so I re implement it .  for now it looks like an unwanted side effect since we know it is an empty array or ended array.

发自我的 iPhone

在 2012-4-6，2:19，nikic<reply@reply.github.com> 写道：

>> @@ -58,6 +58,29 @@
>> #define SPL_ARRAY_INT_MASK           0xFFFF0000
>> #define SPL_ARRAY_CLONE_MASK         0x0300FFFF
>> 
>> +#define SPL_ARRAY_CHECK_POS_EMPTY_OR_END_REACHED(object, ht, err_msg) do { \
>> +    if (!(ht)) { \
>> +        php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Array was modified outside object and is no longer an array"); \
>> +        return; \
>> +    } \
>> +    if (((object)->ar_flags & SPL_ARRAY_IS_REF)) { \
>> +        if ((object)->pos == NULL) { \
>> +            if (((object)->pos_h) == 0 && (ht)->pInternalPointer == NULL) { \
>> +                php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Array was empty " err_msg);    \
>> +            } else { \
>> +                php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Array was already reached the end " err_msg " and it will be rewinded to the beginning"); \
>> +                spl_array_rewind((object) TSRMLS_CC); \
> 
> I'm not sure I understand this. Why should the array be rewinded when one reaches the end?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/php/php-src/pull/38/files#r651769
This description needs to be updated since you're averaging across iterations now.
kvadratik ist krieg!
You can probably change this to be `time = original_time.presence` to get the same result.
This is used when generating the column SQL statement. When getting the column type, this method is called, which correctly adds the `[]` to the column statement
Do we need to alias method chain it or can we just use super?
Would it be best to remove: "Defines the name of the table column which will store the class name on single-table" in place of the more descriptive text you wrote?
The idea behind the `ThreadSafe::Cache` is there would be no locking for reads.
Same here, but `unlock` or `remove_lock`.
Should be "Active Resource".
The problem is that the warning will be showed either in the application so I don't think we should define the `store_attribute` and also the custom accessor. If this test fails we can remove `:phone_number` from the assertion
Idea was to move `find_by_sql` and `count_by_sql` methods into AR::Relation. They were in same module, that was included into AR::Base. Hence there was a need to separate them.
(Btw, my comments on outdate-proofing the tone are unique to Scaladoc/API docs- they don't hold for non-distribution docs like docs.scala-lang stuff)
Also as below ... ;-)
Okay what about this. Say I have class `A` that refers to class `B` from another library that I don't have on classpath. When I write `staticClass("A")`, currently it will crash. As far as I can guess, in your branch it will succeed (I actually like that).

What is supposed to happen when I write `staticClass("B")`? This function simply navigates the symbol table and returns a symbol if it's already there. Therefore, I guess, `staticClass("B")` will return a `ClassSymbol` that will appear valid. If that's the case, that doesn't seem to be very good.
Re 1) since we have a silent for makeAccessible all the real errors are handled before. Although stabilize can be run afterwards, this is already outside of silent so it should report any errors.
Usually I am reluctant to put things like 'reporter.errors > 1'  as it seems hackish to me.

Re 2) good point.
Unless my understanding of Sinatra's workings is incorrect, perhaps I should read it.
it would be better to use

````
self.new_record?
````

instead of id.nil?
Not sure how comment and code relate here.
The contradicotry nature in my notation of 'H' but not of 'v' definitely violates the whole argument in favor of book-keeping. Decided to get rid of the notation '^N v^P' and just go with 'v' as a result.
But I dream that sympy will be able to handle with singularities, and e.g. inform about cases of expression or simplification is valid by request, I remember last year we discussed about singularities analysis.

[Infinities and Singularities](https://github.com/sympy/sympy/wiki/Infinities-and-Singularities)

This interesting too:

[GSoC-2011-Application-Yuri-Karadzhov] (https://github.com/sympy/sympy/wiki/GSoC-2011-Application-Yuri-Karadzhov#wiki-Main_Functionality)

[UD-Under-Development] (https://github.com/sympy/sympy/wiki/UD-Under-Development)  section "Singularities"

btw, it worth to add to the idea list. What do you think?
I am writing the other pull request at the moment.
That needs to be dedented or else it won't handle multiple limits (it quits after the first).
>
> I guess because this one is for human reading and the ccode is for machine
> reading, and the machine doesn't care about order (the compiler will just
> optimize it anyway), so this saves a little time.
>
>
I thought of that but thought that maybe this opens up the troubles with
testing since the order may vary. By judicious selection of tests, however,
I guess we can have the best of both worlds: coverage and efficiency.
btw, the reason that log(x) is not in the returned expression is because the subs replaces it.
It was an additional 'Point' so I took it out.
Yeah, I will put in a keyword arg
ditto about what used to be
If it's not too long, why not just show d.premises?
My English is bad? I'm well known for my beautiful, literary English! :P 
And jQuery ajax callbacks are ugly and messy. This is not judgement. This is fact.

And to be serious - I would prefer to prepare new example and will send it to Craig for translation to English :D This has nothing to do with new js API for 1.4. This is example how to use jQuery in 1.3 right now.
Wie bereits bei der Form erwähnt, gibt es hierfür noch keine konkrete Vorschrift... Leider...

Grundsätzlich gibt es viele verschiedene Möglichkeiten. Und einige findest du auch in unserem Code verteilt.
- Fixe Url (im Controller:: $this->_redirect($url);
- Relative Url (z.b. deine Form)
- via Route (da wird die URL von einer gewünschten Route zusammengestellt)

Via Route finde ich persönlich noch elegant... und auch robust gegen kleine Änderungen.
Ein Beispiel dafür findest du auf dem DashboardController in der createcampAction.
(Diese leitet den User nach dem erstellen des Lagers zur Campliste zurück)

In deinem Beispiel würde das dann etwa so aussehen:
$this->_helper->getHelper('Redirector')->gotoRoute(array('action'=>'show'));
Do you actually have to disable individual options or can you just disable the <select>?
So... something like this?

> // That node is the first tr I'll find. If it finds the body tag: BOM!!!
This looks strange. Do active users have inactive reasons?
I actually removed the parenthesis to increase readability. Really don't like unnecessary parentheses. `&&` is evaluated before `||`, that's just fact.
select the primary key, i.e. msg_id
Why are there transforms in both directions? Instead of transforming the second time, don't transform at all and use original data.
1. You should document that in the docblock, but I already said that. 
2. Maybe the first check should be is_object() so it is clear what is being checked.
Please don't add functions to front facing files, it makes it impossible to re-use the code. For example a blog MOD could use this function when it is in the function file rather than having to duplicate the code. Functions should be kept in function files, because why else use a function call in the first place?
vezi că ai pierdut: onclick="remove_storage()"
Ya, definitely. Will fix this on Monday.
I think this line needs to be removed.
This is the part that I suspect will fail in Manhattan.  In Manhattan the server handles multiple apps, and so doesn't cd to any particular app directory at startup.
Ok. Didn't clue in to that at first. I'm all for a little more obvious name so it's not confused with a simple getter.
Does $.post() urlencode the params?
439-443: could make your code simpler, a little shorter... I think this should work:

```
var examlist = Ext.getCmp('examList').getStore();

for (i = 0; i < examlist.getCount(); i++) {
```

remove unneeded variable ```prob_num```, and confusing ```prob_num = prob_num -1```. Change ```<=``` to ```<```.
add an error msg.
You can take better advantage of a change like this by:
    declaring the member final, even though its contents can still be mutated.
   eliminating null checks on the member (like the one in toJSONString).
This function is called from a function that has <code>@nested_commit_on_success</code>, if you look closely.
Is it worth a comment here indicating that this is a generated file to avoid any confusion? I'm not certain it is, just a thought.
"Everywhere that needs to make.." sounds odd to me.
Maybe I'm lost in the diff - but I don't think you said anything about creating the template file yet.

and you probably wouldn't say "call" the template, maybe just let's use that html template
Thanks! Didn't know that Py3 didn't have xrange
Do not swallow the error here...
typo, and needs description
I'm not comprehending the purpose of `^|`
`*classes` and you can do away with the tuples!
The sentence is confusing because I don't get what is plc.  Do you mean plpgsql function, or C function?
Don't need array brackets on these two lines
```ruby
"PYTHON=#{which 'python'}"
```
`downloader_type`?
Is there an 'a' missing in `message_paylod`?
Do we really need a separate test for this here? acks and nacks are both events and get routed the same way.
Ok. will fix.
versteh nicht..
In the event of the user not being found for whatever reason, we still need to be able to delete the user from the list.  Otherwise they would get stuck.
It's not useless for the generics.  Let the compiler inline this shit.
@amb26 
Yes this brings us back to the initial conversation about the whole config loading pattern based on components/grades.
Is that an indicator that we will proceed in similar fashion?
I mean that the default value for IncludeCategory#assignableTo is ALL, and ExcludeCategory#assignableTo has default value ANY.
have you had a look at my describe() implementation in the other pull-request? i think some of your ideas are better and some of mine. if you would merge some of my stuff this could result in "even better" ;)
I'm open to a fix.  :-)
Also, since every parameter is provided to the method, how about simply `message`?
Agreed, I will remove this after merging. Thanks @antond!
Why not just replace the block with air?
Why not a simple falsy check as before.  Is "" really a valid command ID?  (I bet it would break lots of other code that _does_ use falsy).
Need to add '.fullPath' after active file:

```
 ... { fullPath: activeFile.fullPath });
```

The file open command is expecting a path name, not a FileEntry.
Remove ``=``
Github is showing indentation wrongly, but it is ok in the real file.
You are completely right -- confirmed it with Ulf this morning. Pushed a change, accordingly. Good catch!
domain needs an exact match - term doesn't seem to consider hyphens as part of a non-whitepsaced block of text. alphanumeric it seems.
Ok, so similar to a memcached key. Whatever you want as long as it's uniquely identifying.
can not merge
Maybe a comment about what's going on here? This is not clear to someone who's neither a maps guru nor ninja :(
I prefer using .Any() instead of .Count() > 0
So this would be Clips.Last().angles.Any()
I am confused. How is this XML?
Ok, I updated this code to not set the path unless all the line attributes are set.
Add TODO to move this user creation (or get) into the User document/manager.
What if we don't have a target?  At this point, I don't see how we can avoid having one.  Should you throw early if it's not there?
Doesn't ActiveSupport::JSON delegates to the MultiJson backend since Rails 3.2 (or even 3.1)?
This could could just be `echo hello > #{path}` in these contexts right?
Is there a general purpose linter that will pick up on this? jorge ortiz's
linter doesn't seem to pick up on this.

On Wed, Aug 8, 2012 at 5:26 PM, Blake Matheny <notifications@github.com>wrote:

> In finagle-redis/src/main/scala/com/twitter/finagle/redis/Client.scala:
>
> > +   * If the key is a non-list element, an exception will be thrown.
> > +   * @params key, value
> > +   * @return the length of the list
> > +   */
> > +  def lPush(key: String, value: List[Array[Byte]]): Future[Int] =
> > +    doRequest(LPush(key, value)) {
> > +      case IntegerReply(n) => Future.value(n)
> > +  }
> > +
> > +  /**
> > +   * Removes count elements matching value from the list.
> > +   * If the key is a non-list element, an exception will be thrown.
> > +   * @params key, count: The sgn of count describes whether it will remove them from the back or the front
> > +   * of the list.  If count is 0, it will remove all instances, value
> > +   * @return the number of removed elements.
> > +   */
>
> The next 12 methods need formatting/indentation updates.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/tumblr/finagle/pull/1/files#r1337097>.
>
>
so, I'm just copying the way they do it above - should we correct all the path / glob handling in this file throughout?
Agreed. It grew a bit organically but better as case.
Actually, I remember now you said there was a name conflict with refresh.
But there could already be some assemblies loaded in AppDomain, which are not accessible via BuildManager. What then?
Hm... good to know. Thanks.
I find sometime PEP8 to be lacking in sense, but we agreed on it so.... So in this case I would either break it like this, or break it after all the selfs - but PEP8 dictatest that we put them all on and split just before the 78 limit?
Might be cleaner to just set the flash message in the if statement and move the redirect statement to the end since its always the same.
Yeah I mean it'll change a lot...we may even have to move these over to the
video model or whatever as we have more views, but I think this is simple
enough for now.

*Nikhil Goel* | Vanderbilt University, 2013 | Computer Engineering,
Economics**

LinkedIn <http://www.linkedin.com/in/ngoel1> |* ngoel36@gmail.com | ( (256)
503-9183 | NikhilGoel.me <http://nikhilgoel.me/>



On Sun, Dec 2, 2012 at 2:24 PM, Luke Steensen <notifications@github.com>wrote:

> In app/models/user.rb:
>
> > @@ -34,5 +41,15 @@ def self.from_auth(auth)
> >      end
> >    end
> >
> > +  def bookmarks
> > +    #returns a user's bookmark List
> > +    lists.where(name: "Bookmarks").first
> > +  end
> > +
> > +  def bookmark_for (video)
> > +    #returns a user's bookmark Listing for a video (if it exists)
> > +    bookmarks.listings.find_by_video_id(video)
> > +  end
>
> Ok that's fine, we can refine it as we build out more views and actions.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/bitcast/bitcast/pull/22/files#r2288003>.
>
>
Don't shoot me, but I suggest goto...
I don't understand this part. Why make fdsetRecv depend on the state of the write queue?
Now I got it yes, my brain told me hey, when SOCKS4 and -proxy, SetLimited(Tor and IPv6), which currently is not the case ^^. But I like the idea, as really no one expects a non-proxy connection, when -proxy was set. If you want me integrate that change that's good, as it makes sens (even as special-case).
I'm not sure as the GCC documentation is quiet about that:
http://gcc.gnu.org/onlinedocs/gcc-4.7.1/gcc/Optimize-Options.html#index-fstack_002dprotector_002dall-901

And we use it for Bitcoin-Qt, too. Do you have a soure to verify ``--param ssp-buffer-size=1`` is set when ``-fstack-protector-all`` is used?
Why did all these tests change?
Missing spaces around operators.
It depends what you consider to be a feature in the app. The files should map to features, and not be split up just because implementation or test setup is different. So, the question remains, is it a different feature for someone requesting access to a group, or admin granting it? It's really hard to know. If you're writing story cards, then perhaps it's one card per feature, but it gets more confusing when you go back and modify existing features. One thing I do is to split the features up into directories a bit. For example, this feature relates mainly to groups (more importantly I think than to users). I might have called the file `features/groups/users_can_join_by_request.feature` or some such. I'd probably use this feature for all situation where the user requests to join (regardless of who approves, or if approval is needed), but then have a different feature for people being invited to join.
No it doesn't. This is the body of `QtObject.create`

```
parent = self._parent
parent_widget = parent.widget() if parent else None
self._widget = self.create_widget(parent_widget, tree)
```

In the case of images, the parent passed to `create_widget` will be `None`. So, the code you have written is entirely equivalent, but breaks the continuity with the rest of the Qt* widgets. It's easier for the developer to reason about if you follow the convention.
The try block isn't a problem. But don't other files already have `__file__`, so we only need to change anything for .ipy files? Also, have a play around with %run and work out what files have `__file__` there. The fix might need to be in `safe_execfile_ipy`
style is no wildcard imports
Where is this callback url actually set in the url? I'm having trouble following where this is coming from.
Did you intentionally remove this QR code line?
We were testing permissions with an admin user, but that was lazy of us. We now try to be more explicit, creating the right permission for the user. In this case, I think the user needs the "'flagit.can_moderate'" persmission. You can see an example on how we set up the user here: https://github.com/mozilla/kitsune/blob/master/apps/wiki/tests/test_templates.py#L916
much better! (not that it was your fault) :)
this is brilliant!!
The code is so good it could be copied into the __doc__ as an example.
What's the difference between this one and test_basic_postgres_crashstorage2?
Why the extra `'./'`? Seems like urljoin does the same thing with or without it.
Generally speaking this should be in your global gitignore file as this kind of cruft can vary wildly depending on the OS, or even the text editor. Please see [Ignoring Files](https://help.github.com/articles/ignoring-files) on Github's help section.
no single letter variables, `package` should do
With the move of the code that relied on this I'll remove this but indeed we should talk about this in either master or 2.1 as it's not consistent between the values that are sent by the framework and what can sent by the user.
(Boolean)
The form should probably also accept an integer as name, which makes it more fault-tolerant (instead of throwing an exception). 
The Form::has does also accept an integer as there is no difference between `$array[1]` or `$array['1']`. Furthermore you would not need to cast to string here.
The `(array)` cast converts objects to arrays of their properties.
I can probably do without path, it's just a util for concatenating file paths. Xregexp provide some enhanced support for reyes that missing in some js implementations.
What is the alert?
Are these endpoint counting tests valuable? They don't feel very expressive to me. Possible that we're testing this implicitly with following tests? Is it here to improve test failures/errors?
I think it is better to create a single Activity in future which will switch between Script/Costumes/Sounds fragments instead of creating three different activities. 
Fragments contain all the necessary  logic inside.
What do you think?
I think there's tons of places with except:, I always have to ctrl-c multiple times before the exit happens.
Indenting wou ik nog fixen maar was ik vergeten. Zal ik zo committen.
Actually, even if you could do this in all rubies, without running this in IRB I'm not sure what this does. Does it return from the `parse` method, or does it return from the fetch block? If the latter, then I would suggest just doing `name = options.fetch(:freezer) { yield }`. I tend not to like to use the return keyword unless it's in a guard clause and I want to exit early.
We don't have a `node_tags` class. You have removed all the `node_*` classes and put `table#nodes th` (which is much nicer), but then we should remove the `class` tags from `main.html` and `virt.html`.
Why the dot here?
I would be awesome if the minHeight and minWidth can be configurable
Our codebase always has the curly brace on the same line as the function
Don't forget to update the module.info file.
Given that is not used from 7.0, could we remove it?
The default is actually an empty string, which doesn't seem correct.
Not sure if it was a good idea to axe the `this._helper` check, but it seemed like the right thing to do. That part might need to be tested further.
i would use `image : ( $('img:first').length > 0 ) ? $('img:first').attr('src')  :  ''`

But we also need a way/function/method to make the url absolute (just in case it is relative to the current web page)
no, it's not necessary, I forgot to remove it. I used it for my debug 
function.


--------------------------------------------------
From: "Martin Roth" 
<reply@reply.github.com>
Sent: Wednesday, May 09, 2012 11:52 PM
To: "chummer" <chummer25@gmx.net>
Subject: Re: [jasiohost] java web start jvm crash (#3)

>> @@ -20,6 +20,7 @@
>>
>>  #include <stdio.h>
>>  #include <string.h>
>> +#include <conio.h>
>
> Is this include necessary? I'm not familiar with `conio.h`, but I found 
> [this](http://en.wikipedia.org/wiki/Conio.h).
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mhroth/jasiohost/pull/3/files#r798289
>
I guess that you want to do an early return at the beginning of the updateAlarmaStatusBar method if mozSettings is not present.
Nit: replace `...` with `…` (ellipsis character instead of three dots)
> I'd like (but you don't need) parens around the && expression.

I agree, it's much more explicit - will do.

> Have you checked that there aren't any other similar lastModifiedDate uses in the code?

No... let me check that right away. Should I file new bugs for these?
Can't we use a direct call to navigator.mozL10n.translate insted of using a MutationObserver? I do like them but I feel like it is overkill here.
Nit: s/favourites/favorites/
yes, this is the page that is executed on the window opened. it is actually hosted to support the OAuth 2.0 implicit grant flow and is the page to which FB redirects once access token is ready to be extracted and to be passed to the app.
You may want to use the origin as well here. Otherwise windows from different origin can collapse.
Hmm, can you provide a bit of explanation?

Without any z-index, the PIN keypad screen will be unaccessible (behind the homescreen). Do you mean it should have a lower z-index?
Weird to make that mistake, will fix
Let's make sure to fill in the Javadoc here
We could validate the options at the beginning of this method and raise errors for a specific option being invalid. If the format changes, we'll have to change the validation too. 

This maybe a wild edge case but once we validate the media type options, to me at least, it feels like there might be implied validation of which methods can use which media_types which is another headache.

If you are talking about `case` or a bunch of conditionals for a lookup table I think it will end up more complex and confusing since there are about 32~ variations of the header that can be sent currently. I might not be thinking of the same thing as you though, some example code or even psuedo code would help me understand better.
This method might make sense in the context it's used in but I'm not sure it belong on the interface itself. Maybe lower level operations should on the interface like, CreateBranch and Reset, and this can be an extension method.
Fantastic, @alexch.  I won't bother posting the 32-bit output.  As soon as you have a version ready for testing, let me know.
Hmm.  Well, one could argue that it's philosophically consistent with why Installfest has students installing XCode instead of RailsInstaller Mac, and (partial basis for) Komodo instead of SublimeEdit.  On the other hand, installing homebrew make a much easier upgrade path for Git and other useful tools for development.  So +1 to arguments to be had for either.  I think this collective topic deserves discussion on-list before making a decision on the PR
story はどこにも出てこない、history のミスリード？
↓
コマンドの実行完了後、"story" 項目に新しい履歴が追加されます
~~~
ユーザは、値をタイピングするか選択肢メニューから選んでジョブへ受け渡します。
~~~

~~~
ユーザは、値を入力するか選択肢メニューから選んでジョブへ受け渡します。
~~~
の方が自然かも？
I removed the checks, not documented as I don't know fully how to use
these. The remote send command was removed because it was adding overhead
and we were doing noops on the datastore server end.

On Fri, Nov 16, 2012 at 9:44 AM, Chris Bunch <notifications@github.com>wrote:

> In AppServer/google/appengine/api/datastore_distributed.py:
>
> >      return
> >
> >    def _Dynamic_UpdateIndex(self, index, void):
> >      self.__ValidateAppId(index.app_id())
> > -    self._RemoteSend(index, void, "UpdateIndex")
> > +    #self._RemoteSend(index, void, "UpdateIndex")
> >      return
> >
> >    def _Dynamic_DeleteIndex(self, index, void):
>
> Document this method, and explain why all it does is validate the app id.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/AppScale/appscale/pull/99/files#r2154460>.
>
>



-- 
Navraj Chohan (Raj)
PhD Candidate @ UC Santa Barbara
http://cs.ucsb.edu/~nchohan
http://appscale.cs.ucsb.edu
http://nlake44.posterous.com
I believe all the BitVector values are given names with the k prefix.
For example, https://github.com/H-uru/libhsplasma/blob/master/core/PRP/Object/plObjInterface.cpp#L20
Now I'm getting the error too, worked fine 40 minutes ago.
Fixed. I normally do this elsewhere in the templates in the application, so I must have just neglected doing it for this one template.
Why instantiate it in a static block?
Uh. Will fix this
Meh, this would just be to support Python 2.5 and 2.6 and I presume it was just a copy-pasta fix from the docs. Certainly we don't need to care about sub-second accuracy so remove that bit and we're good :-) (or alternatively use 2.7, it has been two years now)
maybe return the result of `copy()` as you do it in `copyTo()` ?
That's correct, even though in the grand scale of things it won't make a noticeable difference, but +1.
no, I alter it for the execution of this test, which is intended. Other tests will have their own value as it is initialized in setUp before each test (and btw, this is copy-pasted from the other test using classmap, 2 methods above)
Mmmm `mark_notification_read`?
I'd use 'checkEvent' rather than 'check' for that hook. 'newCheck' mens something else, really.
Remove, don't comment out things that you want to get rid of.  They are still in the git history.
Going to break my rule about doing work things out of work hours for this...

What happens when another module needs to change a URL that isn't `index=n`? Then we have to add another function to `Url` and another model listener. The `Url` module shouldn't be deciding how to render the gallery's URLs, surely that's the same cross dependency we're trying to remove?! I honestly don't think it's an improvement, just code bloat.

Also, in that code, simply emitting `modules:url:loaded` doesn't help on its own - I wrote it to return the `getParams` function because my code needs to call it on a history event change (it will have updated since the page was loaded and the event was emitted).

As for loading `history.js` ... another 14kb of JS! The URL updating is a cuts-the-mustard thing, I don't think it's important enough to polyfill.

If we build this by just loading a list of images it'll still be complex - either we send a dozen+ 600px wide images down the pipe at the user, or we give them thumbnails and then write some JS to upgrade them, plus more JS to support swiping and URL changes (that code should still be there regardless of how the template is rendered). This is one of the most UI-driven parts of the site so I don't think it's bad that it's a few hundred lines of code.
That would be fair, since the field is optional.
Ah, I think I get it. In our require statements, we're passing weiqi in as a parameter, and the requiring modules are mutating it. This works OK, but it seems a little different from how commonjs modules usually work - I've only just learned how they are supposed to work =)
You are overriding `options` argument of `runTests` method.
`new TestRunnerConsole(new ptc.PlainTextConsole(print), options)` is expecting runTests options argument.
awww.  I liked that space.
Does this only occur during a password reset?
Only add a cleanup vow if there is in fact cleanup to do.
I guess probably not.  that file doesn't exist anymore....
Unfortunately, I don't think there is a way to find out a blocks arity at runtime
good catch.

On Oct 30, 2012, at 12:21 PM, TJ Holowaychuk <notifications@github.com> wrote:

> In lib/runnable.js:
> 
> > @@ -186,6 +186,11 @@ Runnable.prototype.run = function(fn){
> >  
> >    // async
> >    if (this.async) {
> > +
> > +    if (this.asyncOnly && !(this.fn && this.fn.length)) {
> this part should move below the if (this.async) from what I can see, because this.async is already = fn && fn.length in the constructor
> 
> \
> Reply to this email directly or view it on GitHub.
>
Added a note in README.md
Another bug introduced by alias abuse. Tests for this file fail.
but use `elseif` instead of `else if`.
Use backslash '\'
Typo `complement`
GMT?
Ah - I'm guessing the first `brew install` creates that directory if it doesn't exist.

If you have the time - you should file a bug against homebrew for that. `brew doctor` failing if run immediately after homebrew is installed is silly.
Is there such command with symfony-extension ? http://extensions.behat.org/symfony2/migrating_from_2.3_to_2.4.html#there-s-no-symfony-command-anymore
Even with <code>USE_SYSTEM_HEADERS=NO</code>?
:evil:
I had a doubt, so I asked yesterday and PSR-2 is without spaces.
Suppose Homebrew is installed to the normal prefix: `/usr/local` and the user is using our GFortran formula. Whenever linking a mixture of C and Fortran object code into an executable or shared library the linking step can fail due to missing GFortran libraries if an XCode C compiler, such as `gcc` or `g++` is used. This is because the C compiler looks for the GCC runtime libraries in `/usr/lib/gcc`, but the GCC Fortran runtime is in `/usr/local/lib/gcc` and the compiler is not looking there.

GFortran knows to look in `/usr/local/lib/gcc` because that is where its prefix is rooted---so everything is okay if you use `gfortran` as the linker instead of `gcc` or `g++`.
@Ninir can you give a look to this and tell me if it is the right way to override a Bootstrap rule?
How to remove a parent listener following this approach ?
you need to give this class a different name .. otherwise the test suite cannot run in its entirety.
The above paragraph doesn't really make sense for me - what is meant here?
I created a ticket for this. And will look into this now.
Cout not use 'name' here since it would overwrite the 'name' from the outer scope
Is that really useful? It is trivial to add, but it seems like useless log clutter. 
run: 'sudo do-it-anyway' if you want @nudded to really do this.
In the PRD from aakash, varying implementations were thrown around but the gist was that Admin>Vouched>unvouched>Public. Since we don't have any use for the unvouched/admin in the code right now, i removed them (in fact, until the last minute I had admin in there but aakash wanted to hold out on that option until we have find grained location and things like that).

Also evident from conversations with aakash is that these permissions were meant to be hierarchical. I agree that this doesn't cover every case and I think we should modify code if/when that comes up.
Style-wise, there should be a space after the colons.
I would use Assert.equal here for the sole reason that if it fails the error message presented to the user will show both the strings it is comparing and where they differ which may just save you having to run the test again to see what the error is.
if i add * before self where it's missing the tests fail.
@cyli Final review would be great :)

Thanks
... even if STATIC_URL is unavailable...
wait, why are there migrations on the SFX db? We dont' want to change the sfx db, do we?
the routes in the routes sub directory  get loaded before the routes.rb file when consulting the (rake routes) table.  The match '*a' is still at the end of the routes table.
yes, but this seems fine (category is null-allowed, there's a test for this), and the categories page now shows how many events are associated with it.
Balls I forgot to add the npm install line too. I am never going to get
this pull request through.

On Wed, Oct 31, 2012 at 12:30 PM, Geoff Petrie <notifications@github.com>wrote:

> In README.md:
>
> > \ No newline at end of file
> > +# DEPENDENCIES
> > +* Node 0.8.14
> > +* ExpressJS 3.x
> > +* Socket.io 0.9
>
> Please add emoji syntax in pull requests.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ABQJS/game-off-2012/pull/3/files#r1996210>.
>
>
these two methods do the same thing.
That's coming from the test suite that's running inside of the Scratchpad embed. The test suite needs to run inside of the internal execution instance (can't cross frame boundaries). It just passes back the results instead.
Actually, there's a better way (if we're really insisting on this :) ): Long.valueOf, which provides the same caching benefits, without autoboxing.
I removed the useless code on line 51.

```
sleep(0.005)
```

I ran more tests and determined it doesn't really add any benefit.
Change please :)
ok my bad, will revert it :)
интересно, что такое index
Capital RETURN
I don't think this works outside of hthor/roxie. What are we really doing here? This -feels- as if we have copied an iterative algorithm without thinking how to parallelize
why must it be evaluated each time? maybe a better question - why would `r` change?
space is missing
hmm there is a wait for this but it's wrapped up in paginator.py :(
Wouldn't it be better to not comment out the code but just keep a comment as to the fact there shouldn't be an exception thrown ?
Specifying "previous" will return rows for the version directly before the one that was just saved, so the versioning commands can be generated.  Code for getting the previous version is under return_version(version_id).
I'm not a huge fan of multiline-string-as-comment.
You can use this instead:

```ruby
tab.templates = Array(tab.templates)
```
I believe the signature here needs to be signed with the tenant of the current user, not the document.
Maybe this function name could be "getFullConfig" or "getTenantConfig" to make it more descriptive?
It might be better to use the _rowsToComments here, as that will give you a proper Comment object.
Can you add a comment for that?
Please format this appropriately.
This could be conflicting with /groups/create.
Also, we should move everything under /api/...
Please switch to ensureSchema and a schema.js file
Would exercising the ShortId library for randomly generating things like this be a good idea?
Could this be clearer as `getScalaVersion(thread).exists(v => v.getMajor == 2 && v.getMinor >= 9)`?
For the documents in this pull request, please remove trailing whitespace. Be sure to check for trailing whitespace in blank lines as well.
Sure X_x

/antoine

Le 24/10/2012 à 19.35, William Durand <notifications@github.com> a écrit :

In src/Geocoder/Provider/IGNOpenLSProvider.php:

> +
> +    /**
> +     * {@inheritDoc}
> +     */
> +    public function getName()
> +    {
> +        return 'ign_openls';
> +    }
> +
> +    /**
> +     * @param  string $query
> +     * @return array
> +     */
> +    protected function executeQuery($query)
> +    {
> +        // var_dump($query);

useless ;)

—
Reply to this email directly or view it on
GitHub<https://github.com/willdurand/Geocoder/pull/112/files#r1931437>.
return empty($_merged) ? FALSE : $_merged;
Да, замечание снимаю. Простите, не сразу понял алгоритм
Всерьёз подумал над вашим предложением, только если переделать переменную класса в свойство (мало того, что readonly, так ещё и NSArray), то не смогу его менять в своей категории. А по заданию, именно метод категории должен модифицировать последовательность.
В условии не сказано как должна происходить мутация, и можно ли заменять саму на себя ячейку или нет. Мутация вообще абстрактное понятие, лично для меня как она пройдет было не понятно. По поводу не оптимальности согласен.
Я, наверное, вас уже замучил, но такой вариант ничего не изменил.) Теперь при каждом упоминании в коде NUKE_ARR у вас будет создаваться новый массив.

Вы можете использовать такое решение:
```objective-c
// Cell.h
@interface Cell
+ (NSArray *) letters;
@end

// Cell.m
@implementation Cell

static NSArray *lettersArray;

+ (void) initialise
{
	lettersArray = [[NSArray alloc] initWithObjects: @"A", @"T", @"G", @"C", nil];
}

+ (NSArray *) letters
{
	return lettersArray;
}

@end

// AnyOtherSource.m
NSLog(@"%@", [Cell letters]);
```

Или посмотреть как это сделал я с помощью спецификатора extern и C-массива.
@Mamix в обсуждении к решению от @voleg (он похожим образом решил) уже пришли к выводу, что хоть такой метод и является формально правильным, но поставленную задачу выполняет не до конца. Переделаю как появится время.
In development.rb and test.rb it has "$" symbol. It doesn't really matter because it is in the comment, I'm just trying to keep the consistency.
Is that part of the weapon PR? o.O
The linuxraw driver contains no Raspberry-Pi specific code, and should work from any Linux terminal.
change this to `log.verbose()` instead of `console.log()`.
I am good with keeping the same request open, myself.
but isnt the CommonPHPDriver providing all this already?
oh, 他ブランチの秘密計画...
Maybe add a link for convenience? ie https://plus.google.com/events
condp或者case，更简洁一点。
I'm not very keen on this change.
Yeah, I intentionally included a bunch of things to help people build a useful representation of clusters. Basically having all these things makes it easy to visualize and report clusters in a publication. I can add or remove as necessary. Can you think of any functions that would simplify this? If not, I can just make the stc_all_cluster_vis STC and let that be enough for now, perhaps building an example later that would demonstrate how to get useful stats / visualizations of clusters.
Use Assert.assertNull(item)
Awesome catch.
Wel... the thing that calls popPath isn't Monadic (routeName). I think this is OK because the caller checks that the list is not empty before calling popPath - so realistically this err will never come up unless there is a bug.
attention aux merge :)
This class looks great. Can you make it a jUnit test instead?
Use an API link here for the `select` method.
My intention was to somewhat duplicate the structure of the reports data structure produced by test.tree/run, which contains the test thread information in the first element, and the test report maps in the second element.  This way I can use the same code in the runner to extract the information.  If there's an easier/better way to do that, I'd be happy to do it.  This just seemed like a very easy way to accomplish it.
The code for getDelete() can like the following:

~~~
if ($this->getIsDeleteRequest())
{
     $this->getRestParams();
     return isset($this->_restParams[$name]) ? $this->_restParams[$name] : $defaultValue;
}
else
    return $defaultValue;
~~~
Почему бы просто не сделать их слотами?
Заюзай же ?:
_Acá podríamos poner algo de cuando, como y porqué se decidió cambiar el formato del product backlog_
Falta mencionar el tercer parámetro.
only you can answer that :)
You probably meant "self.parent.item_no" instead of "self.parent.get_item_no()", right?
You shouldn't need the `:url => { :action => 'create' }` here.
Is this correct way of getting context? (getActivity.getContext)
This should be good enough in general. However, there could be cases where things are more complicated like below

![](http://leejjoon.github.com/matplotlib_astronomy_gallery/_images/allsky_galactic_proj_06.png)

And, I think it is better if the basic underlying functionality can support this. With pywcsgrid2, we do something like

```python
ax.axis["left"].set_coordinate(0)
ax.axis["bottom"].set_coordinate(0)
```

This is more like a verbose version of "ax.set_tick_location(0, 'lb')", with slightly different point of view.
Boolean, no boolean
I'm not sure it is a good idea to be move it around 170 (the else clause of the uri connection) cause I have to do the same tests for the options, that's why I'm doing it after
Will fix this soon - good idea!
agreed. Id like to chat about it on monday
Right, the question to ask yourself is why the context needs to be ImmutableContext  for expiration (leaving eviction as is)...

No, there has not been any discussions, but you could create an expiration manager to deal with this separately, and let eviction refer to it as when needed. IOW, have EvictionManager injected with the ExpirationManager. The scope of ExpirationManager should in theory be the same as EvictionManager, per cache. Another benefit is that you get the data container depending on a more precise component, the expiration manager.
Are you gonna create a new cache per task created? Isn't that far too much? Imagine a customer executing 1.000.000 tasks, are we gonna have a cache manager with 1.000.000 caches?? Can't we have a temporary cache that's shared by all tasks??

IMO, we can easily solve this with 1 cache, created on startup on each node, with some defined configuration. Avoids the need of a cache create command, deal with concurrent cache creation, makes things simpler... :)
there are several of these issues in mpl. range is a common one. Was it pylint which was shouting at you? In this case, I am not too concerned about the use of a builtin's name.
Generally, yes, but with the exception that if there are only a few, and they are corrections rather than regressions, and they are in the file in which the substantive changes are being made, then it saves considerable work to leave them in.  I don't normally find them until I have already worked with a file, at which point I really don't want to have to separate the deliberate changes from the whitespace changes.  As a related point, I think that a moderate amount of unrelated cleanup--the occasional typo or badly-formatted docstring--should be allowed to stay in a commit, if it is not so much as to obscure the meat of the commit.  So there is a judgment call involved. Regarding white-space-only changes in files without real fixes, I agree; it is trivial to keep these out of the commit, and take care of them separately.
These comments should not be in the section for changes to v1.1.x.  It should be in a new section for changes to v1.2.x.  I could have sworn I already started a new section in master, but I could be wrong.
Oddly enough it actually doesn't show any side effects. It would surely show in the images. Some good old debugging through print statements also shows that apparently changes to rcParams don't carry over to the next test. 
Correct me if i am wrong though. My guess is that the testing framework reloads everything from scratch for each test.
Passing self wouldn't strictly be necessary if there were a closure on the function in axes (i.e. the function could be created with a reference to itself from the outset). Having said that, this approach is consistent with  the other artists' remove method, so +1 from me.
we don't have a results table form on the homepage
i don't understand, how the hash gets substituted into _delete_run_locator[1] , but this may be a problem with my incomplete knowledge of python
This should really be an `if` statement instead of a ternary; it'll make it look much cleaner and easier to read.
wouldn't this be better written as below?

```
$val_ordered_current_val = htmlspecialchars(
    $val_ordered_current_val
);
```
The API functions should probably take required parameters first and optional parameters last. I'll create a follow up issue for this.
Is this still necessary with the widget loader changes in place?
Hint: It's ant format source, but there's a reason why ant format source is doing this.
Please remove that due to ongoing removal of Array3
Format does not look Ok, follow this convention rather:
$tmpTopic->create(array(
    'parent_id' => 0,
    'names'=>array($f_language_selected=>$f_search)
));
Easy to do -- I'll make that change.
This was just matching other methods in session -- I'll take it out.
That might be a little aggressive, but let's see how we go with it.  It's 8KB per session, which I can live with.
Yeah, I haven't yet worked out the full interaction between an SC.TextFieldWidget and SC.FieldEditor, so this is just temporary.
It would, yeah.

OTOH I'll be removing this whole code block in the next couple of days (maybe even tonight), so I'm not too worried.
Should the type for parameter ``$file`` not be "string" instead of "type"?
Are you sure that ``$entities`` (of type ``*``) is traversable?
Injected whitespaces break the formatting pattern and add unnecessary line changes.
You have Next Line and Next Slide. I guess I could have called it Next
Either Thing or maybe Next Line Or Slide. What do you want to call it ?
I'll rename.
On Sep 13, 2012 8:37 AM, "Alfredo Deza" <notifications@github.com> wrote:

> In plugin/posero.vim:
>
> > @@ -136,6 +138,10 @@ function! posero#PreviousLine()
> >      call s:Previous()
> >  endfunction
> >
> > +function! posero#NextAnything()
>
> But the name throws me off. What is *anything*? in what context? If this
> is supposed to be exposed to a user so that they can map this to something,
> "NextANything" is not meaningful, it is confusing. Next line? Next slide?
> Next line and then slide?
>
> The problem here is that you don't want to abstract it this way, the user
> needs to know that it is doing the next line(s) or next slide.
>
> If I am mapping this to move forward with the next lines I would not
> expect to suddenly find myself on the next slide.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/alfredodeza/posero.vim/pull/3/files#r1597049>.
>
>
It might be good to sanity check that the list isn't enormous. If so, maybe just show the first few and then "and others".
Agreed about this being confusing. I expanded the note in DOM4.
Nit: this should be ancestor and opener
Not intuitive, esp for code trying to use this - the annotations should (except for this code, hidden away in the guts) be written to be as easy to use as possible, for writing methods like

    @Limit(10)
    List<MyData> loadStuff(@Keys List<String> keys, @Skip int offset);

as opposed to 

    @CouchParam(name = "limit", value = 10)
    List<MyData> loadStuff(@CouchParam(name = "keys") List<String> keys,
                           @CouchParam(name = "skip") int offset);

Even renaming `@CouchParam` or whatever to the shortest possible `@P` still is pretty verbose - the code that turns this into a HTTP call would look nicer, but this is designed to be easy to use from the perspective of writing new service methods.
I'm missing something. What's wrong?
Fixed. As you have shown, I was using a reset, and a white marker. Would you like me to resubmit, or submit a patch?
It wouldn't surprise me if you can't. Once I merge a PR into master it's effectively "done". I think referencing the old PR number is sufficient.
please keep 16 here, just add your 17
Is this supposed to be `:user_input => input.match`?