labofsahil/github-event-dataset-2012 huggingface dataset:
Symfony 2.0 is broken : and the branch 2.0 does not revert it 

'''
[ErrorException]                                                                                                                                                                                                       Catchable Fatal Error: Argument 1 passed to Sensio\Bundle\GeneratorBundle\Generator\BundleGenerator::__construct() must be an instance of Symfony\Component\Filesystem\Filesystem, instance of Symfony\Component\HttpKernel\Util\Filesystem given, called in /Users/jf/Documents/workspace/offres-parrainage/vendor/bundles/Sensio/Bundle/GeneratorBundle/Command/GenerateBundleCommand.php on line 298 and defined in /Users/jf/Documents/workspace/offres-parrainage/vendor/bundles/Sensio/Bundle/GeneratorBundle/Generator/BundleGenerator.php line 27 
'''
Lade till funktioner, så gott som klar nu. Det fungerar att köra med ett graphicalObject i tut1.
Too bad I actually liked the fact it wasn't in the application list.
Great, thanks!!

btw - any love for https://github.com/SpaceManiac/PermissionsBukkit/pull/6 ?
Why remove ```<```? :P
Format: semi colon not needed.  Please have two spaces before classes.
@config.preferred_currency -- видимо здесь должно быть по аналогии @config.currency
Often you want an objectClass=person or objectClass=user.
Do we have access to section['category'] or something similar? If so, I think that would be slightly better to use than section['emailcode'].charAt(0).

Also, can you give the Javascript access to esp.program.models.class\_.open\_class\_category(), that way we don't have to hard-code the 'W' in here?
haha yeah.. I couldn't stop once I actually started.

I'm not sure if it's easy to tell what's going on. I found a cool forum post on item hierarchy. All the items are still entities as of now (to continue and handle collision), but then from items we can have weapons, armor, consumables... and then a vector of *items could be our inventory basically.. woot! :) 

And the weapon.. works like.. when you click, it becomes a collidable object based on the player's X and Y for that one very loop (though as of now it still stays until an enemy walks into it), and then becomes a "maponly" entity again. Anyway, it works :)  And thus the weapon attack range is the same as its width.

And.. yeah!  From this we should be able to easily add new enemies, items, and weapons, that work. The player just needs to Wield(*weapon weapon) it! :D
Awesome! My last name has 2 t's though :( ... Wolgamott
Add mdpi drawable
Was really not sure if you meant "BDD helps both developers..." or "Jasmine helps both developers..." here, since the end of the previous sentence seems to be transitioning to discussing Jasmine specifically, not BDD generally.
Jotschi - thanks for fixing these little things so quickly.
**Si on ne veut pas changer de repo:** Plutôt que de faire ça et de filer bookmarklet à index.php, tu peux pas dans `add.html.twig` ne pas appeler `{{ parent() }}` dans `{% block header %}` et du coup ne pas hériter du header avec la liste déroulante?

** Et si on veut donner le choix du repo à l'user dans add? ** :)
Not sure about 4chon, but I just tested it here: http://imgur.com/kAwHp
@skurfer - are you going to change to make the SafariApplication *Safari an iVar so you're not creating a new one every time the getSafari method is called?

Can't remember if you did it for the iTunes module. We discussed it in this Safari pull request
i display info message but i want to disable checkbox. ???!!!!
My only concern here is that blowing out a nesting level of 100 seems like we're creating memory usage scalability issues.  I understand that we're unlikely to deal with this for beta1, but I think it's something we should dig into in the future. For now, this is fine.
Why not just include it back here ? Things should be easier to process yeah ?
yes. Looking into that. Hasn't happened yet
should refactor to simpler basic operation, and use array.map(phpVar) to apply to the array
The bug here is really in beautify - it is making a transformation that changes the actual rendered output of the HTML in this instance. So I don't think we should go put in this change into the layout view to make up for beautify's issue.

Admittedly, the same logic could tell me to remove this workaround from the widget definition itself. But given the FIXME comment, I think my hack is okay for now. It's easier to understand, I claim. :)
"ListTextItem" should be "TextListItem"
should this be the MIN?
You dont really need the else{} clause here.
exactly! Sort this out! :)
I don't know either. I left it in because it was revealing the fact that all states evaluate False.
I’d name this `escalateStrategy`
behaviorStackPlaceHolder instead of Stack.empty
Isn't it cheaper to test version prior to set membership?
`ne null`, but that doesn't matter
what about french?
Same for this, or rather DRY suggests we move this to a common location (parameter processing, pre-load ...)
whoops. I was testing to make sure my version produced the same results as the new one, since I wasn't familiar with Spinner.
This blank line shouldn't exist based on PEP-8 standards. http://www.python.org/dev/peps/pep-0008/#imports
can use diff method, newMembers diff currentMembers I think this would be clearer
You could add brackets
@FernetMenta Could you explain this? Shouldn't Xutf8LookupString should have filled this in earilier?
This seems a bit fiddly to me. I think either the relevant method in `mrjob.conf` should be able to handle `None` or a list of paths (or, deprecated, a single path), or the runner should find the conf path itself.
Should be @param {Object}
Right now, currentRate is volatile. Is this enough to take care of it or should we use a call to the actor? In all cases, it would be easy to implement a new call for the actor.
good enough for the Elder class. Also, here quick computation matters more.
Que tu acha de mudar de `:payment_receiver, :payment_receiver_nickname` para `:payment_receiver_login, :payment_receiver_name`? Pelo que eu vi do exemplo disponível em http://labs.moip.com.br/parametro/instrucaounica/ , me parece mais um nome mais formal, diferente de nickname.

```xml
<Recebedor>
  <LoginMoIP>recebedor_primario</LoginMoIP>
  <Apelido>Nome Fantasia</Apelido>
</Recebedor>
```
I think `process_metrics` would be a better name here.
use an positive check and an early return here:

```php
if (isset($this->cache[$name])) {
    return true;
}

try {
    $this->findTemplate($name);

    return true;
} catch (Twig_Error_Loader $exception) {
    return false;
}
```
:boom: :camel: Very nice. :sunglasses:
Take it this is just removing the auto-insertion of suite title and leaving it blank?
As far as I know (and I researched it a bit) System.nanoTime is cheaper OS call wise compared to System.currentTimeInMillis. Also, if you use nanoTime you get considerably better precision which is what you are after here (compute elapsed time).
печаль. каждый раз при конфликте перезаписывать все файлы — это не дело
I don't see how it'd enter this `elsif` condition, since `args.size > 0` would enter the first one.
For 'rebar help' to also support external plugins we need that initialization. How about making two init_config functions? Is init_config and init_config1 ok or do you suggest other names?
Test(s) for this?

What was broken before?

```scala
scala> case class X(xs: Int*)
defined class X

scala> {val X(x @ _*) = X(); x}
res0: Seq[Int] = List()

scala> {val X(x @ _*) = X(); x}
res1: Seq[Int] = List()

scala> {val X(x @ _*) = X(0); x}
res2: Seq[Int] = WrappedArray(0)

scala> {val X(0, x @ _*) = X(0); x}
res3: Seq[Int] = WrappedArray()

scala> {val X(0, x @ _*) = X(0, 1); x}
res4: Seq[Int] = WrappedArray(1)

scala> {val X(0, x @ _*) = X(); x}
scala.MatchError: X(List()) (of class X)
```
Yeah, I left the comment intact, because I cannot relate to that “previous” thing. Might as well clean it up, I guess it was related to catching IE.
yes, I did that in https://github.com/scala/scala/pull/1279, but since these branches are not based upon each other I cannot use it from here.
On Sun, Aug 26, 2012 at 4:26 PM, Mateusz Paprocki
<notifications@github.com>wrote:

> In sympy/core/numbers.py:
>
> > @@ -1710,49 +1652,6 @@ def __floordiv__(self, other):
> >      def __rfloordiv__(self, other):
> >          return Integer(Integer(other).p // self.p)
> >
> > -    def factorial(self):
>
> I can restore those, but the question is do we really need them. Actually,
> I
>
I don't think we need them. And as I said, it's better to make the user be
explicit and convert a Float to an Integer before doing a factorial.
>
> > -    return _keep_coeff(coeff, term*f.as_expr())
> > +    return _keep_coeff(coeff, term*f.as_expr(), clear=clear)
>
> your doctest has a clear=False, so a positive case should be clear=True,
> unless you plan on having multiple levels of true...
>

Sorry...I'm not following. I need to pass along to _keep_coeff whatever the
user passed for clear.
`pl` comes from the list comprehension just after this function. The list comprehension iterates this function over all tuples of valid arguments. This is how `pl` and `the_args` get to be the same. I suppose that I have changed the name of the arguments of this function at some time from `pl` to `the_args` and forgot to correct it in all places.
I've used three different variables to keep the process simple. Using less variables brings usage of temporary variables for conversions on different process stages. FormattedDateString is the guide for textarea's value. dateString is the guide for whole process.
I can see what hes got on his mind :)
+1 Nice Tests.
I just looked at django and sphinx setup.py and they import a module (django.get_version(), sphinx.__version__). I think I would prefer to update the sys.path and import the py4j.version module instead of using execfile.
All title markers (==) need to be the same length as the title above. Otherwise sphinx will not mark them
I agree. That TODO is a placeholder to remind me that I hate that test.
nit: We should either pick uppercase or lowercase for CSS colors and stick with it.
These statics had to be renamed because thread_create is found in AIX system headers. Given that this is xthread.h, it only made sense that this should be xthread_create.
Wow!  Nice.

Don't know if it is possible to break onto more lines, but some comments here might be helpful in the future.
Well, the way the code is right now, quadbase will not allow a multipart question to be added on to another multipart question, so no worries
listDomainMembers -> listEscalationsForPair
"relevant expressions follow" is unnecessary.
this comments out the entire list that follows. nesting error.
A subdirectory seems okay to me.
It seems this code was removed so, fine with me
I just wanted to point out, that its a boolean and not the number of rules.
Maybe bool(ean) would be better?
Should be in ext manager or some reusable class that is part of the ext system. Not in the controller.
You can not assume that system cron is used. You either have to come up with a generic cron task that work in system cron mode and non-system cron mode (see the tidy_* cronjobs) or you have to come up with one task for system and non-system each (see prune_forum vs. prune_all_forums).
So data is updated all or nothing. You know how transactions work, right?
duh, yea, after help and version.
missing local
Changed in 4cec79a14bd7ba495d8e41efade8345e4ba37bfe.
As a general case all code in Mojito, with the exception perhaps of the resource store, was updated to follow the Google Closure standard, which is still YUIDoc compatible, of putting the type first, then the param name. Also, we should be using proper sentence syntax in all comments, Initial caps and a period. This allows us to run the Google linter to verify that we're properly commenting the code since I checks not only code but comments against their matching functions to find missing param declarations, out-of-order declarations, etc.

\@param {string} fullPath The path to the JSON file.
Опять что-то с отступами
I concur that. Duplication is fine. It's the perfect way to check for regressions. I already asked Ilya to modify the implementation in OpenCV, so with the reference implementation in the test it will be easy to verify correctness.
Should be in its own file?
We need the 'seen' variable here as well
> Except, you can have DimCoord instances in the aux_coords list.... 
Heh, oh yes, so there's exactly zero or one or more.
ah, thanks, you beat the tests.
As the management consultants say, there is no "U" in "gantlet".
A lot of project specifics here.
cursor_active must always be false here? Otherwise we have a fatal error?
Could this fail if the mass of the material is 1?
Fixed, more merge damage.
Yes, would definitely have to be a gradual migration (might be a good impetus to make the ORM more featureful in any event).
怎么可以让他执行sql
Well, as I said, I could see it going either way -- if the remote end disappears during this loop I'm not 100% sure we'd get an empty string back, instead I'd expect either a timeout or a network error, and so my worry is if it it *is* a timeout we'd be in trouble.

I tried testing this via a `run("sleep 60")` to localhost & killing my sshd, but that doesn't work -- if I gracefully kill (OS X's) ssh server, it finishes handles the command and then terminates. If I ungracefully kill it, it kills the child process which results in a 'valid' nonzero return value.

Basically I need to test an actual network partition :) which I will do shortly!
Ditto here about `@doc` and `-spec`.
Yeah. Although reading the reserved word policy docs, I see that this isn't actually required for object properties: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Reserved_Words
Alright, besides that everything looks good to go.
No, it's not. :-) But you should then make sure this test works with a custom build that has ajax excluded.
What does this do? Why do you have an incomplete list of javascript productions? I'm not familiar with the data structures html5lib is producing, but I'm suspicious of this part. What happens if my javascript doesn't start with one of these?

Also, is this loop getting run on every token inside a script tag? How does that affect performance?
probably a new line after `fixed;`
Use Google C++ style, please.  `for (`, `"out" + string`
Also can you use a local variable instead of manipulating the input? So instead of doing `p = p || ''` just do `var path = p || ''`.
Seems like this should be internal and not public.
The comment isn't correct here. It's totally fine for live indexing to work in this case since you're not testing the indexing tasks. However, live indexing isn't implemented, yet.

So this should be something like:

```
# TODO: When live indexing is implemented, we can nix the
# setup_indexes() and refresh() calls here.
```
Is this newer version of autoconf required for all setups, or just Xcode 4.3+?
Bug to create the tag: https://github.com/pgib/virtualhost.sh/issues/29
Using `assertTrue()` like this doesn't give us very useful error messages when the assertions fail. I'd rather do something like the following, which will tell us what the expected/unexpected values are:
```python
for req in requests:
    self.assertEqual(req.path, '/')
    self.assertEqual(req.method, 'GET')
```
Probably not, but it may not hurt to send them to it.
Perhaps. We can leave that until later, though.
this is not a behavioral test, it uses fixtures, and as far as I remember we settled on doing behavioral testing
No im saying if we are in a worker then window is self. In we are in iframe then self is window.
Let's move this after maven-cdk-plugin
Yeah, you're right. This code doesn't handle streaming, I can fix that.

The "previous bar" was curl's output.
But now that I see what went wrong with the "if defined $state[$_]" business, I think I can clean this up sufficiently in the radmon routine for now.
nope.  "Keys.get()" != "Keys.getElementKey()"
Do we need to catch all exceptions here?
Sure? I can see them.
I thought it was because of console.log(), and now we have consoleDebug()
Went with C, thanks @Sija!
The account ids we generate and have control over and they're only hashes, but I like the idea of using binds anyway so I'm going to try converting it to that :)
Yeah, I thought you might not. They're now all written this way.
This is great. It took me a while to figure out how the sequence of  runs/waits gets fired, but it's certainly much cleaner code.
Since this loop is based on string compares, I think it could be drastically simplified (and sped up) just by keeping the counts in a map instead and just walking the array in a single straight pass.
Empty strings are falsy, so there is no need for the additional `!== ""` test. This applies to the errorMessage test below, too.
reverted anyway; I think this was from a lack of merge from master (mostafa had made some changes around this)
Happening in server-side.
It should be something like:

```
geom_rug <- function (mapping = NULL, data = NULL, stat = "identity", position = "identity", sides = "bl", rugwidth = 0.03, ...) {
  GeomRug$new(mapping = mapping, data = data, stat = stat, position = position, sides = sides, rugwidth = rugwidth, ...)
}
```
Same here, ditch the old commented out code
Depends. A `rescue` caluse without a specific exception class will only catch exceptions that descend from `StandardError`. And according to the ruby docs: "Programs may subclass Exception, or more typically StandardError".
.. I still had to do this to avoid file conflicts. Any ideas Karol?
Improve alt (make translatable, start with upper case letter).
Moved bounds checking to `__init__`.
Does it matter if it goes into a div tho? Adding in that functionality would make it a good bit more complex than it needs to be and a lot of the work thats done in smart would then be done here as well.
We can drop this declaration entirely; safari 5.1 supports webkit-linear-gradient so we don't need the old style declaration IMHO
we don't need to do that for object literals, see https://webmademovies.lighthouseapp.com/projects/63272/styleguide ctrl+f for  Paren whitespace exceptions
That should be:

```
fileStore.remove( embedShell );
fileStore.remove( embedDoc );
res.json( { error: 'okay' }, 200 );
```
Could bubble be an invalid id?  Will elem being undefined kill this plugin later?  Might want to do something about it here.
What do these two lines achieve?
Any reason here to capture the block?
ideally blocks are indented and on newlines, but probably not worth a change for just pep8
This block got moved to the exception handler for ```import lsb_release```. A much cleaner graceful degradation.
Still should be `if ca_certs:` instead of `if context.verify_mode != CERT_NONE:`. See [discussion form previous version](https://github.com/shazow/urllib3/pull/89#discussion_r2203365).
如果ctx->sid长度是0的话，不要进入循环了，直接fail。
Is it defined somewhere else? If not, it should be `var s` so we don't pollute the global scope.
Is it just that we don't know how this has to look yet until the module/namespace stuff is in place?
Thats because you checku !params[:default_locale] instaed of user_params[;default_locale], but I would recommend to move this checking to model validations:

    validates :default_locale, :inclusion => {:in => AppConfig.available_locales, :message => _("must be one of %s") % AppConfig.available_locales.join(', ')}
Can we remove this reference to CFSE?
It's possible to do in one line:

    text.gsub(/^/, spacing)

but nothing important :)
If this is systems page specific it should live in the section specific to systems (i.e. systems.scss)
Imho it should be compatible with the current renderers and break BC with all at once at some version.
I did not.  Ran it and fixed the lint errors
right, 'manifestPath' is more self-explanatory.
This is a credible start for a valid pure-ASCII table file.
```
BZh col2
1 2
```
Is there a stronger test?
Ok, I'll do this, but I'm finding that (unexpectedly)  the obliquity I had, which is from the Explanatory Supplement, actually agrees best with your 2006 algorithm, so I'm a little confused. I need to go back to the ES to see which equation you used (yours seems to depend on J2000 instead of B1950 as the reference epoch):

```
from astropy.coordinates.earth_orientation import obliquity
from astropy.time import Time

_EQUINOX_B1950 = Time('B1950', scale='tai')

t = Time('J2050', scale='utc')

# ES 1992

dt = (t - _EQUINOX_B1950).jd / 36525.

o = 23.44578777777777 \
  - 0.01301375 * dt \
  - 8.86111111111111e-07 * dt ** 2 \
  + 5.02777777777777e-07 * dt ** 3
  
print "ES:   %15.10f" % o

# astropy

print "1980: %15.10f" % obliquity(t.jd, algorithm=1980)
print "2000: %15.10f" % obliquity(t.jd, algorithm=2000)
print "2006: %15.10f" % obliquity(t.jd, algorithm=2006)
```

gives

```
ES:     23.4327736170
1980:   23.4327890498
2000:   23.4327855442
2006:   23.4327743945
```
Add one or two rows of the the numeric table values here.
Woops, that's in an io:format, sorry.
So change this to a protected function?
PSR-0 + http://www.amazon.com/The-Readable-Code-Dustin-Boswell/dp/0596802293 + Object Calisthenics + our own stuff = doctrine
I would add a `- if can? :edit_description, model` above here as well since users without the appropriate permissions should never see this form.
I missed this, but I'm out-of-office these days. Will try to do it when I'm back.
use utils.import_string, as elsewhere.

And the default should be set in the notebook_manager_class default value.
I don't know of any, @jlongster may have one if he already used it elsewhere.
Yes, I've also updated playdoh-lib to update test-utils.

Because test-utils has a new TestRunner. See https://github.com/jbalogh/test-utils/pull/18
You could move all of the above into a utility method on the test that takes in the locale, whether to force the full installer, and the setting for `AURORA_STUB_INSTALLER` and save a lot of typing.
I can't find #footer-menu anywhere in the project, I only get css and js hits when I search for it. Old stuff?
Unless it's possible for a thread to be created and be locked by default, you probably don't need this. But... it's not a big deal either way.
indent 4 more spaces.
lots of commented out stuff
@mattbasta I agree, it's pretty confusing. I didn't touch that in this commit because it was a different change than just updating the URLs, but that forgot password page is essentially gone from Persona.

The best way forward is probably to remove that link from zamboni. If people have problems logging in, they'll see the "forgot password" link in the Persona dialog.
you could just condense this to
```ruby
@response = Scraper.new(params.delete :url).scrape(params)
```
Redis doesn't have this concept of connection strings. It also doesn't have a concept of a username. So, I fixed this too.
Eh.. I didn't notice .gitignore was already there. I just pulled gitignore for python from github.com/github/gitignore repo :-). I will fix this tonight. Btw what is .swp for? Is it something which we manually generate?
This was the one thing I was still unsure about, should I rename the method replace? Call parent::replace($data)? Both? or Neither? :)
Totally agree, I'll change that around and include that as part of the pull request that takes Phil's feedback into account.  Thanks!
Thanks for your comments.
Fixed.
Yes, this is required
CS here (and docs)
This should probably be moved to the `debug.xml` file as the `ErrorHander` is only registered when debug mode is on. We don't want this listener to run in the production env.
okay, moved
`(\d+|(?:\d+)` == `\d*` ? 
maybe we can use `[x.[:xdigit:]]` and `is_numeric` ?
this is wrong... as `getValue()` [can return `null`](https://github.com/ruian/symfony/commit/fc7c7f645869e30010f3f8e050189303bfd5c2c8#L1R194). Could you revert and add a comment here (which I should have done in first place).
Can it be also achieved with surpressing php notices like `@$session->getFlashes()`?
What's the point in returning null here?
extra line breaks after `(` and before `)`
This is not required, `null` is fine.
@jalliot I'm ont it too... I add features step by step, it's a WIP!
if we introduce an interface, it means that the setParent method could be called on *another* class
Please use a short class name
you should not throw an exception IMO as the user cannot avoid calling it on a dir as soon as the folder in which it searches for files has subfolders.
I'm leery of these key binding changes.  Since 'space' is often used as pause/play in all sorts of movie players, and we are hoping to add playback controls this summer, I think it would be a mistake to use space to indicate "next image".  I'm also not sure about backspace being "previous image" -- don't a lot of people think backspace either means "delete" or "go to the last thing I was looking at" (browsers all do this) and that isn't necessarily image n-1 (especially after we add some kind of thumbnail catalog).

But I'm willing to be swayed.  I'll open it for discussion on the mail list.
diese "umwandlung" mache ich jetzt direkt im repository - dann muessen wir sie nicht immer und immer wieder machen...
Or simply reverse the epsg lookup dictionary and check equality - the transformation from epsg -> cartopy crs and back should be 1:1 and we want them to be consistent, so just use a single source of mapping?
Pourquoi as-tu enlevé heroku?
secure_headers aren't really the issue here. Or at least I would like to discuss it as a separate commit for clarity. Also it should be set to [] then not None.
I am pretty sure it is :)
https://github.com/emberjs/ember.js/blob/master/packages/ember-runtime/lib/mixins/evented.js#L25
Can we fix this white space please? :D
this should be passed in as a variable as opposed to pulling directly from node attributes.
Aha! Mystery solved. :)
:+1:  on not ignoring notices. Treat all warnings as errors!
Just separating the pickImage from the place is called. I mean, return false only makes sense when is called from an onclick or similar (and may be sometimes don't) but is not part of the pickImage itself. I don't think is going to affect us in any use case if we  move it inside, so we can do it if you want.
oh noes! such a shame!
Sure, I'll make that change in my patch.
Should we name this file recents_db.js to be aligned with the rest of the app?
The very fact that you're calling this here means that it shouldn't have the `_` pefix.
What do you want to do here? Check if there is any child? It should be done with `visibleCallParentNode.childNodes.length`
Let's add the type attribute to be consistent with the other scripts.
app.css was not used by fb_import.html. I think you are taking advantage of this PR for cleaning it, right?
Done.
Function name and comments are both added, thanks.
Could you add a method in 'JS' in order to add this 'return false' in 'submit' event? If you need help (because we are so busy with a lot of stuff) let me know and I will send you a PR with the patch! Thanks ;)
Is it on purpose?
Never thought about that, in the future I want to move this whole step out a makefile so I can just import the pre-compiled templates.
I'm more comfortable if we add code that checks that the first character is a slash, and adds one of it isn't.
I prefer not to capitalize non-first words.  We can always capitalized them using CSS.
Ok, I remove this changes.
Nix return after module declaration.
The "or higher" idea was discussed and generally +1'd at the Madison Ruby Rails Bridge (if we can do it in a useful, informative-but-not-distracting fashion)
if you want to make this class more compact, you can do:

StringField[T](override val id : String)(implicit override val ord : Ordering[T], override val mf : Option[Manifest[T]]) extends Field[T]

I think....  Not a big deal, just FYI.
To be clear, this is port range for mock servers.
Should not overlap with default boss port ;)
TH
There are some other extensions that are often associated with markdown — `.markdown` and `.mdown`, so it would be nice to support them there too.
Follow proper Python naming conventions for this function name. Also, document this method.
Cannot be static as this is called $integration->open() inside the plugin. Same is true for close().
The content includes a <p> tag so was treating it as block-level.
Better to either use sqlalachemy directly to add the tags, or to do this before `addChange`'s `thd()` begins, rather than call between classes within a DB thread.
Shouldn't this be:

from md5 import new as md5
these were not failing for me
Yeah that's alright (the new exception)
This was written by @palex-fpt in #831
Why catch Exception instead of the checked exception directly?

In time, the RuntimeExcepton catchings need to be removed, because to sweep things under the carpet and resteasy deals with them automatically in the correct way (so it's just useless boilerplate code).
What is it equal for by default?
This is now much cleaner :dancer:
Where did ```current``` come from? Should this be ```current_node```?
Ok. Please watch your indentation.
there is a memory leak here when a jetpack is unloaded, this listener is not removed afaict.

I opened [bug 807382](https://bugzilla.mozilla.org/show_bug.cgi?id=807382) which is related, but we should probably not wait for that patch here.
Let is supposed to be a block scoped, so `pbService` won't be defined outside of this if block, that is why `let pbService` was defined outside of the block. If this still works that's very surprising and probably there is some bug somewhere.
Reverted this and fixed other issues.
So any further comment on it David? Do we wanna make sure that the folder is always present or shall I show a warning message?
```
:type debug:
```
done for this file, but it should be done for all the lib
Do you get an enumerator if not passing a block?
@Evan-Pierce my 2 cents, I would append a commit to this PR that adds the shared context, and then append a third commit that refactors what you have into the shared context approach.
`puppet queue` is in master but is deprecated. Since I moved the require lines to `puppet.rb` they should already have been loaded.
I still need to check with Randall about how to proceed with restoring the documentation, if we should at all. The previous code is basically reminder documentation about settings that Puppet already has and that you could already pass to the Face.
Well, if ternary operator looks cryptic, there is no problem to change it, I'll update.

> should this just be LITTLE_ENDIAN since it was just defined?

It's complicated. The API off ffi assumes only that `BYTE_ORDER` constant will be equal to `LITTLE_ENDIAN` constant [or another one], without specifying a value of those constants.

In ffi, LITTLE_ENDIAN is an integer value ([look here](https://github.com/ffi/ffi/blob/master/ext/ffi_c/Platform.c#L104)) and can be changed. I had to assign some value and I chose `:little`, it could be anything actually.

In Rubinius, `Rubinius::ENDIAN` constant is assigned [here](https://github.com/rubinius/rubinius/blob/master/vm/ontology.cpp#L478). Therefore, `Rubinius::ENDIAN` has nothing to do with `FFI::Platform::LITTLE_ENDIAN`. I'd call it dangerous if we would rely on equality of these constants just because the same symbol is assigned to both of them in two completely different parts of codebase.

What do you think?
To be more precise, the line is to wait for the process to exit, but not to fail if either there never was a child process forked, or if the process has already been reaped by an earlier Process.wait.
Could you update the wording to something like:

it "parses a day name into a DateTime object"

We try to keep the wording as clear and explicit as possible and not use things like it "can" or it "should". This also applies for some of the other cases described here.
I'll just remove it for now - another PR for debug options will include that.
In fact, you can just "return false" here. Then there's no need for the no_errors local variable at all.
hm, this seems like it will fire two events – does it?
That looks great to me. :) Glad to be able to easily maintain from that $defaultHelperMapClasses array. 
@weierophinney this is what you had in mind, correct?
according to the Symfony2 CS, you should use strict comparisons
Should be `json_decode($data, true)`
Ah, kk :)
arf I confused project's convention
The `-march=native` was getting passed to `gfortran`, and causing it to throw up.  The specific errors are:

    k_standard.c:1: error: bad value (native) for -march= switch
    k_standard.c:1: error: bad value (native) for -mtune= switch

When compiling various parts of julia.  julia internally chooses to compile with gcc over clang, (and when I forced it to use clang, I ran into other problems) The compiler being used is still llvm-gcc 4.2, but the `ENV.gcc_4_2` gives the proper flags to pass to it.
@ja
Can we kill these commented lines?
only valid characters like explained here
http://stackoverflow.com/questions/70579/what-are-valid-values-for-the-id-attribute-in-html#answer-79022
will remain in the id
@harjis Eiks tää koko exceljuttu ois kannattanut integroida ostotilausrivien_hallinta.php koodiin? Eiks täs kuitenki laiteta exceliin ihan samat tiedot ku ruudullekin?
Tehty ja commitoitu.
Cramer use zmq for his backfiller scripts, this is need to build pyzmq
Can we name this `File.rm`. We want `File` to follow Unix naming convention (this is not documented, will do it soon), so I believe `File.rm` would be the best here.
There are several good reasons: 1. Any later change to any of the actions will potentially introduce side effects to the others. 2. It adds unnecessary complexity which makes the code hard to read. Since code is way more often read than written, it should be optimized for reading. For example, if you want to dig into it (e.g. for debugging), you need to search for the concrete place where the signal you are looking for is handled. If you have a dedicated slot for each signal you only find the code which you are looking for. 3. It makes code hard to test, because its hard to follow all possible code paths. 4. Errors in the dispatching code can easily lead to hardly debuggable errors (imagine there is one "if" instead of an "elseif"). There is no need to manually dispatch here anyway, because there already is a "dispatcher" in place (the SignalDispatcher), which encapsulates this concern in a central place and is dedicatedly tested for that purpose.
Nebolo by lepsie takto?
`test.avi 2012-01-12 2012-02-07`
Free this at the end.
Might be better to have this a little longer/clearer: "submit_SMS_form" ?
Also "Montreal" should be capitalized.
This looks like the only intentional change in this file. Could we remove the other items.
It is for the case that an update function isn't provided. That and I personally think passing in a copy of the entire track event is a waste so I would rather only give them the properties that actually changed.
Should be number here as well, input supports it as well https://developer.mozilla.org/en/HTML/Element/Input
You can probably blow all of this away:

              currentTime = seekTime = +val;

              seeking = true;
              media.dispatchEvent( "seeked" );
              media.dispatchEvent( "timeupdate" );
              vimeoObject.api_seekTo( currentTime );

and just call vimeo.api_seek( +val );

and remove the check in the vimeo seek event callback.
Is this a standard property?
"rather than as a local module"
Then the entire method could be:

```ruby
def dependent_destroy
  @dependent_destroy ||= (:destroy if options.delete(:dependent_destroy))
end
```

Unless I'm missing something about why you're using `defined?(@dependent_destroy)` (for example, a `false` value would trigger the `||=`)

Thanks
> it shows all related templates including template data, also the data of templates which are not selected. 
???  I only get the templates that were selected.
total nit and I should have fixed, but can do this:

`expect(options.data.cid).to.match(/^t/);`
Doesn't look like this case is detected in detectWeb, but I may be misreading it. I think all three of these cases and only these cases specifically should be picked up in detectWeb. On the other hand, if we let detectWeb be less stringent, the error reports may let us pick up more Primo variations.
I assume that you have thoroughly researched that modifying the exchange from some random other thread is okay, right?
Is there any reason why ```@platform``` should receive the options in a specification. The options are currently used to pass the deployment target, Which is a ```Gem::Version``` instead in a specification the deployment target is a ```Gem::Requirement```. This allows to specify deployment targets as:

```ruby
  s.platform = :ios, '>= 5.0'
  s.platform = :ios, '~> 5.0'
```

Or something like (for discontinued pods):

```ruby
  s.platform = :ios, ['>= 4.0', '< 6.0']
```

On the other using the ```Gem:Version``` would work assuming that the requirement is always ```>=```.
Can you explain what `nextSeed` is and how it relates to `problemNum`?
What purpose does this "name" field represent in a document? It is not used in any of the internal documents, since a node actually never knows its own name (rather, the parent's ChildReference holds the name of the child). I'm not sure we should advocate people setting that, as there'd be two places where the name is required while only one would be used.
"to to"

-like what?

"for for"
Mistake, will revert
I like that ! very usefull :)
not anymore, apparently :)
может мы будем использовать vector<int>
Well, that works just fine with four. Not sure what happened, but well, that works!
I forgot to do this before pushing the code. Easy fix.
Earlier test of sort issues. Can be nuked.
we use conditional debugging to switch it on while required (developing) but off by default (in production)

e.g.

  28 // Define this if you'd like to see debug messages from the switcher
  29 #ifdef DEBUG_SWITCHER
  30 #define SWITCHER_DEBUG(things) qDebug() << Q_FUNC_INFO << things
  31 #else
  32 #define SWITCHER_DEBUG(things)
  33 #endif

^ use a similar block to that at the top of the file, and then use SWITCHER_DEBUG instead of qDebug directly
[.NET]
A precondition would be good here.
Can the `getStorageBackend` function be executed inside of the `get` functionality? I see this coming back a lot throughout the PR
Ah, sure, I'll add that in.
This should be null instead of false
Simon has a good point. This should check whether or not the content has a reply. In case of no reply, the comment can be deleted. In case of a reply, it should be marked as deleted but shouldn't actually be deleted.
`ScalaJdiEventDispatcher` does make synchronous call to the actor, but only with messages of type `jdi.Event`.  ThreadSuspended is only used for the debug target to communicate with its actor.
Що ти маєш на увазі? Обмеження на довжину імені немає ж
Missing empty line between `@param` and `@return`.
Please view the following url.

https://github.com/EllisLab/CodeIgniter/pull/1720/files
This is simply not acceptable:

    php > echo date('H:i')."\n"; date_default_timezone_set('UTC'); echo date('H:i')."\n";
    22:22
    19:22
необходимо, чтобы метод mutate именно изменял эдементы, то есть мутация элемента на самого себя невозможна. представьте, что получилась днк, в которой все элементы одинаковы. маловероятно, но возможно. тогда метод mutate не будет заменять.
Чтобы не работать с NSString вы решили создать целый класс. Зачем?
ок, тогда такой вариант, который точно работает с 99го года:
int distance = 0;
for ( int index=0; index < [dna count]; index ++ ){
....
А от операционной системы это не зависит от того, что for конструкция пришла из C (в данном случае - С99), а Obj-C - это надмножество над С.
в десятку. спасибо!
Ну ничего страшного вобщем-то, особенно, если сделать замену, о которой написал чуть ниже (в строке 29 вместо "mutIndex = random() % 100" написать "mutIndex = random() % (100 - mutCounter)", если ДНК будет достаточно длинной, то придется пересмотреть метод поиска случайного места мутации в принципе, для ускорения. Если задавать размер ДНК отличным от 100, нужно будет многое поправить. Мне кажется, для этого задания будет излишним, хотя в реальности нужно конечно писать более универсально.
(Cell*) cell – ваш метод принимает указатель на объект класса (типа) Cell и называется эта переменная-указатель cell.
попахивает индуским кодом
плохой метод замены - получаеться что вы очень сильно привязаны к генератору случайных чисел - допустим он заглючит (маловероятно конечно но все же) тогда и ваша програма зациклиться
суть такова что нужно текущий символ вообще исключить из возможных случайных вариантов
ведь кто то может сделать и так
// file main.m
u_int32_t arc4random(void){
    return 0;
}
ваша праграма не должна быть зависима от реализации генератора случайных чисел
I think this return statement should be in the preceding "if" block. Otherwise, if invalid parameters are passed, the error will not be returned correctly.

Also, it would be good to add a comment that CloseLiveBrowser() will take care of calling the callback handler.
No longer shipped to client.
Since you originally opened the PR, Doctrine switched the MIT. Can you revise all of the LGPL license headers created in this PR?
empty space should be removed
Also, I'm not clear about when that could occur. Seems like the immediate and deferred schedulers will complete before hitting the `lock` message.
Eh, probably. That's cool :+1:
But again, it's not trying to execute. Those seem like different semantics, especially compared to `-tryLock`.
Thanks! I didn't know `msg.send` could take multiple string arguments. Good to know.
This needs to stay on the Thor namespace so it can be overridden in a Thorfile. Maybe pass it to the call to write_version?
Just in case if the user could do some thing that affect the decompressor after we added to the pool for reuse.
抛出异常整个eventbus就挂了。这里的做法其实是参考guava的: "Handlers should not, in general, throw.  If they do, the EventBus will
 * catch and log the exception.  This is rarely the right solution for error
 * handling and should not be relied upon; it is intended solely to help find
 * problems during development."
You're right! Those methods should be moved out of the `Blob` type.
Please fix the code style using JSLint
If ``ES_INDICES`` is ``{}``, then this line fails.
Would these be useful as macro defines?
Since MAC is such an awesomely reused term, maybe wrap with one in a :term: as well?
> My impression is that you don't need to add your bundle to the bundles configuration until you place a stylesheets or javascripts tag into a template that lives inside that bundle.

I strongly suspect that you are correct. It makes a lot more sense to me now. I’ll make some tests next week and rewrite accordingly.
The basic rule of thumb is: only `Future.apply` and `Future.get` ever block.  Watch out for those, and you'll be fine. (In a future API revision, I plan on making this obvious; blocking will only be available through an external object, `Awaitable`, so you'll have to call: `Awaitable.await(future)`—but I digress).

I would change the wording a bit: "This places the blocking operation in its own thread." to "This runs the blocking operation in its own thread pool, giving you a future for the completion (or failure) of that operation which you can compose with other futures".  Or something like that. You get the gist.
Return value is always an instance of `Request` no need for `void|`
I don't think you're supposed to handle `:allow_nil` and `:allow_blank` inside your own validator, the basic functionality of these default options [are already handled by the `EachValidator`](https://github.com/rails/rails/blob/master/activemodel/lib/active_model/validator.rb#L151).
Охуенная дока, все бы так писали, опенсорсу было бы получше. Я серьезно.
В смысле `.arg ("<em>" + QFileInfo (FilePath_).fileName () + "</em>")`
看起來像是給首頁用的......叫 `_root.css.scss` 好了
yeah, get_cache_request was nearly identical to execute_request, so I merged them into one.
any reason you def this as a constant when you only use it once?
Yeah, I guess you could say that. PyCharm has this excellent PyLint built in that shows red, yellow or green for files with errors, warnings or all-good. It was tremendously helpful in tracking down all of the issues. This marker tells it that the next line is incorrect for the virtualenv but not to worry about it.
unless...else is evil
Feature should be "Awesome Feature"
Isn't "ignore_if_database_cleaner_not_present" pretty clear already?
I suppose we can get rid of this todo :)
There are better ways to do this. We should separate the paste config from the other config options and load the config options before the paste app. It won't be too much work. 

Sent from my digital shackles. 

On Mar 30, 2012, at 6:58 PM, Tim Simpson<reply@reply.github.com> wrote:

>> @@ -60,6 +60,7 @@ if __name__ == '__main__':
>>     create_options(oparser)
>>     (options, args) = config.parse_options(oparser)
>>     try:
>> +        config.Config.load_paste_config('reddwarf', options, args)
> 
> I traced the code and load_paste_app wasn't reading the configuration file values by the time the start up code is run. So the conditional import code would not work, since at that moment CONFIG.instance was an empty dictionary.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/hub-cap/reddwarf_lite/pull/53/files#r629171
Changed. Sorry for the confusion.
This will just return the `coll` as is.
@galderz as requested by you, I've moved this stuff here. Subclasses must invoke super.validate()
I'm curious what would be the benefits? We felt that the extra performance we could gain is too tiny and we just add unnecessary clutter. Remember that this class is only serialized when a cache joins - not really a hotspot. It's internal members (especially Hash and ConsistentHashFactory) are not externalizable.  And they are stateless anyway, so writing an externalizer for them would be pretty odd :)
@vblagoje @danberindei Let's chat about this on IRC this afternoon.
Hahha, I did not know this. How should I write it, full blown if/else?
Nevermind, I see the commit message. Hmmm! Rails 4, good point. I am OK with this.
Very minor point, but I find this approach slightly easier to read:

```
'yellow' if contains else 'red'
```
You should send a PR from "pretty quickly made" work. You should contribute first to the first french fork... Which only 2 or 3 paragraphs are missing.
Do we want the y to always be 0???
It looks like this should be able to use the same utf8 function, if it checks for unicode in that function.
I'll merge it as it is - we'll move the lock warning higher when I revisit system warnings.
we should not do this here but only in the XPath QueryBaseCase, otherwise query tests break for all implementations that do not support xpath.
there is still a D_EUCLIDIAN here
Also, on the specific mixin name: Its misleading to call something an "edit button", implying a very generic component, but then limiting styles to "ss-uploadfield" etc within. Please prefix the name with ss-uploadfield.
Nicely done, thanks for the docs!
Any proposition what we want have under this routing.
. did you miss the part about this feature not working properly if this save is here. . . also nothing is broken as far as I can tell. If you look at the code btwn playground.rb & experiment/base.rb, ```save``` is being called on the experiment twice in a row:
(playground#load -> playground#experiments -> base#load -> base#define [save called here, then calls playground#experiments, which is now a _hash_, to store it] -> base#load returns experiment to the original call of playground#experiments where save would be called (but following this chain of events you can see that save has JUST been called])
Will def point out the concern w/ the pullreq to vanity though.
Where does it belong?
Do we still have a setting to turn off the draft stuff?
Perhaps this is a bit more readable as
`if split_min and split_max` 
However,
Is the expected behavior that if only one of `split_max` or `split_min` is defined, the command dictionary receives neither?
If it's feasible to have either or both defined, we could change this whole block to
```
cmd["min"] = config.get('split_min')
cmd["max"] = config.get('split_max')
```
Are you sure ``$this->normData`` has the correct type as ``*`` is not a sub-type of ``string``?