Community Edition 3.8.6 Release Candidate 1

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-7995 - Various minor valgrind-reported issues

Running valgrind on thorslave (while running the thor regression suite) reports
various uninitialized memory accesses.

This fixes the first batch of them.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #3482 from afishbeck/querymain_webserviceinfo

HPCC-7997 Fix retrieveWebServicesInfo support for QueryMainDefinition

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
HPCC-7996 Introduce memory manager spill threshold option

Add a thor option to allow the memory manager to be configured, so that it
can spill when it hits a certain threshold(%), default 80%.
The reasoning being, that if the memory manager waits until it is out of
memory before requesting memory to be freed, those requests can take some
time (e.g. sort+flush to disk), and cause all other small memory consumers
to block in the meantime.

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
HPCC-8001 Stop generating grouped hash aggregate activities

Hash aggregate activities should always currentlybe global or local.

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
Changes following review

1) Use elapsedCycles for efficiency (and static calc. of 1 sec in cycles)
2) Add memorySpillAt to thor.xsd
3) handle memorySpillAt of 0

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
Merge pull request #3484 from jakesmith/spillat

HPCC-7996 Introduce memory manager spill threshold option

Reviewed-By: Gavin Halliday <gavin.halliday@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
HPCC-8001 Modify example to ensure group aggregate not generated

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
Merge pull request #3485 from ghalliday/issue8001

HPCC-8001 Stop generating grouped hash aggregate activities

Reviewed-By: Renato Golin <rengolin@hpccsystems.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merge remote-tracking branch 'origin/candidate-3.8.x' into candidate-3.8.6

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Community Edition 3.8.6 Release Candidate 2

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge remote-tracking branch 'origin/candidate-3.8.x' into candidate-3.10.x

Conflicts:
	thorlcr/thorutil/thmem.cpp

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-8004 Wrong user descriptor when accessing Distributed Superfile

in dadfs.cpp, CDistributedFileDirectory::getFileDescriptor and
CDistributedFileDirectory::getFile both are passing NULL to the
constructor for CDistributedSuperFile. This action, which takes
place at the client, causes the default dali user (daliuser) to
be passed to ESP and eventually to dali.

Signed-off-by: William Whitehead <william.whitehead@lexisnexis.com>
HPCC-2942 Configmgr - Add custom attributes

- In XML View selecting opening the context menu will bring up a
  menu option to 'Add Attribute'
- A dialog asks user to enter attribute name
- Refresh will return focus to previous location

Signed-off-by: Gleb Aronsky <gleb.aronsky@lexisnexis.com>
HPCC-7884 Detect superfile error on reload subs

Fix errors in new superfile corruption test, leading to false positive
superfile corruption reports.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-7884 Detect superfile error on reload subs

Fix errors in new superfile corruption test, leading to false positive
superfile corruption reports. And actually remember to add them this
time.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-2942 Configmgr - Add custom attributes

- Changes based on feedback
  - Extra error check
  - Fix error message

Signed-off-by: Gleb Aronsky <gleb.aronsky@lexisnexis.com>
Merge remote-tracking branch 'upstream/candidate-3.8.6' into candidate-3.8.x

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-8011 xmlsize crash fix

The xmlsize utility was crashing due to a missing call to InitModuleObjects

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
Merge pull request #3487 from garonsky/issue-2942_Add_Functionality_to_add_custom_attribute

HPCC-2942 Configmgr - Add custom attributes

Reviewed-By: Kevin Wang <kevin.wang@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>