[EFL] Remove redundant entries on the Skipped list
https://bugs.webkit.org/show_bug.cgi?id=95458

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-08-30

* platform/efl/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Fix a crash in SourceBufferList.remove().
https://bugs.webkit.org/show_bug.cgi?id=94950

Patch by Aaron Colwell <acolwell@chromium.org> on 2012-08-30
Reviewed by Eric Carlson.

Source/WebCore:

Move SourceBuffer::clear() call before the removal of the SourceBuffer from
SourceBufferList::m_list to avoid a use after free if m_list holds the last
reference.

Test: http/tests/media/media-source/video-media-source-sourcebufferlist-crash.html

* Modules/mediasource/SourceBufferList.cpp:
(WebCore::SourceBufferList::remove):

LayoutTests:

Added a layout test to verify that the application doesn't crash if a SourceBufferList is
holding the only references for its SourceBuffer objects when a MediaSource transitions to "closed".

* http/tests/media/media-source/video-media-source-sourcebufferlist-crash-expected.txt: Added.
* http/tests/media/media-source/video-media-source-sourcebufferlist-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127153 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Clean up some webkit compositor unit tests
https://bugs.webkit.org/show_bug.cgi?id=95410

Patch by James Robinson <jamesr@chromium.org> on 2012-08-30
Reviewed by Adrienne Walker.

This adds includes that were implicitly being picked up, removes ones that weren't being used, removes
dead code, adds OVERRIDE on functions that OVERRIDE, and deinlines virtuals that the chromium clang style
plugin is unhappy about.

* tests/CCAnimationTestCommon.cpp:
(WebKitTests::FakeFloatAnimationCurve::duration):
(WebKitTests):
(WebKitTests::FakeFloatAnimationCurve::getValue):
(WebKitTests::FakeTransformTransition::duration):
(WebKitTests::FakeFloatTransition::duration):
(WebKitTests::FakeLayerAnimationControllerClient::id):
(WebKitTests::FakeLayerAnimationControllerClient::setOpacityFromAnimation):
(WebKitTests::FakeLayerAnimationControllerClient::opacity):
(WebKitTests::FakeLayerAnimationControllerClient::setTransformFromAnimation):
(WebKitTests::FakeLayerAnimationControllerClient::transform):
* tests/CCAnimationTestCommon.h:
(FakeFloatAnimationCurve):
(FakeTransformTransition):
(FakeFloatTransition):
(FakeLayerAnimationControllerClient):
* tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeLayerTextureUpdater::sampledTexelFormat):
(WebKitTests):
(WebKitTests::FakeTiledLayerWithScaledBounds::FakeTiledLayerWithScaledBounds):
(WebKitTests::FakeTiledLayerChromium::textureManager):
(WebKitTests::FakeTiledLayerChromium::textureUpdater):
(WebKitTests::FakeTiledLayerWithScaledBounds::contentBounds):
(WebKitTests::FakeTextureUploader::isBusy):
(WebKitTests::FakeTextureUploader::uploadTexture):
* tests/CCTiledLayerTestCommon.h:
(FakeLayerTextureUpdater):
(FakeTiledLayerChromium):
(FakeTiledLayerWithScaledBounds):
(FakeTextureUploader):
* tests/FakeWebCompositorOutputSurface.h:
* tests/TextureCopierTest.cpp:
(MockContext):
(TEST):
* tests/ThrottledTextureUploaderTest.cpp:
(WebKit::TEST):
* tests/WebLayerTreeViewTest.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Refactor WrapShape classes to BasicShape
https://bugs.webkit.org/show_bug.cgi?id=95461

Reviewed by Rob Buis.

This is a follow up patch of bug 95411. While the previous patch
just renamed the files, this patch renames the classes, enumerations
and functions.

Just refactoring of internal names. No new tests.

* css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):
* css/BasicShapeFunctions.h:
(WebCore):
* css/CSSBasicShapes.cpp:
(WebCore::CSSBasicShapeRectangle::cssText):
(WebCore::CSSBasicShapeCircle::cssText):
(WebCore::CSSBasicShapeEllipse::cssText):
(WebCore::CSSBasicShapePolygon::cssText):
* css/CSSBasicShapes.h:
(WebCore::CSSBasicShape::~CSSBasicShape):
(WebCore::CSSBasicShape::CSSBasicShape):
(WebCore::CSSBasicShapeRectangle::create):
(WebCore::CSSBasicShapeRectangle::type):
(WebCore::CSSBasicShapeRectangle::CSSBasicShapeRectangle):
(WebCore::CSSBasicShapeCircle::create):
(WebCore::CSSBasicShapeCircle::type):
(WebCore::CSSBasicShapeCircle::CSSBasicShapeCircle):
(WebCore::CSSBasicShapeEllipse::create):
(WebCore::CSSBasicShapeEllipse::type):
(WebCore::CSSBasicShapeEllipse::CSSBasicShapeEllipse):
(WebCore::CSSBasicShapePolygon::create):
(WebCore::CSSBasicShapePolygon::type):
(WebCore::CSSBasicShapePolygon::CSSBasicShapePolygon):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseBasicShapeRectangle):
(WebCore::CSSParser::parseBasicShapeCircle):
(WebCore::CSSParser::parseBasicShapeEllipse):
(WebCore::CSSParser::parseBasicShapePolygon):
(WebCore::CSSParser::parseBasicShape):
* css/CSSParser.h:
(WebCore):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::init):
* css/CSSPrimitiveValue.h:
(WebCore):
(WebCore::CSSPrimitiveValue::getShapeValue):
(CSSPrimitiveValue):
* css/StyleBuilder.cpp:
(WebCore):
(WebCore::ApplyPropertyWrapShape::setValue):
(WebCore::ApplyPropertyWrapShape::applyValue):
(WebCore::ApplyPropertyWrapShape::createHandler):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateWrapShapeInfoAfterStyleChange):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/WrapShapeInfo.cpp:
(WebCore::WrapShapeInfo::isWrapShapeInfoEnabledForRenderBlock):
(WebCore::WrapShapeInfo::computeShapeSize):
* rendering/style/BasicShapes.cpp:
(WebCore::BasicShape::destroy):
* rendering/style/BasicShapes.h:
(WebCore::BasicShape::BasicShape):
(WebCore::BasicShapeRectangle::create):
(WebCore::BasicShapeRectangle::BasicShapeRectangle):
(WebCore::BasicShapeCircle::create):
(WebCore::BasicShapeCircle::BasicShapeCircle):
(WebCore::BasicShapeEllipse::create):
(WebCore::BasicShapeEllipse::BasicShapeEllipse):
(WebCore::BasicShapePolygon::create):
(WebCore::BasicShapePolygon::BasicShapePolygon):
* rendering/style/RenderStyle.h:
* rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[chromium] Disable CCLayerTreeHostTestScrollMultipleRedraw.runMultiThread
https://bugs.webkit.org/show_bug.cgi?id=95472

Unreviewed gardening.

When landing r127079, this test was re-enabled, and has not passed since. I'm disabling it, and created bug 95473 to track fixing this issue.

* tests/CCLayerTreeHostTest.cpp:
(WebKitTests::TEST_F):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Make RenderBox::computeInlineDirectionMargins const
https://bugs.webkit.org/show_bug.cgi?id=95255

Reviewed by Ojan Vafai.

Source/WebCore:

This is part of making computeLogical{Height,Width} return computed values rather than
mutating the RenderBox directly. This makes a submethod const.

This change is just a refactor, but I've added some tests to cover code that wasn't
previously covered by layout tests.

Tests: fast/block/margins-perpendicular-containing-block.html
       fast/table/margins-flipped-text-direction.html
       fast/table/margins-perpendicular-containing-block.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion): Handle flipped text direction manually.
(WebCore::RenderBox::computeInlineDirectionMargins): Make const with out parameters.
No longer need to call setMargin{Start,End}ForChild.
(WebCore::shouldFlipBeforeAfterMargins): Helper function to figure out how to map a logical
writing mode direction to another logical writing mode direction.
(WebCore::RenderBox::computeLogicalHeight): Use const method. This also makes it more
obvious that when computing the height, we only modify the before/after margins.
* rendering/RenderBox.h:
(RenderBox): Make computeInlineDirectionMargins const with out parameters.
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth): Same as RenderBox::comptueLogicalWidthInregion.

LayoutTests:

Add test cases for setting margins with perpendicular blocks or flipped text.

* fast/block/margins-perpendicular-containing-block-expected.txt: Added.
* fast/block/margins-perpendicular-containing-block.html: Added.
* fast/table/margins-flipped-text-direction-expected.txt: Added.
* fast/table/margins-flipped-text-direction.html: Added.
* fast/table/margins-perpendicular-containing-block-expected.txt: Added.
* fast/table/margins-perpendicular-containing-block.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127157 268f45cc-cd09-0410-ab3c-d52691b4dbfc