labofsahil/github-event-dataset-2012 huggingface dataset:
Dave, I think your 'bigOmega' is identical to what I have above in lines 49 & 50 of this document, except yours always includes every term.
Let's continue to use Omega with capital 'O' for 'bigOmega' and omega with lower case 'o' for 'smallOmega' The only line here that's necessary is I believe line 60. I haven't made any changes though as I'm worried I might damage something! When you see this if you agree with me then please go ahead and remove lines 58 and 59 and change the 'bigOmega' variable to 'Omega'
After the constructor is done `_is_initialized` is true, and there is no other function, which modifies this attribute, but `setZero()`. Maybe splitting `setZero()` into constructor and `setZero()` is possible and would eliminate `_is_initialized`?
This Y.UA sniff was already there, and I'm not sure what the Chrome sniffing is for, tbh.
``bind(0, bind, null, 0`` is for binding bind_, no need for bind.call.

@davglass TC passed on my pc, sorry i do not know why it failed here.
This will verify `host.get('axis').x` and `host.get('axis').y` are both true.  If so, apply logic to modify host's current scroll properties, which it already did previous to this commit.
Is it more appropriate to start this at 0 instead of null? Or is null used explicitly to convey "has never scrolled" vs. "scrolled 0pxs"
Having this method on `Y.Base` may affect the ability to mix in `Y.BaseEvents` into a `Y.BaseCore` subclass at runtime.
Because I want it as username. It is the best way to do groupname unique and fast to get. We'll need it for all URLs involving groups, and get_group_by_groupname must be fast.
Does this want marking up as above (:py:class:`Arg` and :py:class:`DataCarrier` ?
If you use $app->registerHook then the hook handlers don't need to be static as that abstraction supports instance methods.

Not a biggie though.
Why not delegate to super.postStop?
creating untestable code usually also hints at some design flaw (just a general observation, have not thought about the specific case)
Add comment about that this is the place to add new replacements.
rename to getInstance, and ScalaDoc it as JavaAPI, you can reuse the same text.
Shouldn't we pull in the version from somewhere else instead of risking this diverging from what we actually use?
I'd consider:

 final def noMatch[T](): T = throw NoMatch

since that's on an object, it becomes a static method, which there is limited type inference for.
So in the Java code you can write:

} else { return noMatch(); }
in a finally block?
Yes, the word scheduler is bad. Will change to "the periodic message scheduling" or something of the sort.

Will add comment about that the interval might drift up to twice as long (you have to be really unlucky though, but there is a possibility) or shorter.
exactly, we haven't used FiniteDuration api consistently
anyway, the important review comment was that it shouldn't be a Long
I don't like this api.

(a) it's not obvious what perm means  (could be ckeck_perm or perm_granted.
(b) if we go with something like this, the best practice is to call it with the variable defined.  eg @account.email( perm_granted=true )
(c) however, if we want that, we may as well enforce it by taking a  hash. eg @account.email :perm_granted=>true

also, I havent figured out why this is necessary.  shouldn't this be the raw_content of this card??
tmp.vertices?
Sorry if you get two copies of this - I couldn't see the first version on the github interface, here's a second version.

I separated the one-line descrip and multiline epilog to make it clear that these had special meaning.  If it's all just ``__doc__`` then the person editing won't know without looking at the code that they should not add two lines of description at the top - for example.

Is there an advantage to ``__doc__`` other than being familiar?
``Fixed``
see the .. warning block right below here.
This is auto-generated by ant based on jni.version, and should only be changed in build.xml when the native API changes.
As far as I could tell the dts is only used for calculating state.time_offset, which it only does if it is a DVDSTREAM_TYPE_DVD (which I think is wrong as one needs the same adjustment for Blurays (?). In any case it is a diff with state.time which is now (would be) on "display time" not "read time" - but I wasn't sure which is why I left the original as a comment
Oh.. unused
I think for seasons you just use item.GetVideoInfoTag()->GetPath() anyway (which points to the show folder) ?
As we talked about: lets factor these giant inner functions out into an observer class, and differentiate the types of observers the simulator takes. Things to be weary of:

- giant functions-inside-functions
- 'unused variables' in function definitions
- repeating big chunks of code with one var changed
You should name variables for what they're used for, not the data-structure you intend to have them implement.

Imagine a world where every string is called "string_1"..
Is this really loud comment necessary?
Similar: this is used in the core app, specifically application.rb, and is needed during runtime.
See above, signature of DownloadCatalog
It seems that this class could be more like a TestSet.  Then you could add_test().  And then you could have a run_all() method rather than having to manually loop through all the tests in your main func.  Since the Summary class already concerns itself with managing a collection, why not just make it manage the testing of the collection too?
This name doesn't make sense to me. local to what?
A simple 3 line setter/getter to the internal `indicator.drawRect`.
There should be no space between the type and the protocol it conforms to. This isn't in the conventions, but I'll file an issue to have it added as I seem to recall this was preferred.
Possibly better to call `doesNotRecogniseSelector:`?
I fixed commit message and introduce `fputc` for `DisplayExceptionLine`.

There is some more places in node source with using `fprintf` to output single character. I think it is better to do a separate pull request, if you need it.
also this should limit to inputs/textareas with a placeholder and data-lu="Placeholder"
a bit confusing calling this variable "first" as you are walking the list backwards and it is one of many items.
TYPO: should be this "chapter"
Yes, it is. I was thinking about this one specially, because a lot of people do overwrite this one and register own `Latte\Engine` instance. Which might be a problem, and will create a BC.
In numpy versions <= 1.6.x unsafe casting was allowed for in-place operations...

It looks like assignments still work, I wonder if that is an error?

    In [1]: a = ones(3, int16)

    In [2]: a[...] = 1.2

    In [3]: a
    Out[3]: array([1, 1, 1], dtype=int16)
Whether the feed item should be added or not should be configurable, like the search and upload items.
тут тоже const не хватает
наверное, при решении конфликта. я сказал автоматически сгенерить новый файл, в котором присутствуют изменения от моего файла и нового. то есть: давно не обновлял версию. кто-то работал с линками, как и я. возник конфликт. с помощью тула гита я создал новый файл, где собрал изменения с обоих файлов.
уровни вложенности выделить пробелами
The tests should follow the same code style too. Also this test had one more `,` after the `word` block argument.
Can drop the `result` var here. Just `wrap_with_time_zone time.__send__(...)`
Why can't we do that? I'm aware that this needs to run migrations in order to allow the application to work, but it seems weird to block it.
Yeah, this would require a syntax change in ruby's parser/lexer. 
//cc @tenderlove

On Dec 21, 2012, at 6:43 PM, "bUg." <notifications@github.com> wrote:

> In activerecord/CHANGELOG.md:
> 
> > +    numrange, tsrange, tstzrange, daterange
> > +
> > +    Ranges can be created with inclusive and exclusive bounds.
> > +
> > +    Example:
> > +
> > +        create_table :Room do |t|
> > +          t.daterange :availability
> > +        end
> > +
> > +        Room.create(availability: (Date.today..Float::INFINITY))
> > +        Room.first.availability # => Wed, 19 Sep 2012..Infinity
> > +
> > +    One thing to note: Range class does not support exclusive lower
> > +    bound.
> > +
> Yes I think, It's better to do in ruby-core, but not sure if Matz will approve this :)
> 
> —
> Reply to this email directly or view it on GitHub.
>
I know other examples look like this one, but since there's just one migration, perhaps it'd be good to just check for `migrations[0]` and call it a day?
ah ok but my commit is fine or do I have to change something?
I think so. This means that if the user doesn't pass the attributes we still generate a secure controller since the parameters will not be permitted.
space after create-object
It's probably not that beneficial, but the caller method itself is unlikely to be inlined anyway. It's pretty big on it own.  I'll remove the annotation as i agree it's confusing. 

On 13 Jul 2012, at 15:22, Iulian Dragos<reply@reply.github.com> wrote:

>> -            val jumpToDefault: Tree =
>> -              if (!canJump || isDefault(CaseDef(commonPattern, EmptyTree, EmptyTree))) defaultBody
>> -              else Apply(Ident(defaultLabel), Nil)
>> -
>> -            val guardedBody = switchesOnSameConst.foldRight(jumpToDefault){
>> -              // the last case may be un-guarded (we know it's the last one since fold's accum == jumpToDefault)
>> -              // --> replace jumpToDefault by the un-guarded case's body
>> -              case (CaseDef(_, EmptyTree, b), `jumpToDefault`)  => b
>> -              case (CaseDef(_, g, b), els) if g != EmptyTree => If(g, b, els)
>> -              // error: the un-guarded case did not come last
>> -              case _ =>
>> -                return switchesOnSameConst
>> -            }
>> +      private def collapseGuardedCases(cases: List[CaseDef]): (List[CaseDef], Boolean) = {
>> +        // requires(same.forall(caseEquals(same.head)))
>> +        @inline def collapse(same: List[CaseDef], isDefault: Boolean): CaseDef = {
> 
> Is `@inline` really necessary? It's a pretty big method, so it may penalize callers who'd be less likely to be jit-compiled early on. 
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/scala/scala/pull/876/files#r1158633
It passes.

But instead, I included a test that is divorved from the standard library (ie, it doesn't depend on the signature of `Option#getOrElse`). It was more convenient to test for an error due to failure to eliminate a tail call than to check for successful tail call elimination.
Please leave out the ``ylim`` line, unless the appearance would be really poor otherwise. If you need it, it should be prefixed with ``plt.``.
Raise a warning here?
*PEP8 nitpicking* (http://www.python.org/dev/peps/pep-0008/#other-recommendations)
I disagree. It's not a full sentence. I believe that independent phrases should not have periods. Not a big deal either way though. If you want this let me know.
Well, I'm not sure what this function does, exactly. But I'll try that.
Right.  This has nothing to do with the order of the traversal.  It's because the traversal happens *only once*.  

I'm not opposed to putting some logic in expand() to intelligently call expand multiple times for various hints to make sure expressions are completely expanded.  But I am opposed to the hint methods trying to do this, because what it leads to is the mess we had before where expand was called far more times than it needed to be, and quite often, and infinite number of times.
If users mistakenly pass a tuple for the bodylist in place of a list then list(bodylist) will change it to a list. If they pass a list, then it won't matter,  Any other data type should bring the 'not isinstance' to the fore.
IMHO in this particular example decorator helps to reduce code length (instead of implementing `kwargs` check in every constructor).
In fact it prevents "silly" user mistakes with `unimodular` and `non-unimodular` parameter.
I think you missed this particular line.
No need to open a new pull request. Just push to the same branch.
perhaps default function parameters that can be null to null (such as customHost)
two indent?
Let's add `user = None` in `kotti.testing.DummyRequest` then.  (There's already a few Kotti-specific dummy attributes there.)
Pure string conditions are supported in active record and are vulnerable to SQL injection.  I think it's up to the developer to avoid SQL injection when they construct their query string.
необходимо добавить  экранирование
I think "エラーハンドリング" is more better as this page's title.
Dies kann kaum funktionieren (nicht getestet!)
Doch bei dieser Ziel-Url verlierst du den Context.... Sprich, du weisst nicht mehr auf welcher Gruppe du den GroupRequest stellst...
Die BrowserUrl hat vorhin etwa so ausgesehen: ecamp.dev/group/pbs/luzern/musegg/requestgroup
Die BrowserUrl für's speichern muss auch so aussehen: ecamp.dev/group/pbs/luzern/musegg/savegrouprequest

Es gibt dafür einen üblen Hack... du kannst die Action einfach nur auf "savegrouprequest" setzen. Dadurch wird nur das letzte Wort in der URL angepasst (als ob es sich dabei um eine HTML-Datei handeln würde)

Wie wir das handhaben möchten ist noch nicht so klar....
Having this check (for `"count"`) bothers me on some level, but I can't think of a big reason why it's actually a problem.
This needs to be initialized in the constructor to be threadsafe.
This option is not available anymore
Looks like it's only used to get a confidence interval, TwoSidedPvalue and
an NeutralValue.

On Fri, Apr 13, 2012 at 4:02 PM, Gert van Valkenhoef <
reply@reply.github.com
> wrote:

> >                               new
> BasicParameter(d_mockAnalysis.getTreatment(new DrugSet(base)),
> d_mockAnalysis.getTreatment(new DrugSet(subj))));
> > -             RelativeEffect<?> expected =
> NetworkRelativeEffect.buildOddsRatio(summary.getMean(),
> summary.getStandardDeviation());
> > +             RelativeEffect<?> expected =
> NetworkRelativeEffect.buildOddsRatio(summary);
>
> Which is correct depends on what getRelativeEffect() is used for, but I
> would prefer not to estimate a normal distribution based on the quantiles.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/gertvv/addis/pull/7/files#r681658
>
Bad things happen. I've added some validation in the follow-up REST API branch.
Me gusta refactoring! I made a monster with that method. :(

One nit: I'd name this function `_should_run_kumascript`, to imply the question rather than that it's actively running kumascript. But, that's just a semantic quibble.
No, the other way around. It's unclear whether relative or absolute URLs are allowed (or both). If you want to get away without using technical terms, you can probably use an example. See "Server settings" which heavily uses examples.
It is "should not" as it is ignored in browsers that follow the standards.


On 4 May 2012, at 08:24, Senky
<reply@reply.github.com>
wrote:

>> @@ -502,7 +532,7 @@
>>    <p>In SQL statements mixing single and double quotes is partly allowed (following the guidelines listed here about SQL formatting), else one should try to only use one method - mostly single quotes.</p>
>>
>>    <h4>Commas after every array element:</h4>
>> -    <p>If an array is defined with each element on its own line, you still have to modify the previous line to add a comma when appending a new element. PHP allows for trailing (useless) commas in array definitions. These should always be used so each element including the comma can be appended with a single line</p>
>> +    <p>If an array is defined with each element on its own line, you still have to modify the previous line to add a comma when appending a new element. PHP allows for trailing (useless) commas in array definitions. These should always be used so each element including the comma can be appended with a single line. In JavaScript, you should not use the trailing comma, as IE doesn't like it.</p>
>
> Isn't "should not" a suggestion, whereas "cannot" command? I agree using "should not" in coding standards suggestions, but in a matter of not working code we should really use "cannot"...
>
> IE error:
>> Expected identifier, string or number
>
> while the code was:
> ```
> var obj = {
>   a: 1,
>   b: 2,
> }
> ```
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/phpbb/phpbb3/pull/779/files#r772747
This is needed for the service container. Otherwise you'll get a fatal error.
We need to be able to do these three things:
1. Allow new sql cache drivers to be written that are _only_ sql cache drivers (they implement the sql interface)
2. Allow new sql cache drivers to be written that are both sql/normal cache drivers (they implement the sql/normal interface)
3. Allow the use of normal cache drivers as an sql cache backend through use of a generic sql driver

The only way I could see this being done with using YML to configure the services was to create one sql cache "container" and one "driver." The container always receives a driver (if it is the generic it receives the driver for the backend we want to use, if it's a new sql driver, it receives a plain null driver that should be ignored). I'd love to hear any idea as to how this could be done better.
or `=== null` it doesn't make any difference.
As far as I know, this should be disabled by default, especially if the key is not present.
`$disallowed` seems to be an array, so this might not work at all (also with sprintf).
What oleg said. This should not be a problem.
That's what I mentioned on the old PR
Surely this can be moved to css.
they got pulled in with the last merge from master
Its even compiling with glcorearb.h even when we use macro that is absent in those header, its mystery :) 
In this particular case I guess source + header are compiled as a solid unit or something.
The reason behind this is that I just copied the code from GMod lamp and pasted it in wire lamp because more lines have changed. I wasn't thinking about that we might want minimal diffs, but if we do, I will replace only those lines that are necessary next time :)
Why not impement the Zend\StdLib\Hydrator interface?
This now uses the view conventions to find the template, but attempts to also maintain the flexibility of using (or not) an extension in the include tag, which seems to be a common liquid convention.
rename '''x''' to something more helpful (e.g. numberOfLoadedStores)
Every drug will have a uuid, so I don't think of an example where it won't find it.
PEP8: Missing spaces within expression.
True, it might be obvious if the reader has both files open to the right locations, and is asking himself "are these two loops doing the same thing?"

I'm thinking about the reader who has opened this file and wants to know what's going on... arguably a more common scenario!

My tiny bit of python code has 3 lines of documentation explaining why it's happening and pointing to a discussion on theano-dev, do we really need to debate whether this big block of C code needs *any comment* whatsoever?
You can do isinstance(updates, theano.gof.python25.OrderedDict).

This should work on all python version
indices and data of the i-th column
device=self
Missing double colon.
Hm. I think it's more readable the current way, as the parsing is mainly
driven by the token kind...
Having the empty string as special value to short-cut seems strange here.


On Wed, Nov 14, 2012 at 1:48 PM, djasper <notifications@github.com> wrote:

> In lib/Format/ContinuationParser.cpp:
>
> >    } else {
> >      addContinuation();
> >      ++Cont.Level;
> >      parseStatement();
> >      --Cont.Level;
> >    }
> > -  if (FormatTok.Tok.getKind() == tok::raw_identifier) {
> > -    StringRef Data(Sources.getCharacterData(FormatTok.Tok.getLocation()),
> > -                   FormatTok.Tok.getLength());
> > -    if (Data == "else") {
> > -      nextToken();
> > +  if (FormatTok.Tok.getKind() == tok::raw_identifier &&
>
> With the comment below, this would be unnecessary..
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/djasper/clang/pull/5/files#r2130963>.
>
>
BrowserKit's client has a default user-agent that is added with the creation of the Guzzle Request, removing this line actually allows the user to overwrite the user-agent.
I have just added tests for parse_imt

2012/9/13 Lars Butler <notifications@github.com>

> In openquake/db/models.py:
>
> >
> >      class Meta:
> >          db_table = 'hzrdr\".\"hazard_map_data'
> >
> >
> > +def parse_imt(imt):
>
> Since this is a utility function, it would be very nice to see some unit
> tests specifically for this bit of code. At the moment, I don't see any.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gem/oq-engine/pull/874/files#r1598917>.
>
>
Just a link to this issue here
No, the "div" text is just a shim, it can be anything.  I use "X" to shave off the two characters.  It would ideally be something like "shim" if every byte of jquery didn't translate into petabytes of internet traffic.  Personally I found it more confusing as "div" than as "X".
This would introduce an error.
"kami" so cute :)
Ok. I'll set it to your original suggestion.
наверное лучше будет "по какому-нибудь критерию поиска" или "по какому-либо"
Using "," instead of / as the seperator for sed would produce better readable code
Maybe simply overriding `finished` would make a more simple example?
Could this be handled in the capability for the page instead of within the component itself. Components shouldn't have to have detailed knowledge of the environment they're in.
Comments must be in English.
Good catch... fixed.
It feels a little weird to me that the regular expression that parses 'color' into redStr/greenStr/blueStr lives elsewhere.  Perhaps we could at least add a note here saying 'color' is tightly coupled to the other three params?  (i.e. it's assumed that each of *Str originated from substrings of 'color')
Those seem to work pretty well. It doesn't feel *quite* as snappy it seems like, but they work. Thanks!
You need to change this to ``.last-color`` also.
Instead of ```Object.<...>``` I think you want ```{...}``` -- the former syntax is supposed to be for Objects that are used as a map.  Also, use "?" instead of "(optional)".  Also I think there's an extra ")" and "}" near the end of the line for "bindings."
Should remove or comment out
old way with 3 boolean active properties was very confusing
because there are three states 'running', 'stopped' and falsy
most external modules look for 'stopped' and some for not falsy
maybe just adding comment like this would be enough?
```js
/**
 * state of the debugged process
 *    null:  process doesn't exist 
 *    'stopped':  paused on breakpoint
 *    'running':  
*/
this.state = null
```
What's the intent of this? At first glance it seems like it could have the potential to generate invalid html. Also is it doing something that could be accomplished with cycle? https://docs.djangoproject.com/en/dev/ref/templates/builtins/?from=olddocs#cycle
in this case it's more like when i feel i'm not doing something the right way or there could be some utility function to handle it -- in this case reconstructing the report url with all parameters. when it gets cleaned up the no-longer-needed import won't still be hanging around.
should this at least be consistent with 'unknowndomain' above?
Heuh, no, it always holds the same amount in total...
Every opcode has a base cost, but IF* opcodes add an extra cycle in the case that the test fails. From the spec:

    * IFE, IFN, IFG, IFB take 2 cycles, plus the cost of a and b, plus 1 if the test fails
I did and forgot, sorry.
Same reasoning as below
I don't think you need this property, or the `text-align` one. `white-space: nowrap` seems to have been the key.
This is a button too!
@ben if you can think of a better name let me know
Would be nice with a comment here describing what the adapter does, what the annotaitonTypeType means and so on.
- unused?
remove all these files: `/app/caches/*`
https://www.google.cz/search?q=katello%20support&hl=cs&lr=
does not give me relevant page in first 10 results
oh yeah, good catch.
Not sure if addColumn vs add_column will be a problem here
Since 'cloned_in_environments' could be a list of environments, recommend comma-separating the env names.
Good catch.  A little bit of copy/paste here.  Will update these as well as check the file they were copied from.
There is an issue here: this will never be reached as a fatal error will already be thrown by the mock class definition. You would need to move MockRavenClient to a separate file
Add the 3rd parameter, `StringComparer.OrdinalIgnoreCase`
Use literal `46` here.
filter 是怎么处理对象的？ 好神奇，全都tostring了吗？
没看到你提交query filter部分的改动？
This will need to lock the appropriate wallet (if any), not pwalletMain.
Could be, but it's also client-specific. How about "Open the debug log file from the current data directory. This can take a few seconds for large log files."
"freeware" generally means no rights except redistribution, which is *less* free than GPL...
Also don't know how this happened.
Should this be added? It will make config adapters that used to work in 2.2 no longer work in 2.3.
It should be `@requires`
It's already used now by AddDownloadHeader.
OK given that the reference is made in a comment.
we could, but then we would need to instantiate all types which could be a performance bottleneck. i think the way we do it now is not too bad - we could easily cache this map in the driver.

btw, we would never ask for sioc:Post but "http://rdfs.org/sioc/ns#Post" - we should not use short names here as we lack the context of the namespace mapping.
Apachehc already depends on commons codec, though explicit dep should be
removed.  Not sure why gcs does, but that also should be removed.
On Oct 31, 2012 7:15 AM, "David Ribeiro Alves" <notifications@github.com>
wrote:

> In
> labs/oauth/src/main/java/org/jclouds/oauth/v2/json/JWTTokenRequestFormat.java:
>
> > +
> > +   private final Function<byte[], byte[]> signer;
> > +   private final Json json;
> > +
> > +   @Inject
> > +   public JWTTokenRequestFormat(Function<byte[], byte[]> signer, Json json) {
> > +      this.signer = signer;
> > +      this.json = json;
> > +   }
> > +
> > +   @Override
> > +   public <R extends HttpRequest> R formatRequest(R httpRequest, TokenRequest tokenRequest) {
> > +      HttpRequest.Builder builder = httpRequest.toBuilder();
> > +
> > +      // transform to json and encode in base 64
> > +      // use commons-codec base 64 which properly encodes urls (jclouds's Base64 does not)
>
> right. I will review this with a bit more attention.
> The reason I've used commons-codec though is that it was already used in
> other jclouds projects (gcs and apache hc), it was the actual lib used by
> the google client to base64 stuff in a way that just worked (jclouds base64
> produces wrong results even without url encoding) and I didn't have the
> time to dig any further. Will take the time now to look into other
> alternatives.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/920/files#r1992432>.
>
>
By removing getAdditionalTargetCss it will break BlackBoard integration.
Also where do you set the width/height for the iframe?
What is this for? Do you often need to override the linker flags?

Also, the variable with the linker flags would traditionally be called `LDFLAGS`.
I thought in this case, we save 'bug_118' into module registry, and not save duplicated module 'bugs/bug_118'. So when it tries to require 'bugs/bug_118', it has exception of 'module not found'.
This function is no longer used, remove it.
For the record, you only need a trailing comma if the tuple has only one element. It's actually the comma that defines the tuple--not the parentheses. e.g. These are tuples:

```
(1,)
(1, 2, 3)
1,
1, 2, 3
```

And this is not a tuple:

```
(1)
```

Python treats `(1)` as just `1`.
Much!
Cool. I'll rip the link out once this is merged in.
这个是git的常识吧。`git submodule init` `git submodule update`
Oh, people actually set such values? Ok
When changing tables that possibly are already in the database (in the case of updating an installation) it is good practise to create a migration for that change. ;)
Any reason these constants aren't prefixed with "k"? And wouldn't an enum be fine here too?
It is kind of a cleanup, when I copied that code over from gates I forgot to remove the liquids
Why would you continue the validation when it's already been invalidated?
This needs to be fixed against Symfony2 CS.
REPLACE INTO should be avoided, but on SQLite its still better than anything else for UPSERT
for MySQL INSERT .. ON DUPLICATE KEY UPDATE is the way to go.

option 1) and 2) are problematic because it can trigger all sorts of ugly side effects if one causes such error conditions. i guess if users use a separate connection to the database for their session handler and the rest of the code, those side effects should not be a big issue, but then it could also lead to other issue with the RDBMS f.e. running out of connections.
It is not.. why should it be?
it says in the documentation that the fact that closures are implemented as a class are an implementation detail that should not be relied upon. given the addition of the callable type hint in 5.4 there is even indication that if they ever do refactor closures, that this could change.
@everzet until we change the way it works for all components, yes
missing ``public`` keyword for all methods
This implementation is totally wrong. The string format for a plural message can be more complex than just `foo|bar`, you can have ranges, several plurals, ...

That's also why we have what we have right now. If you want to use translation, you need the translation component.
.
@certik ok, I'll get back these changes, but even so, I think this code should be reorganized.
1. 

> from urllib import urlencode

Should be removed with pastehtml functionality, because not used.
2. For me, mess "from" and "import" in one code block is ugly
3. "os", "time", "sys", "re", "subprocess" could be written in one "import" line, that will improve readability
Sure thing.

I kind of just want it to be documented somewhere so that it's googleable.  It's a tough one to figure out if your upgrading.
Not sure if it's any easier than using Sinatra, but there's an app bundled with rack that serves static assets from a root: http://rack.rubyforge.org/doc/classes/Rack/File.html
I change it from export2OFF and export2OBJ, and add the operator >> for exporting by default in OFF.
Since it is more complicated to specify the choice between OFF and OBJ I let the previous >> string but I update the doc.
Add references to Soille's book and Najman's one
FIxed !! Tell me when it is ok so I can rebase everything in a single commit !
Is it not possible to get the code building cleanly without these flags? I think many were coming from boost, but now that you added SYSTEM they should be silenced.
Nope. I could resize the figure and it is no longer sensible...
Yes, but it's a useful stand-alone function too.
I'll move it in but it would probably be better in a *util* module instead.
Sorry for not having much of substance to add, but with this one, i think you've completed of possible indentations and spacing for if statements in a single file ;-)
in this context, these functions are not available, and need to be copied here.
Really?  The try-catch doesn't prevent the crash?
I think given the context that "close" is no longer called, this comment could be a little clearer. :)
No, but I may have to check which alarm item is needed to refresh.
I wonder this translates surrogate characters transparently to JavaScript string?
Where are b2g-scripts?
Shame on me!!!
ok perfect but I have an obsession writing 'ret' as name of variable to return :) but i can change :)
why DOM events are not handled my handleEvent?
Bitwise operators are discouraged on JavaScript because the values are converted to integer first, then modified, and then converted back again. May be some of the lack of performance is here. I don't know but we could check this.
Please add this entity to settings.en-US.properties.
remove this from here
Definitely don't want that. Kudu is an Outercurve project, so no ties to MS Open Tech.
Can be a function also. I did a lambda for a reason. Cannot remember why now. May have changed as this changed.
created automatically already when installing empty qt.conf
**

あとこんな訳になるのかなと思った

各ステップの実行と各ノードへのコマンドディスパッチの順序をコントロールします。
↓
実行順序のオーダーとノードへのコマンドディスパッチをコントロールします:
`track_highscores` contain the complete highscores for every track the user played. So I do have to filter the users entry :-)
I think this line should say
```python
if dist == (0, 3) or dist == (3, 0):
```
Because right now you're checking the same condition twice.
Honestly, the presentation class doesn't need testing because we're setting public class attributes and referencing them directly. The test_presentation module was made for the proof of concept to help visualize errors, failures and scope inside unittest. I'd vote to remove this module completely. Your thoughts?
I agree I think it should not include sub directories when specifying a directory.

I think the tool should also be improved to be non-interactive so the user can pass all the parameters in 1 line, this why someone can write a script using this tool as well as making a GUI frontend for this tool would be useful too. I had asked Mitchell to create bug #249 for this improvement.
Take out this empty line and make sure all the `=` are lined up.
That's a problem, I couldn't quite solve. Since Smart Search works with access levels, messages in categories which don't use the joomla access level system are assigned the acces level 0. See getAccessLevel() in Line 505. 

I haven't investigated yet, if there are other ways to set access control in Smart Search than access levels
I think this is just leftover javadocs that need changing, rather than code... Hope I'm not wrong at least ;-)
I said the guest agent name is some kind of constant, which chance do you think we would change it?

Even we set guest guest agent in every test case, the guest agent name should be also 'org.qemu.guest_agent.0'. So I don't get your point, what kind of problem would we meet?

But, this value can be moved into virt_agent module so that we don't need to write it down when create GuestAgent.
Agree, should remove useless white-space from default parameters according to PEP8, thanks. 
In addition, should use pylint wrapper to check it in autotest, but I remember it didn't work for me
ago,  will double check codes error and code style. thanks.
What is this? The point of loading content instead of url is that content contains the injected plugins. Won't this not do that?
If you are passing an option multiple times to get multiple tags, it would make more sense if it was `--tag`.
wait, how was this not ignored?
I think I'm going to change this to not add \n ever... otherwise I have to reformat all the unit tests :S
Perhaps a better fix to satisfy the LLVM SA would be: to not initialize (as before -- a possible speed-up), but also chain the if statements into if else clauses so that the Static Analyzer can see the values will be set.  最好的问候。
I use a lot of these.  Not sure if we want to add them but can't hurt
lhs OR and AND can now be annotated
usart_baudrate() isn't used anywhere in the code. So we should think about removing it.
I vote for http://m.guardian.co.uk/top-stories  (but leave core-navigation in the ajaxy endpoints, I think it is good to namespace them)
Need to fix the wiki ;)
Thanks for the suggestion, and the offer. I think I understand what you mean. I'll update the pull request shortly after testing it.
See https://bugzilla.mozilla.org/show_bug.cgi?id=800643
You need to use versioncmp with this. Probably better to just create SemVer objects.
Is it still worth retaining the abstraction, if we only have one implementation?  I can accept yes as an answer, but it feels like we could simplify that for now...
This should delegate to the newly created method, to avoid duplicating all those lines of code.
Yep, tested the carousel with pills and it works perfectly. Nice work mikaelbr!
The prior behavior should match how this library works with a real cassandra cluster. Does it not?
Yeah, I will move it.
Shouldn't this hint at a boolean?
Not my tabs! Will check parent class - might have come it originally.
Yeah ... better with assertions. It's ok with new commit, sorry
Some docblocks are still missing in this class
I kept it because I will add some methods to change the settings
I was thinking about this. What do you think a good way to make something optional would be? Ask if they've set it up already?
*sigh* My emacs seems to have replaced my spacing indent (4 steps more than before because I wrapped the <li>:s inside a <% e.begin_block("editbarMenuLeft"); %> <% e.end_block(); %>) with TABS!!!
Looks rather weird, <?=$variable; ?>
I would either go with a space before and after, or no spaces at all? :(
@zml2008 
We can't format that message :P or can we?
nice, somehow I was not aware of this for years.
Will do (also, going to close this pull request as this code isn't quite ready anyways). Not sure about moving it to util.py, though. It's not a generally applicable utility; it's just a class that HTMLReader uses to pick apart the HTML (as oppposed to the regex that's there currently).
Since the dictionaries are always the same it might look better to define variables:
```python
trees = {'name': 'trees', 'sql': tree_query}
plots = {'name'; 'plots', 'sql': plot_query }
```
That way these lines like a bit less intimidating:
```python
return ogr_conversion('ESRI Shapefile', [trees, plots])
```
don’t capture data that is not actually used
@piotras because @dbu already fixed it after merging
You mean it should look like this?

```python
        samples = (('/test/test.html', '..'),
                      ('/test/test/test.html', '../..'),
                      ('/test.html', '.')),
                      ('test.html', '.'))
```
I like that format is configurable...nice.
`.result()` is probably a stupid method. It doesn't actually take a callback, it just provides a very reduced "view" of the badge object depending on its state, which only makes sense in some sort of final state. I decided to make it throw so that it would fail loudly if used incorrectly, but I should probably just get rid of it and be more explicit in the client code about what portions of the full object I'm actually looking for where `.result()` is used.
I don't feel good about making this part of Popcorn's public API.
sure it does... 

`matches = document.querySelector( entity );`
it's probably not a good idea to have the `target` variable switching from referencing a DOM element to a string. better to cache the id in a new variable.
It seems like there are other places outside of the ready event where top level state will be useful. Scrolling in the error handler for example.
It would be insightful for me to hear the arguments for defining the class inline as I would have chosen to make another file (I like small files). It would be also helpful to hear if you have any other stylistic critic/observation to point out, even nitpicks :-).
We should return `true` if run_setup passes, and `false, error` if it fails to make it consistent with pcalls (which this is basically a fancy wrapper for). I like that you're returning a test status table.
We cannot handle the performance hit from this unused call. ;)
The references to $lib/layout and $lib.onyx are not necessary, and there's apparently a blank line before the closing brace.
Adjust default footer height if the "Selected Items:" text has been hidden (e.g. Grid is not in multi-select mode)
"lower" than what? did you mean "low"?
How can I define a constant in a Module? It does not work that way and I have no idea why?
Nope, its not just you... fixed.
Yes, but...

That would require `middleman-more` to use Rack, which is lame.

And Bundler + our extension system will autoload `sprockets` and `more` if they are in the bundle.
See https://github.com/eLBati/poweremail/commit/b419f7a4cf4878f35ff6b753ef336ab8925f47ba
`@isNull err`
Ya, this is a client variable for the JS side. These convention inconsistencies will have to be somewhere  (either JS or python). Is this ok?
This throws an exception if the content is not valid. We should catch that exception and respond with `callback(err)`
Yeah not sure what happened here.
Dropped it like it's hot.
This trait needs a ``scalaProject``, and it's used only by ``ScalaProject`` (as far as I can tell), so why not having a ``self: ScalaProject``?

This way you can avoid the ``scalaProject``, ``javaProject`` and ``underlying`` members. WDYT?
http://stackoverflow.com/questions/5962514/how-to-assert-mock-objects-function-invocations-object-arguments ?
A constructor is not public when it is only accessible from a static function in order to impose a proper singleton pattern. CodeIgniter::instance instantiates the object one time upon first call, and simply returns the object reference on all subsequent calls. As part of the class, instance() has access to the constructor, whereas public access is not desired in this scenario. Yes, it does work. Does it need more detailed commenting?

I'll add the ```@return```, but it always seemed pointless to mark a return on a constructor. Do we have a statement about this in the style guide? Maybe someone should add one.
You could safely do ++ inside the `substr_replace()` above. :)
This procedure is lacking details on how to manage each case where things may go wrong: Technique version changed on both sides, etc... This should drill down on a Technique/version level, rather than stay at a high level where we just sync the "whole library".
FreeBSD's make has -C so make is not required.
one other sort-of-nit-pick thing.  We have been conforming to a strict max 80 column width.  Would you be able to format the lines such that it conforms to that?  This especially helps so you can display two pages side-by side and see everything.
test_solve
yay testing
Not quite. We want it to escape any autorelease pools since the user has no visibility into when the subscribable was released if it was released in this runloop.
Compatibility is maintained because JDatabase::insertObject sets the KEY using insertid. Therefore, those calls were redundant.
Tror ikke du trenger denne, `resources` lager ikke en `:subcategories`-action. Det holder at du definerer `get` under.
no, let's keep it.
Are there cases when
 - The `referenceName` is empty and `msg`  is not? What should we do with the message?
 - The `referenceName` is not empty and `msg`  is empty? Should we add anything to `pushStatusUpdates`?
 - Both the `referenceName` and `msg` are empty? Should we add anything to `pushStatusUpdates`?
someone suggested me yesterday to do :

event_ids = {'AudL': 1, 'AudR': 2, 'VisL': 3, 'VisR': 4, 'Aud':[1, 2], 'Vis':[3, 4]}

what would think of that?
This list will potentially be large.  But even with a normal hierarchy of 5-10, this will make the results look terrible.  How about putting the "hit" first, then the first 2-3 with a ... and a mouseover of the entire list?
This sound strange too. I suggest to you: "Now that Propel knows about your database, Symfony2 can create the database for you"
不是默认，是一定含有这个类型
配置开启该模块处理当前路径
Fixed in commit 866eba5
fixed.  There is now an AMQPActor that accepts a ConnectionRequest message.
then it should be removed
nice.  updated.
I don't know of any efforts to maintain compatibility with epydoc directly.
same question about what you are looking for here. Also, note that you already caught a positive Integer above so your test for this line need only be `if n.is_Rational` since Integer is a subset of Rational.
No es un hash del attachment, es un hash del estado de la configuración del
sistema en cuanto a extracción de contenido de los attachments.

On Mon, Mar 12, 2012 at 10:52 AM, Alpha <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,15 @@
> > +﻿using System;
> > +using System.Collections.Generic;
> > +using System.Linq;
> > +using System.Text;
> > +
> > +namespace CommonJobs.Domain
> > +{
> > +    public class Attachment
> > +    {
> > +        public string Id { get; set; }
> > +        public string ContentType { get; set; }
> > +        public string ContentExtractorConfigurationHash { get; set; }
>
> Habría alguna objeción con llamarlo simplemente "Hash"? O representa algo
> más que eso que no logro ver?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/CommonJobs/CommonJobs/pull/30/files#r545671
>
```tagObj``` will never be ```None```. ```get_or_insert``` either retrieves the existing object in the DB, or creates a new object (and ```obj.put()```'s it) with the provided ```tag=tagStr``` argument upon creation.
This pulls in a lot of extra deps.  I am not sure what it needs to do that can't be done with the normal selenium API?

Or maybe there is javascript data that we can get directly as JSON?
Yep, http://www.python.org/dev/peps/pep-0328/
Would be great to have some controller specs for this as well.
In Cocoa a view which is being edited is [considered "in use" and not reused](http://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/TableView/ViewBasedTables/ViewBasedTables.html#//apple_ref/doc/uid/10000026i-CH15-DontLinkElementID_5), presumably so that editing doesn't need to end just because it's out of view:

> The view cells that are currently visibile are considered ‘in use’ as is the currently selected cell (even if it currently isn’t visible) as is a cell that has editing in progress, for example a text field being edited.
Whoops didn't know
This can be a default, but we can extract a dynamic user either by looking at specific files on the filesystem that we expect to be owned by the libvirt user, or looking at /etc/libvirt/qemu.conf and extracting the 'user' variable.
Let's add a TODO here so that we can think about handling the cases where it's in the Reddwarf db but not in nova. If ours is valid data, then the users might atleast want to see an error or something for that instance.
Unless someone asks us make sure 5.0 can cluster (momentarily) with 5.2. I don't think it's in the cards, but AFAIK, the discussions have not yet been finalised. Keeping the ids empty makes it easier to deal with potential issues down the line.
Hmmm, if we go for a single temp cache shared by all tasks, do you still need this? The document still does not explain why you need an id in the first place. IOW, why do you need to identify the task uniquely concurrently at runtime? I guess maybe to name the task cache?
> If you look at the current ActivationInterceptor, it there's a remove() called, it removes from the store and updates the 
> activation counter.

Isn't that incorrect?  Logically, a remove is *not* an activation event, if you define activation as the process of moving something from a cache store into memory.  I think we should fix the test (which seems incorrect) as well.
MetadataValue shouldn't contain the key.
See #263 for the related bugfix (I added this test before merging the PR)
I don't really get what's the point, by default ENTRY_ICON_PRIMARY is highlighted,
anyway, the code seems to work.
same thing is returned :)
Small cleanup - I'd just clean this up now before merging
Looks like a loading transition. I did a little digging but didn't come up with anything yet. Perhaps a Gaia dev would be able to help here?
In other places, you write one-line if statements as `if (condition) return ...;`. Keep it consistent.
Out of curiosity, could you actually verify that ` translate3d(0,0,0)` actually turns on hardware acceleration and does make pan faster? I thought that `translate3d(0,0,0)` turning on GPU-based rendering was a WebKit thing.
Did you want to put your name on the Copyright? :)
I'm gonna need help with this one
This isn't the best way to do a filter -- you should filter in the cascalog query itself, then use `c/limit` to take a single thing for each grouping.
You could probably memoize this
```ruby
@size ||= body.size
```
Looks like I commented out code and forgot to remove.
please put a /**, otherwise doxygen produces a modular interface warning