Merge esmtp-hostname-error-4796 

Author: tpratt, exarkun
Reviewer: jesstess
Fixes: #4796

Check for `twistd mail`'s `--hostname` option whenever the `--esmtp` option has
been given and emit a useful error message if the former is not found, as the latter
requires it.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32438 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge listopenfds-resource-fallback-5052

Author: soyt, exarkun
Reviewer: glyph, jesstess
Fixes: #5052

Change the logic which selects an implementation of the list-open-file-descriptors
to allow the resource module to suggest an upper bound on platforms which have
a non-working "/dev/fd".

In particular, this improves behavior on OpenBSD.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32440 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge not-modified-not-content-type-4156

Author: exarkun
Reviewer: mbp, jesstess
Fixes: #4156

Change `twisted.web.server.Request` to not set a default Content-Type header in
the response when the response code is NOT MODIFIED.  Previously the always-set
text/html default might have been incorrect and confused the client (possibly a
cache).


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32443 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge deprecate-google-5209

Author: retenodus
Reviewer: thijs, exarkun
Fixes: #5209

Deprecate all of `twisted.web.google`.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32449 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge cooperator-cleanup-5223

Author: itamar
Reviewer: exarkun
Fixes: #5223

In `twisted.internet.task.Cooperator`, cancel the pending scheduling call
as soon as the last task is stopped.  This makes a `Cooperator` more
reactor/testing friendly, by leaving no remaining event sources once it
has no more work to do.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32450 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge non-global-publisher-err-3307

Author: zseil
Reviewer: exarkun
Fixes: #3307

When an observer on `LogPublisher` raises an exception, broadcast that
exception event to the `LogPublisher`'s own observers, instead of to
the global `LogPublisher` instances observers.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32453 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge aybabtu-warnings-5193

Author: dustin
Reviewer: exarkun
Fixes: #5193

Remove the use of the deprecated `twisted.python.reflect.allYourBase` from
`twisted.persisted.styles`.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32461 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge agent-redirect-5157

Author: therve
Reviewer: exarkun
Fixes: #5157

Add a new twisted.web.client.RedirectAgent for redirect support the HTTP 1.1
client stack. The branch also makes the response available in ResponseFailed
errors.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32466 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge zi264-5215 

Author: exarkun
Reviewer: therve
Fixes: #5215

Change the `twisted.python.components` unit tests to avoid mutating the global
adapter registry and to avoid using nested class definitions as adapters and
interfaces.  Aside from generally being nicer by improving isolation and
repeatability, this lets the unit tests work with zope.interface 2.6.4 which
changes some of the hashing behavior of interface objects.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32468 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge conch-publickey-bool-5241

Author: toidinamai
Reviewer: exarkun
Fixes: #5241

Change the Conch userauth client to send \x01 instead of \xff when it is constructing
"publickey" messages.  This improves RFC compliance by following the definition of
the boolean type more closely.  It also fixes an interoperability issue between
Conch and Apache SSHD.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32472 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
A slight distortion, but essentially accurate.

git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32473 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge required-ifaces-skip-msg-5217

Author: exarkun
Reviewer: mwh
Fixes: #5217

Improve the skip message for `ReactorBuilder`-based tests when the reactor is missing
a required interface for a particular test.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32480 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge osx-skip-poll-5218

Author: exarkun
Reviewer: jesstess
Fixes: #5218

Avoid trying to run the poll and epoll `ReactorBuilder`-style tests on OS X,
where they will never work because those APIs are not available on OS X.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32481 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge recvline-fnkeys-5246

Author: djfroofy
Reviewer: exarkun
Fixes: #5246

Handle non-string keystrokes in `twisted.conch.recvline.RecvLine.keystrokeReceived` so that
they do not cause a exception to be raised when they are received.  This makes things like
F1-F12 and PGUP and PGDN not lead to a `RecvLine` being disconnected.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32505 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge amp-docs-3476 

Author: exarkun
Reviewer: jesstess
Fixes: #3476

Add a howto covering some of the basics of AMP.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32511 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge ephemeral-getstate-pypy-5254

Author: fijal
Reviewer: exarkun
Fixes: #5254

On PyPy, skip logging the referrers to a `twisted.persisted.styles.Ephemeral`
instance when it is serialized, because `gc.get_referrers` is prohibitively
expensive on PyPy, because `Ephemeral` is not widely used anymore anyway, and
because the extra information isn't likely to be critically important
anyway.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32519 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge sftp-listing-eof-3009

Author: mt, jcollie
Reviewer: exarkun
Fixes: #3009

Change `twisted.conch.ssh.filetransfer` to handle short `STATUS` packets,
rather than raising an unhandled exception while trying to parse them.  This
improves interoperability with other SFTP implementations which may leave the
message and/or language values out of the packet.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32523 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Apply stdize-tests-5256.patch to bring recvline tests up to modern coding standard.

Author: djfroofy
Reviewer: exarkun
Fixes: #5256

Update the test method names for tests covering `twisted.conch.recvline`,
as well as giving them docstrings describing the functionality they cover.


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32524 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge pydoctor-errors-5244: Fixed incorrect epytext markup in docstrings.

Author: magmatt, thijs
Reviewer: exarkun
Fixes: #5244


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32527 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb
Merge tls-api-links-5243: Fixed incorrect epytext markup in docstrings.

Author: magmatt, thijs
Reviewer: exarkun
Fixes: #5243


git-svn-id: svn://svn.twistedmatrix.com/svn/Twisted/trunk@32529 bbbe8e31-12d6-0310-92fd-ac37d47ddeeb