labofsahil/github-event-dataset-2012 huggingface dataset:
I am not sure about this one but getResult() should give a collection, so regardless the actual value, this:
(bool) $comments_enabled
... will be always true.

Please check it out and fix if that's the case by using getSingularScalarResult() instead
Був раніше некоректний код?
Чи він просто саме цього разу змінився?
`$test = $this;`
Are you sure ``$mockResult`` has the correct type as ``object<PHPUnit_Framework_MockObject_MockObject>`` is not a sub-type of ``object<Iterator>|object<IteratorAggregate>``?
Are you sure the class "Zend\Feed\Reader\Feed\AbstractFeed" actually exists, or did you maybe forget to add a USE statement?
@chip We do - baycoruby@gmail.com.  

@denniskeefe We were just discussing initializers at lunch today :) I encountered a situation recently using Devise on a project where we already had a "from" email established in our Settings.  So Settings.email_from was used app wide & we only wanted to change it in one place.  

To get around having to change it in Settings AND Devise I changed the Devise initializer to:  
   config.mailer_sender = Proc.new { Settings.email_from} .  
This is exactly what we were talking about regarding making decisions that make more efficient code.  Now we only have to change Settings.

Not relevant for our project right now but since we just talked about it today I wanted to share.
IS_IPHONE/IS_IPAD
was ist dasd für ein List Type? Würde da auch wieder LinkedList bevorzugen.
It won't ever hit this return false line since a fallback will just drop to returning the string below
Fjern `notice()`
I think you probably didn't want to publish this. If I understand correctly, someone could use this key to publish a fake version of your plugin. You should probably generate a new key before you push your plugin to Chrome.
Why not returning $this for chaining ?
Even further:

``` js
{
  '@px': 'left,top,bottom,right,width,height,letterSpacing,lineHeight,...',
  '@': 'zIndex',
  ...
}

And just have the initializer code once.
```
Could you add that `humanEvalTaskType` is the name of the evaluation, and that you're using it as the unique identifier?

(Though again, as mentioned above, I don't really like using the name as the uid.)
Am I missing something, or there should be "su -c 'yum insdtall #{names.join(' ')}'"
We said that you will be sending only changes? But you can send everything, just not as JSON.
So there should not be any output here. If there is any output, you should put if around. If there is none, then it is good.
`self.is_open == true`? Why not just `self.is_open`?
I think I said that you should not do it like that.
*Povezani uporabniki*?
No need for `_COMPILE` suffix.
You should check if horoscope data is too old (more than one day)?
да, про нее.
Shouldn't this be `cls` rather than `__class__`?
Why not test that /tmp/timberwolf is deleted? Because the path is generated with a random UID
It looks like you can merge those ifs:

```haskell
if v == 1 || hadDouble 
    then eof
    else do ...
```
Good catch.

On Sun, Oct 14, 2012 at 12:32 PM, Moxie Marlinspike <
notifications@github.com> wrote:

> In src/org/thoughtcrime/redphone/RedPhoneService.java:
>
> > @@ -142,9 +144,15 @@ private void initializeAudio() {
> >      AudioManager am = (AudioManager) getSystemService(AUDIO_SERVICE);
> >
> >      if (ApplicationPreferencesActivity.getAudioModeIncall(this))
>
> Maybe add an open brace? A whole try block under an un-braced if condition
> is slightly confusing.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WhisperSystems/RedPhone/pull/17/files#r1837728>.
>
>
Are you sure this library works, I know their tar library failed horrible with extraction. Can it archive long filename (100 char+) and localized characters?
Hmm, I think you're right. Maybe I should make this dynamic and just use an id?
PIL is also required.
This commit got in by mistake. we will revisiting this how jar class-loader issue for 3.0.2. The related fix in 3.0.1 is not complete.
Indeed, it is a bugfix. AICmdDock process spawns child processes AICmdFlyTo. They sometimes return AIERROR_GRAV_TOO_HIGH when the ship doesn't have big enough thrust. This error was, however, not captured by the parent AICmdDock, which continued spawning more AICmdFlyTo children. As a result, autopilot sometimes managed to land even with the errors, and somerimes it got totally crazy. After the bugfix, autopilot ends when child AICmdFlyTo returns the error.
Ok. I'll merge as-is (mostly because the Mission side of this is fine and we really need the bugfix), and create a todo issue to make a mission registry.
This won't entirely work. I think this will work in puppet 3, but there hiera-puppet is bundled anyway and this code isn't used there. Older versions of puppet will return `:undefined` (and possibly `:undef`, I think) instead of `nil`.
configureSession() is called everytime settings are saved. With your patch (and the setting enabled), a random port will be selected every time you save the settings. This is not what we want: this should happen only once. Therefore, we probably need on boolean property in this class to know if we were using a random port or not.
I'm pretty sure that if we're going to do this, we don't need to override this method at all.

I did a bit of testing to confirm and `[super canBecomeKeyWindow]` was always `YES`.
Nah, like you said you probably added it because it wasn't happening.
We agree. I started to have a look at the "large sample" implementation today and I think one limitations of the actual code is that the data on which LTS is applied are only referenced as self.endog/exog, which makes difficult to reuse the already existing "fit_*" methods.
I propose to continue my investigations if you are ok with me doing so.
а, ух ты. ок
You should indent the whole block from here four spaces to the right, no?
All strings should be [translatable](https://docs.djangoproject.com/en/dev/topics/i18n/internationalization/). Those dots are probably for required fields? This should be done through form template or CSS, not hardcoded in the label. (You can see if form field is required and not and based on that append or format with CSS the field.)
I'm wondering if we want to choose a different syntax. '[' require shell escaping or quoting in many cases. We could use a space or ':'  or we could merge the type with acl so it would be: knife node acl show OBJECT
On Jul 4, 2012, at 12:10 PM, Mike Jarvis wrote:

>> @@ -488,6 +493,13 @@
>> 
>>     /**
>>      * @brief The Lanczos interpolation filter, nominally sinc(x)*sinc(x/n), truncated at +-n.
>> +     *
>> +     * The Lanczos filter is an approximation to the band-limiting sinc filter.  Order n Lanczos has
>> +     * a range of +/- n pixels.  It typically is a good compromise between kernel size and accuracy.
>> +     *
>> +     * Note that pure Lanczos, when interpolating a set of constant-valued samples, does not return
>> +     * this constant.  Setting fluxConserve in the constructor tweaks the function so that it
>> +     * conserves value of constant (DC) input data.
>>      */
> 
> This is only approximately true.  I spoke to Gary about it, and apparently he added the first order correction to get the right flux, which he says is accurate to about 1.e-5.  I pointed this out in #208, which isn't merged yet.  So you don't need to add it here.  I just figured I'd point it out.

I just noticed this in 208 when I looked at it a little while ago.  Good point, thanks for adding that.
Was this an error in the original docstring, or are we moving to a new definition of the gain?
s/cane/can/
yeah, much better without parameterizing to OS.

BTW, what how does one install ffmpeg on mac?  Perhaps you might consider writing up a line somewhere?
I'm not really sure having this class is the best way to go. Would welcome some suggestions about how to refactor this.
Can use `Arrays.toString(keys)` instead of creating the list. But this is fine - don't bother changing.
I like using parenthesis to disambiguate between potentially different meanings. I think this would be best as
`sign = scroll_momentum/(Math.abs scroll_momentum)`
bien sur que tout n'est pas moisi, mais je ne parle que des majors. Je pourrais remplacer industries par majors d'ailleurs
Remove the `.id` due to the reasons mentioned above.
Ideas welcome here.
This can also be removed, identical to parent
good point. I brain-o'ed on that one I think.
having a separate method AND defining a special exception class is a verbose way of doing this and breaks with the code conventions already present - i would just have a single line

    raise RuntimeError, "You must set DataMiner.unit_converter to one of [:alchemist, :conversions] if you wish to convert units"
I am referring to files inside `src/test/php/net/xp_lang/tests/integration/src`. These are not test XP-Classes `**/*.class.php`, but merely resources used during tests. The `${xp.compile.testPhpIncludePattern}` is telling xp-maven-plugin to copy all files inside `src/test/php` to `target/test-classes`.

Please note that, by default, Maven copies all contents of `src/main/resources` to `target/classes` and from `src/test/resources` to `target/test-classes`.
I can see that LineFormatter use a "normalize" function.

Maybe, create a new formatter like "NormalizerFormatter" could be a good thing ? But, It could be redundancy to LineFormatter expect it return an Array instead of a Single Line.
Creating a new array.
the for loop and the close ought to be part of the previous try block.  The 'close' would be in a 'finally' clause.  I'm not going to r- this code just for this, however.
do you really need to use an attribute storing this array ? It won't be used elsewhere than in the constructor so you could pass it as an argument to the method call instead of storing it
this makes me feel like we could use some sort of reflection here.
> I agree, my question was about the "DriverInterface". One question though, could you eplain: "there are cases where there will be an object and it will still be a miss" ?

On object can be present and stale, at which point it would be considered a miss even though it still exists. If you let the higher level caching layer that the drives feed into make the decisions about what to do with stale data (reuse it, discard it, etc) then you have a very powerful tool. Stash has [some examples](http://code.google.com/p/stash/wiki/Usage#Invalidation_Methods) of this.


> You assume that the TTL is global for all the items here, right ? If this is the case we might be able to retrieve it from a different place. I am not saying that always returning an object is a bad, just trying to understand.

To be clear, the TTL I'm referring to is the remaining TTL for that specific object. If the start TTL was 180 seconds, but only 20 seconds remain to expire, then it would be very useful to know that. Additionally it may be useful to know that it expired 120 minutes ago- using a datetime (or timestamp) internally for that expire date is important.
lol, yea, you're right I just went along with what was there, i'll fix
The directory doesn't match this namespace.
We'll see what PT thinks, but I'd prefer to lose it if it is unused.  That way anyone using it will think carefully about the implications.
Надо. Я вот и спрашиваю - зачем?
Попробуй избавиться от strAnalyse
We will need to be able to open some notifications, before closing for example. For the debugger, we also need to show a message if an exisiting debugging is open.
It does not do more now though.
Any thoughts on making this a class method like:

    Parts::Part.file?(value)

Then the line looks like:

    if file?(value)

Swap `file?` out with a better name if you so desire.
Hmm, this could have surprising results for users if they only specify an absolute threshold that's less than the relative threshold.

Maybe you could set a default of `threshold_abs=None`, and then use the relative threshold only if `threshold_abs` is None. (You'd need to add a docstring comment to `threshold_rel` like "Only used if `threshold_abs` is None".)

On the other hand, you may want to allow users to blindly specify both and have the function decide the best threshold. In that case, you may want to set a default of `threshold_rel=None` and use the default relative threshold of 0.5 only if both are None. (You'd need to add a docstring comment to `threshold_rel` like "If `threshold_abs` and `threshold_rel` are None, a default relative threshold of 0.5 is used".)

Personally, I think the first option is more intuitive.
I don't see the fit_path parameter documented here.
Ok that's also done. And I think @GaelVaroquaux would like to have another look before we merge it. But he should be busy for the next couple of days...
ok. Especially if there is no test I would still explicitly write copy=True for the function call in case the default behavior of the function changes
Yes, that´s what I was asking for. But it only seems to work if I put  ```dog = dogs.first``` there as well so I don´t get a undefined variable for dog and also change ```dogs.sort``` to ```dogs.sort_by``` because otherwise I get a "multiple values for a block parameter (2 for 1)" warning. Anyway I  check out your other comments now.
Good advice on the list comprehensions, I'll update for that thanks. So this being it's own function is vestigial from my initial stab at this involving multiprocessing; I do plan on possibly rolling that back in if it's worth it (still need to test). Thoughts on if that is even worth it and design on having a separate tallying function?

I'm kind of banking on even a slight improvement may be worth it given how long it takes to pull the associated apid/device token/user_ids with even a modest number of identifiers (20k+).
Yes, good catch. Thanks!  (The original implemention was float-only, I templatized it during the port and missed this spot.)
As with the node pattern, I don't think we should have a default value here. For KKB, it would generate around 200K useless aliases for users whose profile are not linked to anywhere and never viewed.
Yes, it is my mistake. Please merge #878 additionally.
(minor) The convention followed through most of dmd is to use `char *` instead of `char* `, and prototypes usually have parameter names.
This doesn't seem to get deleted. Also, should only create if `tcpServer_ == NULL`
Is that something, that could happen? I don't think it could be string.
It will be replaced with
    @signature.cancel
Yes.
See in http://docs.jboss.org/hibernate/search/4.2/reference/en-US/html_single/
Search for "Tip" , you'll find several examples of a nice highlighted box with a specific icon.
Yes its meant to be and it can be overridden by adding "&serverIP=x.y.y.x" to the URL.  

It only comes into play when opening the htm file directly in a web browser (not from ESP), i have called it "developerMode" as the only time you do this, is when you are developing the web pages.
The change of the licence text will be done globally - still awaiting guidance on the timing of that.
No, I think the URI tests inside remotetests.cpp should do the ifdef, not here.
Are you sure that the 'cluster' in ecl-package _is_ a target cluster? I'm not...
Roxie does not have instances but the directory attribute is based on the name, so when the name is changed, it needs to be updated.
Wording is maybe a tiny bit strong here. "This is commonly set to be the name of the current application, and isn't modified for different instances of metlog within the scope of the same application."
I didn't want to have the inner class access the outer class's instance var. Maybe there's a better way I don't know.
This'll break backwards compatibility with Rails 3.1.
This will swallow potentially valid errors. What's the `rescue` for here?
At this point I had to go look to see what 'more advanced' could possibly mean. This could possibly be called 'Configurable Password?' In the future, we might just consider making simple_password the version of generate without any options.
Ah, ok, it just looked real. :-)
Agree wtih you. But earlier I had some regressions and performance issues when i manipulated arguments in $callback.  I just refined a little and incorporated ur suggestions. please have a look at this.
"Input is the type of the current exception cause." which describes the Input which should belong to param part of javadoc.
CloudMineObject no longer exists so that value is not used
Hi Riq,
I notice some differences of the implementations in CCParticleFireworks(or other classes in CCParticleExamples) between cocos2d-iphone and cocos2d-x.
In initWithTotalParticles function, cocos2d-x and cocos2d-html5 will not set a default texture( fire.png ) to particle system.
The reason is that we don't want to bring resources to engine.
So if not invoking setTexture after cc.ParticleXXX.create(), app will crash at ccGLBindTexture2D( m_pTexture->getName() )  since m_pTexture is NULL.
Actually, it's either null from the database or already set as some non-parseable integer value from the column that it was derived from in the database. So if it does fail on the first parseInt, the field is not touched.
I think we should wait until the UX design specifies a way to delete customized data, and then add the dao and service layer support for it. I don't want to write backend support for features we don't have yet.
Use double quotes here, remove the spaces, capitalise and add a full stop. I appreciate the whole file needs doing.
How about moving the nil check here with something like
```RELEASE = ENV["RELEASE"] ||= "1"```
when clauses should indent to the same level as the associated case
Yes, I ran it--I think it illustrates the code better than the patch + average display from before.
This was to ensure that we get a 2-D array out.
I really don't care. The decision is up to you.
can you explain when this will be used? alias route to a Page to have different routes for different languages for the same Page?
Are those JMS bundles really necessary? Is it not possible to handle the roles just with symfony core?
I know, but I find implicit returns ugly if they are not in very short functions and "easy to pronounce". Do you insist on removing the return keyword here?
What if position, direction, up, or right changed but the transform didn't? The world coordinates would not be updated in the current reference frame. Most of the time `transformChanged` is false, but we would need to execute 3 branches to check if the properties changed anyway.
I'm wondering if I should move the parameter to the end or keep it as the second. Having to specify the PixelFormat and border width can be annoying. A way to remedy this would be to use an object literal as you suggested below.
That is what I though.  It's OK like this.
I know this is in CHANGES.md, but multiple people have asked for WMS.  It might be worth a quick followup to your [post](https://groups.google.com/forum/#!topic/cesium-dev/Rcx11y4TA_g) or a new post to let folks know when it is in master.

Did we update the Imagery Sandcastle example with a WMS button?

Given this, how much work is involved to implement WMS-C?  CC @tfili
Create the atlas with a 1x1 texture with the new initial width and height arguments.
Is possible to return throw LoggerMessages.MESSAGES....instead of null?
This is a dictionary with nv pairs. Could we redefine this as a custom type and add the details there?
Fixed. Please check you are happy with the wording now, though.
If m doesn't exist, then undefined is returned. In the next if statement, dn.indexOf is referenced without a check for dn being undefined. So either m will never be undefined, and the m && is superfluous, or dn needs to be checked for existence in the later if statement
Android and iOS did not have the "property" property associated with "change" event before. Why do you add this property here?
I don't see the fix. You still have toggle button in parenthesis after center and checkbox in parenthesis after left...these need to be marked as android only.
There is also a numerical constant Ti.UI.TEXT_ALIGNMENT_blah that can be passed that has an integer value that will fail here.
Going forward, we shouldn't imply that you need to wrap everything in a class. Consider moving away from classes in the future unless you really need them.
Always forget about Strings class. Hopefully that gets refactored and hangs off of String at some point.
lol nice - @ugisozols is right this syntax just won't work. try `{'1' => 'href'}`
Maybe I should just write it 

```scala
if(value == null || value.trim.isEmpty) None
else Some(value.trim)
```
Comment on a separate line please.
The examples make it pretty clear range is not required here.
LGTM
The ˋULˋ is a trick to force promotion to ulong, in case of overflow, before doing the division. Then the cast is to downcast back to size_t. I should have definitly commented it, and used a clearer upcast, too. Sorry about that.

Come to think about it, the upcast would probably be too late here anyways... I'll just change it to a straight up:

ˋcast(ulong)_source.length + ...ˋ
What exactly do you mean by that? I am testing both static and non-static visitors?
Please note that this is actually an implementation of a `FactoryBean`, not a `BeanFactory`.

So please rename the class to `JacksonObjectMapperFactoryBean`.

The same applies to the corresponding test class.
You might want to move this up and append it to the end of line 32 so it reads:
- MyExceptionCountHandler - Only counts the the number of times MyException is thrown. This handler is also used as a Named CDI bean
Just wanted to make sure that we can only do that. For future, if it will be possible to use eg. smooks for transformations, you could transform any kind of object.
this assumes GL_TEXTURE_2D no? It also assumes a POT texture
shouldn't we check target to see if its arb and then if arb assign w and h - if 2D calculate the t and u 

I did this in the old PR ( see deleted lines above 459-471 )
SQLite doesn't need any preparation on this point. That is handled by the connection handler *(IIRC)*

Sent from my iPod

On May 3, 2012, at 4:54 PM, "Michael C."<reply@reply.github.com> wrote:

>> @@ -15,12 +14,10 @@ matrix:
>>       env: DB=sqlite
>> 
>> before_script:
>> -  - sh -c "if [ '$DB' = 'pgsql' ]; then psql -c 'DROP DATABASE IF EXISTS phpbbblog_tests;' -U postgres; fi"
>> -  - sh -c "if [ '$DB' = 'pgsql' ]; then psql -c 'create database phpbbblog_tests;' -U postgres; fi"
>> -  - sh -c "if [ '$DB' = 'mysql' ]; then mysql -e 'create database IF NOT EXISTS phpbbblog_tests;'; fi"
> 
> What about sqlite?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/phpBB-Blog/phpBB-Blog-for-3.1/pull/66/files#r768399
Professor, não entendi! Era pra corrigir os testes??????????????


Em 16 de abril de 2012 17:42, rodrigovilar <
reply@reply.github.com
> escreveu:

> > +
> > +import grails.test.mixin.*
> > +import grails.test.mixin.support.*
> > +import org.junit.*
> > +
> > +
> > +@TestFor(Periodo)
> > +@Mock(Curso)
> > +
> > +class PeriodoTests {
> > +
> > +    void testValidacaoPeriodo() {
> > +             Periodo numeroInvalido = new Periodo()
> > +             assert !numeroInvalido.validate()
> > +
> > +             Periodo periodoSemCurso = new Periodo()
>
> Então, você deveria ter corrigido o código e não afrouxado o teste.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rodrigovilar/AlocadorHorarios/pull/32/files#r691269
>



-- 
[]´s
Sérgio Campos
Graduando Sistemas de Informação - UFPB_LN
Last item should not have `,`
``fos_rest.request.param_converter.request_content_param_converter`` seems a bit redundant

why not just ``fos_rest.request.param_converter``
Should we only look for people who have the CD4 fall by a significant amount, e.g. sixMonthsAgo - latest > 10? (This is a question for George.)
http://knockoutjs.com/documentation/dependentObservables.html
Sounds good to me.  I actually waffled about this when I did it.  I'll take some of those out.
$qb = $this->creatQueryBuilder("o");
$qb->where("o.user_id = '" . $user->getId() . "'")
       ->andwhere('o.state != ' . Order::STATE_CLOSED);
Totally agree. Thank you.
Hm, not sure what went wrong here. All of these comments are pointing to the same line. I'll work through this block of code and see what I can find back.
This shouldn't use the `"shortdesc"` identifier (already used above).  It would make sense to have a short description that was useful for the [examples page](http://openlayers.org/dev/examples/).
Casting it to void* first makes it a unsafe cast, which will not invoke the regular D cast. This is safe because I alerady know it is a TypeInfo_Const and it is faster.
Is it possible that tempWbufsize is very large? That could break the program on 32 bit.
Don't we want to include all names?
> package-protected 

But it isn't...
The same question as above
Sure, we can add the setter, but it would be just as simple or even simpler for someone who needs custom poll* method to extend JdbcMessageStore and override the entire method. The fact that they could still do it makes me wonder if its really necessary? 
Anyway, we can discuss it next week since that would really be a new feature and probably deserves its own JIRA anyway so if this is the only comment and you agree with my assessment then merge it.
I need to think about this, but I need to get ready for my webinar. The bottom line, is I am concerned that during initialization we are rescheduling messages and we need to be sure that the iteration doesn't pick up one of the rescheduled messages in error.
I'm not sure it makes sense to tell folks to add a test. In a TDD environment this makes perfect sense, but as most of our contributors will be *only* adding and/or changing tests, it might be confusing.  Perhaps replace that line with:

3. Make your changes to the code (e.g., add or fix a test).
I see why you used this technique, but it is safer to use UserService.getUser(Integer.parseInt(suser))
I understand the aim of this method but in this line you've juste take the opposite value so why use the ternary operator ?
You can compare element.Name.LocalName to avoid worry about the namespace.  In fact, it seems pretty user-unfriendly that the user apparently needs to tell you what namespace their KML document uses.  Is that because there are multiple valid KML namespaces?
@fabienrohrer 
This one too seems to have been added to the firmware.
But I am not sure it is really useful ?
Oh yeah, it was a stick in my craw while I was working on this so I turned it off. It'll be useful running it day to day so I should probably switch it back.
how come u didnt add a report/report.log in the projects gitignore? was this just so the empty folder would be in the repo?
I would order them in different way: first `tastypie` (external library), then `tastypie_mongoengine` (current library), then `test_app` (our project).
Cierto, ahi lo arregle.
your are right - I changed it.
Why do we need this general methods? (for shared shared scripts)
Guess you committed this file by mistake. Please remove it from the PR
> Yep, I copied the code from shufflesplit before you fixed the issue...

That the error: if you had created an AbstractBaseMetaShuffleSplit class
and sublassed both objects from it we wouldn't have this error
propagating.
And we could add a quick type check to make it not violate the LSP :)
Yes, thats true, calcdeps is deprecated, but there are problem with closurebuilder, it requires from user to create own namespace and not gonna work without it (your example for this project not gonna work with closurebuilder). It might be not clear for end user who not so familar with closure details, and even for advanced closure users. You see, I left closurebuilder code in comments, coz I've started with it.

Moreover, I've changed regexp in calcdeps a bit to handle files like *.js.erb
So I think its not a good idea to give a user option to point on py script.
Ah, interesting - didn't catch that.
Can you convert this to use the language file? Juuust in cause people see this value.

I would say the name should be "Parent ID". This will be used a ton in other languages and they always appreciate my lang() happiness!
This is a Proxy representation of the Android Intent type:
http://developer.android.com/reference/android/content/Intent.html
This comment indicates there should be an accompanying `TODO` for switching our modal model to the presentation model. We will be grepping the source for `TODO` at some point and actually doing them.
Yes, foreach over all types your functions should work with is nice idiom for testing.
Here I know in advance that regex engine is templated on unqualed character type (stripped of any immutability) and not a string.
Though other mutability levels are interesting to test that interface functions accept them.
Also added this check, since client secret is not used except in the IP bypass scenario.
I guess I am fine with that.
Add some commenting around this to explain what you're doing here
Let's try to mock process.exit() and see if it is called