labofsahil/github-event-dataset-2012 huggingface dataset:
Eh fair enough, I guess if one doesn't want to be bothered --non-interactive is there.
same thing as the other one. Clicking an element has no guarantee on any driver that the page will be fully loaded.
you want to enter "and other authors" right?
Backbone用にjQuery、Zepto、Enderのいずれかが$変数を所有する。
What it is with indentation?
Be careful with such supposition. Cuz we always have to keep in mind that each constant of this class __have to__ mean level
Too laconic message. You should at least specify the cause of the faillure.
Troublesome, not the test, but the toGeographic method and its javadoc. WGS84 may mean both lon/lat and lat/lon depending on the context and who's reading, it should be quite clear that we mean lon/lat.
I'm also not sure if this makes the method usable in general, I mean, Geotools by default functions in lat/lon mode, will these methods make any sense and be of any use for programs that do not force lon/lat orientation?
@wiibaa - this patch implementation is fine, no need to change it.
Hmm perhaps doing nothing is fine, and there is no need to throw an error.  The content worker is effectively dead while frozen, and alive again when unfrozen.  Instead of throwing error messages while frozen
@lloyd, @callahad, @ozten - before this is merged, I am still concerned about this line.
and is that necessary? No easy workarounds?
this is now built into validate.js
we don't need the extra variable here. Just add the check directly to the if condition.
I don't think this will be very common.
add a space between j and ++ :)
at least a class that extends `LogicException`, like `InvalidCriteriaException` or something
I think this group is actually covered by tests starting at L109, but I'm not one to complain when people write _extra_ tests.
not unlink? I vaguely remember you telling me that was better here
如果可以，尽量减小作用域范围
All these extra cases here for 1 to 10 don't really add any value. Having 2 or maybe 3 cases is more than enough
What happens if you have both files?
To make a setting required, make it abstract instead:
`var workPoolSize: Int`
oh no it's not a string so this isn't necessary
use the same regexp than Uri `'/:[\d]{1,5}$/'`
Why do you use the FQDN of the exception here, instead of just Exception\InvalidArgumentException? Same for all other occurences.
`if (isset($this->attributes['step']) && 'any' !== $this->attributes['step']) {`

I just noticed the "any" value in the spec:
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#attr-input-step
And basically, yes :)

Assuming the `ServiceManager` doesn't have any instances (absurd) for example for `Configuration`, then you shouldn't be able to retrieve (and `canCreateServiceWithName` should reflect that) anything that depends on `Configuration` :)
`nuofo` -> `nuovo`
I wonder if this can be cached when the scrubber is first created - will this really be changing?
Another benefit of this over the slider is that you can drag multiple times without having to reselect the number - so you can just let go then drag again if you need to change it more or adjust more finely.

For the first problem, switching it to be 2.0 instead of 10.0 should be good enough, but I'll play around with the numbers when I get back to this.

For the second problem - agreed - I don't think 1e-6 granularity is going to be useful very often
No you're right Jamie, the second comparaison will always be true, strange that I didn't noticed anything when debugging. The code needs modifications for SFML 2, I'll correct that as well.
ah yes, I forget the markdown case. Is there an equivalent "Summary:" for mkd ? We can remove the ":" in the comment.
no `angular`, just `forEach`
Is this file needed? Try not to repeat documentation information over multiple files, that just makes it harder to update.

I would also remove the same information from the README.md file, having a doc/LICENSE file should cover the needs here.
please use camelCased names for variables
do we have an emacs c-mode description around ? :-D
It might be a good idea to create local references of all your lookup arrays, as it is faster to access the index of an array and not a field additionally.
Ok, i just removed the normally then, otherwise people would believe they have super fast machines! :P
Yowch! That's amazing.


On Sat, Dec 15, 2012 at 7:17 PM, Dan Allen <notifications@github.com> wrote:

> In lib/asciidoctor/block.rb:
>
> > @@ -128,48 +149,30 @@ def splain(parent_level = 0)
> >    # * super/sub script
> >    def content
> >
> > -    Asciidoctor.debug "For the record, buffer is:"
>
> Just to give you an idea of how much it slows it down, it goes from 5
> seconds to .2 seconds on my machine :)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/erebor/asciidoctor/pull/13/files#r2429304>.
>
>
Not really. Couple of days ago, tehkonst reported an encoding glitch in Russian, which triggered me to investigate. I think, I [solved](https://github.com/dmdm/test_strftime) it, but wanted to wait for tehkonst's response before incorporating that in Pelican.
This is needed for the unitary negation iirc
one space too much indentation
80 chars would be nice.
Why does this need to be copied?
I wasn't sure if the db would take a `None` but we just need something that evaluates to `False`.
Are we single or double quoting things?
Then should we change other places, such as https://github.com/mozilla/mozmill-ci/blob/master/jenkins-master/jobs/release-mozilla-beta_addons/config.xml#L4 to read 'Beta release candidates' or https://github.com/mozilla/mozmill-ci/blob/master/jenkins-master/jobs/release-mozilla-release_addons/config.xml#L4 to read 'Release release candidates'?
I initially tried that, but it causes issues in the core tests:

  //  initially no listeners
  equal( Popcorn.sizeOf( popcorn.data.events ), 0, "Initially no events have been added" );

I don't know if we want it on he API. Also, the ready state events don't go on via the API either.

Do we want it managed by the API? or to be invisible to the API, as internal workings?
FWIW, this breaks a rule that's usually worth maintaining.

Which is to never have side effects inside of a list comprehension.
so you can only resume a runner instance? how about an instance that was never powered on?
Where is the cleanup for this?
I'd like that as well.  Annoyingly, inotify-like functionality is built in only in Java 7 onwards, and the bolt-on solutions for Java 6 are ... not all that attractive.
A lock can be lost if the lock server fails, or if the client looses connection to the lock server.
On 30/12/12 2:38 AM, Joseph Caudle wrote:
>
> In app/controllers/crops_controller.rb:
>
> > @@ -3,7 +3,6 @@ class CropsController < ApplicationController
> >    # GET /crops.json
> >    def index
> >      @crops = Crop.all
> > -    @new_crops = Crop.limit(20).order('created_at desc').all
>
> Ought we have a story to make tests, or should they be added before 
> the PR is merged?
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/Growstuff/growstuff/pull/75/files#r2520109>.
>
We ought to add it to this pull request, I reckon. I'll see if I can get 
to it today.

A.

-- 
Alex "Skud" Bayley
skud@infotrope.net
http://infotrope.net/
The absolute file path won't work.
Deleted in new commit
Yes, public properties are ugly in most places, but atm we have the same problem also with (set|get)Value.. Changes are not reflected into ->arr. Only the other way arround..
the usual convention for id is to write them in lowercase and separate words by a dash (-).
On 1and1 another case of IM crash related to this is memory limit. By spawning new threads IM can exhaust the memory pool.
This probably (?) throws an AttributeError if STATIC_URL is not set.
No, it does not. Leading spaces are currently not recognized by my &lt;div&gt; parser, but I can easily add that.
To elaborate, I mean loop through the elements on the side here and return the text of the one which is selected.

Then the test will read something like:
Assert.equal(themes_page.selected_explore_filter, 'Most Popular')

Then this method can be reused for the other options, if required.
+1 to perrito's idea
On 03:29 Tue 11 Dec     , Paul Tagliamonte wrote:
> > @@ -3,6 +3,13 @@
> >  PACKAGE=$2
> >  SUITE=$1
> >  
> > +if [ $# -le 1 ]; then
> > +   echo Usage: $0 suite package
> > +   echo suite: can be binary\|source
> > +   echo package: .deb if suite is binary  tarball if source.
> 
> check the code bro :)
Sure bro will do that :)

-- 
Vasudev Kamath
http://copyninja.info
Connect on ~friendica: copyninja@{frndk.de | vasudev.homelinux.net}
IRC nick: copyninja | vasudev {irc.oftc.net | irc.freenode.net}
GPG Key: C517 C25D E408 759D 98A4  C96B 6C8F 74AE 8770 0B7E
Could also make this PHP4-compatible, but I don't know whether that's desired.
`which` only finds executable files, so I think -x is unnecessary here. Then the `which` doesn't need a subshell, either (as the exit code is sufficient).
Would be easier I think to just pass in `command-processing` here; no need to pull out the keys you need only to put them back into a map again.
These cached variables should not be exposed, as there's a danger that they'd be used directly without knowing whether or not they've been initiated.
Same remark here, I'd make the removal of  role explicit by checking
```if (roles[p] === false)```
I think `$enclosingMethod` will generate some errors in scaladoc (it tries to use an undefined variable), maybe it's a typo.
Exit is an internal message used to notify an actor that another actor it is linked to died.
ta been meaning to sort this one out  and keep forgetting ;)
initWithSchem:host:path was incorrectly used in this case because the "path" var (also incorrectly named) also includes the query string. As a result, initWithSchem:host:path was doing a strange substitution to occurrences of "//" in the query string and breaking links in the &note
Yes--good catch!
yozio
Why not just pass in the Editor object?
Спасибо, упустил.
а если ==0?
При 100 тыс. значений в ДНК замена 10% производилась за 4 сек., 30% - за 33 сек. 100% я не дождался. В рамках задания все ок, но лучше бы пересмотреть алгоритм.
removeObjectAtIndex, insertObject:atIndex можно заменить на setObject:atIndexedSubscript
Test works! :)
This line should be removed (I forced a single selection since multiple selection wasn't implemented).
i like something like

```ruby
  def hash_to_query(hash)
    require 'uri' unless defined?(URI) && defined?(URI.escape)
    normalized_hash = hash.reject {|_,value| value.nil? }
    query = normalized_hash.map{|kv| kv * '=' }.sort.join("&")
    URI.escape(query)
  end
``` 

better. Shows a little bit more about what is going on. But again, personal pref.
There is a Login Form rendered in navbar.

Von meinem iPhone gesendet

Am 01.08.2012 um 02:45 schrieb Rodrigo Augosto<reply@reply.github.com>:

>> @@ -555,7 +566,7 @@ def get(self, encoded_email):
>>             return self.redirect_to('home')
>> 
>> 
>> -class ContactHandler(BaseHandler):
>> +class ContactHandler(LoginBaseHandler):
> 
> Why contacthandler extends from LoginBaseHandler ???
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/coto/gae-boilerplate/pull/104/files#r1278987
This test is a good one to have, but somewhat misleading. It's only okay on an infinite sequence because the subscription is being disposed of.
I'll open a PR asap
right, i remember we had this issue.

On 05.12.2012, at 21:55, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/epochs.py:
> 
> >          if event_id is not None:
> > -            selected = np.logical_and(events[:, 1] == 0,
> > -                                      events[:, 2] == event_id)
> > -            self.events = self.events[selected]
> > +            overlap = np.in1d(events[:, 2], event_id.values())
> use in1d from fixes.py as np.in1d is too recent
> 
> —
> Reply to this email directly or view it on GitHub.
>
it's only common practice if  `plot_topo_power` doesn't always open a new figure anyways ;)
tmin = evoked.times[0]
This should be GET_ENCOUNTER_ROLES
typo: stickiness
There are 2 other occurrences in this commit.
Here we are not sending unlock instructions, but rather unlocking an account. Or we need to leave it as before or add a new hook.
yeah, but who cares when using composer ? you don't need to bother about the way stuff are stored in the vendor/ folder
this should be ``:phpclass:`` as you want to link to the PHP documentation, not to the Symfony API doc
By including *a* - I think that sounds better
@weaverryan I changed the class name to make it fit with the filename... (oops I should have done the invert change the filename to fit the class name (according to PSR-0)) now it is fixed
Is it a good idea to add a note that the code samples in this documentation always use the variable `$formFactory` when referring to that global factory?
I don't think so, maybe the author did that just for differencing between the function itself which has the same name
"return backing array _for_ ...".
That was one of the questions I expected to come up: users are used to the Mailbox term, does it have more value to use the less-gripping term MessageQueue because it matches our internal abstraction? It’s a serious question. Either we rename all of them, including the config file entries, or none.
Since you're testing simplify(), it's probably better to just test the expression itself, in case the result from integrate() changes.
Perhaps some more characters could be added in the future. They could be even set as a param to the underscore method or as a config array.
¿El join no debería ser con <br />?
It's necessary because whenever we declare an attr_accessor, it defaults to nil

Here's an example that shows a way to solve this... Probably a way using meta-programming to handle inside the class definition though: http://rubyfiddle.com/riddles/b2334
We can call only one of these two function on the same grid.
It works like a mask so maybe we can add a exception to tell the user to use only one of these two methods.
you should always use curly braces
Once a line is modified, CS should be updated on that line
Yes, you are right, this is a typo. I'll fix it today.
So when you are a regular user who has never installed before, how do you get the environment variable set? Am I misunderstanding that process environment variable will aways be set?
Why two different catch clauses where the only difference is log.failedClearingJdbcCacheStore(ex); ?
+1

On 26 September 2012 16:01, danberindei <notifications@github.com> wrote:

> In core/src/main/java/org/infinispan/distexec/DefaultExecutorService.java:
>
> > @@ -150,6 +151,13 @@ else if (localExecutorService.isShutdown())
> >     }
> >
> >     @Override
> > +   public <T> DistributedTaskBuilder<T> getDistributedTaskBuilder() {
>
> How about createDistributedTask()? The 'get' in the name seems to imply
> that every call returns the same builder.
> I'd also make the Callable a parameter to this method, since it's not
> optional.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/infinispan/infinispan/pull/1343/files#r1696286>.
>
>



-- 
Manik

"Physics is like sex. Sure, it may give some practical results, but that's
not why we do it." - Richard P. Feynman
Why use a latch here? By submitting a Callable, you can get Future instances back which allow you to check:
1. If the callable threw an exception
2. Allow you to call get on the future and wait for all threads to finish.
I think @danberindei commented about the lack of whitespace between operators and operands. Makes it a bit harder to read.
This should be `uint32_t`.
Would need a docstring.
`return Accept.Checked`
you no longer comment this, it would be nice to have a "see NEMO#XXX for why this is necessary" or something, but ok
Two thoughts,

1. Drupal (before it was arrayified) had `$headers` before content (I use headers more than content) and `$method` (aka type) later as well with GET being assumed as a default. I think getting a sane order is important to ease the pain of a lot of use. [drupal_http_request](http://api.drupal.org/api/drupal/includes%21common.inc/function/drupal_http_request/6) is the Drupal version.
2. An idea would be to make this chainable method calls. Instead of numerous arguments on one method having one method per argument. Spitballing here:

```
$foo = new Client();
$foo->method('GET')->url('http://foo.com')->execute();
````
Wszystko fajnie, ale po co to zakomentowane?
Nitty question, but what specifically makes this test simpler?
just making sure this should be commented?
Is this ever going to execute in Windows? All in all it's just another brick in the wall. Actually, this kind of broadcasting of a message to logged-in users is frowned on in Windows because there were too many exploits in the dial-up days which tried to extort users into paying money to stop the message attacks. Maybe add a Platform method which does nothing in the windows case?
This will be required when we allow deleting of items.
sure thing, good catch.
Use CDynamicObjectArray.
It could be character encoding problems. I'll fix it.
Yes, this is admittedly a brute-force approach to a possible syncing problem (in particular old photos imported to tokyorails that are no longer on meetup). The issue is that I don't think we currently have a way of comparing the Image objects in the system to the URLs given back.

The key question then is how rigorous we should be about syncing images. If we want to be really thorough and not have this bottleneck of clearing and generating images every time, I think we'll need to build a new model that will hold the original URLs for all the Images for the most cleanest (but perhaps a bit too heavy-handed) way. 

Alternatively, we could just add a column on the Image table to hold the original URL. This isn't so bad either, since the table will still only be 7 columns wide.

Let me know what you think :) I'll be glad to make the changes.
When vanity is not collecting data, the dashboard will display 0 participants/conversions even if there is collected data; I disabled resetting when not collecting so users cannot unintentionally reset the collected but not visible data.
Это вынести в custom.css
Needs phpbb_ prefix.
@schmittjoh this looks like a wrong check
Are you sure you want to override the parameter ``$classes``? This often makes code less readable. Please also check line 46.
Sure, will change it
Clarity... I just prefer switch statements to lots of if statements....  like I said, if *I* do it then I do it the way I like to.  :-)
you should probably link to the contributors page instead of adding every guy doing a PR to the bundle (otherwise, you already forgot one contributing before you)
Its not really guaranteed that ```riak.restart``` is going to return true.
No empty lines around. Because they also go to the translation string and it is ugly. So start the string immediately after `{% blocktrans %}`.
This is not XHTML valid.
Oh, just pass request to `image_url` and do the rest there.
Int field? What will be stored here?
2 should be a top level module constant.
You have to configure a context variable with a label. You use `with` for that. :-)

Yes, you should fix it. But first fix that your local version works. :-) You can always logout. And register again. :-)
Yup that's exactly the implication.  I thought this code would be okay because 4.0.x didn't create databases, so I figured the only database where this would make a differences was ones created with the nightlies.  I just realize that we need to deal with versions after 5.0, and this code will definitely not do the right thing there.

I think I will change != to <, so that we won't erase databases created by newer versions of miro.  At that point it will be pretty ugly, but hopefully good enough to push out the door and we can rethink things for the next version.
What about Int64s? Shouldn't they be supported as well?
why not mangos version?

```diff
diff --git a/src/server/game/Spells/SpellInfo.cpp b/src/server/game/Spells/SpellInfo.cpp
index a497227..a456022 100644
--- a/src/server/game/Spells/SpellInfo.cpp
+++ b/src/server/game/Spells/SpellInfo.cpp
@@ -1989,22 +1989,20 @@ uint32 SpellInfo::GetMaxTicks() const
     if (DotDuration > 30000)
         DotDuration = 30000;
 
-    uint8 x = 0;
     for (uint8 j = 0; j < MAX_SPELL_EFFECTS; ++j)
     {
-        if (Effects[j].Effect == SPELL_EFFECT_APPLY_AURA && (
-            Effects[j].ApplyAuraName == SPELL_AURA_PERIODIC_DAMAGE ||
-            Effects[j].ApplyAuraName == SPELL_AURA_PERIODIC_HEAL   ||
-            Effects[j].ApplyAuraName == SPELL_AURA_PERIODIC_LEECH))
-        {
-            x = j;
-            break;
-        }
+        if (Effects[j].Effect == SPELL_EFFECT_APPLY_AURA)
+            switch (Effects[j].ApplyAuraName)
+            {
+                case SPELL_AURA_PERIODIC_DAMAGE:
+                case SPELL_AURA_PERIODIC_HEAL:
+                case SPELL_AURA_PERIODIC_LEECH:
+                    if (Effects[j].Amplitude != 0)
+                        return DotDuration / Effects[j].Amplitude;
+                    break;
+            }
     }
 
-    if (Effects[x].Amplitude != 0)
-        return DotDuration / Effects[x].Amplitude;
-
     return 6;
 }
 ```
Like I've said, I'm really clueless about what do you mean, sorry :)
If you can help me out with this one it would be much appreciated.
Missing line break before and after. Use spaceless if you want to remove extra generated spaces
You should just add a single backdrop element to the page when the document loads and then add/remove a class on it to show and hide it. This way, you can animate the opacity transition when displaying and hiding it. Look at the CSS for the Pushpop modal to see how I did this because it's a little more difficult than it sounds (e.g.: you want the visibility of it to go completely away after it has faded out which is tricky).
you have a critical problem here: this 3.0.0-SNAPSHOT is messing up all dependencies. This should be 4.0.0-SNAPSHOT
yet*
(Use `get` method of the `META` dict.)
plone/act/plone.txt has already been renamed ti plone/act/keywords.txt
I don't think so, hence me adding it. Want me to first test if the init script exists before overriding it?
don't use import *  either import .... as shorthand_name, or explicit imports
needs an explanation, which is which, what are the constraints in each version
It would be great to add a comment at the top of this file with a link to the NFKD spec, but I was referring to a description of the stable sort algorithm you used.  If you mention it's just a bubble sort that maintains the order of equal elements and exits early if no swap was performed, that should be fine.
感觉还是分成两句好点？
Will the test end once the end of the test method is reached? Seems like the async callback wont ever get a chance to execute
Since this is a new file, I don't think this header info is correct.  Recommend either elimination (preferred) or correcting it.
I have this logging pushed down into the direct exception constructor, will swap it after this gets pulled in.
Wouldn't this be better as an  AbstractSystemProperty<T> 
with abstract T getValue() ?

Having subclasses inherit from something which delegates to string-based is weird.

Alternatively we could get rid of this hierarchy altogether and use ConfigKeys that are used against BrooklynSystemProperties ?
We do a `wars != null` above, but then do this which would throw an NPE. But same as groovy, so ignoring in this pull request.
maybe make this an abstract method, to force people to implement it ?
Hah yeah I think I left this same comment on your initial review, minus the helpful CSS hack :wink:
Not new code, I just moved it around. Just fixed it.
Because I can get failures on things other than SyntaxError, and the error messages changed between 4.3 and Ace so I can't preserve the behavior.
Uncommented. Now it's a passing test.
I am always in favour of using descriptive names for the tabs. Might be something to change. But that's just me :)
Should be a tiny bit better. Tell me what you think.
Should we not set recursive to -1 here?  seems like that would help as well.
what do you mean by "concentrating on common data" ?
I did experimentally test with a null and an empty CatalogItems, but it had no effect, so I suspect it's either not supported or doing the merge behaviour. As I don't have any spare catalog items to add, I couldn't test it further right this moment. Also, given that catalog items are managed individually by their own calls, I suspect they're not intended to be edited in this manner.
No real difference here, but you'll see why this is awesome on my first framework check-in with its tests.
Here the line to improve...
Personally I'm always much happier in C++ making the member variables private and using public setor methods.  That way if we ever have to add sanitization logic it doesn't require refactoring.
RbProjectSettingsController maybe?
I see where you're going, but HTML sanitisation in this case should be a given - escaping would escape all the new markup (frustrating), stripping leads to strip_tags() and less safe solutions (vulnerabilities). HTMLPurifier sanitising the output will give them exactly what they ask for, perform escaping on the rest, and the output is always safe.

You might have meant something else I'm missing?
agree, i'm changing it to class_eval.
Это не надо копировать. Надо использовать мои классы.
gBrowser.ownerDocument
This needs to get fixed.
maybe we want to rename `targets` to `registeredTargets`… up to you.
This is ok, but as a nit I would suggest something like:

Assert.contains(foreign_search_term, search_page.title)
Well, the answer is really simple; There is a defined interface already for `index` in the regular indexing, the bulk method should not deviate from that which means we need to do it like this:

```php
<?php public function index($doc, $id=false, array $options = array());
```

It is kind of important that these interfaces are in sync so they are replaceable. A problem is that the current method signature has no way to supply meta fields. I guess I want to switch to a new method signature:

```php
<?php public function index($doc, array $meta = array(), array $options = array());

// Example
$indexer->index($doc, compact('_id', '_index', '_type'), array('refresh' => true));
```

So this is what must happen:
Implement it with `index($doc, $id, $options)` but perform type sniffing on the `$id` input, if it is an array treat it as the complete `$meta` data, and if it is a basic type set it to `$meta['_id'] `. That solves backwards compatibility and adds support for meta fields — I can add support for this behavior to the other index method later on.
How does this sound to you?
クロージャはAntの"copy"の処理の中から実行され、インクルードするパターンのリストを指定する"fileset"のみを含むことができます。

というような意味ですかね。
What about `valid_framework?`
I removed the ``demo/`` dir from git
@ogrisel  What do you think of a private method ``_generate_random_matrix`` that the subclass has to implement? It could contain specific details such as `_check_density` and distribution type.
Yeah, I know, I should really look into that again... motivation level... not that high ;)
Btw, this is just copy and pasted ;) I think you wrote this code ^^
@lsmith77 those locales will be shared around by a compiler pass of the cmf corebundle one day right? i see that we already have that in the Configuration of ContentBundle but don't do anything with it until now.
The brackets, in this case, are a break from the coding style for single line if statements..

http://kohanaframework.org/3.2/guide/kohana/conventions#single-line-statements
You shouldn't need config parser for yaml support. please remove.
That sucks :/
This seems to be a Walterism, but what's the official word on this? Put braces on their own lines but only in new code?
More exhaustive test I think.

```d
private   struct TestProt1 {}
package   struct TestProt2 {}
protected struct TestProt3 {}
public    struct TestProt4 {}
export    struct TestProt5 {}

void getProtection()
{
    class Test
    {
        private   { int va; void fa(){} }
        package   { int vb; void fb(){} }
        protected { int vc; void fc(){} }
        public    { int vd; void fd(){} }
        export    { int ve; void fe(){} }
    }
    Test t;

    // TOKvar and VarDeclaration
    static assert(__traits(getProtection, Test.va) == "private");
    static assert(__traits(getProtection, Test.vb) == "package");
    static assert(__traits(getProtection, Test.vc) == "protected");
    static assert(__traits(getProtection, Test.vd) == "public");
    static assert(__traits(getProtection, Test.ve) == "export");

    // TOKdotvar and VarDeclaration
    static assert(__traits(getProtection, t.va) == "private");
    static assert(__traits(getProtection, t.vb) == "package");
    static assert(__traits(getProtection, t.vc) == "protected");
    static assert(__traits(getProtection, t.vd) == "public");
    static assert(__traits(getProtection, t.ve) == "export");

    // TOKvar and FuncDeclaration
    static assert(__traits(getProtection, Test.fa) == "private");
    static assert(__traits(getProtection, Test.fb) == "package");
    static assert(__traits(getProtection, Test.fc) == "protected");
    static assert(__traits(getProtection, Test.fd) == "public");
    static assert(__traits(getProtection, Test.fe) == "export");

    // TOKdotvar and FuncDeclaration
    static assert(__traits(getProtection, t.fa) == "private");
    static assert(__traits(getProtection, t.fb) == "package");
    static assert(__traits(getProtection, t.fc) == "protected");
    static assert(__traits(getProtection, t.fd) == "public");
    static assert(__traits(getProtection, t.fe) == "export");

    // TOKtype
    static assert(__traits(getProtection, TestProt1) == "private");
    static assert(__traits(getProtection, TestProt2) == "package");
    static assert(__traits(getProtection, TestProt3) == "protected");
    static assert(__traits(getProtection, TestProt4) == "public");
    static assert(__traits(getProtection, TestProt5) == "export");
}
```
Thanks. I've needlessly added the `{ }` and then the compiler complained about lacking `;`, which distracted me from the real issue.
This function seems like it's duplicated many times, but I don't see anything that's specific to this class. I'd like to see this made into a static function in TiPropertyMapObject and then called instead.
What the avdId here?
It will be implemented in a future patch.
style requires whitespaces
A comment here about <name>[@<cluster>] syntax/capability would be useful here I think.
I expect it is, but are you 100% sure always in order ?

If they are, I don't know why we have @num at all ...
This function will need amending.  Again probably better to assert on no_if and think about when implemented.
The owner->disconnectSem.wait() is going to throw an interrupt exception...

that thread doesn't handle the exception itself.. shouldn't it?
Don't need ```args``` and ```kwargs``` functionality, just a single arg. In fact I'm not sure we want this enum style class at all. The constructor is called once (without an argument) in views.py and only used to get the known datatypes.
Just checking, this will default to `DEFAULT_PRODUCT` on pages like the 404 page. Is that OK?
Yep, this is all that is needed now. So beautiful ;)
And why do you need it twice?!
Hi Peter, which line are you referring to exactly?
Can you maybe drop this URL into the comment as well:

http://www.datastax.com/docs/opscenter/configure/configure_opscenter_adv

And we could create a separate issue to try and have the cluster auto-configured into opscenter.
I had no issues with parallel builds.  But actually this deletion slipped in. Sorry.
En français, contrairement à l'allemand, il n'y a pas d'accent sur les majuscules.
really, just retested it to be sure and it only creates the last one from the 'multiport' statements
what could be great is the possibility to specify multiple protocols
I would remove tab-browser from here as we have left it just because of some test that rely on it. We probably will be removing it at some point in a future.
this code is duplicated above and we can probably be refactored
the curly brace should be on its own line for method declaration
Yeah the `lib` diretory is not OTP standard, BUT it won't hurt to add it for greater compatibility across Erlang projects.
add @Logged annotation before methods you want to see logged in the surefire report.
clarity attempted.

note, there is another issue with make_hash, as dictionaries are unordered, its behaviour is not consistent.  I have added a sort() to the keys to address this
It's not hard to find the number of superusers, rather than hard-coding 1.
s/Exploits/Modules/
elsif ret =~ /NI_PONG/
why not just ```uri = target_uri.to_s``` ?
# ... and transform based on user-specified function
The rest of the main fixes are here and a few more below.
If the designers need to create a new issue for the assets when updated means that there are two places that need to be in sync. Also who is the issue assigned to? When is the issue created? 

The only difference here is that instead of making a pull request with the mockups+assets every time, there is a judgement call made by the designer as to whether it is a big change and if not they just have to create an issue for it. This optimization, trading some pull requests for tickets, comes at the cost of any accountability or changelog. You still have two places that have to be synced and when things get out of sync there is confusion introduced to the spec, whereas when you make it absolutely clear that developers are only developing on the spec that is on master you force clients and designers (both internally and externally) to actually follow a procedure for changes.
which kwargs do we need to be available?
Gettext again? Again, maybe a macro for this because it's the same as above and seems something better to automate.
I updated, but either way, this code is not used right now. Multiple items do not work with this commit. Cookies and asynchronous doGet's do not work well together. Which means either this would have to be made synchronous or the translator needs to fetch data from the article page instead of EndNote export.
I agree it's not ideal, but I think it's ok for now.  We'll want to revisit if/when we add support for more projections.
We'll also use this for models as I believe folks are describing the model in JSON, but transferring the vertex data as typed arrays.
Usage of delete is generally frowned upon due to performance issues.  Why not just assign to `undefined`?  On top of that, `_deferreds` is created as an object literal but then only indexed with sequential numbers like an array.  Why no make it an array, which should improve speed?  Finally, if you're concerned about the array getting to big with lots of `undefined` values, you could simply recycle ids after they are used.  My theory is that this will ultimately result in faster performance overall, but it's possible it could be a wash.  Thoughts?
Do we have a `Ray` class?  If not, I suppose we should make one even if it is trivial to start.
this is a fall through basically.  if the specified suite isnt found, ignore the argument and run all tests.  This behavior could be argued against in favor of just stopping the test.  Kind on the fence in this regard.
Именая переменных принято называть с маленькой буквы. Тебе не кажется, что параметров слишком много? Подумай как можно сделать твой код более читемым.
Annotation is good, but moved to its own file.
hopefully we don't need this . . .
Ah, yeah, sorry - I've miss read it. I meant `ConnectionPool` which means it's already fine.
pageId should be page
can you also mention the vagrant setup option please?
не получилось сделать возврат себя - создается несколько копий одного и того же. Как итог - удаляется it в одном из них, что очевидно не есть хорошо.
any reason this is private? 
http://developer.android.com/reference/android/widget/ViewAnimator.html#setDisplayedChild%28int%29
check_if_route_is_permitted
The typo is "Convenicence" right? Or the period? If not, I'm not seeing it :/
But the point here is getting "put(r, e)" to work to begin with.
Fixed by Jerro's latest commit.
so here temp needs to hold only `mid` elements..
The same goes for all of the cases in here where you did that.
This looks good and I would merge a pull contaning just this. Can you add a spec? Or I can in the new pull.
does this value end up being different from the value of "_" ?
an `EntityListener`
This may be covered in the preceding paragraph.  Or you could say:

Continue to insert, edit, or remove contacts to see registration of audit records.
http://developer.android.com/reference/android/content/Context.html#getCacheDir%28%29

Let's be friendly to the system, here.
Why?  You can format this as javadoc.

Anyway, all that's overridden here is you've replaced `getEngineName()` with `"history"`.  Rather than overriding this code, make sure that your data structure either contains both `history` and `forms` or contains neither, so this stage just Does The Right Thing.
either as constants in XLinkUrlBlueprint OR

public String modelClassKeyName() {
 MyConstantClass.modelClassKeyName();
}
instead of all this string checking, you could simply use a binary operator instead such as 0 or 1, and then use that for the boolean toggle checking.
Could this optionally take a config[:url] parameter?  It's nice to just copy-paste from graphite web UI, rather than breaking apart into host/port/whatever.
Can we call it ContentItemPresenter?
can you split these into separate lines.  it's hard to read
what about returning true in the process method if we want to flush?
Aah right. Oh okay - sorry, just wrap the whole expression in (). :-). You don't need the ternary. Sorry - wasn't paying attention.
I *think* that we need for this to default to true, because otherwise the puppet master can't connect.
Repetition: 
würde ich evtl in eine Methode auslagern...
@lsmith77 are we going to inject the locales to all cmf bundles anyways with the symfony2.2 feature for config precompiler? if so this would make sense.

actually the default locales order could be incomplete, as not all languages need to fallback to all other languages. (ie. english could fallback to french only even if german is allowed as well)
Cré*e*r
This line won't work. `hasClass` takes a single class name, not a CSS class selector. Also, please format this line to the style guide -- add spaces around the if statement, like

```javascript
if (condition) {
```
use the org.infinispan.configuration.cache.Configuration object instead, as this one is deprecated.
This is overly conservative. We should be able to e.g. destroy a `const int` or a pointer or an enum value etc. because that's a no-op. So we should only disallow overwriting const/immutable data, but other than that no problem. (There is this weird corner case of destroying const objects without indirections and without mutable indirections... we should discuss that later.)
So, maybe it will be OK to do it with ```Mockito.doAnswer``` ?
E.g. ```FileTransferringMessageHandlerTests#testRemoteDirWithEmptyString```
Maybe move this down into the else of the if {} else{} block at line 488 ??

Avoid 2 ifs for the same condition.
I see; sorry, missed the "outdated diff". 

I agree, technically, the output-channel and order should be done after the if/else, but it really doesn't make any functional difference, aside from wasting a few CPU clock ticks before detecting the error.

Regardless, the sum of the comments is a little more than I would like to do in a "polish while merging" so, Gunnar, take a look at Artem's comments and make another push (or push back :-)
Could "FOR UPDATE" introduce a deadlock potential here for any isolation below READ_COMMITTED, as MessageGroupStore (MGS) locks access to itself? If the inserting side of the queue runs inside a transaction there could be the following scenario if multiple messages are inserted and the transaction isolation level allows for it:

Inserter (I): Acquire MGS lock
I: Start transaction and insert message A, keep lock on row A
I: Release MGS lock
Poller (P): Acquire MGS lock
P: SELECT ... FOR UPDATE, waiting on lock for row A

At this point, the Inserter can't acquire the MessageGroupStore lock anymore (as it's held by the Poller) to insert a second message and end the transaction, while the Poller is locked waiting for row A to be unlocked, which cannot happen as the Inserter is blocked and can't finish the transaction which would release the row lock.

I haven't confirmed this behavior for Postgres yet, but I had a similar situation with MySql, due to the fact that the SELECT FOR UDPATE with an ORDER BY would create locks on multiple rows. If a lot of messages were inserted within the same transaction, e.g., after a splitter, there was a high likelihood of the poller getting into this deadlock scenario.
Is this safe? What if someone already has {abc} & {ABC}

Perhaps unlikely, but...
Should this method be really called in onInit() ensuring that you always have EC?
The requirement is to implement the interface, not to extend the class. So this change is wrong. You could add a note about this base class but documenting that you need to extend it is wrong, and will let think you cannot access the container if you extend from the abstract fixture class
Again drop the `{`.
The `(%s installed)` can be removed as it will always be 5.4.0.
два соседних предложения начинаются с «Контроллер»
Please use complete sentences with full punctuation in comments.
恩，可以用pt做单位的，我失误了
This doesn't seem to have a whole lot to do with OData, and appears to be pretty specific to current usage. Considering that other services also use OData, I'd hate for such a general name to be "eaten" on something so specific. Is there a more specific name we could use?
I'm changing this to 
`<programlisting language="JAVA" role="JAVA">`
The idea was to have an easy way to run all tests at once.
Yes, it compiles without them, but IMHO there are many good arguments for having them. This is a code style issue though and depends on which conventions are followed. I found it hard that indentation in the original code seemed to be 8 instead of 4. :)
Android does not have setContentOffset.  However, there is a scrollToBottom() method.
Direct language entry - it should use either English, or `$user->lang[''];`

I would preffer `$user->lang['']` - it is not a big deal, you can include it in common socialne language file. Or if you do not want to mix dev tools with default end-user package, use English at least, please.
file to file is the same domain (no webkit problem), and platform seemed to be fine since we don't have any problems with webworks working.
Można dodać taką klasę.
**Cupón
useDeviation has no default value. The doxygen comments says "@param useDeviation Sets whether or not to use the deviation. Defaults to true.".
This sentence is dunglish.