labofsahil/github-event-dataset-2012 huggingface dataset:
The upgrade needs to happen for the whatever the version is in 1.2.0 I guess. Are you saying that if the method executes twice we get the problem? Because the better fix would be to make it so he method does not cause corruption if run twice (if that is indeed the problem).
I will file a JS Lint bug.
This message and code seem out of sync.
Fixed. Removed comments
the rage.
this section is not publishable in its current form. 

I'm revising now.
Sure thing, I'll rework. Also removing some code i noticed isn't being used.
Yeah I suppose a comment would make sense.
You need to have response assertions for each request. E.g. assert_response_success.
Please not, this can now be abused by mods/extensions to mark a topic read for ever ;)
Cast user id to integer.
You mean move the sorting to the avatar manager, right?
What would be in $lang if it's not a string?
Why strtolower?
Shouldn't the above and the similar part in acp_users.php be done the same as it is done in functions_display.php?
protected, everywhere
对于 project，也是 go run 主文件即可。
Won't this create a new instance of sigar multiple times? shouldn't we share it?
why not use p.history_bought instead?
Сега като се замисля, top-level-а трябва да бъдат четири неща:

* visitor viewing a user profile
* user viewing their own profile
* user viewing somebody else's profile
* admin viewing a student's profile

Смислен рефакторинг е, би трябвало да елиминира объркания setup. Ако искаш, пробвай да го направиш.
Never for URLs.
I think this might be a problem too, tout won't be defined unless a timeout is > 0.  I'll fix that up as well
I removed the requirement that columns be AbstractDataVec's. It could be useful to be able to stuff in anything that can be indexed like a column. A Vector is a good example. If I have data with no NA's, then using Vectors would be faster and more memory efficient. 

That said, the default for reading from CSV and for all constructors should be for DataVecs.
This does not match the name of the file. The old header guard did.
didn't this same code for "platformizeModelConfig" get checked in in another commit?
suggest removing vm_lazy here too
one entry per line
Why not use the Named mixin?
If the functions are used outside, they need to go to the header file. Otherwise they need to be static.
I think that this method can be renamed to - cannotApplyForJobTwice()
unhelpful doc comments
You should also remove the `-abort` command line option and local `abortOnError` variable now that they do nothing. There'll also need to be a top-level `try { ... } catch (exception) { return 1; }` to catch the exception from `error` before the repl starts.
Sounds like an amazing idea, likely a @mikesherov project?
It seems to me kmeans is not dependent on svec anymore.  Everything is converted to float[]?
Thanks for all these feedback and bad to know that Tencent has such restrictions on developer account. :-).  I hope they could do better in opening their so called open platform. :-)

For testing  and evaluation purpose I guess I can put up an app (probably the TODO example ) at meteor.com,  enabled with my auth package, . That's what I actually did for local testing.

Does this make sense?
The fix doesn't apply to Windows, so Windows uses the algorithm for directories.
The below functions are kind of weirdly placed. I think they would fit better in `fjord/search/index.py`, but they can't go there because of circular import problems. I put them here to alleviate import problems.
The way data is transformed from the ES value to the display value varies a bit for each field. For sentiment, we can just map True to "Happy" and False to "Sad". For platform we can send it straight through. For locale, we want to call `locale_name()`. This function allows for all three options.There is also support for changing sentiment's True/Valse into 0/1 for the values. I'll add some comments about it all.
Committed a fix and rebased into the same pull request.
Also, this should be turned into a `Requirement` and specified using `depends_on`.
Yes, and I'm not really honest in the error message because, if high_pass > low_pass, you don't end up with a blank signal but with some weird values full of NaNs which, in my sense, is worse. That's why it's really an error and not a warning.
estimated attributes should end with _
Return forest of comments, with top-level comments as tree roots.

May contain instances of MoreComment objects. To easily replace these objects with comments, use the all_comments property instead. Use comments replies to walk down the tree. To get a unnested, flat list of comments use comments_flat.
Probably true - fixed.
I don't like the phrase _"If you use code gen"_ . . . users *MUST* use code gen. That's how dagger works! It isn't just for generated artifacts, it's also for doing static validation.

I think my biggest complaint about this change is that it's going to take always-on validation and make it optional.
Yup. And in the best case we never log anything.
ここから下のコードは
partialのコードにてMではなく、selfで自身を参照できるようにするためのコードです。
touchblockとは関係ないです。
OK, will do it as soon as possible ... My learning of Javascript ;)
This ends up as a global variable on `window`, doesn't it? I think you want this inside the class definition if you want it in the closure.
> I feel like instead of defining the function here, just use the call to the Utils module directly above.

The method already existed and was a public method.  I left it in to avoid unnecessarily changing the libraries API.
In the actual flow it doesn't get called more than twice I believe, in very different contexts... and I wanted to keep the internal structure hidden and not let other stuff depend on it, as I expect it to change, keeping the interfaces more strict felt safer (and the cost is pretty relatively minimal here, just some string parsing)
Yep, more likely redis/memcache or something that is cached but /might/ hit an async resource occasionally.  I'm pretty sure we'll want to manage the partition mappings more dynamically than a config file in the future.
Agreed, I don't like it either but it's the best I could come up with. FWIW, it dovetails nicely with the commit that I just amended to the pull request.
I was thinking that attempting to access a non-existant element would throw an exception, which may be harder for the person running the tests to understand. If so, then i think it's worth adding.
Did you mean to have "key" at the end of these 2 ids? It doesn't seem consistent.
The DocumentManager module no longer seems to be used.
Oops, and this one also has one reference by old name still in the unit test
This is a "pull" type API, so this function gets called on every keystroke by Smart Autocomplete and has to hand _something_ back each time.  I suppose we could return a "real" Promise the first time, and dummy Promises that never resolve for all subsequent calls... but that doesn't feel especially clean either.  We'd also need to add an extra check to make sure the query hasn't changed to one that the file search code doesn't even handle (e.g. text with an "@" prefix) -- see the logic in _handleFilter().
I wondered if that was needed, couldn't decide. What's the risk which
basic auth prevents?
This is not good. You are then comparing only dates. But the field can be also with time. We want to support a general use case, not just ours which is for birthday and thus only a date.
You don't need to define this method because it is already implemented in the parent class.
You will have to merge it sooner or later. I don't care. ;-)
Can we move the setter up, so it is directly after the getter?
Spacing around args-- (<space>this.headers<space>)
Listening for `input` instead of key-specific events works pretty well in cases like this one.
I figure we'll just change this requirement (mysql or sqlite3) in Matt's patch when that gets closer to landing
This should be on the same line as the catch
A relic from something else I tried originally. Being removed.
Same as https://github.com/mozilla/butter/pull/1056/files#L1R261
Do we want to remove `class`, `title`, `data-l10n-id` and `style` attributes?
`PDFJS.createBlob(data.buffer, 'application/pdf');` -- per comment above
Why `Underscored_Capitalization`?
Either use `camelCasedVariables`, or use `underscored_naming_conventions`.

In JS camelCasing is mostly used; and in PHP, Python underscored_naming is preferred.
Go with either one, not both.
The easiest fix would be to just change that line to `#ifdef __MINGW32__` since the only reason it's there is to define something the windows headers don't.
Is there any reason why we can't simply use GetDefaultApplication always if there are potential problems with CreateApplication/AddApplication?
in general, when a string can only be one of a few values, you should convert it to a symbol and use the symbol. faster comparisons, and it's also more clear that the range of values is fixed.
Move this out into a constant (or perhaps config?) somewhere with a description as to why we do it
query & notification & update
please remove the comment
```
# yum install pulp-rpm-handlers python-pulp-agent-lib
Loaded plugins: product-id, rhnplugin, security, subscription-manager
Setting up Install Process
No package pulp-rpm-handlers available.
No package python-pulp-agent-lib available
```
Where I can get these packages?
This PR needs to be merged in the very same day when you build pulp v2 in our koji. Good start point is to make sure scratch build will pass.
Yes, this change is in VerboseStragety so it affects only the verbose mode. Verbose and grep-friendly functionality has been divided in separate classes.
Oh, I am actually disappointed with numpy here. I did not expect that this would be necessary. Thanks for noticing it.

What was happening before you did the change?
you are removing the dependency of the handler (the raven client) on close, which seems weird to me. This means that the handler is in a totally broken state once close (calling a method on it would trigger a fatal error). And removing the reference is not needed. PHP is able to garbage collect objects.
This line should be

    if (instant) {
      style.MozTransition = style.MozTransform = '';
    } else {
      style.MozTransition = '-moz-transform 0.2s linear';
    }
That is definitely a mistake :P (Because I was trying to subtract some pixel but I didn't)
Thanks for this and I had corrected it.
I would prefer req.onload, but not blocking...
Well I for a bool mask yes. It means values that were masked (in either of the operands) stay masked. But you can define your own mask which can have different behaviors for the different arithmetic operations.
OK, forget my last comment. Yesterday was too late for me. I implemented as @jaor suggested but with the correct last line:

```
...
return url and (url.scheme and url.netloc and url.path)
```
Can you throw in a flag in this line that says DISCONNECTING or something?
>
> I think the line here should be indented to match the "If" in the
> statement above otherwise rst renders this as a separate line apart from
> the bullet.
>

Looks like I went a little crazy with the reformatting :)

A
Where can I see this change? It doesn't appear on dev.123done.org.
well, the method is not abstract when implementing it in a class
Why is this here? Doesn't seem to have much to do with request processors.
Saw that after, it'll be part of my next rebase alongside the other changes :-)
I don't do much HTML, but should there be quotes around _blank?
good point. no it is not. corrected!
The intention is - if there's no full name provided , just use login as fullName.
To be precise, no we don't need the wildcard, unless someone figgured out how to extend byte[] (which I've never seen actually done).
please revert this change!
good idea.  mind sending a PR for that? :P
Yes, there is certainly more than one way to do it. That code is just conceptually how I think about it (i.e. look at the format and then choose normalization logic based on those bits).
here it looks like failed metrics would halt the class loading, so perhaps that's not an issue
Same here - this code is duplicated. I think we can just remove the `exists?` method completely from `Criteria` and it should delegate to the context.
is `l10n_utils.dotlang._` lazy? If not then these strings will be set to whatever locale first loads them I think.
are you going to the edit page to grab the wiki syntax? or?
There is no need to add the method name to the message. It will be visible in the exception. Also it looks like you have an indentation issue in the last line.
Does this change affect the diffs currently used by the funfactory script to alter the settings file? I remember having issues adding stuff to this file before.
Yep and somehow you've deleted these stdClass definitions which means when we merge this PR you'll have broken PHP 5.4 support.  

--  
Phil Sturgeon


On Monday, 20 August 2012 at 10:43, Salmane wrote:

> In installer/controllers/installer.php:
> > @@ -217,8 +209,6 @@ public function test_db_connection() > public function step_2() > { > $data = new stdClass(); > - $data->mysql = new stdClass();  
> What part? I only added the lines to double check the writability of some blog subdirectories ..
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/pyrocms/pyrocms/pull/1707/files#r1412394).  
>  
>  
>
Nice - we fixed the same issue. You can drop this patch.
ну. тут ще потрібно додати можливість редагування полів типу компанія і т.д.
The best solution is to either.

1. UPDATE check if any rows are affected and if not perform an INSERT, but when using triggers that always fire this may lead to bugs,
2. INSERT and when hitting an error check the error-code and perform INSERT instead.

As far as I can find PostgreSQL does not support MERGE/UPSERT just yet.

https://wiki.postgresql.org/wiki/Add_MERGE_command_GSoC_2010
https://wiki.postgresql.org/wiki/SQL_MERGE


REPLACE INTO (In MySQL) is not completely safe, first it performs an DELETE (also firing any FK's or triggers) and then inserting it! :warning:
http://bugs.mysql.com/bug.php?id=2418
separating the tags from the description is not mandatory when using phpdoc. But it is what is done in the Symfony source code
@jalliot: Alright. So we now have a chainable method `setContentDisposition` that also allows to override the filename.
This will create a circular dependency: ``twig > twig.extension.form > twig.extension.form.renderer > twig.extension.form.engine > twig``. Twig extensions are a dependency of the environment, and contrary to the PHP helpers, they are not lazy.
it's done this way everywhere else.
``mixed[]`` means any array, so it looks weird to provide the others
Oh, I missed that. I completely forgot that all moment functions actually mutate stuff rather than return a new object. I cloned the `input` one, because then you may use an object that is convertible to a moment :) I'll fix that right away!
```Topic#owned_by user``` かなぁ
You can remove the commented line and the unused `skimage` import
@cowboy points out that this probably needs to change to 0.7.0 and higher since the new code won't work anymore. Is that cool?
`& > li`
算是故意为之吧，因为某次提交的时候乱码了，修改一下来覆盖那个乱码而已。
Oh right, my bad
Minimum age of reports archived/deleted is expressed in days.
On Thu, Oct 25, 2012 at 8:43 PM, sirkonst <notifications@github.com> wrote:

> In gunicorn/workers/ggevent.py:
>
> > @@ -79,7 +79,7 @@ def run(self):
> >
> >          try:
> >              # Stop accepting requests
> > -            server.kill()
> > +            server.close()
>
> Not now, see benoitc/gunicorn#419<https://github.com/benoitc/gunicorn/issues/419>
>
>
>
mmm it is based on the develop branch here. I wlll remove it on merge.
Give me a few minutes to get that swapped in and I'll submit a new pull request!
Actually, as of e2a757d we are memoizing the view context. This, on the other hand, only memoizes the `HelperProxy` object, and `HelperProxy#view_context` delegates to `Draper::ViewContext.current`, so I think this is safer.
m4v is in the old list, but missing from the new one.  we should map that to video/x-m4v
The xsd should enumerate the legal values.
Roger that, though while they seem like they are similar the configuration (apache/nginx) and setups only share some commonality, I think the best way is to have an Install with apache/mysql/php section and an install with niginx/mysql/php-fpm section.
There is enough difference there to justify two sections which is why I wrote the readme instead of just adding some comments into the .conf file. Its important to get it right so nobody has to ask questions :)

I'll commit and push this version up and you can check it out and let me know if you think this is the best course of action, it will be easier for users to install the system with clear cut directions.

also in the context path while it is possible to allow a user to create an essentially fake directory, this is a bad idea, they need to make sure that the contextpath matches the real path. while it is possible to add in a bunch of exceptions to check for a fake directory this is wasteful and not needed. I'll make sure to note that, but allowing someone to have a real directory structure of /var/www/testswarm/api.php and have contextpath point to /extra/api.php wont work and shouldn't :) 

The reason it is important that they follow these directions is because having all these optional variations is great if you know what you are doing, but they are following these directions because they don't already know how to do them, if they follow these directions they can be pretty sure they will have a working nginx setup running, if they don't get clear concise directions it's asking for trouble. This has just been my experience when dealing with people who are not very familiar with server side configurations and setups :)

kk I pushed it up so let me know what you think.
In fact, when this library is used in CAS server, all properties are pushed to CAS client applications using toString().
So you should add a toString() there and be able to parse it in ColorConverter. That's why you had two conversion logics in the previous ColorConverter (from Color object and from toString() output of Color object).

The best would be to have a toString() method returning HHHHHH, with H being an hexadecimal value (0 -> F), two hexadecimal values for each color.
http://people.mozilla.com/~lco/Settings_B2G/Release_1_Specs/R1_Security_and_Privacy_v3.pdf  page#7
are we planning to do this in the production version? 

@antonioMA ?
I thought that was the popup UI/UX has not been verified yet?
Probably the API should return all timezones available (including cities and more info)
The code for managing sound should be moved into Gaia...
If I add window.removeEventListener('appopen', hideTray); it doesn't work any more
yes, should be removed
What is the intent of this file?
English nit (how ironic :)):

I think it's 
Enable the user proximity sensor **once** the call is connected.
removing the need for this
Does this JS cover the cases where we could have a danger button or having only one "full" button?
Useless unconventional space.
README.md 里边的示例代码要改下
Did you forget to delete?
This translation has been reverted to English. Why?
This is not an orchestration class. I wouldn't call this an orchImpl. The method names should be renamed to avoid confusion.
out these in the same order that they are in the method call signature.
See comment in last diff about using `next` here.
Comment is misspelled.
It doesn't appear that this needs to inherit from `StatusReceiver`.
I think the point was that, if the 128 refers to bytes, rather than code-points, that while 128 is generous for English text, for other text it might be cramped.
Is there any way to use an or pattern here or above?

Maybe something like:

```javascript
/(%r(\(|\[|\{|&lt;))(.*?)(\))([a-z]*)/g
```

If not that's fine, I'm just not super crazy about the idea of having to use functions here, but I understand it saves a lot of duplicate code.
`for prop in properties when this[prop]?`

also,

>This pull request cannot be automatically merged.
There probably is a nicer way of doing this - I didn't understand the code myself, I was just patching here!
Why to subtract a const value 16? On ipad, the letter 'g' will out of bound.
<<OpenGL Programming Guide>> said that.

And not all SetBlending() usage is changed.
`'install' === $operation->getJobType()`
can you make this a macro like NACL_ALIGN in other code?
Well, that was my first try (see 9dc89d7ae). But the problem was that it would load the data for auto-completion every time you load a page with comments. This means you pay the extra db and disk look-ups for loading the auto-completion data even if you only want to read the page (Issue, MR, Wiki, etc.)
Is it *really* bad to append an image to the head? It won't be here forever, but does it work cross-browser?
Oh... how you make me smile sometimes!
Right, good point... I guess it shows I hadn't had coffee when I was reading that
What about ```APNSNotConfigured``` exception? I see python code handles this one too.
item_prices vs items_prices
Resolev -> Resolve
> url.parse returns string

Ya, that is a bit odd.

Another way to roll, would be `parseInt`, but your solution is solid.
this is a beautiful test to ensure we don't regress.
If the labels are not going to be shown but written into the DOM dynamically, is it easier just to place the strings here surrounded by a gettext?
bad CS here
If you are going to do this, you should do it uniformly to all the test files at once. :)
Style for the guidelines: periods at end of sentences.
You could also eliminate this class & module and register ``BlockView`` directly in zcml instead, since it does not really do anything. Or am I missing something?
Ok, one final question before I update. PythonOps.Compare does not seem to
be calling a custom __cmp__ method that is defined in Python. Is there a
better operation to use in C# to get it to do so?

 I had no idea the Binder was so good. I need to refactor some other code
to take advantage of it as well.

On Fri, Mar 16, 2012 at 11:52 PM, Dino Viehland <
reply@reply.github.com
> wrote:

> > +using IronPython.Runtime.Types;
> > +using IronPython.Runtime.Exceptions;
> > +
> > +[assembly: PythonModule("_bisect",
> typeof(IronPython.Modules.PythonBisectModule))]
> > +namespace IronPython.Modules {
> > +    class PythonBisectModule {
> > +        public static string __doc__ = @"Bisection algorithms.
> > +
> > +This module provides support for maintaining a list in sorted order
> without
> > +having to sort the list after each insertion. For long lists of items
> with
> > +expensive comparison operations, this can be an improvement over the
> more
> > +common approach.
> > +";
> > +
> > +        #region Private Implementation Details
> > +
>
> I think modifying List's insert method to be virtual should fix this (with
> very few negatives) and I think it'd also cause calls from
> IList<object>.Insert(...) to call the overloaded insert(...) method as
> well, which would seem to be an improvement.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/IronLanguages/main/pull/60/files#r571179
>



-- 
Website: http://earl-of-code.com
If/when we merge this, feel free to substitute this in lieu of the function I just added in PR47.
yes => #r1926016
and missing error handling
:return_to was lingering around in certain paths of use and thus directing the user to unexpected places. I figured this was a good place to reset it.
Won't this path make it fail when running via unit tests in ezp-next?
Anyway of getting path of the bundle and be relative from that?
you should use a markdown link IMO. I don't think the uri needs to be displayed (especially as it is quite ugly)
Also make sure to add validation to the model, in addition to the `null: false`
The wmsimage method will raise an exception if OWSLib cannot be imported, telling the user that OWSLib is required.
That's cute, but having it show `#skills` in the URL bar is probably better.
yikes!  sorry.  didn't mean to leave that comment in, it was in a moment of frustration...i apologize.

i'm not working with authentication, so hadn't run across that issue.  in the meantime, please let me remove that comment.

so sorry about that.  really appreciate the work you did on this project, it's a huge leap forward from ActionMongo.

-eric

On Apr 5, 2012, at 2:49 PM, Omar Gonzalez wrote:

>> @@ -71,6 +71,17 @@ package as3.mongo.db.document
>> 		{
>> 			return _values[index];
>> 		}
>> +		
>> +		/**
>> +		 * ERICSOCO ADDED
>> +		 * I hate this fucking Document class....so bloated.
> 
> The reason I had to add this Document class is because the authentication command sent to MongoDB has to have the keys encoded in the correct order. Ideally I wanted to use plain Object type to create command structures to send to MongoDB, but because Object is a dynamic class the properties can not be iterated in a predictable order, so I made this Document object w/ the put() method. 
> 
> Do you have any suggestions for an alternate solution that would let the driver enumerate over keys in an ordinal manner?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/s9tpepper/MongoAS3/pull/12/files#r652925
@jcredding  - thanks man, I'll clean that up.
Agreed. What about an optional `background-size` instead?
```scss
background-size: $image-width $image-height;
```
Well, that's a services proposal. This is due to AutoYast. Neither of these functions do it well ;) This one takes the current runlevel into consideration, the other one also starts dependencies and checks whether the service is actually installed. I would probably need to do a merge and move it to the RunlevelEd module.
This should just use `\Security::htmlentities($value)` as that one does exactly what you did here without code duplication.
should have )  at-end of previous line, and { alone at left margin, to line up properly with }
Hmm;  I see.  I think either of those behaviours is reasonable.  In your example, it's also possible that the assignment to 'c' happens *before* that of 'b', and then the `_wait` call in the 1st thread would be waiting for `c` to update anyway.  So I don't think user code can reasonably have expectations beyond that when Thread 1's `_wait` completes, the updates for `a` and `b` will definitely have completed (possibly along with some others).

The big advantage of the state machine for me is that it makes reasoning about the code easier, e.g., for guarding against race conditions and deadlocks.
enum? :)
Thats why I'm not using the singleton unless the this.SwaggerConfig property in null.  Controller property can be marked as dependency property for IoC.  (as can swaggerConfiguration.Instance)
This won't be done in the pull that changes Adblock Plus with MemChaser, please read the description in this pull:
https://github.com/mozilla/Addon-Tests/pull/385
Shouldn't this be `AB BC 12 34` (i.e., no commas)?
Might be nice to point them at the language reference here, so they know why we're enforcing this.
Can we use require instead to achieve a synchronous read?
The idea behind the `thingId` is that at some point you'll be able to create a revision for other things (sakaidocs/pages/widget configs/..)
I admit that `thingId` isn't very clear, but it's the best that I could come up with (besides a generic `id`)
configAPI and tenantAPI should have a capital
For SubMonitors it does not matter. I can put it in a finally block, but that's the main advantage compared to `SubProgressMonitor`: the parent work items are always consumed from child monitors.
This test never worked.
Again, I divided up these sections to apply them to the new outline:

- Page types [move to 5 ii]
- Layouts [move to 5 ii]
- Page and content permissions [move to 6 iv?]
- Importing and exporting content [move to 6 iv?]
- Content creation and editing [move to 5 ii & iii]
- Staging [move to 6v]
- Content publishing [move to 5 iv]
- Structures and templates [move to 6 i-iii]
- WCM Workflow [move to 5 v?]
- Asset publisher [move to 5 iv]
Hi,
I have addressed this. Can you please take a lot.
Do I also need to add code to the RHEL 6 branch? I guess that is here 
the original code that I posted was meant to go.
Who can I turn to with all of these trivial questions - sorry to be 
asking you - just saw your name appeared a lot on the github.
Thanks
Gary

On 07/02/2012 05:00 PM, Jesse Jaggars wrote:
>> +### This program is free software; you can redistribute it and/or modify
>> +## it under the terms of the GNU General Public License as published by
>> +## the Free Software Foundation; either version 2 of the License, or
>> +## (at your option) any later version.
>> +
>> +## This program is distributed in the hope that it will be useful,
>> +## but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +## MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +## GNU General Public License for more details.
>> +
>> +## You should have received a copy of the GNU General Public License
>> +## along with this program; if not, write to the Free Software
>> +## Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
>> +
>> +import os
>> +import sos.plugintools
> This is the old plugin base class module. Have you read [How to Write a Plugin] (https://github.com/sosreport/sosreport/wiki/How-to-Write-a-Plugin)?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/sosreport/sosreport/pull/61/files#r1084349
Should we use `OIORest` or `OIOREST`?
Trying to enter ACP main, got an error:
<blockquote>Cannot access private property phpbb_assertion_manager::$failed_assertions in C:\[skip]\phpBB\includes\environment\checker.php on line 95</blockquote>
Make it public back probably?
One indent is ok.
While I find 3+ description blocks for 1-line variable definitions wasteful, I usually ignore them. This however is not semantically right - a constant is not a variable.
Ah. Makes sense. I got confused because some command-line utilites use "1" to mean "stdin" as it's file handle 1 in C/UNIX
Ну как же, ведь r является суммой остатка от деления arc4random() на (self.genomeLength - i ), который не меньше нуля, и числа i.
Поэтому r не меньше i, в отличие от <что угодно> % 100.

Именно этот отрезок нужен по своей причине:

я набираю X случайных карт из упорядоченной колоды 0..99 следующим образом:
вытягиваю случайную карту 0..99 и меняю её местами с первой картой (единицей).
Потом вытягиваю из 1..99 и меняю местами со второй (двойкой).
И так далее, пока в начале колоды не наберется X случайных карт.
(Карты - номера клеток, которым предстоит мутировать, а X - процент из условия задачи.)
Советую использовать вместо  arc4random()%4 -> arc4random_uniform(4).
Прикльно, спасибо.
'e.file in'  is not correct as that will try to catch properties of the object, not indicies of the array. Can you change it to indexOf() ? (And maybe change the == to ===?
Thanks
Note: $failovergroup (returned as a boolean) was not used anywhere.
Why the `new...` prefix? It doesn't feel very Cocoa-y. How about `+schedulerWithPriority:`?
Reply below.
It is ZincJSONReadingOptions. Do you mean should it be NSJSONWritingOptions?
Trrue. A relict, used to loop over names in the beginning.... ;-)
we usually do not require SUBJECTS_DIR to locate the mne-sample-data which is assumed to be in the examples folder.
yes you can use this simple for loop, but it's better to use forEach method.
I think we should only explicitly include *IT.java, not ITCase, which we don't want to support.
Maybe. I thought that the user may want to access to the original Global (to delegate methods), but it's not necessary.
python 2 or python 3 ?
the default value should be removed IMO as the interface is ``transform($value)``
This is a perfect note, but actually the entire previous sentence needs to be changed as well. Setting `property_path` to `false` only works for 2.0, `mapped` completely replaces that for 2.1.
@WouterJ no I missed that it was the missing brace rather than the missing space that you were pointing out. I have added it now
This should contain a  link to the ``ConfigCache`` doc as it exists
It's cleaner to put the link on a new line
`BinaryFILEParser`
need to pass the proxy here as well :-D
Also, the argument to PyArray_malloc should be size_t. You might want some error check for negative values somewhere down the line.
>
>
> ```
> (A**2 - B**2)*(A**2 + B**2)  -> A**4 - B**4
> ```
>

doh  - that doesn't simplify to the rhs. The cross terms are A**2*B**2 and
-B**2*A**2 and those don't cancel.
Ньюлайн лишний (и там ближе к концу файла тоже).
li.spot
mmm, no, viendo la implementación parece que este debería ser `backupsToKeep`, ya que no lo hace por días sino por cantidad de archivos.
General comment - there is some overlap with scilifelab.bcbio.flowcell. We should consolidate these inte one module. Your naming convention is much better - these functions go to scilifelab.illumina, not bcbio.
This is a great presentation that helped me understand Rake much better http://www.confreaks.com/videos/899-railsconf2012-basic-rake
Makes sense. I was thinking the GUID because you can search for the installed application as well
i believe it is @cp16net
are we using these? it seems we are just raising below.
Yes it does. In OGM we actually have put the MongoDB module in a separate maven profile and we can override connection settings (hostname and port) by using environment variables. What do you think about this approach ?
you're using the deprecated configuration API. Could you update it to use the new one? We're in the process of eradicating all usages of the old API.

I already updated most other tests, so there are examples.
Oh good shout.
I can see you have a real passion to sort this out @akhmerov  :-) . Would you be willing to submit a pull request against my branch (or even mpl/master) with some of your suggested changes and we can talk it through in-line? I do not propose you modify all backends at this point, perhaps just the 3 we have discussed.
Tiny style point: please delete space between condition and colon, here and below.
OK, can you (or someone) give me a hint as to how to rebase properly?  The pull request was branched off of the tag "v1.1.1".
Suggestion:
```python
trans = Affine2D().scale(1.0 / self.figure.dpi)
bbox_inches1 = TransformedBbox(_bbox, trans)
```
If you have any time to fix it, go ahead. I just wanted to get as close to work as possible because no one reported that these bugs still existed until I found them tonight.
Add size attributes to all of your boxes.
Totally agree. I was trying to be "clever" and missed this side effect. I will rewrite this function.
Ehh btw you don't even need that function - you can just use CLabels::get_unique_labels()
This should have got split out into "Bottom actions", when we split things up some of this got put with the wrong parts. For bottom actions I did a bit of a clean up for all buttons so they were a bit more consistent.
This function isn't necessarily "evict" anything any more, shouldn't it be renamed?
clients is unused.
0后面的逗号。
From lines 1058 - 1063 are what I changed.  This massive diff is happening because I'm using CR LF line endings and I guess someone else is using some other format.  I notice that there are smaller spaces in the code.
Good call Myles.
.bem/lib/bem-bl ?
I had same question, but unfortunately I was not able to create test for it. For `methodWithCallableParameter(void onClick()...)` I got parse error. What is right definition of sequenced functional parameter?
Sure, trying to keep number of concepts down per example.
Do we really need to catch ``Throwable``? Usually, it is a bad idea to do so, since you may be catching system error exception (from which you simply can't recover). I'll change this to ``Exception``, unless you disagree.
I couldn't find a case where multiple SQLExceptions where chained into the sqlwarnings object, but the caller can get the warnings object and log/printout/report the entire chain.
I'm noticing a lot of repetition here. You should extract shared blocks into separate partials and re-use as much code as possible.
hehe good call. Must have forgotten. I'll fix soon
No need to prefix every file with "fs", IMO. Also, if its a JS module, file extension should be .jsm
People often use var $something when they want to distinguish between "something' and "something, as wrapped by jQuery". However, that's not the case here, so I think your concern is valid.
Sensible. I'll see what I can do.
`True` or `False`? :-) Try simply `bool()` on the value.
`(!self.runs)`?
No, this is not good way of translating. Use `blocktrans` and pass in the URL value, leaving HTML in the translatable string.
It works but you will certainly hate the way I added strings. :)
True. You are right. I had to fix this bug in one my other project now. :-)
*URL* -> *link*, if you are using it elsewhere.
You probably want `.text()` instead of `.html()`.

Space around `+`.
Same as in Python. Constant strings single, user-exposed strings double (which should be marked as translatable in JavaScript!).
Why no newlines on these?
Intentional: [download link on the project download page](http://www.atagar.com/arm/download.php) now points to `archive.torproject.org`
Test file parser_exposure_portfolio_unittest.py itself should be probably renamed?
I'm not familiar with return confirm. Is that a popup? If so, I would suggest we use a modal dialog instead (bootstrap has js ones we can use)
this needed because server returns "YES\n" instead of "YES"
DoCast checks for nullptr:)
But ye, it must be player only for this spell....
see https://github.com/bieridee/bieridee-front/pull/26/files#r844454
added nav-pills in next PR
No go... It should use CWD... (also, you got a space more than needed after `if`)

Maybe something like 
```php
if (!(@include_once './vendor/autoload.php') && !(@include_once __DIR__ . '/../vendor/autoload.php')) {
```

This would consider:
 1.  the case when the module is installed as sub-dir of a skeleton (handled above)
 2. the case when composer is run within the module itself (but it can't be, since the module requires a skeleton to work)
Change to "The term ID."
If you change to "response_code", this should change too.
To `frag`? Looks like they aren't :P
Could be I was working off an out-of-sync (w/ github) community site version which does not appear to have the install_method attributes.
One is `.len` and the other is `_len`.  I don't know why nginx stores the content type length redundantly in an `ngx_http_headers_out_t`.
え、なんでですか？
Why was that suddenly moved to currency formatter?
This line is strange. I do not understand it.
`loadsettings` is fired when `core/settings` has loaded up the settings file. Vim's `hook` method does not enable or disable Vim otherwise, so this is a safe way to guarantee that we will enable or disable Vim mode based on the user's previously set preference.
quite right - changed and will be pushed asap
I don't mind, although i) I'm very tolerant of deviants ;) and ii) I do think that it would make sense for changes in the Python names to be reflected at the C++ level too, which makes me slightly more reluctant...

Any other opinions?
Perhaps also explicitly state that `nproc` is accordingly being reduced to `nfiles`?  It's true, and might help make people realise the pointlessness of setting `nproc > nfiles` in the first place.
These can be done in one line.  No need for the new_target_PSF variable.

Also, I'd put a `break` after this line.  No need to check the rest of the ImageView classes if we've already found a match.
I agree, but we already have fields that don't follow this convention, so I vote to change it in v4
Why is db/schema deleted?
Best not to declare `throws IllegalArgumentException` and instead to just include in javadoc the runtime exceptions that are thrown, and when.
Is to worth including a link to http://wiki.nginx.org/CommandLine for this, and a bigger comment saying we prefer `kill -HUP` because that is the approach described in the nginx command line docs (rather than just saying it's an alternative). Also including a reference to issue #365?

Does this behave better, or is it the same as `nginx ... -s reload`?
worth javadoc however (also parent methods which i wrote)
Don't call `.id` on these two lines.
Did you mean "! " instead of "not"?
Furthermore, why are you using the raw `check_box_tag` instead of the `form.input`? According to [its documentation](https://github.com/plataformatec/simple_form/#mappingsinputs-available), simple_form should show a check box when the column is a boolean.
まだ初回の保存前の UserConfig さんを使って 上記URIへの POST をしてたりしないですかねぃ
this could break things depending of the user used to run the webserver
You no longer ask the Policy Manager... Policy Manager intercepts the messages so you can remove this log
indentation is breaking off at many places, a consistent indentation will be useful
Not sure. Is it like a validation of the parameter?
OK, moved User back to Application
I would make a case for some documentation here, even an inline comment - case 47: is super ambigous
In line 352, all arguments are piped through `shell_escape` which  should properly escape this.
Moving the fulfill down here makes a huge difference in some libaries. Not so much to the overall time but to the amount of recursion that takes place.
Здесь ты face проверяешь на null. А до этого вызываешь isInterface.
ex надо передавать в качестве cause (и в остальных местах по коду тоже поправь)
Не очень эффективный код.
За зачем здесь setAccessible?
Yes as I'm not over-riding all aspects of background. This clears everything and below that I set background-colour or background-image, etc
Remove this, just set through constructor.
<3 new property name
i agree with moving it into the page object, but i think it should keep the click_submit_review(). @zacc, can you explain your preference?

(an automation strategy i used on a previous project did not use POM, but treated anything that had an add button, filling in a form, and a submit button as a coherent process, in a similar kind of way to the POM.)
should have gotten all the places
:) old habits... will fix
:+1:, but please make it clear in the readme part that hints are not rendered since they don't support it by default.
The rake task is used to build the site (pages => site). Initially I wasn't sure how it would process markdown files but it turns out so long as you have *.html.md it works fine.
Do we really want to have a different assume_centered in the mahalanobis than in the different parts of the object? Is there a usecase?
Probably better to use `0.01 * self.random_state.randn(self.n_components, X.shape[1])`.  Also is `0.01` always good / as good as any other value?
According to [this](http://docs.scipy.org/doc/scipy/reference/generated/scipy.sparse.linalg.eigsh.html#r122), I believe so.
those commented lines, if they are not part of the test
Shouldn't we return None here?
Can we rename this to something more generic, like 'noScroll'?
It is not safe to call `gem` directly here, see how it's done on other compdefs
BTW how about excluding that test by a maven profile triggered by -Dopenjdk?
I understand. It looks like a bad merge to me.

Mickey




On Sunday, February 19, 2012 at 11:34 , jmburges wrote:

> > @@ -53,6 +39,10 @@ def hours(member=nil)
> > end
> > end
> > 
> > + def members
> > + TimecardEntry.find_by_sql("select distinct member_id from timecard_entries where timecard_id = #{id.to_i}").map {|e| e.member}
> > 
> 
> 
> I didn't change this...
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/mickeyreiss/abtt/pull/19/files#r465440
> 
>
As discussed, lease it as is for now but we need to ask Appcelerator if this is actually the intended behaviour.
There, see new diff
> Yeah i know but it was worst before that!
?
Those kernel ids are not working.... I tried all the kernel ids I could find from the canonical's ami locator on the ap-southeast-1 region.
That is why I looked for help on the mailing list. Martin is telling us to hang on for the new AMIs.
It should be using roxiemem, but not at this point in time.

Using other memory (general heap), just side-steps the issue, and may cause other problems.
e.g. if allocating / resizing to a big table, using heap, the process may run out of memory altogether and OOM.

As Gavn said in previous comment:
>it needs to be preallocated.

.. before it needs to spill (because out of memory)
See code in ccdsever.cpp(28165) to call the row checking functions.
I was actually more concerned about packageSetSpec being NULL.  Especially since it is explicitly allowed into this branch by the test condition.
I don't think it has any effect (presently) in linux. But it probably should. I will fix and repush
If you mean what is the point in 'seed' ..

seed() is used when phase is done, spill buckets have been created (ht key spills + row spills).
A new bucket handle is created for one of the spilt buckets and is primed with the corresponding spilt keys (all of them)
It is called elseDs because it is the dataset that is returned if the condition is out of range
Is 0 a sensible value to indicate an error? Can it be distinguished from the return value for two identical strings?
Thinking more, maybe we should keep the original author and filter it on the way out.

I've been talking on the annotator-dev list about making the Annotation class pluggable. I think we could modify Annotaton.search() to filter out redacted.

What do you think of that? Leave the `user` field alone here and introduce a filter in Annotation.search?

Then, when I refactor annotator-store upstream to make the Annotation class pluggable, we can bring our custom annotation class into h and use upsteram annotator-store. With a customizable Annotation base class, the threading can be kept downstream, too, until there's consensus on how to upstream that.
Unless each and every page accepts the ``product`` parameter, or we use cookies again, I don't see how we can reproduce that previous behavior. Maybe some JS and local storage?
not a huge fan of this try/except block. Couldn't we use some sort of established serialization format? (querystring, JSON, ...)
If the Us in About Us can be assumed, why cannot the Us in Contact Us also be assumed?
Wrap this in three-backticks-c#

```c#
namespace likeSo { };
```
maybe `contentScript` would be more explicit.
I'd actually add matching here, so that one can:

- define which params are required to match
- define constraints for the match
C'est la technique que j'ai trouvé pour updater un enregistrement avec un attribut non accessible
@christianv Is this the new main text color for the whole site? Or just for UpNext? (if so, maybe it needs a more specific name).
I was actually using the SendGrid addon on Heroku for sending the email, maybe it sets some of it's own variables.
Nää kaikki voi määritellä yhessä `let`issä:

~~~clojure
(let [shvalues (sort (map rank hand))
      smvalues (sort (replace {14 1} shvalues))
      [minv _ _ _ highv] shvalues
      minVals (range (- minv 1) (+ minv 4))
      maxVals (range (- highv 4) (+ highv 1))]
~~~
Was wondering about using apache httpclient here.  Wanna show, "It's easy, you just POST the token to auth_info", but this Java HttpURLConnection makes it look all weird. :/
It's painful this class is 242 LOC for 1 LOC that does anything useful.
Please avoid the use of general url's, only references to the specific technique in the module
I just wanted to say that I really like this example.
To clarify, the coefficients for each problem can be set up as to mimic the most general problem.  E.g.:

We start of, trying to solve the most general ``Hp = p'``.  Now, we can set certain values in p to constants (1's, 0's etc. depending on what they are expected to be).  You can then write the system as follows: ``H(p_model + p_const) = p'``.  Where p_model has zeros in the appropriate positions.  We now have: ``H p_model = p' - p_model``, where we do not have to solve for the zero values in p, since they are zero.  This new system is written by dropping the appropriate columns in H and entries in the results vectors, such that we have ``H_dropped * p_model_dropped = p' - p_model``, which can be solved using lsqr.  Something along those lines...
I thought we had discussed avoiding declaring (and especially initializing) multiple variables on a single line like this.  But it's not in the coding conventions and I don't actually care either way, so feel free to disregard this.