labofsahil/github-event-dataset-2012 huggingface dataset:
That's what it has to be according to GCC's license: gcc's implementation of standart headers is part of GCC, therefore it uses GNU GPL, and therefore, as long as GPL is copyleft, it forces us to use GPL as well. But it's ridiculous, so I am just ignoring copyleftishness of GPL (and, btw, it's a kind of illegal to use any copyleft license in Russia, but I'm not sure about that).
I assume that this section was removed based on the resolution of the following bugs:

[TIMOB-6610](https://jira.appcelerator.org/browse/TIMOB-6610)
[TIDOC-150](https://jira.appcelerator.org/browse/TIDOC-150)

Can you give some more info on this if necessary?
Usually the `FFFP_` prefix would usually be ommited here. Same applies to other members and `FILE_USAGE_TYPE` class.
c et d? => src et callback
Actually it is the other way round. warden.log now _only_ contains check fails
All debug messages are logged to server.log if the appropriate debug log mask is activated
You could just add the following to your vimrc instead of forking and editing the source code:

    call Pl#Theme#RemoveSegment('fileformat')
    call Pl#Theme#RemoveSegment('fileencoding')
    call Pl#Theme#RemoveSegment('scrollpercent')
    call Pl#Theme#RemoveSegment('lineinfo')
Okay I pushed the change. You can set the generics in situations where they cannot be inferred that way.
They are handling it wrong if you need to put them in cpp. If SAI can hook them from db then cpp scripts should be able to hook them from db also. I know that scripts used to have their own text table also but that is changed. It would be best to keep all gossip in db on a go forward basis.
#simpy at freenode -> #sympy no freenode
Original author MD
@nacmartin @sixty-nine take a look and don't forget to update sandbox too: exposing routes is required.

Some extra coding was required to update dropped node's ID to keep possible to drag&drop it again and again.
this commit makes the coast of removing a rail 0.. not what that vote said?
&& is preffered here also... please, check here:
http://codeigniter.com/user_guide/general/styleguide.html#logical_operators
I would use the full name <code>storekeeper:app</code> for clarity's sake.
Maybe my Unit test isn't OK, not sure on that either.
I doubt adding a lock for .error makes sense. It's set to False only during init and later it only ever gets set to True if there is an error. I doubt there can be a race condition or conflict here (famous last words).
Yup, that's [how I did it](https://github.com/christiangenco/hw2_rottenpotatoes/commit/526be4f38a9c2ec13faa0ca2596f783d810a8d5a) too.
done ... [9d9e754](https://github.com/plone/plonetheme.sunburst/commit/9d9e75444ca7cc6ec62d4e7a9f9483e65d48e7d9)
Can you do me a favor and use < in place of LT, its more inline with the script style syntax I'm using in the Koans.
Ты сломал мне мозг расположением скобочек ))
Thnx for the tips i updated it accordingly.
There is not so much doc on Packagist.org so i was just playing around how it would work best ..
By the way, the example you gave above wouldn't work either, because query.search = 'starbucks' would return a new Query object.. so you'd have to go query = query.search = 'starback'
can stop be called before start has been called?  E.g., if conditional.  If so this access to writer may fail.  I would move the if (writer) test so outside if (aborting).
an empty string on this place caused a php notice on https://github.com/UnionOfRAD/lithium/blob/master/net/http/Media.php#L445
Great suggestions - I've pushed the latest.

Concerning seeding of the generator, MWC64X_SeedStreams does use get_global_id(0) and should allocate non-overlapping regions of the sequence space to each work item.  __cl_random_seed is used as a base offset for this allocation, so if my understanding is correct it's like a single seed for all work items in a given invocation.  Further "splitting of the streams" then happens within each kernel when MWC64X_SeedStreams is called ala get_global_id(0).  Let me know if you think I'm being naive here.

And you're right, randomSeedParam should refer to randomSeedName but I think I'd need to move MWC64X_RNG.scala to ScalaCL/Collections.  How do you feel about that?
Don't forget `commands`.
You could move the `logLabel` logic (and even the `queryEnd` computation, if you wish) into a separate method:

```
private Cursor checkAndLogCursor(String label, long queryStart, Cursor c) {
  long queryEnd = android.os.SystemClock.uptimeMillis();
  String logLabel = (label == null) ? this.tag : this.tag + label;
  RepoUtils.queryTimeLogger(logLabel, queryStart, queryEnd);
  return checkNullCursor(label, c);
}
```

so `safeQuery`'s body becomes:

```
  long queryStart = android.os.SystemClock.uptimeMillis();
  Cursor c = db.query(table, columns, selection, selectionArgs, groupBy, having, orderBy, limit);
  checkAndLogCursor(label, queryStart, c);
```

which of course you could flatten into a single line, because Java guarantees order of evaluation.

Note also that checkNullCursor wants to concatenate the tag and the label, so you should shuffle the internals of `checkAndLogCursor` to reuse `logLabel`.

We can't do better than this: we can't push `queryStart` anywhere else, and we can't abstract the cursor creation in the two methods without introducing another layer (such as a `Runnable` to delay execution).
I had to send PDFs this afternoon and made some updates to the framework so I could stay within ColdBox. Please let me know if you have any questions.

Thanks.
`y.year_string` would be more idiomatic Ruby. I'll go put that in place right now.
Do you think its better to keep the one yum_clean action but give it options?

Something like:

   mco rpc package yum_clean mode=all

and then if you dont specify mode let it default to this new way?  or maybe make the default configurable?  I think this might be better and doesnt pollute the agent with a lot of kind of related actions?
(It's a totally different commit now though, not this one you see up here.)
in the newest version, this problem has returned.
"Lots of stuff"? That's all we're going to get? Did any of this stuff fix anything?
It's weird. I wonder where these came from...  I tried using these in cm9 to see if they would make a difference and when I pushed them over, my phone would no longer boot.
That's what loadMetadataFromPom lets you do. It will read dependency info from the pom and store it internally. If you request a groupid:artifactid it will supplement that with the version found in the pom. But not sure if it will override with the version found in pom if you give it a full expression groupid:artifactid:version. @kpiwko should know.. :)
Thanks for finding this! I've actually got a fix in jquery.fix.clone;
I've just put deprecation notices in the older repositories to reduce
confusion.

2012/1/17 clst <reply@reply.github.com>:
> This does not work in jQuery 1.8 for me.
>
> This does:
>        my_textareas = this.filter("textarea"),
>    result_textareas = result.filter('textarea');
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/spencertipping/jquery.fix.textarea-clone/commit/67542deeb01b25968026faaa314814ff07246249#commitcomment-874445
@ohadlevy @jeffmccune I agree on 'we should handle all of the correct logic in save; not override create()' .  Currently  vSphere::Server can stand for both VM and Template.  It's great to add a templates collection and related requests (new_vm, clone, ...).   

If we all agree on this,  the following work will be done:

1) remove server.create() but add save() to create a new blank VM
2) modify server.clone() to create a new VM by cloning this server(or say VM) ; server.clone() will call connection.vm_clone().
3) use connection.vm_clone() to create a new VM by cloning the VM specified in the param (params now has template's full path and newvm's name)
4) [tentative] If VMware Tools is installed and options['power_on'] == true and options['wait_for_ip'] == true , we will wait for ip to be ready. 
5) [tentative] define how to implement ready?() 
  5.1) For VM:  the VM is poweredOn or VM's IP is ready (when poweredOff, IP is empty)
  5.2) For Template:  the Template exists (I guess in this case ready?() will always return true)

Thanks :)
Nitpick; You should indent this line 2 spaces, such that it looks like this:

<pre>
* define an attribute `location`, which is itself an object
  defining two attributes, `x` containing the longitude value
</pre>
I had overlooked the duplicate. The setuptools command has been working for a while and other support code has been getting all the attention. Would be happy to rename or alias the build command and accept a docs patch. 

Marcus Smith <notifications@github.com> wrote:

>> @@ -20,6 +20,18 @@ class InstallCommand(Command):
>>  
>>      def __init__(self):
>>          super(InstallCommand, self).__init__()
>> +        self.parser.add_option('--use-wheel',
>> +            dest='use_wheel',
>> +            action='store_true',
>> +            help='Find wheel archives when searching index and find-links')
>> +        self.parser.add_option(
>> +            '-w', '--wheel-cache',
>
>more important than bikeshedding the parameter name, I'd personally prefer a very literal help message so people know what this is really about.
>
>help = "Run 'setup.py bdist_wheel -d DIR' prior to installing distributions.  The "wheel" package is required to build wheels."
>
>btw, does it work for setuptools commands to have duplicate short form arguments?
>there's 2 "-d" parameters?
>https://bitbucket.org/dholth/wheel/src/a4ab096e2a91/wheel/bdist_wheel.py
>
>---
>Reply to this email directly or view it on GitHub:
>https://github.com/pypa/pip/pull/651/files#r1570385
This is presentation, you're right. Spot on.
I'm not totally happy with the overloaded `err` argument. I noticed this feature in Express.js, and see it being very useful, and `next('route')` looks nice. But this ended up being hard to document, so that signals something isn't ideal with the API.

I'm open for suggestions on a better API for this feature.
The extents of the iterationspace, that they're a tuple is an implementation detail I think
Let me push a patch and we can take it from there.
How will you collect this?
ah, good point, I would make it a `lazy val` instead, and use actorFor
I can only agree, I'll take a stab at it
they are true from beginning (phi = 0.0) so that would not verify much
could be used for the `must be (false)` case in the next case, but we might want to check that first and second are not affected anyway

I can reduce the length of the sleep here and use awaitCond in next test - that is a good enough compromise
renamed all options
Well, I can give you a future which will eventually (and IMHO very probably) evaluate to not breaking anything (sensible), but you know ...
How does this handle asynchronous backends?
If there is a multi-line case statement I usually add spaces after and before it. I remove it  if that is not the preferred way.
Search is only generated for the online docs :)
to avoid this compilation message.  I'm probably missing something obvious here, but I'm not sure what it is:

[info] Compiling 1 Scala source to /Users/jstanford/devel/github/akka/akka-amqp/target/classes...
[error] /Users/jstanford/devel/github/akka/akka-amqp/src/main/scala/akka/amqp/FaultTolerantChannelActor.scala:126: could not find implicit value for parameter executor: akka.dispatch.ExecutionContext
[error]       channel = Some(Promise.successful(ch))
[error]                                        ^
[error] one error found
Ah, that's why you didn't want to support indexing--because all the fits have to implement it?
This is a really neat and concise way to test all the auth rules, super easy to read and to add new auth tests
I think the test you're suggesting appears immediately below this comment. :)
It would be great to have doc blocks in this class, especially to describe the "failure_threshold" parameter.
Something I forgot to mention in the code review. We try to use "get" to imply raise an exception if it doesn't exist and "find" to return None if it doesn't exist. This is the behavior you have here; I'm not saying to change it, just mentioning that it's a convention we try to follow (still a bit inconsistent).
used in mry TestDatabase
This could be merged with the #elif defined(TARGET_LINUX) ... on line 38 i.e.

#elif (defined(TARGET_LINUX) || defined(TARGET_FREEBSD)) && defined(HAS_GLES) && defined(HAS_EGL)
imho, m_fileSize = m_filePos + uiBufSize only.
I think [[ is a bashism - how about if 

```
test "$2" == "-f"
```

 instead?
Ao invés de 

   #if ( $auth.ShareBank )

deve ser 

    #if ( $auth.AllBalances )
Hey palash-baran, could you remove unnecessary lines instead of comment them?
其实是 the base directory of data
Can you explain why you are making these changes? I am not sure I understand the improvement here.
No problem ;). Actually it took me a while to understand the os.walk
function :P.

On 29 Nov 2012 14:38, xeor wrote:
>    In taggo:
> > @@ -176,6 +177,9 @@ class Taggo:
> >              count = 0
> >
> >          for root, dirs, files in os.walk(self.content_folder):
> > +         if self.ignore_hidden:
> > +                     dirs[:] = [d for d in dirs if not d.startswith('.')]
> 
>    Hi, sorry, I was too quick on this comment. This works as advertised..
>    :)
> 
>    —
>    Reply to this email directly or [1]view it on GitHub.
>    [INLINE]
> 
> References
> 
>    1. https://github.com/xeor/taggo/pull/1/files#r2272131

-- 
Enric Caussa Morales
<me@enric.me>
'--print-args' should be invisible by default, and action='store_true' can be used.
Please use the initializer list to initialize the member variable, like done with `mMap`.
Hmm, I think this is correct.  If IE, check if we're served from http/https, if yes, check if we're inOrigin and return XDomainRequest.  If no, it falls out of the if and returns XMLHttpRequest instead.

If IE and served from file://, use the ActiveXObjects.
NOW STRONGER.

On Tuesday, November 13, 2012 at 11:01 PM, galaxas0 wrote:

> In ExampleProject/Example/ExampleView.h:
> > @@ -17,13 +17,9 @@ > #import "TUIKit.h" > #import "ExampleTabBar.h" > > -@interface ExampleView : TUIView <TUITableViewDelegate, TUITableViewDataSource, ExampleTabBarDelegate> > -{ > - TUITableView *_tableView; > - ExampleTabBar *_tabBar; > - > - NSFont *exampleFont1; > - NSFont *exampleFont2; > -} > +@interface ExampleView : TUIView <ExampleTabBarDelegate> > + > +@property (nonatomic, retain) ExampleTabBar *tabBar;  
> Strong!
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/github/twui/pull/140/files#r2120787).  
>  
>  
>
Saying "unimplemented" here could lead a person to believe that this is incomplete. If you want to leave a comment in, please make it more clear. For example:

> Implemented by subclasses
This needs documentation.
Yes, just redeclare it here with the new type you want, and then use `@dynamic` in the implementation (remove `-tableView` and `-setTableView:`).
Please add a license notice.
yep, think i m isunderstood the param, done!
Looks good but do you mind saying what the exit status was as part of the exception? Thanks!
may want to put STDOUT and STDERR in <var> tags throughout
How is this lazy?
I don't know. But since it works I'll prefer not to  touch it.
скобочки фигурные
Can we use `value.blank?` here?
You're right: present? will work fine, too. I was matching the style in other parts of Active Record that use .any? without a block. Anyone else want to weigh in or is there a discussion of when to use which? I'm a "present?" guy myself so I am happy to change this.
`true`.
You don't need to. I'll merge this and cherry-pick with the CHANGELOG message that you added here.

But we will need to wait the 3.2.9 release to backport it.

Thanks
Shouldn't we override `createNewEntry` here and use that?
Feel the calm, pure clarity washing over you.
Get it, "apparent"
See the comment to CaseDef
case TypeRef(_, ExprClass, runtimeType :: Nil) => runtimeType
Note to self: we should change this to a modal box with links instead.
I updated the comments.
The call signature changed. This might interfere with `Spectrogram.__getitem__`
I would just use LT, and modify the output (e.g., using `expr.as_coeff_Mul`) if you want to drop the coefficient.
Nope, it's not :-)

By the way, it is not possible to create a `Morphism` anymore, yet this function is used by `_print_NamedMorphism` and `_print_CompositeMorphism`, therefore I have left it here for now.  If having such a function is not OK (after all, `Morphism` can never be instatiated), I'm not sure what would be the way out.  I obviously feel against duplicating the functionality in the two functions.
It is due to the order dependency in the helper `_split_gcd` function: with this docstring:

    split the list of integers `a` into a list of integers a1 having
    g = gcd(a1) and a list a2 whose elements are not divisible by g

In [19]: _split_gcd(3,6,10,5,15)
Out[19]: ([3, 6, 15], [10, 5])

In [20]: _split_gcd(10,5,15, 3, 6)
Out[20]: ([10, 5, 15], [3, 6])
Seems odd to have this outside of a class. Can it be put in as a class method for Partition? Can it be used to construct IntegerPartitions?
Should be `SingleRightAnglePrism` here, as this is how your class is called.  I'm afraid I must conclude that you haven't run all the tests.  In most friendly way I recommend always running your tests before submitting the pull request (joining Stefan words in this regard).
The subs doesn't work...that has to be tested and fixed later today.
when you repeat code for several times, there is always possibility to make it shorter, e.g.

```r
if(is.null(w <- options$out.width) && is.null(h<- options$out.height) &&
  is.null(s <- options$out.extra)) {
  return(sprintf('![%s](%s%s) ', cap, base, .upload.url(x)))
}
# additional styles require the HTML syntax
add = paste(sprintf('width="%s"', w), sprintf('height="%s"', h), sprintf('style="%s"', s))
sprintf('<img src="%s%s" %s alt="%s" title="%s" /> ', base, .upload.url(x),
        add, cap, cap)
```
Yep, from Abstract:

function addEventToStorage( event, method ) {
        _.each( event.trim().split( /\s+/g ), function( item ) {
          eventStore[item] = { method: method };
        } );
      }
Ah I didn't realize build isn't supposed to persist the new association object.  How does its id get set then?  Seems like it can't ensure that the id it's claiming isn't taken by something else if it doesn't persist the new association.
What do you need to include `<unistd.h>` for?
Этот метод убрать вообще
Тут все таки foreign_key не member_id, a user_id. Смотри db/schema.rb:
```
  create_table "event_members", :force => true do |t|
    t.integer  "user_id"
    t.integer  "event_id"
    t.datetime "created_at", :null => false
    t.datetime "updated_at", :null => false
  end
```
Delete lines 13,14,15, and change line 12 to 

    credit = f.object.credit || 0
done

On Wed, Apr 25, 2012 at 11:10 AM, Manuel Ebert
<reply@reply.github.com>
wrote:
>> @@ -357,6 +357,10 @@ def autocomplete(text, state):
>>      else:
>>          with open(CONFIG_PATH) as f:
>>              config = json.load(f)
>> +        if not 'highlight' in config:
>
> Maybe make it more general?
>
>    missing_keys = set(default_config).difference(config)
>    if missing_keys:
>        default_config.update(config)
>        with open(CONFIG_PATH, 'w') as f:
>                json.dump(default_config, f, indent=2)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/maebert/jrnl/pull/17/files#r731334
outputted.
probably not minor?
yes. but it's hacky: 

the solution is to add something to the rst epiolgue variable (which is a string in the conf.) make a jira?
Git GUI…

The GUI I tested it in worked fine, lol.

I'll fix that, then xD
why are you not prefixing the columns like we do in the rest of phpbb?
We have user_location and stuff. just use item_read, item_time and item_data (or notification_* depending on whether the column is for the item or the notification)
Allow remembering logins
Done. I also found that I used OR instead of AND in one point so its good that you asked me to do that. :D
Reduced to 18 dom traversals as '_hot' and '_hot_mine' only exist for topics.
gen -> generate?
Hmm... that makes this more complicated then. I'm not sure then how to do this. Would a for loop that runs a DELETE query $remove_amount times to remove the last $remove_amount revisions be acceptable?
Never mind, don't know why I bothered to commit in the first place.
Call the class and file host info instead of info? I don't care that much but it maps to the protocol.
Will this bite you when the difference between cwd in testing and production is realized?
Please add a blank line here. Also I guess its worth mention MIT license here:
Yage is licensed under MIT license, see COPYING for details
This comment should really be a comment introducing the cache() method (plus add yuidoc tags).
id should be 'inadyn' since you're using that ID on line 28. Otherwise, backup will not work
This is an error with MSVC9 (VS2008) since `nLabels` is not a constant; use new and delete instead.
Public property is missing XML comment
Also, since null == "", I don't believe you even need the ```if``` check.  Setting the text's value to null might not hurt anything?
Mapping is good - we should start using mapping rather than id's in the model array. This is cool.
I don't understand how this can pass.
~~I must be making a mistake~~, so may remove this comment...
This line seems to be comparing the *forecast period* with the number of seconds in the *forecast period unit).
I wonder if its worth having a "bugs fixed" section...
Does the grad method ever check for the case where both inputs have integer dtype? In this case, the output will have integer dtype too, so the gradient with respect to the inputs should be 0, since (x+eps)*y = x*y.

This pull request doesn't introduce a problem in that respect, I just noticed that now while reviewing it. Are there no tests of the grad method using integers?

It's probably not a particularly dangerous bug since the grad method will raise an exception if the op's grad method does the wrong thing in this case.
I don't understand that part (and it's not your fault). Someone else should review / clarify it. @nouiz / @lamblin / @jaberg?
Given that this if/else statement is how rankUpper is always called (except for tests that could be changed), simplify the callers by replacing rankUpper with an overload of rankAsc that takes the isUpper argument and decides how to call the single-argument rankAsc. The new function would combine this if/else with the logic now in rankUpper.
This is needlessly costly, traversing all domains each time. And wrong (e.g. matches ``10.197.10.in-addr.arpa`` when searching for ``110.197.10.in-addr.arpa``).

Alternative:

```
parts = name.split('.')
superdomains = [".".join(parts[i:]) for i in xrange(len(parts))]
domains = Domain.objects.filter(name__in=superdomains).extra(
    select={'length': 'Length(name)'},
).order_by('-length', 'name')
if domains.count():
  return domains[0]
```
Display links to the duplicated devices in the message.
Just worried that these functions would have been expecting the context to be the route now it is the di container
`function page_path() {`
And another user makes changes, because he have smaller/bigger screen))
If you don't call srand, the random number sequence is the same for each call. right?

I want different random number sequence for each call. Please refer to http://cplusplus.com/reference/clibrary/cstdlib/srand/.
Sure, but there are some C++ peculiarities to keep in mind.

I would have to look up how C++ treats the case when only a base class of `LinearRegressionAccumulator<Container>` contains `operator=(LinearRegressionAccumulator<Container>&)`, but not `LinearRegressionAccumulator<Container>` itself. Does it do an element-wise copy then, or would it (only) call the base class's `operator=`? If the first, an `operator=` in a derived class will always be necessary. If the latter, we could get rid of the derived class's `operator=` implementations.

In any case, the base class would also need `LinearRegressionAccumulator::operator=(LinearRegressionAccumulator<OtherContainer>&)`. In order to allow that, one could give `operator=` in `DynamicStruct` another template parameters, and require derived classes to implement something like the [`rebind` in STL allocators](http://en.cppreference.com/w/cpp/concept/Allocator).

So far, reducing the 2-line implementation of `operator=` in derived classes has not been enough incentive for me to look into this a bit deeper. But I will (after my vacation). But even in the current implementation, note that there is no logic in `LinearRegressionAccumulator::operator=` but it only calls the Base class's `copy` function!
If it really only works if both are there let's just leave a comment.
In a nutshell whenever you hit an oauth API you run the signing algorithm that you'll find in this package. So if you want to implement a twitter client with meteor (maybe a bad example because you'd probably just use accounts-twitter) you'd have to sign requests to get non-public data or post to the user's feed, etc. Same thing with oauth2 except it's a little simpler because you simple add the access_token to the url when you hit the API. But the example plays out for Facebook also. Would be nice to leverage all your auth2 code so people can hit facebook's api even when they aren't using facebook-accounts.
Looks good, but why is the method called RefreshToClient() when it only relates to gold? and do you need to leave in the commented code?
Add a return for the else case please.
On 26 April 2012 07:43, wonk
<reply@reply.github.com>
wrote:
>> @@ -0,0 +1,118 @@
>> +require 'formula'
>> +
>> +class CouchDB < Formula
>> +  homepage  'https://github.com/apache/couchdb/'
>> +  head      'https://github.com/apache/couchdb.git', :using => :git, :tag => '1.2.x'
>> +  url 'http://www.apache.org/dyn/closer.cgi?path=couchdb/releases/1.2.0/apache-couchdb-1.2.0.tar.gz'
>> +  md5 'a5cbbcaac288831b3d8a08b725657f10'
>> +end
>
> Thank you for the tip.  Formula updated.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mxcl/homebrew/pull/11659/files#r737087

Works for me.

A couple of suggestions -

add how to run the geocouch tests
clarify that this borks your couch install (but thats not really an issue)
add a note on uninstalling - seems sufficient to rm
/usr/local/etc/couchdb/default.d/geocouch.ini  and stop the launchd
plists

A+
Dave
Ok, should I made a new commit?
supprimé.
Weird. I did a search and replace. Somehow some of it must have been undone?! Will fix obviously.
And by fullhash I obviously mean full*name*.
This means that `jargs` depends on `junit` in the test scope, which it does in order to run the tests :-)
Is it possible to move this code outside of the `try`? Is it guarding against anything other than the `int()` failing?
Could there be an option ([`SupportedOptions`](http://docs.oracle.com/javase/7/docs/api/javax/annotation/processing/SupportedOptions.html)) to turn it on/off?
Use `Blaa &operator=(const Blaa &)` in this and other applicable commits for consistency.
Probably, I didn't modify this code.
This construction is too complex.... should perform the transformWithRules on a separate line so that in future we have a better opportunity to trap errors in this process - also more debugging-friendly
remove these lines as we need to keep the same view in different yields distinct
It's trying to pull the adapter out of the global namespace, so it's gotta start with window. There may be a core dojo function for this.
Why would source be called 'main'? Is `source` just meant to be an identifier? If so, what's the convention? Since this is a tour, should it be 'tour'? Can it simply be inferred from the Adapter name?
fixed this one too.
It looks like you removed the extra line at the end of the file. It should work ok, but I am curious why?

I find editing easier with an extra empty line, and I have run into very rare cases where it did cause a problem, so I always make a point of having an extra line at the end of each file.
Ok, I see -- my suggestion isn't sufficient because closeFullEditor() is relying on FILE\_OPEN (of the no-longer-existing file) to switch away from the closed file's editor.  FILE\_OPEN notifying that the next file was deleted doesn't substitute for that, since notifyFileDeleted() only touches the editor if the _deleted file_ was open in the editor.  It has no idea about the pending close operation that wants to get rid of some _other_ editor.

I still believe #1451 is a change we should make, but it indeed doesn't help with anything here.  Sorry for the confusion.
@RaymondLim: I'm still curious about this -- do we need additional code in order to cover the variant of this case where there's _no_ whitespace token to the left?
I worry that these more generic labels could be confused with navigating Find results, etc.  Not sure I can think of a better wording, though (other than something long winded like "Next Quick Edit Match")... so maybe we'll just have to keep an eye on it.
Same with this, ``} else {`` on one line.
Just curious, where is the default width before your changes? How do you come up with this specific pixels?
yes, and old versions are monkeypatched in server.js, so that's ok to remove this line, and not add anything in it's place?
This is unnecessary I think, when you now have a file with a quote in it it shows the escaped text in the tab.
setCurrentFilterValue is not part of the ActiveFilter contract. It seems to be present in the implementations (fortunately), but it's not forced by the abstract class itself.
No, *wlan slovenija* is not translated, it is the name.
I am giving up too, what the hell was wrong now. I didn't change any other feature, just did what you said. And I don't see any harm done in making more features (if you don't like them thats a different story). How can it be simple, if whatever I did you said fix this and this, and when I fixed it, everything was wrong. I am afraid to start anything now. :)
It should be consistent.
What is link is undefined here? I'm surprised I'm not getting console errors on opening a editor for a new image.
Not really necessary to gather them all here. You can if you want to though. I'm just talking about the tab spacing. Just trying to keep them all in line. Let me find an example...

Got one: https://github.com/mozilla/butter/blob/master/src/main.js#L42
Too many spaces after `[`.
I think this might be redundant. On 185, it attempts to use "default-icon", which is specified in the config and inserted into the page via butter. Added this ticket to help: https://webmademovies.lighthouseapp.com/projects/65733-popcorn-maker/tickets/1082-simplify-config-by-selecting-generally-sane-defaults
Replace first two spaces with '//' for this and previous line, so the code will not be invoked in dev environment. Pre-processor will remove it
What I meant that all fillXXXXAnnotationOperatorList functions can be combined into simple ['startAnnotation', annotation operators, 'endAnnotation'] sequence and let canvas.js or (viewer.js) handle the lineTo/moveTo/clipPath primitives.
Good catch. I don't think we need to scroll anything in fullscreen view -- let me disable this function for that mode
这里是不是再判断一次，如果用户的顺序文件没有写完整的话，就找不到顺序列表了。
ham arz ham dir ro bar dar niyazi nist
related to line 67: we could lack for shorter amounts of time if we release the lock during getAllDomains
This is actually pull-over from another controller.  Many of the UI controllers currently use the notation.   That said, I don't believe it will be needed, so will update it in the next PR, if that's ok.
Parens would be nice here too. But again, not totally necessary.
Are you returning Javascript from the controllers anywhere? Other, I think you want `:json` here, as `:js` can lead to some unexpected issues.
Sorry about that - it should be a one-time thing to go along with the changes to the install script. In fact, I plan to remove it once it's used.
Well, the old selector went after all <pre> elements.  However, prettyprint only is needed in cases where the <pre> has a <code> element child.  The new code uses a selector to do that, but that selector gets the <code> elements that have <pre> as a parent.  The .parent() method gets back the set of <pre> elements that need the css class.
Yea it looked outdated when I saw it, but when I followed the link I got an index out of bounds asp.net exception. I added another commit with the updated url, which doesn't have the space problem.
Yes, only on startup
Exactly that :)
It works the same as before - I just centralized all the reflection-related things and this method operates on a collection of ActionDescriptors, instead of raw MethodInfos.
false is the default value now for addEventListener, you don't need to explicitely add it.
Done.  Nuetrino -> Neutrino also fixed.  Don't tell my wife (a neutrino physicist).
On 26-Sep-2012, at 7:44 AM, Thomas Robitaille <notifications@github.com<mailto:notifications@github.com>> wrote:


In astropy/cosmology/core.py:

> @@ -87,9 +91,11 @@ def __init__(self, H0, Om0, Ode0, name='FLRW'):
>            Omega dark energy: density of dark energy in units
>            of the critical density at z=0.
>
> -        Ok0: (float)
> -          Omega curvature: equivalent curvature density in units
> -          of the critical density at z=0.
> +        Tcmb0: (float)
> +          Temperature of the CMB in Kelvin at z=0 (def: 2.725)
> +
> +        Neff: (float)


Here and elsewhere, the type shouldn't be in parentheses (I know it was already incorrect before this PR, but if it's easy to do, maybe it can be fixed here?)

—
Reply to this email directly or view it on GitHub<https://github.com/astropy/astropy/pull/365/files#r1695295>.
Oh. All these `.keys()` calls are unnecessary.  Just use `'foo' in kwargs'`.
The URL stuff in here was actually just added as a secondary feature, but the compression stuff seems to be different from what's in ``config.get_data_*``. How about having this general function (without cache support) in ``utils``, and then have ``config`` use as much of it as possible to avoid duplication, and add the cache stuff? It somehow feels more natural for ``io.votable`` and ``io.ascii`` to use a file-reading utility from ``utils`` than from ``config``...
There are a few reasons for this:

1. Most of these functions give quantities that generally aren't mentioned in reference texts, which instead define the (sometimes confusingly-named) angular diameter distance, proper motion distance, absorption distance and so on.  So to me it makes sense have a method for quantities that are generally referred to by cosmology reference texts, and things like `kpc_comoving_per_arcmin` as functions. (The `distmod` function is an exception to this.)

2. I think it's more intuitive to use a function to get these values, especially from the interpreter. Doing 

 ```
 from astropy.cosmology import * 
 kpc_proper_per_arcmin(3)
 ```
 is quick and easy to remember if I just want to quickly check a value (in, say, a talk, or when reading a paper),  rather than first being forced to think about the cosmology I want.

3. Making it a function indicates to the user that this is a commonly-used task, and so makes it easier to understand how they should use the package.

I admit for points 2. and 3. it's a judgement call which tasks you want to include as functions. But the current list is pretty short and I hope uncontroversial, and more can be added if it looks like they're needed.
This is supposed to be ``self._excepthook_orig``, right?
use _destroy_delete() for logical delete models.
https://github.com/jeremyevans/sequel/blob/master/lib/sequel/model/base.rb#L1490-L1495
It's the "Legacy" argument to this function that's got to go.
Is this code path ever followed? I mean, will an unsigned integer ever be larger than (unsigned) -1?
You're right. It sucks that `connect(mapper, SIGNAL(viewModified()), ui, SLOT(setEnabled(true)));` is not possible.
following this I should then move it to the bootstrap as the CacheDispatcher is an adapter and therefore app concern, right?
just out of curiosity, do you have an url to a reference/documentation for that syntax ?
You may want to couch this delete in a check for whether the commod_ has been set to anything during the course of the sim.
Instead of using and if...else, why don't you build and array of properties and then just implode?
the wording here is confusing. the actual thing happening here from an isolated perspective is that an event is getting fired, not activity being created. same applies to the other tests in this area.
if you render piece by piece, you are still free to not render all in all places. if you specify the class here, i think this adds no flexibility as to what should be rendered, in the contrary. you could have 2 RDF types that map to the same class.

but before, the controller was a RDF type name, not a class name, so using the class would change things. expanding the namespace also changes things to some extent, but i think it is the only possible way to properly support namespaces (somebody could need to map a NS to a different prefix for namespace collision reasons - this is the reason for the NS vs prefix stuff)

when we use the RDF type to create new objects (with the VIE type stuff), i think there is no sane way to have multiple classes mapped to the same rdf type (which would be the only reason to use class and not type here)
Not following you, why is `mv` relevant?

On Tue, Oct 2, 2012 at 2:00 PM, Bussonnier Matthias <
notifications@github.com> wrote:

> In IPython/nbformat/v3/jsonpointer.py:
>
> > @@ -0,0 +1,222 @@
> > +# -*- coding: utf-8 -*-
>
> Because mv != git mv ?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/ipython/ipython/pull/2396/files#r1743857>.
>
>



-- 
Brian E. Granger
Cal Poly State University, San Luis Obispo
bgranger@calpoly.edu and ellisonbg@gmail.com
neat trick. learned something new today.
done!
looks like you could just use SmartOSHost directly as opposed to wrapping it through SmartOSManager.  It will be easier to understand and less code to manage.  Mind unwinding that?
We no speak this kind of language.
This could just be ``if (trigger_id) {``. If it's undefined, it will return false.
s/DROP/TRUNCATE
If we let these bubble all the way up, then won't a single bad directory cause the whole run to be aborted?

I think we need to handle any reasonable exceptions either here, or perhaps more reasonably around line 127 (in run() )
you could eliminate at lot of copied boiler plate if you were to derive from socorro.app.generic_app.App instead.  The required_config that you've defined here and in your `run` function could be combined here.  You'd define a `main` function in your that would have only the decision block of lines 565-573.  The `main` function of the generic_app module would instantiate your app class for you, and even create the config context for you.
The purist in me in screaming. If the application can't even connect to the database, it's just wrong that it reports 0 crash hits. It should either be a 500 error on the server or an error JSON structure sent back.
`return redirect(request.path)` would also get you where you want to go
The contents of `getUsers` need to be un-indented by 2 spaces I think. Except for the lines `users = {},` and `lines, both, i;`

By convention, all variables declared in a function are declared in a single `var` statement, where all lines beyond the first are indented by 4 spaces. Where you put the line breaks is sort of up to you, but I like to put each initialization (variable that is assigned something in the var statement) on its own line, then all others on the next line (or the same line if its very short), so it looks something like:

```
var contents = fs.readFileSync(filePath, 'utf8'),
    users = {},
    lines, both, i;
```
This requires an alternative solution.

Currently it won't be possible to implement a funcion DisconnectFromAllServers(), since local state is remembered for each disconnect attempt here.
@jcredding please add `, :params_value` to this OpenStruct comment for me please.
This is useless. The container is already available during the boot if you inject it through its setContainer method (which is what Symfony itself does).You should probably do it the same way
Aren't you ignoring the possibility that s might have a pitch which isn't equal to w, here?
that's not how it's done
besides, everyone knows it's spelled "bucket", not "bukkit"
no such thing pls
@Tobion you cannot do it. This PR makes it extend UrlMatcherInterface so it has to respect the contract of the UrlMatcherInterface otherwise it is simply broken.
I don't see the relation between the fact that you turned the gradient and the fact that the W3C syntax is missing.
this is confusing IMO as ``$process`` does not contain the Process object but the status code.
And btw, it does return a catalogue to allow for further potential customization.
Yes. We only need to check, that string begins with a dash followed by a space. This is now done with `strpos()`.
Is there an upper bound on the length of a string? Can I assume that the size will never need to be represented with 8 bytes?
Just a note: JS files are static and thus do not support translations which needs to be dynamically processed.

The error message above cannot be translated. You need to put the message into HTML output so it can go through gettext translation.

There are basically two solutions;

- Render a JS code snippet in HTML output which sets some global variable (object) with the translated text, see e.g. https://github.com/SUSE/slms/blob/master/yast/webyast-slms/app/views/slms/show.html.erb#L34, there are more texts grouped together for better readability. You can also store some global variables there.

- Render the error message in HTML into some hidden tag, move the text content via JS (jQuery) when needed.

(I'd go for the first solution so it's consistent. And it does not pollute the document tree with unnecessary nodes.)
I like this idea. @adarshpandit  suggested a similar approach that actually passed in a strategy. Either works for me. This is slightly simpler, so I'd say we go this route.
Pretty sure we wanted this removed (3073c60c80b3a2d9f4557d1f6e12d1c3b32e8ba3)
This syntax confuses me.
what does short tags do? i dont see a description or specs for this.
What do you think about creating a Cloud model?
```ruby
cloudfile.clouds.each do |cloud|
  cloud.databases.include?('postgresql')
end
```
This can now be removed I think?
To capture the most up-to-date info if it's submitted?

I can imagine the scenario where somebody changes their job title or phone number (maybe it's over-engineering).
I know we don't have a published style guide (yet), but notes tend to be either div notes:
  <div class="note">my note</div>
or italic
  *my note*
not parenthetical.
Are you just checking for a match here?  If so, you can do this:

```ruby
if line =~ build_string
  ...
end
```
Reference based types as defaults is a very bad idea since they get shared by all instances. We got bitten by this a few times.
Normalement tu n'as besoin de ce fichier... Je merge quand même, je le supprimerai après.
Always spaces. There's an exception for `({` when an object is the only parameter, but that's not the case here.
Can you open an issue for that and reference it here.
yes. here I will update some strings on UI.
Declare |length| here, you don't use it before. Generally you should avoid C-style declaration with a huge block of variables at the start of the function.
After confirmation, we would need to email dev-gaia to people and stress AGAIN how to specify font properly...
I talked to @jcarpenter today and he said that the homescreen edit mode would be done with contextmenu events on the icons themselves rather than on the homescreen.  So my understanding is that we can just use contextmenu anywhere on the homescreen (but not on icons) for wallpaper.  That makes more sense, really.  I don't like the idea of being able to touch and hold the wallpaper on some screens but not on others.
`airplaneOff`
Is there any direct way of getting this element just with a query selector? If not, it's not a problem at all, was just wondering :)
var application = document.location.protocol + '//' + document.location.host.replace('system', 'settings');
specifically, we didn't want `http-browserify@0.1.2`, since it requires node 0.8.
I believe this is dependent on #199 being implemented.

Also, I think you should also handle the case of getting a regular byte array too.
why use ``__import__`` over ``import_module``?
Before the change in FakeRedis's char handling `hset()` left `None` as `None`, now it'll turn it to `"None"` which the `int(result or 0)` is not happy with.
Ignore case for comparing hosts ?
Note that ``self.task_subord_face_v6`` is NOT included, as we didn't use Face V6 Task for the HvM paper.
Should we define properties for maven-project-info-reports-plugin and maven-changelog-plugin as well? What about defining the convention that we always use properties for plugin versions to facilitate updates?
This method is useless.
generally, i do sep PRs. however was trying to get this project cleaned up in a nice sweep.
trans block
Why use string interpolation for the section_name as opposed to just using the return value directly?
Note that put doesn't count as an access -- it's just used to update the value to which the key maps (making it kinda useless, but it seemed useful once, when it was added).

I think you'll want to do a `get` here?
you should check the exit code of the process to provide some error management if building the archive failed
Sorry, I found it. Please ignore my comment here.
Eagle eyes :mag_right:
Don't need this line now
Very Crockfordian, but constructors should start with a capital, so: new Swipe()
A more useful comment would describe what this block is trying to accomplish; save the `@Bug(15634)` for the test case.
Maybe use `closeTab` form [tab/utils](https://github.com/mozilla/addon-sdk/blob/master/packages/api-utils/lib/tabs/utils.js#L45)
In that case could you please add comment saying that it may be `null` in some cases.
I'd rather throw with such error message in `resolve` method. And assume that `resolve` either return an uri or throw.
(we can keep this check too and use a more generic message like `can't resolve/load this module`)
"good"?  not sure, but here's what exists:  https://github.com/lloyd/awsbox/blob/master/doc/SERVER_LAYOUT.md#the-proxy-user
Same here. Or remove the declaration in line 50.
Column "name" has not to be removed
This is not gamma!

Gamma is Sqrt[1 / (1 - (v / c)^2]

I understand that you do not do the division but rather divide by gamma in the solvers, maybe that increases accuracy so its fine but you are definitely missing a minus sign there!
https://en.wikipedia.org/wiki/Lorentz_factor

If this is intended pelease add an explanatory comment.
can you put the first argument in a `$expected` variable?
I created `Puppet::InvalidTypeError` and `Puppet::InvalidFunctionError`. I placed both classes in `lib/puppet/error.rb`.
Should I relocate them to `lib/puppet/dsl` directory and rename to `Puppet::DSL::InvalidTypeError`, etc. to make them DSL specific?
IMHO Is best have the hexadecimal characters in uppercase
Everything should be indented with 4 spaces and not 2
(fixed thus far)
Netbeans... added four spaces
this does not look like plain English
Cause that's how the request object looks like when you use Form::create() in a submodule :(
Micro, but I guess you don't really need key here, right?
if(req.socketId !== socketId){
Now all of these ```self.assertEqual("OK", self._check_zip_response...)``` can simply be:
```python
self.assertTrue(...)
```
Could you remove this extra blank line, so that we can keep up on PEP8?
do you really need the second FROM in this test ?
import order should be alphabetical
Can we remove commented code
Ok, but it needs to be a lot clearer that it's an alternative.
hmmm... not sure about a test that doesn't have any tests. is there nothing you can assert? I see what you're doing, I'm just not sure it's a test.