labofsahil/github-event-dataset-2012 huggingface dataset:
Does it make sense to use the same role name for a node started on another address? If that is the case we should definitely not add this cache.

As next step I would prefer that we use role names in the tests instead of mix of address and role names, that's why I added the implicit conversion as suggestion towards that. Lookups can be done in tight loops, such as awaitCond. Of course one can cache that locally in a val, but knowing that it's no cost to do `node(role).address` means that you don't have to think about that part.

If you think it's a bad idea, and I have no problem with that, we simply don't merge this.
Oh, the lib/authenticated_* needs to be merged into whatever becomes of this.
This might be a heretic question, but... couldn't we just (offer to) attempt to repair this from the script? Perhaps after some extra sanity testing, e.g.
   /usr/bin/file /usr/bin/pod2man
should indicate that the file is a
  perl script text executable
?
i would actually prefer to have all images store themselves in `images`. let this be `True` (ie. just call the method, don't add `True` ;-) and move the `icon_calendar.gif` to `public/images`
intentionally still warning?
I thought this would be more future proof in case we have to add more of these special cases. I went with the boolean approach in VideoLibrary.cpp and it's getting a bit confusing.
Why does this have to happen here? What if the call to CommitTransaction() fails and throws an exception? In that case the movie wouldn't have been removed but the announcement has been sent out.
where would it live?
That's what we've done with the python repo: if you don't have any interest in the previous history, then yes.

BTW, we could add to the README a support section pointing to the issue tracker, the mailing list and the campfire room (cf. python's readme).

BTW2, it was me who had the idea of naming the repos just with the name of the language, but i'm not sure it was a good idea... i thought bigmlcom/python was neat, but the problem is that when people fork our repo it appears in their list simply as "python," which can be confusing, i guess.  

If you think that's a valid concern, we're still in time to change the repo name for the R bindings (after our HN hit for the python bindings i'm afraid it's too late for that one...)
Shouldn't this be string_type not string_name?
I don't know how I feel about this plugin.
delete me too
I selected those because it did not find `2.1.*` anymore and I don't have time to find out why.

Send a pull request to fix.
merge w next line
see wand.image before first class
This should probably be an assertion instead of an exception:

    NSAssert(fabs(attributeRange - sourceAttributeRange) < 0.001, @"Invalid source and target attributes: %f, %f", sourceAttributeRange, attributeRange);

Permitting glitchy behavior is better than crashing a release build. Note also how I added some fuzzy checking for the floating-point value, since floats usually shouldn't be compared for exact equality.
This should use `-windowDidBecomeKey` instead, since that method already exists and is made for overriding. The notifications are only useful for classes that aren't `TUIViews`.
That and the ordering of properties and methods as follows: properties, factory methods, class methods, initialization methods, and then finally normal methods. Sounds weird, but this is an unspoken standard I see in many other libraries and Apple's own stuff half the time.
Event should be "resize"
I just copied the current UNWRAP as it is, do you think we need to add abort here?
Does this need to be documented? It seems like something of very limited use.
yes, i tought about the two as well and came to the conlusion that for bind/unbind the user clearly has the symbol in mind, whereas for file handling its not so clear. so i just kept IntPtr, but dollarzero will work as well and has the advantage that it makes more sense in the PD context. will change that too.
This might not always work well, because the user may have set spark.master.port from outside (e.g. as a JVM option), so you go ahead and launch workers, but those workers might connect *before* the Spark master is started. Ideally you would keep looking for that property and try to open a connection to that port once it's set, and wait for the master to really be up. How hard would it be to do that?
Okay - are you against doing this in an imperative style in general (there are other ways to create an analog of break without using this package)?
Doing this is more involved than it seems, as PyDataMem_NEW is used in the npysort library, which is linked separately from the multiarray module.  Adding NUMPY_API causes the functions to be declared static (at least in my setup), which then prevents npysort from linking to them.

I think the answer is to use sort.o in multiarraymodule instead of libnpysort.a, but if you have a better idea, I would appreciate hearing it.
phpinfo and phpcredits aren't the same thing.

Please give me an actual example.
Two setup calls.
Yes.   It cannot, check the types, dawg.
Formatting ate my last line;
```
Where hopefully the meaning of <1..4> is apparent.
```
THANK YOU for documenting this.  I still think it's way more complicated/indirect than it need be, but at least someone has a chance of figuring out what's going on.
If you don't like embedding code in a string, but still want a check file that resembles a REPL transcript, you can now write a test like the one in c619f94a.
I can't help myself. REPL is so convenient :)
Do you think a local implicit conversion into something very specific is a bad idea?
I'm open to better solutions, or I can remove this change if you prefer.

I think unapplies are translated after type-checking (there's an `UnApply` node)..
asm, fjbg and forkjoin add roughly 4 seconds altogether, but removing them wouldn't be worth it imho, because I rebuild the compiler much more often then the entire locker, whereas the copypaste tax would be heavy.
Keep in mind you can always do

    import binding.{ className, methName }

(I say "keep in mind" because whether that's a good idea is situational.)
"also now" --> "now also"
Oh yes, they behave differently. Need to check that the numpy version is what's required here.
Didn't know that existed. Thanks.
Could we perhaps move this into a method on the `Order` model instead?
Is there any image fixtures to use in Spree? I'm not noticing any
this looks like an unrelated and unnecessary change …?
There's an issue with floating precision, I suppose. I can change it to n(1) and then it will work, but testing strings is not without its precedent.
The oo-related work can be done later and can build off of these functions, I guess. So all I would recommend, beyond what I've already commented on, is that you make the non-general functions private (`def _foo` instead of `def foo`). I'll check back tomorrow.
btw, issue 3068 has some examples where difficulties in evalf'ing are encountered.

http://code.google.com/p/sympy/issues/detail?id=3068
1) Can you start this function with a (longish) comment outlining the steps that are going to be performed.
2) I know I'm repeating myself, but this function also seems quite long.
You're right. `default` will not work here. I've not found where `connectionID` default value is defined.
yes, subsections too... something like the "see more" links...
I think all this can be removed.

See: https://developers.google.com/web-toolkit/doc/latest/DevGuideOrganizingProjects#DevGuideModuleXml

in section Defining conditions and Deferred Binding Example
database: "benchmark"?  Wouldn't that be better if it wasn't that database name?
Did this ever get figured out?
This is kind of gnarly. Is there a reason why we need to multitask `assert_raises`, rather than just implementing a `must_raise` context manager or some other new name?
command名があまり好きくないです
もっと簡潔なのがいいー
In fact this plug is only a degraded version of `gateway.html`, so I just kept this instruction to be coherent.
By the way, if we really need to include this file, we should download it and link it in a relative way. I heard that linking files from svn/git/... repositories is not a good practice (code may change or even broke following a commit, the time response can be bad, ...).
uv_tcp_t is a stream. As to dangerous, people just need to be careful. It's not an uncommon pattern in libuv: uv__handle_init(), uv__req_init() and uv__is_active() do the same thing.
Maybe `!== undefined` instead of `typeof`?
Instead of copying most of the code for this text_field_tag, I recommend replacing this whole ````if```` block with

    <%= text_field_tag 'partcred', nil, :value => credit, :class => 'part_cred_field', :style => "#{credit != 1 && credit != 0 ? '' : 'display:none'}", :onblur => "changePartial(this)" %>

This might also work:

    <%= text_field_tag 'partcred', nil, :value => credit, :class => 'part_cred_field', :style => (credit != 1 && credit != 0 ? '' : 'display:none'), :onblur => "changePartial(this)" %>

Also note that you have a rogue ````</input>```` at the end of this line.
I'm not quite sure I understand this function, but maybe I'm being a bit stupid, so if you could just explain it to me, that would be cool.
A general comment here, I'm finding it hard to keep track of the logic.  The various Maps<> coming out of Params and the usage of them is throwing me off.  I'm finding that it is hard for me to build up a mental model of the code interactions.  When I step back and think about the algorithm that I'd probably implement for this, it's

1) For each segment
  a) Check if it is currently loaded at >= the expected replication factor and operating as expected in the right subtype grouping
  b) If loaded and things are happy, check for things to cleanup
    I) If the segment is also served in a different grouping of nodes that it is not supposed to be in, drop it from there
    II) If it is over-replicated start dropping replicas

I'm not sure if that is the algorithm implemented here.  If it is, then it's my ability to grok the code that's impairing things.  If it's not, please explain the algorithm and maybe that'll help me understand the code.
these italicized bits need to be subheadings. change throughout.
This should be a property.
Why? This is the default "do nothing" implementation for all the other DBMSes.
USER_POSTS does not contain the actual number of posts, but the displayed number. You can disable increasing USER_POSTS in certain forums. So this might be 0 even though the user has posts. You need to add a query to retrieve the actual number of posts in acp_users.php
`$this->id` -> `$this->revision_id`
Assert that code is either 404 or 500.
Does $error contain actual error data? If so, you should handle the error instead of just returning false.
You should cast to int for safety regardless.
Same with this, shared global constant?
That looks reasonable.
I would change this to use MVars. They're generally more widely used.Here is the alternative:

```haskell
i <- modifyMVar $ \i -> let i' = i+1 in return (i',i')
if i `mod` 2 ...
```
just in case `config` addon is not available. if that is very unlikely, then calling `config.getAppConfig()` directly is cleaner.
The `walkSettings()` is tested as part of the tests for the YCB library.  The `_listUsedDimensions()` doesn't have a unit test.  I will add.

While I agree with the general wish to unit test as small units as possible, there is a danger here.  Closers *are* very useful -- there one of the strengths of javascript.  Trying to code without ever using a closure is posible, but can sometimes cause more pain than micro-testing might alleviate.
I just realized, this get_descriptors function is totally wrong.  One should never poll for events other than read on a zmq FD.
It was my understanding that we wouldn't do anything with privileges any time soon. Perhaps you can add this (and other privilege related) file(s) in a separate branch?
some xml comments in here would be good :P
Why would $DEVICES_TAR_GZ be empty?
please delete rather than comment
"provides"
I'm going to merge it because all looks good, but I would suggest to also add "-m64".
The reason is that one might have a 32 bit gcc installed, and I'm not sure what would happen if the code is compiled in 32 bit. It may be a hard-to-debug error message, while at least if you have "-m64" in the command line, gcc will crash saying 64 bit is not implemented (which gives a stronger hint).
Alternatively, maybe we could verify the version of gcc to provide an even better error message (but it's probably not worth the trouble).
I think that by the end of the review I had convinced myself that none of the templates would be missed.

BTW, I did happen today to stumble across confirmation of my interpretation of INTERSECT ALL and EXCEPT ALL. 
I found it explained in an old "O'Reilly Pocket Guide to SQL".
This predicate should be (asserted) null. There is no need for it to be maintained in the java and serialized into the EE.
Can this use RealVoltDB.scheduleWork() instead of starting a new thread pool executor?
pep8 for keywords
ICS does not require the fix on our test.
Shouldn't it be if(!android || androidICS) return; ?
IE assigns it to `:`?? :s yikes haha
In fact, unless you have a special sequence like \n, \r, \t, the raw prefix is not strictly necessary. But for consistency, it's better to always add it to indicate that none of the escaped letters have to be interpreted as special-meaning sequences.
Need some comments here. Overall, I find a single "index" value  for a multiple retention store not natural: that's why we have hard coded 0 in line 69 and 64.  Ideally I want to see different index values for diff retention stores -- however, that will change the interface.
Is that `elem.style` path accurate for SVG? It might be safer to drop entirely.
So doesn't that mean `style="display:inline"` will produce false positives for `:hidden`?
I think it was removed in the pre-rebased branch for smaller size. I can add it back, but is `Error: no ajax` really better than `TypeError: jQuery.ajax is not a function`?
Ideally we should test not only for `create` but also for ` reload`, `update` and `destroy` to be sure ajax is canceled for any record's change
Hmm, really calling DROP TABLE CASCADE should be a means of last resort. Is it really necessary? If not, it should probably only be called with schema-qualified names. Otherwise, this is potentially very dangerous.
True. This is, BTW, an example where directly calling the function using an array of length 5 would lead to undefined behavior.
Will we need to maintain this version separate from ```src/config/Version.yml```, any way we can have this automatic so that we don't have to maintain the version number in multiple places?
I had it as a test generator, and it generated over 300 tests that seemed to fail in waves. It seemed a bit excessive, and would amplify test numbers. Do you think it should be a test generator again?
I'm not 100% sure, but I think it sets the precision of the slider based on the number of digits.  Before we would use 2 digits of precision, but that made using the scrollwheel weird, since we could be seeking by less than 0.1.  After the change we get 4 digits of precision.
typo in function name, which also suggests that maybe there isn't a unit test for this code path?
This leaves it unclear which case will result in "true" and which in "false". Try something like "...will be called with true if the command is ready  for execution" (or the opposite).
You drop the pipe for pgm and epgm transports too? Is this what you mean?
I thought about deleting it a couple of month ago in a (comment)[https://github.com/KentBeck/junit/pull/404#issuecomment-4923648]:

> TypeSafeMatcher is also shipped with Hamcrest core now. I wasn't sure whether I could delete the class right away. Some people might have written custom matchers using it. I know I have... Thus, I decided to leave it as is but deprecate it as well.

Would you rather delete it right away?
```displayKey``` field should be added to the docs for this method
That's because of #1257
I think the code can be made a little more consistent and easier to understand by creating a "topDelta" variable, something like:

```
         } else {
            var topDelta = elementOffset.top - viewOffset.top;
             if (topDelta < 0) {
                 // above viewport
                $view.scrollTop($view.scrollTop() + topDelta);
            }
         }
```

Note: this code has not been test :)
It seems like we should have some unit tests around this, to make sure that the document actually ends up with no references (and thus gets disposed properly) in this case.
I don't like "_getStream()" because it does nothing most of the time. I renamed _getFirstToken() to _firstToken(), and _getNextToken() to _nextToken() (and also associated functions).
so, ideally, no blocks of css should exist mixed in with our templates, but this is ok since it's app manager stuff and that hasn't _really_ been moved over to hqstyle. But this shouldn't be considered a best practice.
this part is a bit of a work in progress.  at its default it should work fine, as in nested types are NOT datetime parsed by default for protection.

the idea here is should we override and implement our own "type walker" for mapping, then you'd put your own "i know i must have datetime indexing" parts there.  i'll make that clearer - that that comment was a directive for "if you override, put stuff there"
rm pls
for long lines like this, i suggest putting each arg on a new line like this:
```python
function(
    one,
    two,
    three,
)
```
Should we delete support for the synchronous version of this?
You've started to get the right idea here. You should assign the output of those `showInputDialog` calls to some temporary variables (e.g. `first_name_input` or something). Then you can use those temporary variables and insert them into your arrays. *Hint*: You already have the number of members in your YMCA...
Yes, I know. I am not really sure why they chose that...
OK changed to field.
Default language can be Slovenian.
*folder* -> *directory*

Write something *make sure that in your Django applications you want translated there is a directory ...*
Should we check that config has the properties you want?  It would make throwing a valuable error message here easier vs. having Sequelize complain and not indicate that it's really your config file that needs fixing.
This needs to be font-family: "Open Sans", "Helvetica Neue", sans-seirf  --- we don't want the fallback to be Times.
Right, but the second argument will be used when it comes to the `component` and `element` models. I'll clarify the description and fix the spelling shortly.
This might be useful to leave uncommented.
You earned some bragging space :)
You should add some information about yourself. Something like ``Guide initially created by ____. @____ +____.``
Check how I did it at the bottom of ``tutorials/play20scalaide20/index.rst``
Prefer something like:

"Delete request could not be completed."

"Repository XXXX cannot be deleted due to dependencies on shadow repository YYYY."
"Dependencies must be removed in order to complete this operation."
avoid nulls
It's not low-hanging fruit. Jameson's code may be a better base for a more generic approach. But, his code works with string representations, not straight types.
There are used parametrized classes for the Foreman moduels, the motivation is getting rid of the dependencies between different modules and use this paramters to hand in values
Why is the @rpm_pull_name used this way? If the reason is preventing calling rpm more then once, it doesn't work, if the rpm is there (it's called every time the rpm_full_name is requested)
The other day we were trying to update the solr configuration and couldn't `git pull` because the files were symlinked - so they needed their permissions changed (owned by tomcat6) and I think some may have even been modified by tomcat. So git didn't want to overwrite them. We ended up just deleting the whole repo and cloning again - so site search was down for a minute or two.

This prevents the files in the repo from ever being touched so we can pull from github without a problem.
I'm running trunk to test this -- but good call, I will have it match both.
please use ``vendor/autoload.php`` instead of the BC file
Need more info about formatting rules
Don't think you need this anymore.
That's working because the 'mozbrowser' attribute is not set in this specific iframe (see background_service.js), but I'm not happy with this solution neither, and I would love to apply your workaround. Where can I find it?
Thanks!
Does most of the above need escaped?
Is it ok, if we rename the xml.py to xmlutils.py or something?
Maybe an example of this should be in the "Getting Started" section?  I actually had to browse the code before I realized that the string->unit conversion required just using the `Unit` factory.  (Also, this is very pedantic, but technically, `Unit` is a class, not a function, right? So it's a "factory class" or something like that?)
typo: lightweight
But if we continue to use the work-around for now, @luke-jr should include a small comment here IMHO.
An earlier version of this code extended DBErrors to have different levels of error, but the code started getting complicated and confusing (e.g. you could have a wallet that had a key error, a non-key error, AND needed upgrading... maybe DBErrors should be a bitmask, etc).

But telling the user that there is something wrong is definitely a good idea, I'll make that so.
1) put it wherever, I dont care
2) It is assumed that people on the mainline branch wish to upgrade with the mainline branch.  For people on stable branches, I would say you should rename the above line to point to a stable-specific file.
This is a slight change too as `'return' => 'bears'` will now pass where it used to fail.
remove the ``= null``. It is useless as it is already the default in PHP when omitting it
64 bits params have to be 8byte aligned as stated in the official mips ABI... Done.
Isn't there an `ipython[all]`?  I don't remember.
`functions (list, group_id) (`
I don't need to open file before calling command, so I rewrote using TemporaryDirectory.
there are a lot of formatting inconsistencies, please do a reformat before submitting
This seems obvious in retrospect.
/* Correct code */
if(buddy->client_type) {
    s_free(buddy->client_type);
    if(client_type)buddy->client_type = s_strdup(client_type);
}
The order here is confusing. 
If the `HBaseConnectionForCrashReports` depends on `self.operational_exceptions` then the connection should be done afterwards. 

Also, shouldn't the `dummy_connection.close()` instead happen immediately after the connection has been made. Otherwise a `finally:` clause should be used.
missing the magical `exc_info=True` ?
Yeah, with context managers, the `__exit__` is as predictable as a `finally:` clause.
Dumb question maybe; but shouldn't  ```zypper.out().info/message/error``` etc. be used rather than writing to the terminal? It was my impression  that  class OUT then handles colorization, verbosity and also xml-output (in case of zypper -x).
This can be assertEqual.
Using a default value would mean users would have to set it to "null" if they want to use php.ini settings, right? If so, I would suggest to not provide a default value.
this is not really safe to call as the profiler could be removed between `enableProfiler` and `request`.
doing it in the testcase is useless
I'm not sure about this, how should we treat the TTL for the users?
While setting it in seconds is a good thing, storing/getting it in the form of remaining TTL is another matter.
Should we have a different method called ```remainingTtl()``` which should provide the number of seconds until the object will expire?
For storing the TTL I think it should be done in form of having the a key named __tos (Time Of Save) in the metadata which should contain the UNIX timestamp for when the object was serialized.

Does the above make sense to anyone?
Good catch! Thanks, I'll remove it later on today.
should be ``null === $ttl``
Although it would require more work, it's probably better to just store the location, not the entire HTML block. We can have the post automatically insert the location in the URL, just like photos with the `<img>` block.
Also you should save it to `html` variable, so if there are 2 or more occurrences you will replace all of them.
Observers have been removed from Rails:

> Active Record Observers has been extracted out of Rails into a gem.
> Please use callbacks or add `rails-observers` to your Gemfile to use observers.

> To disable this message remove the `observers` option from your
> `config/application.rb` or from your initializers.

> See http://edgeguides.rubyonrails.org/4_0_release_notes.html for more information

[Here's the commit that removed them}(https://github.com/rails/rails/commit/39e85b3b90c58449164673909a6f1893cba290b2).

I don't see a reason why after some brief Googling.

I prefer to start by naming a method rather than call `save` on everything, then invoke other methods normally as needed inside the method. If not, callbacks.
There has been no checking to see that ```is_geodetic``` even exists on this method. The result would be a pretty unhelpful exception. Use case: Not that I think we should support it, but it is conceivable that a user might try passing the associated transform instance instead of the CRS...
I wouldn't be too worried if this wasn't a lazy import (the feature module has no extra dependencies over what has already been imported).
Additionally, I wonder if you have any neat ideas about making this module available to the users so that they don't always have to import it. For example, currently the extra import is needed:

```
import cartopy.crs as ccrs
import matplotlib.pyplot as plt

ax = plt.axes(projection=ccrs.PlateCarree())

# I have to import feature to get something cool:
import cartopy.feature as cfeature
ax.add_feature(cfeature.OCEAN)

plt.show()
The first wrapped TFramedTransport socket is passed to create a TSaslClientTransport, then open the new transport. It ends up with TSaslClientTransport(TFramedTransport(socket)) instead of double-wrapping.
`ring` and `data`
Just "Server application error"
Should the layout be set before starting to use the appender?
How about  "jboss.management.client_socket_bind_address" ?
@scottgonzalez @mikesherov : is there an editor that supports directory-specific jshint rules?  I'm a Vim guy myself.
hellip?
Use the same approach as many file by making a string that you assign with innerHTML.
please test the `interactive` case as well:
https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/utils.js#L273
nit: `debug(' + ' + pathInZip);` (spaces)
var notification = this._notification;
I know that now we are not using this info as you said before, but should we include a checking for ensure that this field is an email (as usual in forms)?
Yeah, that does make sense.  I was mainly going for persistence-of-UI where it's like we're just adding more stuff, so your suggestion is more consistent with that anyways.
I changed to <code>defaultImage.textContent = result.metadata.title || navigator.mozL10n.get('unknownTitle');</code>.
Although it still longer then 80, but looks better!
Note: these two lines should not be necessary — they are just fallback values in case the localized date/time format can’t be fetched.
Can you put this meassure in rems?
@vingtetun I need to talk to you about this.
oh didn't saw the review form @vingtetun  already, cheers!
Let's use an early return at the top of the closure. You don't need to assign variables/methods if there is no mozMobileConnection.
indentation please ;-)
"Modifkation"
This could be moved to initializeTurbolinks
1を入れると全てのノードに対して直列で実行されます。

→

    1 を入れると全てのノードに対して直列で実行されます。

半角スペース
please split this spec into two (true/false)
The reason I use an outer join is because, just as in the star join case, the key on one side may be very skewed (and so we'll likely see it in our sample counts) while the key may appear very few times on the other side (and so we probably won't see it at all). 
We still want to replicate this key, though, (and taking the general case, the skew side could be either one) so we need an outer join, right?

Also, I was thinking of maybe changing the joinWithTiny on the full sampledCounts to a joinWithSmaller, since on second thought, I'm not so sure it's going to be tiny.
This will not work if ``times`` is set to a negative value
Avoid this and use `Djinn.log_run`.
Don't version control `.class` files.
shouldn't you only do this for Android if it's not relevant for other browsers?
why not setting it to ``null`` by default in the constructor ?
Probably should mention that these `amqp_socket_t *` objects are destroyed when you call `amqp_socket_close()`.
But what if the pixel *surrounds* the aperture, in which case part of the pixel *is* in the aperture? I haven't had a chance to review all the code carefully yet, but I had seen this section a few days ago, and it hit me today while traveling that this does not take this kind of overlap correctly into account.
I think you shouldn't pass `$object` here, but rather compose the method calls outside of this method:

```
call_user_func(array($object, $methods['add']), $item);
```
you should use a strict comparison here (the CS rule is to use it everywhere except when the soft comparison is really needed) and switch the order of the terms to put the variable on the right
I'm pretty sure we'll need the whole chain rather than just the peer certificate to validate this properly. I should be able to do it without the second context in a way that each request is validated as to not allow for the client profiling attack mentioned above (great find, by the way).
private methods should be defined after protected ones
Basically it is to enhance the IRB shell capabilities
Hmmm, I might have added this to `cos_component.h`, or something like it.  check.
please rename to raw_torso...
Mainly it's to provide parity with the `#port` method, so that you're working at the same level of abstraction whether reading or setting that value.
I think you mean 'e'.  Further, maybe we don't need to provide a single letter abbreviation for 'emergency'?
We don't trust `sources`. Mixing twice is unreasonable performance cost IMO. As for `mix.apply` it makes sense can't remember why I have not done it in first place.
This looks great.

I didn't add a second (larger) limitation to the backend, as I thought the existing one was fine and we can tune later.
@6a68, @klrmn - Is there a way to get this content into the browserid/docs/ directory so that all documentation is easily found from one area?
@jedp - good catch.
Is that just changing all the private methods called in load_test_data to be nocommit, changing mark_complete to nocommit, and then committing at the very end?

I think I can do that but I want to confirm I have it right

I'm also not sure if that will affect other aspects of datazilla / is load_test_data and the methods it calls isolated to itself, or are they used by other things?
Not sure, that error report is needed. IMHO it's enough to fail silently.
I also have 'registration' in my list for richard. squiddy added it with the commit message "Fix password change and log out page in admin".
could you add a comment - so we can fix this up later - it will need some thought/work but fine for now
{# FIXME need to add the scripts better #}
I actually wonder how much we need this whole section. Or if we should make a wiki page about this and make the README shorter. Thoughts?
I don't see any reason to change these back. They have no need for compatibility with 2.7, as they're core classes. Compatibility with 2.7 only matters for classes delivered as plugins.
After talking to Jeff McCune the correct thing seems to be to set the last_updated on the CRL to be one second before the update. This prevents the problem that whenever you revoke a certificate there is a one second window during which the CRL is not valid and so the certificates are not yet revoked.
The only thing is that there is certainty that the `cmd.isSet` will be shared among more commands as more features are added. If you print out the `cmd` object it should have the name. I pulled in your request to my machine and added the check for the name property back in and it works fine.

I'd like to get your pull request in asap so if you can find out why `cmd.name` isn't resolving for you that would be great.
I was thinking of making a similar change. Done.
Shouldn't that line go into the else above as well?
Huh:

1.) --silent
2.) --verbose

Which one wins :)?
Thanks,  but no, it isn't, they were test keys removed before publishing :-) 

but now that I think about it,, to compute the Authorization it reads the access key and the secret Key, we have to add it to the test.
Instead of if/else and nesting conditionals, return as soon as you have an instance.
Then I'm back to my original question: if we want separate typehints, then these need to be separate interfaces. Within the framework, we're trying to typehint on interfaces, not classes -- capabilities, not implementations.

I think this requires discussion on the ML, TBH. While I appreciate what you're trying to do here, there is rationale for the previous architecture. Can it be done cleaner? Probably. However, what you're proposing here goes very much against the Contract-Oriented design we've been aiming for with ZF2.
Skip these until the DbTable save handler is refactored (beta4).
Should be &lt;proposal href="proposals/WEBGL_color_buffer_float"&gt;
Doesn't show the correct pluralization when 0 item**s**

```js
activePlural: active === 1 ? '' : 's',
```
How would you do it differently if you had access to the current route state?

You actually have access to it: `app.router.location.lastSetURL` will give you `/active` if you're on the `active` route.
yay, far better :)
Mets plutot ```passbook.test```
You can do something like this:
'''
control[error ? "addClass" : "removeClass"](errorStyle);
'''
maybe there was no data to load, but th eloading itself was succesful.
Jens, fixed that. Now go back to sleep.
Max int? Is that just an old comment?
Test fails without the trailing slash because we are asserting if the results are equal below
This test was redone and moved.
How are you stopping the actual process?
To be honest, I'm not a big fan of radmin either.

Call me traditional but what if we suggested `rails_admin`? That seems to be unlikely to conflict with anything else. :wink:
Also, this version bound is too tight.  Typically, with versions of the form a.b.c.d, our default behavior is to use "< a.(b+1)" as our upper bound, because that's the bound that the PVP allows to break the existing API.
Didn't you ask me to move this line to the event panel recently?
this wont work in a controller, I'll fix it
why adding the arch controller? I thought it didnt change from V1?
right, repeat after me, no code reviewing while a meeting
Yep, lists are shorter now no need for pagination.
That's exactly what I Was asking you yesterday :)
nit: I usually say `typeof pt === "string"` without the parens. The jQuery style guide shows it that way too, fwiw.
It seems potentially risky to store this as a field, since multiple threads might attempt to call the "suspend()" method. Yes, you could make a valid argument that this is currently only used when initializing the repository (which is done in a single-thread due to the locking), but the fact that we're adding this method to the interface means it's possible that some code might attempt to call it in the future.

Perhaps it's better to return the Transaction from the `suspend` method, and to pass it back into the `resume` method. The RunningState could hold onto the Transaction used to initialize the content, and then pass this into the `resume` method. (This might actually better reflect the state of the repository during the initialization process, which could be checked with some asserts).
Do we have a standard GIF naming convention for this? Image element will not be shown if name of GIF file does not match with image src value.
If you don't need those remove them
Because what you define as important is not the same as what I define as important
ahh  I see.. you just compare the hour itself, not the date object...
надо бы структурку завести для вершины.
Should probably use File.join here in case someone specifies trailing slashes and such.
It's picky but the trailing comma is superfluous AFAICT.
not needed :)
just say: cb( null, results[0] || null )
The "Object::" has been there since the initial import.  I could delete it in a separate clean-up patch.
Sorry, I didn't notice the change from `["nodes" node]` to `[node]`. That part seems fine. All I saw was that it's destructuring `uri` now, but `uri` isn't used.

Does this mean the `puppet node status` face needs to change as well?
No, I meant to log one message at debug level, will clean that, thanks
I'd probably prefer it if this file would be places in a separate performance folder (or even the scripts folder), just to keep the lib folder focussed on the actual business logic. Perhaps we could move the dataload scripts in there as well
The data.error was an application error (ElasticSearch returned  JSON feed that represented an error). This `call.error` is more like "Could not communicate with ElasticSearch". I suppress logging the application-level errors as that can sometimes be intended (e.g., doing a check to see if an index exists).
Yes but `readdir` is asynchronous so I'll probably still need a count.
Was this supposed to be an error object rather than 2 parameters? Maybe ensure there is test coverage (e.g., check the code) on this error condition.
Use UpperCamelCase style
What if I really have a function `Object => Object`?
ohh i let passed some. Yeah interrupteurs was sounding wrong but didn't know what to change it for. I tought of "boutons" or is there a better word
I think it would be better to flush the cluster buffer in mk_mux_destroy() instead.

Something like this should do it:

if(mkm->cluster)
  htsbuf_queue_flush(mkm->cluster);
Makes sense. But I don't think a single large commit that adds all those spaces is a good idea. A 'Fix as you touch' philosophy?
Ik zal
* player          -> main-character
* playerbase -> player
op deze manier ze aanpassen
You're allocating memory for `prob->Amat`, but it doesn't get set to the values in `a_mat`.
а меньше 0? =)
Элемент в такой реализации может быть изменён на самого себя, что в конечном итоге не будет являться заменой вовсе.
У объекта NSArray (а значит, и у NSMutableArray, так как он наследник) есть метод -(NSString *)componentsJoinedByString:(NSString *)separator, которая делает то же самое, что и вы, только пишется легче и не нужно заново описывать велосипед. =)
С точки зрения оптимизации кода: если известен размер массива — лучше использовать arrayWithCapacity. Это позволит компилятору более оптимально работать с памятью
Пауза на джостике будет делать паузу игры. Так как это сделано на всех приставках
We should probably remove the reference to queues here.
I like the callback `Action<PushStatusUpdate> onError` proposal.

It obviously should be invoked when both `referenceName` and  `msg` are filled (if indeed `msg` only contains information related to some kind of failure).

 - How should the method behave when only `referenceName` is empty?
    - Throws because it shouldn't happen and may hint at a bug in the libgit2 implementation?
 - How should the method behave when both `referenceName` and `msg` are empty?
  - Silently ignores this because this is a standard case implied by the git protocol?
  - Throws because it shouldn't happen and may hint at a bug in the libgit2 implementation?
Could you rather make this an `IntPtr` and marshal the pointer by hand? see [bit_branch_foreach callback declaration](https://github.com/libgit2/libgit2sharp/blob/vNext/LibGit2Sharp/Core/NativeMethods.cs#L116-126) and [usage](https://github.com/libgit2/libgit2sharp/blob/vNext/LibGit2Sharp/BranchCollection.cs#L109) for inspiration.
Could you add an `close()` here, too? It shouldn't do anything more than set `mMyRepo` to `NULL` again. Otherwise the new `RepoManager` won't be able to drop the reference count to zero and it will stay in memory (even if all of MGV thinks it was unloaded).
You are changing the shared test object here which might affect other tests – at least in the future which kind of violates [the principle of least surprise](http://en.wikipedia.org/wiki/Principle_of_least_astonishment). It would be better if you moved your tests to the `DeletionTests` test case in the same file which sets up the test files anew after each test. (Actually this test case should rather be called `DestructiveTests` or so … at least it is meant for cases where the test data is in some way altered.)
yeah right - my naming convention is p_typeName (p = parameter). For this example function I crossed this convention to increase the comprehension. mne_rt_server is supposed to be a hint use the address and ports which are given by mne_rt_server, and then the IP and the command/dataPorts
you can use: S = ica.fit_transform(data)
I just saw the exception doesn't cover triple mismatch between all three
channel type dicts...
Explicitness is an argument, admittedly I always found Python's dict
handling strange.


On Tue, Dec 4, 2012 at 1:51 PM, Alexandre Gramfort <notifications@github.com
> wrote:

> In mne/viz.py:
>
> >      """
> > +
> > +    if scalings.keys() != units.keys():
> > +        raise ValueError('Scalings and units must have the same keys.')
> > +    else:
> > +        plot_channels = sorted(scalings)
>
> I like the name types so +1 for channel_types and fine with
> sorted(scalings) although I find sorted(scalings.keys()) more explicit.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/214/files#r2305528>.
>
>
Could we refactor things to move refreshApplicationContext() from ModuleUtil to ModuleFactory? (Or would this be too much refactoring for a 1.9.2 release?)
I think you need to call done();
copy paste error in the comment here?
Sure, we just need to assume then that the integers should be consecutive and start from 0, or it will result in inefficient arrays.
You should use a double backtick around `/blog/`:

    with a trailing slash (i.e. ``/blog/``). In this case the slash is a seperator and
I've add the addItemsToChest function to the event , then , you can call this in an another plugin when you listen the event

Xephi
google.com URL? ehm?
It does, mostly, sometimes - it's particularly good on newer versions of pip.  Older versions I've seen have problems.   Thus why it's still in there.
Does this needs to be called for windows?
anything within a grouping symbol (like paren, bracket, brace) can be wrapped without a continuation char so:

```python
assert a == (
b1+
b2+
b3
)
```

is a way to keep line lengths down.
See [AppEngine Documentation](https://developers.google.com/appengine/docs/python/datastore/modelclass#Model_get_or_insert)
Do a full class import instead of a package ref.
Other than running your PR in a branch, what should I be doing to activate it?
Rather than doing an if statement inside of a loop, I recommend you get an array of items that are valid first, and then loop over those items to puts show. Something like:

```
valid_shows = Network.all.select{|s| s.day_of_week == day_of_interest}
valid_shows.each do |show|
  puts show
end
```

Which could be combined if you don't need to access the valid_shows anymore:

```
Network.all.select{|s| s.day_of_week == day_of_interest}.each do |show|
  puts show
end
```
what about putting this method in the `ACL` class ?
slice is a builtin name. Maybe we need another name?
What you've done here is really interesting
With the change to forms.rb, except will always be an Enumerable. We can remove the line above this one: `next if except && k.to_s == except.to_s` and remove the test for `except.is_a?(Enumerable)`.
this isn't called from anywhere
This was causing text submissions not work, as the URL of the Reddit API and the input was the same variable name.
It is necessary there as we create ExecutorService in DistributedExecutorService and DES takes ownership of created ExecutorService lifecycle - so it needs to shutdown all these threads in ExecutorService (I guess test might fail if it detects unstopped threads or so). FYI Erik Salter made a comment that by default we should not take ownership of ExecutorService lifecycle and I will revisit these tests and make appropriate changes in all these tests
It should be irrelevant Galder since this is REPL_SYNC setup.
I don't think this solves the problem for the general case as there might be an exception thrown between lines 208-223 which would still keep the thread associated with the transaction.
このクラスにセッタは必要ですか？
Original indentation was better.
On Tue, Oct 2, 2012 at 10:49 AM, Phil Elson <notifications@github.com>wrote:

> In setupext.py:
>
> > @@ -258,6 +258,20 @@ def get_win32_compiler():
> >  else:
> >      std_libs = ['stdc++', 'm']
> >
> > +def set_pkgconfig_path():
> > +    pkgconfig_path = sysconfig.get_config_var('LIBDIR')
> > +    if pkgconfig_path is None:
> > +        return
> > +
> > +    pkgconfig_path += '/pkgconfig'
>
> os.path.join is the preferred way to do this, but then, I'm not sure that
> a Windows build can ever get to here...
>
os.path.join() is also good in case the first string is empty

>>> os.path.join('', 'foobar')
'foobar'
Hmm, magic numbers like this are probably dealt with a better way. Not suggesting it is fixed in this PR, just thought I would point it out.
Because I didn't know `rotate_deg_around` existed. I will push an update to use that instead.
It's hopeless; there is nothing reasonably simple you can do to fix *existing* usage of this function when applied to ambiguous dates.  All we can do is make it easier for users to write new code, or fix old code, so it doesn't blow up in their faces.  Dateparser is badly designed for our purposes, but for the time being we are stuck with it.    Some method of feeding it the kwargs seems like an essential improvement.
I implemented PhaseStarted in all the relevant functions, and added it to the CommitteeElection class-map, should be good now.
Super helpful that you added this script, thanks!
this locator is not used
This was an important declaration as since this locator was initially set we have changed the givenName of the contact. Thus the locator has changed, too.
I'd just change the option name to `maximizeTitle` or `maximizeBtnTitle` as we may want to change the markup for this button in the future. The doc could mention that there's no "title" by default.
@arnodeclercq What is the reason for `themes.themes` ?

Can't we do this instead:

```javascript
themes = $.extend(sakai.config.skinStore, {}, true);
```
@bp323 single quotes
I can remove them,  but setting statics still works due to the Config.php still merges statics, see https://github.com/silverstripe/sapphire/blob/master/core/Config.php#L33 

Leave or scrap the static settings?
Again, just use substring rather than `replace(RegExp, String)`
Tohle se mi moc nezdá? Jak mám tu metodu jako volat? A upravil jsi i volání z interrupt handleru? Proč nezůstala schedule (void) a musí se ten timer předávat parametrem?
why not itereate only over the definitions you want to import? This way the `MigrationStrategy` subclasses gain more flexibility.
This shouldn't be here. One `end` too many.
Getting the metric name from the redis key (which is in format "#{experiment}:alts:#{alternative}:metrics:#{metric}:*"). I split the string at ':' and want the 5th substring, which is index 4.
Enabling D3 transitions was simply a matter of exposing the Element.attribute methods on Raphael elements.
niyazi be in class hanabood !
ye gardehs kamel ba time 60s niyazdashti dige
ya time 3600s vase sa@
I'm wondering, does it make sense that the plugin doesn't have a start? are there other ways it could do anything without a start? - I already put log/warn here in a pull req.
Now I kinda wonder what exactly would happen if child  plugin wouldn't use cljminecraft.ClojurePlugin as its main, like what kind of error would it throw