labofsahil/github-event-dataset-2012 huggingface dataset:
OK, I need to pay more attention. The comment below says it all. It seems that this should not be a problem, esp. since we don't have multiple directories.
Hmm, I see your point. How about `andAlso` or simply `add`?
Odd to put semicolon at the beginning of a line.
Also need to do this for #context-menu-bar for context menus.
Never mind. I was wrong. You have called convertToNativePath() and it already call unescape().

So it is looking good. Merging.
Good suggestion. I also stripped "x-" from beginning.

Note that CodeMirror sends a mode of "text/plain" for most files, so this doesn't impact most files used on web sites.
False. In fact, quite the opposite, you can test it yourself:

- http://jsperf.com/array-join-vs-string-connect
- http://jsperf.com/join-concat/2
- http://stackoverflow.com/questions/7296594/array-join-vs-string-connect

String concatenation is insanely optimized in modern browsers.
example here is out-of-date
Added documentation in the dygraph-options-reference.js file.
I think doctests in models.py still get included here.  I think there's maybe one of them in the entire codebase.  We should do something like https://github.com/dragoon/django-selenium/blob/master/django_selenium/selenium_runner.py#L67
"Empty" may be better than "null" in this sentence. By the way, can't a password be left empty when connecting to a database ?
Yeah, found a workaround, already used this pattern in ~5 gems and can finally retire it :)
I think using only `settings.xhr` all the time is OK because everything from `$.ajaxSettings` is copied to `settings` initially.
I am not sure I understand completely what to do here. If I pass the variable for FUTUREDATE offset through LimitedDateTimeField in models.py I have to override __init__ in LimitedDateTimeField right and then somehow clean that value off of kwargs, store it in a class variable so validate() method can access it, and pass the rest to the parent class.
Hm, form fields do not have `error` method. This is something from mongoengine.

You should probably do something like `raise ValidationError(self.error_messages['bounds'])`, where you define the `bounds` error message in `default_error_messages` (extend/append new one).
Can't you just leave this as json.backupDate?
Does this check need to happen with the changes you made to dragndrop?
We should probably just delete this entire file, actually.
Please document args and what you expect/mean by each.  Some are obvious, some (exclude) are not.
no controversial already. As I tell you yesterday, just update it. Thank You.
In the previous line you just confirmed that the text is the same as in `database_name`... why not use this:

`page.click_link(database_name)`

?
这些xsdg是怎么回事？
Можно же записать в одну строку
```js
if (url.indexOf('#') === 0 || url.indexOf('?') === 0) return false;
```
Although we don't seem to do it very consistently, this seems like a good place to include some comments.  E.g. What is CustomInfoMethods?  What is the purpose of this module?
Grammar: allows `you` to iterate
`protected` vs `private`?
Place this right after user creation, please.
The docstring for set_temp is wrong; there's no reason it should need to be called from within in a loop.

Even if you restore the original value, what I'm concerned about is whether or not this could accidentally *modify* the user's configuration while the tests are running.  Whatever you have for it now is probably fine, but I'd want to double check. I just don't remember if the test sandbox for configuration variables is totally safe now or not, though I think it probably is.  As long as you put the original value back in the teardown that should be fine.
why still here uses rescue?
We could, I'm pretty sure that it might be more efficient to do this when looking up the controller on incoming requests.  But I'll look into it.  It might end up making sense to do it on route connection as it will make reverse routing behave more consistently.
Checking the api for `wincache_ucache_inc()` there is no need to initialize `$success`, its passed by reference and its values is set by the function.
would prefer the explicit names :-)
They are redefined to put the upper bound at 'precision'.
"\r\n" is typically Windows, so if your code runs on an X-platform, it should be fine, don't bother.

Do you think you could also write a few lines on the Feeders wiki page when we'll do the release?
https://github.com/excilys/gatling/wiki/Feeders

Thanks again!
ترجمه بخشی از https://wiki.archlinux.org/index.php/Time#Time_standard 
به همراه توضیح فارسی راه حل
try returning false, it might be what causes the second 'document ready' to trigger.
This template is mesh-specific, we should probably have a more generic one that we can reuse with the various XTK objects.
See the [argparse docs](http://docs.python.org/dev/library/argparse.html) for more details on how to use argparse...
hi, andrei.  look at how ImageExtension works, for example.  in BaseComputeServiceContextModule.provideImageExtension

you can also make a separate module for this and add it to the list in the ApiMetadata classes
Ok, looks good, lets do this.
Ссылка абсолютная, здесь нужно относительную делать /adminboard
typo -)
`giterr_clear()` here.
Yeah I don't like `GIT_ENOTFOUND` either for this case. That would mean that the reference was not found, not that it was corrupted. I'd say go back to `-1` and don't check for specific error codes.
URL may not contain port, path or query string, so plupload builds url like this: http://example.com:undefinedundefined (port and path are undefined). This fixes it.
There's a possible race condition between here and when you actually open the file below. You should probably use a `try` clause instead and catch the `IOError`
It's hard for me to determine the major difference between contribute.html and contribute-page.html, perhaps they could use better filenames?
I believe the &raquo; is supposed to be within the string for rtl languages.
ehrm. yeah!
Should use ``@example.com``. It's the domain you're supposed to use for examples.
So in the non-unified version, the filters were applied to the wiki_s, but if you weren't doing a kb search, they'd be ignored.

In the unified version, we should only apply the filters if we're searching that thing.
Not strictly, but I noticed it after I merged and decided it wasn't worth cleaning up. It fits better with the rest of the page, where semicolons are also omitted.
kind of silly nit - when saved directly to file (not from a postgres restore), the json is pretty-printed:
https://github.com/peterbe/socorro/blob/5a7b11bb9c3da793a51338f63cbb3be35fe1a9d1/socorro/cron/crontabber.py#L182

However restoring from postgres just dumps the string. Why not do json.loads here, then json.dumps?
Would be a good chance to make sure it's valid JSON and not some random garbage too.
should this be commented out? Or does it work anyway?
The global ``Defaults`` object no longer exists, it is now attached to the ``Config`` object, so update this code.
Ok, I understand. Thanks for the feedback! 

So the solution for my problem would be to create a facade for the all uses of Process/ProcessBuilder and mock this one? Doesn't this just shift the problem?
@fabpot:
- is reusing the finder intended (or a bug) here ?
- is handling serialized class only (vs string, ie paths) intended ?
thanks, too tired to figure out tonight !
Or just drop the defaults...?  To be honest, it's must must better we have this explicitly defined than in system wide settings since some systems have very strange settings.  Debian for example disables GC in favour of a crontab which is crazy.
as it is an interface, you can use ``getMock`` with the same result
This is more explicit as it verifies exactly where the notice occurs.
you should add `'position': 'normal'` to the params array instead of concatenating the string
Keep it the current way as this is how it is done everywhere else in the data collectors.
hmm .. i dont think i have seen ``are`` as a boolean getter prefix yet. usually its ``is`` and ``has`` .. but i dont think ``hasResourceTracking`` is better really. so i guess its fine.
Ah ... I thought that was the standard header. Tell me if you want different or no credits.
Hmm, where did this come from? Must've been the github code editor...
adobefont should be left. (error of merge)
Давай какой-нибудь sass-метод для этого использовать, а то не кашерно как-то. Или в бутстрапе или в compass-е есть такие.
These methods are compatibility methods with matplotlib 1.2.0rc2. Once 1.2 has been released, I hope to remove them. As a result, I am uncomfortable with this change. 


```
plt.axes(projection=ccrs.PlateCarree())
plt.contourf(x, y, data) # <- does not get nice wrapping functionality
plt.contourf(x, y, data, transform=ccrs.PlateCarree()) # <- does
```

It is my intention to create a new feature of a mpl axes which allows one to specify a default transform - I think rather than wrapping *every* method to set a default transform, that would be preferable.

Thoughts?
nit: this feels too disconnected from route.handle, maybe move up and put comment inside?
@rowenaluk do you have any more clarification on this comment? Also do you feel this is an issue with all of the notifications or only the stockout notification?
this allows to launch AWX in "fullscreen" on IOS devices when added to home screen.
Do you need this empty string at the end?
Perhaps because if it fails moduleSpecification.addSystemDependency(...) doesn't get called?
Should be "https://github.com/madlib/testsuite"
Because this: https://github.com/mozilla-b2g/gaia/pull/5139#discussion_r1721842
please extract to a `var selector` for example, will make the code more readable
I was refering to the `Recents.stopUpdatingDates()`
Can we move this line into the first "if" ?
In fact I have delete that "if" clause and included a comment about the phone type being a mandatory property of every contact's phone number.
Probably we won't need this debug string ;)
seems like I fucked up here ;)

since you're at it, could you please also fix `style/trusted_ui/trusted_ui.css` and `style/wrapper/wrapper.css` to use `progress.gif` in `shared` ?

In `wrapper` it seems we're using currently a different file so I'm not sure we want to change it (but I think we should) but in `trusted_ui` I'm sure it's missing.
With this line `Desktop` it's not working properly. Change for:
`if (!telephony) {
    return;
  }`

instead.
We already have something to share js files.
Let's use it (you can ping me on IRC for details if needed).

A good example is the `l10n.js` file.

You need to put custom_dialog.js in `shared/js/` and reference it with 
`<script type="application/javascript" src="shared/js/custom_dialog.js"></script>`

and then magic :)
We can't hard-code 400 millisecond here because it may happen to be out of sync with CSS someday.
For l10n purposes, we don't want to reuse strings in different contexts.  The rationale is that in languages with gender and plural agreement, the required phrasing may actually be different.  Please create a new l10n id for this.
The fact that we have to test it that way means something is wrong with the template engine.
But happy to know we're covered!
You need to edit this file with UTF-8 encoding.
I couldn't think of a good use case yet, these should all be local to solitude and be damn fast. Although DELETE might be sending subsequent requests on.
The key `base` should be replaced with the correct message name `intpm` (as in Mathematica)
On mono :)? This helper is only for solution files. I'll see how well Path.GetFullPath works.
Is the `else` needed? Just call `@car.drive` if `isRaceRunning` is `true`?
Might want to have a "return None" here just to be explicit
I think this test is no longer valid if we're in a vpc, as vpcs allow the use of protocols beyond tcp udp and icmp, should probably add in  a check to verify that you're in ec2 classic, if you decide to keep it.
I'd reverse this if statement, so that you check for the positive case, and the else is the negative case.
Is unscaled redundant in these descriptions?
Would if @guide.video_url.present? be clearer here?
I assume if this were a real "recommended-link", the link would be a URL?
Perhaps, but since it's a test utility, I don't think it's worth the trouble.
Do we want this interface to be by object, or by name?
Can you please also add a test case for a failure scenario?

Otherwise LGTM
Makes me wonder - what is PHP doing internally? Kevin, you ever look at C code? :P
hmm why didn't git ignore it? i'll see to it
getCaretPosition
@randx Maybe you can let me know what you think about the suggestion above. We are running into a bug with the existing code. `raw_url = self.web_protocol` makes raw_url the same as self.web_protocol, when you modify `raw_url` after that `self.web_protocol` is also changed. This leads to errors such as https://github.com/dosire/gitlabhq/issues/58. You could either use `raw_url = self.web_protocol.dup` or merge this PR to solve it.
You should add indexes for `:commit_id` and `:noteable_id`
In gitolite 3, `gitolite setup` will not create hook files?

It's weird.
Missing line break before and after this line.
It's a good practice to isolate logical blocks by a line feed.
use common.$g ?
HTTP request body
If this getting into master, this will come back to bite us. For now, we can just filter this in. An even better way to deal with this would be reading the meta information added to our project by maven.
this feature has a database change.
It's awesome. Let me tell you a story.

This is a variable that contains the index of 'i18n/:locale/...', that we have to count by hand after a `console.log`. Since I removed the EJS lib, there was one less resource in the list before the :locale resource. Hence the "fragile" comment above.
I think the new exception class is the way to go.  As it stands, if you use an ini file and mistype it, you'll get the expect IOError.  It would make no sense if you were to type 'myconfig.ini' and get an ImportError
Same here. Also could you flip both entries so they are in alphabetical order?
Fixed. Damn, my style should be improved!!
not by a setting, but by a default method param. :(
@zaphod42 Not sure. How about I file a ticket to deprecate the autoloader and remove the comment (as in once we start requiring face/actions), then the checking for multiple default values is valid?
This exists to support all kinds of debuggers that use any of methods from Kernel or Object (which are not available in BasicObject).
This deserves a comment about why it is done.  (I assume, it allows regular Ruby objects to be used as defaults, right?)
Huh.  We added a thing in Rails to make sure that `Rack::Lock` is added with Webrick (because many people are running WEBrick in production).  It *shouldn't* be there when you're using Puma, otherwise you couldn't do parallel requests.

I guess we need to fix the `rake middleware` task in Rails.
don't need that source != i i think
Is this synchronized method going to be in the hot path? Perhaps consider replacing the mutable HashMap with an unbounded Guava MapMaker?
Lucky me indeed :-)
protocol is part of process vars - needed on unserialize pickled data
The option "protocol" is used on serialize
Bad indent here: 1 soft-tab = 4 spaces. And add, tag @throws in the DocBlock.
Not sure this was necessary; it only changes the line length by 3 characters, and the old line still fit in the 120 character limit.
I'm using it, as it calls function. Didn't understand your point I think.
Please explain this a bit more. The comment is the same as in the above function but the code isn't
@md-5 Removed blank line in latest commit
Nitpick: this has inconsistent capitalization compared to the other private member variables
Das könnte man gut testen!? :)
Zidane wanted like one general event, so I guess this is called any time a vehicle does anything.  Ie creation, collision (which isn't implemented yet) exit and enter, etc
Should be called app.css
FYI: It was this set of benchmarks that I was meaning had changed between different versions of LevelDB. Sorry for the confusion - I should have learnt to fully understand things before attempting to explain them by now.
:in_memory
Can this be left as a method instead of property, since every other property is accessed via a method; urls(), formats(), text(), html()
IMO this should be `FOUND_ROWS` (uppercase) to make the example consistent with the docs below.
That would be Luis Muñoz :-p
Do we need the `form` tag here?
`Bugzilla`
please modify this to use `Popcorn.getScript( scriptAddress, callbackFn )`
Thank you for helping Dmitry!
This is the actually important change, where instead of trying to do raphael scaling, just re-draw the bar. Also, remove it after drawing to cut down on flickery-ness.
Can you put the hints in <p>s so that there's more space in between them when shown? (That's our default)
Same as my above coment here.
Done. Also i needed to rename a file due to a utf-8 encoding problem.
It's in a separate commit. You probably dont
need this one. I guess is an issue related to my os/filesystem configuration.

On Sun, Jul 8, 2012 at 8:53 PM, David Chambers
<reply@reply.github.com>
wrote:
>> @@ -17,6 +17,8 @@ responder = (fn) ->
>>  app = express.createServer()
>>  app.get /// ^/card/(\d+)(?:/(\w+))?/?$ ///, responder api.fetch_card
>>  app.get '/card/:name',                      responder api.fetch_card
>> +app.get /// ^/lang/(\d+)(?:/(\w+))?/?$ ///, responder api.fetch_lang
>> +app.get '/lang/:name',                      responder api.fetch_lang
>
> I'd prefer to use "language" in full in the URL patterns. Do you mind making this change?
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/davidchambers/tutor/pull/17/files#r1119850



-- 
The lights then came up and the crowd erupted in applause, because
that's what the crowd does after it watches destruction on a large
screen. -- Ben Kuchera, Modern Warfare 3 review.
This regexp isn't used at all. The name wasn't the problem, it's removal was.
Typo : expanded :arrow_right:  expanding
That's the same reason why I use $ in the name for variables, so I know that the object says I can use it. I never really thought about having a function return a jQuery object like this, however, but it makes a lot of sense.

Typically, I'd assign the output of a function to a variable prefixed by $, but this works too, if you don't cache the data, like if you're calling it once and chaining it.

Anything that makes code clearer to others (including future one's future self) is pretty much almost always a very good thing. (:
из-за длины и не разбиения на функции в этот момент я уже не понимаю к какому if это отнсится... мне приходится идти и искать и понимать.
в идеале я должен все понимать сразу
Hmmm, maybe we have a separate `middleman/rack` which we force folks using Rack directly to require instead of `middleman`?
should be 4 spaces for indentation not 5
All the other code used it. I guess just `rel` would work. Although it looks like whitespace is allowed in the value.
Need to be changed, is going to take the first record when two users haves repos with the same name. (use repo.github_id instead)
oops sorry... this was not the latest. Now it should be fine.

On Fri, Aug 3, 2012 at 1:28 PM, Felix Ruess <
reply@reply.github.com
> wrote:

> > @@ -4,20 +4,20 @@
> >    <dl_settings name="control">
> >      <dl_settings name="photocalc">
> >
> > -      <dl_setting max="90" min="-90" step="1"
> module="cartography/photogrammetry_calculator"
> var="photogrammetry_sweep_angle" shortname="Angle"
> param="PHOTOGRAMMETRY_SWEEP_ANGLE" unit="rad" alt_unit="deg"/>
> > +      <dl_setting max="RadOfDeg(90)" min="RadOfDeg(-90)"
> step="RadOfDeg(1)" module="cartography/photogrammetry_calculator"
> var="photogrammetry_sweep_angle" shortname="Angle"
> param="PHOTOGRAMMETRY_SWEEP_ANGLE" unit="rad" alt_unit="deg"/>
>
> RadOfDeg definitely won't work here...
> Also since alt_unit is deg, it was correct before anyway...
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/paparazzi/paparazzi/pull/250/files#r1300936
>
I don't like that we're co-mingling the merging of default values into this functions. Why can't the caller just do:

    (merge initial-config (inis-to-map path))

This function can then remain small and single-purpose that way.
I don't think we should bother...part of the intent of /experimental is that stuff under it is unsupported, could change at any time, etc.
I don't think we need `-v` at all in these examples...if people want more verbosity from curl, they know where to look i think. :P
Yes, you're right. I was working on two parallel goals and gave up on one, and this is one of the artifacts of that. Let me change it real quick.
Refinery::DummyGenerator changes the working directory to spec/dummy. If you follow that up with the :spec task it can't find any specs and dies.
:+1: I agree with @phiggins
@jede hey, do you intend to change this at all?
There is no test, we'll be able to add that when we'll add tests :)
There are a view instances of the variable name `app` in this init method:

```
/tmp/Hilary$ git grep "module.exports = function(app"
node_modules/oae-authentication/lib/init.js:module.exports = function(app, callback) {
node_modules/oae-authz/lib/init.js:module.exports = function(app, callback) {
node_modules/oae-content/lib/init.js:module.exports = function(app, callback) {
```
It looks like the same `results.dataload` object that gets passed in for every tenant, not a tenant-specific one. Therefore I **think** the results from each tenant just keep overwriting each other. The authz tests don't split up the data-load results per tenant, it aggregates and averages.
I think the chain of `moduleConfig[colHash[0]][colHash[1]].elements[colHash[2]]` should come from a function. This function would probably also verify `moduleConfig[colHash[0]] && moduleConfig[colHash[0]][colHash[1]] && moduleConfig[colHash[0]][colHash[1]].elements[colHash[2]]`, returning null if any are `null`/`undefined`. Then this code and a couple value accesses below get shorter.
I'm wondering if this needs to be publicly exposed function? If it does need to be one, does that make it possible to move createUser out to the principal API?
Not completely accurate. The resizing happens in the function above, this functions saves the images on the principal.
Which I think it would make sense. IMO, the less we share between profiles, the better. It makes it clearer. But it might be me...
Why not put that 100 into the `ProposalRefactoringActionAdapter` as the default value for the `relevance`?
This looks like a bug (left for right swapped)
Besef net dat je het laatste natuurlijk kan schrijven als:

```js
if (this.standing && (condition1 || condition2)) this.vel.x = 0;
```
Ну уж для себя-то могли бы и `for (int i=0; i<100; i++)` написать. Легче же читается. В инициализации с произвольным числом то же самое.
для большей гибкости предлагаю изминить int r = arc4random() % 4; на int r = arc4random() %[dict count];
можно не пользоваться промежуточной переменной, а просто написать

        NSLog(@"hammingDistance: %d", [myCell1 hammingDistance:myCell2]);
Нет смысла постоянно в цикле создавать массив и вычислять его длину.
I don't think I can remove at least the first 2 relevant loops here because the second is dependent on the first (the first remaps the nodes at the top level, the second remaps the dependencies of those nodes). This could potentially be done recursively instead though.
Set to true instead of 1.
Ok, perhaps we should consider just adding in the strong params gem in the near future then?  I forget if there was a reason we decided not to do that and go with the 'users keys' filter instead, so that may affect our decision if there was a problem I am forgetting.  Maybe we can talk tomorrow about the template xml modeling idea
This behaviour is missing on this flow, and it should be added.

Thanks for pointing that out. Feel free to open a issue/pull r
You and your semi-colons.
You could also use the `/i` flag for case-insensitive matching instead of `[Bb]` and `[Cc]` :)
This helper should be moved inside the ```describe do ... end``` block, preferably at the top (over the ```before``` call). Defined here (in the top-level scope), it becomes a private method on Object, which may conflict with all sorts of things.
That won't happen, or it's at least *extremely* unlikely. The value used to seed the hash to generate this API key and any API key used in production are guaranteed to be different, and the probability of a random hash collision for this function is 1 in 2^80.
Why do you delete such useful code comments here and below?
I thin we should have the archive inside path, i.e., use `archive_name = op.join(path, archive_name)` this makes sure the tar file will always be in the same location.
super-magic expansion. never used % but you're right. safety goes first

On 24.12.2012, at 18:06, Alexandre Gramfort <notifications@github.com> wrote:

> In doc/source/python_tutorial.rst:
> 
> > +~~~~~~~~~~~~~~~~
> > +	
> > +  For optimal performance we recommend using numpy / scipy with the multi-threaded
> > +  ATLAS, gotoblas2, or intel MKL. The EPD python distribution for example ships with
> > +  tested MKL-compiled numpy / scipy verisons. Depending on the use case and your system
> > +  this may speed up operations by a factor greater than 10.
> > +  
> > +  The expected location for the MNE-sample data is my-path-to/mne-python/examples.
> > +  If you downloaded data and an example asks you whether to download it again, make sure
> > +  the data reside in the examples directory and you run the script from its current directory.
> > +  
> > +  From IPython e.g. say::
> > +  	
> > +	cd examples/preprocessing
> > +	
> > +	run plot_find_ecg_artifacts.py
> ipython says %run plot_find_ecg_artifacts.py
> although run works until you have a variable called run ...
> 
> —
> Reply to this email directly or view it on GitHub.
>
> Either way, I think that it should stay in the format it was in before removing pointns (which was COO).

fair enough !
There should be 3 dots.
please maybe remove some extra lines here and rather place the information @stof gave you:

```
$builder
    ->add("name", "text")
    ->add($builder->create("issue", "text")->appendClientTransformer($transformer))
;
```

it is neat how one can learn from @stof :D 

should be easy to remake against 2.0, @weaverryan  wonder people is just not PR'eing master directly, i don't have experience handling PRs for different branches, it is like working with git-flow i guess but who takes the toll of merging here and there you? :D
@WouterJ, I see your point, and I don't think we have a super-clear standard here one way or another, but I'm personally -1 on the format. It makes more sense in the `TreeBuilder` because you actually have `->end()` statements at each node - so you build up the tree (and indent), and then have to work your way back down the tree (with `->end()`). In this case, we're not returning the same instance, but it's not that same tree structure.
it should be that is decisions not that are decisions here
Here is what you get when copy/pasting too hastily :P Good catch!
+:100: 

That's why the note is included here.  Eventually those should be removed.
All copyright notices need to be updated to the new ones.
Removed improper use of default param values. This was used originally to take into account receiving cmd line args from the main program, but that's not up to the dev server to worry about.
No, I will look at it
А зачем чекбокс? Разве на хедерах нельзя выставить CheckStateRole во что нужно?
Ты юзал какую-то не ту функцию. Юзай из локали short-версию.
Потому что стоит с подозрением относиться к глобальным рефам и прочему счастью.
Олсо, он здесь тупо не нужен. От него скорее только оверхед будет.
На самом деле, можно их просто создавать на стеке.
最上面加過了, 就不用每個都再加
remove 48 49 50
Quizá esto ya estaba mal en la tarjeta, pero lo re-redactaría como "Complejidad innecesaria del UI"
`marcar` en lugar de `margar`.
checkSession();
/me feels that needs strip_tags or something
Should be checked
Small question: What is the reason for this change? I see that we have code in both styles, but do not know what to prefer and why.
I am using InteilliJ. I have now installed the Eclipse Code Formatter Plugin ( http://plugins.intellij.net/plugin/?idea&pluginId=6546 ) to adhere to the c:geo style. Will re-submit.
I would suggest doing this another way:

- make an optional content length member.
- only set the content length member if there was a header parsed for content-length.
- make the determination on whether to continue if the total length of the body that's been parsed is already equal to the content-length.
Hmmm... shouldn't this go in extensions/mysql/models.py. Are we punting on it for a while?
What the hell am I looking at?! When does this happen in the movie?!
    "Now". You're looking at "now", sir. Everything that happens now is happening "now".
    What happened to "then"?
    We passed "then".
    When!?
    Just now. Were at "now," now.
    Go back to "then"!
    When?
    Now!
    "Now?"
    Now!
    I can't.
    Why!?
    We missed it.
    When!?
    Just now.
    ... When will "then" be "now"?
    Soon.
+1 for TODO , this method is invoked quite frequently and this list doesn't need to be pre-computed. One of the nice things with having the routing table (vs old CH)
I recommend using the "rpcssl" setting here, as it's also used by bitcoin itself to determine https or normal connectivity.
As above, this should be `copy`.
They are, and you've had to make decisions about where to break things and what to modify. When opinions start getting passed around involving those decisions it can lead to frustrations and sometimes upset. It's good to see you're taking none of it personally.
I think I agree with the lowercase thing.  It's more of a gut feeling though -- and part of me feels like it should be lower case on Unix and mixed case on Windows, but that's probably a bad idea ;)
Temporary variable > trailing backslash.
User shouldn't be setting the UrlName, it should be derived from the Name property.
This is the same as implicit wait in webdriver?
Minor nit: 'for example' twice in one sentence.
i am trying to decide if this section is overly complicated. none of the tests actually test the removal of suites from runs.
why does this one locator not use self?
This is an old comment from a previous version. We now always use startcol and startrow.
First line

```
var modalContainer = oae.api.util.modal($('#addcontent_container'));
```
@gsilver can we remove this comment? (and the ones beneath)
@bp323 Missing space before `(`
I think I'm missing something about the intended use case. The original logic (replaced in the above diff) causes the query to be scoped to the access rights of the session owner if the session owner is not Admin. The replacement logic obtains the userId from an Authorizable sent into the processQuery method. In the backward-compatible processQuery(...) which is deprecated above the Authorizable is created from request.getRemoteUser(). Is it possible that the Session obtained from the request will be owned by a user other than the remote user? If so, I agree that this may have broken something. But I had believed Sessions obtained from the request would be under the current user or under anonymous.

As for uses of processQuery by other services the behavior is an open question. All existing code must be sending in a SlingHttpServletRequest object and so should be following the same logic/process. The question is how the new processQuery method *should* behave. I have designed it to take both a Session and an Authorizable with the idea that the Authorizable is the principal under which queries should be preformed regardless of the Session owner. This could open the door for an escalation of role if someone codes a use of processQuery which creates the Authorizable from a request parameter haphazardly.

Please let me know if I'm tracking your concern or if my understanding of this use case is lacking.
Savitha fixed it in another pull: https://github.com/sakaiproject/nakamura/pull/722
Changed to. 

    container = this.closest('.cms-tree-view-sidebar');

and 

    if(container.length > 0){	

Hard to test at this point, but it should work in theory.
soo. why it worked? get of course.
i'm not sure.  maybe it supports different versions of rails / rubygems or something.  maybe ask the original authors.  not urgent.  maybe try to think of some way to dry it up, like sym-linking one file to the other, or just including one file in the other.
Why are we including the `!` here instead of in the template?
Function name is wrong in the comment
Yes, for now it must be done like this. If zencoder-php had namespaces and composer.json, it wouldn't be necessary.
Nitpick: Is the fallback anything other than `reverse('home')` anywhere else? Looks like boilerplate.

A TODO here might be to roll that into `_clean_next_url`, maybe as an optional second parameter `reverse_name` that defaults to "home" and does the `or reverse()` by the end of the function
why relative to the proxy path ? Fixtures have nothing to do with proxies
So validate is opt-in? This will break any `set`s (several of mine :cry:) expecting validations. I would expect opt-out behavior, but maybe that's just me?

```js
if (!this.validate || options && options.validate === false) return true;
```
```javascript
    if (!options.data && model && (method === 'create')) {
        model.set({id:model.cid}, {silent:true});
    }
```
Thanks @elkuku :)
I think using the DIC id may not be the best idea here. Providing an ``alias`` attribute on the tag may allow giving a better name to checks (``symfony_version`` instead of ``liip_monitor.check.symfony_version`` for instance)
Yes, the csv datastore uses this parameter to control what strategy is selected:
https://github.com/opengeo/geoserver-exts/blob/68f6f363199cb9e5de2f33cf5b807f62752f66d0/csv/src/main/java/org/opengeo/data/csv/CSVDataStoreFactory.java#L113-121

I was trying to avoid having the importer know about the csv datastore specifically, so I named it something more generic on the importer side and always added the parameter in. But in the future, we might want to consider having a concept like a "ParseSpec", or something along those lines anyway, that gets passed on through to the datastore. This would be driven from the rest endpoint or the importer ui, with the user making the decision. Is there a somewhat standard set of metadata that different datastores use for this sort of thing?
Should we also require the node to generate `Odometry` messages in addition to tf, allowing to use `robot_pose_ekf`?
Ah I recall. If you test for response.empty? then the if test (165) passes, but the logger line (166) fails because it tries to perform "".join. Rather than change a whole ton of code, the above fix seemed quicker.
(So, you don't have `!==`, but `!=`.)
No, there is no race condition here. It does not matter if this command or some other command clears all `None` out.
I thouth so too, but instead of 404 I get 500 :) and "User.User matching query does not exist."
Empty line after loading tag.
Why this method? What is different than to call directly `messages.error`?
This is clearly not going to work - remove this change
Interesting!! is that a ruby operation?
GetHitUnit works in BeforeHit hook
> deal with this complexity so that users don't have to, but that's not all

deal with this complexity so that users don't have to. However, that's not yet all implemented and depending on your use case there might be better approaches you can take anyways.
assigning, not assign
The purpose is to define a threshold for the accumulated usage of memory and cpu. because if it spikes on cpu once and then on memory once and then back on cpu once it is not restarted (as it has to happen in a row). But with this accumulated version with a lower value you can catch that as this one would be hit every time and the process gets restarted. That was the basic idea but I am not entirely sure whether this is the best implementation of it nor it makes real sense in production environment.
This field is not updated in a thread safe manner but it is used for allowing access to workers. Would that be an issue or is it ok if the value for this field is not 100% accurate.
This isn't a public method, so should start with an underscore.
Why not? We will have it. From `request.user` or from querysets we will be doing against the database?
Should we set 'control' on the model so that if this gets re-registered we don't keep making new InputFilter controls?
This is a good question!  However, I think that as telescopes typically have a single, fairly static secondary mirror configuration this might not crop up to be such a common issue.

However, what is it that prevents `MAX_AIRY_TABLES` from being 1000, or 1000?  If it's a memory useage question, we can probably go above 100 for this *and* Sersic. (Hitting the Sersic max table limit actually concerns me more...)
>  I still have a slightly hard time wrapping my head around the fact that it's OK to simply seed a random number generator with 50 successive integers (say) and have the outputs be truly random with respect to one another

Me too.  But I convinced myself that it was ok with tests like this:
```
>>> init_seed = 12424324
>>> for i in range(20):
...     rng = galsim.UniformDeviate(init_seed+i)
...     print rng(), rng(), rng(), rng()
... 
0.142667399254 0.287860462908 0.499770418741 0.0904984772205
0.025454856921 0.357784117805 0.430668052984 0.368717640173
0.0751579699572 0.830725742737 0.133976681391 0.126615930349
0.474595359061 0.658753247932 0.857061795192 0.746172973886
0.258327680407 0.413334427634 0.0603196506854 0.0771445366554
0.826725080842 0.44527738262 0.46451025526 0.950500963489
0.592470949283 0.523005650146 0.27025623899 0.851358348271
0.662243493833 0.112081465079 0.311012901133 0.0241208549123
0.986671980238 0.870796030387 0.22343868902 0.0195284474175
0.0333418587688 0.291803715285 0.207603618735 0.706907879096
0.943576825317 0.304902520729 0.803312628297 0.907725275494
0.592949304031 0.348949268693 0.0933580228593 0.617740861606
0.277417049743 0.0601493164431 0.231691793539 0.60588549939
0.540089566493 0.279012271902 0.765644069528 0.36745402636
0.313540697331 0.0833754418418 0.458292542258 0.930945093744
0.217242887244 0.679196968675 0.594959717011 0.385159309255
0.531789692817 0.704118636204 0.194076437037 0.405635475647
0.644275538158 0.280683466233 0.423620385118 0.884210122284
0.372639579233 0.771887405077 0.308223272208 0.142117248615
0.998528596712 0.542636452476 0.336369198281 0.752252283273
>>> 
```
Looks pretty random to me, so I think it's ok.  Especially considering that our requirements on the independence of the random numbers are pretty weak actually.
其实这个玩意没用，删了。。。
I prefer better performance for such code. So I still prefer ArrayBuffer (however of course it's just microoptimisation, not sure it can cause some performance problems, but this is my superstition, and I think that just in case it should be faster...)
Maybe `./mmaloc/configure` is simpler here ?
Copyright and license notice should have the proper content (see the existing feature to add those)
Should this be an attribute?
This is okay even though it's in ExamRecord.

See production db:
```
mysql> select distinct(score) from c2g_examrecord;
+-------+
| score |
+-------+
|  NULL |
|     0 |
+-------+
2 rows in set (0.01 sec)
```
:+1:  on this way to do JSON.
This is the 6th log4j.properties file in the brooklyn repo. That smacks of something being wrong, to me.
Not suggesting we fix it here but just wanted to raise it...
i'm only using it for start, although could be useful for creations in future perhaps
More typo / line-noise.
We could do that, and in fact I tried that first, but I didn't like the fact that create_firefox_profile was then also responsible for adding extensions. Seems to violate SRP and also could be a problem later when we want to support non-firefox extensions. That's my $0.02 anyway.
possible unsupportedoperationexception (note to self.. document this)
ふつうにIDをキーにするだとうまくない理由が何かありましたっけ
Variables should be in camelBacked format.
This will conflict with https://github.com/mongodb/mongo-php-driver/pull/176
ah right .. using ``File`` is a bit annoying .. since you then need to do a node type definition allowing to set the additional properties like ``caption``
That's a nice little feature. I like it :)
I debated about making a default value other than null or not for these. For my own use I would prefer them to both be null which is why I made it that way. What are your recommendations on which one should be set? I think setting contextPrefix to 'ctxt_' is the best option.
Was unable to do this - not sure why, I agree this would work.  Fixed other things
The "var/var" ones here need changing.
Я уже объяснял, что это можно сделать с помощью виртуальных методов у enum. Либо сделай так, либо удали комментарий такой :)
Этот комментарий актуален. Исключение в конструкторе OutputStreamWriter повлечён незакрытие FileOutputStream.
В этом задание, собственно, было.
Even if we don't buy into non canonical DevTools instances, this isn't right.
I think we should have a few references to gDevTools as possible
ex: 
data-context: {"category": "", "hash": "85b1e5c85b1e5c", "bodyclass": "home", "title": "Firefox Marketplace", "headertitle": "Firefox Marketplace", "cache": "cache", "type": "root"}

we try to match only the part that we need "bodyclass": "home"

so that locator points to the element #container > #page that contains in the data-context attribute value "bodyclass": "home"

I escaped the "  and ' to make the locator more exact
Also this property suggests that it is returning the username however it is not. It is only returning if it is present.

The name should be changed to reflect what this property is returning :)
you might take these constants and explicitly make the constants, so that they have clear names and can be changed in a central place.
"done." is more explicit.
ok makes sense. Maybe you can illustrate it with the digits to avoid too much duplication
Good question. I thought about this quite a bit and thanks to @pprett's
suggestion that I buy Programming Pearls, I could implement a version of
quicksort that does not exhibit that behaviour, but rather has a worst case
performance of O(n log n).

But you raise a very good point in general. Since most of the computation
time is spent in argsorting, we would do well to benchmark various
implementations and choose carefully.
On Aug 31, 2012 6:12 PM, "Gilles Louppe" <notifications@github.com> wrote:

> In sklearn/tree/_tree.pyx:
>
> > @@ -1592,3 +1576,41 @@ def _random_sample_mask(int n_total_samples, int n_total_in_bag, random_state):
> >              n_bagged += 1
> >
> >      return sample_mask.astype(np.bool)
> > +
> > +# Sedgewick's version of Lomuto, with sentinel
> > +cdef void _argqsort(DTYPE_t* primary, int* secondary, int l, int u):
>
> I am wondering if QuickSort is a good choice for sorting features. My
> concern is that it degenerates to O(n^2) when the array is already sorted.
> The fact is that, as you build deeper nodes, they become purer, which often
> correlates with purer features as well, which in turn means that you will
> tend to sort arrays with more and more identical elements. A degenerate
> case.
>
> What is your opinion? I remembered that you tried heapsort in the first
> version of this PR?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/scikit-learn/scikit-learn/pull/986/files#r1508540>.
>
>
Then what would be the point of "Seeding RNG with seed 4389128" before running the tests? Something is eluding me...
sounds good to me, too.
wAt? hm ok...
Do not use np.linalg.norm, use sklearn.utils.extmath.norm, which is a backport of improvements to scipy's norm.
Il me semble qu'on avait dit que visit_TryFinally devrait être dans analyse.py
doesn't fit with https://github.com/wikimedia/WikipediaMobile/blob/master/STYLE_GUIDELINES
should be fixed later...
That should of course not be there.
The empty line at line 390? I like to code with some extra space and empty newlines. I think it makes the code more readable if it's not packed.
Yes, something like this is definitely better.
Use similar naming convention for static member functions, i.e. with prefix underscore.
will do as soon as we have a clear list of possible values
gonna remove the ref.
teh array will be passed to the new ArrayConfiguration class which extends Configuration, just like Xml or Yaml
Well in the default us-east-1 region we can omit it:
    https://github.com/cloudfoundry/bosh/blob/master/aws_cpi/lib/cloud/aws/cloud.rb#L9
But in another region it will complain that the us-east-1a zone is not available.
    https://github.com/cloudfoundry/bosh/blob/master/aws_cpi/lib/cloud/aws/cloud.rb#L111

So adding this to the doc makes it easier to know where to look for it if needed.
fine filter documentS
It's safe to be there, we concluded.
It is valid only to dedup based on what's left.
The logic changes once spilling begins.

What remains in the HT is valid to dedup by only, whereas before (where it contained all), it was valid to assume that when there was a negative match, the row was a new unique row.

i.e. the HT is performing some filtering only, you _could_ throw away all of it at this point, but it is useful to retain some, to minimize the amount of duplicates that would/could spilt to their buckets otherwise.
Back to original comment, can it just as easily be environment.xml ?
I'm not sure.

The floating point numbers can only store 16 significant digits, so I would expect the last digit to be rounded - but not the last two as it seemed to have been testing.
I believe the extension should be .co
Raise deprecation warning
This is incorrect. You need: ``from account.conf import settings``
@wch - Yes. We don't have a formal suite of automated tests, but we ran `R CMD check` with both versions of ggplot2 separate to verify that it passes with 0.8.9 *and* 0.9.0. I also hand-inspected the output of all the example code to be sure it was right. Does that make sense?
I think that multiple people are searching for `window-utils` and `tab-browser` when they want to get access to chrome DOM nodes, because high-level API doesn't expose them, nor implement a modifier for what they want to achieve (UI listener or modification). We may give some extra-visiblity to these ones. They fit in this "expose low-level access and comes with longer review". But we might be able to help some developers to find those easily.
No, it makes sense and cuts down the code in `api_views`.

I think it falls into my second point a bit, though I was coming from a standpoint of classes being "seen" by Django. Nonetheless, those list and detail views are just the basis for the "implemented" views.
data provider for the creds.
Formatting needs to be looked at
I've added the ".timepicker" namespace for all events for which the plugin will be listening to. This way we can later remove all those listener without removing also listeners that where binded by 3rd party code.
Why was the process handle dropped from the response packet?
The file will be in use though.  Maybe you can in Linux, I'm not sure in Windows.
I should really sit down one afternoon and just finish ``convex_hull_objects`` -- all the pieces are already there!
Yes, it should still be 0.15. I argued in favor of 0.16 for the morphological reconstruction PR, and then Andreas pointed out that the most current Ubuntu has Cython 0.15.
Where is a bare ``delete`` defined? I get a lint error on this. Do you mean ``self.delete(key)``?
Yeah, I guess if one wanted to be purist, if it's not enabled, one could ask the user whether to adjust their main format, and warn them that it'll be discarded.
Same question/comment for `rgbaf` and `rgba`.
We could call doneCallback with the exception, but that would mean closing the connection. There are cases where most of the messages are completely valid and one or two could be invalidly structured. What's the preferred strategy here? Close the connection as soon as you get invalid data or log it and continue?
Add an arrow to indicate the order in the table, it improves the usability and previously you could not know the order in which they were neat rows in the table unless the You will review in detail.