labofsahil/github-event-dataset-2012 huggingface dataset:
That line looked properly indented, though the create() method wasn't looking right (a tab instead of 8 spaces) That should be fixed now.
@dharkness 
@coreyjv 
@marcphilipp 

I vote for simplicity:

withMessage(:String): ExpectedException
withLocalizedMessage(:String): ExpectedException

Pls create 
ThrowableLocalizedMessageMatcher
You should be able to replace this line and the previous one with:

    assertEquals(Arrays.asList(Ignore.class), d.getAnnotations());

I think this will work too:

    assertThat(d.getAnnotations(), hasItems(Ignore.class));
The same comment as for the single-process cuda code applies here I think.
This seems like just another place we're storing config. Can the `multi` module just use `lconfig`?
Are these intended to coexist for long? I can see there being confusion in the similarity of the words.
This jQuery expression appears in two different places... it'd be nice to wrap it in a function like getFirstSearchResult() or something.
`rawQuery` doesn't appear to be used.
I think we should rename "command" and "isEnabled" to make it clearer that they're callback functions (and in the case of "command", to avoid confusion with how it relates to the Command object). Maybe something like "executeFn" and "isEnabledFn".
How does the user set the selected/enabled state once a menu has been created? Do they have to hold onto the actual MenuItem that's returned from `createMenuItem()`? Or is there a way to get a menu item by ID later on?
Garth bumped it to 3px.
set operations in function form work on any iterator, not just other sets (in contract to the operators like | & ^)
There's find_or_create_by_... use it!
It was useless, so it was removed. Moreover, risklib should not deal (atm) with output/input format
I'd always use the indexer (`SelectedClip.angles[0]`) instead of ElementAt, since you're working with collections.
Unused import ! :-(
wait... what ? We may need to explore that a little further...
layout 可以都用 application 就好了
增加 layout 的成本會比較高
Add `TODO` at the beginning of the comment:

```
# TODO: Message user that they have not been logged in because they cancelled the Facebook
```

Also, use information provided from the Facebook why login was not successful.
And yes, the above is also not perfect. It should be something like:

```
<ul>
  <li class="field">
    <ul>
      <li class="field_label"></li>
      <li class="field_content"></li>
    </ul>
  </li>
  <li class="field">
    <ul>
      <li class="field_label"></li>
      <li class="field_content"></li>
    </ul>
  </li>
  <li class="field">
    <ul>
      <li class="field_label"></li>
      <li class="field_content"></li>
    </ul>
  </li>
</ul>
```
This assumes that the user is using restmail. As above, I prefer the idea of offering the regular expression and let the consumer handle their email implementation. The majority of users will simply want to sign in with an existing account.
There's no manual input required here, so why do we need the timeout?
I don't think I can use the same baseDir that's in there for everything else. I tried a little and unless I'm using path.resolve wrong with node it's basically because they are from two different places. The baseDir stuff that's there is relative to butter, where as I am relative to cornfield.
Do the same for error, since you call it below in some cases (i.e., null function so it doesn't throw if not provided).
is there a reason it needs to update newText on every keydown?
Afaict, this is the only place `container` is actually used. I believe the idea was to use `itemCallback` to let the user of this function do whatever they want with the object. Using `container` provides a nice shortcut, but it should be consistent.
vmtx can stay (for now) since it's now trigger the sanitizer. I'm not sure it is just ignoring the tables or that involve setting some other flags in other tables.
Do you think there will be a case when `CFFCharset.charset` will be modified?
If the GitHub API call returns nothing for the description field, at that point the `sourceData.github_description` var set in line 70 resolves to "<p></p>" -- hence the test for > 7 :) I should probably just test `data.data['description']` on the fly right there, rather than creating that var in the first place.

---
Ryan Pitts
@ryanpitts
http://www.ryanpitts.com


On Thursday, August 30, 2012 at 7:53 AM, Brian J Brennan wrote:

> In source/code/templates/code/code_detail.html:
> > sourceData.github_last_push = new Date(data.data['pushed_at']).toString('dddd, MMM d, yyyy'); > sourceData.github_forks = data.data['forks']; > sourceData.github_watchers = data.data['watchers']; > sourceData.github_details = '<li class="spacers"><i class="icon-github"></i><span>Forks: ' + sourceData.github_forks + '</span><span>Watchers: ' + sourceData.github_watchers + '</span><span>Last push: ' + sourceData.github_last_push + '</span></li>' > {% if not code.description %} > - if (sourceData.github_description.length > 1) { > + if (sourceData.github_description.length > 7) {  
> Why 7? Seems a little magic numbery, maybe either storing the value in a descriptive variable or writing a short comment before might be helpful. (Or it could be obvious if I were more familiar with code/results of the code).
>  
> —
> Reply to this email directly or view it on GitHub (https://github.com/mozilla/source/pull/26/files#r1497480).  
>  
>  
>
I'm fine with either /* */, /** **/ or // - depends on mood :)
Isn't this more specific and readable?

`response.should redirect_to(projects_path)`

Is there some problem with this, like you really need a regex?
indeed! I just setup a new laptop for a big road trip. I didn't have it set to auto convert tabs to spaces. I'll fix that right up now.
Sweet!




On Wed, Nov 14, 2012 at 6:21 PM, Sean Channel <notifications@github.com>wrote:

> In debian/changelog:
>
> > @@ -1,3 +1,16 @@
> > +salt (0.10.4-2) lucid; urgency=low
> > +
> > +  * Latest version
> > +  * use python-zmq with zmq3 support
> > +  * generate HTML doc package
> > +  * include support files for systemd, logwatch
> > +  * update build/pkg dependencies
> > +  * reduce postrm scripts to 1
> > +  * update init scripts
> > +  * misc & dependencies cleanup
>
> I am pleased to discover the abundantly obvious "history" button on github:
>
> https://github.com/saltstack/salt/commits/develop/debian
>
> ^ ^ this batch basically started Nov. 5
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/saltstack/salt/pull/2549/files#r2130587>.
>
>



-- 
http://flavors.me/tvaughan
> task の名前について

これは僕が昔つくったRakefileからのコピペなので @mrkn さんのいうようにcompileの方が名前とやっていることがあってますね
さくっと修正します！
Can you add a comment here describing what the class does?
Seems to me this setting should be opt in instead of opt out. That way we can simplify support for older local_settings.py
Good catch. That was something else I was doing before but is now irrelevant.
Why at random?
Maknuo si ovo pravilo van?
Again, 8px grid. This should be either 136px or 142px.

But again (and again), this should be flexbox. So please revert this change.
Maybe this is irrelevant if the "simpler version" @iguananaut is working on doesn't have this function, but I think the name should be ``should_build_with_cython`` or something like that - right now it looks like this actually *does* the building (rather than just telling if we *should*)
100% of this document so far has been talking about Linux. I'd take recommending ZFS in the body text, then add a note declaring that it's ok for non-linux systems.
I don't see a var utils anywhere here - missing:

    var utils = require('./utils');
It's only memset if -datadir is specified...
How does this handle enum values that contain `,`?
META is not understandable for many people.
Please use "⌘" instead.

This also must be taken into account in the control. This doesn't seem to be the case currently.
you should be using the vendor free syntax ( style[transitionDuration] )
Why do you keep newing this up. That seems wrong. It should be injected via DI and it should be a singleton like the other settings.
Yes that looks better
please make more explicit that N
Missing `({`, no?
Same here - we should expose a method in GitRepository that allows us to create a branch using a LibGit2Sharp call.
The thing is: this was meant to fix problems when in the terminal, readline wasn't available for some reason. We didn't have the notion of 'kernel completions' back then.

Now that such a thing exists, obviously we need the completion machinery to function even when there is no tty attached.
I think in my comment, I also showed a class available in the JRE.  Did you
try that?
On Nov 2, 2012 1:31 PM, "David Ribeiro Alves" <notifications@github.com>
wrote:

> In
> labs/oauth/src/main/java/org/jclouds/oauth/v2/json/JWTTokenRequestFormat.java:
>
> > +
> > +   private final Function<byte[], byte[]> signer;
> > +   private final Json json;
> > +
> > +   @Inject
> > +   public JWTTokenRequestFormat(Function<byte[], byte[]> signer, Json json) {
> > +      this.signer = signer;
> > +      this.json = json;
> > +   }
> > +
> > +   @Override
> > +   public <R extends HttpRequest> R formatRequest(R httpRequest, TokenRequest tokenRequest) {
> > +      HttpRequest.Builder builder = httpRequest.toBuilder();
> > +
> > +      // transform to json and encode in base 64
> > +      // use commons-codec base 64 which properly encodes urls (jclouds's Base64 does not)
>
> I've spent a bit of time on jclouds's Base64 impl. I tried adding URL
> safeness by implementing configurable alphabets and although it works
> sometimes other times it messes everything up. moreover jclouds base64
> encoder insists on adding two equals signs to the end of the encoding.
>
> personally since guava 14 will include what we need, I'd rather not spend
> more time chasing this. one thing we could do is change the jclouds base 64
> impl to use commons-codec (copy paste) and keep the copyright.
>
> wdyt?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/jclouds/jclouds/pull/920/files#r2020802>.
>
>
I think this can be removed, since you already have `Anita::Activities:: InvalidDateString` defined.
It was around for debugging. I think I'd like to keep it, but if you dislike it, I'm game for removing it. I can always figure out how to put it back again later.
Indentation is weird here. Tabs vs spaces?
If ``tags`` is None, then this line will fail since None doesn't have a ``.sort()`` method.

It's probably better to sort a few lines down after the ``if tags is None`` block.
Not sure if we explicitly allow preference names with whitespaces. At least we shouldn't accept those when Firefox doesn't support it. Might be good to check that.
If you're defining var ``options`` by extending ``defaults`` with ``opts``, you should refer to ``options`` throughout the rest of your code instead of ``opts``. The point is that if something is missing from ``opts`` (the arguments you pass in when you call the fn in init.js), it will be filled in by the ``defaults`` object. So here (and throughout the rest of your code), use ``options`` instead.
Mmm ok I see that there was a problem with the documentation of the previous service. It isn't ``products/versions/`` but ``products/`` only. In that URL, ``versions`` is a simple parameter, it is not part of the "path" of the URL. If we were using classical URLs, it would be ``products?versions=something``.
We either have to loosen it here, or change the type system radically. Since we piggy back on the JVM type system, we can't say "we accept nodes, relationships or paths" - we have to fall back to the least common denominator - object, Any, or in Cypher - AnyType().
I assume here that you mean that dialogs can't be skipped at all? Is this something that can be implemented in the future and if not, why?
Should be "Elemente" for the plural form.
Right now, it does. In the future it may not.

Also, when you write custom code that depends on the builder, you should type against the interface, not the code.
You can revert this change as you have re-added the old method now.
Use openFile and SplFileObject::fpassthu
It won't. FormEvent extends FilterDataEvent, so it's fully BC.
Fixed, rebased, repushed.
you should not tag it as part of the stable API yet
CS issue. It should be ``} elseif ('oci' === $driver) {``
constants are Capitalized
Is it needed to sanitize empty string here?
For these three (38-40), I might create a single `User` object and use in 47-49
Maybe this? http://blogs.msdn.com/b/zainnab/archive/2007/07/09/grep-and-sed-with-powershell.aspx
Please use the old style python string formatting `'Unable to get haproxy statistics %s' % e` to stay backwards compatible with older version of python
`def test_profile`
is that necessary? I think you should be able to test functionality without actually needing a server (you have already tested that the server retrievals are working).
I agree. The caching is premature. I'm tempted to just remove it...
Why include the "1.2"? The cut'n'stitch isn't version specific is it?
Explicit paths are not permitted.  If this is a calibration you should be
using the calibration system to write the file to $ORAC_DATA_CAL.
For example suppose this was a zeropath calibration.

my $zpd = "ZPD_S8C.sdf";

Once the file is made you file it with the calibration system

$Cal->zeropath( $zpd );

In later primitives you can access the calibration

my $zpd = $Cal->zeropath;

You will need a rules file that selects the appropriate calibration.
For instance, if S8 refers to 850 microns you would provide a rule to
match the filter in $ORAC_DATA_CAL/rules.zeropath.

FILTER eq $Hdr{FILTER}
nit: Returns a list of captured fields given a path.
this part should be kept. It's really important to closes fds when forking
`It has`
should we make it `set(this, 'eventTransitions',get(this, 'eventTransitions') || {})`

c'mon, bro!

:)
The default behaviour before was to return True if the _cancel_drag was called (see diff in lines 139-140). The new line (i.e. 129) will allow the user to override that behavior by returning False.
I don't think this is required as Flame.CollectionView inherits from Ember.CollectionView that gives sets content for each instance of ItemViewClass it creates (https://github.com/emberjs/ember.js/blob/master/packages/ember-views/lib/views/collection_view.js#L146).
Please see the comment in the other PR https://github.com/jbossas/jboss-as/pull/3473/files#r2191059
We can merge this for today since AIUI it's urgent to get this in, but this requires a bump to the schema before the cutoff for EAP 6 ER5.
Because in near future we want allow CDI interceptors on JAXWS POJOs,
see: https://issues.jboss.org/browse/JBWS-3550
ahhh okay! nice! I see
so, I would let the min and max on the line 53.
and additionally add viewportSize = Math.max(viewportSize, 5);
to the end of the calculation

No setZoomLimit needed. But if you want, you could add setViewportSizeLimit(min, max); but only if you want or need it.

Then I can merge your pull request.

It would be also great if you'd extend the GraphViewDemos with an example for your custom styling :-)
Are you going to address this in this PR?
is there a good reason not to us the `download` function wrapper here that uses a pool? I worry about clogging the node thread pool (or the main event loop) with too many http requests, since they will be made very every symbol downloaded for every map copy.
Here we have an anonymous function
nit: extract `navigator.mozL10n.get` in a `_` variable at the beginning of the method.
Same as above.

Also add spaces around '*'
if (alarm.enable == enable)
       return;

and save extra indent to the code follows.
if (captiveNotification_onTap) {
      notification.removeEventListener('tap', captiveNotification_onTap);
      captiveNotification_onTap = null
    }
Fine with me, I'll send the PR.
It's fixed in next pull
Maybe call this method terminate_all? And change the LOG.info to LOG.debug?
Same comment about var applies here.
Why all comments are in Portuguese? :worried:
I'd prefer to see an explicit slowdown (e.g. using `sleep`) rather than an implicit one using a loop like this.
~~~
もしオプションがセットされていなければ空文字列（""）で置き換えられる。
~~~

~~~
もしオプションがセットされていなければ空文字列（""）で置き換える。
~~~
Although I´m no RoR expert and I´ve just done it for two years, my coder intuition tells me that this is wether ruby-like nor rails-like.
But the only placed it is used is for failures in edts-code-handle-eunit-result? If you mean that it's used for both falied tests and failed assertions, then I think it should either be two different faces/issue-types or have a descriptive name that includes both types of failures
Good idea including your reference material
Take this and make into a constant.
Code doesn't work if the value is NULL (SQL queries fail).  But I would rather find where the variable gets used and put 'com_kunena' instead of the variable.
This function is important. Somehow, the previous student who worked on MobiPerf/Speedometer code merging didn't not move this function over.
Without this function, the updated preferences can't be sent to the MeasurementScheduler.
I just wanted a confirmation dialog for the link so the user knows where they are going.

I suppose it's less needed because it opens in a new tab anyway.
kongove, you mean we should recursively close/cleanup all of opening session, right?
we should rename this to be more reflective of what it is used for
Is it possible to handle this in `setUp`, and clean up afterwards?
Is this used anymore?
Why not use CC_SAFE_RELEASE_NULL?
It will check the validity of s_pHttpClient.
Yes, _va_copy_ is for linux 64-bit compatibility. If we remove
```void alignItemsInColumns(unsigned int columns, va_list args);```
```void alignItemsInRows(unsigned int rows, va_list args);```
from CCMenu.pkg then there's no need in this fix.
I followed the pattern of the other commands in this section. Example:

    composer init \
        --name='simensen/srcmvn' \
        --author='Me M I <me@example.com>' \
        --require='sculpin/sculpin=2.*' \
        --description="hello world"

Running that should ask you for `name`, `author`, `description` and it will default to the CLI values.
because visibleFields_ holds all visible fields. not just fields for a specific section.

We first filter all fields that are in the section, then return the count for all visible fields in that section
Isn't it done by default? Why do you need to set it explicitly?
hm, this one would match not only scripts but also regular missing target links e.g. /web    imho that would be "too restrictive" -- make those "script extensions" being mandatory for the patter I guess (now they just follow with | )

does nginx has a way to report that it was indeed a script, not just static content, which wasn't found like apache does?
good catch, changed my previous try to this one.
@punkisdead you forgot to update these lines :smile:
:D
This is because the S3 class ``package`` has the description field in 
lowercase, while meta is expected to have field names starting with a 
capitial letter, as in the DESCRIPTION file itself.
I think that argument meta is necessary because some CITATION files 
(e.g., the example on Writing R extension) uses such data to follow the 
package's life (Date, Version, etc...) without having to update the file.

-- 
Renaud Gaujoux
Computational Biology - University of Cape Town
South Africa


On 20/06/2012 15:36, hadley wickham wrote:
>> @@ -129,6 +130,23 @@ build_vignettes<- function(package) {
>>     unname(apply(cbind(filename, title), 1, as.list))
>>   }
>>
>> +capfirst<- function(s) {
>> +	paste(toupper(substring(s,1,1)), tolower(substring(s,2)), sep='')
>> +}
>> +
>> +#' @importFrom utils readCitationFile
>> +build_citation<- function(package){
>> +	
>> +	citfile<- inst_path('CITATION', package=package)
>> +	if( !file.exists(citfile) ) return(package)
>> +	message('Rendering CITATION')
>> +	package[capfirst(names(package))]<- package
> I don't get what this line is doing.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hadley/staticdocs/pull/27/files#r1017559
Why not use the "len" parameter passed to this function?
this said "this is horrible" when I wrote this comment.
Dependency between window/utils and tab/utils kind of sucks, but I guess we don't a better solution :(

Also it could be me who suggested to remove this from tab/utils but since we do keep dependency between `window/utils` and `tab/utils` anyway I think it would make sense to put this function into `tab/utils` itself.
ah the onUntrack part is being tested.
"Loader providers"
Why do you have to override globals although you gave thems as prototype ?
If it doesn't work using just globals as prototype, we should just override and let a default prototype.
I don't think `for of` is shipped yet.
complete is actually a function, so this check will always fail.

complete's intent is to be a shortcut for 
`if(callback) callback(args...)`

the shortcut is called using 
`complete(callback, args...)`

which compresses to a few fewer bytes than the former.

Instead of `(status.status === complete...`, this should be `(status.complete === "complete"...`
Unfortunately, [].forEach cannot be used right now - IE8 does not support this and we have not yet added it to javascript-extensions.js.

You can either add Array.prototype.forEach from MDN (https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/forEach) to javascript-extensions, use _.each, or use a plain old for loop.
ok, I made both PushLogStatsModel and PerformanceTestStatsModel inherit directly from DatazillaModelBase.  PushLogStatsModel did have a tiny bit of convenience code copied.  But the constructor was simpler because it doesn't use all the stuff from PushLogModel.
Also, this is wrapped tighter than necessary, can go out to 79 chars and not use so many lines
I'm fine with commenting out code for software that's in rapid flux, but figured I'd point it out in case you meant to remove it entirely.
Be creative, GenericActiverRecordObjectTest?

2012/7/28 Jérémie Augustin <
reply@reply.github.com
>

> > @@ -10,7 +10,7 @@
> >
> >  namespace Propel\Tests\Runtime\Om;
> >
> > -use Propel\Runtime\Om\BaseObject;
> > +use Propel\Tests\Bookstore\Book;
>
> to what GenericBaseObjectTest ?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/propelorm/Propel2/pull/281/files#r1258404
>
Maybe "Installing **the** RapidSMS project template"
I think this could just be `== 'greet_jack' - no need for the complexity of the regex - wdyt?
I should be able to look at this today or tomorrow.
Good point. From a compatibility perspective, this would be necessary. But at the same time, I'd love to see a callback when an item is selected. Perhaps a special new method?
I think that default value should be `self::DEFAULT_DATETIME_FORMAT`
Based on the logic you have, there's a real possibility that you'd have an array like this for $allowedServiceNames:
```
array(
    'Some\Service' => 0,
    'Some\Other\Service' => 1,
)
```
As such, this will fail for whatever service is in the first position, no?
At time when I wrote this I didn't see any sensible format validation in other loaders. Any suggestion how to handle it? Just an exception? I think additional data that is not translation is not a problem so we are OK to skip it.  I probably should check tmx specification for that one.
upper sensei told you to use `selenium2` instead of `sahi`, not just adding this dependency.
Do use var in a a loop. move the declaration outside so the same varible is used.
Or have it return an anonymous type with meaningful properties? Arrays are so .Net 2.0
Why is this constructing the message by hand?
sure, it's better
Formatting is off here, you need to use all tabs. No spaces.
use a constant
You don't need to put the file in both notmyidea AND simple. Just put it in simple and it will be inherited in any other themes.
Still wrong usage of the elements.
you could remove the default here as ``_format`` already defaults to ``html`` in Sf2
The Contiki code style requires single-line if()s and while()s and for()es to have braces (there are a bunch of those in this pull request).
Missing space between `if` and open parenthesis
indent comments along with code
if you're already sorted you don't need to check for in, but just compare with l2[-1]
I think the check `<=0` might be wrong. If size is 0, but len is larger than 0, then what will happen here is we copy the entire original string. But we should copy 0 bytes of it, that is, just return a new string of size 0 (just a null terminator).

If I am not mistaken, just removing the `size <= 0`  condition will make this work ok. If size is 0, the processing after it will work ok.
This is sounding better, but I'm not sure if it belongs in motionArgs...I mean, it isn't something that any of the functions that will be passed it as true will use...An alternative that might be confusing for others reading the code is in evalInput, save the value of lastHPos, set it to null, see if the evaled function has set it to non-null, and if so set stickyHPos to true otherwise to false...
Why is this a synchronous request on every login rather than a task?
If its only for registration then it should go on apps/users/forms.py
You could just assign a value to the ID at the start and pass it along during initial creation too saving this call but I suppose that's nitting.
Two things.

1) I think this should be PopcornYT

2) You need to declare this so we don't leak into global.  Maybe do it up above where you declare oldYT
Maybe provide the option, but chances are this would be used on startup or as part of a deployment job, where asynchronous behavior wouldn't be as impactful.
Clarified and pushed :)
Add {@inheritDoc} javadoc.
...or by adding the module used to your application's package.json.
Minor, but probably slightly cleaner:

```python
return self._getData(url, accept=kwargs.get('accept'))
```
I don't like having this. We don't want to ship broken configurations. Perhaps just remove the XSLT config altogether if we don't have time to finish it?
OK, then we should fix that. This is where mocking and stubbing come in.

Do the non-pro features still pass if you do have pro?
true again?
I do not really like the default values are hardcoded as magic numbers when calling ```access```. IMHO we should ship a set of default config files from ```defaults/*.yml``` with *perfect* metrics you have to adjust initially.

Flay, Flog: All zero.

Yardstick: 100%

Reek: Most restrictive, no exceptions

...
There's a deadlock issue here: `self._callback` can be executed immediately, if the task referred to by `future` has already completed (e.g., because the executor worked fast, or just because thread switches happened to occur at the wrong time).  But we're calling `_submit_job` from `execute`, within the scope of a `with self._state_lock`, and `_callback` also needs to acquire `_state_lock`.   This can be fixed by moving the `add_done_callback` from `_submit_job` to its callers, and calling it outside the `with self._state_lock` blocks.
Can we be 100% sure that $selected will never be null?
This entire block should probably be implicit in the command queue being given a message to send.

Policy around "optimistic vs pessimistic" send should totally be the responsibility of the command transport, not the code that invokes it.  Remember the single responsibility principal: the transport should be fully responsible for transport related things, and only the transport should be responsible for them.

If you need to have more control over the "how", define the contract so that this code expresses *how* the message should be carried, and the transport is responsible for delivering on that.
Not able to load the page in this link. Please verify and post the correct one.
I'd rather not create a "production" piece of code that promotes the creation of fake contexts. This is really just a bridge in an exceptional development circumstance.
I think all the `sign` and `verify` methods should be taking in a tenant alias now, right? When signing the message, you could prepend the body with `'tenantAlias#'`?
Neat! Such a nice tip :bow:
I didn't say it's "just" a visibility issue :)

In general, I think it would be more helpful to put down your reasoning from the beginning, instead of a question that needs a few more hops to clarify.

I still don't understand fully why adding `@volatile` can lead to lost updates. If the `var` is volatile, other threads will see the latest assigned value, am I right? Or you think that the `invoke` call should have exclusive access, so that nobody can modify the `currentThread` variable while it's executing?
Changed in last commit
Don't test PTR against 0, always test against NULL.
Just curious. Are you trying to handle the case where checkin() fails and we dont closeInternal? I am asking since checkin by itself will destroy the resource if its invalid. In general can you add all the stack traces you got, to fix these?
@Baachi If i move zend packages to require-dev, do i need to keep the repo ?
I don't think we should include an orphan instance here. A better approach would be a newtype wrapper, and unwrapping it when creating the FromJSON instance below.
Production centre should not be selectable - it is the logged in user's production centre, so just display it but don't allow it to be selectable
Such as  a 404 page
Confirm?  Document changes don't go in the change log?

On Nov 15, 2012, at 7:43 AM, Andrey Andreev wrote:

> In user_guide_src/source/changelog.rst:
> 
> > @@ -446,6 +446,7 @@ Bug fixes for 3.0
> >  -  Fixed a bug (#1220) - :doc:`Profiler Library <general/profiling>` didn't display information for database objects that are instantiated inside models.
> >  -  Fixed a bug (#1978) - :doc:`Directory Helper <helpers/directory_helper>` function :php:func:`directory_map()`'s return array didn't make a distinction between directories and file indexes when a directory with a numeric name is present.
> >  -  Fixed a bug (#777) - :doc:`Loader Library <libraries/loader>` didn't look for helper extensions in added package paths.
> > +-  Fixed Doc Errors (#17) - :doc:`Javascript Library <libraries/javascript>` Updated document to reflect working code.
> This should be removed.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Please try and following the coding style guide and wrap with {'s on new lines.
Why the change when they do exactly the same thing?
Convenience function. The _ext version requires the output string to be passed by reference so it can be written to. It seems much nicer to provide this version than make the developer declare their own local set to FALSE before calling. If you could just call get_ext(FALSE, 'myconfig', 'config'), I wouldn't have bothered.
Если процент больше 100 — сделать его равным 100, а если меньше — не делать ничего?
Очень хорошо, что решили придумать свой метод для замены элемента, отличного от заменяемого. Могу лишь сказать, что можно вообще не использовать цикл, а выбирать случайным образом из оставшихся 3 элементов, в дискуссиях на hexlet'е это разбиралось.
Прошу обратить внимание, что в Obj-C все - public, и все методы - override. Т.е. методологии других языков в плане инкапсуляции и механизмов наследования к Obj-C применимы лишь через некоторую призму. Особенно на это обратить нужно внимание, если раньше вы писали на С++ или Java.
The main reason is my severe lack of python knowledge :-)

From my limited research, calling git commands and piping them though find was much easier to do with batch commands than with python. Of course it's entirely likely that I overlooked something simple in python, and if so, would love to hear about it.

The variables will only be set in the current shell session, so I'm not too worried about having conflicts with other programs.
It would be awesome to have "ok" and "cancel" as default buttons.
No, you're right in that. Just wasn't sure if that's what the solution was for that problem.
There's definitely some code that could be refactored out and shared with `+combineLatest:reduce:`, the problem is that one is in `RACSubscribable`, the other in `<RACSubscribable>`.

Unless we want to introduce a new `+combine:reduce:aligned:` public method or something to that effect, where aligning the values reproduces the `zip` behaviour, and not aligning them the `combineLatest` one, we'd have find a way to share code between the two privately.
This first comparison should probably use `-isEqual:`.
Could you remove these dependencies from the `package.json` before I merge this pull request, we no longer put the dependencies in here because it becomes a message, and suggest people put the required dependencies into their hubot's `package.json`.
Since it's a throwaway, I would also generate (really small) certs with some email like dummy@example.com and check them in so that the demos just work.
Not sure. I changed it back.
Why is that needed? The user already *is* a superuser isn’t she?
adding a methods section would mean documenting all of them

I am -1 on this and it automatically appears in the sphinx doc + when you tab complete in ipython or any descent IDE
true, changed it to 1 Hz
här har du det: http://www.assembla.com/spaces/akka/tickets/1834-durable-mailboxes-should-not-log-enqueued-messages
Because otherwise NPEs and other funny things occur. We should only ever call preRestart() once on one Actor instance.
Needs earlier permission check,
you must not use a transmuter an ddeclare the drivercontainer, but use the media-alchemyst service provider
I'm really excited to see this shaping up so nicely!
These errors disappear by adding an overload to boost::get_pointer in "boost/get_pointer.hpp". The problem therefore is not with cpp-netlib or your changes. I have written a quick patch on my machine to workaround this for now and I will continue testing with MSVC 2012.
data-lift="..." really is the new way. It's a feature of HTML5.
I wonder if it would be useful if nova-gridcentric-common contains all of the python code need by the different parts. Then each deployment package just needs to worry about what init scripts, config files, etc. it should modify. And for development we don't need to be aware of where this code lives, and will we be able to access it.
Looks like this is the only ReddwarfError that has a mandatory parameter in its constructor. Guess we'll have to pay extra attention when throwing it.
The bigger issue is that fake mode needs a way to be data driven. We can do that, just probably shouldn't do it now.
commented, needed?
I don't like it but I can't think of an alternative... yet ;)
There is nothing in cache as this method overrides the default one in superclass which loads data into cache. This test is designed to confirm that entries are loaded from cacheloader
Looks like you wouldn't need a separate key parameter if the stateConsumer.addUpdatedKey call was in a separate method.
We need to initialize/reset the ``resourcePaths`` in the ``load`` or ``doLoad`` method as the source might vary.
please use the same case for the class name and the file name. Otherwise the autoloading would fail on case-sensitive filesystems (activating Travis on your fork would show it as Travis VMs are using Ubuntu)
I was exposing a method already there: https://github.com/libgit2/objective-git/blob/1f329db5eed5da1c90eb048f7f4c13f0fb20b993/Classes/GTReference.m#L271
Yeah -- I wasn't expecting pixel perfect, obviously.  This is something that just has to be manually verified for now.  Looks to be fine in general.
@WeatherGod: No problem, as far as I can see.  The backends that were using self.window.show  also had methods self.show that were defined as self.window.show, so the difference between patching in self.window.show and self.show was zilch.

Ginput works fine on macosx after this PR.
debug_backtrace() ?
If there are plans for theme generation for MediaWiki and Roundup, then it might be a good idea to keep all the stubs in a common sub-url. So here, could use e.g.

    (r'^\/+theme-stubs/wp/index$', 'mysite.base.views.wordpress_index'),
these divs are not necessary (probably copy/paste)
@kukulich Regarding supermajority, 2:1 is 2 out of 3 respondents; in the voting systems I'm familiar with, 50%+1 is a majority, and 66% is a supermajority.  Not trying to nitpick. :-)
Just me again about license headers. :)
indention in this function is flawed, it should be

for (int32_t i=0; i<size; i++)
{

}

and

if (i==j)
<tab> ...
else
<tab> ...
Tady tenhle if trochu nechápu, mohl bys prosím přidat komentář? Kdy může být count < last_relative_time? Když se ten count registr přetočí? Potom ale absolute_time by mělo být (MAX - last_relative_time) + count, nebo-li to, co zbývalo do přetečení, plus to, o kolik se to stihlo od přetečení posunout?
@jferris Are you thinking the advantage of interpolating is that we wouldn't have to change this value as often?

I feel like that could come with side effects: I create a Suspenders app while experimenting with Rubinius.

More importantly, I don't think it reveals the intent of this value, which is supposed to mean "use the latest stable version of Ruby."

Just pushed a new version in 700de0e to better communicate that reason.

Ready for re-review.
Right, it is fairly cheap. I might end up backing it out just to keep it consistent.
aside from being a spinal tap reference
- Could you add a ``@return`` annotation?
- Is it possible to add a ``@param`` annotation for parameter ``$username`` which defines a more specific range of types; something like ``string|array``, or ``null|MyObject``?
statische DB Variable verwenden die es schon gibt.
This is wrong. RequestParams doesn't set headers, it sets GET/POST parameters. The header is set like this (or similarly):

    client.addHeader("If-Modified-Since", RFC822DATEFORMAT.format(new Date(cachedFile.lastModified())));

With this in the class:

    public static SimpleDateFormat RFC822DATEFORMAT = new SimpleDateFormat(
            "EEE', 'dd' 'MMM' 'yyyy' 'HH:mm:ss' 'Z", Locale.US);
Forcing to array will not allow to use iterators here
If the version is 5.0, this will attempt to remove the index twice. Looks like a bug.
Good catch. But now you have to think about common users (deployers of this portal) who would like to change template a bit. It is good that they do not have to know all the details about where everything is stored. To ease them (and because the whole e-mail is exactly about this confirmation) I would leave this in. Because it is easier to use. Now that I think about, I would even add user's email address we are confirming to the template directly.

This also helps later on, if we decide to change internal implementation where we are storing tokens and so on (like we could store multiple tokens for each request ...). So it is better to give exactly the information this confirmation is about: token, e-mail address and user for which it is.
It shouldn't be. It should be None, undefined.
Why additional `div`? Why not simply `li` with that class?
Please use our [code style](https://github.com/wlanslovenija/PiplMesh/pull/199#commitcomment-1707793).
Yes, because our map has the same width and height (actually, this number is computed from width = 450px, but I see now that our map has width=260px, was it changed lately?). Anyway, should I write in comments what is a formula based on map width and zomm level?
Yes. Check and do it. And also for username. Check the length in nodewatcher.
Name it `v1`. This is for different versions.
Still too much code:

```
template_name = 'user/user.html'
document = models.User
slug_field = 'username'
```

In urls.py you name the username regex capture group `slug`. And everything else goes automatically. :-)
Sorry. :-)
I added --all that will export all plugins. By default it will only export Markup Plugin.

I used reverse relations now.
We're using Markdown Deep?
discussion about what? brackets? pfff
I thought it was best practice to use local variables -- i.e. @variables -- and not reference the node object directly in templates? Seems you've undone a lot of that in this patch...
K.a. aber IntelliJ hats als obsolet betrachtet.
Wenn man ins Detail eines Bieres wechselt und wieder zurückkommt wird das auch erhöht. (in Onstart wird der Task angestossen).
Sollte aber bleiben. Mit toggeln zwischen Beerdetail und Liste wird der Pagecount immer höher. 
Es führt nicht zu problemen soweit ich das sehe, aber ist etwas unschön. Wenn du's grad siehst noch fixen ansonsten vorerst lassen.
Symfony does not use ``use`` statements for classes in the global namespace
Hi,

Would have to look at the sources, but I'm not around my PC (on vacation
until late next week).

I'll try to remember to have a look when I'm back home, if I don't reply
until the end of next week, don't hesitate to send me a reminder ;)

JP.
On Sep 24, 2012 11:30 PM, "Bryan Smith" <notifications@github.com> wrote:

> In drivers/input/touchscreen/cy8c_tma_ts.c:
>
> > @@ -635,7 +636,7 @@ static ssize_t cy8c_hw_reset(struct device *dev,
> >  static DEVICE_ATTR(hw_reset, S_IWUSR,
> >  	NULL, cy8c_hw_reset);
> >
> > -static struct kobject *android_touch_kobj;
> > +struct kobject *android_touch_kobj;
>
> I tried to impliment this in HTC Ville (one S) source and am getting an
> error upon compiling the actaul s2w-switch.c file that this function is
> undeclared prior .... gahhhhh... if you have advice i would greatly
> appreciate it
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/faux123/msm8660-htc-ics/pull/9/files#r1678152>.
>
>
should we really default to `unsafe` ?
this means all the switches would have been considered inline and implies that you haven't even tested the feature thoroughly ;)
Now that I'm taking a closer look... you might need to rethink... what if the 'discriminator' isn't a string?  

I know in this case, it's likely the 'starts with' queries won't possibly work... but we probably need to figure out how to deal with an object (dict or list) and not just a string.
json.dumps chokes on a lot of different types, I'd suggest wrapping this in a try: except block so you can handle json encoding errors nicely.
Doesn’t the plug-in manager have a method that does this already?
nuageToken?
does this need a safety maxiter, checks if problem is well defined?
Can you check to see if error is !NULL before calling g_error_free? Otherwise, I think we will get a warning in the logs.
Don't we already use the RNG in boost math??
Mention: For an example of how you could do bulge + disk, see demo 3? (which is the first place the Sum appears)
Have pushed an edit to address this request, thanks I think it's an improvment.
good catch, I didn't notice in my testing since most definitions aren't changed by it anyways. updating...
This commented out code has been kicking around in here for a while, just removing the clutter for now.  If/when we go back to think of a better way to do installs, we can figure this out again.
I'd use `checkNotNull(factory, "factory")` to catch the NPE earlier.
If this one is const, maybe newline, encoding, and indentation should be const as well. I don't have a strong preference as long as it's consistent where possible.
Yes, kdevelop used tabs sometime depending of previous line. and now i use netbean which use space. Also cmyth use sometime space sometime tab. What can i do ?
maybe this should read "mutually exclusive" ?!
Yeah, we'll switch this to default when we merge. After Chef 11 I think we can move this stuff back into the attributes file.
This is actually called from `ProductsHelper` and `shared/_taxonomies` partial within core. This method definition should override the one already there.
You don't need 'Favorite Foods' in quotes here, but it should be fine with them, I guess.
If this is true you'll leak DropJob, right?

Also, why check DropJob::acceptsMimeData above, and here again w/ some different drop flag types?
I think #add_user_role and #remove_user_role may not be in the right location...
and please use #is_a? when checking object type.
Yea this is all wrong and doesnt follow the pattern we use today. Kick it off in ui.initialize.
Please add I18N comments here for translators.
misnamed file.
Added an issue for it: https://github.com/aeolus-incubator/thor-cli/issues/4
Just a typo to the method below s/getbaseURL/getBaseURL
Not sure why the entities were replaced here.
чтобы можно было создать один тип Comparator для и -i , и отсутствия -i.
@shacker Fix this file?
What is this part doing? I don't understand... Maybe a comment should explain it.
sorry for that...
Returns. Not sure if that is important here, though.
Sorry about this, I think I am just so fascinated to use the pipelined though without a transform function pipeline does not allow me :) and will correct it to the right way. 

I just wanna use this to use spectral clustering to test the embedding.
> I think including which target-vector k causes the warning could be useful.

+1 @ibayer . It's really nice to see you making very useful comments on
PR.
навіщо нам x-dev?
добавил в ридми
why no join?
Please make explicit by adding a comment to that effect above the copy ctor and assignment signatures
The logic for the set of blocks should probably be outside of the putBlock method.  Maybe break it out into an `addBlock:inRequest:atKey:` and have it call `addObject:inRequest:atKey:` passing `[block copy]` in the object parameter? And maybe a similar method for `removeBlock:inRequest:atKey:`?
huhuaehuaehuae sim, eu nem sabia que existia essa palavra
`has`
`has`
`has`
`has`
`has`
`has`
`has`
`has`
`has`
`has`
`has`
`has`
`has`
`has`
`has`
`has`
no worries, I do the same mistakes. It's much different reading other's code than reviewing self written stuff.
if cache is always IInterface's , wouldn't it better to use PointerIArrayOf<X> and let it own and dispose of?
Don't you need to call init on hashtables 0..numHashTables-1?
Might suggest a different method name, like `tipNumber`, to make it clear that this is an analogue of `tip` (which is admittedly a bit of a misnomer currently).
wouldn't be better to add this action in the end once the build id finished instead of adding it i the beginning  and checking if the build is finished or not?
Thanks, I didn't thought about querystring format. I'll push modified code soon.
I think JSON is too complicated to write by hand on a command line
String s = "Invalid event type(s): " + Joiner.on(", ").join(badEvents);
    return Response.status(Status.BAD_REQUEST).entity(s).build();
yeah, I noticed that ... I think Rohit missed it ...
Usually that would make sense but I think I interpreted the semantic meaning of label incorrectly. After reading the spec, it seems like span is much better for it.
OK, I removed this sentence.
Won't we know already by this point that the class is found?
ok, 會修正
@cursedcoder I looked at the Twitter doc about the api. And I confirm there is an issue. Here is the result for my own timeline with a count set to 5. there is [only 4 results](http://api.twitter.com/1/statuses/user_timeline.json?screen_name=Stof70&count=5&exclude_replies=true)
and when setting the limit to 10, I only get [6 results](http://api.twitter.com/1/statuses/user_timeline.json?screen_name=Stof70&count=10&exclude_replies=true)
A comment on the diff
Destrukturointi tekee elämästä helpompaa:

~~~clojure
(defn contains-point? [[left bottom] [right top]] [x y]]
  (and (<= left x right) (<= bottom y top)))
~~~
Tässä voisit kutsua edellä määriteltyä funktiota `authors`.
I agree with Jose.
Has this been tested in Linux or Mac?
no check for out of range access, deliberately so, assuming that everything will behave correctly?
Good point! I'll do that.
Some of these `get` functions, e.g., `getModelView`, might have to do computation so we have to call them.  However, others, e.g., `getView`, just return the property.  So I guess we are more consistent (and safe) by always using the getter.  However (again), I would say that this consistency is institutional, and not all that useful (except if, for example, getting the view matrix suddenly required computations, which I don't foresee), so I'll remove the getters for the ones I can.
I think this is an important optimization, but doesn't need to do done as part of this pull request.
让这个StateManager作为单例比使用一个预先存在的全局变量更好吧，这样就可以减少其他人不小心再实例化一个StateManager的可能性了。
Typo `Alet-based`->`Alert-based`
effectively, thisObject == eventKrollObject