Community Edition 3.8.6 Release Candidate 1

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-7995 - Various minor valgrind-reported issues

Running valgrind on thorslave (while running the thor regression suite) reports
various uninitialized memory accesses.

This fixes the first batch of them.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge remote-tracking branch 'origin/candidate-3.8.x' into candidate-3.8.6

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Community Edition 3.8.6 Release Candidate 2

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-8004 Wrong user descriptor when accessing Distributed Superfile

in dadfs.cpp, CDistributedFileDirectory::getFileDescriptor and
CDistributedFileDirectory::getFile both are passing NULL to the
constructor for CDistributedSuperFile. This action, which takes
place at the client, causes the default dali user (daliuser) to
be passed to ESP and eventually to dali.

Signed-off-by: William Whitehead <william.whitehead@lexisnexis.com>
HPCC-2942 Configmgr - Add custom attributes

- In XML View selecting opening the context menu will bring up a
  menu option to 'Add Attribute'
- A dialog asks user to enter attribute name
- Refresh will return focus to previous location

Signed-off-by: Gleb Aronsky <gleb.aronsky@lexisnexis.com>
HPCC-7884 Detect superfile error on reload subs

Fix errors in new superfile corruption test, leading to false positive
superfile corruption reports.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-7884 Detect superfile error on reload subs

Fix errors in new superfile corruption test, leading to false positive
superfile corruption reports. And actually remember to add them this
time.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-2942 Configmgr - Add custom attributes

- Changes based on feedback
  - Extra error check
  - Fix error message

Signed-off-by: Gleb Aronsky <gleb.aronsky@lexisnexis.com>
Merge remote-tracking branch 'upstream/candidate-3.8.6' into candidate-3.8.x

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
HPCC-8011 xmlsize crash fix

The xmlsize utility was crashing due to a missing call to InitModuleObjects

Signed-off-by: Jake Smith <jake.smith@lexisnexis.com>
Merge pull request #3487 from garonsky/issue-2942_Add_Functionality_to_add_custom_attribute

HPCC-2942 Configmgr - Add custom attributes

Reviewed-By: Kevin Wang <kevin.wang@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #3486 from RussWhitehead/daliUser

HPCC-8004 Wrong user descriptor when accessing Distributed Superfile

Reviewed-By: Jake Smith <jake.smith@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #3489 from jakesmith/xmlsize-fix

HPCC-8011 xmlsize crash fix

Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
HPCC-8016 Ensure global sort order recalculated when grouped order lost

Signed-off-by: Gavin Halliday <gavin.halliday@lexisnexis.com>
HPCC-7825 Document roxie file copy settings

Signed-off-by: JamesDeFabia <James.Defabia@LexisNexis.com>
HPCC-8018 - Dynamic array causes Windows build failure

Replace dynamic array variable with alloca, as a 'quick fix' for compilation
errors under Windows.

Signed-off-by: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #3493 from ghalliday/issue8016

HPCC-8016 Ensure global sort order recalculated when grouped order lost

Reviewed-By: Renato Golin <rengolin@hpccsystems.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>
Merge pull request #3497 from richardkchapman/superfile-compile-issue

HPCC-8018 - Dynamic array causes Windows build failure

Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merge pull request #3480 from richardkchapman/valgrind-thor

HPCC-7995 - Various minor valgrind-reported issues

Reviewed-By: Gavin Halliday <gavin.halliday@lexisnexis.com>
Reviewed-By: Jake Smith <jake.smith@lexisnexis.com>
Reviewed-By: Richard Chapman <rchapman@hpccsystems.com>