labofsahil/github-event-dataset-2012 huggingface dataset:
I'll respectfully disagree simply because the patch build value is
hardcoded. I'd rather a configurable option default to '.build' than have
some one else hunt for like I did :-\
On Oct 8, 2012 6:06 PM, "Laurent Sansonetti" <notifications@github.com>
wrote:

> In lib/motion/project/vendor.rb:
>
> > @@ -184,9 +184,13 @@ def build_xcode(platform, opts)
> >        end
> >      end
> >
> > +    def configuration_build_dir
> > +      File.absolute_path(@opts[:configuration_build_dir] || 'build')
> > +    end
> > +
>
> I believe that c66f4fa<https://github.com/HipByte/RubyMotion/commit/c66f4faeff42db3d27b1a21f5ed68a18e1fa7a85>is a better solution, as it's simpler and does not introduce a new option.
> Using ".build" is probably safe enough.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/HipByte/RubyMotion/pull/44/files#r1790157>.
>
>
The Configurator.php is the class under DependencyInjection folder for every bundle at least somewhat standard, this is the configuration we are after to try to dump it
It's `null|\DateTime` not `date`
Sorry what do u mean by 'Also use space. '
@stas Committed, thanks :)
It'd be good to add a test that expects we're setting this transaction level, with the test name explaining why it's needed.
when upgrading to php5.4 nasty things will happen if we will use isset instead of in_array =)
hmm indeed. This is the id of the service. I commented without checking the FOSUB source to confirm the id :)
hah! yeah, as soon as we annotations we can make it `@protected` maybe?
Please drop anything that isn't necessary. after all, you're not instantiating those :)
It is actually part of the PR, we want to enable this for people that want to go more torwards Active Record.
Is this covered by `load_and_authorize_resource`?
Not sure what these mean, or how I would use 'before_filter' in a controller
Is `array_merge()` used here on purpose ? Couldn't `+` be used instead ?
Yep, that was it.  I put it back in, added a message to the body of the HTML so the user would know the log messages were written.
No more `bcrypt`? I mean, it doesn't really matter as we're using BrowserID, but why no `bcrypt` for `1.4`?
Space before `action` attribute.
this is causing issues with lint, realPaused has never been defined
Scott, because this is repetitive, I am trying to think of some way to refactor to make it DRY. It looks to me like in all these cases, you can achieve what you want by tacking on the message to whatever is in flash[:notice]. I would suggest def'ing a method that just does:

if !@collection.nil? && @collection.moderated?
  flash[:notice] ||= ""
  flash[:notice] += ts(' Your work will only show up in the moderated collection you have submitted it to once it is approved by a moderator.")
end
(or some other text that would make sense in all the cases), and then just call that method AFTER you've set the flash[:notice] = ts('Work was successfully updated.') or whatever other thing.
I'll try to have a look at the changes tomorrow. I'm surprised that
soundtouch is involved, I thought it would be a purely gstreamer
modification, not involving clocks or anything tricky like that. But
concerning the TODO on video for soundtouch: if you cannot process video,
you should force video=0 in the type!
I think the tests should be in test/patch.js since that's what we're changing
Should this be used in the normalize file?
i guess we should also add location?
This is what generic class based views were invented for. If time allows and you feel like it, try to refactor to that in a branch.
I have placed the configs under 'config/ondemand' because they should not exist in the root folder.
wanted the response back from Start to ensure that the channel has been set up and is ready to accept messages.  Avoids the need for a channel listener (at least initially).   Using tell, in my tests, I would get the actor back, then block waiting for the channel listener Started notification to fire, or risk the chance of sending a message to the actor before the channel was available.  I would really like to some ideas on how to handle this better. 

I can probably do fire and forget on the producer side, and leverage then do the basicPublish when the future is completed.  The consumer side seems like a different story since fire/forget would result in an ActorRef, but the consumer not ready to receive messages yet since the channel may still be in the process of being constructed.  I'm not sure how applying a future channel will help when it's purpose is to consume incoming messages.  

That puts me back at using a channel callback to let the client know the state of the channel, which isn't a bad thing.   I'm very interested in your thoughts...
Should not we also reset m_bIsAllocated to false here?
It'd be better to use our `HashCode.compute(...)` method. Or better yet, why not just `return repository.hashCode()` ?
NexusHTTP404
Please help me get a better name for this :thought_balloon:
This assumes your host is running on Apache. Can you edit this so I can run this from php-fpm and nginx?
I wonder if it makes sense to fold this into the function above? Calling both would prevent it being used from the command line easily.
Do we need a lock of some sort here? It seems possible that `self._future` could be changed from `None` to non-`None` by another thread in between the check and the assignment to `self._future` below.
Here is API for registering the severity map...
Please remove this line for accepting. =)
right, my bad
Thx, I don't know use case of with_stmt.
This error will be thrown when the 'public-key' key doesn't exist. The error message does not make this obvious to me: the public key isn't malformed, it just can't be found in the well-known file.
Okay. I agree that an unnecessary amount of debugging makes the code cluttered. But a few well-placed debug statements in key points don't hurt. :)
ok, i'll fixed it tomorrow night. gracias
If there's really no else clause, probably better to use `when`
Well, the thing is that I think that he and I have agreed that  doing it "right" means "not doing it in the PuppetDB terminus code", most likely.  Which means that there is a limited amount of payoff for spending time on this approach.  At this point one of the main reasons I'm interested in getting this series of commits merged is because it decouples us from the indirector for our HTTP command submissions and seems to me to be generally a step in the right direction as far as refactoring for separation of concerns.  It's by no means perfect but I think it's progress.
I forgot to mention that under the hood `rebuild!` is now mapped (using `alias_method` to `rebuild_with_invalidate_cached_urls!` so calling `Refinery::Page.rebuild!` executes our new method instead.
Assuming marketable urls are used.
Added in a check that uses the same login id validator as the main create user function.
If we're going to allow people to crop an area out of their picture it might be OK to allow 5MB. Most camera's have pretty big resolutions so 5MB doesn't seem like all that much anymore.
Actually, the me feed should not take a user. We can adjust so it just uses req.ctx.user(). I know this bug already exists, but we can probably use this patch to make up for it.
```
PrincipalsAPI.getMe(req.ctx, function(err, meData) {
```
I find the following to be a bit easier to read:
```javascript
var commentIds = [];
for (var i = paging.startIndex; i < pagedRows[0].count; i++) {
    commentIds.push(pagedRows[0][i].value);
    timestamps.push(pagedRows[0][i].name);
}
```
Correct form would be "chosen". So the correct sentence would be "One note chosen." "Two notes chosen." etc
Why did you reformat this part?
the reflect Call method expects a []reflect.Value so this converts our arguments into one of those.
What's to trim on the right side if you append a slash?
Проблема не в быстродействии, а в том что вы можете мутировать один и тот же элемент несколько раз.  И тогда это будет не СТРОГО Х процентов, как просят в задании
Until we have an actual jsc version, don't include this file.
Please align the `=` signs
Shouldn't you at least make the write-console take the stream keyword and ``ignore`` it for now?
1 vs 2 is very Unix specific. Please just make this pass a symbol ... ``stream: #"error"`` and then the platforms can do the right thing and it is clear what is happening.
Should this disposable be added to `self` using `-rac_addDeallocDisposable:`?
Just curious why it doesn't get disposed when the test block completes, but no biggie.
Can you please [use dot syntax](https://github.com/github/objective-c-conventions#expressions) here?
Missing command docs. Is 'ping hubot' the command?
Use symbols: ```Vote.human_attribute_name(:about)```
why send? #instances appears to be public

https://github.com/intuit/simple_deploy/blob/issue103/lib/simple_deploy/stack.rb#L77
Could you please split this test into three smaller ones?
This should allow you to have more explicit test method names and possibly get rid of the comments.
Would it be worth adding a check like `isinstance(m, (type, types.ClassType))` or `inspect.isclass(m)` before appending here (so as to give a more informative error)?
``` Python

def test_access_by_name():
    """Test accessing epochs by event name
    """
    assert_raises(ValueError, Epochs, raw, events, {1: 42, 2: 42}, tmin,
                 tmax, picks=picks)
    assert_raises(ValueError, Epochs, raw, events, {'a': 'spam', 2: 'eggs'},
                 tmin, tmax, picks=picks)
    assert_raises(ValueError, Epochs, raw, events, {'a': 'spam', 2: 'eggs'},
                 tmin, tmax, picks=picks)
    assert_raises(ValueError, Epochs, raw, events, 'foo', tmin, tmax,
picks=picks)
    epochs = Epochs(raw, events, {'a': 1, 'b': 2}, tmin, tmax, picks=picks)
    epochs.drop_bad_epochs()
    assert_raises(KeyError, epochs.__getitem__, 'bar')
    epochs.save(op.join(tempdir, 'test-epo.fif'))
    epochs2 = read_epochs(op.join(tempdir, 'test-epo.fif'))

    for ep in [epochs, epochs2]:
        data = ep['a'].get_data()
        event_a = events[events[:, 2] == 1]
        assert_true(len(data) == len(event_a))

    assert_true(epochs2['a'].events.shape == epochs['a'].events.shape)

```

Maybe a bit paranoic but feels safer...

On Sat, Dec 15, 2012 at 6:54 PM, Eric89GXL <notifications@github.com> wrote:

> In mne/fiff/raw.py:
>
> > +    ----------
> > +    index : list-like | int
> > +        List of ints or int representing points in time.
> > +    use_first_samp: boolean
> > +        If True, the time returned is relative to the session onset, else
> > +        relative to the recording onset.
> > +
> > +    Returns
> > +    -------
> > +    times : ndarray
> > +        Times corresponding to the index supplied.
> > +    """
> > +    if isinstance(index, int):
> > +        index = [index]
> > +
> > +    index = np.array(index, dtype=int) + (first_samp if
>
> Don't know actually, that code was copied and pasted from before. It seems
> unnecessary to me, too, I'll get rid of it. I'll also add that test
> @dengemann <https://github.com/dengemann>.
> ? <#13b9fb3b82b1841c_>
> On Dec 15, 2012 2:20 AM, "Alexandre Gramfort" <notifications@github.com>
> wrote: In mne/fiff/raw.py: > + ---------- > + index : list-like | int > +
> List of ints or int representing points in time. > + use_first_samp:
> boolean > + If True, the time returned is relative to the session onset,
> else > + relative to the recording onset. > + > + Returns > + ------- > +
> times : ndarray > + Times corresponding to the index supplied. > + """ > +
> if isinstance(index, int): > + index = [index] > + > + index =
> np.array(index, dtype=int) + (first_samp if why dtype int as you divide by
> a float after? ? Reply to this email directly or view it on GitHub<
> https://github.com/mne-tools/mne-python/pull/273/files#r2428162>.
>
> ?
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/273/files#r2428708>.
>
>
source_ was suggested to me by the input named "stcs"
can it accept a np.array?

regarding bands would it make sense to average the connectivities for the frequencies in each band? so just a post processing of what you give now. It might just be then more memory consuming this way but maybe we can leave with that.

+1 for fskip especially considering the smoothness of the curve output by the example.
_data is private so nobody is supposed to modify it, I would just use numpy indexing , i.e. 

    if preload:
        new._data = self._data[index]
since we're returning unresolved dependencies, can we rename this as unresolved
There is no need for a note in my opinion because we shouldn't change the line above. We should just change just the line below which will affect only new apps.
We should document that they should run git checkout develop after this line to make sure they are working in the develop branch and not off of master, same for line #49
No, we can't because ``class BaseFactory(metaclass=BaseFactoryMetaClass)`` will raise SyntaxError under python 2.
maybe make it a `m (HttpReq s)` with `m` being `Monad` and use `fail` vs. `error`?
I guess what @sorin-ionescu suggested was using `ruby-info` in this method instead of having something specific for rvm only. (and maybe change the plugin name to `+borra-ruby-info`).
You should place a `$ ` in front of every bash line
Jip, I'ts also got a lot of commented-out System.out.println() statements which should be removed.
If you're merging two orders together, wouldn't you need to nullify one of the order's line items? For example, if a variant only has 5 stock items available, merging it like this would cause it to go into backordering.

I would recommend clearing the old order's line items as you iterate through them, i.e. in a call right before `add_variant`.
was the deletion of this file intentional?
Detalle muy tonto: ¿estas las expresamos en primera o en tercera persona?
Won't this forcing of when to load Forge break OptiFine, since it's supposed to be installed _after_ forge? Perhaps the addition of an exception/test for OF would solve the issue?
One good reason is that in tests, $timeout is mocked out with a pseudo-synchronous version that can be manually flushed!  This might help with your testing issues.
Getting rid of global variables!
I do not really get this, as you take the LongitudeSpan but add it to the Latitude. Additionally you should comment that e.g. your tests showed that it is OK to ignore the difference in map distance for different orientations (instead of taking the smaller or the larger distance always)
I wondered for a moment why you were shelling out to echo | bc to do something like multiply numbers until I looked again and saw this is a shell script

Details matter!
Because they can't be null.

Sent from my iPhone

On Jun 9, 2012, at 9:35 AM, "Michael Basnight" <reply@reply.github.com> wrote:

>> @@ -25,11 +27,12 @@ def upgrade(migrate_engine):
>> 
>>     # add column:
>>     instances = Table('instances', meta, autoload=True)
>> -    volume_size = Column('volume_size', String(36))
>> -    flavor_id = Column('flavor_id', String(36))
>> -
>> -    instances.create_column(flavor_id)
>> -    instances.create_column(volume_size)
>> +    instances.create_column(Column('flavor_id', String(36), nullable=False,
>> +                            server_default="1"))
> 
> its server_default? really? that seems so very odd :D Why do these have defaults anyway?
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/hub-cap/reddwarf_lite/pull/110/files#r955723
I like the idea of being explicit here.  There will always be some options that don't make sense in this context -- the "configure subplots" button, and the "save" button which needs to behave differently.  I suppose we could always just copy the first few, but I was worried that would become brittle if the standard GUI set of buttons ever changed.
These files should be added to the ```.gitignore``` file rather than being part of the repository (otherwise, simply changing the interpreter used in the pydev project, as one may do to test different python versions with mpl, would trigger an unnecessary source change).
Yes -- forgot to update the docstring.
Maybe each writer should have a default extension?
I don't know about the removing of run_tests() and replacing with run(). I think that's a call for Jeff. The self.report_disconnect() call needs to be moved into run_tests if you're going to remove this exception otherwise, I don't think we have any notice of the disconnect. Probably need Jeff to confirm that though.
Move the TODO onto the line above and reference the bug that's blocking you from accessing edit button.

Also it's not the home button that's causing the problem, it's `long_press`
Nit: s/baner/banner
a) Are all changed
b) I don't find a way, to remove one. All the variables in the class header are needed in the complete class. Could you pls give me an example?
c) I looked the code, but I can't split something. Everything looks so complicated because listen, receive and send are all asynchronous. Every method is somehow depending to one in this class.
d)done.
Maybe my formulation was also not ideal. What I mean is something like this

```
Every methods accepts a string, or an object with a __toString method as message. Implementors MAY have special handling for the passed object in which case they MAY forgo casting the object. In all other cases, implementors MUST cast the message to a string before proceeding.
```

That is what is intended here, no? The difference simply is that casting is optional (depending on the object), but not required.
Assuming that we can never get multilines DEFAULT field values (because of MYSQL doesn't support DEFAULT for TEXT/BLOB) I think I solve this in https://github.com/hastenax/phpmyadmin/commit/0249919c15d132f39374f6fdb40533827411a853
@gsilver Seems like you removed the newline at the end of the file - that shouldn't be the happening.
We always need one extra line at the end of each file in order for git not to complain.

http://stackoverflow.com/questions/5813311/git-no-newline-at-end-of-file
Why did you add an extra "1" to "fm1"?
please use a whitespace after if, i..e
```
if (chain_search(...))
```

same with for loops everywhere etc
please don't  add 

#ifdef DEBUG_NEWTONSVM around
 SG_SPRINTS 

in the final version we don't want debug outputs.
Yes it is a convention - SGVector is meant to be able to SGVector a,b; a+b; a*b and other operations... So it was already a bug in the previous code.
Why are you removing the default value setting?
it's obvious
This query should go to the repo as done with getIndexBatch()
Don't we have to walk a linked-list here checking each one for a matching name, can't there be more than a single pool structure we could match?
More changes to correct column-store recno handling for implicit records.
I like how you've added a test but it'll fail with non-English locales.
We should kill the color options.
Should the return type not be "array" instead of "type"?
Put comment on two lines
This is close on how the options class works. Take away the equals "=" at the end and it just becomes a flag. If it exists, it sets it to true. Otherwise it keeps it false. Less code to look at as well.
this has to be at authPort because browserid treats the web port different from the actual port. on the server, we are running through ssl, so port is 443. but the proxy runs through port 8000 so socket connections have to be through there.
Well, if by some reason Fiber, we wish to resume in, were resumed erlier, than `next_tick` occured, than we could have FiberError very easely, for example, when that Fiver has already stopped its execution.

That uncaught FiberError seems to kill event loop. But other question: should it be a signal, that we do something wrong (cause no one should resume, or should it be silently hidden?
Check is often called and return value checked.  I think this might cause a few problems ... you think?
btw, you should probably drop the file entirely as the bundle does not have any testsuite
`?:` syntax is PHP 5.3 only.
Will we need to re-index everything because of this? Can we also check for datetime.max and ignore that as well?
Uhh, I am afraid of such CSS selectors. I would much more prefer that you wrap the whole form into some id-div (or just add id to li). And then simply hide all labels inside that id.
Uh, you should really update from main repository. Quite old code you have here. ;-)
For the second part, OK. Leave it then like this.

I see that in their example they have `!=`. :-) So I don't know. Probably we can leave it.
Some ideas for the content:

https://github.com/wlanslovenija/nodewatcher/blob/master/nodewatcher/frontend/templates/registration/activation_email.txt
`return false` here as well. We found our blog post, so loop can end. Just comment is already there.
Move this to class-level attribute. Don't have long data defintion in function. (You have to define it only once, for the class, not that it has to be evaluated/executed on every function call.)
remove "to databases" since console doesn't write to databases, and some others could write to other things
Please fix the coding standards
No :). Never wondered why they will introduce a Password library to PHP 5.5 ? Because the current syntax of crypt is... cryptic ! (that's why I use the Bcrypt class from ZF 2 instead, it is clearer).
I agree, at least the printStackTrace is not what should be there.
I will remove it (since there are other API changes in this release).
that is clever. Done.
And might skip braces.
Maybe a small comment about the the template getting a `min-width` from the `.profiler-event-small`declaration.
The possibility of rounding to `0` tingled my spider sense.
Should probably be a QStringList.
Let's get rid of these newlines at the end here.
On 07/25/2012 10:06 AM, Skipper Seabold wrote:
>> +            Value of a nuisance mean parameter.
>> +
>> +        Returns
>> +        -------
>> +
>> +        llr: float:
>> +            Log likelihood of a pre-specified variance holding the nuisance
>> +            parameter constant.
>> +
>> +
>> +        """
>> +
>> +        sig_data = ((self.endog - nuisance_mu) ** 2 \
>> +                    - self.sig2_0)
>> +        mu_data = (self.endog - nuisance_mu)
>> +        self.est_vect = np.concatenate((mu_data, sig_data), axis=1)
> This is updated during the optimization correct? I think it should be passed around then rather than attached and read. It's a bit confusing to follow where things are getting changed and what's a set attribute.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/statsmodels/statsmodels/pull/326/files#r1235094
So do you mean instead of having est_vect as an attribute that gets 
changed during optimization, I just use it as an input in _modif_newton?
TODO

An alternative is to detach fit_regularized from fit.  This makes sense, since fit_regularized could grow and we don't want a bunch of patches.
I tried completely removing `KeyPath` and fixed a couple of specs in this PR (to make it testable and see the whole picture). @gbadiali, @camertron, please, have a look at [this diff](https://github.com/KL-7/twitter-cldr-rb/compare/f64c9dc4a14c7363b86ef6efe44e3a54c304734d...adding_ago). It completely fixes the problem with `units.hours-ago.1` and all the specs are passing (except [this](https://github.com/KL-7/twitter-cldr-rb/compare/f64c9dc4a14c7363b86ef6efe44e3a54c304734d...adding_ago#L10R64) that I'm not sure how to fix so I'm leaving it for you). If you like it, I can send these changes as a PR to @gbadiali. She will merge them into her branch and in the end they will be added to this PR.
Please put a \n after """

```python
def get_default_gateway_interface():
    """"
    Reads the ip address of default gateway interface
    """
```
...empty file comment?  We should replace this with the standard header.
in discussion 2
Is this a TODO about deprecating them, or are they now deprecated? I couldn't see any warnings or javadoc about them, but haven't looked closely yet.
It looks like it does fail with a null pointer exception in the latest version. Should we go back to setting the default location to localhost or make the location parameter required?
Can you mark this test as  `@Test(groups="Live")` please, and the setUp as `@BeforeMethod(alwaysRun=true)`, and include a tearDown with (alwaysRun=true) that does `if (app != null) Entities.destroy(app)`.

And please convert it from junit to testng so we have consistence.
Missing comma and default.
This is kind of a weird change. Why did you make it, and why didn't you do it to the other places?
You'll also need to tweak moduleupdates_installer
MongoLog::CON is missing from this test.
Can we please change all of those to:
Test for bug PHP-408: MongoBinData custom type is returned as -128.
Totally agree with you, I've been wanting to do the same for quite while

On Feb 22, 2012, at 8:09, Mark Story
<reply@reply.github.com>
wrote:

>> @@ -2592,4 +2595,26 @@ protected function _initInputField($field, $options = array()) {
>>        $this->_secure($secure, $fieldName);
>>        return $result;
>>    }
>> -}
>> +
>> +/**
>> + * Checks if the field is required by the 'on' key in validation properties.
>> + * If no 'on' key is present in validation props, this method returns true.
>> + *
>> + * @param array $validateProp
>> + * @return mixed. Boolean for required, null if create/update does not match
>> + */
>> +    protected function _parseRuleRequired($validateProp) {
>
> The allowEmpty check could be a separate method, or since its a simple condition, it could be inlined.  I think this parsing of validation rules, has cemented the idea for me that validation rules really need to be managed by some sort of object that contains all this logic.  Having it in both FormHelper and Model expressed in slightly different ways has been problematic over time.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cakephp/cakephp/pull/463/files#r475632
3-4 percent seems to be the sweet spot for air movement speed.
head happened. these are only directory includes, removing them should slightly speed up compilation. put em back in anyway
a comment what happens below would be nice
E putin ciudat ca sa fie gol constructorul.. Vezi comentarii pentru metoda test.
Can we rethink the way we have port in hwsettings? It's inefficient to have to add new ports for each new hardware target.
Why this comment was removed?
Could you please also add a fix for Chiliproject? They have `gem 'test-unit'`: https://github.com/chiliproject/chiliproject/blob/master/Gemfile
Надо Throwable ловить.

В случае tooLong надо ещё на два пробела сдвигать стек-трейс.
Надо кешировать результат этого метода.
А почему здесь comparator не используется?
А почему просто MessageType.BYE не устраивает?
Why is the DEBUG flag not good enough?
I take it that we don't allow creation of validator clients. Assuming that is the case, this is fine.
Please fix these comments, add spaces after #, remove `there`, `alll` is wrong, finish the sentence with a `.`. 2 lines should be enough, thanks.
I removed the gray scale branch, but any attempt to pare down the LAB branch led to failures.
Without reading the code it is not really clear to me what happens when arrays are passed...
Better use `column_idx` to be more explicit.
why do you make a copy of y ? it's not useful
I wonder if it's worth turning this into a benchmark, possibly including other implementations?
Even if not pep8, I think the rest of the scikit almost never uses trailing `\`. 

```
    T2 = nmf.ProjectedGradientNMF(n_components=5, init='random',
         random_state=999).fit(A_sparse).transform(A_sparse)
```
----------

not

======
how about transformers?
cf9bcc2
pass in **xml** parameter
I'm not completely sure what you mean. Is `stringValue` a better name?
Remove previous 3 lines. They have no effect on POD. Only the element type does.
added platforms section for 'enable' property
This is not handle the cases when module should load relative to current. So, for example having ui/module1 ui/module2. In app.js having require('ui/module1') in module1 having require('module2').
@anthonycabot when copy/paste some piece of code, wrap it inside \`\`\`  like this :

\`\`\`
my code ...
\`\`\`

it will be rendered like this : 

```
mycode ...
```

in yourcase : 

````
"termsOfUse": [
{
"locale": "ar_SA",
"terms": "ar_SA" /* Check this /
},
{
"locale": "de_DE",
"terms": "Ich bin ein Berliner" / What is the correct example ? */
},
]
```
I've done this, as well as extracted it out into the community-cluster localconfig/templates. It is very specific to the performance testing environment.
Now we have the optimal level chosen
Now that we have chosen the optimal level
yes, I will delete
This section should also include WAIT, which is a statement
The HT isn't pre-sized, (expanded on 1st addition), so I could create the CBuckets up front, if you thought the check in queryCreateBucket to dynamically create them is significant...
In the future this will be handled with `git subtree`[*](http://apenwarr.ca/log/?m=200904#30). At which point we wont need the recursive mess. Wont even need this whole thing!
I can see that, but what's the downside to being opinionated about it? A URI is, in essence, an ASCII String. The values in `Request#path_info` are Strings.
Ticket #12850 to figure this out in the future.
@EvanDotPro your example is incorrect. 

Unsetting a value from inside a numeric array changes it to an associative - that's by PHP design.

If you want to remove an element **from the middle** of a numerical array, you must use `array_splice()`. Below is your example modified to remove the middle value in a way, which correctly re-sorts the array.

````php
<?php
$foo = array('foo', 'bar', 'baz');
array_splice($foo,1,1); // remove 'bar'
var_dump(\Zend\Stdlib\IsAssocArray::test($foo));
Whoops, I now see that it should actually state "integrated" instead of "secondary".
why removing this method ? It is a BC break (for no good reason IMO as it could be used by some users and nothing in the code require dropping it)
Missing spaces (PEP8).
Could do with being less verbose, there are a lot of policy folders
It doesn't look like this logic has been moved elsewhere; will this break LAMP?
@author Naz Chan (LISAsoft)
One of our javascript convention gurus can chime in, but that sounds reasonable to me.
Mainly because all of our Core types follow this pattern.  I agree that you don't get as much benefit for it from Ellipsoid as you do with other types, but I think that being consistent does make the overall API cleaner.  It wouldn't be hard to make it prototype only (and go back to get methods) if we really want to, but I don't see a strong argument for either approach.
Is this what we intend given `show` is boolean?
All of my comments for `loadCubeMapSpec.js` also apply to this class.  I can point out the specifics if you want me to, but in general we need to test all cases.
reverted back to original. not using vertexArrayFacade
is any info about the error available?
Remove the service type check outside of the if/else statement here too.
I dunno, I see that to a certain degree as a hack and the comment being accurate (there is not a API point provided for detecting if the file is opened or closed).  fstat might be the best API point provided that can be used to check the desired state but the designed purpose of the API point is not to determine if the file is open or close.  Open call on a file can be used to check for existence but it's not what the API point is designed for (naturally I am not suggesting that is viable - doubly so given the "exists" API point).

If I remove the comment I feel that leaves with the incorrect assumption IMO that there is a purpose built API point but does not explain why it was not used.  I will update the comment to explain that the fstat approach can be used but was not selected based on the previously provided rationale.
Although defined on Node only Elements have attributes. Everything else will return null
what is `self.cfg['exts_filter']` is a non-sequence type (e.g. an int)? Maybe check for that as well?

Something like `assert hasattr(self.cfg['exts_filter'], '__getitem__')` ?
Add `amazon`?
Why is this a case statement? Can't it just do the following?

       yumrepo {  'postgresql-#{$postgresql::version::version}':	
          baseurl  => 'http://yum.postgresql.org/#{$postgresql::version::version}/redhat/rhel-$releasever-$basearch',
           descr    => 'Postgresql #{$postgresql::version::version} Yum Repo',	
           enabled  => 1,
           gpgcheck => 0,
       }

I would assume that if your override the default version of postgres then you want  to use the version specified.
Mmm...  This seems really strange.  Are these statements meant to work around some issue in Puppet?
No worries, it's XOR - I'll lookup the 1.9 equivalent :)
I don't think that's right, the interfaces require an implementation, then you require the interface ('cause you need it) + the implementation you chose of it, and I guess the implementation requires the interfaces too since it implements, but that should be no big deal.
Don't hard-code the file name. Maybe build plots for all files in the current directory.
Well, (unsigned) time_get() is more random than time_get()/time_freq().
You're right, 'except' is better. I'll commit that change tomorrow.
Bat as your pull is here to not call `opAssign`, why do you call a destructor? It's not necessarily here at all.
Upon further investigation firstOne doesn't cut it. The name suggested to me that some improvement e.g. no check on each iteration.
What needed is to stop emitting else after each if clause, not to do  something on first. To check that I use  last_one since  the last one doesn't have it. It's can't go much clearer then that.
To claim that one-line definitions for highly infrequent data structures definitions "add up" is rather tenuous. If there would be any gain in having them actually be the same type, that would be something. But as things are, we have some advanced library construction tips (the documentation is actually pretty good) mixed with what's supposed to be largely reusable code.
It works, and I already added a test for it (very similar to yours + more)

See https://github.com/Poita/phobos/commit/b6c9ffed919f0f3b683377d46c306c9a81a3502e#L0R1556
I can change it and commit it, but it would be easier if you just changed it to whatever you want it to be. What is in there was my best guess at the time. Just feel free to change whatever is in the POM.xml as it is not fragile.
You wanna milk me dont you ?
Integration Tests Hello ;-)
Should _MethodConstraintLocation_ not become _ExecutableConstraintLocation_ (the docs at least mention method and constructor)
Reorder these to match the super constructor. (Use Cmd-Opt-C in Eclipse, and it'll fix the call sites for you.)

You should also support the "standard" constructor.
done, I called the parameter "envelope"
Do not use version in internal names, changing version may happen, and it is therefore no more in sync. We use version in the classname for unicity and clarity, no more.
Here we convert the value to a double as it does not loose data because it is the larger of the types. If this fails then we try the default comparison.
Yeah, I think this was mainly a research project that's gone dormant. Not sure its much used anymore though. If Lee Byron's not accepting new changes, best you can do is host a fork with your changes so others can still use them. Maybe send him an email? Not sure if GH does that for these edits. I only see them in the notifications section when I log in (frequently).
Can you pull these into the `var` definition above instead of having them as separate lines?
Actually I think I can just .first() and .last() here.
Please remove trailing spaces.
I know we talked about this but now seeing it I don't think i like to include the code that has no chance to execute in the real SI application since there is no way today to remove nullChannel. And in tests that do not rely on fully initialized AC we usually inject BF with nullChannel registered via registerSingleton
Just making sure that the intention here is indeed to return a mutable Map
FWIW, "usingDefaultTemplate" seems like the right compromise to me (it doesn't require !, but it also doesn't contain the word "not" - best of both worlds).
I am not sure I understand. The attribute name is 'contentType' and the value is 'content-type'
~~the~~ parameter expression__s__
Do not you think, that there should be a different code path for that case? And actually earlier, then here. Why should the ENUM values be parsed in a List of values, like the  `postgresROW2StringLists()` is supposed to do?
This really should be
QString systemScopeFile = QString("%1/etc/palm/%2.conf").arg(systemScopeRootDir).arg(applicationName);

Also I think it would be cleaner to have the systemScopeRootDir passed into the initSettings method.
In general it is advised to use `.prop` instead of `.attr`. `.prop` can access also dynamic values.
I had it in a separate file at first, but since this is a demo page, some users (I usually do this) might want to check the page source to overview the code behind. It's nice to have all of the example code in one place.
Changed also ' to " for Seconds, 10 Seconds, Minutes...

On 29. 09. 12, at 12:48, Mitar <notifications@github.com> wrote:

> In tests/test_project/test_app/static/test_app/js/datastream.js:
> 
> > +                        if (debug) {
> > +                            debug.find('#debugTable tr:last').after(
> > +                                '<tr><td>' + $.datastream.metricName(data) + '</td>' +
> > +                                    '<td>' + granularity + '</td>' +
> > +                                    '<td>' + toDebugTime(from) + '</td>' +
> > +                                    '<td>' + toDebugTime(to) + '</td>' +
> > +                                    '<td>' + data.datapoints.length + '</td></tr>'
> > +                            );
> > +                        }
> > +
> > +                        if (data.datapoints.length === 0) {
> > +                            return;
> > +                        }
> > +
> > +                        // format data points
> > +                        for (j = 0; j < data.datapoints.length; j += 1) {
> Use jQuery .each.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
You should use `$params['subclass'] = $this->admin->getActiveSubClass();`
One per core? ... WS don't waste as many CPU as AS which uses crypto ... so I think it could be better 2 per core ... or configurable?
Spelling - Include, not Inclue. Will need to update this throughout the file.
This might become unmanageable once we start caching more information.
ostad man alan age projaro ro montaghel konam b xampp,smartgit haleish nemishe move kardam.chika konam?
ah its answered already on the next diff discussion, will use get_object_or_404
Those two lines can be extracted from the each block to avoid unnecessary DB queries

(primary_locale and first_locale_translations)
Faire une méthode need_update? dans le modèle qui renvoie la comparaison que tu as là et que tu peux utiliser dans la vue.
why was the +1 removed?
If the menu has no scrollbar this will always be false... I feel there would be no considerable advantages in checking previously if there is a scrollbar on the menu or not, compared with the disadvantage of a larger code if we do this kind of checking... but I'm not 100% sure. Any thoughts?
Why dev-master?, I think that any version of tcpdf is well
Ok, so I'm not following the logic yet.. Closurebuilder is more complicated but is supposedly the recommended approach, while calcdeps is the old and tested way. Judging by what you're saying, it seems like there would definitely be (more advanced) users that should be using closurebuilder, in which case, we can default to calcdeps, but provide an override option to use closurebuilder instead - no?
I would prefer if this was a string generated from a method, instead of (essentially) copied throughout the code.
`it's` -> `its`, throughout the comments.
Rather than replacing just spaces, we should replace all whitespace characters. Should be able to do this with `-[NSString componentsSeparatedByCharactersInSet:]` and then rejoining the string.

Also looks like this strip happens for all identified types; should just be done upfront on the value.
```$result``` => ```$serializedLinks``` ?
`// $sn.fms');`
even though it is comment, it should be rewritten. Or removed if unnecessary.
please don't use comments to keep old code. Git is about versionning code, comments are not
I suggest using the `link_to_function` rails helper here instead of creating the link yourself, and the text of the link needs to be translatable - use `t("user.account...")` and add the string to `config/locales/en.yml`.
This isn't at all necessary, but I was adding so many properties that I was having trouble keeping track of them.
The nice part about key sorting here is that all the standard `og:` properties will be on top, and all the Twitter specific `twitter:` properties will be on the bottom.
@intermediaterepresentation  Yeah otherwise the first language in the list, Afrikaans, will be set as default. Check the nightly:). I'm 100% positive:)