labofsahil/github-event-dataset-2012 huggingface dataset:
It seems like there ought to be a test in here for how it's stored when the same rule has both prefixed and unprefixed (or differently-prefixed) versions of the same property, since that's pretty critical.
Zorba needs to be built from a separate dir, so it fails unless I do this. I've added a comment to clarify.
I don't know of a version numbering for the CLT. I guess there is no. Our old semantic seems to break here and I would prefer a clear solution, even if it breaks backwards compatibility. We have the change to get it right, now. I hope.

Having `xcode_version` say *something* even if _no_ Xcode is there, seems bad design but I guess we have to stick to that, right?
Further we have the case of CLT-only systems (hopefully) and CLT+Xcode. And we somehow have to tell these cases apart.

For now I can follow @jacknagel's suggestion to make `xcode_version` follow the old behavior and add a new `xcode_installed?`
brew install python --framework ?
I'd rather not use a submanager and re-use the redis manager from the message store as is since then we don't need to do any rewriting of data already in Redis (though we could do that potentially anyway with the reconcile method). A bit undecided. 

Agreed on not needing the message store passed in, I'll clean that up a bit.
It doesn't. It is also used in get requests. Not the first mistake in this docstring, originally it also stated that it returned True if no errors where found, when in fact it returns the return value of the function it wrapped.

Too long summary line. Maybe 

"""Raise client side exception(s) if errors in the API request response."""
These three descriptions look really good.
Leaving for later!
Why this change? Didn't see it being used differently.
and remove the apostrophe in `Areas` while you're at it ;)
@marcphilipp: I am not quite sure what you mean about "odd". Actually I tried to name the variables as close to the other quietly-methods. The only variable name which does not need to match the comparable quietly-methods is that of the AssumptionViolatedException. Would renaming it to `e` be a solution? (Actually I personally prefer longer variable names but I always try to adopt to existing code).
Also seems odd that the params for this method are very different than its corresponding iOS version.
Nitpick: Is there any reason `why getPlugin()` needs to be a function call for instead of setting a var initially?
This would take a fair amount of rework of the modal dialog. I originally wanted to pass a validation function to the dialog, but dialog is closed before OK button handling occurs, so this won't work as dialog is currently designed. Let me know if you want me to spend time on this.
This also counts pasting as typing.
These methods are only called when brackets is running in the browser - they implement brackets.app.
There's still an `ide.readonly` call here? The IDE can't recover from that state.
I think we want to adjust max_id *after* potentially creating a new counting bloom
`c` -> `dir`?
OK cool, updated the documentation around that then.  The docs were referencing an integer value.
could you change this to be <code>!(self.header.to || self.header.cc || self.header.bcc)</code> just to make it easier to read/parse.
One problem we have is that we leave it up to the templates to decide whether to indent or not (which you've obviously discovered!). I think perhaps the best way to deal with this is keep track of which was requested by the templates. This can be done [here](https://github.com/ender-js/Ender/blob/9ba05d7125bb0e26802b546ba8ae4e7cb6233af2/lib/source-package.js#L118), that information can then be used in building the source map data. Then the templates are free to indent or use the raw (but not both!).
This cast here is useless, ```Math.log10``` returns a double already.
I'm not sure, but I don't like this magic underscore method. The functionality inside the actual merge_base method is simple enough to be pulled into the c code.
might want to declare this variable at the top before assigning to it
We don't need this at all, since main.js will load the shims for us, and they'll be there for the life of the app.  Yeah, remove all this shim stuff.
Putting this here is fine now that I know they remove themselves.
Forced semantics.

```
<label>
    Name
    <input type="text" name="form[name]">
</label>
```
What's wrong with this?
Don't thank me, thank 'rake db:migrate' :)  I just noticed it had changed, that it looked more accurate after the change, and committed it.
please look at https://github.com/saltstack/salt/pull/2676/files#L30L143

does it make more sense?
ok, then I will remove the if.
Two spaces between the variable type and name is enough.
Myslím, že nejlepší je "poškozená". Každopádně nejde z kontextu (ani originálu) o něco "zadaného"
Thanks.  When I was a ruby programmer this style was common practice in our team. After years I've managed that it's not true code beauty. And finnaly I have heard same thoughs from other developers and such gurus as Steve McConnell. Sorry for pain.
Instead of these booleans for traversal, do the next() call in places where they are set
For auto_complete_package, we sort and restrict the result to uniq[0..19]; however, we do not appear to be doing that in other places (e.g. products_controller, packages_controller).  Should we be consistent in this case?  (I assume we are restricting here for UI usability)
As noted in IRC should probably put a comment in this file that its contents are for example only and will be replaced by puppet
Was this purposely added to system_template.js?

It looks like it was previously removed as part of commit ce488f71ee6a3c8e94e1d5c5a18c8e1ffeb924ae .  With that commit, the intent was use auto_complete.js as a common component.
looking at this i wonder if it would not be easier to use a twig template that the user can overwrite
Is the added complexity really worth saving one substr() call?
By this you mean it shouldn't be *instantiated* by users, right?  When I first read this, it looked like it might mean that users shouldn't use the objects' methods, either, which obviously is not the case (on closer inspectio).
This is done in commit 77c55ad.
But then it would differ from the documentation ... ```You can pass a last argument to any assertion to control the message.```
Can you please remove HTML here, this leads to confusion on Transifex.
Just the string "An update is available for Bitcoin-Qt." will do it :).
It should be fine as currently parseParams() doesn't expect that any of the constants are set.
this property contains a string
please remove ``@static`` and add the missing types
Well, there is an issue here: ``realpath`` will return ``false`` if you ``excludePath`` does not exist, and this will then break things for the check
ids no longer necessary
the width and height of a central widget in a main window does not obey constraints. i.e. this container will be expanded to fit. so setting its width and height is nonsensical, it will only affect the minimum size computation. But, there are better ways to achieve this. What are you trying to accomplish here?
I think the last few characters on the line ('rel';) are some copy n paste leftover or something
Op zich niks mis, maar ik zou eerder een pagina maken zoals 404, die de juiste header 403 stuurt.
Since it is only to be called from devtools, how about a function with a different name, like `system.file2`, to avoid confusion? Or is there some benefit to overriding the existing name that I'm missing?
I'd rather you commented them out, at least the ones that look like they could be semi-useful in the future :)
You're relying on `%` sorting before any alphanumeric characters, but note that `! " # $` all sort before %. I don't think completion can currently return any of those at the start of a string, but we could one day have a system command completer for things starting with `!`.

For that matter, should we generalise this function so that it can handle our various escape characters? The list here should be definitive:

https://github.com/ipython/ipython/blob/380060a1500dcc8b5be553e0d0e641b85446e8ca/IPython/core/inputsplitter.py#L79
If you make another commit and push, it will be reflected in this PR, so you can address review like this.
return the single location we have no?
maybe assign Utils.functionLoader = BasicFunctionLoader.INSTANCE before stopping?
Are the new imports necessary (they weren't there b4 and there isn't anything changed in the code) also rever the EOF change
don't hardcode that
So if we do that jQuery's .show() won't work. Unless we hide the overlay on ready...
Seems like you nixed a bunch of this test. It goes through and does 4 separate http requests and checks the output for each one. You've changed it so it only does one request.
Maybe have a test that changes the locale?
Imports should always happen globally and not within a method. Reason is that it will be absolutely hard to figure out dependencies this way.
I'm not sure why you would need to redefine ``products`` here, since it has already been defined above on line 129. And in any case, within the ``change`` event, you can access the element that triggered the event by just using ``$(this)``.
Failing to unlink a symlink will raise a `OSError`.
Why can't this just be after the variable `results` has been created? The `else:` statement doesn't help a lot.
if they do, you need to use mock objects instead. For example, wrap the test in ``@mock.patch('metlog.socket')`` or whatever you need to patch and assert that a network connection was made.
OK, I thought I had tried `multi` and it still returned futures, but I'll switch it regardless.
I'm definitely fine with that. I named it grabTemplates because that's what ICanHaz.js uses.
I think it's a "boolean integer" :)
I need these lines bro! Don't know why, but I do.
If lines like this are no longer necessary, they can just be deleted instead of commented out.
Seriously that's the API for ByteSink? That's weird. Almost everything wants to be symmetric with InputStream/OutputStream, and it's weird to be needlessly different!
Lead how? There's three conditions to handle all of which potentially have different response types?
Thanks for your point. No, when the programming language is PHP, no, it is not really important (In OOP when some class has private constructor is not extendable and instatiable)

Thanks for answering my comment, I get the note.
btw @fabpot, why does it echo the return value ?
In which parent phpdoc? It's there for setContext maybe but not for getContext.
What about my idea `null === $this->getParent()` above? Also I'd make `setParent` and `getParent` protected, as it should not be public.
No need for else as you have `return` above.
missing empty line between the properties and the ocnstructor
this is wrong. The property contains an array
@Tobion I'm not sure to understand what behavior you want exactly, given previous changes; could you do a PR for this ?
because we have two cases:

 * When TwigBundle is available (we could use an include in this case);
 * When we are using the ExceptionHandler, where the stylesheets can be retrieve via the `getStylesheet()` method.
Do you have a use case? Anyway I'm not against it.
コメントありがとうございます。
今まで気にしたことがないポイントでした。。。
今後は、Gemfileの更新とソースコードの修正は分けていきたいと思います。
Refactoring problems....
I think there is more elegant way to do it then just comparing class. You can create simple `@protocol` with method `-(BOOL) shouldReplaceContactsOnAppStartWhenVisible` (or similar). Then just test if `visibleViewController` conforms to that protocol and call this method.
We have not used `expects` in this fashion in the codebase. Prefer using mocha/bourne style stub/spies like here:
https://github.com/yammer/sched.do/blob/master/spec/models/vote_spec.rb#L71

Realizing these have crept in. Making a new ticket to remove them.
I actually did this in one of my PRs. Althought I went with "invite" only to avoid possible collisions.
I've started throwing methods down in order of usage, so I would put this new guy right after `find_existing_yammer_user`
In regards to build vs build_stubbed, Josh told me build_stubbed was faster.
就是这个这个\vskip 80bp  以及上面的\vskip 100bp 的绝对距离约束了论文的标题不能太长，太长的话就把下面的那一坨给挤到下一页去了。这个我再调整一下吧，可能调整后就和教务给的(在空间距离上)会有些出入了。
Why this define?
This is checking that the key exists and has a length > 0.   If the key exists then it should return true (irregardless of the value)
Maybe also use a static factory method to be consistent... "newFromContext"
no "is True" here either
List images here, the link to images is not good. Think of how it should be not how it is easy to do.
prefix these `id` with `modal-dialog`
`Just to be sure. This timeout is to manage the 10 seconds timer mentioned by UX in the 2nd screen on the 3rd page at https://www.dropbox.com/s/yrd9mmj9w08x2c0/OWD%20USSD%20V02%2020120921.pdf Do you control timeouts for responses on the backend side?`

Hmm... IMHO we shouldn't block the dialer UI when sending an USSD... The USSD functions are asynchronous, so we should probably take advantage of that.
What about a ensureFolderExists('directory') for the last 3 previous cases?
Removed all the stuff related with PendingDB
Sorry Steve, I missed to include it now. I will include it in next pull and I will review if we call on this way in other part of the code. Thanks!
Yes, from yesterday :D
As I'm not using this html attribute anymore. I'm binding directly the right action from javascript code:
`document.getElementById('reset-button').onclick = reset`
I'm not used to gaia html guidelines. Is `data-action` somekind of standard attribute for buttons?
It needs to be one z-index higher than lockscreen-main-panel. Don't know how to give a relative z-index.
Should be ...

sum(rep(filledDurns, ...))
I want to reserve those types of corrections for a different change.
I just think lines like:  SET DEBUG LEVEL = 42

have so much meaning.   OF COURSE the setting of 42 means it enables the hilarity filter on debugging messages.

It's fine to leave it as is.
No problem. Go ahead and modify it as you like.
Our other option which I'm now leaning towards is not having this information, similar to other popular projects (hadoop, cassandra, etc). The authors can be tracked by github instead.
This is a testing function - move it out of this file and into a test script.
skipping.
This function never gets called when the client starts. So the recent connections list is always empty until the user places. See gh-226.
I think that in this case we should return array(0, array()) instead of false/null.
>.nextSibling

Oh alright.
well you mean the SpoutChatChannel
But only if there is a single codebase `''`. But yes, we should perhaps still mention them.
This could perhaps be done more robustly. (And, incidently, I don't see any tests for when this function could fail.)

Also, might this function be called for other masters in the future, when presenting masters in the web status?
How is this different than `assertRaises(Exception, ...)`?
Yes, it's correct. Since the dispatcher first load Cake core, and all the constant first. LOG_ERROR is the last constant defined, and is in `app/Config/core.php`.

Unless the user is defining constants at the beginning of core.php (before LOG_ERROR), this should works.
But in the first place, constants should be defined in bootstrap, isn't it ?
@molily are you into functional programming?
所有的都exclude了？
See previous comment on the method names.
Ouch....
we have `path` attribute which represent directory
If this is a test for deletion, call it `test_delete`, not `testTearDown`. A 'tear down' is something else in testing, and don't use camel-case for function/method names.
I could be wrong, but I think specifying the default parameters here is risky - if someone gives an options hash, but doesn't give these two params they will not be set.  Rather do `options={}`, and then in the body of the method have `options[:spool] ||= true`, etc.
My concern was that explicitly closing the socket could impact on connection reusing to syslog server. After some testing I realized that doesn't.

Thanks,
We can talk about changing how / when do we bootstrap add-ons, but I'd rather have that discussion under separate thread and definitely as separate step. I don't like `enable` or `startup` as both may be fired by an actual platform causing strange behaviors. In general pretending that we do something that we don't asks for problems.

I think change to handle diff stratup reason can be very minimal. What is actually a reason you'd like to avoid that ?
Is it going to expose one `Loader` object or all symbols `exports` ?
Might be worth specifying it here.
This calls doSetPassword, the same comments apply as https://github.com/mozilla/browserid/pull/1975/files#r1216393
These chans are for concurrent requests.

Instead of a chan per return type condition from your goroutine, consider using an option type and the chans only for communicating the result.

```go
type getdir struct {
  err error
  name string
  exists bool
}

rpcs := make(chan getdir)

go func(off int) {
  err := c.call(...)
  switch {
    case RANGEERROR:
      rpcs <- getdir{}
    case ERROR:
      rpcs <- getdir{err: err}
    default:
      rpcs <- getdir{name: res.name, exists: true}
    }
}(i)

for i := 0; i < lim; i++ {
  res := <- rpcs
  switch {
    case res.exists:
      names = append(names, res.name)
    case res.err != nil:
      return nil, res.err
   }
}
```
well, the goal of ``updater`` is to return the value to set in the field from the item. Btw, this let me wonder if the default implementation should be ``itemLabel`` or ``itemKey``.
If you simply a callback running when selecting, a separate method should be used IMO (which is done in the other PR implementing the feature btw)
Actually, as of PHP 5.0, constructors don't actually return anything.
please, watch your changes before commit them.
The `timestamp` field seems to be the standard used by the Logger itself, even though it's an array and there's no firm contract.

I decided to expect that field name in the formatter. I did consider examining all values in the event data array and formatting any DateTime instances I came across, but that seemed like over-engineering.
Check the indentation of this block
Doh! I’ve mistaken `!==` for `===`.
Please use nested resources:
resources :dictionaries do
  resources :labels
end
See http://guides.rubyonrails.org/routing.html#nested-resources
All it does is return the XML form for the properties. It will return something like this (with no spaces):
<property>
            <key>0</key>
              <label>Read a book</label>
            </property>
            <property>
              <key>1</key>
              <label>Watched TV</label>
            </property>
            <property>
              <key>2</key>
              <label>Other</label>
            </property>

and will be pass to the properties argument in the function call addPrompt( )
FYI, had to make it `fos_user.registration.form.handler.default`.
I'm not sure what you mean about a missing line.
you should not ignore the license
@lsmith77 do you have an idea where the right place for this would be?
I think this line is not necessary. We can put the default SequenceName in config.yml : 
simple_things_entity_audit:
    revision_sequence_name: revisions_id_seq
Maybe some more info on how it works ...
check if TBB is loaded when using SOFTROOTTBB
This is not required anymore.
Please use ```if @cwd```
Please use consistent indentation with the rest of the file.
There's some weird spacing going on before the `++` operator, here and below.
Need a different text at the end of this line I think
This should be indented to match `ClientCachedResource`, although there's a cleaner way to wrap this:

```python
response = (super(ClientCachedResource, self)
            .create_response(request, data, **response_kwargs))
```
sourceNode doesn't appear to be used anywhere
Same stuff here as the comment above. It would be better to remove Lines 2413 - 2417 inside your event handler after the assertions.
how would we do that? the second half of it is a variable.
I don't think copying/moving files should have to care (or even know about) whether or not tags are being saved.

Also, do you really need this and line 160+? You're only changing the tags in the renamed file anyway.
Please split this change into its own commit and pull request.
Moved, due to the UI possibly changing size.
Would it be helpful to still pass options to appendTo/ready to allow for an abstract communication channel?
I'm new to ruby and like the ```<<```? No particular reason other than it was really long.
Tabs on this line...
There already existed tests for queue size, and I added test for flushing when not BESTEFFORT.
this could possibly leak a file.
we could just use the https://github.com/Mayflower/PHProjekt/blob/next/phprojekt/application/Default/Helpers/Upload.php#L220 functions to track these files.
Formatter is a specific thing that Ivey wrote that formats output. Originally I had to format my output a certain way until I inspected the Vagrant UI class.

Now knowing what I know about the Vagrant UI class, you are right. I am refactoring this into SetUI instead of SetFormatter and will just simply set the Berkshelf.ui class to the Vagrant one.
whichever photometry or detection function is used it would be nice if they used the same output reporting format or had complimentary reading functions either in photometry or in the astropy.io package.
yeah - updated in next push.
Just returning the model should be fine.
at least, i need change other locale file apart from 'en.ini' to can testing
`$namespace` documented in 9e585cf (directly on master, not in this PR)
как ты называешь классы? определись.
Won't this be weird from here? In the `rackup` case, you'll have already loaded a good part of Middleman, and *then* you'll invoke Bundler.setup...
Please no inline styles
I didn't really understand what you mean by Qt automatically expanding the read buffer. Do you mean arr resizing?
We should validate as not null.
option은 accessor로만 정의. 몰랐네
The reason is that `askOption` has some additional logic for catching exception and it has a timeout (which prevents the IDE to freeze for too long).
ups, right. but i think its wrong there as well. we totally can generate from a normal symfony route. and theoretically somebody could implement the RouteObjectInterface with something not based on the symfony route, then the code would totally break on $collection->add()...

can you change the check further down as well please?
why not threshold.to_i
So if 'exact' is specified, it will no longer be an index-file-only read, correct?  In this case, don't we still need to control the rate at which hasKeys shall be used?
use empty() instead.
But just do whatever you have time for.
дистанция увеличивается, если array[i] НЕ совпадают
соответственно должно быть '!=' вместо '=='
Forgot to remove that on Windows side. I guess I wasn't running the code I thought I was running :)
Addendum: However, if there is good reason to have it in the browser, I believe it could be added (and should work) to the browser runner.
That's certainly right, I missed that, too. I'll fix that soon.
Remove this.
Align `=` signs
Why is this necessary? I reckon the test suite should only utilize its composer dependencies. This path refers to a directory above the library itself.
Will this ever be nil? Should it be allowed to be nil?
I really don't like this name, since it doesn't hint at the semantics of it at all. How about something like `iterativeScheduler`, to indicate that it's used to break recursion?
I think we should guard against ':/commitmessage' and ':2:blobname' patterns, don't you think so?
Hm, it "closes the repository". Maybe adding that it does that soely by "dereferencing it, which might have the side effect that it isn't removed from memory immediately". :smile:
It seems to me the **kwargs was forced choice resulting from buying *args: actually methods are mutually exclusive, right?
So there we go:

equalize_event_counts(eq_list, method='mintime')

where method is just a string

and then:

if not method in known_methods:
    raise ValueErrror('Method %s is not known.')
I can only second that...
what we have is really nice. Let's start somewhere. Although a class would be nice, it certainly implies lot's of additional work. I think we should make a first commit and gather some real-world experiences with it (e.g. i have some resting state data i would like to analyze using the interface from this commit). then we can revisit it later from a more grounded stance. wdyt?

On 19.11.2012, at 21:21, Eric89GXL <notifications@github.com> wrote:

> In mne/connectivity/spectral.py:
> 
> > +    for m in method:
> > +        if m == 'coh':
> > +            accumulator_fun.append(_coh_acc)
> > +            normalization_fun.append(_coh_norm)
> > +        elif m == 'cohy':
> > +            accumulator_fun.append(_coh_acc)
> > +            normalization_fun.append(_cohy_norm)
> > +        elif m == 'imcoh':
> > +            accumulator_fun.append(_coh_acc)
> > +            normalization_fun.append(_imcoh_norm)
> > +        elif m == 'pli':
> > +            accumulator_fun.append(_pli_acc)
> > +            normalization_fun.append(_pli_norm)
> > +        elif m == 'wpli':
> > +            accumulator_fun.append(_wpli_acc)
> > +            normalization_fun.append(_wpli_norm)
> That would be more general, which would be nice. However, it seems like that would take a lot of re-coding, in which case it might not be worth it for now. I'd be happy with merging this in its current state and revising it later on when one of us feels the need to include PPC or other pairwise measures (or other crazy methods), especially since I think those could be made without changing the functions called by the user.
> 
> I assume using classes would also make it easier to do causality analyses later, too (?), but maybe those would go in a different module. It's hard to plan too far ahead, so it might not be worth puzzling over now...
> 
> —
> Reply to this email directly or view it on GitHub.
>
rename jsonR to something meaningful like "result"
I agree that a semi-colon would be better here, but will again ask @chloeatplay to decide.
We want `true` here.
I think that we may remove this line and add this:

```ruby
user.update_attribute(:confirmation_sent_at, options[:confirmation_sent_at]) if options[:confirmation_sent_at]
```
Though I guess all it actually requires is being overridden to no-op as opposed to return false.
@WouterJ I actually liked it better the old way. The reason is that - as much as possible - I like to have code that will function if it's copied and pasted. When it's a comment, you can copy it. But with the new way, it would be a syntax error.

What do you think?
This is wrong as it forbids using the same tag several times (as you only read the first tag)
you should use ``:method:`` to link to API doc of the method
``.. note::`` should be alone on the line, and without the extra space.
Yes, you can preview de docs: http://symfony.com/doc/current/contributing/documentation/format.html#testing-documentation
I prefer to add `...` before the sentence or, maybe better, something like this:

    // the full image url, to be used in templates for example
    return ...;
or with the stabby lambda:

```ruby
@block = block || ->(user) { true }
```

even nicer!
val reply = connection match {
  case Some(c) => Some(conn.createChannel)
  case None =>
    log.warning(...)
    None
}
sender ! reply
IIRC, npy_intp is set to Py_ssize_t for later versions of Python, so despite the name, that is what it has become and how it is used. Maybe that should be documented.
this is now redundant, isn’t it?
ooops ! Certainly a huge bug !!
use partial to render pic
This might be from a dependency loop like @TimSimpsonR and I saw on Friday.
I have to narrow my eyes at this but ** does have higher precedence in Python
Still, I'd like to see a little more space in this expression, and I'm sure Lord Pepperington the Eighth would, too
we should add a message with the id of the instance that can not be processed.
Ah, the single quotes was confusing me... I can see why you add it for afterFailures, but looks confusing IMO for TakeOffline. Not too fuzzed about this, but let's try to be consistent with other descriptions.
visitCommitCommand looks exactly the same as the overridden method in CacheStoreInterceptor. Do you really need the override?
Do you already have a test for this?
sorry, not true. Maven trying to funny
Fixed and rebased the bad commit out.
That's like, anti-idiomatic Objective-C :P
Done. The RMS errors for the particular cases I chose are 22 (for the whole image) and 13 (for the sub image), out of 255. This is above the default tolerance, but it's what I would have expected, given that a lot of pixels don't match. This is expected, but unfortunate, since it is not a major difference in the images from a human standpoint.
I agree that we should be using CSS_SELECTORS instead of XPATH due to it being slow. Please remove all XPATH references
Period at the end, please.
@atomic-penguin So if I understand the scope of the change, it would find the Amazon-provided repo file, determine that it's disabled, and "flip the switch"?
Why WILL?  WHY?!?!
(let [identity (DoubleMatrix/eye (int num-features))] ...) doesn't work here, since it is used twice.  I will clarify the note.
Not that i know of, I have removed the important and it seems to work fine - looks like js gives it the correct width anyway. Might have been a "in development" thing
Should escape $Description here.
what happens if an incident title contains a " ? ..similarly with other fields: what happens if they have quote? are we escaping these?
I know we ditched the htmlentities since this isn't html, but do you need addslashes (or maybe http://php.net/manual/en/function.addcslashes.php so you can specify what to escape?)
Not sure if new lines have issues too?

(side note: this is why fputcsv will be better long term)
I'm functioning as a proxy for @piscisaureus here (who apparently has forgotten how the comment function works) but he mentioned that he would prefer it if the fields are zeroed explicitly.
Are you sure ``version_compare($version, '4.0', '>=')`` has the correct type as ``*`` is not a sub-type of ``boolean``?
Are you sure ``$childPath`` has the correct type as "object<PHPUnit_Framework_MockObject_MockObject>" is not a sub-type of "string|object<Symfony\Component\Form\Util\PropertyPath>"?
That is no problem.
We can change the license.
Should I change it and resubmit it?
mappau

-----Original Message-----
From: Jonathan Hoffmann <notifications@github.com>
Date: Wed, 5 Sep 2012 12:11:10 
To: blackberry/NDK-Samples<NDK-Samples@noreply.github.com>
Reply-To: blackberry/NDK-Samples <reply@reply.github.com>
Cc: Andre Pura<andre.pura@mappau.com>
Subject: Re: [NDK-Samples] Sample added: Multitouch (#36)

> @@ -0,0 +1,9 @@
> +Multitouch Example for BlackBerry PlayBook
> +
> +This example shows how to use multiple touchpoints on the BlackBerry PlayBook. You can find and download the compiled application here: http://appworld.blackberry.com/webstore/content/104764/?lang=en
> +
> +It is published under the following License: CC http://creativecommons.org/licenses/by/3.0/ Overview: You are free ...

We can only accept code licensed with the Apache 2.0 License.

---
Reply to this email directly or view it on GitHub:
https://github.com/blackberry/NDK-Samples/pull/36/files#r1536893
The bucket name should be removed and $storageName from the different methods be used or not? To namespace the different objects into different storages.
Perhaps the date could be written only once, at the beginning of the logfile?
`count` is a costly operation. It would be better to check `(not (empty? ...))`.
I find it strange to name the class J<b>OauthOauth</b>2client. Wouldn't it be better to change the name to JOauth2client (it sounds more natural)?
For me, it's more readable without the double parenthesis, but it's my point of view.
```js
expect(document.createElement('div').getComputedStyle('margin-left')).not.toEqual(null);
```

you're right, however in most places we just use, and it will be cleaned up after onunload.

```js
new Element('div').getComputedStyle('margin-left')).not.toEqual(null);
```
this class is not changed just formated don't wory
Why you have `($('#map').detach().prependTo('#basic-map'))` and not `$('#map').detach().prependTo('#basic-map')`.
No, put also links inside of `blocktrans`.
With current implementation, nodes does not know what is its backend. I think this should be different ticket. Agree?
`.text()` also automatically HTML escapes.
You don't mind any of them?
`== true`???
I can appreciate that, but we haven't thrown 32-bit Snow Leopard under the bus yet.

Is it possible to build a 32-bit pypy from source instead?
https://github.com/bekoeppel/cdist/commit/cd8e2869883efd3eedd1b78a78227259565c6731

Am 20.02.2012 um 10:48 schrieb Nico Schottelius:

>> +#
>> +# cdist is distributed in the hope that it will be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with cdist. If not, see <http://www.gnu.org/licenses/>.
>> +#
>> +#
>> +
>> +# if --database was specified
>> +if [ -f "$__object/parameter/database" ]; then
>> +   database="$(cat "$__object/parameter/database")"
>> +else # otherwise use the object id as database name
>> +   database="$__object_id"
> 
> I'd prefer using --name instead for consistency throughout the types, because this is the usual way of using something alternative to the object_id. This is not a hard requirement, though.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/telmich/cdist/pull/39/files#r466619
There is also a similar interface, [IInterface](https://github.com/AutoFixture/AutoFixture/blob/master/Src/TestTypeFoundation/IInterface.cs), in the TestTypeFoundation project.
If you not sure in this code, i can try to make other pullrequest.
Render as code.
If you implement these, please use the interface too
That's a clever approach. But it introduces quite some complexity, not least that you might need permissions in the JVM to do that. Maybe that's a far reached statements, as many of the things we do might need such same permissions... still, would it be much work to define them all in an Enum ?
No, and they shouldn't be - this should filter by gte and then get by index
This behavior is unfortunate, but I've added a comment to the javadocs to
describe it nonetheless.


On Wed, Nov 28, 2012 at 10:42 AM, Raghu Angadi <notifications@github.com>wrote:

> In pig/src/main/java/com/twitter/elephantbird/pig/util/PigToThrift.java:
>
> > @@ -104,38 +104,44 @@ public T getThriftObject(Tuple tuple) {
> >      return tObj;
> >    }
> >
> > +  /**
> > +   * For a given Pig value, return a Thrift object of the same type as the Thrift field passed.
>
> ah, thats right.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/kevinweil/elephant-bird/pull/275/files#r2254840>.
>
>
Can we keep this pull to just reducing the nodes with Firefox prereleases? Adding Google Chrome is a good thing to do, but should be a separate concern. I'm also keen to know if you've tested this. It would also require an addition to grid_configuration.yaml to map *googlechrome to the environment name.
Ah, well, they are now pairs again.
It is not clear what the difference is between the label and the name.
that's how [original PHP docs](http://php.net/manual/ru/language.oop5.patterns.php) stated for making singleton . You've to make the constructor private to prevent users from creating instances from the class.
what about validating $parsed and $tag here?
Okay, it's more clear here. I have changed all functions on `Response` to are public. I had also changed `current_response` to private, there are a few cases where I want to access it from the service, but I think I'll make getters and only use them in this case.
if (event.wheelDelta < 0)
      diff = -diff;
Using keywords like 'to bottom', 'to top' is probably less confusing.

-90deg in the old one was in other words 'to top', 180deg in the new one is 'to bottom'.
What is msg? document.
Any particular reason? Even the stupidest of inlining compilers should be able to sort this out.
At a glance, this seems over-defensive.  E.g. why not also handle the case where ```replace``` is nil?

Even with this change, the caller is left to handle the ```nil``` result.  It's an error either way; this just adds more steps to debug.
I'm going to have to work my way through this, but in the end I don't think we'll want a separate folder for this example. We also have been using examples as runnable / interactive scripts to include in the online documentation. Would it possible to convert this to that format?
so actually two other bugs, yeah?
this class isn't complete yet.
I think you accidentally removed the GPL statement. Please could you add it back, i'd like to use your HTML as a generic template for projects in 1995.
A question to the wider group:  Do we need to keep these ifdefs around.  We're always going to be using images, aren't we?
this one also -- too long!
Again, comments like "run the command" don't add much.
Turns out we need a combination of yum package, rpm file, apt-get package and deb files, plus a port package too ;)
That would be my preference.

On 02/07/2012 10:09, Peter Veentjer wrote:
>> @@ -0,0 +1,164 @@
>> +package brooklyn.entity.basic.lifecycle;
>> +
>> +import java.util.*;
> I'll change it.
>
> It is a default setting of intellij; if there (afaik) are 5 or more important for the same package, a single wildcard import is used.
>
> Should i set n to infinite?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/brooklyncentral/brooklyn/pull/182/files#r1083056
I think this is clearer as `_.isNumber(Infinity);`.
you actually can coerce to an int using `type=int` in argparse. I would use that rather than issuing an "int" after. The port number should be an int, and not a string ;)
Shall I just put the method back and have it not called by anything?
What happens in a Firefox desktop build?
ImmutableSet.copyOf
OK I have fixed this and pushed.
You don't need this file here.
E cam lunga linia cu conditia if, imparte-o in doua inainte de '||'. Nu uita de spatiu inainte de '{'.
Just add the jquery_datepicker_settings on every page to avoid trying to be smart? That's something that could probably be cached quite easily as well.
Ну и к protected имеют доступ только методы класса и его наследников (опять таки если не юзать reflection, с которым я думал возиться в xmlBinder)
We don't need this here.
>       app_details.type_descripion(app['description'])
E       AttributeError: 'Details' object has no attribute 'type_descripion'
please remove the empty lines here
I think we need to support slugs for the API in projects because we're using slugs in the URL bar. Let's chat IRL about this.
Could be a definition list.
Can you kill the extra line? :scissors:
driveLeft?
On Sun, Sep 30, 2012 at 08:19:33AM -0700, Wei LI wrote:
> @GaelVaroquaux Actually what I want to know is whether we can and will just get
> a serials of estimators which have fit_transform pipelined together?

No, the pipeline code is used to do cross-validation, so it will not
accept something that does not do out of sample transform.

I agree that it would be cool to have an example of spectral-clustering
implemented as a pipeline. For know, I would just do it manually in the
example (unless you can code some out of sample transform :} )
Don't throw this part out. Just retry resolving with encoded version.
Calling `setBody(NULL)` to make sure the params are sent via URL seems 'magical' to me
Oh, I was looking at http://packagist.org/packages/propel/propel. Is no one using Propel2 with Symfony2 yet?
Delete this line! This validation is not necesary
Is removing the admin_token key integral to this patch? If not, probably best to keep it out of the patch for clarity and submit a new pull request that removes it (along with a reason why...)
I wish we could convince the bosh guys to take my very innocent change?
I rewrote it to minimize the changes to the behavior they currently have.

Any advice on what I could do to make them comfortable with it?
I am sure they are busy with everything else already.

Avoiding the fork would be nice unless there are tweaks you have in mind?

Otherwise:
* cherry pick would be my favorite.
* a small script to patch things up
Why + INDEX_BLOCKSIZE?
As I said in previous comments, the rowsToSort capacity will only increase in steps (as it's limit is exceeded and it's size is bumped).
So allocating same as capacity when detected to need to should be enough.
Can you not set 'n' at end outside for loops?
I've renamed the functions.
Minor comment - I was trying to understand the OR at the end of the function and wondered why it wasn't obvious.  

I think this name could be improved.  is it more like queryMismatchingRemotePart()?  The cloning is what you do if this doesn't matching.
>I think this is saying that the number of buckets should be set so that one bucket can just be big enough to not spill.

It is, but assuming 0 duplicates, i.e. that all are unique and fit into HT.
If hashing produces unevenly filled buckets, then I suspect it will be an under-estimate, yes.

Perhaps, I should just add 25% more buckets or something...
It looks like this code should be combined with the unquoting code above.  E.g., what happens if you ESCAPE a quote that should be stripped?

(It would also avoid potentially copying the data twice.)
Remember, if you are retrying on soft-errors, remember to add a number of attempts to perform and bail when it runs out, or you'll busy-wait when the expected recoverable error (such as empty queue) is not recoverable under specific conditions.

You better provide the user/debugger with an error message of "too many attempts" than busy-wait.
if reg_sleep wasn't a multiple of 60K this would sometimes go over 60K.

    nextLog = lastNextLog + 2; /
    if ((nextLog * REG_SLEEP) >= 60000) 

would avoid it.  I wouldn't bother fixing though.
Empty docstrings are pretty useless, could you please add a small comment about what that function and other uncommented ones do?
I would go for something like

```
if not kwargs.get('signature'): 
    raise TypeError("'signature' can't be empty")
```

because neither None or empty string is accepted.
муу биш буруу гэвэл арай зохимжтой
Chris,

Have a few minutes to pair on this?

-Eric

Sent from my iPad

On Feb 28, 2012, at 5:49 PM, Chris Price<reply@reply.github.com> wrote:

>> @@ -2,6 +2,9 @@
>> Puppet::Parser::Functions::newfunction(:include, :doc => "Evaluate one or more classes.") do |vals|
>>     vals = [vals] unless vals.is_a?(Array)
>> 
>> +    #Protect against an array passed in being wrapped in another array
>> +    vals = vals.flatten
>> +
> 
> This looks harmless, but it does seem like the line above that calls "unless is_a?(Array)" is trying to do the same thing.  Would be interesting to know exactly what the data type of "vals" is in the case that you're debugging, because it seems like only one of the two lines should be necessary.
> 
> It's true that this exact same pattern is used in :realize, though.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/puppetlabs/puppet/pull/535/files#r499011
This is where I had it from, maybe it would have been useful later but I removed it: 

https://github.com/composer/composer/blob/master/tests/Composer/Test/Repository/VcsRepositoryTest.php#L26-L41
I'll make this change.  It's a better solution.

On Fri, Mar 30, 2012 at 12:17 PM, Zachary Belzer <
reply@reply.github.com
> wrote:

> >    end
> >
> > -  # Returns random word. If +length+ given, find word with this length.
> > -  def word(length=nil)
> > -    length = self.dictionary.keys.sample if !length || length >
> self.dictionary.keys.max
> > -    self.dictionary[length].sample if self.dictionary.has_key?(length)
> > -  end
> > +  # Ensures that the word is valid:
> > +  #   is at least 2 letters
> > +  #   and does not exceed the MAX_WORD_LENGTH
> > +  #
> > +  # Returns the word if it is valid
> > +  # Returns nil if the word is invalid
> > +  def validate_word(word)
>
> Why doesn't this just return a boolean value? It seems like you could
> simplify add_word and blacklist word if you did:
>
> ```ruby
> def add_word(word)
>  return unless valid_word?(word)
> end
> ```
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/AutoCash/memorable_password/pull/1/files#r627244
>
Hmm, I almost think that
 ```csharp
 "Hello, world".WriteLine()
 ```
would look better than

 "Hello, world".Wl()
somehow this was broken before this change. So im commenting it for now. will fix in a separate PR.
je sens de la redondance avec ```.picture-right```
Ridiculous but OK :)
@christianv Yup, won't work without that - it's what distinguishes a "constant" filename from a constructed one. See doc note at http://docs.angularjs.org/api/ng.directive:ngInclude
If you changed List to IEnumerable I would consider it as meaningful change ( the last call .ToList() could be omitted). 
You also could return IEnumerable in GetStashDiffFiles, to not have to do list.union(untracked).ToList(). Here I think concat would be better (union returns a set, it is ok since list and untracked should be disjoint, but using concat you defend against error situation when they are not disjoint).
I don't believe, that someone would ever use other implementation of IList here. But I can be mistaken.
To clarify that, 'recipients' is the property available from the metadata - it will contain all 'To' and 'CC' addresses, and the 'BCC' if we have them.

The precise contents of each grouping is only recorded in the header fields, and to access them you need to retrieve the message proper.
@bodepd This is what I found in the example file I used for reference.

I found an explanation in [the blueprint of this middleware](http://wiki.openstack.org/Keystone-BP-S3Token) : s3token communicates with the public keystone api ().
Although the [official documentation](http://keystone.openstack.org/configuringservices.html#configuring-swift-with-s3-emulation-to-use-keystone) uses port 35357.

I have the feeling that as the s3token middleware is not passed the admin credentials (and only admin users can leverage the features of the Keystone admin api), it's safe to assume that access to the Keystone public API is enough.

I'll double check this tomorrow that this setting works correctly although.
Comments like this makes me super nervous. :) See comments below about test cases.
Consider using:

```
f, (ax0, ax1, ax2) = plt.subplots(1, 3)

ax0.imshow(...)
ax0.title(...)

etc.
```
So, ``astype(double, copy=False)`` should be fine here; I just found the comment misleading.  Maybe something like "No need to rescale using img_as_float--the threshold is computed correctly irrespective of range."?
It might be nice to have interface functions (for `ellipse` and `circle`) in `draw.py` that converts arguments to ``double`` so that users don't have to.
ahaha, an indent so nice, I typed it twice.
This test failed when I ran it, due to the typo:

E       AttributeError: 'ContributorsPage' object has no attribute 'selnium'
I'm not opposed to the names; we just rarely use abbreviations in public interfaces.  The ones that we do use, e.g., WGS84, are expected to be well known (well, we'll see about WGS84).  Although Effective C++ is a best seller, and perhaps the best C++ book out, `lhs` and `rhs` are not exactly popular enough that we should make an exception.

This change is a search and replace, right?  Do we really need to do it later?  We should not set a presidence of cleaning everything up after it is merged into master.
Good catch. Somehow I didn't notice this last night.
Any reason to delete this?
What happens if it is off screen because the bottom/right values are too high?
Worth noting for future additions as it's not a bad idea but unless you think this is critical I believe we can pass on this for initial push ;)
While this does work, [subview isKindOfClass:[UIScrollView class]] is faster and is considered better practice.