labofsahil/github-event-dataset-2012 huggingface dataset:
Should we document what happens when the user tries to skip forward, but there isn't a next item in the queue? Similarly for skipping previous, but with  no previous item in the queue.
This import doesn't seem to be used.
On iOS, `hasCompass` is a property, so this information (and plenty of other information in the doc) is incorrect. I don't have a physical device with a compass in it to test, but the signature in the source code is:

```
-(NSNumber*)[GelocationModule hasCompass]
```

Which the bridge routes to a property. Can somebody with a device that supports a compass confirm this?
I don't understood how to do it. I need to define the strings (@"starting", etc) or the constants (MKAnnotationViewDragStateStarting, etc..) ?

And when I define the constants, how can I use on this source?
Recommend adding/removing CSS classes to control the display instead of manipulating styles directly.
I removed it, everything is ok. 
If it is really needed, the dependency should go to assetic package.
Yeah, since its just the one line I think its clearer and more readable.
Could you delete this?
PR regarding `@Transactional` will handle this.
Мой друг Анатолий тоже бесил меня чрезмерным вайтспейсом в конце файла, но я не подавал виду. %)
Add a newline before this line.
I wouldn't like to add the footer as it doesn't really belong to the template IMO. But if the majority really wants to have it back, go ahead...
The example also requires that T1 and T2 are default-constructible. You could initialize them with void to fix this.
Sorry I replied too fast. I actually dived into this before, but forgot in the heat of the moment. The problem in this case is that we are using the CDI container as provied by AS. This bean manager will depend on the Hibernate Validator module as provided by AS as well which is HV 4.2. Hence the problem with the xsd. So really there are two Validator versions at play 5 and 4. 

I tried to also upgrade the HV module (similar to what I do with the BV API in the pom), but that causes other problems in some of the AS integration code. It is really chicken and egg here. 

We need to adjust the AS integration code anyways, which I wanted to look into later this week, but how I could then use this AS container for my tests I am not sure. 

I think for now this has to do.
did we not agree to add author lines?
Maybe that something we get into common too. the Base classes for the client.
hehe :smile:  at least it's only the comment
The constructor should only be called once per object instance.
Should this be changed to something more generic?
Not quite -- JSON.parse(JSON.stringify(foo)) is a *clone* of foo. 
    That way I can manipulate one object, but maintain a backup.  I do
    the same thing on line 378.On 12/25/2012 7:01 AM, Jonathan
      Protzenko wrote:
    
      In modules/message.js:
      > @@ -241,6 +245,19 @@ KeyListener.prototype = {
>      return [msgNodes, index];
>    },
>  
> +  saveKeybindings: function () {
> +    Prefs.setString("conversations.keybindings", JSON.stringify(KeyListener.prototype.keybindings));
> +  },
> +  loadKeybindings: function () {
> +    if (Prefs.hasPref("conversations.keybindings"))
> +      for (let [os, bindings] in Iterator(JSON.parse(Prefs.getString("conversations.keybindings"))))
> +        KeyListener.prototype.keybindings[os] = bindings;
> +  },
> +  restoreKeybindings: function () {
> +    for (let [os, bindings] in Iterator(KeyListener.prototype.defaultKeybindings))
> +      KeyListener.prototype.keybindings[os] = JSON.parse(JSON.stringify(bindings));

      I'm puzzled. JSON.parse(JSON.stringify(foo)) is
        supposed to be foo right? Or are you abusing these
        functions to perform something else?
      
        —
        Reply to this email directly or view
          it on GitHub.
це на пам’ять?
Should this be input[ 0 ].disabled?
Relié au configurateur. doit être déplacé
This seems to disagree with your comment on line 80, which says that these numbers should be multiplied by 1.5. Also, I don't think either of these counts take into account number of hours, just number of classes.
Agree that those 2 aren't needed for `init.pp`.
Habe den Konstruktor nun noch angepasst. Der Rest habe ich ja schon eingearbeitet - oder gibts gerade noch etwas?
Ansonsten würde ich dann weiterfahren :-)
indeed. however, as long as this is the only dependency on 2.2, i would really love to stay compatible with 2.1 at least until 2.2 is stable, maybe even longer. 
one thing we could do is provide 2 route classes, one for 2.1 and one for 2.2 but not sure if its worth it.
Nope. Just a typo.
Зачем тебе здесь Q_OBJECT?
I don't think this equals test is necessary
This may be something we want to add in at a later date, as we're currently only concerned with working with the current project.  This would have to be a flag to override the default here.
Add fallback for default image
In order for the RSS admin page to be displayed as a sibling menu item (as a tab), the standard solr admin page needs to be defined as a 'default local task' . So both admin/settings/islandora_solr_search and admin/settings/islandora_solr_search/config will point to the same admin page.
Yes, and I am not comfortable with this either but as you can see form the comment Mark wanted it back in so I'll defer it to him.
````

FAILURE: Build failed with an exception.

* What went wrong:
Could not resolve all dependencies for configuration ':spring-integration-jdbc:testCompile'.
> Could not find group:com.oracle, module:ojdbc6, version:11.2.0.3.
  Required by:
      org.springframework.integration:spring-integration-jdbc:2.2.0.BUILD-SNAPSHOT
````
Renumbering through a lookup table instead of hardcoded rules might be more maintainable. Probably even better would be some general renumbering rule, so that the same custom_task would work as broadly as possible. However, that is bigger refactoring that should be postponed until other surveys have been prepared.
@Ocramius No problem. (Once the zf2 di has settled down again, things with these doctrine modules should be more straightforward.) By the way, I started transitioning over to composer install earlier today. It's very nice. Wonderfully simple. Thanks for your efforts.
you should require ``2.0.*`` instead. This bundle is compatible with 2.0.9 too, but this branch is **not** compatible with 2.1 whereas your constraint allows it (it even allows 4.6.9 even if it does not exist currently)
Do:

```JavaScript
if (i === 0) {
```
It doesn't really matter here, but it's a good practice to always use triple equals. Triple equals doesn't do automatic type conversion, which is almost always what you want.
provider is fine to me :)

On Mon, Sep 10, 2012 at 9:38 PM, Markus Bachmann
<notifications@github.com>wrote:

> In Provider/CacheProvider.php:
>
> > +use Doctrine\Common\Cache\Cache;
> > +
> > +/**
> > + * @author Markus Bachmann <markus.bachmann@bachi.biz>
> > + */
> > +class CacheProvider implements ProviderInterface
> > +{
> > +    /**
> > +     * @var \Doctrine\Common\Cache\Cache
> > +     */
> > +    private $cache;
> > +
> > +    /**
> > +     * @var \Geocoder\Provider\ProviderInterface
> > +     */
> > +    private $fallback;
>
> I don't know what is the best name for this variable.
>
>    - delegate
>    - fallback
>    - provider
>
> What name do you prefer?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/willdurand/BazingaGeocoderBundle/pull/13/files#r1569679>.
>
>
try to take a look at FilterTargets hooks used in various spellscripts. Also take a look at gridnotifiers in the Trinity namespace:)
I am not sure if this should deprecated. JsonLoader is not drop in replacement.
 ````.. using LzoJsonLoader```` is so much better than ````using JsonLoader('com.twitter.elephantbird.mapreduce.input.LzoInputFormat')````
Any arguments why?
Just a quick echo
please add a use statement for SqlitePlatform
Twice *EmbeddedSortedListField*?
No spaces, please.
You can do multiline comments with """ """.
If there isn't a particular reason for keeping the old code, i'd recommend to remove it. 

Are multiple messages now all shown at the same time? How can the messagewidget display all of them at the same time?
Is this a fix for #214?
Display->Displays
that would be excellent…

after reviewing the comments, I should also review the code :)

On 12/09/2012, at 5:53 PM, flopma <notifications@github.com> wrote:

> In src/main/java/org/sonatype/nexus/plugins/crowd/client/rest/jaxb/SessionPostResponse.java:
> 
> > @@ -0,0 +1,34 @@
> > +/*
> > + * Copyright (c) 2010 Sonatype, Inc. All rights reserved.
> Shall I update all the new files ? Thx -- Issa
> …
> —
> Reply to this email directly or view it on GitHub.
> 
>
Does this really work? `BaseControl` already defines `$disabled` as `private`.
Do i have to loop over all datadefinitions and fetch the parameters from them or just the default PatientDataSetDefinition?
Can we remove this has_scoped_evaluation? method and let has_evaluation? method handle the both scope and non-scope cases like add_evaluation method? Thanks!
I mean the very next line:

```
protected ClientRecordFactory factory = new ClientRecordFactory();
```

can be

```
protected final ClientRecordFactory factory = new ClientRecordFactory();
```
Should we simply ue ForceApp.SDK_VERSION?
could you add a 2-space indentation here and below?
Traditionally we will !! the input to allow "truthy" values.
@sleroux - since you are in this space can you clean this up please. 
all this qnx.callExntensionMethods are making me angry ;)
we should put this in the webworks namespace
It hard to tell from the code what value m_ppgUrl may have but I wanted to point out that in the case of public/BIS push m_ppgUrl must have a valid non null non empty string value. In the case of BES/enterprise push the ppgUrl must be an empty std::string("") it cannot be null. It may be necessary, if not handled somewhere else, that if m_ppgUrl is null that instead an empty string is passed to the createChannel call.
please throw exception on the last retry