labofsahil/github-event-dataset-2012 huggingface dataset:
Fixed, but the var is in uppercase do differentiate the plugin https://github.com/balupton/history.js from the browser api window.history.
Also why repeat the var? Just add it to the above var.
We're definitely on the same page here (single-page app, topbar is currently pointless). I was actually experimenting with now-playing controls in the top-bar, but couldn't quite get the CSS to do my bidding :/

On a related note, how do you feel about HAML? I friggin hate hunting for closing tags, and it's trivial to generate even JS-based html templates in HAML with the asset pipeline.
doc doesn't match the output of line 11. But I'mma use this all the time now.
Actually I'm wrong. Apple's ARC guide [here](https://developer.apple.com/library/mac/#releasenotes/ObjectiveC/RN-TransitioningToARC/_index.html) has a section on how "The Compiler Handles CF Objects Returned From Cocoa Methods."
Yeah, I suppose this was the reason - so for the plugin to work I suppose it needs to be reverted and/or branch a s9y version specific code call; in s9y 1.7 we can add the $status field in the function header, yes!
Perhaps something like this?

```
diff --git a/GitTfs/Core/GitRepository.cs b/GitTfs/Core/GitRepository.cs
index 94a4500..98a9171 100644
--- a/GitTfs/Core/GitRepository.cs
+++ b/GitTfs/Core/GitRepository.cs
@@ -404,16 +404,26 @@ namespace Sep.Git.Tfs.Core
             using(LibGit2Sharp.Repository repo = new LibGit2Sharp.Repository(GitDir))
             {
                 Blob blob;
-                if ((blob = repo.Lookup<Blob>(sha)) != null)
-                    Copy(blob.ContentStream, outputFile);
+                if ((blob = repo.Lookup<Blob>(sha)) != null 
+                    && Copy(blob.ContentStream, outputFile))
+                        blob.ContentStream.Close();
             }
         }
 
-        private void Copy(Stream gitstream, string file)
+        private bool Copy(Stream gitstream, string file)
         {
             using (var destination = File.Create(file))
             {
-                gitstream.CopyTo(destination);
+                try
+                {
+                    gitstream.CopyTo(destination);
+                    return true;
+                }
+                catch (Exception ex)
+                {
+                    Trace.WriteLine(ex.ToString());
+                    return false;
+                }
             }
         }
```
# method naming reset()

I worried the naming conflict if bass classes used.
That was no worry QObject or QWidget both does not use the name for method.
Pass this topic, I just note here I searched about it.


# BeatInfoChanged slots has direct access to metronome

I suggest use Qt 's signals/slots.

(in this metronome case)
If applyed this suggestion, the variable "metronomeBar" will be used only within the MainWindow constructor
and the all tasks what MainWindow side does for metronome object are:

* Create and Initialize the instance
* Connect signals/slots
* Add widget to layout

## Method like a "reset()" is often slot in other Qt widgets

Here, the mean such like method work like reset(), e.g QTextEdit::clear().
The reset() call can be signal/slot or called internal in metronome bar setBeatsPerInterval slot.


### The behavior for BPI/BPM changed event

windows client does not reset current beat position when bpi/bpm are changed.
they count the rest of the loop, and update BPI/BPM on position at 0.

Can remove the reset() on BeatInfoChanged slots ? or is that still needed for BPM changes ?


## setBeatsPerInterval is a slot

That can be connected by something bpi changed notify signal, instead of call the method manually.
now the arguments does not match.

 * the signal arguments are bpi and bpm
 * metronome slot recieve bpi only

This change may require add new signal for bpi changed notification, but it does not be much cost.


## Merit of these changes

This can decrease future changes cost. for example, when the metronome move to another class,
no need to search whole code, and the context of how other methods are used. Signals/Slots promises that interface.


NOTE: "scope of variable"  may be incorrect term, 
I did not mean a lifetime of the object. I mean just where the variable name appear on the file,
that defines how wide range developer has to look and take care for new changes.

----

#  MetronomeBar::setCurrentBeat slot

No need range check ? (any case when setCurrentBeat get invalid value ?)
If no need or don't want the check every times, but assert macro still helps code readability.

 Q_ASSERT(bpi >= currentBeat && currentBeat >= 0)


> This could be optimized to repaint only changed regions but it just makes the code trickier.

I see that can not take a straight approach for NJClient.
update signal by passing the range (prevBeat, currentBeat) may helps though,
but no need that optimization yet. leaving that comment is enough ok for now.

Current patch code has call update() twice at BPI change, that in reset() and setBeatPerInterval(bpi)
but the area of MetronomeBar update is not so wide and BPI change is rare event, I think performance won't be problem.
this can leave until when need optimize or cleanup code.
Why don't you include this in 2.0.10 tag?
r+wc outstanding!
Great thoughts Stefan.

Why don't we close this pull and I'll see if I can remove the build dep and call zlib directly from Julia.  I don't see why it wouldn't be possible.
What rule is this an exception to? Everywhere else that we use a letter as an abbreviation, we make the letter capital. (RBM, CAE, etc) I did change the filename though because we have been keeping filenames lower case so far (rbm.py).
If a query is written using a row key and at least one column key as a constraint the exception should be thrown. 

This only happened if the row key filter clause came before the column filter clause. So the change takes into consideration that the column filter can come before the row key filter.
What exactly does this commit fix?
Isn't secure version `https://secure.gravatar.com/`?
I think that's a good idea. Why? cuz i don't think its good to check ALL inputs form for all change events.. no right?
So i just save a global var for check if i use in the forms, and if yes.. i can't leave a page without confirm. :)

Yakir.
There are many lines changed in GraphicsDevice.  I cannot easily find the actual changes due to Github's diff showing whitespace changes, so I cannot comment on the functionality changes.

There are also substantial changes to Vector3.cs.  It is very difficult to see what has changed and why.

See the wiki (linked at the top of the page) for the description of how to use submodules and submit a pull request.  I'm not sure what the decision was on using latest OpenTK for Windows.
ok. I will try it next time.  thx
 2012-2-18 11:02"lishunli" <
reply@reply.github.com
>д

> maybe you can click  "Add a line note" to add comment.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/usc/FileExplorer/commit/2396a412bf78647b62b64ddc82810e971062144c#commitcomment-981147
>
Is it? I made sure that it doesn't happen and I just checked it, it works just fine on my machine.

In fact, this test (https://github.com/vaidikkp/zamboni/commit/83a3a777e6e25cdfc700f7425e35807527b1a074#L1R76) checks the same thing. When you leave the textbox empty, request to `users.ajax` is sent with `q=''`, which returns `status = 0` (error) with the message 'a user with that email address does not exist.`
Replaced with PxLoaderTags.contains method
It's supposed to be exposed at the top.
but then what happens if someone adds to the html5.elements array?
I don´t think there were any blending going on in the original Q2, so maybe they are bad examples to use.
I think the first version of the md3 format, that came after, had like head, torso, legs split up so they could be animated independently(running, shooting etc.).
It looks like for example ogre(http://www.ogre3d.org/docs/manual/manual_78.html) have split it up into "morph animation" and "pose animation", where only the later one supports blending. There´s probably a good reason for that.

Maybe blending is more meant/used for skeletal animations? Sounded like a nice thing to have in theory at least. :)

But I do remember away3d(flash) had some feature like that. Found this post with an example: http://www.closier.nl/blog/?p=83
oh the assert is there line 410, i think everything going in is well tested.
we don't need this.  i'll remove this one now.

thx for the heads up.
I modified the API. Now the expression goes into the listener. And there is a removeResolverListener.
D'oh! That's what I get for copy/pasting.
Reviewed; +1
In this case:

    shared void bug242<T>(T[] a, Integer i) {
        T? t = a[i];
    }

The `T? t` is also converted to `java.lang.Object t`.
On the other hand if I for example say `given T satisfies Sized` it's again transformed to `T t`.
Which seems a bit strange.
тут тоже отступ поплыл
While testing some stuff I realized that the cube barely rotate. s/AsSeconds/AsMilliseconds solves the issue. :-)
The same could apply to X11 and Windows example. Didn't try, though.
why are you checking for ReferenceManyCollection and not just Collection? or doesn't it have to be an scalar?
Why hello, and not hai?
Why did you go back ?
Test　Merge
No I just noticed! Am fixing it now :)

Sent from my iPhone

On 02/02/2012, at 13.50, Josh Suereth<reply@reply.github.com> wrote:

> Does this syntax work with command-line jekyll?
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/sbt/sbt.github.com/commit/1d77c2f1516028a8d44dc1126d1979eff9aad126#commitcomment-926229
Should these dates come from the conference, instead of hardcoded?
First part https://github.com/f4rnham/TrinityCore/commit/46e8b5d1e28802bfb31e9ae3ab94b66e59282765
Oh thanks! That would make things more readable. Very cool. I gave the
presentation last night. I think a number of people are going to give
Draper a try.

Great stuff Jeff.

Alex

On Thu, Jan 12, 2012 at 3:52 AM, Jeff Casimir <
reply@reply.github.com
> wrote:

> When you're inside a decorator, as long as it has `decorates :user`, then
> you can use the `user` method to access the wrapped model. It's an alias
> for `model`, but it tends to be much easier to read/write.
>
> In specific decorators, I'll use the alias. I only use `model` when
> writing more abstract, shared code in the `ApplicationDecorator`.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/alexpeachey/dritter/commit/b55a1d5d9d59ae339ca5d9951974a72b45488561#commitcomment-860564
>
I would merge this if I could find it. :)

The Github Web interface is beyond horrible. Never heard about this patch until I stumbled across it on the network graph. (?)
We were getting different GUIDs depending on how you got a YouTube video (from a feed vs. from the API/from a feed but had to call the API as well).  This makes them consistent.
No commented-out code allowed.
I'll write a ticket about that to Synology. Shouldn't be our job to ensure the package is not running. That's the upgrade logic to do that :/

Anyway, this is a clean start for the installer script, I am not against putting more stuff like ensuring package is stopped.
Would like to see it working first :)
ты ведь и так в suggestion... может просто SetHeight? setContatinerHeight?
I'd replace with this 'current', the current state, and 'ever', all past states |'d together.
AMS has a bug that still occurs: if you have Magic Suppression it doesn't go up to 100%.
Visually it does, but as soon as you relog/take damage it goes back to 75%
The `get_translations_url` should not modify the `@lang` variable.

An [immutable object](http://en.wikipedia.org/wiki/Immutable_object) is a better approach.

The side effect of overriding the `@lang` is that you could leave the `DebsFromRepos` in a broken state. Something like this:

```ruby
o = DebsFromRepos.new("...", "", "", "es")
o.get_translations_url                    # This works. Use the @lang initialized in the constructor
o.get_translations_url("0")  rescue nil   # This does not work,
o.get_translations_url                    # This does not work anymore, since @lang is "0" now
```
Right, I think I understand. But how is one supposed to do this then? Looking at the SBCL manual (section 7.2.1), should I call cairo_surface_destroy on the pointer directly? If so, should new-surface-with-check (just below it in the file) also be changed?
Good catch, we will solve this problem as part of <https://hibernate.onjira.com/browse/OGM-40>. That's probably going to be my next assignment on OGM.

Hopefully you won't need to apply that anymore.
I'm trying not to be too picky about white space, but this line REALLY needs some spaces to delimit operators.
я планировал туда еще добавить настройки уведомлений об автообновляемых подписках. ждем notifications api =)
Well, THAT didn't work.
Love this one !
https://github.com/Phenix789/C---Epitech/blob/master/piscine/D01/ex00/white_rabbit.c
weird indenting here, maybe put "or" in line with the "(req" above and then make


    and (req....
         or (utils .....
             in... )
Correct. Per the user guide, controllers maybe organized into subfolders named the same as themselves. In a particular cause you may have a sitemap method already in an existing controller let's call it site.php. You may have the site controller set as your 'default_controller'.

$route['default_controller'] = 'site';
$route['404_overrride'] = 'site/sitemap';

If you already had the controller in the folder structure as /application/controllers/site/site.php, the 404 override will not work because the Router only looks for the controller in /application/controllers/ and not in the subfolder as allowed by any other controller mapping.
Nope, it's wrong.

FIrst make sure you put ServerInfoChanged at the right place in the enums list, to fit with the wiki.

Then, either put the enums of the network flag in a separate enum, or start again from 0, since the network commands start from 0 not later, or hardcode the numbers (since they're only used in server sending and client receiving, 1 place each).

Then again, you need to output network before the rest of the stuff. So you need to set the correct network flags before sending anything else.

A bit like:

```cpp
Flags newtork (!name.empty()  + (newMaxNumber != -1) << 1 + (!newDescription.empty() << 2)  );
```
Some browsers also have a setting for minimum font size. Color: transparent is just a good thing to keep.
get rid of the loop see above.
If `USE_HAYSTACK` is set, we're probably doing it because the search backend is down.  In that case, we should either fake it (description__contains='foo') or return an empty query set.  Still doing the search just means users will get a non-useful error page.
kannst den stalker der die gesichtslosen beschwort auchnoch zu erudax umbenennen, denn is die illisiun perfekt :D
wenn sum sachen dbc fummeln geht, sprech mich an :D   das zum thema schattenorkan, denk ich haste auch ne falsche spell id :O  eiglich dreht sich der orkan mit effect wie gewohnt. musst ma ingame .lookup spell  schattenorkan machen
What about the menus ?
warning C4351: new behavior: elements of array 'PlayerTaxi::m_taximask' will be default initialized
Wait, the tumour they throw at you attaches and grows on you? Brilliant.
When will you release next version. I'm waiting for a version buildable with released Play! versions.
This looks good. Nice job adding a title to the links.
Have you tried compiling it on windows?
Do we need it for all platforms?
On Friday 13 January 2012 05:35:28 you wrote:
> Hi this gem can not be found on  gem sources (gems.github.com and
> rubygems.org)
> 
> Could you provide in  docs what gem source to set ?

Sorry, this package isn't distributed as a gem, but you can use it through 
Bundler by pointing at the git repo, i.e.:

  gem 'browser_check', git: 'https://github.com/RailsPlay/browser_check.git'

I'm not using this gem any more, so won't be maintaining it.  Feel free to get 
whatever use you can out of it.

-- Steve
Our current implementation doesn't include /all/ of backbone's features. all we have working frontend-wise is just adding and persisting on refresh, but I used the console to test everything, which includes the initial fetch, persisting, updating existing records, reading existing records, etc. I'm pretty sure it's used to parse the response returned from the read method, or, more specifically, `Goal.all.map { |g| {:goal => g.attributes.merge({:id => g.id})} }`
You could use "Arquivo com as fontes (Lançamentos)"
yes, that would make more sense :)
Good point, perhaps a notice on "Templates No Longer Distributed", and a section "How to Switch To/Apply Another Template"
Is this valid in php 5.2 as well?
Although android:exitFadeDuration was documented to have been publicly available since api 11 I was unable to compile against anything below api 15 without getting compilation errors.
Do you think we need the id on a per-module basis? We could just base it on the title - one less bit of similar code in all the modules. But perhaps I'm over-optimizing.
Sweet, oh boy i need to find time to place this on my 69 charger!
> Interesting optim, how much do you gain in practice on your use case?

I don't remember, it was a while ago that I coded this for a deadline. I
think that that specific function had a fairly significant gain on large
data.
fair enough... I guess with the latest beta, the granting of superpowers is no longer optional.
this commit fix resize method in layout controller.
resize is a dojo widget method, each widget should resize itself. So keep it in scene widget this moment.
When view changes to object and remove scene widget, this method can be changed to common method in layout controller.
Guys,

Have you tried building the entire kernel with ENABLE_BCM_4329=true? It's there in the Makefile and I always build with this option via the command-line (ENABLE_BCM_4329=true make -j4).

I rebuilt the kernel without this enabled, and my wifi driver is no longer initializing. It may be a coincidence, but it's worth a try.
Funny one if you read the email but these notifications miss the previous message :D
Blasted copy / paste code. :-(
Fixed in 287fc7a5ac998cf0b7816158ed64f5bc7c4acedb
Better to use ignore-case regex, you never know what'll come from the XML.
Fix Headphones
Brilliant, works perfectly !
salut


Nu te stresa...daca ai timp.
@EventHandler :)
sorry, I don't know if this is the right place for this, but I don't find any other place to ask this question (on XDA I haven't find any answers)
recently I forked FXP kernel from this git (you can find it in my github) it worked just fine, but I need to build wifi modules from source...
I manage to compiled the module from sony developers site but it still would not load...

my question is, does the wifi compat driver source is different with the one from sony developers website?
also from some pointers DooMLord gives me, he also copied the wl12xx_spi.ko modules, but in fxp kernel ramdisk that I have (extracted from 109 kernel), I don't have this file in the modules folder... does it necessary to copy it to the modules folder?

regards

krizky82
Yeah, that is a pain.

I guess it is too late to back out the formatting?  If not, this is really annoying, but can you got through and point out your changes?
This was my favorite in CM :)
I add the extra properties to the error object so the callee can handle errors in a diferent way if they want to, or even use the currently parsed style rules to do some graceful degredation.
My specific use case is for assetgraph, where I want to find all the relations from the stylesheet, even though there are errors in it.
Yeah, well, can I leave that as a TODO task? :)
@ericf : To me, that's just more confusing to read than what's currently there.
I think addSandboxHeader should add a header when it can't find that header. If you return when not finding the header, how can you add a new header?
But, absolute URL can be "www.xxx.xxx", or "xxx.xxx/xxx/xxx", or "ftp://xxx/xxx", and something else.
Is this method safe to close over?
Why use the default dispatcher and not the actors' dispatcher?
have this extend AtomicInteger
Do you prefer this?

      // find the node with least routees
      val numberOfRouteesPerNode: Map[Address, Int] =
        currentRoutees.foldLeft(currentNodes.map(_ -> 0).toMap) { (acc, x) ⇒
          val address = fullAddress(x)
          acc.get(address) match {
            case Some(count) ⇒ acc + (address -> (count + 1))
            case None        ⇒ acc + (address -> 1)
          }
        }

      val (address, count) = numberOfRouteesPerNode.minBy(_._2)
      if (count < settings.maxInstancesPerNode) Some(address) else None
This is the main interface now, get the cache from this class method using the class as the key.   So, nothing is initialized until it asks for a cache to do something with it.
This is a point of divergence with ObjectContent vs. WikiContent.  WikiContent uses this, but ObjectContent uses split_content as the primary parsing of the wiki notation, urls and such.  Now it iterates over the keys, but it's the same ...
I'll change it. If I get in the habit of doing this, I'll no longer have to think about optimizations
It is always good to add new parameters after existing ones

if there is an existing call to the function using positional arguments then it will break adding the new param after existing ones prevents this risk
Personally, I like the improved readability. You know exactly for what is purpose it. Especially when calling several logic functions. (that's be the case when subscriptions will be integrated in this very function (next pull request))

However, we currently face more important problems than renaming. That maybe, you can give us more insight into. Please read the lated comments from tobes and me and also consider https://github.com/okfn/ckan/pull/186

Thanks.
The implementation of these tests are a TODO: and I added a comment to that effect.  I can see why it would be awkward without it.
directory matching may want an unescaped path. previously this was handled by Rack::File as static didn't need to care.
Yes, I will add a call to SortAndRenumber right here
This seems a bit elaborate to me.

I think it'd be less surprising to have all the `FileSystem` classes inherit from `mrjob.fs.base.FileSystemBase`, and put the `cat()` method in `FileSystemBase`.
you can do a static initializer to avoid having to answer this question.
private static final String schemaString = schema.ToString();
would this ever be more than 1 item?
Crazy indentation here. This should be using tabs, not spaces.
Zitat von micha137 <notifications@github.com>:
>
> In ingo/lib/Script/Ispconfig.php:
>> @@ -0,0 +1,87 @@ > +<?php > +/** > + * The Ingo_Script_Ispconfig::  
>> class represents an ISPConfig Vacation "script generator". > + * >  
>> + * Copyright 2012 Michael Bunk <mb@computer-leipzig.com>
> OK, can do that. But how do you explain line 3 of  
> ingo/lib/Script/Maildrop.php:
> https://github.com/horde/horde/blob/3375cf1e6e2bfe152c884c4a9eee50f5ca7bc2a6/ingo/lib/Script/Maildrop.php#L3
>
> ?
>    Reply to this email directly or view it on GitHub[1].
>
We haven't been able to contact that contributor when we assigned all
copyrights to Horde LLC a few years ago. For new contributions this is
mandatory.




Links:
------
[1] https://github.com/horde/horde/pull/20/files#r2054971
-- 
Jan Schneider
The Horde Project
http://www.horde.org/
Eww, this line should be broken to keep it under 80 character wide.
character typo (previous code)
ahh, je vais merger, ye temps qu'on aille ces changements. On enlevera ca apres ca brise rien de toute facon
Your code is not properly aligned. Could you please double check?
`.instance` here too
Are the values in `@columns` actually used as Hash keys? If not always, then this change is actually worse than without it because this code always allocates another copy of each string and then freezes it. Basically, it's paying constant upfront cost instead of a variable cost. You'll need to just show why that trade off is valid.
For me is fine to stub private methods if the method is doing something expensive or depends of the environment.

We don't have any policy, we follow our :heart:. My :heart: is saying that for this case it is fine.

I'll take a look later on this pull request.
Has the `new_record? ||` check been removed?
It's compatibility.
If we don't have key, we should assign true to *serialized* variable.
@carlosantoniodasilva @kuraga thanks ! I agree with you, and I updated it !
Much as I like the skateboard ramp, you could write that like this and save some bit-trees:

    import definitions._
    0 to 22 map (x => appliedType(FunctionClass(x).asType, (1 to x map (_ => AnyClass.asType)).toList :+ typeOf[Target]))
and we have a winner!
I tried various approaches but somehow didn't come up with this one :-(

code reviews ftw!
Typo. Mention other reasons.
But then we have a problem. `locker.comp` has to reference msil.jar, so it will have to use one from starr, which might lead to weird situations.
I'm abashed at my own behavior here. I shall never delete another commented assertion again without a SIP.
References
    ----------
    "The Scaling and Squaring Method for the Matrix Exponential Revisited", Nicholas Higham, 2005.
this req should be mentioned in the docs.
In the context of Matrix and SparseMatrix I agree, this is a LazyMatrix. In the context of MatrixExprs it seems like a strange name because everything is lazy. I wouldn't rename Transpose to LazyTranspose for example. When everything is lazy then the lazy adjective feels unnecessary to me. Giving it to one of the lazy objects has the unwanted side effect that it calls into question the laziness of the others (see http://xkcd.com/641/ )

However you bring up a good point that this class can implement all of the others in MatrixExpr so maybe deserves the name. I'm not sold on the idea but if you feel strongly then I'll change the name.
For example: https://github.com/scolobb/sympy/blob/ea1ec859598072973fb8200d8974a8c57b04bea0/sympy/core/function.py#L1649
How about `except Exception, a`, and then below, you can use `a.args[0]` in the error message.
`1/3` or R(1,3)?
Yeah, I've seen that change as well.  Thanks for that one, I really didn't know what to do with that argument.
What's the intent of this? `bool(<Relational>)` is rather dangerous and confusing, cf; [issue 2832](http://code.google.com/p/sympy/issues/detail?id=2832).
set the `self._is_transitive` attribute here?
Maybe state it like "generic, non-SymPy specific strategies" instead of "strategies that have nothing to do with SymPy", because this latter formulation makes me wonder why one would add to SymPy something which has nothing to do with it.  But feel free to discard this nitpick.
I generally try a top import; if that fails, a bottom import, then use of C.foo (if possible) else an import in the function. And if the import is for a error I put it with the error code since performance is no longer an issue at the end of the road.
Yes, that's final goal. Now I'm going step by step to make clear what is necessary.
now it uses constant, so error is better. undefined constant LENS
I have not removed note about fix of the #724 in this file because in fact it was fixed, closed and works properly.
…except Files…
Isn't this linked to the nav points depth?
The sf2 code uses the newline at end of file to avoid these weird diffs for the last line (the ``check_cs`` script would add them for instance)
Well all the tests fail when it's removed since it's used by pretty much every test that uses study or ExampleData ;-)
Поменять: пусть возвращает Hello world!
I'm wondering whether this function is significant enough to warrant it's own datapoints in a theory test, or all of the paths sufficiently covered in shouldTileEvents/1 of HibernateDomainDifferenceStoreTest?
this delete_revision view should still just reset or clear the document html
What happens if the request is a `POST` and the form is invalid or the user is not a Mentor?
You can remove the limit 1
Add newline, squash into e8a31f20128419e48d2d082c76effb403cc0d201.
What needs to be in $row? What can be in $row?
Use jquery?
Looks like it's only used in style and from outside, so I think this should just not be part of the template_locator interface.
Oh! I didn't notice that there's a section dedicated to the schema changes. I'll go find it and change this.
Primele linii (user_to,user_from.text si timestamp) am considerat ca nu ar trebui modificate asa ca nu le afisez ca form field ci doar plain text.
Митьо, това което си предложил за съжаление не работи :-/
.. освен ако аз не съм в някаква жестока заблуда..

Всъщност ето какво става:

промених render-a на:

``` ruby
  render partial: 'activity_content', format: 'html', locals: { activity: activity }
```

и си тръгна - ток и жица. Но после като изтрих rss partil-a:

```
Missing partial activities/activity_content, application/activity_content with {:handlers=>[:erb, :builder, :coffee, :haml], :formats=>[:rss], :locale=>[:bg, :bg]}. Searched in:
  * "/home/zeni/workspace/evans/app/views"
  * "/home/zeni/.rvm/gems/ruby-1.9.3-p0/gems/devise-1.4.9/app/views"

...

Request

Parameters:

{"format"=>"rss"}
```

явно не ще да възприема формата така
Serialization is really expensive, and we try to avoid doing it wherever possible- this would make it so we do multiple serialization attempts when storing data, so we'll need to find a better way to handle it before merging this.
I'm confused. There's nothing here which would imply that the results are actually sorted from what I can tell.
!! might be cleaner.
why exactly 2 items? put a comment to explain if needed

Is that the total #? If so, generally better to cycle over a list, e.g.
```
for (var i=0; i < items.length; i++)
{
  
}
```
Is there a way we can get these to load automatically in the store->view rather than hardcoding them in?
Should still raise an error for non-spherical ellipsoids.
@john3571 you're not using $sky_content_type are you?
should throw an InvalidArgumentException if it isn't a string.
Without a title formatting, this looks weird (it seems like the following subsections, like "Basic Tests", are not part of the "How to Test it" section).
name is just part of key. d should be indexed by [key], not [name].
If it is a normal situation, then the warning should go away completely.
Even better, you could make this a link with `[http://support.microsoft.com/kb/946358](http://support.microsoft.com/kb/946358)`.
You can use `type='choice'` with `choices=['ipython', 'bpython']` for options with a predefined set of choices: http://docs.python.org/library/optparse.html#optparse-standard-option-types
Ah, now I understand. Yes, your point makes sense. Let's keep it in
accounts-oauth1-helpers for now.

Thanks for taking the time to help me understand the concern.

On Thu, Aug 9, 2012 at 11:31 AM, Mike Bannister <notifications@github.com>wrote:

> In packages/oauth1/oauth1.js:
>
> > @@ -0,0 +1,114 @@
> > +var crypto = __meteor_bootstrap__.require("crypto");
>
> You're right with oauth2 that you simply need to add the access_token to a
> url when hitting the service API but with oauth1 you need both the
> access_token and access_token_secret to sign the request (i.e. you can't
> just append them to the url). I'm not sure what the solution is but I'd
> like to be able to leverage the oauth1 signing code used for account
> authentication to sign requests to the service API. To me it makes sense to
> go ahead and move the oauth1 package into accounts-oauth1-helpers for now
> until we have a chance to build some stuff and see what the best pattern
> (if any) is for sharing the code.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/meteor/meteor/pull/251/files#r1345304>.
>
>
Line 7 already has `&state=' + state`, this would add it twice to the URL.
Then let's leave it at this :-)
```rb
cd "src" do
  system "make", "-f", "Makefile.simple"
end
```
Please include transport name?
The ones in the txredis branch? Either way, this will be replaced with the new session manager stuff as part of #281.
please explain in the function documentation when the search stops (when it reaches a directory containing a .rain file)
Gitb ja dann rex-url statdessen
这是几个空格？4个就够了
Of course it gets iniutialized correctly. There are already tests for @IncludeCategory(Single.class) and they still run fine.
I didn't know about that, thanks.

However, in this case it seems to be breaking a lot of tests since if `getter(parent)` returns falsy it will return `parent` instead of the return of `getter(parent)`.

---

```js
val = (typeof getter === "function" ? getter(parent) : void 0) || parent;
```
We really shouldn't hardcode the `Model.`, so people can extend the state machine.
could shorten this up a bit:

    var description = item.description || '';
    return (dojo.isObject(description) && dojo.isArray(description)) ? description[1] : description;
it feels a bit strange that debug is decoupled from env. This seems a tiny bit smelly, but I'm not sure if there's anything to be done about it. 

I suppose we could have
env = 'production'
debug = false

if @target['development']
  env = 'development'
  debug = true
end

but maybe that's more silly.
The comment above makes explicit the assumption that _updateHintList is only called from an active session, which guarantees that sessionProvider is initialized.
fixes a bug loading unit tests on linux
Good catch! Fixed. I ran into a problem where the waiting flag got stuck on so cache was never cleared. Now, we just return the list whether it had items or not.
@lennartcl I don't agree - this is complicating stuff and coupling `debugger.js` too much into the API

@nightwing I agree, those should be the stuff talked with the debugee instance
if you can do the "non-breaking simple change", plz do it
What do you think about calling this something like "drawGapEdgePoints", to be more explicit?
I guess this answers my "why a function" question.
`:after' is for user.  Please use `:post-init'.
Add a new comment.
Can you change this to just `require 'test_helper'` please?
Maybe it would be more accurate to say that this adds some JavaScript to be executed when the DOM is ready for processing? It seems like “set” implies that it would replace a previous setting done by a call to this.
No changes in this file
I don't think we are going to use this style of indentation. Single space please
Also, is it possible to stop the propagation of the event before this? Only curious. This solution is fine, but preferable if you can stop it from getting here at all.
let's change to the text to something like 'the linearization data is not available to unreadable pdf data is found'
We already get these middleware clases from funfactory (https://github.com/mozilla/funfactory/blob/master/funfactory/settings_base.py#L253-264) so don't need to duplicate things.

If you want to add in new middlewares you can do so as demonstrated here: https://github.com/rossbruniges/make.mozilla.org/blob/master/make_mozilla/settings/base.py#L129-131
On Sep 7, 2012, at 8:42 AM, chuckcranor <notifications@github.com> wrote:

In fuse/plfs_fuse.cpp:

> @@ -1,6 +1,7 @@
>  #include "plfs.h"
>  #include "plfs_private.h"
>  #include "LogMessage.h"
> +#include "PosixIOStore.h"

I had to include this for the statfs, since it only works with posix fs
currently.


Can't we just add a prefix in front of the path in the plfsrc and handle
the same way we handle all other paths?

John

 —
Reply to this email directly or view it on
GitHub<https://github.com/plfs/plfs-core/pull/88/files#r1555186>.
Good catch!  `parsed_body && parsed_body["errors"]` is what i mean. Ruby style guide says:

`Use &&/|| for boolean expressions, and/or for control flow. (Rule of thumb: If you have to use outer parentheses, you are using the wrong operators.)`
Oops, you're right. I actually looked that one up and still got it wrong. :-)
Ok, so with some minor modifications, this is what it looks like now:

debianzfs:~# cat /proc/net/iet/volume 
tid:1 name:iqn.2012-04.com.bayour:share.tests.iscsi1
        lun:1 state:0 iotype:fileio iomode:wt blocks:31457280 blocksize:512 path:/dev/zvol/share/tests/iscsi1
        lun:2 state:0 iotype:fileio iomode:wt blocks:31457280 blocksize:512 path:/dev/zvol/share/tests/iscsi2
debianzfs:~# iscsiadm -m discovery -t st -p 192.168.69.13:3260
192.168.69.13:3260,1 iqn.2012-04.com.bayour:share.tests.iscsi1

I'm not sure if this is expected behaviour though...
This is a bug setCreationtime() -> setCreationTime(). 

A general remark: the bug itself is not a large problem as it can be fixed easily. The point is - are the changes in this Pull Request actually tested ? This PR is supposed to be part of a patch release which will not go into certification testing. So, the test of the changes are under the responsibility of the developer, which is of course a certain risk considered to be acceptable for patch releases. If even me and other developers try to look through all the PRs for evident inconsistences, we do not actually test the changes. Therefore, the rules of thumb for the patch PRs:

- put in the patch PR only changes needed to fix a particular problem
- do not mix in in the patch PR other code changes ( beautifications, syntax sugar and other pylint recommendations ). These changes complicate the  code changes inspection and sometimes can introduce unexpected bugs
- try to test the changes in the developer environment as far as it is reasonably possible
Did you also make sure that the trigger was on document as well? `$(document).bind() and $(document).trigger()`
this is already solved in a with singletons in foreman_architectures
Indeed... followup comming.
I don't like this hack but let's keep it for now.

I know this trickery is to be able to communicate from the keyboard to the system application in order to send the size of the keyboard window. I would like to avoid this hack and to replace it by an other until there is a correct solution. 

A correct solution that would also help with disposition: inline activity could be to add a getHeight/getWidth/onResize methods to the <iframe mozbrowser> element. This would let you know the size of the content of the iframe without hacking with postMessage and without the need to access it's content. I have open https://bugzilla.mozilla.org/show_bug.cgi?id=757859 for that.
What do you think of moving this code into its own file? js/background_services.js?
Sorry, you need to help me, how does it need to look now, I'm really confused. Can you post the correct formatting code please.
That's possible, but I don't see the advantage. We don't use lexical_cast anywhere right now, and we have the strprintf function already.
Another missing space between foreach and the (
No

On Oct 22, 2012, at 1:58 PM, Alan Malloy <notifications@github.com> wrote:

> In src/jiraph/merge.clj:
> 
> > @@ -160,25 +194,28 @@
> >                                                  (<= revision (:revision edge)))]
> >                                   [to-id {:deleted true}]))}))
> >  
> > -;; TODO this needs to use read function, not get-node
> > +;; TODO update merge-count on unmerge-node
> @ninjudd Does this todo need to be addressed before merging into develop?
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
Error surpression should be avoided almost entirely. Why not typecast the arguments, or avoid even trying to merge if not an array?
The reason this was added is b/c when the menu closes, the viewport has repositioned to where you last scrolled the menu. Either shrink the size of your browser to see this happen, or use the iOS simulator.
I think these three lines could be deleted.
Again space after `if`.
About CSS, I'm using less, so this css is a compiled version I can put blanc line by hand, but i'll have to do it at every compile time.

Do you think using less ore something similar could be an good idea as you can use variable in CSS for color, or properties and anything ?
How do you reckon that? This gets called from `gitno_close` which only gets called once we're disconnecting the TCP layer anyway, so this change is precisely what the quoted text says we should do.
Also see the `GIT_INIT_STRUCTURE` idea below as a possible alternative
`self.config.logger.warning(...)` here mayhaps.
lol @ flock
So I keep wondering if `if` helps for some of these. Just trying it out, fine as-is.
```
if
    IsAdmin -> authorized;
    (IsValidator andalso CreatingUnprivileged) -> authorized;
    true -> forbidden
end
```
As you've probably found out by now, I'm rather conservative when it comes to API design. Once a design begins to point in a particular direction, it tends to make other approaches hard.

The problem in this context is that it's still early days for Hyprlinkr, and while I've used it successfully in at least one largish project and a couple of smaller ones, I haven't seen enough use of it yet to see any auxiliary code start to evolve around it. This makes it hard for me to predict what would be a good API design and what wouldn't.

Right now, Hyprlinkr is very close to the metal. It's a very sharply focused library that provides helpers for some non-trivial parts of the Web API concerned with RESTful linking. The current API is mostly shaped by having to deal with the Web API, which is what I mean when I say that it's close to the metal. There aren't really any abstractions on top of that.

That's one thing, and I don't think it should do much more than that yet... I'd prefer to wait until we have a better idea what idiomatic Hyprlinkr code looks like, and where the pain points are.
No, the code is still cutting the contents to the frame. Now it's just using the internal variable instead of the external one ;)
I'm not sure I'm 100% happy with this, as the tests are supposed to make sure logging works *without* any configuration.
It is implicit.
Missing blank line here.
We don't use "use" statements for global PHP classes. So, these use statements should be removed.
> What about my idea null === $this->getParent() above?

Entering in this branch if the rest of the condition isn't true won't construct a valid tree. Having a null parent here is an error / shouldn't happen, so it seems reasonable to handle this by throwing an exception ?
Implementing a fake template for the data collector before implementing any cache profiling seems really weird to me
Why using keys when other translations use the English sentence?
I don't think every component needs it, but the ones, that have lead maintainers, different from @fabpot :)
@certik what you wrote is correct.
IMHO, this should be a fatal error.
whitespace: `if (`
No need for `stringWithFormat`.
Rename to `invitation_template_path`?

Otherwise feels like it should be a path to the `Invitation` object itself.
Delete the commented-out code?
itou?
Add a TODO here because we want to change the client side not to require this legacy function!
So is here
Looks like `TableCell` is missing a `content` property?
I went and checked the spec and it doesn't explicitly specify the order, so I supposed that's a possibility. The browsers I tried did put it in order, and this code goes away as soon as we move to Express 3 because we'll use their parsing instead. So I say we let them worry about it :).
To add a newline before the new prompt gets printed in the terminal. So it looks like

```
./when-changed.py file command
When 'file' gets changes, run 'command'
^C
% 
```

rather than

```
./when-changed.py file command
When 'file' gets changes, run 'command'
^C% 
```
fwiw, I don't like implicit return :)

Don't worry about fixing this, I'll fix it when I merge.
Nope, would've wrote it down otherwise. Let's try to come up with something.
Missing space after commas.
Small doubt... Why are you creating this object as a anonymous function?
SleepMenu will handle it's own key events on my next pull request.
Out of curiosity, did you have issues where `window.navigator.mozMobileconnection` wasn't accessible ?
Is there any chance that we need to update the loading string?
This code is not synced with the previous you moved. Can you revert those changes?
Extra space before closing parentheses, `gjslint` you code!
src.slice(5,-2) (or something like that) will do the same if you assume that there are no leading or trailing spaces.
@vingtetun: I've filed https://github.com/mozilla-b2g/gaia/issues/4076 to convert mediadb.js to stop using localStorage.  @dominickuo is not responsible for that; I am.  @dominickuo: since the music app is now using shared/js/mediadb.js, you should git rm apps/music/js/MediaDB.js, I think.
@etiennesegonzac so far getIcon isolates from getDownloadingIcon and getDefault icon, but as you say, we don't need to expose the getDownloadingIcon as a function.

Working on it, thanks.
To avoid race condition, move `PowerSaveHandler.init()` to let it occur before `BatteryManager.init()`;
Yeah, I unified everything at the level of the elements with the "log-item" class adding or removing the "selected" class so that the children elements adapt accordingly. Not considering the new Building Blocks mechanisms which we should integrate or adapt afterwards ;-)
Last thing. Doing it with a for wouldn't make it prettier and more maintainable?

```javascript
var searchable = ['givenName', 'familyName', 'org'];
for(var field in searchable) {
  if(contact[field] && contact[field][0]) {
    searchInfo.push(contact[field][0]);
  }
}
```
https://github.com/mozilla-b2g/gaia/pull/6657#discussion_r2249205

Please do what @fabi1cazenave said here.
You are using 4 times the missedCallItem.querySelector('.call-type-icon').classList element, can you extract to a variable and apply the removes and the add?
yep it has been fixed
`type="submit"` / `type="reset" would be enough; class = accept/dismiss could be used when type=submit/reset can't.
Hi, 

in fact there are 4 versions of this tool, 2 with the 2.0 version (32 and 64 bits) and 2 on the 4.0 Client. 
I am based on a standard 2008 Windows installation witch is provied with the .net 3.5 (formelly an extention of the 2.0 version) A standard installation (or an uptodate windows) has this folder. So  this is the standard path. I used the 32 bit to touch the most of computers (including workstations) 
I don't have the way to check whitch .net version is installed - for the moment but i can search. 
It's also the case on an XP, Vista and Seven installation. This path never change for the moment.   

With the libexec folder, i can delete all the check_xx programs and the DLL of my compiled cygwin version. With this version only the local check swap is used an all the others check are set by the check_wmi_plus templates. 
WMIC.EXE is my own work, it's under AGPL. 

Let me know if you want to delete the libexec 3 part files. 
regards, 

Jean-François BUTKIEWICZ 
Consultant VEOSOFT (groupe VEONERGIE) 

----- Mail original -----

De: "Gabès Jean" <notifications@github.com> 
À: "naparuba/shinken" <shinken@noreply.github.com> 
Cc: "jfbutkiewicz" <jean-francois.butkiewicz@veosoft.net> 
Envoyé: Jeudi 25 Octobre 2012 10:23:15 
Objet: Re: [shinken] Windows installation for shinken, using .net services instead of instsrv... (#644) 


In windows/install-shinken.cmd: > +rem (c) 2012 October, By VEOSOFT, Jean-françois BUTKIEWICZ
> +rem This script is for IT admins only. If you do not have experience or
> +rem knowledge fundation to install manually shinken on a windows host, please use the 
> +rem integrated installation of Shinken using the setup.exe program delivered by
> +rem VEOSOFT. This kind of installation perform the same tasks but without any request
> +rem using command line.
> +rem This script is delivered upon Alfresco GPL licence.
> +rem
> +
> +echo Shinken Windows Installation
> +echo Provided by VEOSOFT for Shinken Team
> +echo V 1.2 - October 2012
> +echo ====================================
> +echo Checkin for InstallUtil tool ....
> +
> +if exist "%systemroot%\microsoft.net\framework\v2.0.50727\installutil.exe" goto NEXTSTEP1 
It it normal that a specific version is used here? What about other versions of this tool? 
— 
Reply to this email directly or view it on GitHub .