labofsahil/github-event-dataset-2012 huggingface dataset:
@nathanmarz  `fork=True` is only needed if the script needs to do something after the call to `exec_storm_class`. Currently, `shell` is the only command for which this is the case (it needs to remove the temporary jar file). For the other client commands, either way should be fine.
So it's either random of port 80? What about https? Or do we not care about that as yet?
Yes, as stated in my commit messages I changed the behavior to use the order of the `$supported` array to break ties, making `$tieBreaker` unnecessary.

This allows for more flexible behavior which would not be possible with a single `$tieBreaker` parameter, including having multiple fallbacks (this is especially helpful when the specified `$tieBreaker` is not among the best matches, but there is still a tie) and easier handling of tie breakers when the `$supported` array is not constant.

It also specifies previously-unspecified behavior:  What happens when there is a tie but no `$tieBreaker` (or one which does not match)? Now that condition is impossible.
Couldn't use the self-signed certificate in the Sensu SSL data bag?
i don't know -> should we? it would add more lines because you have to setup the fake timer and restore it afterward. I guess it would only be better if we had more than one spec that needs it in the describe block
That actually was how we used to name the functions, but since I didn't use `git mv`, they showed up as changes. But I agree - they should be consistently named. Changed accordingly.
This could be simplified to say "if ((group & (1u << i)) != 0)" (note that I usually leave the != 0 part in hsplasma to silence VS's useless warning about truncating an int to a bool).
ignores。
Lets keep the current padding.  Bigger tabs look better with the layout.
Please don't do this. Instance means that there can be only one object of this class.
If you are overwriting it in a subclass, you don't need to set it here.
Yup, in fact I made it clear in https://github.com/thekad/clusto/commit/5c9de5f3c0b603bcf179d0f45551a3cdaa3526ae
I think that's inconsistent. Don't you do it for `@param type foo` in a method docblock?

But whatever.
No need to change these files?
is this really a parent swap? It looks like old's parent never get's changed.
As I mentioned, these lines are intended to _simplify debugging_ – and because they match the intended semantics. It just happens so that they might possibly, at some point in the future, also run faster.

While I agree that your counter-proposal is nicer on the eyes, it has the wrong semantics, so I would prefer adding one comment along the lines of `//  don't capture internal errors`.
Added a test case. It found that I should call prepareDeps... :)
yeah.  I personally will add an ngettext implementation to front and back when we need it.  *promise*
Nice! I had not thought.
I've written `ConstraintNotFoundException` extending `ClassNotFoundException`. In fact, it's not an exception thrown for an invalid argument, but because we can't find the correct class, associated to this argument (imho).
Could this use the non-string form of class eval like so?

``` ruby
@klass.class_eval do
  alias_method @method, stashed_method_name
  remove_method stashed_method_name
end
```
Is there a way to enable / disable simultaneous replay using a preset parameter?
I needed to change the way the bundler interaction works because I would want it to fail silently on zeus. So I started doing that but I had issues with it changing the overall flow of vroom. I'm happy to do that but I think that would become a much bigger request. I might be getting it totally wrong though, would you be able to put together a version that works the way you are thinking?
no, now I returns the TileCoord, fix the calculation and add tests
apply the same of the rest of the PR
Cause it is declared twice. 

Line 357 - 359 are exactly the same as 364 - 366.

See code block below. 

 foreach (array(
            'constraint_type'         => 'setType',
            'match_option'            => 'setMatchOption',
            'update_rule'             => 'setUpdateRule',
            'delete_rule'             => 'setDeleteRule',
            'columns'                 => 'setColumns',
            'referenced_table_schema' => 'setReferencedTableSchema',
            'referenced_table_name'   => 'setReferencedTableName',
            'referenced_columns'      => 'setReferencedColumns',
            'match_option'            => 'setMatchOption',
            'update_rule'             => 'setUpdateRule',
            'delete_rule'             => 'setDeleteRule',
            'check_clause'            => 'setCheckClause',
        )
I'm assuming this is an implementation detail, and not required by the interface, correct?
Finally, is this targetting the 1.0 beta version of FirePHP or the 0.3 version? And does it matter which version?
`lei` -> `la logica delle viste`
Rename to `assertResponseHeaderRegex`
This isn’t necessary since `'_vendorPrefix'[0] === '_'`.
Can you just use the "userLayer" member here instead of this really long expression to get the layer?
Updated.  Thanks for pointing that out, I hadn't checked.  Looks like both F77 and F90 cases are covered, great!
I think we need a ExtensionProxy that will look on the implementation object's class for ordinal() since the register_extension() will be looking for an instance method called ordinal.
for ezselection yes!
The thing is that documentation tools behaves differently. Some supports inheritance with a dedicated flag, some inherit by default,... We should probably decide what to do based on some research in this regard.

I am personally in favour of not documenting anything if there is no doc change, and use ```{@inheritdoc}``` in the case we have something that is changed and use it for copy/paste parent doc. Like in:

    /**
     * Wrapper for in-memory cache. {@inheritdoc}
     */

The following shouldn't be used IMHO as it should be documentation tool's default behaviour:

    /**
     * {@inheritdoc}
     */
This version string doesn't matter since we're not publishing to npm.
Wow, is that what we were doing? *Never* depend on `id` for sequence order.
Good point. I will consider it.
Not sure what you mean by this—e.g. you'd like to change the signature of Request.__init__()? Or something more?
No, except if something has just gone wrong in the past? Maybe delete the app and try again? I can try as well if you want?
Yep, but it's the job to ``AbstractMessage`` on ``addHeader``, like your PR for ``addHeaders`` (which may call ``addHeader`` recursively, same for ``setHeaders``).

In this case, calling only ``$request->addHeaders($headers)`` doesn't duplicate the code.
The admin interface already uses script blocks, thus it already has CSP disabled.
You'll want to mock out the BANNERS_HASH setting for this test and modify the fixture above to match whatever you set it to.
Can we create a separate region for tabzilla? 

Maybe a separate project for this area and a new submodule
the same area is present in marketplace too... https://marketplace-dev.allizom.org/
and I have a feeling we will see it more often in our web pages
s/_productlist/_productlist_locator
If you wanted to get fancy, you could do

```js
exports.get = env.get.bind(env)
```

Or probably even better

```js
module.exports = env;
```

but what's here works fine as well.
change this to an `ok()`, as you're always setting `error` above
This means that we would stop a machine if master machine wasn't able to SSH connect to it. 

IMHO it is better to assume that machine is loaded (and not try to stop it) when there is no SSH connection.

Otherwise we could rename this method to machine_bored? and return false, when there is no connection.
为什么要修改.gitignore？
It doesn't matter, right? It's a value of length - you express it as you need it, e.g.

    q1.to_(u.km)

Whether you keep is as cm, km, or convert it to m, it's all the same thing. Any solution (left unit, right unit, SI) is "correct".
Don't use a hardcoded label, please use a code:

_('ID_INACATIVE')
Is not necessary get the same connection again, please reuse the connection
You could use `Page#ext` here instead of `File.extname(path)`.
use `<br />` not `<br>` for all instances
`cache_index.delete` seems like it would work here http://ruby-doc.org/stdlib-1.9.3/libdoc/pathname/rdoc/Pathname.html#method-i-delete
Yes. This and the change above fixes bug mentioned in #1667.
keys can be cached here
Because the Authz API has the ability to manage group membership.
dude, this is a python script, not js :)
parent gives the version
let ff op dat je niet overal onnodige lege regels hebt.
!!! so many dots !!!
Спасибо за комментарий, действительно упустил этот момент.
Они итак все FALSE
А когда в твоем коде может возникнуть ситуация, что ДНК будут иметь разную длинну?
Скажите об этом так, чтобы программа дальше не выполнялась, а не тихонько ничего не делала :)
```objective-c
assert(mutatePercent > 100);
```
долго медитировал над этой формулой
если заменить nucleotideIndex на число от 0 до 3, то ломается и возвращает неверные значения
но если не менять, то работает идеально, и мне не понятно почему, откуда такая формула? это математика?
По этому я делю не на 100 на  100.0
Результат деления будет float, который умножится на percent, а вот после этого уже приведется к int.
Рекомендую использовать switch - case
Нет, есть алгоритм случайного выбора символа, исключая существующий
Perhaps put in into the main layout. I forget what the name of it was. It's not "main" the other one :)
We should start thinking about ways to abstract this pattern out, given how many places we're doing something similar now.
Please include `underscore` in the Dependencies section above with a version. This should be in the same format as a package.json, so it's easy to copy & paste into your own.
Yep! )
Jeg klarte å trigge denne timeout-alert()en ved å klikke litt fort rundt i løftewidgeten. Kanskje vi som default bare bør gjøre `console && console.log('timeout')`.
a-to-b, b-from-a这种名字我在别的代码里面看到用a->b, b->a这种命名比较多，好像也直观一点。
You will also need to do:

    for new_fid_new, this_fid in zip(new.fids, self.fids):
        new_fid.seek(this_fid.tell())

So the newly opened files are at the same position.
with take one can correlates a lot. -> we use one that correlates a lot with heart beats: 'MEG 1531'
oops. indeed. not sure what happened here. thanks
if this line is not necessary  remove it.
Is that a past tense of "highlight", or a typo? "Highlighted" sounds more right, but I could be wrong.
Well spotted. I am going to fix this in my [Play2.0.x-withTLS branch](https://github.com/bblfish/Play20).  I suppose you'l fix this in the merge right?
Again, not clear on why this is needed? Can't we test whatever this is testing as part of the Jasmine unit tests?
URL needs to be on the next line.
or => 或
逗号改顿号
这一句看不懂是什么意思。。。
I made this update to use `handle_cookies` on a Patron::Session. For the same cookies to be used between requests, the Patron::Session should be memoized. Creating a new Patron::Session would lose the cookies.

In hindsight, cookies could be persisted in a file.

An untested example:

```ruby
connection = Faraday.new(:url => url) do |conn|   
  conn.adapter :patron do |session|
    session.handle_cookies cookiejar
  end
end
```
Nice. Thanks for pointing out exactly why it felt like a weird name to me.
@martin-ueding
I was not really talking about plugin technology, it's not like you are introducing a new plugin here and of course at some point we will convert wikimanager plugin into a component. My point is more that this module is currently not used in XE which is why it's only included in XEM.

So my concerne is just, is it ok to emmbed wiki management module in XE instead of just XEM (it is OK for me but I think it require a vote).
All children will be stopped when parent is stopped anyway
The defaults should go into the configuration file, we have no defaults in code.
single short sentence for desc.
<BLANK LINE>
detailed description (possibly paragraph)
<BLANK LINE>
Сами неймспейсы не отбиваем же.
> itm
Т прнс?
This looks like it should work!
alignment !
Isnt it bad to default a named parameter to a mutable value?
Lets change the default for the above value as False and update the conf with the same.
The only way to return ERROR here is if the server isn't found, but the instance isn't being built or deleted. ERROR seems appropriate.
Let's use primitives instead of objects.
@tristantarrant What about we put this, and the method below, in TestCacheManagerFactory, so that other tests can more easily spot this way of creating a cache manager?

In fact, we already have a method with signature:
    EmbeddedCacheManager createClusteredCacheManager(ConfigurationBuilderHolder holder)

Maybe a equivalent `createCacheManager` there would make sense?

Also, we already have a method to create a cache manager from XML:

    EmbeddedCacheManager fromXml(String xmlFile)

But that's for a XML file path I believe.

Finally, we have test class in XmlFileParsingTest that creates XML config files on the fly. I'm not suggesting we put these tests in there, but they should share as much logic possible wrt constructing cache managers (at least, sharing the corresponding logic in TestCacheManagerFactory).

WDYT?
to deprecated something, you should use ``@deprecated`` in the phpdoc

And keeping the BC is better for now
exception is only set to not None when an `JSBridgeDisconnectError` has been raised. Given my above comment we never reach that code here in `run()`. So this is a no-op. So why I haven't added it to `run_tests()`? Reason is that we do not want to stop executing tests if a `JSBridgeDisconnectError` case happens. It's not a clear stop and can be expected by the test.
Now that the issue with handlers are cleared I would leave it and come up with a follow-up bug to reimplement the logging to the console. That's something we are missing right now.
s/can us/can find us/
A blank line is required at the end of the file.
That is for anyone who is interested in adding "zoom in on double click" feature (we only have zoom out at the moment)
so the mouse area already handles that, and the person who'll add the feature already has half work done
У нас, кажется, заведено что статический create это алиас для __constructor, а здесь логика у них отличается
тут слэшик лишний, пожалуй
It is not immediately obvious why we expect 3 headers here. The test would be more readable if you did something like

    var headers = {};
    proto.setRequestHeader = function(key, value) {
        headers[key] = value;
    };
    // ...
    t.eq(headers.foo, 'bar');
    t.eq(headers.x, 'y');
Sounds like you haven't committed the changes...
Why not simply have a `Markerb.renderer` be any objet and get rid of `render_options`? This way you can pass `Redcarpet::Render::HTML` or your own `TestRenderer.new(:show_text => true)` without a need to configure two different places. Thanks!
why are these here? Did you copy these from the schema namespace?
Why does this need to be window.location.hash? I don't see it being set anywhere?
@bp323 missing space here & above
I got blank IDs from the XML download. I suspect they're null or similar in the DB..
Yes, I think you're correct.

The problem with this is we clear the entire session structure during session close.

I think we have a few possible solutions:

1. Don't clear the session structure on close -- I don't like this because I think this might introduce subtle bugs in the future.   As a slight modification of this idea, we could have the session close code mark the session in some way, and then have the eviction server thread discard the session structure on close (as the eviction thread is the only thread that cares about checking  hazard references), but that doesn't sound like a lot of fun, either.

1. Go back to maintaining the hazard list separate from the session structure -- I don't like this because I believe we're going to have to grow the hazard list in the future, and moving the hazard list to the session structure is necessary to clear the way for that change.  (The argument is the one you made: a session with 100 cursors isn't necessarily insane, each cursor has a hazard reference, so 15 hazard references isn't enough.)

    The way I was thinking of growing the hazard list was to have a second WT_HAZARD *pointer in the session structure.  The hazard setting/checking code would have a second loop, to set/check the second hazard list if that pointer wasn't NULL.  The second hazard list would be quite a bit larger than the first (with a "max-active" count to minimize the amount of information that has to be checked, where the max-active count would be published by the hazard setting code whenever the maximum number of hazard references for the session increases).

    Arguably, we could switch to that model now (so, allocate 100 hazard references per session by default, and use a max-active count to avoid looking at all of them), but I think there's a requirement of an additional ordered-read for every session during hazard checking, to retrieve the max-active count, and that makes me dislike that.   I'd rather not pay a big cost for the vast majority of sessions that will have never have more than 1 or 2 hazard references.

1. Don't clear the session's hazard reference until connection close.   I made this work by doing one bit of trickiness, I moved the hazard reference to the end of the session structure, so it's reasonably simple to clear just the beginning of the structure and not the hazard reference field.
I (personally) think that might be a bit overkill.

But nice spot.
= IN should throw a SQL error,
1. Use sql_in_set
2. Use $request instead of $_POST
3. Ensure the values are integer!
degress=degree?
So what happens to `.span-all` elements without the snap? Do they just show up in the middle of text?
Are you sure ``$resource`` has the correct type as ``null|resource`` is not a sub-type of ``resource``? I found this a couple of more times on lines: 206, 213, 242, 266, 293, 321.
Are you sure that the property "message" exists?
Should this be `/auth/singly/:service`?
Dafür gibts doch bestimmt eine builtin funktion?! Ev. in den commons (falls wir die included haben)?
probably need to also add /part since that was in your match
This is really long. Does C# allow this to be linewrapped?

(In general, it's best to keep code width below the ~120 characters visible in GitHub diff views.)
Reverted by 02ee062b4d70b023f7e260a1eace9bcdc49ee5db.
No period here
use === test instead of ==
To be perfectly honest, I don't know why we're masking any of the `xsl` files. They're not a security risk at all, but yes this change would do that.

I would personally opt for removing any masking of xsl, but I was just following simplifying the existing code.
(Anyway, I think tastypie ignores CSRF protection currently.)
Create User class:

```
function User(data) {
    var self = this;

    $.extend(self, data);

    self.someMethod = function () {
        ...
    };
}
```

And then you do:

```
var user = new User(data.user);
users[user.username] = user;
```
Something is wrong: I get import error: cannot import name get_verbose_name

"from django.db.models import get_verbose_name"
I don't know why I get ```assertion error``` if I login with foursquare. Any hint? :)

Traceback:

```
Environment:

Request Method: GET
Request URL: http://127.0.0.1:8000/foursquare/callback/?code=ZCN4PDJ3AAS5QK0IMFIBL0TEXLT0WQHDFXBTK5YPESVUGC2F

Django Version: 1.4
Python Version: 2.7.2
Installed Applications:
('piplmesh.account',
 'piplmesh.api',
 'piplmesh.frontend',
 'piplmesh.nodes',
 'piplmesh.utils',
 'django.contrib.messages',
 'django.contrib.sessions',
 'django.contrib.staticfiles',
 'pushserver',
 'djcelery',
 'tastypie',
 'tastypie_mongoengine')
Installed Middleware:
('django.middleware.common.CommonMiddleware',
 'django.contrib.sessions.middleware.SessionMiddleware',
 'django.middleware.csrf.CsrfViewMiddleware',
 'django.contrib.auth.middleware.AuthenticationMiddleware',
 'piplmesh.account.middleware.LazyUserMiddleware',
 'django.contrib.messages.middleware.MessageMiddleware',
 'piplmesh.account.middleware.UserBasedLocaleMiddleware',
 'piplmesh.frontend.middleware.NodesMiddleware')


Traceback:
File "C:\env_piplmesh\lib\site-packages\django\core\handlers\base.py" in get_response
  111.                         response = callback(request, *callback_args, **callback_kwargs)
File "C:\env_piplmesh\lib\site-packages\django\views\generic\base.py" in view
  48.             return self.dispatch(request, *args, **kwargs)
File "C:\env_piplmesh\lib\site-packages\django\views\generic\base.py" in dispatch
  69.         return handler(request, *args, **kwargs)
File "D:\PiplMesh\PiplMesh2\piplmesh\account\views.py" in get
  120.             assert user.is_authenticated()

Exception Type: AssertionError at /foursquare/callback/
Exception Value: 
```
No inline JavaScript. Use jQuery to attach event handler to elements.
Always start a comment with upper case letter.
Feel free to correct and change whatever you want espes.  Redo it and make it better if that is what you want to do but I really do not have time for the playground nitpicking. 

I really do know what is missing and needs to be redone.  Thank you for your feedback but like I said it is not complete.  

Those are really just notes for myself right now.  I am tired of manually applying these changes and that is the only reason I am putting it out there to be merged.  If the rest feel the same way then close out the request.
return what?
There are extra lines in this switch
please don't store non-obvious data types in the parameter struct. these end up in the database, and being unsure about the size of stuff that is not a language feature but defined in random libraries will potentially cause trouble.

so maybe store a flag/an int with bitmasks instead of gboolean.
Puedes poner el if en su propia línea? 

http://wiki.gamersmafia.com/wiki/GuiaDeEstilo#Ifs_al_final_de_l.C3.ADnea
there's a type on the method name. While you are at it, could you add some comments to explain the purpose of it?
Hi,
I did the changes, but when I'm using your way, I have problems with the tests. in other words, they don't pass. The error is the following: 
Failure/Error: response[country_cd"].should == "CA" 
expected:"CA"
got: nil (using ==)
Not sure if it was an out-of-date merge from develop, but this shouldn't be there
put this in if with instruments and elsif, so we don't need to have 2 column_stack when there are instruments given
跟上面的意见一样
Good idea. I have provide mine for example

-----Original Message-----
From: Herr.Vorragend [mailto:reply@reply.github.com] 
Sent: Thursday, March 15, 2012 11:36 PM
To: N. Petkov
Subject: Re: [Scribite] Ticket 49: More support for CKEditor (#50)

> @@ -281,6 +282,10 @@ public function getckeditorBarmodes($args)
>          $barmodes = array();
>          $barmodes['Full'] = 'Full';
>          $barmodes['Basic'] = 'Basic';
> +        $barmodes['adminbar']   = 'adminbar'; # @nikp: have to be defined in custconfig.js (same for bars below)

I think that we should sever a "custconfig.js" for the users. It is easier to modify an existing file instead of not knowing where to store a non-existing file.

--- 
Reply to this email directly or view it on GitHub:
https://github.com/zikula-modules/Scribite/pull/50/files#r565666
this should be required in VideoPlayer if it's not already, and then it shouldn't need to be required here.
Correction -- this *is* a private method :) The existence of `@assets[:dir]` should be assured by the time this is called.
Why are you reimplementing servers and set_servers via the server_structs? I would think that the superclass methods would be close enough to do some massaging and delegate to.
Please do not use inline CSS. Use Firebug to see what CSS rules are applied to each element and which CSS rules are overridden by which other CSS rules.

You can also ask other members of your team to help you.
I know Zach has commented elsewhere about this.  You can add an Eclipse setting to auto-format your classes, which can clean up imports automatically.  Check our eclipse setup guide for details.
Blizz used "Bate-papo"
The initial `...` is a bit weird.  I think it might be clearer to write 
```
galsim.GaussianDeviate( [seed], mean=0., sigma=1. )
```
Then describe somewhere (probably above before the itemize) that `[seed]` can be either nothing, an integer, or another deviate object and what those mean.
Is there a good reference we could point to where these chosen definitions for lensing PS are made crystal clear?  It might help, but no worries if not.
Concur.

On Nov 14, 2012, at 12:50 PM, Sef Kloninger <notifications@github.com> wrote:

> In main/c2g/models.py:
> 
> > @@ -923,6 +924,15 @@ def __unicode__(self):
> >              return self.student.username
> >       class Meta:
> >          db_table = u'c2g_video_activity'
> > +        
> > +class VideoDownload(models.Model):
> > +    student = models.ForeignKey(User)
> > +    course = models.ForeignKey(Course)
> > +    video = models.ForeignKey(Video)
> > +    download_date = models.DateTimeField(auto_now=False, auto_now_add=True)
> Would TimestampMixin be cleaner? I guess then you get a updated date that would never be used, but seems cleaner and more consistent with what we're doing elsewhere.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
that's fine.

On 9/23/12 1:40 PM, halawa wrote:
>
> In main/courses/reports/views.py:
>
> > @@ -0,0 +1,16 @@
> > +from courses.reports.data_aggregation import *
> > +from django.http import HttpResponse
> > +from django.shortcuts import render_to_response
> > +from django.template import Context, loader
> > +from django.template import RequestContext
> > +from courses.actions import auth_is_course_admin_view_wrapper
> > +
> > +@auth_is_course_admin_view_wrapper
> > +def main(request, course_prefix, course_suffix):
> > +    try:
> > +        common_page_data = get_common_page_data(request, course_prefix, course_suffix)
> > +    except:
> Alright. Thanks. I will do the fix so this function uses the 
> middleware instead. I believe, reading through the middleware, that 
> you have more specific exception handling. So would that be sufficient?
> … <#>
> I will send you some results on the execution time for different nums 
> of students shortly. I am running a db_populate --massive with 4000 
> students on my machine and its taking some time to fill the DB. Can I 
> take the fix for undelayed writing of rows as a P1 and work on it 
> after the pull request is merged?
> ----- Jason Bau <notifications@github.com> wrote:
> In main/courses/reports/views.py: > @@ -0,0 +1,16 @@ > +from 
> courses.reports.data_aggregation import * > +from django.http import 
> HttpResponse > +from django.shortcuts import render_to_response > 
> +from django.template import Context, loader > +from django.template 
> import RequestContext > +from courses.actions import 
> auth_is_course_admin_view_wrapper > + > 
> +@auth_is_course_admin_view_wrapper > +def main(request, 
> course_prefix, course_suffix): > + try: > + common_page_data = 
> get_common_page_data(request, course_prefix, course_suffix) > + 
> except: sorry, i'm going to make a stink about this one. please catch 
> only certain types of exceptions, instead of all exceptions. You 
> should only catch the exceptions you expect, and can handle, meaning 
> you should be minimizing the set rather than maximizing. I am going to 
> gate the pull request on this fix. — Reply to this email directly or 
> view it on GitHub.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/Stanford-Online/class2go/pull/797/files#r1669409>.
>
Yup -- full supercession.  I think those were just kept around to ensure that the migration to the new system was done correctly.
nice to include \@Overrides
certes
Sounds good, updated.
This doesn't maintain all precision...
I notice that the parameter 'refunded_product' isn't referenced within the block.  Does this mean that if the subscriber cancels any product, he cancels all products?
I would prefer to use the `> -1` operation instead since you don't care about where it is.
let's remove this line if it's unneeded
the curly brace should be on its own line, and you should use camelCased names for variables
Oh good, I have an occasion to raise this problem: this file is a controller, and controllers should not care about retrieving data. That is the role of models. So everything that is related to a middleware service should not be here but in the topcrasher model.

Maybe not in the scope of this bug, but I needed to tell you that. I was kind of lost when I last looked for this code for debugging purpose.
I've been trying to figure out how to do the config for the past hour, but to no avail. 
Can somebody who is more intimate with config builder give some hints if this is even possible.
ping @stof, @vicb
Can you use the same way that another manipulator ?

https://github.com/Abhoryo/APYDataGridBundle/blob/master/Resources/doc/grid_configuration/manipulate_rows_data.md
So:

```php
<?php

public function __construct($url_prefix, Client $client = null, LogPlugin $log_plugin = null);
public static function SessionFactory($url_prefix, CookiePlugin $cookie_plugin = null, Client $client = null, LogPlugin $log_plugin = null);
public static function OAuthFactory($url_prefix, array $oauth_config Client $client = null, LogPlugin $log_plugin = null);
public static function BasicAuthFactory($url_prefix, $username, $password, Client $client = null, LogPlugin $log_plugin = null);

public function getClient(); // returns Guzzle\Http\ClientInterface
I understand that. That's pretty much related to the fact of making StepRegistry an internal component vs. making it a first-class citizen. I am fine both ways.
Maybe s/Fieldname/Field name ?
I guess you could put them in a :hoodwink_factories group and allow people to bundle --without hoodwink_factories.

But honestly probably not worth the effort.
Этот код может выбросить NullPointerException.
oh right, adding arrays is different than array_merge ... sigh, php.
unused import!
シンプルなコマンドの

リンクが消えてしまっているので

    シンプルな[war|commandLine]コマンドの

とかにしては。
I think for the preference descriptions it is better to use normal casing, not Title Case.  That is the original text is what we want.
If you don't mind it would be great to forward that email to the mailing list so that we have an archive of it.
why not relative imports here?
PEP8 says 2 lines between class definitions.
Absolutely - I'll send you an email immediately. 

regarding the PR - sure thing - I had it on my radar but I was a bit busy lately.
does the seed need to be fixed?
why did you hide the button; I think that it's a usefull featyre. did it look that ugly.
Please fix this, thanks.
Yeah. It's necessary for Solaris and it doesn't seem to hurt performance.
What should actually be in the feed?
ah, yes. makes sense.
Is this going to cause problems if there are say 2000 subfiles in a super file?  (Jake thinks he's seen super-files that big). Should it only display the first <n>?  Do the lines need breaking up?
Formatting looks a bit odd here.
The test (modScope != containerScope) looks as though it could be performed by the lookup, passing "extraLookupFlags(modScope)" like you do below. Though I'm not sure it's the same semantics.

Nevertheless, the check looks correct.
Is there a significant benefit in dynamically creating the buckets, rather than creating them all up front?  If because of hash table size, should the initial hash tables be smaller?
ditto as in doConfirmDeleteSmartFrogLogs()
Good catch. I missed the slashes at the end. Certainly a human error during rebase... :/
Yeah you're right - this shouldn't be top level - it fixes the test but the test is flawed since caller_module_name will never be a fact.

Ive reverted this commit
I pushed a new commit that uses `request.uri`.
Doesn't accepting a dict/list for hmget/hmset could save us this recursive algo, isn't it?
在 UTF-8 環境下開 Firefox 閱讀生出來的HTML 才看到的, 是 Big5裡沒定義的字元 ( 0xAE 0x20 )
I would have done it in a for loop to reduce the code duplication. We can take care of it when we implement the full parsing of the complete data. For now it's fine even unusual for me too.
I think those can go away now that we actually have docs.
This will be additional_fetcher
When you read this line what type is bar?
var bar = "foo".MatchesAny(predicates);
I guess you're right.. I'll get rid of it.
don't nova-compute nodes still require tgt and it's related actions, regardless of nova volume vs cinder?
@shacker can we "abstractify" this into a general class?
I didn't delete the first line on perpose. Maybe online edit automatically omit the first empty line. Both pulls have the same problem then,
please use camelCased names for properties (and probably a shorter name)
> Instead, what I think is best is for Discussion.search to have some adequate tests and documentation.

That sounds like the best next step :+1:

> Also, I think it's natural when using get parameters in the controller to assume that those are the params being sent on to the search method. 

Of course. The only yucky part is that Rails includes more than just the get parameters in the `params` hash. But as you pointed out that isn't a big deal in this case since that method is only using the values it is concerned with, `state` and `category`
TARGETURI and its api should be used
The default timeout value isn't a problem for me.
This should be fixed in the most recent batch of commits. Please, double check this another time ;-)

I also added the article from above to the reference list.
s/he is/they are/
The central body doesn't have a pick id. Should I add one?
Can you add a comment here ? intentionally blank or smthg ?
こちらでは大丈夫でした。
Rubyのバージョンを1.8系を使っているんですね？そのへんでも違いが出てきそうです。
declarations on different lines
It would nice if 'i' and 'row' were defined with the other vars at the top.
We should reuse numChildren/numNodes instead of declaring two variables. Saves on file size a bit that way.
Blank line please :)
Why do this if? Shouldn't ${output.text} just return an empty string if text is empty?
Do you really have to import dart:core? I thought it was imported automatically.
I don't like the documentation pointing to a single commit. It should point to the tree surely.
startServer(permittedPorts.min, handler) and inline managementPort and managementLimit into the permittedPorts definition wins 2 lines.
No need for media and type attributes. Should probably be cleaned up in other demos as well.  Also no need for type attribute on script tags.
Rather than explicitly listing all elements, just use "Structural Element". After all, that's the term for... all those.
i have encounter the problem when install graphite_dsl 0.04
another blank line required.
Please fix it so that the braces are on their own line. One of the few style rules that we stick to in Phobos is that braces go on their own line. And having the `in` there is _highly_ confusing, since it makes it look like it's an attribute on the function, which isn't even legal.

As for whether it should be const, definitely not. First and foremost, `opSlice` needs to be able to return a fully mutable slice when the `Sequence` is mutable. That won't work unless you can completely copy the `Sequence` when slicing it, which would mean copying rather than slicing. If it can't return `Sequence`, then there's something wrong. In fact, I'd advise changing the return type to `Sequence` in order to catch that ( and since inside a template, the name of the template when used by itself means that particular instantiation of the template, it really isn't an issue to use it instead of `auto`).

Now, it would be nice if `opSlice` could work with const objects, but that would mean either using inout or overloading `opSlice`. The fun part is that in order for it to match how arrays work (and how many Phobos functions expect them to work), the return type of `opSlice` must be tail-const _and_ implicitly assignable to the original type, but I have yet to see anyone able to make a templated type do that, because you end up with a recursive template instantiation when you try and instatiate a tail-const version of the type to return. It's something that I've been meaning to bring up in the newsgroup for discussion.

So, for now, I'd say that you shouldn't worry about having a const version of `opSlice`. Just make it mutable. And if you want to make it const, you'd need unit tests testing it as const anyway, which you don't have.
Hey wait, you are right: This is the struct implementation, so enums should not be an issue . Using:
`static if (is(typeof((inout int _dummy=0){static T i;})))`
here should be fine.
`COINIT` is the name of the enumeration directly above it. If you make it `enum COINIT { ... }` then qualification becomes `COINIT.COINIT_MULTITHREADED`, which is both redundant and incompatible with equivalent C++ code. The alias just makes it work more or less exactly like in C++. The rest of the header does not bother with this extra step and just foregoes the name of the enum entirely.
Does/will that work if `ror.front` doesn't return an Lvalue?
Implementation of new paramaters for the analog in task : name of the analog in device, use of a trigger for synchronization...
OK, now I see. Fixed.
That kinda sucks :-(
I think this could be clearer:

    The server log should contain a message at (about) <date>, indicating that the call to the asynchronous bean completed.
Perhaps it should force the internalPixelFormat back to whatever the video reports, and ofLogError()?
If brew has already been deleted, this will pick up the local pip, no? In which case, could this be deleting from an unintended location?
@neoeahit Would you like to update the default scheme value? ^^
Indentation. Please use 2 spaces.
I imported the file 'by hand' and I applied the tested operations and I obtained a report with different numbers, it seems that Refine counts differently the number of modified lines within the model since 2.5 (may be a Refine regression?).
Did you mean this to use backticks rather than single quotes, to evaluate hostname?
Or should we be using something like machine.getHostname()?
PaginatableArray -- наверное имелось ввиду PaginableArray :)
curly on the next line
Lets avoid the regex, I like option number 1
self.parent_id -> self[parent_column]
We should add the rest of the departments and then make the combo boxes pull from this enum.
Ok, convinced :-) - and we did the same for ```documentDrag```.
This call already has a `get_password` method for reading the password from STDIN:
https://github.com/opscode/knife-windows/blob/master/lib/chef/knife/winrm.rb#L133-135

Can we just leverage that here?
Some corrections:
*errors*
*thrown* (twice)
*dereferencing*
*system-dependent*

It's also a good idea to use $(D symbol) when referencing symbols.
This is what makes it possible to use Mandrill more intuitively, like ```mapi.messages.send``` instead of:
```
mapi = MailSnake(API_KEY, api_section='messages')
mapi.send(...)
```
Should use the new function to set FormView parameter.

->setVar('format_tags', $form->getAttribute('format_tags'))
Another font family of choice?
use BigInteger for this:
return new BigInteger(msgDigest).toString(16);
Remove this line if you don't want this theme to override your existing ls colors
Yes. Sorry for the typo.

--- El mar 20-nov-12, ramielrowe <notifications@github.com> escribió:

De: ramielrowe <notifications@github.com>
Asunto: Re: [Evangelion--3.0-Translation] Update TRANSLATION (#11)
Para: "eva3/Evangelion--3.0-Translation" <Evangelion--3.0-Translation@noreply.github.com>
Cc: "YQS" <fsaliceti@yahoo.com.ar>
Fecha: martes, 20 de noviembre de 2012, 13:58

In TRANSLATION:
> @@ -171,11 +171,11 @@ I've been waiting for you
>  08:34-08:52 - 検体、DM03、拘引しました <Unsure exactly this was said>
>  08:33–08:52 - <Overspeaking by various people>
>  08:54 - Pervert [...] <Couldn't hear the rest>
> -08:57 - 了解、拘束を解いて。
> +08:57 - Understood, restrains released.

Is this supposed to be 'Understood, restraints released.'?

            
              —

              Reply to this email directly or view it on GitHub.
Hm, Just a note here.
This particular constructor's a _bit_ complicated because of the CustomerID thing, since there's no real way for us to determine what the database will assign to the next new customer.

Options:

* In the constructor, call a "Create Customer" on the database, followed by a "Get Customer" query on the database, and getting the customer ID to store that way.
* Initialize the CustomerID as null, and add a method called something like "saveNewCustomer" which would then call "Create Customer" on the database and store all the information that way.

Uh. Actually, now that I think about that, the second one looks better. What do you think?
this method is invalid, just use ``$admin->getTemplate('preview')``
You shouldn't put this calls in the views, instead make a call to a custom function in the collector
This should just be ```require 'test_helper'``` as in other tests.
Did you intend to upgrade the solution?
This logic is probably cleaner with individual case statements instead of several case statements following by conditions (who knows - I probably wrote some of this).

Same comment for the others below, but perhaps less so since there is more shared code.  To share code, a common function can be created.  C# has closures and all that good stuff I'm told.
Should it also clearRedirectToUrl() or is it superfluous (unreachable edge case)?
you have extra spaces here
Drop this branch into the `compat` module, so we can just do...

    from rest_framework.compat import smart_text
in issue #587 (custom sized maps introduction) is stated, that maps have to be square atm. might be connected to this crash. 
is it working with square maps?
Now I'm not so sure. I've seen a lot of javascript but almost never in the notation with the else statement on its own line. 

My take on it is that without the else right after the `}` it reads as if it's a if statement alone without an else. That and the fact that it's a rare convention. Kinda like this is valid but also very rare:
```javascript
if (foo === bar) 
{ 
    doThis();
}
else
{
    doThat();
}
```
jake deploy-tests should be added.

You should also mention

Please run jake -T to familiarize yourself with various tools available to you as a developer.
very little

("information" is not countable in English :p I used to make that mistake all the time)
you should always add the :dependent => :destroy (sometimes :nullify for logging purpose or when it is relevant to still access the data) operand to avoid cluttering the DB with never accessed entries/rows.
Needs space
Just FYI - question mark is actually not a valid character for metadata key attribute.
Need to use the "title_field" in the settings array here, not a hard-coded title field from the model
Gah!  I see.  I got this mixed up for a real model.  For testing models, sure... this is fine.  I blame Dave and being tired. :-p
Yes, lets come back and refactor.
yeah, but you're writing a part of the manual of the oeb; staying 
general sounds quite interesting in such circumstances :-) basically 
it's ok to give a general description of the feature, but where you e.g. 
reference a bus, reference the OEB

On 02/18/2012 05:20 PM, ChristophPrybila wrote:
>> +<para>Actors share links of modelobjects via channels like email, when they want to
>> +                highlight points of interest for other actors. When an actor receives a link to a
>> +                modelobject, he wants to open corresponding datapoints in his tools and datasets. To
>> +                make those links easy to call from a wide range of programs, it may be wrapped in an
>> +                url that points to the registry, for example<emphasis role="bold"
>> +>http://urlToRegistry.suff/modelobject-link</emphasis>. The registry must be
>> +                able to receive such http requests and act on them. Since we are talking about a
>> +                distributed integration framework, the registry and the tools must also be able to
>> +                communicate reliably over the network. Therefore they must provide interfaces for
>> +                communication.</para>
>> +<para>As mentioned, the<emphasis role="bold">registry</emphasis>  must act as a central
>> +                component to all tools and must therefore be providing it´s services the whole time
>> +                to enable linking. Tools may be up and running or not. When an actor starts his
>> +                client in the integration framework, his installed tools must notify the registry if
>> +                they will participate in linking. During a registration, the registry associates the
>> +                tool with an appropriate model. The tool must connect this model with it´s
> what "how"? I´m sorry but I cant figure out what you want to point out here.
> Remember, I wanted to keep this chapter quite general and go into openengsb details in the next chapter.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/openengsb/openengsb-framework/pull/639/files#r464876
Except that we *use* CACHE when logged in, since this is django default.  So this global SETTING *is* a problem.
ah I get it
All over the code, their is this._attribute , _("String") and I was wondering, what's the purpose of all those underscores?