labofsahil/github-event-dataset-2012 huggingface dataset:
As it is not usual that a container returns objects that are actually not "equal" to the contained ones, why not calling this function  "on_surface" instead of __iter__ ?
- iteritems is deprecated in python 3 (future-proofing)
- list comprehensions are generally faster than for loop; willing to change back to for loop if this isn't readable (I'm biased, so have no impression)
What does ``lazy_index`` do?  I'm a bit confused by its docstring.
You mean, the effect size of the contrast (c^T \hat{beta}), on top of the statistic ? Sure.
I'd still have all this stuff in it's own controller - maybe that's just me
This will break on unicode
They both get created, but anything that will reject a sync will also reject a publish
This is an interesting paradigm we're shifting to. I dig it.
you should be able to just use `dummyAjax`
Yup will align properly.
I think I misunderstood you first comment. The question is should an external xrandr command overwrite the desktop resolution, right? I think so, in particular when using pvr where a user wants to switch frequently between fullscreen and minimized view.
well, the problem is that if this is the first thing that occur, it will not stop parsing and it will output a pes packet belonging to the new pmt before the new pmt is output. Ie the wrong order.

If we get a new pmt in the middle of a pes packet, i suspect we can flush the old pes. So setting stop_parse here would make sense i think.

This is really tricky code thou. And we do want something we can get upstream, so we need to get this nice.
Good point will change.
Er..... sorry, my mistake.  This comment was meant for the PhenotypeAttempt
isn't this actually an ordered "prioritized" list? or is there more work to do?
Per the discussion in this message (http://www.rtems.org/pipermail/rtems-devel/2012-August/001693.html), please pre-allocate all structures used for "key/thread value pairs" and keep a dedicated RTEMS Score Chain as a pool of them.
rename bounds to size.
removed because there was no implementation for it.
It is lazy because it is only used in some logging cases. I think this was  
a recommendation of someone.
Your xcuserdata/thijs.* should not be in github. Please remove and put xcuserdata in .gitignore.
There will be loss of precision here, because doubleValStr came from a double, and there is not a distinct double value for every long.

long l = Long.MAX_VALUE - 10;
double d = Long.MAX_VALUE - 10;
long ld = (long) d;

System.out.println("l:  " + l);
System.out.println("ld: " + ld);

Prints:
l:  9223372036854775797
ld: 9223372036854775807

However, none of this matters because it looks like Errai's JSON parser (server-side) presently treats all JSON numbers as doubles. GWT's JSON parser (client-side) delegates to JSON.parse() or eval(), so it's all doubles there too. If there was more precision on the wire, it will be lost in either case.

Given all of that, what about just returning o.isNumber().doubleValue() unconditionally? It's simpler and shouldn't result in any loss of precision.
Shouldn't this be hinted as being aligned to SPI_ALIGN_BASE ?
It probably makes sense here to exempt the `gauges` type. Since the last added value persists in the metrics object, it will just keep adding the values which isn't really useful.
That explanation doesn't make sense to me. It's only short-circuiting hide/show logic.
And maybe name it `encodingAssert()`. Brevity is good but so is readability.
Maybe intended d3_radians here?
Yes, modified all tab's to spaces
Fair enough

________________________________

From: Matt Shin [mailto:notifications@github.com] 
Sent: 18 October 2012 16:36
To: metomi/rose
Cc: Fitzpatrick, Ben
Subject: Re: [rose] metomi/rose#6: rose suite-run: ROSE_ORIG_HOST (#68)



In lib/python/rose/run.py:

> @@ -397,6 +398,12 @@ def run_impl(self, opts, args, uuid, work_files):
>              self.fs_util.chdir(opts.conf_dir)
>              opts.conf_dir = None
>  
> +        # Automatic Rose constants
> +        for k, v in {"ROSE_ORIG_HOST": socket.gethostname()}.items():

Your suggestion does not work. It needs another pair of braces around
it.

The code was originally written as:

constants = {"ROSE_ORIG_HOST": socket.gethostname()}
for k, v in constants.items():
    pass

Therefore, it looks as it does now. If there are more automatic
constants in the future, I'll pull the dict out.

-
Reply to this email directly or view it on GitHub
<https://github.com/metomi/rose/pull/68/files#r1880097> . 

 
<https://github.com/notifications/beacon/PlVaVh46Oxl2lylB_4sPDQYIbUzkuZQ
Fdw_yHmI1dMer-75q7_l8CYVI6Fo7BY8A.gif>
This bug did not just deal with None, while that is all that was reported, it was actually caused by any mix of anything that could not be indexed and things that could, when the item that could not be indexed was not in the first position. Possibly adding a line to test for an array like [3, (1,1), None] would be a good idea.
Есть.
For some reason, this block was indented with tabs instead of spaces. I've made this more consistent as well.
IMO, it's fine.
This always sets `updated_at`, so you can't `touch(:other_timestamp)` without changing `updated_at`. Not sure if that's a good idea. It's not demonstrated in the test coverage, in any case.
sure, I'll do it in a second. Is there a specific reason to prefere inheritance? I've seen that there are models of both kinds.
The text says `config.secret_key_base`, and the example `secret_token`. Is it correct?
Exactly, doing it now.
Yes, this is sad. I'll see what I can do about this.

On 2012-08-07, at 9:08 AM, Mike Cooper <notifications@github.com> wrote:

> In standup/templates/includes/macros.html:
> 
> > @@ -70,7 +70,7 @@
> >          {% if status.project.name != last_project %}
> >            {% set last_project = status.project.name %}
> >            {% if show_project %}
> > -            <a class="project-name" href="{{ url_for('project', slug=status.project.slug) }}">
> > +            <a class="project-name" style="{% if status.project.color %}background-color: #{{ status.project.color }};{% endif %}" href="{{ url_for('project', slug=status.project.slug) }}">
> The length of this line makes me sad :(
> 
> plus it makes github draw a scroll bar.
> 
> —
> Reply to this email directly or view it on GitHub.
>
this check is not based on... WHAT, THEY'RE ENDING THE SEASON THAT WAY?
Would it be useful to also log `CyclicReference#{sym, info}` here?
I think the comment was about ordering these three methods in the source code, not `Ordering`. Or did I misunderstand smth?
@smichr Yes, that seems to be a better way to do this. 
Shall I make the changes?
Yeah, I wrestled with that for a while. I can change it if you like. I'd really like to make this `canonicalize` as I think that's what is actually happening. `evaluate` sounds way too strong for what we're doing. I suppose it's best to maintain a uniform interface though.

Would you prefer this change?
I'm a little clear what you're saying here, but `expand(deep=False)` should not recursively call expand on any args, only rearrange the ones it has (to look at it another way, treat the args as if there were already too simple to expand, like Symbols or numbers).
Put in the full wikipedia link.
if it's not there anymore then this comment will have no meaning for anyone looking at this in the future, so it can either be deleted or changed to indicate what you are doing, perhaps?
Why not just call the argument `keys` or directly use `wilds` in the function body?
A lack of knowledge here. So does __eq__ check memory location or does it do the above automatically? If its the latter then I can see sense in removing it. If not, it needs to be there.
I'd recommend starting the function name with a lowercase letter, unless there is special reasoning behind having it start with a capital letter.
@cebe Eine Idee wie man dies besser übersetzen könnte?
You do not want the unique Meta tags registration – fine, you can through the related code away.
Just apply the first 2 commits of this request (804c7aa, 50cbb81), which fix the bug, event it was not the one reported in the issue.
Yeah, I was just used to write this way, but removed it now.
I don't think this file belongs in this commit, right?
The vocabulary seems to have been changed by this branch to talk about lending limits rather than loan allocations. Should this method still be named allocations?
Get rid of the trailing semicolon.
The iterations argument should be `1` instead of `0`.
For performance reasons I would much rather use a critical section for this.
replace "most situations" with just, "read from a secondary if available."
because you aren't using these anymore, you should probably remove all the console.log messages that were used for debugging
See IRC explanation.
I didn't fully test it and I don't completely know it's consequences.
This is not something that is used directly by a user call, so I didn't test it fully on that. Anyway, I felt like I needed to protect my hide.
Any new features that are not required, IMO, should be disabled by default. Anyway, this isn't a big deal so if everyone really thinks this needs to be enabled by default, then fine. I just think that it's a good rule of thumb that when changing something (we are changing the way the last post info is displayed), it should default to how the user expects it to, and then give them the option to change it.
In javascript perhaps?

My reformat script doesn't make this exception currently.
Because the previous one does, I would imagine.
Should start with a capital O (like on the next description)
супер! ще ги пробвам (или поне някое) :)
Maybe silly, but I would move the duplicate PRIMEs out to `PRIME_INT` and `PRIME_LONG` and reuse them vs copy.
here should actually be the plugin folder name, isn't it?
Oh, I hadn't thought of that! @Gozala can you make a pull request on monotonic-timestamp?
@aszlig Your reasoning makes sense to me for why this isn't in pythonPackages, but wouldn't buildPythonPackage still help here?
this is the only change right? (action: 'doLogin')

per my comment below, be careful about editing the whole file at once. it's confusing to review the code if you can't see the important code changes via the diff
Fix it, I return it without replacing it with IndexCountPlanNode if the TVE is on the right of this expression.
It took me a second glance to see that your just matching of the `monitor_list` here. I know that this is perfectly valid. In most other gen_servers I've seen in riak the match is done in the function head. I'm just mentioning out of interest: do you prefer this style for a reason?
because then it is guaranteed to be normalized.
We could remove this comment.
DBAL code was not closely revised by me during its creation.
This is not an excuse to not implement the standardized code when implementing new one. I don't mean to sound harsh, but whenever you see some code that's not part of our standard, feel free to update and send a PR. We have tons of them
Comments should always start with upper cased letter
There is a way you could make these queries quite a bit more concise:

http://pastebin.com/F5d3FJwx

Basically, this example uses the `//` operator skip over elements that we don't care about. See: http://www.w3schools.com/xpath/xpath_syntax.asp
Can you convert all of the variables to camelCase?
@mathiasbynens I love it :)

Feel free to add additional instructions for anything that isn't covered but should be
create a separate test rather than calling `Qunit.reset();`.
@PaulBRamos, do you want to take that too? Removing the fragment cache will make your job here much easier. You'll probably want to submit a separate pull request for http://bugs.jquery.com/ticket/11989 and then rebase this one after it lands.

I'm happy to do it if you prefer, but rebasing seems so much more pleasant when it's on top of your own changes.
There are methods that don't have to worry about its input being a nodelist and that is the case for this one and for the other ones I've indicated. for loops comparing an index to length are faster than for loops checking for null.
In terms of how the user of this class should perform seeding, I think it should at least be explained in comment somewhere. Since I can still abuse this seed function when I use this class with the interfaces provided now. :)
`:hover` (and `:active`) have the same specificity as a class (10), so if you just put the `&:hover` block below the `&.selected` block, `:hover` should win without needing `!important`.
This is my first homebrew pull request (if you can't tell :) ).  Is the correct convention to separate multiple command params by commas? e.g.:

```
system "./build",  "--prefix=#{prefix}"
```
Run `brew audit`.

Since there are multiple MPI implementations, we can't pick one on the user's behalf. This needs an `MPIDependency`.
Should we bite the bullet and do this by default in ENV.setup_build_environment even when HOMEBREW_PREFIX is /usr/local?

Or, alternatively:

```rb
sqlite = Formula.factory("sqlite")
ENV.prepend 'CPPFLAGS', "-I#{sqlite.include}"
ENV.prepend 'LDFLAGS', "-L#{sqlite.lib}"
```
No, definitely keep it.
MAKEFLAGS is for passing flags to `make`. HOMEBREW_MAKE_JOBS (probably poorly named, but that's beside the point) is to tell Homebrew to allow X number of parallel jobs, and is useful even for things that do not use `make` (scons, for instance.) I don't see why it is an improvement to have the user set MAKEFLAGS directly.
Thanks for this Jack. I have changed the descriptor accordingly.
It looks like this is actually a `#column{}` record in epgsql and it would be better to use it as such.
I think it'd be fine to leave the semantics as they were before (i.e. yes, please do remove it). I assume this change is for one of your modtools userscripts since you can't put subreddit CSS on a multireddit or /r/mod, right? In that case, it's safe not to enable for admin mode as we try not to run userscripts on privileged accounts for security reasons.
kind of weird to do a sample like this here
the same {@code Lazy} instance will return.
nice explorer logic
WASplash shouldn't  be aware of operation types.
78 chars for POD, and code, please. Do-able?
I would also prefer longer names, but `e` would be appropriate in this context. Thanks!
This should be removed not commented out.
Drive-by comment: should indicate this is optional: `{boolean=}`
Ooops. I removed that so I could make the tests pass, but forgot to turn it back off again.
This needs to handle the case where propId is not an integer. A savy user might change it.
would this be faster if durations was converted to some numpy array type just once?
May be this my python vocabulary..
I never defined form textbox. I guess this got messed a bit when merging.
Keep the comment style here, please.
Hm. A whim I guess? Markdown leaves it all as the same paragraph ( https://github.com/jbuck/butter/blob/7f9e4c6ae69960dfabacebea1447d8057c415fed/README.md ), and the line was kind of long... but I can revert it
How can this not exist?
Just to keep the behaviour of the callback system consistent, so you can expect the event loop to roll over once regardless of whether or not your check function succeeds.
Why aren't we just shimming console instead of always assuming it isn't there?
Likewise - this feels like a case for the page IDs
What about the more concise:

    // Append .pdf to the filename if it isn't already there
    url += (url.toLowerCase().indexOf('.pdf', url.length - 4) !== -1) ? '.pdf' : ''
test assembly does what? I should be able to tell by the method names what is being tested.  If it can't be summarized in a simple sentence it is probably doing too much
did not try, it will probably show the generic error message box.
I think that was because on some OSes the size is not given. Also I thought it might be possible that the binary is generated on the fly. I think even HTTP1.1 allows for that. But perhaps a Try is wrong, and an Option would be better in that case.
this shouldn't be deleted
Yeah but it works :-) I am actually putting this on one line.
I had it there, but replaced it with direct connection because thank to puppet, we cannot be sure httpd proxy will be already running :.-(
I'm not a huge fan of checking at promotion time only, just because
you could potentially have a failed promotion at that time, and failed
promotions are bad (can't roll them back, etc..).

On Fri, Jul 20, 2012 at 10:41 AM, Ivan Necas
<reply@reply.github.com>
wrote:
>> @@ -205,20 +205,19 @@ def export_as_tdl
>>
>>
>>    def add_package package_name
>> -    if pack_attrs = Katello::PackageUtils.parse_nvrea_nvre(package_name)
>> -      self.packages.create!(:package_name => pack_attrs[:name], :version => pack_attrs[:version], :release => pack_attrs[:release], :epoch => pack_attrs[:epoch], :arch => pack_attrs[:arch])
>> -    else
>> +    package = Resources::Pulp::Package.name_search(package_name)
>
> I'm not talking about checking that in the promotion phase. And that should also be the time, when checking the package specified in the template, can be found in the environment. What I'm suggesting is, in this place, use only
> ```
> self.packages.create!(:package_name => package_name)
> ````
> without any conditions, and do the checking when promoting (or alternatively when adding the template into a changeset)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Katello/katello/pull/335/files#r1205772
This is probably overly nit-picky, but the lack of whitespace in between logical segments makes this kind of hard for me to read.
You've a fault. It's called "Du scheinst" not "Du scheints" ;)
I think yes, it's possible that users have audio files with characters (&), (<), or (>)
We better escape them or the UI will be messed.
Maybe I have to use textContent to assign the text.
I had thought a little about how to not create the array of zeros.  This solution was driven by making downstream code simpler since the arrays can be assumed to be matched in length.  There is likely a more elegant solution but when I was writing this I didn't want to get stuck on that detail.  In any case the `val2` array is temporary and goes out of scope after `__init__` is done, so memory use is temporary.

Don't know about multi-line comment.  I guess you can just state which lines you are referring to.
perhaps above this you should put ``result_error = MyError(...)`` or something like that? Then it's clear that `result_error` is an NDError subclass instance, rather than an array (as I originally was thinking).
:heart:  :metal:
The thing is, it won't be `/tmp/rt` on the buildbot builders. I almost feel like we should use error_logger to write something to the console and then check the `console.log` for the message. Alternately, we could have it write to a new bucket/key and then read the bucket/key from the test.
I feel like this should all be in an initializer. Also we shouldn't have to require things on a per-file basis like this. Putting them in the Gemfile should load them or we can do it in an initializer for the non-gems.
I suppose we should declare fRequestShutdown as volatile, as a sufficiently smart compiler will decide to move this statement out of the loop, as it doesn't depend on the loop invariants in any way.
The rest of the code uses #include <limits> and std::numeric_limits<type>::min()/max(), it'd be nice to be consistent if possible.
After the last rebase, I reverted to the current used coding style for this.
should dygraph-combined.js and excanvas.js use requires include isn't enough ?
it exists because phpdoc was created in the PHP 4 time when there was no ``static`` keyword for functions (this is the same reason why ``@private`` and ``@protected`` exist in phpdoc). Doctrine does not use ``@static`` anywhere in the source code
(but you should override that method in your preferred dialog instead, so just leave this line as it is)
When a user only wants to generate the report without executing a simulation, there is no simulation hence the Option.
decode/encode are used in lots of places, although with different names. Are you suggesting to go change the usage of those calls? If so, should that be done as a separate pull request?

decode/encode are also used with the following names:
* Python 2
  **decode**: str_to_unicode
  **encode**: unicode_to_str and inside cast_bytes (as cast_bytes_py2)

* Python 3
  **decode**: bytes_to_str
  **encode**: str_to_bytes
IPython requires 2.6 now, doesn't it? We could make an ABC that checks for the necessary methods, and then use a plain `Instance` trait.

http://docs.python.org/library/abc
Is this missing nargs=1 ?
just to be clear, you're suggesting extending basecomputeservice and using strategies, right?
This whole function can be condensed to:
```python
def convert_to_json(message):
    """
    converts input (as formatted by collectd) to json
    """
    return dict([line.split(': ', 1) for line in message.splt('\n')])
```
Note that you're not setting the error code here. This should jump straight to an `on_error` label.
Nit: alphabetical order.  I prefer these on one line too,

import argparse, bisect, ...
Wrong, it should redirect to `settings.LANGUAGE_CODE`. :P
`getElementById` will have a broader browser support.
yeah, good call on this move.
Nit: trailing semicolon
Ah yeah you're right, you're really dealing with splitting the path here.. having trouble thinking of a name that isn't too ugly, might be nice if it had "path" or "url_path" or something in it.

I am fine if you leave it as-is too, now that I realize it's different from urlparse.urljoin(), just didn't want to duplicate the code.
??
is that code not done yet?
because this is `jinja` you can do `third_party_libs[name].link` if you want this to be prettier
I'm curious what problem "sequence(:id)" was solving for you. The rest of the test suite doesn't need this. Eventually, I'd like to make these singletons, but haven't gotten around to it.
This allows to inject a different ResponseFactory without forcing to inject a ResponseFactory.

Client does the same thing with the ConnectionManagers.

This still has the benefits of dependency injection, without giving too much work to the client when it doesn't need it.
Indeed, i'll change it.
Doesn't this leak the pGregorianCalendar instance?
Please provide a more detailed explanation of this hack
Same as `$rootDir ?: $this->getRootDir()` ;-)
I would rename it to ``DriverInterface``. ``Cache`` is already in the namespace of the component
you should typehint the argument here
This class should go in a subnamespace IMO. It is not one of the main classes of the component (Kernel and HttpKernel are at the top level)
@vicb oops :/
indeed, I think it's a copy/paste issue :-/
Why this is in `@try` block? Which part could raise an exception?
kill this, super class can handle it
ghabl az neveshtane a (line 55)
```
    &:hover
        a
            background-image:url(images/nav_hover.png)
```
add a space between arguments.
Agreed.  Make this function virtual like all the others and put the implementation and data in the ICI subclass whose purpose is to hide the implementation.
Isn't the digest always the same size? Would it be more efficient to also have a method to return it as a struct of the right number of bytes?
Not a big deal, but do you think you could indent this docstring back the way it was? I've got nothing against this style, just that it isn't consistent with the rest of the library.
Consider doing the filter inside the loop to avoid the need for the lambda that always returns True.
I am not sure removing this code is a good thing. I think this code has to do with the fact that when you only have permission for 2 out fo 5 pages you only will see 2 pages and maybe some of them will be a root.
This line isn't needed, as even when using curl we still use the require() api definition to keep forwards/backwards compatibility
Hmm. Needs i18n, although w/o any context provided in the message it should be removed altogether.
We should probably have something like 
```java
return LoggingLogger.ROOT_LOGGER.rollbackFailure(cause);
```
testParseEmptySubsystem() was checking the number of operations (which may or may not be necessary) resulting from parsing.
Tried to avoid having the same code copy&paste all over.
Probably a good idea, but I won't get to it until tomorrow. Up to you.
лучше просто getRemark(..)
This doesn't even compile: you're trying to assign from a String to a double. I'm concerned that no testing was done if your pull request won't even compile.
Yea, it's a view controller.
I'll rename it.
I would say that FTU is not obvious for user, so you may want to replace that by something more visible.
Nit: I propose `meridien` instead of `mode` (“meridien” being the “M” in AM/PM).
better to codify this function as follows:

return ((number.indexOf('*') != -1) || (number.indexOf('#') != -1))
ugh, I missed this `data-state`. Can’t we just use a `:target` selector instead?
Can you comment every new function with a short, one line at most commentary? It is really useful when you are facing the code for the first time or recovering it after a long time.
Is it because the keys have a gap between them?
This function deserves a name :)
And finally, this focus toggle allows to correctly restore the focus when closing an attention screen and getting back to the original app.
For exemple after receiving a call when writing an SMS. Without that the keyboard doesn't show up after the call.
Never mind, I've just realized this is just a fake API.
Now it's in the Javascript code in order to use scope properly.
I added <code>setLocalization()</code> that does the localized things, and put <code>navigator.mozL10n.get()</code> in it to assign the global variables for <code>unknownArtist</code>, <code>unknownAlbum</code> and <code>unknownTitle</code>.
<code>setLocalization()</code> will be called at init() and mozvisibilitychange, thanks for reminding me the localized strings maybe wrong if music does not update after users change the system language.
`(evt.prevValue.indexOf('edit') !== -1)`
ooops, my bad. Thanks for picking this.
#### Current ####
The power saving **setting** does this:
1. When ON: Turn off wifi, 3g, gps, bluetooth
2. When OFF: Turn on wifi, 3g, gps, bluetooth if it had turned them off.

@RudyLu wants to introduce **turn off the power saving setting when charging**.
And I am wondering **change the setting is not suitable. should be IGNORE the setting when charging?**
Didn't knew you were an "empty line at the end of the file" kind of guy :)
Oops. No need to deprecate it. Updating...
See https://github.com/fnichol/Razor/commit/bb8543d702ebe5342d32c459dbf1ba7cede4b1a8
If you don't strip new lines, `new Function` takes below codes:

```javascript
parsed = new Function("return \n
(function () { .... })()\n
\n")()
````

This codes raises syntax error.
But it may be too late to ask, should I use `vm` module instead of `new Function`?
I'm not sure if this is the best approach to grabbing the value. Feel free to refactor.
Why the Metrix?
use same mentioned constant
Move this global to the top of this file and document it.
Is this accurate? I thought it also deleted any values associated with those keys.
Also write names as they are officially written: FeedBurner, RSS, URL... Also end all the sentences with period. ;)
What is the real difference between canDamage and canBuild/canDestroy?
If we decide we want to start outputting flags, and other diagnostics, this might argue for outputting a Table object from ``astropy.table``, which can then be expanded in future without users having to capture many arrays from the output of this function. Is there a good reason *not* to output a table instead of two arrays?
These two if blocks look pretty similar, perhaps a function is required? especially if you are likely to add a third variant in the future.
We had to shut down our server due to impending Hurricane :p.

On 2012.08.28 18.24, Tom Prince wrote:
> > @@ -8,6 +8,10 @@
> >  
> >  <p>(<a href="{{ path_to_root }}waterfall?show={{ name }}">view in waterfall</a>)</p>
> >  
> > +{% if description %}
> > +  <pre>{{ description }}</pre>
> > +{% endif %}
> > +
> 
> The link is timing out for me, but it seems that `<pre>` isn't a reasonable default style. I'd think that a description is typically going to be some prose, so a regular font would be best.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/buildbot/buildbot/pull/501/files#r1481609

-- 
Bryce Adelstein-Lelbach aka wash
STE||AR Group, Center for Computation and Science, LSU
--
860-808-7497 - Cell
225-578-6182 - Work (no voicemail)
--
stellar.cct.lsu.edu
boost-spirit.com
llvm.linuxfoundation.org
--
nitpick: missing closing '}'
You are right, this feature is available since 9.0. What's the minimum supported version of Twisted in buildbot?
Yeah, if they're that different, then you should use different Endpoint classes (see also the comment I just made about subclassing Endpoints)
I'll fix it post-merge
m_pScriptHandlerEntry only valid when using LUA-Binding. 
So I think you should put 
<pre>
CCScriptEngineProtocol* pEngine = CCScriptEngineManager::sharedManager()->getScriptEngine();
 	 107	
+       if(pEngine->getScriptType() == kScriptTypeJavascript) 
</pre>
before this line.
ok sounds good, but next time it's best to keep the diff noise to a minimum so the actual changes are obvious
Any reason why we don't replace the assembly-guvnor-jboss-as-7_0.xml entirely?
Anyways, there might be a better solution, but at least now it won't try to process an empty queue.
@pksunkara I'm concerned about the performance of copying all of these Objects and Functions on every request. Before we merge this, can you put together a benchmark which compares flatiron with and without this codepath?
ここなんかおかしくないですか？
；が抜けていますが？？訂正してください。
Makes sense, want me to remove it, or will you guys?
why duplicate?
Probably fine to just delete this commented-out stuff...?
These things should probably be done with the `tempfile` module. I might dump the notebook JSON into a triple-quoted string within this file, write it out to a tempfile when needed. Also, `os.path.join` for platform agnostic delimiters.
if you just use a `LOCK_FILE` class var that is overridden by subclasses, you don't need this property, just access `self.LOCK_FILE`.

Also, the current implementation doesn't match what's claimed in the docstring, overriding `self.lock_file` would have no effect.
As mentioned above use the custom attribute set as data value.
Nit: I think we should turn this around and make the new behavior the default one. It's not obvious that the observer is the new way to go.
I decided to use `Components.Exception` based on [Bug 757663 comment 3][1], to be consistent with AddonManager. For the details see [Bug 759642][2]!



[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=757663#c3
[2]: https://bugzilla.mozilla.org/show_bug.cgi?id=759642
__xabolcs__ wrote:
> How much should "expiry" be by default? A month, or forever?
> ...

Please give feedback before merge!
probably should say `site:projects.puppetlabs.com` ?
`Pathname('c').realpath rescure 'c'` works, though, because it leaves the path unmodified.  So, you won't make absolute paths, but you will get the original content passed through.

I will look at updating it with the regexp, or perhaps just dropping the whole "make it absolute" thing.
Thanks.
I will do it.
Is this guaranteed to terminate? what if rootURL is not a sub path to aURL? I guess that could happen if someone gets crazy with the tm_properties file?
On Tue, Sep 25, 2012 at 3:10 PM, Pankaj Gupta <notifications@github.com>wrote:

> In src/main/java/com/twitter/pers/graph_generator/HDFSEdgeListOutput.java:
>
> > +        System.out.println("Using HDFS output: " + fileNamePrefix);
> > +    }
> > +
> > +    @Override
> > +    public void addEdges(int[] from, int[] to)  {
> > +        try {
> > +            FSDataOutputStream dos = partitionOut.get();
> > +            int n = from.length;
> > +            StringBuffer sb = new StringBuffer(from.length * 32);
> > +            for(int i=0; i<n; i++) {
> > +                sb.append(from[i]);
> > +                sb.append("\t");
> > +                sb.append(to[i]);
> > +                sb.append("\n");
> > +            }
> > +            dos.write(sb.toString().getBytes());
>
> seems like the binary format here would be different than the one above
> (in EdgeListOutput). Is that correct? If so, it would be nice to have the
> same binary format. If it would be the same, then it would be nice to use
> the same code to do the actual writing if possible.
>
> —
>
Actually, this is not a binary format all, but Ascii format targeted for
Hadoop/Pig jobs.

The binary format was committed in mistake, as it is for generating graphs
for GraphChi to use (that is reason for the reverseBytes() as well). It
does not belong to the cassovary project.

There were many mistakes in my pull request, for example I don't
undersstand why the .idea files we commited. I will fix this week.

Aapo


>
style nitpick, maybe just:

```js
function pluralize(n){
  return 1 == n ? 'test' : 'tests';
}
```
In such case IMHO should be excluded all by default and when a new vendor is added then add the exclusion
If we put it in InputInterface, it will be a BC as people implementing InputInterface will have an error as a new method will be missing.
This is not correct as there is no 'c' support. I guess this is a  mistake.
Can you ensure that this doesn't do n queries?
I don't think it's been fully implemented.
```js
if ( !value.trim() ) {
    return;
}
```
the curly brace for the method should be on its own line
oh and we usually try to add a use statement to avoid fully qualified names inside the class code
this idea was letting single word strings through, might stick with the lengthy regex unless you strongly suggest otherwise
@haseebgit you need to import `socialtite_js` from `baseframe` and add to the `js` assets in `__init.py__`.
"".join(prefix, OPTNAME_SEPARATOR, key) is beter here.
Place on top of the module?
But `fsockopen()` will create a new TCP session, so it won't receive any packet that does not belong to response to requests sent through own connection. And since we are using blocking PHP client we are completely sure, that no other request will be sent to this socket before response of previous one will be receiver.

For me it sounds legit ;), please correct me if I'm wrong.
gah, I naturally sent a PR with the buggy branch. semi colon is bad here
You should wrap this to <= 79 chars. You can wrap inside the parens from `list()`, but also, the return from `values_list()` is a list, so the outside `list()` is extraneous.
Oh also, just do `.location`; no need for the `div` part.
This looks good! Just a nitpick, really, but would you have the time to change the t function to ts?

And remove the obsolete function h - so what would be left would be, for example:

<code>&lt;strong><%= ts("Please note") %>&lt;/strong>:
@kellyredding - The strings for arg 1 and arg 2 value need to either mix `"` and `'` or escape the inner apostrophes.
What's the mutual exclusion here for?
I merged this, so I don't think it's a blocker, but I'm not a fan of the `has_unique_id?` method.  I would expect that to be a side-effect-free method that would return a true or a false.  Instead, it either raises an error, or adds to a set.  For clarity, I would rename that method or split it into different parts: one that answers the question, one that adds to the set or raises an error if it's already there.
http://www.insigniasoftware.com/opac not install the new version , this code just test 。
Sorry I just got a YAML error later at line 65. Not related to this commit.
If the `UpdatesHelper` isn't going to be used, this should also be removed.
We may want this to be 'slid', although terms like opened/closed or hidden/visible may be more intuitive.
you should 

    return firewall_list()
The default  value will be zero -> 0
ENABLE_AREA_EVENTS && ENABLE_AREA_EVENTS !== 'false'

those are both the same, I suggest only using && ENABLE_AREA_EVENTS (also for the second one your casting it as a string, so that most likely would never be true because most people set false as a bool and not a string.
No need to indirectly access the constants via a list of strings followed by const get.

You can directly do:

```ruby
[Config::Flay, Config::Mutant, Config::Flog, Config::Roodi, Config::Yardstick].each do |config|
  config.new(Devtools.project).prepare_file
end
```
Why do we store same code in three places? Extract it to separate file.
It's up to the build process to do this kind of tweak for EE version and AFAIK, from a build script perspective, it's the same to replace the path to an image in a stylesheet or in a template.
Should name be part of cachekeys to avoid crash with similar cache blocks?
It's not *that* bad :)
да уж, назвал так назвал 
явно перестарался
sigh. I told Lu about this, all excited that I learned something new

before I even finished she was like, "wait, doesn't 'do' do that?"
It shouldn't be possible for a color at this stage to have an undefined alpha... It is possible for it to have null red/green/blue though.
I might be wrong but I think you could do something like `(cwd + 'config.rb').exists?`. I'd try it out but I'm on an iPad in a car.
i think this should be named make_contribution_button_name
Click is not a native event so this mark isn't required.
We should make the 'root' private by using <code>_root</code>.
but it's self-closing!
Why does it show this (`\ No newline at the end of the file`)?
Should we add Facebook, Twitter and Google to this as well ?
Please add documentation to all of these and comments inline as well.
Making a mental note that _setContentPermissions will need the context object once the securing principal api PR comes trough.
I added `secret1` and `secret2` as placeholders for the actual secrets.
ehr, what about the `rows` comment above?
Yes, I can :)
Changed! It also fits better with the `organizationStrategy` above.
As noted in htsp.c I don't think this function is required.
hahahah what the
please always add parenthesis
Now add additional tests to ensure that the function does what it should given other parameters. You should check it works with the value you expect to pass in when this class is used in the application, and also any corner case parameters such as 0. This is your opportunity to show that your code won't crash even if it is missused, and also to make sure that if someone changes your code so it might crash, this unit test will detect it.
':new' is not needed so should be removed
@slebedev в задании видим только то, что там написано. Если в _задании_ не уточнено другое, то нечего и придумывать новые сущности - бритва Окама в действии, однако.
Нам просто нужно 4 символа, если для этого можно обойтись имеющимися средствами, то зачем так все усложнять. Причем усложнять буквально. Посмотрите сколько действий вам придется сделать, если вдруг понадобится добавить или убрать символ.
Поменял rand() на arc4random(), теперь результаты разные на каждом запуске.
Так не получится изменить все Х процентов. При совпадении вы ничего не измените и будет i++.
Поправил, установив атрибут (readonly) для свойства в новом коммите
Да, мне это видно в XCode.
Я не сильно понимаю, чего собственно вы хотите достичь оставляя такой комментарий? В условиях к заданию вроде бы не было требований относительно warning-ов.
Yes, Actually any transport has two type of `drain`  now, with sequence id and without sequence id.  When the `drain` emits, the listener get one parameter (sequence id) in callback and then we going to search that is there any callback function for this sequence id or not, if yes, we execute it.
looks like it appends the output of the `input_div_wrapping` block that follows
Forgive me if I'm wrong about this elsewhere in LibGit2Sharp, but we should probably use C# conventions here, not C. So `fetchStats` and `checkoutStats`.
ovr -> over
Speaking of which, should we just make it so that you can access SourceEstimates as `stc[:,:]` in addition to `stc.data[:,:]`?
If you wonder about this, I also did. It turned out that interger ('uint32') subtractions creates integers looking like long....
Typing as 'i2' helped to solve this problem.
You have to declare the method before you can override it in a subclass
No, it would fail. Do you think it should search in all locales if none given?
Makes sense to test a degenerate prerelease tag like alpha1 and alpha2, but sets a bad example. Can we make it more clear what the desired tag format is and what we are testing as edge cases?
Remove "from" => "with the content below:"
This may be shorter, but is less readable than the previous implementation, whose intent was easily understood.
Thanks! Can you do it for other entries too?
Ok, I have done this.  Thanks for your help, but please note the indentation does render something different - it creates a grey box on the docs site, just not using an non-proportional font as in code-blocks.
Maybe this is better:

    as described :doc:`here</cookbook/console/console_command>`
I prefer to avoid scrolling in coding example, you could change it in something like:

    <encoder class="Symfony\Component\Security\Core\User\User"
        algorithm="bcrypt"
        cost="15"
    />
The reason for this pull request was non-conformity with [PSR-2](https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-2-coding-style-guide.md#44-method-arguments).
This should be:

    // src/Acme/HelloBundle/DependencyInjection/AcmeHelloExtension.php
This is wrong. This class has 2 mandatory constructor arguments
good catch. I'm not sure i've been totally consistant with that so will do a clean sweep
Why is this trait needed? Seems like namespace pollution at a first glance
that's a ok.
Ну едрить, ну порядок инклюдов, ну.
Dado que `postulation.Comment` es markdown yo incluiría un doble inter lineado en la concatenación.
http://encosia.com/6953-reasons-why-i-still-let-google-host-jquery-for-me/
Nice job converting to data driven!
LOL!!!!!
This formatting should be enhanced
Just note that this wouldn't quite work the way it is written. In the code for `aperture_photometry(...)` we have two arrays before we use the "statistic": the value of each pixel (`subarr`), and the fraction of the pixel in the aperture (`frac`). The default behavior is `np.sum(subarr * frac)`. However, this cannot simply be replaced by `np.median(subarr * frac)`, or even `np.average(subarr * frac)`.

You probably realize this but it is not clear from the API document that the above is not an actual solution. Perhaps put the registry solution above and then say that a user can also define their own function that accepts values and weights, such as `my_median(a, weights)`.
might want to catch socket.error here too to be more robust
The bless will set the status of the instance to ``ERROR`` and log any exception that it retrieved. We can create a new exception and raise it. From the end users' perspective there would be two similar error log entries instead of one.
This method ```TestingUtil.cachestores``` is undefined
Pushed a new commit
Since componentLookup is not a concurrent map, I don't think it's safe to synchronize only on write operations.
Please create a JIRA to track this
Updated this see a79db83
Another trailing backslash. Could you modify this as per my comment above?
Backticks here as well.
Seems like a rather trivial detail.
`.bold` is too specific to the appearance of the element that would use this class.  For places that you are using `class="bold"`, switch to something more descriptive of its purpose instead of the way you want it to look.
A previous conversation with PH had left me with the impression that Instance's startup_tags were truly just the startup_tags, but we wanted the Cook process to operate with the most recent.  I don't believe I saw the Instance's startup_tags referenced anywhere, so this may be a non-issue.
Why are we using an underscore in the variable?
Please move the license headers to be the first thing in the file.
maybe these checks should be done in the beginning of the function call?
Same here, please exclude from merge
Not all content elements are layoutable - you need to check for that.
Tak tomu říkám reakční doba :+1:
Why does this case use a `WT_PUBLISH` to clear the hazard pointer but the normal case doesn't?
length should probably be 40 if this is a sha1.
All strings match the given regular expression. If it can't find an email, it treats the entire string as the name.
what are these magic numbers? Better to use descriptive names like STARTING_POINT, NUM_MIXTAPES_OWNED - again, make constants - understandability will impact the time required to maintain this code.
For puppet-lint , this should be:
  $graph_period = 'second'
No, it is not forced, I'll update this to current version.
I also changed the exception - will change that back.
I'm unclear on the right way to control whether we're doing operations on the dev or prod databases. How is this usually done?
Also, what will happen if we asked for multiple judgments on the task?
Why settings?
And on StackOverflow it is written:

> If you want to do sane multiple inheritance, you need everyone to be calling super

And read comments under the second answer.
I was just making unnecessary complications. All I needed is to convert date to string. It's fixed now. :)
This line should document "int" instead.
New jsperf version includes @rkatic's `makeArray` → `merge` optimization and features improved test code isolation and charting. http://jsperf.com/2012-03-07-jquery-clean-11325/2
Maybe do this with `time.time()` or something, so that they're ordered?
Yes, do you see how the "After" child node count increases from your filtered to unfiltered test suite? That is precisely the leak that I'm talking about.
Ok, do you mind if I put the for on multiple lines, or would you like me to use a while?
artifacts left over from a broken merge.
this is not needed. The current command works too
And this is because basically I'm an ass ;)
use `Forwardable` and `def_delagators` to delegate attributes to the resource
The following is needed before nuking the model to avoid a crash:
gtk_combo_box_set_active_iter(ui->comboBox_album, NULL);
You should extract this from here and roll your own gem with this. I'll require it in my Gemfile and you would benefit from the walkthrough
What about having a single setting for all these options, like httpd = server:port; and assuming that we don't want one if it's unset?
Hang on.. sorry, not quite got it! When you call `get_arbiter`, you're passing in a list of dictionaries, each with config for a single watcher. So even in this context, it's clear that `hooks` refers to the watcher, because it's inside the dictionary:

    get_arbiter([{'hooks': {'before_start': 'foo.bar.baz' ... }}])

If you wanted to add arbiter hooks, that would probably look like

    get_arbiter{[{'hooks': {'before_start': 'foo.bar.baz' ... }}], hooks={'before_start': 'foo.bar.foo'})

Is that what you had in mind? Is the fact that the `hooks` argument is repeated what you're referring to? Doesn't the fact that they're in different contexts solve the issue?

Sorry for the constant questions, but I'd rather get this right! :)
I based my code in a snippet http://djangosnippets.org/snippets/2017/ but I adapted it and wrote tests for it https://github.com/alfredo/popcorn_gallery/blob/master/popcorn_gallery/base/tests/decorators_tests.py#L130-L175
Array()
But we call it on `parent_view` anyway? What's the difference with just calling `parent_view.handle(action_id, event, target);`?
Ah, makes sense now. Fixing.
Unnecessary parenthesis around `event.interval.start`
You could just use `realpos.[xy]` directly when computing `distDiff[XY]`. If you keep it, it should be a `vector2f`.
Actually we can move all these `;;` comments into the namespace comments.
I had the problem that I've got "Invalid step" when I opened the installer without a step. After negating the configured check the installer worked correct. But now (after the installation with a valid config and $rcmail_config['enable_installer'] = true;) I've got the "Invalid step" message again.
So I would recommend that you deny these pull request and I will try to solve these issue.