labofsahil/github-event-dataset-2012 huggingface dataset:
th .gitignore is not that flexible, and is you are goint to clone the repo for first time i don't kwon how to fetch js, css stuff from and other repo and put it in the correct directory. 

So, i think that remove those file make everything more dificult. Or if you think that you got a greate idea... you know what i'm goin to say!! :P
`list()` shouldn't be needed here.
Unnecessary `list()` again.
Oops, need to be deleted
I guess this doesn't perform Unicode Normalization Form NCF. Is there any unicode gem we can use instead?
а может будем возвращать функцию, которая ждет? тогда чуваку проще сделать несколько запросов и ждать. типа

    delete_waiter1 = file1.delete()
    delete_waiter2 = file2.delete()
    delete_waiter1()
    delete_waiter2()

или даже не вызывать если ему плевать
I see... the icon can also be changed with the channel manager... I missed that. 

What about the SetIconPath calls in CPVRChannelGroup::SearchAndSetChannelIcons? Should those icons be updated from the backend or not?
Could mention how to apply shears separately to individual components - or at least, "see demo script X for an example".
Yes, I was thinking mostly of work that would have to be done -- this is not straightforward for other reasons than the error codes raised at the level of wrappers (and I don't actually think making setSigma() etc. would be too hard, but as Jim says, lots of careful testing would be needed to pick up all kinds of nasty bugs).  But the mutability issue is another good one.

I am trying to think of other reasons why we might not want the user to have to specify args -- for example, if there was a mode in which it would save whatever the previous arguments were, and a call without args but with some keyword like use_saved would tell it to make an SBProfile with the same params as before?  (NOT that I propose doing this now.  But I could imagine that being useful at some point in future... thoughts?)

If I want to throw an exception for no radius specification for Sersic, deVauc, Airy, Box, what's the cleanest way to do that?  I could rewrite the code so that we can use checkRadii, parallel to Gaussian etc., but that seems like overkill.  Should I just remove the default from the C++ in src/ and in pysrc/?
why do you need to test if it's a student?  shouldn't professors also get the choice, for no other reason than to test the feature out?
Please remove this. Modifying `global` is a bad idea. Instead, `assetFingerprint` can be exposed to Jade or other view engines via a helper [(see res.locals)](http://expressjs.com/api.html#res.locals).
Fair enough, how about "Returns *false* for primitive types, including `null`."  That way we clarify but don't imply that `null` is not a primitive.
global $
this files does exactly the same as urdf_world.launch just without spawning an empty world.

let's better call it urdf_world_respawn.launch having the following default argument for arg robot_env:
<arg name="robot_env" default="$(optenv ROBOT_ENV !!NO_ROBOT_ENV_SET!!)"/>
you don't need `!= nil`, this will be more readable as `(previousIndexPath || indexPath)`
Again, this looks like a typo....`[0, 2, 3, 4, 4].should start_with [0, 1]` wouldn't pass, right?
I tried to cover all cases here: https://github.com/dkastner/data_miner/blob/6f6504b52516a6e2b2cbd222409bf5e69f85af8d/test/data_miner/test_attribute.rb#L31

And DM imports seem to work fine. I check whether a converter is defined in cases a user does not want to use the conversion gem that may pollute Numeric.
Changed, submitting asap! Git does not see . files (invisible) - thats for me to figure out!
As I said below I do agree with the coreplugin part of the code. A centralized location for board info is a must. Also I agree about moving the board specific ui out of the config plugin. However the way it is done here with one class per board doesn't make sense to me. 
Raw board data should be defined centrally on a ground/flight common location and parsed by the gcs to the proper data format and functions.
Board specific ui should be created with a runtime parseable format and pointed to by the board file. This format should preferably be in qml or normal qt ui xml files using the object to widget framework.
Specific configuration functions should be centralized because they can be unique to a particular board today but can be needed in the future for other hw.
Какого рода thread-safety ты здесь огранизовываешь?
Зачем лишняя обёртка?
Теряешь исключение t
Правильнее это проверять непосредственно в цикле. А не ждать исключения.
Ты на этапе генерации можешь определить параметр с правильным типом.
We can get rid of these now. Lowering line count by 70 lines :astonished:
I meant comment in github :)
Can you add the 'scope' to these variables?  =)

I mean "sAssetBasePath" -> "MusicFactory.sAssetBasePath"
Yeah. I thought we might want to use something like this in the future if we want to interpret the params before we bluntly stuff it in the filterParams. Guess it's better to leave it out now until we need it.
Later, when this is implemented, we probably want this to be a 'button' type to prevent accidental deletes via a GET url
Better name? Also, argmax(axis=1)
On Thu, Nov 15, 2012 at 08:45:40AM -0800, Lars Buitinck wrote:
> We don't usually put LabelEncoders on estimators as public attributes. Instead,
> I'd prefer a property

> @property
> def classes_(self):
>     return self._label_encoder.classes_

You are hiding things from the user. Not a good idea, IMHO. I prefer the
property-less approach.
Oops sorry I missed it.
Now done, and in many other places :)
цю менюшку теж через KnpMenu можна зробити
Glad you're using them, and thanks to you for the contributions!
We cannot hard code 127.0.0.1 or localhost in tests. Why did you delete the server setup task?
I changed it so _get_reviewers just calls util.Abort directly.  No need to introduce our own exception-type in this case, I don't think.
Where does this information come from?  From testing with breakpoints, this all happens in the application thread
instead to passing a char*(utf8) to Qstring back to char*(ascii), why not do `QString decoded = QUrl::fromPercentEncoding(*v8UtfString);` directly?

Also fromPercentEncoding seems to be expecting utf8 so we should not decay the utf8 to ascii before passing to fromPercentEncoding
Use `MenuCompat` for this.
No worries, I'm not in any rush.
Again here - by all means use a regex but use it to check that the string matches a valid pattern [a-zA-Z0-9_]
yep, I'll correct
TBH I was a bit lost on the organization of this file... ;)
The code structure is odd, but it looks to me as though yes, you should make the changes in mangleLocalTempFilename

The mangling for tempfile names is actually done partly in each function. I have no idea why (and we could consider correcting that I suppose, eithe rin this or a separate commit_
well I need to retake this PR before going further. you're right anyway
Please use loop_until_bit_is_clear
Same comment about nth-argument feature of this function.
Could we use 'default' in place of 'user' as this would make it consistent with other projects.
This variable is not used in the function.
You can write this and the sniff below as `/[ ]\t|\t[ ]/`. But again what you have works and is simple enough to read.
Yes as its used in UserCMWebService
space after commas in argument lists
Right, the idea is that a lot of what we do (short of authentication!) actually won't require having a locally stored record for the person & so there's no need to write one.
@yuhunglin shouldn't there be some code here?
So, in the case where Inbox has not been flagged yet, this will show all messages in this account until a folder marked as the inbox is retrieved.  If this is what we want, we should at least add a filter for QMailMessageKey::status(Incoming) so that we don't show any draft/sent/outbox messages.
Are you sure res.body is not nil here? could be a bit more defensive
As we discussed yesterday, I believe that the scaling can be done by pre-processing and should not therefore be part of the segmentation routine. A channel scaling routine could be included in the color module. What do you think? We can ask for a third advice, if needed :-)
As I said in another place, this algorithm is known either as "Felzenszwalbs" (autor) or as "efficient graph based segmentation" (paper title)
I can't remember now why I used router.navigate. Maybe there was a reason or I was testing to make sure it all worked when using the backbone router. The spec passes either way I can switch it back to using the window.location.
Have to test both QueryDict and dictionary like objects due to special casing in paginator.
Ah ok, now i get it. Yes then the line is necessary obviously :-)
@josevalim commit updated
"...weil es viel Spaß macht!"
I was unaware of that. Good to know, thanks.
For consistency let's call these `secure(..)` and `notSecure(..)`.
Did this in the private repo.  The pattern is different in the private repo.
isNaN(fontSize) || (font.fontSize = dom.unitize(fontSize));
Android has this
please keep a TODO: tag so that we can come back later and remove these code .
Mobile Web does nothing.
"'Canvas not found: $elementId can't be found"
I agree, infact we need to .getCanonicalName() on the class too
JSON.parse() is more restrictive than require()? Ok to change?
No, it's not needed. TBH I don't know exactly what JMSSecurityExtra does, but since it comes with both default Sf2 and CMF sandbox, I thought it might do something useful. Let me know if I should remove it.
HEIGHT %)
Might be better to use `Libraries::get(true, 'resources')` instead of `dirname(dirname(dirname(__FILE__))) . '/resources`
`hasLength` yields false for UTF-16 strings
..thanks
..i
..like
..cascades
> At least that's my current line of thinking, I guess it needs more fine-tuning and adjustment. Does that make sense?

it does thanks :-)
Fixed, see 5139f84761c50d8da544cdf01ba1b0e0782498bb
turntable?
Will try to be more clear. Though hold of some more, i need to clarify whether catkin relaying of python packages works even without a setup.py.
You have jQuery at your disposal. Use it ;)
Gaad damnnit
This is problematic.  We will have multiple `svg` elements on the page. Create an `svg` element in `superuser.html.haml` with an `id` attribute, and select that `svg` element specifically here.
this is totally useless. You can align the items in your autoload file if you want, but why should we indent things here when there is nothing else to align with ?
Yes, you are right. Leave it in.

On Fri, Jul 6, 2012 at 12:05 PM, Roger Llopart Pla <
reply@reply.github.com
> wrote:

> > @@ -0,0 +1,15 @@
> > +<?php
> > +
> > +use JMS\SerializerBundle\Metadata\ClassMetadata;
> > +use JMS\SerializerBundle\Metadata\PropertyMetadata;
> > +use JMS\SerializerBundle\Metadata\VirtualPropertyMetadata;
> > +
> > +$className =
> 'JMS\SerializerBundle\Tests\Fixtures\ObjectWithVirtualPropertiesAndExcludeAll';
> > +
> > +$metadata = new ClassMetadata( $className );
> > +
> > +$pMetadata = new VirtualPropertyMetadata($className, 'virtualValue');
> > +$pMetadata->getter = 'getVirtualValue';
>
> This line is required, if it's not set the getter is "virtualValue" and
> not "getVirtualValue".
>
> This is because VirtualPropertyMetadata checks if the first 3 characters
> of the method name are "get" and if so, it changes that, I guess that for a
> prettier serialized output by default.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/schmittjoh/JMSSerializerBundle/pull/145/files#r1111888
>
Agreed. The current mixin is straight from upstream, so we can just keep as-is.

Is there a good way to prevent this from affecting Compass users? Can we provide a workaround for them at least in documentation?
Добавь еще возможность выбора любого файла.
хм, нет
as we discussed, CommandAwareRpcDispatcher shouldn't care about the commadns it serializes, nor the commands should carry the TO flag, so we should:
a) add a TO flag to the CommandAwareRpcDispatcher.invokeRemoteCommands
b) this flag should be read directly from the Configuration object, and not from the command
c) drop the TO flag from the prepare command
Haven't looked at the autotester results, but I'd say this is the reason why linux is failing on them.
new goto url for dismax (need to add type=dismax paramter)
Actually that is correct. Anything other then MessageID copy is optimized correlation. In other words we can optimized *ONLY* if we provide correlationKey in the reply and expect that its going to be copied by the reply producing side. So this message although was copied is still correct.
Its another tricky part where correlation-key attribute basically already implies optimization, but must be the same on both sides. Keep in mind we still generate the value and therefore as you can see form the code we are using the same code. The only difference is that in on condition correlationKey is static ('JMSCorrelationID') and in another its dynamic
Looks a bit funny: singleton Beans which are just Strings :-)
I propose to remove **object-names-ref** and rely only on **object-name**:
1. We can use it as before.
2. like this `object-name="#{patterns}"` where **patterns** is a List Bean, or something from @Bean 
3. Via SpEL Inline lists
There is similar solution for `<context:property-placeholder>`.
But then we should follow with my proposition for `void setObjectNames(ObjectName... objectNames)`
as per above discussion, this can just be string instead
Probably. If they all end in `.conf`, which they do now, but I obviously haven't mandated.
True, but I don't think a period is necessary in this case.
We need to make sure this works.  It sounds like the override functionality is borked.
Or `placeholder.children('canvas').is()`.
Data in database is just to the second of precision. There is no need for float?
Pedantic: flicks imports should be in the last group.
You said you used the paths sketch for global variables but this shorewall array seems to be defined in main. can you also show examples of the definition of them?
Should we also set `'stale-if-error' => 86400, 'stale-while-revalidate' => 86400` ?
It does not actually allocate anything. Allocation is muuuuuuch more complex.

Shay: ಠ_ಠ x 100000
Wouldn't it be better to not change the signature of the getBase64 method and use setOption() for setting a custom code?
I would just use the fos_comment_before_load_thread event, and also, you should be passing params in as an array element:

FOS_COMMENT.thread_container.trigger('fos_comment_before_load_thread', [params]);
It would probably be nice to have a `find_or_create_file` method in `rails_setup` to take care of this. I'll throw that on the issue tracker :smile:
The XML serialization is very basic and manual, this us hard to maintain. The .NET has ability to serialize class into XML directly and in PHP what we do is to convert the class into array and then pass this to function called `serializetoXml` which will generate the request body. Constructing the XML manually is error prone and hard to maintain as well. I'd suggest finding more automated way in Python to do it.
with a type safe DSL. (easily doesn't fit)
I am not 100% sure that this step is necessary.
But I suspect that without it, mServos[i]->getPosition() will return nan.
These are good negative tests. Let's also add a test that confirms that all of the correct stuff is getting into ObjSearch. For example, if searchData is 

- WTF is this? The word contains a+b but neither 'a' nor 'b' will be entered. If I quote a word like "this-one" then maybe it should get entered as such (but   currently doesn't). We have no escapes. What about 12/25/2012 as a date? or 12-25-2012?
Haven't had to do this in any other extensions so far, maybe the spec_helper is missing something
Rename variable "data" to "serverResult".
*call each function in events  
*do chooseFormatAndImport under model : Import (instead of guessFormat...) in View 
*replace "guess" with "choose" in Import.js 

Am I correct? Do I need to change code inside the guess function in Import.js ?
Considering return value validation, another interceptor could theoretically alter the returned value, possibly violating the contract promised to the method caller. I thus was thinking whether one couldn't have two separate interceptors:

* one for parameter validation which is added late the stack (after all interceptors possibly changing parameter values) and ignores the return value and 
* another one for return value validation which is added early of the stack (before all interceptors possibly changing return values) and ignores the parameter values.

That way each part of the contract is validated as close to the respective client (method implementation vs. caller) as possible, on the downside a `ConstraintViolationException` raised during return value validation wouldn't cause a transaction rollback.

I'm just thinking loud here, let me know whether that makes sense or not :)
> I would split the sentence:
>
> @ConvertGroup and @ConvertGroup.List can be placed on fields, getters and method return types. In the latter case 
> the method must either implement and interface or override a super class method.

Your sentence is different that the previous one. The previous one said that you could place convert groups on overriding methods. Your version says that you must.
I'd move the log after the actual kill (just like what you did on startService)
Not at all in the core, and the notes use-case being a rather specific one I don't think in a plugin either. Anyway, I raked my brain but couldn't come up with a sensible default, as the method is on the journaled object and the journal of interest could by any journal anywhere…
Yes, that's does work. Ok, I'm cool with that.
We'll need to discuss the SmartStore aspect with @eoksman a bit more; we talked about that the other day, and were considering scenarios where you may log out to temporarily log in as someone else, and wouldn't want data to be blown away.  The discussion of data namespacing came up again, and there's a story to consider it.

But let's do the cookies for now, and discuss our SmartStore data plan with Eugene when he's back in the office.
The reference to `blocks` is (a) incorrect and (b) shows that this is cut'n'paste from one of the existing duplicates of this method... Can we merge all together please instead of creating yet more copies of it...
what does this do? logic?
a policy within a policy seems a bit much for some simple code.
that sounds like a nice improvement, but i don't know of anyone that uses a different git editor than their system editor.

going to punt on that change for now due to complexity to assert/test the change.
not too keen about that. Especially since I don't know if it really works. :( All this and examples was to be left as an exercise for later.
Should be `canceled` instead of `cancelled`. We need to standardize not just the docs, but also the API point names on American English (this is the British English spelling) due to documentation standards. I'm unsure if this should be processed as part of this PR or not; depends on the level of flexibility of revising the initial module API.

__CONFIRMED THAT INTERNAL MODULES DO NOT USE THIS API__ and therefore it is safe to rename.
Some work must come  before the initialization of webview, but I could add a new class method to do that work and keep the logic inside the plugin.
add the how here; intresting might be direct-java-code-on-openengsb-level
remove java code
remove c# code
Yes, write this to code itself, so that anyone in any time can understand the code, please.
I don't know how that got altered.  I can try making the change again tomorrow and see what happens.

----- Original Message -----
From: Nukul Bhasin [mailto:reply@reply.github.com]
Sent: Wednesday, July 18, 2012 08:44 PM
To: Matthew D'Andrea
Subject: Re: [BB10-WebWorks-Framework] Added a new error constant for blackberry.push (#89)

> @@ -1 +1 @@
> -Subproject commit 4f942c5869a6c9fb580aa252b1ef04fe6da2ad48
> +Subproject commit 30a9271dff0de5c645cae83b14f5da710b9ad58c

why have you updated the webplatform??
looks like a mistake to me

---
Reply to this email directly or view it on GitHub:
https://github.com/blackberry-webworks/BB10-WebWorks-Framework/pull/89/files#r1193232

---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.
I notice there isn't any logging in this class. I am not sure if the WebWorks team typically logs anything but there are certain "internal error conditions" that might be hard to debug why this is coming back without any logging.
Use consistent formatting, include an opening and closing brace for the else block
This is a really old hash.
I think we have to rely on that.

@kwallis What makes sense to you? This becomes additionally complicated if we consider whether we want the event to fire when battery decreases below critical point and NOT when it increases back above.
Nevermind, different function.
Can we change this from window.hideMenu to 'require(contextmenu).hideContextMenu()'?  Having those functions in ui.html is tech debt we want to get rid of.
I'm fine with this, but IMO it increases the complexity of the file structure unnecessarily. This is a server side example, so having all the client side stuff in one file was somewhat intentional.