Use localized date-time format in datetime input
https://bugs.webkit.org/show_bug.cgi?id=102769

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-11-20
Reviewed by Kent Tamura.

Source/WebCore:

Move the implementation of Locale::dateTimeFormatWithSeconds and Locale::dateTimeFormatWithoutSeconds
to its subclasses and use platform-specific methods to get date-time pattern.
Because Windows does not provide an API to get date-time pattern. We use fixed "{date} {time}"
pattern for Windows.

Test: fast/forms/datetime/datetime-appearance-l10n.html

* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::initializeDateTimeFormat): Retrieve datetime formats too.
(WebCore::LocaleICU::dateTimeFormatWithSeconds): Added.
(WebCore):
(WebCore::LocaleICU::dateTimeFormatWithoutSeconds): Added.
* platform/text/LocaleICU.h:
(LocaleICU): Add m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.
* platform/text/LocaleNone.cpp:
(LocaleNone):
(WebCore::LocaleNone::dateTimeFormatWithSeconds): Added. Always returns "dd/MM/yyyyy HH:mm:ss".
(WebCore):
(WebCore::LocaleNone::dateTimeFormatWithoutSeconds): Added. Always returns "dd/MM/yyyyy HH:mm".
* platform/text/PlatformLocale.cpp:
(WebCore): Remove dateTimeFormatWithSeconds() and dateTimeFormatWithoutSeconds() as these are now pure virtual.
* platform/text/PlatformLocale.h:
(Locale): Make dateTimeFormatWithSeconds() and dateTimeFormatWithoutSeconds() pure virtual.
* platform/text/mac/LocaleMac.h:
(LocaleMac): Add m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.
* platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::dateTimeFormatterWithSeconds): Added.
(WebCore):
(WebCore::LocaleMac::dateTimeFormatterWithoutSeconds): Added.
(WebCore::LocaleMac::dateTimeFormatWithSeconds): Added.
(WebCore::LocaleMac::dateTimeFormatWithoutSeconds): Added.
* platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::dateTimeFormatWithSeconds): Copied from original Locale::dateTimeFormatWithSeconds().
(WebCore):
(WebCore::LocaleWin::dateTimeFormatWithoutSeconds): Copied from original Locale::dateTimeFormatWithoutSeconds().
* platform/text/win/LocaleWin.h:
(LocaleWin): Add m_dateTimeFormatWithSeconds and m_dateTimeFormatWithoutSeconds.

LayoutTests:

* fast/forms/datetime/datetime-appearance-l10n-expected.txt: Added.
* fast/forms/datetime/datetime-appearance-l10n.html: Added. We can confirm vi-vn have time-date ordering.
* platform/chromium-mac/fast/forms/datetime/datetime-appearance-l10n-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
webkitpy unit tests should run serially when checking code coverage
https://bugs.webkit.org/show_bug.cgi?id=102693

Reviewed by Dirk Pranke.

When checking code coverage, the unit tests should not be run in parallel
as this causes the tracing functions (set via sys.settrace in the coverage
module) being overriden, resulting in incorrect coverage reports.

* Scripts/webkitpy/test/main.py:
(Tester._run_tests):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Mark inspector/profiler/cpu-profiler-profiling-without-inspector.html
as crashing.

* platform/chromium/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[V8] Remove V8ParameterBase
https://bugs.webkit.org/show_bug.cgi?id=102774

Reviewed by Adam Barth.

V8ParameterBase is a redundant indirection.
We can flatten methods of V8ParameterBase to V8Parameter.

No tests. No change in behavior.

* bindings/v8/V8StringResource.h:
(WebCore::V8Parameter::V8Parameter):
(V8Parameter):
(WebCore::V8Parameter::toString):
(WebCore::::prepare):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[EFL][GTK]Sharing accessibility support in WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=99011

Patch by Mateusz Leszko <m.leszko@samsung.com> on 2012-11-20
Reviewed by Martin Robinson.

Accessibility files from gtk folder are moved to atk folder due to common implementation. Event Type naming changed to default, from Gtk to ATK.

* WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp.
(WTR::AccessibilityController::logAccessibilityEvents):
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Apply DeviceController as parent class of DeviceMotionController.
https://bugs.webkit.org/show_bug.cgi?id=102578

Reviewed by Hajime Morita.

DeviceController needs to be applied as parent class of DeviceMotionController
because DeviceController which is extracted as parent class of
DeviceMotionController and DeviceOrientationController is already added.
Therefore duplicated implementation can be removed.

Covered by existing tests.

* dom/DeviceMotionClient.h:
* dom/DeviceMotionController.cpp:
(WebCore::DeviceMotionController::DeviceMotionController):
(WebCore::DeviceMotionController::didChangeDeviceMotion):
(WebCore::DeviceMotionController::deviceMotionClient):
(WebCore::DeviceMotionController::hasLastData):
(WebCore::DeviceMotionController::getLastEvent):
(WebCore::DeviceMotionController::from):
(WebCore):
* dom/DeviceMotionController.h:
(WebCore):
(WebCore::DeviceMotionController::~DeviceMotionController):
(DeviceMotionController):
* dom/Document.cpp:
Remove all implementations which are related DeviceOrientationEvnet and DeviceMotionEvent.
Because DeviceController checks suspend and stop status of active dom object before dispatchEvent.
(WebCore::Document::suspendActiveDOMObjects):
(WebCore::Document::resumeActiveDOMObjects):
* loader/EmptyClients.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Simplify Element::isSpellCheckingEnabled
https://bugs.webkit.org/show_bug.cgi?id=102779

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Andreas Kling.

isSpellCheckingEnabled contains logic that duplicates parentOrHostElement
and can be simplified by just calling that.

No new tests, just simplification.

* dom/Element.cpp:
(WebCore::Element::isSpellCheckingEnabled):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove unneeded optimization in Element::isInTopLayer
https://bugs.webkit.org/show_bug.cgi?id=102772

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-20
Reviewed by Andreas Kling.

There's no reason to worry about calling elementRareData() multiple
times in this non performance sensitive code path as it's only used
in HTMLDialogElement's showModal and close methods.

No new tests, just simplification.

* dom/Element.cpp:
(WebCore::Element::setIsInTopLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Collect user style sheets in DocumentStyleSheetCollection
https://bugs.webkit.org/show_bug.cgi?id=102683

Reviewed by Andreas Kling.

Move the user stylesheet collection logic from StyleResolver to DocumentStyleSheetCollection.
        
* css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectRulesFromUserStyleSheets):
(WebCore::collectCSSOMWrappers):
* css/StyleResolver.h:
(StyleResolver):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::pageUserStyleSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserStyleSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserStyleSheet):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::collectActiveStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateStyleResolver):
        
    Factor the StyleResolver updating code to function.

(WebCore):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
        
    Collect the user style sheets. Some renaming and other minor refactoring.

(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):
* dom/DocumentStyleSheetCollection.h:
(WebCore::DocumentStyleSheetCollection::activeUserStyleSheets):
        
    Add activeUserStyleSheets vector that contains all user stylesheets from different sources,
    similar to activeAuthorStyleSheets.

(DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::documentUserStyleSheets):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Zoom logic confused by page and pinch resize
https://bugs.webkit.org/show_bug.cgi?id=102803

Reviewed by Kenneth Rohde Christiansen.

Clear the zoom-out stack after page resize, and ensure the zoom logic can still detect
zoom-out and zoom-back when the zoom-out stack is empty.

* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::clearRelativeZoomState):
(WebKit::PageViewportControllerClientQt::setContentsScale):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::didChangeViewportAttributes):
* UIProcess/qt/PageViewportControllerClientQt.h:
(PageViewportControllerClientQt):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[GTK] no volume slider in HTML5 media element controls
https://bugs.webkit.org/show_bug.cgi?id=97192

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2012-11-20
Reviewed by Philippe Normand.

r115829 was causing this regression so it was partially
reverted. The revert causes some small regressions, in the tests
but it is better to have the volume slider shown.

Source/WebCore:

* css/mediaControlsGtk.css:
(audio::-webkit-media-controls-panel)
(video::-webkit-media-controls-panel): Partially reverted
r115829.

LayoutTests:

* platform/gtk-wk2/TestExpectations: Updated because it causes
some new regressions
* platform/gtk/TestExpectations: Updated because it causes some
new regressions
* platform/gtk/media/audio-controls-rendering-expected.txt: Updated
* platform/gtk/media/controls-after-reload-expected.txt: Updated
* platform/gtk/media/controls-strict-expected.txt: Updated
* platform/gtk/media/controls-styling-expected.txt: Updated
* platform/gtk/media/controls-styling-strict-expected.txt: Updated
* platform/gtk/media/controls-without-preload-expected.txt: Updated
* platform/gtk/media/media-controls-clone-expected.txt: Updated
* platform/gtk/media/video-controls-rendering-expected.txt: Updated
* platform/gtk/media/video-display-toggle-expected.txt: Updated
* platform/gtk/media/video-empty-source-expected.txt: Updated
* platform/gtk/media/video-no-audio-expected.txt: Updated
* platform/gtk/media/video-volume-slider-expected.txt: Updated
* platform/gtk/media/video-zoom-controls-expected.txt: Updated

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Week picker width is too small
https://bugs.webkit.org/show_bug.cgi?id=102766

Reviewed by Kent Tamura.

Source/WebCore:

The width of week picker was too small because we were forgetting about
the week number column when calculating the desired width.

No new tests. Covered by week-picker-appearance*.html.

* Resources/pagepopups/calendarPicker.css:
(.week-mode .week-column): Needs to be table-cell.
* Resources/pagepopups/calendarPicker.js:
(CalendarPicker.prototype.fixWindowSize):

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
* platform/chromium/TestExpectations:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] REGRESSION(r128174): Fast build path doesn't work now
https://bugs.webkit.org/show_bug.cgi?id=100360

Reviewed by Tor Arne Vestbø.

Use a separated .builtRevisions.cache file instead of .qmake.cache to cache built SVN revisions.

* Scripts/webkitdirs.pm:
(buildQMakeProjects):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Chromium] Expectations update

Unreviewed test expectations update.

Some results for calendar and month picker may not be up-to-date for the slow bots.

* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
* platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
* platform/chromium-win-xp/fast/block/float/overhanging-tall-block-expected.png: Removed.
* platform/chromium-win/fast/block/float/overhanging-tall-block-expected.png:
* platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Remove historical enums from ExceptionCode.h
https://bugs.webkit.org/show_bug.cgi?id=102095

Reviewed by Ojan Vafai.

Remove unused enums from ExceptionCode.

No new tests. No tests affected.

* Modules/intents/NavigatorIntents.cpp:
(WebCore::NavigatorIntents::webkitStartActivity): The error type for this is unspecified.
* dom/DOMCoreException.cpp:
* dom/ExceptionCode.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed gardening.
Update results for compositing/geometry/vertical-scroll-composited.html after 133898.
Mark animations/negative-delay.html as flaky.
Remove a few passing tests from TextExpectations.

* platform/efl/TestExpectations:
* platform/efl/compositing/geometry/vertical-scroll-composited-expected.png: Added.
* platform/efl/compositing/geometry/vertical-scroll-composited-expected.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Update NEWS and configure.ac for 1.11.2 release

.:

* configure.ac: Bump version numbers.

Source/WebKit/gtk:

* NEWS: Added release notes for 1.11.2.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] Large areas highlighted on touch
https://bugs.webkit.org/show_bug.cgi?id=97216

Reviewed by Simon Hausmann.

Restrict highlighting of scripted event-handlers to inline elements only.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Unreviewed. Update NEWS and configure.ac for 1.11.2 release

* configure.ac: Bump tarball version number, not updated in
previous commit by mistake.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
[Qt] No test of double-click to zoom out
https://bugs.webkit.org/show_bug.cgi?id=102810

Reviewed by Kenneth Rohde Christiansen.

Adds tests of zoom-stack behaviour, the ability to restore previous zoom levels. It tests
that zoom out always goes to lower zoom levels.

* UIProcess/API/qt/tests/qmltests/WebView/tst_doubleTapToZoom.qml:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@135282 268f45cc-cd09-0410-ab3c-d52691b4dbfc