Don't re-use hf_gluster_dict in different sub-protocols

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Correct formatting of some spaces

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Use gluster_dissect_common_reply()

hf_gluster_op_ret and hf_gluster_op_errno will not be referenced
anymore.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Correct some usage of spaces

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Don't register Gluster CLI under the main Gluster protocol

Gluster CLI is a seperate protocol and can be registered as such. This
prevents referencing to proto_gluster.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
The gd_mgmt_brick_2_proc table contains value-string-function-function entries

The table was incorrectly marked  as 'value_string', it should be
'vsff'.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Introduce local proto_glusterd as replacement for global proto_gluster

Reduce referencing to the global variable proto_gluster.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Use gluster_dissect_common_reply()

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Seperate GlusterFS Callback from GlusterFS Handshake

GlusterFS Callback contains some legacy calls. None of these
calls/replies carry any data in GlusterFS-3.2.x and newer. There is no
need to provide dissectors. For clarity, Callback and Handshake are now
completely seperated and have their own register functions.

This change also makes use of gluster_dissect_common_reply() so that
there are no references to the global op_ret and op_errno header-fields.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Use local proto_gluster_dump instead of the global proto_gluster

Reduce referencing to the global variable proto_gluster.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Use local proto_gluster_pmap instead of the global proto_gluster

Reduce referencing to the global variable proto_gluster.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Name all local functions and variables 'glusterfs' instead of 'gluster'

All local functions are now prefixed with glusterfs_ and functions
available in packet-gluster.h have gluster_ as prefix.

Also move gluster_rpc_dissect_dict() from packet-gluster.c to the
GlusterFS dissector as it is the main user of the function.

Drop the unused "GlusterFS Mops" tables and protocol pointers. GlusterFS
3.2.x and newer do not seem to use this anymore.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Remove global variabled from packet-gluster.h

There is also no need for packet-gluster.c anyore. All global functions
have been copied to other dissectors.

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Correct some usage of spaces

Signed-off-by: Niels de Vos <ndevos@redhat.com>
Major cleanup: don't use global variables anymore

A lot of protcols now have their own namespace:
- gluster.pmap
- glusterfs
- gluster.cli
- gluster.hndsk
- gluster.dump

None of the protocols refer to 'proto_gluster' anymore. The single
protocol called 'gluster' has been removed to reduce dependencies
between the sub-protocols.

All dissectors now use gluster_dissect_common_reply() where possible.

As a side effect, packet-gluster.c does not contains any useful (for
GlusterFS 3.2.x and newer) protocol information anymore. This file has
therefore been deleted.

Signed-off-by: Niels de Vos <ndevos@redhat.com>