labofsahil/github-event-dataset-2012 huggingface dataset:
The good news is that the regression uncovered a bogus test in AP, fixed everything in fd5d9b366c7ad192bbcf5b3c0a774ff684cb9d78.
Thanks, but use proper style :) (no extra spaces around (), dtype = nm.object -> dtype=nm.object in keyword arguments etc.
if CanUseItem() is never called with proto as NULL and can't be called with NULL as parameter, then there should be an assert instead of a NULL check. Looking at the code, the proto parameter is dereferenced before passing it to this method.
A fix like this does not strictly require a rebuild, so I prefer not to promote the release for this.

Luckily you really didn't do that :-) Thanks !
Looks good.  As far as I can tell, a bit of cleanup can be done.  eg there's no problem with not going through the app messenger if you're firing off a job (atm ApplicationMessenger::OpticalMount just fires off a threadmessage, where we wait for app thread, then fire off a job from the app thread).  Can probably move job creation direct to OpticalMount, or track down the (few?) places we're using OpticalMount() and just fire the job off directly from there?  Looks like it's done at app start on win32 (there's some notes that it can be removed later by the looks) plus I'm guessing somewhere in the win32 event handlers?  Not called at all on osx by the looks.
I !personally! don't like that there is an 'Archive' button in the TopicList on the left. Either think about adding checkboxes and some (maybe appearing) Archive Button somewhere else or like the current dev-version has in the in TopicView itself ?
I'd appreciate it if you use izip(…) rather than zip(…) =)
Duh. Sorry, I was only my mobile when I replied... and it's early... What if we move `gum` into it's own project, that way we can just have qunit tests that can run in a real browser or a PhantomJS browser? (This is why `grunt` is awesome... it comes with a scaffold for this!) So I'll just land this test and then move it all over to the new project repo. What do you think?
indeed, its only purpose was to block toAirWeapon weapons from attacking the ground (because toAirWeapon changed the weapondef copy, which was checked instead of the weapon copy)
The return type is missing here (also `UPtr`).
Init was running twice... fixed bug
A few comments inline on what you did with this.
I think you address all the comments.

For an example of how to use a single empty list, see 5f54c8d320b3a5c534666ef067f94517c39faf6f.
I dont want to add another overloaded version - I want to add one that takes an HSlicePredicate from which it can pull the 'count'
Nothing major as far as I can see. To be honest, the release management is not very sophisticated, I just bump the version if enough changes accumulated. I'll try to improve that.

https://github.com/podio/podio-rb/compare/e2425a49346ae6c1e34770fb07d1b8192ee478cc...a9de851c11f0205ef57b62b754eb7fcba14b77af
I believe this will always be true, as function arguments are always passed as an array. I haven't checked this, but it seems like unconditionally calling `vals = vals.flatten` should be correct. Given that this condition is always true, that's effectively what the code is already doing.
I dig the copyright/license shout out. Let me know which browsers/environments you support and I can help you trim down `deepClone` to fit your needs.
Trivial... I don't think the isShutdown() call is necessary -- the call to execute() will execute the call synchronously if it is -- and it doesn't looks like hostThreadPool can ever be null (declared final and initialized on construction).
Split out ` Seq(test, testOnly, testQuick)` as a `defaultTestTasks` method.
any reason this bit wasn't done inside AddPath as per AddFile ?
Oh mais ça a marché !
keine ahnung :). Kannst mal morris Fragen
That should be HaveKeys(keys, keystore) == keys.size(), I think.
ҪġΪʱҪʲôǾͲˡ

On Wed, Feb 1, 2012 at 11:55 AM, Juven Xu <
reply@reply.github.com
> wrote:

> Git Github... ȫ滻
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/larrycai/sdcamp/commit/838f7562df9893e41dc88185f0f7df8a4135c2c3#commitcomment-921284
>



-- 
True software development embraces consistent inconsistency.
blog: http://codeslife.com
http://img528.imageshack.us/img528/4396/screenshottl.png

Realm ***** Online for 14 hours, 35 minutes, 5 seconds
Max players this uptime session: 1435
CONFIG_BOOL_MMAP_ENABLED,? I thought this is only in mmap branch
since you're calling extend in a loop here it would double up the platform options if an addon supported *both* mobile and android. I don't know if an addon would realistically support both or not.
Ok, this sounds good. Thanks for the explanation,  Would you mind checking [this commit](https://github.com/petsagouris/pyrocms/commit/ffddf188936596bd9c87565898d3f5804d92f655) out, should I make a pull req about it?
E.g. nipy does not install examples and doc at all. I propose we do not install doc, and install all other data into <site-packages path>/sfepy/ along with the sources. Could you try, please, (when you have time) https://github.com/rc/sfepy, where I tried to do it that way?
Yup, it was split for old jQuery support, but 1.9 will only support 1.6+, so we're good.

Nice catch on the missing `;`.
this is comment!
Thank you! will look into the changes you make.
I think the javadoc should be improved to point out what the method is really doing. The doc is already good, you should only add a 1st sentence which is saying what the method is basically doing (checking if the other dependency is included in this' dependencies version range).
Also, I'm not 100% sure if I like the method name - 'contains' could also mean a lot of other things (e.g. others might think of transitive deps in that case), but I cannot image a better name, yet.
actually this commit adds the usage function.
where do you use `$errBox`?
We should also shorten long names.
UsernameVeryLongSuperAwesomeBlaBlaBundle shoule became "...AwesomeBlaBlaBundle"
You should find appropriate length to fit badge size.
can we merge these three rules into one `background` rule?
I believe that's not voodoo, that's > 250.
what about a dynamic rtl/ltr less variable to make all this changes automatically "switchable"..
Yes, I agree that would be better. Commit pending.
@JakobKallin Hallo
I think you are not following the naming conventions :), also you need to document the API using the Doxygen tags. Have a look on my last 2 commit in my branch.
It's what's currently there.
can we make these required args? optional args are great for functions that get called often but I only see one existing non-test call for this
This line should be like this:

```
data <- coord_transform(coordinates, data, scales)
```
@saltybeagle: Can you confirm/infirm the above statement? (or @helgi?)
You should move your player 10 pixels each game iteration yes... but you should move it By looping 10 times, moving the player 1 pixel at the time + testing for colliosions. Pseudo code:

update() {

  .. do game logic ...

  loop 10 {
    player.x += 1
    check_collisions()
  }
}
Fixed in a previous commit.
If you're so concerned about the bytes ;) wouldn't Collections.emptyList() not be even more reduce the footprint?
I also took much time to think about this, I know that the meaning of  "dash" is not totally equal to "minus" in English, but they are using the same character and having the same ASCII code.  And that symbol has multiple pronunciations. [1]

I finally change "破折號" to "減號" is because that "破折號" is "em dash", which uses two spaces [2], and "連接號", the formal Chinese translation of "dash" [3] is not very common used than "減號".

Do you think "連接號" is better here?

[1] http://www.codinghorror.com/blog/2008/06/ascii-pronunciation-rules-for-programmers.html
[2] http://zh.wikipedia.org/zh-tw/%E7%A0%B4%E6%8A%98%E8%99%9F
[3] http://zh.wikipedia.org/zh-tw/%E9%80%A3%E6%8E%A5%E8%99%9F
Interesting. I changed this some time ago to not close the connection to keep it alive (persistent connection). The same is true for the second change you suggest. Now curl_init is called every time even though the same client is used for several queries. With this enhancement, I had quite a performance boost.

So what I want is to use a persistent connection, but not having a memory leak :-) I hope you can help here.
Is this screenshot helpful? I don't see anything related to dynamic abbreviation here.
Wouldn't it be better to use 'C-h f dabbrev-expand' instead of 'C-h m'?
The removeFromSuperview was what was causing the toolbar to abruptly dissapear.  I don't know what that was in there in the first place.  Probably from where I got the code.  I think this should be ok now.
Awesome patch! This is epic for people who play the server.

On a off-topic note, you added an index to your database Maescool? You mean you added a primary key as an autonumber or? HawkEye has been causing large lag MySQL wise and I've not found a way to fix it yet. The table is too big to fit in the cache.
So in order to do a checked block destroy, the plugin developer would have to remove the block from the world, execute a block break event, check the canceled status afterward, and re-add the block if necessary?
We just came up with a solution to this bit, you should be able to do `from flexget.utils import json` now instead. http://flexget.com/browser/trunk/flexget/utils/json.py
Ok. I understand. Allowing @extend to apply to mixins was considered but ultimately rejected because mixins don't participate in the cascade. I don't see a need to create a new concept here -- I want to build on the existing concept of the class for this feature. I really do consider these abstract base classes in the object oriented sense. This feature doesnt just apply to a single class definition -- it applies to all rulesets that use the class. E.g the selector `#context .base a` is also silenced if you silence `.base`. This is why I was them to live in and be part I the document selector domain.
gj
any way to find all the miscvalueB that can control a creature?
Hey Susana, I can't get any of the commits since my last one to run on my Android device; specifically, when I try to run ScheduleListActivity, it crashes on me. This seems to come up most of the time in my adb log when it crashes, not sure if it's relevant:

```

 110         ActivityManager  W  Trying to launch com.ksj.bamft/.activity.ScheduleListActivity
 17568         AndroidRuntime  D  Shutting down VM
 17568               dalvikvm  W  threadid=1: thread exiting with uncaught exception (group=0x40015578)
 17568         AndroidRuntime  E  FATAL EXCEPTION: main
 17568         AndroidRuntime  E  java.lang.RuntimeException: Unable to start activity ComponentInfo{com.ksj.bamft/com.ksj.bamft.act
                                  ivity.ScheduleListActivity}: java.lang.NullPointerException
 17568         AndroidRuntime  E  	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1651)
 17568         AndroidRuntime  E  	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:1667)
 17568         AndroidRuntime  E  	at android.app.ActivityThread.access$1500(ActivityThread.java:117)
 17568         AndroidRuntime  E  	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:935)
 17568         AndroidRuntime  E  	at android.os.Handler.dispatchMessage(Handler.java:99)
 17568         AndroidRuntime  E  	at android.os.Looper.loop(Looper.java:130)
 17568         AndroidRuntime  E  	at android.app.ActivityThread.main(ActivityThread.java:3688)
 17568         AndroidRuntime  E  	at java.lang.reflect.Method.invokeNative(Native Method)
 17568         AndroidRuntime  E  	at java.lang.reflect.Method.invoke(Method.java:507)
 17568         AndroidRuntime  E  	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:842)
 17568         AndroidRuntime  E  	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:600)
 17568         AndroidRuntime  E  	at dalvik.system.NativeStart.main(Native Method)
 17568         AndroidRuntime  E  Caused by: java.lang.NullPointerException
 17568         AndroidRuntime  E  	at com.ksj.bamft.activity.ScheduleListActivity.onCreate(ScheduleListActivity.java:78)
 17568         AndroidRuntime  E  	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1047)
 17568         AndroidRuntime  E  	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:1615)
 17568         AndroidRuntime  E  	... 11 more
  110                          E  Dumpstate > /data/log/dumpstate_app_error
  110         ActivityManager  W    Force finishing activity com.ksj.bamft/.activity.ScheduleListActivity
  110         ActivityManager  W    Force finishing activity com.ksj.bamft/.activity.BamftActivity
 17577              dumpstate  I  begin
```

I'm not sure if this is related, but I installed the Maps app from the marketplace, and the google map image is still not showing up on the Profile view. It could be related? I'm not sure.
This is pretty inefficient, as we're still querying the database for EVERY record, then filtering and only creating student objects from the ones we want. It's a step in the right direction though.
hmm good question, the cool thing about this solution is that all you need to do to add a new renderer is add the file to the build (and test, and bookmarklet) and you are done, users choose the renderer with an option and that's it

so i think it's a good way to add new renderers
@gggeek, if you think the issue should be reopened, please do so.
You're right, carry on. :koala:
>Wait we had Easter eggs?

Halloween?
My request:

Adding 'visible' and 'invisible' as data grid actions,
so this could be used as a shortcut to make items fast visible/invisible in a datagrid using ajax.
Do you have git setup via command line?




On 15 Jan 2012, at 22:58, David Mark
<reply@reply.github.com>
wrote:

> When trying to merge, keep ending up on this page, but only has a "comment" button. :(
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/gibletto/My-Library/commit/f11ea1fe7f729a649cac003c482cae4e4f16f950#commitcomment-869380
Thank you.
... i don't know what you mean with the storage part, but i only want to use it for simple authentication for me and some friends, eg. @ 
http://stackexchange.com/users/login?returnurl=%2f or http://www.livejournal.com/identity/login.bml or Drupal
Is there the storage part required?

Now i've tested the old version and i wasn't able to run it ... arrr... i've to try it again...
Greets
mm
you better 'b'elieve this helps.
Correct the program you wrote in the previous exercise to copy from u into v. There are at least two possible ways to correct the program. Implement both, and describe the relative advantages and disadvantages of each approach.
That's kewl.  Good to know development is coming along nicely.  Can't wait to try out the new module.  Keep up the great work!!!
I'll commit the patch and do the minor refactoring.
That's not going to help with the rest of code, now that I took a look at it. It's using some new System.Threading functionality (`ManualResetEventSlim`). Is there any reason we can't use the old method in FX35 and use this new same-thread method in FX40?
I think geo_field here and below should be this.geo_field ?
2012/1/17 Amit Kulkarni
<reply@reply.github.com>:
> i found out that the 'mv' moved the file from the fake-amd64 folder and didn't install files in /etc
>
> so I added the cp -R

It should not install files in /etc, it's the @sample's job. See pkg_create(1).
@xpaulbettsx @tclem This is weird as I was pretty sure the Untracked case was [covered](https://github.com/libgit2/libgit2sharp/blob/1cb40daeab62551b44a964e2dce60bad098a0477/LibGit2Sharp.Tests/StatusFixture.cs#L140-143).

Could you help me creating a unit test for this by describing how to reproduce this behavior? Thanks in advance.
@methodmissing our Ruby VM box is at `http://files.travis-ci.org/boxes/provisioned/travis-ruby.box`, it is supposed to be used with [Vagrant](http://vagrantup.com) or you can unpack .box and find .ovf image there. Keep in mind that it is about 2.4 GB in size.

In addition, see [our ZeroMQ cookbook](https://github.com/travis-ci/travis-cookbooks/tree/master/vagrant_base/zeromq). We will be happy to tweak it if necessary. Most of our contributors use [sous chef](https://github.com/michaelklishin/sous-chef/) to test cookbook changes.
Incidentally, Addressable should be preferentially attempting to use a native IDNA implementation. If that isn't working let me know.
auto-scroll -> autoscroll
Hombre pues si, a los que están aprendiendo como yo les era de mucha ayuda, es una lastima que tomasen esa decisión :/ (ojo, no tengo server  únicamente hago esto por aprender y pasar el rato xd)
I just fix it, can you test it again

On Fri, Feb 24, 2012 at 11:48 PM, Daifu <
reply@reply.github.com
> wrote:

> There is a problem here, what do you want to compare?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/khaing211/g-simulator/commit/c4d3a4b35d2c809cdf6b69325b7cf2e1843620d2#commitcomment-1010449
>
Я имею в виду, что if else слишком большая конструкция для этой задачи, она хороша для блоков кода. А когда делаются две простые операции тернарный вариант самый красивый, т.к. стразу видно что за чем (в большинстве случаев). А присваивание заметить это просто дело привычки.
Yeah, I had hoped to try that first, but the URL and routing helpers, etc aren't available in the block - looking into it.
2. and 3. are old bugs, the other two seems to be new.
see #270
This information should just go in the main README.md file.
모임 생성할 때 썼었어요..  

모임 만들면서. 발표도 같이 추가할 때.. 지금은 쓰고 있나 모르겠네;; 안쓰나??  

--  
KeesunBaik


On 2012년 2월 22일 Wednesday at 오후 7:44, YongKwon Park wrote:

> 귀찮아서 한방에... ㅡ,.ㅡ
>  
> 대략 내가 생각한건 다 적용한건데... 뭘 더 정리하면 좋을까?
>  
> 현재 로컬 DB를 메모리 디비로 했는데... 이거 파일디비로 변경하고 백업데이터 일부를 넣어서 사용가능하게 바꿀까?
> 구지 그럴 필요가 있을까 싶기는 한데... 흠...
>  
> 하이버네이트 기반을 JPA2 기반으로 변경하고 Spring Data JPA 로 가는것도 좋을것 같고...
> 테스트 오류 잡고나서야 가능할거 같고...
>  
> 현재 웹 플로우 쓰는데가 있어?
> 그외에도 안쓰는건 좀 걷어내야할거 같은데... 벨로시티나 프리마커는 이메일 템플릿으로 쓰는건가...
>  
> ---  
> Reply to this email directly or view it on GitHub:
> https://github.com/whiteship/springsprout/commit/5a70cd5b61a6a8f4ca519b9ab03ff979bf07045b#commitcomment-995444
>  
>
ну как бы я совсем не против можно выделить в алгоритмы такую логику просто, допустим как конкретно мне сделать джимп при это так что бы при загасании прыжка он сделал состояние ожидания? он будет вешаться на цикл игры?
Oh i c . ok then .... I was thinking the other way :) .
I agree this should be changed to `void 0` only to remain consistent with the rest of the Backbone.js source code.  Reassignment isn't a concern of Backbone.  You could technically reassign any number of global objects, but expect weirdness.
Ah mira vos, ahora lo leo. Gracias por la respuesta =)
@paulirish Thanks for the hint

@nimbupani In Vim to convert tabs to spaces use _:set expandtab_. To control the number of spaces command _:set tabstop=4_ (four spaces). When you have set these to intended values you can retab the file by saying _:retab!_.
@yakloinsteak Thank you for being so supportive. I've just pushed a [commit](https://github.com/lucapette/vim-ruby-doc/commit/076734aedadeb73f32e958438507a0f3ebccc688) in the branch. I've tested it with bash ans zsh. It works fine for me. You could try it with your setup and tell me if it works for you too. I would greatly appreciate it.
@zalun how terrible is it to just sweep everything under the rug?
Thank you, Manuel fixed this in 4e82180
should say ```%d pages``` not ```%d page```
@eominsuk55 노노, 그렇게 공헌하는게 아니고, 미리 한 친구 처럼 Fork를 받아다가 고친후 Pull request하세요.
Nice! thanks :D
so sorry about this. evidently when i did one of my merges some things got messed up
ah eso se me paso, buen catch
Why did you break everything out to different files? Part of what is so nice about edspencer's plugin is that it's one file to include. I'm having a very hard time installing your plugin because of all of its dependencies. 

Sorry for the weird place to comment, but you don't have any issues for this repo and you didn't give github an e-mail address so people can message you.
Ah, great. Obvious once you look closer.

Two pairs of eyes *do* see better than only one.

Thanks for spotting that. I wonder if I didn't make any other errors like that.
Huh, was there a reason you didn't just pull in my identical commit/pull-request?

https://github.com/stephencelis/addressable/commit/e710b612cf1c35480da588191fdacb368ea050f6
You may use the -o option of git archive
2012-03-05 16:50:55 [SEVERE] Error occurred while enabling MobArena v0.94.3.24 (Is it up to date?)
java.lang.NullPointerException
	at com.garbagemule.MobArena.util.WaveUtils.getWaves(WaveUtils.java:93)
	at com.garbagemule.MobArena.Arena.load(Arena.java:926)
	at com.garbagemule.MobArena.ArenaMaster.loadArenas(ArenaMaster.java:251)
	at com.garbagemule.MobArena.ArenaMaster.initialize(ArenaMaster.java:185)
	at com.garbagemule.MobArena.MobArena.onEnable(MobArena.java:74)
	at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:215)
	at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:336)
	at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:363)
	at org.bukkit.craftbukkit.CraftServer.loadPlugin(CraftServer.java:342)
	at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:324)
	at net.minecraft.server.MinecraftServer.t(MinecraftServer.java:422)
	at net.minecraft.server.MinecraftServer.a(MinecraftServer.java:409)
	at net.minecraft.server.MinecraftServer.init(MinecraftServer.java:223)
	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:477)
	at net.minecraft.server.ThreadServerApplication.run(SourceFile:490)
Might be right, my changes are pretty superficial so go with w/e you trust. About the html(): yes, fairly certain. Else you could explicitly queue it I guess.
What's the purpose of this value? It seems pretty arbitrary.
Done:

https://github.com/rspec/rspec-expectations/commit/40f83a9d6b8820d57c2b2ecc20f193b1d1f55f71
In need of fully qualified names, here, should be `lang.Throwable` and `text.parser.generic.ParserMessage`
Should this be a try/except?
Note clever reference to our other article.
Thank god. I was looking for that already and I did not want to fall back to while loops.
many where my fault any way ;)
no `git pull --rebase` :P
This build of curl does not support https. The file included in msysgit does. This severely limits the usefulness of this package.
Thanks for your fixes, where I can read about metasploit best code practices???

HACKING don't provide enough information.

Or, you can point me to some good modules?

I took modules/auxiliary/scanner/misc/redis_server.rb as example, but I see that it is not entirely consistent with accepted standards.

Why << and not =+ ?

Thnaks.
Quitar el DataCasting, ya no es necesario para nada de ese boss.
I updated the commit to do a better check, here is a jsfiddle for what I was talking about: http://jsfiddle.net/sontek/ewaps/
@fernandoluizao responders don't replace inherited resources. Responders generators generate all seven CRUD actions. As I mentioned in the README, Inherited Resources hides too much what is happening while scaffold shows too much. Therefore we think responders provides the perfect balance.
TheHacker66  has said " I haven't finished with opcodes yet.. " and title of the source "NOT SUPPORTED Client version 4.3.2"
Vagrant is cool.  Is it worth mentioning [VirtualBox](https://www.virtualbox.org/) as well?
i'm making  a backup copy of the fork as it currently is, then force-overwriting my new code for this milestone. we can sort this shit out later
confused by the `/^focus./`
incomplete sentence?
It is still visible in "this" commit. I guess you would have to amend your original commit with your fixes and then push it again, but I never did this in github pull request so cannot tell if this will really work.
Thought it did D:
I have no clue what happened here
Fixed sex
Hi,

Be free to use mine instead:
http://blog.invisivel.net/2011/05/17/django-domain-driven-development/

They're hosted on flickr:
http://www.flickr.com/photos/filipecorreia/5690392757/
http://www.flickr.com/photos/filipecorreia/5626824909/

I wanted to provide a patch to this file myself, but time hasn't allowed yet.
New default value that can be overwritten by users or sub-plugins.
https://github.com/MarcWeber/vim-addon-manager-known-repositories/commit/529cfa2ccab494b77a316b7aefc740756aef96a1
So warning, I'd say.
Presumably a map shouldn't have negative values in it? Should we check for that as well?
I didn't look closely enough the first time. It populates `required_actions` and returns a list of parent-less nodes. That makes a bit more sense, and it doesn't really matter since it's an internal method anyway.
isn't there a risk that you have moved the node(role).address lookup to after the shutdown?
Yes, this is blocking -- I just realized it yesterday. I could not find a  
non-blocking name lookup in Java. Can you recommend a solution?
Sure. But typos shouldn't be ignored regardless.
how often is this invoked?
has it been tested on linux (the blocking issue we discussed previously)
reduce clutter further down, for example `selfAddress` is referred to 44 times
should be closed in finally (or afterAll)
It is called by the guy who creates the ActorRef, immediately after, this just makes sure that if he calls it twice things don't get messed up
Why is this lazy, it's going to get forced by the line below it?
shutdown and "shut down" in the same sentence
yes, I don't think it's that simple to automate, the sample code is committed source
ScalaVersion shouldn't change that often
I think this shouldn't be enforced here, why don't we make the guardian and systemGuardian LocalActorRefs in the Impl?
Hey, atleast I gave you options ;-)
Check, I see. Not very likely.

Still, unbounded `rangeImpl` for every message lookup... Tried to find something better, but I just can't. A get range of size N would have been nice.
Ok, that makes sense, thanks for the clarification (though I'd still prefer to catch something more specific than Exception (e.g. except (DecimalException, TypeError)).
this has a few issues.  most importantly, the issue isn't whether you can create the account card, but whether you can create +account.

I'd also say our new rep obviates the accountable setting.   let's kill it!
In the comment you can write that the survival function = 1 - CDF_truncnorm(x), just to better understand the return statement
We explicitly made the choice to compute FA there because it is so cheap, and because it would require re-computation otherwise (we put a comment in the code to say so).  But I think this should remain the exception.
@tobes I moved the previewable types into the environment in 8e48daf. However, to be honest, I don't see any advantage whatsoever. What am I missing?

Where do you think should the `resource_is_on_same_domain` and `_can_be_previewed` go?
Don't sys.exit from an extension. It's a somewhat unused feature, but return the exit code you want and the framework will raise that after it's done any post processing it needs.
The parameter name is "defaults", not default.
It doesn't really seem right to me that one of our REST API actions doesn't return anything. We should have some indication of success. Maybe a list of successfully uploaded package names? It'd also be nice to be able to provide a link to the newly uploaded resource(s) in the return.
you should just be able to swap out `MyForm` with `GridClass`
Here now: https://github.com/ethn/wagn/pull/21/files#r2226816
Why do we update the timestamp in child tables? Also comment and code not in sync.
Resolver shouldn't be called here. Switchboard is a link in the chain of handlers, it shouldn't execute a previous chain link manually. Resolver should probably add the resolved token in the message instead. I'm 100% sure we will need it somewhere else (probably in the consistency manager)
could we add a condition to only set the expiration time to 1 year on files that are no HTML sites? I'd like to prevent that addon html files probably get cached that long by some browsers/clients - just to be really sure. So something like:

```c++
c_int expirationDuration = CDateTimeSpan(356, 0, 0, 0);

if (ect.c_str() == "htm" && ext.c_str() == "html") {
 expirationDuration = CDateTimeSpan(1, 0, 0, 0);
}

expiryTime += expirationDuration;
```

ofc only if this is the right place for it
Why the need to check if the PVRManager is started?  There's no other dependency here on g_PVRManager.
yeah, unnecessary in both .h. and .cpp - we're in namespace std regardless.
тут лучше сделать через join. Т.е. как-то так: order__warehouse__compas__officers=user 
Это ускорит запрос.
Bedoel je een git submodule?
onTrackChanged?
when adding/modifying settings, preferences.Settings.VERSION needs to be incremented, and that new value is used to identify when a particular setting was added/modified, so "V(1," should be "V(7", and VERSION should be changed from 6 to 7.

yes, this can be problematic with different branches adding new settings.
Why not doing:

- Add all the contributions but texit
- Get texit
- Add text

this way the only overhead is the one of getting and adding texit.
Why importing it here? It is no where used.
I usually find this more readable if you return in the try block, after os.kill
opening brackets for switch should also be in the same line.
perhaps a better name would be tree_level
Ah, sorry, didn't realize it was private.
That's not accidental. The `restart` command doesn't have any purpose after those changes, since it does exactly what `make` does by default.
I'd also like to add that this is only possible because `NSCell` instances are supposed to be highly efficient at drawing, otherwise, the point to cell-backed `NSTableView`s is lost. So, rest assured, this shouldn't cause a massive gaping hole in drawing speeds.
This method also needs to check the class of `self`, since subclasses may invoke `+[TUIScrollView initialize]` if they don't override it:

~~~~objc
+ (void)initialize {
    if (self.class != TUIScrollView.class) return;

    // initialization code goes here
}
~~~~
Also, even when we insert an image in graphical emacsen, we might make it clickable so that an external viewer will open it when clicked.  That way, we could scale the size of the image we insert in the buffer to fit the size of its window, and let users click to see it in full size (an alternative is to expand it directly in the buffer).
A passing test should be a quiet test. Otherwise LGTM.
"should be 8" - are you sure about that?
Don't you want it to accept an array of callbacks?
looks like the slashes are messed up here
I made the ClassManifest fields `implicit` to simplify the code for wrapping RDDs, although it looks like the benefits are marginal here (JavaPairRDD's implicit key and value ClassManifests have more usages).  I was probably thinking of Java when I used `implicit def`, since Java doesn't interfaces or classes to specify abstract values/fields.  I'll change it to `implicit val`.
Are we supporting multiple 'source' files/directories in config-edit?
oops...good catch :)
Not sure this is safe - what guarantees that EG(current_execute_data)->opline is valid for every call to zend_error?
ninja'd
А это нормальное название переменной?
Yes, all tests are passing. 

I couldn't think of a good reason for `to_s` to remain. It's not necessary to guard against nil in a string comparison, and the column name should already be a string.
That code's pretty peculiar too, if the user's giving us an expires_in, why would we increment it?  If they want to avoid the race conditions they can increment their ttls themselves surely?
Use the ruby 1.9 syntax
Could we have a test for this scenario? Basically a render_to_string followed by a respond_to. Thanks!
This should probably be `assert_equal(Set.new(expected), Set.new(actual))`, otherwise none of the above `assert_equal_sets` will fail.
Tested like a champ.  But see my email to scala-internals.
*Stream* Interpolation??
I think this should work also without the asarray
Same for ``Voronoi``.
On Fri, Apr 13, 2012 at 3:05 PM, Tom Bachmann
<reply@reply.github.com>
wrote:
>> @@ -139,7 +139,7 @@ def _eval_rewrite_as_coth(self, arg):
>>      def _eval_as_leading_term(self, x):
>>          arg = self.args[0].as_leading_term(x)
>>
>> -        if C.Order(1,x).contains(arg):
>> +        if x in arg.free_symbols and C.Order(1, x).contains(arg):
>
> I never really understood how this is supposed to work. What about `cosh(1+x)`?
>
```
>>> cosh(1+x).as_leading_term(x)
cosh(1)
>>> cosh(1+x)._eval_as_leading_term(x)
cosh(1)
>>> cosh(1+x).series(n=2)
cosh(1) + x*sinh(1) + O(x**2)
```

In master this gives

```
>>> cosh(1+x).as_leading_term(x)
1
>>> cosh(1+x)._eval_as_leading_term(x)
1
>>> sinh(1+x)._eval_as_leading_term(x)
1
>>> cosh(1+x).series()
cosh(1) + x*sinh(1) + x**2*cosh(1)/2 + ...
```
if you write `s += bell._bell_incomplete_poly(n-m, k-1, symbols)*Poly(a*symbols[m], symbols)` then the code works. However this is very slow. This is probably because the Polys code is not especially good for multivariate polynomials. Or perhaps one has to work at a lower level to get this to work fast.
I prefer the `A.I` syntax.  It keeps to the numpy standard
You need to structure this exactly like `test_symbols_each_char` in sympy/core/tests/test_symbols.py.
kinertic -> kinetic
Is your system robust to someone changing the values to internally stored matrices?
It is based closely on the other.  I considered implementing this solver by transforming to a constant-coefficient equation and then transforming back, but these transformations seem to introduce technical difficulties sometimes.  Duplicating and modifying the code turned out to be very simple, and avoids issues like branch-cuts in the ln() calculations.
It is better to use sub directory and clear it at "tearDown()" or "tearDownAfterClass()", so the test running will not left extra garbage behind.
One test case is not enough. There should be at least two test cases (1. failing and 2. returning parsed timestamp value). But better to add four test cases (two failing and two normal).
or create it if it isn't available already :-)
It is usually better to use ClassRegistry. Also you should take into consideration the connection that was passed to the schema, models will use the default connection if no parameters are passed.
This conditional is used at least twice, would it be better to pull it out to a meaningfully named method?
Ok, Got it. Thanks.
Cool, can you add that to comments?
I would like someone with DragonFly to verify this.
это с мобилки с жемаила отправлял=) понял, сделаю ща
No idea why this file is different for you. Don't commit this file here.
I think the field name is actually hosts, not host
I see where this came from? we need to tweak it.
Great catch!  "term" is baked into the moz plugin so I'll make an update here.
End of comment block... looks like there's a waffle switch on this, so maybe not needed?
Might be worth deleting... I just wanted to turn it off for now, and look into properly fixing it in the future. It's not updated for the Kuma world where locale + slug are unique rather than title + slug
Switch to regular sidekiq while you're in here, not a git-specified one.
What if `$user->data['user_id'] !== $user_id`?
Using `RegExp.$1` is fairly bad practice, iirc. Save the `.match` call to a variable and then refer to that instead.
Maybe this should be in `cache.php`
Having displayed posts implies having posts. In this case, the query is not necessary. If displayed posts is 0, the query has to be run to get the final outcome.
Is trace/error going to be shown to everyone (i.e. non-admins)? Do we show them to everyone elsewhere?
outside? The point of it is to be able to add another link as part of that list to a page which is something quite a few MOD Authors do?
isset() doesn't work but in_array() does.
In the constructor this parameter is called `$revision_id` should be changed to keep the variable names unified
I don't like globally recognized avatar either and I like imkingdavid's suggestion.
Should probably use a hash instead of an array for readability/extensibility.
This is unrelated to this PR, but I haven't noticed this sooner.

Is there a reason why `getTargets` function is async instead of sync? I see no reason for this function being async. It just makes code more complex and adds unnecessary level of nesting...
Okay. Some options:

  1. use `skip`
  2. use `enable` as it is now (the inverse of `skip`)
  3. use `enable` like `publishArtifact` where `generatePdf` called directly would still run (and rename to `generateOutput`?)
  4. make `enable` more specific to this case (so just use an `enablePdf` setting and have html always on)
  5. ...
consistent style:  (believe me, I wish there was a good automated tool for this)

```scala
trait Hashtable[-T, +R] extends (T => R) { self =>
```
Should we start adding warn level logging around deprecated features?
Yeah, none of the tests are delinted.  Hopefully that happens as the tests are ported to the new testing framework.

I'm punting here/now since I'm concerned about this redesign work growing in scope...
Should refactor this fn and the above fn

getObsBMI and getObsComplaint are nearly identical... the just have one different item (the displayName, such as ```'REGISTRATION COMPLAINT'```). So can you create one shared fn: ```getObsByDisplayName: function(observations, displayName)``` which takes the displayName as a parameter instead?
@johnstoecker can you please help me with this one?
A very deft piece of "code surgery" to work around the test-unfriendly structure of FF2PP & FFHeader. It leaves the rest of the test *beautifully* simple and focussed. Nice. :smile:

It'd be good to factor out the repetition in the subsequent tests. Perhaps something like:
```python
    def test_payload_unpacked_real(self):
        mock_field = _MOCK_FIELD(...)
        self._test_payload(mock_field, 800, ff._FF_LBUSER_DTYPE_LOOKUP[_REAL])
```
@return boolean

opening brace, use consistent spacing in the if / else if { } blocks
Is this the right thing to do? Or should the perform() method downcast the output, so that it has the same type as x?
Testing vs. To test?
yes - added
When there is no model group, nothing should be displayed.
How about calling `determine_all_n` and using `lists:max`?
It's fine for now, I'll throw a TODO on it to make sure I don't forget about it.
In this case yes, but in other cases - such as load_modules_of_type() and related - there is a lot more logic to move up a level and it may be file loader dependent.
Yup! https://docs.djangoproject.com/en/1.4/internals/contributing/writing-documentation/#commonly-used-terms
Prefer the non-abbreviated version of integer instead of int.
Yeah this is actually a textfield. I moved it from widgets but didn't adjust the code yet.  

Sent from my iPhone

On 11 aug. 2012, at 11:17, Peter Verhage <notifications@github.com> wrote:

> In vendor/Adapto/src/Adapto/Field/TextInput.php:
> 
> > @@ -0,0 +1,19 @@
> > +<?php
> > +
> > +namespace \Adapto\Widget;
> > +
> > +class TextInput extends AbstractWidget
> Shouldn't this be called a TextWidget?
> 
> —
> Reply to this email directly or view it on GitHub.
>
This is a celery task. There is a test for the complete workflow of the calculator, so it should be covered. 

For the sake of a unit test, I am wondering: do we have a proper way to mock Celery or can we test the "undecorated" function?
This is certainly better than a failing test, but I don't also like unit tests that are tautologies. It's going to be true because it's literally a copy of the function body. However, I can't think of a better way to test this. Can you?
I don't think we're looking for an overridable hook. We're trying to provide a flexible way for alternate ajax implementations to provide sync script evaluation by exposing an interface. Since the interface we need is ajaxy, it seems most logical to put it in ajax.js.
Turns out to be simpler than I thought. Kept both and turned into an each.
Not technically correct since NULL and -1 are treated as equivalent, but not a huge deal.
s/sparsere/sparser/
As above.  It seems to me the sentence above should be out of pre.
Grumble. This was supposed to be "supportedVersions".
Also we prefer not to use `&&` chains, and we have a "curl" utility method:

```rb
mktemp do
  curl "-O", "http://partners.adobe.com/public/developer/en/xml/AdobeXMLFormsSamples.pdf"
  system "#{bin}/pdf2htmlEX", "AdobeXMLFormsSamples.pdf"
end
```
Excellent. We need more tests and make tests in homebrew anyway[without "s"].
This should be done as

```rb
ENV.append_to_cflags '-D_BSD_SOURCE'
```

otherwise it will throw away all of our other CFLAGS.
Bummer... ok. Will do.
Can we have an `r_key()` implementation in this class?
I don't think this approach is wrong. I think we should just add a helper method to the middleware base class that does this by sending the message through the rest of the middleware stack (it'll need support from the middleware stack object probably).
I've added support for both 'widths' (as per R's, as you describe), and 'colspecs' (as half-open intervals, as you suggest).
Half-open is indeed more Python and besides has to get parsed on the client anyhow, so "+1" is not a big issue, and as for widths, it was trivial to implement, so why not make you happy. 

Done.
The problem is that linker is very stateful. If you add additional linkers, it's unclear where that state goes. If you want to move behavior out of linker, that's okay.
And I meant to add: I'm not sure it's terribly important to invoke them for these either.
These are required on Windows build servers. Can you change it to conditionally exclude these for Mono builds?
Seems the following scenario is still possible:
1) You reconnect, the old pipe termination is initiated, incomplete_detach is 1
2) Reconnection is successful; now you have a new pipe and incomplete_detach is still 1
3) The pipe termination initiated in step 1 finishes, you decrement the incomplete_detach counter (0 now) and nullify the pipe member

Perhaps using a std::set <pipe_t*> to keep track of pipes + active_pipe member could simplify the code.
Refactored to shorten lines, and reduce duplication at the same time.
There is a fair bit of duplication in here and in UpsertForDevStorage. The biggest thing keeping you from combining them is how the "Add" is handled in the catch block.

Finding some way to handle that would be nice.
Good call.

Since clients may choose to hold on to ID's or Menu/MenuItem objects I changed these APIs so they return the object rather than the ID since the ID can be retrieved from the object. The user has both options then with one API.

My expectation is that holding on the Menu/MenuItem objects will be the most common since it's concise to call the methods on these objects directly rather than getting the Menu/MenuItem object from the ID each time. Also, the objects themselves will be triggering the events (whether they originate from native or html menus) so these objects will persist due to listeners.


-----Original Message-----
From: Narciso Jaramillo [mailto:reply@reply.github.com] 
Sent: Friday, May 18, 2012 9:32 AM
To: Ty Voliter
Subject: Re: [brackets] Menu API Proposal (for review only) (#911)

> +     *  click
> +     *  rollout
> +     *  rollover
> +     *  hide
> +     *  show
> +     *
> +     */
> +    function MenuItem(id) {
> +        this.id = id;
> +    }
> +
> +    /**
> +     * Returns id of parent MenuItem if the menu item is a sub-menu, returns null otherwise
> +     * @return {string} parentMenuItemId
> +     */
> +    MenuItem.prototype = getParentMenuItem()

In general, do we expect people to be passing around and holding onto actual MenuItems, or onto their IDs? If they're going to be dealing with both, then our naming should distinguish between the two, so these should be called `getParentMenuItemID()` and `getParentMenuID()`.

---
Reply to this email directly or view it on GitHub:
https://github.com/adobe/brackets/pull/911/files#r846242
The `5` multiplier should be in a constant
I wonder if we should just make this "Live Highlight". I know we have "Enable JSLint", but the "Enable" seems a little redundant since this is a checkable item.
ChangedDocumentTracker could be confused with the ``change`` event for Document. I think "dirty" still applies. For the client, the file was dirtied since the last reset().
This change should be transparent. It never added new shortcuts for Brackets. What copy, cut and paste shortcuts are depends on the OS.
The wording of "If undefined, all platforms will use the key binding." can be improved:

What about "If undefined, all platforms not explicitly defined will use the key binding." ?
ah right. ok.
Should priv.thread_pool.submit also hold the thread mutex so the shutdown flag can be properly tested before adding items to work queue?  If so, the function needs to return a bool or such for status.
enlever le support des formats alternatifs
good catch on the dict here
change domain_qs to domain? i think this an artifact of long-dead django-based code
Not generally best practice to use `<br/>` tags for spacing.
To reduce duplication (esp. with `annotate`) maybe the the layer construction should be extracted out into its own function?
Исправлю. Доделывал поздно, понаделал опечаток. Что-то не это слово никак не хочет запоминаться ))
Hm, don't use backticks for non-links and non-references, they are tried to be specially processed. Use some other [inline markup](http://sphinx.pocoo.org/rest.html#inline-markup).
BTW, this line is also unnecessary. Same as above. Memoization/caching is useful if you have some expensive computation to do and present it as a property.
yes, it's true. but it hit where i could verify it after i made the pull request.
it's being tracked https://github.com/mozilla/bidpom/issues/39
need padding around the e
You don't need to check this
Are you just leaving this file in here for quicker access to testing the responsive css? If not, we should remove it.
Please update this comment to reflect the fact that the options object is not the only thing passed in, and what isGhost means.
I've changed to `@db`
I wasn't sure what you meant here... perhaps that forms look as ordered as lists? :-?  In any case I think my copy conveys the "forms look awesome" message :)
Oh wait, sorry I'm wrong. This should be fine. (And in particular, the value of ENV.to_hash shouldn't change across restarts anyway, because that's the whole point.)
Onko se tarpeellista? Musta koodin lukeminen vaikeutuu, jos kaikki paloitellaan pienen pieniksi metodeiksi ja hajautetaan eri puolille luokkaa. Tossa näkyy paljon selkeämmin se, että mitä toi tapahtuman poistaminen vaatii: avaimen lukemisen, kyseisen tapahtuman poistaminen tietokannasta ja käyttäjän ohjaaminen takaisin omalle sivulleen :)
Should this be "Definitions" instead of "views"  ?
`filter is a...`
To be clear, by the time you're here, `data` is in fact guaranteed to be one of { string, buffer, undefined }, because of the test on line 34.
Should use the `with` statement here to ensure that the file gets closed.
Yeah, I think that strictly speaking, PEP8 requires this, and I find it easier because I know where to look for where these things are defined, but I'm easy going.
What "is" a name proxy? I agree GetNameProxy() currently doesn't make sense either, but I'd go for HaveNameProxy().
"must require" sounds strange
I don't want users to be told that hardlinking failed-- most end-users won't know what a hard-link is, and if it DOES fail I don't expect them to do anything (they'll just fall-back to downloading the whole chain again).
Inline comment here too, using  `//`
The formatter function cannot be date(). There was a reason for this but totally can't remember at this time. I will test tomorrow and see if I can remember why.
a number of indentation issues in this file.
Is this required? Won't it always run even when WIF isn't in the pipeline?
Removing the message, but I like leaving the check in. I don't want any surprises in case something went wrong.
Do we have guaranties that the api will be the same  ?

I don't like importing as sqlite3 as later you don't know that sqlite3 is not effectively sqlite3

Maybe importing both as `history_db` and change sqlite3 references across all file ?