labofsahil/github-event-dataset-2012 huggingface dataset:
Sorry for the slowness of my reply! 

From what I understand, your approach makes quite a bit of sense. I say go with it. If you want to do some code, then that would be really cool :-) I just haven't had the time lately to do much myself, but I am determined to get back on with it again soon. I think I still need to review/merge your other pushes, so I'll try and do that tonight. 

Thanks for your enthusiasm, by the way.
(s) lol yeah i missed that /shrug ya got me lol
yes, the adjacent sibling selector (try making that, wordfeud) is counter-intuitive.

@crazytonyi Could you check that my patch b2a37e0 also includes the functionality you intended, and if so, close this request?
You wait until you get to versioning and sharing your patch queue. Which you can do… with a patch queue.

Good lord.
フラグを無くして「Reputation.create_for_accept! answer if accepted_answer_id_was.nil?」と書くと、既にsaveされているので常にfalseとなってしまい、正しく動きませんでした。
というわけで、最新のコミットでは「変更されていればsaveする」というロジックに変更しています。

また、これまで成功/失敗でtrue/falseを返す仕様にしていたのですが、本番コードでは特に判断していないので戻り値は特に意識しない仕様に変えてあります。

https://github.com/JunichiIto/passenger_overflow2/commit/781aba30f0fcdff8bb0a002e1d5876b0cf353242
I don't actually care if str(level) is called. That's why the test is called testAccessMembershipStr
In general, isn't <b> enough? Instead of <h4>.

Other than the comments I gave, I think it looks good enough ^^
Sorry, I was quite busy these past days. The drop_caches.c code appears to periodically drop caches every 20 minutes (by echoing "1" to /proc/sys/vm/drop_caches).

I suspect that it can cause lag due to the unnecessary flushing of caches, but I'm not entirely sure. Only Samsung includes this hack in their kernels, I never saw it in my Huawei kernel, for example.
I still think these methods should be behind an indirection layer like `onMethod` `onConstructor`.
OK, swift_keypad.kl needs to be created. I'll upload the patch in a sec.
maybe they have this extension...
//TODO carrier label default isn't resetting propperly
ovo nam je trebalo u player aplikaciji jer je tamo view trebao moći do kolekcije radi toga da može maknuti element iz playlist kolekcije.

ovdje view/user ne koristi nigdje kolekciju, pa je nije potrebno niti proslijediti - idejno, ne proslijeđuješ više nego što je potrebno.
So.....we're just deleting the changes we made??
What I want to see indicated by the RGB LED:

When the system is running, I want to see missed calls, unread messages and similar in the first place. The only battery indication worth in this state is the low battery indication, as that is a critical condition. I don't want to see the orange/green battery charge status indication, as such indication would distract/collide with the LED messages mentioned above.

When the phone is in charge only mode, indicating the red/orange/green battery charge level status is perfectly reasonable, no other messaging can take place anyway.

The issue with sorting this out in liblights (I already thought about checking the sys.chargeonly.mode property there) is that the liblights code is shared between both Milestone and Droid - the Milestone's TARGET_BOOTLOADER_BOARD_NAME is unfortunately "sholes" as well (not "umts_sholes"). I needed a quick fix >now< and I hate using unnecessary forks. The sholes device repo is out of my control and getting a patch merged there can take a while. It also may not get approved at all in the end, as the Droid itself is not using the charge_only_mode at all.
@rsjtdrjgfuzkfg  ...one question...did you tar up the files so they're all already inside a folder named windows-i686? If not, that's tbh an easier way as you can just check if the dir is there (or not, and just rm -rf &> /dev/null) and then untar...

That said, either way, you're not going into that directory after creating it...or checking if it's there, so you at least maybe need a 

"cd $depdirn" below the fi here?

Otherwise, looks good.
Already added, see scmnr.2009
This is throwing an error for me in  non-mocking mode
      - authorize port range access by another security group
      The security group 'fog other group' does not exist (Fog::Compute::AWS::NotFound)
Do we need these transpose comments at the end?
Please place this function below the "local functions" comment, and reformat it to match the code style used in the rest of the file:
- function return type and function name + arguments on the same line
- indentation with hard tabs
- no spaces before parens: eg `strcat(...)` instead of `strcat (...)`
I don't think this requires a `new`, AFAIK there is no prototype on `Y.Array` and this is likely a waste of new objects.
This whole `HANDLERS` object seems odd to me. Why does this have to be used?

It appears that there's two buckets of event subscriptions: the long-lived `start` subscription, and the shorter-lived set of `move`, `end`, and `cancel` subscriptions. The code doesn't distinguish between `on()` or `delegate()` handles in any meaningful way. I don't see a need for these two sets of named constants, but maybe I'm missing something?
Do you really expect someone to pass a `callback` property that's truthy and isn't a function? Seems like this could just be `if (callback)`. If someone wants to shoot their own foot, let 'em.
It's be uniform with eventName.
`->delete($child->guid);`. You should also set `$child->subtype` so that, for the rest of the request, anyone using the cached entity instance would see the new subtype. This looks workable (assuming we're comfortable with letting a plugin change subtype).
As in the text ` .defaultText("The exception code could not be located for " + defaultCode)` ?

That's fine, but that's mostly for safekeeping and covering all the bases, just in case the code mapped to
`BadCredentialsAuthenticationException.CODE` goes away for whatever reason this messages not allow the app to crash. As things stand, the user will never ever see this message. 

Come to think of it, maybe it's better to crash early?

As in, if for some reason the code mapped to `BadCredentialsAuthenticationException.CODE` is removed, it might better to remove the default text above and simply allow CAS to crash or forcibly throw an exception back to indicate the actual issue.
Are you sure this master.zip is the last snaphost available ? I think it would be better to explain that snapshot artifacts are stored in the Sonatype snapshots repository, explaining groupId and artifactId and version. Or maybe give a link to the repo itself : https://oss.sonatype.org/content/repositories/snapshots/org/jasig/cas/.
Ah, good catch. I will add the regex for that.
Yes, true, because it has to maintain red-black property for the resulting  
tree, I think. Log(n) still, but it materializes only for large trees.

> Might just be better of with an array and linear find.

Even better: sorted array and binary search.
I wanted to prevent exactly that, closing over "this". I wanted to basically separate the function from the Actor. So the Actor should just be able to return a function, the user should be able to provide a custom function, and I only want that function to be contained in the message, without a reference to the Actor. Any way you can see how to do that?
Maybe a short explanation about the tradeoffs with different values?
def generateSeed(length: Int): Array[Byte] = InternetSeedGenerator.GENERATORS.view.flatMap(g => { try Option(g.generateSeed(length)) catch { case _: SeedException => None } }).headOption.getOrElse(throw new IllegalStateException("All available seed generation strategies failed."))
I don't know whaat the right semantics should be, I just want to know that failures are handled :-)
well, I just wanted to "document" that the AskTimeoutException is related to the join procedure
No, I mean, in the style enforcer :-)
Changes the Renderer.  Note that it doesn't clear it between file loads (maybe it should), so we need a: format :base in each file to explicitly set it even for the default formatter.
Shouldn't this be using `is` instead of `!=`?
I just tried it, np.vdot seems to just return one value. I need something like `[np.dot(a, b) for a, b in zip(A, B)]`
I think you need to add to the docstring to document what activity_params is
The comment location got a little lost again, but this change was made.  Around line 33 now
I've been thinking about this issue.

1) Codenames can be assigned to !simple? cards.  We can create the situation with rename, and if we don't want to prevent that, and I can't see that we would, we have to allow it.

2) Codename can be a Set, and I think it should.  It is an easy change, and I think expressively powerful.  Then we don't actually need indestructability of codenames as a feature.  Just prevent it with a rule.  Also, I think we need a permission rule setting that says 'not even admin'  WagnBot may still be an exception. (special, like root).  Note that 'read-only' can be just setting some rules: *all+*(create|delete|update|comment) -> :no_permission

3) The codename rules mean we can't let them delete these cards, but they can be hidden with rules.  We'll go over this, but the upshot is that :invite would point to *invite+*thanks, or maybe it is :invite_thanks.  That would make it indestructable without any code changes.  Also, as another example we can bind: :default_type to the card *all+*default, then Card[:default_type].type_id is what Card::DefaultTypeID currently defines.
`OptionStore` started life as a dictionary, and it should probably continue to look like one. Changing everything to be magic attributes would require changing roughly 5% of all lines of code in mrjob. (And come to think of it, some Yelp code too.)

`OptionStore` adds a specific set of features to the plain dict:

1. Store "cascading dicts" internally
2. Enforce a specific set of config keys

`RunnerOptionStore` adds further features:

1. Combine options across dicts
2. Switch between old and new option behavior (see EC2 options)
3. Default behavior

My main mistake here was to put the switching stuff in `RunnerOptionStore` instead of a general feature in `OptionStore` that reads from a class variable. Will fix.
Would be more efficient to use dictionaries for this.
`raise` not `return`.
Probably should access through account, but I'll hit that detail later.
put the closing parenthesis and semi-colon on its own line, e.g.:
```
rtems_status_code rtems_memory_management_create_entry(
  rtems_memory_management_region_descriptor region, 
  rtems_memory_management_entry** p_ret
);
```
add copyright and license header.
They are not, but my API does not reflect this well. I will fix this,  
thanks for pointing out.
based on http://devblog.blackberry.com/2012/08/blackberry-10-user-agent-string/, it looks like this will work for BB10 through BB19... I'm OK with this, but their own detection script uses BB10 explicilty.  I guess we're treating Playbook as it's own platform... it has a different scheme listed at http://stackoverflow.com/questions/3839838/what-is-the-blackberry-playbooks-user-agent.
same here: you don't need t use ``else``
Crazy indentation here.
This should be a top-level function that takes a hostname and a certificate, and returns `true` if it's valid, or `false` if it isn't.  Then it's up to the caller to pass in the appropriate arg and create the error.
s/have no/doesn't have a/ and s/require/requires/
bye bye class!
Ah, je vois. Ok.
This is API break, is it necessary?
This should be ``if exclude is not None``.
после 5 пробел :)
нужно бы комментариев
Thank you! I forgot this was added.
There's no need fot the else part, is there?
What kind of warnings? Could the comment elaborate more on what it's fixing?
Wouldn't be better to just build the options hash instead?

```ruby
options = {
  ampm: @options.fetch(:ampm, false),
  start: @options.fetch(:start_hour, 0),
  end: @options.fetch(:end_hour, 23)
}
```

Or something like that.
Please use 1.9 hash syntax where you have made changes or add new code. Thanks.
Entries must be on top.
Boy, you sure don't want to use mapValues here.  You'll probably want to go back and review everywhere you've ever used it after you go look at what it does (which I assume you will do now.)
`IndexedSeq` is more general; one could write one that wasn't based on the `IndexedSeqLike` template trait.
yep, a `dealias` does `betaReduce` immediately followed by a `dealias`, so it sounds good to me to expose our little type-level evaluator's intermediate steps as an iterator
I allowed myself to change that as well, because it seems to me that the `completed?` behaviour and not the `complete?` state were tested
I was playing with the idea of X.T just being a Transpose object in the case where `type(X)==ImmutableMatrix`. While I was playing with this I needed to use equals rather than `==` (MatrixExpr's don't overload `==`). I decided against this idea but left in this change. I can revert it if you prefer. I think that using `.equals` is safer than using `==` though.
You have a typo here
align_char = self._alignment[0] # = l, r, c
Well, `Symbol` is a rather large class, I was reluctant to use it _just_ to store a string.  I've changed the code to use `Symbol` and `Dummy` now, according to your recommendation.
signsimp-ing the LHS doesn't work for me.
Any reason to not just use hasattr?
This  makes completely unwarranted assumptions on the meaning of the args.
Approx. Then clean. But in general I think about this question.
Good catch! Removing.
This is good. We should look at tip extending the container - This may be a better pattern. Thoughts(?)
I think sean's right.  Build_association does not save the newly created object, does not save the current object, but does save a replaced object if the previously linked object on that association had a foreign key pointing back.  Create_association saves the newly created object, doesn't save the current object, and does save the replaced object.  Create_association! saves all three.  Sean, does that sound right?  Maybe we only want to support  the third case?  Our use case would be most convenient to use with the third.  I don't know how we want to deal with naming of the ! methods in ruby.  Technically the save and create methods would be the ! versions.
As discussed, I really dislike this calling convention -- a separate `assert_match_regex` and `assert_all_match_regex` would be better.
`colorMap`
What's the difference between `meck_ret_spec` and `meck_expect`? Could they both be merged into the same module perhaps?
I don't think this is valid, detection of ANI support should not install ANSI support, which is what this change does.
why are these lines removed?
You are wise.  Can you put in a comment to that effect so that someone doesn't just "simplify" it in the future.  Also are all of these permutations tested?
In fact it could even be that this code and ````from_param```` use the same utility method to take an ID string and return the ID, number, version, etc.
terminology q: "Get Commit Acknowledgement" vs "group commit acknowledgement"?
Wouldn't the RecursiveDirectoryIterator be a better approach for that?
Please use " . $row['user_id'] rather than {} in strings.
Good change :)
Haha. Shoot! Who would’ve thought such a *simple* addition could be done so sloppily.
Copy/paste crap :-/
I believe this is specific to x86, can you try to make it platform-independent?
Why does the `PropertyName` and `BoundType` properties has to be `virtual`?
remove this file from pull request
My only concern - do we want location acronym (GAN) to fundamentally be part of the ID?  (Just shown in UI as a 3 letter tag that precedes the ID? or actually part of ID?)
I think the more pythonic approach might be:

```
if all([is_partial_slice(s) for s in full_slice]):
   ...
```
Those `%0d` terms can be simplified to `%d`.
The behaviour of ```Cube.dim_coords``` property has changed.

For example, previously if you had a 3d cube, where <i>dim0</i> and <i>dim2</i> were described by a ```DimCoord```, then the ```Cube.dim_coords``` property would return something like [```DimCoord```, <b>None</b>, ```DimCoord```].

Thus there was a need to filter. After a previous CF review this behaviour was found to be more troublesome than a benefit, so the property was change to return a tuple containing <b>only</b> the ```DimCoord```'s.

Hence the filter is a NOP, and should be removed.
@nouiz R-op does not use the fancy implementation @goodfeli wrote for grad. It relies only on None and zeros_like. It some sense it suffers from the issue grad used to (when you are dealing with ints or maybe disconnected paths). I haven't look into making use of the DisconnectedType and the rest, but that will be quite a bit of work, and I feel that even for the grad method things are not perfect yet. Plus is not clear to me that we can reuse exactly what Ian wrote. I think a few changes might be required. 

The change does not change anything, except that before R-op used to introduce a lot of dot(zeros_like, V) or elemwise operations involving zeros_like. Those are usually optimized out, but it makes for a huge graph. Also for the conv op, I'm not sure that conv(X, zeros_like) will be optimized out. I did not want to implement another optimization and I thought is better for Rop to be smart and not introduce all that garbage. 

Regarding tests, you are right, but thankfully enough all the old testes failed because of this change and I feel that they cover this.
Should that be "alloc = true;"?
Actually VoltDB never run this overflow or underflow code in ee. I think it already returns with an error message in Java level.
what is wrong with it ?
I can't understand this comment. If I can't I doubt anyone else will be able to.
+1, and for comments the usual rule is: "Explain why you are doing something not what you are doing" -- If you have to explain the "what" you probably have to rewrite it anyways ;)
@Lynart the spec actually outlines the end of file to contain zero or more line terminators, a new line at the end of every file shouldn't be necessary, see: http://dev.w3.org/html5/webvtt/#webvtt-file-body
@gibson042 this is really nice :)
Good catch, I'll nuke it.
See above; the new rgroups matches never start with leading whitespace.
Are there other cases besides trailing pseudos that is not covered in the regex? If not, we don't need to go through tokenize. See latest commit. We can keep working on it, but there were so many changes in your pull I wanted to get us on the same slate again.
These will conflict with the identical directories installed by the main ocaml formula when linked into HOMEBREW_PREFIX.

I worry about how much of this was just straight copied from the ocaml formula.
@samueljohn Thank you for advising me on the code style. I will wrap the line.
Let's not tangle the universal binary line in between unrelated things like this.
Yes, of course. Thx.

/F

On 20 sep 2012, at 05:12, Jack Nagel <notifications@github.com> wrote:

In Library/Formula/task.rb:

> @@ -2,7 +2,7 @@
>
>  class Task < Formula
>    homepage 'http://www.taskwarrior.org/'
> -  url 'http://www.taskwarrior.org/download/task-2.1.1.tar.gz'
> +  url 'http://www.taskwarrior.org/download/task-2.1.2.tar.gz'
>    sha1 'c23cb320f3478e37527c5c3cc547286f97bacc7c'

Need to update the checksum!

—
Reply to this email directly or view it on
GitHub<https://github.com/mxcl/homebrew/pull/15012/files#r1647260>.
That the School was created
Nettoie les TODO inutile s'il te plais, ça nous permettra de mettre des //TODO quand il y en aura besoin par la suite.
Yes, `normpath` normalizes the path.
Hmm.  How is this better than throwing a clearer runtime exception. THis isn't a violated assertion or an impossible state.  This is what you get for running Dagger in something with a crappy security manager.
Please remove commented out code (same below).
There are custom runners (Theories, for example), that have tests that are not backed by a method annotated by @Test.  There is already a way to run just some tests in a suite, which is to use a Filter.  If this can't be done with Filters, let's enhance Filters to make them work, but let's not break dozens of custom runners.
@kcooney 
Making a deep copy is an overhead.
We should provide high performing implementation which minimizes blocking operations and is 100% guarantee of semi sequential flow.
The COWAL is against this idea. I think using tryLock in run, and lock in removeListeners is the best solution => we do not need to block run() unless the listeners change.
What you think?
This will change the ordering that the nested classes will run. It's possible that this could cause some tests to break if they depend on the ordering. Test authors shouldn't do that, but it would be better if we could just keep the existing ordering.

Luckily, that's easy to do. Create a LinkedHashSet instead of a HashSet
hey @beaugunderson @temas I want to make sure this is an ok pattern w/ statsd, that each partition (hash of the pid) will have it's own grouping, and that we'll be able to access all that data to find the ones with the most range, one, and mod values over time easily somehow?
I can't, no; this won't have access to an instance of a View.

Perhaps this is what `mulberry.Device.standalone` ought to be?
Should change the name here as well since we're referring to this as "changed documents" instead of "dirty documents".
```query``` has already been escaped at this point, yet defaultResultsFormatter() will escape it a second time, making it display wrong.

In general, I think it's best to do the escaping as close as possible to where it gets inserted into the HTML string.  Another potential pitfall: in defaultResultsFormatter() I'm not sure whether the RegExp bolding stuff will work right when the matching part of the string contains something that got escaped... ```query``` is escaped but ```item``` is not, so I think the RegExp might not find any matches.
hintList is dereferenced in many places without verifying it's non-null. There seems to be a complicated/delicate balance of when hintList is null or not, that might be OK as it currently is, but could easily get messed up when the next dev comes along and needs to update this code. It's safest to check ``if (hintList)`` in all cases.
Gotcha.  I could imagine cases where you'd still want to get info about the tag name, but the current behavior seems reasonable for now.

I do think it's still worth putting a comment here explaining what case this is covering.
Nice -- the _getMenuItemId() bit is a great addition
You write `exec` like `exec` and not like `EXEC`. That makes no sense. Also in the other files.
this won't actually trap any exceptions raised in the import task anymore, will it? is there a way to find if the async task had an unexpected error?
Could also just set token's default to `uuid.uuid4`.
Leave this change; what it does is Math.floor() whatever start is.
Looks like the beautifier did get rid of a new line here.
Why remove this line? Doesn't this let you do ./make.js <whatever> in unixes if make.js is marked executable? Seems like it's useful to have it, even if gjslint happens to complain about it. :/
Ah, now I got it.
useful to add as a comment in source code?
That URL at the start is causing a syntax error. You can use `pod spec lint` to check the spec’s validity.
This was not intentional too.
I dislike this while and len loop. Use slices.
Do we want to throw an exception or just send a message to console.log? I think it's probably OK to continue to load the rest of the apps, but I'm not sure what the convention is here.
Changed it to _get_object_path()
Here and below in the detailed section (or maybe only in the detailed section?) I think it's important to clarify what the origin of the 3-d coordinates is meant to be. I know this is technically system dependent, but maybe spell that out with a couple of examples for people who don't know that level of detail.
Shouldn't the int and long tests be int(q) and long(q)?
Ha, yeah you're right. Elementary school was  a long time ago...

The term nrequired is always capitalized as nRequired elsewhere in the code, so I think it's meant to read as two words.
@laanwj I couldn't have said it any better!
space after `elseif`
Are we really getting rid of the null facility? Any particular reason?
sorry, wrong statement
want to leave a space?
ok, there is an interface, but you should implement it :)
Actually, we can remove extra block completely and instead use a "shared_context" function that is defined in this blog post (search for shared_context):

http://testdrivenwebsites.com/2011/08/17/different-ways-of-code-reuse-in-rspec/
This must be explained. Why the flag was needed in the previous version and what forces removing it now?
`timestamp`
This is more of an aesthetic thing: you have an interface to provide the abstraction for other code, and you have two different feature requirements here. One uses a simple string tag and the other uses a bson.RegEx to achieve the desired end result. Yet you have a single struct implementing both features with a boolean in it to decide which you're doing. It seems ... wrong?
So if I want an "auto expanding" text area, I need to add the jquery/jquery.textarea-expander.js and I have to write some specific js-code. Seems a lot of hassle to me.
This feels like a lot in this method. What about something like:

```ruby
def add_endpoint_attributes(args)
  bucket     = args[:bucket]
  id         = args[:id]
  name       = args[:name]
  key_name   = args[:key_name]
  domain     = "heirloom_#{name}"
  path       = "#{bucket}/#{name}/#{key_name}"

  end_point_attributes(path).each_pair do |key, value|
    add_endpoint_attribute domain, id, key, value
  end
end

private
def add_endpoint_attribute(domain, id, key, value)
  @logger.debug "Adding tag #{key}."
  @logger.debug "Adding tag #{value}."
  sdb.put_attributes domain, id, { key => value }
end

def end_point_attributes(path)
  {
    "#{@region}-s3-url"    => "s3://#{path}",
    "#{@region}-http-url"  => "http://#{endpoints[@region]}/#{path}",
    "#{@region}-https-url" => "http://#{endpoints[@region]}/#{path}"
  }
end
```
Did you mean to include this file?
Doesn't this always add -E? The original added the -E option conditionally.
remove the extra 2 line breaks
this class is for SmartOs, so make sure you use SmartOS names, like VM, Dataset, etc. in the methods
Eliminate commented-out debugging code.
Check == null here
Strict warning: if the prop is not found, function doesn't return a value.
This whole `error` thing breaks with the general style. If we want to store the error code, we tend to do `if ((error = some_fun()) < 0)` which allows us to jump to the cleanup and return `error`. Initialising it to `-1` and setting `error = 0` on success feels backwards.
I believe this should be public?
if(buddy->status) {
    s_free(buddy->status)
    /* status 应该在这里赋值吧, 不然status为空的时候怎么处理? */
    buddy->status = s_strdup(status);
}
I had that `D` shortcut for my own debugging. I removed it later :)
Maybe at least one exception should cause the indexer to exit non-zero?
Done. And thanks for the git tip.
well, I couldn't remember the arguments that fov_octant takes...

*removes*
backup_type is still there, just gotten to in a slightly different way.

A task has an action like 'daily_backup', so when tempo.actions.daily_backup is called, we know its backup type == 'daily', so we pass that along to nova backup.

The impetus for this change was to avoid passing around unnecessary info; cron only needs to know about the task_uuid, everything else will be taken care of later when the queue worker pulls the task object.
Yes, that is correct. I've changed it to 6, to check when a unit-test fails..  didn't changed it back
мені це не подобається. виходить, що тести в StfalconEventBundle залежать від ApplicationDefaultBundle. зроби в behat issue на цю тему і слідкуй за розвитком подій. вони казали, що працюють над цим
напиши комментар до коду
This file can be removed entirely, using the composer autoload file directly
Should the comments in the interface be updated then?
OMG, I didn't check that... I'm glad I post that PR, I'm learning a great deal of stuff !!
let's google now so I can check the diff :)
missing the COMPOSER_ROOT env variable.
is it useful to keep the method in the node ? It will never be used as the builder always uses attributes directly, and I doubt someone builds the node tree without using the builder.
Ok the rationale:

- When you have a min value, you guess a min length of this min (LOW_CONFIDENCE) , lines below
- If this value is a float type, this is wrong so you guess null with MEDIUM_CONFIDENCE to override the previous guess.

Example:
You want a float greater than 5,  4.512313 is valid but length(4.512314) > length(5)
I thought it was a bug, as I explained it in the original issue with the faker command.
I'm not sure I like this for when you are upgrading the ruby version - there will be a portion of time when a previously set rubber profile is blanked out - maybe put this in its own file?
因为这个地方应该是直到正式发行前都不会改，所以以1.0命名版本号。关于版本号，不知道你的意见是怎样来处理？
我个人觉得可以像ubuntu那样分奇偶的，偶数为公开发行的，奇数为测试版的。或者以年份加数字来命名？
`DMSplitView` isn't public (will it ever be?), so does this need to be here?
I noticed that m_iLastRenderBuffer is not set back to -1 after a rederer was flushed.
I'm not a big fan of "wfs" as the name of this routine - it's more like "get_geometries".
$title_prefix and $title_suffix as according to http://drupal.org/update/themes/6/7#title-prefix-suffix
There might be a case made for better naming of the variables of the code, e.g. visible_pages, but I was trying to keep the commit size down.
I found this: http://hackage.haskell.org/package/directory
I guess the better question would be "when is context not the view?" Is it when the view itself has a `content`?
1. prod is default value
2. prod is default symfony2 production env
3. crear_controllers can run only in prod env otherwise its broke deploy
I work on the project and I don't understand the difference between the pages.  They're all just "the homescreen" to me.  If touching the wallpaper allows me to select new wallpaper then I would expect that to work everywhere I can see wallpaper, unless there is some other good reason for it not to.  On the lockscreen, obviously we don't want wallpaper selection.  But everywhere else, why shouldn't wallpaper selection work?

I'm sure this is easy to change, if we decide we want to.

But if we need more discussion, we should really open a bug for that
Humm. In fact if you also create a var notification = this.notification before the function and do var toaster = this.toaster I think you can avoid the self.
This code is actually duplicate. It would be simpler if you pass view and fakeView as arguments of the method
In Spanish, the keypad is "Teclado numérico"
Refresh seems expensive I don't think you want to trigger this repeatedly. ideally you could do this in a single transaction then have an 'oncomplete' callback for the `AlarmList.refresh` call.
+1 looks like there's enough in common to still have something readable.

If the issue was the "reuse" of elements for the `renderNormal` case we can probably make that a param too.
s/Does the event fires event/Does the event fires/
I’m not sure it makes sense to start with a `<h2>` heading in a section. I’m not sure to see the point of the `.block-title` class either… and the `.block-items` class is not self-explanatory to me.

To be perfectly honest, I’m not sure I understand the rationale of this BB. What do we want to do with this? What features should be expressed with such a markup? Shouldn’t we use several BBs for that instead of this 400-line stylesheet?

Calling this BB `lists.css` doesn’t make it possible to apply to all lists we use in Gaia — the Settings app comes to mind (most of its UI is just a list).
@vingtetun is working on it, because main idea is not launching an 'Activity' here anymore.
lol yeah this is a typo thanks!
@stasm feasible, I kinda thought that this modification would only concern the English strings…
Ideally I'd like the timeout management to stay in gecko yes (and I think it is).
Unless @ferjm advice otherwise.
Do you plan to add more stuff in the future? otherwise a if should be enough.
@jmcanterafonseca localStorage does synchronous i/o on the main thread, which is really bad.
Why do not we extract it to a locale file?
eh just in case we end up having other types of .error classes inside of a form.
So I assume you have provision to make that become true when we deploy?
I had trouble with Savon about a year ago with an invalid WSDL file. It was definitely the API vendor's fault, but it was impossible to work around. Of course, it may be easier to do now. Just something to check out before implementing it anywhere.
Keeps the doctor away.
Oh my .. I am used to iterate via while, but can I remove from an STL container via the "for loop" idiom at all then? I'll investigate and recommit.
Hmm, shouldn't it be + 2 only if they're both False, and +1 for the case when one is False?
Whoops, I did forget to change it there...
因为我默认使用OSS保存文件，你的判断本地文件的逻辑就不工作了，所以简单的替换了下。

你看是不是考虑下这种情况？
oops, forgot to un comment this line again .. ;)
They should probably be seperate methods, even if they are called on the same timer.
I assume you mean changing `Thunk` to -1.  That was because `Thunk` wasn't usable with the method spec tests.
That `data.updates.addChange` is flexible in what it allows is a bug.  It should only accept an epoch time, and that's what the docs say.

That said, I'm having second thoughts about using epoch time everywhere, having read more about how to build REST interfaces and specifically how to handle timestamps there.  For the moment, let's leave this as-is?
If you have multiple force schedulers, you need to show *something* to the user. We don't have external/internal names for builders, either ...
Why did you comment these lines?
`.nil?` already only returns `true` or `false`, no need to double ensure it.
learn something new everyday :)
ですよねー ><
```
# ISO-4217 に従い、必要になるたびに足しています
```

というコメントをば。
Try not to use Config::group, replace it by "beginGroup" everywhere
@makasim 

Why do we make a check on this level? I mean when error already happened. The reason, I guess that we can not set it during a chain constructing cuz `newrelic_set_appname` works with global scope and an app name can be redefined in run time. Am I right?
You can just remove the code.  Since we're using git, there's very little reason to actually keep commented code around.
typo, func name is with capital D in Data.

In general, compile with "-Wall -Wextra -Werror"
If you start the server with the option off it wont add usermode +L and it wont check for usermode +L

If you later change the option to on and rehash it will check for usermode +L, but there wont be a usermode +L enabled on the server because the module hasn't been reloaded.

I see why he wants me to change it.
ttyTact is not available on cob3-6. it might be even more confusing.. 
may be it should read "#dsadevicestring: DEVICE"
"trying to"
So some email providers treat certain different strings as the same email address (ie, blahblee@domain.come gets email to  blah.blee@domain.com). We will possibly want to do something like that, and thus would need our code to reflect that (although the change probably wouldn't go in email_unique_on_server---maybe in find_by_email_or_alias, or elsewhere)
Fixed at a8f9d2059538928badcd7d3b1f074c9a65dc1ec2.
no need for before_filter
What about using something like this:

    let sandboxOptions = {
      sandboxPrototype: options.prototype || {},
      wantXrays: options.wantXrays ||false,
      sandboxName: options.name
    }
    if (options.sandbox)
      sandboxOptions.sameGroupAs = sandbox;

Your current code is unecessary complex. The mapping between input options and the sandbox options, and what will be the default value is all but simple to catch. Using same variable name for both is a bad practice.
I think it's better.
Nice docs.
elegantly done
we should add a comment explaining what this line does and why it's necessary.
It's now implicit, and handled by Array.prototype.length
This isn't a very appropriate error - this isn't a missing method, I think, but rather a logical failure in the data structure being build, right?

It also isn't a very actionable message.  It would be much better if it guided the user to what they need to change to fix it, and added some context about where it was.  (eg: nodes must be declared at the top level, not inside a block...)
It is possible that it may break something
I don't see this being used anywhere.  Seems like we don't want a default if the default is to not have JMX enabled.
`undefined` is not a reserved word in JavaScript, so it can be redefined like a normal variable (although that only seems to work in Internet Explorer). This line ensures that any usage of `undefined` in our code (within the scope of this function) will refer to the value of an undefined variable rather than whatever `undefined` might be set to outside of the function.

The first line of the [JQuery source](http://code.jquery.com/jquery-1.8.1.js) is
```javascript
(function( window, undefined ) {
```
for the same reason.
require supported minimal version (5.3.3)
I think that should be optional (suggest) because is only required for certain filters
parenthesis are highly optional
Ugh. Well, I guess you'll live with it longer than me, so sure.
If anything this method should be called `getSelect()`, but I quite like `select()` as it leaves `getSelect()` available for concrete classes to use if they want to.
Global leak:

`for ( var x`
-> `===`
I've suggested that these should actually be available in the admin interface, rather than via the command line only.
Yeah, you have a point. Sadly, IE's before 9 have never heard of such a thing as a getter. I believe this calls for an api change, it would do to just change the getters for regular functions. Do you have a better idea?
This can be done inline if you won't be using it elsewhere. 
 I can't find the backtick on the iPad keyboard so I can't make this code, my apologies. 
title { |n| "Furniture Name #{n}" }
Missing line break after param and before throws
I think it is quite common to do that, and it works in most cases.

There are however events where you should not do that.
no need of the explicit ``getIterator()``
What simplicity is associated with marking these properties as public?
This require_once is not needed anymore since a while when switching the testsuite to use an XML config file instead of a AllTests class. So please remove it
This one should go to `storage_engines.yml` as it only concerns legacy SE
こちらのほうが見やすいかなあ、と。
Instagram 風といいますか。
What do you mean with per resource scope validation?

The bundle already sends the configured `scope` to the authorization endpoint, I think sending it to the access token endpoint too should be no problem, but I'll try to test it.
The list tag is missing from around the list items:
```html
<dd>
  <ul>
    <li> </li>
    <li> </li>
  </ul>
</dd>
```

I am not 100% sure about this -- you might want to wait for confirmation from someone else -- but I think we might want the labels to be done like this:
```ruby
<%= label_tag "work_status_wip", ts("WIP") %>
```

Even if I'm totally wrong there, the label text should be translation strings. Also, if we're going to use "WIP" instead of writing out "Work in Progress" or "In Progress," it should be marked up as an abbreviation to provide title text for anyone who might be unfamiliar with the terminology.
```
<abbr title="<%= ts('Work in Progress') %>"><%= ts("WIP") %></abbr>
```
`it { ... }`とする場合は`subject`を僕は使うようにしています。なぜなら、その方が英文として意味が通るから。`it { munoh.hoge.should ... }` だと文章として不自然。
それをやりたくないのであれば、`it do "..." end` として説明を記述するか、あるいは`it`でなく`specify`を使うべきだと思います。
While you're in here, it would be great if you could remove this whole block at the bottom.  We already have this type of thing solved elsewhere:
1. `_.indexOf(arr, val)`
2. `$.inArray(val, arr)`

If you do that, you'll have to update the native `indexOf` calls on lines 104 and 108 to use either the underscore or jQuery equivalent.
I didnt try it out, but it should be translated eventually to:

'Accept:application/json;version=1'
You're turning the element into a jquery element 3 times. 
Consider something like this
```javascript
$element = $(this);
var format = $element.attr('...
```
Maybe: To increase readability, make a separate function of the code ti find the next lower number.
- form api table to include in solution packs admin pages.
Do you mean moving them in the trade slots? I think I removed this originally because I thought it was doing the same thing twice. Add to _Offered and copy that to MyOfferedItems. 

I was unaware that it was required to get that method to work.
In the _very unlikely case_  that Steam would allow that, we can change it. There is no sign for that though.
This shouldn't be removed, as this is in the "dependenciesManagement" section (which we can think of as defaults for modules that declare the dependency with the "groupId" and "artifactId". It should also probably use a scope of "provided" (meaning that if people want to use it, they have to explicitly add the MongoDB driver to the classpath, and we'd just find it and use it; but anyone not using the MongoDB BinaryStore won't require the MongoDB driver on the classpath).
This is the string that's in the URL of TuneIn, ours is `s174185`, for example.
I see... Too bad they cannot be removed now :\
Как вы это делаете?)) fixed
As mentioned in the other test, please change Adblock Plus to Memchaser or Nightly Tester Tools
I just said findall as an example, use the re method that suits better the issue :D
Hmm it looks like actually it will always be `==`. I'll fix that.
Actually, does this take into account that profile section for private users cannot be retrieved ?
A test should be written for the access check as well, and should have at least the following:

1) Comment as manager on (private) piece of content (--> success)
2) Comment as member on (private) piece of content (--> success)
3) Comment as logged in user on private piece of content (--> fail)
4) Comment as anonymous on private piece of content (--> fail)
5) Comment as logged in user on logged in piece of content (--> success)
6) Comment as anonymous user on logged in piece of content (--> fail)
7) Comment as logged in user on public content (--> success)
8) Comment as anonymous user on public content (--> fail)
P.S.: Please create an issue for it if you don't have time in this sprint.
Maybe also test  `p.choices.filter(...)` to demonstrate that the `RelationshipInstance` is wired like other Django managers?
Drupal will only be using Symfony 2.2+, and that code was only there for 2.1 compatibility, so it should be fine on our end.
will drop following empty line
We have a `production` remote that is different from Heroku production on one project. May be a project-specific problem but I think the `--app` flag is more foolproof.
Why is it  string?
Seems you have some spacing problems...?
нет проверки на повторные символы. то есть, randomNucleotide может заменить A на А и т.д. В описании проекта это прямо не указано, но символы при замене не должны повторяться.
...вот я и боюсь, что среди мусора не найдется случайно единица. поэтому пробегаюсь по массиву и явно устанавливаю значения либо в NO, либо в YES.
Уверен, в курсе еще будет про это, не беспокойтесь. :) Кстати, я имел в виду не "потоки", а "потоковость", что ли... В общем, в свойстве можно сделать переменную подготовленной для работы с несколькими потоками. 

Просматривая различные варианты, вы могли видеть следующий вариант: 

@property (nonatomic,readonly) NSMutableArray *DNA;

nonatomic - без потоков 
readonly - только для чтения (т.е. автоматически создается только геттер)

weak, strong - тип "владения" переменной (слабые и жесткие ссылки), об этом мы по-любому будем говорить, когда затронем работу памяти. 

В общем, "оставайтесь с нами", все самое интересное еще впереди! ;)
--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
Согласен, обоснованное замечание!
этот же массив используется в функции `init`. Имеет смысл вынести его в отдельный член или метод класса.
Зачем? =)
I don't see the logic in this honestly, seems like you set the id and data of the target block, after overrideBlock is called, that makes overrideBlock rather useless...
"Set a lifespan of file cache in localStorage in hours" ?
We don't write out error codes for any of the other functions, so I'm not sure we want to do it here either. The code is returned to JavaScript, so the caller can always display errors if needed.
The contact handler has no associated form yet, as far as i can remember

P.s. I am mostly offline this week. Talk to you next week

Von meinem iPhone gesendet

Am 01.08.2012 um 02:43 schrieb Rodrigo Augosto<reply@reply.github.com>:

>> @@ -11,7 +11,7 @@
>>         };
>>     </script>
>> 
>> -    <form id="form_reset_password" action="{{ action|safe }}" method="post" class="well form-horizontal">
>> +    <form id="form_reset_password" action="{{ url|safe }}" method="post" class="well form-horizontal">
>>         <fieldset>
>>             <div class="control-group">
> 
> why it does not has {{ form.csrf_token }} ???
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/coto/gae-boilerplate/pull/104/files#r1278967
This should be True
I'm not a fan of the `assign` here, since it implies that the queue isn't properly memory managed.
What if the queue-specific data was set before each block, and cleared after each one, and retained the scheduler?

If we assume only serial queues (like I suggested in my top-level comment), that seems like it should work.
And then flip the statements.
does it have to be specified as a time index?
I guess you've seen the PR now.
This needs to be removed/replaced with an actual call to updateConceptIndexes() as per my comment one line above.
Good idea...I shall fix everywhere.
btw, why creating all these FileResource instances outside of the ``isFresh()`` check ? it means you are doing extra work when the cache is fresh (and so resources don't need to be recreated). And in prod, the cache will be fresh most of the time (as your resources will generally not change until you deploy a change)
I guess `SecurityContextInterface` would be even better :)
Well, I don't really like it too. But it is used in the Symfony core code everywhere, for instance: [BrowserKit\History](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/BrowserKit/History.php#L104), [HttpKernel\HttpKernel](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/HttpKernel.php#L144), [Routing\Route](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Routing/Route.php#L101) and [FrameworkBundle\EventListener\SessionListener](https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/EventListener/SessionListener.php#L43).

It seems less natural, but it is more consistent with the way assertion in PHPunit work:

    $this->assertEquals('expected', 'input');
    // if statements
    if ('expected' == 'input')

    // inconsistent
    $this->assertEquals('expected', 'input');
    if ('input' == 'expected')
Thanks. Fixed in 13e1335.
you can use int_tested here
Let's specify the formats as Enums for type safety.  The Enums can know more about themselves as well.
I've replaced the `select` method for the `@turns` with an `each` because now in each turn the ranking for the move is different.
Why even spawn this?
This assertion should log the object that failed.
Nyt vain teet tämän a-seq kaikille alkiolle.
Might be useful to explain how to use the method to jump into the first element. That would be jumpToIndex(1), right? 

And what about to jump to the last one? jumpToIndex(size()) ?
as per the javadoc it does 2 things: decides when to rebalance *and* manages membership status. Wouldn't it make more sense to move the membership management to the ClusterTopologyManager class(or elsewhere) and leave RebalancePolicy to only be concerned with "deciding when to rebalance". My main reason for suggesting this is that I think that "deciding when to rebalance" is an extension point for NBST, whilst membership status management is "fixed". Now if one decides to implement its own RebalancePolicy, then it would need to also duplicate (and understand) the membership status management logic, which is unnecessary.