labofsahil/github-event-dataset-2012 huggingface dataset:
Expose editing of version info and deletion of versions

Preliminary code review.
Interestingly, the call to deleteVersions seems to fail every time.  This seems like a server-side issue though.
Maguro props for Mr1 staging
Add locale brazilian portuguese (pt-BR.yml)
Implemented more functions in Servos module

(-fixed indentation issue in sample.hpp)
-implementation of setControlP/getMotorForceFeedback/setForce/setVelocity
-Function setForce is not finished.
-Functions setControlP and setVelocity : the coefficients have to bee verified (this will be done in the second calibration part).
Random number generator calls added.
Show Resource Amounts in Production Overview

This Pull Request fixes #1211. 
It now shows a marker on the fillbar of the input resources at the amount that is needed to produce something. 
It also shows the amount of needed input resources to produce a amount of output resources. 

See: 
![ ](https://a248.e.akamai.net/camo.github.com/f2e77bb34f85ac4ce797b39c65bc39a525a65056/687474703a2f2f692e696d6775722e636f6d2f34696374422e706e67253544)
Post updates

- Updated base prototype
- Changed the way dates are handled
Update source/index.md

update website url.
Not really a step …

… but some general CSS/tpl cleanup including (hopefully) resolving a weird merge conflict. Keep your fingers crossed.
Make it possible to embed in root for sideloading without including asso...

...ciation key
Replaceing old pull request.  It got merged by accident and I reverted it.

Same stuff, fixed up CIB's complaint.
Make print_tty work on both black and white backgrounds. Fixes #4
MINOR: fixed example and cleaned up the code
contest parameter added
Merge Some My Practice

salam ostad ...
man ye bakhshi az tamrin hamo pull request kardam , age moshkeli too kodhash nadare lotfan merge konin..
.tanx.
Use TmhOAuth namespace and config array for constructor args

BC break. Using a config array here instead of consumer key/secret params, as it's more flexible to support additional options.
Update for Burn boostrapper
LPS-25605

Hi Jorge,

As we discussed I added the possibility to display the ORGANIZATION_OWNER role under organization roles even if the user is not a member of said organization. I also allowed the "remove" link for the user so he/she can drop his/her ownership. It is still not possible to add this role without becoming a member of the organization. Let's talk about it if we want to have that too...

However now we need to do something with the organizations list because if the user is a member of an organization, any newly created organization will not show up in the list (as he/she is not a member by default)!

Zs.
Add more options to fixwallet, allowing partial recovery.

This recovered my wallet when I just skipped recovery of settings.
Update for the two missing images

Stolen from toby
Fixed all database objects. Also added new Counter object for counterpicks
Working branch

Check this out
Patch 2

DD
Minor refactoring

Did some minor refactoring. Appreciated or not ? either way please let me know.
Stop using own `now` function in migrations but rely on upstream fix (South tip)

See https://bitbucket.org/andrewgodwin/south/pull-request/26/handle-old-migrations-gracefully for more details.
Updated README

Using the current version of get-post to fetch the Cakefile gives a result full of newlines. I think it's because get-post is expecting JSON...

"fs            = require 'fs'\n{print}       = require 'util'\n{spawn, exec} = require 'child_process'\n\n# ANSI Terminal Colors\nbold = '\\033[0;1m'\ngreen = '\\033[0;32m'\nreset = '\\033[0m'\nred = '\\033[0;31m'\n\nlog = (message, color, explanation) ->\n  console.log color + message + reset + ' ' + (explanation or '')\n\nbuild = (watch, callback) ->\n  if typeof watch is 'function'\n    callback = watch\n    watch = false\n  options = ['-c', '-o', 'lib', 'src']\n  options.unshift '-w' if watch\n\n  coffee = spawn 'coffee', options\n  coffee.stdout.on 'data', (data) -> print data.toString()\n  coffee.stderr.on 'data', (data) -> log data.toString(), red\n  coffee.on 'exit', (status) -> callback?() if status is 0\n\nspec = (callback) ->\n  options = ['spec', '--coffee']\n  spec = spawn 'jasmine-node', options\n  spec.stdout.on 'data', (data) -> print data.toString()\n  spec.stderr.on 'data', (data) -> log data.toString(), red\n  spec.on 'exit', (status) -> callback?() if status is 0\n\n\ntask 'docs', 'Generate annotated source code with Docco', ->\n  fs.readdir 'src', (err, contents) ->\n    files = (\"src/#{file}\" for file in contents when /\\.coffee$/.test file)\n    docco = spawn 'docco', files\n    docco.stdout.on 'data', (data) -> print data.toString()\n    docco.stderr.on 'data', (data) -> log data.toString(), red\n    docco.on 'exit', (status) -> callback?() if status is 0\n\n\ntask 'build', ->\n  build -> log \":)\", green\n\ntask 'spec', 'Run Jasmine-Node', ->\n  build -> spec -> log \":)\", green\n"
Updated Verizon Pre2 and Preplus test-scripts (related to Verizon Apps only) no other changes...

...removed audio volume control (only for EU markets)...
Add barclamp requires and membership [1/11]

This push adds barclamp.members and barclamp.prereqs to the 
barclamp model.

The import routine has been updated to correctly populate this data

This required me to reorder the migrations because the order
matters - you cannot import a barclamp if you have not already
imported it's prerequists.

Also, added Docs on some internal Dell stuff thats not on github.


 ...0120801015047_barclamp_import_nova_dashboard.rb |   24 --------------------
 ...0120802042000_barclamp_import_nova_dashboard.rb |   24 ++++++++++++++++++++
 2 files changed, 24 insertions(+), 24 deletions(-)
[TIMOB-6374] Updated Module Template

"exampleProp" setter corrected to be prefixed with "set" so that it no longer hides the getter.
[TIMOB-7347] Using getters instead of dynaprops to avoid error message from Kroll Layer when trying to remember


__Testing Instructions:__

Run KitchenSink for the following tests
     Base UI > Views > Scroll Views > Scrolling Zoom+Pinch
     Base UI > Views > Scroll Views > Scrolling Drag Start&E
     Base UI> Views> Scroll Views>Basic:
     Base UI> Views> Scroll Views>Scrolling tabs:

Additional test for sanity:

Test the following [app.js](https://gist.github.com/1713839) file :
     Check log to see if you can see type of content Offset to be TiPoint and the values being returned properly.
Small changes

- Typo "Wienberg" on English website fixed.
- Small German captions improvements.
zh_CN Translation
Seeds refactor

I think it's better have only table creates into migrations, and move all the data insert into seeds.rb. Also, all the non-required data (such as example pages) should be in a different file. I created a new task, ry:example, to import data from that file.
Added RVM cap
updates for supporting Security Identity Server
RC-3: Add service method to search for similar persons and patients

Performance needs to be tested at some point. Also needs squashing commits and updating to the latest before merging. I'll do it after the review.
Fixed your bugs

I fixed those two bugs. You should pull.
Set the LANG var to support non US-ASCII chars

This it the same as the ruby buildpack.

Ref: https://support.heroku.com/tickets/42300?col=24470182&page=1
Fixed last two failing tests
GPDATABASEMIGRATION-43

allow updateOnStart to optionally drop all tables before running migrations scripts
Issue 35

Hi Jordan,

This isn't a 'done' request. I think I've made some decent progress. Can you take a look at the code to see how well I'm doing? 

There are a couple issues at this point:

1. I don't have tests yet.
2. Somehow 'app/views/comment_mailer/comment_made.html.erb' doesn't seem to recognize the @body var. I've spent a lot of time trying to figure it out with no luck. I might be doing something completely nonsense.

Anyway, please give me some feedback so I can head down the right direction.

Thanks,
Jingjing
Fix for issue #23

Remove IE9 hack in forms.less line 89 which breaks the asset precompiler and use the proper mixin instead
User Management - Demo 2

 portal/controlpanel/organizations/usecase/demo1
Set permissions by install

Set permission for user status by install for each registered users.

Two choices:
1. Group permissions
2. User roles
MIT License

Thanks for the quick response on your blog forum.  Very cool of you!  I wasn't sure if you have a specific format that you prefer for the license so I thought I woud give it a try in the hope that it may save you some time.  Of course, I'm happy to change it if you want. Keep up the awesome work!
Фича для скрытия ответов на скрытые посты

http://iichan.hk/b/res/2355532.html#2409708
Using File::Temp tmpnam() for dbname in tests

Using core module File::Temp tmpnam() to genereate a name to use for the
test database. This allows the test to work in Linux and Windows (which
does not have a /tmp directory)
Update bits and pieces for Mali R3P0
Removing more DEVICE_PREFIX

Change-Id: I0466367667682cc846c8517f60758cb39ec7ac0a
Adding support for the XWKJ2 firmware, similar to the XWKI4
Inserted .DS_Store in .gitignore for those programing on the Mac
Onebusaway nyc app mods merge

... in comments.
Title updated

Title updated
[Public Key Security Vulnerability and Mitigation](https://github.com/blog/1068-public-key-security-vulnerability-and-mitigation)
There shouldn't be any issues on a subclass of another resource.  Take a look at any of the children of `Chef::Resource::File` or `Chef::Resource::Directory`.
怎么又恢复到以前的代码了？
Did you actually test this in IE before making this change?  The `nodes` arguments are actually instances of Dojo's `NodeList`, which has its own `forEach`.
I have a branch with that too (before writing my own client) but I'm hesitant to land that. It seems really corporate :/
I know it blocks the thread, but it blocks its own thread that is only for the timer, not for query processing. That is why every query  that manager processes has its own timer. So manager will create one thread for every query for every webservice and one thread for timer. Next step i wanted to try to release the sleeping thread in case when all results are returned sooner. I will try other approaches you suggested. But this works :-D
?!! lastMap always =0. no value assignment.
Did more in 6f79200.
We wanted to expose them all, just in case that some other code somewhere wants to get just a binaryimage or something similar.
Well of course is different than the other implementations. :)
My idea is to provide a strong support to handle Capture points events, world states, custom (missing) spell handling and conditional DB scripting.
With this stuff, all the pvp scripts around can simply go to some easy event script DB queries. This can also apply to battlegrounds and Wintergrasp.
This commit doesn't fix the condition that the Scheduler is so busy that no thread can idle for a while, and causes epoll hanging, because working threads tickles frequently but no thread enters idle to read the tickles.
`hb, handlebars` are missing from `text_extensions` in the generated config.yaml.
added long click on channel list, to select stream
Ähm, wie kommst du denn von "Lightweight Markup Language" auf "LuMicuLa"?
On Fri, Jan 20, 2012 at 6:56 AM, Patrick Lucas <
reply@reply.github.com
> wrote:

> This should be in examples/Felix.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/skaller/zguide/commit/43efe0b2c14972fd8e0d5e890c0dc19e58e0de56#commitcomment-883443
>

Ooops .. fixed!
perhaps we should consider a more intelligent way of doing this, are users going to scroll through all the reminders they have sent to be sure.

I would rather find a way of checking for similar content sent today to same recipients and alert them
This error message was very helpful to me. :-D
perhaps use the same function above, in the forEach?
he writes that:

 it does not function
    and
 the solution also solves the fury warrior powers

Looked at paralysis or archangel?
i accept contributions agreement
I believe there's already an enhancement ticket to allow specifying the parent field, so this is a good idea.
http://pastebin.com/Y7fDE7EA
все правильно, нету краша. только потом неснятые ауры control_vehicle накопятся в количестве *цать экземпляров и юнит рухнет в _UpdateSpells
I did not try yet. Using the same old version.
1. что то совсем сломалось форматирование
2. здесь используется ответ в формате js - он используется только в этом методе, а значит желательно вверху указать что формат js бдует использоваться только для этого action
неужели это дает какой-то эффект? убери эту шляпу вообще отсюда
Respone team?
Next: Implement command line arguments.
    python connect_four.py [column_length] [row_length]
Ok I'm on it :)

The best place is like host/service alias and address missing property : in the is_correct pass, so if it's not, we can just set it.
Well done! And a quick issue right now:
http://www.webpagescreenshot.info/i/308771-2212012111224pm.png
As you can see, my access level is `Reporter`, so I was able to create wiki index page but now I can't delete this. Any suggestions, why?
to short, too
"stellt", but is ok you don't have to change this ;-)
Remove this comment please :)
If those were 3 seperate tests you get 2 more points in the jenkins cigame :)
OK, but using -DGTEST_HAS_PTHREAD=0 also doesn't hurt, so I compile with this define.
Curious about this, do you not have sockaddr_storage or is the way I was using it wrong?  Did the compiler complain about something?  I ask because I want to use it again elsewhere.
rofl code
No It was suppose to be "Finally, Jungle trees are fixed!! YAY!!" + SMILY_FACE
What about:
    if (m_navMesh->getTileAt(tx, ty))
        return (m_navMesh->getTileAt(tx, ty));
And is it really in this function? According to crash logs?
Ack. To note though that only the filename was being asciified, not the watermark. I'll remove this.

Q: How do we convert from the text field GetValue text to a) a value good for PDF watermark, b) a value good for filename. Would just using the value +  try/except + error be a good enough solution?
might want to get rid of this?
The last and final one to remove...
Note: lists:delete remove the first instance of a element in the list not necessary the "selected" element
@Rüdiger zu Dohna: I thought I had removed all the lower case 
readme.html files. Apparently I missed 
the*kitchensink-html5-mobile/readme.html*. Are there any others that 
you're aware of?


On 02/09/2012 03:15 AM, Rüdiger zu Dohna wrote:
> @sgilda now there's a readme.html and a README.html, which is irritating for Windows and Mac users, as directly after a checkout, the code seems changed (one file overwrites the other). Taking a look at the files, it seems that this was by accident and you intended to delete readme.html
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jbossas/quickstart/commit/087c9c4551568c798b280e87f7249b4621387de4#commitcomment-948560
For some reason, all my builds were crashing, but only when my device was not connected to the internet (meaning something was wrong with the cache-updating and talking to the database). i commented out the db.close in the onCreate handler, and it seems to be working fine now.

I think we might not understand what the DatabaseHandler is. I was under the assumption that this is the actual database's "onCreate" function itself, but now I'm led to believe it might not be, and is only the interfacing adapter. We should probably look into this more. If it is the case that this is only the handler and not the actual database itself, it may make more sense to move the CREATE SQL statements to its own. I'm not sure though.

The fact that I left the db.Close() intact on the recreateTable SQLs and it ran fine might confirm my suspicion on this.

In the meantime, I'm gonna comment out the db.close in the onCreate function, we'll see how it plays out.
We currently don't clear the sandbox at all between detection with different translators, or between detection and translation. While we could, it would increase detect overhead by a factor of 3 as things are currently coded now, which might be noticeable on pages with lots of iframes. (It adds up to about 81 ms on Amazon.com on my machine.) We could potentially mitigate this by speeding up sandbox construction, merging the 4 translators that run on every page into 1, or by breaking getTranslatorObject() in the translators where it's used without exports.
Fixed in def0da41237aa8239488a0cefc9ee87443ff2cb1.
Do you really want that file in our repo?
I think there are many people interested in testing file uploads in Opera Browser. Due to this patch they can do that on Windows. Please, add these changesets into the main upstream.
Your Linux distro may already have the "posterazor" package, usually the old fltk version.

If you want to build it yourself, I suggest using the Qt version (master branch), since it is the more recent one and has nicer UI.
What exactly was the error when compiling?
use is_null?
Updated this request with the suggestion, without options.  Can add options if needed.  I'm not 100% familiar with where I might place or name a helper that I could get to from both signed_in and signed_out locations, but open for suggestions.
Needs more Haskell
This is fascinating! I wouldn't know of a project where someone actually went this far to get the testing right :) . Definitely worth a write–up, I'd say. 4) Sounds great, but I'm a bit afraid how slow it would be?
Hence, 3): I thought (but I'm not sure) it could like this:

* test generators functionality
* test that generated file matches fixture
* test fixture with Jasmine (now that we know that it's what the generator will output) 

Yep, let's continue on skype.
I see. Still exciting.
Just run the tests...
Technically you could simulate that with something like this:

t = floor(t / c), where c is some constant

Then t would only increment once every c seconds. Actually, t = floor(t)
would probably work fine then because you wouldn't want it much slower than
one frame per second. Of course, this wouldn't actually change the
framerate, but it would make it look like the framerate was only 1/c frames
per second.

On Wed, Mar 7, 2012 at 2:30 PM, Nicholas Bardy <
reply@reply.github.com
> wrote:

> The thing I don't like about this way is that you remove to ability to
> slow it down to be a step by step with a real low framerate.
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/butchler/PixelMapper/commit/bd83cd7ba6e3e5381ce39cf870d0183410374360#commitcomment-1055161
>
If we have homebrew and macvim as dependencies it seems reasonable to require that macvim be installed by homebrew. Otherwise we could take the app path as a parameter when we rake and have it as a shell variable in .zshrc or similar. This could be on the readme that we will automatically use the one homebrew installed and fall back to ~/Applications and prompt the user to abort or provide a path or just go ahead and fix it in the .zshrc later.
Весь этот коан также требует исправления.
I agree, I think it's a good idea to make the naming simpler.
important for ubuntu: therubyracer must be activated!
「示す」と「:class:」のあいだに半角スペースをいれていただけますか？
Yepp I get errors now!
What is this for? 

On Jan 5, 2012, at 10:46 AM, Mustafa Khattab wrote:

> yo ritchie!
> I used to have almost the same code here. But decided it was probably easier to execute a shell command that returns the path of the executable rather than harding coding it in.
> 
> [check it out](https://github.com/mkhattab/emacs/blob/master/mustafa-util-func.el). I'm not sure if it's safe or the proper way, but who cares.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/malloc82/Emacs-Config/commit/256ad5291cd64133bc17e61b4a3e450ac8dae1c7#commitcomment-841231
I don't have a problem with this. vstone?
Ok. It's all done for the `neo4j-<edition>`. All of the gems ensure the same jars version.

So only things left to do are:

- kill of the global `NEO_VERSION` const here
- `Neo4j::Community::NEO_VERSION` into neo4j.rb.
No problem, create a new folder in i18n with slovack language (?)  and translate there. 
BR
So I think `<p>` must be put back on the whilelist or turn off TinyMCE HTML validation (bad option?). Any other options?
oh, indeed!
Bandeira: nasty... compiling things at runtime in production won't get us far when in need of performance. Take a look on why we're having troubles with assets compilation on heroku and remove this line :-).

Works for now!
I guess it comes down to who the typical logging user is and what they expect.
I have been presuming a user is expecting the logging behavior they would get if logback were not present.
However, even that behavior is not completely predictable; the presence of isLoggable() must be made explicitly.
For myself I will be using the logback configuration file exclusively so this change is sufficient for me.
If it bother some other developer then they can reopen the issue.
Thanks
Just pop array('127.0.0.1') into the default value (& on 108)

and then a paragraph to the installation explaining that if they are having problems running on anything other than local check the allowed_ips value
Looks good overall, see my comment above
original autor is https://github.com/Left4Info/TrinityCore/network
because of we go to drop EventAI from system you don't go to see any EventAI script added to core.
@stof what about the CS ?
Yes, but there was no way on github to comment on a specific line that wasn't included in a commit so I used the blame feature to find the one where it was commited and added it there.
use %s otherwise Strings are being created here unnecessarily
To konto stworzylem do prezentacji, zeby pokazac jak sie uzywa gita, push pull, fetch tworzenie remote branchy itp. Btw na niej sklonowalismy jeden z twoich projektow:)
уже прокомментировал выше: повторение кода, невалидный HTML
@vincentfretin yep, that line looks wrong. This whole code is likely buggy - at least in the two migrations I did, I ran a full "reindex index" on the object_provides index instead.
Consequence was that we could not run tests with Selenium, but only with phantomjs, right?
Hey Alec

thanks for the detailed feedback! Just curious, what was the total
available points for this?

On Tue, Feb 7, 2012 at 3:21 AM, Alec Goebel
<reply@reply.github.com>
wrote:
> Homework 3
> ==========================
> | **Part**  | **Points** |
> |-----------|------------|
> | base      |  1 |
> | advanced  |  0.75 |
> | clean code     |  0.25 |
> | if statements | 0.25 |
> | **Total** |          2.25 |
>
> ## prissybot.py
> Well done.  You covered the entire assignment and added if statements.   Also, I'm glad someone figured out `time.sleep`.
>
> The only issue is you didn't implement step 1 exactly, which would have forced you to do string manipulation to create the input prompt.  Here's what step one should have looked like:
>
> ```python
> name = raw_input("Enter your name: ")
> print ""
> print "PrissyBot:  Hello there, %s!" % name
> resp = raw_input("%s: " % name)
> print 'PrissyBot:  You mean, "%s, sir"!' % resp
> ```
>
> Finally, just a reminder, commas only work with print statements and they add a space
>
> ```python
>>>> print 1, 3, 5
> 1 3 5
> ```
>
> ## AsciiArt.py:
> Not a bad example of ascii art.  Your variable names made it a bit hard to follow, like using `s` and `s1`.  Also, as a rule you don't use empty print statments, use `print ""` instead to print and empty line.
>
> ## fractions.py:
> Well done on this.  Obviously we hadn't gone over if statements yet but this is definitely a good use of them.  Also, thank you for checking for the divide by zero error.
>
> I only have a few comments (not criticisms) about this file.  Your input phrases could be consistent but that is just a design choice.  Also, since you use commas there are a lot of excess spaces in your output.  By using string formating you could be:
>
> ```python
> # what you have
>>>> print t," ",n,"/",d
> 1   2 / 4
>
> # cleaner
>>>> print "%d %d/%d" % (t, n, d)
> 1 2/4
> ```
>
> Also, in python if statements you don't need to wrap the conditionals in parentheses.
>
> ```python
> # not needed
> if (a == b):
>    pass
>
> # cleaner
> if a == b:
>    pass
> ````
>
> ## numberConversionsTable.py:
> Well done on this program as well.  Your code is well formatted and clean.  I can nitpick at the little things but overall really well done.  One thing I noticed in this file and others is how you parse integers.  You can write this as one statement instead.  For example:
>
> ```python
> # two lines
> n = raw_input("Enter a number: ")
> n = int(n)
>
> # one line
> n = int(raw_input("Enter a number: "))
> ```
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/habahut/CS112-Spring2012/commit/fedf66aa29c7a894ac8b5d8b19ec8dfc0793f259#commitcomment-939883
This does not limit to 3.1.

`~> 3.0` means `>= 3.0 && <= 3.x`, where x can be anything.
So this dependency means "any version, in 3.x."
> Maybe Clear button is not perfect for this context but maybe is OK in the meanwhile http://openclipart.org/detail/32329

The Clear button is already used for project revert...

> There are some unneeded icons with very low frequent access

I think at least "show title" and "full screen" should be removed.
# Homework 3

| **Part**  | **Points** |
|-----------|------------|
| base      |  1 |
| advanced  |  0 |
| **Total** |  1 |

Well done overall.  The only piece you missed was implementing step one *exactly* as it was written.  However, the rest of your code makes up for this and you did use strings in your raw_inputs.

The only comment I have about your code is that you are putting a space between your functions (`int`, `float`, etc) and the parentheses:

```python
# bad
int (n)

# good
int(n)
```

Anyways, here is the step one code.

```python
# Step 1
name = raw_input("Enter your name: ")
print ""
print "PrissyBot:  Hello there, " + name + "!"
resp = raw_input(name + ":")
print "PrissyBot: You mean, \"" + resp + ", sir!\""
```
As @amueller pointed out, this must be done only when `len(y.shape) == 1`.
МОжно сделать так:

text = begin
тряляля
rescue
траляля
end
je pense pas mais faut en faire un de toute facon

2012/2/11 Puddi Puddi ! <
reply@reply.github.com
>

> on aura pas un rapport  rendre  la fin du projet ?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/OlivierB/Polyjoule_siteWeb/commit/5d14503993efcb5aef35a2e8679dddd52db2c448#commitcomment-956678
>
oops, bad edit, ignore this pull request
actually there's a method we should use instead: 
template = if exception.pending_fixed?
Why offset rather than totalLength?
It worked, but you have to write code in the post template to make it actually do anything with the data.
はい、おめでとうございます。
Hey Andrew, is the second part of this logic backwards? Shouldn't we be removing the account only if it *is* universal?
They should be the same: yes. They should have different parents: no.

Here's a full example of what I'm talking about:

`values/themes.xml`

```xml
<style name="Theme.ActionBar.InternalBase" parent="@android:style/Theme"></style>
<style name="Theme.ActionBar.InternalBase.Light" parent="@android:style/Theme.Light"></style>

<style name="Theme.ActionBar" parent="Theme.ActionBar.InternalBase">
   <!-- THEME CONTENT -->
</style>

<style name="Widget.OtherCrap"></style>
<!-- etc... -->
```

`values-v11/themes.xml`

```xml
<style name="Theme.ActionBar.InternalBase" parent="@android:style/Theme.Holo"></style>
<style name="Theme.ActionBar.InternalBase.Light" parent="@android:style/Theme.Holo.Light"></style>
```
Thanks David. Sounds reasonable.
Mark, I couldn't merge this because of some futzing around I was doing with labels.  I made another commit with this exact change and referenced you in the comments.  Thanks.
oh, i confirm it can build with ics source.
i've compiled it. but not yet test it
is this fileman fully working on ics? if yes we should use this
I tried that yesterday.. will try again

also I tried compiling and what ever I do vendor/qcom doesn't get 
compiled... I have all the flags set..

I do't get those libOMX files at all in the end of compilation

any suggestion??

On 02/23/2012 05:42 PM, 0002647302 wrote:
> Removing the audio ifdef. The one you claimed fixed it.
> On Feb 23, 2012 11:34 AM, "LorD ClockaN"<
> reply@reply.github.com>
> wrote:
>
>> so you are telling me that you have working mic with new drivers??
>> you remember what commit fixed it?
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>>
>> https://github.com/TwistedPlayground/android_frameworks_base/commit/830100747ee6630fbedfda77c83e132d9fd90c81#commitcomment-1003173
>>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/TwistedPlayground/android_frameworks_base/commit/830100747ee6630fbedfda77c83e132d9fd90c81#commitcomment-1003232
>
here and in the method above NPE might be thrown if propertyValue is not initialized. And this situation is possible since we have empty public constructor ( I'm not sure why we need )
Removed my changes to .travis.yml, sorry about that.
@ericf and I discussed this before, and we decided that `Y.CacheOffline` had too much overhead and not all of the parts in it would be needed for `ModelSync.Local`, so just a quick re-implementation of the core portion of it would be fine.  Any thoughts on your side?
Also, we don't have to use "propertyVisible" in property scheme. I think only "visible" can do the job
yeah, I thought about it too, but jquery.wikia.js contains too many global functions in there already.  To be safe, I just wanted to make it come after so Wikia.somefunction is not overwritten by something in jquery.wikia.js accidently
Why not Protobuf?
Oops, indeed. Sorry, improve the docs!
Might also help in cases of overflow etc
val NATFirewallAddresses = getStringList("akka.remote.nat-firewall-addresses").asScala.toSet
I don't think you'll need this
I think this is erronous usage of @implicitNotFound
`nodes` should probably be called `nodeMetrics` or `metrics` here?
Why the watch?
why not set id directly?
Tabbing on the above three lines is off.   They should be four spaces to the left/
Same thing as above (with `get_dip`).
try to avoid these from ckan... import ... as they make it hard to unpick circular references.  It is always better to do a 

    import ckan.module as module
    
    module.function()
Good suggestion. I've reverted the changes to Layout.cs and DockLayout.cs for now. The rest of the changes should be good to go. Cheers,
We can split it out, but it is small, so I think either keep it or toss it, but don't make a separate branch for it?
I wonder why tests were not breaking for this.

Fixed.
Any better, safer way to avoid race condition than to sleep for an arbitrary amount of time?
It's used in MRY 

MryResource.scala
=====
scn.getNextSequence(sequenceName, (scnId, optException) => {
        request.checkError(optException)

        val key = keyPrefix + scnId.toString

        newObj += (keyName -> key)

        insert(key, newObj, callback)
      })
I'm pondering if GetFileName shouldn't take care of this... might bring major pain thou.
Why do you need this if GetArtist() also returns m_strArtist after these changes?
Hmm, this saves the filtered list, not the unfiltered?
Code ported from ...?
Self refactor. Simply a more correct way to get the app icon.
these tags have nothing to do in the license header. Their location is the phpdoc of the class
I'm not sure what happened here and whether it was intentional, but nearly the entirety of the rest of the aqsis codebase has the public: indented one level, and the methods indented again from that - please just leave this as it was.
Please change to LogCvmfs instead of C++ streams
+1, fix in 0ac7aad
= = ..... 除了这个是后来改的以外其它那几个 `_` 开头的是太小的函数....... (没加插件名字作前缀而用_开头其实是为了复制粘贴方便................. :P )
The reason was for system-wide directory (user==FALSE), installer puts snippets.conf into prefix even if user has been using autocomplete.conf before, unlike where in ~ user has manually copied in a snippets.conf if she wish to use it first.
A better name for this (like `selectable`) would be nice.
Unnecessary change, please undo.
Wait, are you telling me that users of the C# bindings will have to remember to explicitly load libpdcsharp.dll before they call any methods in libpd, and that there's no way to do this in a platform-independent way?
require constants.
I'd keep the beginning and omit everything after 'API'. The examples have an insider flavor.
Please add spaces around the "=" as well.
should this be ``method.lower() in correction_types``?
это о чем? коммент не к той ветке привязался, видимо
Will remove

Sent from my iPhone

On 12 במאי 2012, at 17:13, Rafael Mendonça França<reply@reply.github.com> wrote:

>> @@ -259,16 +259,47 @@ def word_wrap(text, *args)
>>       #   simple_format("<span>I'm allowed!</span> It's true.", {}, :sanitize => false)
>>       #   # => "<p><span>I'm allowed!</span> It's true.</p>"
>>       def simple_format(text, html_options={}, options={})
>> -        text = '' if text.nil?
>> -        text = text.dup
>> -        start_tag = tag('p', html_options, true)
>> -        text = sanitize(text) unless options[:sanitize] == false
>> -        text = text.to_str
>> -        text.gsub!(/\r\n?/, "\n")                    # \r\n and \r -> \n
>> -        text.gsub!(/\n\n+/, "</p>\n\n#{start_tag}")  # 2+ newline  -> paragraph
>> -        text.gsub!(/([^\n]\n)(?=[^\n])/, '\1<br />') # 1 newline   -> br
>> -        text.insert 0, start_tag
>> -        text.html_safe.safe_concat("</p>")
>> +        paragraphs = paragraph_split(text)
>> +
>> +        if paragraphs.empty?
>> +          content_tag('p', '', html_options).html_safe
> 
> `content_tag` always returns a html safe string. You don't need to call it again.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/rails/rails/pull/6273/files#r812380
You forgot adding your name :smile:
I like it. I'll update it.
Please don't use `elsif existing_record = begin`. Could you break it apart?
Hm, we'd be creating extra arrays anyway to generate a final hash, will end up being the same as the current `hash.merge` I think. I can rollback or use your change if that's not a problem :)
wrong, indentation
[EventEmitter2](https://github.com/hij1nx/EventEmitter2) is a popular and small event library. This will provide the .on() and .emit() functionality to the objects.

EventEmitter2 was chosen because it integrates nicely in the browser and node.js.
Well, I sneakily created the hardcoded object in scala.tools.nsc.doc.Settings when I added implicits:
https://github.com/scala/scala/blob/master/src/compiler/scala/tools/nsc/doc/Settings.scala#L145

We can always expose the stuff in hardcoded a an option, but that's pretty ugly stuff to show the user.
This output is wrong right? In the test you are printing the tree:
```scala
println(tb.typeCheck(expr))
```
Default is 'bandpass'.  (Be explicit that it is the string value.)
`FILEIO_H_`?
I don't think that we have a standard for this. If we have, I'd like to know where and when it was established, because I missed it. 

Anyway, I'm not holding up the PR for this, it was more of a general remark.
>
> The `order` argument was originally (I mean, currently in `master`) unused
> in `Basic`.  I wonder whether that's a typo.
>
>
I think so. I also think that there is some misunderstanding of what this
is suppose to do with sorting.

order will change the order of terms within an expression (e.g. 1 + x vs x
+ 1) but this doesn't mean that the key of the one or the other is going to
cause a sort to change, e.g. sorting [1, x] with keys generated with 'lex'
or 'rev-lex' doesn't happen to change the ordering:

```
>>> a,b=S.One, x
>>> l=[a,b]
>>> k=[li.sort_key() for li in l]
>>> ksort=sorted(k)
>>> ksort==k
True
>>> k=[li.sort_key(order='rev-lex') for li in l]
>>> ksort=sorted(k)
>>> ksort==k
True
```

Notice that in both cases the 'lex' and 'rev-lex' keys sort in a,b-order.
Why? The keys are the same:

```
>>> a.sort_key()==a.sort_key('rev-lex')
True
```

OK, so change b so that this is not true:


```
>>> b=x+1
>>> b.sort_key()==b.sort_key('rev-lex')
False
>>> l=[a,b]
>>> k=[li.sort_key() for li in l]
>>> ksort=sorted(k)
>>> ksort==k
True
>>> k=[li.sort_key(order='rev-lex') for li in l]
>>> ksort=sorted(k)
>>> ksort==k
True
```

The sort_key of x + 1 and 1 + x both come after the sort key of S.One.
Oops!  Slipped my notice. I thought our code quality checker checked for this.
No problem at all. We prefer to use it as well.
no, this should be done by the user if he wants to use this type of animations; you are not supposed to change the default value (`hook_ffmpeg_html`)
where you do this:
```
String methodName = method.name().trim();
```

Would this work instead?
```
String methodName = method.toString();
```
I don't think it's useful to test the internal mechanics of how the reporter decides when to send stuff.
Писать в отдельный лог?
deck_init
Somewhere down the line we should consider a full-blown search package like ThinkingSphinx
Will replace with a more descriptive name and tidy up.
I would name it just Server instead of ServerModel, like the Chat properties above
we might consider setting the encoding flag (for 1.9 only) on the return value here based on what was detected
That seems reasonable. Probably it's something that won't be useful in other parts of the website, so it makes sense to move it to the template and not introduce a new function.
Extra `/` at the start of the line. Also you can convert this comment to single line.
Can you add a bit of doc explaining what options are available and what they do?
I don't think this is a requirement. Personally I prefer lines < 80 chars long.
Couldn't these potentially want other parameters? Should we instead configure them as services in the dependency injection container?
Nitpick, but ' should be on the previous line, so that the line break is in the query (readability on explain=1 page)
Please quote everything just in case.
Why is this done at all? Pid should be written to a pid file, and read from the pid file.
why do we expose this complexity in the agent?

Why not just support string, gauge, int64 and double?
Why do we need to use strings here?
why is that VERSION 151 and not 150?
Those are good points. I did not realize that the dependencies were sorted, sorry. I agree with your assessment and I will move them to devDependencies.
I think some kind of error handling is needed where, if the server times out or such.  (Ideally an error should propagate up to `cb`, so that it can figure out how to respond.)
Yep, close this, I'll revert head~2 then commit into fresh branch with out the keymaps file.

Sent from my Windows Phone
________________________________
From: Brendan Forster
Sent: 13/04/2012 8:18 AM
To: Jake Ginnivan
Subject: Re: [carnac] Settings provider14 (#54)

> @@ -17,11 +17,11 @@ shortcuts:

Can you pull this file out as its included in #53?

---
Reply to this email directly or view it on GitHub:
https://github.com/Code52/carnac/pull/54/files#r679756
Ugly indeed, but looks correct. Then again the entire qFlagLocation is a massive hack.

One alternative might be keeping the implementation of that internal to the core library and only exporting a function (with a different name). The hook would then just call that one. Should also simplify unit-testing of this. Basically similar to what the Windows version already does.
Our coding convention is to put braces in the same line.
These original changes were made here https://github.com/SchedMD/slurm/commit/2bb9ff62ce8095488794ff26c1f4101d788dccbc 8 years ago by you.  From your comments here it appears this functionality exists else where and is no longer needed.  The original code is similar to what is done in sview as well.
so that:
```
"Not yet translating standard name into grib param codes. \n"
```

becomes:
```
"Not yet translating standard name into grib param codes.\n"
```

?


> Should it have gone after the carriage return?

Why would I want a space after a carriage return?
I felt a comment saying it was a netCDF4 dataset was unnecessary. That's why I removed it
不再使用了就删除掉。不要这样注掉
It was introduced in a recent commit, so I'm not sure it needs to be in the NEWS.txt.
Remove m_numTest. Instead, add m_numPass + m_numFail when you need it.
Ok, found more problems here. The `calc_timing` fun returns two timing entries for `reply` on the put_fsm, which means two updates to that stat. I really need to refactor this function so it does what I think it is meant to do. (Time each stage, and the total time from init to reply)
why 'c'? kept is spelled with 'k' and the code uses 'k' in the signatures everywhere, such as

#define cfr_kept_internal          "ki"
There's no need to add a class here, as there already is 'dashboard'.
Please use inheritDoc whenever possible
No, if that's written as {receiving, Opcode, <<>>} the first message will be considered invalid if it was incomplete and we need to retry decoding it using the websocket_data function. In the receiving state the opcode must be zero for data messages.
Please use comments (not docstrings) to document test cases. Docstrings make the verbose test output a bit messy.
Done in this branch and the bindings branch in my other pull request.
stderr can be explicitly flushed. Problems with stderrRawFile is that:
* it is relatively expensive, because printTo may result in multiple `write` syscalls
* because write is not atomic, output from multiple parallel processes can mixed on terminal
But honestly, I think I prefer it this way... `defaultDisplay` is the kind of thing that might be conditionally replaced in client environments offering a better way.
Last request (promise :)): Could you use

    "@CMAKE_COMMAND@" -E make_directory server/utils

instead? That's more portable and consistent with the other patches. Thanks!
Triggering state_changed event from %(old)s to %(new)s - perhaps?
Note that the comment above no longer applies, and both branches of the conditional are performing the same action.
It would probably be more correct to substitute `$(CXX)` here instead, so that it respects things like `--use-llvm`, etc.
Sorry, I wasn't so clear. The complete `def options ...end` can be replaced by

```ruby
options "with-metis", "Compile in metis libraries"
```

The "--" is added automatically for the command line, we don't have to care anymore.
What is the lock actually for? I'm sure it's needed but I'm yet to spot what exactly for.
Maybe raise NotImplementedError and add a TODO?
> With this order of processing, It is clear that you cannot modify the file with information from the commit, because it would change its content, thus its SHA-1 and the commit object would not point to this new content.

By "file" you mean a corresponding blob in the commit object? Because if you modify the file, the object in the database remains the same, so there is no problem with this.
You could put this line at the beginning of the method because you don't need the instance count when there isn't actually any css.
I still don't see the difference. Suppose fromField is the sequence of `["x", "y", "z"] ` with prefix `"pre_"` and postfix `"_post"`. You will invariably generate the fromFieldStr sequence of `["pre_x_post", "pre_y_post", "pre_z_post"]` right? 

So why not just use that as the fromField if you always need it to be that way?
We could clear the dirty flag at the end of the constructor, assuming the updates are happening there.
Can you explain what's going on here? Why do you need to empty the background-color, then set it to transparent, when the method says it's just getting styles? If this is necessary, then this would be a helpful place for a comment.
Seems like this is workingset specific. Would it make more sense to move to ``project/SortUtils`` instead?
This causes a bug where you can never get back to the original color.  I think it needs to record the last-picked value and check against that instead... but I wonder if we even need a check at all?  How often / how likely is it that ColorEditor will send us a spurious change notification?
It seems like this proposal specifies relative position in different ways for different kinds of things. Top-level menus and dividers use a {relativeId, relativePos} pair, whereas menu items have separate "before" and "after" properties (though see my comment above). We should be consistent.
@RaymondLim as soon as you commit the change to restore these 2 lines of code, I will merge your changes.
According to the official spelling rules, combinated nouns may either be written together (omitting spaces) or be separated by a dash.

> § 37 Substantive, Adjektive, Verbstämme, Pronomen oder Partikeln können mit Substantiven Zusammensetzungen bilden. Man schreibt sie ebenso wie mehrteilige Substantivierungen zusammen.

> § 45 E1 Aus anderen Sprachen stammende Verbindungen aus Substantiv + Substantiv, die sich im Deutschen grammatisch wie Zusammensetzungen verhalten, werden zusammengeschrieben; ebenso ist die verdeutlichende Schreibung mit Bindestrich möglich: Sexappeal (Sex-Appeal), Sciencefiction (Science-Fiction), Shoppingcenter (Shopping-Center), Desktoppublishing (Desktop-Publishing), Midlifecrisis (Midlife-Crisis)

*Source:
Deutsche Rechtschreibung, Regeln und Wörterverzeichnis entsprechend den Empfehlungen des Rats für deutsche Rechtschreibung, Überarbeitete Fassung des amtlichen Regelwerks 2004, München und Mannheim, Februar 2006. [PDF](http://www.ids-mannheim.de/reform/regeln2006.pdf).*
strange, but cool to know
What if shutdown pending gets set to true after you pass that above test?
A comment here describing what's going on inside the loop, also.
I'm on staging locally, and it appears that this doesn't handle report renaming in all cases, such as this one: https://github.com/dimagi/core-hq/blob/master/corehq/apps/reports/models.py#L272.  This will break any report config with a report_slug of daily_completions, daily_submissions, or submit_time_punchcard by causing them to display as "Deleted Report" instead of the actual report (even though if you click the saved report link the redirection works) and causing scheduled reports to not get sent.

It looks like the dispatcher.get_report() method was not updated to use this new interface and should be.
This is Ruby! We need to be more lenient here. Ideally, you should be able to pass a Rugged::Commit object and the function will work properly too (i.e. by getting the OID of the object and using that in `git_merge_base`).
I think it’s probably better to use a different shim for fallback. It’s incredibly messy to try to patch all the methods that might return elements and make them return Elements instead! I wasn’t sure how hard it would be to change all the code that calls addEventListener or removeEventListener. Maybe I’ll have a look at that now.
If we fail here we should probably log something, maybe do something like https://github.com/brianchirls/butter/blob/3e77abac543722b28ec14af96339b86181ab2c22/src/core/popcorn-wrapper.js#L143
This is a part of the text plugin that allows it to circumvent that trackevent.js default stuff.
Caching arguments.length is advised, yes.  Whether you wrote this code or not, you've touched it now, so we have to deal with it here.
Good catch.

I can probably just do an update with an empty object.
Just checked, it is not. `AS::JSON` takes care of escaping json entities and checking circular references. Maybe bypassing it could improve performance, but I am not sure if it is a good decision in terms of security and convenience.
The viewport should be within it's own meta tag and I don't think we need a comment after it.
Fair enough, though I don't think that really warrants a separate top-level pom just for that... but perhaps its needed by something in pro?
Before each key?  You mean each value?  reduce() will be called once per docId, and in that we have local variables for document and topicVector.  Then we iterate over the (at most 2-element) value iterator, setting one or both of document and topicVector.

But yeah, I added the precondition, good idea.