labofsahil/github-event-dataset-2012 huggingface dataset:
I made that change because I noticed that every time you want to process a line, you need to break it down into tokens so you can figure out what is the key and what is the value anyways
Why not use readTVarIO here?
Du coup, le service aura également deux fonctions ban et unban, sauf qu'à la différence, le service prendra vraisemblablement un UserInterface (et non un UserBan). C'est le service qui va se débrouiller pour convertir les User en UserBan.
I meant this:

https://github.com/iNecas/katello/blob/master/puppet/lib/puppet/parser/functions/katello_process_count.rb

If you want to use it, then change the algorighm. If you do not want to use it, increate reserve because foreman will eat some memory. It would be nice to set it heuristically for both.
same as line 232
I recommend to separate the action into two: history, and history_detail (or something like that), and add route: /system_groups/:system_group_id/history/:id

This style would complicate the documentation and might be confusing once returning array and otherwise only a hash, depending only an the parameters.
text-plain != text/plain
What's happening with all these links? We shouldn't be merging broken links.
The code here only make sense during `init`, for reason stated in XXX I cannot put it in init.

Padlock is always hidden if it's not enabled when locking the phone. In other word, checking the setting on run tine only make sense when locking the phone.
So simply not use the int passed from fooChanged() SIGNAL... it is cleaner yes, I just was sad we didn't use it.
I'm going to change it in all 3 files.
Maybe add a warning that it is recommended to build with db 4.x, because wallet compatibility with the binary builds will be lost when converting to db 5.x. If you don't care about compatibility there is no reason to go through the extra trouble of finding a db4.x++ package.
thats the point. you NEED to pass some value here. you cannot just run around putting

    $Folder->copy();
    $Folder->copy();
    $Folder->copy();
    $Folder->copy();

in your code.

you need to at least do

    $Folder->copy($var);

even if that one is then NULL, string or array then.
Because they were duplicated, check first line.
I totally forgot, but we should use FQCN everywhere in this file... only remembered now. =)
A primer about routing doesn't require data from a remote service. I don't get why we're confusing the issue by adding remote data at all.
return is not a function. just:

    return results
What's the behavior when noReports? always success?
Does this even work? It looks like it might work with `(split-at-subs [2 3] [0 1 2 3 4 5])`, but would surely not work for `(split-at-subs [2 3] [1 2 3 4 5])`.
Note that Github displays this file using a default encoding (probably latin-1 or cp1252), so these characters don't look like cyrillic characters. They are compared with a literal in the UTF-8 encoded test file.
Alternatively I think you can do this in a [Python 3 portable](http://docs.python.org/py3k/howto/pyporting.html#capturing-the-currently-raised-exception) way as:
```
except:
    e = sys.exc_info()[1]
```

(And add `import sys` to the top of the file if necessary.)
Hmm. Should I drop this change, or really forward it upstream? It was a change in the docstring, but alas, would be wrong for Python 3.
I believe there is an error here.  the comment eludes to a mistake where it didn't do ImmutableSet.<String> builder().addAll(arg0.getPublicAddresses()) first
so basically, there's hateoas all over this api :)  we should make a common function for that, then employ it.  I think we can address hateoas in 1.6, and this could be a good way to consider working with it.
How can do I parse the data without defining the parser, can't find any examples on how to this exactly :/
prefer Closeables.closeQuietly for this stuff
Do we want to expose these somewhere for the lightweight variant, that doesn't use the component wrapper but just the parsed jCal tree?
Hm. I don't know if I like this approach. We underwent a very long migration towards dynamic buffers in the stack (against the old statically allocated ones) to prevent overflows. I don't want to go back to it; I'd rather alloc something on the heap.

It makes no performance difference when compared to the actual operation of reading the whole directory. And it's a single alloc for the call.

Also: Solaris defines a NAME_MAX. I'd rather check against that before hardcoding our a value of `255`.
No. Keep a buffer in *our* stack, and then keep calling the callback with our buffer so the user can fill it.

Change the signature of the callback: `int (*source_cb)(char *content, size_t max_length, void *payload)`, and keep passing the same length and buffer. After each call, `assert` that the amount of bytes written is not bigger than our buffer.
Please use `@method Analyzer.stripBuiltins` so doc linking works.
Sure. In general, if an article doesn't exist, it links to the create page for that specific article, which contains /new. 

So, if an article doesn't exist, don't even *try* to retrieve it.
This line is not needed if `not allowable_errors` is true. E.g.

```python
except ProgrammingError, e:
    if not allowable_errors: 
        raise
    dberr = e.pgerror.strip().split('ERROR:  ')[1]
    for err in allowable_errors:
        if dberr in err:
            logging.warning(dberr, exc_info=True)
       else:
           raise
```
Well, I was thinking that for each iteration you'd want to invoke the @queues.sample(@num_queues) so that you apply the weights for each iteration. Once you know which queues you want to pass to blpop, then you'd do queues.map { |q| "queue:#{q}" }. I think we could have a map that create in the #initialize that maps queue names to their equivalent "queue:#{q}" form.
I'd keep it uppercase to keep it consistent with every other python package.
Because it printed out an error saying "Cannot access member 'connectionId' of a deleted QObject" when the client is exit()ing. I will fix this by getting the entity name which is stored in `this.me.name` to avoid accessing `client` for getting the name.
Do these `@link`s this work?
you don't need to create a variable here as you use it only once
you should exclude ``vendor`` to avoid running the coverage on the vendors
I will remove the commenatary distinction for ",;=" in the PR.
btw, it should even go in 2.0 as it is affected too
duplicated semicolon
This test would be marked as failed when running PHPUnit in strict mode ads it does not contain any assertion
btw, it cannot return null either
Maybe not! I didn't look carefully to see if I could remove it.
yeah haha it would be much nice to keep modularity in..modules haha spreading yourself all over the FS is very rails-like
If we're flushing every check, then you would only miss 1 point if `sample1 > sample2`. It wouldn't take down the entire check, just that particular metric for that particular flush. We could WARN log something here though just so people have something to look for if metrics aren't coming in as expected.
why not ? 

we shouldn't create a thread pool if the pool_size is 0.
Good point, I'll remove `has_metrics`.
Should this be calling `bind` and not `bind_all`?
None currently, it just uses the first subimage.  Do you think it should be an error?
This is not great. (it will impact other wms tests if they exist). Perhaps make the class an argument to the WMS constructor and cache the WMSServiceInstance?
what are your changes to doozer client?  Anything substantial?
see previous np comment
I occasionally sneak in entirely intentional, not-indicative-of-my-shitty-typing-ability mistakes to ensure people are reading my commits.
OK, je supprime le filtre alors…
Pour le most popular, vu que c'est dans le master, j'attends ton pull requets qui la supprime?

Le 7 avr. 2012 à 15:41, François a écrit :

>> @@ -0,0 +1,35 @@
> 
> Re Sensei,
> 
> En fait, je pensais filtrer chaque paramtre de requte !
> 
> Pour le most popular je comprends, c'tait une tentative en attendant ES
> donc on peut supprimer mais l j'ai quasi de finir ES et les auto suggest
> ;) Donc je vais bientt remettre  la pull je pense.
> 
> F.
> 
> Le 7 avril 2012 15:38, Julien Dubois <
> reply@reply.github.com
>> a crit :
> 
>>> @@ -0,0 +1,35 @@
>> 
>> A quoi sert ce filtre??? L je pense que je vais le supprimer, je ne
>> comprends pas l'intrt
>> 
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/ippontech/tatami/pull/45/files#r657795
>> 
> 
> 
> 
> -- 
> Franois Descamps.
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/ippontech/tatami/pull/45/files#r657798
I see what you are saying, but my understanding of the usage of the "private" module semantics is that it's meant more for user deployment dependencies rather than external subsystems (or are they called layered products? :)). We had a case where SwitchYard had some similar dependency where their subsystem was using some such API it broke across versions. 

By the way, I'm not opposed to this change, if we all agree that this service isn't supposed to be used as a real public API. I guess, we just need to decide what a public and private "service" is.
else if (configuration != null) {
    context.revertReloadRequired();
}
Sorry, I was asking if undefined vars on a separate line at the end instead of on one line at the top was our new coding standards. I've seen people doing different things and I just haven't asked anyone yet.
The "founds" here has always bugged me :P
This code is failing for unknown artists or other missing metadata, with this error in the console:

 [JavaScript Error: "TypeError: result.metadata.artist is undefined" {file: "app://music.gaiamobile.org/js/music.js" line: 449}]

Turning the expression around to regExp.test(result.metadata.artist || unknownArtist) would avoid the type error, and would also match against the localized version of "Unknown".
this got copied a bit too literally from vingtetun's pseudo-code.  You need a colon after "new".
oh just realized, if we don't have `navigator.mozSettings` we need to use a default value for screenState.
Maybe something like
`screenState = screenState || 'unlocked'`

at the beginning for the if.
Remove that for landing.
Have you tried again to directly use the blob that was sent? Bug 812098 is waiting on an answer from you about whether the bug has been resolved or not.
Please add `data-l10n-id="messages"` to this element.
I just tested your code and it seems modal dialogs/authentication dialogs are not broken. Maybe it's safer now.
Because we alway use webAPI for asynchronize callback. Just beware of the callback function and you will be safe :)
nit: s/net /not
Why you increase 8 px even when there is no 'intro' button pressed? It causes a small 'jump' that we should avoid.
@vingtetun As in the note above i will change this as is not longer needed the -moz-element
You can loop on the elements list.
Is the unavailability cause by OOP?

I don't like the approach here but it's fine I think.
We do for snippets; because of the way they're inserted into about:home, they have to be valid XML, which means escaping character data.
Not sure about this class. Better to BatchCreator because there all parameters could be passed like (index poi/transport/route ...).  Basically users who use command line need to pass parameters.
Shallow class could be used for automation however BatchCreator is also suitable for it and already documented.
No, I am crazy. 638263aa5a
Same as [this](https://github.com/redu/help-center/pull/6#discussion_r2120383) comment.
Is there any reason why this method can't be called `profile` to match the command-line flag?
oder noch besser: mach einen Ember.View draus -> du verwendest jQuery für die css Klassen und brauchst auch mind. ein element für die uhr nehm ich an! Es ist besser solche zugriffe so "lokal" wie möglich zu steuern und nicht immer über absolute #ids mit jQuery
The comment is wrong. It needs to be font size 22 based.
see suggestion above!
Remove this commented out line.
Oh i see - didn't read the put_or_post correctly. Merging.
object => self
This is exactly like _full except that it abandons on failure and makes a shallow clone
Well, I guess that's how they force people to bump browser versions.

Like jQuery 2.0+ will do.
Sure. that's more in line with the `included` var for `filterer`
This is not intentional and shouldn't be deleted.

Tried:
git merge upstream/gles20
Already up-to-date.

Tried:
git checkout upstream/gles20 generated

And it always generates empty directory, don't know how to fix it... Maybe subproject support is missing in Eclipse EGit. Do you recommend some GIT client for Windows?
It shouldn't really matter since it has a higher priority.
It's `mixed` anyway. The `ArrayDumper` returns an `array`, while the others create an archive.
for the record, this feels kinda weird to do a state machine like this in ruby, but whatever.
Not sure -- we still have access to the prefs object in this scope, though...?
Filtering is possible only where the data flows from the model to the view and not vice versa. Thus TextArea isn't eligible unless I started demanding the user write function plus inverse. The filter function is analogous to being able to write a function to generate the label for Action elsewhere.
Just compute_prices seems to be sufficient as a name of this method.
BTW second argument may be `'*'` which will allow communication with any domain. I think it's worth mentioning as if you write page mod that applies to diff pages it's crucial to have a content script that will work for all of them.
Nit: I think we'd be better off showing more restricted pattern in the example as many people just copy & paste. Maybe "*.mozilla.org"
Going along with https://github.com/mozilla/browserid/pull/2843#discussion_r2358831, this should have a test as well as have some {}s.
we need to go through and obliterate type completely.  The time to do this is probably after we land the last API changes in a separate pass?
What'd you think about my CompressedJSONField? It might be overkill, but it seems to work well.
Fixed. And the same at line 44
why do you add extra spaces between `string`, and `$param`?
the same here : 
I think the "\\" is not needed because $queryClass is already a FQCN
These commented out functions should be entirely deleted.
....so, if another field is removed, in future, wouldn't it be nice to apply this behaviour to *all* the attributes, not just the ones we know to have changed?
This adds O(N log(N)) complexity to something that the caller may never want.  If you want to keep original (server defined) behavior, then you'd need to sort on offset, rather than name.

You can also include the offset in the :

```go
names = make([]string, lim)

type result struct {
  off int
  name string
  err error
}
...
names[res.off-lim] = res.name
```

Now, you have the same order as the server.
Additionally:

```
* Include the Features module in RSpec scenarios with `:type => feature` set
```
Should these be single quote aswell
`define` is optional since SLES9, but recently I used it in new code so that I could grep for functions defined in a file.
Return within the if block, so that the else can be removed, and its body bumped up a level.

Also, add a space between `if` and the opening paren.
$this->setExpectedExcpetion('Zend\Escaper\Exception\InvalidArgumentException') instead.
I got lower case dislexia ;)

I will fix the fix tonight and add the original exception.

Best regards
Falk

-- 
cogitatio
Falk Kühnel
Am Lappenweiher 1
53127 Bonn

0228-369 369 9
fk@cogitatio.de

Am 12.04.2012 um 16:58 schrieb Till Klampaeckel <reply@reply.github.com>:

>> @@ -175,8 +175,12 @@ public function getMethod()
>>     public function setUri($uri)
>>     {
>>         if (is_string($uri)) {
>> -            if (!\Zend\Uri\Uri::validateHost($uri)) {
>> -                throw new Exception\InvalidArgumentException('Invalid URI passed as string');
>> +            try {
>> +                $newuri = new \Zend\Uri\Uri;
>> +                $newuri->parse($uri);
>> +                $uri = $newuri;
>> +            } catch (Exception\InvalidUriPartException $e) {
>> +                throw new exception\invalidargumentexception('invalid uri passed as string: ' . $e->getMessage());
> 
> +1 on the casing.
> 
> I'd also argue that the exception caught should be added to the new exception.
> 
> E.g. `new Exception("Something happened.", code, $oldException);`
> 
> I am also wondering why the names are all lower-case?
> 
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/zendframework/zf2/pull/1038/files#r676635
setRawData not longer exists in Zend\Http 2.0
s/avilble/available/
@stloyd not sure what you mean here
Here is something wrong.
I wouldn't use `Object.freeze(Object.create(settings));`. It makes debugging unnecessarily hard since `console.log(context.settings)` will always print out `{}` plus it does not protect the settings from being changed (since `settings.__proto__` is still mutable)
My guess would be this has to be removed ;)
The whitespace doesn't look right here. Also, I don't think we should make the name change.

Should the num_ operation be #ifdefined - I think it should be included unconditionally. Similarly below.
Why are you returning "object" if you already know the instance class name?
Missing space between type conversion and variable name.
As the HtmlReader still has problems, I guess it's counted as an undocumented and disabled-by-default feature. xD
e.g. it can't parse <!--# date: 2012-08-08 12:34 --> correctly because of the second colon in the date.

Additionally, it doesn't allow for äüößéèȩ etc. which should be valid as a value, I guess..

I'm not good enough with regexes to fix this by myself. :/ Can you help me with that?
OK, that was not correct. But we probably should add versions, because other packages may expect version >= x.y or some such.
fixed everywhere
spaces after all commas
I've released 1.0.0.M4 of the BOMs which includes the errai BOM :-)
Contacts and users are different. Each user has many contacts. I think I will add this current_user logic to the controller because realistically nobody should be able to see any contacts except the user who created them
yep, sure !
This needs a comment to explain what it is doing.
you need to add reason here :)
No, this should already be taken care of by the model form logic.
Yeah - `form-horizontal` is boostrap and it seems that the rest of our classes are `something_somethingelse`
I know you didn't do it, but add a space after the `a` while you're at it.
Scrapping these files means we need to update our Vagrant/Puppet configuration to work off of env variables too.
I'd like a bug filed in 1.4 for us to remove this when they fix it in webkit, and a comment in the code with the popcorn bug.
Can you add a 0 in front of the decimal point here? Then I will merge this.
I can change that as well. Again, just sticking to the established coding convention.
Using get _any_IP will return the firewalls public IP (ex 80.88.170.190) which don't want to monitor on.
I'm not sure I understand what is the purpose of this validation? dont we set it up already some where else?
getWriteObject() is a funny name (contains two conflicting imperatives). Should get a clearer name.
There were blank lines where the package changed. Please be consistent.
"the official download page" would probably be better
Indenting is wrong. You should also add some new lines to this function, as it is current just a block of code.
As far i see, there's no calling points to executeBody other than the ones in this this file. same goes for executeClassMethod. i greped for it in extension, lib and kernel folders, with a ez 4.6 enterprise install. that's why i decided to remove includeFile entirely...
i wonder if we need to extend XMLReader. maybe @chregu knows if we can make this code (its based on libxml2) automatically skip empty whitespace and comments?

what should we name the class and where to put it otherwise? Jackalope/Util ?
Is there a way to turn off gzip'd files? Otherwise watching a directory glob will result in logrotated files that are compressed to be reingested. I would prefer gzipped files to be off by default.
Fix the "objec" typos and I'll merge! Thanks!
Huh, good point. Maybe child mocks inherit the return value of their parent, or perhaps the way mock replaces names in the module affects the time method as well as the time module?

Changing the patch to jingo_minify.helpers.time.time works, so I'll change it to that since it makes more sense.
removed space, changed span to <a href>
Not necessarily. Keep in mind that also for release/beta candidate builds zip files are available and also tests will be available on FTP which we would kinda like to download in the future. Same applies also for tinderbox builds:

ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/16.0b2-candidates/build1/win32/en-US/
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-l10n/

So I don't think that having this parameter on `DailyScraper` only would help us in general. I would propose you move it back to the base `Scraper` class.
I like consistency and the e.g. lines allow you to show multiple examples. e.g. The channels one. It's up to you.
Why dont we better make an encoding map and insert such line if we know which one is, there is such line for most if not all languages.
It worked on my machine (with and without target folder).
Would be good if somebody could confirm it.
if a value should be checked, assert.equal should be used.
That would simplify things.
We could do with some clearer variable names in this case as well
module.exports.hasRole = function(actor, resource, role, callback)

where
 * actor: The thing that needs the permisson on the resource (ex: a user, ..)
 * resource is the rowKey that express what we're talking about (ex: content item)
 * role: The role we wish to check

ex:
```javascript
// content check
roleAPI.hasrole('u:cam:simon', 'c:cam:foo.docx', 'manager', function(hasRole, err) {
    if (hasRole) {
        console.log('Simon is a manager of the foo.docx file.');
    }
});

// group check
roleAPI.hasrole('u:cam:john-lennon', 'g:cam:the-beatles', 'member', function(hasRole, err) {
    if (hasRole) {
        console.log('John Lennon is a member of The Beatles.');
    }
});

```
if... if what?? The suspense is killing me!
Please make this +=. Same with lines 888 and 889. This is because
3x-7y=3a+7b can hav positive integral solutions, while the same equation with plus sign does not. Also make sure you are using the primes as they are,without converting to floats. I realised the mistake of the minus sign, and sent a commit. You used my earlier code in your PR. Sorry about the noob mistake. With the change, the output is right as expected :-)
yeah, copy/paste..
I'll do it in some later pulls
`OR` instead of `||`, as per the style guide.

Also - there's no hard limit on line lengths, you should merge this line with the one above and 870 with 871.
arr будет создаваться при каждом вызове метода - итого для каждой нашей клетки 100 раз. Рациональнее вынести его в свойство класса, и создавать только один раз
В данном случае для проверки равенста двух строк необходимо использовать метод isEqualToString класса NSString.
Например: if(![[_DNA objectAtIndex:i] isEqualToString:[cell.DNA objectAtIndex:i]]){ }
неверно, n может быть больше DNA_LENGTH, так как это процент.
don't we still need provider_account to hook into the conductor provider_account_id? If it was not doing this (which this patch makes it appear it was no, then perhaps this is 2 bugs?  It seems to me like if we need a provider account id from factory (which I am not really sure we do), it should be in _addition_ to the provider_account id we get from the host app, rather than in place of.  Am I forgetting/misunderstanding something here?
SHA isn't a checksum, it's a hash.
I think you've written this eventually do block 3 ways in the pull request. Can you standardize them?
Go ahead and add your name to this file as an @author
I'm all for making these methods with necessarily weird semantics private, but what is a user supposed to do to make a well-behaved signal?
I agree. I will fix this tonight.
units is not documented :)
why lazy import ?
> true.. it is probably better to go with a simple solution ;)

the simple solution is often the hardest to find ;)
Maybe make this plural? i.e. `this.previousTransformations`
Since you'll use these strings in your code, wrap each of them with the double-tick:

    ``AMEX``
you should use ``!`` instead of ``false === ``
I can't make a call, only support your PR. I'd support removing that cache entirely, though.
This isn't safe, this could replace more than it's supposed to. Consider the path /x/y/x, if you replace "/x" then you'll also incorrectly replace the last element of the path.
My usual soft limit for C++ is 100, and this has worked for me in the vast majority of cases.  But I'm happy to adhere to any documented standard! I will break these up and use 80 for now.
Кто мне мешает хотеть загрузить файл в гуглодокс и расшарить его сразу?
Объявления сигналов в самом конце идут (после слотов).
上面包一個 .spot-row 蓋全部吧
De curioso pregunto: ¿quién es el que soporta los comodines? ¿`StartsWith`?
In version 2.1: The SessionInterface interface as changed

http://symfony.com/doc/master/components/http_foundation/sessions.html
Good point @danberindei. 

@mmarkus, since the test uses the old configuration, couldn't this be a bug in the old configuration that it's using the same lookup instance in different configurations? Or a bug in the way the old configuration is transformed to the new one and used internally?
s/MongoBD/MongoDB/
No it is not, but I'll make it. You got the point! I'll retract this PR and submit two separate PR!
Don't use '==' when testing for None.  *Always* use "is" and "is not".
Yep :smile:
On Fri, Apr 27, 2012 at 1:42 PM, Benjamin Root
<reply@reply.github.com>
wrote:
>>          Line collection with all streamlines as a series of line segments.
>>          Currently, there is no way to differentiate between line segments
>>          on different streamlines (other than manually checking that segments
>> -        are connected).
>> +        are connected). NOTE: this return value is likely to change since it
>
> Why not prepare for future changes by simply returning a one-element list?  Future revisions could then have the arrow patches as the next item in the list without breaking anyone existing code?

Because I don't think a list is the way to go for complex objects like
this.  Better to return an instance of a class.

Eric

>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/matplotlib/matplotlib/pull/849/files#r744390
we might as well do (got == null)
Third commit pushed.
could you please reduce the number of parameters of that function? for example w is a member variable anyways so w and dimensionality are known inside it. lambda = 1.0 / C is known too etc...
Are all those mixins still required now that we've removed the tooltip code?
They look fairly general purpose, but also need documentation to explain
what they're actually doing - its a bit much complexity to add "just in case".
Does anything speak against removing them?
Methods must be documented
Isn't there a timeout on Notifications already. @svenfuchs?
Please create a Jira issue for this, "Support for custom events"
And we need an off then ;)
inbetween > between,  it's not posed a problem > it doesn't pose a problem
please make this 80 chars
This method doesn't seem to return anything.
Elin, you're right. It is missing the priority. Not sure how this got missed.
I think we can cop out here if the count is only one since that means no expression has been used. Or am I missing a corner case here?
appending this here as the body might not exist yet at this point of the code execution (if js was included in head) and Opera returns empty values for `window.getComputedStyle` on a detached node.
Can do this:

    cpanm = node['perl']['cpanm'].to_hash
    remote_file cpanm['path'] do
      source cpanm['url']
      checksum cpanm['checksum']
      # ...
    end
result[-1] is there a helper for this?
Is this more info? really?
Just name CSS class `user_image`.
Empty space at the end of the line.
Probably `safe_update=True` argument should be used?
No, we do not want that EVERY request has to load all nodes. Staff users will be a big minority and why would you load huge data for everybody?

Also, middleware is not the right place to store data you want to use in templates. Please read about context processors.
ready doenst work in FF and Opera
OK. Then rename this to `current_password` and move it to separate form (as you are using it twice).
What if their is more than one variable? Should it yield here or at the end of the variables loop?
'/accounts/password/change/'
Indent this by another two spaces. The line above it should end in a comma, too.

This is because `:revision => foo` is another argument to the `url` method, not a method of its own. So it's a continuation of the same line.
Removed the 'a' due to the fact that we have no way to conjugate to 'an' if necessary.
I would say "key name" here. LGTM otherwise.
I can add the -- to make it more clear
Nope, we're not, maybe should we stay with the "force_respawn" name, which will make things more explicit.

We shouldn't need to have a look at the docstring nor the implementation to understand what this is doing. I propose that we change it back to `force_respawn`.
:-) +1
No, it can't be. Actually crafter_request_id is missing on the Entry when it's initialized, fixing that too. Also adding a check if crafter_request_id was already set, that only makes sense to do once.
Didn't we give up on doing that? I think it can cause problems when enabling / disabling services? Not totally sure though.
This seems a bit overkill. Could we simply add a setter method for defaultSavePath to QbtSession class?
one possible speadup: increase xtol=0.0001
As far as I understand: the exact bandwidth might not be very important, so we might not need it to converge to a high precision. The important part is convergence in function value.   (a guess: this might save time and calculations if the objective function is relatively flat at the optimimum.)

What I don't know is what the scale is: do we need absolute or relative tolerance in x?

extra question (maybe for future): is any of the other optimizers potentially better/faster, make it into a choice?
I don't think I changed anything here at all. I just pulled this out into a bit of a simpler function as part of a little housekeeping. My code from first gsoc makes me shudder. Am I missing a change?

The assumption for diagonal GLS is different from diagonal WLS IIRC. Could be wrong.
Looks like there's not a helper, but I'd definitely create one in `app.rb` under `Mulberry::Framework::Directories` for this and other paths.
codestyle will complain about specifying "public" and "abstract" in an interface, as it is redundant. This is nitpicky, but since we are going through the process of fixing codestyle errors, this will need to be cleaned up soon anyway.
Not new to this branch,  but it might be worth a quick comment here about how the CCDNoise model provides the Poisson noise, and has default gain=1 and zero Gaussian read noise when initialized here.  This is available via the CCDNoise docstring, but I think these demo scripts are going to be a useful starting for many people...
In fact, I think I could even lose the case switching there and it would still work, making it very succinct. Yep, that would work too.
Have pushed an update that I hope addresses this!  Please edit further if you wish.
So, I've looked into two ways of handling the 0 item `SBAdd` input list weirdness.  The first is to give it an empty list.  This gives the following relatively desirable but not perfect behaviour:
```
In [26]: a = galsim.Add([])

In [27]: a.flux
Out[27]: 0.0

In [28]: a.flux = 3.

In [29]: a.flux
Out[29]: nan

In [30]: a.add(galsim.Gaussian(sigma=2., flux=5.))

In [32]: a.flux
Out[32]: 5.0
```
So initially getting and setting a flux (which is one of the only active things you can do with an Add) works.  But then trying to set an empty Add to non-zero flux gives an undefined `.flux` output on later query. But once you've added another object, making it non-empty, the flux seems to be correctly reported.

The other alternative would be to set the `SBProfile` property to `None` or something similar, and raise an informative `TypeError` or `AttributeError` if attempting to access.  Not sure which is best!

The other alternative to keeping this behaviour would be
Well, it lives in the atmosphere namespace and should be unique in there. Just like psf() and psf_image() and so on in optics.py. We can decide to have more globally unique function names but then have to go back to other python files.
why are we adding a new obsolete field?
hmm... I didn't knew about "case in", intresting thing.
(very low priority). Strange method order; I normally write the methods in the order they'd get executed: [install, customize, launch, (isRunning | stop)] seems more logical to me.
this line (above) just failed in the jenkins build
This file shouldn't be here anymore. I removed it in this commit : f1c32637
I'm not sure yet if you should redo the pull request without it or we should cleanup things after accepting the pull request.
I remove it
casting in service call looks strange :)
Oooops! sorry xDDDDD it was #FFF . Anyway, done ;)
Or to do this: http://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac
O que justifica o parâmetro `num_month` ter um valor default? Me parece que não faz sentido invocar um método para pegar a representação texto abreviada de um mês sem informar o mês.
Wouldn't it make sense to use a more specific search? If 'search' were an ignored parameter, this test would still pass.
no IMO if it fails for mac it should check platform as it builds for linux. script is clear that it is for linux .. so it fails for other platform please add a check to make it not run in mac.
formatting appears to be bit more compared to rest of the file
Does the comment need to be on the line above or should it be in the assert?
Теряешь информацию о ```Throwable e```
А если 128 ядер у компьютера?
Would be nice to say a bit about what's going on here (specifying the port allows us to target >1 jboss as instance on the local machine), either here or where the properties are used.
I prefer the neater approach of them instead putting the spell's .jar file inside the folder, as they're truly writing plugins for this plugin.  It doesn't really make sense(or is as efficient) for them to create a bukkit plugin that's simply adding onto this plugin.
Absolutely. Will fix.
We should move this import and the beginning of the file as per http://www.python.org/dev/peps/pep-0008/#imports
While you're here, can you change this to login_to_paypal_sandbox, to match your new _developer_page_login_to_paypal method?
the ``<tr>`` tag should be closed
Subsection name repeats title name.
We do if we want a specific output range, do we not?
if you want the example plot to appear in the doc it should be named starting with `plot_`
I think future potential multitask classification models will have the same need. I think we will have to do another pass of API consistency discussion if we have other models implementing that patterns.
Handle starts_with mechanism
цікавий глюк в мене. коли я прописав setRoles, в базі є лише пустий масив ролей (для звичайного).. довелося прописувати роль вручну. вказував і дефолтну роль, і ROLE_USER -- нічого не вставляє. з іншими ролями ок
Also, that line should come before the comment.
empty line here is not necessary anymore, it was for the old formatter, don't need to change it back though
I think it's more consistent to have it return null instead of false.
I think testing injection should still be kept as it is a core functionality we provide (along with pulling from `ServiceManager`)
to filter documentS
I think the init system uses this path to determine the output path for configuration files. So, the path may be necessary.
I suppose it's not your fault that this whole service has been written specifically for the configmgr javascript.  It's hard for me to review in that context as our web services are intended to be independent of the client.  I would still remove these assumptions where I could, but it may not be critical.
What exactly is this (last line) doing?
Related to the linking problems commented on earlier..
This overloaded getNextSorted(), need to ensure that either it passes back ownership of the rows it returns, or it links them.

In this case prob. easiest to link the row returned.
You're correct it should have been separately noted.  It is adding a missing call that is present in the other branches (see surrounding code) to ensure that any operator that has a ROWS(LEFT|RIGHT) allowed doesn't allow that dataset to leak outside the operator.
In practice it has no effect since it isn't currently tracked - part of the bug I was tracking down.
That ```trim``` will only trim the last input - it's the previous inputs that end up with extra spaces.
Mauricio, No problem, this all sounds good! Good to hear that you improved the test.
Well if the database schema changed, then you need a migration. If not then not. No point in merging this file in like it is though
You can give `alive?` to filter as is: `(filter alive? authors)`
'install Django >= 1.3' would be more consistent with the python line above.
I agree it's weirds, but it's not my weirdness.  That kind of behavior was there before.  I assume it was a flag that the Payload ModuleSet was doing.  I can trace why that would be set.
So, funny story, neither Resolver::Error nor ResolverError seem to be defined. Going with the currently undefined ResolverError for consistency's sake.
Thanks for including this change so I don't have to make a PR to fix this.
This really needs to get fixed in the mime api
is there an append function for store_loot ?
im finding it hard to find documentation on the api so i just read other ppl's code.
`f.read` should almost always be `f.read f.stat.size`  for some windows FS reason I can't articulate right now.
And also _ is part of \w
Same comment as above.  And throughout I assume.
Show isn't really boolean but is instead a DynamicProperty instance, so the || here is fine.  That being said, it's probably cleaner to use defaultValue or typeof instead of ||, there's already a bug open to do this throughout the code (and DynamicScene has it for all versions of mergeProperties.  I'll take care of it.
How do we compute the bounding volume for the polygon during the morph?  Why not just union the bounding volume of the source and target scene mode to avoid any CPU overhead during the morph?
According to John Resig, there were problems with the splice method. Consequently, I followed his recommendation, which you could see in the code.
This log is going to fail as it doesn't contain `%s` to put the type in
The same idea here.
Also don't need to define the getter
OK, so that was my understanding from the code. After testing, here's what actually happens:

-- Android returns "undefined"
-- iOS crashes trying to convert "nil" into a URL.
-- Mobile Web returns the empty string

Not sure whether "undefined", empty string, or "null" is the best option, but I'm pretty sure crashing is the worst.
Well spotted, Bryan - thank you!
Fixed in next update.
can you explain why these are not needed?
Should retrieve and normalize val() just once. Would reduce the duplication below.

As for the normalization itself, joining into a string doesn't seem very useful. If a multi-select is validated against a method that doesn't support it, it should throw an error. As its now, its likely to go through undetected or produce some weird behaviour.

How about adding a method that calls .val(), the normalizes by replacing \r only in strings, then returns that value. Use that in both places.
I have only tested it with 2.1; I'm having trouble installing Symfony2 dev-master but can try the instructions with that later. Do you want to keep 2.1 for now and then update when 2.2 is released, or go to dev-master?
Looks like you're using `.toFixed( 2 )` everywhere else--just missed it this one place

![Imgur](http://i.imgur.com/h8N5k.png)
protected function createCaptcha
I (partially) agree, but the main issue though is that this code relies on emplace, which, itself, doesn't actually correctly emplace that kind of stuff anyways.

The original tests had `opAssign(S){assert(0);}`, for example, but that didn't work, because it was called by emplace...

While these tests aren't actually checking correct manipulation of the structs, they do cover all of the Appender's code branches, which is already good, and I dare say better than most unittests ;).

Ideally, we'd need to create an series of objects in some module that are thorough, that could be tested by emplace, move, swap, uninitalizedFill, scoped etc...

Problem is they'd currently all fail the tests though...
a narrow string
Same question of `isDynamicArray!S`.
I'd then rename this file to ```essentials-section.css.less``` and only contain styles for the ```_essentials_section``` partial.
I don't know of any downside.
what's this env variable for?
Yup, agreed. There are still tons of calls to reading/writing certs etc that need to be mock'ed
Well, from that point of view it is same story as MTL4:
you need to feed its sources manually;  (at least that was the case last time I checked it); your story?

What is your preference about how to fix the pull request? I'm unsure now.
I guess ASTNode::ref is always valid as returned by next, or can it point to nothing?
Инлайн ничего не пишем, если это не темплейт.
What about these tests to org.infinispan.configuration.ConfigurationUnitTest where we have other similar tests?

Also, it would be neater if you'd avoid that try/catch and instead do: @Test(expectedExceptions=IllegalArgumentException.class)
This is an intersting one. All other infinispan's thread pools are configured in the global section of the configuration. AFAIR the reason for that is to keep resource alocation centralized and to make possible sharing thread pools between different components.  I think this thread pool shouldn't make an excdeption from this rule: perhaps @maniksurtani might also want to comment on this.
minor nit -- we usually use *minlength* when formatting rest docstring parameters.
Removed it in follow-up commit.
@croby: It doesn't have to be random, and it can be changed to be static. The rationale behind it is that each sakai doc would have a different initial id, which could potentially make debugging or helpdesk requests easier to resolve.
~~We will see a bit more about the <emphasis>parameter</emphasis> sub element here.~~

Not needed.
Yes; also in IMAP, plus the comma below; I can do them all during the merge; just wanted your concurrence.
I know, neither was I. I was saying that it was 'required' in the schema for some element yesterday (can't find it now, perhaps accidental typo) and i removed that.
I hope not. Especially in this case where one may specify more than one method and for some it may apply but not for others. Remember, this is an inbound gateway so i may have downstream routing based on method name etc., so I am simply stating how many methods I support and this change simply telling me which methods of all that I support will ignore 'requestPayloadType'
I refactored windows.console.log to console.debug, so now we have only one if (debug). If there will be the need for another one I will write the debug function.

On 29. 09. 12, at 12:48, Mitar <notifications@github.com> wrote:

> In tests/test_project/test_app/static/test_app/js/datastream.js:
> 
> > +                        if (debug) {
> > +                            debug.find('#debugTable tr:last').after(
> > +                                '<tr><td>' + $.datastream.metricName(data) + '</td>' +
> > +                                    '<td>' + granularity + '</td>' +
> > +                                    '<td>' + toDebugTime(from) + '</td>' +
> > +                                    '<td>' + toDebugTime(to) + '</td>' +
> > +                                    '<td>' + data.datapoints.length + '</td></tr>'
> > +                            );
> > +                        }
> > +
> > +                        if (data.datapoints.length === 0) {
> > +                            return;
> > +                        }
> > +
> > +                        // format data points
> > +                        for (j = 0; j < data.datapoints.length; j += 1) {
> Use jQuery .each.
> 
> —
> Reply to this email directly or view it on GitHub.
> 
>
But this is plaintext. Maybe I shouldn't bbe using code-block?
What can I use to provide a semantic seperation?
Also, can I somehow revise the current commit, or do I need to cancel the push request and make a new commit with a new push?
The parenthesis around name.length - 1 are unecessary due to JS' operator precedence. The standard JS coding style is to not use parens unless absolutely necessary (a holdover from the web where file size affects performance).
missing new line before the ``{``
make sure you add {} as I think is more standard
@willdurand This is really crazy. The config key and the providerkey from the `MapQuestProvider` and `OIORestProvider` are different.
I don't change this for BC reasons.
change this to length=38
This file is in a `Backup` folder?
maxSessionLength could be used for both polling and eventSource. If you're using polling and the server is ridiculously slow, you'll want to kill the session instead of waiting on it.
Yeah I can put in a commented out version of the older path, and document that the change might be necessary in the top level.  Do you think that will be enough?
do you still need dbname for sqlite? or is this just ignored?
One empty line after this?
I would start this comment with TODO:

```
# TODO: Might need it in the future
```
**Error:** Missing blank line before return statement
sure thing

On Wed, Feb 22, 2012 at 1:52 PM, Dave Dash
<reply@reply.github.com>
wrote:
>> @@ -9,7 +9,7 @@
>>
>>  import input
>>  from input import FIREFOX, OPINION_PRAISE, OPINION_ISSUE
>> -from input.tests import ViewTestCase, enforce_ua
>
> Can you remove enforce_ua entirely?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/mozilla/input.mozilla.org/pull/42/files#r477873
I prefer @gravitystorm's version, but the real answer is that we should just leave our the lat and lon attributes for deleted nodes rather than returning a fake position.
Again, this can be moved to settings and that variable can be used.
Why don't you use
These should probably all be part of the post body using json. It would also be good to have an example that shows a different HTTP verb in use.
Examples are getting formatted a little funky--intro text is being wrapped into example. Might need a blank line between intro text and example.
Do we want to include a "Does not compile" option [as discussed](https://github.com/scalapuzzlers/scalapuzzlers.github.com/pull/56#issuecomment-10173658), e.g.

1)
```scala
Hello, kitteh!*
U go now.***********
```
2) Second fails with runtime exception, first prints
```scala
Hello, kitteh!*
```
3) First fails with runtime exception, second prints
```scala
U go now.***********
```
4) Does not compile

Or change 1) to the "expected" answer if we want to reference that later
Seems okay.  The removal on low memory was originally added in 721e9542f886a37b39510e25d703bccb16cd7583.  Was that for Chatter logout considerations?
s/Reksiteröidy/Rekisteröidy/

s/ministeirön/ministeriön/

:-)
But using `update_attributes` allows anyone to inject their own parameters and potentially change other user's ratings and even rate puzzles which they haven't solved.
Should all be capitalized
Учитывая, что в `liteMode` он всё равно не нужен, то его надо перенести в `initUpdater` после инициализатора постформы.