labofsahil/github-event-dataset-2012 huggingface dataset:
The Catalogue abstraction in GeoNode should probably use encapsulation rather than inheritance to access OWSLib functionality - ie, maintain an owslib.csw.CatalogueServiceWeb instance as a member variable, rather than inheriting from it.  That makes it explicit where we are using catalogue.Catalogue methods instead of ones from OWSLib (and we can easily review the code to minimize such access.)
populate output data when you are creating input itself
After talking to @Pajk this looks fine to me. ACK.
thanks, got rid of that diff.  should no longer effect master when this is merged
What about updating the Environment name?
Should it not be there? I added it because I thought it'd be good to have all ways for logging out covered, but if it's not a good idea, I will remove it.
¡Usa una Poké Ball después de\xfffedisminuir su PS!
Send another PR

Sent from my Windows Phone
From: MatsKarlsson
Sent: 3/16/2012 1:48 AM
To: DamianEdwards
Subject: Re: [SignalR] Javascript-deferred should return a
promise() ... (#254)
>
>              if (connection.transport) {
>                  // Already started, just return
> -                promise.resolve(connection);
> -                return promise;
> +                deferred.resolve(connection);
> +                return deferred;

I agree. Will test and verify that it still works later.

But what's the best way to proceed? accept this and another pull
request, or reject this and another complete pull request?

---
Reply to this email directly or view it on GitHub:
https://github.com/SignalR/SignalR/pull/254/files#r567048
We don't need to post this message anymore.
Wrap in a small tag
should it be ``in`` instead of ``if``? Or ``if any parameterized WCS keyword is present``?
I'll merge this pull request, but in future please take care not to include trailing whitespace in your commit.
What I find strange is, that my tests in a Ubuntu VM with Gitian, bitcoin-qt showed used OpenSSL version as 0.9.8, is that true, that we use such an "old" version with the official Linux bins?
You can change the docblock :wink:
"Seules les interrogations par simple clic sont possibles pour cette couche."
Could you please add a blank line before the closing docstring quote?
This line appears to be unneeded.
Not clear how the comment relates to the code. What are the token value and matching string?
I'd just condition on something like `if (length(dir(path_vig, "Rnw")) > 0)`
Now I have to use 2 IDES, since QtCreator (I'm a linux only user) seems to have identation broken...again. May I sort the wrappers? Since Eclipse allows to do it automatically it is not a big deal.
I will move this as inner static class
please remove all instances of stuff like this
А это что за ссылка?
You can use StringBuilder which is more lightweight as it doesn't synchronize calls.
Remove // Debug comments if possible.
import views works here too.
The Style Guide was started before any l10n work in bedrock, and there aren't any plans to localize, that I'm aware of. Should we be wrapping strings anyhow?
This is not designed to be a mutable tree so this is not a concern. I've not enforced it in the code though.
Uhhh I don't know, I was just following what was done above :-). Is a list better?
Yeah for mobile we have to use sprites to allow us to use media queries to detect whether we need the regular or retina version. So maybe it makes sense to do the same on desktop since retina is now a concern there as well...
s/topic/product/
I want the ini file to reflect the hardcoded defaults.  That line is part of the new throttler, so it ought to exist here, too.
This turns on all switches, not just your own. Which may not be what you want. And making the lambda more specific to just your switch turns all other switches off. Which is why you need to use `create_switch` even though it (unfortunately) hits the DB.
I think that's pretty hard to test since the changes are to the global class structure.  I'm willing to give him a pass.
Indentation issues here as well
``and`` and ``&&`` are not equivalent.

It doesn't matter in this case, but it could lead to weird behavior in other cases.
arf, you edited the PR after I loaded the page, so it changed the line numbers between the JS in my browser and the backend. The comment was meant to be on the method declaration of ``addDriverInstances``
please declare the ``storage`` property
oops good catch
should mention that a length of `0` means all in the phpdoc (can be irritating).
``@param integer $calendar       An \IntlDateFormatter instance`` ? really ?
I'll let you decide, but while using this feature I found it handy to be able to change the hostname of a single route even though the route collection had a hostname already.
``normalizeValue`` would be the place.
The same reason every other place in the form component is type hinted or checked against the interface instead of the implementation.
Please use the short class name (and add the use statement if it is missing)
personnal preferences I would say.
@Tobion but in the context of the full-stack framework, what is injected is the router (which implements both the MatcherInterface and the GeneratorInterface and lazy-loads the actual matcher and generators from the cache). Injecting the same object twice seems really weird
Can you revert the CS change here?
The the order of the arguments for files matter? My understanding is that java_lib_path is a more specific place for jars that java_class_path so java_lib_path should be search first.
mage too in proje 1style estefade kardi ?
sabkesh 1styli nist, hazfesh kon
Note for me: change to exporting in some `anm.util` object.
Should return the result of histogram_impl<float> for consistency.
I wanted to make config read only.  I thought that if made update_config a setter, it would obscure the fact that it will change the global state.
It could be easier to maintain - instead of case / when you'll just use hash.
`selection` is already wrapped with Ember.A
I prefer checking if `null !== $timeout`
ok, I will update with SimpleAttributeDefinitionBuilder as I update the attributes
Ah, much simpler explanation than all the complicated theory below. This should be getServiceRegistry(true) since this handler is modifying service state. It should only be false if the handler is only reading the services.

If you don't pass 'true' to that param, the OperationContext 1) may not acquire an exclusive lock and 2) may not wait until the container is settled before running the SVH. (It definitely won't if this 'activate' op is run by itself, not as part of some larger composite op or list of boot time ops.)

For sure the above needs to be 'true'. And my guess is setting it to 'true' will remove the need for the change to ServiceVerfiicationHandler.
The previous semantic would have resulted in calling abort(null, 1) with the old method converting the 1 to ExitCodes.HOST_CONTROLLER_ABORT_EXIT_CODE because t == null. So, the equivalent semantic in the new code would be to call abort().
Might as well merge these conditionals together. It'd be easier to read as:
`return amount + ( amount > 1 ? " results are" : " result is" ) +  " available...";`
After some tests I removed this snippet. It was needed once, but it seems bo be useless now.
That commit changes the appendTo logic, but the z-index is still set. Is it still necessary?
а там кеш в usersDao, так что не страшно
I think we should provide at least the main ones (the most generic ones also), to be sure that are being used in the same way always (goto and launch ).
We can drop the other ones
`/* === Localization === */`
It would be better to separate this segment of code to a function.
are you sure linting is passing with the double quotes? :)
Same here. Which would be the better way to have access to the DOMRequest.error property if we set "this" to the UssdManager object? Thanks!
nit: one space instead of two
I'll implement it.
maybe you told me already, but why are we using a `data-type` attribute here? Didn’t you use a `role="list"` before?
@vingtetun : according to  asutherland "to/cc/bcc/subject/body all have default values that shouldn't be clobbered if they are not specified in the URI. Right now you will clobber them to be undefined, which is not correct."
This is why I added the if statement
Keep this code and disable the button at a higher level in css.
Do we have a way to listen changes on the SIM card? I'm thinking on the case of changing the SIM card, that seems to be a common use case in Brazil. 

I'm ok with the code but if we can re-call this method when the SIM status changes, would be great!
Move this part on top of `switch` at Line 101, and write a comment about it.
I knew spork was the primary library that relies on rspec's DRb support.  Spork's usage of this should be relying upon public APIs that another bit of code or library could use as well, though, right?  Can we document how the rspec DRb protocol works (as a standalone thing, without referencing spork as the only way to use it?).  I'm thinking something along the lines of "start rspec with the drb option, then send it commands by doing XYZ".

Maybe it's not possible to distill how spork uses rspec down into something easily documentable, but it would be nice to do so.
The rdocs indicate that the behavior of call changed

http://apidock.com/ruby/v1_9_3_125/Proc/call

> Generates a warning if multiple values are passed to a proc that expects just one (previously this silently converted the parameters to an array).
`minimum`?
Does not return anything so I dont have that section.
Ok, i will do that
Err, we need to combine and move this logic out of the template file.  The code is also slightly broken == 1.. I can look at this soon, shouldn't take more than a few minutes.
The idea of the original patch is to allow for customized versions of the autotest test runner, so that's why he split the _set_parsers part. Now the customized version originally planned won't happen anymore, but in any case we might want one in the future, so that's why I considered it to be OK :)
Also, it isn't clear to me that `resolveTags` is the best name for this function.
I'm not a SA expert by any means .. but you do a "fetchall" and then only take the first row ... is that what you meant to do?
Hi Tom,

dustin expressed the same valid concerns in trac #2282 already. 

I think it isn't remotely usable, but have to check all possible configuration options:  a bzr branch or mercurial clone cannot guess without help what's the preferred way to serve it, but there may a way to tell it in locations.conf. 
By default, this is the file:// URL on the filesystem. I get an absolute path with the Mercurial hook. The goal is just to have them behave consistently, but I may be misled (recent buildbot user, here). Do you have cases from hooks where this 'repository' value is actually remotely usable ?

I aggree it's a bit lame per se, but it can serve purposes if the filesystem layout  has some kind of systematic organization (in my use-cases, it's local mirrors, so it has). Even worse, I can also understand that some people would not appreciate disclosure of local filesystem structure.

Shall we discuss this in the ticket further ?
The module portability is limited somewhat by providing a name. For example a project could use 'less' as a submodule and not expose it as a 'less' global module, but rather 'my-project/less'. Local requires of 'less' would require './less'. In this way it doesn't need to litter the global namespace.

As another example, the module I use to require less files is called 'less' as well.

This allows me to include less files in requirejs with the following:

```javascript
require(['less!my/style'], function() {});
```

Where the 'less' is this custom plugin (still to be released). So that would also cause a naming collision, where I'd rather have the less compiler module defined as submodule 'less/compiler'.

It's not the end of the world but the benefits of not providing the name are the accepted best practise.

This doesn't conflict with providing the exact named "Less" global. With the shim configuration, modules are free to define any global they like, which will remain available on the global object. The global name is unaffected by the AMD name though as they are defined entirely separately.
This is ugly hack - something like a dummy file. Function getcwd() returns path to the current directory, but the findShortestPath method works with the paths to files. It behaves strangely without this amendment (see vendor_dir == working_dir).
there is a git config option that will only push the branch you're on
what you mention has been on my TODO list for a while, also to optimize some unnecessary repeated calls :) I'll take the time now since I have no choice ;)
To save PROGMEM space ow_find_sensor() should call ow_find_sensor_index() and return the address of the entry found by it.
@fzaninotto The `path` option defines the remote endpoint to send events to. They're effectively normalized so it really doesn't make sense imho to use that as a config option. Even if that wasn't the case I think path is a really weird place to define which events we want to monitor.

I would really like to see the ability to invoke the same type plugin multiple times so you could define one for pings and another for checks.
same comment as above: reduce amount of default positions and give them meaningfull names, _not_ up1, up2 and up3. can we put comments behind the list which describe the position in a few words?
e.g.
deliverup: [[0.35, 0.0, -1.725]] # moves the tray to a high position and puts the deliver side up
this config option needs a documentation comment like the others.

(clarification: this is necessary because the comments above the config declarations are how logstash generates its plugin reference docs)
Second argument of `Error` should be file uri/path/name of the error and third one the error line number.
Here it seems to be a falsy value instead. we may pass `requirer && requirer.id` instead of `id`.
What do we gain from using this mixin+functor-style mechanism instead of inheritance? For such a convoluted mechanism, a more convincing example would be useful.
Here I ignore errors from `rm` but not errors from the upper `try/catch` statement. i.e. errors happening in one of these `writeSomething` functions. I'm using `finally` as suggested in previous comment https://github.com/mozilla/addon-sdk/pull/410#discussion_r1047176
could we add a `assert.equal(wellKnown.authority, "example.domain")'` here?
Is the escapeFn ever used in templateFn? Does it need to be passed in?
I find the code hard to read. The `or` statement construct is "odd".
I think it would read better if it was:

```python
for key, val in source.items():
  if isinstance(val, Namespace):
    if self._aggregate(val, base_namespace, local_namespace[key]):
        aggregates_found = True
...
```
or am I missing something?  
Perhaps I'm just morning-dumb but I couldn't understand the point of the code simply by skimming.
How much should "expiry" be by default? A month, or forever?

By the way, should we make it configurable? (If we should, then it have to be p.m.o specific!)
extract method `remove_trailing_comments`
block是可以确定类型的，直接使用getInteger的。  另外，如果block不存在，JSONObject会抛异常，这里没处理，异常会传到外面，最下面的关闭file的逻辑就执行不到，导致资源泄漏。
For now, this should be "http://framework.zend.com/"
Yes I fully agree with this - Fixed in the last commit
Can you explain the motivation for using values -1 and 1 and not in general positive or negative numbers return by gmp_cmp ?
I think this was here so that Graylog2 can send emails.  If you don't like it, maybe at least add a comment indicating that it can be uncommented to setup mail.  Or just remove it entirely ;)
It's not clear what these are for. Magic numbers are generally something hacky.
Any reason you commented this out?
`|` is forbidden, but `_` is a good idea. Would you do that?
As far as I can tell this function is no longer in use. If it is intentional it should probably be removed. Not sure if you want it as an invoker though (as it used to be).
you should remove the ``\``
Just added this to the pullreq


On Thu, Nov 8, 2012 at 3:11 AM, José Valim <notifications@github.com> wrote:

> In lib/ex_unit/lib/ex_unit.ex:
>
> > @@ -52,6 +70,17 @@ defmodule ExUnit do
> >      end
> >    end
> >
> > +  @doc false
> > +  def user_options(user_config // nil) do
> > +    user_config = user_config || System.get_env("EXUNIT_CONFIG") || File.join(System.get_env("HOME"),".ex_unit.exs")
> > +    if File.exists?(user_config) do
> > +      {config, _} = Code.eval(File.read!(user_config))
>
> Yeah, please ignore me. Just do:
>
> Code.eval(File.read!(user_config), file: user_config)
>
> So we get nice stacktraces.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/elixir-lang/elixir/pull/636/files#r2067885>.
>
>
@yrashk In order to make `ex_unit_ansi` work with both master and previous elixir versions, all you need to do is copy and paste the code from "New API" up to "Old API".
Was more of a note for reviewers, especially @tobyS :)
This was "inherited" from the kitchensink project.  I'll review how the kitchensink pom has evolved since I forked it.
these seem a big unwieldy, it would be great if we had something less specific for passing options through without handling each individual flag
You right. I will fix it. And when size < 0 i assume that strndup should also return empty string.
This method contains a lot of duplication in respect to the getKeyString methods. The duplicate code should be extracted and reused.
Both @gvol and @lunaryorn submitted similar pull requests at almost the same time. :-)
i'm not attached, so long as it's consistent. any other votes?
I don't think we use dt/dd pairs to provide questions and answers inside other forms, so let's take out the question and just use "We value anonymous feedback, but if you'd like a personal reply to your question or comment, we need your email address to contact you. Our spam filter does collect IP addresses, but we never see them." It can be a notice or unclassed paragraph above the dl or an unclassed or footnote paragraph under the input (inside the dd, like on some tag wrangling pages). It could also go under the dl, if you want.
Not sure what this comment applies to...
Run `make lint` and fi
Missing curly braces here.
Missing ```var```
If you use \displaystyle at the beginning of your `<code>` tags with integrals, they will probably look a lot better.
why the trailing backslash? for whatever reason (maybe a composer bug?) composer configures the autoload to look inside `vendor/ubermuda/discount-service-provide` (not the missing ending `r`) which makes the autoload fail.

Removing the trailing backslash seems to make things work

btw, I'm going to move that provider to the `Knp` namespace soon
The whole point of that line is this...

    github.gitdata.updateReference({
        user: global.github_vars.user,
        repo: global.github_vars.repo,
        ref: 'heads/node',
        sha: commitSha,
        force: false
    }, function (err, resp) {
        // do stuff with resp
    });

When I tried to pass `force:false`, the parameter would not get passed because it was checking `(!value)`.

By adding the `typeof` operator, it will ensure when passing a boolean value, the parameter will be added to the request.
same here - might keep with port 5000, since it's devstack's default
Overall, it might be a good idea to add a link to an online reference that explains what this is exactly.
Solid - I will try to keep that in mind next time.
as this is only used in one place, it might make more sense to take it to a file-level static instead of a class-level static?
Me hace un poco de ruido que accedas a un atributo privado de algo desde afuera del mismo set/unset follow mode no sera mas bonito?
This is a nice, general way of doing this. Can we call `p` `params`? And remove the space. Spaces are for in between functions!
"This route responds with the following JSON:"
Probably.. it should technically be impossible to know what the `userId` is now without authenticating the request first, so `userId` should not need to be specified here.
I agree, I'll make a mental note to move that logic in there once the DAO is in
Do we need a check here for basic things like 'at least 3 characters long' etc.?
I removed this function. The UI will get back the full config and get the available log in strategies from that.
Pushed up extra checks
Considering ``assert`` can be elided, maybe it's better to throw a "real" exception, e.g., ``IllegalStateException``.
active-by-default profile are de-activated automatically when a profile is specified from the command line, so its content doesn't act as default values.
Also, profiles cannot extend or trigger each other, so it is not possible to create a hierarchy.

Then all profiles would have to contain all values, or the user would have to trigger the build with a list of profiles to apply (in the right order).
`validateReturn` 达不到想要的效果，因为 `validateReturn` 是验证和样式的处理是一起处理的，`:checkbox:checked` 会被跳过，即使这一个组是 `invalid` 的。

所以我把验证和处理分离了出来，在 182L 里单独调用。

而且在 171L 已经有一个 `validate.apply` 了，再调用一个 `validateReturn` 不划算。

我这里的思路是从 `validateReturn` 的单个元素验证改成一组元素验证，验证完统一修改样式，所以封装一个可以复用的 `packageErrorObject `。
also, it's spelled IPython, according to http://ipython.org
Are you sure 'this.value' works? I'd imagine in tis function 'this' would be 'window'
What would you recommend? I could break out the utf-8 trimming to a separate function and use 'return' instead of 'break', but that's pretty much exactly the same thing. :)
Isn't that if useless? In the return statement it is not checked if any of the return values are set.
Maybe it's better to add a check after geoip_record_by_name call and assume after it that every parameters are correctly set?

```php
        $results = @geoip_record_by_name($address);

        if (!is_array($results)) {
            throw new NoResultException(sprintf('Could not find %s ip address in database.', $address));
        }

        $timezone = @geoip_time_zone_by_country_and_region($results['country_code'], $results['region']) ?: null;
        $region = @geoip_region_name_by_code($results['country_code'], $results['region']) ?: $results['region'];
```
'php' already is in there - replace it instead, and add a changelog entry.
Здесь, я, немного не понимаю. Если я переопределяю родительский init, то при любой инициализации, через init, объект, будет инициализироваться значениями, заданными мною. А если этого не надо?
Спасибо.
К сожалению не согласен с  nanotears, хотя условие задачи было "мутновато".  Поставлю 8 балов.
@iamqq метод должен заменить строго х% исходной последовательности. Проверяется это условие очень легко: выводим ДНК до изменения, запускаем изменение 100%, выводим полученный результат. Метод будет удовлетворять условию тогда, и только тогда, когда все элементы будут заменены, то есть, полученная ДНК будет на 100% отличаться от исходной.
You shouldn't check for the indoors flag here. Indoors just means "without weather or sunlight".
perform_analyze() uses the skill level of ch to display various information. If you want to use it like this, you'll want to change it so you can pass the effective level as a parameter.
`Thye` typo
Heh, you're right, it is overboard.  Way overboard.  More interesting things to work on.
2007-2012, to be consistent with other entries ?
`event` is a reserved word in Javascript.  Please use `evt`.
他の行と同じく、追加した行の前後には空白行を含めたほうが良いと思います。
Why doesn't this merely call `retrieveUserImages()`? Looks like the logic is nearly identical.
Fair enough, was a leftover from 'not title', will be changed.
Yes that makes sense
Noted! Removed the test.
In general, splitting lines at the 80 character limit is useful for others that don't use wrapping editors, also makes referencing a word here or there easier. :) Sphinx/rst will recombine lines into a paragraph if there are no blank lines separating them.

I wrote that to write this: We generally use a single space after a period before the next sentence, not two. It makes for cleaner rendered text.
It just seemed convenient to stuff all those in a single module. We could refactor it later perhaps?
you should describe the full syntax here, showing how to pass a priority and how to register several listeners for the same event in the subscriber
默认配置时，
没这意思啊。
why get or else instead of a simple pattern match?
Just to make that more clear: `$default=null` should mean there is no default, therefor no default brackets will be displayed and we get what the user typed, also if it is empty. I agree with @qiangxue is has to be `$input=''`.
too specific to mit setup. you can assume that the user has their ants environment setup properly.
ну, элемент Trash. И не понятно что хотел пользователь - кинуть в мусорку
или в корень.
Да ты упоротый.
máquina (estoy probando los comments más que nada)
oh great, that's a good thing :)

will do that.
The alternative was
Sketchup::require File.join( CommunityExtensions::STLImporter::PLUGIN_PATH, 'importer')
Sketchup::require File.join( CommunityExtensions::STLImporter::PLUGIN_PATH, 'exporter')
System() only works via AGI, so we would need to wait for the first call. We could wrap it up into the Record component, and return an error in response to a request to record instead. I actually prefer this approach to an app global one.
You could use $app['file-system'] service to be consistent & allow mocks
Remove these brackets please.
Is that ok to fail to scale the image? If it isn't, we should record a warning (`Log.w()` or an error `Log.e()`), and in any case we should store the traceback as well, as in:

```java
   Log.e("ImageHelper.scaleBitmapToFitDisplay: failed to scale image", e);
```
I like this generalization!
What the is an `assert true` ???
It's not going to verify that this is properly executed or anything like that..
so this happens when the commit is sent for a transaction that hasn't prepared on this node and was  migrated during state transfer?
I guess some comments describing when this code happens would be helpful for further reading.
Right, I transformed this into nested IFs to ensure isKeyLocalToNode is not evaluated for both CHes if not necessary.
I've created https://issues.jboss.org/browse/ISPN-2205

Truth be told, I didn't realize we needed a protocol change until I had already written the new DefaultConsistentHash. That's why it's not documented...
About testing: I did run some tests to check that it's not completely unfeasible, but I still have some work to do before the hotrod client test suite is green.
possible., but that would expose the sync to outside world though, which is slightly more error/deadlock prone. The benefit of doing that would be small as this lock is a single final object per HR client instance.
I'll answer myself: because if the table is empty it would not work
According to doc/api/api_changes.rst, bbox_all() should be changed to Bbox.union()
Can you just add one extra blank lines for pep8 purposes? I haven't yet pep8-ised this file, but this will help !
I suspect all of these type tests could and should be modernized, perhaps in a separate PR.  I think the number category info can be taken very directly from the dtype now.
just make sure to add a comment once you're finished that I get a
notification

On Tue, Aug 7, 2012 at 4:36 PM, François Thillen
<notifications@github.com>wrote:

> In testproject/Protocols/TCP/TCPProtocol.cs:
>
> > @@ -0,0 +1,98 @@
> > +﻿using System;
> > +using System.Collections.Generic;
> > +using System.Linq;
> > +using System.Text;
> > +using System.Collections;
> > +using Org.Openengsb.Loom.CSharp.Bridge.Interfaces;
> > +
> > +namespace Org.Openengsb.Loom.CSharp.Bridge.Protocol.Tcp
> > +{
> > +    /// <summary>
> > +    /// Simulation of the TCP protocol
> > +    /// </summary>
>
> ok. I will include them today or tommorrow. Should I do a diffrent pull
> request?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/openengsb/loom-csharp/pull/23/files#r1321857>.
>
>
Demostrates the LayerGroups functionanlity on the LayerSwitcher... or some description on that way.
need moar spaces!
If you want to respect a specific one, use the `int-struct` or `long-struct` functions. If you do some testing at the repl, I think you'll find that you're not actually creating the values you think you are. Try `(class (int 10))` to see what I mean. `int` is just a hint that's respected when you're making calls to java methods.
Fixed: 4377f5a
We shouldn't be using any `!important` in this file so we can override it later.

Apart from that we should change (the lines that have changed) to use 4 spaces instead of 2
This seems like a 'hacky' solution. Do you know what the root cause is of the rows being strings and if we can avoid it?
Could you revert this for now? 

I'd like to keep the API a bit more explicit as this is quite new, and people in the PHP world are not really familar with this kind of return type yet. 

We could consider adding this some time in the future. I can see that it might be useful when you convert an existing API to use option types, but as I said for now I'd like to keep it a bit more explicit.
currently, we only have alpha releases for 1.1 (but doing a stable release would be a great idea)
Unfortunately, this isn't a foolproof way to get the correct last resort size for these two font rulers. It breaks down on Android, where the last resort fallback is determined by the last thing in the font stack (falling back to sans-serif if there's nothing recognized in the font stack). In addition, after some more research, I determined that on Android, the last-resort fallback for a given web font name is determined by the last thing in the first font stack where that web font name is used. Thus if you have

    STACK_A: '__webfontloader_test__',serif,sans-serif
    STACK_B: '__webfontloader_test__',sans-serif,monospace

Then both stacks will measure the width of `sans-serif` for the buggy period. However, if you use two null fonts and make each name different (like `__webfontloader_test_1__` and `__webfontloader_test_2__`), then they will each measure according to their own last item in the stack. What crazy logic!

Suffice it to say that I think the only totally accurate way to determine the last resort fallback size that we should ignore for each ruler is to actually measure that last resort fallback size using a fresh null font for each pair of rulers. So much about the measurement of the last resort fallback is determined by the context that that seems like the only really safe way to measure it.

I think that means that we can move detection of the webkit bug within the FontWatchRunner, since we basically have to re-detect it in order to accurately measure it.

Now, I think that what we have here actually works today just by coincidence, because Android has `sans-serif` as the generic last-resort fallback that you get when you use the `""` font stack, and we also have `sans-serif` as the last thing in `FALLBACK_FONTS_A`, which is the first CSS rule with the webfont name that the browser encounters. So it *happens* to line up today, but it's not necessarily guaranteed to on another platform.

Are we OK with that happenstance, or do we want to try to make the approach more bulletproof? I'm not sure what to do about that.
"write changes" -> "write a change" (to match "is" in (a) and (b).

Why won't the __wt_txn_init() leak the memory allocated for txn->snapshot from the previous __wt_txn_init?

We don't need to save & restore the transaction unless was_running is set, why do that, 40+B of memory being copied twice.

I'm really confused why we're checking was_running to see if we destroy or commit the transaction.  Why is that a test of was_running?   Hopefully it will become clearer as I continue on... :-)
Oh and after reading the log:
<imkingdavid> naderman: writing these tests for stuff I've already tested myself is more work than imo it's worth

This is just not true. It might be faster to just manually test something right now. But the idea behind autoamted tests, is that other people who don't even know will be able to run these tests with a single command in a few years after they have made changes, to be sure they did not break this feature. That way a large number of regression bugs are avoided. So spending extra time now, will save much more development time in the more distant future.
@nickvergessen I don't believe anything could actually break from changing it here.  truncate_string's only purpose is to ensure that a string's htmlspecialchars() representation does not exceed the DB's storage space, and that function is not affected by this change.  Therefore the only harm possible is a broken layout if the text wraps.
看起來很像是拼錯字了.....|||
remove spaces inside parenthesis
I bet you could pretty easily refactor this method by inverting some of your conditions and returning home early.
Nimm doch da eine LinkedList, muss nicht synchronisiert sein
what? würde ich weiterdelegieren an den node
Expected a string but was BEGIN_OBJECT tends to be a bytebuffer, which is the return value of all the CouchMetaDriver slot methods for consistency sake (all marshalling should be done in DbTerminals using hard ByteBuffer assumption.  should go back and change visit() to match...)
This may work fine on the Node.js side and in modern browsers but the older browsers (e.g. IE <= 7) [don't support `querySelector`/`querySelectorAll`](https://developer.mozilla.org/en-US/docs/DOM/Element.querySelectorAll#Browser_compatibility), thus the original need for Sizzle.

Would you like to axe support for IE <= 7?  It's a reasonable option since most IE7 users could upgrade to IE8, other than corporate/government workers with locked down IT.  However, we should probably actually discuss an official stance for browser support.

For the record: personally, my day job involves web apps that unfortunately still have to support IE7 (:-1:) and yet would like to utilize the upcoming new-and-improved ZeroClipboard.
If it's an empty query, it'll be returned and get the empty instance logic.  (I think it's consistent with other usages)
Yep you can merge it yourself after you fixed this, all the rest is great.
Then you should pass the correct directory directly.

If one would use another directory (you may have a completely different directory structure in your project) it will be annoying that the directory is changed this way. For example I would like to have that image being generated into a temp directory as I will upload it to Amazon S3 afterwards and delete the temporary file.
this file should be dropped: there is not testsuite, and no vendors.php script
Still in English. Same for the line below.
Ah, so just like Akka.  Good to know.  We were afraid the plan was to touch `Predef`.
Sorry, I had that overlooked.
Yes, ```with open()``` would have worked, but (a) I wanted to keep the changes minimal and (b) I wasn't sure whether it would work in Python 2.5.
Not sure. It worked on my machine, but thats quite recent. I suppose we could leave this out for now - it only generates a warning on 1.9
yep:

[gsutcliffe@osiris modules]$ irb
irb(main):001:0> str=""
=> ""
irb(main):002:0> str.empty?
=> true
Lowercase *Password*?
This does not really wait for all tasks to finish. If you return a set of pending tasks with return, you can do something like:

```
        results = tasks.generate_weather_tasks()
        prev_completed = None
        while not results.ready():
            completed = results.completed_count()
            if prev_completed != completed:
                self.stdout.write("Completed %d/%d.\n" % (completed, len(results)))
                prev_completed = completed
            time.sleep(1)
```

So we call `generate_weather_tasks` directly, we do not invoke it over the worker (as it just spawns subtasks, we can afford that). Because of that, we get access to the result, and then we poll status of tasks.
I was testing the right code but I stashed it because I made too many changes everywhere. Then I wrote this again (and made a typo).. So it should work...
Wouldn't it be better if you could just pass in backend and node, and `get_full_node_id` would extract full name and id?
And then you can simply in the template check if there is any data in `stations`. Which is not really necessary an error, simply maybe there are no stations around.
*template* -> *templates*
And you can propose a better semantic-full model.
Then i create dict?

2012/6/17 Mitar <
reply@reply.github.com
>

> > +    ('gemini', _("Gemini")),
> > +    ('cancer', _("Cancer")),
> > +    ('leo', _("Leo")),
> > +    ('virgo', _("Virgo")),
> > +    ('libra', _("Libra")),
> > +    ('scorpio', _("Scorpio")),
> > +    ('sagittarius', _("Sagittarius")),
> > +    ('capricorn', _("Capricorn")),
> > +    ('aquarius', _("Aquarius")),
> > +)
> > +
> > +class Horoscope(mongoengine.Document):
> > +    sign = mongoengine.StringField(choices=HOROSCOPE_SIGNS)
> > +    language = mongoengine.StringField(choices=settings.LANGUAGES)
> > +    description = mongoengine.StringField()
> > +    date = mongoengine.StringField()
>
> Of course will not know. You have to tell him. ;-)
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/wlanslovenija/PiplMesh/pull/228/files#r998604
>



-- 
Domen Čebulj
http://cebulj.net
http://olsevek.si
OK. This is misuse of the API. Here you should or fix dependencies or display an error. You cannot do both.
Indentation here is misleading, we are no longer in the else if block, but our indentation is the same.
Shouldn't this be breaking existing validation ?
Normally, you don't have to implement the IConstructorQuery interface. That interface is now used only for backward compatibility. You only have to implement IMethodQuery here..
This bracert should be in previous line.
How to declare, when compiling an error, undeclared identifier   print_cheat_status
Is it possible to still send the request.GET into the YearMonthForm and do all of the necessary defaults for month/yeary/user there? I think it could be a lot cleaner to have something like:

year_month_form = timepiece_forms.YearMonthForm(request.GET or None, initial={'request_user': request.user})
if year_month_form.is_valid():
    from_date, to_date, form_user = year_month_form.save()
else:
    from_date = utils.get_month_start( .....

It might also be worthwhile to investigate putting these default month and year into the form itsel
this is wrong. It is an attribute, not a tag
wireless should be in wireless section (or is it the switch that is in wireless section?)
parens not necessary here :)
When you use parentesis you don't need the plus sign
I wasn't referring to alignment, I meant that if you use the constant as the property name, the name and the constant value will always be in sync, even if you re-order the values.
I guess this should be on the prototype btw.
Can be simplified:

```python
    binaries = [b for b in binaries if b != el]
```

and then you can drop the comment since it's clear what it is going on.
This may may also be caused by AUTO_NAME_DIRS being enabled, since you are creating a named variable by running ``export hello=/var/lib``.

Sorry can't test this myself at the moment, as I'm a system that's running an older ZSH
duplicate to higher up on page
try for example  (z is exog_full)
z_pinv = pinv(z)   (nobs, k_exog_full)
xhats = (np.dot(Z, np.dot, z_pinv)) for equ in ..]

smaller arrays but an extra dot product for each equation

we might need an option here to calculate it different ways depending on the size of the problem

suggestion: move first step estimation into separate _method that returns the xhats, so it's easier to add options for this
Is there something special you think a plot method should do? If it's just ``plot(x)``, which plots estimate(x) vs. x on a linear scale then I don't think it adds much.
Well, you can actually pass a file handler (as an IO-object) into `YAML.load` or even a file name directly into `YAML.load_file`. That might be more efficient, I think.
Maybe this is a deficiency in the docs specification? What if I added

"params" : {
  "cx" : "The x coordinate of the center of the image".
...
}

Also, I was thinking of replacing many (most? all?) of the external references to pointSize with radius. WDYT?
ahhh, this is sloppy for sure, the line should actually read

```js
var bindMeat = function(element, model)

....

var bindIt = function(elt) { bindMeat(elt, binder); }
_($(".meatglue").find("span[data-name]")).each(bindIt)
```

the i (and idx in bindMeat) are also superfluous, but they're the args that are passed to iterators. It makes more sense to change it along these lines rather than leave these dangling arguments that serve no purpose.
He improved his code! :D

https://github.com/ahmedalex/CoderDojo-Kata/commit/714977dbaa41c0fec7959624554ebc75e29604df
Is this the normal definition of beta?  I thought beta was normally the complex argument in (e1,e2) space.  In which case no "2*" here.  (beta = 2*theta).  If it is the normal convention to use beta as the real-space angle, then one of my above comments is wrong.  

Either way, I think the distinction merits a bit more explanation in the docstring above to make sure the user knows what to expect here.
Sorry.  I started this file by copying the Airy version and forgot to edit this description.
```brew install ffmpeg``` but yeah, I'll write it upda
Initial size can be ownConfig.size() rather than `+inheritedConfig.size()`. And could create copy with with `return Collections.unmodifiableMap(Maps.newLinkedHashMap(ownConfig))`
It seems mixture from somewhere. I will delete it.
Honestly I think we should just remove the `rescue` and let it blow up in the traditional way.
For example, what if the user wants to pass mongodb as the provider, but there was not `mongodb::server` class? What about adding something like:

<pre>
validate_re($provider, '^(mysql|postgresql|another_supported_provider)$',
  "${provider} is not supported for provider.
</pre>
variavel ```antes```
Is this match case-insensitive (HTTP spec says it should be, but it often isn't)?
parameterize on underscore, but wouldn't sub('/', '_') suffice?
well its an age old question .. which imho hasnt been clearly defined.
.gitignore this too
He can't. He fix the homescreen.html page that bottstrap the real homescreen. 


But I still see some white when killing/restarting b2g. It should a few others places to fix. Maybe the main shell.xul file?
Are you sure ``$values[3]`` will always be a string? Why not use ``empty($values[3])`` instead so you also consider ``null``?
We're not using predicate_result here. Fuel for my argument of making this a single return code function that can potentially raise an ActionError exception. :)
again, better to use visibleBounds
Yep, no need to keep the commented line but it might be worth leaving a note that Mike Smith did tests and found 64 to be around the number of manually clocked bytes where setting up a DMA transfer is cost equal.

BTW what is the problem with F4 DMA?  I didn't know that was broken and I use it (via the pios_overo driver) just fine for overo logging.
Can you alias this to `__bool__`, for Python 3?
Off-topic question: Should we make the Pipeline class final as well?
这里的event不需要到view 展示吧？如果不需要，不需要声明instance variables
А если сообщение длиннее?
Со строчной.
A direct copy from test.rb. The environments will probably be very similar, but this is how rails sets up new environments.
Why can't you catch curl exceptions in a separate catch block?
What is this commented code for?
I'd rather not even have this file in here, let alone being updated.
On 10/10/2012 11:05 PM, Mike Arnold wrote:
>
> In manifests/if/dynamic.pp:
>
> >    $bootproto = "dhcp",
> >    $mtu = "",
> >    $ethtool_opts = "",
> >    $ensure
> >  ) {
> > +
> > +  if ! $macaddress {
> > +    $mac = getvar("macaddress_$title")
> > +  } else {
> > +    $mac = $macaddress
> > +  }
>
> Why not write this like:
>
> |   if ! $macaddress {
>      $macaddress = getvar("macaddress_$title")
>    }
> |
>
> And drop the use of $mac?
>
>
<face palm>. Indeed, why not.  Do you want me to fix the pull request or 
will you fix the patch yourself?

-Josh

--
No need to convert to a specific output type.
Crap, I wanted to believe I could just make a small code edit to give us Passive Aggressive.
Yes, that's the same thing. What would be dangerous in doing that ? Having a non symmetric matrix at the end ?
That looks fishy. Unless an explicit condition check induces a significant performance regression I would rather avoid using the `1e-10` offset and compute the exact kernel value instead.
> @GaelVaroquaux What's your opinion about this renaming, from mode to
> eigen_solver and eig_tol to eigen_tol :)

I prefer the new names. We need to check: I think that eig_tol has been
added recently, and thus does not need backward compatibility.
End this line with "::" instead of ".".
This isn't D1 code, it's under `DMDV2`.
Is there a "Part 2" Jira for the rest of this stuff?
Thanks, I didnt know of the hint capability.
Il faudrait rajouter un état (enum) pour: new, fixing, fixed, won't fix, duplicate.
Dans la side bar on afficherait que les unfixed (new or fixing)
Le pole info pourrait changer le statut d'un bug
It's not supposed to be preserved across submissions. The user enters '123,13,199' and '12,313,199' should come back out.
you could use the <tip> tag if you want to. Up to you, make sure to render it to see how it feels.
It could be a good idea to name them done() instead of release_all(). Then when merging the newer core, we'd just change the format struct and remove the atexit() and we're set.
Well, we wanna stay backwards compatible but the more important point is that these files currently is just the old .css files renamed to .less files, nothing else has changed. Why I am mentioning that is because these vendor prefixes is going to be handled much more elegantly now that we are using LESS.

There will be a mixins.less file that will have all of these items such as border-radius etc. defined and the vendor prefixing will be done there.
I'll just revert the .gitignore changes since you handled that elsewhere
We should follow the pattern other views do with a class-level messages dictionary.
@radar any idea why we are not using @order.complete! to preserve order's state callbacks ?
why ``== 1`` ? There is a failure for `` > 0``, not only for ``1``
I am not sure, I essentially copied that from the posts collection. 
Afaik that url there is never really used for fetching data from the server (but I may be wrong about that), at least nowhere I would stumble upon it...
answer of first question : I am cathcing null pointer exception because no one cell can be null in any condition so expliciltly  I want to throw null pointer exception.

answer of second question :  I have give if condition in which if value ==null then definitely it will come to catch block.  mean throw point
Ah, naughty! Don't confuse our lovely contributors on purpose, @jvazquez-r7 !

Yes, the 200 column width needs to stay for regexery (mostly). That said, it would be nice to see msftidy enforce the shorter max width for descriptions.

And with *that* said, there is no reason to fix msftidy in this pull request for a Lotus Protector module. Please revert those, or @jvazquez-r7 or @wchen-r7 or whomever, when you land it, leave out the unrelated bits.
use ```write_file``` instead of a bunch of ```echo```s
You're right, up and down won't work.  But expand and reduce don't seem to be the correct technical terms either.  Should we use ``downsample`` and ``upsample``?  Any other suggestions?
i agree that it could be moved. but what's the error...it doesn't happen when i run the tests locally...
I think these should have always been copies, and that `setFillColor` and `setOutlineColor` below should also copy.  Those functions and perhaps others elsewhere (the tests come to mind) could benefit from `Color.equals`.
This sort of thing is a valid JavaScript optimization to avoid allocating temp variables, and is something we should do more often where possible.  JavaScript is single-threaded and will always be.
I tried creating an array of references to polylines like you suggest because this would also speed up the render method. iterating through an array is faster than enumerating through the map. It cleaned up the get and getLength methods but made other methods like remove messier because of having to keep track of two different structures.
I hope so, but it seems not easy to do