labofsahil/github-event-dataset-2012 huggingface dataset:
The user may also set this value to something different in his controller.
Please take the opportunity and put in some spaces inside `{}` :smiley:
lol. I didn't change anything. I think it was the correct way.
no need of parentheses
Yeah, but technically `StandardError` should give you this, if it's inheriting, not?

```ruby
>> StandardError.new('foo').message
=> "foo"
```
Sure, thanks for catching it. Fixed in forthcoming commit.
The test is just copy/pasted verbatim from the bug report. No idea what was the original cause of the problem - this bug has fixed itself over a few months.
Yes, as I already commented above, there was a duplication of methods and data.
You should write `_print_contents`, `_print_contents_pretty` and `_print_contents_latex` methods. On the note of printing, you should add tests to the `test_printing.py` file with objects from each class. It should be straightforward on what you need if you take a look at it.
you can write just `if n%2: blah; else: blah;`
On 11.06.2012 15:33, Christopher Smith wrote:
>>           return K1.from_sympy(a.ex)
>>
>>       def from_GeneralizedPolynomialRing(K1, a, K0):
>>           return K1.from_FractionField(a, K0)
>>
>>       def unify(K0, K1, gens=None):
>> -        """Returns a maximal domain containg `K0` and `K1`. """
>> +        """Returns a maximal domain containg `K_0` and `K_1`. """
>
> containg->containing
>

done
This are 3th-party things (3 images and one stylesheet). Do I have to remove them?
I don't see you setting the package name anywhere
Why did you change indentation level for this block?
+1 we want to implement `__eq__` only for what Python considers equality -- the case @eteq mentions above (`self.radians == other.radians`).
@stof OK, thanks.
Is it a good practive not putting parentheses ?
I don't think slash is needed here because the string is using double quotes.
" kuku 'kaka' kuku" will be ok. Please check.
at line 95: typo: Managment --> Management
there's a funny story about the term "aspirational documentation."
Chrome does not URLencode the "+" character when sending data to search engines.  Vomnibox should behave similarly.
Oh yeah, thanks.

Yeah, as I said in the commit message, i hadn't tested it. I was working away from my normal computer and didn't have a test environment set up. Looks like I just forgot to include the class file.
Add `.` at the end?
The variables with l_ prefix like $l_search_title and $l_search_matches are just control variables for a language key to be or not to be displayed. $l_phrase_search_disabled does the same. Should this be changed?
You can't expect people to remember stuff for months, unless you push it.
What is `$k` here? Try to pick a better variable name.
=== 0 ?
Use sql_in_set and a single delete per table.
Oh, I see, vi seems to add new lines to the ends of files when it can't find one, thanks >_<
For the record, the commit itself shows just the ©. I have no idea why the Â is being added in this diff and not that one. it does not appear in the file itself either.
This does not look like the UTF8 equivalent of `&#133;`. See http://www.fileformat.info/info/unicode/char/85/index.htm
Maybe unescape -> decode? I realize pg function has unescape in its name.
Yeah, caching could (should?) be done for the rendered pages.  It doesn't really make sense to cache at this level unless we are doing other things with the data.  It should be an easy change.
I asked,
Done: In master, production.
Accepted: Branch LGTM'ed, not merged, but work done.

Process is
"-" / EAP Blocker -> In Progress -> Accepted -> Done -> Closed
I believe this criteria should be revised with Hartsock's permission.
Should this be left like this?
Yea findWhere is much better.
Do we need them separated here? Public and private is mostly just a distinction for our business operations. From a user/client perspective they are just all "extensions."
Sorry. Meant "read json" here. We seem to do that a lot :). This routine did a bit more than pure read, but not much.
scripts.start is what you enter if you want npm start to do something other than node server.js. we no longer need that redirection to ensure npm start will start mojito consistently.
Плюс ко всему, смешана логика котроллера и работы с баннерми
This meta tag is needed to get IE to behave correctly. Much of the current skin doesn't render right in IE's compatibility mode and without this flag the users browser will use the 2nd level domain wide setting for compatibility mode.
There will around 50 server variables per request. And I found it tiring to loop through 50 to go to the line after foor loop.
And that code will 100% never through and error or need to be debugged.
Ah, perhaps these aren't as necessary in the test spec. Never mind, seems fine.
Eventually will want to add patient image ticket here, however it is not created (far in the future after all back end is done on this)
yes, but that is for the dateCreated one. When making REST calls, the ISO standard for date is used and that will be used by the client.
That needs to be saved as part of the searchQuery string
test rankUpper(7), rankAsc/ranUpper(0), and rankAsc/rankUpper(12)
I don't understand. Any unrecognized keyword is interpreted as SELECT?
move  to the bottom
Need one more test for nested include
<pre>In order to avoid a dependency between a module that handles post processing stuff and a module that handles db related stuff I used a factory.</pre>

This is totally unnecessary. You don't need to do this. And please explain to me what is wrong about a module (which calls the post processing) importing two things: a module containing the post-processing logic, and a module containing ORM code (i.e., models.py).

<pre>There is also another minor advantage. The post-processor does not know anything about the OqJob and its interface. </pre>

The "interface" for OqJob (apart from the generic functionality inherited from django's Model class) is 11 fields (including foreign keys). That's it. If we add/remove/rename fields, it is reasonable that we need to update the code which references those fields. I don't see what's so difficult about this.

<pre>More your module/function/class are independent and decoupled more they are maintainable.</pre>

This is a very broad statement. Please explain to me how this applies to our codebase. So far, I have not encountered any serious maintainability issues (except for the ones that we all, as a team, recognized and removed) in this regard. I've been working on this codebase for almost 2 years. If you have some specific issues in mind that are causing real problems, please, I would like to hear them.
@marchof  I will change it to use "ratio" instead of "rate".

As far as using percentage values vs unscaled ratios, I guess that is more a matter of personal preference.  I personally like the percentages because that's what I use when I'm talking about coverage with colleagues so it translates well.  I mean I would never say "make sure you've covered 1.0 ratio of classes."  I would simply say "make sure you covered 100% of the classes."

That being said, I could see the argument for ratios as well so I'll defer to whatever you would prefer.  Just let me know.
It looks like a number of people have already confirmed the crashing behavior with `animate` on several devices and versions of 2.3.x in the bug thread: http://bugs.jquery.com/ticket/12497
@cmcnulty The use case in the bug (and this) is definitely a legitimate bug. I'm wrapping up a patch that is significantly smaller to address this issue.
Nice catch here.
Forgot to check it in. Fixed
Is 0 a valid number of iterations?
What we mean here is that we will create a PL/PGSQL function for this c function, as you can see from the following code.
{code}
CREATE OR REPLACE FUNCTION MADLIB_SCHEMA.__ebp_calc_errors
    (
    total                       FLOAT8,
    prob                      FLOAT8,
    confidence_level    FLOAT8
    ) RETURNS FLOAT8 
AS 'MODULE_PATHNAME', 'dt_ebp_calc_errors'
LANGUAGE C STRICT IMMUTABLE;
{code}
Well, if madlib isn't in the path then it needs to be a qualified operator, so:
```(a.set_list OPERATOR(madlib.+) b.set_list) OPERATOR(madlib.-) (a.set_list OPERATOR(madlib.*) b.set_list)```

Which I guess is a little more succinct than calling the svec_minus functions directly, but I can understand the reticence around schema qualified operators...
Could you check the expected output coefficients? Is that not converging because of the hard-coded stepsize?
Change to 2 spaces.
Change `:compressor` to `:compessor` and watch the spec still pass.  You need to set some expectations to verify your methods are being called.
I'll contact the author!
Homebrew switches to sha1. I just put `sha1` there, let if fail and copy the "Actual" hash homebrew spits at me :-)
I guess that I was wrong: we shouldn't return a Niimg. The logic should be, in general Niimg in, Niimg out. In this case, it is not Niimg in, it is array in, thus it should be array out.

I suggest as a naming convention that everything that is an nimg ends with '_img' (and I suggest renaming the input epi_img variable to mean_epi to avoid confusion).
This is great. I think it would be useful to include the original error code in the message since this can be useful if one is searching the web for error and bug reports.
un seul block try catche peut suffir. Pas besoin de la verification du statement tout seul à mon avis
This means that index_en_US.html will never be used. Is this correct? I think that if the language is en_US and index_en_US.html exists it should be used.
Ios tastatur :-)
This should be a separate commit.
What happen if it return null?
I didn't remember it can return null, returning null may break the other? Have you check this?
Or maybe throw an exception would be better?
哦亲体很好
I do not really like that field. I i am asked I would remove this line and assign new Class<?>[0] where its needed.
Should this be `get('id')?`? Wouldn't this always eval to `true` or `false` and thyen try to call `_withoutDirtyTracking` on it?
Negative, just wasted cycles in this case. You might want to null out something if you still want the key in the object for iteration, or you might want to delete something if you dont want the key in the object for iteration, but never both.
Right, as I said, it would only be to protected plugins from each other.
Okay. I am assuming this is all set then and will be accepted.
I notice that this can highlight multiple substrings in an item, which seemed a bit weird. Is that intended?
One more minor nit. If I remember it correctly, Japanese UI strings always have a space before ``:`` for most labels in UI. If so you need to have one for this string.
Since you're already changing this comment, here's a typo: "going to changing" should be "going to be changing"
Oops, actually expectHints() already runs that assertion before returning it.  I'm not sure we'd gain anything by doing the same check again...
@redmunds Yes... I was planning of adding it next, as it's required to finalize the sidebar refactor.

Panels using the `makeResizable` API can already set a minimum height. For the other ones, I was thinking of using a `data-minSize` attribute in the elements.

Would that be enough or do we still need an API to change the minSize at runtime? I would expect minSize to be set only during initialization...

Should I add it now, or wait to do it with the sidebar refactor final step?
ここどういう理由でlayoutの履歴を残したりensureしたりしているのかまだ分からない
Uh wtf, sync code?!?!?!
If I set current to master, I can just look at `ActiveRecord::Base.connection_proxy.current.name` with marginalia instrumentation to log the connection with the query. It was the easiest way I could find.
What is this change? I'm assuming you mean to match that CONFIG_FILE is required, in which case it should have the square brackets removed, but I have more comments on that below.
Is there a reason that this can't just be the way that hooks actually works?
since it's statically defined this should actually use ugettext_noop
the parenthesis are unneccesary
thin arrow should be enough
can the 'id' param be renamed to something a bit more descriptive?
maybe edit to 'getDataLocationsOfLocation' as I think 'group' is an older reference dhis stuff
the above two lines can be condensed with jquery:

```
$('#flipurl').focus();
```
I'd rename the *default* parameter into *default_sorting*
*Ponastavi*?
`ModelForm` does not support mongoengine backend.
Could you do this in TomDoc style? I'd love to have everything converted to that in the long run.
s/are/a/
this should be rgba.... not rgb.
Also our convention is (r, b, b, a)
Why are you creating a function that is only called in one spot?

Let's reduce the call stack and just pu the code in here.
Sorry but the rest of the file is like that. I stuck with that to make it consistent.
I actually do this in ticket #2297 :)
shouldn't need to do `newText  && newText !== "" ? newText : trackEvent.popcornOptions.text`. Can just do `newText || trackEvent.popcornOptions.text`
is there no element for zoom? We should probably have one.
javadoc could be cleaned up. There is no user agent 'passed in' for example, it comes from getUserAgent
Locally fixed.
Ok, removing and adding additional validation for two possible values.
I'm not exactly sure what to perform there since so far this has been proven to be a very one off error.
Actually it is (even if not completely obvious).  This function is looking for conflicts between a key's environments and a key's system groups' environments.   If the system group's environments are empty then there is no conflict.  If the system group's environments are not empty, and key's environment is included, no conflict.  If the grou's environments are not empty and the key's environment is NOT included, there is a conflict.  

Some more verbose psudo code:

if group.environments.empty?
  no conflict
else if group.environments.include?(key.environment)
  no conflict
else
  conflict
FYI: you could make this shorter:

```ruby
post :refresh, :on => :member
```

Your way is better though if you're expecting more member actions.
I think that yes. I used buffer handler and send big log and "substr($log, 0)" copy this again to memory.
If there is null it means that there is no actual hub instance and invoker delegates are being called without target.

This scenario may happen only when someone customizes SignalR. Eg. create dynamic hubs at runtime - right now such scenario would require passing some "stub" hub type in the descriptor so activator would not throw an exception.
Just do new UTF8Encoding(), the default is false.

Update ForeverFrameTransport as well as it override this.
I was loose at some point with |w| and |d|, let's give them a better name
Can you open an issue to remove this comment and the code in the keyboard code?
Same here (use a constant).
Could also use `lists:flatmap` instead of comprehension + `lists:flatten`
Here it's buffer again, too ;).
I'm not sure this is right. When the receive version is set, it is only applied to new messages. In practice that probably doesn't mean anything, as the version/verack message order is quite strict.
Using one "proxy info" lock would be enough, no need for a separate one for the nameproxy.
Shouldn't fImporting be set here?
rather than storing these on the App, the MockWidget class could have a registry similar to QtObject and WxObject
The constants are the subset of [Shell grammar tokens](http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_10_02) chosen for simple command subgrammar.
Useless if we use a boolean.
Why is this a bug fix? The change just adds an 'expand' class to the textarea so javascript picks it up and loads the inlineTextareaEdit plugin.
Awesome; can you wrap this line to 100 characters?
`Hasie::Mash`を使いたいという強い意図を感じたのでそのままにしてありますｗ
Have set to 4k.  Will double-check if there is a page size value I can query.
explain the change. Not sure I completely understand it
`jsp.is_identifier_char` could be used instead.
Not sure, but I reckon it might very well need to be. It is up to the privacy folks really
"these". The wording could probably be better anyway, like "First, learn `how to write good git commit messages`_.". Also needs a period at the end.
Aw, man! Now it fails!
By changing this class to overriding `run` instead of `main`, you don't have to reproduce the complicated backfill algorithm implemented in `BaseBackfillCronApp.main` if you want transaction behaviors in a backfilling operatin..  The superclass `main` method always invokes the `run` method with a consistent signature, a single date.  The actual meat of the work is implemented in `_do_my_postgres_work` where your are free to set the signature to anything appropriate.  This avoids polluting the `main` or `run` public interfaces with arguments that are inconsistent through the inheritance tree.
this seems okay to me
Is that a horrified scream??? Came on! I've seen worse code! :)
Because method `handle` located in other class (`ExceptionHandler`)
I'm really not sure about the scope right now, I'll think of it next days.
I added the whole lazy loading part because I was thinking about the uses cases where one shouldn't instantiate any cache driver before actually using it and also for the case when you don't use a DI component, like people who just want to use this in their code. 

On the other hand, I don't know how to use the DI to create services on the fly, like those needed for the various caching drivers, so if you have any tutorials/links it would be much appreciated.
I used the `iterable` test now.
In the end I picked the second option as this approach is in use already there. I put the message into a hidden label which will be rendered by the onchange event handler method.
The only time we call V6process.process is in the watchdog function, which is done at startup (or restartup, I suppose).
Here if the template Vector is "Z3i::Point" it will be a problem...
Stylistic note: Making this `tags=tags,` would mean that adding new keyword parameters on the end could be a 1-line diff, rather than needing to edit this line as well to add a comma.
sorry `__name__`
Yes I'm comparing the lists and you see correct about the order. basically
when you search you create a note with your criteria. So it'll only match
the categories you are looking for.
On Apr 15, 2012 3:03 PM, "achance" <
reply@reply.github.com>
wrote:

> > @@ -0,0 +1,17 @@
> > +package edu.bgsu.notebook;
> > +
> > +import java.util.*;
> > +
> > +/**
> > + * Category Comparator
> > + * @author Josh LaRoe
> > + * @since 04/03/2012
> > + */
> > +
> > +public class CategoryComparator implements Comparator<Note>
> > +{
> > +     public int compare(Note leftNote, Note rightNote)
> > +     {
> > +             return
> rightNote.getCategories().containsAll(leftNote.getCategories()) ? 0 : 1;
>
> Are you trying to compare the category lists for equality here?  For
> example, if note 1 and note 2 have all the same categories, return 0?
>
> I may be wrong, but what will happen here if rightNote has 5 categories
> (let's say A, B, C, D, E), and leftNote has 3 categories (say A, B, D).
>  Should that be returning 0?  If the notes are passed in reverse order, the
> results will be different, because leftNote will not contain all of the
> categories held by rightNote.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/achance/notebook/pull/3/files#r686178
>
s/outselves/ourselves
This set seems like it won't change, so it could be initialized outside of the loops.
Can we have check for hasOwnProperty as well? Suppose, my view consists of a property named toString. so, this._cache["toString"] will return a function.
Do I need this list of modules here? It's not good having this in two places, but without it, no sub-modules are built.
This is wrong. We don't want to update the live region on close. The user shouldn't hear that there are no results immediately after they pick an item or tab out of the field. You should probably proxy `__response()` instead of `_suggest()` and `_close()`.
I've turned this around to match the remaining UI codebase. Maybe @mikesherov wants to chime in here though?
a lot of our code, for example the averaging code in monitor.py, assumes that all batches will be the same size.
could we make the iterator have an attribute that determines whether it is allowed to return varying-size batches or not?
I’m not sure we want to have any operator-specific strings in Gaia. Maybe we should have a custom setting for this?
do we really need this? alerts stop the JS loop
You can keep a `var call;` here
The indentation from line 858 seems no at the correct position?
I can be easily convinced by numbers but I am not convinced how this makes first load faster if we load the files we need to show the ui after?
You can add to `custom-prefs.js` when needed, yes.

Here, it's in the `if (DEBUG)` block - is that not the right place?  I assumed that if you set `DEBUG=1`, you'd want this as well, no?
Remove the extra empty line.
We are not taking in account anymore the company field when searching, then?
We tried to not hardcode ffos in the code. Can you use a different class name?
Remove this in `bootstrap.js` if you intend to move it here.
sie --> Sie
Here we add a "finalizer" slot to the Done constructor.
what is a track key?
usually we would return Pipe here since RichPipe is just an enrichment class.
If the following three lines were in a method, we could override that method and experiment with different replication strategies.

That might be the easiest thing to do for a quick shipit and experiment-phase.
Can you put a TODO to handle Test mode and Local mode here?
3rd arg is an options object with optional key 'hostHeader'.
Would be good to be consistent in using snake case for parameter names, so needId -> need_id
Also, and this is just pedantic, but I think what bugged me about this is that "annulus" is spelled out, but everything else is abbreviated :)
yes it should work now, I have added a check to see if all console methods used in this file is defined or not and if not defined its creates one.
you're right. i've fixed this, but i didn't find a way how to add another commit to this pull request, so i'll wait with another one untill we discuss all the above comments you have :)
If `\d` ever comes to mean anything in Python, then this string will change out from under you.  Jared's suggesting ``r".* refs/changes/\d\d/(\d+)/(\d+) -> FETCH_HEAD$"``, to explicilty indicate that the \'s aren't to be interpreted by the python parser.
Yeah, these don't belong here. Having some example requirements files for "small" and "large" installs might be nice, but thats still a ways down the road.
This doesn't matter, if it's written to the cache it means the json was valid, so we can assume it's correct.
I'd format as follows:

```python

if not os.path.exists(
    '{tag_dir}/{filename}.json'.format(
        tag_dir=tag_dir,
        filename=filename
)):
```
looks like it'll merge clean, so don't worry about it if it becomes a pain, but just wanted to make sure you knew that this branch that you have right now is not in sync with ipython/nbconvert/master
based on the design - can be removed if it is all supposed to be on one line
From where does $currentRepoName come ? From the zone parameters ? It should be indicated at least in comments in the zone.
This change will automatically call the extended classes `initialize` method right? if so then it would make sense to remove the manual calls that are made in modules that are currently using `Class` I would think.
I don't see that this has been addressed.
http://app.noodletalk.org/#/post/1223115/ednapiranha
I got change the path 
https://github.com/nvcVincent/CoinCod/commit/6100e7f6a608eafef621550aa859c277dcba22b2
why do you change my doctype? I need those doctype to let the browser recognise it a html5 site. I just need to remove the "
does Propel follow the same rule than Symfony2 regarding not using ``else`` when not needed ? I don't remember what the agreement was when we discussed the coding standards months ago
mmh, what did you change on this file?
You are right, all of the others default to 'unknown'.
ok, I guess this is already handled in `lib/puppet/util/monkey_patches.rb`:

    class Symbol
      def to_proc
        Proc.new { |*args| args.shift.__send__(self, *args) }
      end unless method_defined? :to_proc
    end
Isn't it more clear if you initialize fallback to NULL and create an else for this condition where it is set to G(object)?
format according to convention
Why remove "implements ExceptionInterface"?
No.  INTENSITY_BOLD for ANSI adjusts the color brightness, not the font styling.  It is how ANSI has the 16 colors, because there are really only 8 colors in both bold and regular intensity.  There is no ANSI equivalent to embolden a font/make it thicker/larger.  The UNDERLINE_DOUBLE was randomly chosen to just "be different" from the other formats.  It's not ideal, but it's better than nothing I suppose.
Because we need to walk the intermediate classes which may get overwritten:

Class A {
  public static $requiredConfig = array('someValue');
}

Class B extends A {
}

Class C extends B {
  public static $requiredConfig = array('anotherVal');
}

the exception catches the reflectException thrown when the property doesn't exist on class B.

Using the direct operator static:: or $this would mean you can't access any of the descendent $requiredConfig properties.  $ref is pointing to the class, and thus the only way to get at the properties declared in the intermediate chain.  This gets to your idea of how to do default properties that are overwritten - we could use the same approach to mashup a set of property arrays.
So, need to check this with twitter - it was barfing with urlencoded urls as the query parameter (incorrectly finding no results).  This was a quick way for the data service to force unencoded params - if http_build_query works, then that's fine.
@ferventcoder Is it possible to only swallow the exception when its a 404, but otherwise re-throw?
Also not clear that this is an improvement. Was the other way breaking something somehow?
Just a thought, removing this config setting will make it harder on people unfamiliar with the module. To make it clearer, I'd have this line commented, but not removed. Document the line saying that the default value can be overridden by declaring the config in some other config (ex: config/autoload/users.local.php)
another way is to create a "server" and "client" dir... so, everything in "server" dir is made available only on the server, ...

implemented todomvc with authentication, where i used this approach -> https://github.com/MStumpp/meteor-todomvc-auth
`for k in item`
Ha, that's a fun use of `bind*`, I'm happy how little you had to change `logic.clj`.
Mikä tää on? Jos haetaan päivittäin pidä mielestäni tehdä enää mitään matikkaa.
but it could cause some issues if someone uses both public properties and ``__call`` in a class
i can follow this reasoning. ok with your change.
Yes, you are right. This is a copy and past from the XML driver...
the catch should be on the same line as the closing curly bracket
Why are these removed? Can the execution continue without a hassle?
This is a stand-alone script, it doesn't use a logger.
Nah, let's keep it for now. One day I'll hope to be able to refactor this code anyway.
Why do we need the `s_http_userinfo_start` state at all? It sees to behave the same as `s_http_userinfo`.
The idea is to not materialize the bytes in between. otherwise we do multiple copies of the same bytes in various layers.
the memColumnReader could also provide a stream to write to. 
Add a TODO here so that we don't forget
In js we use camelCase
```js
var totalBadges = badges.length
var totalPerIssuer = {}
```
Hm, I thought I fixed that. I may have forgotten to commit, hang on a few minutes and I'll push the change to my branch.
What about commented out tests marked `TODO: this test needs to be fixed`?
auto completer is not required (its the search auto completer - not relevant for api)
maybe I"m not 100% clear on what is the usage, but this is just to provide a default per image?
Hmm...looks like the style in gaia isn't following traditional python style too well in this arena. Maybe take care of that in a followup, but we need to come in agreement on style guidelines.
You know, removing the timeouts from `Trade` is actually a great idea. It removes complexity a lot. We'd just have to move `SubscribeTrade()` and `UnsubscribeTrade()` to the `TradeManager`.
Perhaps a comment above the "file-store" line that says that most of the time a cache store will not be needed? I'd even prefer the 'file-store' line to be commented out.
OK. I was unaware of the API spec. When I originally made the change I was using an earlier version of node-github that had a weaker check.
Well, I suspect `Angle` will eventually become a subclass of `Quantity`...
> You can ask for help on the socket.io IRC channel; #socket.io on [Freenode](http://freenode.net/).
sure. not too nitpicky
Please read the issue related to this. That is why the pull request is
called "first part", because the second part is much more trickier. The
DataSet name is right above in the <setName> element.

On Wed, Aug 8, 2012 at 8:52 AM, Sjoerd Siebinga <notifications@github.com>wrote:

> In web-core/app/core/harvesting/OaiPmhService.scala:
>
> > @@ -165,6 +165,11 @@ class OaiPmhService(queryString: Map[String, Seq[String]], requestURL: String, o
> >          <set>
> >            <setSpec>{set.spec}</setSpec>
> >            <setName>{set.getName}</setName>
> > +          <setDescription>
> > +            <totalRecords>{set.getTotalRecords}</totalRecords>{if (set.isInstanceOf[OrganizationCollectionInformation]) {
> > +            val organizationCollectionInformation = set.asInstanceOf[OrganizationCollectionInformation]
> > +            <dataProvider>{organizationCollectionInformation.getDataProvider}</dataProvider>}}
>
> Could we also add the dataset name. And what is the planning for the other
> required info like:
>
>    - number of landingPages: europeana:isShownAt
>    - number of digitalObjects: europeana:isShownBy
>    - number of thumbnails: europeana:object
>    - license information from the dataset
>
>  —
> Reply to this email directly or view it on GitHub<https://github.com/delving/culture-hub/pull/626/files#r1329713>.
>
>
It's "rewritten" :)
Doese that mean that the elements should be strongly in the order?
Please change this to _featured_extensions_header_locator or something similar that gives a bit more context to the name.
why do we move to offset?
I think "somewhere cool" might need to be defined better, since the CSS references these images, right? So do they need to be in some relation to each other?
it was more a note to myself (as you didn't add this), but, qmake supports explicit dependencies between targets, so for instance, this could be:

plugin.depends = src
tools.depends = src

and once src was built, both plugin and tools could be built in parallel assuming make -j
We could maybe even get away with having the `is-query-result` function accept the full maps, and it could just verify that they have the expected keys in them and then *it* could pull out the `:name` value to compare against `expected`.
I don't think these should be declared here, as they are already in bundleDependencies. Also, I think the official name is "bundledDependencies".
Spacing is also off on quite a few of the `[options]` params within this PR
Why did this need to be added? For readability, I also prefer
```
if (t) {
tenants.push(t);
}
```
I changed this to be a multiget.
Might be worth documenting here who can delete a comment.
This is dangerous. The ``this`` reference is escaping during initialization.
what exactly is the purpose of this class?
this just makes sure what gets passed in is actually a function and adds it to our cache
Nogmaals: niet waar thomas mee bezig was?
woah keen eye.. that's crazy yes - i messed up!
здесь можно было бы обойтись без вложенного цикла
Ну почему же бессмысленно. Если x отрицательный, то мы не войдем в цикл, а если больше длины DNA, то изменим все символы и выйдем. Но лучше, пожалуй, сразу сделать проверку и ограничение xPercents диапазоном [0-100]. Спасибо
В вашей реализации в DNA измениться X элементов, а не X процентов элементов, и нет проверки на вызов с -1 процентом или 123424324 процентами. Условие строгости не выполнено.
change this to:
> <setting id="VDR_VIDEO_DIR" value="/storage/videos" />
This line is still assuming the nomenclature of pre-384 Forge versions.
there is no such constraint in ImageInterface
No. Why would i do that?
`/./` Match any string
`/[.]/` Match full stop
Also I said this to Drew, but we should have `strftime("%Y-%m-%d")` all over the place. I think we have a parse date or something. But I'll let Drew respond
Leftover /ezpublish/ezpublish_legacy :)
:+1: I'm terribly inconsistent with this.
Because `-[NSMethodSignature getArgumentTypeAtIndex:]` takes an `NSUInteger`, so we have to cast either way we go. It seems safer to go from `NSUInteger` => `NSInteger` since we shouldn't be dealing with any non-positive numbers.
Probably don't need these trailing newlines.
It's confusing that `parties` here can be both an Array and a Party instance, and that the :group_name option is what decides which one is expected.

Either split it into two methods, `#text_for_party` and `#text_for_parties`, or decide based on the passed in type. If you go for the latter, changing `:group_name` to `:name` would allow us to override the name also for the single Party case:

```ruby
def text_for(obj, opts = {})
  case obj
  when Enumerable # may need to use "ActiveRecord::Relation, Enumerable" if passed object is e.g. Party.where(:foo => bar) - should be specced :)
    score = score_for_group obj
    name = opts.fetch(:name) # will raise if name is missing, whereas opts[:name] will return nil
  when Party
    score = score_for obj
    name = opts[:name] || party.name
  else
    raise TypeError, "unexpected type: #{obj.inspect}:#{obj.class}" 
  end
end

Maybe splitting into two methods is easier to understand.
What's that for? Just curious.
This comment seems outdated, doesn’t it?
Did you add all the above text including the line break inside the heading on purpose?
Should the event be recorded here or when the actual operation begins? Could the operation be aborted before it starts?
I think _prepare_forward would make more sense
On 19.11.2012, at 21:55, Eric89GXL <notifications@github.com> wrote:

> In mne/connectivity/spectral.py:
> 
> > +    for m in method:
> > +        if m == 'coh':
> > +            accumulator_fun.append(_coh_acc)
> > +            normalization_fun.append(_coh_norm)
> > +        elif m == 'cohy':
> > +            accumulator_fun.append(_coh_acc)
> > +            normalization_fun.append(_cohy_norm)
> > +        elif m == 'imcoh':
> > +            accumulator_fun.append(_coh_acc)
> > +            normalization_fun.append(_imcoh_norm)
> > +        elif m == 'pli':
> > +            accumulator_fun.append(_pli_acc)
> > +            normalization_fun.append(_pli_norm)
> > +        elif m == 'wpli':
> > +            accumulator_fun.append(_wpli_acc)
> > +            normalization_fun.append(_wpli_norm)
> That makes sense to me. I assume by default we'd have the 'mean' operation do the averaging using appropriate sign-flipping within the label, too. This seems very general. I'd be happy to implement this at some point after you're done classing it up if @dengemann wasn't planning on using this type of analysis.
> 
yay, easy, let's go -- even i would be-- no incompatibilities-- or did i miss sonething? i would be very interested in
this. would be happy to contribute / test / share
> —
> Reply to this email directly or view it on GitHub.
>
probably should have renamed the variable to "idOrUuid" to make the code more readable
sample misspelled
I found minion a less common word and since there will be also chapters about Puppet, Chef, CFEengine, using words `master` and `slave` might feel more natural.
I've removed it and force pushed. Hopefully the specs pass!
If you wrap code examples with `+` signs then they get escaped properly. I'd write it like this probably:

    NB: Content is not marked as safe by default. To mark it as safe use: +@page.content_for(:body).html_safe+

Or something like that.. what do you think?

Thanks for the improvement :-)
Put a semicolon at the end of this item
Nitpicking, these v0 and v1 are actually key/value or name/value or option/value, right?
Translations can be added directly in the templates. So you don't need to pass them in as variables.
While I don't like that ``use_alt_url=true`` is long, ``alt_urls=true`` is less descriptive and
I'm not sure why it's plural.

Any suggestions for a descriptive and short name?
No delegation to super needed?
Is this method needed? And why?
s = s.lstrip(' +') will strip all space and `+` from the left of the string.
ugh, yes. I'll fix that
Mi idea era simplificar la escritura de HTML dentro del método, en este caso parecería que estarías envolviendo un form (seguramente esta función sería un wrapper de BeginForm), y si bien soluciona ese problema, ¿aplica a las situaciones que necesitás? Por otro lado, ¿qué pasa si no tiene permisos y por tanto no querés generar un form?
Another use of `final`
use ``null|integer`` instead of variant
Yes `opts` changes for each element 
line 19 :  
```
opts = angular.extend({}, options, scope.$eval(attrs.uiCodemirror));
```



But what about `options`  that depends of the `uiConfig`
 line 18:
```
options = uiConfig.codemirror || {};
```
Is it use whatever the element during compile-time ?
It seems like we could do the is_valid check before trying the connection. Or even between trying
to create a UEPConnection at all. 

On the other hand, failing a is_valid checki in _request before the con should be a very rare event, so checking between asking for the request and
making the connection is probably wasteful. 

Maybe a workable compromise would be to make sure we check if id certs are expired on process
startup, and present a helpful message. Otherwise just let it fall back to generic ssl errors. I think
we currently check on gui startup (or at least, I see various id_cert.is_valid() style calls). Probably
need to make sure cli and rhsmd-worker (and yum plugin?) do as well.
And it went.
oops.. forgot to scrape these before hand :(  i'll clean these up.
Rename class to OptimisticDistSyncTxCacheStoreSharedTest, remove TODOs?
Yeah they're all copied from matlab except spectral, but I wasn't sure if that should be mentioned or not.  any ideas for wording?  they are also used in other things like h5utils, but, again, copied from matlab.  http://ab-initio.mit.edu/wiki/index.php/Color_tables_in_h5topng
We could do a version specific override here. Something like:

```
if matplotlib.__version__ < '1.2':
    transform_path = ...
    ...
```
Do you think we should add a comment explaining that it is a dict?
Please stick to PEP8 for organising imports: http://www.python.org/dev/peps/pep-0008/#imports

> Imports should be grouped in the following order:
1. standard library imports
1. related third party imports
1. local application/library specific imports

> You should put a blank line between each group of imports.
I think this should be an APIProperty (should have been so on the UTFGrid layer too)
What does `clean` mean?

This function doesn't seem that much clearer than what came before since before `(map first clean)` at least had a name.
The success modal util can be used.
@jsloane It seems like these lines were necessary to fix [SAKIII-4724](https://jira.sakaiproject.org/browse/SAKIII-4724)
https://github.com/sakaiproject/3akai-ux/commit/90c179e075221ae1b5021e8fb575a9b2a9b28050

You don't need to change this, it's just that when we do the functional review, we should keep this in mind.
@nicolaasmatthijs probably knows more about why this was needed.
Reintroduces all kinds of debug_* code which has been removed from 3.1, need to go through the commits again
you should be catching only the exception you want to assert, so that other exceptions appear as an exception in the phpunit output, not as a failure about the instanceof check
Are you sure? Because it's not plural.
``$has_foo`` does not seem to conform to the naming convention (``^[a-z][a-zA-Z0-9]*$``). Please also check line 25.
This is all I changed.  Don't know why the diff is so large.
Also, "Git" should be "git"....stupid autocorrect.
Id vergleichen, Tag namen könnnen mehrfach vorkommen...
Also in javascripts/backbonemvc.js
You're right, I misread... though IMO I think it'd be safe to assume people wont do those odd cases you mentioned
Right, fair enough. In general I try to avoid large timers in specs.. since that really slows down the runs, hence the next_tick suggestion. The other alternative is to lower the actual timer.
why excluding DependencyInjection and Twig ?
The change wasn't intentional, no. Good catch. I agree that the size shouldn't be hard-coded on principle, but that will be easier to fix once we upgrade the feeds to use the new CBV-based Feed views introduced in 1.4.
I'm still meh on identifying Evaluations by their names. Could you add a comment that you're assuming names are unique (which is indeed the case for now)?
sure, would you prefer binds on `attachCookies` too and drop the `self`?
No unnecessary empty lines.
Set it to first name.
Or `dl`/`dt`/`dd`? Semantically could be better?
Read about [info field lists](http://sphinx.pocoo.org/domains.html#info-field-lists).
This should probably be removed. :-)
Spaces before `{`.
I blame WPP.
Needs to be deleted, test shit
Yeah, I switched how this is used, we can assume we are always in call when
it's called.
On Nov 10, 2012 2:11 PM, "Moxie Marlinspike" <notifications@github.com>
wrote:

> In src/org/thoughtcrime/redphone/call/LockManager.java:
>
> > +
> > +    accelerometerListener = new AccelerometerListener(context, new AccelerometerListener.OrientationListener() {
> > +      @Override
> > +      public void orientationChanged(int newOrientation) {
> > +        orientation = newOrientation;
> > +        Log.d("LockManager", "Orentation Update: " + newOrientation);
> > +        updateInCallLockState();
> > +      }
> > +    });
> > +  }
> > +
> > +  private void updateInCallLockState() {
> > +    boolean horizontal = orientation == AccelerometerListener.ORIENTATION_HORIZONTAL;
> > +    if (phoneState == PhoneState.IN_CALL && !horizontal) {
> > +      setLockState(LockState.PROXIMITY);
> > +    } else {
>
> You check for IN_CALL in the above if, but not the else block. Seems like
> it should be consistent in both places or neither?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/WhisperSystems/RedPhone/pull/60/files#r2091560>.
>
>
Regarding what to show: $exceptionHandler deals with really fatal exceptions so there is not much we can say, apart from 'Sorry, sth went terrible wrong, we are working on this' or sth along those lines. Basically it is not recoverable. Also we should not be showing any raw exceptions / messages from an exception (as it might "disclose" technical details).

As for logging - yes, let's add this. It will be opportunity to show usage of decorate + $delegate. Cool! As for pluggable strategy for the actual error handling - why not in general but might be an overkill for the book. Don't know...
please use the same value in all formats
I use ?: all the time :)
way too much logging
How does the rules file knows if it's doing pfdetect_remote or not?
You're right, but older IEs don't have the method at all. The idea:

```coffeescript
exports.some = if Array::some
  [].some.call
else
  (array, fn) ->
    return true for e in array when fn e
    false
```
change "Event Listener" to "event handler", in lowercase
how about just casting 'value' to (String)? That is consistent with how other fields are treated here.

Because of backward compatibility, I am wondering if there is a legitimate case where we can expect non-existing enum name. will commit this if I don't come up with a case..
How do we get this plugin? Same concern as the thrift one.
the String.format( .. ) call and kiji.getName() are separate arguments to the c'tor of KijiNotInstalledException. I don't think nested indents apply here.

That having been said, the Oracle Java Code Conventions (see chapter 4, "indentation": http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html#262) specify an example where

nested(function, 
    calls(that, span, 
        many, lines))

cause the indentation rule to be recursively applied. In the absence of a specific reason to go with our own alternative, I vote we adhere to the JCC on this.
you meant the class I guess. Why do you do this in \_\_new\_\_ rather than in CircusCtl's constructor ? 

it seems to me that everything could be added in a list in the class instance and serve by __getattr__ to avoid the meta complexity
That depends on the API itself. If the API works asynchronous then it will return `AsynchronousOperationResult` otherwise it should return it's normal response body. For `createHostedService` API it works synchronously and at the same time doesn't return a response body as you have just to assure that the response status is 201 which means the service was created.
0.55 looks good.
Okay, I was a bit careful with this code. So I can `__selected_window = window_id || __selected_window;`and work with __selected_window afterwards?
Because then I can't do that conditionally. Ah, or I could start with "" if I don't have a buffer? I'm not sure what you mean with `attrs.unshift`, the outer array is so that I can put the buffer before the `span`. Was also thinking I could just make a separate return that would include the buffer, but I also need to clear it afterwards, that was much worse.
Moving ngx_http_pagespeed_str_to_string_piece out of the header file; gives duplicate definition error.
'nbp' ? geometric?
_compute_cov_resids

should this have a dfk option here? maybe not now.
Yeah, my local server crashed or something, and then i got the wrong behavior of the search engine, so I kinda thought that is possible.
For a "Quick Reference" file, I don't think we should even mention the View classes other than at most in a footnote.  The user should almost never need to use these explicitly.
there is an Upstart provider that you should use instead of this: 

```ruby
service "some_service" do
  provider Chef::Provider::Service::Upstart
  supports :status => true, :restart => true, :reload => true
  action [ :enable, :start ]
end
```
This could use Enumerable#any? also.
How about `PebbleQuery`?
AbstractGroup.addMember/removeMember sets GROUP_SIZE so I'm not sure why we need to set it at all in this class. The remaining call in resize(delta) only sets it if nothing changed, and sets it to the vaule of `_members.size()`. I'll delete that call to setAttribute as well.

Can you see any reason why we need it here?
What is the difference between stop() and destroy()? Should stop delegate to destroy, given that restart calls stop?
(the javadoc in AbstractEntity.destroy says "Should be invoked at end-of-life to clean up the item.")
i got ya. good to be consistent now, and fix systematically.  initializing a field in the body is a warning sign now, which itself is a warning sign!
Could use guava's Files.createTempDir()
Hi Aled,

when everything is null, it still can go alright if at the destination location inferred by brooklyn, they key/certificate already exist.
This looks like an inadvertent commit / typo.
Again, c'est mon point de vue, je pense pas qu'on puisse remplacer le cine, et j'adore y aller, meme avec les pubs et les gamins de 15 ans qui hurlent.
I investigated it. Seems a line feed code of them is  mixture of different codes. I unified it, therefore files has been modified.
Should I recover it?
Why is this necessary? Doesn't blur happen automatically?
ops, I meant "return $content". I'll fix that
I think we should expand this to a string as well, so f.e. have connection_type and connection_type_desc ?
It's not clear to me how the tested functionality here is related to "utilities".
There seems to be a bug here.  When I select an image, it doesn't populate the right placeholder - it always populates the right-most one.  I guess it's a js thing.
Yes - just that.
Please add the namespace "t:LegacyFreeBusyStatus"
Bien bien.
Given that the behaviour has changed, we should tweak the test name too