labofsahil/github-event-dataset-2012 huggingface dataset:
Looks like IE6 doesn't like [].prototype as much as Array.prototype. We'll have to revert this line
Has been done.
That problem lays deeper, that function depends on those vars so those are the ones that should be passed into the event. That it is an "unpleasant" api should be fixed in the actual user api and hacked to make an event work around those strange variable names.
Ahh, okay.
This condition looks weird. Shouldn't it be
<code>if (($this->db->sql_layer == 'sqlite' || $this->db->sql_layer == 'sqlite_3') && $this->return_statements)</code>
?
Should have class="btnmain" as other buttons in subsilver2. Please look at other pages to make sure the design of new templates is in line with existing ones.
Pick one of "tags" and "bbcodes"?
I would presume that it does. Is that a problem?
What is a supposed policy for version changes?
Any particular reason for reverting the changes in this block?
ye `[OR]` akhare in khat bezar
Надо бы нормальное название сделать, типо statistics_unit
Why not implement Zend\StdLib\Hydrator?
code style as per above comment, plus seems that the tab indentation is wrong
Where do you get `next` variable into the template context?
Keep this here, validation is good.
Oops. I'll remove it.
I still think this is too general. For instance, if someone makes a new Type with C code, as explained [here](http://deeplearning.net/software/theano/extending/ctype.html), this code may fail to compile, or crash.
We should only use Py_XDECREF and Py_XINCREF when we know it will work (for the moment: Sparse, TensorType, CudaNdarrayType, maybe Generic).
Other, unknown types should not use the C code.
method -> methods. And I guess it would make sense to put infer_shape, grad and R_op in \`\` to render them as fixed-width/code.
It is used in nvalue_test.cpp to go from string constants to NValues.
Each of these functions contains a small error -- in standard SQL, when ANY argument (of any type) is passed as null, the function result should be a NULL, not 0.
Also, in VoltDB, I have tried to be careful that the returned NULL value is properly typed for the return value of the function.

If the null input argument has the same type as the function return, I just return it. 
If the null input has a different type than the function return, I return the result of the matching NValue::getNull...() function.

End of review comments. Good work.
Should be running hsql and multi-partition configs, here, too.
"have starts with" -> "has to start with"
I initially was going to use `bool`, but Riak uses a value of `"true"` so I just used bytes since the value was already a string. I'm open to changing that if you think it's better to use `bool`. I suppose it would also save a few bytes on the wire.
This line is now an unused import
It might be worth compiling the regexp in the class or [module level and reuse](https://github.com/django/django/blob/master/django/contrib/localflavor/ca/forms.py#L16-L17).
Are there formatting rules specified, could not found it anywhere, or I should learn from current code?
Do we still need all of this nrml stuff? I don't think we do.
This is way too much code, and the reset block in particular has both style issues (`var` declarations should be collected at top of scope) and behavior issues (you are setting `display: none` on parents that might not have previously had inline styles). Why don't you see if you can bring this in line with the block below for getting computed value of margin properties? It may also help to look at [jQuery.swap](https://github.com/jquery/jquery/blob/877306738f931a711c41d907e69fc8930f985830/src/css.js#L254).
@mikesherov haha, yikes! thanks for info :)
Right. I forgot about the linting. Sorry.

I was merely trying to yield a better minification.
@jaubourg Clever but less clear. Isn't that smth a minifier should handle though?
It is the same as above. How do you think about the potential naming collision problem?
We probably want to pick the arch based on MacOS.prefer_64_bit? here.
Not a test.
Can't assume /usr/X11 for libpng; on 10.8 it will be a Homebrew-built libpng, and on other versions it may be in /usr/X11 or /opt/X11.

Note that these variables can be set without patching; pass them to `make` e.g.

```rb
system "make", "PNG_LD=#{foo}", "PNG_INCL=#{bar}", "install"
```
Do a `case spec` inside a `case spec`? Why?
Could be simplified to...

```js
var path = $(this).attr('data-path') || ‘’;
```

Assuming we are using jQuery 1.6.
Can we put these imports on fewer lines as well?
Why the  nuking of the encoding line and related changes?
Am I correct that this has yet to be updated?
+1, good pick up Sayli.
I am not quite convinced about this version number. Shouldn't we start from the beginning, like 0.1.0 or 1.0.0?

Nevertheless, I am aware that in favor of this version is a fact, that mox3 is a simple continuation of what good old mox had to offer.
This doesn't look right. How is it possible that after the ``Logger.destroyAll()`` line that the logger is used to log a message ... ?
wouldn't it better to make currentSite() static ?
Can u give me more details? I can't reproduce this crash
dependency graph --> object graph
I'm using a HEREDOC (<<EOF...EOF) to echo all 6 lines.
可能如此~不过我一般都是显示声明。其实该提醒的应该是gtk2-dev和java的安装。因为包依赖他们。我早就逃离了ubuntu~忘记具体名字了...


On 2012-3-31, at 上午12:44, Yihui Xie wrote:

>> sudo make install
>> ```
>> 
>> 这的确是个办法，几乎对任何软件适用。如果你（比如为了用满屏幕的命令行赢取PPMM的盲目崇拜）鼓起勇气尝试这一条路，你可能两个小时装不好。此时你才触碰到Linux的一个核心特征：软件依赖。在Linux世界里，经常存在A软件依赖于B软件，B依赖于C这样的现象，可能是因为开源的缘故，作者经常把自己的软件构建在别人的软件基础之上，这就导致一片依赖的海洋（当然不是所有的软件都有一大串依赖）。R也依赖大量的其它软件包，如果现在那PPMM还在眼巴巴看着你，那么就用这条无敌命令一次性解决依赖问题：
>> 
>> ```bash
>> -sudo apt-get build-dep r-base-dev
>> +sudo apt-get build-dep build-essential r-base-dev
> 
> 这个我表示不能相信……build-dep的意义就在于把烦人的依赖统统装上，而build-essential是r-base-dev的依赖。
> 
> --- 
> Reply to this email directly or view it on GitHub:
> https://github.com/yihui/r-ninja/pull/2/files#r629491
I'm not fond of it, but the JUnit style does not put a space before the assignment operator (like the previous line)
If this is handled by the proxy, this spec could be deleted.
Can you move the body of this if/else up to the other `if getattr(request, 'couch_user', None):` line and leave `'timezone': timezone` in the context literal?
Please check but I think this is still used somewhere ...
Given the signature of your method, this class may throw a ClassCastException here. It should be documented, even if this class is not part of the public API.
This is sad, because of boxing this cannot be replaced with a

```java
return tmpPKIndices.toArray(new int[tmpPKIndices.size()]); // fails
```
Where is a real language when you need one...
Unnecessary import I believe?
Are we assuming a Mac OS X dev env?
don't need these variables
Better to put a stack here in case something fails: "Open Sans", "Helvetica Neue", sans-serif
See above ^
Let's just use open sans
Might be confusion between bigPlayFunction and bigPlayButton.

bigPlayFunction is defined, and only used later.

It should probably be moved into a better scope that as talked about earlier.
Looks like this isn't used anywhere anymore. Mind removing it?
Ahaaaa, I understand now. Thanks.
This doesn't look right, but maybe I'm wrong...
There is text completion for `window.undefined` on the web console.

Should I just change it to `if (!this._shadowWidth)`?
nit: Lots of ==, we haven't documented it but don't we generally try to use strict operators instead.  (maybe we should add that to coding style)
It's not clear what's going on here. Maybe something like 'not-a-file' would be more clear. Or, it's probably better to just mock out os.path.exists to avoid touching the filesystem altogether.
mime-types.properties is for the MimeUtil2 lib. I do not want to change that, if we configure those mimetypes 'the new way' they would override the MimeUtil2 behavior and break customer installations that had to supply their own mime-types.properties.
Maybe swapping the two input parameters would be more consistent with the rest?
ngx_pcalloc -> ngx_pnalloc?
Should we compile jemalloc here?
cpy 的大小和 zero 的大小一样, 就不需要 zero 了?
You mean the ghc stats?  You originally had a lot of them hardcoded; I just hard coded in the names.  What would you prefer?
I tried to do that at first, but `make` gave me "missing separator"
problems, so I used backticks instead.

On Wed, Jul 25, 2012 at 6:15 PM, pao <
reply@reply.github.com
> wrote:

> > @@ -10,7 +10,7 @@ default:
> >       mkdir -p $(JULIAHOME)/deps/SuiteSparse-SYSTEM/lib
> >       cd $(JULIAHOME)/deps/SuiteSparse-SYSTEM/lib && \
> >       rm -f *.a && \
> > -     cp -f `find /lib /usr/lib /usr/local/lib $(subst -L,,$(LDFLAGS))
> -name libamd.a -o -name libcolamd.a -o -name libcholmod.a -o -name
> libumfpack.a 2>/dev/null` . && \
> > +     cp -f `find /lib /usr/lib /usr/local/lib \`eval
> $(JULIAHOME)/contrib/filterArgs.sh $(LDFLAGS)\` -name libamd.a -o -name
> libcolamd.a -o -name libcholmod.a -o -name libumfpack.a 2>/dev/null` . && \
>
> If we're requiring bash instead of sh (are we?) this should use the `$()`
> construct instead of backticks, which should avoid having to do the escapes.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/JuliaLang/julia/pull/1058/files#r1240733
>
talked to david and we're going to add a content view version model which will make id,name work just fine and i think will make more sense from a developer perspective
This change is a fix for all tests that use the stub_repos helper.  That said, I see that travis does not like it for ruby 1.9.3, so will be investigating and it may change.
It behaves how Senos thought it behaved before :)  The actual functionality is actually different, but closer to what people would expect.
This works and I believe is correct per-spec.
There's no connection ID?
I know I'm anal, but I hate this kind of white spaces. :P
@wkerzendorf - yes, but note that one could consider having each error type having a method that validates whether its shape is consistent with a given data shape. For example, a spatially varying PDF  would need to be 4-d if the data is 3-d, and the first three dimensions should match, or an SDError's shape should match (unless it's a scalar), etc. So I wonder whether the error classes should have a method e.g. ``validate_shape`` that checks for this? Even though there might be a variety of error types, a specific error type still has a set of criteria that determines if it is consistent with the data.
This unit (``fnu``) should be removed - F_nu is not a unit, but a symbol for a monochromatic flux, which could be in mJy, Jy, ergs/cm^2/s/Hz, etc.
Yes, it's a balance between code size and clean code. Note that the current master already has hardcoded names as well...
at a minimum, these are new features that belong in separate commits, not a single commit entitled "improve debug.log output"
`edit_close_date` should not be in these `except` arrays. As in, it should be using cancan and also be authenticating the user before running the method.
This should be using `when` instead of `given`, since it's an action that the user is taking. Also, like everything else, it should take regular expression arguments. I would probably rewrite it as: `When I invite "fake@email.com" to "Enspiral"`
For later: We should delete all of these and replace them with adding a `delay` call to the mailers. Have a google for something like "delayed_job mailers".
When is this used?
Correct me if I'm wrong, but by default you *will* override gated check-ins?
I was 50-50 while writing, so I will make that change shortly.

The reason I went with disabled is that ~all people for whom this is relevant are looking for a way to 'disable' the history, so disable is the relevant active verb for users, even of 'enable' is cleaner for the object itself.

-MinRK

On Aug 10, 2012, at 13:25, "Brian E. Granger" <notifications@github.com> wrote:

> In IPython/core/history.py:
> 
> > @@ -81,12 +83,32 @@ class HistoryAccessor(Configurable):
> >              ipython --HistoryManager.hist_file=/tmp/ipython_hist.sqlite
> >          
> >          """)
> > +    
> > +    disabled = Bool(False, config=True,
> I guess I am +1 on Fernando's comment about disabled->enabled. On Fri, Aug 10, 2012 at 12:59 PM, Fernando Perez <notifications@github.com>wrote:
> …
> —
> Reply to this email directly or view it on GitHub.
>
Need to update the top-level blurb at https://github.com/jclouds/jclouds which is not connected to either of these.
should throw a RunNodesException...
Just add the `strlen` explicitly and drop the comment. GCC will optimize it into a constant.
This is a completely new file. Should have javadoc.
How about exporting `is_identifier_char` instead?
`alt` attribute contents have been removed.
Yes, this makes more sense in kitsune. Or just made less sense in oedipus.
Should we handle the case where there's a tag in production that we didn't account for and thus isn't in the tags_to_migrate map.
I know. It's rather annoying. On the elmo project we put in an exception to the `.pep8` file when this was introduced. 

I did say "Just FYI". 

Also, what's always worth keeping in mind when being "liberal" about coding standards is to think about how interupting it can be to read somones text when they have speling misstakes even though you clealy can see what theyre trying to say.
re. mixing styles; I totally agree. Still needs to become a tuple though :)
when the user submit with an empty field
Danimo, thanks for the feedback! QUrl::RemoveScheme leaves the slashes in there. If you don't like the regex, how would you like me to get rid of those?
Whoops, spoke too soon. After running with your changes on a large test suite, the js stack blows up. It has something to do with not clearing the handler function from the scheduledFunctions hash right away (too many closures?) I experimented with marking the scheduledFunctions with the sentinel value 'null' to indiciate the function has been queued.  If the interval  or timer gets cleared, it becomes jasmine.undefined.  Curious, why are we assigning jasmine.undefined to a hash value as opposed to using the delete operator ? 

This works for me, but I wouldn't be surprised if someone objects to the tri-state variable magic. 

jasmine.FakeTimer.prototype.runFunctionsWithinRange = function(oldMillis, nowMillis) {
  var scheduledFunc;
  var funcsToRun = [];
  for (var timeoutKey in this.scheduledFunctions) {
    scheduledFunc = this.scheduledFunctions[timeoutKey];
    if (scheduledFunc &&
        scheduledFunc.runAtMillis >= oldMillis &&
        scheduledFunc.runAtMillis <= nowMillis) {
      funcsToRun.push(scheduledFunc);
      this.scheduledFunctions[timeoutKey] = null;  // null means the handler is queued but can still be cancelled
    }
  }

  if (funcsToRun.length > 0) {
    funcsToRun.sort(function(a, b) {
      return a.runAtMillis - b.runAtMillis;
    });
    for (var i = 0; i < funcsToRun.length; ++i) {
      try {
        var funcToRun = funcsToRun[i];
        this.nowMillis = funcToRun.runAtMillis;
        if (this.scheduledFunctions[funcToRun.timeoutKey] !== null) {
          // Timer was cancelled after it was queued
          continue;
        }
        funcToRun.funcToCall();
        if (funcToRun.recurring && this.scheduledFunctions[funcToRun.timeoutKey] === null) {
          this.scheduleFunction(funcToRun.timeoutKey,
              funcToRun.funcToCall,
              funcToRun.millis,
              true);
        }
      } catch(e) {
      }
    }
    this.runFunctionsWithinRange(oldMillis, nowMillis);
  }
};
This is not needed, the content on [L#287](https://github.com/pyrocms/pyrocms/pull/2085/files#L1R287) is just fine ;)
at least not with your settings.
Можна зараз - тоді створюй пустий репозиторій для бандла, перенесемо.
Або можна створити вже після прийняття цього пулл-реквеста і потім перенести.
it is the way to do it.
broken indentation. And you should remove the extra newline you added before the method
Could you invert the logic and rename this to "valid" please?
The namespace should be singular
I gave my opinion how I would solve your issue. Either you trust the passed parameters (because you defined them yourself or you validated them when they we specified by a user), or you don't trust them at generation time (which means you probably need a different twig function for url generation).
you can remove the braces. They are not needed
This is wrong. You should not pass the actual user options as the options guessed by the guesser. Leave this like before.
you should remove these ``@var`` as the Symfony codebase does not put them on protected or private properties.
this check needs to be moved to ``enableAnnotationMapping`` when instantiating the reader
`setParent()` of FormBuilder is currently public. It should be private as it cannot be used outside the class anyway without creating inconsitencies. So it should not be part of the public API. And instances of the same class can access private methods anyway on each other.
This change is not directly related to this PR. But you can probably include this fix here.
Yep, this is cool.
if (!_infoBubbleArrow) {
       UIImageView *arrowImageView = [[UIImageView alloc] initWithFrame:CGRectMake(0, self.userInfoBubble.frame.size.height, 25, 15)];
        arrowImageView.image = [UIImage imageNamed:@"check-in-status-arrow.png"];
        _infoBubbleArrow = arrowImageView;
        [self.userInfoBubble addSubview:_infoBubbleArrow];
}
return _infoBubbleArrow
My testing is showing that the utc is always of 0 length when switching to either of the proposed methods.
据我所知本科生的毕设论文要求所有英文数字都使用times new roman字体（我没具体了解代码是否有特殊的处理）
+refs 
+description of template parameters
Oh dear, I do seem to have gotten something backwards.  I don't know where I would be without code reviews.
Wichtig! MappedBy gibt immer das Feld an, auf dass sich in der targetEntity bezogen wird. In diesem Fall also race!
Done. Seems like there may be a few other headers we no longer need, but I'll not touch them yet.
Should be `Reverse` not `Reverce`.
aah..  much better :-)
@stuartwdouglas I'm unsure on this one, do you think it is safe to retreive an instance of the component and return its string value?
Sorry, I've just noticed you changed this in the aria-tweaks branch.
For some reason the md5sum does not match on my machine.
I suspect you ran into some kind of cache problem and used a previously downloaded tarball...
Regenerating.
@springmeyer If I'm not mistaken, that is for localizing stylesheets themselves, which is rarely used (not in TileMill) and would generally be a very low number.
Extract this in a variable
you can use evt.application here as well (trying to minimize keeping references from outside scope)
Declare this closer to where it is used since you need it only once. (Maybe a method is not needed).
Yeah, yeah, I will go through internationalization as soon as I push the latest code for the highlighting of the most recent calls. You can accept this pull request and I will send another one for the internationalization or wait until the internationalization and then accept it ;-)
The point is that that information is no longer used in this function so no possibility to reuse it ;) What we could do is to get that invocation out of the if clause and reuse it on each of the cases, but once again there would be no reuse, we would be invoking that piece of code and later on accessing the variable where the invocation is stored (only once).
Remove this rule for now it will fire a warning in the javascript console in strict mode  for the moment.
Comment needs updating. Do you want to keep it deprecated?
How do I add a host name to an existing site?
Add a `:` after `TypeError`.
My unit test could not access it so I needed a public wrapper.
Could you explain what are you referring to as Freeseer Headers?
It's less memory calls so it's better imo :D
Used only by the JSON conversion bootjob, just makes sure not to overwrite an existing item.
Well, being a global saves:

1) Instantiation checks
2) 4 lines of code

To the print functions that follow, so yeah, better to keep it as a top level module attribute. I've moved print_stdout up, with a comment.
Yes, true. Good catch!
This is changed to `public` along with line 27 so that I can call these methods in the subclass `BackButtonHandler`
Can you un-remove these lines?
This will cause a pyflakes error.
`if check?` and logic switch will be more idiomatic, if `null` is OK here (`if check is undefined` which coffee compiles to `void 0` if isn't).
This change is necessary since the CCLabelBMFont objects in CCDirector don't have parent's to them and so this assert fails.
@ricardoquesada said that this line was once added to prevent users from using a CCSpriteBatchNode as the root node and then complaining in the forums. We agree that removing that line would be the proper fix.
we can set it in constructor too. As you described it would affect other things if it is set in consuctor. so I am setting in a handle. It would have a shorter scope.
That should be ```$('.loading').hide()```.
Thanks.
@avakarev Did you check your work at all?
Getting rid if reserve_cap_range() and his brother release_cap_range().
this doesn't work on IE + debugger: http://stackoverflow.com/questions/5538972/console-log-apply-not-working-in-ie9
You can actually enforce a limited set of values:

Here's an example:

```ruby
config :integration, :validate => ["udp", "rmi", "rest", "tcp"], :default => "udp"
```
I suggest we keep Lucida or choose a new font. Helvetica Neue is way saturated because of Bootstrap.
After looking at the rest of the code in this file, we are already tied to JBoss in several places.  For instance, the getVHostName(ServletContext) is also dependent on JBoss.  For now, it seems acceptable to just inject this change and then later we can wrap all of the container concerns into a component.
Let's use something more precise.  We can add a `data-jetpack-id` attribute set to `jetpack_id` in `options_xul.py`, and use that in this query selector.
You only seem to use `uri` and `content` so what's a point of adding `tab` and `browser` and use of getters are even more confusing.
we std modules will be in manifest
What is the purpose of this? From what I can see, you get the exact same information from `len(klass_list.keys)`.
The 5-year-old in me wants to point out this reminds me that github has :poop: . But that's childish and unprofessional, so I'll refrain.
what does it say about me that I actually prefer the current syntax?  :)  I get it, though... it's not the ruby way... will change it
I think all of these reduce the clarity of the code significantly, so I'm going to stick with what I have, I think.
why do you need to specify ': Array[Double]''
Same here (CS) ;)
Could you be more specific ?

Do you suggest to have Zend\Json\Decover replaced with json_decode ?

Or do you want to skip automatic decoding in the abstract class and leave decoding to the controller instance ?
@jmikola Is good no problem for this

@b-durand PHPDoc by default use the class name as return value
Technically this whitespace has been moved, so the `// CraftBukkit end` should go after it
This code had been made by you sir. We haven't touch it
Could we append to this file or backup the old one?
This doesn't actually throw, because the exception is swallowed in GetFile. @ferventcoder, do you want me to change this test to WillReturnNullWhenTheRequestedFileDoesNotExist, or make it throw? GetFile's contract is to return null when a file doesn't exist, but I don't if perhaps we can be smarter about handling the exception and only return null in some cases.
Buto numeris čia turėjo būti.
I think the setters can be removed now from the NewImageWidth and NewImageHeight properties?
I think these need to be added to the translation template? Same with the string added to the Layer Properties dialog.
Oh, ok. Then ignore that ;)
Did you take the compression out because it wasn't working, or because it wasn't required in the benchmark?

In general when comparing with Level DB we've had compression enabled - since LevelDB always uses compression.
@harjis Käytetään mieluummin olemassaolevaa pupesoft_sahkoposti() funkkaria. En haluaisi ylläpitää kahta eri infraa.
Is that because public properties don’t trigger the internal lazy loading?
A few comments:

* I think a better approach here would be to bundle the point assignment with vote creation, that way your controller doesn't need to manage multiple objects and you can better synchronize your data across those objects.
* You assign to ivars (e.g. `@class_type` and `@object`) but don't seem to use them in the view since you end up redirecting -- you should consider changing these to local variables or private methods.
* This module introduces non-RESTful actions to the controllers you mix this into -- a better approach would be to handle votes as a separate nested resource. I can help you with this refactoring.

For now, I'd like to see you make the controller code look like this:

    def vote(direction)
      votable.create_vote_by(current_user, direction)
      redirect_to :back
    end
This isn't really true, the trait doesn't provide anything
just run

repoman -vdx fix

in the pybraindir and fix everything.

then use

repoman commit

to commit your ebuild.
Each repo version will need a consecutive if statement, repos will be built by consecutively upgrading from initial to current if the repo does not already exist.
Mention the version dependency.
consistens should be `Benutzeraccount`
@maxdec Did you test out only the login? Or also the registration stuff?
Perhaps just make `Arturo::Feature#symbol` always return a symbol? Or maybe create a new method if you don't want to override the attribute accessor.
Could you indent by 4 spaces, just like Java files in all files?
Does `json_decode('null', true)` return an empty array? Or is this app specific?
and what about 'this.code' ?
Files should end with a new line.
I believe you are correct with this `if you do not have _maxTraces over and over, you'd be sending between once every _maxIdleTime and once every 2 * _maxIdleTime`.

I personally see this as a good thing and don't see it as a problem as long as it's documented the way it behaves and I change `maxIdleTime` variable name to something better - e.g.:

```
Traces will be sent to the backend when one of the following conditions has been meet:

1. Number of queued messages is >= maxTraces
2. More than maxIdleTime milliseconds have passed since the messages have been last sent to the backend
```

@cyli Are you OK with this?
Comparing if Puppet::PUPPETVERSION < 2.7.10 is not really 'easy' without an additional gem dependency added.  Using versionomy gem , which may be useful in other areas of Foreman, we can do this

```diff
diff --git a/Gemfile b/Gemfile
index 078b260..1dc1e0d 100644
--- a/Gemfile
+++ b/Gemfile
@@ -15,6 +15,7 @@ gem "safemode", "~> 1.0.1"
 gem 'uuidtools'
 gem "apipie-rails", ">= 0.0.12"
 gem 'rabl', '>= 0.7.5'
+gem 'versionomy', '~> 0.4.4'
 # Previous versions collide with Environment model
 gem "ruby_parser", ">= 2.3.1"
 gem 'oauth'
diff --git a/db/migrate/20090714132448_create_hosts.rb b/db/migrate/20090714132448_create_hosts.rb
index f029466..47e318e 100644
--- a/db/migrate/20090714132448_create_hosts.rb
+++ b/db/migrate/20090714132448_create_hosts.rb
@@ -4,7 +4,11 @@ class CreateHosts < ActiveRecord::Migration
     # we are only creating the full database if the hosts table doesn't exists, if it does, we assume that store config is already configured
     unless Host.table_exists?
       require 'puppet/rails/database/schema'
-      Puppet[:dbadapter]= ActiveRecord::Base.configurations[RAILS_ENV]["adapter"].sub("mysql2", "mysql")
+      dbadapter = ActiveRecord::Base.configurations[RAILS_ENV]["adapter"]
+      if Versionomy.parse(Puppet::PUPPETVERSION) < Versionomy.parse('2.7.10')
+        dbadapter.sub!("mysql2", "mysql")
+      end
+      Puppet[:dbadapter]= dbadapter
       Puppet::Rails::Schema.init
       Puppet::Rails.migrate()
     end
```

Without versionomy simplifying the comparison , it would be like this

```ruby
      dbadapter = ActiveRecord::Base.configurations[RAILS_ENV]["adapter"]
      puppetversion_major = Puppet::PUPPETVERSION.split('.')[0..1].join
      puppetversion_minor = Puppet::PUPPETVERSION.split('.')[2]
      if puppetversion_major.to_i < 27 or ( puppetversion_major.eql?('27') and puppetversion_minor.to_i < 10 )
        dbadapter.sub!("mysql2", "mysql")
      end
      Puppet[:dbadapter]= dbadapter
```

If the goal is to eventually remove the Puppet dependency for the schema, I'd think simply always substituting "mysql" for "mysql2" should work since this portion of Puppet using the string treats them the same even once the code added support for "mysql2".
This doesn't need to walk the tree anymore does it?
noticed you wrapped most the other regex, is this something you missed or intentional?
I would probably tuck all of this code into the Berksfile class instead of the CLI
If you move this rescue logic into the bin file that instantiates the CLI class and starts it you won't need to repeat this logic everywhere

```ruby
#!/usr/bin/env ruby
$:.push File.expand_path("../../lib", __FILE__)
require 'nexus_cli'

begin
  NexusCli::Cli.start
rescue NexusCliError => e
  NexusCli.ui.say e.message, :red
  exit e.status_code
end
```

You'll also need to create a class/module function on NexusCli to hold a ui object.

```ruby
module NexusCli
  class << self
    def ui
      @ui ||= Thor::Shell::Color.new
    end
  end
end
```
It's "Users and Groups"
Well i just did a rebase, no this issue no longer is a problem.
Его никто не наследует. Дефолтный деструктор подойдет.
реализация?
How many combinations of number/value are we expecting - previously we were using ,FEW which is much faster (if it works). Failing that using a ,MERGE will prevent skew issues
We're not really doing delete on a resource (api/tenant doesn't exist), but on the current server. It also doesn't really delete the tenant, it flags it as deleted.
It looks like this will only ever return an array of authorizable ids, even when retrieve_basicprofile is set to true.
Please document this function.
Now when you say it and I think about it again I even can't think of a good reason not to highlight them. Firstly I thought that it can be confusing when something like \u00 is highlighted, although it is not valid, but now it doesn't really matter.
I'm not sure if that's equivalent, but I have seen this code beeing used somewhere in our codebase (I believe in the refactoring package). The reason for this change is avoiding to generate an exception when the project that contained the ``scu`` is deleted. If there is a better way for this, please tell me :)

Either way, good point, I'll update the code and add the logging for ``null`` values.
I disagree, I don't think it's "just" a visibility issue. ``currentThread`` should be ``@volatile`` if it's accessed by different threads, but that won't be enough to fix the existing race condition. IMO, the lost update can lead to incorrectness (that is what I'm arguing here). For instance, ``ScalaLogicalStructureProvider`` could be invoking a method on a thread that is no longer the *currentThread* (https://github.com/scala-ide/scala-ide/blob/master/org.scala-ide.sdt.debug/src/scala/tools/eclipse/debug/model/ScalaLogicalStructureProvider.scala#L74).
Gotcha, yes, I went overboard here.  I was quickly trying to get an idea out there before I spent too much time on it so I overlooked the DriverChain itself since I was on a file creating streak ;P
This is due to how Rake handles task invocation:

```ruby
# Rakefile

task :task_1 do
  puts 'task 1'
end

task :task_2 do
  puts 'task 2'
end

task :joint_tasks do
  Rake::Task['task_1'].invoke
  Rake::Task['task_2'].invoke
  Rake::Task['task_1'].invoke
  Rake::Task['task_2'].invoke
end
```

```
[ ~/dev/thoughtbot/shopximity/internal dev ] rake joint_tasks
task 1
task 2
```

Running multiple tasks from the command line does the same thing; it'll invoke once only.

You can reenable manually, however:

```ruby
task :joint_tasks do
  Rake::Task['task_1'].invoke
  Rake::Task['task_2'].invoke
  Rake::Task['task_1'].reenable
  Rake::Task['task_2'].reenable
  Rake::Task['task_1'].invoke
  Rake::Task['task_2'].invoke
end
```

```
[ ~/dev/thoughtbot/shopximity/internal dev ] rake joint_tasks
task 1
task 2
task 1
task 2
```
You have to put a space between `if` and `(`. Also, put opening/closing brackets for if statements, like this:

    if ($this->dsn)
    {
        ....
    }
    else
    {
        ....
    }

See the [coding style guidelines](http://codeigniter.com/user_guide/general/styleguide.html) for more info.
It's a public property ... who'd use accessor methods for it? A note in the docs and upgrade guide would be a better solution IMO.
используется rand(), но нигде в коде не вызывается srand()
self setDna здесь абсолютно лишний.
В метод setRandomValues передается ссылка на переменную dna (а не сама переменная) и массив после вызова уже заполнен.
Потом мы через сеттер делаем по-сути _dna = _dna.
Я думаю, что это не должно быть изменяемым свойством класса. Либо (readonly) @property, либо константа.
Я уже не знаю даже, ругать или благодарить Рахима @freetonik, уж сильно меня увлекает анализ работ. :)

"Свободный университет" занимает практически все мое свободное время, простите за тавтологию. ;)

--
Your sincerely,
Sergey Lebedev.

Twitter: @drasgo
Facebook: s.a.lebedev
This declaration can be removed.
Remove old commented-out code?
Interesting, yeah I like your idea.  Was thinking about having jQuery datatable but felt overboard, but I guess giving an option never hurt anyone.
these dependencies are in the DependencyManagement section, and should be left in.  If you want, you can add <scope>test</scope> here
As I'm new to this: Is there any way to pluck it out and put it into a new pull request or should I cancel this and start a new one?
现在name似乎是没有什么作用的？是否需要去重？
Hm, it could be the refcount going wacky, though I can't see the error from a quick look at the refcounting code. The library doesn't have tests that change the index, does it?
This is not enough anymore. the master branch is now for 2.2 and 2.1 also has its branch
This isn't correct. The `select` method will return the key, not the value. You should add `$colors[$dialog->select(...)]` around it.
then you can use the program without a debugger, madness! :)
tell me about it... :)
Any ideas how to rewrite this test?
no trailing \
`null` means no default provided. In this case nothing will be shown and we need a value that indicates that there was no default and user entered nothing.
No uso mucho este tipo de clases, aunque tengo entendido que es una buena práctica. Creo que en otros casos yo no las estaba utilizando, tal vez deberíamos unificar criterios y tratar de utilizarlas más.
Fixed in 55ca43e
please remove this line. It is absolutely not related to the current section about i18n. This will make it easier to update the doc for KnpMenu 2.0 (where th ``setCurrentUri`` method will not exist anymore)
`pyramid.reload_templates` was actually semi-silently removed at some point
in 1.3.
Bad formatting
Missing spaces arround equal when a function argument is assigned in the function declaration
You can use `Logger` instead of  `\Monolog\Logger`
Was that all you get? In a fresh repo with no upstream I get

    > git rev-list --count --left-right '@{upstream}'...HEAD
    error: No upstream branch found for ''
    error: No upstream branch found for ''
    error: No upstream branch found for ''
    fatal: ambiguous argument '@{upstream}...HEAD': unknown revision or path not in the working tree.
    Use '--' to separate paths from revisions

(the quotes are required or fish will strip the curly braces).

This is not surprising. You have no upstream. The end result of this command is that `count` will contain the empty string, which you see on line 182 is treated as no upstream.

In order to set an upstream you need to pass the `-u` flag to `git push` or the `--set-upstream`/`--track` flags to git branch (see the manpages).
True, gets rid of the id.
Static please
All whitespace ? :/
This is not an option for Infinispan 5.1, only for 5.2 AFAIK
I think it's time to rename this interface :)
I think this happens when git changes its interpretation of a file between text and binary.

CC @arrbee
Yes -- not a hard and fast rule.  I guess why these particularly bothered me is that they are in files without any other changes.  Doing "git log axes.py" would show that it was edited to improve handling of scalars, when in fact it had nothing to do with it.  Just adds a little speed bump when trying to do code forensics down the road.
This seems a little unfriendly. If I ask for blitting, I would expect to get it - otherwise I should get an error. What do you think?
This is the part that i wanted to keep for last.
I've showed the tests which i was struggling with and also i will refactor this in an update.
Probably under Gaia Data probably makes sense
Seriously this one look like a bad google translate.
`"pour devenir malin dans le “spec.”`... This means nothing.
Never used at all, as far as I can tell?
Ожидаетя, ТоЧтоЕсть - правильно
Так ожидает аргументы assertEquals а было наоборот!
Good call! Addressed in 372c43b
I've removed this
Clarification: "If you want, you could even implement both interfaces in the same class." => both the SearchPropertyProvider and the CollectionCountService.
Specifying the Service interface caused this component to be exposed with *only* that interface. I eliminated the value here so that *all* implemented interfaces are used.
use SG_CALLOC then you don't need the *m_refcount=0
Do you have some funny line ending settings in your editor? 
Any idea where those whitespace changes could come from?
Ahh, was wondering how to do that. :)
the myriad pro served from typekit is not 100% identical to the Myriad Pro that comes with many Adobe products. If we're serving the font ourselves, "Myriad Pro" as first font family can actually mess up the placement
Is it me or is it standard practice to match up 5.1.18 client side to a 5.5.x server?
mcp.php should be fine.
Actually I agree here... all it is doing is assigning the array element to an alias and then using that alias to assign to a template var. Just an extra step really. I think you should just do it like 'NAME' => $metadata['name']. Faster and easier.

Unless, of course, you are planning on doing something else with the alias variables?
Just tried it too. It is the other way round. If defining a function without 
parentheses, it enforces calling it without.

Example (doesn't compile):

    object Test { def test=4 }

    object MyApp extends App {
        println(Test.test())
    }

Because you can't enforce parentheses on call site, I don't get the reason for 
using them at definition.
All functions can be called without parentheses and only those with side-
effects also with parentheses. This doesn't highlight side-effect-functions, but 
side-effect-less functions on call site and therefore can't be used to warn the 
user "this function has side-effects", because side-effect functions also can be 
called without parentheses.
Where did you find the convention about side-effects?
Are you sure the class "Zend\Search\Lucene\Document" actually exists, or did you maybe forget to add a USE statement?
? :S
i just tried http://www.python.org/dev/peps/pep-0215/ (string interpolation) and i get syntax error. The page states that it is Superseded by pep 0292. Would you like me to use pep 0292 or string formatting ( like 'foo%s bar' ) ?
Nope. Not in there. Removed Docblock line.
Fair point.

I have updated the test to use this syntax for both parts and then to create the union with $q->union($q1);
Is that what you meant? There are of course three variants, I could put them all in the test if you think it's a good idea.  I notice there are some other "multiple" tests.

I have now my gitHub repository with the single test mentioned above, do I need to do anything else for you to see that?
You can use spl_hash_object($options['callback']); and drio the getClosureUniqueId function
this line seems unnecessary
What's the reason for inlining these styles?
Perhaps "Multiple inputs exist with the specified name. Please specify a namespace to disambiguate."?
This should be called only in case DBus is defined, otherwise try the fallback version
No, it is OK with `<a href>` inside.
I am not really sure if we need completely new file just for this short function? You could move this to tasks file?
See example here:

https://github.com/wlanslovenija/PiplMesh/blob/master/piplmesh/api/authorization.py
No newline around the tag. Check how we are doing it elsewhere.
Moved this to $.ajaxSetup. But I'm not sure if it is placed right.
thats what you get from lazy copy-pasting :)
This is not the right way to do translations which depends on the count. See [here](https://docs.djangoproject.com/en/dev/topics/i18n/translation/#blocktrans-template-tag).
I forgot, before it was necessary, because i havent except Does not exits
`make -e` should be avoided, as it can inadvertently leak unrelated things from the user's environment leak into the build. If things need to be overridden, i.e. CFLAGS, they should be passed as a list of args:


```ruby
system "make", "prefix=#{prefix}", "CFLAGS=#{ENV.cflags}", ...
```
Hmm, yeah thought that was weird, tried it again and it worked fine. 
Must've had a typo or something in there last time.

On 20/02/12 23:07, Joe Groff wrote:
>> @@ -156,8 +156,8 @@ static bool keywordIdentifier(TokenPtr&x) {
>>       "<--", "-->", "..", "=>", "->",
>>       "==", "!=", "<=", ">=",
>>       "<",">","++=","++",
>> -    "::", "+=", "-=", "*=", "/=", "%=",
>> -    "+", "-", "*", "/", "%", "=", "&", "^", "|",
>> +    "::", "+=", "-=", "*=", "/=", "\x5c\x3d", "%=",
> I don't see how that's possible. `"\\="` and `"\x5c\x3d"` are equivalent.
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/jckarter/clay/pull/224/files#r469019
Also, that's way too long for an option description.
There's a lot of duplicate code in here, it would be great to see it refactored a bit to make it easier to maintain in the future.
Most of the validation problems with this template seem to stem from the fact that Sphinx is just using the wrong doctype, as the bootstrap theme seems to be HTML5.  I don't know why the theme itself doesn't do this, but inserting this here should fix it I *think* (not tested):

```
{% block doctype %}
<!DOCTYPE html>
{% endblock %}
```
I believe `fieldatom` is just a stand-in for actual fields in the generated code, so I would use `atom()`. Again, I would convert `#pikachu{}` to `tuple()`.
I've considered that for adding but I believe that that's the minimum information you need to identify a query when in minified mode. Adding more content to that would just make the minified queries not so minified imo.
Same as https://github.com/doctrine/DoctrineModule/pull/17/files#r800233 . It *could* be useful, but I need to ask @ralphschindler, and this is mainly misleading for new users. Plus, it produces an array of objects, which is out of scope of the DIC.
I did changed my mind between 2002 and 2012 for sure. But I don't recall when exactly :)
Let's make this "zero-indexed, ordered lists"
this function just translates a config file into a mapping. The watcher are then created with those mappings (see later)
Because, I find it less descriptive and was hoping that native English @Mossop could help to figure out what would be most natural naming :)
Use Number instead of parseInt.
`_make_selection_func.bind(this,` looks strange: either have a `_make_something_func` or use `bind`, but i cannot imagine that you need both.
is called by
Should we instead be keeping a list of available mission types instead of relying on a string translation which might actually be provided by another module?
Is the empty? check correct here? It seems to me like if you get back an empty array that's a valid return value.
did you check if all tests work out with 2.5.1? maybe we should go with 2.4.3?
这个什么意思
Very nice demo! I like the frowny/smiley face.

One issue I noticed: when a point is selected, both the drawPointCallback and drawHighlightCallback functions are called. Is this intended? It results in shapes appearing double when selected, whereas I would have expected a single, larger image.
Why not putting this in TNLibvirtEntity? You wouldn't need to loop on all the hyper visor's VM
Same question - is InboundMessageEvent correct here?
probably worth a comment here that we're still sorting out the timestamp extraction.
Minor point about these -- none of the .py files are executables any more.  They need to be run as `python blah.py`.  However, doing `scons examples` will build executable versions in the bin directory without the .py ending that have the necessary shebang at the top to make them executable -- usually `#!/usr/bin env python`, but it might be something else if you specify PYTHON=.
The reason the magic numbers are in the .cpp file is so that they do not become globally visible.  In cpp it's not possible to define non-integer constants inside a class definition - you can declare them to exist but you still have to allocate storage and initialize them in a .cpp file.  So I chose to put them in the file where all the code that uses them will be.  @rmjarvis may know a better way to put constants in the .h file while still limiting their scope to the relevant classes' code.
Thanks . Don't know what I have done to that one . Was just months away .
Just noticing that the first 17 lintes of #show are identical to the #index.  Perhaps this could be DRY'd up a bit.
use log here?
Why the difference between 3/15/12 and 3/14/12?  I don't know where the $40 refund is coming from when the user has had the subscription for a day.  Doesn't this exceed the grace period?

Perhaps you should add hours as well here (ex: 3/14/12 at 7:00AM).
Nit: Spaaaaace. :P
Thanks for the contribution! I'm actually not super familiar with django-browserid, so I'll leave the review to @Osmose. :)
trololo, testi

# testi
This description is not sufficient to tell me what this function is doing.

Providing some example inputs and outputs would help.
Are you sure? I think REST-like API returns the parameters you provided as query back in JSON response. Have you checked that?
This should be ToStringIPPort(), I think.
So wouldn't that obviate the need for this whole branch, in fact? I mean, we're back to the "two methods  for entry, one backdoor" ...
How do I access inbox from the main page? Is there a link?
nit: This should be away
I believe this has to start with `\` to get proper context, otherwise it is assumed to be part of the current namespace as `\AllPlayers\Service\Guzzle\Http\Exception\BadResponseException`.
Revert this shit.
These 2 rails deps are just too old, they should be ~>3.2.  All new upstream development is currently against 3.2.8, so there is no reason to make this project start off already playing catch-up. Related, this is probably why you got the error listed as the reason for some of the extra code in the base ARes class below.
Now I think that we're good to merge it. Ideas?
Теперь тест будет падать на русской локали.
基本はオフラインインデックスを使うようにしたいんですけど、
実行時に環境変数として通常インデックスを使えるようにもしておきたくて
こんな感じになってます。コメント付けておきますね。
yes, i was thinking about that.
will do.
I don't think this calculation is quite right for RGB images.

If we have a 2x2 (xLen = 2, yLen = 2) image with 3 RGB channels and 2 bytes per pixel, then as it is ```index``` will be 12 when we try to retrieve the b=1 byte from (0, 0) at channel 0.  Regardless of whether the channels are interleaved, the index in this case should be 1.

If we have the same image and wish to retrieve the b=0 byte from (1, 1) at channel 1, then as it is ```index``` will be 7.  If the channels are interleaved, then the index should be 20; if the channels are not interleaved, then the index should be 14.
I would prefer if this was:

`colorize! if @colorize_logging`

That would ensure that this line still works when we change out way to `colorize!`. (Atm, its pretty much equivalent)
``[1]_``
What's the purpose of this. It does not seem to be really used.