labofsahil/github-event-dataset-2012 huggingface dataset:
Instead of using the `should` library, tower's using [chai](https://github.com/logicalparadox/chai), which has `should`, `expect`, and `assert` functionality that works on the client and server.  Personally, I don't like the rspec / "should" syntax because it adds a layer of abstraction over the tests that makes it harder for me to read.  Tests should be developer friendly because we're the ones reading them on a daily basis and I haven't really seen clients or non-developers look at the BDD/TDD spec, let alone try to read it and make sure all expected functionality is tested :).

Also, the mocha tests can be run with `npm test`: https://github.com/viatropos/tower/blob/703de31bb311ceac826a27ac786474f1f3eb5b8d/package.json#L79.

Thanks though, I'll keep the cake task in there.
这里在我这里部署时需要加上两行依赖

```ruby
gem 'execjs'
gem 'therubyracer'
```

不然会有
Could not find a JavaScript runtime. See https://github.com/sstephenson/execjs for a list of available runtimes. (ExecJS::RuntimeUnavailable)
的问题

后面我提交一个commit里面fix即可。
удали весь код метода и попробуй заново
no. we want to know which is the shared cache so we padd each rows on its line size so every thread starts on a different line.
I get:

No route matches {:action=>"show", :controller=>"responses", :sighting_id=>#<Sighting id: 101, ... other attributes go here some of which are nil... >}
The problem might be "delete" and "status" hit the keyword in javascript in some of webkit version and cause syntax error. Though both GTK and Qt works for me, might different version of gtk/qt hotot have this problem.
Yeah, I noticed the missing run right after commenting. Definitely got the failing test case going. It appears to be related to the table/parentage issue. Unless @wycats knows how to fix it already, I'm happy to work on this one.
标点和空格在引号总通通都是有反应的
Done checking! Merge!
maybe 'def self.authenticate(name, password)'? :)
please, please, please, with a lot of sugar. _ALWAYS_ try to use _try-with-resource_ statement
where possible. Checkout comment on service interface. `InputStream` as parameter would be
also nice.
yep, sorry about that. the last event.PreventDefault() call is causing the
error.

On Thu, Mar 8, 2012 at 3:43 PM, Andre Dublin <
reply@reply.github.com
> wrote:

> which file? rolldown.js?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/Rhodee/adelante/commit/e691b94bb3a1e5d97f0321a1c4f90c93a8818f4b#commitcomment-1062895
>



-- 
Mr. Denis R. Rhoden Jr, AICP
LinkedIn <http://www.linkedin.com/in/denisrhoden>
Twitter <http://twitter.com/#!/revelar30>
-----------------------------------------------------------------------------------------------
This E-mail is confidential. It may also be legally privileged. If you
 are not the addressee you may not copy, forward, disclose or use any
 part of it. If you have received this message in error, please delete
 it and all copies from your system and notify the sender immediately
 by return E-mail.

 Internet communications cannot be guaranteed to be timely, secure,
 error or virus-free. The sender does not accept liability for any
 errors or omissions.
2012-02-16 20:35:10 ERROR: Item (Entry: 59120) marked as non-disenchantable by RequiredDisenchantSkill == -1, remove disenchanting loot id.
2012-02-16 20:35:10 ERROR: Item (Entry: 59121) marked as non-disenchantable by RequiredDisenchantSkill == -1, remove disenchanting loot id.
2012-02-16 20:35:10 ERROR: Item (Entry: 65020) marked as non-disenchantable by RequiredDisenchantSkill == -1, remove disenchanting loot id.
2012-02-16 20:35:10 ERROR: Item (Entry: 67129) marked as non-disenchantable by RequiredDisenchantSkill == -1, remove disenchanting loot id.
2012-02-16 20:35:10 ERROR: Item (Entry: 67151) has wrong (not existing) spell in spellid_2 (98718)
Este array...... Al ser algo general..... no deberia estar definido en algun lugar que sea accesible para toda la aplicacion?
Dürfte unter Linux auch standard-mäßig drin sein... hast es ja schon rausgenommen ;)
Ich finds gut
My change was to reduce duplicate code in the lib and in the cli.

We could add an option to set the language. But who is this option invented for? I don't see any complaints from any users that need this.
s/arguments/options/

And no need to save options, use 3-arg split to request just 1 split item
@Undergarun esta revertido este y puesto una nueva version, pero sigue con fallos..como cooldowns de 20dias por spell y cosas asi
I think I will try to find some time and check spell attributes for some attr maybe some kind of TARGET_PLAYERS_ONLY or TARGET_PLAEYRS_AND_PETS_ONLY can be found. Also some code optimizing can be done in FillCustomTargetMap() which I will try to do.
Exactly, why only one thread working? Mangos started with 6 Map.UpdateThreads and load balancing disabled. Why change in some point to only one thread.
https://github.com/Batters может хватит ругаться? ничем не лучше школьников с вовжопы. Не ошибается тот - кто ничего не делает.
I don't see `GroupedRating` used here.
A couple of points:
1) It looks like you're still doing set operations, not top-level hash operations.
2) The client shouldn't do any of the MD5 work if ignore_duplicate_jobs? is false.
3) We'll need to refactor this into client-side middleware.  If you want to take a stab at the design and implementation, feel free.  I'll try to find some time over the next few days to work on it.
I thought I was assigned for this. :D
Should restrict value input to [A-Fa-f].
typo, kernel
why can't we just iterate over `form in self.forms`?
Guess I should have had a look on your project list first... ;)

Thanks for the information!
So if I read this correctly, what rt_finalize_gc() gains over rt_finalize() is that it doesn't reinitialize the memory block after finalizing it.  Two things.  First, I think you could key off the "det" (det=deterministic) parameter in rt_finalize() to do the same thing.  Second, this re-initialization was added at Andrei's request, I think partially in an attempt to make badly written finalizers behave more sensibly.  He'd really have to weigh in on whether this change is acceptable.
I do not change the total size which still indicates the sum of *original* sizes. But when I calculate the total percentage of progress, I use the native sizes of all photos to get it right.

Then, the solution is a bit weird since the total size is *before" resizing and the various sizes of each file is updated *after* resizing. 
But it allows to have the 2 values, and (most important) a real progress :)
Wow, Thanks :D
Does this still apply?
I like this clarification.
Line 98: you have $oObj instead of $cObj.. returning false for everything! And it only took me 4 minutes to find it.
ops mi sa che non dovevo caricare tutto nel branch master...
apache sounds fine to me :)
(I'll ask John if I should merge or just let him pick it up)

As for the name, I'm no lawyer (thank god) but if the author asks for I'd consider it playing nice to rename it to jgrapht-tgraph or something along those lines.
pretty sure this breaks a bunch of AMO `devhub` tests. does it not?
add one newline at the EOF
Oops. Good spot, fix incoming.
Sorry, i'm incorrect says.
I mean that in the custom type can be override some options of parent type, but here overrides will not be passed to `getDefaultOptions` of parent type.

I have trouble with `data_class` option, for example. Value of this option defined in my form type, but the form always builds with the empty data which contains empty array (in this case the FormType win), expected the closure.

Related issue [#3327](https://github.com/symfony/symfony/issues/3327)
Interesting. The main platform for openlava is x86_64 so perhaps all OS running on it have pidof, but little hardcore shelll scripting 
can only be beneficial.
I always avoid one character variable because it makes pdb useless (you have to type ``locals()['a']``). Two characters is ok though :)
it seems like we probably want to `$(window).resize()` here too?
Sometimes a global .gitignore can be helpful: http://help.github.com/ignore-files/
I think this looks fine.  It's interesting that you found the need to stor the type of document in the document identity.  There's always been a tension between the identity and the edition - which owns the type?  Maybe they both do?  Whichever, I think this is a good solution to the problem, given the constraints.
I figured `async.forEach` is actually better for situations like that:

```async.forEach(files, function(filename, cb) { ... }, function(err) { ... });```
I am very dubious about this. Why should reification logic change between reifyThis and reifySymRef? 

The main difference seems to be that moduleClasses here always generate freeVars. This seems wrong. Certainly, static module classes should be locatable with mirrorCall("staticModule", ...).moduleClass.
See also:
```
commit 119d13cc9d18987c04bb7122a0dbbb8c9f04ac90
Author: Michael Price <price@kilentra.net>
Date:   Tue May 4 20:37:51 2010 -0400

    Fixed school year label in onsite student registration
```
Crash Fix

if (spellProto && spellProto->AttributesCu & SPELL_ATTR0_CU_BINARY)
Greate, now will be more easy.
This change is not available in any tag yet. Any idea when you going to make another tag? Keep the great work and please take a look in the "Pull Requests" a lot of great improvements there.
You must always initialse error to NULL (see GError documentation)
Dit e-mailadres is niet meer in gebruik. (Uw e-mail is wel correct
doorgestuurd en zal bij de ontvanger aankomen.)

Netlash-bSeen is van naam veranderd en heet vanaf nu Wijs.
Meer informatie vind je op http://wijs.be

Het nieuwe e-mailadres is nu dieter@wijs.be
Basically the main reasons are:
so that codecs supported do not vary across computers.
so that we do not have to worry about patented code
so that we can get rid of one of many bad areas in FoFiX's source code.
Ну и? Это повод запретить тестировать и/или использовать остальным? А опция все же будет потом, даже если без горячего переключения локали. Не все пользователи знают как установить язык с помощью переменных окружения...
A minha filosofia é sempre em busca da simplificação do codigo. E utilizar a classes Faces como wrapper para os principais métodos, pertindo acesso ao FacesContext sem injeção é também uma simplificação. Estaria satisfeito apenas com os métodos comumente utilizados no ManageBean, deixando o @Inject ocorrer normalmente nas demais camadas.

+99% dos meus ManageBeans soh chamam addI18nMessage(), validationFailed() e getManageProperty(). Este ultimo simula a anotação @ManageProperty, e com isso você reduz bastante o número de linhas do ManageBean, deixando efetivando somente os metodos e injeçoes essenciais.

Mas se voces nao compartilharem desta ideia, farei outro PR... Mas reflita um pouco
I thought this branch was dead... are you still using it for something? If not we should go ahead and remove it.
1，是的
2，不复用，理由是验证、逻辑等会差别较大。单独拿出来就不会影响网站本身功能，也易于优化。
really weird. Sounds like a bug in LLVM.
Oh, curses. "__proto__" in Object.create(null).
Better not be --si switch or I'm going to drive to Verona and beat you up.
Why not convert to integer minutes and seconds?
Shaun,

The design is based on one advocated by (among others) [Jim Webber](http://jim.webber.name/shortbio.html). He did a talk recently in Brisbane & Melbourne at the [YOW! Developer Conference](http://www.yowconference.com.au/):
http://yow.eventer.com/events/1004/talks/1047

The Event model is outlined from 38 minutes onwards.

Tim
1. translate strings and make them translator friendly; get the entire string into one string (ie. not separated by variables)
2. html escape the translated string
Squish parameters into two lines.
Y asi lo arreglais? comentando todo para ver si se arreglan los crashes? :O
верни ты плз, я смержусь просто.
When changing the template to say: 

 knp_menu:
    twig:  # use "twig: false" to disable the Twig extension and the TwigRenderer
        template: @AcmeDemoBundle:knp_menu.html.twig

Is it possible to extends the existing template without having to do it all over ?
Exemple:

{% extends '@KnpMenuBundle:knp_menu.html.twig' %}

{% import '@KnpMenuBundle:knp_menu.html.twig' as macros %}

{% block list %}
{% if item.hasChildren and options.depth is not sameas(0) and item.displayChildren %}
    <ul{{ macros.attributes(listAttributes) }}>
        {{ block('children') }}
    </ul>
{% endif %}
{% endblock %}

Doing so currently fails because the templates are not in the vendor/bundles/Knp/Bundle/MenuBundle/Resources/views but in vendor/KnpMenu/src/Knp/Menu/Resources/views

Any solution to this ?
Thanks
Next rounds of refactoring fixed this mistake
It's acutally: `SVN: $Id$` in the file header. And `Release: @package_version@` in the class header. Small mixup. :)
Absolutely.  All I did was handle the new and updated packet types.  Let me
know what you think the best way to proceed is.

On Tue, Jan 31, 2012 at 6:01 PM, Steve Losh <
reply@reply.github.com
> wrote:

> This looks good.  There's probably still a bit of fleshing out to to, like
> adding new item/block IDs that have been introduced, right?
>
> ---
> Reply to this email directly or view it on GitHub:
>
> https://github.com/jkdufair/clojurecraft/commit/e43755107fc4fe7d5c1672c5cfe75a69608437b3#commitcomment-920541
>
This mechanism works perfectly but doesn't strike me as particulary elegant. Any suggestion more than welcome.
AFAIK on boss death those mushrooms dont disappear. On retail I always had to wait until the remaining ones exploided before safely looting him
I think you broke something here. You didn't remove the closing brace.
Don't use that function, I'd rather remove the index position in favour of bulking up the caller code.
Ah, I found it! The problem were some trailing tab characters after a backslash causing the multiline-string to break. This problem didn't show up for the minified javascript. That is why you didn't see it probably. I have `SCRIPT_DEBUG` set to `TRUE`. I'll send a pull request.
please try:      if (R->cf!=currRing->cf)
As mentioned in another commit: getRefinedDeclaration() can't return null
I tried several combinations but none worked except my workaround.
duh, this isn't related to configuration anyway
if this was not clear, there is definitively something going really wrong on this system , just look at sound_init code, it's not complicated, even if mclk is 0.0 (which is already going to screw up sound by itself), mcycles per samples for psg/fm should not be like that. I don't even know how both end up to 16 as fm_cycles_ratio is fixed to 144 x 7 x 2048 when hq_fm is enabled. It's like there was a major memory corruption on the system, as when you do buffer overflow and end up corrupting static data.
Unfortunately, I don't think I can help further, your only solution is to step in the code, debug it and figure what's happening on this system...
I don't agree with this change, the event page should be prefixed in the near future, as a fully serialized reference.
>    <class class="plone.app.something.browser.SomeView">
>       <implements interface="plone.app.toolbar.interfaces.IUIView"/>
>    </class>
>
> Then have subscriber for IPubAfterTraversal doing:
>
>    def mark_ui_views(event):
>        request = event.request
>        view = request['PUBLISHED']
>        if not IUIView.providedBy(view):
>            return
>        request.response.setHeader('X-Theme-Disabled', 'True')
>        view.context.changeSkin('toolbar', request)

Okay, that works. Rather nicely. But Jean Jordaan, who responded on
the dev list, is going to hate us for this. Opening folder_contents in
another tab is now horribly broken.
Okay, very nice ;-)
ups!! I don't know what has happened with the indentation!
My apologies... I hope you understand my changes, anyway.
it does not work with versions like 1.5
.match(/(\d\.\d)/)[0] works fine
Kek, **it happens...
I added the copy to the Google Doc, maybe it's better if we have it there? Give a note if you approve or change it. I am going to improve them, too.
s/path/patch
All progress stuff is now prefixed with 'support'. You don't need to call the normal version at all.

In this case it would be

```java
activity.setSupportProgressBarIndeterminateVisibility(true);
```
Agree, although not part of this commit really. I just removed the redundant fully-qualification of the name. But I'll fix this also!
Why defaultText option doesn't work properly?
Seems github has got some problem. Let's ignore this.
Not too sure on how often the purge should run to clear the list of quit players. Quit list does not hold reference to Player or Player Event objects so they are free to be gc but only hold the players unique username and date object, should be good as it is.
ping @Herzult
Klar, ich kann's so formulieren, das es absolut wasserdicht ist. Andererseits ist das nur die Überschrift, die einen schnellen Hinweis geben soll - die komplette Beschreibung ist unter dem jeweiligen Eingabefeld ständig sichtbar (nicht wie z. B. bei den Systemeinstellungen) und sollte im Zweifelsfall Aufschluss geben; außerdem befinden wir uns ja schon im Bereich "Paginierung". Ich bin nicht sicher, ob ein Roman als Überschrift zielführend ist - wer öfter mit Articles arbeitet, wird dadurch vermutlich eher ausgebremst, weil er vergleichsweise viel Text lesen muss, bis die signifikanten Wörter kommen.

Na ja, ich werde noch mal darüber brüten, wie man es klarer formulieren kann, ohne die Prägnanz einzubüßen.
I am not understanding anything about this branch :S
Hello:

I have a question.

Why did you change the style here?

This prevents the action bar from being shown on Galaxy Nexus (and tables until another change re-instated that).
I am planning to change this back and I wanted to make sure that this was not the cause of any problems and that
this change was actually unintentional.

Thanks
-Flavio
That's strange ... in my running test system, this line was in the file ...
Clever. I was wondering how I was going to pass the true title forward. It seems I already had.
Wieso habt ihr das umbenannt?
The usual value to use for something null in Python is None....
У тебя итак есть коллекция, просто ленивая. Смысл дальше её раскрывать через fetchAll()? Это вообще внутренний метод в коллекции должен быть.
@dinamic : apparently, this has been added two days ago : https://github.com/symfony/symfony-standard/commit/5a2c4ba7ea07f03d1222a682d360e631dea8abdd , so I guess there won't be any problem in the next tag.
Треды все еще не скрываются.
Не ленитесь, не нужно отмахиваться, выставьте sav.cookies единсвтенный равным true, и запилите все нормально.
@johanlunds with the responders gem and custom Rails generators feature.
Happy to merge this one commit ASAP.  Could merge the same for Passwords and FormHistory.
The pull request should probably be reopened then, pinging the author.
Forget that ... just recompiled this latest commit and all seems fine.  Weird.

Apologies for the noise.
```Readonly``` seems unmaintained old module and has quite few bugs that haven't been fixed. And it also will mess up the test coverage, I think use of ```Const::Fast``` is better.
This function gated every paranoid class because of a type mismatch, `paranoid_column_type` returns a symbol.
Well I've worked around it with 45f95a49a3b6be5af629891ec68d73d867eee22f, which also has the added bonus of conforming with readyState requirements for server closes.

There are a few test cases which are difficult to prove, with or without the close event, such as definitely saying that the client won't reconnect after getting a 204 response (halting problem, yay).
Hmm for me that would be ok, but i dont know if we break peoples existing interfaces.
I would propose to merge this PR and maybe add a config option or smth to change behaviour lateron.
ahahaha well I was doing some funky positioning via css to get the icon aligned with the article title when I noticed the extra padding. Removed it and BAM! Lined up like a charm :smile:
Is there a way to not have an empty conditional?
Auch hier ist "Komprimierter Link" die korrekte Form. (https://secure.wikimedia.org/wiktionary/de/wiki/Link)
> Which also leads to a related question, should we allow to select the group validated per parameter / return value.

I think this is addressed by the `groups` parameter of the annotation triggering method validation (`MethodValidated` or similar). This would not be on a per-parameter base, though, but for the entire method altogether. I think this should suffice, what do you say?
We can set `$postdata['noresample']` here since we're resampling anyway as part of the resize—I imagine Imagick uses a sane default for quality if the image happens to be a JPEG. The resample path converts images to JPEG and I'd like to avoid that if it's not necessary.

The only reason a file should still be unacceptably large after the resize step is if it's the wrong format for the data within (template vs wavelet), is this a problem we care about or are likely to encounter at the > 1600^2px scale?
I think this import is still needed. fix_username is still called in this file.
And ka-pow! Thanks, Boone . . .
the push method is basicallly great, the viewId param is also fine; the void return value is also fine with me. I'm not so sure about the XLinkIdentifier though. a) we don't use raw Collection class, but rather java.util.List and b) I'm not sure that we need an additional class here. It's not that those xlink params are pushed here directly. Basically they are transformed before in OpenEngSBModelObjects from the correct domain. therefore I think it should be sufficient to push them directly.
Take a look at mktemp (coreutils fedora package).
Good things:
1. trim()
2. preventDefault
3. event manager
4. IE support
The class you are looking for is named CRSMatrix.
What's the advantage of running these two commands rather than simply `python setup.py test`? Also, I must be stupid - how the heck does `python setup.py nosetests` even work? Where does that command/alias come from?
unless I'm mistaken, I think the get_page call a few lines down against main_index_url is the only redirect case right now
I think it's unexpected for the url_name (which in most cases is the pkg name) to already have the "/".  thinking it's better to add that as part of url construction.

I think you could move the embedded  `mkurl_pypi_url` function up higher (which adds "/"), so that could be reused to construct `main_index_url`

    main_index_url = Link(mkurl_pypi_url(self.index_urls[0]))
Remove the spaces around `handle`.
One of my test cases is 'numbers near'.  it's a definite edge case, although with dates might not be so.

E.g. 
A.intersect([1,5,7], [2, 5, 9], function (a, b) {return Math.abs(a-b) < 2;});

should give [1,2,5].  but it goes wrong if you try and use unique using the same comparison function - in this case, 1 and 2 will be considered the same and 2 will be removed.

With numbers it looks a bit unlikely, but I could see a 'dates +- 2 days' type use case.
"Button" can be changed to "Button List", "ListButtonItem" can be changed to "ButtonListItem"
You didn't add the png file into this commit
some hard code for Imitating the original select's triangle
There seem to be a number of changes in here unrelated to Authentication APIs.  It would have been great for review if these were separated.
Is there a particular reason the test needs to change?  Do you just prefer this or is it required to demonstrate the bug you're trying to fix?
Default to False, which means we should do matrix colouring, fine.
Magic number, clear, but...
ah right, will do that as well then.
hmm, people can do that, I’d like to keep it dead-obvious
Wow, isn't that a bit confusing?
If someone calls endpoint or processor in the constructor then they'll get null...
why use ReentrantLock, why not synchronized?
Hm...gave it some more thought. The content of ThreadLocalReflectiveDynamicAccess#classLoader is

return dynamicVariable.value(); // java code therefore return ;)

even if this gets inlined it is still dynamicVariable.value() which is fine. I did some compiles and decompiles and failed to see this optimization in action.
Well, we should at least know about it right, and restart them? I could let the Registry watch them and create fresh ones when that happens?
Does Akka create producer actors?
* @Destroyed
* context
* missing space in front of "when"
Prefer the documentation:

    def pause(self):
        ''''Pause the video
        .. versionadded:: 1.4.0
        '''
        ...
This should be grouped with "os", and the blank line should be between them and the pulp imports per PEP8.
The problem with making these flags is when updating the repo config it's tricky to then remove the flag. But you're right, this needs a parse_boolean and was just missed.
Aah, My bad, Changed this instinctively. Will undo this.
this doesn't seem right -- we use `something == null` as shorthand for `something === null || typeof something === 'undefined'`, which is nearly always what you want.  if anything i would think that you'd just check if `typeof something === 'undefined'` (w/o the null check).

[that's why the style guide makes this one allowance for the usage of `==`.](http://siq.github.com/front-end-development-guidelines/#always-use-instead-of-unless)

why change this to `=== null`?
Implemented in commit a7ff687. May be I don't understand your point correctly, but in updateWidget, doesn't setting the collection result in two calls to setting models on checkboxgroup; one because of the collection in multi-select widget and the other one because of the if block that sets the collections in checkboxgroup the same as that in multiselect widget.
`make_runner()` isn't mocked. To do that I would have to have all test cases inherit from a new superclass.
Manter valor original (http://figgo.com.br:8080/)
1/ Beware of files without trailing newlines in git.
2/ I think we should have a file like `errors` or something, rather then create a new file for every exception there is.
Should be "AutoMOD"
Should this have an:

    else:
        src_rel = src

?
I need access to it through a dummy agent for testing. I'm currently using
StubModel. We could make a TestModel that exposes the private function
through a public interface, because that doesn't really belong in the
StubModel.



2012/7/18 Robert Carlsen <
reply@reply.github.com
>

> > @@ -220,7 +220,19 @@ class Model {
> >    int nChildren() {return children_.size();}
> >
> >    /**
> > -     set the parent of this model
> > +     recursively prints the parent-child tree
> > +   */
> > +  std::string printChildren();
> > +
> > +  /**
> > +     returns a vector of strings representing the parent-child tree
> > +     at the node for Model m
> > +     @param m the model node to base as the root of this print tree
> > +   */
> > +  std::vector<std::string> getTreePrintOuts(Model* m);
> > +
> > +  /**
> > +     calls doSetParent() and itLives()
>
> I guess I should have clarified more - I think doSetParent should probably
> be private - did you have a specific need for it to be public?
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/cyclus/core/pull/267/files#r1190890
>
Merge issue!
Please put this on the line above the method itself. Also:
> Returns *an* array of NSString *selectors*
Alright, I'll factor it out and fix the braces.
remove spaces at the end of lines
you don't have to do an include. It is already included.
We use the `exit` event in 0.7, this was an API change from `0.6`.

Commit: 90ce5b3d41a01bfd5793d1d634318fe607fa533c
Source code: https://github.com/joyent/node/blob/master/lib/cluster.js#L297
Let's move this file to the repository with the binaries.
is it always going to be nii.gz? Are you sure it is not controlled bys ome env variable like FSLOUTPUTTYPE in case of FSL commands?
ah but FSL's default output type is taken from the environment variable, even though in inputspec it is NIFTI. if somebody's FSL environment variable is NIFTI_GZ, default output of FSL will be NIFTI_GZ. the point was not to mess with what people are used to.
Nonetheless, I can't believe that the answer is that we have to guard every "from ... import ..." just in case someone left out a basic language feature. There is tons and tons of code out there that depends on this working correctly. (Recently on the statsmodels list there was confusion abut whether circular imports were even possible, because they *never use* the 'import ...' form.)

I'm not opposed to working around other people's bugs when necessary, but there has to be more to the story here.
`window.onload` should just be `window`, since `window` is a reference to the global object.
лишний пропуск здесь и ниже
This
```
      images_should_compile = ["a.png", "happyface.png", "happy_face.png", "happy.face.png",
                               "happy-face.png", "happy.happy_face.png", "happy_happy.face.png",
                               "happy.happy.face.png", "happy", "happy.face", "-happyface",
                               "-happy.png", "-happy.face.png", "_happyface", "_happy.face.png",
                               "_happy.png"]

```
should be replaced with
```
      images_should_compile = ["a.png", "happyface.png", "happy_face.png", "happy.face.png",
                               "happy-face.png", "happy.happy_face.png", "happy_happy.face.png",
                               "happy.happy.face.png", "-happy.png", "-happy.face.png",
                               "_happy.face.png", "_happy.png"]

```
Rake was aborted because of `-happyface` has no extension. I think it because of old frozen versions of sprockets-rails and sprockets, isn't it?
`ControlThrowable` shouldn't be caught by anyone other than the compiler generated catch.

```scala
def foo: Int = { try { (() => return 0)() } catch { case _ => 1 } } // Warns; returns 1

def bar: Int = { try { (() => return 0)() } catch { case NonFatal(x) => 1 } } // returns 0

def baz: Int = { try { (() => return 0)() } catch { case _: Exception => 1 } } // returns 0
```

(SI-5890)[https://issues.scala-lang.org/browse/SI-5980]
Or you meant "swallow NonFatal, rethrow Fatal"?
Yes, if one must hard abort "abort" is the way. Thank you hubert for picking up on my discouragement of assert-false.
Ok, sure thing.
I see. Can you clean up those comments? Comments in test-cases are supposed to explain what's going on and what's expected. This is not the case.
From the more-than-one-way-to-skin-a-cat department, I realised this morning we could ship a pretty useful macro:

```scala
nullSafe(a.b.c)
```

rewites to

```scala
if (a == null) null
else {
  val ab = a.b
  if (ab == null) null
  else ab.c
}
```
oh, I didn't spot the space between the patmatDebug and the opening paren (search/replace mistake..)
sorry about that, but you can completely ignore this commit except for the TODO comment at the top
You can write this less noisily as
```
def unapply(tree: Tree) = tree.attachments.get[SuperCallArgsAttachment] collect { case SuperCallArgsAttachment(vargss) => vargss }
```
Ha! actually, i just checked parse_time and I actually wanted it to give current time if given None so I'll fix it here.
`Matrix**Rational(1, 2)` does exactly this already.
My latest commit is causing some issues. If you want, we can drop it for now and figure it out later.
I think because they are non-standard terms but the functionality is available in another method.
I don't understand. Why aren't you just using raises()?

By the way, raises() now works with a lambda or as a context manager (see the docstring).
The full function name for iterable is "all the possible types of the `.args` field of a `Compound`". I could type this `class Args(tuple)` and then use `isinstance(blah, Args)`. Would that be better?
On 11.05.2012 13:59, raoulb wrote:
>> +
>> +    assert fresnelc(z).diff(z) == cos(pi*z**2/2)
>> +
>> +    assert fresnelc(z).as_leading_term(z) == z
>> +
>> +    assert fresnelc(z).rewrite(erf) == (S.One-I)/4 * (erf((S.One+I)/2*sqrt(pi)*z) + I*erf((S.One-I)/2*sqrt(pi)*z))
>> +
>> +    assert fresnelc(z)._eval_nseries(z, n, None) ==  z*(-z**4)**n*(2**(-2*n)*pi**(2*n))/((4*n+1)*factorial(2*n))
>> +
>> +    assert fresnelc(z)._eval_aseries(z, oo, 0, 0) == S.Half + sin(pi*z**2/2)/(pi*z)
>> +
>> +    assert fresnelc(w).is_real is True
>> +
>> +    assert fresnelc(z).as_real_imag() == ((fresnelc(re(z) - I*re(z)*Abs(im(z))/Abs(re(z)))/2 + fresnelc(re(z) + I*re(z)*Abs(im(z))/Abs(re(z)))/2,
>> +                                           I*(fresnelc(re(z) - I*re(z)*Abs(im(z))/Abs(re(z))) - fresnelc(re(z) + I*re(z)*Abs(im(z))/Abs(re(z))))*
>> +                                           re(z)*Abs(im(z))/(2*im(z)*Abs(re(z)))))
>
> Done. Do we want even more?
>

No I think that's enough.
it's optional, and it's the last parameter. why should you pass null?
`getSortingFieldValue()` would be more descriptive as it returns the value of the field
1. `is_callable` isn't too slow comparing with `is_string`: http://liveworkspace.org/code/2664hV$3
2. `is_string` was replaced by `is_callable` because `create_function()` returns string.
`is_numeric` will return `true` for `'0xFF'`.
`parameter is available since version 1.1.13.`
No need for changelog line because mainly it's about formatting.
I noticed and this raises my concerns. Looking at the ```next_result``` we don't want to accept answers such as:

  abc 
  200 some result
  some result
  200 another result

This will be parsed as [200, "some result\nsome result"] but there was some partial result left in the buffer...
ah, im on windows 7. i have a linux hosting plus testing vps but I don't actively have the need for node on them. i would most likely use nvm if i did looks like someone made a nvmw, hum.
Thanks! Will look into it
should $class be typehinted with ```EventSubscriberInterface```?
Or rather, we're injecting the response with the "val entities = reversedentities" bit--that could be clearer.
In order to keep the filter agnostic to all the date/time handling stuff, I kept the interface as strings. I'll review to see if I've broken that plan

On 20 Oct 2012, at 06:07, Ben Hood <notifications@github.com> wrote:

> In kernel/src/main/java/net/lshift/diffa/kernel/config/RangeCategoryDescriptor.java:
> 
> >      if (!isRefinement(refinement)) throw new IllegalArgumentException(refinement + " is not a refinement of " + this);
> > -    RangeCategoryDescriptor refinedRange = (RangeCategoryDescriptor) refinement;
> > +    if (refinement instanceof RangeCategoryDescriptor) {
> > +      RangeCategoryDescriptor refinedRange = (RangeCategoryDescriptor) refinement;
> > +
> > +      refinedCategory = new RangeCategoryDescriptor(
> > +          this.dataType,
> > +          refinedRange.lower != null ? refinedRange.lower : this.lower,
> > +          refinedRange.upper != null ? refinedRange.upper : this.upper,
> > +          refinedRange.maxGranularity != null ? refinedRange.maxGranularity : this.maxGranularity);
> > +    } else if (refinement instanceof RollingWindowFilter) {
> > +      RollingWindowFilter filter = (RollingWindowFilter) refinement;
> > +      WindowRefiner refiner = WindowRefiner.forPeriodExpression(filter.periodExpression).
> > +          withOffset(filter.offsetDurationExpression);
> > +
> > +      WindowRefiner.TimeInterval interval = refiner.refineInterval(this.lower, this.upper);
> I think the factoring might need a bit of tightening up here:
> 
> The expression WindowRefiner.forPeriodExpression(filter.periodExpression).withOffset(filter.offsetDurationExpression) is duplicated in a few places in this class;
> Since RollingWindowFilter depends internally on WindowRefiner, could the RollingWindowFilter have an instance method to cover some of this code?
> It seems that there are many transitions from strings to dates and back again. Maybe this is unavoidable, but if it isn't it might be nicer to decide which way round suits the internal mechanics of the WindowRefiner best, given the handful of uses of that class.
> —
> Reply to this email directly or view it on GitHub.
>
Should be listRepairActionsForPair
Release notes documenting the feature change, Java library upgrades and Javascript library upgrades have been added in 9957315.
OK - if you need null values, then I suggest we implement a helper routine to validate all functions where startDate must be before EndDate.
Bug fix.  Want this in a separate PR?
c/which perform/which configurations perform/
(I get the sentence but am thinking of translation)
this sentence isn't grammatically correct.

something more along the lines of: mongodump and mongorestore provide similar functionality; however...
hey @samg, I removed that reference for a few reasons:
 - the top portion (lines 1-23) is what gets executed when ::PhusionPassenger constant is defined.
 - the comments in the second portion refer to some 'older version' of passenger.
 - the only action the bottom portion takes resolves to: "This is only done for old versions of passenger that don't implement an explicit after_fork event."

If the third reason is not true, and it indeed needs to check_server_connection, we should add that back in.
you don't seem to use Option
Not necessarily, I just though why not? The delete command isn't something called very frequently I guess. However, it's not required of course.
Kill via sigterm before sigkill.
What happens if this function is called to load valid drivers first and all drivers subsequently?
I think the new system for plural form should be used instead.
Sending the email must be made optional!
Plurals.
755d6b1
which `tilt` file?
Update these headers to match the other ones.
It is not the order that is important here, the 'code-quality' target must depend on 'plugins'.
Each rollup file is written idempotent, so a failure would just mean that some of the rollup files are written.  Each rollup that is written should be correct.  Each run of `mojito compile rollups` will rebuild/rewrite all rollup files.
Looks like this was probably just git interpreting a file move due to some similarities in the files (copyright mostly).
Adding a //TODO:  comment will help IDEs track them down automatically
naming consistency: receiptDelete vs addReceipt. suggest verb first --> deleteReceipt
okay!! I will do that!! 

On May 14, 2012, at 1:48 AM, John Stoecker<reply@reply.github.com> wrote:

>>         patient.set('doctorid', -1);
>>         Ext.getStore('patientStore').add(patient);
>>     },
>> 
>>     //removes all patients from the current doctor
>> -    removeAllPatients: function () {
>> -        Ext.getStore('doctorStore').getAt(this.currentDoctorIndex).patients().each(this.removeAPatient);
>> -        for (i = 0; i < Ext.getStore('doctorStore').getAt(this.currentDoctorIndex).get('numpatients'); i++) {
>> -            Ext.getStore('doctorStore').getAt(this.currentDoctorIndex).patients().removeAt(0);
>> -        }
>> -        Ext.getStore('doctorStore').getAt(this.currentDoctorIndex).set('numpatients', 0);
>> +    removeAllPatients: function () 
>> +    {
>> +    objectRef = this;
>> +    Ext.Msg.confirm("Confirmation", "Are you sure you want to do that?", goDeleteAll);
>> +    function goDeleteAll(btn)
> 
> Ah yes, and here as well of course.
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Raxa/Raxa-JSS/pull/45/files#r814347
Tarang -- if the Obs has been voided by a doctor, I believe we don't want to include it. Why did you comment out these lines?
``another Op that is already being applied inplace on the same input``
From here.
Whitespace. Could you set up your editor to automatically fix it for you?
I'm wrong  that is only for version added - but in this case the release note doesn't add much, if anything.
Any reason to change this?
I am going to fix all these files and add more unit tests in my next commit. Thanks for reviewing.
`wrapSubtract` for one argument is defined incorrectly at numbers/numbers.clay:526. Is `significand` tested?
s/an BOOL/a BOOL/
Sure that makes sense, I can look into modifying how that works.
Awesome! I'll try to be more responsive next time. Let's get this merged!!!

On Wed, Aug 8, 2012 at 6:49 PM, Mike Bannister <notifications@github.com>wrote:

> In packages/accounts-oauth-helper/oauth_server.js:
>
> > +    // method is called. Maps state --> return value of `login`
> > +    //
> > +    // XXX we should periodically clear old entries
> > +    oauthAccounts._loginResultForState = {};
> > +
> > +  };
> > +
> > +  // Handle _oauth paths, gets a bunch of stuff ready for the oauth implementation middleware
> > +  Meteor.accounts.oauth._handleRequest = function (req, res, next) {
> > +
> > +    // req.url will be "/_oauth/<service name>?<action>"
> > +    var barePath = req.url.substring(0, req.url.indexOf('?'));
> > +    var splitPath = barePath.split('/');
> > +
> > +    // Find service based on url
> > +    var serviceName = req._serviceName = splitPath[2];
>
> Ah, yeah, OK, I definitely should have taken the misuse of req as a signal
> something wasn't awesome.
>
> I see, yeah, I can't remember if I had a good reason (or what seemed like
> one at least) to stack the middleware like that... but definitely makes
> more sense to call to a impl. specific method. I'll beat it back into shape!
>
> -Mike
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/meteor/meteor/pull/251/files#r1338722>.
>
>
I think this is a copy-and-paste error. "happy" should be "sad" here.
This resulted in the log message

> WARNING You should have at least one memcache server. You have 1.

Am I supposed to have one or two?
`self.data[data_layer]`
proc{ |r| CheckRunner |

to make it easier to see side by side
Pas de slick sur le serveur s'il te plais. Passe donc par des int posx, posy, ça va très bien ;)
ok, i understand !
Can we name it accordingly then? This stuff trips me up, like when you give `"80"` as opposed to `80` to Twisted as a port number it tries to map it to a named port which had me running around rabbit holes for a good while. In that specific case the str value came from YAML.
Actually, given there are two example programs, I think this is better as @logan has structured.
I did.
See near the top of the file.
Lets call `.to_i` so the response is parsed consistently regardless of type.
Then again, if you disagree with the logic that is now copied thrice, it might make sense for me to fix it once and generalize now.
Oops, was not intentional.
Why do you remove WeakMap?
Another one, I think. Can you file an issue for it?
I think `_updateHighlightCheckmark()` would be a better name (this sounds like it always sets it on).
Might be good to name this something like "__brackets-ld-highlight" so that if someone inspects the DOM it's more obvious where they come from. Also, this could go in a constant somewhere so it stays consistent between here and `clear()`.
The strings have already been concatenated, so I think you want the last arg to be just ```initialString.length```
Right -- I think the checks you just added are definitely still useful though, since they ensure that InlineColorEditor's document change listener doesn't choke on edits made by itself.
Good idea. Added (by testing whether the start/end line of the TextRange is null--seemed easier than adding a handler to look for the event).
@njx Thanks for the info! It somehow felt that it'd be safer to have nullable parameters to avoid possible errors. However, it also feels strange to "request a file system" and not wanting to do anything with it :)
Do we want to keep this in?
I think I like them better here. They won't really need to change; they're just there to document my assumptions and give a little more context to the code.
Is anyone using new lines in this field? Json equals JavaScript which means it takes extra effort to add new lines in strings.
No space here...
I would define a ConditionalLossesTestCase#assertAssetOutputEqual in that case and/or a ClassicalAssetOutput#equal_to.

Reasons: 1) the previous behavior is not lost, 2) minimum surprise, 3) you are not implicitly requiring that also loss_curve, loss_ratio_curve, conditional_losses should have an equality operator overriden.
Unfortunately XSD doesn't really cater for element deprecation...
Forgot to mention, it's intentional. Stuff like that should not be in the repo gitignore but in your own global gitignore.
Why just WidgetEvent? I think we can support here all Events.
Don't indent docstring.
*POST_MESSAGE_MAX_LENGTH*?
That's why I was confused since there's no way to get post from outside source if they don't post.
No? This enables or disables HTML escaping. The question is how to escape output of the url tag for JavaScript. Like filter for variables. How to filter tags? There is something in builtin tags to help you with this.
Why did you add to this file?
Add some spacing here before `window`.
Same as https://github.com/mozilla/butter/pull/1227/files#L2R16
Not going to stop reviews based on this but change to single quotes for consistencies sake.
You can do a return false here to cancel the functionality too. This way you can still select the text. preventDefault would prevent other things not ust the click. May cause unexpected behaviour.
Does this absolutely need its own z-index?
Yep, that's just chrome
OTS just copies stuff as is, no checks

tooComplexToFollow == true when the fixing algorithm becomes harder to implement
FYI, you've got `goog.functions.NULL` for exactly this.
this is so wrong, it hurts. maybe we should rename it to `Php5ClosableInterface` or just `ClosableInterface`.
we can replace all the `fromMaybe [] $ lookup ..` with `maybeToList $ lookup ...`
Do a git checkout master <file> to get that version
This condition is really hard to read. it definitely should be simplified.
You'll want to include h/m files in XBImageFilters/Classes and its subfolders
```ruby
s.source_files = 'XBImageFilters/Classes/**/*.{h,m}'
```
There is no 0.8 tag in a repo, please, add it.
We should be using Tim's helper method for this. https://github.com/GeoNode/geonode/blob/dev/geonode/utils.py#L290
Write testcase for run() method as well.
might consider not using HttpErrors if you move this to a central helper class since it may be used outside the context of a REST API call.
And can you put all this changes to spec file for consistency please?
On Wed, Jul 18, 2012 at 10:39 AM, Brad Buckingham
<reply@reply.github.com>
wrote:
>> @@ -0,0 +1,35 @@
>> +class AddRepositoryLibraryId < ActiveRecord::Migration
>> +  def self.up
>> +      change_table :repositories do |t|
>> +          t.integer :library_instance_id, :null=>true
>> +      end
>> +      Repository.reset_column_information
>> +      User.current = User.hidden.first
>> +
>> +      Repository.enabled.each do |lib_repo|
>
> I read something a while back that indicated that using 'execute' for SQL is more efficient in a migration than embedding ruby, when there is a lot of data to be modified.  Have we done any testing of this migration on a server that has a lot of repositories synced?  If not, we might want to do that and make sure that this isn't an activity that takes too much time.

I did run this on a server with a full manifest imported without using
the enabled scope (so it was iterating over hundreds of repos).  It
seemed to take about 30-60 seconds due to all the pulp calls, but
there doesn't seem to be much we can do about that.  In this case we
including information in the table that previously wasn't available
and had to be calculated with expensive pulp calls.

I don't know that just setting  library_instance_id on even a hundred
or so rows should be very intensive.  The calls to pulp would take
wayyyy longer.


>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/Katello/katello/pull/327/files#r1188225
May be some more blah blah....
I want to stick to the pattern of a test for `function` to be `test_function`. Here we are testing the function `_is_finished_dumping`, hence `test__is_finished_dumping`.

Will fix the mistype.
This does not take care of the log level (logging a debug message as error on newrelic looks weird), of the logging channel or of the ``extra`` key (which is where processors can add data, and so extending AbstractProcessingHandler is a lie) (it does not take care of the datetime but maybe newrelic handles the time itself).

Thus, what does ``newrelic_add_custom_parameter`` expect as second argument ? Your code is using the unformatted record, so it could be anything supported by PHP (including a non-serializable object or a resource)