labofsahil/github-event-dataset-2012 huggingface dataset:
有两个问题：

1. cache变量永远不会删除元素么？如果是，可能存在内存膨胀问题；
2. 看这里的实现，目录下增加一个文件需要重新reload才能其作用？
conviniently -> conveniently
@astrofrog - I just remembered when looking through the code that the 9 digits is fundamentally driven by the number of digits that can be represented in a 32-bit int, which is the standard C int length.
Please don't remove semi-colons, also you've changed the indentation here by the looks of things.
This file shouldn't exist.
Indentation is off for the whole block.
I think this might be clearer as 

```php
if (!isset($index[$idx->Key_name]['length'])) {
  $index[$idx->Key_name]['length'] = array();
}
$index[$idx->Key_name]['length'][$idx->Column_name] = $idx->Sub_part;
```

The first few times I read this I thought the length index would only ever have one value which is clearly not the case.
Use ``` ``layer_name`` ```. This is RST.
Why Polish names? You can use internationalization for that.
Clicking create group seems to be missing here
Cookie name is mandatory, so can't you just write getName(). equalsIgnoreCase(other.getName())
You'll have to change the maven archetype so that it uses the new class name.
you should not assume that there is a mapping for the PHPCR node. also i could have an interface where the user can overwrite the generated name. i think you should just check if the nodename field is empty.
Why make this version dependent?  It seems to me we could just move to the new form for all versions, since `.format` exists in 2.6, no?
Yeah. I've looked through AsWeightedGraph sources and realized what you meant. You are right, we can't use "e != e" test here. I'll fix it.
This memory filling is needless, when using `calloc` like above.
Seems like this line is not required. Is there any string from the `2011faq.lang` used on this page?
If no, please remove this line.
If yes, please remove the first argument `"foundation/annualreport/2011"`, the system will find it automatically.
You can go ahead and delete this section now that it is in the header.  Also, apply this same logic for setting the url down in the macro where you render the link for the header.
In Mozilla webdev, we really frown upon using `!important`. Usually, you can just make a more specific selector.
As the comment above states it returns the .app bundle.
There should be a test for this.
I'm not familiar enough with the internals of unit tests and python class caching in order to do so. I'd greatly appreciate the assistance of someone far more comfortable with those areas.
I think that code can be simplified to
```
if ( God->pool().isRequestedLocale( lang ) )
  return _("Yes");
else
  return _("No");
```
It would be good to add a test for the admin count functionality
A taky jsem nenašel, odkud se ta želvička vzala. To je nějaká coffee scriptová magie? Slibuji, že se na něj dneska už podívám.
how do u suggest to incorporate blog routing that supersedes the cms config  routing?
looking at this code, i'm wondering if we need a @skip_to variable, basically if you've already decided to skip, then that should act as your next step, so we could just set @next_step, does that logic make sense?
навіщо це тут?
I cherry-picked and added this commit.
@fabpot btw, an interface would be needed to be able to mock it in tests
@bschussek is this example working ? self from closure looks weird to me and ``isKnownMaleName`` is not defined
It is a matter of consistency. While `headers->get` usage is generally a bit inconsistent, `Content-Type` appears to be the most commonly used notation, which makes sense, as it is how the HTTP RFC defines it.
no need to make it public
why removing the default value for ``$showPrivate`` ?
In RouteCollection and Route, or in configuration too ? (annotation, xml, yml). I think `hostnamePattern` in configuration makes it more obvious that you can put `{parameters}` in it.
version needs update.
debug log left in or intentional?
apparently we still need a - (BOOL)CPUser isEqualToUser:(CPUser *)user;
move it on same line as }

    } else if ...
Looks like it still works.
Can drop `return`s.
Thoughts on a module to extract common code?

```ruby
class UserPrivateMessenger
  include PrivateMessenger
end

module PrivateMessenger
  include Rails.application.routes.url_helpers

  PRIVATE_MESSAGES_PATH = 'app/private_messages'

  private

  def message_body(name)
    ERB.new(File.read("#{PRIVATE_MESSAGES_PATH}/#{name}.erb")).result.binding
  end
end
```
理由大致同上，可以通过 {\verb \somecommand} 来实现相同的效果
das deployment-script aendert nun automatisch die asset_version, die an jedes asset gehaengt wird. durch dieses "cache busting" wird also jeder cache beim user invalidiert und neue assets werden vom user-browser automatisch heruntergeladen.
I do have a more substantial change to doozerd, that supposedly allows it to bring in a new server days after the doozerd cluster is started. Erik gave me the patch - I've got a pull-request in to 4ad/doozerd, but he's sitting on it for the moment (he probably forgot about it).
Обязательно использовать джемы в которых уже есть данный функционал.
I think we should just use ActiveSupport's `assert_valid_keys`, then this won't be an issue.
Ah, duh that should have been obvious thanks
Ah, the "test" topic and queue are actually some leftover -- needs proper cleanup.
I only need "capedwarfQueue" -- for real, not for testing.
Again, Everett said this meant the screen reader read the contents to the user once the dialog was active.
(I'm not much help here, just the coder - Everett's the expert!)
Should this be "allMoves"?
This is part of BB so I would prefer not to modify anything. Anyway @jmcanterafonseca said some things have changed, I'will include those changes in the following pull requests.
while (this.container.firstChild) {
        this.container.removeChild(this.container.firstChild);
      }
'almost' same code code for two functions, sure we can have the logic to retrieve the iframe common
Please do NOT modify an existing string but create a new string instead. 
This will make localization team aware of a new string here. 
Let's use `your-rights   = Your Rights`.
Thanks!
The important changes are in here. The idea though is that views can "move" the calendar app to a specific position in time and the rest will be taken care of (loading of busytimes, caching, purging of cache) as long as the views are listening and responding to the correct set of events.
Since every alarm is created from a default alarm, you don't need the default value elsewhere. If you do you are wrong.
This works well for now though we may want a "custom" option or a "range" option in timeController (or here views can reference each other if needed) . Week view should eventually "snap" between 4 & 3 day chunks between the start & end of the weeks.
Add `background: none;` for avoiding extra "press" state!
First is OK. Not sure what does section header means.
Of course, the inline way it's here in the code is more likely to be optimized by a JIT since it can have a polymorphic inline cache that can quickly assert the shape is the same as it was last time and then just reuse the slot information.  In an init method, it doesn't matter, but it could matter more in other places with high enough throughput.  Also, messing with arguments and apply could potentially be slower too.  (Note: I was just quickly deleting github mails, not trying to give reviews to every place but calendar ;)
nit: indent/formatting
You can use `StatusBar.settingValues['ril.radio.disabled']` :)
line 108 worries me a bit:

        rootIssuer = jwcrypto.extractComponents(certs[0]).payload.iss;

is that `.iss` a raw field? Does there need to be a version-sensitive retrieval function for it?
during long running operations (#95)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

I see what you mean, just add write methods to the progress writer. Not
that clean but less classes I guess.

Sent from my Windows Phone
From: David Ebbo
Sent: 4/29/2012 5:03 AM
To: David Fowler
Subject: Re: [kudu] Write progress when there's 5 seconds of inactivity
during long running operations (#95)
>
>  namespace Kudu.Core.Infrastructure
>  {
> -    public class ProgressWriter : IDisposable
> +    internal class ProgressWriter : IDisposable

My initial feeling is that this seems unnecessarily over abstracted
with ProgressWriter/ConsoleWriter/IWriter. Do we really gain much over
it just being a ConsoleWriterWithProgress class?

---
Reply to this email directly or view it on GitHub:
https://github.com/projectkudu/kudu/pull/95/files#r748893
Change it back to GetApplication. Don't leak the Site into the main code, it just knows about an IApplication.
Ah got it. Need to read up on this!
please comment why you use `reopenClass`
Maybe `originState` should be called `lastStateBeforePublishing`? This would be more clear
It's generally considered best practice not to increment the version number when contributing a patch. This is because there could be other patches that might end up sharing this version number. Would you mind reverting this change?
Since this operation is done a lot, I think it might be worth optimizing:

v.view.zip(other.v).map { pair => pair._1 max pair._2 }.toArray

The ".view" says to not go ahead and make the intermediate output, but be lazy.  Nothing is actually done until the .toArray, which will then do the whole computation in one loop.  (views are useful in scala when performance counts).
Then we can bump it when we do the release. We have a special commit that bumps all the version numbers, so that's the right time to do this.
Should be "Waits for the application hosted on this machine, on the given port, to respond to HTTP requests".
We alternately use `translateFrom/To` and `outgoing/incoming`. Could we use just `outgoing/incoming` everywhere?
not sure what you mean by if ( and else if ( etc
`data` is what jquery calls it:

http://api.jquery.com/jQuery.ajax
> Data to be sent to the server.

> Leave it as `form`, which implies in its name that this is the 'data' that will be sent.

`form` implies an html form element; that's what i thought it was at first
What about extracting this to check_params method?
я бы это лучше хелпером сделала. Он же может быть нужен не только в этом контроллере
The `<a>` tag has no `src` attribute. Afaik.
Why does this need to exist?  Can we not just call exception_notification, which is already in place.  See https://github.com/smartinez87/exception_notification#background-notifications for details on triggering manual notifications with it.

And if this really does need to exist, it should really be using ActionMailer.
Happy to make that change, though it would be a PITA for me if there wasn't a "allow all" option - what would you suggest?

    {'poller': { 'allowed': ['pollername']}}

would only allow pollername to be poked, but

    {'poller': { 'allowed': True}}

for any? Or perhaps None? Or perhaps if the 'allowed' option isn't present then all pollers are allowed? In that case, would i pass an empty dict or True like in the current implementation?
You're right, that is clearer. Since you've already pulled it, if you make that change, I'll alter the code I have that depends on GITOSIS_KEY and change it to GITOSIS_CURRENT_USER.
Alright, changed, I just did that because of the other things that were
already there.
did you test it ? i'm suprised the `\n` works inside simple quotes
Let's add something like this so we can override settings without having to fork:
```
" Use local vimrc if available {
if filereadable(expand("~/.vimrc.local"))
  source ~/.vimrc.local
endif
" }
```
time == "1"
Ahh, that makes sense :)
var errHandler = next || options.errorHandler;
It would be, maybe test for support first and use it if it's there, then fallback to `encodeURI()` if not?
I will merge and make the following change:

```
>> Fixnum.ancestors
=> [Fixnum, Integer, Numeric, Comparable, Object, Kernel, BasicObject]
```

I think this should check: `if value.is_a?(Numeric)`
Yeah whoops.
1/ Why don't you use the default baseURI value defined in loader.js?
2/ It is really messy to mix Loader options and this packaging thing that is used for many various purpose.
For the sanity of this code, we should decouple them.
You can put all necessary data to create new loader instances in `@packaging`:
```
loader = module.Loader({
   baseURI: options.baseURI,
   prefixURI: options.prefixURI,
   main: options.main,
   version:  options.version,
   ...
   packaging: options,
});
```
or
```
options.defaultLoaderOptions = {
   baseURI: baseURI,
   prefixURI: prefixURI,
   main: { id: options.main, uri: ..},
   version:  options.metadata[options.name].version,
   ...,
  packaging: options
};
loader = module.Loader(options.defaultLoaderOptions);
// but this will require to delete circular references during JSON.stringify
```
I guess I should have read further, but I think it makes sense to have this description up above the example though.
I'll write more detailed documentation in loader.md
It isn't very clear to me. Can this `.` case be used for anything else than main module?
True, except that this is a `page`, and so it's templates are expected to render server-side, and are not included in the full Templates.js package. If it were, it would be more bytes for the dialog that are never used...
I'm responsible for finding the correct place to call this, that work still hasn't merged.

/whip whip
now we get an error from the database layer when a process that cannot write attempts to write 55925c66383e4435e290f5a3fcb780f65c7e7a90
We would only run it once, but it would run before build/run/test to ensure that we have cfx available. Not sure what you mean in the last part of this comment... do you want build to fail if tests fail?
Mind adding documentation for this section?
we have this implemented in https://github.com/mozilla/qmo-tests/blob/master/page.py#L19 
it's safer use the method from page.py
I thought you say to put it before the </footer> ? Only template footer got the footer tag.
that isn't true, unless actual and expected are catalogs; the description should reflect that.
why is http_con better than connection
Interesting changes, here, thanks! Have you tested this in IE6-8? I'm curious how you've worked around the issue of all un-supported media types/queries being converted into `@media UNKNOWN` when fetching the text in IE.
changing this logic isn't necessary. we only need to move the event def further down.
Ah yeah, got it in the travis file, but not there. One moment.
preferably `function dir(p) {`
Without probing for backslash you end up blindly replacing backslashes on posix system (which are allowed in file names).
Try this on linux:

````bash
echo foo > \\.txt
````

In an edge-case scenario you will break valid paths on *nix.
Since this has already been merged and done,  I've created #2404
нет у subscripton subscription_type, надо его в context ложить или еще как-то передавать сюда
Yah, it should match the indentation of the line below.
Ah, OK. I personally would find it confusing to be presented with such a mathematically wrong result (as my comment below shows), but if what you say about the popular designation is true (I wouldn’t know, I’m unfamiliar with netbook territory), then I agree. Disregard the following comment in that case.
Here and below:

```
case ($days <= self::ACTIVITY_LOW):
default:
    $activity = self::ACTIVITY_LOW;
    break;
why doing a loop over an hardcoded array with only 1 element ?
@albertosaurus  Ok. I'm adding it.

My initial though was if index already created it anyway raise an error. So, I hadn't throw any exception.
I think it's inappropriate to silently ignore index creation when index already have been created.
@gwoo - moved to below
@nateabele  - sorry, I went through coding standards and not sure what I'm doing wrong there.  I fixed the tab vs. 4-spaces issue (I think)
argparse was introduced in 2.7. why are you removing this?
Ok. Muistaakseni vielä kysyin tuota tehdessä tuleeko juttuja hardkoodata vai ei. Sanoit että hardkoodataan ne tiedot mitä spekseissä on hardkoodattu.
and the same is true for protected methods
"=" is not correctly indented to other ones.
guess that makes sense. the ORM seems to duplicate but i think extending is more elegant. its called MappedSuperclass btw, not SuperMappedclass :-)
You don't need an `InstanceMethods` module this can go directly into `VoteConnector` module
Missing comma after closing parenthesis (started running unit tests)
break long lines, 100-character columns should be the limit to aim for
comma at the tuple end is not required and style is never used elsewhere
"temporary job script"
you should use ``if (1 !== $user->length) { throw ... }`` to avoid a useless ``else``
Hmm, after fetching the user info the storage handler removes the data from the session (https://github.com/hwi/HWIOAuthBundle/blob/master/OAuth/OAuth1RequestTokenStorage/SessionStorage.php#L46). Is there a way to fix that? It's now impossible to call `getUserInformation` multiple times.
Regarding the "Principal", the idea was to show how to get the principal to use it in is in role, I'll change the variable scope to local variable in the new branch, also I'm going to remove the CDI support.
Actually there was method to my madness which I only just realised when re-running the unit test. I wanted devs to be able to pass in strings or Role/Resource objects and not have to worry about checking parameters for every method apart from when initially adding in the roles and resources so I'll leave as (string) if that's ok?
Should it be home_breadcrumb, just for easier reading?
Yes, I can see that but why are you doing that? Also nit:
```python
# Comments are like this.
#Not like this
```
Were you guys already using SHA256 hasher? I think playdoh by default does something else, so this may need to be different.
It doesn't have to be all or nothing. Code debt can be paid back incrementally as it's touched.
shouldn't popcorn be declared up around line #360?
Do you care that you're not deleting the global callback onYouTubePlayerAPIReady as well?
use `model.objects.filter(slug__iexact=slug).exists()` which'll prevent a potential object load.
Issue #70 has been raised to switch to using Clone Workspace SCM, however it is currently blocked by two issues in the plugin.
Still need to validate here that we uninstalled successfully doing tear down, so that we know the test was cleaned up successfully.
`remove(/(.*)/)` works here, but it's rather confusing and fragile (i.e. if the website decided to remove the newline between the date and the title in their HTML, this would delete the whole title). I guess it can be updated if things change.
Some magic substringing going on. TODO rewrite with regexp or split or something more robust?
timeout only makes sense if wait is set, maybe at comment saying that.
There were some others like that also, assuming same fix for all.
AKC, fixed
But then you end up with &lt;= which looks horrendous, because you miss the =
This will replace any existing Connector instance that was already registered with the same name. This seems dangerous, as we'll likely need to have lifecycle methods on Connector.

If we follow the `Sequencers` pattern, then the connectors can only be added via a configuration change, at which point we create a new ConnectorsManager instance. That's not ideal, as the connectors will have state and we'd like to keep as many of them around even when we're adding/removing connector instances.

So perhaps a better mechanism might be to add a connector with it's classname rather than the instance, and have this manager ensure the lifecycle methods are called.
This method suffers from many of the problems explained above. I think all of them can be safely addressed to reduce the complexity and help make this method more readable.
Just put a blank line for a new line (same everywhere else in this file - `<br />` is HTML, which you should not be using)
It's fine to use `.trim()` here instead.
yeah and others problems with PostgreSQL, unfortunately I won't be able to tackle them down in this sprint...
не надо выводить мусор.
You want to import both `pickle` and `json`, presumably
Should this be an enum?
should be seneca.fail( ..., cb )

no need for cb(err,null)
Well-spotted, I missed this one. Thanks
missing parens ;-)
I'm guessing this does side-effects. If that's the case, it should take a ``()``
This seem like a breaking API change in ``org.eclipse.jdt.internal.core`` bundle, implying that we won't be able to run the same plugin against Eclipse Indigo.

Since it looks like it may be the only breaking change, maybe we should have a conditional check on the Eclipse version. WDYT?
Shouldn't ``enclosingProject`` be a ``Option[IProject]``? Looking at the name that's what I'd expect...
Hm, I was following the docs for `SubMonitor`, and they suggest to never use an `IProgressMonitor` in new code, but instead convert it to a submonitor first. I guess I was lazy to rename everything from `pm` to something else. I'll rename it now.
Ok I'll remember ;)

/antoine

Le 24/10/2012 à 19.38, William Durand <notifications@github.com> a écrit :

In tests/Geocoder/Tests/Provider/OIORestProviderTest.php:

> @@ -56,9 +56,9 @@ public function testGetGeocodedDataWithAddress()
>          $provider->getGeocodedData('Tagensvej 47, 2200 København N');
>      }
>
> -    public function testGetGeocodedDataWithRealAddressWithSocketAdapter()
> +    public function testGetGeocodedDataWithRealAddressOne()

same thing here. 1 PR = 1 feature

—
Reply to this email directly or view it on
GitHub<https://github.com/willdurand/Geocoder/pull/112/files#r1931479>.
Will publish 1.5 tomorrow
Посмотри внимательно 1й, он же 0й элемент заполняется отдельно


Sun, 04 Nov 2012 11:27:54 -0800 от s1dney <notifications@github.com>:
>	
>
>
	
	
>
		
		
			
>
>In DNAProject/DNAProject/DNAProject/Cell+Mutator.m:
>> +#import "Cell+Mutator.h"
> +#include <stdlib.h>
> +
> +const int MIN_PERCENT = 1;
> +const int MAX_PERCENT = 100;
> +
> +@implementation Cell (Mutator)
> +
> +-(void) mutate:(int)x {
> +    int usedIndexes[ARRAY_COUNT];
> +    int count = ARRAY_COUNT*x*0.01;
> +    int index = 1;
> +    
> +    if(count>=MIN_PERCENT&&count<=MAX_PERCENT){
> +        usedIndexes[0] = arc4random() % ARRAY_COUNT;
> +        for (int i=1; i<count; i++) {
>
>вероятно, опечатка
>
если i = 1, а count (то есть %) 20, то цикл проработает только 19 раз вместо 20
>
должен быть 0
>
или в условии цикла i<=count
>
              —
>
              Reply to this email directly or view it on GitHub.
All of the above lines are shared with the zero case. Can you pull them out into a `beforeEach` block?
This block needs to be copied.
I take issue with this
Maybe would this deserve an exception of its own? Any idea? `DirtySomethingException`?

Sadly I'm not really as good at naming things as @dahlbyk and @carlosmn are. :-/
We had though about this, too. However, the slugified part is the part that is human-readable and it would easily become “lost” when being placed after the 64-character ID; for example people with smaller browser address bars wouldn’t see it anymore. Therefore we placed the long ID at the end.
untested :

--> 582         from nitme import TimeSeries
    583 
    584         if not self.preload:

ImportError: No module named nitme

GGGGRRRRR!!!!
and you modify tfr inplace here which can have some side effects
Sounds reasonable to me -- I was hoping @mluessi would say it would be easy to make it class-based an just implement it, but I too doubt that that's the case :)

@dengemann , are you going to be doing an all-to-all connectivity using labels (e.g., the aparc 2009 labels)? If so, that's something I had planned on implementing and using, but I'll hold off if you're going to do it. It would be nice to be able to add that type of functionality, basically taking in a set of label names (or instances) and compute all-to-all connectivity for them in different frequency ranges would be really cool -- and it's the sort of thing we can add pretty easily once this gets merged, if people thought it woulrd be useful.

Perhaps we should open an issue to discuss these types of future extensions / functions (and let this one be merged if @mluessi and @agramfort are also happy with it)?
you're testing something different here
in order to have them compatible with the plot..
and as get_sources is invoked which takes hits arg.
right?

2012/10/29 Alexandre Gramfort <notifications@github.com>

> In mne/artifacts/ica.py:
>
> > +        Returns
> > +        -------
> > +        fig : instance of pyplot.Figure
> > +        """
> > +
> > +        sources = self.get_sources_epochs(epochs)
> > +        fig = plot_ica_panel(sources[epoch_idx], start=start, stop=stop,
> > +                             n_components=n_components, source_idx=source_idx,
> > +                             ncol=ncol, nrow=nrow)
> > +        if show:
> > +            fig.show()
> > +
> > +        return fig
> > +
> > +    def find_sources_raw(self, raw, target, sources=None, score_func=None,
> > +                         start=None, stop=None, sort_func=stats.skew):
>
> why do you need to sort to score sources?
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/mne-tools/mne-python/pull/165/files#r1965988>.
>
>
yes, exactly!

On 04.12.2012, at 09:27, Alexandre Gramfort <notifications@github.com> wrote:

> In mne/viz.py:
> 
> >          if t in types:
> >              n_channel_types += 1
> >              channel_types.append(t)
> >  
> >      counter = 1
> >      times = 1e3 * evoked.times  # time in miliseconds
> > -    for t, scaling, name, ch_unit in zip(['eeg', 'grad', 'mag'],
> > -                           [1e6, 1e13, 1e15],
> > -                           ['EEG', 'Gradiometers', 'Magnetometers'],
> > -                           ['uV', 'fT/cm', 'fT']):
> > +    for t, scaling, name, ch_unit in zip(['eeg', 'grad', 'mag', 'misc'],
> > +                           [1e6, 1e13, 1e15, misc_scale],
> > +                           ['EEG', 'Gradiometers', 'Magnetometers', misc_name],
> > +                           ['uV', 'fT/cm', 'fT', misc_unit]):
> this tells me that we should have 2 news params that are units and scalings with
> 
> units = dict(eeg='uV', etc.), scalings=dict(eeg=1e6, etc.
> 
> so no special case for misc
> 
> and if a channel type is present and units is not None and not defined for this type of sensor raise an error
> 

and hence the user can plot what she wants, brilliant!

i'll continue with this later.

D

> —
> Reply to this email directly or view it on GitHub.
>
I tried in the service constructor first, but registering the listener failed (apparently Spring or Context did not have the admin service loaded yet). I suppose in the handler won't be a problem though.
Rebased @parndt .
You fixed `_concat` so if it gets a basestring, it converts it to a list. So you can reword this to:

```
:arg indexes: The indexes to update or ``'_all'`` to do all of them.
```
Because i need only rvm and calling a function named 'ruby-info' I expect every version of installer rubies, not just rvm if exists or rbenv if exists. If @sorin-ionescu fix this function I'll create a ruby-version plugin.
this should be `fr:`
I improved the docstring; it was quite needed since when there is more than one rule it works differently from the
sympy subs method.
This isn't the right fix, what if some databases quote table and column names differently?
Ты устанавливаешь style sheet на каждое движение мышки над виджетом? Да ты ебанулся.
Пробел лишний после =.
¿Este comentario se refiere al nombre de la variable?
Originally I had retained the (modified) clear-all-notifiations function, and the value was needed there as well.  I decided to keep this def because it seems very likely that there will be the desire to access the js notification array for other reasons in the future, so I wanted to encourage the use of the variable, rather than hard-coding the value in multiple places.
That'll work, too.
I am not in favor of using the exception code as a result code here. I would prefer multiple catch and return the good exit code depending on it.

Please update documentation to tell which codes can be returned
This line should read:
if (null !== $facet->getInclude()) {
I'm not sure if these changes are correct.  The Jaccard index is defined over sets of elements, but the changes are just comparing the indices non-negativity.

What exactly is the new function computing?
Hmm, I suppose if we remove the inheritance the exceptions would be "view / controller" agnostic in that they wouldn't be relying on something from webob. Sounds like a good idea.
Instead of having this be an argument, how about create another method to "create_volume_client" and one more called "create_compute_client" that called this one and potentially sent in the SERVICE_TYPE and SERVICE_NAME variables as well (so the volume and compute specific code would stay in those two respective methods).
We log out the ID above.
I think using ordinal() with a warning on the enum to not change the order of elements should be good enough
I think this can be a warning (and it should have a Log method as well).
Hmmmm, can we leave this out of commits (and whitespace changes)? It helps focus reviews
As above, why break out this block type?
or math.radians, since we know we are dealing with a scalar and don't need numpy's machinery.
@pelson: Any of the GUI backends should be able to save to any of the formats (the same doesn't hold true for non-GUI backends), so as per my other comment below, I think the `savefig.format` parameter should be unrestricted as to what it takes, and then let the backend decide whether it's valid at save time.
Should we set prerelease to None here?
Did you consider always returning an array so that all the success handlers that people will write don't have to deal with this?
@omgnull wth?
How is % escaped? 
What happens if a placeholder is not present in the context attribute (exception, ignored)? 
Are deep replacements supported now (e.g. %foo.bar%), which would kind of prevent a . in keys?
Why did you comment it out?
So what about these parameters k and q, do they make sense 
as design parameters to tune with model selection?
Either:
A GridFieldComponent sets and gets data...
or
GridFieldComponents set and get data...
Imho GitComandName and CollectArguments functions are well defined what they are supposed to do. I can't imagine why someone would implement them depend on they are protected or public. Hence I estimate maintenance cost to 0. Since estimated cost of installing them now is not greater that installing them in the future, I insist on publishing this functions.
this.assertEqual('function', typeof $('testdiv').down().onclick);
the same as above
What do you think about adding a version constraint to this boolean expression, so that we don't check for the bug on versions of WebKit that are new enough that we know they won't have the bug? (We'd probably use `getEngineVersion` for the purpose.) I remember you saying that the version wasn't always 100% accurate, but is there a version we could pick where we were certain (from testing) that everything newer doesn't have the bug?

It'd be nice if the more complex detection code didn't have to run for any latest-version browsers that are out there, because it would further limit the scope of the changes...

Just curious what you think. I'd be fine to leave it like this for now as well.
Can we maybe get something like:

   if (pingTimer) {
       AsyncTimerDeleteCallback(pingTimer,...
       pingTimer = 0
   }

The extra variable and the assignment in an if are ugly and potentially confusing
Yeah, crummy patch. I should fix it, just didn't have time yet.

-- 
C. R. Oldham
Executive Director, HopeKids Utah
cr@hopekids.org / cro@ncbt.org
801-564-4673


On Jun 1, 2012, at 6:07 PM, Lee Trout <reply@reply.github.com> wrote:

>> def _set_up_zebra_form(context):
>>     if not "zebra_form" in context:
>>         if "form" in context:
>>             context["zebra_form"] = context["form"]
>> +        elif "form" in context["wizard"]:
> 
> Shouldn't there be a check for wizard first?
> 
> `elif "wizard" in context and "form" in context["wizard"]`
> 
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/GoodCloud/django-zebra/pull/17/files#r918486
Is it possible to define the element type for the array of parameter ``$preferredEntities`` (using ``array<SomeType>``, or ``SomeType[]``)?
also,
s/and/an/ in the first comment :-)
Server muss gestartet sein. Am Besten immer gegen lokale Instanz mit bekannten Testdaten...
I just got some more time to play around with this and I see you're right.  I had gotten confused with strait websockets and WAMP.  I was using autobahn.js to communicate with WsServer (without wrapping the WampServer) .. hence the confusion.  It might be a good idea to make the distinction clear in the docs / examples.  I'm essentially new to web sockets and it took me a minute to figure out how WAMP fit into the stack.  Since this is an open source project I guess it's up to me to do it :)
maybe use an example of prefix with import here. This would eliminate the comment.
It would be better to have delegate hide the fact that there is a datastore inside.  Can you make this call self.delegate.start_batch() again, and just have that call to the inner data store?
I put it there because it was kind of linked to the UserBundle, but OK. In the main config file then ?
I think we agree on, that we have users with accounts or something like that (so unlink "account" should be good)
Anyway. It seems code is far from good. It is just adding and adding new elements, because timestamp changes even if there is no change. And even if there is a change, it happens that it does not change.
Like this? 
from . import horoscope, models
(But it is not necessary that it helps you here much.)
I see where you're coming from on this. What I had in mind was something 
like the dispatch functor. From the datasource's perspective it does 
just one thing, but from the database's perspective it can set in motion 
any number of actions. I'm anticipating that this (configure.js) will 
turn into a similar functor that passes requests to the router. (Other 
ways we could possibly use this is the linguist (unless, as we 
discussed, we update mongo directly from the datasource) or the entire 
admin interface, or the interface in which customer super-users can 
manage their own employees).

If we extend this functor to handle all of these, it will probably look 
very little like the current implementation (and, for all I know, be 
renamed). That guard clause I put in there was an inelegant way to put a 
flag down and basically note that "there's more work to be done here". I 
don't expect it to last long.

Steve


On 09/14/2012 01:38 PM, W. Cole Davis wrote:
>
> In lib/functors/configure.js:
>
> > +    handle: function (xtr, session, callback) {
> > +      var payload = xtr.get("data"),
> > +        payloadObject = JSON.parse(payload),
> > +        parameters = payloadObject.parameters,
> > +        id = session.get("details").id,
> > +        oldPassword = parameters.oldPassword,
> > +        newPassword = parameters.newPassword,
> > +        didChangePassword = function (err, result) {
> > +          if (err) {
> > +            xtr.error(err);
> > +          } else {
> > +            xtr.write({data: {message: "Password change successful!"}}).close();
> > +          }
> > +        };
> > +
> > +      if (payloadObject.functionName !== "updatePassword") {
>
> This is a little perplexing. The functor itself is intended to be an 
> RPC of sorts and you're acting on a call to one called "configure" but 
> you have a nested function as named by the client? Functors can handle 
> multiple things, so handles could be: "function/configure 
> function/update_password" or something like that. So, while what you 
> have here isn't "bad" it breaks the general convention. You could also 
> just create separate functors for each individual "function" you want 
> to run. There are definitely examples where I have tested which handle 
> was used, but this is checking nested data sent by the client and not 
> relying on the socket routing system explicitly.
>
> —
> Reply to this email directly or view it on GitHub 
> <https://github.com/xtuple/node-datasource/pull/40/files#r1609904>.
>
@dmethvin traditionally uses the new york times home page as a "real world example". True story.
Might, yes. Best to keep pull requests clean.
It seems like this would be better as:

```ruby
form[:test_mode] = 'TRUE' if options[:test_mode]
```

Simpler code, and it abstracts the caller away from how Viaklix happens to want the parameter passed.
enum need update :)
careful here: it should be the connection name, not the em name
I guess `item.name` isn't a boolean, so the function won't return a boolean value if `item.name` equals `''` (empty string). Using `!!item.name && GEOR.util.isUrl(item.value);` is probably more correct.
нет гарантии, что 4 байта придут одним куском
In fact I documented that, but anyway I'll just update to `{ resolve: onResolve, reject: onReject }` is was suggested.
Same again, `rejectedPromise` or just `rejected`.
this is the line I added
should we add a timeout clear here?
Yep. Tx.
setCookie() is only used by googiespell. Maybe we should change that anyways to save the current language as a user pref.
How is it different than OLS without a constant?
when I reviewed this I didn't read up on the statistics of it. I thought of doing that the next round of working at this.

In the example the "categorical" variables are floats rounded to a number of digits. It might be fragile if the floats are not rounded consistently, but there is nothing wrong with having real (as in real line) categories.

We might also just use KM as a nonparametric benchmark if we otherwise consider the exog as numerical metric variable.

However, for the documentation it might not be a good / typical example.
Any chance we can keep a `self.dist` and add `self.<dist_name>`? I specifically use `self.dist` a lot in the plotting methods and frankly, I'm not don't know if I could gracefully and dynamically account for varying distribution names.
追記してください
```javascript
/*jshint node: true, browser: true, indent: 2, laxcomma: true */
/* vim: set fenc=utf-8 ts=2 sts=2 sw=2 : */
"use strict";
```
The defaults for `$openvpn_user` and `$openvpn_group` are nobody:nobody; do we need this conditional? Is is reasonable that someone would supply a blank answer for the user/group?
HTTP headers are normally capitalized, but I dont think they are actually case sensitive. Consider capitalizing this. Just make sure Android and iOS are sending the same thing, and that the server can handle it.
Why are you building form fields yourself in the template. It should be done automatically from the form object.
In the "time" util file? I'm going to leave this for now. If someone wants to use it, we can make it more general.
This raises a question that is probably worth addressing now.  Normally, a mask image has 0 wherever the image is good, and some non-zero value for pixels with some kind of problem.  Should we switch to using this format?  I think it would be clearer for people who are used to using typical mask images.  Then I would remove this check, since any non-zero value would be valid as a masked pixel value.
I believe this should be "Included order ids"
Perhaps take the timeout as an argument, rather than hard-coding it here?
It could be good to also put variables in braces
je vais mettre strong amateurs oui. ils sont bcp moins forts que les pros
I think it's undesireable to have different behavior on different frameworks.. can we do something that doesn't involve a preprocessor directive?
無いとIDとして見てくれないっぽくてrouting errorになってしまうんですよね
Shouldn't this be a development dependency?
Não comparar strings Unicode com strings Utf-8
Deveria ser: 

```
self.assertTrue(u'Seu usuário e senha não conferem. Por favor, tente novamente.' in response.content.decode('utf-8'))
```
Oscar now supports i18n.  We need to wrap all text in the appropriate tags so it can be translated.  For simple text like this, use ``{% trans "..." %}`` tags.

See https://docs.djangoproject.com/en/dev/topics/i18n/translation/#internationalization-in-template-code
it should be within the folder that webinos starts and executes. This is why a copied it from webinos/test where we used to start the pzp.

https://github.com/webinos/Webinos-Platform/blob/master/webinos/common/manager/policy_manager/src/pm.cc#L29
totaler quatsch
That's what you would think, but memory balloons if either of these `&` are removed.
That is actually where is was until my last commit as it seemed conrollers/Applications.java became our catch all for  for controller methods. I will gladly make the switch back.
Could you quick change this to "~> 5.0.0". There are some potential big changes coming in the money gem and we should automatically pickup 6.0.0
attribs.select! {|k,v| RbTask.column_names.include?(k) }
Это лишние remove по всему коду.
Похоже что нет. То есть все таки нужно заменить на другую структуру?
no, we cannot. In java, those private properties are not exposed.
I think we can remove the comment about Tomcat from this readme, as it doesn't target Tomcat.
Did this file need to get committed?
The test case states that we should check that "page navigation displayed at the bottom of the list when there are more than 20 purchased apps". We don't have at the moment 20 app in out test account and the test passes, but when there will be more that 20 this assert will fail. We have to check that page navigation is displayed in the case where there are more than 20 apps. I suggest using an if here.
the assignment operator is not a mistake...
"Bio-formats metadata processing" ?
This, and other instances, should be verbatim text.
right, fixed :)
On Thu, Aug 09, 2012 at 03:13:21PM -0700, ibayer wrote:
>    The prototype is available here:
>    [1]https://gist.github.com/3188143
>    We agreed to take it as gold standard for now.

But we cannot base testing on a gist.

I understand Alex's comment as: give me a better ground truth than a hard
coded list of integers that, by looking at the code, I cannot figure
where they come from. Testing cannot be based on 'I reproduced the
results from this guy over there', because when it starts failing, the
question become 'was the original guy right, or wrong?'.
Eventhough it is a very local and minor variable, I'd love it if 'x' could be called something different (and more meaningful).
besides this line being too long +1 for merge (after the test) :)
Could you explain this a bit more? I would have thought the class prior is ``np.mean(y)`` and if I understand the code correctly,
``self.prior`` is what I would call the log-odds.
Do I misunderstand something or are we just using different words?
On Aug 9, 2012, at 23:31 , Alexandre Gramfort <notifications@github.com> wrote:

> In sklearn/metrics/euclidean_fast.pyx:
> 
> > @@ -0,0 +1,89 @@
> > +import numpy as np
> > +cimport numpy as np
> > +
> > +cimport cython
> > +
> > +from cpython cimport bool
> > +ctypedef np.int32_t INTEGER
> > +ctypedef np.float64_t DOUBLE
> > +
> > +cdef extern from "math.h":
> > +    double sqrt "sqrt"(double x)
> > +
> > +cdef extern from "cblas.h":
> > +    double gemm "cblas_dgemm"(char STORAGE, char TRANSA, char TRANSB, int M,
> 
> dgemm is not in the shipped cblas

Are you sure? I used the sklearn/src import path with pyximport and it worked!

> 
> we'll need @fabianp one more time for windows :)
> 
> —
> Reply to this email directly or view it on GitHub.
> 
> 

------------------
Vlad N.
http://vene.ro
You should add a link to the PDF: http://www1.icsi.berkeley.edu/~stellayu/publication/doc/2003kwayICCV.pdf
it's probably worth putting the 

    [auth]

prefix here since kiln.prefix is snagged off ui.ui().config('auth', ...)
VIctor,

I have updated and committed the code to the Measurement branch after
analysing the structure more carefully (in the absence of a published API)
and believe I have now restored the base code to original with only minor
modifications.

I have now:

   1. Externalised all strings
   2. Added a new 'planningLayer'
   3. Moved most of the changes to the MapActivity class into a separate
   MeasurementActivity class
   4. Added new functionality to provide creating/editing/saving/loading
   gpx files for manually created tracks. This is great for planning trips and
   provides a graphical gpx editor.

I find the intention and use of the 'GPX file...''' and "Favourites"
options in the "Define views" menu rather confusing. When a GPX file is
loaded using the 'GPX file...''', the points are loaded as favourite points
and which can only be displayed by turning on 'Favourites'. Turning on the
'GPX file''' actually clears the favourites loaded, hence if the user
returns without loading a new gpx file, the favourites originally loaded
are no longer available.
It is not clear whether the 'GPX file'' map menu option should be a check
button or just a button to open the file selection menu.

Is the intention that the gpx files only contain favourites? Are
favaourites and historical tracks considered to be the same thing?

I found the 'Define view' option title misleading and suggest that it be
changed to something like "Configure Layers".

Regards,

Car


0 AM, vshcherb <
reply@reply.github.com
> wrote:

> > @@ -56,6 +60,10 @@
> >       private Drawable boxLeg;
> >       private float scaleCoefficient = 1;
> >       private Rect textPadding;
> > +
> > +     private LatLon tempPoint;       //For measurement mode support
>
> Including the code is only first and simplest step. It should be clear in
> sense of future scalability and maintainability. Many efforts were put for
> simplication main activities but still they are very hard to maintain.
> http://code.google.com/p/osmand/issues/detail?id=872.
>
> About possibilities : you can create 2 layers with different priorities
> that's ok.
>
> Main message : if there are no tools to do it now we need to try to create
> that Public API. That is strong requirement for now in order to allow other
> developers create nice tools for Osmand and keep the code out (or partially
> integrated).
> So MapActivity, not the best place, ContextMenuLayer (not the best place
> to extend). New Layers - ok! If you have problem to add smth to context
> menu feel free to extend OsmandLayer interface and introduce some general
> code into ContextMenuLayer.
> FYI : every layer can propogate action into object context menu already
> and that's right decision.
>
>
>
> ---
> Reply to this email directly or view it on GitHub:
> https://github.com/osmandapp/Osmand/pull/158/files#r442330
>
Better to change to  "cannot cast from % to %s" since in many cases (eg on 64 bit) it isn't even an operation that makes sense
I agree with @9rnsr, though I can imagine a weird case in which `immutable T x = void;` makes sense. If the declaration appears at top level, x could actually be initialized in the `static this()` block. The semantics is that of a "write-once" variable that is initialized at the beginning but immutable for the run. Haven't thought about this much, but thought I'd mention it.
Why the second strip?  What will it do that wasn't done during the previous line's call of strip?
Lister les sous-définitions d'un document
Shouldn't be in the PR
I'm not sure it is worth using reflection here. You are already importing the types with

    import org.apache.tika.metadata.Metadata;
    import org.apache.tika.parser.AutoDetectParser;
    import org.apache.tika.parser.ParseContext;
    import org.apache.tika.parser.Parser;
    import org.apache.tika.sax.WriteOutContentHandler;

So I think that if someone is loading this class without having Tika, it's too late already. But this shouldn't be possible anyway: this class will be loaded only on demand via a ```@TikaBridge``` annotation right?
isn't stopping a boolean parameter to this function?