labofsahil/github-event-dataset-2012 huggingface dataset:
>>
Since there's nothing in the design of this class that forces the user to destroy the object as soon as possible, and since the lock is no longer necessary after dump finishes (since calling dump again will clear the string), there is no need to keep the lock longer than this function.
<<
why would it need to hold a pointer to a class instead of just calling a function to dump an expression.  I can't see any reason as it currently stands to expose the interface outside the .cpp file.
If you want to be able to dump multiple expressions in subsequent calls then the lock needs to be in the class
can be `type="int"` to save on line 44 being there :)  [error catches it as well I believe]
I'm not sure I will have time now.  But I'd like to talk about this, as I think there needs to be a cleaner way of doing this.

I may not have much time this week so if you're ok to just branch from this pull request and work from there that would be ideal :)
@brandonsavage I would prefer to not use Mozilla product names in the tests but have been leaving that up to people writing the tests.
Reword to:

Set flag indicating whether or not we should render trees of view models. If set to true, the View instance will not attempt to render children separately, but instead pass the root view model directly to the PhpRenderer. It is then up to the developer to render the children from within the view script.

or something similar.
Tässä ideana että API_PositionWidget toimii kahdella tavalla. 

API_PositionWidget(widget, API_POSITION_XXX)  kutsuu valmiiksi määrättyjä paikkoja
API_PositionWidget(widget, x, y) asettaa omiin koordinaatteihin
Function name should have a verb in it.
are tehse comments? if so can you remove them.
Yes, as delete functionality happens, the notes table gets refreshed and it takes some to refresh.
```js
w._gaq || (w._gaq = []);
```
ok, navbar component is also invertible (now it implements the interface too). i've changed the javadoc.
you could delete the method entirely as this is the default implementation provided by AbstractType
Because it not make sens to convert any object to string and then parse and convert back to object.
For example if somewhere in application someone use (or will want to use) this like that:

    setting.value = true 
    # or
    setting.value = {:key => :value} 
   # direct assign object to value 

so if You will use `to_s` You will do convert them twice. 
We just need do that only if we have string from form because there is no possibility to get object in other cases I think we should use standard object. There should be no string assign to that in code just ruby objects because it is much faster.
The Post::File methods when possible please.
dtype=np.bool_ (explicit keyword is clearer)
Please use `it "is valid"` instead of `should`.
Why do you remove the html5 bang?
After the previous `cst"`, the cursor will be on the opening double quote. The user will need to move the cursor to the word “Hello” to surround it with an EM tag (otherwise the “inner word” will be just the opening double quote).

Also, the double quotes have disappeared in the following examples. Did you intend to keep them in there, or do you want to add a `ds"` before doing the EM tag surround?
How about this:
* Private (_named) fields should never be accessed outside of the type they're in.
* However, a function named in the same way is understood to be internal, not private.  Use this sparingly.
* Actual private functions are not added to the prototype.
This may not be ideal, but I think it's a lot better than the current policy, where "_anything" means it's private, or internal, or public but I forgot to rename it. :)
I don't like to see "save state, change state, restore state."  Much of the renderer design makes this pattern unnecessary.

Conceptually, should we be changing the camera's frustum?  Would it be better for `FrameState` to have a `cullingFrustum` that is set from either the camera or the pick frustum?  Other ideas?
Should this be something more like `centerCameraOnObject`?  Describing what it does, not that it just so happens to be the default for right-click.
I suggest swapping the order so the common case when calling this function is clean.
反转Y轴的英文是Y Axis Inversed
I think maybe this is supposed to be disqus_id per L46
iOS text field only
I don't think this position is necessary?
Should probably comment that this is also used so a field can be removed from the document.  If you force a selection you will always have a value.
Setter público sem necessidade! :) Vale para todas as linhas com setter!
this is not exactly the case and i think we should formulate differently to not create wrong understanding: all those bundles provide documents and mappings for PHPCR-ODM but it would entirely be possible to use the bundles with something else like the ORM or mongo.
removed as well.
This won't buy you any. In D, unlike C++, you may consider objects are cheap to copy. You may want to merge the branches back.
This was code written in a haste, the actual implementation accounts for the case when bsr is not defined.
Ok, maybe `_doStat()` should be named `_tryDoStat()` instead. The only difference is that it doesn't throw if `stat()` fails. `_ensureStatDone()` is still there, for the cases where `stat()` must succeed for the caller to proceed. `_doStat()` (or `_tryDoStat()`) gives the caller a chance to use a less dramatic fallback procedure.
Maybe the flag `_didStat` should also be replaced with e.g. enum with values `didNot`, `triedButFailed` and `succeeded`. This way we'd avoid further calls to `stat()` in case a `DirEntry` was reused for something else after `_doStat()`.
We've used `$(D true)` elsewhere btw.
to clarify:

```d
immutable at = stack[stackLen - 3].length <= stack[stackLen - 1].length
    ? stackLen - 3
    : stackLen - 2;
```
Since we drop all the quotes, won't dropping two characters off the end break it?
This one leads to fatal error, since no _tinyMultipleMockMaker method exists. But you have another one that is without leading underscore
Okay, some github formatting messed that up it seems.. Can't be bothered to try and fix it from my phone, I'll pastebin something tomorrow if you haven't figured it out yet.
Make this one line :-)
Does that data accessor result in a record being moved between the deleted table and the live table? I seem to recall the CP doing that…
No, I mean small things like using maybe vs fromJust. I don't think it's worth the complexity to add sql sanitization
I can't imagine a test with this "not see a graph" step passing on the superuser dashboard - there are `svg` elements in the haml of the page that are rendered regardless. Maybe add an `id` to the step:

    Then /^I should not see a graph identified by "(.*?)"$/ do |graph_id|
Never do this, not even temporarily. :-) Swallowing exceptions leads to hard-to-debug errors. If an exception is thrown, unless you're specifically catching it on purpose, it's better to have that exception cause an ugly error, rather than a silent error that nobody realizes is there.

In this case the code shouldn't  throw an exception, unless the patient has not obs result, so you should handle that specific case with an if/then.
Auch hier negative Formulierung verwenden und bei zutreffen Fehler vermerken:

if($rating->getGrade != null){
  // ERROR: Bewertung bereits abgegeben
}

if( ! is_numeric($grade)){
  // ERROR: Bewertung ist nicht numerisch
}

$rating->setGrade($grade);
из темы говнота
This should be `{jQuery}` as `.html()` is used on line 1777
i don't have a problem with this, but i'm just wondering if now there are other non-div things with `class="exercise"` that i should be looking out for
Yes, missed a colon.
This `static assert` must never fail. It is here to prevent `destroy` from doing no-op because of a compiler bug or inform about incorrect implementation (just like you should always add `static assert` before any `memcpy`/`memmove` in a template to ensure no memory corruption will be done because of reasons listened above).
Why was this changeset deleted?
The inconsistency was with mongodb-template, we have MongoTemplate.

So, I have changed it; we now have mongodb-factory, mongo-template, mongo-converter.
Yeah and since its protected we can change that.
Will do in a minute
Decided to go with

    Assert.isInstanceOf(ExtendedSession.class, session, "mget failed - ");

to avoid string concatenation on every mget operation. Results in

java.lang.IllegalArgumentException: mget failed - Object of class [foo.MySession] must be an instance of interface org.springframework.integration.file.remote.session.ExtendedSession
OK, I'll check it, thanks ;)
It all goes now, at least for standard setups. If someone needs something different, then uncomment and change it.
`bin` should be an object, keyed by command name.
Note: There is not param id in the example below
Use single-quotes in code examples.
@apex13 Usually we only make the first letter upper case.
I'm thinking now: Could be better to use uuid.v1() instead a counter?

With the counter we can overflow it after too many registrations ...
That would create a bigger window where the user may try to submit again.
This simple change restore also the Plone 3.3 compatibility (this only if you also use collective.backportGS that I'm releasing today).
I know, its strange. It was like that before and working so I didn't want to change it, not yet at least.
I would rather see us come up with a well-defined way of injecting heira data so that it's safe for us to always clobber the hiera.yaml with our stadard version
Not really part of this review, but should we look at prefixing or separating the api extensions?
Do we really need the class name?
Again, we'll have one MessageNotificationHandler per message? This should just take Context. And the other method should take sender and message
Empty path, for DLL/SOs, I believe will look on lib dir, so the effect is the same if libdir is set.
How about checking if the component is enabled or  not as well at here? Then we can be able to disable a given area. ^_^
This block should do nothing, its being applied by the meta tags above.
мжно модифицировать end
end = it_next


тогда в этом случае у тебя отрезок будет заканчиваться в найденном not_less элементе,
а в случае aviable_distance > step, тогда end окажется первоначальным.

далее надо будет искать в отрезке от it до end
Also disables horizontal bounce.
Should not be documented/public, as it is only used internally and intended to be controlled entirely by `Ti.UI.backgroundColor`.
most of these are useless as they are the default. you only need the colors and the bootstrap
el tipo de contenido es News Article y no News Item
@nathanlon This is still a WIP, and @beberlei opened a ticket on Symfony to avoid having to add a way to retrieve the XML encoder but being able to pass some options to the encoder instead
There is another console.log further down in the try catch that needs to be dealt with, but instead of removing it lets do a logger.error?
Please make sure to make it a meaningful error as it will be shown to the user.
Also, please remember to localize the error message when you create it.
Yea, you're right; As far as i can tell it should be existsSync. Not sure why it was exists before. I shall change it.
Could we pull it into a separate commit then?
Old one always works ?