labofsahil/github-event-dataset-2012 huggingface dataset:
## Implementando o teste
The following exceptions are neither logged or re-thrown.
i would just put the unlock in  an ensure call?
Constant strings ...
But where should I set the success_url. I mean dispatch is called first, and its suitable to set all atributes there.
You can combine those two imports into one line.
Ok, i remove keyup event
`user_choices` -> better name.
I can't say for sure without knowing more about the code, but it might be possible to eliminate most of the 'ifs' by using a variation of the [Strategy Pattern](http://en.wikipedia.org/wiki/Strategy_pattern).

For example, we could have an internal abstract class, GraphicsProfileBehavior.  And then HidefProfileBehavior and ReachProfileBehavior implementations that actually do the work.  That way you create the right kind of behavior object when the user chooses the profile they want, and eliminate the need for if statements to be throughout the code.  All the differences would be isolated into the behavior of those two classes.
`#pikachu{}` / `tuple()` again. `any()` is probably too loose, maybe `atom()`?
Ok, I have added a comment

2012/9/3 Giuseppe Vallarelli <notifications@github.com>

> In eqcatalogue/datastores/spatialite.py:
>
> > @@ -289,15 +289,15 @@ def _load_extension(session):
> >      for library in [SO_LIBRARY, DLL_LIBRARY, DYLIB_LIBRARY]:
>
> Can you add a comment for this workaround? Thanks :-)
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/gem/oq-eqcatalogue-tool/pull/16/files#r1515009>.
>
>
LOG.warn("$class is deprecated, use $newclass");
Also, I am not convinced by name `resolution`.
Indent. or just move the forEach to the previous line.
Hard to see what the actual changes are here. Has 5 line more than before though :P
`tag_manager`
Doesn't it have `tooltip-container` by default, out of the template? A bit strange that one case adds a classname, the other one resets it. Is the container reused?
Alright. I wasn't sure about spacing when using the `||` to provide a fallback value.
Fixed.
Chris, I am not sure what is port QLineEdit. Where will I disable this?
These are just style changes. Do we actually have a style guide somewhere? Maybe we should. :-)
You have to use the anonymous function and enable EXTENDED_GLOB locally or this will fail.
Is there any reason to work explicitly with integers?
Please add some APIdocs here - and think about including a link to the documentation (e.g. https://developers.google.com/search-appliance/documentation/52/QuickStart/quick_start_se#dynamicresclust - maybe use the newest version, but you get the picture), as I'm not sure everyone knows what search "clusters" are. The term "cluster" usually refers to a load-balanced group of 2..n machines configured in the same way and serving the same purpose, not "group[ing] search results by topic".
This is disgusting. Where's your doctype?

`<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">`
No change to suggest here, I just wanted to say that I really like the new comments at the top of all the demo scripts.
Also, in terms of chronology, we want the galaxy shape to be first! :)
It's not pretty, but it's mainly to avoid refactoring when other people might be working on the same thing, and having a merge nightmare. This is something that needs a little team discussion.
Shouldn't need finally block. The AfterMethod should stop the app+rabbit?
ouai enfin elles produisent le contenu aussi avant de vendre des bouts de plastique.
Change this to final just for consistency. I think these can all be "static final".
:+1: on having optional arguments on `_.result`.
It's not None, according to call context
This file has a lot of `t('single key')` references. In order to avoid the chaos in the translations, every I18n key should be within a namespace. Instead of `t('sign_in')` it would be much better something like `t("devise.actions.sign_in")`.
As per @callahad's comment, we should use `onready` until the `onmatch` event is ready, which won't be for another month. We can file an issue once this is merged to record that that change needs to happen (and, of course, if @callahad could ping that issue once `onmatch` is live, life would be wonderful and full of joy :P). So this looks fine to me (except changing the classname as mentioned in the other comments).
The same is true in a few other model classes.
Rather than returning null, I've got a shorthand for returning an empty credentials object

    return useraccessConfirmed ? GetUserCredentials() : TwitterCredentials.Null;

[Source](https://github.com/shiftkey/BoxKite.Twitter/blob/master/src/BoxKite.Twitter/Models/TwitterCredentials.cs#L25)
My question was semi-rhetorical :wink:  The answer is indeed "yes."

The value of the option also ought to default to `ENV['MONGODB_URI']`.
I just thought that *eager* might be a bit unintuitive for non-natives in English. But that's just a suggestions.
Sorry to be a pain, but I would prefer this field to be ``is_discountable`` as that's more consistent with other field names in oscar.  I guess you'll need to recreate your migration to handle this too.
I personally like not having to type the quotes, but yeah if it changes in the future we can update the docs.  Nonetheless, this is fine for now because it *does* work with the quotes anyway.
We are still in the process discussing making a common UI library for Gaia apps.

Please remove this file, especially your own app does not use it at all.

(I don't find <script src="ui.js"> in your HTML)
only one way to find out :)  throw in a test and see what happens!
Actually, this test should get expanded. The All section shouldn't have anything in 30, 40 or 50 in it.
Could you please follow the 80 columns rules? It makes it easier to review the code.
fields must be public. Are you also working on User Languages?
http://guzzlephp.org/api/class-Guzzle.Http.Exception.ClientErrorResponseException.html
pathdesired.h is not required here.  It's already in "paths.h" to satisfy the API.
Вопрос в том, нужно ли вообще кешировать extensions в фабрике.
Nit: remove assert
Can you explain `ORDER BY FIND_IN_SET(id, ?) = 0`, please?
I'm not sure that anyone would be confused would they? Capital 'T' indicates that this is not a method on an instance, but on the Class i.e. it's static. And the verb 'new' gives a strong hint that this is creating something new.

OTOH Having Factory in there made it feel a bit like the verbosity of Java.
If you feel strongly or if someone else says they were confused then I can be persuaded, though.
these strings change pretty frequently. can we instead just check if `.success` appears on the page? I'd hate for this tests to randomly fail when any copy changes are made to Marketplace.
Not used, delete
They where converted after I submitted the pull request, which is why I haven't changed it in them here..  I have in fact changed the version numbering in my master branch to 1.6.1. I can merge my master branch with my pull request branch, but I did not want to make the review process hard then it was, by making changes at the same time.
@jni What do you think about renaming `ar` to `labels`? Otherwise, I'm happy to merge the PR.
Why do you use a multivariate normal and not just a standard normal if you have diagonal variance?
we use "-----------" rather than "========" for Parameters and Returns
I would just called this option `positive`.
Cheap remark: I'd prefer a tuple to a list here: ('lars', 'omp'): the tuple is much a less costly structure.
> And Numpy 1.3? It's in my Numpy 1.4.1, but I believe we should support
> 1.3...
>

It's Numpy 1.3...
Don't remember saying something like that (which doesn't mean I didn't).
It could be merged with the next line: `pred /= sum(self.boost_weights_)`.
I guess this is a side effect of automatic merges. There was not intention to make a change here. Perhaps put in a temporary change and backed it out, making some small formatting change.
True :D I mean:

```ruby
@independent_lines = options[:independent_lines]
```
Unless I missed something, fbody can't be null here.
This comment does not match the discussion about defaulting to Date. Also, remove the commented code.
All platforms lines you added have hardtabs, convert to spaces
The only specific thing is _valueModify function. For now it seems for me too heavy to refactor this things. It is the virtual function from TiObject. So cannot put it in TiPropertyMapObject.
qde editor couldn't find the qnx inclusions, and consequently auto-complite also didn't work.
these changes fixe mentioned issues
Consider using `[NSString stringByAppendingPathExtension:extension];` here.
This is in anticipation of a BottomDrawer. Top- and bottom drawers would both inherit from HorizontalMenuDrawer which contains the shared logic for these.

You could argue that onMeasure, onTouchEvent and onInterceptTouchEvent should be moved from MenuDrawer into a VerticalMenuDrawer as these methods contain code only needed for the left/right case.
Là j'utiliserais le champ "id" qu'on reçoit :
si  b.id == 0, c'est qu'on veut ajouter un nouveau bug : on b.save()
sinon, on veut modifier un bug, on b.update()  (modulo la verification de l'existence d'un bug avec cet id si on veut faire les choses proprement).
the == is no good here dude, you're in a SRC block, the == won't be interpreted
I'm not sure ```populateFields``` can throw an exception... ```uriparser``` and ```StringBuffer```, AFAIK, don't.
true, it should be:

    if (t && !link)
      remove
    else if (!t && link)
      add
It's nested enough that's it's a bit hard to read (very long lines are usually a red flag for that kind of thing)

I notice e.g. report['report_date'] is used more than once, perhaps you could do:

report_date = report['report_date']

If I am reading this correctly, you could eliminate the "else" completely by just doing e.g.

```
            formatted[report_date] = [0 * (days_out + 1)]
            formatted[report_date][days_out] += report['report_count']
```

TBH I haven't completely read and understood the data structure involved yet, I suspect there is a less clunky way to deal with it but I think we will have time to refactor that kind of thing later. Being "more like prod" is more important at this juncture :)
Could not find "Devart.Data.MySql.NHibernate.NHibernateMySqlConnection" and "Devart.Data.MySql.NHibernate.NHibernateMySqlCommand" classes in Devart.Data.MySql.dll 

Are you sure that this is not a mistake?
This is an interesting way of aliasing a method. I never thought about doing it like that before.
Comme dit par Thomas, l'Académie Française recommande de les mettre, et
c'est aussi ce que j'ai "toujours" entendu.
Après j'avoue ne pas le faire car les claviers sont pas faits pour, c'est
pas pratique.
Je pense qu'il faut juste être homogène, si on commence à le faire, il ne
faut en oublier aucune. Sinon, autant laisser comme c'est.

Greg
Le 2012 8 29 07:25, "Fabien Potencier" <notifications@github.com> a écrit :

> In book/controller.rst:
>
> > @@ -400,7 +400,7 @@ elle-même.
> >
> >  .. tip::
> >
> > -    Etendre la classe de base est *optionnel* dans Symfony; elle contient
> > +    Étendre la classe de base est *optionnel* dans Symfony; elle contient
>
> En français, contrairement à l'allemand, il n'y a pas d'accent sur les
> majuscules.
>
> —
> Reply to this email directly or view it on GitHub<https://github.com/symfony-fr/symfony-docs-fr/pull/130/files#r1482405>.
>
>
Tony - take a look at what I did here, with addJavascriptInterface: https://github.com/wikimedia/WiktionaryMobile/pull/32/files
It might be able to address this issue. You also need to make sure that this will fail gracefully on non-Android platforms.
We ABSOLUTELY need to keep this. Look at how the other third party libraries are used, and where their license files are referenced, and copy that.

Also, it wouldn't hurt to talk to yuvi to make sure this is okay.
use ``InputArgument::REQUIRED | InputArgument::IS_ARRAY`` for the argument, allowing to pass several usernames like ``php app/console knp-last-tweets:force-fetch knplabs knplabsru``. Then, ``$input->getArgument('usernames')`` will contain an array.

allowing to have an argument containing multiple value is a powerful feature (it works only for the last argument of your command obviously to avoid being ambiguous). Btw, the same exist for options (without the restriction as passing an option several times is not ambiguous as they are named)
Yeah, I agree.
I was just trying to decide what information would be useful. Anna didn't like the idea of having links in the popover, such as enquire or having the price displayed either.
Did you write a method which displays the artists inline as text?
I think I remember seeing that written somewhere?
It should be using the distributed cache as it is (at least that's the way it is used in the Pig tutorial). I ran it in cluster mode with a local Hadoop installation and it worked there.
I think fitting the sfs in memory in a HashSet is not a problem, it just gets ugly if you put them in a Trie. I think I had all English surface forms in a HashSet in about 1GB for the LREC paper.
Please do not review this class
`{{! This is a comment }}`
Then it won't show up in the actual output
@yuhunglin do we need to .grep here? Doesn't `.each` suffice?
it's to differentiate between list and string, so no
I think we can actually remove the entire concept of a logBuffer to simplify this function greatly.
It still sorts if the index is unknown, for example the original 5 value produces different results as seen below:



-1:
[+] Group Policy Credential Info
============================

 Name               Value
 ----               -----
 TYPE               DataSources.xml
 USERNAME           blhalh
 PASSWORD           password
 DOMAIN CONTROLLER  SYSVOL
 DOMAIN             MSFLAB.net
 CHANGED            2012-07-02 07:28:35
 DATASOURCE         blah
 DRIVER             SQL Server
 ATTRIBUTE          ip - 192.168.1.1
 ATTRIBUTE          something - good

5:

[+] Group Policy Credential Info
============================

 Name               Value
 ----               -----
 TYPE               DataSources.xml
 USERNAME           blhalh
 PASSWORD           password
 DATASOURCE         blah
 DOMAIN CONTROLLER  SYSVOL
 ATTRIBUTE          ip - 192.168.1.1
 DOMAIN             MSFLAB.net
 DRIVER             SQL Server
 CHANGED            2012-07-02 07:28:35
 ATTRIBUTE          something - good
The Versio field isn't needed anymore (svn related)
Actually anybody can make changes to this cookbook and namespace.
wrong indentation (tabs detected)
Also, it'd be nice to mention some common use cases (face detection?) and add reference(s) (maybe one technical reference and one simpler one, e.g. Wikipedia, although that page is a bit vague).
Just a head up, this line will not work should you have un-commited items in your repo however the script will carry on and remove everything from your current repo and commit the static page into it.....
`.reject(&:empty?)`
The label shouldn't get a class. There should instead be a class on the `<li>` called `done`, when it's checked.
Soooo...we really want to encapsulate this somehow. Right now we're using Google Maps but we have an issue to abstract out the mapping provider. This is safe to merge but we'll want to include this in that refactoring.
Wow, that went on way longer than I intended ;)
This copy should also be done in `setPositions`, right?

We should probably make a generic function for copying `Cartesian3` arrays.  @shunter where would that go?  Just a function in `Core`?  A static function on `Cartesian3`?  I suppose we want to avoid a fully generic JavaScript deep copy array function because it would not perform as well as something custom.
A good question.
This is down in Core so we should avoid the term "vertices" right?

Sadly, the fancy and fast abstraction you speak of probably does not exist.  You can get close in C++ using templates, but that's just because it duplicates the code for you behind the scenes.
I think you can simplify this as:
`var center = Cartesian3.add(northEast, southWest, viewExtent3DCenter);`
`Cartesian3.multiplyByScalar(center, 0.5, center);`
@bagnell these tests look pretty good overall.  I noticed that coverage for Scene.js is low because we do not test `Scene.pick` and friends, `getPickPerspectiveCullingVolume` and `getPickOrthographicCullingVolume` (well that is 2D).  Perhaps we should change the picking tests to use `Scene.pick` or add new tests.  Let's discuss, and do it as a separate pull request.
Same comment for `CommandLists.js`.
Too many tabs below?  Perhaps run this file through the eclipse formatter.
We really need to start getting rid of `DOC_TBA` and commenting things properly.  If this is supposed to be the last major camera refactor that creates the architecture we stay with going forward, now would be a good time to do it.
囧……怎么音量设定没和音效在一起反而和反转Y轴在一起了……
The property name is "checked". getChecked() or isChecked() work the same with the annotation "Kroll.getProperty".
This function is only used once and could just be passed directly into processArguments() below.

Should you choose to leave it here, then it would be better to use the "function postProcessArgs() {}" convention so that stack traces report the function name instead of anonymous.
The problem is that this is in a discussion of layouts, and for the most part, the layout types don't affect the sizing logic, only the positioning. (Except in horizontal layout on Mobile Web, I guess).
у меня  PyCharm там тоже есть авто генерация на пои /** Enter но он както криво работет
Can you use a heredoc here?
I think generally an input function name might need validation, even if Puppet::Parser::Functions.function() does the right thing anyway ... however I'm wary of replicating validation for function names here, unless Puppet exports the regexp for it in some nice way.
зачем ты делаешь по файлу на класс?
I think it should go before <%= yield :javascript_libraries %>
Jut so you know, all of these extra attributes shouldn't be necessary at all. These functions are templated, and the attributes are inferred.
also -- I would change it to not have `{{ curlies }}`.  Similar to how `data-action`, `data-value` and `data-bind` work. Similar to AngualrJS, we don't have curlies on special properties we handle (only for normal HTML properties)
Ну да, это правильно, но кучу устаревшего лучше тоже в библиотеке не таскать. Название VK_IFRAME_APP_ID лучше VK_APP_ID, его лучше всегда и использовать. Старое будет работать, и сообщение вполен понятное ('use' на 'rename' заменить только). Чтоб у пользователей меньше проблем было в дальнейшем, лучше ведь VK_IFRAME_APP_ID использовать - так лучше к этому и стимулировать их сразу.

Хитрая настройка, в которой имя настройки лежит - немного overkill :) Да и от коллизий с VK_IFRAME_APP_ID_SETTING из другого приложения она не предотвратит. Ну и описывать ее в документации "заведите настройку, в которой будет имя другой настройки" сложновато.
I'm not sure this is a good idea for handling these Exceptions
To separate it from the checkbox by 1 space.
To corrigindo agora. Também não tive como fazer Domingo e Hoje, trabalhei
domingo e somente sai às 07h de Hoje(Central de Transplante - Trauma JP).
Vou virar a noite fazendo e fazer novo push.

Em 17 de abril de 2012 22:49, Sérgio Campos <sergio.campos@dce.ufpb.br>escreveu:

> Professor, não entendi! Era pra corrigir os testes??????????????
>
>
> Em 16 de abril de 2012 17:42, rodrigovilar <
> reply@reply.github.com
> > escreveu:
>
> > +
>> > +import grails.test.mixin.*
>> > +import grails.test.mixin.support.*
>> > +import org.junit.*
>> > +
>> > +
>> > +@TestFor(Periodo)
>> > +@Mock(Curso)
>> > +
>> > +class PeriodoTests {
>> > +
>> > +    void testValidacaoPeriodo() {
>> > +             Periodo numeroInvalido = new Periodo()
>> > +             assert !numeroInvalido.validate()
>> > +
>> > +             Periodo periodoSemCurso = new Periodo()
>>
>> Então, você deveria ter corrigido o código e não afrouxado o teste.
>>
>> ---
>> Reply to this email directly or view it on GitHub:
>> https://github.com/rodrigovilar/AlocadorHorarios/pull/32/files#r691269
>>
>
>
>
> --
> []´s
> Sérgio Campos
> Graduando Sistemas de Informação - UFPB_LN
>
>


-- 
[]´s
Sérgio Campos
Graduando Sistemas de Informação - UFPB_LN
You are completely right. I'll update the PR accordingly :-)
The lines to start the slave were moved into the "if type flock" block to support xtrabackup for issue jayjanssen/Percona-Pacemaker-Resource-Agents#3 

See https://github.com/y-trudeau/resource-agents-prm/blob/master/heartbeat/mysql#L586-L600

The start slave that is in your pull request looks like it was from a merge conflict that was resolved incorrectly. The start slave line should not be there and instead is already in the block I mentioned earlier.
can you add a note that n_jobs > 1 will require more memory?
I think you can change these to `NSUInteger`s since you're not using any atomic functions that would require a particular type. (I probably can too, the builtins should be polymorphic)
Ok thanks - new to this :)
У всех этих классифкаторов должно быть текстовое описание `title`. Можно пустое
I overlooked this remark. Now, complete.
P.S. But generally, a lot of returns randomly distributed within the function looks for me like archaic "goto exit_point". So, I am trying to structure them like here.
Ich habe den ServiceBase korrigiert... Ab sofort kannst du auch $this->persist und $this->remove verwenden....
Aber das kannst du ja bei gelegenheit korrigieren.... eilt nicht!
I opted for add_names for parity with the SuiteImporter.
Should be `===`
Shouldn't we be checking whether this was successful?

`if(success ...)`
When doing a for (var i in ...) we should either check with hasOwnProperty or use jQuery each instead.
I thought we agreed that we don't really need an extra attribute and can manage all that with an empty string for 'temporaryFileSuffix'. I understand why you have this new attribute, but we can always do rename in the try/catch block.
My biggest concern especially after this morning's call is that this requirement came from dealing with FTP server that is not a real FTP server (not really spec compliant), yet we are introducing mutually exclusive attribute that i  am very reluctant to do especially in the point release.
wdyt @garyrussell ?
Again; I think we'll have problems if two threads are in here at the same time; it should work OK, but we'll end up with two queues; the first of which will only be used once, and then hang out there until the connection is closed.
I think this method also have to be reviewed and refactored.
AtomicReferences & getting  "CREATED_DATE" for each message
since the whole file doesn't have header doc, I would leave it for now when we have more resources to do it in a systematic and consistent fashion.
`s.from` probably? not `settings.from`?
What do you mean "like a method on the dealer"? Do you mean creating a method within the Game class that handles getting cards from the deck for the dealer? Hardest thing about all these exercises is trying to figure out which way you'd like us to go in answering them! With that said, I know it's for the better!
No the URL?
For me is Ok, but we should return to the node the URL since is what he knows about the app ...
NotImplementedException means there should be an implementation, but you haven't gotten around to writing it yet.  You should throw NotSupportedException if it's something that is intentionally not supported, or perhaps ArgumentException to indicate that the element passed in does not meet the preconditions of the method.
Can we detect the namespace instead of forcing the user to specify it?
A tout les coups c'est ça.
lName should be the rest of the string (not the second token)
okay, I'll do
this is about registering filters, not entities
What about CommunityUtil?
Hmm, we are doing the exact same code in 6 tests. Wonder if it would make sense to throw it into some sort of function.
що за опція?
sample usage is not a test. See comments in semanticweb project.
Well, I might just fix it, but I'm not sure I will finish this tonight. :)
Should specifically state that the image loader is intended to be a singleton class. We should also subhead the `sharedLoader` task as "Getting the Application Instance". See the `UIApplication` documentation for an example of how Apple documents singleton APIs.
Format is messed up--should only have one properties: tag
I think we should stick with a hard-wired socket for the TelnetServer - it's a main so it won't run as a test in the build. Having to dig around to find out which socket to telnet into increases the price of admition.

How about a simple constant that is set in the environment. They can change the constant if they have a conflict.
The ``default_queue`` configuration must represent the queue name, and the extension must create a backend with the direct exchange. So the ``AMPQDispatcher`` will not raise any error anymore.
Если в треде нет постов, кроме оппоста, то `$t('table', node)` даст `null`, `aib.xTable` станет равным `false`, а значит скрипт будет считать, что посты в треде соответствуют xpath'у `'.//div[contains(@class,"' + obj.pClass + '")]'`. Это полностью сломает подгрузку постов в Хроме/Опере и частично в лисе (обёртка `table` просто не будет определяться и подгруженные посты будут "слипаться" между собой).
@pagey Is this reasonable here. I was getting errors without the spy statement.
Why don't we lint our functional tests?
so you have this concept of multiple webviews in lib/policy/webkitOriginAccess.js

but when you are responding to NetworkResourceRequested you hardcode the _webview?
this is bizarre or I am missing something
What's your suggestion? should the last line be changed to do m_foldersMap.find(key) then use the iterator to get the found folder?
Can you do some quick tests and see what 2 slashes does? Its my understanding that 2 slashes is valid, but will not always start at the root of the bar.
Is *that* what those letters mean!